Some cleaning in huggingface_hub integration

#13
by Wauplin HF staff - opened

Nothing critical (just some cleaning):

  • use api everywhere to avoid passing token in create_repo + whoami
  • whoami is not needed. Repo_id is inferred when creating the repo.
  • repo_type="model" is not needed
  • MODEL_NAME is not a constant => rename to model_name

repo_type="model" is not needed

good to be explicit though no?

Agree with all other points

Up to you 🤷 I personally do it the implicit way for models but both are fine

ggml.ai org

Thanks! I'm going to YOLO merge this!

reach-vb changed pull request status to merged

Sign up or log in to comment