Refactor position eligibility checks in exposure_spread.py to use explicit conditionals for each position, improving clarity and maintainability of the code.

global_func/exposure_spread.py

@@ -10,10 +10,16 @@ import math
 #### makes sure to check if the player is eligible for the position before replacing them
 
 def check_nba_position_eligibility(column_name, player_positions):
-    if any(pos in column_name for pos in ['PG', 'SG', 'SF', 'PF', 'C']):
-        # Extract the base position from the column name
-        base_position = next(pos for pos in ['PG', 'SG', 'SF', 'PF', 'C'] if pos in column_name)
-        return base_position in player_positions
+    if 'PG' in column_name:
+        return 'PG' in player_positions
+    elif 'SG' in column_name:
+        return 'SG' in player_positions
+    elif 'SF' in column_name:
+        return 'SF' in player_positions
+    elif 'PF' in column_name:
+        return 'PF' in player_positions
+    elif 'C' in column_name:
+        return 'C' in player_positions
     elif 'G' in column_name:
         return any(pos in ['PG', 'SG'] for pos in player_positions)
     elif 'F' in column_name:
@@ -23,10 +29,18 @@ def check_nba_position_eligibility(column_name, player_positions):
     return False
 
 def check_lol_position_eligibility(column_name, player_positions):
-    if any(pos in column_name for pos in ['TOP', 'JNG', 'MID', 'ADC', 'SUP', 'Team']):
-        # Extract the base position from the column name
-        base_position = next(pos for pos in ['TOP', 'JNG', 'MID', 'ADC', 'SUP', 'Team'] if pos in column_name)
-        return base_position in player_positions
+    if 'TOP' in column_name:
+        return 'TOP' in player_positions
+    elif 'JNG' in column_name:
+        return 'JNG' in player_positions
+    elif 'MID' in column_name:
+        return 'MID' in player_positions
+    elif 'ADC' in column_name:
+        return 'ADC' in player_positions
+    elif 'SUP' in column_name:
+        return 'SUP' in player_positions
+    elif 'Team' in column_name:
+        return 'Team' in player_positions
     elif 'CPT' in column_name:
         return any(pos in ['TOP', 'JNG', 'MID', 'ADC', 'SUP'] for pos in player_positions)
     return False
@@ -49,8 +63,16 @@ def check_mlb_position_eligibility(column_name, player_positions):
     return False
 
 def check_nfl_position_eligibility(column_name, player_positions):
-    if any(pos in column_name for pos in ['QB', 'RB', 'WR', 'TE', 'DST']):
-        return any(pos in ['QB', 'RB', 'WR', 'TE', 'DST'] for pos in player_positions)
+    if 'QB' in column_name:
+        return 'QB' in player_positions
+    elif 'RB' in column_name:
+        return 'RB' in player_positions
+    elif 'WR' in column_name:
+        return 'WR' in player_positions
+    elif 'TE' in column_name:
+        return 'TE' in player_positions
+    elif 'DST' in column_name:
+        return 'DST' in player_positions
     elif 'FLEX' in column_name:
         return any(pos in ['RB', 'WR', 'TE'] for pos in player_positions)
     elif 'UTIL' in column_name:
@@ -78,8 +100,12 @@ def check_nascar_position_eligibility(column_name, player_positions):
     return True
 
 def check_cfb_position_eligibility(column_name, player_positions):
-    if any(pos in column_name for pos in ['QB', 'RB', 'WR']):
-        return any(pos in ['QB', 'RB', 'WR'] for pos in player_positions)
+    if 'QB' in column_name:
+        return 'QB' in player_positions
+    elif 'RB' in column_name:
+        return 'RB' in player_positions
+    elif 'WR' in column_name:
+        return 'WR' in player_positions
     elif 'FLEX' in column_name:
         return any(pos in ['RB', 'WR'] for pos in player_positions)
     elif 'SUPERFLEX' in column_name:
@@ -87,8 +113,14 @@ def check_cfb_position_eligibility(column_name, player_positions):
     return False
 
 def check_nhl_position_eligibility(column_name, player_positions):
-    if any(pos in column_name for pos in ['C', 'W', 'D', 'G']):
-        return any(pos in ['C', 'W', 'D', 'G'] for pos in player_positions)
+    if 'C' in column_name:
+        return 'C' in player_positions
+    elif 'W' in column_name:
+        return 'W' in player_positions
+    elif 'D' in column_name:
+        return 'D' in player_positions
+    elif 'G' in column_name:
+        return 'G' in player_positions
     elif 'FLEX' in column_name:
         return True  # UTIL can be any position
     elif 'UTIL' in column_name: