Refactor allocation calculation in FinancialTools: simplified logic for determining final total value based on investment type, ensuring accurate handling of both percentage-based and share-based portfolios.

agents/tools.py

@@ -640,9 +640,7 @@ class FinancialTools:
                             if shares is not None:
                                 # Shares-based calculation
                                 value = current_price * shares
-                                allocation_percentage = (
-                                    percentage if percentage > 0 else 0
-                                )
+                                allocation_percentage = percentage
                             else:
                                 # Percentage-based calculation
                                 value = total_investment * (percentage / 100)
@@ -674,11 +672,12 @@ class FinancialTools:
                                 }
                             )
 
-                # Use calculated total if we have percentage-based portfolio
+                # For percentage-based portfolios, use the original total investment
+                # For share-based portfolios, use calculated value
                 final_total_value = (
-                    total_calculated_value
-                    if any(h.get("percentage", 0) > 0 for h in holdings_info)
-                    else total_investment
+                    total_investment 
+                    if total_investment > 0 and any(h.get("percentage", 0) > 0 for h in holdings_info)
+                    else total_calculated_value
                 )
 
                 # Analysis and recommendations