Refine portfolio data extraction in financial agent: Enhance JSON response to include total investment field, improve markdown handling, and validate JSON structure for better accuracy. Update error messages in tools.py to include debug information for input received.

agents/financial_agent.py

@@ -193,7 +193,7 @@ Return only valid JSON, nothing else."""
 
             try:
                 response = self.llm.invoke([
-                    SystemMessage(content="You are a portfolio data extraction assistant. Return only valid JSON with holdings array."),
+                    SystemMessage(content="You are a portfolio data extraction assistant. Return only valid JSON with holdings array and total_investment field."),
                     HumanMessage(content=extraction_prompt)
                 ])
                 
@@ -201,12 +201,20 @@ Return only valid JSON, nothing else."""
                 extracted_data = response.content.strip()
                 # Remove any markdown formatting
                 if extracted_data.startswith("```"):
-                    extracted_data = extracted_data.split("\n")[1:-1]
-                    extracted_data = "\n".join(extracted_data)
+                    lines = extracted_data.split("\n")
+                    # Find the start and end of JSON content
+                    start_idx = 1 if lines[0].startswith("```") else 0
+                    end_idx = -1 if lines[-1].startswith("```") or lines[-1] == "```" else len(lines)
+                    extracted_data = "\n".join(lines[start_idx:end_idx])
                 
                 # Validate JSON
-                json.loads(extracted_data)
-                return extracted_data
+                parsed_json = json.loads(extracted_data)
+                # Ensure it has the required structure
+                if isinstance(parsed_json, dict) and "holdings" in parsed_json:
+                    return extracted_data
+                else:
+                    # If structure is wrong, fall back to regex
+                    pass
                 
             except Exception:
                 pass

agents/tools.py

@@ -632,7 +632,8 @@ class FinancialTools:
                 
                 # If no valid holdings found, return early to avoid using this tool
                 if not holdings_info:
-                    return "Portfolio analyzer requires specific holdings with percentages or shares. Please provide portfolio details like 'AAPL 40%, MSFT 30%' or JSON format."
+                    # Debug: show what we received
+                    return f"Portfolio analyzer debug - received input: {input_str[:200]}... No holdings found. Please provide portfolio details like 'AAPL 40%, MSFT 30%' or JSON format."
 
                 portfolio_data = []
                 total_calculated_value = 0