events
list | data_with_bots
list | data_without_bots
list |
|---|---|---|
[
{
"action": "opened",
"author": "et1975",
"comment_id": null,
"datetime": 1448028373000,
"text": "Serving reactor files via mounted GitFS root exposes the backend logic to minions.\r\nIt seems though that reactors being exposed via the roots is not a _requirement_ for them to function and therefore IMHO is an oversight and a security risk. \r\nWhile there are workarounds and ways to hide sensitive information, it is not enough IMHO. Knowing what backend is doing can be of value by itself to an attacker.\r\nWould be great to see GitFS configuration for reactors getting the same treatment as the one for pillars - separate, bypassing the root mounts, and being able to include the reactor.conf itself.",
"title": "GitFS for Reactors",
"type": "issue"
},
{
"action": "created",
"author": "basepi",
"comment_id": 159125755,
"datetime": 1448329655000,
"text": "You make great points here, and I think this is a great idea. Thanks for the request.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mew1033",
"comment_id": 183488710,
"datetime": 1455311297000,
"text": "This is definitely something I want. Reactors should be store-able in gitfs without exposing them to minions.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Da-Juan",
"comment_id": 234481253,
"datetime": 1469175011000,
"text": "I'm interested in this too!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "spyd3r",
"comment_id": 237391178,
"datetime": 1470262283000,
"text": "I'm interested in this feature as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "c4t3l",
"comment_id": 249889371,
"datetime": 1474988091000,
"text": "+1 internets for this idea!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "thatch45",
"comment_id": 249902902,
"datetime": 1474990566000,
"text": "I have added the nitrogen tag here, we would also want to be able to do this with thorium files as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gtmanfred",
"comment_id": 345473398,
"datetime": 1511041302000,
"text": "You can put your reactor files in your regular gitfs fileserver, and just reference it using `salt://reactor/whatever.sls`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "et1975",
"comment_id": 345690804,
"datetime": 1511183393000,
"text": "I'm confused, in the context of the problem (\"hide reactor logic from the minions\") what would that accomplish?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gtmanfred",
"comment_id": 345741403,
"datetime": 1511193877000,
"text": "ahh, i missed that part of the feature request, nevermind.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "et1975",
"comment_id": 473351337,
"datetime": 1552666937000,
"text": "this issue is closed prematurely.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Thank you for updating this issue. It is no longer marked as stale.",
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *et1975*:",
"text": "this issue is closed prematurely."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *et1975*:",
"text": "this issue is closed prematurely."
}
}
] |
[
{
"action": "opened",
"author": "vasile-ghete",
"comment_id": null,
"datetime": 1422529754000,
"text": "The PR contains only the XML file for L1Menu_Collisions2015_50ns_v0 menu, so it can be merged w/o HLT changes, Changes to use it must be included in another PR.",
"title": "Add XML file for L1Menu_Collisions2015_50ns_v0 menu",
"type": "issue"
},
{
"action": "created",
"author": "degano",
"comment_id": 72034642,
"datetime": 1422542295000,
"text": "@cmsbuild please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mulhearn",
"comment_id": 72582231,
"datetime": 1422931164000,
"text": "+1",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *degano*:",
"text": "@cmsbuild please test"
}
},
{
"bot": "This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *mulhearn*:",
"text": "+1"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *degano*:",
"text": "@cmsbuild please test"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *mulhearn*:",
"text": "+1"
}
}
] |
[
{
"action": "opened",
"author": "epilande",
"comment_id": null,
"datetime": 1468242023000,
"text": "This will allow components to transition in & out.\r\n\r\n",
"title": "Proposing Animate component",
"type": "issue"
},
{
"action": "created",
"author": "primozs",
"comment_id": 231774592,
"datetime": 1468251820000,
"text": "Looks great!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "epilande",
"comment_id": 234521435,
"datetime": 1469187166000,
"text": "Added animation example triggered by scrolling. See grommet/grommet-docs#59\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ericsoderberghp",
"comment_id": 236196769,
"datetime": 1469802849000,
"text": "Sorry it took so long for me to get to this one. Just a few comments.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/7118153)\n\nCoverage decreased (-0.7%) to 8.449% when pulling **6477244f96e0e75db844ab7a11aabcaf42e5f50f on epilande:animate** into **7f994dce9c5ed27c71036d8111fea29611077412 on grommet:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *primozs*:",
"text": "Looks great!"
}
},
{
"bot": "[](https://coveralls.io/builds/7250209)\n\nCoverage decreased (-1.03%) to 8.121% when pulling **15024d9b5232f1a150322f8a292adfedafbde57e on epilande:animate** into **7f994dce9c5ed27c71036d8111fea29611077412 on grommet:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *ericsoderberghp*:",
"text": "Sorry it took so long for me to get to this one. Just a few comments."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *primozs*:",
"text": "Looks great!"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *ericsoderberghp*:",
"text": "Sorry it took so long for me to get to this one. Just a few comments."
}
}
] |
[
{
"action": "opened",
"author": "chaaya",
"comment_id": null,
"datetime": 1464268609000,
"text": "## Feature\r\n- Native out of the box support for English(default) and Swedish.\r\n- Can be configured via the dashboardProvider.\r\n- Translations/langauges can be added to the framework.\r\n\r\n## Why?\r\nIt can seem to be little bit tacky when a system doesnt uses English, in my case our system is in Swedish and all adf labels/tooltips are in English. I think the language support takes the framework to the next level. \r\n\r\nHope you like it :)",
"title": "Feature: Multi-language support",
"type": "issue"
},
{
"action": "created",
"author": "sdorra",
"comment_id": 221938200,
"datetime": 1464283576000,
"text": "Looks really nice. Great job. I would love to see it in the next version.\r\n\r\nBut i'm not sure if i like the name \"culture\", i think i would feel more comfortable with a name like i18n, locale, l10n or something like this. Is there a special reason for culture?\r\n\r\nDo we need a new module or could we add it to adf.provider, to reduce complexity?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdorra",
"comment_id": 221939171,
"datetime": 1464283809000,
"text": "This would fix #102",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdorra",
"comment_id": 221939546,
"datetime": 1464283898000,
"text": "The documentation should be placed elsewhere in the wiki, extra file or we could add some extra pages to the api documentation. But i think the readme would get too long.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chaaya",
"comment_id": 221940840,
"datetime": 1464284212000,
"text": "I had a hard time deciding the name to be honest :) I have used kendo alot and they are using culture, but a culture also has an affect on dateformats and stuff, so it may be the wrong module name to use.\r\n\r\nadf.locale is good module name. \r\n\r\n```javascript\r\ndashboardProvider.setLocale('en-US')\r\n```\r\n\r\nI think it should be a own module, since it has a very narrow scope. That helps with the unit testing if we where to extend the locacle module with its own provider and translation factory that we later could inject into the dashboardProvider.\r\nMaybe I could fix that in the future, but this works for now. \r\n\r\nSound good?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdorra",
"comment_id": 221942414,
"datetime": 1464284547000,
"text": "Yes, sounds good for me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdorra",
"comment_id": 222148712,
"datetime": 1464356350000,
"text": "Thank you very much.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chaaya",
"comment_id": 222149046,
"datetime": 1464356439000,
"text": "@sdorra thank u :) would love som help regarding the wiki. Maybe we can take that privately over gitter?",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/6357910)\n\nCoverage increased (+0.4%) to 92.963% when pulling **8bec896f5eec146576015f5a5b9210cb3def52b1 on momentumsoftwareab:feature/language-support** into **3b910f95431413aa6183abe43f370813f2ba0323 on angular-dashboard-framework:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *sdorra*:",
"text": "Yes, sounds good for me."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *sdorra*:",
"text": "Yes, sounds good for me."
}
}
] |
[
{
"action": "opened",
"author": "ivanbuhov",
"comment_id": null,
"datetime": 1440056531000,
"text": "There is no more `metadata.bin` file. Metadata is now included in the executable upon build. The app thinning will strip the fat binaries to a single slice on the AppStore when the app is distributed to the client devices. This will leave a single copy of the metadata in the actual download from the AppStore.\r\nRelated issue: https://github.com/NativeScript/ios-runtime/issues/179",
"title": "Buhov/metadata merged in binary",
"type": "issue"
},
{
"action": "created",
"author": "fealebenpae",
"comment_id": 132967397,
"datetime": 1440066545000,
"text": "I can't tell from the patch, but did you move the 'Generate Metadata' build phase in the project template to the top? It would be best if it were right before the 'Link Binary' phase, for the same reason @jasssonpet cited for the proposed `PRE_LINK` CMake phase change.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivanbuhov",
"comment_id": 132981997,
"datetime": 1440070386000,
"text": "It turns out that the generation of `__TNSMetadata` section is part of the compilation phase, not the linking phase. It is the linker who does the job (`Ld` command is called), but it is called as part of the compilation process, right after all `CompileC` commands. So when the metadata generation step is between `Compile Sources` and `Link Binary With Libraries` or when it is set as `PRE_LINK` action the compilation phase fails with `ld: can't open -sectcreate file: /Users/buhov/Desktop/NS/ios-runtime/cmake-build/examples/Gameraww/Release-iphoneos/metadata-armv7.bin`, because it expects metadata to be already generated but there is no `metadata-armv7.bin` file yet. When I move the metadata generation step before `Compile Sources` phase (and in the other case - as `PRE_BUILD` action) it works like a charm. So I will leave it as it is unless you have better ideas.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fealebenpae",
"comment_id": 132985120,
"datetime": 1440071595000,
"text": "Alright, makes sense",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivanbuhov",
"comment_id": 133426124,
"datetime": 1440164031000,
"text": "Unfortunately, this approach is not working when NS Runtime is linked dynamically because it seems it is looking for TNSMetadata section in the dynamic library, but it is in the app executable.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jasssonpet",
"comment_id": 133427085,
"datetime": 1440164331000,
"text": "Can we move the extern variable to the app then",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivanbuhov",
"comment_id": 133440714,
"datetime": 1440166861000,
"text": "Yes, it should work. :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fealebenpae",
"comment_id": 134138680,
"datetime": 1440412204000,
"text": ":+1: after squashing to make things prettier",
"title": null,
"type": "comment"
}
] |
[
{
"bot": ":x:",
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *fealebenpae*:",
"text": "Alright, makes sense"
}
},
{
"bot": ":white_check_mark:",
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *ivanbuhov*:",
"text": "Yes, it should work. :+1:"
}
},
{
"bot": ":x:",
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *fealebenpae*:",
"text": ":+1: after squashing to make things prettier"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *fealebenpae*:",
"text": "Alright, makes sense"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *ivanbuhov*:",
"text": "Yes, it should work. :+1:"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *fealebenpae*:",
"text": ":+1: after squashing to make things prettier"
}
}
] |
[
{
"action": "opened",
"author": "tbreloff",
"comment_id": null,
"datetime": 1471638082000,
"text": "",
"title": "name changes",
"type": "issue"
},
{
"action": "created",
"author": "Evizero",
"comment_id": 241125469,
"datetime": 1471638245000,
"text": "we should deprecate the old types I think",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tbreloff",
"comment_id": 241126120,
"datetime": 1471638405000,
"text": "What the best practice to deprecate? I normally just break things without telling anyone.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Evizero",
"comment_id": 241126327,
"datetime": 1471638460000,
"text": "there is a macro for types, I'll look it up",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Evizero",
"comment_id": 241127052,
"datetime": 1471638649000,
"text": "`Base.@deprecate_binding DynMultivalueHistory MVHistory`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Evizero",
"comment_id": 241141189,
"datetime": 1471642459000,
"text": "Thanks! I'm off for today. please feel free to merge once the tests pass",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/7530622)\n\nCoverage remained the same at 79.13% when pulling **8d033c4e734bebc98a6d344b70e7115d27120a46 on tom** into **b4ea936e765e3927189f45782832292ccb5903a4 on master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *Evizero*:",
"text": "Thanks! I'm off for today. please feel free to merge once the tests pass"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *Evizero*:",
"text": "Thanks! I'm off for today. please feel free to merge once the tests pass"
}
}
] |
[
{
"action": "opened",
"author": "viirya",
"comment_id": null,
"datetime": 1424076267000,
"text": "Affinity Propagation (AP), a graph clustering algorithm based on the concept of \"message passing\" between data points. Unlike clustering algorithms such as k-means or k-medoids, AP does not require the number of clusters to be determined or estimated before running it. AP is developed by Frey and Dueck. Please refer to the [paper](http://www.psi.toronto.edu/affinitypropagation/FreyDueckScience07.pdf).",
"title": "[SPARK-5832][Mllib] Add Affinity Propagation clustering algorithm",
"type": "issue"
},
{
"action": "created",
"author": "mengxr",
"comment_id": 74559761,
"datetime": 1424114694000,
"text": "@viirya For new algorithms, we need to discuss whether we want to include it in MLlib on the JIRA page first (before implementing it). Could you describe more about this algorithm on the JIRA page, e.g., scalability, usage, and alternatives?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 74622054,
"datetime": 1424153796000,
"text": "@mengxr okay.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 74638488,
"datetime": 1424164888000,
"text": "@mengxr I updated the JIRA page. Please take a look. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 75284420,
"datetime": 1424453901000,
"text": "@mengxr have we decided no to include this algorithm? If so, please let me know. Then I will close this pr and maintain it as third-party package. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mengxr",
"comment_id": 75288067,
"datetime": 1424455202000,
"text": "I didn't see `cartesian` in your code. So the complexity is really `O(nnz * k)` but not `O(n^2 * k)`, correct? This is the same complexity as PIC/PageRank. If this is the case, let's check the code.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mengxr",
"comment_id": 75297368,
"datetime": 1424458423000,
"text": "@viirya I made a pass on the code. Some high-level feedback:\r\n\r\n1. What is the expected size of the model? Should we store it distributively?\r\n2. Defining a private case class to replace `Seq(Double, Double, Double)` would make the code much easier to read.\r\n3. Please try to add a Java example, which helps test Java API compatibility.\r\n\r\nI will go through the algorithm part again after 2).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mengxr",
"comment_id": 89915614,
"datetime": 1428294910000,
"text": "@viirya Any plan to update this PR?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 89915963,
"datetime": 1428295333000,
"text": "@mengxr I will update this soon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 90643243,
"datetime": 1428425469000,
"text": "@mengxr I updated for small comments. For the bigger ones, I will update later.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 91229215,
"datetime": 1428585490000,
"text": "@mengxr I have added a new function to automatically calculate the preferences used in AP algorithm. In fact, it just the median of similarities.\r\n\r\nBecause I use the function `percentile_approx` in Hive to calculate the median value, it has to add spark-hive as dependency of MLlib. I don't know if this is a good idea? How do you think?\r\n\r\nIf it is not, in order to provide this function to users, where it is better to put this in? Or it is better to implement a custom method to compute the median value?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vanzin",
"comment_id": 91299289,
"datetime": 1428600275000,
"text": "spark-hive can be disabled (in fact it has to be explicitly enabled, it's disabled by default), while mllib cannot, so I guess that is a non-starter.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 91304199,
"datetime": 1428601218000,
"text": "Thanks @vanzin, I think it might be a problem. I decided to move to custom method for median computation.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 91319694,
"datetime": 1428604196000,
"text": "@mengxr The model is now distributed. Edge messages and vertex data are defined as private case classes too. I will try to add Java examples later.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 91601780,
"datetime": 1428681789000,
"text": "@mengxr I have addressed all your comments. Please take a look. Thanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dbtsai",
"comment_id": 99354269,
"datetime": 1430897393000,
"text": "General question. In euclidean space, the negative squared error is used as similarity. If we want to use affinity propagation to clustering lots of samples in euclidean space, it's impossible to create all the pairs of similarity data even it's symmetrical. What's the criteria to filter out those pairs which have very low similarity? Also, it's impossible to compute all the pairs of `RDD[Vector]` since it's O(N^2) operation, and how people address this in practice? \r\n\r\nI really like this algorithm, but still have concern about how people can use it in practice. \r\n\r\nThanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 99541423,
"datetime": 1430932472000,
"text": "@dbtsai Thanks for comments and the question.\r\nI have no very good answer to the question. We have used a threshold to filter out the insignificant similarities of large scale data. As you said, it is impossible to compute all the pairs. However, the data we process is very high dimensional and very sparse, so the all-pair computation can be much reduced by only considering the pairs having corresponding dimensions with values more than zero (or a threshold defined).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dbtsai",
"comment_id": 99565738,
"datetime": 1430937180000,
"text": "@viirya Maybe you can comment on this in the documentation and in the comment of the code, and it will be useful for people trying to understand the use-case.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 121487220,
"datetime": 1436936041000,
"text": "@mengxr any plan to revisit this and merge it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rxin",
"comment_id": 168112592,
"datetime": 1451529759000,
"text": "I'm going to close this pull request. If this is still relevant and you are interested in pushing it forward, please open a new pull request. Thanks!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[Test build #27622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27622/consoleFull) for PR 4622 at commit [`6dbec7d`](https://github.com/apache/spark/commit/6dbec7d451511d17f39750815d4a7d11da03561b).\n * This patch merges cleanly.",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr okay."
}
},
{
"bot": "[Test build #27622 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27622/consoleFull) for PR 4622 at commit [`6dbec7d`](https://github.com/apache/spark/commit/6dbec7d451511d17f39750815d4a7d11da03561b).\n * This patch **passes all tests**.\n * This patch merges cleanly.\n * This patch adds the following public classes _(experimental)_:\n * `class AffinityPropagationModel(`",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I updated the JIRA page. Please take a look. Thanks!"
}
},
{
"bot": "[Test build #29798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29798/consoleFull) for PR 4622 at commit [`d762697`](https://github.com/apache/spark/commit/d762697e4140781b2dc8882c4d654e19ce5bb80b).",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I updated for small comments. For the bigger ones, I will update later."
}
},
{
"bot": "[Test build #30037 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30037/consoleFull) for PR 4622 at commit [`ffe06c3`](https://github.com/apache/spark/commit/ffe06c32fa892fc36a3a7f225ba8df256813e653).",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I have addressed all your comments. Please take a look. Thanks."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr okay."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I updated the JIRA page. Please take a look. Thanks!"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I updated for small comments. For the bigger ones, I will update later."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I have addressed all your comments. Please take a look. Thanks."
}
}
] |
[
{
"action": "opened",
"author": "trunet",
"comment_id": null,
"datetime": 1480857433000,
"text": "It uses a completely new API. More info on https://developer.honeywell.com/content/getting-started-guide.\r\n\r\n\r\n\r\nI didn't find any python library to deal with the new API.",
"title": "Support Honeywell Lyric Thermostat",
"type": "issue"
},
{
"action": "created",
"author": "jzwack",
"comment_id": 264976436,
"datetime": 1480971806000,
"text": "Should be pretty straightforward... does home assistant support auth code OAuth2 flow via a browser?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trunet",
"comment_id": 287303702,
"datetime": 1489741973000,
"text": "This is still not added to latest home-assistant. home-assistant support oauth2 on the webui.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trunet",
"comment_id": 305718542,
"datetime": 1496390558000,
"text": "hello, there is a custom_component that make the deal. should be easy to port to trunk.\r\n\r\ncheck this post:\r\nhttps://community.home-assistant.io/t/honeywell-lyric-thermostat/3520/52",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trunet",
"comment_id": 338270980,
"datetime": 1508520443000,
"text": "hello, the thread is still going on, we still should have lyric support available",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathanweinberg",
"comment_id": 371230385,
"datetime": 1520446252000,
"text": "Thread is still trucking!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.\n\nPlease make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:",
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *trunet*:",
"text": "This is still not added to latest home-assistant. home-assistant support oauth2 on the webui."
}
},
{
"bot": "There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.\n\nPlease make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:",
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *trunet*:",
"text": "hello, the thread is still going on, we still should have lyric support available"
}
},
{
"bot": "There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.\n\nPlease make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:",
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *jonathanweinberg*:",
"text": "Thread is still trucking!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *trunet*:",
"text": "This is still not added to latest home-assistant. home-assistant support oauth2 on the webui."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *trunet*:",
"text": "hello, the thread is still going on, we still should have lyric support available"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *jonathanweinberg*:",
"text": "Thread is still trucking!"
}
}
] |
[
{
"action": "opened",
"author": "JACKHAHA363",
"comment_id": null,
"datetime": 1456855954000,
"text": "Otherwise there will be an error on my machine.",
"title": "random.sample cannot take np.array. fixed",
"type": "issue"
},
{
"action": "created",
"author": "JACKHAHA363",
"comment_id": 190838642,
"datetime": 1456856060000,
"text": "I signed it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JACKHAHA363",
"comment_id": 190838684,
"datetime": 1456856069000,
"text": "I signed it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "KonradMagnusson",
"comment_id": 190923709,
"datetime": 1456869413000,
"text": "[Related fix.](https://github.com/tensorflow/tensorflow/pull/1335)",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA ([login here](https://cla.developers.google.com/) to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.\n\n<!-- need_author_cla -->",
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *JACKHAHA363*:",
"text": "I signed it."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *JACKHAHA363*:",
"text": "I signed it."
}
}
] |
[
{
"action": "opened",
"author": "davidlange6",
"comment_id": null,
"datetime": 1499703742000,
"text": "for comment about what clang-tidy does to CMSSW (and likely big and not mergeable - this is what clang-tidy check boost-use-to-string does on the tip of CMSSW_9_3_X as of a few days ago",
"title": "clang check boost-use-to-string",
"type": "issue"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 314158887,
"datetime": 1499703898000,
"text": "please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 314164079,
"datetime": 1499704975000,
"text": "please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 314296194,
"datetime": 1499736450000,
"text": "-1\r\n\r\nthis technically looks OK, but it should compile",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ianna",
"comment_id": 314713194,
"datetime": 1499853049000,
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dmitrijus",
"comment_id": 315015599,
"datetime": 1499936035000,
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 315195722,
"datetime": 1499978455000,
"text": "please test\r\n\r\nthe compilation error seems unrelated - i wonder if it reproduces",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 316667624,
"datetime": 1500547757000,
"text": "please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 316779906,
"datetime": 1500572929000,
"text": "merge",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
},
{
"bot": "-1\n\nTested at: 294f8bfa46271bea3ae7cae33cb8b9c86d00ef04\n\n\nThe following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: \nhttps://github.com/cms-sw/cmssw/commit/06199984952d9a6468923f7f1e47bed589272363\nYou can see more details here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-log-recent-commits\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-merge-result\n\nYou can see the results of the tests here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/summary.html\n\nI found follow errors while testing this PR\n\n**Failed tests: Build**\n\n* **Build**:\n\nI found an error when building: \n \n <pre>>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/CSCObjects/test/stubs/CSCPedestalReadAnalyzer.cc \n\fIn file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Archive.h:11:0,\n\f from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Test.h:9,\n\f from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Alignment/test/testSerializationAlignment.cpp:1:\n\f/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/eos/portable_oarchive.hpp: In function 'void testSerialization() [with T = unsigned int]':\n\f/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/eos/portable_oarchive.hpp:319:17: error: 'originalObject' may be used uninitialized in this function [-Werror=maybe-uninitialized]\n\f\f if (T temp = t)\r\n\f ^\n\fIn file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Alignment/test/testSerializationAlignment.cpp:1:0:\n\f/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Test.h:55:7: note: 'originalObject' was declared here\n\f T originalObject;\n\f</pre>\n\n\nThe following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: \nhttps://github.com/cms-sw/cmssw/commit/06199984952d9a6468923f7f1e47bed589272363\nYou can see more details here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-log-recent-commits\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-merge-result",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
},
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test\r\n\r\nthe compilation error seems unrelated - i wonder if it reproduces"
}
},
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test\r\n\r\nthe compilation error seems unrelated - i wonder if it reproduces"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
}
] |
[
{
"action": "opened",
"author": "caesarxuchao",
"comment_id": null,
"datetime": 1439941647000,
"text": "Breaking #12755 into smaller pieces. This is the first PR, it includes:\r\n\r\n1. 26a1992: enforces the URL exposed by apiserver to be in the form of prefix/group/version/...\r\n * for api/v1, we set the APIPrefix=\"api\", group=\"\", version=\"v1\", so the URL is still /api/v1\r\n * for experimental api, we set the APIPrefix=\"api\" (the exact name is open to discussion), group=\"experimental\", version=\"v1alpha1\", so the URL is /api/experimental/v1alpha1. And all future API groups will have the same APIPrefix.\r\n * for openshift and other third party API, we can either make prefix=\"osapi\", group=\"\", or prefix=\"\", group=\"osapi\", so the URL will not be changed.\r\n\r\n2. 45f3232: stop apiserver from encoding api.Status to a specific version unless the version is v1.\r\n\r\n3. 4e4dc89: let the existing two experimental objects use experimental storage which uses the v1alpha1 codec. This maybe needed to pass tests.\r\n\r\nThere will be subsequent PR depending on this one:\r\n\r\n1. factoring out default version, oldest version, storage version, etc. https://github.com/kubernetes/kubernetes/pull/12755#discussion_r37247918\r\n\r\n2. add KubeAPIPrefix https://github.com/kubernetes/kubernetes/pull/12755#discussion_r37251228\r\n\r\n3. move api.Status to unversioned https://github.com/kubernetes/kubernetes/pull/12755#discussion_r37251228\r\n\r\n4. move /expapi to /api/experimental https://github.com/kubernetes/kubernetes/pull/12755#discussion_r37251963\r\n\r\n5. ease our testing for multiple groups/versions\r\nhttps://github.com/kubernetes/kubernetes/pull/12755#discussion_r37329030\r\n\r\n@uluyol @nikhiljindal @bgrant0607 @krousey @smarterclayton @derekwaynecarr",
"title": "add more supports for multiple groups; change the version of experimental api v1alpha1",
"type": "issue"
},
{
"action": "created",
"author": "smarterclayton",
"comment_id": 132722125,
"datetime": 1440007138000,
"text": "Can we summarize the current status of the proposal into a proposal document or design (if one doesn't exist)? I have a lot of concerns about this but I'm finding I can't keep up with the pace of the design. I think this is a fundamental part of the core product we're changing, so if anything deserves a proposal it's this. I'd also like to offer my feedback on the pieces that are important to us (as an external API group that has different needs than expapi) and I'm worried about spreading around these pulls.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "smarterclayton",
"comment_id": 132722195,
"datetime": 1440007153000,
"text": "@bgrant0607 re my comment about this needing a proposal",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 132734283,
"datetime": 1440009119000,
"text": "@smarterclayton, I will write one.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 135131296,
"datetime": 1440613653000,
"text": "cc @lavalamp, this is the first step of #12591.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 136532386,
"datetime": 1441066007000,
"text": "@nikhiljindal, you can ignore the second commit \"don't encode api.Status to a version if the version is not v1\", because we changed our plan for it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhiljindal",
"comment_id": 136582255,
"datetime": 1441081687000,
"text": "I just glanced over the later part of PR as its a big one.\r\nI have added some comments, which should give you enough to work on for now.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 136590702,
"datetime": 1441085384000,
"text": "#12837 enables validate by default and it reveals the problem that validation doesn't work across groups of different versions. I'm fixing the problem.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 136592237,
"datetime": 1441086264000,
"text": "client.ServerAPIVersions() needs to be fixed. Currently it reports:\r\nServer does not support API version 'experimental/v1alpha1'. Falling back to 'v1'.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhiljindal",
"comment_id": 136841441,
"datetime": 1441137469000,
"text": "Is it possible to take the test changes out of this PR?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 136845246,
"datetime": 1441137956000,
"text": "Unless we have a way to disable the tests related to experimental objects, they will fail without the changes to the tests.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bgrant0607",
"comment_id": 143944236,
"datetime": 1443502376000,
"text": "Is this PR still active?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 143944408,
"datetime": 1443502526000,
"text": "No. Thanks for the reminding.\r\n\r\nSuperseded by #14156, #13833, and #13581 etc.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "GCE e2e build/test **failed** for commit 9a139b6efbb6bd910bed47fe4e68fe6fd28d122e.\n* [Build Log](https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/9a139b6efbb6bd910bed47fe4e68fe6fd28d122e/kubernetes-pull-build-test-e2e-gce/6348/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/9a139b6efbb6bd910bed47fe4e68fe6fd28d122e/kubernetes-pull-build-test-e2e-gce/6348/_artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//6348)",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-bot* by author *caesarxuchao*:",
"text": "@smarterclayton, I will write one."
}
},
{
"bot": "GCE e2e build/test **failed** for commit b7035afee127f5228d340d7469fce2c652f4dcd4.\n* [Build Log](https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/b7035afee127f5228d340d7469fce2c652f4dcd4/kubernetes-pull-build-test-e2e-gce/6357/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/b7035afee127f5228d340d7469fce2c652f4dcd4/kubernetes-pull-build-test-e2e-gce/6357/_artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//6357)",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-bot* by author *caesarxuchao*:",
"text": "cc @lavalamp, this is the first step of #12591."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-bot* by author *caesarxuchao*:",
"text": "@smarterclayton, I will write one."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-bot* by author *caesarxuchao*:",
"text": "cc @lavalamp, this is the first step of #12591."
}
}
] |
[
{
"action": "opened",
"author": "Ladas",
"comment_id": null,
"datetime": 1466680246000,
"text": "Service should load all_vms from nested services\r\n\r\nThen parent service page shows all vms of all nested services, which is a nice overview.",
"title": "Service should load all_vms from nested services",
"type": "issue"
},
{
"action": "created",
"author": "Ladas",
"comment_id": 228018692,
"datetime": 1466680306000,
"text": "@bzwei @gmcculloug if you have any insight guys, it would be nice. Point is to see all VMs in the top level service.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bzwei",
"comment_id": 228386988,
"datetime": 1466784297000,
"text": "cc @kbrock",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kbrock",
"comment_id": 228626316,
"datetime": 1466979350000,
"text": "Thanks bill. @ladas let's talk Monday. I would like to know where the old code was not bringing back all the vms. Sounds like you found a bug. But I'm guessing the bug is not in the call to all_vms vs direct_vms",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kbrock",
"comment_id": 229951446,
"datetime": 1467380932000,
"text": ":+1: with this pr.\r\n\r\nI think the failure may be a bad test. @Ladas could you take a look at the return values and determine the underlying cause?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ladas",
"comment_id": 229982383,
"datetime": 1467388392000,
"text": "@kbrock test should be fixed now",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kbrock",
"comment_id": 230046727,
"datetime": 1467406969000,
"text": "@Ladas is this for darga?",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "<rubocop />Checked commit https://github.com/Ladas/manageiq/commit/29f597bf28130d0425c7ba1d09fb299d9b5458e2 with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1\n2 files checked, 0 offenses detected\nEverything looks good. :trophy:",
"previous": {
"meta": "This message directly preceded comment from bot *miq-bot* by author *Ladas*:",
"text": "@kbrock test should be fixed now"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *miq-bot* by author *Ladas*:",
"text": "@kbrock test should be fixed now"
}
}
] |
[
{
"action": "opened",
"author": "aaronlevy",
"comment_id": null,
"datetime": 1441848829000,
"text": "The current conformance-test-v1 branch does not use the KUBE_MASTER_URL extracted from the kubeconfig.\r\n\r\nIt looks like this change is already in master from: https://github.com/kubernetes/kubernetes/commit/29da889bbf0acbf579ea155e4cc66ae168705468\r\n\r\nBut looks like only part of that change was pulled into conformance-test-v1: https://github.com/kubernetes/kubernetes/commit/104aa5d361e624a2d11198ef00fd737dab588f60",
"title": "Use KUBE_MASTER_URL in conformance test",
"type": "issue"
},
{
"action": "created",
"author": "ixdy",
"comment_id": 139398355,
"datetime": 1441923526000,
"text": "ok to test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ixdy",
"comment_id": 139403953,
"datetime": 1441925323000,
"text": "oh, this branch is not whitelisted, so @k8s-bot will never test it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erictune",
"comment_id": 140229429,
"datetime": 1442271905000,
"text": "LGTM.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erictune",
"comment_id": 140229533,
"datetime": 1442271951000,
"text": "Merging because it is to a special branch that I am the defacto owner of",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Labelling this PR as size/XS",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *ixdy*:",
"text": "oh, this branch is not whitelisted, so @k8s-bot will never test it."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *ixdy*:",
"text": "oh, this branch is not whitelisted, so @k8s-bot will never test it."
}
}
] |
[
{
"action": "opened",
"author": "krris",
"comment_id": null,
"datetime": 1476361465000,
"text": "This PR resolves an issue https://github.com/spotify/HubFramework/issues/51",
"title": "Image loader: Replace cache-check with timer",
"type": "issue"
},
{
"action": "created",
"author": "krris",
"comment_id": 255058373,
"datetime": 1476956357000,
"text": "@JohnSundell 🎾",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krris",
"comment_id": 255079574,
"datetime": 1476962691000,
"text": "@JohnSundell 🎾",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "<table>\n <thead>\n <tr>\n <th width=\"50\"></th>\n <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Warning\">\n 1 Warning\n </th>\n </tr>\n </thead>\n <tbody>\n\n <tr>\n <td>:warning:</td>\n <td data-sticky=\"true\">Couldn’t find the (junit) unit test report file in ‘build/tests/’. Make sure the tests were actually run.</td>\n </tr>\n </tbody>\n</table>\n\n<p align=\"right\" data-meta=\"generated_by_danger\">\n Generated by :no_entry_sign: <a href=\"http://danger.systems/\">danger</a>\n</p>",
"previous": {
"meta": "This message directly preceded comment from bot *spotify-ci-bot* by author *krris*:",
"text": "@JohnSundell 🎾"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *spotify-ci-bot* by author *krris*:",
"text": "@JohnSundell 🎾"
}
}
] |
[
{
"action": "opened",
"author": "thockin",
"comment_id": null,
"datetime": 1423951886000,
"text": "In some places we expect an IP where a hostname might suffice. We should make a pass over the API and decide for each case and document/test it properly. As per #1300 the \"must be IP\" fields can self-document as net.IP. The hostname-or-IP fields we can think about decoding tricks.",
"title": "API: analyze all \"IP\" fields and decide if hostname is valid",
"type": "issue"
},
{
"action": "created",
"author": "girishkalele",
"comment_id": 236397692,
"datetime": 1469923411000,
"text": "I guess this one is still open - #11838 was closed in favor of https://github.com/kubernetes/kubernetes/issues/13748 but that one is also still open.\r\n\r\nTo summarize my understanding, if an EndpointsAddress entry is added to a service endpoint that contains a string IP or hostname field, we respond with CNAME records ?\r\nCan CNAME and A records be mixed in a response ? i.e. if the service has both IP and hostname endpoints, can we serve a mixed CNAME and A record response ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "thockin",
"comment_id": 236499092,
"datetime": 1470032800000,
"text": "#13748 will be worked on by @rata.\n\nYou can not mix CNAME and A records, and in fact you can not even have\nmultiple CNAME records.\n\nNeither of those are what this one is about, though. This is about\nauditing the API and documenting when a field *must* be an IP (and\nadding/tightening validation and tests in those cases) vs when a field may\nbe an IP or a hostname (and adding/loosening validation and tests in those\ncases).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kargakis",
"comment_id": 305931812,
"datetime": 1496446444000,
"text": "@kubernetes/sig-network-misc",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Issues go stale after 90d of inactivity.\nMark the issue as fresh with `/remove-lifecycle stale`.\nStale issues rot after an additional 30d of inactivity and eventually close.\n\nPrevent issues from auto-closing with an `/lifecycle frozen` comment.\n\nIf this issue is safe to close now please do so with `/close`.\n\nSend feedback to sig-testing, kubernetes/test-infra and/or `@fejta`.\n/lifecycle stale",
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *kargakis*:",
"text": "@kubernetes/sig-network-misc"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *kargakis*:",
"text": "@kubernetes/sig-network-misc"
}
}
] |
[
{
"action": "opened",
"author": "ueshin",
"comment_id": null,
"datetime": 1494399890000,
"text": "## What changes were proposed in this pull request?\r\n\r\nBecause the method `TimeZone.getTimeZone(String ID)` is synchronized on the TimeZone class, concurrent call of this method will become a bottleneck.\r\nThis especially happens when casting from string value containing timezone info to timestamp value, which uses `DateTimeUtils.stringToTimestamp()` and gets TimeZone instance on the site.\r\n\r\nThis pr makes a cache of the generated TimeZone instances per thread to avoid the synchronization.\r\n\r\n## How was this patch tested?\r\n\r\nExisting tests.",
"title": "[SPARK-20588][SQL] Cache TimeZone instances per thread.",
"type": "issue"
},
{
"action": "created",
"author": "viirya",
"comment_id": 301358915,
"datetime": 1494813801000,
"text": "LGTM",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gatorsmile",
"comment_id": 301636373,
"datetime": 1494892372000,
"text": "Thanks! Merging to master/2.2",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "**[Test build #76923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76923/testReport)** for PR 17933 at commit [`3cdbb3a`](https://github.com/apache/spark/commit/3cdbb3acf12b2082056e8b4e2eb3f1645fa1bde7).",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "LGTM"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "LGTM"
}
}
] |
[
{
"action": "opened",
"author": "Undo1",
"comment_id": null,
"datetime": 1465223634000,
"text": "Missing backtick was causing unhappiness.",
"title": "Fix formatting issue",
"type": "issue"
},
{
"action": "created",
"author": "Undo1",
"comment_id": 223977658,
"datetime": 1465223723000,
"text": "@googlebot I signed it!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "girving",
"comment_id": 224019156,
"datetime": 1465232133000,
"text": "@Undo1: Thank you for the fix! Backticks are depressing hard to see. :)",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "CLAs look good, thanks!\n\n<!-- ok -->",
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *Undo1*:",
"text": "@googlebot I signed it!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *Undo1*:",
"text": "@googlebot I signed it!"
}
}
] |
[
{
"action": "opened",
"author": "liancheng",
"comment_id": null,
"datetime": 1433135074000,
"text": "This is a follow-up of PR #6493, which has been reverted in branch-1.4 because it uses Java 7 specific APIs and breaks Java 6 build. This PR replaces those APIs with equivalent Guava ones to ensure Java 6 friendliness.\r\n\r\ncc @andrewor14 @pwendell, this should also be back ported to branch-1.4.",
"title": "[SQL] [TEST] [MINOR] Follow-up of PR #6493, use Guava API to ensure Java 6 friendliness",
"type": "issue"
},
{
"action": "created",
"author": "andrewor14",
"comment_id": 107308592,
"datetime": 1433135642000,
"text": "lgtm merging once tests pass",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liancheng",
"comment_id": 107851793,
"datetime": 1433232307000,
"text": "Addressed @zsxwing's comment, will merge this to master and branch-1.4 once Jenkins passes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andrewor14",
"comment_id": 108136412,
"datetime": 1433290043000,
"text": "master 1.4 thanks cheng",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[Test build #33876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33876/consoleFull) for PR 6547 at commit [`72da795`](https://github.com/apache/spark/commit/72da795dee1e7926452d134f7b0c6d4a0549dc31).\n * This patch **passes all tests**.\n * This patch merges cleanly.\n * This patch adds no public classes.",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *andrewor14*:",
"text": "lgtm merging once tests pass"
}
},
{
"bot": "Merged build triggered.",
"previous": {
"meta": "This message directly preceded comment from bot *AmplabJenkins* by author *liancheng*:",
"text": "Addressed @zsxwing's comment, will merge this to master and branch-1.4 once Jenkins passes."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *andrewor14*:",
"text": "lgtm merging once tests pass"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *AmplabJenkins* by author *liancheng*:",
"text": "Addressed @zsxwing's comment, will merge this to master and branch-1.4 once Jenkins passes."
}
}
] |
[
{
"action": "opened",
"author": "romanblanco",
"comment_id": null,
"datetime": 1427722740000,
"text": "Parent issue: #2389\r\nShould be reviewed after #2425 got merged",
"title": "Added missing semicolons, var's; using dot notation",
"type": "issue"
},
{
"action": "created",
"author": "martinpovolny",
"comment_id": 95582976,
"datetime": 1429795568000,
"text": "No further notes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "martinpovolny",
"comment_id": 96656890,
"datetime": 1430142324000,
"text": "@romanblanco : great, thx for the re-checking. I'd merge this right after we for a branch for the release.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "<rubocop />Checked commits https://github.com/romanblanco/manageiq/commit/7ba11adbfa2846ca222c4ce33acd36b23915fe3d .. https://github.com/romanblanco/manageiq/commit/7f5ddaa32b5350afbe6bfbda89ec800e42e3187f with rubocop 0.27.1\n0 files checked, 0 offenses detected\nEverything looks good. :+1:",
"previous": {
"meta": "This message directly preceded comment from bot *miq-bot* by author *martinpovolny*:",
"text": "No further notes."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *miq-bot* by author *martinpovolny*:",
"text": "No further notes."
}
}
] |
[
{
"action": "opened",
"author": "makortel",
"comment_id": null,
"datetime": 1466605894000,
"text": "The check for `Track::seedRef()` availability in MultiTrackValidator, added in #14248, was not sufficient. This omission leads to an exception from missing product in the MTV standalone mode ([SWGuideMultiTrackValidator#cmsDriver_MTV_alone_i_e_standalo](https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMultiTrackValidator#cmsDriver_MTV_alone_i_e_standalo)). Requiring explicitly the availability of the seed product fixes the exception. Thanks to @ebrondol for reporting the bug.\r\n\r\nTested in CMSSW_8_1_0_pre6, no changes expected in standard workflows.\r\n\r\n@rovere @VinInn",
"title": "Fix to MultiTrackValidator standalone mode",
"type": "issue"
},
{
"action": "created",
"author": "VinInn",
"comment_id": 228316456,
"datetime": 1466765727000,
"text": "@cmsbuild , please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ebrondol",
"comment_id": 228479847,
"datetime": 1466807875000,
"text": "@kpedro88 is it possible to fit also this in pre8? It would be useful (with another PR that I am testing now) to fix the validation for the phase2 tracking.. We just discover the issue today.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kpedro88",
"comment_id": 228480219,
"datetime": 1466807998000,
"text": "@davidlange6 this seems to be a one-line bug fix, would be nice to put in pre8.\r\n\r\n@dmitrijus, @vanbesien please review and sign if possible (I realize it's short notice, but it seems to be a straightforward change).",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *VinInn*:",
"text": "@cmsbuild , please test"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *VinInn*:",
"text": "@cmsbuild , please test"
}
}
] |
[
{
"action": "created",
"author": "colemickens",
"comment_id": 253090941,
"datetime": 1476234411000,
"text": "I hit it too, direct link to build: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/34416/kubernetes-pull-test-unit-integration/48793/ PR here: https://github.com/kubernetes/kubernetes/pull/34416",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dims",
"comment_id": 253094273,
"datetime": 1476235829000,
"text": "@colemickens : can you try rebasing on https://github.com/kubernetes/kubernetes/commit/3d2674b2ddbdea485e1114479b03392ce2589c4c ? That should have fixed this problem",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "colemickens",
"comment_id": 253097030,
"datetime": 1476237019000,
"text": "Looks like they finally passed and retest is skipped for the submit-queue for that PR, so I'd prefer not to rebase and risk encountering another flake.\r\n\r\nIf you need it as a confirmation of 3d2674b, let me know and I'll force push my rebase.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dims",
"comment_id": 253097913,
"datetime": 1476237433000,
"text": "@colemickens no worries. things are looking up in the gate. we can close this issue out tomorrow",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gmarek",
"comment_id": 253155714,
"datetime": 1476262190000,
"text": "This is still happening and blocking the build. @apelisse please treat this as a real P0.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "piosz",
"comment_id": 253187924,
"datetime": 1476271609000,
"text": "cc @deads2k @kargakis",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "deads2k",
"comment_id": 253195860,
"datetime": 1476274086000,
"text": "opened https://github.com/kubernetes/kubernetes/pull/34608",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "piosz",
"comment_id": null,
"datetime": 1476277187000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/18013/\n\nFailed: TestDeploymentController_dontSyncDeploymentsWithEmptyPodSelector {deployment}\n\n```\ndeployment_controller_test.go:270: expected deployment controller to not take action\n```",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *gmarek*:",
"text": "This is still happening and blocking the build. @apelisse please treat this as a real P0."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *gmarek*:",
"text": "This is still happening and blocking the build. @apelisse please treat this as a real P0."
}
}
] |
[
{
"action": "opened",
"author": "apfeiffer1",
"comment_id": null,
"datetime": 1426780969000,
"text": "add listGTs sub-command to commandline tool (conddb) to list all GTs in condDBv2",
"title": "add functionality to list all GTs in condDBv2",
"type": "issue"
},
{
"action": "created",
"author": "ggovi",
"comment_id": 83990490,
"datetime": 1426851137000,
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 84022034,
"datetime": 1426859937000,
"text": "+1",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *ggovi*:",
"text": "+1"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *ggovi*:",
"text": "+1"
}
}
] |
[
{
"action": "opened",
"author": "hsanjuan",
"comment_id": null,
"datetime": 1491445739000,
"text": "This should fix what I meant in #84\r\n\r\nLicense: MIT",
"title": "WIP: A guide to running ipfs cluster",
"type": "issue"
},
{
"action": "created",
"author": "hsanjuan",
"comment_id": 292652666,
"datetime": 1491599428000,
"text": "Would be good to get feedback here.\r\n\r\n@bgadmin, would you like to read this guide and provide some feedback? Like things that are missing, or not clear enough and can be better explained...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bgadmin",
"comment_id": 292859379,
"datetime": 1491805210000,
"text": "@hsanjuan sure thing, sorry for late reply will get back to you today :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "VictorBjelkholm",
"comment_id": 292866558,
"datetime": 1491807934000,
"text": "Would be nice to have a quickstart in the top, similar to what was in the top-level readme.md before, where you just list the minimal set of commands to get up and running.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hsanjuan",
"comment_id": 296367958,
"datetime": 1492861762000,
"text": "I have added the quickstart to the main README.. The guide is meant for a more in-depth approach.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/11194158)\n\nCoverage decreased (-0.07%) to 74.095% when pulling **ef4132f57220528bc058d9a9eee701c7082bcea1 on guide** into **98039bdd0d5d77f1230bef5e65b7d21069548a95 on master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *hsanjuan*:",
"text": "I have added the quickstart to the main README.. The guide is meant for a more in-depth approach."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *hsanjuan*:",
"text": "I have added the quickstart to the main README.. The guide is meant for a more in-depth approach."
}
}
] |
[
{
"action": "opened",
"author": "haypo",
"comment_id": null,
"datetime": 1509500590000,
"text": "bpo-31910: test_create_connection() now catchs also EADDRNOTAVAIL to\r\nfix the test on Travis CI.\n\n<!-- issue-number: bpo-31910 -->\nhttps://bugs.python.org/issue31910\n<!-- /issue-number -->",
"title": "bpo-31910: Fix test_socket.test_create_connection()",
"type": "issue"
},
{
"action": "created",
"author": "miss-islington",
"comment_id": 340963251,
"datetime": 1509504507000,
"text": "Thanks @haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.\n🐍🍒⛏🤖",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "miss-islington",
"comment_id": 340963297,
"datetime": 1509504525000,
"text": "Thanks @haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.\n🐍🍒⛏🤖",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[GH-4209](https://github.com/python/cpython/pull/4209) is a backport of this pull request to the [2.7 branch](https://github.com/python/cpython/tree/2.7).",
"previous": {
"meta": "This message directly preceded comment from bot *bedevere-bot* by author *miss-islington*:",
"text": "Thanks @haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.\n🐍🍒⛏🤖"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *bedevere-bot* by author *miss-islington*:",
"text": "Thanks @haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.\n🐍🍒⛏🤖"
}
}
] |
[
{
"action": "opened",
"author": "cblecker",
"comment_id": null,
"datetime": 1516647924000,
"text": "",
"title": "Add mergewarning to k/community",
"type": "issue"
},
{
"action": "created",
"author": "spiffxp",
"comment_id": 359530402,
"datetime": 1516647989000,
"text": "/lgtm",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/test-infra/pull/6374#\" title=\"Author self-approved\">cblecker</a>*, *<a href=\"https://github.com/kubernetes/test-infra/pull/6374#issuecomment-359530402\" title=\"LGTM\">spiffxp</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\n<details >\nNeeds approval from an approver in each of these OWNERS Files:\n\n- ~~[prow/OWNERS](https://github.com/kubernetes/test-infra/blob/master/prow/OWNERS)~~ [spiffxp]\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *spiffxp*:",
"text": "/lgtm"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *spiffxp*:",
"text": "/lgtm"
}
}
] |
[
{
"action": "opened",
"author": "dorzel",
"comment_id": null,
"datetime": 1468511520000,
"text": "create empty environments when no packages are supplied in create",
"title": "WIP Create empty environments",
"type": "issue"
},
{
"action": "created",
"author": "kalefranz",
"comment_id": 232720699,
"datetime": 1468514290000,
"text": "Will definitely need at least one test in `test_create` for this. Read through the tests that are currently there for examples and inspiration.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dorzel",
"comment_id": 233006313,
"datetime": 1468601575000,
"text": "@kalefranz all tests passed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kalefranz",
"comment_id": 233102959,
"datetime": 1468635123000,
"text": "This PR can be merged by Monday for 4.2.0rc1 as is, but there's still a bit more work to do here and there I think. One thing that I think we probably need is some additional unit tests for `History` now.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dorzel",
"comment_id": 233669691,
"datetime": 1468942080000,
"text": "@kalefranz let me know if this looks good",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[cc-base-branch]: https://codecov.io/gh/conda/conda/branch/master?src=pr\n[cc-compare]: https://codecov.io/gh/conda/conda/compare/86a24ee68c697da3dee807787d3f4c3db6fcef22...2a29d3de44e0def5b54d741b66fb5aa6a484d11c?src=pr\n[cc-pull]: https://codecov.io/gh/conda/conda/pull/3072?src=pr",
"previous": {
"meta": "This message directly preceded comment from bot *codecov-io* by author *dorzel*:",
"text": "@kalefranz let me know if this looks good"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *codecov-io* by author *dorzel*:",
"text": "@kalefranz let me know if this looks good"
}
}
] |
[
{
"action": "opened",
"author": "isobelojalvo",
"comment_id": null,
"datetime": 1453751447000,
"text": "In 76X we were missing some necessary tau discriminators and had an issue with a new decay mode in the decay mode finding algorithm. The fix was applied in 76X by re-running the Taus at the miniAOD step. This pull request makes the RECO/AOD sequence the same as what is run in the miniAOD sequence in 76X (i.e. integration of needed discriminators + bugfix) and removes the 're-running' of the taus in miniAOD.",
"title": "Integration of 76X Tau re-miniAOD into main 80X Sequence",
"type": "issue"
},
{
"action": "created",
"author": "slava77",
"comment_id": 174646529,
"datetime": 1453752784000,
"text": "@isobelojalvo what is the relationship between this PR and #13042 ?\r\nIt looks like the same code is modified, also, the original branch in #13402 was removed, which I guess means that #13402 should be closed.\r\nPlease clarify.\r\nThank you.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 174651335,
"datetime": 1453753564000,
"text": "Hi, The 80xReMiniAOD should be used and the 80xReMiniAODv2 had been created as a dummy for testing purposes. I should have notified AJ of this earlier! Apologies! Could you please work off this pull request?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 174654749,
"datetime": 1453754151000,
"text": "@cmsbuild please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 174953645,
"datetime": 1453805328000,
"text": "Checking the unit tests I see they are run on the following sample:\r\n\r\n25-Jan-2016 22:04:29 CET Successfully opened file root://eoscms.cern.ch//eos/cms/store/relval/CMSSW_7_6_0_pre7/RelValProdTTbar_13/AODSIM/76X_mcRun2_asymptotic_v5-v1/00000/0E9A5DE8-1D71-E511-A205-00261894380D.root\r\n\r\nThe error we see is that MVA6 is not present. This is certainly true: we did not have MVA6 in 7_6_0 at MVA6. Am I missing something? @slava77 @cvuosalo @andrewj314",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175194978,
"datetime": 1453837318000,
"text": "@isobelojalvo: For the RECO product of workflow 134.805_RunMET2015C, I find 64 added tau discriminators and 16 removed, for a net gain of 48 discriminators. I think we want to keep the net addition of discriminators to be less than 10. Could you please remove more obsolete and unneeded products?\r\n\r\nI see no change in Mini-AOD event content, and I'm still checking AOD.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175196776,
"datetime": 1453837659000,
"text": "@isobelojalvo: The PR description does not describe the results of \"fixing\" the decay mode algorithm. There are numerous differences showing up for workflow 134.805_RunMET2015C. Are these differences expected? If so, please add an explanation of the expected differences to the PR description. Here are some examples:\r\n\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 175245569,
"datetime": 1453844542000,
"text": "@cvuosalo Thanks for the plots. Could you tell me if red is from the current pull request or from the old? (or how can I check this myself?) Thank you!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175261446,
"datetime": 1453846723000,
"text": "@isobelojalvo: Yes, red in the plots is from the PR, and black is from the baseline I used, 800pre5.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175266174,
"datetime": 1453847181000,
"text": "@isobelojalvo: I checked AOD event content also, by using workflow 1000.0_RunMinBias2011A. Again, this PR adds 64 new tau discriminators, while only removing 16. We should be aiming to remove almost as many old, unneeded discriminators as new ones being added.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 175274049,
"datetime": 1453848079000,
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175287972,
"datetime": 1453849987000,
"text": "@slava77: With this PR, there are 140 tau discriminators in AOD for workflow 1000.0_RunMinBias2011A.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175290536,
"datetime": 1453850668000,
"text": "@isobelojalvo: Concerning the unit test failures, the baseline used by Jenkins, CMSSW_8_0_X_2016-01-25-1100, performs the same unit tests successfully. It would seem this PR somehow adds the dependence on MVA6, as indicated by this error message:\r\n```\r\nPrincipal::getByToken: Found zero products matching all criteria\r\nLooking for type: reco::PFTauDiscriminator\r\nLooking for module label: hpsPFTauDiscriminationByMVA6LooseElectronRejection\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 175292207,
"datetime": 1453851031000,
"text": "Hi @cvuosalo, First: apologies about to go offline in a few minutes and will address other issues in the morning. Second: concerning the MVA6, yes, I see it is missing. However, I think this is due to the pattuplization test running on a 76x AOD sample. Dumping the event content of that file shows MVA6 is not there: This is the correct and expected behavior.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 175329702,
"datetime": 1453858040000,
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 175711784,
"datetime": 1453910698000,
"text": "@slava77 @cvuosalo \r\nRelval sample:\r\nOK, we will see about the new relval sample. I am actually not used to the workflow for the creation of a new relval. Any guidance would help. I will also check with our tau relval experts. In the mean time, is it allowed to run on a privately produce sample instead? And can this pull request be integrated before the new relval is produced? (I am worrying about the timescale here)\r\n\r\nNumber of Discriminants:\r\nWe have a preference to do the discriminant clean up in a separate branch so that we can keep track if there is an error in the clean up. I created a new branch[*] in cms-tau-pog and will do a pull request when this branch is edited. It should be fast. \r\n\r\nDQM Plots:\r\nIt is expected that the efficiency will increase and this should be in line with what we see in 76xReminiAOD. In the plots, the low efficiency in the black was apparently due to the 3prong+1pi0 integration. It is removed in the current pull request. We are working towards reintegration in the NewDecayModes and not in the OldDecayModes.\r\n\r\n[*]https://github.com/cms-tau-pog/cmssw/tree/80xReMiniAOD-RemoveOldDisc",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 175720214,
"datetime": 1453911625000,
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 175740586,
"datetime": 1453913527000,
"text": "About the unit tests, I was thinking that we could generate an AOD file on the fly for the case where we know well that the new AOD format is needed.\r\n\r\n@gpetruc I seem to remember we did something to make the tests running PAT on AOD inputs to complete in a similar case. Do you remember what was done?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 175742134,
"datetime": 1453913804000,
"text": "The discriminants for removal are listed in the attached files created by Aruna\r\n\r\nA rough count shows approximately 1/3 can certainly be removed. The increase overall is partially due to the addition of a new MVA6 electron discriminator and keeping the MVA5, we can remove MVA5 in the next cycle after analysts have had a chance to fully validate MVA6.\r\n\r\n[PatTauID_Discriminators_80X.txt](https://github.com/cms-sw/cmssw/files/106993/PatTauID_Discriminators_80X.txt)\r\n[RecoTauID_Discriminators_80X.txt](https://github.com/cms-sw/cmssw/files/106992/RecoTauID_Discriminators_80X.txt)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175915937,
"datetime": 1453938895000,
"text": "@isobelojalvo, @slava77: I am editing the list of tau discriminators here: https://twiki.cern.ch/twiki/bin/view/CMS/RecoTauDiscrim",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 176260586,
"datetime": 1453998136000,
"text": "As suggested, I removed the new inputs. I will put them back in for pre6. Could this be tested?\r\n\r\nThanks",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 176263872,
"datetime": 1453998507000,
"text": "@cmsbuild please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 176343781,
"datetime": 1454007867000,
"text": "@cvuosalo concerning the twiki update, I have pointed Arun to the twiki and he will modify as necessary he has also already committed the cleaned up branch. Depending on the release schedule, it would be nice to have the cleaned up branch added to the next release. Let me know if this is a problem for you.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 177000804,
"datetime": 1454106926000,
"text": "+1\r\n\r\nFor #13060 a20e68d1d9f843be26c134fcb066a63c992ff55f\r\n\r\nAdds some new tau discriminators and removes a few obsolete ones. Also, removes the 3prong1pi0 decay mode from the AOD sequence.\r\n\r\nFollow-up PRs will delete additional unneeded tau discriminators and will add new input for PAT algos after they become available in the next pre-release, as discussed above.\r\n\r\nThe code changes are satisfactory. Jenkins [tests](https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13060/10818/summary.html) against baseline CMSSW_8_0_X_2016-01-27-2300 show numerous, insignificant differences related to tau decay modes, plus efficiency increases that are expected, as discussed above. Tests of workflow 25202.0_TTbar_13 with 70 events against baseline CMSSW_8_0_0_pre5 show similar differences as those from the Jenkins test results and the plots shown above. An additional example difference plot from this 25202 test is shown below.\r\n\r\nMemory and timing measurements show no significant increase. Two timing measurements show no increase, while a third measurement shows an overall timing increase of 1%. At worst, the new tau discriminators may increase times by 18 ms per event, but we expect a follow-up PR that will delete more obsolete discriminators and reduce this timing increase.\r\n\r\nExample of change in decay mode finding frequencies:\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 177011400,
"datetime": 1454108749000,
"text": "Additional timing measurements from test of workflow 25202 (without Validation step) against baseline CMSSW_8_0_0_pre5:\r\n\r\n```\r\nTotal time formerly used by deleted discriminators: 2.8 ms/ev\r\nTotal time used by new discriminators: 62.3 ms/ev\r\n\r\nNew discriminators taking > 3 ms/ev\r\n hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr3HitsdR03 4.90777 ms/ev\r\n hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3HitsdR03 4.88347 ms/ev\r\n hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr3HitsdR03 4.88874 ms/ev\r\n hpsPFTauDiscriminationByIsolationMVArun2v1PWnewDMwLTraw 3.37712 ms/ev\r\n hpsPFTauPUcorrPtSumdR03 4.82939 ms/ev\r\n hpsPFTauNeutralIsoPtSumWeightdR03 3.78463 ms/ev\r\n hpsPFTauDiscriminationByIsolationMVArun2v1DBdR03oldDMwLTraw 3.28005 ms/ev\r\n hpsPFTauDiscriminationByIsolationMVArun2v1PWdR03oldDMwLTraw 3.40165 ms/ev\r\n\r\n\r\nRetained discriminator that uses the most time, change from baseline to PR:\r\n hpsPFTauDiscriminationByMVA5rawElectronRejection 15.8576 ms/ev -> 12.6722 ms/ev\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "deguio",
"comment_id": 177861587,
"datetime": 1454317118000,
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 177934890,
"datetime": 1454327597000,
"text": "Do we (tau group) have any action items for this pull request? Can it be integrated?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 177991190,
"datetime": 1454336454000,
"text": "@isobelojalvo @davidlange6 \r\nanalysis signature is still pending here.\r\nThere is one more PR (13100) that depends on integration of this one.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 177998093,
"datetime": 1454337672000,
"text": "Right - its been signed by other groups for only a few hours….\r\n\r\n>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 178000628,
"datetime": 1454338153000,
"text": "No worries, just want to keep in mind the release closure cycle and not get 'ding-ed'. - Thanks",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *slava77*:",
"text": "@cmsbuild please test"
}
},
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *slava77*:",
"text": "@cmsbuild please test"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *slava77*:",
"text": "@cmsbuild please test"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *slava77*:",
"text": "@cmsbuild please test"
}
}
] |
[
{
"action": "opened",
"author": "samphilipd",
"comment_id": null,
"datetime": 1491817336000,
"text": "",
"title": "Projects columns",
"type": "issue"
},
{
"action": "created",
"author": "samphilipd",
"comment_id": 292905540,
"datetime": 1491818629000,
"text": "@piotrmurach Should this also have unit specs?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "piotrmurach",
"comment_id": 292929908,
"datetime": 1491825912000,
"text": "I would add unit tests as well, they tend to catch different kind of bugs related to the parsing of arguments etc... \r\n\r\nAnother thing that I thought I will do is to add you as collaborator to my `github_api_test` repository which I use for recording cassettes. It's a safe sandbox that I think it would be good for feature tests to us this repo to help with future maintenance.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samphilipd",
"comment_id": 292941219,
"datetime": 1491829003000,
"text": "@piotrmurach unit tests added.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samphilipd",
"comment_id": 293198880,
"datetime": 1491901990000,
"text": "@piotrmurach ready for merge",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "piotrmurach",
"comment_id": 293232148,
"datetime": 1491911107000,
"text": "Will merge later today.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/11013852)\n\nCoverage decreased (-1.4%) to 95.056% when pulling **cf34604650d46dd4b8dc00c6bc6439da4f72b858 on samphilipd:projects_columns** into **3eed18eff3becd33878d97d0a414c87ec7c41ec9 on piotrmurach:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *samphilipd*:",
"text": "@piotrmurach Should this also have unit specs?"
}
},
{
"bot": "[](https://coveralls.io/builds/11015863)\n\nCoverage decreased (-1.2%) to 95.287% when pulling **50f604f0dd871076063b03ea4e80cff0ec278aba on samphilipd:projects_columns** into **3eed18eff3becd33878d97d0a414c87ec7c41ec9 on piotrmurach:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *samphilipd*:",
"text": "@piotrmurach unit tests added."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *samphilipd*:",
"text": "@piotrmurach Should this also have unit specs?"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *samphilipd*:",
"text": "@piotrmurach unit tests added."
}
}
] |
[
{
"action": "opened",
"author": "aschwaighofer",
"comment_id": null,
"datetime": 1505245707000,
"text": "And add builtins for the added runtime functions (assign-take, assign-copy).\r\n\r\nrdar://27412867\r\nSR-3376",
"title": "Use array copy runtime implementation instead of the array value witnesses",
"type": "issue"
},
{
"action": "created",
"author": "aschwaighofer",
"comment_id": 328964772,
"datetime": 1505245728000,
"text": "@swift-ci Please smoke test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aschwaighofer",
"comment_id": 328967233,
"datetime": 1505246289000,
"text": "@swift-ci Please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aschwaighofer",
"comment_id": 328990162,
"datetime": 1505251850000,
"text": "@swift-ci Please benchmark",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rjmccall",
"comment_id": 329216231,
"datetime": 1505318714000,
"text": "That seems like a tolerable set of regressions in exchange for dropping three value witnesses. Awesome!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jckarter",
"comment_id": 329220657,
"datetime": 1505319636000,
"text": "Are we still able to specialize when the type of the array element being copied/moved is known?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eeckstein",
"comment_id": 329220800,
"datetime": 1505319672000,
"text": "great work!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Build comment file: \n--------------\n\n### Optimized (O) \n\n\n<details open>\n <summary>Regression (12)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nCalculator | 30 | 35 | +16.7% | **0.86x** \nStringEqualPointerComparison | 244 | 272 | +11.5% | **0.90x** \nArrayAppendStrings | 13647 | 15103 | +10.7% | **0.90x** \nArrayAppendLatin1 | 39814 | 43503 | +9.3% | **0.92x (?)** \nObjectiveCBridgeStubNSDateRefAccess | 312 | 338 | +8.3% | **0.92x** \nDropLastSequence | 613 | 660 | +7.7% | **0.93x** \nRangeAssignment | 346 | 372 | +7.5% | **0.93x** \nDropLastSequenceLazy | 613 | 659 | +7.5% | **0.93x** \nPrefixWhileSequence | 342 | 363 | +6.1% | **0.94x (?)** \nSetExclusiveOr_OfObjects | 7977 | 8422 | +5.6% | **0.95x** \nPrefixCountableRangeLazy | 18 | 19 | +5.6% | **0.95x** \nSetUnion_OfObjects | 6635 | 6988 | +5.3% | **0.95x** \n\n</details>\n\n<details >\n <summary>Improvement (8)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nPopFrontUnsafePointer | 9472 | 5765 | -39.1% | **1.64x** \nSim2DArray | 450 | 348 | -22.7% | **1.29x** \nSetExclusiveOr | 3153 | 2792 | -11.4% | **1.13x** \nMapReduceString | 104 | 93 | -10.6% | **1.12x** \nMapReduceLazyCollection | 13 | 12 | -7.7% | **1.08x** \nBitCount | 144 | 133 | -7.6% | **1.08x (?)** \nArrayAppendLazyMap | 989 | 925 | -6.5% | **1.07x** \nSetIsSubsetOf_OfObjects | 388 | 363 | -6.4% | **1.07x** \n\n</details>\n\n<details >\n <summary>No Changes (307)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nAngryPhonebook | 2946 | 2941 | -0.2% | 1.00x (?) \nAnyHashableWithAClass | 68860 | 67524 | -1.9% | 1.02x \nArray2D | 1946 | 1946 | +0.0% | 1.00x \nArrayAppend | 1075 | 1075 | +0.0% | 1.00x \nArrayAppendArrayOfInt | 597 | 597 | +0.0% | 1.00x \nArrayAppendAscii | 18777 | 18718 | -0.3% | 1.00x (?) \nArrayAppendFromGeneric | 597 | 597 | +0.0% | 1.00x \nArrayAppendGenericStructs | 1228 | 1225 | -0.2% | 1.00x (?) \nArrayAppendOptionals | 1227 | 1240 | +1.1% | 0.99x (?) \nArrayAppendRepeatCol | 998 | 998 | +0.0% | 1.00x \nArrayAppendReserved | 841 | 844 | +0.4% | 1.00x (?) \nArrayAppendSequence | 911 | 912 | +0.1% | 1.00x (?) \nArrayAppendToFromGeneric | 597 | 597 | +0.0% | 1.00x \nArrayAppendToGeneric | 597 | 597 | +0.0% | 1.00x \nArrayAppendUTF16 | 39295 | 39011 | -0.7% | 1.01x (?) \nArrayInClass | 61 | 61 | +0.0% | 1.00x \nArrayLiteral | 0 | 0 | +0.0% | 1.00x \nArrayOfGenericPOD | 230 | 230 | +0.0% | 1.00x \nArrayOfGenericRef | 4011 | 3987 | -0.6% | 1.01x (?) \nArrayOfPOD | 176 | 176 | +0.0% | 1.00x \nArrayOfRef | 3890 | 3912 | +0.6% | 0.99x (?) \nArrayPlusEqualArrayOfInt | 596 | 597 | +0.2% | 1.00x (?) \nArrayPlusEqualFiveElementCollection | 4780 | 4798 | +0.4% | 1.00x (?) \nArrayPlusEqualSingleElementCollection | 1072 | 1074 | +0.2% | 1.00x (?) \nArrayPlusEqualThreeElements | 1647 | 1668 | +1.3% | 0.99x (?) \nArraySubscript | 1473 | 1486 | +0.9% | 0.99x (?) \nArrayValueProp | 6 | 6 | +0.0% | 1.00x \nArrayValueProp2 | 6 | 6 | +0.0% | 1.00x \nArrayValueProp3 | 6 | 6 | +0.0% | 1.00x \nArrayValueProp4 | 6 | 6 | +0.0% | 1.00x \nByteSwap | 118 | 115 | -2.5% | 1.03x \nCStringLongAscii | 4727 | 4693 | -0.7% | 1.01x (?) \nCStringLongNonAscii | 2217 | 2173 | -2.0% | 1.02x (?) \nCStringShortAscii | 4742 | 4789 | +1.0% | 0.99x (?) \nCaptureProp | 4479 | 4616 | +3.1% | 0.97x \nCharIndexing_ascii_unicodeScalars | 13841 | 13824 | -0.1% | 1.00x (?) \nCharIndexing_ascii_unicodeScalars_Backwards | 11265 | 11249 | -0.1% | 1.00x \nCharIndexing_chinese_unicodeScalars | 10493 | 10483 | -0.1% | 1.00x (?) \nCharIndexing_chinese_unicodeScalars_Backwards | 8537 | 8530 | -0.1% | 1.00x (?) \nCharIndexing_japanese_unicodeScalars | 16555 | 16552 | -0.0% | 1.00x (?) \nCharIndexing_japanese_unicodeScalars_Backwards | 13474 | 13454 | -0.1% | 1.00x \nCharIndexing_korean_unicodeScalars | 13420 | 13415 | -0.0% | 1.00x (?) \nCharIndexing_korean_unicodeScalars_Backwards | 10928 | 10917 | -0.1% | 1.00x (?) \nCharIndexing_punctuatedJapanese_unicodeScalars | 2539 | 2531 | -0.3% | 1.00x (?) \nCharIndexing_punctuatedJapanese_unicodeScalars_Backwards | 2101 | 2081 | -1.0% | 1.01x \nCharIndexing_punctuated_unicodeScalars | 3174 | 3159 | -0.5% | 1.00x (?) \nCharIndexing_punctuated_unicodeScalars_Backwards | 2602 | 2597 | -0.2% | 1.00x \nCharIndexing_russian_unicodeScalars | 11536 | 11525 | -0.1% | 1.00x \nCharIndexing_russian_unicodeScalars_Backwards | 9396 | 9380 | -0.2% | 1.00x (?) \nCharIndexing_tweet_unicodeScalars | 27232 | 27234 | +0.0% | 1.00x (?) \nCharIndexing_tweet_unicodeScalars_Backwards | 22189 | 22166 | -0.1% | 1.00x (?) \nCharIndexing_utf16_unicodeScalars | 83796 | 83843 | +0.1% | 1.00x (?) \nCharIndexing_utf16_unicodeScalars_Backwards | 73801 | 73804 | +0.0% | 1.00x (?) \nCharIteration_ascii_unicodeScalars | 15423 | 15596 | +1.1% | 0.99x \nCharIteration_ascii_unicodeScalars_Backwards | 16574 | 16177 | -2.4% | 1.02x (?) \nCharIteration_chinese_unicodeScalars | 11687 | 11815 | +1.1% | 0.99x \nCharIteration_chinese_unicodeScalars_Backwards | 12548 | 12248 | -2.4% | 1.02x \nCharIteration_japanese_unicodeScalars | 18458 | 18687 | +1.2% | 0.99x \nCharIteration_japanese_unicodeScalars_Backwards | 19843 | 19367 | -2.4% | 1.02x \nCharIteration_korean_unicodeScalars | 14959 | 15126 | +1.1% | 0.99x \nCharIteration_korean_unicodeScalars_Backwards | 16070 | 15684 | -2.4% | 1.02x \nCharIteration_punctuatedJapanese_unicodeScalars | 2798 | 2831 | +1.2% | 0.99x \nCharIteration_punctuatedJapanese_unicodeScalars_Backwards | 2988 | 2919 | -2.3% | 1.02x \nCharIteration_punctuated_unicodeScalars | 3504 | 3546 | +1.2% | 0.99x (?) \nCharIteration_punctuated_unicodeScalars_Backwards | 3743 | 3655 | -2.4% | 1.02x \nCharIteration_russian_unicodeScalars | 12864 | 13000 | +1.1% | 0.99x \nCharIteration_russian_unicodeScalars_Backwards | 13806 | 13476 | -2.4% | 1.02x (?) \nCharIteration_tweet_unicodeScalars | 30406 | 30743 | +1.1% | 0.99x \nCharIteration_tweet_unicodeScalars_Backwards | 32767 | 31954 | -2.5% | 1.03x \nCharIteration_utf16_unicodeScalars | 81361 | 78680 | -3.3% | 1.03x \nCharIteration_utf16_unicodeScalars_Backwards | 113090 | 112863 | -0.2% | 1.00x (?) \nCharacterLiteralsLarge | 6099 | 6097 | -0.0% | 1.00x (?) \nCharacterLiteralsSmall | 403 | 403 | +0.0% | 1.00x \nChars | 426 | 427 | +0.2% | 1.00x (?) \nClassArrayGetter | 13 | 13 | +0.0% | 1.00x \nDeadArray | 186 | 186 | +0.0% | 1.00x \nDictionary | 553 | 566 | +2.4% | 0.98x \nDictionary2 | 1826 | 1834 | +0.4% | 1.00x (?) \nDictionary2OfObjects | 3311 | 3333 | +0.7% | 0.99x (?) \nDictionary3 | 457 | 456 | -0.2% | 1.00x (?) \nDictionary3OfObjects | 892 | 889 | -0.3% | 1.00x (?) \nDictionaryBridge | 2550 | 2561 | +0.4% | 1.00x (?) \nDictionaryGroup | 276 | 275 | -0.4% | 1.00x (?) \nDictionaryGroupOfObjects | 1789 | 1799 | +0.6% | 0.99x \nDictionaryLiteral | 1533 | 1528 | -0.3% | 1.00x (?) \nDictionaryOfObjects | 2331 | 2351 | +0.9% | 0.99x (?) \nDictionaryRemove | 2444 | 2498 | +2.2% | 0.98x \nDictionaryRemoveOfObjects | 23208 | 23878 | +2.9% | 0.97x \nDictionarySwap | 414 | 415 | +0.2% | 1.00x (?) \nDictionarySwapOfObjects | 7400 | 7412 | +0.2% | 1.00x (?) \nDropFirstAnyCollection | 55 | 55 | +0.0% | 1.00x \nDropFirstAnyCollectionLazy | 75440 | 76146 | +0.9% | 0.99x (?) \nDropFirstAnySeqCRangeIter | 28606 | 28169 | -1.5% | 1.02x (?) \nDropFirstAnySeqCRangeIterLazy | 28569 | 28183 | -1.4% | 1.01x (?) \nDropFirstAnySeqCntRange | 50 | 50 | +0.0% | 1.00x \nDropFirstAnySeqCntRangeLazy | 50 | 50 | +0.0% | 1.00x \nDropFirstAnySequence | 6260 | 6217 | -0.7% | 1.01x (?) \nDropFirstAnySequenceLazy | 6260 | 6239 | -0.3% | 1.00x (?) \nDropFirstArray | 30 | 30 | +0.0% | 1.00x \nDropFirstArrayLazy | 30 | 30 | +0.0% | 1.00x \nDropFirstCountableRange | 18 | 18 | +0.0% | 1.00x \nDropFirstCountableRangeLazy | 18 | 18 | +0.0% | 1.00x \nDropFirstSequence | 2093 | 2093 | +0.0% | 1.00x \nDropFirstSequenceLazy | 2118 | 2118 | +0.0% | 1.00x \nDropLastAnyCollection | 21 | 21 | +0.0% | 1.00x \nDropLastAnyCollectionLazy | 25122 | 25371 | +1.0% | 0.99x (?) \nDropLastAnySeqCRangeIter | 4727 | 4840 | +2.4% | 0.98x \nDropLastAnySeqCRangeIterLazy | 4728 | 4738 | +0.2% | 1.00x (?) \nDropLastAnySeqCntRange | 16 | 16 | +0.0% | 1.00x \nDropLastAnySeqCntRangeLazy | 16 | 16 | +0.0% | 1.00x \nDropLastAnySequence | 6762 | 6785 | +0.3% | 1.00x \nDropLastAnySequenceLazy | 6706 | 6709 | +0.0% | 1.00x (?) \nDropLastArray | 10 | 10 | +0.0% | 1.00x \nDropLastArrayLazy | 10 | 10 | +0.0% | 1.00x \nDropLastCountableRange | 6 | 6 | +0.0% | 1.00x \nDropLastCountableRangeLazy | 6 | 6 | +0.0% | 1.00x \nDropWhileAnyCollection | 68 | 68 | +0.0% | 1.00x \nDropWhileAnyCollectionLazy | 90 | 90 | +0.0% | 1.00x \nDropWhileAnySeqCRangeIter | 23398 | 22675 | -3.1% | 1.03x \nDropWhileAnySeqCRangeIterLazy | 88 | 89 | +1.1% | 0.99x \nDropWhileAnySeqCntRange | 63 | 63 | +0.0% | 1.00x \nDropWhileAnySeqCntRangeLazy | 88 | 89 | +1.1% | 0.99x \nDropWhileAnySequence | 7287 | 7275 | -0.2% | 1.00x (?) \nDropWhileAnySequenceLazy | 2007 | 2007 | +0.0% | 1.00x \nDropWhileArray | 43 | 43 | +0.0% | 1.00x \nDropWhileArrayLazy | 78 | 78 | +0.0% | 1.00x \nDropWhileCountableRange | 19 | 19 | +0.0% | 1.00x \nDropWhileCountableRangeLazy | 70 | 70 | +0.0% | 1.00x \nDropWhileSequence | 1553 | 1553 | +0.0% | 1.00x \nDropWhileSequenceLazy | 46 | 47 | +2.2% | 0.98x (?) \nEqualStringSubstring | 387 | 384 | -0.8% | 1.01x \nEqualSubstringString | 385 | 384 | -0.3% | 1.00x (?) \nEqualSubstringSubstring | 388 | 386 | -0.5% | 1.01x (?) \nEqualSubstringSubstringGenericEquatable | 386 | 386 | +0.0% | 1.00x \nErrorHandling | 2024 | 2065 | +2.0% | 0.98x (?) \nFilterEvenUsingReduce | 1284 | 1293 | +0.7% | 0.99x (?) \nFilterEvenUsingReduceInto | 145 | 146 | +0.7% | 0.99x (?) \nFrequenciesUsingReduce | 7177 | 7431 | +3.5% | 0.97x (?) \nFrequenciesUsingReduceInto | 4106 | 4114 | +0.2% | 1.00x (?) \nHanoi | 3390 | 3486 | +2.8% | 0.97x \nHashTest | 1639 | 1627 | -0.7% | 1.01x (?) \nHistogram | 285 | 290 | +1.8% | 0.98x \nIntegrate | 262 | 262 | +0.0% | 1.00x \nIterateData | 759 | 758 | -0.1% | 1.00x \nJoin | 368 | 377 | +2.4% | 0.98x (?) \nLazilyFilteredArrays | 64812 | 65747 | +1.4% | 0.99x (?) \nLazilyFilteredRange | 3755 | 3617 | -3.7% | 1.04x \nLessSubstringSubstring | 385 | 383 | -0.5% | 1.01x (?) \nLessSubstringSubstringGenericComparable | 385 | 384 | -0.3% | 1.00x (?) \nLinkedList | 7110 | 7111 | +0.0% | 1.00x (?) \nMapReduce | 360 | 360 | +0.0% | 1.00x \nMapReduceAnyCollection | 362 | 363 | +0.3% | 1.00x (?) \nMapReduceAnyCollectionShort | 2070 | 2099 | +1.4% | 0.99x (?) \nMapReduceClass | 3066 | 3082 | +0.5% | 0.99x \nMapReduceClassShort | 4524 | 4564 | +0.9% | 0.99x \nMapReduceLazyCollectionShort | 36 | 36 | +0.0% | 1.00x \nMapReduceLazySequence | 90 | 90 | +0.0% | 1.00x \nMapReduceSequence | 438 | 442 | +0.9% | 0.99x (?) \nMapReduceShort | 1957 | 1980 | +1.2% | 0.99x (?) \nMapReduceShortString | 21 | 21 | +0.0% | 1.00x \nMemset | 234 | 234 | +0.0% | 1.00x \nMonteCarloE | 10335 | 10380 | +0.4% | 1.00x \nMonteCarloPi | 43930 | 43971 | +0.1% | 1.00x \nNSDictionaryCastToSwift | 5457 | 5433 | -0.4% | 1.00x (?) \nNSError | 290 | 290 | +0.0% | 1.00x \nNSStringConversion | 351 | 356 | +1.4% | 0.99x (?) \nNopDeinit | 22892 | 22888 | -0.0% | 1.00x (?) \nObjectAllocation | 178 | 179 | +0.6% | 0.99x (?) \nObjectiveCBridgeFromNSArrayAnyObject | 22594 | 22487 | -0.5% | 1.00x (?) \nObjectiveCBridgeFromNSArrayAnyObjectForced | 3480 | 3453 | -0.8% | 1.01x (?) \nObjectiveCBridgeFromNSArrayAnyObjectToString | 39336 | 39142 | -0.5% | 1.00x (?) \nObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 33567 | 33467 | -0.3% | 1.00x (?) \nObjectiveCBridgeFromNSDictionaryAnyObject | 118737 | 118503 | -0.2% | 1.00x (?) \nObjectiveCBridgeFromNSDictionaryAnyObjectForced | 5171 | 5089 | -1.6% | 1.02x (?) \nObjectiveCBridgeFromNSDictionaryAnyObjectToString | 93507 | 90418 | -3.3% | 1.03x (?) \nObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 99730 | 100260 | +0.5% | 0.99x (?) \nObjectiveCBridgeFromNSSetAnyObject | 64646 | 64503 | -0.2% | 1.00x (?) \nObjectiveCBridgeFromNSSetAnyObjectForced | 4235 | 4266 | +0.7% | 0.99x (?) \nObjectiveCBridgeFromNSSetAnyObjectToString | 67495 | 67650 | +0.2% | 1.00x (?) \nObjectiveCBridgeFromNSSetAnyObjectToStringForced | 68572 | 70861 | +3.3% | 0.97x (?) \nObjectiveCBridgeFromNSString | 988 | 986 | -0.2% | 1.00x (?) \nObjectiveCBridgeFromNSStringForced | 1865 | 1817 | -2.6% | 1.03x \nObjectiveCBridgeStubDataAppend | 3641 | 3574 | -1.8% | 1.02x (?) \nObjectiveCBridgeStubDateAccess | 181 | 181 | +0.0% | 1.00x \nObjectiveCBridgeStubDateMutation | 272 | 272 | +0.0% | 1.00x \nObjectiveCBridgeStubFromArrayOfNSString | 25054 | 25077 | +0.1% | 1.00x (?) \nObjectiveCBridgeStubFromNSDate | 3600 | 3544 | -1.6% | 1.02x \nObjectiveCBridgeStubFromNSDateRef | 4007 | 4062 | +1.4% | 0.99x \nObjectiveCBridgeStubFromNSString | 521 | 531 | +1.9% | 0.98x (?) \nObjectiveCBridgeStubFromNSStringRef | 143 | 143 | +0.0% | 1.00x \nObjectiveCBridgeStubNSDataAppend | 2376 | 2417 | +1.7% | 0.98x (?) \nObjectiveCBridgeStubNSDateMutationRef | 12474 | 12140 | -2.7% | 1.03x (?) \nObjectiveCBridgeStubToArrayOfNSString | 28573 | 29223 | +2.3% | 0.98x (?) \nObjectiveCBridgeStubToNSDate | 13783 | 14378 | +4.3% | 0.96x (?) \nObjectiveCBridgeStubToNSDateRef | 3276 | 3254 | -0.7% | 1.01x (?) \nObjectiveCBridgeStubToNSString | 1484 | 1484 | +0.0% | 1.00x \nObjectiveCBridgeStubToNSStringRef | 109 | 108 | -0.9% | 1.01x (?) \nObjectiveCBridgeStubURLAppendPath | 220626 | 222165 | +0.7% | 0.99x (?) \nObjectiveCBridgeStubURLAppendPathRef | 220933 | 220519 | -0.2% | 1.00x (?) \nObjectiveCBridgeToNSArray | 29166 | 29586 | +1.4% | 0.99x \nObjectiveCBridgeToNSDictionary | 45038 | 45322 | +0.6% | 0.99x (?) \nObjectiveCBridgeToNSSet | 39259 | 39603 | +0.9% | 0.99x (?) \nObjectiveCBridgeToNSString | 1271 | 1272 | +0.1% | 1.00x (?) \nObserverClosure | 2281 | 2286 | +0.2% | 1.00x (?) \nObserverForwarderStruct | 1124 | 1151 | +2.4% | 0.98x (?) \nObserverPartiallyAppliedMethod | 3772 | 3784 | +0.3% | 1.00x (?) \nObserverUnappliedMethod | 2653 | 2715 | +2.3% | 0.98x (?) \nOpenClose | 3 | 3 | +0.0% | 1.00x \nPhonebook | 5976 | 5941 | -0.6% | 1.01x \nPolymorphicCalls | 17 | 17 | +0.0% | 1.00x \nPopFrontArray | 1218 | 1226 | +0.7% | 0.99x (?) \nPopFrontArrayGeneric | 1216 | 1227 | +0.9% | 0.99x \nPrefixAnyCollection | 55 | 55 | +0.0% | 1.00x \nPrefixAnyCollectionLazy | 75329 | 76101 | +1.0% | 0.99x (?) \nPrefixAnySeqCRangeIter | 22554 | 22103 | -2.0% | 1.02x \nPrefixAnySeqCRangeIterLazy | 22558 | 22101 | -2.0% | 1.02x (?) \nPrefixAnySeqCntRange | 50 | 50 | +0.0% | 1.00x \nPrefixAnySeqCntRangeLazy | 50 | 50 | +0.0% | 1.00x \nPrefixAnySequence | 5551 | 5408 | -2.6% | 1.03x (?) \nPrefixAnySequenceLazy | 5513 | 5408 | -1.9% | 1.02x (?) \nPrefixArray | 30 | 30 | +0.0% | 1.00x \nPrefixArrayLazy | 30 | 30 | +0.0% | 1.00x \nPrefixCountableRange | 18 | 18 | +0.0% | 1.00x \nPrefixSequence | 1607 | 1571 | -2.2% | 1.02x \nPrefixSequenceLazy | 1515 | 1515 | +0.0% | 1.00x \nPrefixWhileAnyCollection | 93 | 93 | +0.0% | 1.00x \nPrefixWhileAnyCollectionLazy | 66 | 66 | +0.0% | 1.00x \nPrefixWhileAnySeqCRangeIter | 12895 | 12919 | +0.2% | 1.00x (?) \nPrefixWhileAnySeqCRangeIterLazy | 66 | 66 | +0.0% | 1.00x \nPrefixWhileAnySeqCntRange | 88 | 88 | +0.0% | 1.00x \nPrefixWhileAnySeqCntRangeLazy | 66 | 66 | +0.0% | 1.00x \nPrefixWhileAnySequence | 14350 | 14549 | +1.4% | 0.99x (?) \nPrefixWhileAnySequenceLazy | 1492 | 1492 | +0.0% | 1.00x \nPrefixWhileArray | 68 | 68 | +0.0% | 1.00x \nPrefixWhileArrayLazy | 37 | 37 | +0.0% | 1.00x \nPrefixWhileCountableRange | 29 | 29 | +0.0% | 1.00x \nPrefixWhileCountableRangeLazy | 18 | 18 | +0.0% | 1.00x \nPrefixWhileSequenceLazy | 28 | 28 | +0.0% | 1.00x \nPrims | 761 | 784 | +3.0% | 0.97x (?) \nProtocolDispatch | 2728 | 2731 | +0.1% | 1.00x (?) \nProtocolDispatch2 | 161 | 160 | -0.6% | 1.01x (?) \nRC4 | 157 | 157 | +0.0% | 1.00x \nRGBHistogram | 2291 | 2244 | -2.1% | 1.02x (?) \nRGBHistogramOfObjects | 23387 | 23519 | +0.6% | 0.99x (?) \nRecursiveOwnedParameter | 2328 | 2326 | -0.1% | 1.00x (?) \nReversedArray | 46 | 45 | -2.2% | 1.02x (?) \nReversedBidirectional | 29185 | 29308 | +0.4% | 1.00x (?) \nReversedDictionary | 108 | 108 | +0.0% | 1.00x \nSetIntersect | 266 | 264 | -0.8% | 1.01x (?) \nSetIntersect_OfObjects | 1726 | 1724 | -0.1% | 1.00x (?) \nSetIsSubsetOf | 321 | 321 | +0.0% | 1.00x \nSetUnion | 2732 | 2670 | -2.3% | 1.02x (?) \nSevenBoom | 1463 | 1460 | -0.2% | 1.00x (?) \nSortLargeExistentials | 8445 | 8553 | +1.3% | 0.99x \nSortLettersInPlace | 1144 | 1146 | +0.2% | 1.00x (?) \nSortSortedStrings | 849 | 829 | -2.4% | 1.02x \nSortStrings | 1640 | 1611 | -1.8% | 1.02x (?) \nSortStringsUnicode | 7821 | 7692 | -1.6% | 1.02x \nStackPromo | 22061 | 22535 | +2.1% | 0.98x \nStaticArray | 5 | 5 | +0.0% | 1.00x \nStrComplexWalk | 1653 | 1653 | +0.0% | 1.00x \nStrToInt | 1814 | 1865 | +2.8% | 0.97x \nStringAdder | 3517 | 3526 | +0.3% | 1.00x (?) \nStringBuilder | 1021 | 1018 | -0.3% | 1.00x (?) \nStringBuilderLong | 931 | 934 | +0.3% | 1.00x (?) \nStringEdits | 113919 | 114890 | +0.9% | 0.99x \nStringFromLongWholeSubstring | 184 | 184 | +0.0% | 1.00x \nStringFromLongWholeSubstringGeneric | 23 | 23 | +0.0% | 1.00x \nStringHasPrefix | 9 | 9 | +0.0% | 1.00x \nStringHasPrefixUnicode | 15301 | 14750 | -3.6% | 1.04x \nStringHasSuffix | 9 | 9 | +0.0% | 1.00x \nStringHasSuffixUnicode | 61605 | 61506 | -0.2% | 1.00x \nStringInterpolation | 10791 | 10695 | -0.9% | 1.01x (?) \nStringMatch | 7327 | 7012 | -4.3% | 1.04x \nStringUTF16Builder | 1892 | 1909 | +0.9% | 0.99x (?) \nStringWalk | 1485 | 1501 | +1.1% | 0.99x \nStringWithCString | 66101 | 66825 | +1.1% | 0.99x \nSubstringComparable | 1520 | 1501 | -1.2% | 1.01x \nSubstringEqualString | 1367 | 1359 | -0.6% | 1.01x \nSubstringEquatable | 3544 | 3512 | -0.9% | 1.01x (?) \nSubstringFromLongString | 10 | 10 | +0.0% | 1.00x \nSubstringFromLongStringGeneric | 62 | 62 | +0.0% | 1.00x \nSuffixAnyCollection | 21 | 21 | +0.0% | 1.00x \nSuffixAnyCollectionLazy | 25153 | 25375 | +0.9% | 0.99x (?) \nSuffixAnySeqCRangeIter | 5056 | 5058 | +0.0% | 1.00x (?) \nSuffixAnySeqCRangeIterLazy | 5056 | 5057 | +0.0% | 1.00x (?) \nSuffixAnySeqCntRange | 16 | 16 | +0.0% | 1.00x \nSuffixAnySeqCntRangeLazy | 16 | 16 | +0.0% | 1.00x \nSuffixAnySequence | 6867 | 6852 | -0.2% | 1.00x \nSuffixAnySequenceLazy | 6748 | 6757 | +0.1% | 1.00x \nSuffixArray | 10 | 10 | +0.0% | 1.00x \nSuffixArrayLazy | 10 | 10 | +0.0% | 1.00x \nSuffixCountableRange | 6 | 6 | +0.0% | 1.00x \nSuffixCountableRangeLazy | 6 | 6 | +0.0% | 1.00x \nSuffixSequence | 4677 | 4693 | +0.3% | 1.00x \nSuffixSequenceLazy | 4677 | 4667 | -0.2% | 1.00x (?) \nSumUsingReduce | 97 | 97 | +0.0% | 1.00x \nSumUsingReduceInto | 97 | 97 | +0.0% | 1.00x \nSuperChars | 81402 | 80845 | -0.7% | 1.01x (?) \nTwoSum | 952 | 963 | +1.2% | 0.99x (?) \nTypeFlood | 0 | 0 | +0.0% | 1.00x \nUTF8Decode | 254 | 254 | +0.0% | 1.00x \nWalsh | 403 | 400 | -0.7% | 1.01x (?) \nXorLoop | 347 | 347 | +0.0% | 1.00x \naccessGlobal | 3 | 3 | +0.0% | 1.00x \naccessInMatSet | 18 | 18 | +0.0% | 1.00x \naccessIndependent | 2 | 2 | +0.0% | 1.00x \n\n</details>\n\n### Unoptimized (Onone) \n\n\n<details open>\n <summary>Regression (4)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nArrayAppendStrings | 13588 | 15227 | +12.1% | **0.89x** \nDropWhileArrayLazy | 17537 | 19070 | +8.7% | **0.92x** \nTypeFlood | 152 | 163 | +7.2% | **0.93x (?)** \nDropWhileAnySeqCRangeIterLazy | 28764 | 30498 | +6.0% | **0.94x** \n\n</details>\n\n<details >\n <summary>Improvement (12)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nPopFrontUnsafePointer | 97092 | 7225 | -92.6% | **13.44x** \nObjectiveCBridgeStubFromNSDate | 4164 | 3827 | -8.1% | **1.09x** \nArrayAppend | 4237 | 3950 | -6.8% | **1.07x** \nObjectiveCBridgeFromNSDictionaryAnyObjectForced | 7767 | 7302 | -6.0% | **1.06x (?)** \nStringWalk | 12427 | 11722 | -5.7% | **1.06x** \nCharIndexing_japanese_unicodeScalars | 596655 | 566043 | -5.1% | **1.05x** \nCharIndexing_tweet_unicodeScalars | 981981 | 932090 | -5.1% | **1.05x** \nCharIndexing_russian_unicodeScalars | 412976 | 392514 | -5.0% | **1.05x** \nObjectiveCBridgeStubDateMutation | 516 | 491 | -4.8% | **1.05x** \nCharIndexing_korean_unicodeScalars | 483286 | 459947 | -4.8% | **1.05x** \nCharIndexing_russian_unicodeScalars_Backwards | 450936 | 429281 | -4.8% | **1.05x (?)** \nStringHasSuffix | 1899 | 1808 | -4.8% | **1.05x** \n\n</details>\n\n<details >\n <summary>No Changes (311)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nAngryPhonebook | 5055 | 5038 | -0.3% | 1.00x (?) \nAnyHashableWithAClass | 86692 | 84992 | -2.0% | 1.02x \nArray2D | 639593 | 634460 | -0.8% | 1.01x \nArrayAppendArrayOfInt | 656 | 658 | +0.3% | 1.00x \nArrayAppendAscii | 53276 | 53457 | +0.3% | 1.00x \nArrayAppendFromGeneric | 658 | 660 | +0.3% | 1.00x (?) \nArrayAppendGenericStructs | 1304 | 1297 | -0.5% | 1.01x (?) \nArrayAppendLatin1 | 81648 | 81829 | +0.2% | 1.00x (?) \nArrayAppendLazyMap | 230025 | 228221 | -0.8% | 1.01x (?) \nArrayAppendOptionals | 1295 | 1336 | +3.2% | 0.97x \nArrayAppendRepeatCol | 234811 | 236359 | +0.7% | 0.99x (?) \nArrayAppendReserved | 3903 | 4014 | +2.8% | 0.97x \nArrayAppendSequence | 79047 | 79114 | +0.1% | 1.00x (?) \nArrayAppendToFromGeneric | 658 | 659 | +0.2% | 1.00x (?) \nArrayAppendToGeneric | 660 | 660 | +0.0% | 1.00x \nArrayAppendUTF16 | 78198 | 78871 | +0.9% | 0.99x \nArrayInClass | 6698 | 6746 | +0.7% | 0.99x (?) \nArrayLiteral | 1749 | 1743 | -0.3% | 1.00x \nArrayOfGenericPOD | 1266 | 1211 | -4.3% | 1.05x \nArrayOfGenericRef | 10113 | 10004 | -1.1% | 1.01x \nArrayOfPOD | 714 | 712 | -0.3% | 1.00x (?) \nArrayOfRef | 9246 | 9203 | -0.5% | 1.00x (?) \nArrayPlusEqualArrayOfInt | 657 | 657 | +0.0% | 1.00x \nArrayPlusEqualFiveElementCollection | 311721 | 312699 | +0.3% | 1.00x (?) \nArrayPlusEqualSingleElementCollection | 303323 | 310268 | +2.3% | 0.98x \nArrayPlusEqualThreeElements | 11245 | 11229 | -0.1% | 1.00x (?) \nArraySubscript | 4428 | 4434 | +0.1% | 1.00x (?) \nArrayValueProp | 3564 | 3576 | +0.3% | 1.00x \nArrayValueProp2 | 18922 | 18929 | +0.0% | 1.00x (?) \nArrayValueProp3 | 4026 | 3996 | -0.7% | 1.01x (?) \nArrayValueProp4 | 3960 | 3992 | +0.8% | 0.99x (?) \nBitCount | 1696 | 1750 | +3.2% | 0.97x \nByteSwap | 4037 | 4008 | -0.7% | 1.01x (?) \nCStringLongAscii | 4755 | 4756 | +0.0% | 1.00x (?) \nCStringLongNonAscii | 2404 | 2440 | +1.5% | 0.99x \nCStringShortAscii | 8809 | 8779 | -0.3% | 1.00x (?) \nCalculator | 1164 | 1187 | +2.0% | 0.98x \nCaptureProp | 124234 | 126851 | +2.1% | 0.98x \nCharIndexing_ascii_unicodeScalars | 494979 | 472013 | -4.6% | 1.05x \nCharIndexing_ascii_unicodeScalars_Backwards | 541684 | 528746 | -2.4% | 1.02x \nCharIndexing_chinese_unicodeScalars | 372325 | 358051 | -3.8% | 1.04x \nCharIndexing_chinese_unicodeScalars_Backwards | 399727 | 391019 | -2.2% | 1.02x (?) \nCharIndexing_japanese_unicodeScalars_Backwards | 637980 | 621880 | -2.5% | 1.03x (?) \nCharIndexing_korean_unicodeScalars_Backwards | 525037 | 512755 | -2.3% | 1.02x (?) \nCharIndexing_punctuatedJapanese_unicodeScalars | 85866 | 82545 | -3.9% | 1.04x \nCharIndexing_punctuatedJapanese_unicodeScalars_Backwards | 93635 | 91706 | -2.1% | 1.02x (?) \nCharIndexing_punctuated_unicodeScalars | 108261 | 104362 | -3.6% | 1.04x \nCharIndexing_punctuated_unicodeScalars_Backwards | 119628 | 116551 | -2.6% | 1.03x (?) \nCharIndexing_tweet_unicodeScalars_Backwards | 1050387 | 1024962 | -2.4% | 1.02x (?) \nCharIndexing_utf16_unicodeScalars | 552523 | 528006 | -4.4% | 1.05x \nCharIndexing_utf16_unicodeScalars_Backwards | 588863 | 582938 | -1.0% | 1.01x \nCharIteration_ascii_unicodeScalars | 186032 | 187219 | +0.6% | 0.99x \nCharIteration_ascii_unicodeScalars_Backwards | 325988 | 326175 | +0.1% | 1.00x (?) \nCharIteration_chinese_unicodeScalars | 140786 | 141873 | +0.8% | 0.99x \nCharIteration_chinese_unicodeScalars_Backwards | 245644 | 246269 | +0.3% | 1.00x (?) \nCharIteration_japanese_unicodeScalars | 223070 | 224777 | +0.8% | 0.99x \nCharIteration_japanese_unicodeScalars_Backwards | 390615 | 390868 | +0.1% | 1.00x (?) \nCharIteration_korean_unicodeScalars | 180647 | 182508 | +1.0% | 0.99x \nCharIteration_korean_unicodeScalars_Backwards | 315885 | 316616 | +0.2% | 1.00x (?) \nCharIteration_punctuatedJapanese_unicodeScalars | 33095 | 33372 | +0.8% | 0.99x \nCharIteration_punctuatedJapanese_unicodeScalars_Backwards | 57036 | 56837 | -0.3% | 1.00x (?) \nCharIteration_punctuated_unicodeScalars | 41678 | 41930 | +0.6% | 0.99x \nCharIteration_punctuated_unicodeScalars_Backwards | 71842 | 71675 | -0.2% | 1.00x (?) \nCharIteration_russian_unicodeScalars | 155315 | 156571 | +0.8% | 0.99x \nCharIteration_russian_unicodeScalars_Backwards | 271432 | 271282 | -0.1% | 1.00x (?) \nCharIteration_tweet_unicodeScalars | 368343 | 371677 | +0.9% | 0.99x \nCharIteration_tweet_unicodeScalars_Backwards | 653024 | 645999 | -1.1% | 1.01x (?) \nCharIteration_utf16_unicodeScalars | 207741 | 208597 | +0.4% | 1.00x \nCharIteration_utf16_unicodeScalars_Backwards | 407945 | 407469 | -0.1% | 1.00x (?) \nCharacterLiteralsLarge | 6373 | 6436 | +1.0% | 0.99x (?) \nCharacterLiteralsSmall | 631 | 646 | +2.4% | 0.98x \nChars | 50715 | 50639 | -0.1% | 1.00x (?) \nClassArrayGetter | 1026 | 1025 | -0.1% | 1.00x \nDeadArray | 113736 | 114410 | +0.6% | 0.99x (?) \nDictionary | 3034 | 3030 | -0.1% | 1.00x (?) \nDictionary2 | 3461 | 3453 | -0.2% | 1.00x (?) \nDictionary2OfObjects | 6068 | 6041 | -0.4% | 1.00x (?) \nDictionary3 | 1298 | 1303 | +0.4% | 1.00x (?) \nDictionary3OfObjects | 2339 | 2328 | -0.5% | 1.00x (?) \nDictionaryBridge | 2643 | 2676 | +1.2% | 0.99x (?) \nDictionaryGroup | 5398 | 5462 | +1.2% | 0.99x \nDictionaryGroupOfObjects | 8301 | 8278 | -0.3% | 1.00x (?) \nDictionaryLiteral | 8719 | 8735 | +0.2% | 1.00x (?) \nDictionaryOfObjects | 6538 | 6536 | -0.0% | 1.00x (?) \nDictionaryRemove | 21410 | 21535 | +0.6% | 0.99x \nDictionaryRemoveOfObjects | 59539 | 59727 | +0.3% | 1.00x (?) \nDictionarySwap | 5336 | 5362 | +0.5% | 1.00x (?) \nDictionarySwapOfObjects | 23425 | 23303 | -0.5% | 1.01x (?) \nDropFirstAnyCollection | 20316 | 20403 | +0.4% | 1.00x \nDropFirstAnyCollectionLazy | 142223 | 144388 | +1.5% | 0.99x \nDropFirstAnySeqCRangeIter | 31115 | 31273 | +0.5% | 0.99x \nDropFirstAnySeqCRangeIterLazy | 30646 | 31297 | +2.1% | 0.98x \nDropFirstAnySeqCntRange | 20497 | 20414 | -0.4% | 1.00x (?) \nDropFirstAnySeqCntRangeLazy | 20352 | 20548 | +1.0% | 0.99x \nDropFirstAnySequence | 15839 | 15966 | +0.8% | 0.99x (?) \nDropFirstAnySequenceLazy | 15890 | 15873 | -0.1% | 1.00x \nDropFirstArray | 6325 | 6524 | +3.1% | 0.97x \nDropFirstArrayLazy | 45890 | 46181 | +0.6% | 0.99x (?) \nDropFirstCountableRange | 340 | 340 | +0.0% | 1.00x \nDropFirstCountableRangeLazy | 39712 | 40659 | +2.4% | 0.98x \nDropFirstSequence | 14747 | 14722 | -0.2% | 1.00x (?) \nDropFirstSequenceLazy | 14759 | 14799 | +0.3% | 1.00x \nDropLastAnyCollection | 6766 | 6827 | +0.9% | 0.99x \nDropLastAnyCollectionLazy | 47276 | 47151 | -0.3% | 1.00x (?) \nDropLastAnySeqCRangeIter | 47344 | 48079 | +1.6% | 0.98x \nDropLastAnySeqCRangeIterLazy | 47511 | 47670 | +0.3% | 1.00x (?) \nDropLastAnySeqCntRange | 6781 | 6815 | +0.5% | 1.00x \nDropLastAnySeqCntRangeLazy | 6740 | 6841 | +1.5% | 0.99x (?) \nDropLastAnySequence | 33871 | 34214 | +1.0% | 0.99x \nDropLastAnySequenceLazy | 33845 | 34246 | +1.2% | 0.99x \nDropLastArray | 2096 | 2169 | +3.5% | 0.97x \nDropLastArrayLazy | 15304 | 15415 | +0.7% | 0.99x (?) \nDropLastCountableRange | 118 | 118 | +0.0% | 1.00x \nDropLastCountableRangeLazy | 13479 | 13579 | +0.7% | 0.99x (?) \nDropLastSequence | 33401 | 33720 | +1.0% | 0.99x \nDropLastSequenceLazy | 34047 | 34164 | +0.3% | 1.00x \nDropWhileAnyCollection | 26460 | 26828 | +1.4% | 0.99x \nDropWhileAnyCollectionLazy | 28945 | 30288 | +4.6% | 0.96x \nDropWhileAnySeqCRangeIter | 32854 | 33665 | +2.5% | 0.98x \nDropWhileAnySeqCntRange | 26560 | 26864 | +1.1% | 0.99x \nDropWhileAnySeqCntRangeLazy | 28977 | 30355 | +4.8% | 0.95x \nDropWhileAnySequence | 18852 | 18795 | -0.3% | 1.00x (?) \nDropWhileAnySequenceLazy | 15193 | 15175 | -0.1% | 1.00x \nDropWhileArray | 10054 | 10326 | +2.7% | 0.97x \nDropWhileCountableRange | 6581 | 6629 | +0.7% | 0.99x \nDropWhileCountableRangeLazy | 27643 | 28365 | +2.6% | 0.97x \nDropWhileSequence | 17558 | 17630 | +0.4% | 1.00x (?) \nDropWhileSequenceLazy | 14543 | 14314 | -1.6% | 1.02x \nEqualStringSubstring | 678 | 676 | -0.3% | 1.00x (?) \nEqualSubstringString | 674 | 670 | -0.6% | 1.01x (?) \nEqualSubstringSubstring | 795 | 795 | +0.0% | 1.00x \nEqualSubstringSubstringGenericEquatable | 423 | 420 | -0.7% | 1.01x \nErrorHandling | 6871 | 6955 | +1.2% | 0.99x (?) \nFilterEvenUsingReduce | 4308 | 4319 | +0.3% | 1.00x (?) \nFilterEvenUsingReduceInto | 2510 | 2509 | -0.0% | 1.00x (?) \nFrequenciesUsingReduce | 16006 | 16410 | +2.5% | 0.98x \nFrequenciesUsingReduceInto | 9273 | 9334 | +0.7% | 0.99x (?) \nHanoi | 19447 | 19269 | -0.9% | 1.01x \nHashTest | 17132 | 17330 | +1.2% | 0.99x (?) \nHistogram | 9422 | 9230 | -2.0% | 1.02x (?) \nIntegrate | 675 | 677 | +0.3% | 1.00x \nIterateData | 13497 | 13482 | -0.1% | 1.00x (?) \nJoin | 1516 | 1501 | -1.0% | 1.01x \nLazilyFilteredArrays | 1752190 | 1758750 | +0.4% | 1.00x \nLazilyFilteredRange | 712272 | 720446 | +1.1% | 0.99x \nLessSubstringSubstring | 790 | 792 | +0.3% | 1.00x \nLessSubstringSubstringGenericComparable | 438 | 436 | -0.5% | 1.00x \nLinkedList | 40301 | 40349 | +0.1% | 1.00x \nMapReduce | 39337 | 38883 | -1.2% | 1.01x \nMapReduceAnyCollection | 39293 | 38858 | -1.1% | 1.01x \nMapReduceAnyCollectionShort | 51879 | 51766 | -0.2% | 1.00x (?) \nMapReduceClass | 44954 | 44184 | -1.7% | 1.02x \nMapReduceClassShort | 55910 | 55635 | -0.5% | 1.00x (?) \nMapReduceLazyCollection | 37383 | 36874 | -1.4% | 1.01x \nMapReduceLazyCollectionShort | 46449 | 46125 | -0.7% | 1.01x (?) \nMapReduceLazySequence | 30394 | 30891 | +1.6% | 0.98x \nMapReduceSequence | 46295 | 46201 | -0.2% | 1.00x (?) \nMapReduceShort | 51446 | 51285 | -0.3% | 1.00x (?) \nMapReduceShortString | 296 | 294 | -0.7% | 1.01x (?) \nMapReduceString | 2779 | 2728 | -1.8% | 1.02x (?) \nMemset | 44663 | 44664 | +0.0% | 1.00x (?) \nMonteCarloE | 140945 | 140871 | -0.1% | 1.00x (?) \nMonteCarloPi | 52649 | 52359 | -0.6% | 1.01x \nNSDictionaryCastToSwift | 6697 | 6689 | -0.1% | 1.00x (?) \nNSError | 703 | 703 | +0.0% | 1.00x \nNSStringConversion | 403 | 408 | +1.2% | 0.99x (?) \nNopDeinit | 168279 | 171479 | +1.9% | 0.98x (?) \nObjectAllocation | 1475 | 1478 | +0.2% | 1.00x (?) \nObjectiveCBridgeFromNSArrayAnyObject | 25157 | 24815 | -1.4% | 1.01x (?) \nObjectiveCBridgeFromNSArrayAnyObjectForced | 6829 | 6754 | -1.1% | 1.01x (?) \nObjectiveCBridgeFromNSArrayAnyObjectToString | 40325 | 40965 | +1.6% | 0.98x (?) \nObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 35270 | 34394 | -2.5% | 1.03x (?) \nObjectiveCBridgeFromNSDictionaryAnyObject | 122650 | 122895 | +0.2% | 1.00x (?) \nObjectiveCBridgeFromNSDictionaryAnyObjectToString | 97687 | 95593 | -2.1% | 1.02x (?) \nObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 102904 | 105803 | +2.8% | 0.97x (?) \nObjectiveCBridgeFromNSSetAnyObject | 68839 | 68408 | -0.6% | 1.01x (?) \nObjectiveCBridgeFromNSSetAnyObjectForced | 7463 | 7450 | -0.2% | 1.00x (?) \nObjectiveCBridgeFromNSSetAnyObjectToString | 72924 | 72836 | -0.1% | 1.00x (?) \nObjectiveCBridgeFromNSSetAnyObjectToStringForced | 73322 | 75092 | +2.4% | 0.98x (?) \nObjectiveCBridgeFromNSString | 3994 | 3998 | +0.1% | 1.00x (?) \nObjectiveCBridgeFromNSStringForced | 2234 | 2192 | -1.9% | 1.02x (?) \nObjectiveCBridgeStubDataAppend | 4066 | 3922 | -3.5% | 1.04x (?) \nObjectiveCBridgeStubDateAccess | 1034 | 1034 | +0.0% | 1.00x \nObjectiveCBridgeStubFromArrayOfNSString | 25702 | 25282 | -1.6% | 1.02x (?) \nObjectiveCBridgeStubFromNSDateRef | 4552 | 4342 | -4.6% | 1.05x \nObjectiveCBridgeStubFromNSString | 558 | 568 | +1.8% | 0.98x (?) \nObjectiveCBridgeStubFromNSStringRef | 186 | 182 | -2.2% | 1.02x (?) \nObjectiveCBridgeStubNSDataAppend | 2860 | 2736 | -4.3% | 1.05x \nObjectiveCBridgeStubNSDateMutationRef | 16305 | 15780 | -3.2% | 1.03x (?) \nObjectiveCBridgeStubNSDateRefAccess | 1236 | 1216 | -1.6% | 1.02x \nObjectiveCBridgeStubToArrayOfNSString | 28917 | 29793 | +3.0% | 0.97x (?) \nObjectiveCBridgeStubToNSDate | 15521 | 15534 | +0.1% | 1.00x (?) \nObjectiveCBridgeStubToNSDateRef | 3376 | 3360 | -0.5% | 1.00x (?) \nObjectiveCBridgeStubToNSString | 1552 | 1546 | -0.4% | 1.00x (?) \nObjectiveCBridgeStubToNSStringRef | 155 | 155 | +0.0% | 1.00x \nObjectiveCBridgeStubURLAppendPath | 223412 | 224748 | +0.6% | 0.99x (?) \nObjectiveCBridgeStubURLAppendPathRef | 226189 | 226158 | -0.0% | 1.00x (?) \nObjectiveCBridgeToNSArray | 29378 | 29697 | +1.1% | 0.99x (?) \nObjectiveCBridgeToNSDictionary | 45587 | 45782 | +0.4% | 1.00x (?) \nObjectiveCBridgeToNSSet | 39882 | 39627 | -0.6% | 1.01x (?) \nObjectiveCBridgeToNSString | 1312 | 1306 | -0.5% | 1.00x \nObserverClosure | 7038 | 7041 | +0.0% | 1.00x (?) \nObserverForwarderStruct | 5256 | 5234 | -0.4% | 1.00x (?) \nObserverPartiallyAppliedMethod | 8480 | 8514 | +0.4% | 1.00x (?) \nObserverUnappliedMethod | 8846 | 8911 | +0.7% | 0.99x \nOpenClose | 398 | 393 | -1.3% | 1.01x \nPhonebook | 22154 | 22429 | +1.2% | 0.99x \nPolymorphicCalls | 5283 | 5132 | -2.9% | 1.03x \nPopFrontArray | 10358 | 10464 | +1.0% | 0.99x (?) \nPopFrontArrayGeneric | 9191 | 9182 | -0.1% | 1.00x (?) \nPrefixAnyCollection | 20296 | 20399 | +0.5% | 0.99x \nPrefixAnyCollectionLazy | 141060 | 141764 | +0.5% | 1.00x (?) \nPrefixAnySeqCRangeIter | 24721 | 24936 | +0.9% | 0.99x (?) \nPrefixAnySeqCRangeIterLazy | 24532 | 24730 | +0.8% | 0.99x \nPrefixAnySeqCntRange | 20488 | 20357 | -0.6% | 1.01x (?) \nPrefixAnySeqCntRangeLazy | 20348 | 20588 | +1.2% | 0.99x \nPrefixAnySequence | 12959 | 13100 | +1.1% | 0.99x (?) \nPrefixAnySequenceLazy | 12952 | 13030 | +0.6% | 0.99x \nPrefixArray | 6307 | 6469 | +2.6% | 0.97x \nPrefixArrayLazy | 45674 | 45832 | +0.3% | 1.00x (?) \nPrefixCountableRange | 337 | 340 | +0.9% | 0.99x \nPrefixCountableRangeLazy | 39654 | 40656 | +2.5% | 0.98x \nPrefixSequence | 11811 | 11892 | +0.7% | 0.99x (?) \nPrefixSequenceLazy | 11840 | 11860 | +0.2% | 1.00x (?) \nPrefixWhileAnyCollection | 38779 | 39523 | +1.9% | 0.98x (?) \nPrefixWhileAnyCollectionLazy | 23809 | 24201 | +1.6% | 0.98x (?) \nPrefixWhileAnySeqCRangeIter | 42992 | 43816 | +1.9% | 0.98x \nPrefixWhileAnySeqCRangeIterLazy | 23618 | 24470 | +3.6% | 0.97x \nPrefixWhileAnySeqCntRange | 39009 | 39605 | +1.5% | 0.98x (?) \nPrefixWhileAnySeqCntRangeLazy | 23663 | 24052 | +1.6% | 0.98x (?) \nPrefixWhileAnySequence | 32993 | 33500 | +1.5% | 0.98x (?) \nPrefixWhileAnySequenceLazy | 13645 | 13877 | +1.7% | 0.98x \nPrefixWhileArray | 17451 | 17880 | +2.5% | 0.98x \nPrefixWhileArrayLazy | 15373 | 16051 | +4.4% | 0.96x \nPrefixWhileCountableRange | 18974 | 19239 | +1.4% | 0.99x \nPrefixWhileCountableRangeLazy | 22948 | 23274 | +1.4% | 0.99x \nPrefixWhileSequence | 31790 | 32577 | +2.5% | 0.98x \nPrefixWhileSequenceLazy | 12495 | 12420 | -0.6% | 1.01x \nPrims | 10689 | 10623 | -0.6% | 1.01x (?) \nProtocolDispatch | 6946 | 7166 | +3.2% | 0.97x \nProtocolDispatch2 | 490 | 492 | +0.4% | 1.00x \nRC4 | 19040 | 18984 | -0.3% | 1.00x (?) \nRGBHistogram | 35459 | 34534 | -2.6% | 1.03x \nRGBHistogramOfObjects | 108609 | 108682 | +0.1% | 1.00x (?) \nRangeAssignment | 5749 | 5797 | +0.8% | 0.99x (?) \nRecursiveOwnedParameter | 11219 | 11269 | +0.4% | 1.00x \nReversedArray | 44520 | 44823 | +0.7% | 0.99x \nReversedBidirectional | 75589 | 76277 | +0.9% | 0.99x (?) \nReversedDictionary | 29642 | 29546 | -0.3% | 1.00x \nSetExclusiveOr | 23034 | 23018 | -0.1% | 1.00x (?) \nSetExclusiveOr_OfObjects | 48147 | 48539 | +0.8% | 0.99x \nSetIntersect | 12542 | 12525 | -0.1% | 1.00x (?) \nSetIntersect_OfObjects | 12486 | 12507 | +0.2% | 1.00x (?) \nSetIsSubsetOf | 1871 | 1861 | -0.5% | 1.01x \nSetIsSubsetOf_OfObjects | 1538 | 1557 | +1.2% | 0.99x \nSetUnion | 11861 | 11958 | +0.8% | 0.99x \nSetUnion_OfObjects | 33638 | 34011 | +1.1% | 0.99x \nSevenBoom | 1610 | 1615 | +0.3% | 1.00x (?) \nSim2DArray | 44266 | 44293 | +0.1% | 1.00x \nSortLargeExistentials | 18053 | 17715 | -1.9% | 1.02x \nSortLettersInPlace | 3102 | 3088 | -0.5% | 1.00x (?) \nSortSortedStrings | 1436 | 1458 | +1.5% | 0.98x \nSortStrings | 2493 | 2502 | +0.4% | 1.00x (?) \nSortStringsUnicode | 8938 | 8942 | +0.0% | 1.00x (?) \nStackPromo | 103402 | 102645 | -0.7% | 1.01x (?) \nStaticArray | 4603 | 4673 | +1.5% | 0.99x \nStrComplexWalk | 6980 | 6993 | +0.2% | 1.00x (?) \nStrToInt | 128065 | 126564 | -1.2% | 1.01x \nStringAdder | 3798 | 3773 | -0.7% | 1.01x (?) \nStringBuilder | 7147 | 7119 | -0.4% | 1.00x (?) \nStringBuilderLong | 1079 | 1088 | +0.8% | 0.99x (?) \nStringEdits | 386553 | 383800 | -0.7% | 1.01x (?) \nStringEqualPointerComparison | 2569 | 2578 | +0.4% | 1.00x (?) \nStringFromLongWholeSubstring | 206 | 206 | +0.0% | 1.00x \nStringFromLongWholeSubstringGeneric | 218 | 220 | +0.9% | 0.99x \nStringHasPrefix | 1737 | 1694 | -2.5% | 1.03x \nStringHasPrefixUnicode | 16752 | 16758 | +0.0% | 1.00x (?) \nStringHasSuffixUnicode | 63899 | 63186 | -1.1% | 1.01x \nStringInterpolation | 13792 | 13761 | -0.2% | 1.00x (?) \nStringMatch | 35448 | 34566 | -2.5% | 1.03x \nStringUTF16Builder | 7971 | 8015 | +0.6% | 0.99x (?) \nStringWithCString | 60304 | 60265 | -0.1% | 1.00x (?) \nSubstringComparable | 4258 | 4272 | +0.3% | 1.00x (?) \nSubstringEqualString | 6576 | 6567 | -0.1% | 1.00x (?) \nSubstringEquatable | 8525 | 8442 | -1.0% | 1.01x (?) \nSubstringFromLongString | 16 | 16 | +0.0% | 1.00x \nSubstringFromLongStringGeneric | 117 | 116 | -0.9% | 1.01x \nSuffixAnyCollection | 6785 | 6827 | +0.6% | 0.99x \nSuffixAnyCollectionLazy | 47886 | 48111 | +0.5% | 1.00x (?) \nSuffixAnySeqCRangeIter | 44517 | 45481 | +2.2% | 0.98x \nSuffixAnySeqCRangeIterLazy | 44743 | 44578 | -0.4% | 1.00x \nSuffixAnySeqCntRange | 6788 | 6798 | +0.1% | 1.00x (?) \nSuffixAnySeqCntRangeLazy | 6747 | 6833 | +1.3% | 0.99x (?) \nSuffixAnySequence | 31275 | 31177 | -0.3% | 1.00x (?) \nSuffixAnySequenceLazy | 31588 | 31604 | +0.1% | 1.00x (?) \nSuffixArray | 2111 | 2192 | +3.8% | 0.96x \nSuffixArrayLazy | 15238 | 15496 | +1.7% | 0.98x \nSuffixCountableRange | 118 | 119 | +0.8% | 0.99x \nSuffixCountableRangeLazy | 13440 | 13582 | +1.1% | 0.99x (?) \nSuffixSequence | 31016 | 30974 | -0.1% | 1.00x (?) \nSuffixSequenceLazy | 30853 | 30803 | -0.2% | 1.00x (?) \nSumUsingReduce | 231937 | 232294 | +0.2% | 1.00x (?) \nSumUsingReduceInto | 227094 | 226778 | -0.1% | 1.00x \nSuperChars | 192525 | 192053 | -0.2% | 1.00x (?) \nTwoSum | 4285 | 4301 | +0.4% | 1.00x (?) \nUTF8Decode | 38835 | 38653 | -0.5% | 1.00x (?) \nWalsh | 12034 | 12028 | -0.0% | 1.00x (?) \nXorLoop | 23764 | 23780 | +0.1% | 1.00x \naccessGlobal | 177 | 180 | +1.7% | 0.98x \naccessInMatSet | 326 | 328 | +0.6% | 0.99x \naccessIndependent | 124 | 121 | -2.4% | 1.02x \n\n</details>\n\n<details>\n <summary><strong>Hardware Overview</strong></summary>\n\n Model Name: Mac mini\n Model Identifier: Macmini7,1\n Processor Name: Intel Core i5\n Processor Speed: 2.8 GHz\n Number of Processors: 1\n Total Number of Cores: 2\n L2 Cache (per Core): 256 KB\n L3 Cache: 3 MB\n Memory: 16 GB\n</details>\n\n--------------",
"previous": {
"meta": "This message directly preceded comment from bot *swift-ci* by author *aschwaighofer*:",
"text": "@swift-ci Please benchmark"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *swift-ci* by author *aschwaighofer*:",
"text": "@swift-ci Please benchmark"
}
}
] |
[
{
"action": "opened",
"author": "dalanlan",
"comment_id": null,
"datetime": 1447833965000,
"text": "Fix #17205",
"title": "[ubuntu] fix etcd flag ",
"type": "issue"
},
{
"action": "created",
"author": "dalanlan",
"comment_id": 158296875,
"datetime": 1448002192000,
"text": "ping @davidopp",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidopp",
"comment_id": 158307672,
"datetime": 1448004131000,
"text": "@resouer @yichengq @xiang90",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "resouer",
"comment_id": 158331459,
"datetime": 1448010491000,
"text": "I did not see error in kube-in-docker, but as #17422 was in. I'm ok with this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dalanlan",
"comment_id": 158628241,
"datetime": 1448103914000,
"text": "Based on @xiang90 's comment, i think it would be fine to set `advertise-client-urls` \r\n- 1. http://${master_ip}:4001\r\n- 2. http://127.0.0.1:4001, given that there is single etcd, and `--no-sync` for `etcdctl` \r\nI'm comfortable with either and adopt option 1 for now.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "resouer",
"comment_id": 158631989,
"datetime": 1448106361000,
"text": "lgtm cc @davidopp",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidopp",
"comment_id": 158688467,
"datetime": 1448145862000,
"text": "LGTM",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Labelling this PR as size/S",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *resouer*:",
"text": "I did not see error in kube-in-docker, but as #17422 was in. I'm ok with this."
}
},
{
"bot": "Automatic merge from submit-queue",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *davidopp*:",
"text": "LGTM"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *resouer*:",
"text": "I did not see error in kube-in-docker, but as #17422 was in. I'm ok with this."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *davidopp*:",
"text": "LGTM"
}
}
] |
[
{
"action": "opened",
"author": "nikhita",
"comment_id": null,
"datetime": 1520944846000,
"text": "Fixes kubernetes/apiextensions-apiserver#28\r\n\r\n`go-openapi/validate` had a bug https://github.com/go-openapi/validate/issues/13 where it did not properly validate enums for integers. This hits users of CRD validation. This was fixed in https://github.com/go-openapi/validate/pull/14.\r\n\r\nI had bumped `go-openapi/validate` for subresources in https://github.com/kubernetes/kubernetes/pull/55168 in this commit: https://github.com/kubernetes/kubernetes/commit/66a4e5122a2d810ada2f23af803d1e44256dd260 (to get the fix https://github.com/go-openapi/validate/pull/36 in). This bump picked up the fix for enum validation, so this bug does not affect 1.10 users.\r\n\r\nThis PR cherry picks the above commit to the `release-1.9` branch to fix the bug for 1.9 users.\r\n\r\nThis is not an automated cherry pick. My understanding is that automated cherry picks are for cherry-picking complete PRs and this cherry picks _a commit_ in a PR https://github.com/kubernetes/kubernetes/pull/55168. Adding an explicit hold to make sure this is ok.\r\n/hold\r\n\r\n\r\n**Release note**:\r\n<!-- Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n\r\n/cc mbohlool sttts liggitt \r\n/assign mbohlool",
"title": "[1.9] bump(go-openapi/validate): d509235108fcf6ab4913d2dcb3a2260c0db2108e",
"type": "issue"
},
{
"action": "created",
"author": "nikhita",
"comment_id": 372652799,
"datetime": 1520945142000,
"text": "/kind bug\r\n/area custom-resources\r\n/sig api-machinery",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbohlool",
"comment_id": 372746601,
"datetime": 1520961522000,
"text": "@nikhita it is ok to sometimes do manual cherrypicks. Please just add justification on why this is needed as a cherrypick and what is the user impact.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 372808596,
"datetime": 1520973180000,
"text": "@nikhita staging godeps need to be updated here too",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jennybuckley",
"comment_id": 373509454,
"datetime": 1521145129000,
"text": "/cc @jpbetz",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jpbetz",
"comment_id": 376248879,
"datetime": 1522085774000,
"text": "Backporting this as a single commit looks fine to me. Removing hold.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 376278115,
"datetime": 1522091352000,
"text": "@nikhita This still need attention (staging godeps need to be updated)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhita",
"comment_id": 376278950,
"datetime": 1522091531000,
"text": "There is a still a discussion on how we should proceed with it. https://github.com/kubernetes/apiextensions-apiserver/issues/28#issuecomment-372751580.\r\n\r\nUntil that is agreed upon, I think we should not merge this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 376291606,
"datetime": 1522094200000,
"text": "@nikhita Understood.\r\n/hold",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbohlool",
"comment_id": 388125473,
"datetime": 1525973467000,
"text": "any update on this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbohlool",
"comment_id": 390816362,
"datetime": 1526945853000,
"text": "Closing this in favor of #63604",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@nikhita: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-kops-aws | 65b2ec140712a9d6bf28311dea3c8ff54201451b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/61106/pull-kubernetes-e2e-kops-aws/79319/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/61106). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/nikhita). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *nikhita*:",
"text": "/kind bug\r\n/area custom-resources\r\n/sig api-machinery"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *nikhita*:",
"text": "/kind bug\r\n/area custom-resources\r\n/sig api-machinery"
}
}
] |
[
{
"action": "opened",
"author": "kshedden",
"comment_id": null,
"datetime": 1472008247000,
"text": "Resolves #3177 by raising if the column names are integer type.",
"title": "ENH: Raise if MICEData dataframe has integer column names",
"type": "issue"
},
{
"action": "created",
"author": "kshedden",
"comment_id": 261079644,
"datetime": 1479332138000,
"text": "@josef-pkt OK to merge? The test failure is unrelated to this PR.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/9678963)\n\nCoverage decreased (-0.001%) to 88.025% when pulling **d7f62ded493eb6a81ca4a4f8c7f863c5e7db8f32 on kshedden:mice-3177** into **22f27667729af3e07ad4ff8a48e0e7a5570b181e on statsmodels:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *kshedden*:",
"text": "@josef-pkt OK to merge? The test failure is unrelated to this PR."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *kshedden*:",
"text": "@josef-pkt OK to merge? The test failure is unrelated to this PR."
}
}
] |
[
{
"action": "opened",
"author": "TonyFlury",
"comment_id": null,
"datetime": 1520414860000,
"text": "<!--\r\nThanks for your contribution!\r\nPlease read this comment in its entirety. It's quite important.\r\n\r\n# Pull Request title\r\n\r\nIt should be in the following format:\r\n```\r\nbpo-NNNN: Summary of the changes made\r\n```\r\nWhere: bpo-NNNN refers to the issue number in the https://bugs.python.org.\r\n\r\nMost PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.\r\n\r\n# Backport Pull Request title\r\n\r\nIf this is a backport PR (PR made against branches other than `master`),\r\nplease ensure that the PR title is in the following format:\r\n```\r\n[X.Y] <title from the original PR> (GH-NNNN)\r\n```\r\nWhere: [X.Y] is the branch name, e.g. [3.6].\r\n\r\nGH-NNNN refers to the PR number from `master`.\r\n\r\n-->\r\n\n\n<!-- issue-number: bpo-33006 -->\nhttps://bugs.python.org/issue33006\n<!-- /issue-number -->",
"title": "bpo-33006 - Correct filter doc string to clarify 2nd argument can be iterable",
"type": "issue"
},
{
"action": "created",
"author": "TonyFlury",
"comment_id": 385549887,
"datetime": 1525127952000,
"text": "I have made the requested changes; please review again.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "miss-islington",
"comment_id": 496750293,
"datetime": 1559093763000,
"text": "@TonyFlury: Status check is done, and it's a success ✅ .",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Thanks for making the requested changes!\n\n@ned-deily: please review the changes made to this pull request.",
"previous": {
"meta": "This message directly preceded comment from bot *bedevere-bot* by author *TonyFlury*:",
"text": "I have made the requested changes; please review again."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *bedevere-bot* by author *TonyFlury*:",
"text": "I have made the requested changes; please review again."
}
}
] |
[
{
"action": "opened",
"author": "oliveralonzo",
"comment_id": null,
"datetime": 1511124201000,
"text": "",
"title": "Fix Markdown in README.md",
"type": "issue"
},
{
"action": "created",
"author": "oliveralonzo",
"comment_id": 345548159,
"datetime": 1511124356000,
"text": "I signed it!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "maryroseMXXXVI",
"comment_id": 363361107,
"datetime": 1517909033000,
"text": "Why do I need to signed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "y00223621",
"comment_id": 451345703,
"datetime": 1546572753000,
"text": "11\r\n22",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sorinj",
"comment_id": 452481936,
"datetime": 1546988163000,
"text": "Thank you for pointing this out and sending a fix.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "CLAs look good, thanks!\n\n<!-- ok -->",
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *oliveralonzo*:",
"text": "I signed it!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *oliveralonzo*:",
"text": "I signed it!"
}
}
] |
[
{
"action": "opened",
"author": "zhangxiaoyu-zidif",
"comment_id": null,
"datetime": 1495867002000,
"text": "<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nReturn nil directly when err is nil\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!-- Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```",
"title": "Return nil when err is nil",
"type": "issue"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 304463681,
"datetime": 1495903985000,
"text": "This is effectively a noop. Why is this needed?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zhangxiaoyu-zidif",
"comment_id": 304482656,
"datetime": 1495929052000,
"text": "@cblecker Sir， please refer to https://github.com/kubernetes/kubernetes/pull/29866, https://github.com/kubernetes/kubernetes/pull/45162. That may be a format. Thanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 304492137,
"datetime": 1495945829000,
"text": "@k8s-bot ok to test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 304702943,
"datetime": 1496078030000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "wojtek-t",
"comment_id": 304815527,
"datetime": 1496134353000,
"text": "/approve",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/46561#issuecomment-304702943\" title=\"LGTM\">cblecker</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/46561#\" title=\"Author self-approved\">zhangxiaoyu-zidif</a>*\nWe suggest the following additional approver: **ixdy**\n\nAssign the PR to them by writing `/assign @ixdy` in a comment when ready.\n\n<details open>\nNeeds approval from an approver in each of these OWNERS Files:\n\n- **[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)**\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"ixdy\"]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *cblecker*:",
"text": "/lgtm"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/46561#issuecomment-304702943\" title=\"LGTM\">cblecker</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/46561#issuecomment-304815527\" title=\"Approved\">wojtek-t</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/46561#\" title=\"Author self-approved\">zhangxiaoyu-zidif</a>*\n\n<details >\nNeeds approval from an approver in each of these OWNERS Files:\n\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)~~ [wojtek-t]\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *wojtek-t*:",
"text": "/approve"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *cblecker*:",
"text": "/lgtm"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *wojtek-t*:",
"text": "/approve"
}
}
] |
[
{
"action": "opened",
"author": "sergiohs84",
"comment_id": null,
"datetime": 1485962115000,
"text": "",
"title": "Add creation date to chat data",
"type": "issue"
},
{
"action": "created",
"author": "sergiohs84",
"comment_id": 278589164,
"datetime": 1486632266000,
"text": "trigger compilation",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "polmr",
"comment_id": 281706727,
"datetime": 1487778184000,
"text": "trigger compilation",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "sdkPRcompilationAutoTools FAILED (422) :-1:",
"previous": {
"meta": "This message directly preceded comment from bot *JenkinsMega* by author *sergiohs84*:",
"text": "trigger compilation"
}
},
{
"bot": "sdkPRcompilationAutoTools SUCCEDED (451) :+1:",
"previous": {
"meta": "This message directly preceded comment from bot *JenkinsMega* by author *polmr*:",
"text": "trigger compilation"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *JenkinsMega* by author *sergiohs84*:",
"text": "trigger compilation"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *JenkinsMega* by author *polmr*:",
"text": "trigger compilation"
}
}
] |
[
{
"action": "opened",
"author": "conglei",
"comment_id": null,
"datetime": 1506452614000,
"text": "Added new network library.",
"title": "Conglei graph",
"type": "issue"
},
{
"action": "created",
"author": "conglei",
"comment_id": 332540062,
"datetime": 1506522602000,
"text": "Changes done :) working on writting the test. Should I push the commit of the test file here?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "williaster",
"comment_id": 332593324,
"datetime": 1506532789000,
"text": "yep all commits should be pushed!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "conglei",
"comment_id": 332680438,
"datetime": 1506553594000,
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "williaster",
"comment_id": 332910073,
"datetime": 1506620304000,
"text": "Great thanks @conglei! \r\n\r\nwill merge and cut a release, and we can iterate on functionality if needed from there 🎉 it still might be useful for this to move back to @vx at some point (cc @hshoff) but let's dog food it a bit first.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hshoff",
"comment_id": 332910368,
"datetime": 1506620374000,
"text": "Great work @conglei!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/13460158)\n\nCoverage remained the same at 81.764% when pulling **6a850bdbaa7e4844558d753006b665f4b50feeff on conglei:conglei-graph** into **efc72176ad64622e29ff4b06c8578a01714bc274 on williaster:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *williaster*:",
"text": "yep all commits should be pushed!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *williaster*:",
"text": "yep all commits should be pushed!"
}
}
] |
[
{
"action": "opened",
"author": "traflm",
"comment_id": null,
"datetime": 1524626514000,
"text": "This is the very first code drop for TRAFODION-2953, the major purpose is to get feedback to see if the design is OK and shall we continue with this effort or not.\r\nPlease check https://issues.apache.org/jira/browse/TRAFODION-2953, I attached a design document there.\r\n\r\nThis PR contains initial prototype of the design. It still has a major code-refactor to do, but I would like to hear from community first, before I spend more time on it, in case there are something fundamentally wrong.\r\n\r\nThe major change for this prototype code is to add a new PartitionFunction, instead of modifying the SinglePartitionPartitioningFunction directly. I will inherit a new SinglePartitionWithSmallTablePartitioningFunction from SinglePartitionPartitioningFunction next.\r\n\r\nOne can check the TEST035 to get a demo of how it works.\r\n\r\nThere are many other tasks following this initial code drop. For example, index/alter/create-super-table etc.\r\n\r\nThe major idea to support this is to add a new SYSTEM column _TBLNM_, so in a single Region, rows belong to different tables can be distinguished. When doing IUDS, always add predicate _TBLNM_ = 'theNameOfTheTable' to filter out the correct rows. \r\n\r\nPlease help to review and let me know your comments!",
"title": "[TRAFODION-2953] initial implementation of small table in one Hbase Region",
"type": "issue"
},
{
"action": "created",
"author": "traflm",
"comment_id": 384149583,
"datetime": 1524626772000,
"text": "something wrong with my PR, most changes not in the PR. Close it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "traflm",
"comment_id": 384150448,
"datetime": 1524627157000,
"text": "Recovered, PR is no OK...\r\n@anoopsharma00 @DaveBirdsall @zellerh , please help to take a review",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "traflm",
"comment_id": 384269367,
"datetime": 1524659435000,
"text": "This PR is not ready, far from ready, sorry, let me close it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "traflm",
"comment_id": 384358265,
"datetime": 1524675338000,
"text": "reopen just for some tests, Do not merge",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "traflm",
"comment_id": 387260480,
"datetime": 1525744742000,
"text": "jenkins, retest",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2597/",
"previous": {
"meta": "This message directly preceded comment from bot *Traf-Jenkins* by author *traflm*:",
"text": "reopen just for some tests, Do not merge"
}
},
{
"bot": "Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2622/",
"previous": {
"meta": "This message directly preceded comment from bot *Traf-Jenkins* by author *traflm*:",
"text": "jenkins, retest"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *Traf-Jenkins* by author *traflm*:",
"text": "reopen just for some tests, Do not merge"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *Traf-Jenkins* by author *traflm*:",
"text": "jenkins, retest"
}
}
] |
[
{
"action": "opened",
"author": "mikedanese",
"comment_id": null,
"datetime": 1524499892000,
"text": "we deploy it as a manifest, not an addon so locate it with the other\r\nmaster manifests.\r\n\r\nThis is the last \"bare pod addon\", which needs to be remove to improve the situation in https://github.com/kubernetes/kubernetes/issues/62808.\r\n \r\n```release-note\r\n\r\n```",
"title": "gce: move etcd dir cleanup to manifests",
"type": "issue"
},
{
"action": "created",
"author": "krousey",
"comment_id": 383640078,
"datetime": 1524501321000,
"text": "Does a service account in manifests work? And you don't need the role bindings anymore?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krousey",
"comment_id": 383645051,
"datetime": 1524502260000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikedanese",
"comment_id": 383720387,
"datetime": 1524517056000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikedanese",
"comment_id": 383965244,
"datetime": 1524582016000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikedanese",
"comment_id": 383999793,
"datetime": 1524588025000,
"text": "/retest",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@mikedanese: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-kops-aws | fb5fb2f09daab9407bda9f68795b7b45762adc75 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63015/pull-kubernetes-e2e-kops-aws/85377/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/63015). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/mikedanese). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krousey*:",
"text": "/lgtm"
}
},
{
"bot": "/retest\nThis bot automatically retries jobs that failed/flaked on approved PRs (send feedback to [fejta](https://github.com/fejta)).\n\nReview the [full test history](https://k8s-gubernator.appspot.com/pr/63015) for this PR.\n\nSilence the bot with an `/lgtm cancel` comment for consistent failures.",
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *mikedanese*:",
"text": "/retest"
}
},
{
"bot": "@mikedanese: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-kops-aws | a9432d09d63c4d842544d8285acefff4d275e579 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63015/pull-kubernetes-e2e-kops-aws/85458/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-integration | ae73bed1d0b9a299b06fc762d513b9b734ea4ce7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63015/pull-kubernetes-integration/8236/) | `/test pull-kubernetes-integration`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/63015). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/mikedanese). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *mikedanese*:",
"text": "/retest"
}
},
{
"bot": "@mikedanese: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-verify | ae73bed1d0b9a299b06fc762d513b9b734ea4ce7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63015/pull-kubernetes-verify/87783/) | `/test pull-kubernetes-verify`\npull-kubernetes-integration | ae73bed1d0b9a299b06fc762d513b9b734ea4ce7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63015/pull-kubernetes-integration/8264/) | `/test pull-kubernetes-integration`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/63015). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/mikedanese). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *mikedanese*:",
"text": "/retest"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krousey*:",
"text": "/lgtm"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *mikedanese*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *mikedanese*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *mikedanese*:",
"text": "/retest"
}
}
] |
[
{
"action": "opened",
"author": "janno42",
"comment_id": null,
"datetime": 1462094921000,
"text": "Fix #681 \r\n\r\nThis allows exporting raw course data per semester as well as a participation overview in CSV format. Both are helpful for creating detailed statistics about a semester.",
"title": "Raw data export",
"type": "issue"
},
{
"action": "created",
"author": "karyon",
"comment_id": 216037755,
"datetime": 1462104364000,
"text": "oh and please add tests :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "karyon",
"comment_id": 216051656,
"datetime": 1462118182000,
"text": "could you add an explanation why that page got removed to the commit message? also, check out the landscape issues.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "janno42",
"comment_id": 217729746,
"datetime": 1462723490000,
"text": "added tests. i don't like them. let the hate begin.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "karyon",
"comment_id": 217736330,
"datetime": 1462730176000,
"text": ":fuelpump:",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://landscape.io/diff/338970)\nRepository health decreased by 0.65% when pulling **[e48c2ab](https://github.com/janno42/EvaP/commit/e48c2abc0bc84738f9b1c995e41e70d601ce825b) on janno42:raw_export** into **[803ac98](https://github.com/fsr-itse/EvaP/commit/803ac9825aac1024137220bed631e4302d580d18) on fsr-itse:master**.\n\n * [7 new problems were found](https://landscape.io/diff/338970) (including 0 errors and 7 code smells).\n * No problems were fixed.",
"previous": {
"meta": "This message directly preceded comment from bot *landscape-bot* by author *karyon*:",
"text": "oh and please add tests :)"
}
},
{
"bot": "[](https://landscape.io/diff/343556)\nCode quality remained the same when pulling **[c0cf3f8](https://github.com/janno42/EvaP/commit/c0cf3f804476a4e0f8fcc641bedf342aa54221e8) on janno42:raw_export** into **[06a0f38](https://github.com/fsr-itse/EvaP/commit/06a0f38db9b1e5d2c6b379aeddc564f935a3bbc7) on fsr-itse:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *landscape-bot* by author *janno42*:",
"text": "added tests. i don't like them. let the hate begin."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *landscape-bot* by author *karyon*:",
"text": "oh and please add tests :)"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *landscape-bot* by author *janno42*:",
"text": "added tests. i don't like them. let the hate begin."
}
}
] |
[
{
"action": "opened",
"author": "zoumo",
"comment_id": null,
"datetime": 1523956268000,
"text": "<!-- Thanks for sending a pull request! See below for tips! -->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nAdd your description\r\n\r\n**Which issue(s) this PR fixes** *(optional, close the issue(s) when PR gets merged)*:\r\n\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n/cc @your-reviewer\r\n\r\n**Release note**:\r\n<!-- Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n\r\n```release-note\r\nchore(k8s): update kubernetes api to 1.10\r\n```\r\n\r\n<!-- Thanks for sending a pull request! Here are some tips:\r\n\r\n1. https://github.com/caicloud/engineering/blob/master/docs/review_conventions.md <-- what is the review process looks like\r\n2. https://github.com/caicloud/engineering/blob/master/docs/commit_conventions.md <-- how to structure your git commit\r\n3. https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md <-- how to work with caicloud bot\r\n\r\nOther tips from Kubernetes cmomunity:\r\n\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->",
"title": "chore(k8s): update kubernetes api to 1.10",
"type": "issue"
},
{
"action": "created",
"author": "yejiayu",
"comment_id": 382954108,
"datetime": 1524192837000,
"text": "/lgtm",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/caicloud/loadbalancer-controller/pull/53#issuecomment-382954108\" title=\"LGTM\">yejiayu</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **zoumo**\n\nAssign the PR to them by writing `/assign @zoumo` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md#bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/caicloud/loadbalancer-controller/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"zoumo\"]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *caicloud-bot* by author *yejiayu*:",
"text": "/lgtm"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *caicloud-bot* by author *yejiayu*:",
"text": "/lgtm"
}
}
] |
[
{
"action": "opened",
"author": "AccessibilityTestingTeam-TCS",
"comment_id": null,
"datetime": 1529415060000,
"text": "**Environment Details:**\r\nVSCode Version : 1.24.0\r\nOS Version : HighSierra10.13.5\r\n\r\n**Additional Details:**\r\nMAS Violated : MAS 2.4.3\r\nScreenReader : VoiceOver\r\n\r\n**Repro Steps:**\r\n1. Launch VS Code while VoiceOver is ON.\r\n2. Navigate to Activity Bar and select \"View Debug \" button.\r\n3. Navigate to \"All Exceptions\" and \"User Handled Exceptions\" tick boxes in \"Breakpoints\" section.\r\n4. Check/Uncheck checkboxes and use \"Tab\" each time to focus them.\r\n\r\n**Actual:**\r\nKeyboard focus does not remain on the tick box when any state is changed. \"Tab\" is needed to bring back tick box on focus for first tick box and for second several tabs are used to bring back focus.\r\n\r\n**Expected:**\r\nKeyboard focus should remain on the tick box on which any state change action is performed.\r\n\r\n**Recommendations:**\r\nRefer below link which is repository of bug fixes code snippets:\r\nhttps://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx\r\n\r\n**User Impact:**\r\nThe keyboard only users will find difficulty in navigating between these tick boxes since they would need to \"Tab\" again and again to bring focus back to same control once their states are changed.\r\n\r\n**MAS Reference:**\r\nMAS 2.4.3 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={0de7fbe1-ad7e-48e5-bcbb-8d986691e2b9}\r\n\r\n**Attachment For Reference:**\r\n[A11y_VSCode_ViewDebug_Keyboard_Mac_TickBoxFocusRetentionIssue.pptx](https://github.com/Microsoft/vscode/files/2115346/A11y_VSCode_ViewDebug_Keyboard_Mac_TickBoxFocusRetentionIssue.pptx)\r\n\r\nDoes this issue occur when all extensions are disabled?: Yes",
"title": "[Accessibility]A11y_VSCode_ViewDebug_Keyboard: Keyboard focus does not remain on the same tick box when checked/unchecked.",
"type": "issue"
},
{
"action": "created",
"author": "chrmarti",
"comment_id": 398405569,
"datetime": 1529416183000,
"text": "/duplicate #52299",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues [here](https://aka.ms/vscodeissuesearch). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!",
"previous": {
"meta": "This message directly preceded comment from bot *vscodebot[bot]* by author *chrmarti*:",
"text": "/duplicate #52299"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *vscodebot[bot]* by author *chrmarti*:",
"text": "/duplicate #52299"
}
}
] |
[
{
"action": "opened",
"author": "tengqm",
"comment_id": null,
"datetime": 1510649379000,
"text": "/kind bug\r\n\r\n*What happened**:\r\nWhen requesting a Pod creation with alpha.kubernetes.io/nvidia-gpu specified, I was hoping that the creation is a failure because I didn't enable the Accelerators feature gate. However, it succeeded. The pod is stuck in Pending status which is fine.\r\n\r\n**What you expected to happen**:\r\nI'm expecting that a Pod requesting GPU will be rejected when its container resource requirements are validated. Having the GPU usage guarded by the feature gate will help cleaning removing it in future when device plugin stabilizes.\r\n\r\n**How to reproduce it (as minimally and precisely as possible)**:\r\nDisable Accelerators feature gate and create a Pod with GPU request or limit, the pod is successfully created. It means that the feature gate is not doing its job.\r\n\r\n**Anything else we need to know?**:\r\n\r\n**Environment**:\r\n- Kubernetes version (use `kubectl version`):\r\n- Cloud provider or hardware configuration:\r\n- OS (e.g. from /etc/os-release):\r\n- Kernel (e.g. `uname -a`):\r\n- Install tools:\r\n- Others:",
"title": "Pods with GPU requests should be rejected early if Accelerators feature gate is off",
"type": "issue"
},
{
"action": "created",
"author": "dims",
"comment_id": 344731151,
"datetime": 1510780676000,
"text": "/sig node",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mindprince",
"comment_id": 375757687,
"datetime": 1521829285000,
"text": "/close\r\n\r\nThis is deprecated in 1.10 and going to be removed in 1.11: https://github.com/kubernetes/kubernetes/pull/61498",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Issues go stale after 90d of inactivity.\nMark the issue as fresh with `/remove-lifecycle stale`.\nStale issues rot after an additional 30d of inactivity and eventually close.\n\nIf this issue is safe to close now please do so with `/close`.\n\nSend feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta).\n/lifecycle stale",
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *dims*:",
"text": "/sig node"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *dims*:",
"text": "/sig node"
}
}
] |
[
{
"action": "opened",
"author": "joeltine",
"comment_id": null,
"datetime": 1438298462000,
"text": "Fixes https://github.com/google/closure-library/issues/345",
"title": "Remove mention of __proto__ being a safe key",
"type": "issue"
},
{
"action": "created",
"author": "joeltine",
"comment_id": 126519152,
"datetime": 1438298656000,
"text": "I signed it!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "CLAs look good, thanks!\n\n<!-- ok -->",
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *joeltine*:",
"text": "I signed it!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *joeltine*:",
"text": "I signed it!"
}
}
] |
[
{
"action": "opened",
"author": "marstr",
"comment_id": null,
"datetime": 1516149744000,
"text": "The Azure REST API Specs portion of onboarding the Go SDK to be generated by the `Swagger -> SDK` bot.",
"title": "Add go batches",
"type": "issue"
},
{
"action": "created",
"author": "marstr",
"comment_id": 358156502,
"datetime": 1516149779000,
"text": "This is still in progress, and shouldn't be merged until I remove the `DoNotMerge` tag.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "marstr",
"comment_id": 358742861,
"datetime": 1516301109000,
"text": "@lmazuel I believe this is all ready for your consideration now. Let me know, and we'll get this merged in. :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "marstr",
"comment_id": 359490131,
"datetime": 1516640400000,
"text": "Anything else that needs to be changed before this is merged, @lmazuel? :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lmazuel",
"comment_id": 360540392,
"datetime": 1516901594000,
"text": "Manual testing content is good, let's merge!!!!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Hi There,\r\n\r\nI am the **AutoRest Linter Azure bot**. I am here to help. My task is to analyze the situation from the [AutoRest linter](https://marketplace.visualstudio.com/items?itemName=ms-vscode.autorest) perspective. Please review the below analysis result:\r\n\r\n\r\n\r\n\r\n\r\nFile: `specification/advisor/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/analysisservices/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/apimanagement/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **2**\r\nAfter the PR: Warning(s): **0** Error(s): **2**\r\n\r\n\r\nFile: `specification/applicationinsights/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/authorization/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/automation/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **59**\r\nAfter the PR: Warning(s): **0** Error(s): **59**\r\n\r\n\r\nFile: `specification/azsadmin/resource-manager/InfrastructureInsights/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **6**\r\nAfter the PR: Warning(s): **0** Error(s): **6**\r\n\r\n\r\nFile: `specification/azsadmin/resource-manager/commerce/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **1**\r\nAfter the PR: Warning(s): **0** Error(s): **1**\r\n\r\n\r\nFile: `specification/azsadmin/resource-manager/fabric/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **6**\r\nAfter the PR: Warning(s): **0** Error(s): **6**\r\n\r\n\r\nFile: `specification/batch/data-plane/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **1**\r\nAfter the PR: Warning(s): **0** Error(s): **1**\r\n\r\n\r\nFile: `specification/batch/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **4**\r\nAfter the PR: Warning(s): **0** Error(s): **4**\r\n\r\n\r\nFile: `specification/batchai/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/billing/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/cdn/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/ComputerVision/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **14**\r\nAfter the PR: Warning(s): **0** Error(s): **14**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/ContentModerator/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/CustomSearch/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/EntitySearch/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **2**\r\nAfter the PR: Warning(s): **0** Error(s): **2**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/Face/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/ImageSearch/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/LUIS/Programmatic/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/LUIS/Runtime/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/NewsSearch/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/SpellCheck/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **1**\r\nAfter the PR: Warning(s): **0** Error(s): **1**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/TextAnalytics/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **3**\r\nAfter the PR: Warning(s): **0** Error(s): **3**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/VideoSearch/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **1**\r\nAfter the PR: Warning(s): **0** Error(s): **1**\r\n\r\n\r\nFile: `specification/cognitiveservices/data-plane/WebSearch/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **2**\r\nAfter the PR: Warning(s): **0** Error(s): **2**\r\n\r\n\r\nFile: `specification/cognitiveservices/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/commerce/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **29**\r\nAfter the PR: Warning(s): **0** Error(s): **29**\r\n\r\n\r\nFile: `specification/compute/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **32**\r\nAfter the PR: Warning(s): **0** Error(s): **32**\r\n\r\n\r\nFile: `specification/consumption/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/containerinstance/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **1**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/containerregistry/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/containerservices/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **4**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/cosmos-db/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/customer-insights/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/datacatalog/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/datafactory/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **1**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/datalake-analytics/data-plane/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/datalake-analytics/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **6**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/datalake-store/data-plane/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **6**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/datalake-store/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **6**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/datamigration/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/devtestlabs/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **1**\r\nAfter the PR: Warning(s): **0** Error(s): **1**\r\n\r\n\r\nFile: `specification/dns/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **13**\r\nAfter the PR: Warning(s): **0** Error(s): **13**\r\n\r\n\r\nFile: `specification/domainservices/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/eventgrid/data-plane/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/eventgrid/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **1**\r\nAfter the PR: Warning(s): **0** Error(s): **1**\r\n\r\n\r\nFile: `specification/eventhub/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/graphrbac/data-plane/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **19**\r\nAfter the PR: Warning(s): **0** Error(s): **19**\r\n\r\n\r\nFile: `specification/hanaonazure/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/hdinsight/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **16**\r\nAfter the PR: Warning(s): **0** Error(s): **16**\r\n\r\n\r\nFile: `specification/intune/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **5**\r\nAfter the PR: Warning(s): **0** Error(s): **5**\r\n\r\n\r\nFile: `specification/iothub/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **17**\r\nAfter the PR: Warning(s): **0** Error(s): **17**\r\n\r\n\r\nFile: `specification/keyvault/data-plane/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **30**\r\nAfter the PR: Warning(s): **0** Error(s): **30**\r\n\r\n\r\nFile: `specification/keyvault/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/locationbasedservices/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/logic/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **1**\r\nAfter the PR: Warning(s): **0** Error(s): **1**\r\n\r\n\r\nFile: `specification/machinelearning/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/machinelearningcompute/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/machinelearningexperimentation/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/marketplaceordering/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/mediaservices/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/mobileengagement/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **16**\r\nAfter the PR: Warning(s): **0** Error(s): **16**\r\n\r\n\r\nFile: `specification/monitor/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/msi/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/mysql/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/network/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **85**\r\nAfter the PR: Warning(s): **0** Error(s): **85**\r\n\r\n\r\nFile: `specification/notificationhubs/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **15**\r\nAfter the PR: Warning(s): **0** Error(s): **15**\r\n\r\n\r\nFile: `specification/operationalinsights/data-plane/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/operationalinsights/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **27**\r\nAfter the PR: Warning(s): **0** Error(s): **27**\r\n\r\n\r\nFile: `specification/operationsmanagement/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/postgresql/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/powerbidedicated/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/powerbiembedded/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **6**\r\nAfter the PR: Warning(s): **0** Error(s): **6**\r\n\r\n\r\nFile: `specification/provisioningservices/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **4**\r\nAfter the PR: Warning(s): **0** Error(s): **4**\r\n\r\n\r\nFile: `specification/recoveryservices/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/recoveryservicesbackup/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/recoveryservicessiterecovery/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **23**\r\nAfter the PR: Warning(s): **0** Error(s): **23**\r\n\r\n\r\nFile: `specification/redis/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/relay/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/reservations/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/resourcehealth/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **1**\r\nAfter the PR: Warning(s): **0** Error(s): **1**\r\n\r\n\r\nFile: `specification/resources/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **71**\r\nAfter the PR: Warning(s): **0** Error(s): **71**\r\n\r\n\r\nFile: `specification/scheduler/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **7**\r\nAfter the PR: Warning(s): **0** Error(s): **7**\r\n\r\n\r\nFile: `specification/search/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/servermanagement/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **4**\r\nAfter the PR: Warning(s): **0** Error(s): **4**\r\n\r\n\r\nFile: `specification/service-map/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **4**\r\nAfter the PR: Warning(s): **0** Error(s): **4**\r\n\r\n\r\nFile: `specification/servicebus/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/servicefabric/data-plane/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **690**\r\nAfter the PR: Warning(s): **0** Error(s): **690**\r\n\r\n\r\nFile: `specification/servicefabric/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **44**\r\nAfter the PR: Warning(s): **0** Error(s): **44**\r\n\r\n\r\nFile: `specification/sql/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/storage/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/storageimportexport/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/storsimple8000series/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **13**\r\nAfter the PR: Warning(s): **0** Error(s): **13**\r\n\r\n\r\nFile: `specification/streamanalytics/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **5**\r\nAfter the PR: Warning(s): **0** Error(s): **5**\r\n\r\n\r\nFile: `specification/subscription/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/timeseriesinsights/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/trafficmanager/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **2**\r\nAfter the PR: Warning(s): **0** Error(s): **2**\r\n\r\n\r\nFile: `specification/visualstudio/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **0**\r\nAfter the PR: Warning(s): **0** Error(s): **0**\r\n\r\n\r\nFile: `specification/web/resource-manager/readme.md`\r\nBefore the PR: Warning(s): **0** Error(s): **45**\r\nAfter the PR: Warning(s): **0** Error(s): **45**\r\n\r\n\r\n[AutoRest Linter Guidelines](https://github.com/Azure/azure-rest-api-specs/blob/current/documentation/openapi-authoring-automated-guidelines.md) | [AutoRest Linter Issues](https://github.com/Azure/azure-openapi-validator/issues) | Send <a href='mailto:[email protected]?subject=Feedback%20|%20AutoRest%20Linter%20Azure%20Bot'>feedback</a>\r\n\r\nThanks for your co-operation.",
"previous": {
"meta": "This message directly preceded comment from bot *azuresdkciprbot* by author *marstr*:",
"text": "Anything else that needs to be changed before this is merged, @lmazuel? :)"
}
},
{
"bot": "Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.",
"previous": {
"meta": "This message directly preceded comment from bot *AutorestCI* by author *lmazuel*:",
"text": "Manual testing content is good, let's merge!!!!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *azuresdkciprbot* by author *marstr*:",
"text": "Anything else that needs to be changed before this is merged, @lmazuel? :)"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *AutorestCI* by author *lmazuel*:",
"text": "Manual testing content is good, let's merge!!!!"
}
}
] |
[
{
"action": "opened",
"author": "lzilioli",
"comment_id": null,
"datetime": 1496335413000,
"text": "This fixes #23",
"title": "better check for presence of ingredient within pantry fixes #23",
"type": "issue"
},
{
"action": "created",
"author": "lawnsea",
"comment_id": 305569792,
"datetime": 1496339538000,
"text": "@lzilioli this failed linting",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lzilioli",
"comment_id": 305576038,
"datetime": 1496340974000,
"text": "@lawnsea fixed",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/11787117)\n\nCoverage remained the same at 99.485% when pulling **0fde105573e9e6405e2f3dc9f0c828f659113196 on fix-lodash-resolve** into **d08c8e1e9aaf905f12ee189d8e81f6f1964c098e on master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *lzilioli*:",
"text": "@lawnsea fixed"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *lzilioli*:",
"text": "@lawnsea fixed"
}
}
] |
[
{
"action": "opened",
"author": "zhyale",
"comment_id": null,
"datetime": 1525136064000,
"text": "Please answer these questions before submitting your issue. Thanks!\r\n\r\n\r\n### What version of Go are you using (`go version`)?\r\ngo1.10.1 linux/amd64\r\n\r\n### Does this issue reproduce with the latest release?\r\nYes\r\n\r\n### What operating system and processor architecture are you using (`go env`)?\r\nCentOS 7 with kernel 3.10.0-514.10.2.el7.x86_64\r\n\r\n### What did you do?\r\nI create a program to detect attack such as SQL Injection, when test case is:\r\nhttp://..../id=1%27;--\r\n\r\nand I use:\r\nr.ParseForm()\r\nparams := r.Form\r\nfmt.Println(\"params:\", params, \"count:\", len(params))\r\nfor key, values := range params {\r\n\t\tfmt.Println(\"param\", key, \":\", values)\r\n}\r\n\r\nGot:\r\nparams: map[--:[] id:[1']] count: 2\r\nparam id : [1']\r\nparam -- : []\r\n\r\n\r\n### What did you expect to see?\r\nexpect only one expression in this case:\r\nkey: id\r\nvalue: 1';--\r\n\r\n### What did you see instead?\r\nI got two key:[value] pairs.",
"title": "r.Form parse error when parameter include SQL Injection test",
"type": "issue"
},
{
"action": "created",
"author": "agnivade",
"comment_id": 385592902,
"datetime": 1525146570000,
"text": "Complete repro -\r\n\r\n```go\r\npackage main\r\n\r\nimport (\r\n\t\"fmt\"\r\n\t\"net/http\"\r\n)\r\n\r\nfunc main() {\r\n\thttp.HandleFunc(\"/foo\", func(w http.ResponseWriter, req *http.Request) {\r\n\t\terr := req.ParseForm()\r\n\t\tif err != nil {\r\n\t\t\tfmt.Println(err)\r\n\t\t\tw.Write([]byte(\"error\"))\r\n\t\t\treturn\r\n\t\t}\r\n\t\tparams := req.Form\r\n\t\tfmt.Println(\"params:\", params, \"count:\", len(params))\r\n\t\tfor key, values := range params {\r\n\t\t\tfmt.Println(\"param\", key, \":\", values)\r\n\t\t}\r\n\t\tw.Write([]byte(\"OK\"))\r\n\t})\r\n\r\n\tfmt.Println(\"starting on port 9999\")\r\n\tserver := &http.Server{\r\n\t\tAddr: \":9999\",\r\n\t}\r\n\tserver.ListenAndServe()\r\n}\r\n```\r\n\r\n`curl 'http://localhost:9999/foo?id=1%27;--'`\r\n\r\n@bradfitz - Is this expected ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fraenkel",
"comment_id": 385651055,
"datetime": 1525174221000,
"text": "Both & and ; are used to split key value pairs. The ; is optional since it allows you to provide a URL as a value with a query string.\r\nSee https://en.wikipedia.org/wiki/Query_string under Web Forms",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "odeke-em",
"comment_id": 385662789,
"datetime": 1525178758000,
"text": "Hello @zhyale, thank you for filing this issue and welcome to the Go project!\r\n\r\n@agnivade and @fraenkel thank you for the responses too.\r\n\r\nSo I believe, the root cause of the question here is rather: `Why is a semi colon being used as a separator in url.Parse?`\r\n\r\nIf you run https://play.golang.org/p/QVz18jWspPF or inlined below:\r\n```go\r\npackage main\r\n\r\nimport (\r\n\t\"log\"\r\n\t\"net/url\"\r\n)\r\n\r\nfunc main() {\r\n\tlog.SetFlags(0)\r\n\tu, err := url.Parse(\"http://localhost:9999/foo?id=1%27;--\")\r\n\tif err != nil {\r\n\t\tlog.Fatalf(\"Failed to parse URL: %v\", err)\r\n\t}\r\n\tlog.Printf(\"%#v\\n\", u.Query())\r\n}\r\n```\r\nYou'll see the real symptom\r\n```shell\r\nurl.Values{\"--\":[]string{\"\"}, \"id\":[]string{\"1'\"}}\r\n```\r\n\r\nA W3C recommendation https://www.w3.org/TR/html401/appendix/notes.html#h-B.2.2 recommended using `;` as a separator for url-encoded params for form-data\r\n<img width=\"1276\" alt=\"screen shot 2018-05-01 at 5 08 58 am\" src=\"https://user-images.githubusercontent.com/4898263/39472383-d41e7482-4cfd-11e8-9326-d8b2a668e17a.png\">\r\n\r\nand that was what we used to add `;` as a separator, making ';' synoymous with '&' in https://golang.org/cl/4973062 https://github.com/golang/go/issues/2210#issue-51278892 \r\n\r\nHowever, unfortunately that recommendation just got superseded very recently in mid-December 2017 by https://www.w3.org/TR/2017/REC-html52-20171214/\r\n\r\nand now that points to https://url.spec.whatwg.org/#urlsearchparams\r\nin which we can see that the only separator here is '&'\r\n<img width=\"1167\" alt=\"screen shot 2018-05-01 at 5 19 53 am\" src=\"https://user-images.githubusercontent.com/4898263/39472615-51c970a2-4cff-11e8-80ec-4b1428326774.png\">\r\n\r\n\r\n\r\nNode.js doesn't seem to recognize ';' as a separator\r\n```javascript\r\nurl.parse('http://localhost:9999/foo?id=1%27;--', true);\r\nUrl {\r\n protocol: 'http:',\r\n slashes: true,\r\n auth: null,\r\n host: 'localhost:9999',\r\n port: '9999',\r\n hostname: 'localhost',\r\n hash: null,\r\n search: '?id=1%27;--',\r\n query: { id: '1\\';--' },\r\n pathname: '/foo',\r\n path: '/foo?id=1%27;--',\r\n href: 'http://localhost:9999/foo?id=1%27;--' }\r\n```\r\n\r\nand the old survey of what other languages do while technically still correct per https://github.com/golang/go/issues/2210#issuecomment-66058500, any future adoptions of the new recommendation from W3C will mean that those languages will also change their behavior.\r\n\r\nNow the big question is: this behavior has been around since 2011, changing it 7 years later might massively break code for many users. Perhaps we need a survey of the make-up and interpretation of query strings from some frontend server?\r\n\r\nAlso this perhaps will need some security considerations as well or maybe a wide scale adoption of the recommendation first?\r\n\r\nIn addition to those already paged, I will page some more folks to help pitch in thoughts about the fate of the new W3C recommendation /cc @ianlancetaylor @andybons @tombergan @agl @rsc @mikesamuel",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bradfitz",
"comment_id": 385692432,
"datetime": 1525186808000,
"text": "So we can't change it during Go 1.x.\r\n\r\nRepurposing this to be a Go 2.x issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikesamuel",
"comment_id": 385696543,
"datetime": 1525187732000,
"text": "+1\r\n\r\nWe might be able to get a handle on the size of potential breakage by surveying URL composition libraries to get an idea of how many sources are likely to produce URLs that are substantially different given non-crafted inputs.\r\n\r\nFor example:\r\n\r\n```go\r\n// html/template\r\nt, _ := template.New(\"T\").Parse(`<a href=\"/?a={{.}}&b=b\">`)\r\nt.Execute(&out, `foo;bar&baz`)\r\nout.String() == `<a href=\"/?a=foo%3bbar%26baz&b=b\">`\r\n\r\n// net/url\r\nurl.QueryEscape(`foo;bar&baz`) == `foo%3Bbar%26baz`\r\nurl.QueryUnescape(`foo%3Bbar%26baz`) == `foo;bar&baz`\r\n```\r\n\r\nIn vanilla JS\r\n```js\r\nencodeURIComponent(`foo;bar&baz`) == `foo%3Bbar%26baz`\r\nencodeURI(`foo;bar&baz`) == `foo;bar&baz`\r\n```\r\n\r\n----\r\n\r\nI think this is mostly a correctness and interop issue but that the security consequences are not severe.\r\n\r\nThat said, there are risks to inferring more structure than the spec allows.\r\n\r\nIf a survey finds that there are widely used url.QueryEscape / encodeURIComponent counterparts that escape `&` but do not escape `;`, and a trusted partner composes URLs thus:\r\n\r\n```\r\ngoServiceUrl = \"//example.com/?\"\r\n + \"securityIrrelevantParam=\" + laxEscapeQuery(untrustedString)\r\n + \"&importantParam=\" + laxEscapeQuery(trustedString)\r\n```\r\n\r\nthen `untrustedString` might inject a `;importantParam` which would be available as the zero-th entry in Go's query map.\r\n\r\nThe risk is pretty small as long as `laxEscapeQuery` escapes `'='` and one workaround is to consistently enforce has-exactly-one constraints.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FiloSottile",
"comment_id": 789799446,
"datetime": 1614785409000,
"text": "It was recently pointed out that this behavior divergence can [lead to cache poisoning attacks](https://snyk.io/blog/cache-poisoning-in-popular-open-source-packages/) in reverse proxies that cache based on a subset of query parameters: if Go treats `https://example.com/?x;id=1337&id=123` as a request for ID 1337, while the cache treats it as a request for ID 123, the cache can be made to serve the wrong response.\r\n\r\nAt the risk of repeating myself, I want to point out that relying on parser alignment for security is doomed, so this will break again, and often in subtler ways that we can't fix universally. However, this is probably broken _most of the time_ now, so we should fix it.\r\n\r\nI did a quick survey of other popular languages and frameworks.\r\n\r\n* PHP used to support both but now defaults to only `&`. https://www.php.net/manual/en/ini.core.php#ini.sect.data-handling\r\n* Rails (via Rack) currently supports both, but landed a change in January following the Snyk blog post. Unclear when it will reach a release. https://github.com/rack/rack/issues/1732\r\n* Python currently supports both, but will switch in 3.10 and assigned it a CVE. https://github.com/python/cpython/pull/24297\r\n\r\nA more interesting question would be how caching proxies behave, but a lot of them are ad-hoc and hard to test. Snyk seems to think at least Varnish uses only `&`. As pointed out in https://github.com/golang/go/issues/25192#issuecomment-432369818, AWS is not only ignoring `;`, but it's unescaping it while proxying.\r\n\r\nI think the W3C and WHATWG recommendations are sort of red herrings: they are about `x-www-form-urlencoded`, not URL queries. On the other hand, the entire reason anyone supported `;` is that it was more convenient to use for `x-www-form-urlencoded` forms, as it did not require escaping `&` in HTML.\r\n\r\nGiven Rails and Python are waiting for the next scheduled release to fix this, we will too, and ship the fix in Go 1.17. It would be too harsh of a behavior change for too vague of a security benefit to land in a security release anyway.\r\n\r\nThis is technically a backwards compatibility promise violation, but I am invoking the security exception. More broadly, we should think whether the thing we want to provide compatibility with is \"the exact self-contained behavior of the library when it was introduced\" or \"correctly interoperate with the current ecosystem\". Realistically, we are already doing more of the latter with crypto/tls and crypto/x509, because doing the exact same thing as 5 years ago would be useless and insecure. HTTP and web specifications are similarly living and evolving, and we should figure out what our policy about that is.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 789933519,
"datetime": 1614793941000,
"text": "It seems kind of backward that every single HTTP server implementation in the world is being charged with coping with a decision made by a few proxies. If they don't think ; is special, then they could easily force it not to be special by escaping the ; as they pass it through. (AWS doing the opposite of that is even more mind-boggling.)\r\n\r\nCan we find some way to make this change less silent? I worry about people updating to Go 1.17 and having their servers misbehave but with no idea why. Maybe a logging print for each request that ignores ; as separator, limited to one per second or something like that?\r\n\r\nIt also seems like a hard requirement to be able to opt back in to the old behavior. Users with client apps sending ; that don't have the misfortune of being behind nginx will not like being forced to rewrite and redeploy their apps just to get Go 1.17.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 795873543,
"datetime": 1615400992000,
"text": "Adding to the minutes. It's getting a bit late to make a change in Go 1.17 so we should try to converge on a plan soon.\r\n\r\n@bigluck, if you still use the AWS API Gateway, does it still _unescape_ semicolons? Or does anyone else know?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 795876917,
"datetime": 1615401137000,
"text": "@ianlancetaylor found private mail saying that https://angular.io/api/common/http/HttpUrlEncodingCodec did not escape semicolons at least in 2019, leading to confusion as well. Does anyone know if that is still the case?\r\n\r\nAnd does anyone know of any clients that _do_ use semicolons for separators and would break if we stopped recognizing them?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 796858310,
"datetime": 1615479607000,
"text": "This is good advice. It boils down to \"Make sure your server and your cache proxy agree about how to split query arguments.\" The simplest, most guaranteed way to do this is to have the proxy rewrite the query to be unambiguous.\r\n\r\n### 4. Go servers behind nginx are _not_ affected by default.\r\n\r\nThe nginx docs say the [default proxy cache key](http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_cache_key) is `$scheme$proxy_host$request_uri`. That does _not_ interpret the query parameters at all, so it has no problem with semicolons versus ampersands. \r\n\r\nThe way to get into trouble is to use a key like `$arg_x` which extracts the `x` parameter from the query string and does so without considering semicolons (the code is ngx\\_http\\_arg called from ngx\\_http\\_variable\\_argument in the nginx code base; there is no configuration to allow semicolons). Go users, and Python users, and Ruby users, and many others, _cannot_ sync the nginx behavior and their server's behavior while also using query parameter cache keys. But again, these keys are not used by default. Only users who use these keys need to make a change.\r\n\r\n### 5. A potential non-breaking Go change.\r\n\r\nTo not break users, we could add a url.AllowQuerySemicolon function that controls whether ParseQuery accepts semicolons. It can default to true, but users who want to use nginx's query argument cache keys would call AllowQuerySemicolon(false) to bring the Go implementation in line with nginx's.\r\n\r\nIt is not clear to me that we have enough justification to take the next step of changing the default and breaking users, all for the very few users who are using nginx _and_ setting a custom cache key using query argument parameters.\r\nAgain, **this does not affect all Go programs sitting behind nginx**. It only affects those who set a custom proxy_cache_key and use a `$arg_xxx` form.\r\n\r\nIn the long term, it still seems like nginx should rewrite the query strings to escape semicolons in requests that are consulting the proxy cache and using query parameter argument keys, ensuring that nginx's understanding of the request URL matches the server's, 100% of the time, no matter what the server is.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FiloSottile",
"comment_id": 801105145,
"datetime": 1615989675000,
"text": "I think focusing on nginx is optimistic. nginx happens to be a popular reverse proxy that exhibits this behavior, but I doubt it's the only one. We should check Cloudflare, Fastly, Akamai, AWS, GCP, Azure, Varnish, F5, and Apache, off the top of my head. If they all need to change, then changing the server frameworks is not \"changing the thing in a lot of places instead of in one place\" (which I generally agree with as an argument).\r\n\r\nAt that point, I think it becomes a matter of what's more expected and predictable. The HTML 4 spec is hardly authoritative for URL query strings in HTTP, so we just don't have an easy reference here. As of today, I found the `;` surprising. If I were to write or audit a regex-based cache key, I would not have flagged the lack of semicolon support, nor would I have requested that the regex be wired into the rewriting engine (which is usually not possible). Now that Python, PHP, and Rails are switching to the better-known behavior, the situation will get worse over time, not better. In five years, we'll be the odd one out, and it will be hard to convince all new reverse proxies to do query string mangling to support Go's bizarre URL parsing.\r\n\r\nIf you are not convinced, I think we should check with all those other reverse proxy vendors before declining this proposal.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 806015076,
"datetime": 1616606647000,
"text": "It sounds like the argument is that \"Go should break all the semicolon users because all the others are too\". \r\nAnd maybe that's true. What we don't really know is how many semicolon users there are.\r\n\r\nAgain, this does not happen in reverse proxies out of the box, only when you start trying to distinguish by query \r\nparameters.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 806056155,
"datetime": 1616610246000,
"text": "Twitter threads gathering info:\r\nhttps://twitter.com/bradfitz/status/1374774763059482624\r\nhttps://twitter.com/FiloSottile/status/1374777816139628545",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joneskoo",
"comment_id": 806194586,
"datetime": 1616620922000,
"text": "Many on the Twitter threads confusing this with semicolons in path section. That’s not what we’re talking about here, right?\r\n\r\nnot in scope:\r\n`https://example.com/a;b=c;foo=42`\r\n\r\nIn scope:\r\n`https://example.com/a?b=c;foo=42`\r\n\r\nnotably JSESSIONID mentioned a few times.\r\n\r\nhttps://play.golang.org/p/OUVtI15HkU3",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AGWA",
"comment_id": 806252940,
"datetime": 1616629226000,
"text": "I'm a semicolon user. I like the ergonomic benefits from not having to escape `&` in HTML.\r\n\r\nThe backwards compatibility break for this would be really nasty. Unlike removing TLS ciphers or support for common name, this won't result in a predictable error. Instead the program will behave differently, and a log message is cold comfort if the program has already taken some undesirable action based on misinterpreting a query string. The bar for such a compatibility break should be very high, and I don't think this proposal should qualify. Parsing URLs is a minefield and [practically every implementation does something differently](https://www.blackhat.com/docs/us-17/thursday/us-17-Tsai-A-New-Era-Of-SSRF-Exploiting-URL-Parser-In-Trending-Programming-Languages.pdf). Any proxy server which relies on parsing query strings in the same manner as their backends is insecure, and removing semicolon separators from Go doesn't change that.\r\n\r\nTo provide an example of how futile this effort is, nginx's query string parser ([`ngx_http_arg`](https://github.com/nginx/nginx/blob/2e94c81b0bf1d8e695d9afd074c79520aa03081a/src/http/ngx_http_parse.c#L2120)) differs from Go's in the following three additional ways:\r\n\r\n|nginx behavior|Example|Go value for `id`|nginx value for `id`|\r\n| --- | --- | --- | --- |\r\n|Keys are case-insensitive|`iD=1&id=2`|`2`|`1`|\r\n|Keys are not unescaped|`%69d=1&id=2`|`1`|`2`|\r\n|Keys without equal signs are not supported|`id&id=1`|(empty)|`1`|\r\n\r\nConsequentially, this proposal would not help nginx users at all, and I would not be surprised if other reverse proxies also deviated from Go in at least one of the above ways.\r\n\r\nI realize that there aren't many semicolon users (@FiloSottile's Twitter poll has been bouncing between 1.5%-2%), but it strikes me as pretty inequitable to force us to deal with a change in application behavior whose only purpose is to try to paper over other people's risky behavior.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 806255755,
"datetime": 1616629753000,
"text": "@joneskoo, you are correct: semicolons before a ? are unrelated to this issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 806256347,
"datetime": 1616629863000,
"text": "@AGWA, indeed. A major problem with this change is that it will be a reason users can't easily update to a newer version of Go, which will increase our support burden as users lag behind. By itself, it may not seem like much to break a small fraction of the user base, but over time that kind of thing adds up. \r\n\r\nThanks very much for the additional nginx examples. I think these support the idea that any kind of proxy caching that tries to strip \"unnecessary\" parts of the URL really needs to canonicalize the URL to enforce its interpretation before passing the query along. That is, there may be a real problem here, but the fix is being applied in the wrong place. Even if we \"fixed\" Go to match nginx in all these cases, it would still not match other caching proxies.\r\n\r\nAgain, this does not happen in reverse proxies out of the box, only when you start trying to filter \"unimportant\" parts of the query string. It's starting to sound like you should basically never do that, and reverse proxies should remove that feature entirely.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FiloSottile",
"comment_id": 806317544,
"datetime": 1616639688000,
"text": "This is not practical, alas. Not for any reason I like, to be clear: it's mostly tracking parameters. But they are very much a thing and \"don't get to your business goals because parser alignment is impossible (and anyway we don't like your practices)\" is not a winning argument.\r\n\r\nTaking a step back, it sounds like there are two ways out of this as an ecosystem:\r\n\r\n1. we convince all reverse proxies to change the semantics of cache keys so that they rewrite the upstream URL to a canonicalized representation, on the argument that it's safer and more robust, and that they should mitigate our exclusive off-spec behavior\r\n2. we converge on the specified behavior, filing issues with reverse proxies that depart from the spec on the argument that they are off-spec and introducing a vulnerability\r\n\r\nI am not a fan of (2) at all, but (1) doesn't sound like it will happen, and this format is unusually simple and well-specified, so it might just be possible to match the spec.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 808423395,
"datetime": 1616782522000,
"text": "I still can't escape the feeling this is all security theater, especially given what @AGWA pointed out.\r\nThe suggestion is to break existing Go users (we don't know how many, but greater than zero).\r\nAnd the benefit is ... unclear beyond speculation about possibly being one step in a much longer path involving many players toward converging on shared behavior.\r\n\r\nI just don't yet see how the benefits outweigh the costs.\r\n\r\nAlso the linked WHATWG spec is about JavaScript behavior specifically.\r\n(The rest of the spec is not, but the parsing of the query is only relevant to constructing a JavaScript object.)\r\n\r\nI'm sorry for being a pain about this, but breaking users is a big deal and we need to be sure it is worth it.\r\nAnd that evidence is absent so far. Starting from the very beginning with Snyk's sloppy blog post, there have been too many fuzzy claims that look different when you get up close and really examine them.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slrz",
"comment_id": 808827170,
"datetime": 1616893928000,
"text": "If other implementations go ahead with this change it will probably cause existing users to move away from their semicolon usage. Let enough time pass and it might be rare enough for Go to follow without annoying too many users.\r\n\r\nNow, leaning back and watching while others take flak for breaking users may not be the nicest thing to do **if** the change in question is absolutely necessary for the ecosystem's continued health. In this case though, I think it's appropriate given that Python, Rails and friends don't have a strong commitment to compatibility in the first place (unlike Go) and the proposed change doesn't seem all that urgent to me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 819703826,
"datetime": 1618422363000,
"text": "It will probably annoy the same number as it would today.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "beoran",
"comment_id": 820166005,
"datetime": 1618469592000,
"text": "The simplest backwards compatible option is to add a url.AllowQuerySemicolon(bool) function, as rsc suggested. Not to +1, but what is there /against/ that suggestion? Whether it should default to true or false is debatable, but either way, letting the Go users have a knob to keep backwards compatibility seems desirable.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Mouvedia",
"comment_id": 820345973,
"datetime": 1618485589000,
"text": "1. option default to true\r\n2. option default to false\r\n3. deprecation notice\r\n4. removal",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 824216147,
"datetime": 1619024471000,
"text": "Filippo and I spent an hour discussing this. The problem today is a “superset” attack, where Go sees a superset of the values that the proxy does for:\r\n\r\n\turl?x=y;id=evil&id=good\r\n\r\nIn this case, the proxy thinks the id is good but Go thinks the id is evil, resulting in the evil entry being cached as good.\r\n\r\nGo's current parser also leads to a “subset” situation, where Go sees a subset of the values that the proxy does. In particular, Go rejects (drops) keys and values % followed by non-two-hex-digits, but the most common code paths don't check the error, so in\r\n\r\n\turl?id=evil%&id=good\r\n\r\nGo sees good while other implementations may see both evil% and good. We are unaware of any attack on this “subset” situation.\r\n\r\nBecause of that, we propose to do the following.\r\n\r\n1. Make url.ParseQuery split on & but then reject key=value pairs containing semicolons.\r\n2. Make package http log about ParseQuery errors mentioning the semicolon problem.\r\n\r\nThe effect will be to make the semicolon-preceded or -terminated pairs disappear, turning the superset attack into a subset situation. Because we are unaware of any subset-based attack, this is an improvement.\r\n\r\nThe log message should make clear what is going on for users who are confused about no longer seeing certain key-value pairs in their apps.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 828655795,
"datetime": 1619632260000,
"text": "Since there seem to be no objections to the proposal in the previous comment, I am going to mark this likely accept. The final acceptance won't happen until after the freeze, but we still would like to get this in for Go 1.17 for security reasons.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 828668252,
"datetime": 1619633333000,
"text": "Based on the discussion above, this proposal seems like a **[likely accept](https://golang.org/s/proposal-status#likely-accept)**.\n— rsc for the proposal review group",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "antichris",
"comment_id": 829409214,
"datetime": 1619714251000,
"text": "`;` is the more reasonable choice and (unrealistic as it sounds, especially when everyone's been using `&`s out of pure force of habit for decades now and some are even actually moving to drop `;` support entirely) should actually be the preferred separator. So, if the idea is to drop the support for splitting on semicolons *unconditionally*, I'm against it.\r\n\r\nIt's not like Go can flip the webdev world now, dominated by javascript kiddies and wordpress \"engineers\", but we can at least keep the saner choice an opt-in for those who can appreciate (and properly set their infrastructure up around) it. In other words, what https://github.com/golang/go/issues/25192#issuecomment-820166005 said, just really do default to `false`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FiloSottile",
"comment_id": 829425741,
"datetime": 1619715014000,
"text": "@antichris, this remark is not consistent with the [Gopher values](https://golang.org/conduct). The Javascript world built many things, and enabled even more people to build things. We want Go to be a tool that works with that ecosystem, and to be welcoming of people that come from that community.\r\n\r\nThe only technical argument in favor of using semicolons is that it's easier to insert them in manually composed HTML. If you have more please do contribute them. Ecosystem consistency is also a technical argument, and that's what we are weighting it against here.\r\n\r\nKnobs are extra complexity, but if you have a proposal for where to insert that knob we'll listen and weight it against the benefit. `url.AllowQuerySemicolon(bool)` is not an option, because package-global state would lead to conflicts between libraries that expect and set the value to be different.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andrius4669",
"comment_id": 830121041,
"datetime": 1619791687000,
"text": "somehow people are forgetting that it's often not necessary at all to escape `&` in case of url parameter usage, because the usual `&x=y` has very little chance to match `&<something>;` sequence for character references, unless parameter key contains `;` AND character reference is actually meaningful AND it's not escaped for some reason (url.QueryEscape does escape `;`).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 832863192,
"datetime": 1620234617000,
"text": "@AGWA's handler converter is nice for opt-in use. I filed #45973 for that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rsc",
"comment_id": 832911228,
"datetime": 1620239157000,
"text": "No change in consensus, so **[accepted](https://golang.org/s/proposal-status#accepted)**. 🎉\nThis issue now tracks the work of implementing the proposal.\n— rsc for the proposal review group",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FiloSottile",
"comment_id": 856071516,
"datetime": 1623082256000,
"text": "I'd like to request a freeze exception for this fix. We deemed it not a backportable security fix (also because of the potential for disruption and the limited real-world impact), but it's conceivable that it could have security value for some applications, so we'd like not to wait for Go 1.18.\r\n\r\nRuss, should we also land AllowQuerySemicolons (#45973) during the freeze? I'm leaning towards yes.\r\n\r\n/cc @golang/release @rsc",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dmitshur",
"comment_id": 856217202,
"datetime": 1623096183000,
"text": "Thank you for making this freeze exception request. It is approved.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yktoo",
"comment_id": 992276264,
"datetime": 1639388193000,
"text": "With the change https://golang.org/cl/325697 in place our servers now produce lots of log lines like\r\n\r\n```log\r\n2021/12/13 08:44:51 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\r\n2021/12/13 08:44:51 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\r\n2021/12/13 08:57:37 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\r\n2021/12/13 09:11:37 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\r\n2021/12/13 09:19:30 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\r\n```\r\n\r\nThis is really not helpful, and since it's a web server, anyone can flood you with requests with a `;`. Can this be switched off somehow?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "antichris",
"comment_id": 992302703,
"datetime": 1639390060000,
"text": "@yktoo Have you looked into using [`AllowQuerySemicolons`] or writing your own middleware to replace all semicolons with URL escapes? Alternatively, you could join the convo at #50034 or give it a thumbs-up if it is relevant to your case.\r\n\r\n[`AllowQuerySemicolons`]: https://pkg.go.dev/net/http#AllowQuerySemicolons\r\n\"AllowQuerySemicolons - http package - net/http - pkg.go.dev\"",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "seankhliao",
"comment_id": 992309838,
"datetime": 1639390536000,
"text": "`http.Server` takes a `*log.Logger`, you can filter it out there if you want.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yktoo",
"comment_id": 992312585,
"datetime": 1639390712000,
"text": "Thanks @antichris, #49399/#50034 describe my concerns exactly. @seankhliao yes log filtering seems the only workaround at the moment, albeit very ugly.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shinny-chengzhi",
"comment_id": 1058799374,
"datetime": 1646365726000,
"text": "I have been caught this by surprise and want to restore the old behavior. But it's unclear to me how to do this while supporting both 1.17&pre-1.17 since calling ```AllowQuerySemicolons``` will result in build error in 1.16.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ianlancetaylor",
"comment_id": 1058808146,
"datetime": 1646367008000,
"text": "@shinny-chengzhi You can use a build tag to compile code differently for go1.16 and go1.17.\r\n\r\nhttps://pkg.go.dev/cmd/go#hdr-Build_constraints",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shinny-chengzhi",
"comment_id": 1060124321,
"datetime": 1646619819000,
"text": "@ianlancetaylor Thanks, that will do it.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "",
"previous": {
"meta": "This message directly preceded comment from bot *gopherbot* by author *dmitshur*:",
"text": "Thank you for making this freeze exception request. It is approved."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *gopherbot* by author *dmitshur*:",
"text": "Thank you for making this freeze exception request. It is approved."
}
}
] |
[
{
"action": "opened",
"author": "ravisantoshgudimetla",
"comment_id": null,
"datetime": 1528234635000,
"text": "This is for adding pod preemption to test suite since it graduated to beta. \r\nNot sure if I missing anything.\r\n\r\n/cc @bsalamat",
"title": "Config updated for pod preemption",
"type": "issue"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 394869577,
"datetime": 1528234826000,
"text": "add an entry to prow/config.yaml as well",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 394876923,
"datetime": 1528236663000,
"text": "/approve\r\n\r\npunt to your sig to lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravisantoshgudimetla",
"comment_id": 394877295,
"datetime": 1528236761000,
"text": "Thanks @krzyzacy for the review and approval :).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravisantoshgudimetla",
"comment_id": 394895670,
"datetime": 1528242460000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 394895866,
"datetime": 1528242528000,
"text": "cc @BenTheElder \r\n\r\nhttps://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/test-infra/8265/pull-test-infra-lint/2909/ looks like a cache issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 395149668,
"datetime": 1528306087000,
"text": "/lgtm\r\n/hold",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravisantoshgudimetla",
"comment_id": 395196321,
"datetime": 1528315544000,
"text": "@krzyzacy Thanks for review. Any specific reason for putting it on hold, is it because of code-freeze?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 395210245,
"datetime": 1528318434000,
"text": "@ravisantoshgudimetla because I added a non-blocking comment, feel free to address it or ignore it and `/hold cancel`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravisantoshgudimetla",
"comment_id": 395232107,
"datetime": 1528323545000,
"text": "Thanks @krzyzacy - I will address it later.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravisantoshgudimetla",
"comment_id": 395232133,
"datetime": 1528323552000,
"text": "/hold cancel",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@ravisantoshgudimetla: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-test-infra-lint | bb15bf40c2fc281fc2ffd9eb0c441a0c2d623948 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/test-infra/8265/pull-test-infra-lint/2899/) | `/test pull-test-infra-lint`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/test-infra/8265). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/ravisantoshgudimetla). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/test-infra/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:",
"text": "add an entry to prow/config.yaml as well"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/test-infra/pull/8265#issuecomment-394876923\" title=\"Approved\">krzyzacy</a>*, *<a href=\"https://github.com/kubernetes/test-infra/pull/8265#\" title=\"Author self-approved\">ravisantoshgudimetla</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/test-infra/blob/master/OWNERS)~~ [krzyzacy]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:",
"text": "/approve\r\n\r\npunt to your sig to lgtm"
}
},
{
"bot": "@ravisantoshgudimetla: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-test-infra-bazel | 3201eef15184e24b3d7c5942eeca52349b35874d | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/test-infra/8265/pull-test-infra-bazel/16897/) | `/test pull-test-infra-bazel`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/test-infra/8265). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/ravisantoshgudimetla). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/test-infra/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ravisantoshgudimetla*:",
"text": "Thanks @krzyzacy for the review and approval :)."
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/test-infra/pull/8265#issuecomment-395149668\" title=\"LGTM\">krzyzacy</a>*, *<a href=\"https://github.com/kubernetes/test-infra/pull/8265#\" title=\"Author self-approved\">ravisantoshgudimetla</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/test-infra/blob/master/OWNERS)~~ [krzyzacy]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:",
"text": "/lgtm\r\n/hold"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:",
"text": "add an entry to prow/config.yaml as well"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:",
"text": "/approve\r\n\r\npunt to your sig to lgtm"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ravisantoshgudimetla*:",
"text": "Thanks @krzyzacy for the review and approval :)."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:",
"text": "/lgtm\r\n/hold"
}
}
] |
[
{
"action": "closed",
"author": "philipromeo",
"comment_id": null,
"datetime": 1538494460000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "## Consider this issue finished! :white_check_mark:\n\n<hr>\n<h3 align=\"center\">Head over to <a href=\"https://github.com/philipromeo/github-slideshow/issues/2\">the next issue</a> now!</h3>",
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *philipromeo*:",
"text": ""
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *philipromeo*:",
"text": ""
}
}
] |
[
{
"action": "opened",
"author": "nberlee",
"comment_id": null,
"datetime": 1527624259000,
"text": "<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**: Make the CoreDNS container more secure by dropping (root) capabilities. Improve the integrity of the of the container by running the whole container in read-only.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\nSame [changes](https://github.com/coredns/deployment/commit/aba0245609821e8bba8b4ecd6a32c1a02a7bf658) as in the CoreDNS deployment repository.\r\n**Release note**:\r\n<!-- Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```",
"title": "Drop capabilities of CoreDNS container and run in read-only",
"type": "issue"
},
{
"action": "created",
"author": "stealthybox",
"comment_id": 392928863,
"datetime": 1527624977000,
"text": "Thanks for this change @nberlee\r\n\r\nI'm running a local kubeadm build now to validate the change",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nberlee",
"comment_id": 392945307,
"datetime": 1527628006000,
"text": "thx @stealthybox, I will add a release note",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stealthybox",
"comment_id": 392946671,
"datetime": 1527628289000,
"text": "/assign @fabriziopandini @bowei\r\nPTAL",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nberlee",
"comment_id": 392968817,
"datetime": 1527633012000,
"text": "/test pull-kubernetes-e2e-kops-aws\r\n/test pull-kubernetes-kubemark-e2e-gce",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nberlee",
"comment_id": 393030306,
"datetime": 1527656136000,
"text": "/test pull-kubernetes-e2e-kops-aws\r\n/test pull-kubernetes-kubemark-e2e-gce",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fabriziopandini",
"comment_id": 393047042,
"datetime": 1527662283000,
"text": "Thanks @nberlee for your contribution!\r\nThanks @stealthybox for testing this\r\n\r\nI'm ok with the change (it mirrors the [sample deployment](https://github.com/coredns/deployment/blob/aba0245609821e8bba8b4ecd6a32c1a02a7bf658/kubernetes/coredns.yaml.sed#L108) in the core dns repo); I let the final approval to the owners of `cluster` folder\r\n/lgmt\r\n/cc @roberthbailey",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "roberthbailey",
"comment_id": 393051560,
"datetime": 1527663554000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fabriziopandini",
"comment_id": 393574066,
"datetime": 1527781278000,
"text": "/lgtm\r\n/approve",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "roberthbailey",
"comment_id": 394755331,
"datetime": 1528212799000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "roberthbailey",
"comment_id": 394768343,
"datetime": 1528214988000,
"text": "/milestone v1.11",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#\" title=\"Author self-approved\">nberlee</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#issuecomment-392940478\" title=\"LGTM\">stealthybox</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approvers: **bowei**, **timothysc**\n\nAssign the PR to them by writing `/assign @bowei @timothysc` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[cluster/addons/dns/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/OWNERS)**\n- **[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"bowei\",\"timothysc\"]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *stealthybox*:",
"text": "Thanks for this change @nberlee\r\n\r\nI'm running a local kubeadm build now to validate the change"
}
},
{
"bot": "@nberlee: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-kops-aws | 4dd193315bad7cf212b3308c687363d1de17a62f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64473/pull-kubernetes-e2e-kops-aws/91401/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/64473). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/nberlee). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *stealthybox*:",
"text": "/assign @fabriziopandini @bowei\r\nPTAL"
}
},
{
"bot": "@nberlee: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-kubemark-e2e-gce | 4dd193315bad7cf212b3308c687363d1de17a62f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64473/pull-kubernetes-kubemark-e2e-gce/92968/) | `/test pull-kubernetes-kubemark-e2e-gce`\npull-kubernetes-e2e-kops-aws | 4dd193315bad7cf212b3308c687363d1de17a62f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/64473/pull-kubernetes-e2e-kops-aws/91425/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/64473). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/nberlee). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *nberlee*:",
"text": "/test pull-kubernetes-e2e-kops-aws\r\n/test pull-kubernetes-kubemark-e2e-gce"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#\" title=\"Author self-approved\">nberlee</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#issuecomment-393051560\" title=\"LGTM\">roberthbailey</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#issuecomment-392940478\" title=\"LGTM\">stealthybox</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **fabriziopandini**\n\nAssign the PR to them by writing `/assign @fabriziopandini` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- ~~[cluster/addons/dns/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/OWNERS)~~ [roberthbailey]\n- **[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"fabriziopandini\"]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *roberthbailey*:",
"text": "/lgtm"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#issuecomment-393574066\" title=\"Approved\">fabriziopandini</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#\" title=\"Author self-approved\">nberlee</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#issuecomment-393051560\" title=\"LGTM\">roberthbailey</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#issuecomment-392940478\" title=\"LGTM\">stealthybox</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[cluster/addons/dns/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/OWNERS)~~ [roberthbailey]\n- ~~[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)~~ [fabriziopandini]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *fabriziopandini*:",
"text": "/lgtm\r\n/approve"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#issuecomment-393574066\" title=\"Approved\">fabriziopandini</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#\" title=\"Author self-approved\">nberlee</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#issuecomment-394755331\" title=\"LGTM\">roberthbailey</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/64473#issuecomment-392940478\" title=\"LGTM\">stealthybox</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[cluster/addons/dns/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/OWNERS)~~ [roberthbailey]\n- ~~[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)~~ [fabriziopandini]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *roberthbailey*:",
"text": "/lgtm"
}
},
{
"bot": "[MILESTONENOTIFIER] Milestone Pull Request: **Up-to-date for process**\n\n@bowei @fabriziopandini @nberlee @roberthbailey @stealthybox\n\n<details open>\n<summary>Pull Request Labels</summary>\n\n- `sig/cluster-lifecycle`: Pull Request will be escalated to these SIGs if needed.\n- `priority/important-soon`: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.\n- `kind/feature`: New functionality.\n</details>\n<details>\n<summary>Help</summary>\n<ul>\n <li><a href=\"https://git.k8s.io/sig-release/ephemera/issues.md\">Additional instructions</a></li>\n <li><a href=\"https://go.k8s.io/bot-commands\">Commands for setting labels</a></li>\n</ul>\n</details>",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *roberthbailey*:",
"text": "/milestone v1.11"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *stealthybox*:",
"text": "Thanks for this change @nberlee\r\n\r\nI'm running a local kubeadm build now to validate the change"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *stealthybox*:",
"text": "/assign @fabriziopandini @bowei\r\nPTAL"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *nberlee*:",
"text": "/test pull-kubernetes-e2e-kops-aws\r\n/test pull-kubernetes-kubemark-e2e-gce"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *roberthbailey*:",
"text": "/lgtm"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *fabriziopandini*:",
"text": "/lgtm\r\n/approve"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *roberthbailey*:",
"text": "/lgtm"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *roberthbailey*:",
"text": "/milestone v1.11"
}
}
] |
[
{
"action": "opened",
"author": "suyogsainkar",
"comment_id": null,
"datetime": 1508995385000,
"text": "…Types of Columns in Guided Decision Tables with the recent UI changes\r\n\r\nDoc Jira: https://issues.jboss.org/browse/BXMSDOC-1848\r\nRendered doc: http://file.bne.redhat.com/ssainkar/BXMSDOC-1848/html-single/#guided_decision_tables_columns_types_con",
"title": "BXMSDOC-1848-master Aligned the documentation text in section 8.4.5. …",
"type": "issue"
},
{
"action": "created",
"author": "vidya-iyengar",
"comment_id": 339561174,
"datetime": 1508998000000,
"text": "ok to test",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Build successful! See generated HTML docs:\n\nhttps://kie-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/kie-docs-pullrequests-7.4.x/38//artifact/docs/drools-docs/target/generated-docs/html_single/index.html\nhttps://kie-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/kie-docs-pullrequests-7.4.x/38//artifact/docs/jbpm-docs/target/generated-docs/html_single/index.html\nhttps://kie-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/kie-docs-pullrequests-7.4.x/38//artifact/docs/optaplanner-wb-es-docs//target/generated-docs/html_single/index.html",
"previous": {
"meta": "This message directly preceded comment from bot *kie-ci* by author *vidya-iyengar*:",
"text": "ok to test"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *kie-ci* by author *vidya-iyengar*:",
"text": "ok to test"
}
}
] |
[
{
"action": "opened",
"author": "timabbott",
"comment_id": null,
"datetime": 1544119027000,
"text": "We've been getting an increasing number of requests for more video conferencing integrations in Zulip (in part because not everyone uses Google, and Jitsi isn't great). zoom.us seems to be the leading option in this space, and in any case, building out the integration strategy for it should provide a clear template for how to do other integrations which require a similar API setup.\r\n\r\nUnlike our existing Jitsi and Hangouts integrations, zoom doesn't support the \"generate a random call URL without talking to an API\" feature we use, but is shouldn't be hard to add something equivalent. What we'll want to do is the following:\r\n\r\n* We'll probably need to sign up for a Zoom free trial or email them for a comped developer account.\r\n* For the settings part of this, like the Hangouts integration's `video_chat_provider`, we have a field `zoom_credentials` where the user can provide the Zoom userId and apiKey. When a user uploads these, we validate via a random Zoom API call that the credentials are valid. Maybe e.g. https://marketplace.zoom.us/docs/api-reference/zoom-api/users/userpermission on the current user.\r\n* Add a new backend endpoint `/calls/create`. When this endpoint is triggered, it will use the Zoom API to create a meeting (https://marketplace.zoom.us/docs/api-reference/zoom-api/meetings/meetingcreate) and return the URL for the link.\r\n* When the organization has the Zoom setting enabled and clicks the \"create video call\" button, we query the server API, and when we get the response, enter the URL into Zulip.\r\n\r\n@skunkmb this could be a good project for you, since I think we'll want to use some of your fancy link-replacement stuff in the compose box that you build for uploads with it.\r\n\r\nI'm going to email them about the developer account issue now, but I think most of the work here can proceed without that.",
"title": "Add a zoom.us video conferencing option",
"type": "issue"
},
{
"action": "created",
"author": "rishig",
"comment_id": 444979591,
"datetime": 1544121194000,
"text": "Just to clarify, \"user\" here will still be an admin, so that there is one API key per realm. We'll also want to make sure the actual API key is not exposed in the UI, once it has been entered and sent to our server.\r\n\r\nZoom allows you to do fancy stuff with your personal API key, but I think we want to skip that for the V1 at least.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "skunkmb",
"comment_id": 445265223,
"datetime": 1544196104000,
"text": "@zulipbot claim",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "skunkmb",
"comment_id": 449612201,
"datetime": 1545536428000,
"text": "@zulipbot claim",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rishig",
"comment_id": 449667726,
"datetime": 1545605023000,
"text": "By the way, we have a number of potential users migrating from HipChat that are asking for this, so would be great to get this in soon!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "timabbott",
"comment_id": null,
"datetime": 1546884230000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "Hello @skunkmb, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?\n\nIf so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.\n\nIf you've decided to work on something else, simply comment `@zulipbot abandon` so that someone else can claim it and continue from where you left off.\n\nThank you for your valuable contributions to Zulip!\n\n<!-- inactiveWarning -->",
"previous": {
"meta": "This message directly preceded comment from bot *zulipbot* by author *skunkmb*:",
"text": "@zulipbot claim"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *zulipbot* by author *skunkmb*:",
"text": "@zulipbot claim"
}
}
] |
[
{
"action": "created",
"author": "jzempel",
"comment_id": 477297853,
"datetime": 1553712023000,
"text": "Closed as duplicate of #291",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "### Renovate Ignore Notification\n\nAs this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for *any* future 6.x releases. However, if you upgrade to 6.x manually then Renovate will then reenable updates for minor and patch updates automatically.\n\nIf this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.",
"previous": {
"meta": "This message directly preceded comment from bot *renovate[bot]* by author *jzempel*:",
"text": "Closed as duplicate of #291"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *renovate[bot]* by author *jzempel*:",
"text": "Closed as duplicate of #291"
}
}
] |
[
{
"action": "opened",
"author": "andy-maier",
"comment_id": null,
"datetime": 1499341014000,
"text": "**Note:** This PR is on top of PR #359.\r\nAffects only mock support.\r\nReady for review and merge.\r\nDetails in commit message.",
"title": "Fixes #319: Mock: Added support for Get Connected VNICs operation.",
"type": "issue"
},
{
"action": "created",
"author": "andy-maier",
"comment_id": 313390697,
"datetime": 1499346436000,
"text": "+1",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/12293258)\n\nCoverage increased (+1.7%) to 89.104% when pulling **c31f4a8e2305e547526c635b4e0fd89d72e7ae2e on andy/mock-add-vswitch-ops** into **8f9cf13f351a4b88ffa15c28d889e2b66269ed76 on master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *andy-maier*:",
"text": "+1"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *andy-maier*:",
"text": "+1"
}
}
] |
[
{
"action": "opened",
"author": "GoelDeepak",
"comment_id": null,
"datetime": 1508860942000,
"text": "## High Level Description\r\n\r\nThis is for my own project and this PR is never intended to be merged. I will close when my experimentation is over\r\n\r\n## Related Issues\r\n\r\n - [DCOS_OSS-<number>](https://jira.dcos.io/browse/DCOS_OSS-<number>) Foo the Bar so it stops Bazzing.\r\n - [DCOS-<number>](https://jira.mesosphere.com/browse/DCOS-<number>) Foo the Bar so it stops Bazzing.\r\n\r\n## Checklist for all PR's\r\n\r\n - [ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n - [ ] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n - [ ] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)\r\n\r\n## Checklist for component/package updates:\r\n\r\nIf you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath `packages`), then in addition to the above please also include:\r\n\r\n - [ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): [example](https://github.com/dcos/dcos-mesos-modules/compare/f6fa27d7c40f4207ba3bb2274e2cfe79b62a395a...6660b90fbbf69a15ef46d0184e36755881d6a5ae)\r\n - [ ] Test Results: [link to CI job test results for component]\r\n - [ ] Code Coverage (if available): [link to code coverage report]\r\n___\r\n**PLEASE FILL IN THE TEMPLATE ABOVE** / **DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE**\r\n\r\n## Instructions and Review Process\r\n\r\n**What is the review process and when will my changes land?**\r\n\r\nAll PRs require 2 approvals using github's [pull request reviews](https://help.github.com/articles/about-pull-request-reviews/).\r\n\r\nReviewers should be:\r\n* Developers who understand the code being modified.\r\n* Developers responsible for code that interacts with or depends on the code being modified.\r\n\r\nIt is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has **2 ship-it's**, **no red reviews**, and **all tests are green** it will be included in the [next train](https://github.com/dcos/dcos/blob/master/contributing.md).",
"title": "[WIP] make periodic reconcile of l4lb config",
"type": "issue"
},
{
"action": "created",
"author": "spahl",
"comment_id": 339488185,
"datetime": 1508969401000,
"text": "@mesosphere-mergebot bump-ee",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GoelDeepak",
"comment_id": 339670074,
"datetime": 1509025395000,
"text": "@mesosphere-mergebot bump-ee",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Your pull request's branch is not based on the most recent version of `master`. Please rebase your changes against this repo's `master` branch.",
"previous": {
"meta": "This message directly preceded comment from bot *mesosphere-mergebot* by author *spahl*:",
"text": "@mesosphere-mergebot bump-ee"
}
},
{
"bot": "Enterprise Bump PR: mesosphere/dcos-enterprise/pull/1619",
"previous": {
"meta": "This message directly preceded comment from bot *mesosphere-mergebot* by author *GoelDeepak*:",
"text": "@mesosphere-mergebot bump-ee"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *mesosphere-mergebot* by author *spahl*:",
"text": "@mesosphere-mergebot bump-ee"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *mesosphere-mergebot* by author *GoelDeepak*:",
"text": "@mesosphere-mergebot bump-ee"
}
}
] |
[
{
"action": "opened",
"author": "ingvagabund",
"comment_id": null,
"datetime": 1556111150000,
"text": "```\r\nError: packet_device.libvirt: \"facilities\": required field is not set\r\n\r\nError: packet_device.libvirt: \"facility\": [REMOVED] Use the \"facilities\" array instead, i.e. change\r\n facility = \"ewr1\"\r\nto\r\n facilities = [\"ewr1\"]\r\n```",
"title": "facility field removed in favor of facilities",
"type": "issue"
},
{
"action": "created",
"author": "zeenix",
"comment_id": 486221842,
"datetime": 1556111370000,
"text": "Seems like an obvious fix to me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ingvagabund",
"comment_id": 486223376,
"datetime": 1556111606000,
"text": "CI is rolling, hopefully it will take at most 15 minutes to run to completion.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ingvagabund",
"comment_id": 486228071,
"datetime": 1556112323000,
"text": "`/usr/bin/docker-current: error pulling image configuration: Get https://registry.svc.ci.openshift.org/v2/openshift/origin-release/blobs/sha256:43a478d6a38d27af0e4473b9e258aad3d052f8702ce553a5a0918b2a2105f18c: dial tcp 35.196.103.194:443: i/o timeout.\r\nSee '/usr/bin/docker-current run --help'.`\r\n\r\n/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ingvagabund",
"comment_id": 486252384,
"datetime": 1556114801000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ingvagabund",
"comment_id": 486272489,
"datetime": 1556117062000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ingvagabund",
"comment_id": 486287209,
"datetime": 1556119147000,
"text": "`'events is forbidden: User \"system:serviceaccount:namespace-dff96ea8-66a2-11e9-978f-0cc47ab21966:default\" cannot create events in the namespace \"namespace-dff96ea8-66a2-11e9-978f-0cc47ab21966\"'`",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@ingvagabund: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/prow/actuator-pkg-staleness | 0232a81a5517f075a505dedcf3668c049057b904 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-libvirt/147/pull-ci-openshift-cluster-api-provider-libvirt-master-actuator-pkg-staleness/12) | `/test actuator-pkg-staleness`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_cluster-api-provider-libvirt/147). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/ingvagabund). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/cluster-api-provider-libvirt/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *zeenix*:",
"text": "Seems like an obvious fix to me."
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nApproval requirements bypassed by manually added approval.\n\nThis pull-request has been approved by:\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=openshift%2Fcluster-api-provider-libvirt).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"ingvagabund\"]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *ingvagabund*:",
"text": "CI is rolling, hopefully it will take at most 15 minutes to run to completion."
}
},
{
"bot": "@ingvagabund: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/jenkins/e2e | 0232a81a5517f075a505dedcf3668c049057b904 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-libvirt/147/pull-ci-openshift-cluster-api-provider-libvirt-master-e2e/386/) | `/test e2e`\nci/prow/actuator-pkg-staleness | 0232a81a5517f075a505dedcf3668c049057b904 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-libvirt/147/pull-ci-openshift-cluster-api-provider-libvirt-master-actuator-pkg-staleness/15) | `/test actuator-pkg-staleness`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_cluster-api-provider-libvirt/147). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/ingvagabund). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/cluster-api-provider-libvirt/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *ingvagabund*:",
"text": "/retest"
}
},
{
"bot": "@ingvagabund: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/jenkins/e2e | 0232a81a5517f075a505dedcf3668c049057b904 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-libvirt/147/pull-ci-openshift-cluster-api-provider-libvirt-master-e2e/388/) | `/test e2e`\nci/prow/actuator-pkg-staleness | 0232a81a5517f075a505dedcf3668c049057b904 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-libvirt/147/pull-ci-openshift-cluster-api-provider-libvirt-master-actuator-pkg-staleness/16) | `/test actuator-pkg-staleness`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_cluster-api-provider-libvirt/147). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/ingvagabund). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/cluster-api-provider-libvirt/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *ingvagabund*:",
"text": "/retest"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *zeenix*:",
"text": "Seems like an obvious fix to me."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *ingvagabund*:",
"text": "CI is rolling, hopefully it will take at most 15 minutes to run to completion."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *ingvagabund*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *ingvagabund*:",
"text": "/retest"
}
}
] |
[
{
"action": "opened",
"author": "sdoxsee",
"comment_id": null,
"datetime": 1530033234000,
"text": "When using jx create spring, I see that the devpod comes with mvn pre-installed. I prefer using the ./mvnw approach as it makes the version of maven git-controlled (not to say that the mvn version in the pod isn't...but it's currently a mystery to me how it is chosen). In any case, although it works when i run `mvn install`, when i use the maven wrapper (`./mvnw install`) there are some permission issues and it fails (trying to write it to /root). Don't have the error available off-hand but could provide that if it's helpful.",
"title": "Spring Boot maven wrapper fails in devpod",
"type": "issue"
},
{
"action": "created",
"author": "ascheman",
"comment_id": 412326783,
"datetime": 1534061910000,
"text": "`mvnw` is now part of the Spring project setup. However, it fails in devpod since the home is set to `/root` which is mounted readonly (and/or has some symlinks to a writeable/overlay FS like `~/.m2/settings.xml` and the `localRepository`):\r\n\r\n```\r\n./mvnw clean\r\n/home/jenkins/wrk/jenkins/jenkinsx/jx-demo-180811-1200\r\nPicked up _JAVA_OPTIONS: -XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap -Dsun.zip.disableMemoryMapping=true -XX:+UseParallelGC -XX:MinHeapFreeRatio=5 -XX:MaxHeapFreeRatio=10 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -Xms10m -Xmx192m\r\nDownloading https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-bin.zip\r\n\r\nException in thread \"main\" java.io.FileNotFoundException: /root/.m2/wrapper/dists/apache-maven-3.5.3-bin/2c22a6s60afpuloj4v181qvild/apache-maven-3.5.3-bin.zip.part (No such file or directory)\r\n at java.io.FileOutputStream.open0(Native Method)\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdoxsee",
"comment_id": 498482832,
"datetime": 1559611234000,
"text": "/remove-lifecycle stale",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Stale issues rot after 30d of inactivity.\nMark the issue as fresh with `/remove-lifecycle rotten`.\nRotten issues close after an additional 30d of inactivity.\nIf this issue is safe to close now please do so with `/close`.\nProvide feedback via https://jenkins-x.io/community.\n/lifecycle rotten",
"previous": {
"meta": "This message directly preceded comment from bot *jenkins-x-bot* by author *sdoxsee*:",
"text": "/remove-lifecycle stale"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *jenkins-x-bot* by author *sdoxsee*:",
"text": "/remove-lifecycle stale"
}
}
] |
[
{
"action": "opened",
"author": "mgaido91",
"comment_id": null,
"datetime": 1550235348000,
"text": "The PR updates `he_normal`'s and `lecun_normal`'s documentation according to issue #25564 and the fix for `glorot_normal` done in https://github.com/tensorflow/tensorflow/pull/25642. In particular, it clarifies that the specified standard deviation is the one after truncation.",
"title": "Update doc for he_normal and lecun_normal according to issue 25564",
"type": "issue"
},
{
"action": "created",
"author": "mgaido91",
"comment_id": 464042787,
"datetime": 1550235680000,
"text": "I signed it!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mgaido91",
"comment_id": 464042967,
"datetime": 1550235710000,
"text": "cc @facaiy thanks.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "CLAs look good, thanks!\n\nGooglers can find more info about SignCLA and this PR by [following this link](go/prinfo/https%3A%2F%2Fgithub.com%2Ftensorflow%2Ftensorflow%2Fpull%2F25782).\n\n<!-- ok -->",
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *mgaido91*:",
"text": "I signed it!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *mgaido91*:",
"text": "I signed it!"
}
}
] |
[
{
"action": "closed",
"author": "pvdlg",
"comment_id": null,
"datetime": 1551896521000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": ":tada: This issue has been resolved in version 15.13.5 :tada:\n\nThe release is available on:\n- [npm package (@next dist-tag)](https://www.npmjs.com/package/semantic-release)\n- [GitHub release](https://github.com/semantic-release/semantic-release/releases/tag/v15.13.5)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:",
"previous": {
"meta": "This message directly preceded comment from bot *semantic-release-bot* by author *pvdlg*:",
"text": ""
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *semantic-release-bot* by author *pvdlg*:",
"text": ""
}
}
] |
[
{
"action": "opened",
"author": "chrira",
"comment_id": null,
"datetime": 1474532921000,
"text": "Added wildfly 10.1 spec pointing to wildfly-101-centos7.\r\nUpdated wildfly:latest to 10.1 image stream.",
"title": "add wildfly 10.1 spec",
"type": "issue"
},
{
"action": "created",
"author": "bparees",
"comment_id": 248883246,
"datetime": 1474545588000,
"text": "you'll need to run \"hack/update-generated-bootstrap-bindata.sh\" because we embed this imagestream in go code as well for oc cluster up.\r\n\r\nif you don't have a full dev environment available to do that, let me know and i can just redo this pull.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrira",
"comment_id": 248898376,
"datetime": 1474549674000,
"text": "pkg/bootstrap/bindata.go is now updated such that the tests pass again",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bparees",
"comment_id": 248899436,
"datetime": 1474549953000,
"text": "excellent, please squash your commits and i'll merge.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrira",
"comment_id": 248903825,
"datetime": 1474551055000,
"text": "the squashing is done",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bparees",
"comment_id": 248908991,
"datetime": 1474552244000,
"text": "[merge]",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrira",
"comment_id": 249139977,
"datetime": 1474621282000,
"text": "test/cmd/debug.sh updated to expect wildfly-101-centos7 as latest wildfly image",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bparees",
"comment_id": 249433726,
"datetime": 1474823727000,
"text": "[merge]",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[Test]ing while waiting on the merge queue",
"previous": {
"meta": "This message directly preceded comment from bot *openshift-bot* by author *chrira*:",
"text": "test/cmd/debug.sh updated to expect wildfly-101-centos7 as latest wildfly image"
}
},
{
"bot": "Evaluated for origin merge up to 4104180b6363ce6fb2809ea9da0c2ae769485e39",
"previous": {
"meta": "This message directly preceded comment from bot *openshift-bot* by author *bparees*:",
"text": "[merge]"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *openshift-bot* by author *chrira*:",
"text": "test/cmd/debug.sh updated to expect wildfly-101-centos7 as latest wildfly image"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *openshift-bot* by author *bparees*:",
"text": "[merge]"
}
}
] |
[
{
"action": "opened",
"author": "raboof",
"comment_id": null,
"datetime": 1552468567000,
"text": "Refs #26502",
"title": "Explicitly require jdk9+ for javadoc generation",
"type": "issue"
},
{
"action": "created",
"author": "raboof",
"comment_id": 472342013,
"datetime": 1552468845000,
"text": "(removed javadoc generation from Jenkins, as it clearly didn't test anything anyway. javadoc problems will eventually be caught by the nightly akka-docs, which seems soon enough)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "raboof",
"comment_id": 472342035,
"datetime": 1552468850000,
"text": "PLS BUILD",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "raboof",
"comment_id": 472348771,
"datetime": 1552470014000,
"text": "PLS BUILD",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Test FAILed.",
"previous": {
"meta": "This message directly preceded comment from bot *akka-ci* by author *raboof*:",
"text": "PLS BUILD"
}
},
{
"bot": "Test PASSed.",
"previous": {
"meta": "This message directly preceded comment from bot *akka-ci* by author *raboof*:",
"text": "PLS BUILD"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *akka-ci* by author *raboof*:",
"text": "PLS BUILD"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *akka-ci* by author *raboof*:",
"text": "PLS BUILD"
}
}
] |
[
{
"action": "opened",
"author": "deads2k",
"comment_id": null,
"datetime": 1550167901000,
"text": "cluster-config-operator is rendered and it produces CRD manifests, the ones\r\nin the installer are duplicates. This eliminates the cruft.\r\n\r\n/assign @wking @abhinavdahiya",
"title": "bootkube: remove duplicate CRD manifests",
"type": "issue"
},
{
"action": "created",
"author": "wking",
"comment_id": 463737892,
"datetime": 1550168985000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abhinavdahiya",
"comment_id": 463738213,
"datetime": 1550169033000,
"text": ":yay: /approve\r\n\r\nIf the CI goes green i'll `lgtm`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "deads2k",
"comment_id": 463800590,
"datetime": 1550179053000,
"text": "Known flake failures, well past bootstrapping. This completes work to clean up our CRD manifest story. Merging.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abhinavdahiya",
"comment_id": 463801007,
"datetime": 1550179118000,
"text": "Talking to @ironcladlou the previous failure \r\nfrom [e2e-aws](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/1254/pull-ci-openshift-installer-master-e2e-aws/3708)\r\n\r\nwas known flake, so should be safe to override for you @deads2k",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/openshift/installer/pull/1254#\" title=\"Author self-approved\">deads2k</a>*, *<a href=\"https://github.com/openshift/installer/pull/1254#issuecomment-463737892\" title=\"LGTM\">wking</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=openshift%2Finstaller).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/openshift/installer/blob/master/OWNERS)~~ [wking]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *abhinavdahiya*:",
"text": ":yay: /approve\r\n\r\nIf the CI goes green i'll `lgtm`"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *abhinavdahiya*:",
"text": ":yay: /approve\r\n\r\nIf the CI goes green i'll `lgtm`"
}
}
] |
[
{
"action": "opened",
"author": "liyinan926",
"comment_id": null,
"datetime": 1504897439000,
"text": "**What this PR does / why we need it**:\r\nThis PR setup and added initial integration tests for the DaemonSet controller. All tests included were ported from their unit test counterparts that currently use fake client, informers, reactor, etc. \r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: #52191.\r\n\r\n**Special notes for your reviewer**:\r\n@kow3ns \r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```",
"title": "Initial integration test setup for DaemonSet controller",
"type": "issue"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 328188648,
"datetime": 1504897539000,
"text": "/unassign @bowei\r\n/unassign @ixdy\r\n/assign @kow3ns",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xiangpengzhao",
"comment_id": 328312181,
"datetime": 1505004189000,
"text": "/ok-to-test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 328313599,
"datetime": 1505006983000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 331773023,
"datetime": 1506312839000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 337975726,
"datetime": 1508433285000,
"text": "@kow3ns can you take a look?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 338790746,
"datetime": 1508791457000,
"text": "@kow3ns this is the PR I mentioned.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 338805156,
"datetime": 1508794873000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kow3ns",
"comment_id": 339738626,
"datetime": 1509038690000,
"text": "/approve",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 339741196,
"datetime": 1509039248000,
"text": "Updated the BUILD file.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 339742558,
"datetime": 1509039534000,
"text": "/assign @mikedanese",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cjwagner",
"comment_id": 339834928,
"datetime": 1509062738000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xiangpengzhao",
"comment_id": 339843616,
"datetime": 1509066382000,
"text": "```\r\nI1027 00:16:13.422] Verifying hack/make-rules/../../hack/verify-bazel.sh\r\nI1027 00:16:31.893] diff -Naupr /go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD /tmp/verify-bazel.xWgF3c/go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD\r\nI1027 00:16:31.893] --- /go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD\t2017-10-27 00:10:16.262995885 +0000\r\nI1027 00:16:31.893] +++ /tmp/verify-bazel.xWgF3c/go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD\t2017-10-27 00:16:25.471230559 +0000\r\nI1027 00:16:31.894] @@ -15,7 +15,6 @@ go_test(\r\nI1027 00:16:31.894] importpath = \"k8s.io/kubernetes/test/integration/daemonset\",\r\nI1027 00:16:31.894] tags = [\"integration\"],\r\nI1027 00:16:31.894] deps = [\r\nI1027 00:16:31.894] - \"//pkg/api:go_default_library\",\r\nI1027 00:16:31.894] \"//pkg/api/v1/pod:go_default_library\",\r\nI1027 00:16:31.895] \"//pkg/controller/daemon:go_default_library\",\r\nI1027 00:16:31.895] \"//test/integration/framework:go_default_library\",\r\nI1027 00:16:31.895] \r\nI1027 00:16:31.895] Run ./hack/update-bazel.sh\r\nI1027 00:16:32.636] FAILED hack/make-rules/../../hack/verify-bazel.sh\t19s\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 339872024,
"datetime": 1509079897000,
"text": "Fixed the bazel build file.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 340562371,
"datetime": 1509392799000,
"text": "@mikedanese Can you take a look? Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikedanese",
"comment_id": 340847492,
"datetime": 1509472370000,
"text": "/approve",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@liyinan926: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-federation-e2e-gce | 28e06c7efcc6942ea7e53f4a9b5932b226e5d752 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26313/) | `/test pull-kubernetes-federation-e2e-gce`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *xiangpengzhao*:",
"text": "/ok-to-test"
}
},
{
"bot": "@liyinan926: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-federation-e2e-gce | 28e06c7efcc6942ea7e53f4a9b5932b226e5d752 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26313/) | `/test pull-kubernetes-federation-e2e-gce`\npull-kubernetes-e2e-gce-etcd3 | 28e06c7efcc6942ea7e53f4a9b5932b226e5d752 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-e2e-gce-etcd3/53455/) | `/test pull-kubernetes-e2e-gce-etcd3`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:",
"text": "/retest"
}
},
{
"bot": "@liyinan926: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-federation-e2e-gce | c0511d2b88b595835392b90fd6a5ff2e8059a066 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26674/) | `/test pull-kubernetes-federation-e2e-gce`\npull-kubernetes-unit | 4a1cb7ac1747ee53c197593294ed5b3159f2e1cc | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-unit/60024/) | `/test pull-kubernetes-unit`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:",
"text": "@kow3ns this is the PR I mentioned."
}
},
{
"bot": "@liyinan926: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-federation-e2e-gce | c0511d2b88b595835392b90fd6a5ff2e8059a066 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26674/) | `/test pull-kubernetes-federation-e2e-gce`\npull-kubernetes-verify | 4a1cb7ac1747ee53c197593294ed5b3159f2e1cc | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-verify/57679/) | `/test pull-kubernetes-verify`\npull-kubernetes-unit | 4a1cb7ac1747ee53c197593294ed5b3159f2e1cc | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-unit/60041/) | `/test pull-kubernetes-unit`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:",
"text": "/retest"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/52192#issuecomment-339738626\" title=\"Approved\">kow3ns</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/52192#\" title=\"Author self-approved\">liyinan926</a>*\nWe suggest the following additional approver: **mikedanese**\n\nAssign the PR to them by writing `/assign @mikedanese` in a comment when ready.\n\nAssociated issue: *52191*\n\nThe full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n\n<details open>\nNeeds approval from an approver in each of these OWNERS Files:\n\n- **[pkg/controller/daemon/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/OWNERS)**\n- ~~[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)~~ [kow3ns]\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"mikedanese\"]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *kow3ns*:",
"text": "/approve"
}
},
{
"bot": "@liyinan926: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-federation-e2e-gce | c0511d2b88b595835392b90fd6a5ff2e8059a066 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26674/) | `/test pull-kubernetes-federation-e2e-gce`\npull-kubernetes-unit | 84919af28b997746587b247dd417f5fbd6ce049c | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-unit/60850/) | `/test pull-kubernetes-unit`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:",
"text": "/assign @mikedanese"
}
},
{
"bot": "@liyinan926: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-federation-e2e-gce | c0511d2b88b595835392b90fd6a5ff2e8059a066 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26674/) | `/test pull-kubernetes-federation-e2e-gce`\npull-kubernetes-unit | 81b163341045a8219ce3f7b89d8c3d8a97f77a2b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-unit/60927/) | `/test pull-kubernetes-unit`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *cjwagner*:",
"text": "/retest"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/52192#issuecomment-339738626\" title=\"Approved\">kow3ns</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/52192#\" title=\"Author self-approved\">liyinan926</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/52192#issuecomment-340847492\" title=\"Approved\">mikedanese</a>*\n\nAssociated issue: *52191*\n\nThe full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n\n<details >\nNeeds approval from an approver in each of these OWNERS Files:\n\n- ~~[pkg/controller/daemon/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/OWNERS)~~ [mikedanese]\n- ~~[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)~~ [kow3ns,mikedanese]\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *mikedanese*:",
"text": "/approve"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *xiangpengzhao*:",
"text": "/ok-to-test"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:",
"text": "@kow3ns this is the PR I mentioned."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *kow3ns*:",
"text": "/approve"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:",
"text": "/assign @mikedanese"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *cjwagner*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *mikedanese*:",
"text": "/approve"
}
}
] |
[
{
"action": "opened",
"author": "sebastienvas",
"comment_id": null,
"datetime": 1564012999000,
"text": "Remove all the persistent volumes things, since we have using CRDs for more than a year now.",
"title": "Update boskos stateful set to use RollingUpdate (default @v1)",
"type": "issue"
},
{
"action": "created",
"author": "sebastienvas",
"comment_id": 515312242,
"datetime": 1564118178000,
"text": "/assign @Katharine",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 515316607,
"datetime": 1564119596000,
"text": "/lgtm\r\n/hold",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krzyzacy",
"comment_id": 517475995,
"datetime": 1564697343000,
"text": "(feel free to hold cancel when you are around)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sebastienvas",
"comment_id": 517501228,
"datetime": 1564704916000,
"text": "is this going to auto deploy ?\r\nI don't think I have access to that cluster",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Katharine",
"comment_id": 519988821,
"datetime": 1565369498000,
"text": "I don't believe this will auto-deploy. Oncall (currently @mirandachrist) should probably deploy this after it merges.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stevekuznetsov",
"comment_id": 528447612,
"datetime": 1567700563000,
"text": "Why isn't `boskos` a Deployment?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sebastienvas",
"comment_id": 528609273,
"datetime": 1567721196000,
"text": "Good point. However in order to deploy this we want to make sure the stateful set is deleted before. Not sure how on call wants to handle this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stevekuznetsov",
"comment_id": 528744981,
"datetime": 1567754896000,
"text": "I think it would be best to list the `kubectl` commands you expect here so that on-call can just execute them and post the output. I think we'd want to manually delete the StatefulSet, then the PV, then apply the Deployment.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sebastienvas",
"comment_id": 528768504,
"datetime": 1567759392000,
"text": "correct:\r\nkubectl delete -n test-pods statefulset boskos\r\nwait for pod to be gone\r\nkubectl delete -n test-pods pv boskos-storage\r\nkubectl apply -f boskos/deployment.yaml",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chases2",
"comment_id": 528959766,
"datetime": 1567793746000,
"text": "/hold cancel\r\n/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chases2",
"comment_id": 529608439,
"datetime": 1568053848000,
"text": "In order to remove the persistent volume, the persistent volume claim also needed to be removed. On the k8s build cluster, this was named `boskos-volume-boskos-0`.\r\n\r\n```\r\nstatefulset.apps \"boskos\" deleted\r\n\r\npersistentvolume \"boskos-storage\" deleted\r\n\r\nclusterrole.rbac.authorization.k8s.io/boskos unchanged\r\nserviceaccount/boskos unchanged\r\nclusterrolebinding.rbac.authorization.k8s.io/crd-creator unchanged\r\ndeployment.apps/boskos created\r\n```\r\n\r\n```\r\nkubectl delete -n test-pods pvc boskos-volume-boskos-0\r\npersistentvolumeclaim \"boskos-volume-boskos-0\" deleted\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sebastienvas",
"comment_id": 529613280,
"datetime": 1568054579000,
"text": "Thanks @chases2",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "LGTM label has been added. <details>Git tree hash: 8320f0242159894b11361ebbdba0d02a25bd5932</details>",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:",
"text": "/lgtm\r\n/hold"
}
},
{
"bot": "New changes are detected. LGTM label has been removed.",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *stevekuznetsov*:",
"text": "Why isn't `boskos` a Deployment?"
}
},
{
"bot": "LGTM label has been added. <details>Git tree hash: 81241b6b27cebb3c40a214c02f7719749d3948e4</details>",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *chases2*:",
"text": "/hold cancel\r\n/lgtm"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:",
"text": "/lgtm\r\n/hold"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *stevekuznetsov*:",
"text": "Why isn't `boskos` a Deployment?"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *chases2*:",
"text": "/hold cancel\r\n/lgtm"
}
}
] |
[
{
"action": "opened",
"author": "mwoehlke-kitware",
"comment_id": null,
"datetime": 1554749054000,
"text": "Add a new method to `metadata` to retrieve an item if present, or clearly indicate (by returning a null pointer) if no such item is present. This saves having to perform two lookups to avoid the \"undefined result\" of the old look-up method. Also update users to use the new method, and remove the no-longer-needed `find`.",
"title": " Improve API for metadata collections",
"type": "issue"
},
{
"action": "created",
"author": "linus-sherrill",
"comment_id": 482271979,
"datetime": 1555010714000,
"text": "I agree with finding a way around querying the map twice, but my concern with returning a null_ptr, is that forgetting to check the return value is a very common mistake. I am not sure what the alternative would be? optional<>?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mwoehlke-kitware",
"comment_id": 482299618,
"datetime": 1555014609000,
"text": "Yeah, I think that would work (I think `optional<T&>` does not add overhead compared to `T*` provided you use its `operator*` rather than `value`), but alas, that requires C++17... unless we want to roll our own version until then? (It would be easy to make one that only holds references... IIRC all the tricky bits have to do with holding *values* and exception safety.)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mleotta",
"comment_id": 484603030,
"datetime": 1555608573000,
"text": "One option here is to keep the `get` function, but have it return a reference as before and go back to returning the special unknown metadata object when a value is not found. To avoid the use of `has` and the double search we could add a `virtual bool is_valid();` member function that returns true for all real metadata items and return false for the special unknown metadata object. For convenience you could then define a boolean cast function for the metadata item that calls this `is_valid` function. So you could then use the metadata item much like we use the pointer in this branch with\r\n```c++\r\nif(auto const& item = md.get(NAME))\r\n{\r\n double val = item.as_double();\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "linus-sherrill",
"comment_id": 484614970,
"datetime": 1555610048000,
"text": "I like the behaviour of Matt's suggestion. The unknown metadata object could then throw something. This is better than a seg-fault.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mwoehlke-kitware",
"comment_id": 484618681,
"datetime": 1555610578000,
"text": "The down side of @mleotta's suggestion (and we had previously discussed exactly this option) is that it adds the overhead of a *virtual* call to just about every user. This isn't Java/Python; we use pointers (often smart pointers, but those still don't protect you against dereferencing a null) all over the place. *If* we were to do that, I would prefer to do it by re-adding / un-removing `find` with the safer behavior. \"Don't pay for what you don't need.\"",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mleotta",
"comment_id": 484642458,
"datetime": 1555613945000,
"text": "I think the expense of a virtual function call to check if an object is valid is negligible here. I also like the idea @linus-sherrill had of throwing an exception if you try to access values from in valid item. This allows users to not check if a metadata item is valid (in some cases you can assume that it should always be there) and then catch exceptions in the rare case that something went wrong.\r\n\r\nIf you are really against the virtual function you could have the unknown item be a static, globally accessible instance and then you could just compare the memory address to see if what you got was the one and only unknown item. However, I would still go with the virtual function.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mwoehlke-kitware",
"comment_id": 484644515,
"datetime": 1555614223000,
"text": "Jenkins test this please",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mwoehlke-kitware",
"comment_id": 486438572,
"datetime": 1556142171000,
"text": "So... in this revision, I've basically left `find` alone (aside from clarifying in the documentation that it *will* return a \"usable\" object), but added `metadata_item::is_valid`. If you want safety, use `find`. If you want efficiency, use `get`, especially if you are writing something like `if (auto i = md.get(...)) { ...use i... }`. Note that `get` is approximately as safe as `std::map::find`¹, and *exactly* as safe as any of the many, *many* functions in KWIVER that return some flavor of `std::shared_ptr`.\r\n\r\n(¹ Both are [UB](https://en.wikipedia.org/wiki/Undefined_behavior) if the item was not found and you try to use it without checking. The latter may crash or may lead to silent memory corruption, whereas `get` almost certainly *will* crash.)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mwoehlke-kitware",
"comment_id": 491931586,
"datetime": 1557771588000,
"text": "Since I am apparently outvoted, this version a) just has `find` and b) requires calling the virtual method `is_valid`¹ to know if the result of `find` is a \"real\" item or the \"fake\" 'not found' item.\r\n\r\n(¹ ...which will almost always happen implicitly via `operator bool`.)",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[KwiverCentOSPR experienced errors.](https://open.cdash.org/viewBuildError.php?buildid=5866203)",
"previous": {
"meta": "This message directly preceded comment from bot *KWCVRobot* by author *mwoehlke-kitware*:",
"text": "Jenkins test this please"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *KWCVRobot* by author *mwoehlke-kitware*:",
"text": "Jenkins test this please"
}
}
] |
[
{
"action": "opened",
"author": "0verc1ocker",
"comment_id": null,
"datetime": 1551974166000,
"text": "I need this for my future self. It is better than searching the web everytime to find all the configMap values that can be set for the nginx-ingress controller configMap. :)\r\n\r\n#### What this PR does / why we need it:\r\n\r\nJust adding a link to configMap for nginx-ingress so it is easier to find the values for the nginx-ingress controller configMap.\r\n\r\n#### Which issue this PR fixes\r\n\r\nThis is just README docs improvement.\r\n\r\n#### Special notes for your reviewer:\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [X] [DCO](https://github.com/helm/charts/blob/master/CONTRIBUTING.md#sign-your-work) signed",
"title": "docs(README.md): add link to docs for nginx configMap :relaxed:",
"type": "issue"
},
{
"action": "created",
"author": "0verc1ocker",
"comment_id": 470584226,
"datetime": 1551974488000,
"text": "Why does nginx-ingress chart need a version bump? I only updated the README. :cry:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "0verc1ocker",
"comment_id": 480834405,
"datetime": 1554730561000,
"text": "@mgoodness Can we look into merging this link update?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "0verc1ocker",
"comment_id": 490560019,
"datetime": 1557333506000,
"text": "@mgoodness Can we look into merging this link update?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ChiefAlexander",
"comment_id": 493253375,
"datetime": 1558045723000,
"text": "/assign\r\n/ok-to-test\r\n\r\nYou are going to have to bump the version before we can merge 😆",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "0verc1ocker",
"comment_id": 493543011,
"datetime": 1558115718000,
"text": "@ChiefAlexander Hi, can you try now? I bumped up the nignx-ingress chart version and rebased from master. :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ChiefAlexander",
"comment_id": 493544697,
"datetime": 1558116031000,
"text": "/lgtm\r\n\r\nThanks for the PR!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.",
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *0verc1ocker*:",
"text": "Why does nginx-ingress chart need a version bump? I only updated the README. :cry:"
}
},
{
"bot": "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.",
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *0verc1ocker*:",
"text": "@mgoodness Can we look into merging this link update?"
}
},
{
"bot": "@0verc1ocker: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-charts-e2e | 4f72a297c4dcfe3eb5c14c552a1d9bb772286455 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/helm_charts/11993/pull-charts-e2e/1129151807143022592/) | `/test pull-charts-e2e`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=helm&repo=charts&pr=11993). [Your PR dashboard](https://gubernator.k8s.io/pr/0verc1ocker). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/helm/charts/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ChiefAlexander*:",
"text": "/assign\r\n/ok-to-test\r\n\r\nYou are going to have to bump the version before we can merge 😆"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/helm/charts/pull/11993#\" title=\"Author self-approved\">0verc1ocker</a>*, *<a href=\"https://github.com/helm/charts/pull/11993#issuecomment-493544697\" title=\"LGTM\">ChiefAlexander</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=helm%2Fcharts).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[stable/nginx-ingress/OWNERS](https://github.com/helm/charts/blob/master/stable/nginx-ingress/OWNERS)~~ [ChiefAlexander]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ChiefAlexander*:",
"text": "/lgtm\r\n\r\nThanks for the PR!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *0verc1ocker*:",
"text": "Why does nginx-ingress chart need a version bump? I only updated the README. :cry:"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *0verc1ocker*:",
"text": "@mgoodness Can we look into merging this link update?"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ChiefAlexander*:",
"text": "/assign\r\n/ok-to-test\r\n\r\nYou are going to have to bump the version before we can merge 😆"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ChiefAlexander*:",
"text": "/lgtm\r\n\r\nThanks for the PR!"
}
}
] |
[
{
"action": "opened",
"author": "binlijin",
"comment_id": null,
"datetime": 1556593600000,
"text": "…ly for meta).",
"title": "HBASE-22280 Separate read/write handler for priority request(especial…",
"type": "issue"
},
{
"action": "created",
"author": "carp84",
"comment_id": 492213355,
"datetime": 1557836315000,
"text": "Please also check the `mvninstall`, `checkstyle` and UT error reported by robot",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "saintstack",
"comment_id": 505126875,
"datetime": 1561401052000,
"text": "Any updates here @binlijin ? Thanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "binlijin",
"comment_id": 505247163,
"datetime": 1561428095000,
"text": "@saintstack i can not do the contribution now for some reason, someone else can take it over.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "binlijin",
"comment_id": 557068101,
"datetime": 1574340179000,
"text": "@carp84 fix the ut, the test need at least two write handler when use separate read/write handlers.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "carp84",
"comment_id": 562060375,
"datetime": 1575540450000,
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "binlijin",
"comment_id": 562073884,
"datetime": 1575542505000,
"text": "@carp84 run this tests and passed locally, they're not related to the patch.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": ":broken_heart: **-1 overall**\r\n\r\n\r\n\r\n\r\n\r\n\r\n| Vote | Subsystem | Runtime | Comment |\r\n|:----:|----------:|--------:|:--------|\r\n| 0 | reexec | 30 | Docker mode activated. |\r\n||| _ Prechecks _ |\r\n| +1 | hbaseanti | 0 | Patch does not have any anti-patterns. |\r\n| +1 | @author | 0 | The patch does not contain any @author tags. |\r\n| -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |\r\n||| _ master Compile Tests _ |\r\n| +1 | mvninstall | 349 | master passed |\r\n| +1 | compile | 85 | master passed |\r\n| +1 | checkstyle | 79 | master passed |\r\n| +1 | shadedjars | 345 | branch has no errors when building our shaded downstream artifacts. |\r\n| +1 | findbugs | 418 | master passed |\r\n| +1 | javadoc | 52 | master passed |\r\n||| _ Patch Compile Tests _ |\r\n| -1 | mvninstall | 267 | root in the patch failed. |\r\n| +1 | compile | 90 | the patch passed |\r\n| +1 | javac | 90 | the patch passed |\r\n| -1 | checkstyle | 85 | hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) |\r\n| +1 | whitespace | 0 | The patch has no whitespace issues. |\r\n| -1 | shadedjars | 315 | patch has 11 errors when building our shaded downstream artifacts. |\r\n| -1 | hadoopcheck | 184 | The patch causes 11 errors with Hadoop v2.8.5. |\r\n| -1 | hadoopcheck | 368 | The patch causes 11 errors with Hadoop v2.9.2. |\r\n| -1 | hadoopcheck | 570 | The patch causes 11 errors with Hadoop v3.1.2. |\r\n| +1 | findbugs | 345 | the patch passed |\r\n| +1 | javadoc | 55 | the patch passed |\r\n||| _ Other Tests _ |\r\n| -1 | unit | 98 | hbase-server in the patch failed. |\r\n| +1 | asflicense | 19 | The patch does not generate ASF License warnings. |\r\n| | | 3296 | |\r\n\r\n\r\n| Subsystem | Report/Notes |\r\n|----------:|:-------------|\r\n| Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/Dockerfile |\r\n| GITHUB PR | https://github.com/apache/hbase/pull/202 |\r\n| Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |\r\n| uname | Linux 4571e48797fb 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux |\r\n| Build tool | maven |\r\n| Personality | /testptch/patchprocess/precommit/personality/provided.sh |\r\n| git revision | master / ada772a1d3 |\r\n| maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |\r\n| Default Java | 1.8.0_181 |\r\n| findbugs | v3.1.11 |\r\n| mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-mvninstall-root.txt |\r\n| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/diff-checkstyle-hbase-server.txt |\r\n| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-shadedjars.txt |\r\n| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-2.8.5.txt |\r\n| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-2.9.2.txt |\r\n| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-3.1.2.txt |\r\n| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-unit-hbase-server.txt |\r\n| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/testReport/ |\r\n| Max. process+thread count | 50 (vs. ulimit of 10000) |\r\n| modules | C: hbase-server U: hbase-server |\r\n| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/console |\r\n| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |\r\n\r\n\r\nThis message was automatically generated.",
"previous": {
"meta": "This message directly preceded comment from bot *Apache-HBase* by author *carp84*:",
"text": "Please also check the `mvninstall`, `checkstyle` and UT error reported by robot"
}
},
{
"bot": ":broken_heart: **-1 overall**\r\n\r\n\r\n\r\n\r\n\r\n\r\n| Vote | Subsystem | Runtime | Comment |\r\n|:----:|----------:|--------:|:--------|\r\n| 0 | reexec | 31 | Docker mode activated. |\r\n||| _ Prechecks _ |\r\n| +1 | hbaseanti | 0 | Patch does not have any anti-patterns. |\r\n| +1 | @author | 0 | The patch does not contain any @author tags. |\r\n| -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |\r\n||| _ master Compile Tests _ |\r\n| +1 | mvninstall | 230 | master passed |\r\n| +1 | compile | 50 | master passed |\r\n| +1 | checkstyle | 65 | master passed |\r\n| +1 | shadedjars | 261 | branch has no errors when building our shaded downstream artifacts. |\r\n| +1 | findbugs | 204 | master passed |\r\n| +1 | javadoc | 30 | master passed |\r\n||| _ Patch Compile Tests _ |\r\n| -1 | mvninstall | 155 | root in the patch failed. |\r\n| +1 | compile | 53 | the patch passed |\r\n| +1 | javac | 53 | the patch passed |\r\n| -1 | checkstyle | 67 | hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) |\r\n| +1 | whitespace | 0 | The patch has no whitespace issues. |\r\n| -1 | shadedjars | 207 | patch has 11 errors when building our shaded downstream artifacts. |\r\n| -1 | hadoopcheck | 115 | The patch causes 11 errors with Hadoop v2.8.5. |\r\n| -1 | hadoopcheck | 229 | The patch causes 11 errors with Hadoop v2.9.2. |\r\n| -1 | hadoopcheck | 349 | The patch causes 11 errors with Hadoop v3.1.2. |\r\n| +1 | findbugs | 207 | the patch passed |\r\n| +1 | javadoc | 33 | the patch passed |\r\n||| _ Other Tests _ |\r\n| -1 | unit | 55 | hbase-server in the patch failed. |\r\n| +1 | asflicense | 13 | The patch does not generate ASF License warnings. |\r\n| | | 2068 | |\r\n\r\n\r\n| Subsystem | Report/Notes |\r\n|----------:|:-------------|\r\n| Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/Dockerfile |\r\n| GITHUB PR | https://github.com/apache/hbase/pull/202 |\r\n| Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |\r\n| uname | Linux abb2e4ccaa87 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux |\r\n| Build tool | maven |\r\n| Personality | /testptch/patchprocess/precommit/personality/provided.sh |\r\n| git revision | master / 438bf3284e |\r\n| maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |\r\n| Default Java | 1.8.0_181 |\r\n| findbugs | v3.1.11 |\r\n| mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-mvninstall-root.txt |\r\n| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/diff-checkstyle-hbase-server.txt |\r\n| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-shadedjars.txt |\r\n| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-2.8.5.txt |\r\n| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-2.9.2.txt |\r\n| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-3.1.2.txt |\r\n| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-unit-hbase-server.txt |\r\n| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/testReport/ |\r\n| Max. process+thread count | 96 (vs. ulimit of 10000) |\r\n| modules | C: hbase-server U: hbase-server |\r\n| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/console |\r\n| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |\r\n\r\n\r\nThis message was automatically generated.",
"previous": {
"meta": "This message directly preceded comment from bot *Apache-HBase* by author *binlijin*:",
"text": "@saintstack i can not do the contribution now for some reason, someone else can take it over."
}
},
{
"bot": ":broken_heart: **-1 overall**\r\n\r\n\r\n\r\n\r\n\r\n\r\n| Vote | Subsystem | Runtime | Comment |\r\n|:----:|----------:|--------:|:--------|\r\n| +0 :ok: | reexec | 0m 33s | Docker mode activated. |\r\n||| _ Prechecks _ |\r\n| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |\r\n| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |\r\n| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |\r\n| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |\r\n||| _ master Compile Tests _ |\r\n| +1 :green_heart: | mvninstall | 5m 23s | master passed |\r\n| +1 :green_heart: | compile | 0m 55s | master passed |\r\n| +1 :green_heart: | checkstyle | 1m 20s | master passed |\r\n| +1 :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. |\r\n| +1 :green_heart: | javadoc | 0m 38s | master passed |\r\n| +0 :ok: | spotbugs | 4m 9s | Used deprecated FindBugs config; considering switching to SpotBugs. |\r\n| +1 :green_heart: | findbugs | 4m 6s | master passed |\r\n||| _ Patch Compile Tests _ |\r\n| +1 :green_heart: | mvninstall | 5m 3s | the patch passed |\r\n| +1 :green_heart: | compile | 0m 55s | the patch passed |\r\n| +1 :green_heart: | javac | 0m 55s | the patch passed |\r\n| +1 :green_heart: | checkstyle | 1m 19s | the patch passed |\r\n| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |\r\n| +1 :green_heart: | shadedjars | 4m 36s | patch has no errors when building our shaded downstream artifacts. |\r\n| +1 :green_heart: | hadoopcheck | 15m 31s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |\r\n| +1 :green_heart: | javadoc | 0m 37s | the patch passed |\r\n| +1 :green_heart: | findbugs | 4m 8s | the patch passed |\r\n||| _ Other Tests _ |\r\n| -1 :x: | unit | 167m 23s | hbase-server in the patch failed. |\r\n| +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. |\r\n| | | 224m 12s | |\r\n\r\n\r\n| Reason | Tests |\r\n|-------:|:------|\r\n| Failed junit tests | hadoop.hbase.master.TestClusterRestartFailoverSplitWithoutZk |\r\n| | hadoop.hbase.replication.TestReplicationDroppedTables |\r\n| | hadoop.hbase.master.TestClusterRestartFailover |\r\n\r\n\r\n| Subsystem | Report/Notes |\r\n|----------:|:-------------|\r\n| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/Dockerfile |\r\n| GITHUB PR | https://github.com/apache/hbase/pull/202 |\r\n| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |\r\n| uname | Linux d9f62458b8d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |\r\n| Build tool | maven |\r\n| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh |\r\n| git revision | master / 4ea792246f |\r\n| Default Java | 1.8.0_181 |\r\n| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-unit-hbase-server.txt |\r\n| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/testReport/ |\r\n| Max. process+thread count | 5054 (vs. ulimit of 10000) |\r\n| modules | C: hbase-server U: hbase-server |\r\n| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/console |\r\n| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |\r\n| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |\r\n\r\n\r\nThis message was automatically generated.",
"previous": {
"meta": "This message directly preceded comment from bot *Apache-HBase* by author *binlijin*:",
"text": "@carp84 fix the ut, the test need at least two write handler when use separate read/write handlers."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *Apache-HBase* by author *carp84*:",
"text": "Please also check the `mvninstall`, `checkstyle` and UT error reported by robot"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *Apache-HBase* by author *binlijin*:",
"text": "@saintstack i can not do the contribution now for some reason, someone else can take it over."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *Apache-HBase* by author *binlijin*:",
"text": "@carp84 fix the ut, the test need at least two write handler when use separate read/write handlers."
}
}
] |
[
{
"action": "closed",
"author": "lenznerm",
"comment_id": null,
"datetime": 1570143096000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "## Consider this issue finished! :white_check_mark:\n\n<hr>\n<h3 align=\"center\">Head over to <a href=\"https://github.com/lenznerm/github-slideshow/issues/2\">the next issue</a> now!</h3>",
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *lenznerm*:",
"text": ""
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *lenznerm*:",
"text": ""
}
}
] |
[
{
"action": "created",
"author": "msatrowsky",
"comment_id": 419503605,
"datetime": 1536339759000,
"text": "I am new to Github and need some advice for web development. Any advice on where to begin would be greatly appreciated. @github",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "msatrowsky",
"comment_id": null,
"datetime": 1536341690000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "## Consider this issue finished! :white_check_mark:\n\n<hr>\n<h3 align=\"center\">Head over to <a href=\"https://github.com/msatrowsky/github-slideshow/issues/2\">the next issue</a> now!</h3>",
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *msatrowsky*:",
"text": ""
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *msatrowsky*:",
"text": ""
}
}
] |
[
{
"action": "opened",
"author": "seanforyou23",
"comment_id": null,
"datetime": 1572290487000,
"text": "I noticed that when a consuming typescript app uses the `strictFunctionTypes` compiler option, following certain component examples causes errors to be thrown. Below is an example of what the error looks like, a typical type mismatch from what I can tell..\r\n\r\n<img width=\"1189\" alt=\"Screen Shot 2019-10-28 at 3 00 24 PM\" src=\"https://user-images.githubusercontent.com/5942899/67710375-33bdd400-f996-11e9-9cc3-b9b91b96ad75.png\">\r\n\r\nThese are the component demos in the react-integration package I see that are affected.\r\n\r\n- ContextSelectorDemo/ContextSelectorDemo.tsx\r\n- SelectDemo/SelectDemo.tsx\r\n- TableDemo/TableActionsDemo.tsx\r\n- TableDemo/TableCompactExpandableDemo.tsx\r\n- TableDemo/TableSortableForCompoundExpandableDemo.tsx\r\n- TabsDemo/TabsDemo.tsx\r\n- TabsDemo/TabsStringEventKeyDemo.tsx",
"title": "Some components don't meet `strictFunctionTypes` requirements",
"type": "issue"
},
{
"action": "created",
"author": "seanforyou23",
"comment_id": 572106030,
"datetime": 1578495361000,
"text": "This is a critical issue, commenting so stale bot doesn't close it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "seanforyou23",
"comment_id": 596523403,
"datetime": 1583760485000,
"text": "Ping to keep this issue active",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "evwilkin",
"comment_id": 620865230,
"datetime": 1588109304000,
"text": "Resolved in #4019",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "evwilkin",
"comment_id": null,
"datetime": 1588109305000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.",
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *seanforyou23*:",
"text": "This is a critical issue, commenting so stale bot doesn't close it."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *seanforyou23*:",
"text": "This is a critical issue, commenting so stale bot doesn't close it."
}
}
] |
[
{
"action": "opened",
"author": "jstrachan",
"comment_id": null,
"datetime": 1563948482000,
"text": "",
"title": "chore: work around for regression in verify preinstall",
"type": "issue"
},
{
"action": "created",
"author": "jstrachan",
"comment_id": 514493734,
"datetime": 1563948491000,
"text": "/test boot",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jstrachan",
"comment_id": 514496419,
"datetime": 1563949190000,
"text": "/test boot",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jstrachan",
"comment_id": 514499456,
"datetime": 1563949908000,
"text": "/test boot",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@jstrachan: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nboot-lh-ghe | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/59) | `/test boot-lh-ghe`\n\n[View all Builds for this Pull Request](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344) \n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *jenkins-x-bot* by author *jstrachan*:",
"text": "/test boot"
}
},
{
"bot": "@jstrachan: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nboot-lh-ghe | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/59) | `/test boot-lh-ghe`\nboot-lh-bs | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/60) | `/test boot-lh-bs`\nboot-local | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/56) | `/test boot-local`\nboot-lh | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/58) | `/test boot-lh`\nboot-vault | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/57) | `/test boot-vault`\ntiller | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/52) | `/test tiller`\n\n[View all Builds for this Pull Request](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344) \n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *jenkins-x-bot* by author *jstrachan*:",
"text": "/test boot"
}
},
{
"bot": "@jstrachan: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\ntiller | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/52) | `/test tiller`\ntekton | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/54) | `/test tekton`\nboot-local | e22085ff34228f3e1afde1e9890334a3e0dbefdb | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/66) | `/test boot-local`\ngitops | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/53) | `/test gitops`\nng | 228c280c0dd543cde845a6bf2c38442000f578f8 | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/55) | `/test ng`\nboot-lh-ghe | e22085ff34228f3e1afde1e9890334a3e0dbefdb | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/69) | `/test boot-lh-ghe`\nboot-lh | e22085ff34228f3e1afde1e9890334a3e0dbefdb | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/68) | `/test boot-lh`\nboot-vault | e22085ff34228f3e1afde1e9890334a3e0dbefdb | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/67) | `/test boot-vault`\nboot-lh-bs | e22085ff34228f3e1afde1e9890334a3e0dbefdb | [link](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344/75) | `/test boot-lh-bs`\n\n[View all Builds for this Pull Request](https://dashboard.infra.jrawlings.co.uk/teams/jx/projects/jenkins-x/jenkins-x-versions/PR-344) \n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *jenkins-x-bot* by author *jstrachan*:",
"text": "/test boot"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *jenkins-x-bot* by author *jstrachan*:",
"text": "/test boot"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *jenkins-x-bot* by author *jstrachan*:",
"text": "/test boot"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *jenkins-x-bot* by author *jstrachan*:",
"text": "/test boot"
}
}
] |
[
{
"action": "opened",
"author": "feiskyer",
"comment_id": null,
"datetime": 1555578567000,
"text": "Cherry pick of #76691 on release-1.11.\n\n#76691: Fix Azure SLB support for multiple backend pools",
"title": "Automated cherry pick of #76691: Fix Azure SLB support for multiple backend pools",
"type": "issue"
},
{
"action": "created",
"author": "feiskyer",
"comment_id": 484419452,
"datetime": 1555578598000,
"text": "/priority critical-urgent\r\n/kind bug\r\n/sig azure\r\n/retest\r\n/assign @andyzhangx",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "feiskyer",
"comment_id": 485346768,
"datetime": 1555916943000,
"text": "ping @andyzhangx",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "feiskyer",
"comment_id": 485649498,
"datetime": 1555997466000,
"text": "/assign @foxish",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/76759#\" title=\"Author self-approved\">feiskyer</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/cloudprovider/providers/azure/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.11/pkg/cloudprovider/providers/azure/OWNERS)~~ [feiskyer]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *feiskyer*:",
"text": "/priority critical-urgent\r\n/kind bug\r\n/sig azure\r\n/retest\r\n/assign @andyzhangx"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *feiskyer*:",
"text": "/priority critical-urgent\r\n/kind bug\r\n/sig azure\r\n/retest\r\n/assign @andyzhangx"
}
}
] |
[
{
"action": "opened",
"author": "roxxette",
"comment_id": null,
"datetime": 1557396513000,
"text": "Fix issue that specify route-host for openshift\r\nAdd failed: failed to create route ...: spec.host: Forbidden: you do not have permission to set the host field of the route",
"title": "Update role.yaml",
"type": "issue"
},
{
"action": "created",
"author": "ccojocar",
"comment_id": 551446218,
"datetime": 1573203946000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ccojocar",
"comment_id": 551446238,
"datetime": 1573203953000,
"text": "/approve",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ccojocar",
"comment_id": 555520903,
"datetime": 1574172153000,
"text": "/ok-to-test",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/jenkins-x/exposecontroller/pull/185#issuecomment-551446238\" title=\"Approved\">ccojocar</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=jenkins-x%2Fexposecontroller).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/jenkins-x/exposecontroller/blob/master/OWNERS)~~ [ccojocar]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *jenkins-x-bot* by author *ccojocar*:",
"text": "/approve"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *jenkins-x-bot* by author *ccojocar*:",
"text": "/approve"
}
}
] |
[
{
"action": "opened",
"author": "mdgreenfield",
"comment_id": null,
"datetime": 1548892797000,
"text": "**Describe the bug**\r\nWhen using SDS in the sidecar injected `istio-proxy` by configuring `.Values.global.sds.enabled` we receive connection errors from `istio-proxy`/Envoy because we also have `controlPlaneSecurityEnabled: true`.\r\n\r\nThis issue looks to be introduced in https://github.com/istio/istio/commit/0b3bd99657a9528e3d9e4a5c5cb1cccc77b6c890#diff-be47e44182a3c785141d47d28a66f2d7R192\r\n\r\n**Expected behavior**\r\nWith SDS enabled and `controlPlaneSecurityEnabled: true` `istio-proxy` should be able to connect to the control plan.\r\n\r\nI believe that [this condition](https://github.com/istio/istio/commit/0b3bd99657a9528e3d9e4a5c5cb1cccc77b6c890#diff-be47e44182a3c785141d47d28a66f2d7R192) should be on `.Values.global.controlPlaneSecurityEnabled` and will need to be addressed in both the `istio` and `istio-remote` charts.\r\n\r\n**Steps to reproduce the bug**\r\nconfigure `.Values.global.sds.enabled` and `.Values.global.controlPlaneSecurityEnabled` to `true`.\r\n\r\n**Version**\r\nWe're using the nightly istio version release-1.1-20190125-09-16\r\n\r\n**Installation**\r\n- Multi-cluster environment (using the `istio` chart in the primary cluster and and `istio-remote` in the secondary cluster)\r\n- SDS enabled\r\n- Control plane security enabled\r\n- Per-pod Citadel node agent\r\n\r\n**Environment**\r\nAWS",
"title": "istio-proxy control plane connection issues when both SDS and control plane security are enabled",
"type": "issue"
},
{
"action": "created",
"author": "mdgreenfield",
"comment_id": 459164516,
"datetime": 1548893991000,
"text": "/cc @wattli",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hercynium",
"comment_id": 493185169,
"datetime": 1558032022000,
"text": "This is still an issue in Istio 1.1.6, as I've just stumbled across it. Is there any timeline for a fix? Is the control plane really unsecured when controlPlaneSecurityEnabled=false?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "quanjielin",
"comment_id": 493191781,
"datetime": 1558033194000,
"text": "@hercynium there is pending fix PR https://github.com/istio/istio/pull/13593 \r\n/cc @wenchenglu",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hercynium",
"comment_id": 494948342,
"datetime": 1558555207000,
"text": "Willl this land in 1.2?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "christianwoehrle",
"comment_id": 500492240,
"datetime": 1560185556000,
"text": "Still an issue in istio 1.1.8.\r\n\r\nIt can be reproduced with the example from https://istio.io/docs/tasks/security/auth-sds/\r\n\r\nWhen the line \r\n```\r\n controlPlaneSecurityEnabled: true\r\n```\r\nis added to the values-istio-sds-auth.yaml file, the the example doesn`t work anymore.\r\n\r\nistio-proxy then waits for certs in /etc/certs/ that it never gets.\r\n\r\n```\r\n2019-06-10T16:49:28.253269Z info Monitored certs: []string{\"/etc/certs/cert-chain.pem\", \"/etc/certs/key.pem\", \"/etc/certs/root-cert.pem\"}\r\n2019-06-10T16:49:28.253276Z info waiting 2m0s for /etc/certs/cert-chain.pem\r\n2019-06-10T16:49:29.254351Z info waiting for certificates\r\n2019-06-10T16:49:29.354492Z info waiting for certificates\r\n\r\n...\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "quanjielin",
"comment_id": 500497436,
"datetime": 1560186398000,
"text": "/cc @costinm @duderino",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "JimmyCYJ",
"comment_id": null,
"datetime": 1568059783000,
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "JimmyCYJ",
"comment_id": 529644861,
"datetime": 1568059783000,
"text": "This control plane SDS support will be shipped with release 1.3",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged \"help wanted\" or other activity occurs. Thank you for your contributions.",
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *quanjielin*:",
"text": "/cc @costinm @duderino"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *quanjielin*:",
"text": "/cc @costinm @duderino"
}
}
] |
[
{
"action": "closed",
"author": "arlac77",
"comment_id": null,
"datetime": 1553964806000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "After pinning to **3.2.20** your tests are still failing. The reported issue _might_ not affect your project. These imprecisions are caused by inconsistent test results.",
"previous": {
"meta": "This message directly preceded comment from bot *greenkeeper[bot]* by author *arlac77*:",
"text": ""
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *greenkeeper[bot]* by author *arlac77*:",
"text": ""
}
}
] |
[
{
"action": "opened",
"author": "smbell",
"comment_id": null,
"datetime": 1550783060000,
"text": "Bug: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/33242\r\n\r\nTo make the type definition consistent with both the implementation and api docs as indicated in the bug, we are updating the return values of `rethrowResult` and `retryResult` to return a `DecisionInfo` object.\r\n\r\nAdditionally the `DecisionInfo` object will have it's `consistency` field made optional and a new optional field of `useCurrentHost` is added.\r\n\r\nPlease fill in this template.\r\n\r\n- [ ] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [ ] Test the change in your own code. (Compile and run.)\r\n- [ ] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [ ] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [ ] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [ ] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.",
"title": "Fix return values of rethrowResult and retryResult",
"type": "issue"
},
{
"action": "created",
"author": "pc-jedi",
"comment_id": 466636115,
"datetime": 1550917329000,
"text": "@michal-b-kaminski For some reason the typescript bot is ignoring that you are also a maintainer",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "michal-b-kaminski",
"comment_id": 466637261,
"datetime": 1550918274000,
"text": "I think they have to update CODEOWNERS for that, and it's been 3 weeks since they did it last.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "<!--header {\"slug\":\"merge\"} headerend-->\r\nA definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!\r\n<!--footer bot @ 2019-2-23 02:24:02 footerend-->",
"previous": {
"meta": "This message directly preceded comment from bot *typescript-bot* by author *pc-jedi*:",
"text": "@michal-b-kaminski For some reason the typescript bot is ignoring that you are also a maintainer"
}
},
{
"bot": "I just published [`@types/[email protected]` to npm](https://www.npmjs.com/package/@types/cassandra-driver).",
"previous": {
"meta": "This message directly preceded comment from bot *typescript-bot* by author *michal-b-kaminski*:",
"text": "I think they have to update CODEOWNERS for that, and it's been 3 weeks since they did it last."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *typescript-bot* by author *pc-jedi*:",
"text": "@michal-b-kaminski For some reason the typescript bot is ignoring that you are also a maintainer"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *typescript-bot* by author *michal-b-kaminski*:",
"text": "I think they have to update CODEOWNERS for that, and it's been 3 weeks since they did it last."
}
}
] |
[
{
"action": "opened",
"author": "ahmetb",
"comment_id": null,
"datetime": 1554137071000,
"text": "- remove \"Google project\" indication\n- add notice about where to file bugs\n- add communication channels of SIG CLI\n- add link to Kubernetes CoC.",
"title": "README: post-migration updates",
"type": "issue"
},
{
"action": "created",
"author": "ahmetb",
"comment_id": 478661785,
"datetime": 1554138158000,
"text": "curious if I can self approve this\r\n/lgtm\r\n/approve",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahmetb",
"comment_id": 478661842,
"datetime": 1554138168000,
"text": "haha I guessed so",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhita",
"comment_id": 478671217,
"datetime": 1554139788000,
"text": "@ahmetb you should be able to approve. can you try again?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhita",
"comment_id": 478672143,
"datetime": 1554139952000,
"text": "This looks fishy https://github.com/kubernetes-sigs/krew/pull/167#issuecomment-478661811 O_o",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahmetb",
"comment_id": 478674613,
"datetime": 1554140377000,
"text": "@nikhita I think I didn't accept the org invite earlier.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ahmetb",
"comment_id": 478674648,
"datetime": 1554140381000,
"text": "/approve",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhita",
"comment_id": 478674992,
"datetime": 1554140446000,
"text": "Oh :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhita",
"comment_id": 478677653,
"datetime": 1554140905000,
"text": "/lgtm",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ahmetb*:",
"text": "curious if I can self approve this\r\n/lgtm\r\n/approve"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes-sigs/krew/pull/167#issuecomment-478674648\" title=\"Approved\">ahmetb</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fkrew).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes-sigs/krew/blob/master/OWNERS)~~ [ahmetb]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ahmetb*:",
"text": "/approve"
}
},
{
"bot": "New changes are detected. LGTM label has been removed.",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *nikhita*:",
"text": "Oh :)"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ahmetb*:",
"text": "curious if I can self approve this\r\n/lgtm\r\n/approve"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ahmetb*:",
"text": "/approve"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *nikhita*:",
"text": "Oh :)"
}
}
] |
[
{
"action": "opened",
"author": "bureddy",
"comment_id": null,
"datetime": 1554306819000,
"text": "",
"title": "GTEST/JENKINS: Fix CUDA testing - v1.6.x",
"type": "issue"
},
{
"action": "created",
"author": "mellanox-github",
"comment_id": 479671145,
"datetime": 1554328064000,
"text": "Test FAILed.\nSee http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/9640/ for details (Mellanox internal link).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yosefe",
"comment_id": 479791715,
"datetime": 1554364609000,
"text": "bot:retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mellanox-github",
"comment_id": 479872191,
"datetime": 1554379997000,
"text": "Test PASSed.\nSee http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/9656/ for details (Mellanox internal link).",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Test PASSed.\nSee http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/6863/ for details.",
"previous": {
"meta": "This message directly preceded comment from bot *swx-jenkins* by author *yosefe*:",
"text": "bot:retest"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *swx-jenkins* by author *yosefe*:",
"text": "bot:retest"
}
}
] |
[
{
"action": "opened",
"author": "matzew",
"comment_id": null,
"datetime": 1562067239000,
"text": "Patching our operator's filename, to use the CI yaml which contains images we build during _this_ process",
"title": "patch the operator, per build",
"type": "issue"
},
{
"action": "created",
"author": "lberk",
"comment_id": 507744864,
"datetime": 1562083935000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "matzew",
"comment_id": 508025121,
"datetime": 1562147489000,
"text": "the actual test -> #178",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/openshift/knative-eventing/pull/173#issuecomment-507744864\" title=\"LGTM\">lberk</a>*, *<a href=\"https://github.com/openshift/knative-eventing/pull/173#\" title=\"Author self-approved\">matzew</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=openshift%2Fknative-eventing).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/openshift/knative-eventing/blob/master/OWNERS)~~ [lberk,matzew]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *lberk*:",
"text": "/lgtm"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *openshift-ci-robot* by author *lberk*:",
"text": "/lgtm"
}
}
] |
[
{
"action": "opened",
"author": "simanor",
"comment_id": null,
"datetime": 1558972394000,
"text": "+ examples\r\n\r\n### Latest improvements:\r\n<i>MSFT employees can try out our new experience at <b>[OpenAPI Hub](https://aka.ms/openapiportal) </b> - one location for using our validation tools and finding your workflow. \r\n</i><br>\r\n### Contribution checklist:\r\n- [+] I have reviewed the [documentation](https://github.com/Azure/azure-rest-api-specs#basics) for the workflow.\r\n- [+] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.\r\n- [+] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps.\r\n### ARM API Review Checklist\r\n- [ ] Service team MUST add the \"WaitForARMFeedback\" label if the management plane API changes fall into one of the below categories. \r\n- adding/removing APIs.\r\n- adding/removing properties.\r\n- adding/removing API-version. \r\n- adding a new service in Azure.\r\n\r\nFailure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.\r\n- [ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them. \r\nPlease follow the link to find more details on [API review process](https://armwiki.azurewebsites.net/rp_onboarding/ResourceProviderOnboardingAPIRevieworkflow.html).",
"title": "Add SmartDetectorAlertRules swagger",
"type": "issue"
},
{
"action": "created",
"author": "simanor",
"comment_id": 496254081,
"datetime": 1558972516000,
"text": "Hello,\r\nHere's a link to the approved PR in azure-rest-api-specs-pr: **https://github.com/Azure/azure-rest-api-specs-pr/pull/734**\r\n\r\nThank you",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "azuresdkci",
"comment_id": 496254454,
"datetime": 1558972611000,
"text": "Can one of the admins verify this patch?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "YairoR",
"comment_id": 498532676,
"datetime": 1559627941000,
"text": "Hi, any update with that?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sarangan12",
"comment_id": 498785079,
"datetime": 1559672307000,
"text": "New changes added. Tagging ARM Team for Approval",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "<html><body><h3>SDK Automation</h3></body></html>",
"previous": {
"meta": "This message directly preceded comment from bot *openapi-bot[bot]* by author *sarangan12*:",
"text": "New changes added. Tagging ARM Team for Approval"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *openapi-bot[bot]* by author *sarangan12*:",
"text": "New changes added. Tagging ARM Team for Approval"
}
}
] |
[
{
"action": "opened",
"author": "batazor",
"comment_id": null,
"datetime": 1559826465000,
"text": ", ...)` format, will close that issue when PR gets merged)*\r\n - fixes #\r\n\r\n#### Special notes for your reviewer:\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [ ] [DCO](https://github.com/helm/charts/blob/master/CONTRIBUTING.md#sign-your-work) signed\r\n- [ ] Chart Version bumped\r\n- [ ] Variables are documented in the README.md\r\n- [ ] Title of the PR starts with chart name (e.g. `[stable/chart]`)",
"title": "[stable/grafana] Bump version",
"type": "issue"
},
{
"action": "created",
"author": "batazor",
"comment_id": 499491648,
"datetime": 1559827393000,
"text": "/assign @maorfr",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "carrodher",
"comment_id": 499895178,
"datetime": 1559915869000,
"text": "It seems you included some undesired changes",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "batazor",
"comment_id": 500102490,
"datetime": 1559977758000,
"text": "@carrodher @maorfr Made changes",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "maorfr",
"comment_id": 500216428,
"datetime": 1560090693000,
"text": "/lgtm\r\n\r\nThanks for contributing!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/helm/charts/pull/14558#\" title=\"Author self-approved\">batazor</a>*\nTo complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **maorfr**\nYou can assign the PR to them by writing `/assign @maorfr` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=helm%2Fcharts).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[stable/grafana/OWNERS](https://github.com/helm/charts/blob/master/stable/grafana/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"maorfr\"]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *carrodher*:",
"text": "It seems you included some undesired changes"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/helm/charts/pull/14558#\" title=\"Author self-approved\">batazor</a>*, *<a href=\"https://github.com/helm/charts/pull/14558#issuecomment-500216428\" title=\"LGTM\">maorfr</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=helm%2Fcharts).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[stable/grafana/OWNERS](https://github.com/helm/charts/blob/master/stable/grafana/OWNERS)~~ [maorfr]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *maorfr*:",
"text": "/lgtm\r\n\r\nThanks for contributing!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *carrodher*:",
"text": "It seems you included some undesired changes"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *maorfr*:",
"text": "/lgtm\r\n\r\nThanks for contributing!"
}
}
] |
[
{
"action": "opened",
"author": "rileyjbauer",
"comment_id": null,
"datetime": 1563405972000,
"text": "<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/pipelines/1637)\n<!-- Reviewable:end -->",
"title": "Sets min widths for buttons to avoid text wrapping",
"type": "issue"
},
{
"action": "created",
"author": "ajchili",
"comment_id": 512606651,
"datetime": 1563406359000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ajchili",
"comment_id": 512614635,
"datetime": 1563408697000,
"text": "@rileyjbauer the snapshots for the tests need to be updated.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rileyjbauer",
"comment_id": 512917043,
"datetime": 1563471735000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rileyjbauer",
"comment_id": 513911389,
"datetime": 1563821975000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rileyjbauer",
"comment_id": 513970912,
"datetime": 1563832687000,
"text": "/test kubeflow-pipeline-sample-test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ajchili",
"comment_id": 514009892,
"datetime": 1563843145000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rileyjbauer",
"comment_id": 514767713,
"datetime": 1563996517000,
"text": "/approve",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "New changes are detected. LGTM label has been removed.",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ajchili*:",
"text": "@rileyjbauer the snapshots for the tests need to be updated."
}
},
{
"bot": "@rileyjbauer: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nkubeflow-pipeline-sample-test | 553c9f578c2de4877d43c9efd9401d03ecf60dfc | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/1637/kubeflow-pipeline-sample-test/1151900824322969600) | `/test kubeflow-pipeline-sample-test`\nkubeflow-pipeline-e2e-test | 553c9f578c2de4877d43c9efd9401d03ecf60dfc | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/1637/kubeflow-pipeline-e2e-test/1151910253747507201) | `/test kubeflow-pipeline-e2e-test`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubeflow&repo=pipelines&pr=1637). [Your PR dashboard](https://gubernator.k8s.io/pr/rileyjbauer). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubeflow/pipelines/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *rileyjbauer*:",
"text": "/retest"
}
},
{
"bot": "@rileyjbauer: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nkubeflow-pipeline-e2e-test | 553c9f578c2de4877d43c9efd9401d03ecf60dfc | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/1637/kubeflow-pipeline-e2e-test/1151910253747507201) | `/test kubeflow-pipeline-e2e-test`\nkubeflow-pipeline-sample-test | 553c9f578c2de4877d43c9efd9401d03ecf60dfc | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/1637/kubeflow-pipeline-sample-test/1153379139449786369) | `/test kubeflow-pipeline-sample-test`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubeflow&repo=pipelines&pr=1637). [Your PR dashboard](https://gubernator.k8s.io/pr/rileyjbauer). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubeflow/pipelines/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *rileyjbauer*:",
"text": "/retest"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubeflow/pipelines/pull/1637#issuecomment-514767713\" title=\"Approved\">rileyjbauer</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubeflow%2Fpipelines).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[frontend/OWNERS](https://github.com/kubeflow/pipelines/blob/master/frontend/OWNERS)~~ [rileyjbauer]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *rileyjbauer*:",
"text": "/approve"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *ajchili*:",
"text": "@rileyjbauer the snapshots for the tests need to be updated."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *rileyjbauer*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *rileyjbauer*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *rileyjbauer*:",
"text": "/approve"
}
}
] |
[
{
"action": "opened",
"author": "sa867b",
"comment_id": null,
"datetime": 1580295396000,
"text": "[root@kubmaster FoodTrucks]# docker build -t sa867b/foodtrucks-web .\r\nSending build context to Docker daemon 6.737MB\r\nStep 1/13 : FROM ubuntu:latest\r\n ---> ccc6e87d482b\r\nStep 2/13 : LABEL maintainer=\"Prakhar Srivastav <[email protected]>\"\r\n ---> Using cache\r\n ---> 0e5f7304a6a0\r\nStep 3/13 : RUN apt-get -yqq update\r\n ---> Running in 13b76c6b54c0\r\nE: Release file for http://security.ubuntu.com/ubuntu/dists/bionic-security/InRelease is not valid yet (invalid for another 1d 2h 57min 51s). Updates for this repository will not be applied.\r\nE: Release file for http://archive.ubuntu.com/ubuntu/dists/bionic-updates/InRelease is not valid yet (invalid for another 1d 2h 58min 42s). Updates for this repository will not be applied.\r\nE: Release file for http://archive.ubuntu.com/ubuntu/dists/bionic-backports/InRelease is not valid yet (invalid for another 1d 2h 59min 56s). Updates for this repository will not be applied.\r\nThe command '/bin/sh -c apt-get -yqq update' returned a non-zero code: 100",
"title": "Getting error while runing docker build command in multicontainer workshop",
"type": "issue"
},
{
"action": "created",
"author": "prakhar1989",
"comment_id": 616239290,
"datetime": 1587336916000,
"text": "Hmm, seems like a temporary issue with the ubuntu repos. Can you try again and see if it works?",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "This issue is stale because it has been open 14 days with no activity. Remove label or comment or this will be closed in 2 days",
"previous": {
"meta": "This message directly preceded comment from bot *github-actions[bot]* by author *prakhar1989*:",
"text": "Hmm, seems like a temporary issue with the ubuntu repos. Can you try again and see if it works?"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *github-actions[bot]* by author *prakhar1989*:",
"text": "Hmm, seems like a temporary issue with the ubuntu repos. Can you try again and see if it works?"
}
}
] |
[
{
"action": "closed",
"author": "surendermuddam",
"comment_id": null,
"datetime": 1578174622000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "## Consider this issue finished! :white_check_mark:\n\n<hr>\n<h3 align=\"center\">Head over to <a href=\"https://github.com/surendermuddam/github-slideshow/issues/2\">the next issue</a> now!</h3>",
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *surendermuddam*:",
"text": ""
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *surendermuddam*:",
"text": ""
}
}
] |
[
{
"action": "created",
"author": "AdmiringWorm",
"comment_id": 535923598,
"datetime": 1569588277000,
"text": "@dependabot rebase and merge",
"title": null,
"type": "comment"
}
] |
[
{
"bot": ":white_check_mark: Package verification completed without issues. PR is now pending human review",
"previous": {
"meta": "This message directly preceded comment from bot *AppVeyorBot* by author *AdmiringWorm*:",
"text": "@dependabot rebase and merge"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *AppVeyorBot* by author *AdmiringWorm*:",
"text": "@dependabot rebase and merge"
}
}
] |
[
{
"action": "opened",
"author": "itaysk",
"comment_id": null,
"datetime": 1543782764000,
"text": "implements https://github.com/istio/api/pull/709\r\nfix https://github.com/istio/istio/issues/9595",
"title": "New header manipulation API",
"type": "issue"
},
{
"action": "created",
"author": "rshriram",
"comment_id": 443734045,
"datetime": 1543848280000,
"text": "/ok-to-test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rshriram",
"comment_id": 443736155,
"datetime": 1543848642000,
"text": "High level comment: if the appendFlag was recently introduced (after Istio 1.0, which is most likely), please guard the config generation pieces with a proxy version check, so that for 1.0 proxies, its only append/remove, while for 1.1 proxies, its set/append/remove [if and only if this functionality didn't exist by Istio 1.0 (around June).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GregHanson",
"comment_id": 444150854,
"datetime": 1543938921000,
"text": "/test e2e-dashboard",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GregHanson",
"comment_id": 444259796,
"datetime": 1543957905000,
"text": "/test e2e-dashboard",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rshriram",
"comment_id": 444279281,
"datetime": 1543961601000,
"text": "Can you sync your branch to release 1.1 fully and see if the test failure goes away?\r\n\r\n@douglas-Reid any idea why this dashboard test is failing for unrelated code?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "itaysk",
"comment_id": 444729268,
"datetime": 1544064510000,
"text": "Rebased",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GregHanson",
"comment_id": 445032848,
"datetime": 1544131116000,
"text": "/approve\r\n/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hklai",
"comment_id": 445085528,
"datetime": 1544144380000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GregHanson",
"comment_id": 445249334,
"datetime": 1544193004000,
"text": "/test e2e-dashboard",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GregHanson",
"comment_id": 445385826,
"datetime": 1544221841000,
"text": "/test istio-pilot-e2e-envoyv2-v1alpha3",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@itaysk: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow//e2e-simpleTests-minProfile.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/e2e-simpleTestsMinProfile/182) | `/test e2e-simpleTestsMinProfile`\nprow/istio-pilot-multicluster-e2e.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/istio-pilot-multicluster-e2e/5648) | `/test istio-pilot-multicluster-e2e`\nprow/e2e-dashboard.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/e2e-dashboard/8703) | `/test e2e-dashboard`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *istio-testing* by author *GregHanson*:",
"text": "/test e2e-dashboard"
}
},
{
"bot": "@itaysk: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow//e2e-simpleTests-minProfile.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/e2e-simpleTestsMinProfile/182) | `/test e2e-simpleTestsMinProfile`\nprow/istio-pilot-multicluster-e2e.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/istio-pilot-multicluster-e2e/5648) | `/test istio-pilot-multicluster-e2e`\nprow/e2e-dashboard.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/e2e-dashboard/8725) | `/test e2e-dashboard`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *istio-testing* by author *GregHanson*:",
"text": "/test e2e-dashboard"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/istio/istio/pull/10233#issuecomment-445032848\" title=\"LGTM\">GregHanson</a>*, *<a href=\"https://github.com/istio/istio/pull/10233#\" title=\"Author self-approved\">itaysk</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pilot/OWNERS](https://github.com/istio/istio/blob/release-1.1/pilot/OWNERS)~~ [GregHanson]\n- ~~[tests/e2e/tests/pilot/OWNERS](https://github.com/istio/istio/blob/release-1.1/tests/e2e/tests/pilot/OWNERS)~~ [GregHanson]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *istio-testing* by author *GregHanson*:",
"text": "/approve\r\n/lgtm"
}
},
{
"bot": "/retest\nThis bot automatically retries jobs that failed/flaked on approved PRs.\nReview the [full test history](https://k8s-gubernator.appspot.com/jobs/istio-prow/pr-logs/pull/istio_istio/10233) for this PR.\n`/lgtm cancel` will stop retrying.",
"previous": {
"meta": "This message directly preceded comment from bot *istio-release-robot* by author *hklai*:",
"text": "/retest"
}
},
{
"bot": "@itaysk: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow//e2e-simpleTests-minProfile.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/e2e-simpleTestsMinProfile/182) | `/test e2e-simpleTestsMinProfile`\nprow/istio-pilot-e2e-envoyv2-v1alpha3.sh | 278c98e7240c3cc348ef2569bbf1816359dd218f | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/istio-pilot-e2e-envoyv2-v1alpha3/12112) | `/test istio-pilot-e2e-envoyv2-v1alpha3`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *istio-testing* by author *GregHanson*:",
"text": "/test e2e-dashboard"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *istio-testing* by author *GregHanson*:",
"text": "/test e2e-dashboard"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *istio-testing* by author *GregHanson*:",
"text": "/test e2e-dashboard"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *istio-testing* by author *GregHanson*:",
"text": "/approve\r\n/lgtm"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *istio-release-robot* by author *hklai*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *istio-testing* by author *GregHanson*:",
"text": "/test e2e-dashboard"
}
}
] |
[
{
"action": "closed",
"author": "varunisataco",
"comment_id": null,
"datetime": 1568401919000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "Let's go to the [first pull request](https://github.com/varunisataco/lab-starter/pull/2) which I've opened for you.",
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *varunisataco*:",
"text": ""
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *varunisataco*:",
"text": ""
}
}
] |
[
{
"action": "closed",
"author": "hansonadam",
"comment_id": null,
"datetime": 1579829436000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "## Consider this issue finished! :white_check_mark:\n\n<hr>\n<h3 align=\"center\">Head over to <a href=\"https://github.com/hansonadam/github-slideshow/issues/2\">the next issue</a> now!</h3>",
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *hansonadam*:",
"text": ""
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *hansonadam*:",
"text": ""
}
}
] |
[
{
"action": "opened",
"author": "ScrapCodes",
"comment_id": null,
"datetime": 1571660159000,
"text": "This is work in progress, because I wanted some early feedback as to overall approach taken. At the moment with current code, this mounting feature does not work in client mode of submission. The reason is, in client mode kubernetes does not create any resources. \r\n\r\nMy question is, what is the correct way to create a config map, while in the client mode. If it is created in a place like ExecutorPodAllocator, then since it is run repeatedly, then we would not want the config map to be created again and again on each executor pod allocation. So, what would be correct place to do it.\r\n\r\n### What changes were proposed in this pull request?\r\nA new feature to propagate correct logging configuration file either by picking up from user specified logger configuration file on the classpath or through user specified k8s config map.\r\n\r\n### Why are the changes needed?\r\nPlease see referenced JIRA.\r\n\r\n### Does this PR introduce any user-facing change?\r\nNo\r\n\r\n### How was this patch tested?\r\nManually tested.",
"title": "[WIP][SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor.",
"type": "issue"
},
{
"action": "created",
"author": "ScrapCodes",
"comment_id": 575103070,
"datetime": 1579173002000,
"text": "@srowen and @vanzin Do you think this patch makes sense? I am ready to work on it more if some more work is needed. Thanks :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ScrapCodes",
"comment_id": 581772993,
"datetime": 1580800218000,
"text": "Jenkins, retest this please.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ScrapCodes",
"comment_id": 581800084,
"datetime": 1580805653000,
"text": "Jenkins, retest this please.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ScrapCodes",
"comment_id": 581801362,
"datetime": 1580805864000,
"text": "This failed with 20/02/04 00:20:45 INFO AmazonHttpClient: Unable to execute HTTP request: Read timed out\r\n20/02/04 00:20:45.716 ScalaTest-main-running-KubernetesSuite INFO ProcessUtils: java.net.SocketTimeoutException: Read timed out",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ScrapCodes",
"comment_id": 581834665,
"datetime": 1580810952000,
"text": "This test is failing more often and only occasionally it passes.\r\n\r\n- Launcher client dependencies *** FAILED ***\r\n \r\nThe code passed to eventually never returned normally. Attempted 1 times over 3.375042707433333 minutes. Last failure message: Failed to create bucket spark.. (DepsTestsSuite.scala:213)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ScrapCodes",
"comment_id": 581834997,
"datetime": 1580810995000,
"text": "Jenkins, retest this please.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ScrapCodes",
"comment_id": 582764037,
"datetime": 1580972123000,
"text": "@mccheah @vanzin @dongjoon-hyun Can you please take a look?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ScrapCodes",
"comment_id": 587484713,
"datetime": 1582035872000,
"text": "@vanzin, Hi Marcelo Vanzin, I have added you for the review, as you have worked on similar features as this PR, please take a look.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "**[Test build #117811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117811/testReport)** for PR 26193 at commit [`05b4273`](https://github.com/apache/spark/commit/05b427391f048240d3f7cd38b0055c70c3a80987).",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *ScrapCodes*:",
"text": "Jenkins, retest this please."
}
},
{
"bot": "Merged build finished. Test FAILed.",
"previous": {
"meta": "This message directly preceded comment from bot *AmplabJenkins* by author *ScrapCodes*:",
"text": "Jenkins, retest this please."
}
},
{
"bot": "Merged build finished. Test FAILed.",
"previous": {
"meta": "This message directly preceded comment from bot *AmplabJenkins* by author *ScrapCodes*:",
"text": "Jenkins, retest this please."
}
},
{
"bot": "Kubernetes integration test starting\nURL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/22738/",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *ScrapCodes*:",
"text": "@mccheah @vanzin @dongjoon-hyun Can you please take a look?"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *ScrapCodes*:",
"text": "Jenkins, retest this please."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *AmplabJenkins* by author *ScrapCodes*:",
"text": "Jenkins, retest this please."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *AmplabJenkins* by author *ScrapCodes*:",
"text": "Jenkins, retest this please."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *ScrapCodes*:",
"text": "@mccheah @vanzin @dongjoon-hyun Can you please take a look?"
}
}
] |
[
{
"action": "opened",
"author": "catenocrypt",
"comment_id": null,
"datetime": 1584715526000,
"text": "## Description\r\n\r\nRefactor the generated Coins.cpp files, instead of independent methods with large switch statements, create a map with all coin data, and retrieve data from there.\r\nMotivation: data is closer to the coins.json file. Solves in part #885 .\r\n\r\n## Testing instructions\r\n\r\nBuild, check `src/Generated/Coins.cpp`.\r\n\r\nUnit tests.\r\n\r\n## Types of changes\r\n\r\n* Minor internal refactor\r\n\r\n## Checklist\r\n\r\n<!--- The following points should be used to indicate the progress of your PR. Put an `x` in all the boxes that apply right now, and come back over time and check them off as you make progress. If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n- [x] Prefix PR title with `[WIP]` if necessary.\r\n- [x] Add tests to cover changes as needed.\r\n- [x] Update documentation as needed.\r\n- [x] If there is a related Issue, mention it in the description (e.g. 'Fixes #444 ).",
"title": "[WIP] Refactor Coins.cpp, coin data as a const map",
"type": "issue"
},
{
"action": "created",
"author": "catenocrypt",
"comment_id": 601950031,
"datetime": 1584746291000,
"text": "/azp run",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vikmeup",
"comment_id": 601958199,
"datetime": 1584748564000,
"text": "/azp run",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vikmeup",
"comment_id": 601959455,
"datetime": 1584748943000,
"text": "/azp run",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vikmeup",
"comment_id": 601960691,
"datetime": 1584749266000,
"text": "/azp run",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vikmeup",
"comment_id": 601962466,
"datetime": 1584749744000,
"text": "/azp run",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vikmeup",
"comment_id": 601963139,
"datetime": 1584749938000,
"text": "/azp run",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "catenocrypt",
"comment_id": 602119806,
"datetime": 1584833921000,
"text": "/azp run",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "catenocrypt",
"comment_id": 602453971,
"datetime": 1584952298000,
"text": "I'm afraid CI teawking is needed.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "<samp>\nAzure Pipelines successfully started running 3 pipeline(s).<br>\r\n\n</samp>",
"previous": {
"meta": "This message directly preceded comment from bot *azure-pipelines[bot]* by author *vikmeup*:",
"text": "/azp run"
}
},
{
"bot": "<samp>\nAzure Pipelines successfully started running 3 pipeline(s).<br>\r\n\n</samp>",
"previous": {
"meta": "This message directly preceded comment from bot *azure-pipelines[bot]* by author *catenocrypt*:",
"text": "/azp run"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *azure-pipelines[bot]* by author *vikmeup*:",
"text": "/azp run"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *azure-pipelines[bot]* by author *catenocrypt*:",
"text": "/azp run"
}
}
] |
[
{
"action": "opened",
"author": "mkothur",
"comment_id": null,
"datetime": 1577813360000,
"text": "### Related Ticket(s)\r\n\r\nRelated to issue #763 \r\n### Description\r\n\r\nCreated the alpha version of a logo grid pattern\r\n",
"title": "feat(pattern): created an alpha version of the logo grid",
"type": "issue"
},
{
"action": "created",
"author": "jeffchew",
"comment_id": 569968491,
"datetime": 1577815892000,
"text": "Alignments look a little weird, and it looks really off in mobile and tablet views...\r\n\r\ncc: @wonilsuhibm \r\n\r\n<img width=\"925\" alt=\"Screen Shot 2019-12-31 at 1 10 50 PM\" src=\"https://user-images.githubusercontent.com/1641214/71630053-ff9da400-2bce-11ea-922a-ad494c04c76d.png\">\r\n<img width=\"620\" alt=\"Screen Shot 2019-12-31 at 1 10 31 PM\" src=\"https://user-images.githubusercontent.com/1641214/71630059-01676780-2bcf-11ea-90a2-7ed392b7d699.png\">",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mkothur",
"comment_id": 569969478,
"datetime": 1577816366000,
"text": "@jeffchew will fix them.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mkothur",
"comment_id": 572107886,
"datetime": 1578495599000,
"text": "@jeffchew: updated the PR for above changes.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Deploy preview for *ibmdotcom-vanilla* ready!\n\nBuilt with commit a5d5e25caf8239af93428a27ab94ce91dd7081f4\n\nhttps://deploy-preview-910--ibmdotcom-vanilla.netlify.com",
"previous": {
"meta": "This message directly preceded comment from bot *netlify[bot]* by author *mkothur*:",
"text": "@jeffchew will fix them."
}
},
{
"bot": "Deploy preview created for package \"Patterns React (experimental)\":\nhttps://ibmdotcom-patterns-react-experimental.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/910/index.html\n\nBuilt with commit: [66cda9925b43706178441187197593d3d4bda197](https://github.com/carbon-design-system/ibm-dotcom-library/commit/66cda9925b43706178441187197593d3d4bda197)",
"previous": {
"meta": "This message directly preceded comment from bot *ibmdotcom-bot* by author *mkothur*:",
"text": "@jeffchew: updated the PR for above changes."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *netlify[bot]* by author *mkothur*:",
"text": "@jeffchew will fix them."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *ibmdotcom-bot* by author *mkothur*:",
"text": "@jeffchew: updated the PR for above changes."
}
}
] |
[
{
"action": "closed",
"author": "suongdle",
"comment_id": null,
"datetime": 1542666905000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "## Consider this issue finished! :white_check_mark:\n\n<hr>\n<h3 align=\"center\">Head over to <a href=\"https://github.com/suongdle/github-slideshow/issues/2\">the next issue</a> now!</h3>",
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *suongdle*:",
"text": ""
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *suongdle*:",
"text": ""
}
}
] |
[
{
"action": "created",
"author": "mscharley",
"comment_id": 612377073,
"datetime": 1586597220000,
"text": "@dependabot merge",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mscharley",
"comment_id": 612399975,
"datetime": 1586604952000,
"text": "@dependabot rebase",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mscharley",
"comment_id": 612400106,
"datetime": 1586604988000,
"text": "@dependabot merge",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.",
"previous": {
"meta": "This message directly preceded comment from bot *dependabot[bot]* by author *mscharley*:",
"text": "@dependabot merge"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *dependabot[bot]* by author *mscharley*:",
"text": "@dependabot merge"
}
}
] |
[
{
"action": "opened",
"author": "mm4tt",
"comment_id": null,
"datetime": 1552393117000,
"text": "Example error is:\r\n```\r\nPost https://34.73.197.67/apis/rbac.authorization.k8s.io/v1/clusterrolebindings: net/http: TLS handshake timeout\r\n```\r\n\r\nRef. https://github.com/kubernetes/kubernetes/issues/75284",
"title": "ClusterLoader2 should retry retriable net errors.",
"type": "issue"
},
{
"action": "created",
"author": "wojtek-t",
"comment_id": 472036936,
"datetime": 1552402791000,
"text": "/lgtm\r\n/approve\r\n\r\nThanks!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/perf-tests/pull/452#\" title=\"Author self-approved\">mm4tt</a>*, *<a href=\"https://github.com/kubernetes/perf-tests/pull/452#issuecomment-472036936\" title=\"Approved\">wojtek-t</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fperf-tests).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[clusterloader2/OWNERS](https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/OWNERS)~~ [wojtek-t]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *wojtek-t*:",
"text": "/lgtm\r\n/approve\r\n\r\nThanks!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *wojtek-t*:",
"text": "/lgtm\r\n/approve\r\n\r\nThanks!"
}
}
] |
[
{
"action": "created",
"author": "rkpagadala",
"comment_id": 441755122,
"datetime": 1543258593000,
"text": "/test daily-upgrade-tests-1.0.1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hklai",
"comment_id": 441763326,
"datetime": 1543260071000,
"text": "/test daily-upgrade-tests-1.0.1",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@istio-release-robot: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/daily-upgrade-tests-1.0.1.sh | f679b45b39d73dadc1d82b92d556a6583e4c7965 | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio-releases_daily-release/1280/daily-upgrade-tests-1.0.1/246) | `/test daily-upgrade-tests-1.0.1`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *istio-testing* by author *rkpagadala*:",
"text": "/test daily-upgrade-tests-1.0.1"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *istio-testing* by author *rkpagadala*:",
"text": "/test daily-upgrade-tests-1.0.1"
}
}
] |
[
{
"action": "opened",
"author": "hougangliu",
"comment_id": null,
"datetime": 1574671310000,
"text": "<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n5. If this PR changes image versions, please title this PR \"Bump <image name> from x.x.x to y.y.y.\"\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.\r\n\r\n**Release note**:\r\n<!-- Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```",
"title": "Change web failPolicy to fail instead of default ingore",
"type": "issue"
},
{
"action": "created",
"author": "hougangliu",
"comment_id": 558050611,
"datetime": 1574671391000,
"text": "Based on https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#failure-policy, katib webhook failure policy should be `Fail` instead of default `Ignore` value\r\n/cc @gaocegege @johnugeorge",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "johnugeorge",
"comment_id": 558065565,
"datetime": 1574673812000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hougangliu",
"comment_id": 558104404,
"datetime": 1574679693000,
"text": "/test kubeflow-katib-presubmit",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "johnugeorge",
"comment_id": 558127242,
"datetime": 1574683731000,
"text": "/retest",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@hougangliu: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nkubeflow-katib-presubmit | 8b5a605792c6a1342af75122a7fec609c034328a | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_katib/933/kubeflow-katib-presubmit/1198895129566384128/) | `/test kubeflow-katib-presubmit`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubeflow&repo=katib&pr=933). [Your PR dashboard](https://gubernator.k8s.io/pr/hougangliu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubeflow/katib/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *johnugeorge*:",
"text": "/retest"
}
},
{
"bot": "@hougangliu: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nkubeflow-katib-presubmit | 8b5a605792c6a1342af75122a7fec609c034328a | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_katib/933/kubeflow-katib-presubmit/1198919793076342784/) | `/test kubeflow-katib-presubmit`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubeflow&repo=katib&pr=933). [Your PR dashboard](https://gubernator.k8s.io/pr/hougangliu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubeflow/katib/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *hougangliu*:",
"text": "/test kubeflow-katib-presubmit"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *johnugeorge*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *hougangliu*:",
"text": "/test kubeflow-katib-presubmit"
}
}
] |
[
{
"action": "closed",
"author": "lorianahines",
"comment_id": null,
"datetime": 1561477802000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "## Consider this issue finished! :white_check_mark:\n\n<hr>\n<h3 align=\"center\">Head over to <a href=\"https://github.com/lorianahines/github-slideshow/issues/2\">the next issue</a> now!</h3>",
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *lorianahines*:",
"text": ""
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *github-learning-lab[bot]* by author *lorianahines*:",
"text": ""
}
}
] |
[
{
"action": "opened",
"author": "gkarthiks",
"comment_id": null,
"datetime": 1565641587000,
"text": "<!-- 🎉🎉🎉 Thank you for the PR!!! 🎉🎉🎉 -->\r\n\r\n# Changes\r\n\r\n<!-- Describe your changes here- ideally you can get that description straight from\r\nyour descriptive commit message(s)! -->\r\nFixed the link for releases.yaml from cli repo releases to pipelines repo\r\n\r\n# Submitter Checklist\r\n\r\nThese are the criteria that every PR should meet, please check them off as you\r\nreview them:\r\n\r\n- [ ] Includes [tests](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if functionality changed/added)\r\n- [ ] Includes [docs](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if user facing)\r\n- [ ] Commit messages follow [commit message best practices](https://github.com/tektoncd/community/blob/master/standards.md#commit-messages)\r\n\r\n_See [the contribution guide](https://github.com/tektoncd/cli/blob/master/CONTRIBUTING.md)\r\nfor more details._\r\n\r\n# Release Notes\r\n\r\n<!--\r\nDoes your PR contain User facing changes?\r\n\r\nIf so, briefly describe them here so we can include this description in the\r\nrelease notes for the next release!\r\n-->\r\n\r\n```\r\nrelease-note\r\n```",
"title": "fix(): release link from cli to pipelines repo",
"type": "issue"
},
{
"action": "created",
"author": "gkarthiks",
"comment_id": 520582491,
"datetime": 1565641770000,
"text": "@googlebot I signed it!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dibyom",
"comment_id": 520584159,
"datetime": 1565642055000,
"text": "/ok-to-test",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "CLAs look good, thanks!\n\nℹ️ **Googlers: [Go here](https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Ftektoncd%2Fcli%2Fpull%2F215) for more info**.\n\n<!-- ok -->",
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *gkarthiks*:",
"text": "@googlebot I signed it!"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/tektoncd/cli/pull/215#\" title=\"Author self-approved\">gkarthiks</a>*, *<a href=\"https://github.com/tektoncd/cli/pull/215#pullrequestreview-274113748\" title=\"LGTM\">sthaha</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=tektoncd%2Fcli).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/tektoncd/cli/blob/master/OWNERS)~~ [sthaha]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *tekton-robot* by author *dibyom*:",
"text": "/ok-to-test"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *gkarthiks*:",
"text": "@googlebot I signed it!"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *tekton-robot* by author *dibyom*:",
"text": "/ok-to-test"
}
}
] |
[
{
"action": "opened",
"author": "nealrichardson",
"comment_id": null,
"datetime": 1589572816000,
"text": "The crossbow jobs now append `, :revision => \"the_current_sha\"` to the git URL in the formula, which makes brew install checkout that commit to build from.\r\n\r\nRelevant homebrew docs: https://docs.brew.sh/Formula-Cookbook#unstable-versions-devel-head",
"title": "ARROW-7803: [R][CI] Autobrew/homebrew tests should not always install from master",
"type": "issue"
},
{
"action": "created",
"author": "nealrichardson",
"comment_id": 629454630,
"datetime": 1589572847000,
"text": "@github-actions crossbow submit homebrew*",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nealrichardson",
"comment_id": 629473653,
"datetime": 1589575200000,
"text": "@github-actions crossbow submit homebrew*",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nealrichardson",
"comment_id": 629478277,
"datetime": 1589576064000,
"text": "@github-actions crossbow submit homebrew*",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nealrichardson",
"comment_id": 629490945,
"datetime": 1589577428000,
"text": "@github-actions crossbow submit homebrew-cpp-autobrew",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Revision: dad17e9312a234a27b9560569cd96f7fa44f1ccb\n\nSubmitted crossbow builds: [ursa-labs/crossbow @ actions-263](https://github.com/ursa-labs/crossbow/branches/all?query=actions-263)\n\n|Task|Status|\n|----|------|\n|homebrew-cpp|[](https://travis-ci.org/ursa-labs/crossbow/branches)|\n|homebrew-cpp-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|\n|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|",
"previous": {
"meta": "This message directly preceded comment from bot *github-actions[bot]* by author *nealrichardson*:",
"text": "@github-actions crossbow submit homebrew*"
}
},
{
"bot": "Revision: a4bcd1081fffca271389bf611ad7f5737e671f8f\n\nSubmitted crossbow builds: [ursa-labs/crossbow @ actions-264](https://github.com/ursa-labs/crossbow/branches/all?query=actions-264)\n\n|Task|Status|\n|----|------|\n|homebrew-cpp-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|",
"previous": {
"meta": "This message directly preceded comment from bot *github-actions[bot]* by author *nealrichardson*:",
"text": "@github-actions crossbow submit homebrew-cpp-autobrew"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *github-actions[bot]* by author *nealrichardson*:",
"text": "@github-actions crossbow submit homebrew*"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *github-actions[bot]* by author *nealrichardson*:",
"text": "@github-actions crossbow submit homebrew-cpp-autobrew"
}
}
] |
[
{
"action": "opened",
"author": "xmudrii",
"comment_id": null,
"datetime": 1556185720000,
"text": "**What this PR does / why we need it**:\r\n\r\nThis PR updates the `machine-controller` to [v1.1.4](https://github.com/kubermatic/machine-controller/releases/tag/v1.1.4) and Cluster-API to [`c63bf6f`](https://github.com/kubernetes-sigs/cluster-api/commit/c63bf6f67ab631a449b6eb76dfe29458441051e0).\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #368 \r\n\r\n**Release note**:\r\n```release-note\r\nUpdate the machine-controller to v1.1.4\r\n```\r\n\r\n/assign @kron4eg \r\n/cc @kron4eg",
"title": "Update machine-controller to v1.1.4 and Cluster-API to c63bf6f",
"type": "issue"
},
{
"action": "created",
"author": "xmudrii",
"comment_id": 486615575,
"datetime": 1556187714000,
"text": "/override pull-kubeone-e2e-digitalocean-conformance-1.13.5\r\n/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1\r\n\r\nProw will retest the PR after this testing cycle is done.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kron4eg",
"comment_id": 486639861,
"datetime": 1556192978000,
"text": "API flakes\r\n\r\n/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kron4eg",
"comment_id": 486650040,
"datetime": 1556195014000,
"text": "API flake\r\n\r\n/retest",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@xmudrii: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubeone-e2e-digitalocean-conformance-1.14.1 | 5e74b244bb6479a9e681cc623f1473047d0b8508 | [link](https://prow.loodse.com/view/gcs/prow-data/pr-logs/pull/kubermatic_kubeone/375/pull-kubeone-e2e-digitalocean-conformance-1.14.1/1121360940592271361) | `/test pull-kubeone-e2e-digitalocean-conformance-1.14.1`\npull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1 | 5e74b244bb6479a9e681cc623f1473047d0b8508 | [link](https://prow.loodse.com/view/gcs/prow-data/pr-logs/pull/kubermatic_kubeone/375/pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1/1121380824374054913) | `/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1`\n\n[Full PR test history](https://prow.loodse.com/pr-history?org=kubermatic&repo=kubeone&pr=375)\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *kubermatic-bot* by author *kron4eg*:",
"text": "API flakes\r\n\r\n/retest"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *kubermatic-bot* by author *kron4eg*:",
"text": "API flakes\r\n\r\n/retest"
}
}
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.