Dataset Viewer
events
list | data_with_bots
list | data_without_bots
list |
|---|---|---|
[
{
"action": "opened",
"author": "et1975",
"comment_id": null,
"datetime": 1448028373000,
"text": "Serving reactor files via mounted GitFS root exposes the backend logic to minions.\r\nIt seems though that reactors being exposed via the roots is not a _requirement_ for them to function and therefore IMHO is an oversight and a security risk. \r\nWhile there are workarounds and ways to hide sensitive information, it is not enough IMHO. Knowing what backend is doing can be of value by itself to an attacker.\r\nWould be great to see GitFS configuration for reactors getting the same treatment as the one for pillars - separate, bypassing the root mounts, and being able to include the reactor.conf itself.",
"title": "GitFS for Reactors",
"type": "issue"
},
{
"action": "created",
"author": "basepi",
"comment_id": 159125755,
"datetime": 1448329655000,
"text": "You make great points here, and I think this is a great idea. Thanks for the request.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mew1033",
"comment_id": 183488710,
"datetime": 1455311297000,
"text": "This is definitely something I want. Reactors should be store-able in gitfs without exposing them to minions.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Da-Juan",
"comment_id": 234481253,
"datetime": 1469175011000,
"text": "I'm interested in this too!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "spyd3r",
"comment_id": 237391178,
"datetime": 1470262283000,
"text": "I'm interested in this feature as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "c4t3l",
"comment_id": 249889371,
"datetime": 1474988091000,
"text": "+1 internets for this idea!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "thatch45",
"comment_id": 249902902,
"datetime": 1474990566000,
"text": "I have added the nitrogen tag here, we would also want to be able to do this with thorium files as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gtmanfred",
"comment_id": 345473398,
"datetime": 1511041302000,
"text": "You can put your reactor files in your regular gitfs fileserver, and just reference it using `salt://reactor/whatever.sls`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "et1975",
"comment_id": 345690804,
"datetime": 1511183393000,
"text": "I'm confused, in the context of the problem (\"hide reactor logic from the minions\") what would that accomplish?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gtmanfred",
"comment_id": 345741403,
"datetime": 1511193877000,
"text": "ahh, i missed that part of the feature request, nevermind.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "et1975",
"comment_id": 473351337,
"datetime": 1552666937000,
"text": "this issue is closed prematurely.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Thank you for updating this issue. It is no longer marked as stale.",
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *et1975*:",
"text": "this issue is closed prematurely."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *stale[bot]* by author *et1975*:",
"text": "this issue is closed prematurely."
}
}
] |
[
{
"action": "opened",
"author": "vasile-ghete",
"comment_id": null,
"datetime": 1422529754000,
"text": "The PR contains only the XML file for L1Menu_Collisions2015_50ns_v0 menu, so it can be merged w/o HLT changes, Changes to use it must be included in another PR.",
"title": "Add XML file for L1Menu_Collisions2015_50ns_v0 menu",
"type": "issue"
},
{
"action": "created",
"author": "degano",
"comment_id": 72034642,
"datetime": 1422542295000,
"text": "@cmsbuild please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mulhearn",
"comment_id": 72582231,
"datetime": 1422931164000,
"text": "+1",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *degano*:",
"text": "@cmsbuild please test"
}
},
{
"bot": "This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *mulhearn*:",
"text": "+1"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *degano*:",
"text": "@cmsbuild please test"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *mulhearn*:",
"text": "+1"
}
}
] |
[
{
"action": "opened",
"author": "epilande",
"comment_id": null,
"datetime": 1468242023000,
"text": "This will allow components to transition in & out.\r\n\r\n",
"title": "Proposing Animate component",
"type": "issue"
},
{
"action": "created",
"author": "primozs",
"comment_id": 231774592,
"datetime": 1468251820000,
"text": "Looks great!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "epilande",
"comment_id": 234521435,
"datetime": 1469187166000,
"text": "Added animation example triggered by scrolling. See grommet/grommet-docs#59\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ericsoderberghp",
"comment_id": 236196769,
"datetime": 1469802849000,
"text": "Sorry it took so long for me to get to this one. Just a few comments.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/7118153)\n\nCoverage decreased (-0.7%) to 8.449% when pulling **6477244f96e0e75db844ab7a11aabcaf42e5f50f on epilande:animate** into **7f994dce9c5ed27c71036d8111fea29611077412 on grommet:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *primozs*:",
"text": "Looks great!"
}
},
{
"bot": "[](https://coveralls.io/builds/7250209)\n\nCoverage decreased (-1.03%) to 8.121% when pulling **15024d9b5232f1a150322f8a292adfedafbde57e on epilande:animate** into **7f994dce9c5ed27c71036d8111fea29611077412 on grommet:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *ericsoderberghp*:",
"text": "Sorry it took so long for me to get to this one. Just a few comments."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *primozs*:",
"text": "Looks great!"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *ericsoderberghp*:",
"text": "Sorry it took so long for me to get to this one. Just a few comments."
}
}
] |
[
{
"action": "opened",
"author": "chaaya",
"comment_id": null,
"datetime": 1464268609000,
"text": "## Feature\r\n- Native out of the box support for English(default) and Swedish.\r\n- Can be configured via the dashboardProvider.\r\n- Translations/langauges can be added to the framework.\r\n\r\n## Why?\r\nIt can seem to be little bit tacky when a system doesnt uses English, in my case our system is in Swedish and all adf labels/tooltips are in English. I think the language support takes the framework to the next level. \r\n\r\nHope you like it :)",
"title": "Feature: Multi-language support",
"type": "issue"
},
{
"action": "created",
"author": "sdorra",
"comment_id": 221938200,
"datetime": 1464283576000,
"text": "Looks really nice. Great job. I would love to see it in the next version.\r\n\r\nBut i'm not sure if i like the name \"culture\", i think i would feel more comfortable with a name like i18n, locale, l10n or something like this. Is there a special reason for culture?\r\n\r\nDo we need a new module or could we add it to adf.provider, to reduce complexity?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdorra",
"comment_id": 221939171,
"datetime": 1464283809000,
"text": "This would fix #102",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdorra",
"comment_id": 221939546,
"datetime": 1464283898000,
"text": "The documentation should be placed elsewhere in the wiki, extra file or we could add some extra pages to the api documentation. But i think the readme would get too long.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chaaya",
"comment_id": 221940840,
"datetime": 1464284212000,
"text": "I had a hard time deciding the name to be honest :) I have used kendo alot and they are using culture, but a culture also has an affect on dateformats and stuff, so it may be the wrong module name to use.\r\n\r\nadf.locale is good module name. \r\n\r\n```javascript\r\ndashboardProvider.setLocale('en-US')\r\n```\r\n\r\nI think it should be a own module, since it has a very narrow scope. That helps with the unit testing if we where to extend the locacle module with its own provider and translation factory that we later could inject into the dashboardProvider.\r\nMaybe I could fix that in the future, but this works for now. \r\n\r\nSound good?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdorra",
"comment_id": 221942414,
"datetime": 1464284547000,
"text": "Yes, sounds good for me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdorra",
"comment_id": 222148712,
"datetime": 1464356350000,
"text": "Thank you very much.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chaaya",
"comment_id": 222149046,
"datetime": 1464356439000,
"text": "@sdorra thank u :) would love som help regarding the wiki. Maybe we can take that privately over gitter?",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/6357910)\n\nCoverage increased (+0.4%) to 92.963% when pulling **8bec896f5eec146576015f5a5b9210cb3def52b1 on momentumsoftwareab:feature/language-support** into **3b910f95431413aa6183abe43f370813f2ba0323 on angular-dashboard-framework:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *sdorra*:",
"text": "Yes, sounds good for me."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *sdorra*:",
"text": "Yes, sounds good for me."
}
}
] |
[
{
"action": "opened",
"author": "ivanbuhov",
"comment_id": null,
"datetime": 1440056531000,
"text": "There is no more `metadata.bin` file. Metadata is now included in the executable upon build. The app thinning will strip the fat binaries to a single slice on the AppStore when the app is distributed to the client devices. This will leave a single copy of the metadata in the actual download from the AppStore.\r\nRelated issue: https://github.com/NativeScript/ios-runtime/issues/179",
"title": "Buhov/metadata merged in binary",
"type": "issue"
},
{
"action": "created",
"author": "fealebenpae",
"comment_id": 132967397,
"datetime": 1440066545000,
"text": "I can't tell from the patch, but did you move the 'Generate Metadata' build phase in the project template to the top? It would be best if it were right before the 'Link Binary' phase, for the same reason @jasssonpet cited for the proposed `PRE_LINK` CMake phase change.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivanbuhov",
"comment_id": 132981997,
"datetime": 1440070386000,
"text": "It turns out that the generation of `__TNSMetadata` section is part of the compilation phase, not the linking phase. It is the linker who does the job (`Ld` command is called), but it is called as part of the compilation process, right after all `CompileC` commands. So when the metadata generation step is between `Compile Sources` and `Link Binary With Libraries` or when it is set as `PRE_LINK` action the compilation phase fails with `ld: can't open -sectcreate file: /Users/buhov/Desktop/NS/ios-runtime/cmake-build/examples/Gameraww/Release-iphoneos/metadata-armv7.bin`, because it expects metadata to be already generated but there is no `metadata-armv7.bin` file yet. When I move the metadata generation step before `Compile Sources` phase (and in the other case - as `PRE_BUILD` action) it works like a charm. So I will leave it as it is unless you have better ideas.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fealebenpae",
"comment_id": 132985120,
"datetime": 1440071595000,
"text": "Alright, makes sense",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivanbuhov",
"comment_id": 133426124,
"datetime": 1440164031000,
"text": "Unfortunately, this approach is not working when NS Runtime is linked dynamically because it seems it is looking for TNSMetadata section in the dynamic library, but it is in the app executable.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jasssonpet",
"comment_id": 133427085,
"datetime": 1440164331000,
"text": "Can we move the extern variable to the app then",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivanbuhov",
"comment_id": 133440714,
"datetime": 1440166861000,
"text": "Yes, it should work. :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fealebenpae",
"comment_id": 134138680,
"datetime": 1440412204000,
"text": ":+1: after squashing to make things prettier",
"title": null,
"type": "comment"
}
] |
[
{
"bot": ":x:",
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *fealebenpae*:",
"text": "Alright, makes sense"
}
},
{
"bot": ":white_check_mark:",
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *ivanbuhov*:",
"text": "Yes, it should work. :+1:"
}
},
{
"bot": ":x:",
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *fealebenpae*:",
"text": ":+1: after squashing to make things prettier"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *fealebenpae*:",
"text": "Alright, makes sense"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *ivanbuhov*:",
"text": "Yes, it should work. :+1:"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *ns-bot* by author *fealebenpae*:",
"text": ":+1: after squashing to make things prettier"
}
}
] |
[
{
"action": "opened",
"author": "tbreloff",
"comment_id": null,
"datetime": 1471638082000,
"text": "",
"title": "name changes",
"type": "issue"
},
{
"action": "created",
"author": "Evizero",
"comment_id": 241125469,
"datetime": 1471638245000,
"text": "we should deprecate the old types I think",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tbreloff",
"comment_id": 241126120,
"datetime": 1471638405000,
"text": "What the best practice to deprecate? I normally just break things without telling anyone.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Evizero",
"comment_id": 241126327,
"datetime": 1471638460000,
"text": "there is a macro for types, I'll look it up",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Evizero",
"comment_id": 241127052,
"datetime": 1471638649000,
"text": "`Base.@deprecate_binding DynMultivalueHistory MVHistory`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Evizero",
"comment_id": 241141189,
"datetime": 1471642459000,
"text": "Thanks! I'm off for today. please feel free to merge once the tests pass",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/7530622)\n\nCoverage remained the same at 79.13% when pulling **8d033c4e734bebc98a6d344b70e7115d27120a46 on tom** into **b4ea936e765e3927189f45782832292ccb5903a4 on master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *Evizero*:",
"text": "Thanks! I'm off for today. please feel free to merge once the tests pass"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *Evizero*:",
"text": "Thanks! I'm off for today. please feel free to merge once the tests pass"
}
}
] |
[
{
"action": "opened",
"author": "viirya",
"comment_id": null,
"datetime": 1424076267000,
"text": "Affinity Propagation (AP), a graph clustering algorithm based on the concept of \"message passing\" between data points. Unlike clustering algorithms such as k-means or k-medoids, AP does not require the number of clusters to be determined or estimated before running it. AP is developed by Frey and Dueck. Please refer to the [paper](http://www.psi.toronto.edu/affinitypropagation/FreyDueckScience07.pdf).",
"title": "[SPARK-5832][Mllib] Add Affinity Propagation clustering algorithm",
"type": "issue"
},
{
"action": "created",
"author": "mengxr",
"comment_id": 74559761,
"datetime": 1424114694000,
"text": "@viirya For new algorithms, we need to discuss whether we want to include it in MLlib on the JIRA page first (before implementing it). Could you describe more about this algorithm on the JIRA page, e.g., scalability, usage, and alternatives?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 74622054,
"datetime": 1424153796000,
"text": "@mengxr okay.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 74638488,
"datetime": 1424164888000,
"text": "@mengxr I updated the JIRA page. Please take a look. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 75284420,
"datetime": 1424453901000,
"text": "@mengxr have we decided no to include this algorithm? If so, please let me know. Then I will close this pr and maintain it as third-party package. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mengxr",
"comment_id": 75288067,
"datetime": 1424455202000,
"text": "I didn't see `cartesian` in your code. So the complexity is really `O(nnz * k)` but not `O(n^2 * k)`, correct? This is the same complexity as PIC/PageRank. If this is the case, let's check the code.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mengxr",
"comment_id": 75297368,
"datetime": 1424458423000,
"text": "@viirya I made a pass on the code. Some high-level feedback:\r\n\r\n1. What is the expected size of the model? Should we store it distributively?\r\n2. Defining a private case class to replace `Seq(Double, Double, Double)` would make the code much easier to read.\r\n3. Please try to add a Java example, which helps test Java API compatibility.\r\n\r\nI will go through the algorithm part again after 2).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mengxr",
"comment_id": 89915614,
"datetime": 1428294910000,
"text": "@viirya Any plan to update this PR?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 89915963,
"datetime": 1428295333000,
"text": "@mengxr I will update this soon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 90643243,
"datetime": 1428425469000,
"text": "@mengxr I updated for small comments. For the bigger ones, I will update later.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 91229215,
"datetime": 1428585490000,
"text": "@mengxr I have added a new function to automatically calculate the preferences used in AP algorithm. In fact, it just the median of similarities.\r\n\r\nBecause I use the function `percentile_approx` in Hive to calculate the median value, it has to add spark-hive as dependency of MLlib. I don't know if this is a good idea? How do you think?\r\n\r\nIf it is not, in order to provide this function to users, where it is better to put this in? Or it is better to implement a custom method to compute the median value?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vanzin",
"comment_id": 91299289,
"datetime": 1428600275000,
"text": "spark-hive can be disabled (in fact it has to be explicitly enabled, it's disabled by default), while mllib cannot, so I guess that is a non-starter.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 91304199,
"datetime": 1428601218000,
"text": "Thanks @vanzin, I think it might be a problem. I decided to move to custom method for median computation.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 91319694,
"datetime": 1428604196000,
"text": "@mengxr The model is now distributed. Edge messages and vertex data are defined as private case classes too. I will try to add Java examples later.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 91601780,
"datetime": 1428681789000,
"text": "@mengxr I have addressed all your comments. Please take a look. Thanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dbtsai",
"comment_id": 99354269,
"datetime": 1430897393000,
"text": "General question. In euclidean space, the negative squared error is used as similarity. If we want to use affinity propagation to clustering lots of samples in euclidean space, it's impossible to create all the pairs of similarity data even it's symmetrical. What's the criteria to filter out those pairs which have very low similarity? Also, it's impossible to compute all the pairs of `RDD[Vector]` since it's O(N^2) operation, and how people address this in practice? \r\n\r\nI really like this algorithm, but still have concern about how people can use it in practice. \r\n\r\nThanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 99541423,
"datetime": 1430932472000,
"text": "@dbtsai Thanks for comments and the question.\r\nI have no very good answer to the question. We have used a threshold to filter out the insignificant similarities of large scale data. As you said, it is impossible to compute all the pairs. However, the data we process is very high dimensional and very sparse, so the all-pair computation can be much reduced by only considering the pairs having corresponding dimensions with values more than zero (or a threshold defined).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dbtsai",
"comment_id": 99565738,
"datetime": 1430937180000,
"text": "@viirya Maybe you can comment on this in the documentation and in the comment of the code, and it will be useful for people trying to understand the use-case.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "viirya",
"comment_id": 121487220,
"datetime": 1436936041000,
"text": "@mengxr any plan to revisit this and merge it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rxin",
"comment_id": 168112592,
"datetime": 1451529759000,
"text": "I'm going to close this pull request. If this is still relevant and you are interested in pushing it forward, please open a new pull request. Thanks!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[Test build #27622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27622/consoleFull) for PR 4622 at commit [`6dbec7d`](https://github.com/apache/spark/commit/6dbec7d451511d17f39750815d4a7d11da03561b).\n * This patch merges cleanly.",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr okay."
}
},
{
"bot": "[Test build #27622 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27622/consoleFull) for PR 4622 at commit [`6dbec7d`](https://github.com/apache/spark/commit/6dbec7d451511d17f39750815d4a7d11da03561b).\n * This patch **passes all tests**.\n * This patch merges cleanly.\n * This patch adds the following public classes _(experimental)_:\n * `class AffinityPropagationModel(`",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I updated the JIRA page. Please take a look. Thanks!"
}
},
{
"bot": "[Test build #29798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29798/consoleFull) for PR 4622 at commit [`d762697`](https://github.com/apache/spark/commit/d762697e4140781b2dc8882c4d654e19ce5bb80b).",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I updated for small comments. For the bigger ones, I will update later."
}
},
{
"bot": "[Test build #30037 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30037/consoleFull) for PR 4622 at commit [`ffe06c3`](https://github.com/apache/spark/commit/ffe06c32fa892fc36a3a7f225ba8df256813e653).",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I have addressed all your comments. Please take a look. Thanks."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr okay."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I updated the JIRA page. Please take a look. Thanks!"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I updated for small comments. For the bigger ones, I will update later."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "@mengxr I have addressed all your comments. Please take a look. Thanks."
}
}
] |
[
{
"action": "opened",
"author": "trunet",
"comment_id": null,
"datetime": 1480857433000,
"text": "It uses a completely new API. More info on https://developer.honeywell.com/content/getting-started-guide.\r\n\r\n\r\n\r\nI didn't find any python library to deal with the new API.",
"title": "Support Honeywell Lyric Thermostat",
"type": "issue"
},
{
"action": "created",
"author": "jzwack",
"comment_id": 264976436,
"datetime": 1480971806000,
"text": "Should be pretty straightforward... does home assistant support auth code OAuth2 flow via a browser?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trunet",
"comment_id": 287303702,
"datetime": 1489741973000,
"text": "This is still not added to latest home-assistant. home-assistant support oauth2 on the webui.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trunet",
"comment_id": 305718542,
"datetime": 1496390558000,
"text": "hello, there is a custom_component that make the deal. should be easy to port to trunk.\r\n\r\ncheck this post:\r\nhttps://community.home-assistant.io/t/honeywell-lyric-thermostat/3520/52",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "trunet",
"comment_id": 338270980,
"datetime": 1508520443000,
"text": "hello, the thread is still going on, we still should have lyric support available",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathanweinberg",
"comment_id": 371230385,
"datetime": 1520446252000,
"text": "Thread is still trucking!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.\n\nPlease make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:",
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *trunet*:",
"text": "This is still not added to latest home-assistant. home-assistant support oauth2 on the webui."
}
},
{
"bot": "There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.\n\nPlease make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:",
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *trunet*:",
"text": "hello, the thread is still going on, we still should have lyric support available"
}
},
{
"bot": "There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.\n\nPlease make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:",
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *jonathanweinberg*:",
"text": "Thread is still trucking!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *trunet*:",
"text": "This is still not added to latest home-assistant. home-assistant support oauth2 on the webui."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *trunet*:",
"text": "hello, the thread is still going on, we still should have lyric support available"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *balloobbot* by author *jonathanweinberg*:",
"text": "Thread is still trucking!"
}
}
] |
[
{
"action": "opened",
"author": "JACKHAHA363",
"comment_id": null,
"datetime": 1456855954000,
"text": "Otherwise there will be an error on my machine.",
"title": "random.sample cannot take np.array. fixed",
"type": "issue"
},
{
"action": "created",
"author": "JACKHAHA363",
"comment_id": 190838642,
"datetime": 1456856060000,
"text": "I signed it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JACKHAHA363",
"comment_id": 190838684,
"datetime": 1456856069000,
"text": "I signed it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "KonradMagnusson",
"comment_id": 190923709,
"datetime": 1456869413000,
"text": "[Related fix.](https://github.com/tensorflow/tensorflow/pull/1335)",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA ([login here](https://cla.developers.google.com/) to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.\n\n<!-- need_author_cla -->",
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *JACKHAHA363*:",
"text": "I signed it."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *JACKHAHA363*:",
"text": "I signed it."
}
}
] |
[
{
"action": "opened",
"author": "davidlange6",
"comment_id": null,
"datetime": 1499703742000,
"text": "for comment about what clang-tidy does to CMSSW (and likely big and not mergeable - this is what clang-tidy check boost-use-to-string does on the tip of CMSSW_9_3_X as of a few days ago",
"title": "clang check boost-use-to-string",
"type": "issue"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 314158887,
"datetime": 1499703898000,
"text": "please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 314164079,
"datetime": 1499704975000,
"text": "please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 314296194,
"datetime": 1499736450000,
"text": "-1\r\n\r\nthis technically looks OK, but it should compile",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ianna",
"comment_id": 314713194,
"datetime": 1499853049000,
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dmitrijus",
"comment_id": 315015599,
"datetime": 1499936035000,
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 315195722,
"datetime": 1499978455000,
"text": "please test\r\n\r\nthe compilation error seems unrelated - i wonder if it reproduces",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 316667624,
"datetime": 1500547757000,
"text": "please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 316779906,
"datetime": 1500572929000,
"text": "merge",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
},
{
"bot": "-1\n\nTested at: 294f8bfa46271bea3ae7cae33cb8b9c86d00ef04\n\n\nThe following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: \nhttps://github.com/cms-sw/cmssw/commit/06199984952d9a6468923f7f1e47bed589272363\nYou can see more details here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-log-recent-commits\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-merge-result\n\nYou can see the results of the tests here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/summary.html\n\nI found follow errors while testing this PR\n\n**Failed tests: Build**\n\n* **Build**:\n\nI found an error when building: \n \n <pre>>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/CSCObjects/test/stubs/CSCPedestalReadAnalyzer.cc \n\fIn file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Archive.h:11:0,\n\f from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Test.h:9,\n\f from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Alignment/test/testSerializationAlignment.cpp:1:\n\f/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/eos/portable_oarchive.hpp: In function 'void testSerialization() [with T = unsigned int]':\n\f/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/eos/portable_oarchive.hpp:319:17: error: 'originalObject' may be used uninitialized in this function [-Werror=maybe-uninitialized]\n\f\f if (T temp = t)\r\n\f ^\n\fIn file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Alignment/test/testSerializationAlignment.cpp:1:0:\n\f/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Test.h:55:7: note: 'originalObject' was declared here\n\f T originalObject;\n\f</pre>\n\n\nThe following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: \nhttps://github.com/cms-sw/cmssw/commit/06199984952d9a6468923f7f1e47bed589272363\nYou can see more details here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-log-recent-commits\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-merge-result",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
},
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test\r\n\r\nthe compilation error seems unrelated - i wonder if it reproduces"
}
},
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test\r\n\r\nthe compilation error seems unrelated - i wonder if it reproduces"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:",
"text": "please test"
}
}
] |
[
{
"action": "opened",
"author": "caesarxuchao",
"comment_id": null,
"datetime": 1439941647000,
"text": "Breaking #12755 into smaller pieces. This is the first PR, it includes:\r\n\r\n1. 26a1992: enforces the URL exposed by apiserver to be in the form of prefix/group/version/...\r\n * for api/v1, we set the APIPrefix=\"api\", group=\"\", version=\"v1\", so the URL is still /api/v1\r\n * for experimental api, we set the APIPrefix=\"api\" (the exact name is open to discussion), group=\"experimental\", version=\"v1alpha1\", so the URL is /api/experimental/v1alpha1. And all future API groups will have the same APIPrefix.\r\n * for openshift and other third party API, we can either make prefix=\"osapi\", group=\"\", or prefix=\"\", group=\"osapi\", so the URL will not be changed.\r\n\r\n2. 45f3232: stop apiserver from encoding api.Status to a specific version unless the version is v1.\r\n\r\n3. 4e4dc89: let the existing two experimental objects use experimental storage which uses the v1alpha1 codec. This maybe needed to pass tests.\r\n\r\nThere will be subsequent PR depending on this one:\r\n\r\n1. factoring out default version, oldest version, storage version, etc. https://github.com/kubernetes/kubernetes/pull/12755#discussion_r37247918\r\n\r\n2. add KubeAPIPrefix https://github.com/kubernetes/kubernetes/pull/12755#discussion_r37251228\r\n\r\n3. move api.Status to unversioned https://github.com/kubernetes/kubernetes/pull/12755#discussion_r37251228\r\n\r\n4. move /expapi to /api/experimental https://github.com/kubernetes/kubernetes/pull/12755#discussion_r37251963\r\n\r\n5. ease our testing for multiple groups/versions\r\nhttps://github.com/kubernetes/kubernetes/pull/12755#discussion_r37329030\r\n\r\n@uluyol @nikhiljindal @bgrant0607 @krousey @smarterclayton @derekwaynecarr",
"title": "add more supports for multiple groups; change the version of experimental api v1alpha1",
"type": "issue"
},
{
"action": "created",
"author": "smarterclayton",
"comment_id": 132722125,
"datetime": 1440007138000,
"text": "Can we summarize the current status of the proposal into a proposal document or design (if one doesn't exist)? I have a lot of concerns about this but I'm finding I can't keep up with the pace of the design. I think this is a fundamental part of the core product we're changing, so if anything deserves a proposal it's this. I'd also like to offer my feedback on the pieces that are important to us (as an external API group that has different needs than expapi) and I'm worried about spreading around these pulls.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "smarterclayton",
"comment_id": 132722195,
"datetime": 1440007153000,
"text": "@bgrant0607 re my comment about this needing a proposal",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 132734283,
"datetime": 1440009119000,
"text": "@smarterclayton, I will write one.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 135131296,
"datetime": 1440613653000,
"text": "cc @lavalamp, this is the first step of #12591.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 136532386,
"datetime": 1441066007000,
"text": "@nikhiljindal, you can ignore the second commit \"don't encode api.Status to a version if the version is not v1\", because we changed our plan for it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhiljindal",
"comment_id": 136582255,
"datetime": 1441081687000,
"text": "I just glanced over the later part of PR as its a big one.\r\nI have added some comments, which should give you enough to work on for now.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 136590702,
"datetime": 1441085384000,
"text": "#12837 enables validate by default and it reveals the problem that validation doesn't work across groups of different versions. I'm fixing the problem.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 136592237,
"datetime": 1441086264000,
"text": "client.ServerAPIVersions() needs to be fixed. Currently it reports:\r\nServer does not support API version 'experimental/v1alpha1'. Falling back to 'v1'.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhiljindal",
"comment_id": 136841441,
"datetime": 1441137469000,
"text": "Is it possible to take the test changes out of this PR?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 136845246,
"datetime": 1441137956000,
"text": "Unless we have a way to disable the tests related to experimental objects, they will fail without the changes to the tests.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bgrant0607",
"comment_id": 143944236,
"datetime": 1443502376000,
"text": "Is this PR still active?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caesarxuchao",
"comment_id": 143944408,
"datetime": 1443502526000,
"text": "No. Thanks for the reminding.\r\n\r\nSuperseded by #14156, #13833, and #13581 etc.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "GCE e2e build/test **failed** for commit 9a139b6efbb6bd910bed47fe4e68fe6fd28d122e.\n* [Build Log](https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/9a139b6efbb6bd910bed47fe4e68fe6fd28d122e/kubernetes-pull-build-test-e2e-gce/6348/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/9a139b6efbb6bd910bed47fe4e68fe6fd28d122e/kubernetes-pull-build-test-e2e-gce/6348/_artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//6348)",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-bot* by author *caesarxuchao*:",
"text": "@smarterclayton, I will write one."
}
},
{
"bot": "GCE e2e build/test **failed** for commit b7035afee127f5228d340d7469fce2c652f4dcd4.\n* [Build Log](https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/b7035afee127f5228d340d7469fce2c652f4dcd4/kubernetes-pull-build-test-e2e-gce/6357/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/b7035afee127f5228d340d7469fce2c652f4dcd4/kubernetes-pull-build-test-e2e-gce/6357/_artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//6357)",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-bot* by author *caesarxuchao*:",
"text": "cc @lavalamp, this is the first step of #12591."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-bot* by author *caesarxuchao*:",
"text": "@smarterclayton, I will write one."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-bot* by author *caesarxuchao*:",
"text": "cc @lavalamp, this is the first step of #12591."
}
}
] |
[
{
"action": "opened",
"author": "Ladas",
"comment_id": null,
"datetime": 1466680246000,
"text": "Service should load all_vms from nested services\r\n\r\nThen parent service page shows all vms of all nested services, which is a nice overview.",
"title": "Service should load all_vms from nested services",
"type": "issue"
},
{
"action": "created",
"author": "Ladas",
"comment_id": 228018692,
"datetime": 1466680306000,
"text": "@bzwei @gmcculloug if you have any insight guys, it would be nice. Point is to see all VMs in the top level service.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bzwei",
"comment_id": 228386988,
"datetime": 1466784297000,
"text": "cc @kbrock",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kbrock",
"comment_id": 228626316,
"datetime": 1466979350000,
"text": "Thanks bill. @ladas let's talk Monday. I would like to know where the old code was not bringing back all the vms. Sounds like you found a bug. But I'm guessing the bug is not in the call to all_vms vs direct_vms",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kbrock",
"comment_id": 229951446,
"datetime": 1467380932000,
"text": ":+1: with this pr.\r\n\r\nI think the failure may be a bad test. @Ladas could you take a look at the return values and determine the underlying cause?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ladas",
"comment_id": 229982383,
"datetime": 1467388392000,
"text": "@kbrock test should be fixed now",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kbrock",
"comment_id": 230046727,
"datetime": 1467406969000,
"text": "@Ladas is this for darga?",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "<rubocop />Checked commit https://github.com/Ladas/manageiq/commit/29f597bf28130d0425c7ba1d09fb299d9b5458e2 with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1\n2 files checked, 0 offenses detected\nEverything looks good. :trophy:",
"previous": {
"meta": "This message directly preceded comment from bot *miq-bot* by author *Ladas*:",
"text": "@kbrock test should be fixed now"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *miq-bot* by author *Ladas*:",
"text": "@kbrock test should be fixed now"
}
}
] |
[
{
"action": "opened",
"author": "aaronlevy",
"comment_id": null,
"datetime": 1441848829000,
"text": "The current conformance-test-v1 branch does not use the KUBE_MASTER_URL extracted from the kubeconfig.\r\n\r\nIt looks like this change is already in master from: https://github.com/kubernetes/kubernetes/commit/29da889bbf0acbf579ea155e4cc66ae168705468\r\n\r\nBut looks like only part of that change was pulled into conformance-test-v1: https://github.com/kubernetes/kubernetes/commit/104aa5d361e624a2d11198ef00fd737dab588f60",
"title": "Use KUBE_MASTER_URL in conformance test",
"type": "issue"
},
{
"action": "created",
"author": "ixdy",
"comment_id": 139398355,
"datetime": 1441923526000,
"text": "ok to test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ixdy",
"comment_id": 139403953,
"datetime": 1441925323000,
"text": "oh, this branch is not whitelisted, so @k8s-bot will never test it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erictune",
"comment_id": 140229429,
"datetime": 1442271905000,
"text": "LGTM.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erictune",
"comment_id": 140229533,
"datetime": 1442271951000,
"text": "Merging because it is to a special branch that I am the defacto owner of",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Labelling this PR as size/XS",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *ixdy*:",
"text": "oh, this branch is not whitelisted, so @k8s-bot will never test it."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *ixdy*:",
"text": "oh, this branch is not whitelisted, so @k8s-bot will never test it."
}
}
] |
[
{
"action": "opened",
"author": "krris",
"comment_id": null,
"datetime": 1476361465000,
"text": "This PR resolves an issue https://github.com/spotify/HubFramework/issues/51",
"title": "Image loader: Replace cache-check with timer",
"type": "issue"
},
{
"action": "created",
"author": "krris",
"comment_id": 255058373,
"datetime": 1476956357000,
"text": "@JohnSundell 🎾",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krris",
"comment_id": 255079574,
"datetime": 1476962691000,
"text": "@JohnSundell 🎾",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "<table>\n <thead>\n <tr>\n <th width=\"50\"></th>\n <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Warning\">\n 1 Warning\n </th>\n </tr>\n </thead>\n <tbody>\n\n <tr>\n <td>:warning:</td>\n <td data-sticky=\"true\">Couldn’t find the (junit) unit test report file in ‘build/tests/’. Make sure the tests were actually run.</td>\n </tr>\n </tbody>\n</table>\n\n<p align=\"right\" data-meta=\"generated_by_danger\">\n Generated by :no_entry_sign: <a href=\"http://danger.systems/\">danger</a>\n</p>",
"previous": {
"meta": "This message directly preceded comment from bot *spotify-ci-bot* by author *krris*:",
"text": "@JohnSundell 🎾"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *spotify-ci-bot* by author *krris*:",
"text": "@JohnSundell 🎾"
}
}
] |
[
{
"action": "opened",
"author": "thockin",
"comment_id": null,
"datetime": 1423951886000,
"text": "In some places we expect an IP where a hostname might suffice. We should make a pass over the API and decide for each case and document/test it properly. As per #1300 the \"must be IP\" fields can self-document as net.IP. The hostname-or-IP fields we can think about decoding tricks.",
"title": "API: analyze all \"IP\" fields and decide if hostname is valid",
"type": "issue"
},
{
"action": "created",
"author": "girishkalele",
"comment_id": 236397692,
"datetime": 1469923411000,
"text": "I guess this one is still open - #11838 was closed in favor of https://github.com/kubernetes/kubernetes/issues/13748 but that one is also still open.\r\n\r\nTo summarize my understanding, if an EndpointsAddress entry is added to a service endpoint that contains a string IP or hostname field, we respond with CNAME records ?\r\nCan CNAME and A records be mixed in a response ? i.e. if the service has both IP and hostname endpoints, can we serve a mixed CNAME and A record response ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "thockin",
"comment_id": 236499092,
"datetime": 1470032800000,
"text": "#13748 will be worked on by @rata.\n\nYou can not mix CNAME and A records, and in fact you can not even have\nmultiple CNAME records.\n\nNeither of those are what this one is about, though. This is about\nauditing the API and documenting when a field *must* be an IP (and\nadding/tightening validation and tests in those cases) vs when a field may\nbe an IP or a hostname (and adding/loosening validation and tests in those\ncases).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kargakis",
"comment_id": 305931812,
"datetime": 1496446444000,
"text": "@kubernetes/sig-network-misc",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Issues go stale after 90d of inactivity.\nMark the issue as fresh with `/remove-lifecycle stale`.\nStale issues rot after an additional 30d of inactivity and eventually close.\n\nPrevent issues from auto-closing with an `/lifecycle frozen` comment.\n\nIf this issue is safe to close now please do so with `/close`.\n\nSend feedback to sig-testing, kubernetes/test-infra and/or `@fejta`.\n/lifecycle stale",
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *kargakis*:",
"text": "@kubernetes/sig-network-misc"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *kargakis*:",
"text": "@kubernetes/sig-network-misc"
}
}
] |
[
{
"action": "opened",
"author": "ueshin",
"comment_id": null,
"datetime": 1494399890000,
"text": "## What changes were proposed in this pull request?\r\n\r\nBecause the method `TimeZone.getTimeZone(String ID)` is synchronized on the TimeZone class, concurrent call of this method will become a bottleneck.\r\nThis especially happens when casting from string value containing timezone info to timestamp value, which uses `DateTimeUtils.stringToTimestamp()` and gets TimeZone instance on the site.\r\n\r\nThis pr makes a cache of the generated TimeZone instances per thread to avoid the synchronization.\r\n\r\n## How was this patch tested?\r\n\r\nExisting tests.",
"title": "[SPARK-20588][SQL] Cache TimeZone instances per thread.",
"type": "issue"
},
{
"action": "created",
"author": "viirya",
"comment_id": 301358915,
"datetime": 1494813801000,
"text": "LGTM",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gatorsmile",
"comment_id": 301636373,
"datetime": 1494892372000,
"text": "Thanks! Merging to master/2.2",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "**[Test build #76923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76923/testReport)** for PR 17933 at commit [`3cdbb3a`](https://github.com/apache/spark/commit/3cdbb3acf12b2082056e8b4e2eb3f1645fa1bde7).",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "LGTM"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *viirya*:",
"text": "LGTM"
}
}
] |
[
{
"action": "opened",
"author": "Undo1",
"comment_id": null,
"datetime": 1465223634000,
"text": "Missing backtick was causing unhappiness.",
"title": "Fix formatting issue",
"type": "issue"
},
{
"action": "created",
"author": "Undo1",
"comment_id": 223977658,
"datetime": 1465223723000,
"text": "@googlebot I signed it!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "girving",
"comment_id": 224019156,
"datetime": 1465232133000,
"text": "@Undo1: Thank you for the fix! Backticks are depressing hard to see. :)",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "CLAs look good, thanks!\n\n<!-- ok -->",
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *Undo1*:",
"text": "@googlebot I signed it!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *Undo1*:",
"text": "@googlebot I signed it!"
}
}
] |
[
{
"action": "opened",
"author": "liancheng",
"comment_id": null,
"datetime": 1433135074000,
"text": "This is a follow-up of PR #6493, which has been reverted in branch-1.4 because it uses Java 7 specific APIs and breaks Java 6 build. This PR replaces those APIs with equivalent Guava ones to ensure Java 6 friendliness.\r\n\r\ncc @andrewor14 @pwendell, this should also be back ported to branch-1.4.",
"title": "[SQL] [TEST] [MINOR] Follow-up of PR #6493, use Guava API to ensure Java 6 friendliness",
"type": "issue"
},
{
"action": "created",
"author": "andrewor14",
"comment_id": 107308592,
"datetime": 1433135642000,
"text": "lgtm merging once tests pass",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liancheng",
"comment_id": 107851793,
"datetime": 1433232307000,
"text": "Addressed @zsxwing's comment, will merge this to master and branch-1.4 once Jenkins passes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andrewor14",
"comment_id": 108136412,
"datetime": 1433290043000,
"text": "master 1.4 thanks cheng",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[Test build #33876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33876/consoleFull) for PR 6547 at commit [`72da795`](https://github.com/apache/spark/commit/72da795dee1e7926452d134f7b0c6d4a0549dc31).\n * This patch **passes all tests**.\n * This patch merges cleanly.\n * This patch adds no public classes.",
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *andrewor14*:",
"text": "lgtm merging once tests pass"
}
},
{
"bot": "Merged build triggered.",
"previous": {
"meta": "This message directly preceded comment from bot *AmplabJenkins* by author *liancheng*:",
"text": "Addressed @zsxwing's comment, will merge this to master and branch-1.4 once Jenkins passes."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *SparkQA* by author *andrewor14*:",
"text": "lgtm merging once tests pass"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *AmplabJenkins* by author *liancheng*:",
"text": "Addressed @zsxwing's comment, will merge this to master and branch-1.4 once Jenkins passes."
}
}
] |
[
{
"action": "opened",
"author": "romanblanco",
"comment_id": null,
"datetime": 1427722740000,
"text": "Parent issue: #2389\r\nShould be reviewed after #2425 got merged",
"title": "Added missing semicolons, var's; using dot notation",
"type": "issue"
},
{
"action": "created",
"author": "martinpovolny",
"comment_id": 95582976,
"datetime": 1429795568000,
"text": "No further notes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "martinpovolny",
"comment_id": 96656890,
"datetime": 1430142324000,
"text": "@romanblanco : great, thx for the re-checking. I'd merge this right after we for a branch for the release.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "<rubocop />Checked commits https://github.com/romanblanco/manageiq/commit/7ba11adbfa2846ca222c4ce33acd36b23915fe3d .. https://github.com/romanblanco/manageiq/commit/7f5ddaa32b5350afbe6bfbda89ec800e42e3187f with rubocop 0.27.1\n0 files checked, 0 offenses detected\nEverything looks good. :+1:",
"previous": {
"meta": "This message directly preceded comment from bot *miq-bot* by author *martinpovolny*:",
"text": "No further notes."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *miq-bot* by author *martinpovolny*:",
"text": "No further notes."
}
}
] |
[
{
"action": "opened",
"author": "makortel",
"comment_id": null,
"datetime": 1466605894000,
"text": "The check for `Track::seedRef()` availability in MultiTrackValidator, added in #14248, was not sufficient. This omission leads to an exception from missing product in the MTV standalone mode ([SWGuideMultiTrackValidator#cmsDriver_MTV_alone_i_e_standalo](https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMultiTrackValidator#cmsDriver_MTV_alone_i_e_standalo)). Requiring explicitly the availability of the seed product fixes the exception. Thanks to @ebrondol for reporting the bug.\r\n\r\nTested in CMSSW_8_1_0_pre6, no changes expected in standard workflows.\r\n\r\n@rovere @VinInn",
"title": "Fix to MultiTrackValidator standalone mode",
"type": "issue"
},
{
"action": "created",
"author": "VinInn",
"comment_id": 228316456,
"datetime": 1466765727000,
"text": "@cmsbuild , please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ebrondol",
"comment_id": 228479847,
"datetime": 1466807875000,
"text": "@kpedro88 is it possible to fit also this in pre8? It would be useful (with another PR that I am testing now) to fix the validation for the phase2 tracking.. We just discover the issue today.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kpedro88",
"comment_id": 228480219,
"datetime": 1466807998000,
"text": "@davidlange6 this seems to be a one-line bug fix, would be nice to put in pre8.\r\n\r\n@dmitrijus, @vanbesien please review and sign if possible (I realize it's short notice, but it seems to be a straightforward change).",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *VinInn*:",
"text": "@cmsbuild , please test"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *VinInn*:",
"text": "@cmsbuild , please test"
}
}
] |
[
{
"action": "created",
"author": "colemickens",
"comment_id": 253090941,
"datetime": 1476234411000,
"text": "I hit it too, direct link to build: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/34416/kubernetes-pull-test-unit-integration/48793/ PR here: https://github.com/kubernetes/kubernetes/pull/34416",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dims",
"comment_id": 253094273,
"datetime": 1476235829000,
"text": "@colemickens : can you try rebasing on https://github.com/kubernetes/kubernetes/commit/3d2674b2ddbdea485e1114479b03392ce2589c4c ? That should have fixed this problem",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "colemickens",
"comment_id": 253097030,
"datetime": 1476237019000,
"text": "Looks like they finally passed and retest is skipped for the submit-queue for that PR, so I'd prefer not to rebase and risk encountering another flake.\r\n\r\nIf you need it as a confirmation of 3d2674b, let me know and I'll force push my rebase.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dims",
"comment_id": 253097913,
"datetime": 1476237433000,
"text": "@colemickens no worries. things are looking up in the gate. we can close this issue out tomorrow",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gmarek",
"comment_id": 253155714,
"datetime": 1476262190000,
"text": "This is still happening and blocking the build. @apelisse please treat this as a real P0.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "piosz",
"comment_id": 253187924,
"datetime": 1476271609000,
"text": "cc @deads2k @kargakis",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "deads2k",
"comment_id": 253195860,
"datetime": 1476274086000,
"text": "opened https://github.com/kubernetes/kubernetes/pull/34608",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "piosz",
"comment_id": null,
"datetime": 1476277187000,
"text": "",
"title": null,
"type": "issue"
}
] |
[
{
"bot": "https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/18013/\n\nFailed: TestDeploymentController_dontSyncDeploymentsWithEmptyPodSelector {deployment}\n\n```\ndeployment_controller_test.go:270: expected deployment controller to not take action\n```",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *gmarek*:",
"text": "This is still happening and blocking the build. @apelisse please treat this as a real P0."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *gmarek*:",
"text": "This is still happening and blocking the build. @apelisse please treat this as a real P0."
}
}
] |
[
{
"action": "opened",
"author": "apfeiffer1",
"comment_id": null,
"datetime": 1426780969000,
"text": "add listGTs sub-command to commandline tool (conddb) to list all GTs in condDBv2",
"title": "add functionality to list all GTs in condDBv2",
"type": "issue"
},
{
"action": "created",
"author": "ggovi",
"comment_id": 83990490,
"datetime": 1426851137000,
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 84022034,
"datetime": 1426859937000,
"text": "+1",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *ggovi*:",
"text": "+1"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *ggovi*:",
"text": "+1"
}
}
] |
[
{
"action": "opened",
"author": "hsanjuan",
"comment_id": null,
"datetime": 1491445739000,
"text": "This should fix what I meant in #84\r\n\r\nLicense: MIT",
"title": "WIP: A guide to running ipfs cluster",
"type": "issue"
},
{
"action": "created",
"author": "hsanjuan",
"comment_id": 292652666,
"datetime": 1491599428000,
"text": "Would be good to get feedback here.\r\n\r\n@bgadmin, would you like to read this guide and provide some feedback? Like things that are missing, or not clear enough and can be better explained...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bgadmin",
"comment_id": 292859379,
"datetime": 1491805210000,
"text": "@hsanjuan sure thing, sorry for late reply will get back to you today :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "VictorBjelkholm",
"comment_id": 292866558,
"datetime": 1491807934000,
"text": "Would be nice to have a quickstart in the top, similar to what was in the top-level readme.md before, where you just list the minimal set of commands to get up and running.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hsanjuan",
"comment_id": 296367958,
"datetime": 1492861762000,
"text": "I have added the quickstart to the main README.. The guide is meant for a more in-depth approach.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/11194158)\n\nCoverage decreased (-0.07%) to 74.095% when pulling **ef4132f57220528bc058d9a9eee701c7082bcea1 on guide** into **98039bdd0d5d77f1230bef5e65b7d21069548a95 on master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *hsanjuan*:",
"text": "I have added the quickstart to the main README.. The guide is meant for a more in-depth approach."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *hsanjuan*:",
"text": "I have added the quickstart to the main README.. The guide is meant for a more in-depth approach."
}
}
] |
[
{
"action": "opened",
"author": "haypo",
"comment_id": null,
"datetime": 1509500590000,
"text": "bpo-31910: test_create_connection() now catchs also EADDRNOTAVAIL to\r\nfix the test on Travis CI.\n\n<!-- issue-number: bpo-31910 -->\nhttps://bugs.python.org/issue31910\n<!-- /issue-number -->",
"title": "bpo-31910: Fix test_socket.test_create_connection()",
"type": "issue"
},
{
"action": "created",
"author": "miss-islington",
"comment_id": 340963251,
"datetime": 1509504507000,
"text": "Thanks @haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.\n🐍🍒⛏🤖",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "miss-islington",
"comment_id": 340963297,
"datetime": 1509504525000,
"text": "Thanks @haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.\n🐍🍒⛏🤖",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[GH-4209](https://github.com/python/cpython/pull/4209) is a backport of this pull request to the [2.7 branch](https://github.com/python/cpython/tree/2.7).",
"previous": {
"meta": "This message directly preceded comment from bot *bedevere-bot* by author *miss-islington*:",
"text": "Thanks @haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.\n🐍🍒⛏🤖"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *bedevere-bot* by author *miss-islington*:",
"text": "Thanks @haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.\n🐍🍒⛏🤖"
}
}
] |
[
{
"action": "opened",
"author": "cblecker",
"comment_id": null,
"datetime": 1516647924000,
"text": "",
"title": "Add mergewarning to k/community",
"type": "issue"
},
{
"action": "created",
"author": "spiffxp",
"comment_id": 359530402,
"datetime": 1516647989000,
"text": "/lgtm",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/test-infra/pull/6374#\" title=\"Author self-approved\">cblecker</a>*, *<a href=\"https://github.com/kubernetes/test-infra/pull/6374#issuecomment-359530402\" title=\"LGTM\">spiffxp</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\n<details >\nNeeds approval from an approver in each of these OWNERS Files:\n\n- ~~[prow/OWNERS](https://github.com/kubernetes/test-infra/blob/master/prow/OWNERS)~~ [spiffxp]\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *spiffxp*:",
"text": "/lgtm"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *spiffxp*:",
"text": "/lgtm"
}
}
] |
[
{
"action": "opened",
"author": "dorzel",
"comment_id": null,
"datetime": 1468511520000,
"text": "create empty environments when no packages are supplied in create",
"title": "WIP Create empty environments",
"type": "issue"
},
{
"action": "created",
"author": "kalefranz",
"comment_id": 232720699,
"datetime": 1468514290000,
"text": "Will definitely need at least one test in `test_create` for this. Read through the tests that are currently there for examples and inspiration.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dorzel",
"comment_id": 233006313,
"datetime": 1468601575000,
"text": "@kalefranz all tests passed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kalefranz",
"comment_id": 233102959,
"datetime": 1468635123000,
"text": "This PR can be merged by Monday for 4.2.0rc1 as is, but there's still a bit more work to do here and there I think. One thing that I think we probably need is some additional unit tests for `History` now.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dorzel",
"comment_id": 233669691,
"datetime": 1468942080000,
"text": "@kalefranz let me know if this looks good",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[cc-base-branch]: https://codecov.io/gh/conda/conda/branch/master?src=pr\n[cc-compare]: https://codecov.io/gh/conda/conda/compare/86a24ee68c697da3dee807787d3f4c3db6fcef22...2a29d3de44e0def5b54d741b66fb5aa6a484d11c?src=pr\n[cc-pull]: https://codecov.io/gh/conda/conda/pull/3072?src=pr",
"previous": {
"meta": "This message directly preceded comment from bot *codecov-io* by author *dorzel*:",
"text": "@kalefranz let me know if this looks good"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *codecov-io* by author *dorzel*:",
"text": "@kalefranz let me know if this looks good"
}
}
] |
[
{
"action": "opened",
"author": "isobelojalvo",
"comment_id": null,
"datetime": 1453751447000,
"text": "In 76X we were missing some necessary tau discriminators and had an issue with a new decay mode in the decay mode finding algorithm. The fix was applied in 76X by re-running the Taus at the miniAOD step. This pull request makes the RECO/AOD sequence the same as what is run in the miniAOD sequence in 76X (i.e. integration of needed discriminators + bugfix) and removes the 're-running' of the taus in miniAOD.",
"title": "Integration of 76X Tau re-miniAOD into main 80X Sequence",
"type": "issue"
},
{
"action": "created",
"author": "slava77",
"comment_id": 174646529,
"datetime": 1453752784000,
"text": "@isobelojalvo what is the relationship between this PR and #13042 ?\r\nIt looks like the same code is modified, also, the original branch in #13402 was removed, which I guess means that #13402 should be closed.\r\nPlease clarify.\r\nThank you.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 174651335,
"datetime": 1453753564000,
"text": "Hi, The 80xReMiniAOD should be used and the 80xReMiniAODv2 had been created as a dummy for testing purposes. I should have notified AJ of this earlier! Apologies! Could you please work off this pull request?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 174654749,
"datetime": 1453754151000,
"text": "@cmsbuild please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 174953645,
"datetime": 1453805328000,
"text": "Checking the unit tests I see they are run on the following sample:\r\n\r\n25-Jan-2016 22:04:29 CET Successfully opened file root://eoscms.cern.ch//eos/cms/store/relval/CMSSW_7_6_0_pre7/RelValProdTTbar_13/AODSIM/76X_mcRun2_asymptotic_v5-v1/00000/0E9A5DE8-1D71-E511-A205-00261894380D.root\r\n\r\nThe error we see is that MVA6 is not present. This is certainly true: we did not have MVA6 in 7_6_0 at MVA6. Am I missing something? @slava77 @cvuosalo @andrewj314",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175194978,
"datetime": 1453837318000,
"text": "@isobelojalvo: For the RECO product of workflow 134.805_RunMET2015C, I find 64 added tau discriminators and 16 removed, for a net gain of 48 discriminators. I think we want to keep the net addition of discriminators to be less than 10. Could you please remove more obsolete and unneeded products?\r\n\r\nI see no change in Mini-AOD event content, and I'm still checking AOD.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175196776,
"datetime": 1453837659000,
"text": "@isobelojalvo: The PR description does not describe the results of \"fixing\" the decay mode algorithm. There are numerous differences showing up for workflow 134.805_RunMET2015C. Are these differences expected? If so, please add an explanation of the expected differences to the PR description. Here are some examples:\r\n\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 175245569,
"datetime": 1453844542000,
"text": "@cvuosalo Thanks for the plots. Could you tell me if red is from the current pull request or from the old? (or how can I check this myself?) Thank you!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175261446,
"datetime": 1453846723000,
"text": "@isobelojalvo: Yes, red in the plots is from the PR, and black is from the baseline I used, 800pre5.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175266174,
"datetime": 1453847181000,
"text": "@isobelojalvo: I checked AOD event content also, by using workflow 1000.0_RunMinBias2011A. Again, this PR adds 64 new tau discriminators, while only removing 16. We should be aiming to remove almost as many old, unneeded discriminators as new ones being added.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 175274049,
"datetime": 1453848079000,
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175287972,
"datetime": 1453849987000,
"text": "@slava77: With this PR, there are 140 tau discriminators in AOD for workflow 1000.0_RunMinBias2011A.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175290536,
"datetime": 1453850668000,
"text": "@isobelojalvo: Concerning the unit test failures, the baseline used by Jenkins, CMSSW_8_0_X_2016-01-25-1100, performs the same unit tests successfully. It would seem this PR somehow adds the dependence on MVA6, as indicated by this error message:\r\n```\r\nPrincipal::getByToken: Found zero products matching all criteria\r\nLooking for type: reco::PFTauDiscriminator\r\nLooking for module label: hpsPFTauDiscriminationByMVA6LooseElectronRejection\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 175292207,
"datetime": 1453851031000,
"text": "Hi @cvuosalo, First: apologies about to go offline in a few minutes and will address other issues in the morning. Second: concerning the MVA6, yes, I see it is missing. However, I think this is due to the pattuplization test running on a 76x AOD sample. Dumping the event content of that file shows MVA6 is not there: This is the correct and expected behavior.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 175329702,
"datetime": 1453858040000,
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 175711784,
"datetime": 1453910698000,
"text": "@slava77 @cvuosalo \r\nRelval sample:\r\nOK, we will see about the new relval sample. I am actually not used to the workflow for the creation of a new relval. Any guidance would help. I will also check with our tau relval experts. In the mean time, is it allowed to run on a privately produce sample instead? And can this pull request be integrated before the new relval is produced? (I am worrying about the timescale here)\r\n\r\nNumber of Discriminants:\r\nWe have a preference to do the discriminant clean up in a separate branch so that we can keep track if there is an error in the clean up. I created a new branch[*] in cms-tau-pog and will do a pull request when this branch is edited. It should be fast. \r\n\r\nDQM Plots:\r\nIt is expected that the efficiency will increase and this should be in line with what we see in 76xReminiAOD. In the plots, the low efficiency in the black was apparently due to the 3prong+1pi0 integration. It is removed in the current pull request. We are working towards reintegration in the NewDecayModes and not in the OldDecayModes.\r\n\r\n[*]https://github.com/cms-tau-pog/cmssw/tree/80xReMiniAOD-RemoveOldDisc",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 175720214,
"datetime": 1453911625000,
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 175740586,
"datetime": 1453913527000,
"text": "About the unit tests, I was thinking that we could generate an AOD file on the fly for the case where we know well that the new AOD format is needed.\r\n\r\n@gpetruc I seem to remember we did something to make the tests running PAT on AOD inputs to complete in a similar case. Do you remember what was done?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 175742134,
"datetime": 1453913804000,
"text": "The discriminants for removal are listed in the attached files created by Aruna\r\n\r\nA rough count shows approximately 1/3 can certainly be removed. The increase overall is partially due to the addition of a new MVA6 electron discriminator and keeping the MVA5, we can remove MVA5 in the next cycle after analysts have had a chance to fully validate MVA6.\r\n\r\n[PatTauID_Discriminators_80X.txt](https://github.com/cms-sw/cmssw/files/106993/PatTauID_Discriminators_80X.txt)\r\n[RecoTauID_Discriminators_80X.txt](https://github.com/cms-sw/cmssw/files/106992/RecoTauID_Discriminators_80X.txt)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 175915937,
"datetime": 1453938895000,
"text": "@isobelojalvo, @slava77: I am editing the list of tau discriminators here: https://twiki.cern.ch/twiki/bin/view/CMS/RecoTauDiscrim",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 176260586,
"datetime": 1453998136000,
"text": "As suggested, I removed the new inputs. I will put them back in for pre6. Could this be tested?\r\n\r\nThanks",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 176263872,
"datetime": 1453998507000,
"text": "@cmsbuild please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 176343781,
"datetime": 1454007867000,
"text": "@cvuosalo concerning the twiki update, I have pointed Arun to the twiki and he will modify as necessary he has also already committed the cleaned up branch. Depending on the release schedule, it would be nice to have the cleaned up branch added to the next release. Let me know if this is a problem for you.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 177000804,
"datetime": 1454106926000,
"text": "+1\r\n\r\nFor #13060 a20e68d1d9f843be26c134fcb066a63c992ff55f\r\n\r\nAdds some new tau discriminators and removes a few obsolete ones. Also, removes the 3prong1pi0 decay mode from the AOD sequence.\r\n\r\nFollow-up PRs will delete additional unneeded tau discriminators and will add new input for PAT algos after they become available in the next pre-release, as discussed above.\r\n\r\nThe code changes are satisfactory. Jenkins [tests](https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13060/10818/summary.html) against baseline CMSSW_8_0_X_2016-01-27-2300 show numerous, insignificant differences related to tau decay modes, plus efficiency increases that are expected, as discussed above. Tests of workflow 25202.0_TTbar_13 with 70 events against baseline CMSSW_8_0_0_pre5 show similar differences as those from the Jenkins test results and the plots shown above. An additional example difference plot from this 25202 test is shown below.\r\n\r\nMemory and timing measurements show no significant increase. Two timing measurements show no increase, while a third measurement shows an overall timing increase of 1%. At worst, the new tau discriminators may increase times by 18 ms per event, but we expect a follow-up PR that will delete more obsolete discriminators and reduce this timing increase.\r\n\r\nExample of change in decay mode finding frequencies:\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cvuosalo",
"comment_id": 177011400,
"datetime": 1454108749000,
"text": "Additional timing measurements from test of workflow 25202 (without Validation step) against baseline CMSSW_8_0_0_pre5:\r\n\r\n```\r\nTotal time formerly used by deleted discriminators: 2.8 ms/ev\r\nTotal time used by new discriminators: 62.3 ms/ev\r\n\r\nNew discriminators taking > 3 ms/ev\r\n hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr3HitsdR03 4.90777 ms/ev\r\n hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3HitsdR03 4.88347 ms/ev\r\n hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr3HitsdR03 4.88874 ms/ev\r\n hpsPFTauDiscriminationByIsolationMVArun2v1PWnewDMwLTraw 3.37712 ms/ev\r\n hpsPFTauPUcorrPtSumdR03 4.82939 ms/ev\r\n hpsPFTauNeutralIsoPtSumWeightdR03 3.78463 ms/ev\r\n hpsPFTauDiscriminationByIsolationMVArun2v1DBdR03oldDMwLTraw 3.28005 ms/ev\r\n hpsPFTauDiscriminationByIsolationMVArun2v1PWdR03oldDMwLTraw 3.40165 ms/ev\r\n\r\n\r\nRetained discriminator that uses the most time, change from baseline to PR:\r\n hpsPFTauDiscriminationByMVA5rawElectronRejection 15.8576 ms/ev -> 12.6722 ms/ev\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "deguio",
"comment_id": 177861587,
"datetime": 1454317118000,
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 177934890,
"datetime": 1454327597000,
"text": "Do we (tau group) have any action items for this pull request? Can it be integrated?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slava77",
"comment_id": 177991190,
"datetime": 1454336454000,
"text": "@isobelojalvo @davidlange6 \r\nanalysis signature is still pending here.\r\nThere is one more PR (13100) that depends on integration of this one.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlange6",
"comment_id": 177998093,
"datetime": 1454337672000,
"text": "Right - its been signed by other groups for only a few hours….\r\n\r\n>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isobelojalvo",
"comment_id": 178000628,
"datetime": 1454338153000,
"text": "No worries, just want to keep in mind the release closure cycle and not get 'ding-ed'. - Thanks",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *slava77*:",
"text": "@cmsbuild please test"
}
},
{
"bot": "The tests are being triggered in jenkins.",
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *slava77*:",
"text": "@cmsbuild please test"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *slava77*:",
"text": "@cmsbuild please test"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *cmsbuild* by author *slava77*:",
"text": "@cmsbuild please test"
}
}
] |
[
{
"action": "opened",
"author": "samphilipd",
"comment_id": null,
"datetime": 1491817336000,
"text": "",
"title": "Projects columns",
"type": "issue"
},
{
"action": "created",
"author": "samphilipd",
"comment_id": 292905540,
"datetime": 1491818629000,
"text": "@piotrmurach Should this also have unit specs?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "piotrmurach",
"comment_id": 292929908,
"datetime": 1491825912000,
"text": "I would add unit tests as well, they tend to catch different kind of bugs related to the parsing of arguments etc... \r\n\r\nAnother thing that I thought I will do is to add you as collaborator to my `github_api_test` repository which I use for recording cassettes. It's a safe sandbox that I think it would be good for feature tests to us this repo to help with future maintenance.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samphilipd",
"comment_id": 292941219,
"datetime": 1491829003000,
"text": "@piotrmurach unit tests added.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samphilipd",
"comment_id": 293198880,
"datetime": 1491901990000,
"text": "@piotrmurach ready for merge",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "piotrmurach",
"comment_id": 293232148,
"datetime": 1491911107000,
"text": "Will merge later today.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/11013852)\n\nCoverage decreased (-1.4%) to 95.056% when pulling **cf34604650d46dd4b8dc00c6bc6439da4f72b858 on samphilipd:projects_columns** into **3eed18eff3becd33878d97d0a414c87ec7c41ec9 on piotrmurach:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *samphilipd*:",
"text": "@piotrmurach Should this also have unit specs?"
}
},
{
"bot": "[](https://coveralls.io/builds/11015863)\n\nCoverage decreased (-1.2%) to 95.287% when pulling **50f604f0dd871076063b03ea4e80cff0ec278aba on samphilipd:projects_columns** into **3eed18eff3becd33878d97d0a414c87ec7c41ec9 on piotrmurach:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *samphilipd*:",
"text": "@piotrmurach unit tests added."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *samphilipd*:",
"text": "@piotrmurach Should this also have unit specs?"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *samphilipd*:",
"text": "@piotrmurach unit tests added."
}
}
] |
[
{
"action": "opened",
"author": "aschwaighofer",
"comment_id": null,
"datetime": 1505245707000,
"text": "And add builtins for the added runtime functions (assign-take, assign-copy).\r\n\r\nrdar://27412867\r\nSR-3376",
"title": "Use array copy runtime implementation instead of the array value witnesses",
"type": "issue"
},
{
"action": "created",
"author": "aschwaighofer",
"comment_id": 328964772,
"datetime": 1505245728000,
"text": "@swift-ci Please smoke test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aschwaighofer",
"comment_id": 328967233,
"datetime": 1505246289000,
"text": "@swift-ci Please test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aschwaighofer",
"comment_id": 328990162,
"datetime": 1505251850000,
"text": "@swift-ci Please benchmark",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rjmccall",
"comment_id": 329216231,
"datetime": 1505318714000,
"text": "That seems like a tolerable set of regressions in exchange for dropping three value witnesses. Awesome!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jckarter",
"comment_id": 329220657,
"datetime": 1505319636000,
"text": "Are we still able to specialize when the type of the array element being copied/moved is known?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eeckstein",
"comment_id": 329220800,
"datetime": 1505319672000,
"text": "great work!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Build comment file: \n--------------\n\n### Optimized (O) \n\n\n<details open>\n <summary>Regression (12)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nCalculator | 30 | 35 | +16.7% | **0.86x** \nStringEqualPointerComparison | 244 | 272 | +11.5% | **0.90x** \nArrayAppendStrings | 13647 | 15103 | +10.7% | **0.90x** \nArrayAppendLatin1 | 39814 | 43503 | +9.3% | **0.92x (?)** \nObjectiveCBridgeStubNSDateRefAccess | 312 | 338 | +8.3% | **0.92x** \nDropLastSequence | 613 | 660 | +7.7% | **0.93x** \nRangeAssignment | 346 | 372 | +7.5% | **0.93x** \nDropLastSequenceLazy | 613 | 659 | +7.5% | **0.93x** \nPrefixWhileSequence | 342 | 363 | +6.1% | **0.94x (?)** \nSetExclusiveOr_OfObjects | 7977 | 8422 | +5.6% | **0.95x** \nPrefixCountableRangeLazy | 18 | 19 | +5.6% | **0.95x** \nSetUnion_OfObjects | 6635 | 6988 | +5.3% | **0.95x** \n\n</details>\n\n<details >\n <summary>Improvement (8)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nPopFrontUnsafePointer | 9472 | 5765 | -39.1% | **1.64x** \nSim2DArray | 450 | 348 | -22.7% | **1.29x** \nSetExclusiveOr | 3153 | 2792 | -11.4% | **1.13x** \nMapReduceString | 104 | 93 | -10.6% | **1.12x** \nMapReduceLazyCollection | 13 | 12 | -7.7% | **1.08x** \nBitCount | 144 | 133 | -7.6% | **1.08x (?)** \nArrayAppendLazyMap | 989 | 925 | -6.5% | **1.07x** \nSetIsSubsetOf_OfObjects | 388 | 363 | -6.4% | **1.07x** \n\n</details>\n\n<details >\n <summary>No Changes (307)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nAngryPhonebook | 2946 | 2941 | -0.2% | 1.00x (?) \nAnyHashableWithAClass | 68860 | 67524 | -1.9% | 1.02x \nArray2D | 1946 | 1946 | +0.0% | 1.00x \nArrayAppend | 1075 | 1075 | +0.0% | 1.00x \nArrayAppendArrayOfInt | 597 | 597 | +0.0% | 1.00x \nArrayAppendAscii | 18777 | 18718 | -0.3% | 1.00x (?) \nArrayAppendFromGeneric | 597 | 597 | +0.0% | 1.00x \nArrayAppendGenericStructs | 1228 | 1225 | -0.2% | 1.00x (?) \nArrayAppendOptionals | 1227 | 1240 | +1.1% | 0.99x (?) \nArrayAppendRepeatCol | 998 | 998 | +0.0% | 1.00x \nArrayAppendReserved | 841 | 844 | +0.4% | 1.00x (?) \nArrayAppendSequence | 911 | 912 | +0.1% | 1.00x (?) \nArrayAppendToFromGeneric | 597 | 597 | +0.0% | 1.00x \nArrayAppendToGeneric | 597 | 597 | +0.0% | 1.00x \nArrayAppendUTF16 | 39295 | 39011 | -0.7% | 1.01x (?) \nArrayInClass | 61 | 61 | +0.0% | 1.00x \nArrayLiteral | 0 | 0 | +0.0% | 1.00x \nArrayOfGenericPOD | 230 | 230 | +0.0% | 1.00x \nArrayOfGenericRef | 4011 | 3987 | -0.6% | 1.01x (?) \nArrayOfPOD | 176 | 176 | +0.0% | 1.00x \nArrayOfRef | 3890 | 3912 | +0.6% | 0.99x (?) \nArrayPlusEqualArrayOfInt | 596 | 597 | +0.2% | 1.00x (?) \nArrayPlusEqualFiveElementCollection | 4780 | 4798 | +0.4% | 1.00x (?) \nArrayPlusEqualSingleElementCollection | 1072 | 1074 | +0.2% | 1.00x (?) \nArrayPlusEqualThreeElements | 1647 | 1668 | +1.3% | 0.99x (?) \nArraySubscript | 1473 | 1486 | +0.9% | 0.99x (?) \nArrayValueProp | 6 | 6 | +0.0% | 1.00x \nArrayValueProp2 | 6 | 6 | +0.0% | 1.00x \nArrayValueProp3 | 6 | 6 | +0.0% | 1.00x \nArrayValueProp4 | 6 | 6 | +0.0% | 1.00x \nByteSwap | 118 | 115 | -2.5% | 1.03x \nCStringLongAscii | 4727 | 4693 | -0.7% | 1.01x (?) \nCStringLongNonAscii | 2217 | 2173 | -2.0% | 1.02x (?) \nCStringShortAscii | 4742 | 4789 | +1.0% | 0.99x (?) \nCaptureProp | 4479 | 4616 | +3.1% | 0.97x \nCharIndexing_ascii_unicodeScalars | 13841 | 13824 | -0.1% | 1.00x (?) \nCharIndexing_ascii_unicodeScalars_Backwards | 11265 | 11249 | -0.1% | 1.00x \nCharIndexing_chinese_unicodeScalars | 10493 | 10483 | -0.1% | 1.00x (?) \nCharIndexing_chinese_unicodeScalars_Backwards | 8537 | 8530 | -0.1% | 1.00x (?) \nCharIndexing_japanese_unicodeScalars | 16555 | 16552 | -0.0% | 1.00x (?) \nCharIndexing_japanese_unicodeScalars_Backwards | 13474 | 13454 | -0.1% | 1.00x \nCharIndexing_korean_unicodeScalars | 13420 | 13415 | -0.0% | 1.00x (?) \nCharIndexing_korean_unicodeScalars_Backwards | 10928 | 10917 | -0.1% | 1.00x (?) \nCharIndexing_punctuatedJapanese_unicodeScalars | 2539 | 2531 | -0.3% | 1.00x (?) \nCharIndexing_punctuatedJapanese_unicodeScalars_Backwards | 2101 | 2081 | -1.0% | 1.01x \nCharIndexing_punctuated_unicodeScalars | 3174 | 3159 | -0.5% | 1.00x (?) \nCharIndexing_punctuated_unicodeScalars_Backwards | 2602 | 2597 | -0.2% | 1.00x \nCharIndexing_russian_unicodeScalars | 11536 | 11525 | -0.1% | 1.00x \nCharIndexing_russian_unicodeScalars_Backwards | 9396 | 9380 | -0.2% | 1.00x (?) \nCharIndexing_tweet_unicodeScalars | 27232 | 27234 | +0.0% | 1.00x (?) \nCharIndexing_tweet_unicodeScalars_Backwards | 22189 | 22166 | -0.1% | 1.00x (?) \nCharIndexing_utf16_unicodeScalars | 83796 | 83843 | +0.1% | 1.00x (?) \nCharIndexing_utf16_unicodeScalars_Backwards | 73801 | 73804 | +0.0% | 1.00x (?) \nCharIteration_ascii_unicodeScalars | 15423 | 15596 | +1.1% | 0.99x \nCharIteration_ascii_unicodeScalars_Backwards | 16574 | 16177 | -2.4% | 1.02x (?) \nCharIteration_chinese_unicodeScalars | 11687 | 11815 | +1.1% | 0.99x \nCharIteration_chinese_unicodeScalars_Backwards | 12548 | 12248 | -2.4% | 1.02x \nCharIteration_japanese_unicodeScalars | 18458 | 18687 | +1.2% | 0.99x \nCharIteration_japanese_unicodeScalars_Backwards | 19843 | 19367 | -2.4% | 1.02x \nCharIteration_korean_unicodeScalars | 14959 | 15126 | +1.1% | 0.99x \nCharIteration_korean_unicodeScalars_Backwards | 16070 | 15684 | -2.4% | 1.02x \nCharIteration_punctuatedJapanese_unicodeScalars | 2798 | 2831 | +1.2% | 0.99x \nCharIteration_punctuatedJapanese_unicodeScalars_Backwards | 2988 | 2919 | -2.3% | 1.02x \nCharIteration_punctuated_unicodeScalars | 3504 | 3546 | +1.2% | 0.99x (?) \nCharIteration_punctuated_unicodeScalars_Backwards | 3743 | 3655 | -2.4% | 1.02x \nCharIteration_russian_unicodeScalars | 12864 | 13000 | +1.1% | 0.99x \nCharIteration_russian_unicodeScalars_Backwards | 13806 | 13476 | -2.4% | 1.02x (?) \nCharIteration_tweet_unicodeScalars | 30406 | 30743 | +1.1% | 0.99x \nCharIteration_tweet_unicodeScalars_Backwards | 32767 | 31954 | -2.5% | 1.03x \nCharIteration_utf16_unicodeScalars | 81361 | 78680 | -3.3% | 1.03x \nCharIteration_utf16_unicodeScalars_Backwards | 113090 | 112863 | -0.2% | 1.00x (?) \nCharacterLiteralsLarge | 6099 | 6097 | -0.0% | 1.00x (?) \nCharacterLiteralsSmall | 403 | 403 | +0.0% | 1.00x \nChars | 426 | 427 | +0.2% | 1.00x (?) \nClassArrayGetter | 13 | 13 | +0.0% | 1.00x \nDeadArray | 186 | 186 | +0.0% | 1.00x \nDictionary | 553 | 566 | +2.4% | 0.98x \nDictionary2 | 1826 | 1834 | +0.4% | 1.00x (?) \nDictionary2OfObjects | 3311 | 3333 | +0.7% | 0.99x (?) \nDictionary3 | 457 | 456 | -0.2% | 1.00x (?) \nDictionary3OfObjects | 892 | 889 | -0.3% | 1.00x (?) \nDictionaryBridge | 2550 | 2561 | +0.4% | 1.00x (?) \nDictionaryGroup | 276 | 275 | -0.4% | 1.00x (?) \nDictionaryGroupOfObjects | 1789 | 1799 | +0.6% | 0.99x \nDictionaryLiteral | 1533 | 1528 | -0.3% | 1.00x (?) \nDictionaryOfObjects | 2331 | 2351 | +0.9% | 0.99x (?) \nDictionaryRemove | 2444 | 2498 | +2.2% | 0.98x \nDictionaryRemoveOfObjects | 23208 | 23878 | +2.9% | 0.97x \nDictionarySwap | 414 | 415 | +0.2% | 1.00x (?) \nDictionarySwapOfObjects | 7400 | 7412 | +0.2% | 1.00x (?) \nDropFirstAnyCollection | 55 | 55 | +0.0% | 1.00x \nDropFirstAnyCollectionLazy | 75440 | 76146 | +0.9% | 0.99x (?) \nDropFirstAnySeqCRangeIter | 28606 | 28169 | -1.5% | 1.02x (?) \nDropFirstAnySeqCRangeIterLazy | 28569 | 28183 | -1.4% | 1.01x (?) \nDropFirstAnySeqCntRange | 50 | 50 | +0.0% | 1.00x \nDropFirstAnySeqCntRangeLazy | 50 | 50 | +0.0% | 1.00x \nDropFirstAnySequence | 6260 | 6217 | -0.7% | 1.01x (?) \nDropFirstAnySequenceLazy | 6260 | 6239 | -0.3% | 1.00x (?) \nDropFirstArray | 30 | 30 | +0.0% | 1.00x \nDropFirstArrayLazy | 30 | 30 | +0.0% | 1.00x \nDropFirstCountableRange | 18 | 18 | +0.0% | 1.00x \nDropFirstCountableRangeLazy | 18 | 18 | +0.0% | 1.00x \nDropFirstSequence | 2093 | 2093 | +0.0% | 1.00x \nDropFirstSequenceLazy | 2118 | 2118 | +0.0% | 1.00x \nDropLastAnyCollection | 21 | 21 | +0.0% | 1.00x \nDropLastAnyCollectionLazy | 25122 | 25371 | +1.0% | 0.99x (?) \nDropLastAnySeqCRangeIter | 4727 | 4840 | +2.4% | 0.98x \nDropLastAnySeqCRangeIterLazy | 4728 | 4738 | +0.2% | 1.00x (?) \nDropLastAnySeqCntRange | 16 | 16 | +0.0% | 1.00x \nDropLastAnySeqCntRangeLazy | 16 | 16 | +0.0% | 1.00x \nDropLastAnySequence | 6762 | 6785 | +0.3% | 1.00x \nDropLastAnySequenceLazy | 6706 | 6709 | +0.0% | 1.00x (?) \nDropLastArray | 10 | 10 | +0.0% | 1.00x \nDropLastArrayLazy | 10 | 10 | +0.0% | 1.00x \nDropLastCountableRange | 6 | 6 | +0.0% | 1.00x \nDropLastCountableRangeLazy | 6 | 6 | +0.0% | 1.00x \nDropWhileAnyCollection | 68 | 68 | +0.0% | 1.00x \nDropWhileAnyCollectionLazy | 90 | 90 | +0.0% | 1.00x \nDropWhileAnySeqCRangeIter | 23398 | 22675 | -3.1% | 1.03x \nDropWhileAnySeqCRangeIterLazy | 88 | 89 | +1.1% | 0.99x \nDropWhileAnySeqCntRange | 63 | 63 | +0.0% | 1.00x \nDropWhileAnySeqCntRangeLazy | 88 | 89 | +1.1% | 0.99x \nDropWhileAnySequence | 7287 | 7275 | -0.2% | 1.00x (?) \nDropWhileAnySequenceLazy | 2007 | 2007 | +0.0% | 1.00x \nDropWhileArray | 43 | 43 | +0.0% | 1.00x \nDropWhileArrayLazy | 78 | 78 | +0.0% | 1.00x \nDropWhileCountableRange | 19 | 19 | +0.0% | 1.00x \nDropWhileCountableRangeLazy | 70 | 70 | +0.0% | 1.00x \nDropWhileSequence | 1553 | 1553 | +0.0% | 1.00x \nDropWhileSequenceLazy | 46 | 47 | +2.2% | 0.98x (?) \nEqualStringSubstring | 387 | 384 | -0.8% | 1.01x \nEqualSubstringString | 385 | 384 | -0.3% | 1.00x (?) \nEqualSubstringSubstring | 388 | 386 | -0.5% | 1.01x (?) \nEqualSubstringSubstringGenericEquatable | 386 | 386 | +0.0% | 1.00x \nErrorHandling | 2024 | 2065 | +2.0% | 0.98x (?) \nFilterEvenUsingReduce | 1284 | 1293 | +0.7% | 0.99x (?) \nFilterEvenUsingReduceInto | 145 | 146 | +0.7% | 0.99x (?) \nFrequenciesUsingReduce | 7177 | 7431 | +3.5% | 0.97x (?) \nFrequenciesUsingReduceInto | 4106 | 4114 | +0.2% | 1.00x (?) \nHanoi | 3390 | 3486 | +2.8% | 0.97x \nHashTest | 1639 | 1627 | -0.7% | 1.01x (?) \nHistogram | 285 | 290 | +1.8% | 0.98x \nIntegrate | 262 | 262 | +0.0% | 1.00x \nIterateData | 759 | 758 | -0.1% | 1.00x \nJoin | 368 | 377 | +2.4% | 0.98x (?) \nLazilyFilteredArrays | 64812 | 65747 | +1.4% | 0.99x (?) \nLazilyFilteredRange | 3755 | 3617 | -3.7% | 1.04x \nLessSubstringSubstring | 385 | 383 | -0.5% | 1.01x (?) \nLessSubstringSubstringGenericComparable | 385 | 384 | -0.3% | 1.00x (?) \nLinkedList | 7110 | 7111 | +0.0% | 1.00x (?) \nMapReduce | 360 | 360 | +0.0% | 1.00x \nMapReduceAnyCollection | 362 | 363 | +0.3% | 1.00x (?) \nMapReduceAnyCollectionShort | 2070 | 2099 | +1.4% | 0.99x (?) \nMapReduceClass | 3066 | 3082 | +0.5% | 0.99x \nMapReduceClassShort | 4524 | 4564 | +0.9% | 0.99x \nMapReduceLazyCollectionShort | 36 | 36 | +0.0% | 1.00x \nMapReduceLazySequence | 90 | 90 | +0.0% | 1.00x \nMapReduceSequence | 438 | 442 | +0.9% | 0.99x (?) \nMapReduceShort | 1957 | 1980 | +1.2% | 0.99x (?) \nMapReduceShortString | 21 | 21 | +0.0% | 1.00x \nMemset | 234 | 234 | +0.0% | 1.00x \nMonteCarloE | 10335 | 10380 | +0.4% | 1.00x \nMonteCarloPi | 43930 | 43971 | +0.1% | 1.00x \nNSDictionaryCastToSwift | 5457 | 5433 | -0.4% | 1.00x (?) \nNSError | 290 | 290 | +0.0% | 1.00x \nNSStringConversion | 351 | 356 | +1.4% | 0.99x (?) \nNopDeinit | 22892 | 22888 | -0.0% | 1.00x (?) \nObjectAllocation | 178 | 179 | +0.6% | 0.99x (?) \nObjectiveCBridgeFromNSArrayAnyObject | 22594 | 22487 | -0.5% | 1.00x (?) \nObjectiveCBridgeFromNSArrayAnyObjectForced | 3480 | 3453 | -0.8% | 1.01x (?) \nObjectiveCBridgeFromNSArrayAnyObjectToString | 39336 | 39142 | -0.5% | 1.00x (?) \nObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 33567 | 33467 | -0.3% | 1.00x (?) \nObjectiveCBridgeFromNSDictionaryAnyObject | 118737 | 118503 | -0.2% | 1.00x (?) \nObjectiveCBridgeFromNSDictionaryAnyObjectForced | 5171 | 5089 | -1.6% | 1.02x (?) \nObjectiveCBridgeFromNSDictionaryAnyObjectToString | 93507 | 90418 | -3.3% | 1.03x (?) \nObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 99730 | 100260 | +0.5% | 0.99x (?) \nObjectiveCBridgeFromNSSetAnyObject | 64646 | 64503 | -0.2% | 1.00x (?) \nObjectiveCBridgeFromNSSetAnyObjectForced | 4235 | 4266 | +0.7% | 0.99x (?) \nObjectiveCBridgeFromNSSetAnyObjectToString | 67495 | 67650 | +0.2% | 1.00x (?) \nObjectiveCBridgeFromNSSetAnyObjectToStringForced | 68572 | 70861 | +3.3% | 0.97x (?) \nObjectiveCBridgeFromNSString | 988 | 986 | -0.2% | 1.00x (?) \nObjectiveCBridgeFromNSStringForced | 1865 | 1817 | -2.6% | 1.03x \nObjectiveCBridgeStubDataAppend | 3641 | 3574 | -1.8% | 1.02x (?) \nObjectiveCBridgeStubDateAccess | 181 | 181 | +0.0% | 1.00x \nObjectiveCBridgeStubDateMutation | 272 | 272 | +0.0% | 1.00x \nObjectiveCBridgeStubFromArrayOfNSString | 25054 | 25077 | +0.1% | 1.00x (?) \nObjectiveCBridgeStubFromNSDate | 3600 | 3544 | -1.6% | 1.02x \nObjectiveCBridgeStubFromNSDateRef | 4007 | 4062 | +1.4% | 0.99x \nObjectiveCBridgeStubFromNSString | 521 | 531 | +1.9% | 0.98x (?) \nObjectiveCBridgeStubFromNSStringRef | 143 | 143 | +0.0% | 1.00x \nObjectiveCBridgeStubNSDataAppend | 2376 | 2417 | +1.7% | 0.98x (?) \nObjectiveCBridgeStubNSDateMutationRef | 12474 | 12140 | -2.7% | 1.03x (?) \nObjectiveCBridgeStubToArrayOfNSString | 28573 | 29223 | +2.3% | 0.98x (?) \nObjectiveCBridgeStubToNSDate | 13783 | 14378 | +4.3% | 0.96x (?) \nObjectiveCBridgeStubToNSDateRef | 3276 | 3254 | -0.7% | 1.01x (?) \nObjectiveCBridgeStubToNSString | 1484 | 1484 | +0.0% | 1.00x \nObjectiveCBridgeStubToNSStringRef | 109 | 108 | -0.9% | 1.01x (?) \nObjectiveCBridgeStubURLAppendPath | 220626 | 222165 | +0.7% | 0.99x (?) \nObjectiveCBridgeStubURLAppendPathRef | 220933 | 220519 | -0.2% | 1.00x (?) \nObjectiveCBridgeToNSArray | 29166 | 29586 | +1.4% | 0.99x \nObjectiveCBridgeToNSDictionary | 45038 | 45322 | +0.6% | 0.99x (?) \nObjectiveCBridgeToNSSet | 39259 | 39603 | +0.9% | 0.99x (?) \nObjectiveCBridgeToNSString | 1271 | 1272 | +0.1% | 1.00x (?) \nObserverClosure | 2281 | 2286 | +0.2% | 1.00x (?) \nObserverForwarderStruct | 1124 | 1151 | +2.4% | 0.98x (?) \nObserverPartiallyAppliedMethod | 3772 | 3784 | +0.3% | 1.00x (?) \nObserverUnappliedMethod | 2653 | 2715 | +2.3% | 0.98x (?) \nOpenClose | 3 | 3 | +0.0% | 1.00x \nPhonebook | 5976 | 5941 | -0.6% | 1.01x \nPolymorphicCalls | 17 | 17 | +0.0% | 1.00x \nPopFrontArray | 1218 | 1226 | +0.7% | 0.99x (?) \nPopFrontArrayGeneric | 1216 | 1227 | +0.9% | 0.99x \nPrefixAnyCollection | 55 | 55 | +0.0% | 1.00x \nPrefixAnyCollectionLazy | 75329 | 76101 | +1.0% | 0.99x (?) \nPrefixAnySeqCRangeIter | 22554 | 22103 | -2.0% | 1.02x \nPrefixAnySeqCRangeIterLazy | 22558 | 22101 | -2.0% | 1.02x (?) \nPrefixAnySeqCntRange | 50 | 50 | +0.0% | 1.00x \nPrefixAnySeqCntRangeLazy | 50 | 50 | +0.0% | 1.00x \nPrefixAnySequence | 5551 | 5408 | -2.6% | 1.03x (?) \nPrefixAnySequenceLazy | 5513 | 5408 | -1.9% | 1.02x (?) \nPrefixArray | 30 | 30 | +0.0% | 1.00x \nPrefixArrayLazy | 30 | 30 | +0.0% | 1.00x \nPrefixCountableRange | 18 | 18 | +0.0% | 1.00x \nPrefixSequence | 1607 | 1571 | -2.2% | 1.02x \nPrefixSequenceLazy | 1515 | 1515 | +0.0% | 1.00x \nPrefixWhileAnyCollection | 93 | 93 | +0.0% | 1.00x \nPrefixWhileAnyCollectionLazy | 66 | 66 | +0.0% | 1.00x \nPrefixWhileAnySeqCRangeIter | 12895 | 12919 | +0.2% | 1.00x (?) \nPrefixWhileAnySeqCRangeIterLazy | 66 | 66 | +0.0% | 1.00x \nPrefixWhileAnySeqCntRange | 88 | 88 | +0.0% | 1.00x \nPrefixWhileAnySeqCntRangeLazy | 66 | 66 | +0.0% | 1.00x \nPrefixWhileAnySequence | 14350 | 14549 | +1.4% | 0.99x (?) \nPrefixWhileAnySequenceLazy | 1492 | 1492 | +0.0% | 1.00x \nPrefixWhileArray | 68 | 68 | +0.0% | 1.00x \nPrefixWhileArrayLazy | 37 | 37 | +0.0% | 1.00x \nPrefixWhileCountableRange | 29 | 29 | +0.0% | 1.00x \nPrefixWhileCountableRangeLazy | 18 | 18 | +0.0% | 1.00x \nPrefixWhileSequenceLazy | 28 | 28 | +0.0% | 1.00x \nPrims | 761 | 784 | +3.0% | 0.97x (?) \nProtocolDispatch | 2728 | 2731 | +0.1% | 1.00x (?) \nProtocolDispatch2 | 161 | 160 | -0.6% | 1.01x (?) \nRC4 | 157 | 157 | +0.0% | 1.00x \nRGBHistogram | 2291 | 2244 | -2.1% | 1.02x (?) \nRGBHistogramOfObjects | 23387 | 23519 | +0.6% | 0.99x (?) \nRecursiveOwnedParameter | 2328 | 2326 | -0.1% | 1.00x (?) \nReversedArray | 46 | 45 | -2.2% | 1.02x (?) \nReversedBidirectional | 29185 | 29308 | +0.4% | 1.00x (?) \nReversedDictionary | 108 | 108 | +0.0% | 1.00x \nSetIntersect | 266 | 264 | -0.8% | 1.01x (?) \nSetIntersect_OfObjects | 1726 | 1724 | -0.1% | 1.00x (?) \nSetIsSubsetOf | 321 | 321 | +0.0% | 1.00x \nSetUnion | 2732 | 2670 | -2.3% | 1.02x (?) \nSevenBoom | 1463 | 1460 | -0.2% | 1.00x (?) \nSortLargeExistentials | 8445 | 8553 | +1.3% | 0.99x \nSortLettersInPlace | 1144 | 1146 | +0.2% | 1.00x (?) \nSortSortedStrings | 849 | 829 | -2.4% | 1.02x \nSortStrings | 1640 | 1611 | -1.8% | 1.02x (?) \nSortStringsUnicode | 7821 | 7692 | -1.6% | 1.02x \nStackPromo | 22061 | 22535 | +2.1% | 0.98x \nStaticArray | 5 | 5 | +0.0% | 1.00x \nStrComplexWalk | 1653 | 1653 | +0.0% | 1.00x \nStrToInt | 1814 | 1865 | +2.8% | 0.97x \nStringAdder | 3517 | 3526 | +0.3% | 1.00x (?) \nStringBuilder | 1021 | 1018 | -0.3% | 1.00x (?) \nStringBuilderLong | 931 | 934 | +0.3% | 1.00x (?) \nStringEdits | 113919 | 114890 | +0.9% | 0.99x \nStringFromLongWholeSubstring | 184 | 184 | +0.0% | 1.00x \nStringFromLongWholeSubstringGeneric | 23 | 23 | +0.0% | 1.00x \nStringHasPrefix | 9 | 9 | +0.0% | 1.00x \nStringHasPrefixUnicode | 15301 | 14750 | -3.6% | 1.04x \nStringHasSuffix | 9 | 9 | +0.0% | 1.00x \nStringHasSuffixUnicode | 61605 | 61506 | -0.2% | 1.00x \nStringInterpolation | 10791 | 10695 | -0.9% | 1.01x (?) \nStringMatch | 7327 | 7012 | -4.3% | 1.04x \nStringUTF16Builder | 1892 | 1909 | +0.9% | 0.99x (?) \nStringWalk | 1485 | 1501 | +1.1% | 0.99x \nStringWithCString | 66101 | 66825 | +1.1% | 0.99x \nSubstringComparable | 1520 | 1501 | -1.2% | 1.01x \nSubstringEqualString | 1367 | 1359 | -0.6% | 1.01x \nSubstringEquatable | 3544 | 3512 | -0.9% | 1.01x (?) \nSubstringFromLongString | 10 | 10 | +0.0% | 1.00x \nSubstringFromLongStringGeneric | 62 | 62 | +0.0% | 1.00x \nSuffixAnyCollection | 21 | 21 | +0.0% | 1.00x \nSuffixAnyCollectionLazy | 25153 | 25375 | +0.9% | 0.99x (?) \nSuffixAnySeqCRangeIter | 5056 | 5058 | +0.0% | 1.00x (?) \nSuffixAnySeqCRangeIterLazy | 5056 | 5057 | +0.0% | 1.00x (?) \nSuffixAnySeqCntRange | 16 | 16 | +0.0% | 1.00x \nSuffixAnySeqCntRangeLazy | 16 | 16 | +0.0% | 1.00x \nSuffixAnySequence | 6867 | 6852 | -0.2% | 1.00x \nSuffixAnySequenceLazy | 6748 | 6757 | +0.1% | 1.00x \nSuffixArray | 10 | 10 | +0.0% | 1.00x \nSuffixArrayLazy | 10 | 10 | +0.0% | 1.00x \nSuffixCountableRange | 6 | 6 | +0.0% | 1.00x \nSuffixCountableRangeLazy | 6 | 6 | +0.0% | 1.00x \nSuffixSequence | 4677 | 4693 | +0.3% | 1.00x \nSuffixSequenceLazy | 4677 | 4667 | -0.2% | 1.00x (?) \nSumUsingReduce | 97 | 97 | +0.0% | 1.00x \nSumUsingReduceInto | 97 | 97 | +0.0% | 1.00x \nSuperChars | 81402 | 80845 | -0.7% | 1.01x (?) \nTwoSum | 952 | 963 | +1.2% | 0.99x (?) \nTypeFlood | 0 | 0 | +0.0% | 1.00x \nUTF8Decode | 254 | 254 | +0.0% | 1.00x \nWalsh | 403 | 400 | -0.7% | 1.01x (?) \nXorLoop | 347 | 347 | +0.0% | 1.00x \naccessGlobal | 3 | 3 | +0.0% | 1.00x \naccessInMatSet | 18 | 18 | +0.0% | 1.00x \naccessIndependent | 2 | 2 | +0.0% | 1.00x \n\n</details>\n\n### Unoptimized (Onone) \n\n\n<details open>\n <summary>Regression (4)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nArrayAppendStrings | 13588 | 15227 | +12.1% | **0.89x** \nDropWhileArrayLazy | 17537 | 19070 | +8.7% | **0.92x** \nTypeFlood | 152 | 163 | +7.2% | **0.93x (?)** \nDropWhileAnySeqCRangeIterLazy | 28764 | 30498 | +6.0% | **0.94x** \n\n</details>\n\n<details >\n <summary>Improvement (12)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nPopFrontUnsafePointer | 97092 | 7225 | -92.6% | **13.44x** \nObjectiveCBridgeStubFromNSDate | 4164 | 3827 | -8.1% | **1.09x** \nArrayAppend | 4237 | 3950 | -6.8% | **1.07x** \nObjectiveCBridgeFromNSDictionaryAnyObjectForced | 7767 | 7302 | -6.0% | **1.06x (?)** \nStringWalk | 12427 | 11722 | -5.7% | **1.06x** \nCharIndexing_japanese_unicodeScalars | 596655 | 566043 | -5.1% | **1.05x** \nCharIndexing_tweet_unicodeScalars | 981981 | 932090 | -5.1% | **1.05x** \nCharIndexing_russian_unicodeScalars | 412976 | 392514 | -5.0% | **1.05x** \nObjectiveCBridgeStubDateMutation | 516 | 491 | -4.8% | **1.05x** \nCharIndexing_korean_unicodeScalars | 483286 | 459947 | -4.8% | **1.05x** \nCharIndexing_russian_unicodeScalars_Backwards | 450936 | 429281 | -4.8% | **1.05x (?)** \nStringHasSuffix | 1899 | 1808 | -4.8% | **1.05x** \n\n</details>\n\n<details >\n <summary>No Changes (311)</summary>\n \nTEST | OLD | NEW | DELTA | SPEEDUP \n--- | --- | --- | --- | --- \nAngryPhonebook | 5055 | 5038 | -0.3% | 1.00x (?) \nAnyHashableWithAClass | 86692 | 84992 | -2.0% | 1.02x \nArray2D | 639593 | 634460 | -0.8% | 1.01x \nArrayAppendArrayOfInt | 656 | 658 | +0.3% | 1.00x \nArrayAppendAscii | 53276 | 53457 | +0.3% | 1.00x \nArrayAppendFromGeneric | 658 | 660 | +0.3% | 1.00x (?) \nArrayAppendGenericStructs | 1304 | 1297 | -0.5% | 1.01x (?) \nArrayAppendLatin1 | 81648 | 81829 | +0.2% | 1.00x (?) \nArrayAppendLazyMap | 230025 | 228221 | -0.8% | 1.01x (?) \nArrayAppendOptionals | 1295 | 1336 | +3.2% | 0.97x \nArrayAppendRepeatCol | 234811 | 236359 | +0.7% | 0.99x (?) \nArrayAppendReserved | 3903 | 4014 | +2.8% | 0.97x \nArrayAppendSequence | 79047 | 79114 | +0.1% | 1.00x (?) \nArrayAppendToFromGeneric | 658 | 659 | +0.2% | 1.00x (?) \nArrayAppendToGeneric | 660 | 660 | +0.0% | 1.00x \nArrayAppendUTF16 | 78198 | 78871 | +0.9% | 0.99x \nArrayInClass | 6698 | 6746 | +0.7% | 0.99x (?) \nArrayLiteral | 1749 | 1743 | -0.3% | 1.00x \nArrayOfGenericPOD | 1266 | 1211 | -4.3% | 1.05x \nArrayOfGenericRef | 10113 | 10004 | -1.1% | 1.01x \nArrayOfPOD | 714 | 712 | -0.3% | 1.00x (?) \nArrayOfRef | 9246 | 9203 | -0.5% | 1.00x (?) \nArrayPlusEqualArrayOfInt | 657 | 657 | +0.0% | 1.00x \nArrayPlusEqualFiveElementCollection | 311721 | 312699 | +0.3% | 1.00x (?) \nArrayPlusEqualSingleElementCollection | 303323 | 310268 | +2.3% | 0.98x \nArrayPlusEqualThreeElements | 11245 | 11229 | -0.1% | 1.00x (?) \nArraySubscript | 4428 | 4434 | +0.1% | 1.00x (?) \nArrayValueProp | 3564 | 3576 | +0.3% | 1.00x \nArrayValueProp2 | 18922 | 18929 | +0.0% | 1.00x (?) \nArrayValueProp3 | 4026 | 3996 | -0.7% | 1.01x (?) \nArrayValueProp4 | 3960 | 3992 | +0.8% | 0.99x (?) \nBitCount | 1696 | 1750 | +3.2% | 0.97x \nByteSwap | 4037 | 4008 | -0.7% | 1.01x (?) \nCStringLongAscii | 4755 | 4756 | +0.0% | 1.00x (?) \nCStringLongNonAscii | 2404 | 2440 | +1.5% | 0.99x \nCStringShortAscii | 8809 | 8779 | -0.3% | 1.00x (?) \nCalculator | 1164 | 1187 | +2.0% | 0.98x \nCaptureProp | 124234 | 126851 | +2.1% | 0.98x \nCharIndexing_ascii_unicodeScalars | 494979 | 472013 | -4.6% | 1.05x \nCharIndexing_ascii_unicodeScalars_Backwards | 541684 | 528746 | -2.4% | 1.02x \nCharIndexing_chinese_unicodeScalars | 372325 | 358051 | -3.8% | 1.04x \nCharIndexing_chinese_unicodeScalars_Backwards | 399727 | 391019 | -2.2% | 1.02x (?) \nCharIndexing_japanese_unicodeScalars_Backwards | 637980 | 621880 | -2.5% | 1.03x (?) \nCharIndexing_korean_unicodeScalars_Backwards | 525037 | 512755 | -2.3% | 1.02x (?) \nCharIndexing_punctuatedJapanese_unicodeScalars | 85866 | 82545 | -3.9% | 1.04x \nCharIndexing_punctuatedJapanese_unicodeScalars_Backwards | 93635 | 91706 | -2.1% | 1.02x (?) \nCharIndexing_punctuated_unicodeScalars | 108261 | 104362 | -3.6% | 1.04x \nCharIndexing_punctuated_unicodeScalars_Backwards | 119628 | 116551 | -2.6% | 1.03x (?) \nCharIndexing_tweet_unicodeScalars_Backwards | 1050387 | 1024962 | -2.4% | 1.02x (?) \nCharIndexing_utf16_unicodeScalars | 552523 | 528006 | -4.4% | 1.05x \nCharIndexing_utf16_unicodeScalars_Backwards | 588863 | 582938 | -1.0% | 1.01x \nCharIteration_ascii_unicodeScalars | 186032 | 187219 | +0.6% | 0.99x \nCharIteration_ascii_unicodeScalars_Backwards | 325988 | 326175 | +0.1% | 1.00x (?) \nCharIteration_chinese_unicodeScalars | 140786 | 141873 | +0.8% | 0.99x \nCharIteration_chinese_unicodeScalars_Backwards | 245644 | 246269 | +0.3% | 1.00x (?) \nCharIteration_japanese_unicodeScalars | 223070 | 224777 | +0.8% | 0.99x \nCharIteration_japanese_unicodeScalars_Backwards | 390615 | 390868 | +0.1% | 1.00x (?) \nCharIteration_korean_unicodeScalars | 180647 | 182508 | +1.0% | 0.99x \nCharIteration_korean_unicodeScalars_Backwards | 315885 | 316616 | +0.2% | 1.00x (?) \nCharIteration_punctuatedJapanese_unicodeScalars | 33095 | 33372 | +0.8% | 0.99x \nCharIteration_punctuatedJapanese_unicodeScalars_Backwards | 57036 | 56837 | -0.3% | 1.00x (?) \nCharIteration_punctuated_unicodeScalars | 41678 | 41930 | +0.6% | 0.99x \nCharIteration_punctuated_unicodeScalars_Backwards | 71842 | 71675 | -0.2% | 1.00x (?) \nCharIteration_russian_unicodeScalars | 155315 | 156571 | +0.8% | 0.99x \nCharIteration_russian_unicodeScalars_Backwards | 271432 | 271282 | -0.1% | 1.00x (?) \nCharIteration_tweet_unicodeScalars | 368343 | 371677 | +0.9% | 0.99x \nCharIteration_tweet_unicodeScalars_Backwards | 653024 | 645999 | -1.1% | 1.01x (?) \nCharIteration_utf16_unicodeScalars | 207741 | 208597 | +0.4% | 1.00x \nCharIteration_utf16_unicodeScalars_Backwards | 407945 | 407469 | -0.1% | 1.00x (?) \nCharacterLiteralsLarge | 6373 | 6436 | +1.0% | 0.99x (?) \nCharacterLiteralsSmall | 631 | 646 | +2.4% | 0.98x \nChars | 50715 | 50639 | -0.1% | 1.00x (?) \nClassArrayGetter | 1026 | 1025 | -0.1% | 1.00x \nDeadArray | 113736 | 114410 | +0.6% | 0.99x (?) \nDictionary | 3034 | 3030 | -0.1% | 1.00x (?) \nDictionary2 | 3461 | 3453 | -0.2% | 1.00x (?) \nDictionary2OfObjects | 6068 | 6041 | -0.4% | 1.00x (?) \nDictionary3 | 1298 | 1303 | +0.4% | 1.00x (?) \nDictionary3OfObjects | 2339 | 2328 | -0.5% | 1.00x (?) \nDictionaryBridge | 2643 | 2676 | +1.2% | 0.99x (?) \nDictionaryGroup | 5398 | 5462 | +1.2% | 0.99x \nDictionaryGroupOfObjects | 8301 | 8278 | -0.3% | 1.00x (?) \nDictionaryLiteral | 8719 | 8735 | +0.2% | 1.00x (?) \nDictionaryOfObjects | 6538 | 6536 | -0.0% | 1.00x (?) \nDictionaryRemove | 21410 | 21535 | +0.6% | 0.99x \nDictionaryRemoveOfObjects | 59539 | 59727 | +0.3% | 1.00x (?) \nDictionarySwap | 5336 | 5362 | +0.5% | 1.00x (?) \nDictionarySwapOfObjects | 23425 | 23303 | -0.5% | 1.01x (?) \nDropFirstAnyCollection | 20316 | 20403 | +0.4% | 1.00x \nDropFirstAnyCollectionLazy | 142223 | 144388 | +1.5% | 0.99x \nDropFirstAnySeqCRangeIter | 31115 | 31273 | +0.5% | 0.99x \nDropFirstAnySeqCRangeIterLazy | 30646 | 31297 | +2.1% | 0.98x \nDropFirstAnySeqCntRange | 20497 | 20414 | -0.4% | 1.00x (?) \nDropFirstAnySeqCntRangeLazy | 20352 | 20548 | +1.0% | 0.99x \nDropFirstAnySequence | 15839 | 15966 | +0.8% | 0.99x (?) \nDropFirstAnySequenceLazy | 15890 | 15873 | -0.1% | 1.00x \nDropFirstArray | 6325 | 6524 | +3.1% | 0.97x \nDropFirstArrayLazy | 45890 | 46181 | +0.6% | 0.99x (?) \nDropFirstCountableRange | 340 | 340 | +0.0% | 1.00x \nDropFirstCountableRangeLazy | 39712 | 40659 | +2.4% | 0.98x \nDropFirstSequence | 14747 | 14722 | -0.2% | 1.00x (?) \nDropFirstSequenceLazy | 14759 | 14799 | +0.3% | 1.00x \nDropLastAnyCollection | 6766 | 6827 | +0.9% | 0.99x \nDropLastAnyCollectionLazy | 47276 | 47151 | -0.3% | 1.00x (?) \nDropLastAnySeqCRangeIter | 47344 | 48079 | +1.6% | 0.98x \nDropLastAnySeqCRangeIterLazy | 47511 | 47670 | +0.3% | 1.00x (?) \nDropLastAnySeqCntRange | 6781 | 6815 | +0.5% | 1.00x \nDropLastAnySeqCntRangeLazy | 6740 | 6841 | +1.5% | 0.99x (?) \nDropLastAnySequence | 33871 | 34214 | +1.0% | 0.99x \nDropLastAnySequenceLazy | 33845 | 34246 | +1.2% | 0.99x \nDropLastArray | 2096 | 2169 | +3.5% | 0.97x \nDropLastArrayLazy | 15304 | 15415 | +0.7% | 0.99x (?) \nDropLastCountableRange | 118 | 118 | +0.0% | 1.00x \nDropLastCountableRangeLazy | 13479 | 13579 | +0.7% | 0.99x (?) \nDropLastSequence | 33401 | 33720 | +1.0% | 0.99x \nDropLastSequenceLazy | 34047 | 34164 | +0.3% | 1.00x \nDropWhileAnyCollection | 26460 | 26828 | +1.4% | 0.99x \nDropWhileAnyCollectionLazy | 28945 | 30288 | +4.6% | 0.96x \nDropWhileAnySeqCRangeIter | 32854 | 33665 | +2.5% | 0.98x \nDropWhileAnySeqCntRange | 26560 | 26864 | +1.1% | 0.99x \nDropWhileAnySeqCntRangeLazy | 28977 | 30355 | +4.8% | 0.95x \nDropWhileAnySequence | 18852 | 18795 | -0.3% | 1.00x (?) \nDropWhileAnySequenceLazy | 15193 | 15175 | -0.1% | 1.00x \nDropWhileArray | 10054 | 10326 | +2.7% | 0.97x \nDropWhileCountableRange | 6581 | 6629 | +0.7% | 0.99x \nDropWhileCountableRangeLazy | 27643 | 28365 | +2.6% | 0.97x \nDropWhileSequence | 17558 | 17630 | +0.4% | 1.00x (?) \nDropWhileSequenceLazy | 14543 | 14314 | -1.6% | 1.02x \nEqualStringSubstring | 678 | 676 | -0.3% | 1.00x (?) \nEqualSubstringString | 674 | 670 | -0.6% | 1.01x (?) \nEqualSubstringSubstring | 795 | 795 | +0.0% | 1.00x \nEqualSubstringSubstringGenericEquatable | 423 | 420 | -0.7% | 1.01x \nErrorHandling | 6871 | 6955 | +1.2% | 0.99x (?) \nFilterEvenUsingReduce | 4308 | 4319 | +0.3% | 1.00x (?) \nFilterEvenUsingReduceInto | 2510 | 2509 | -0.0% | 1.00x (?) \nFrequenciesUsingReduce | 16006 | 16410 | +2.5% | 0.98x \nFrequenciesUsingReduceInto | 9273 | 9334 | +0.7% | 0.99x (?) \nHanoi | 19447 | 19269 | -0.9% | 1.01x \nHashTest | 17132 | 17330 | +1.2% | 0.99x (?) \nHistogram | 9422 | 9230 | -2.0% | 1.02x (?) \nIntegrate | 675 | 677 | +0.3% | 1.00x \nIterateData | 13497 | 13482 | -0.1% | 1.00x (?) \nJoin | 1516 | 1501 | -1.0% | 1.01x \nLazilyFilteredArrays | 1752190 | 1758750 | +0.4% | 1.00x \nLazilyFilteredRange | 712272 | 720446 | +1.1% | 0.99x \nLessSubstringSubstring | 790 | 792 | +0.3% | 1.00x \nLessSubstringSubstringGenericComparable | 438 | 436 | -0.5% | 1.00x \nLinkedList | 40301 | 40349 | +0.1% | 1.00x \nMapReduce | 39337 | 38883 | -1.2% | 1.01x \nMapReduceAnyCollection | 39293 | 38858 | -1.1% | 1.01x \nMapReduceAnyCollectionShort | 51879 | 51766 | -0.2% | 1.00x (?) \nMapReduceClass | 44954 | 44184 | -1.7% | 1.02x \nMapReduceClassShort | 55910 | 55635 | -0.5% | 1.00x (?) \nMapReduceLazyCollection | 37383 | 36874 | -1.4% | 1.01x \nMapReduceLazyCollectionShort | 46449 | 46125 | -0.7% | 1.01x (?) \nMapReduceLazySequence | 30394 | 30891 | +1.6% | 0.98x \nMapReduceSequence | 46295 | 46201 | -0.2% | 1.00x (?) \nMapReduceShort | 51446 | 51285 | -0.3% | 1.00x (?) \nMapReduceShortString | 296 | 294 | -0.7% | 1.01x (?) \nMapReduceString | 2779 | 2728 | -1.8% | 1.02x (?) \nMemset | 44663 | 44664 | +0.0% | 1.00x (?) \nMonteCarloE | 140945 | 140871 | -0.1% | 1.00x (?) \nMonteCarloPi | 52649 | 52359 | -0.6% | 1.01x \nNSDictionaryCastToSwift | 6697 | 6689 | -0.1% | 1.00x (?) \nNSError | 703 | 703 | +0.0% | 1.00x \nNSStringConversion | 403 | 408 | +1.2% | 0.99x (?) \nNopDeinit | 168279 | 171479 | +1.9% | 0.98x (?) \nObjectAllocation | 1475 | 1478 | +0.2% | 1.00x (?) \nObjectiveCBridgeFromNSArrayAnyObject | 25157 | 24815 | -1.4% | 1.01x (?) \nObjectiveCBridgeFromNSArrayAnyObjectForced | 6829 | 6754 | -1.1% | 1.01x (?) \nObjectiveCBridgeFromNSArrayAnyObjectToString | 40325 | 40965 | +1.6% | 0.98x (?) \nObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 35270 | 34394 | -2.5% | 1.03x (?) \nObjectiveCBridgeFromNSDictionaryAnyObject | 122650 | 122895 | +0.2% | 1.00x (?) \nObjectiveCBridgeFromNSDictionaryAnyObjectToString | 97687 | 95593 | -2.1% | 1.02x (?) \nObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 102904 | 105803 | +2.8% | 0.97x (?) \nObjectiveCBridgeFromNSSetAnyObject | 68839 | 68408 | -0.6% | 1.01x (?) \nObjectiveCBridgeFromNSSetAnyObjectForced | 7463 | 7450 | -0.2% | 1.00x (?) \nObjectiveCBridgeFromNSSetAnyObjectToString | 72924 | 72836 | -0.1% | 1.00x (?) \nObjectiveCBridgeFromNSSetAnyObjectToStringForced | 73322 | 75092 | +2.4% | 0.98x (?) \nObjectiveCBridgeFromNSString | 3994 | 3998 | +0.1% | 1.00x (?) \nObjectiveCBridgeFromNSStringForced | 2234 | 2192 | -1.9% | 1.02x (?) \nObjectiveCBridgeStubDataAppend | 4066 | 3922 | -3.5% | 1.04x (?) \nObjectiveCBridgeStubDateAccess | 1034 | 1034 | +0.0% | 1.00x \nObjectiveCBridgeStubFromArrayOfNSString | 25702 | 25282 | -1.6% | 1.02x (?) \nObjectiveCBridgeStubFromNSDateRef | 4552 | 4342 | -4.6% | 1.05x \nObjectiveCBridgeStubFromNSString | 558 | 568 | +1.8% | 0.98x (?) \nObjectiveCBridgeStubFromNSStringRef | 186 | 182 | -2.2% | 1.02x (?) \nObjectiveCBridgeStubNSDataAppend | 2860 | 2736 | -4.3% | 1.05x \nObjectiveCBridgeStubNSDateMutationRef | 16305 | 15780 | -3.2% | 1.03x (?) \nObjectiveCBridgeStubNSDateRefAccess | 1236 | 1216 | -1.6% | 1.02x \nObjectiveCBridgeStubToArrayOfNSString | 28917 | 29793 | +3.0% | 0.97x (?) \nObjectiveCBridgeStubToNSDate | 15521 | 15534 | +0.1% | 1.00x (?) \nObjectiveCBridgeStubToNSDateRef | 3376 | 3360 | -0.5% | 1.00x (?) \nObjectiveCBridgeStubToNSString | 1552 | 1546 | -0.4% | 1.00x (?) \nObjectiveCBridgeStubToNSStringRef | 155 | 155 | +0.0% | 1.00x \nObjectiveCBridgeStubURLAppendPath | 223412 | 224748 | +0.6% | 0.99x (?) \nObjectiveCBridgeStubURLAppendPathRef | 226189 | 226158 | -0.0% | 1.00x (?) \nObjectiveCBridgeToNSArray | 29378 | 29697 | +1.1% | 0.99x (?) \nObjectiveCBridgeToNSDictionary | 45587 | 45782 | +0.4% | 1.00x (?) \nObjectiveCBridgeToNSSet | 39882 | 39627 | -0.6% | 1.01x (?) \nObjectiveCBridgeToNSString | 1312 | 1306 | -0.5% | 1.00x \nObserverClosure | 7038 | 7041 | +0.0% | 1.00x (?) \nObserverForwarderStruct | 5256 | 5234 | -0.4% | 1.00x (?) \nObserverPartiallyAppliedMethod | 8480 | 8514 | +0.4% | 1.00x (?) \nObserverUnappliedMethod | 8846 | 8911 | +0.7% | 0.99x \nOpenClose | 398 | 393 | -1.3% | 1.01x \nPhonebook | 22154 | 22429 | +1.2% | 0.99x \nPolymorphicCalls | 5283 | 5132 | -2.9% | 1.03x \nPopFrontArray | 10358 | 10464 | +1.0% | 0.99x (?) \nPopFrontArrayGeneric | 9191 | 9182 | -0.1% | 1.00x (?) \nPrefixAnyCollection | 20296 | 20399 | +0.5% | 0.99x \nPrefixAnyCollectionLazy | 141060 | 141764 | +0.5% | 1.00x (?) \nPrefixAnySeqCRangeIter | 24721 | 24936 | +0.9% | 0.99x (?) \nPrefixAnySeqCRangeIterLazy | 24532 | 24730 | +0.8% | 0.99x \nPrefixAnySeqCntRange | 20488 | 20357 | -0.6% | 1.01x (?) \nPrefixAnySeqCntRangeLazy | 20348 | 20588 | +1.2% | 0.99x \nPrefixAnySequence | 12959 | 13100 | +1.1% | 0.99x (?) \nPrefixAnySequenceLazy | 12952 | 13030 | +0.6% | 0.99x \nPrefixArray | 6307 | 6469 | +2.6% | 0.97x \nPrefixArrayLazy | 45674 | 45832 | +0.3% | 1.00x (?) \nPrefixCountableRange | 337 | 340 | +0.9% | 0.99x \nPrefixCountableRangeLazy | 39654 | 40656 | +2.5% | 0.98x \nPrefixSequence | 11811 | 11892 | +0.7% | 0.99x (?) \nPrefixSequenceLazy | 11840 | 11860 | +0.2% | 1.00x (?) \nPrefixWhileAnyCollection | 38779 | 39523 | +1.9% | 0.98x (?) \nPrefixWhileAnyCollectionLazy | 23809 | 24201 | +1.6% | 0.98x (?) \nPrefixWhileAnySeqCRangeIter | 42992 | 43816 | +1.9% | 0.98x \nPrefixWhileAnySeqCRangeIterLazy | 23618 | 24470 | +3.6% | 0.97x \nPrefixWhileAnySeqCntRange | 39009 | 39605 | +1.5% | 0.98x (?) \nPrefixWhileAnySeqCntRangeLazy | 23663 | 24052 | +1.6% | 0.98x (?) \nPrefixWhileAnySequence | 32993 | 33500 | +1.5% | 0.98x (?) \nPrefixWhileAnySequenceLazy | 13645 | 13877 | +1.7% | 0.98x \nPrefixWhileArray | 17451 | 17880 | +2.5% | 0.98x \nPrefixWhileArrayLazy | 15373 | 16051 | +4.4% | 0.96x \nPrefixWhileCountableRange | 18974 | 19239 | +1.4% | 0.99x \nPrefixWhileCountableRangeLazy | 22948 | 23274 | +1.4% | 0.99x \nPrefixWhileSequence | 31790 | 32577 | +2.5% | 0.98x \nPrefixWhileSequenceLazy | 12495 | 12420 | -0.6% | 1.01x \nPrims | 10689 | 10623 | -0.6% | 1.01x (?) \nProtocolDispatch | 6946 | 7166 | +3.2% | 0.97x \nProtocolDispatch2 | 490 | 492 | +0.4% | 1.00x \nRC4 | 19040 | 18984 | -0.3% | 1.00x (?) \nRGBHistogram | 35459 | 34534 | -2.6% | 1.03x \nRGBHistogramOfObjects | 108609 | 108682 | +0.1% | 1.00x (?) \nRangeAssignment | 5749 | 5797 | +0.8% | 0.99x (?) \nRecursiveOwnedParameter | 11219 | 11269 | +0.4% | 1.00x \nReversedArray | 44520 | 44823 | +0.7% | 0.99x \nReversedBidirectional | 75589 | 76277 | +0.9% | 0.99x (?) \nReversedDictionary | 29642 | 29546 | -0.3% | 1.00x \nSetExclusiveOr | 23034 | 23018 | -0.1% | 1.00x (?) \nSetExclusiveOr_OfObjects | 48147 | 48539 | +0.8% | 0.99x \nSetIntersect | 12542 | 12525 | -0.1% | 1.00x (?) \nSetIntersect_OfObjects | 12486 | 12507 | +0.2% | 1.00x (?) \nSetIsSubsetOf | 1871 | 1861 | -0.5% | 1.01x \nSetIsSubsetOf_OfObjects | 1538 | 1557 | +1.2% | 0.99x \nSetUnion | 11861 | 11958 | +0.8% | 0.99x \nSetUnion_OfObjects | 33638 | 34011 | +1.1% | 0.99x \nSevenBoom | 1610 | 1615 | +0.3% | 1.00x (?) \nSim2DArray | 44266 | 44293 | +0.1% | 1.00x \nSortLargeExistentials | 18053 | 17715 | -1.9% | 1.02x \nSortLettersInPlace | 3102 | 3088 | -0.5% | 1.00x (?) \nSortSortedStrings | 1436 | 1458 | +1.5% | 0.98x \nSortStrings | 2493 | 2502 | +0.4% | 1.00x (?) \nSortStringsUnicode | 8938 | 8942 | +0.0% | 1.00x (?) \nStackPromo | 103402 | 102645 | -0.7% | 1.01x (?) \nStaticArray | 4603 | 4673 | +1.5% | 0.99x \nStrComplexWalk | 6980 | 6993 | +0.2% | 1.00x (?) \nStrToInt | 128065 | 126564 | -1.2% | 1.01x \nStringAdder | 3798 | 3773 | -0.7% | 1.01x (?) \nStringBuilder | 7147 | 7119 | -0.4% | 1.00x (?) \nStringBuilderLong | 1079 | 1088 | +0.8% | 0.99x (?) \nStringEdits | 386553 | 383800 | -0.7% | 1.01x (?) \nStringEqualPointerComparison | 2569 | 2578 | +0.4% | 1.00x (?) \nStringFromLongWholeSubstring | 206 | 206 | +0.0% | 1.00x \nStringFromLongWholeSubstringGeneric | 218 | 220 | +0.9% | 0.99x \nStringHasPrefix | 1737 | 1694 | -2.5% | 1.03x \nStringHasPrefixUnicode | 16752 | 16758 | +0.0% | 1.00x (?) \nStringHasSuffixUnicode | 63899 | 63186 | -1.1% | 1.01x \nStringInterpolation | 13792 | 13761 | -0.2% | 1.00x (?) \nStringMatch | 35448 | 34566 | -2.5% | 1.03x \nStringUTF16Builder | 7971 | 8015 | +0.6% | 0.99x (?) \nStringWithCString | 60304 | 60265 | -0.1% | 1.00x (?) \nSubstringComparable | 4258 | 4272 | +0.3% | 1.00x (?) \nSubstringEqualString | 6576 | 6567 | -0.1% | 1.00x (?) \nSubstringEquatable | 8525 | 8442 | -1.0% | 1.01x (?) \nSubstringFromLongString | 16 | 16 | +0.0% | 1.00x \nSubstringFromLongStringGeneric | 117 | 116 | -0.9% | 1.01x \nSuffixAnyCollection | 6785 | 6827 | +0.6% | 0.99x \nSuffixAnyCollectionLazy | 47886 | 48111 | +0.5% | 1.00x (?) \nSuffixAnySeqCRangeIter | 44517 | 45481 | +2.2% | 0.98x \nSuffixAnySeqCRangeIterLazy | 44743 | 44578 | -0.4% | 1.00x \nSuffixAnySeqCntRange | 6788 | 6798 | +0.1% | 1.00x (?) \nSuffixAnySeqCntRangeLazy | 6747 | 6833 | +1.3% | 0.99x (?) \nSuffixAnySequence | 31275 | 31177 | -0.3% | 1.00x (?) \nSuffixAnySequenceLazy | 31588 | 31604 | +0.1% | 1.00x (?) \nSuffixArray | 2111 | 2192 | +3.8% | 0.96x \nSuffixArrayLazy | 15238 | 15496 | +1.7% | 0.98x \nSuffixCountableRange | 118 | 119 | +0.8% | 0.99x \nSuffixCountableRangeLazy | 13440 | 13582 | +1.1% | 0.99x (?) \nSuffixSequence | 31016 | 30974 | -0.1% | 1.00x (?) \nSuffixSequenceLazy | 30853 | 30803 | -0.2% | 1.00x (?) \nSumUsingReduce | 231937 | 232294 | +0.2% | 1.00x (?) \nSumUsingReduceInto | 227094 | 226778 | -0.1% | 1.00x \nSuperChars | 192525 | 192053 | -0.2% | 1.00x (?) \nTwoSum | 4285 | 4301 | +0.4% | 1.00x (?) \nUTF8Decode | 38835 | 38653 | -0.5% | 1.00x (?) \nWalsh | 12034 | 12028 | -0.0% | 1.00x (?) \nXorLoop | 23764 | 23780 | +0.1% | 1.00x \naccessGlobal | 177 | 180 | +1.7% | 0.98x \naccessInMatSet | 326 | 328 | +0.6% | 0.99x \naccessIndependent | 124 | 121 | -2.4% | 1.02x \n\n</details>\n\n<details>\n <summary><strong>Hardware Overview</strong></summary>\n\n Model Name: Mac mini\n Model Identifier: Macmini7,1\n Processor Name: Intel Core i5\n Processor Speed: 2.8 GHz\n Number of Processors: 1\n Total Number of Cores: 2\n L2 Cache (per Core): 256 KB\n L3 Cache: 3 MB\n Memory: 16 GB\n</details>\n\n--------------",
"previous": {
"meta": "This message directly preceded comment from bot *swift-ci* by author *aschwaighofer*:",
"text": "@swift-ci Please benchmark"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *swift-ci* by author *aschwaighofer*:",
"text": "@swift-ci Please benchmark"
}
}
] |
[
{
"action": "opened",
"author": "dalanlan",
"comment_id": null,
"datetime": 1447833965000,
"text": "Fix #17205",
"title": "[ubuntu] fix etcd flag ",
"type": "issue"
},
{
"action": "created",
"author": "dalanlan",
"comment_id": 158296875,
"datetime": 1448002192000,
"text": "ping @davidopp",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidopp",
"comment_id": 158307672,
"datetime": 1448004131000,
"text": "@resouer @yichengq @xiang90",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "resouer",
"comment_id": 158331459,
"datetime": 1448010491000,
"text": "I did not see error in kube-in-docker, but as #17422 was in. I'm ok with this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dalanlan",
"comment_id": 158628241,
"datetime": 1448103914000,
"text": "Based on @xiang90 's comment, i think it would be fine to set `advertise-client-urls` \r\n- 1. http://${master_ip}:4001\r\n- 2. http://127.0.0.1:4001, given that there is single etcd, and `--no-sync` for `etcdctl` \r\nI'm comfortable with either and adopt option 1 for now.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "resouer",
"comment_id": 158631989,
"datetime": 1448106361000,
"text": "lgtm cc @davidopp",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidopp",
"comment_id": 158688467,
"datetime": 1448145862000,
"text": "LGTM",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Labelling this PR as size/S",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *resouer*:",
"text": "I did not see error in kube-in-docker, but as #17422 was in. I'm ok with this."
}
},
{
"bot": "Automatic merge from submit-queue",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *davidopp*:",
"text": "LGTM"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *resouer*:",
"text": "I did not see error in kube-in-docker, but as #17422 was in. I'm ok with this."
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *davidopp*:",
"text": "LGTM"
}
}
] |
[
{
"action": "opened",
"author": "nikhita",
"comment_id": null,
"datetime": 1520944846000,
"text": "Fixes kubernetes/apiextensions-apiserver#28\r\n\r\n`go-openapi/validate` had a bug https://github.com/go-openapi/validate/issues/13 where it did not properly validate enums for integers. This hits users of CRD validation. This was fixed in https://github.com/go-openapi/validate/pull/14.\r\n\r\nI had bumped `go-openapi/validate` for subresources in https://github.com/kubernetes/kubernetes/pull/55168 in this commit: https://github.com/kubernetes/kubernetes/commit/66a4e5122a2d810ada2f23af803d1e44256dd260 (to get the fix https://github.com/go-openapi/validate/pull/36 in). This bump picked up the fix for enum validation, so this bug does not affect 1.10 users.\r\n\r\nThis PR cherry picks the above commit to the `release-1.9` branch to fix the bug for 1.9 users.\r\n\r\nThis is not an automated cherry pick. My understanding is that automated cherry picks are for cherry-picking complete PRs and this cherry picks _a commit_ in a PR https://github.com/kubernetes/kubernetes/pull/55168. Adding an explicit hold to make sure this is ok.\r\n/hold\r\n\r\n\r\n**Release note**:\r\n<!-- Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n\r\n/cc mbohlool sttts liggitt \r\n/assign mbohlool",
"title": "[1.9] bump(go-openapi/validate): d509235108fcf6ab4913d2dcb3a2260c0db2108e",
"type": "issue"
},
{
"action": "created",
"author": "nikhita",
"comment_id": 372652799,
"datetime": 1520945142000,
"text": "/kind bug\r\n/area custom-resources\r\n/sig api-machinery",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbohlool",
"comment_id": 372746601,
"datetime": 1520961522000,
"text": "@nikhita it is ok to sometimes do manual cherrypicks. Please just add justification on why this is needed as a cherrypick and what is the user impact.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 372808596,
"datetime": 1520973180000,
"text": "@nikhita staging godeps need to be updated here too",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jennybuckley",
"comment_id": 373509454,
"datetime": 1521145129000,
"text": "/cc @jpbetz",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jpbetz",
"comment_id": 376248879,
"datetime": 1522085774000,
"text": "Backporting this as a single commit looks fine to me. Removing hold.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 376278115,
"datetime": 1522091352000,
"text": "@nikhita This still need attention (staging godeps need to be updated)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nikhita",
"comment_id": 376278950,
"datetime": 1522091531000,
"text": "There is a still a discussion on how we should proceed with it. https://github.com/kubernetes/apiextensions-apiserver/issues/28#issuecomment-372751580.\r\n\r\nUntil that is agreed upon, I think we should not merge this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 376291606,
"datetime": 1522094200000,
"text": "@nikhita Understood.\r\n/hold",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbohlool",
"comment_id": 388125473,
"datetime": 1525973467000,
"text": "any update on this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbohlool",
"comment_id": 390816362,
"datetime": 1526945853000,
"text": "Closing this in favor of #63604",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@nikhita: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-kops-aws | 65b2ec140712a9d6bf28311dea3c8ff54201451b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/61106/pull-kubernetes-e2e-kops-aws/79319/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/61106). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/nikhita). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *nikhita*:",
"text": "/kind bug\r\n/area custom-resources\r\n/sig api-machinery"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *nikhita*:",
"text": "/kind bug\r\n/area custom-resources\r\n/sig api-machinery"
}
}
] |
[
{
"action": "opened",
"author": "kshedden",
"comment_id": null,
"datetime": 1472008247000,
"text": "Resolves #3177 by raising if the column names are integer type.",
"title": "ENH: Raise if MICEData dataframe has integer column names",
"type": "issue"
},
{
"action": "created",
"author": "kshedden",
"comment_id": 261079644,
"datetime": 1479332138000,
"text": "@josef-pkt OK to merge? The test failure is unrelated to this PR.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/9678963)\n\nCoverage decreased (-0.001%) to 88.025% when pulling **d7f62ded493eb6a81ca4a4f8c7f863c5e7db8f32 on kshedden:mice-3177** into **22f27667729af3e07ad4ff8a48e0e7a5570b181e on statsmodels:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *kshedden*:",
"text": "@josef-pkt OK to merge? The test failure is unrelated to this PR."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *kshedden*:",
"text": "@josef-pkt OK to merge? The test failure is unrelated to this PR."
}
}
] |
[
{
"action": "opened",
"author": "TonyFlury",
"comment_id": null,
"datetime": 1520414860000,
"text": "<!--\r\nThanks for your contribution!\r\nPlease read this comment in its entirety. It's quite important.\r\n\r\n# Pull Request title\r\n\r\nIt should be in the following format:\r\n```\r\nbpo-NNNN: Summary of the changes made\r\n```\r\nWhere: bpo-NNNN refers to the issue number in the https://bugs.python.org.\r\n\r\nMost PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.\r\n\r\n# Backport Pull Request title\r\n\r\nIf this is a backport PR (PR made against branches other than `master`),\r\nplease ensure that the PR title is in the following format:\r\n```\r\n[X.Y] <title from the original PR> (GH-NNNN)\r\n```\r\nWhere: [X.Y] is the branch name, e.g. [3.6].\r\n\r\nGH-NNNN refers to the PR number from `master`.\r\n\r\n-->\r\n\n\n<!-- issue-number: bpo-33006 -->\nhttps://bugs.python.org/issue33006\n<!-- /issue-number -->",
"title": "bpo-33006 - Correct filter doc string to clarify 2nd argument can be iterable",
"type": "issue"
},
{
"action": "created",
"author": "TonyFlury",
"comment_id": 385549887,
"datetime": 1525127952000,
"text": "I have made the requested changes; please review again.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "miss-islington",
"comment_id": 496750293,
"datetime": 1559093763000,
"text": "@TonyFlury: Status check is done, and it's a success ✅ .",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Thanks for making the requested changes!\n\n@ned-deily: please review the changes made to this pull request.",
"previous": {
"meta": "This message directly preceded comment from bot *bedevere-bot* by author *TonyFlury*:",
"text": "I have made the requested changes; please review again."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *bedevere-bot* by author *TonyFlury*:",
"text": "I have made the requested changes; please review again."
}
}
] |
[
{
"action": "opened",
"author": "oliveralonzo",
"comment_id": null,
"datetime": 1511124201000,
"text": "",
"title": "Fix Markdown in README.md",
"type": "issue"
},
{
"action": "created",
"author": "oliveralonzo",
"comment_id": 345548159,
"datetime": 1511124356000,
"text": "I signed it!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "maryroseMXXXVI",
"comment_id": 363361107,
"datetime": 1517909033000,
"text": "Why do I need to signed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "y00223621",
"comment_id": 451345703,
"datetime": 1546572753000,
"text": "11\r\n22",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sorinj",
"comment_id": 452481936,
"datetime": 1546988163000,
"text": "Thank you for pointing this out and sending a fix.",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "CLAs look good, thanks!\n\n<!-- ok -->",
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *oliveralonzo*:",
"text": "I signed it!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *oliveralonzo*:",
"text": "I signed it!"
}
}
] |
[
{
"action": "opened",
"author": "zhangxiaoyu-zidif",
"comment_id": null,
"datetime": 1495867002000,
"text": "<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nReturn nil directly when err is nil\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!-- Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```",
"title": "Return nil when err is nil",
"type": "issue"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 304463681,
"datetime": 1495903985000,
"text": "This is effectively a noop. Why is this needed?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zhangxiaoyu-zidif",
"comment_id": 304482656,
"datetime": 1495929052000,
"text": "@cblecker Sir， please refer to https://github.com/kubernetes/kubernetes/pull/29866, https://github.com/kubernetes/kubernetes/pull/45162. That may be a format. Thanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 304492137,
"datetime": 1495945829000,
"text": "@k8s-bot ok to test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 304702943,
"datetime": 1496078030000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "wojtek-t",
"comment_id": 304815527,
"datetime": 1496134353000,
"text": "/approve",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/46561#issuecomment-304702943\" title=\"LGTM\">cblecker</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/46561#\" title=\"Author self-approved\">zhangxiaoyu-zidif</a>*\nWe suggest the following additional approver: **ixdy**\n\nAssign the PR to them by writing `/assign @ixdy` in a comment when ready.\n\n<details open>\nNeeds approval from an approver in each of these OWNERS Files:\n\n- **[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)**\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"ixdy\"]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *cblecker*:",
"text": "/lgtm"
}
},
{
"bot": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/46561#issuecomment-304702943\" title=\"LGTM\">cblecker</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/46561#issuecomment-304815527\" title=\"Approved\">wojtek-t</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/46561#\" title=\"Author self-approved\">zhangxiaoyu-zidif</a>*\n\n<details >\nNeeds approval from an approver in each of these OWNERS Files:\n\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)~~ [wojtek-t]\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *wojtek-t*:",
"text": "/approve"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *cblecker*:",
"text": "/lgtm"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-merge-robot* by author *wojtek-t*:",
"text": "/approve"
}
}
] |
[
{
"action": "opened",
"author": "sergiohs84",
"comment_id": null,
"datetime": 1485962115000,
"text": "",
"title": "Add creation date to chat data",
"type": "issue"
},
{
"action": "created",
"author": "sergiohs84",
"comment_id": 278589164,
"datetime": 1486632266000,
"text": "trigger compilation",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "polmr",
"comment_id": 281706727,
"datetime": 1487778184000,
"text": "trigger compilation",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "sdkPRcompilationAutoTools FAILED (422) :-1:",
"previous": {
"meta": "This message directly preceded comment from bot *JenkinsMega* by author *sergiohs84*:",
"text": "trigger compilation"
}
},
{
"bot": "sdkPRcompilationAutoTools SUCCEDED (451) :+1:",
"previous": {
"meta": "This message directly preceded comment from bot *JenkinsMega* by author *polmr*:",
"text": "trigger compilation"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *JenkinsMega* by author *sergiohs84*:",
"text": "trigger compilation"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *JenkinsMega* by author *polmr*:",
"text": "trigger compilation"
}
}
] |
[
{
"action": "opened",
"author": "conglei",
"comment_id": null,
"datetime": 1506452614000,
"text": "Added new network library.",
"title": "Conglei graph",
"type": "issue"
},
{
"action": "created",
"author": "conglei",
"comment_id": 332540062,
"datetime": 1506522602000,
"text": "Changes done :) working on writting the test. Should I push the commit of the test file here?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "williaster",
"comment_id": 332593324,
"datetime": 1506532789000,
"text": "yep all commits should be pushed!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "conglei",
"comment_id": 332680438,
"datetime": 1506553594000,
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "williaster",
"comment_id": 332910073,
"datetime": 1506620304000,
"text": "Great thanks @conglei! \r\n\r\nwill merge and cut a release, and we can iterate on functionality if needed from there 🎉 it still might be useful for this to move back to @vx at some point (cc @hshoff) but let's dog food it a bit first.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hshoff",
"comment_id": 332910368,
"datetime": 1506620374000,
"text": "Great work @conglei!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://coveralls.io/builds/13460158)\n\nCoverage remained the same at 81.764% when pulling **6a850bdbaa7e4844558d753006b665f4b50feeff on conglei:conglei-graph** into **efc72176ad64622e29ff4b06c8578a01714bc274 on williaster:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *williaster*:",
"text": "yep all commits should be pushed!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *coveralls* by author *williaster*:",
"text": "yep all commits should be pushed!"
}
}
] |
[
{
"action": "opened",
"author": "traflm",
"comment_id": null,
"datetime": 1524626514000,
"text": "This is the very first code drop for TRAFODION-2953, the major purpose is to get feedback to see if the design is OK and shall we continue with this effort or not.\r\nPlease check https://issues.apache.org/jira/browse/TRAFODION-2953, I attached a design document there.\r\n\r\nThis PR contains initial prototype of the design. It still has a major code-refactor to do, but I would like to hear from community first, before I spend more time on it, in case there are something fundamentally wrong.\r\n\r\nThe major change for this prototype code is to add a new PartitionFunction, instead of modifying the SinglePartitionPartitioningFunction directly. I will inherit a new SinglePartitionWithSmallTablePartitioningFunction from SinglePartitionPartitioningFunction next.\r\n\r\nOne can check the TEST035 to get a demo of how it works.\r\n\r\nThere are many other tasks following this initial code drop. For example, index/alter/create-super-table etc.\r\n\r\nThe major idea to support this is to add a new SYSTEM column _TBLNM_, so in a single Region, rows belong to different tables can be distinguished. When doing IUDS, always add predicate _TBLNM_ = 'theNameOfTheTable' to filter out the correct rows. \r\n\r\nPlease help to review and let me know your comments!",
"title": "[TRAFODION-2953] initial implementation of small table in one Hbase Region",
"type": "issue"
},
{
"action": "created",
"author": "traflm",
"comment_id": 384149583,
"datetime": 1524626772000,
"text": "something wrong with my PR, most changes not in the PR. Close it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "traflm",
"comment_id": 384150448,
"datetime": 1524627157000,
"text": "Recovered, PR is no OK...\r\n@anoopsharma00 @DaveBirdsall @zellerh , please help to take a review",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "traflm",
"comment_id": 384269367,
"datetime": 1524659435000,
"text": "This PR is not ready, far from ready, sorry, let me close it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "traflm",
"comment_id": 384358265,
"datetime": 1524675338000,
"text": "reopen just for some tests, Do not merge",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "traflm",
"comment_id": 387260480,
"datetime": 1525744742000,
"text": "jenkins, retest",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2597/",
"previous": {
"meta": "This message directly preceded comment from bot *Traf-Jenkins* by author *traflm*:",
"text": "reopen just for some tests, Do not merge"
}
},
{
"bot": "Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2622/",
"previous": {
"meta": "This message directly preceded comment from bot *Traf-Jenkins* by author *traflm*:",
"text": "jenkins, retest"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *Traf-Jenkins* by author *traflm*:",
"text": "reopen just for some tests, Do not merge"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *Traf-Jenkins* by author *traflm*:",
"text": "jenkins, retest"
}
}
] |
[
{
"action": "opened",
"author": "mikedanese",
"comment_id": null,
"datetime": 1524499892000,
"text": "we deploy it as a manifest, not an addon so locate it with the other\r\nmaster manifests.\r\n\r\nThis is the last \"bare pod addon\", which needs to be remove to improve the situation in https://github.com/kubernetes/kubernetes/issues/62808.\r\n \r\n```release-note\r\n\r\n```",
"title": "gce: move etcd dir cleanup to manifests",
"type": "issue"
},
{
"action": "created",
"author": "krousey",
"comment_id": 383640078,
"datetime": 1524501321000,
"text": "Does a service account in manifests work? And you don't need the role bindings anymore?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "krousey",
"comment_id": 383645051,
"datetime": 1524502260000,
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikedanese",
"comment_id": 383720387,
"datetime": 1524517056000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikedanese",
"comment_id": 383965244,
"datetime": 1524582016000,
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikedanese",
"comment_id": 383999793,
"datetime": 1524588025000,
"text": "/retest",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "@mikedanese: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-kops-aws | fb5fb2f09daab9407bda9f68795b7b45762adc75 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63015/pull-kubernetes-e2e-kops-aws/85377/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/63015). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/mikedanese). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krousey*:",
"text": "/lgtm"
}
},
{
"bot": "/retest\nThis bot automatically retries jobs that failed/flaked on approved PRs (send feedback to [fejta](https://github.com/fejta)).\n\nReview the [full test history](https://k8s-gubernator.appspot.com/pr/63015) for this PR.\n\nSilence the bot with an `/lgtm cancel` comment for consistent failures.",
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *mikedanese*:",
"text": "/retest"
}
},
{
"bot": "@mikedanese: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-kops-aws | a9432d09d63c4d842544d8285acefff4d275e579 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63015/pull-kubernetes-e2e-kops-aws/85458/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-integration | ae73bed1d0b9a299b06fc762d513b9b734ea4ce7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63015/pull-kubernetes-integration/8236/) | `/test pull-kubernetes-integration`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/63015). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/mikedanese). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *mikedanese*:",
"text": "/retest"
}
},
{
"bot": "@mikedanese: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-verify | ae73bed1d0b9a299b06fc762d513b9b734ea4ce7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63015/pull-kubernetes-verify/87783/) | `/test pull-kubernetes-verify`\npull-kubernetes-integration | ae73bed1d0b9a299b06fc762d513b9b734ea4ce7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63015/pull-kubernetes-integration/8264/) | `/test pull-kubernetes-integration`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/63015). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/mikedanese). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *mikedanese*:",
"text": "/retest"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *krousey*:",
"text": "/lgtm"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *mikedanese*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *mikedanese*:",
"text": "/retest"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *k8s-ci-robot* by author *mikedanese*:",
"text": "/retest"
}
}
] |
[
{
"action": "opened",
"author": "janno42",
"comment_id": null,
"datetime": 1462094921000,
"text": "Fix #681 \r\n\r\nThis allows exporting raw course data per semester as well as a participation overview in CSV format. Both are helpful for creating detailed statistics about a semester.",
"title": "Raw data export",
"type": "issue"
},
{
"action": "created",
"author": "karyon",
"comment_id": 216037755,
"datetime": 1462104364000,
"text": "oh and please add tests :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "karyon",
"comment_id": 216051656,
"datetime": 1462118182000,
"text": "could you add an explanation why that page got removed to the commit message? also, check out the landscape issues.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "janno42",
"comment_id": 217729746,
"datetime": 1462723490000,
"text": "added tests. i don't like them. let the hate begin.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "karyon",
"comment_id": 217736330,
"datetime": 1462730176000,
"text": ":fuelpump:",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[](https://landscape.io/diff/338970)\nRepository health decreased by 0.65% when pulling **[e48c2ab](https://github.com/janno42/EvaP/commit/e48c2abc0bc84738f9b1c995e41e70d601ce825b) on janno42:raw_export** into **[803ac98](https://github.com/fsr-itse/EvaP/commit/803ac9825aac1024137220bed631e4302d580d18) on fsr-itse:master**.\n\n * [7 new problems were found](https://landscape.io/diff/338970) (including 0 errors and 7 code smells).\n * No problems were fixed.",
"previous": {
"meta": "This message directly preceded comment from bot *landscape-bot* by author *karyon*:",
"text": "oh and please add tests :)"
}
},
{
"bot": "[](https://landscape.io/diff/343556)\nCode quality remained the same when pulling **[c0cf3f8](https://github.com/janno42/EvaP/commit/c0cf3f804476a4e0f8fcc641bedf342aa54221e8) on janno42:raw_export** into **[06a0f38](https://github.com/fsr-itse/EvaP/commit/06a0f38db9b1e5d2c6b379aeddc564f935a3bbc7) on fsr-itse:master**.",
"previous": {
"meta": "This message directly preceded comment from bot *landscape-bot* by author *janno42*:",
"text": "added tests. i don't like them. let the hate begin."
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *landscape-bot* by author *karyon*:",
"text": "oh and please add tests :)"
}
},
{
"previous": {
"meta": "This message directly preceded comment from bot *landscape-bot* by author *janno42*:",
"text": "added tests. i don't like them. let the hate begin."
}
}
] |
[
{
"action": "opened",
"author": "zoumo",
"comment_id": null,
"datetime": 1523956268000,
"text": "<!-- Thanks for sending a pull request! See below for tips! -->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nAdd your description\r\n\r\n**Which issue(s) this PR fixes** *(optional, close the issue(s) when PR gets merged)*:\r\n\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n/cc @your-reviewer\r\n\r\n**Release note**:\r\n<!-- Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n\r\n```release-note\r\nchore(k8s): update kubernetes api to 1.10\r\n```\r\n\r\n<!-- Thanks for sending a pull request! Here are some tips:\r\n\r\n1. https://github.com/caicloud/engineering/blob/master/docs/review_conventions.md <-- what is the review process looks like\r\n2. https://github.com/caicloud/engineering/blob/master/docs/commit_conventions.md <-- how to structure your git commit\r\n3. https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md <-- how to work with caicloud bot\r\n\r\nOther tips from Kubernetes cmomunity:\r\n\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->",
"title": "chore(k8s): update kubernetes api to 1.10",
"type": "issue"
},
{
"action": "created",
"author": "yejiayu",
"comment_id": 382954108,
"datetime": 1524192837000,
"text": "/lgtm",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/caicloud/loadbalancer-controller/pull/53#issuecomment-382954108\" title=\"LGTM\">yejiayu</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **zoumo**\n\nAssign the PR to them by writing `/assign @zoumo` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md#bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/caicloud/loadbalancer-controller/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"zoumo\"]} -->",
"previous": {
"meta": "This message directly preceded comment from bot *caicloud-bot* by author *yejiayu*:",
"text": "/lgtm"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *caicloud-bot* by author *yejiayu*:",
"text": "/lgtm"
}
}
] |
[
{
"action": "opened",
"author": "AccessibilityTestingTeam-TCS",
"comment_id": null,
"datetime": 1529415060000,
"text": "**Environment Details:**\r\nVSCode Version : 1.24.0\r\nOS Version : HighSierra10.13.5\r\n\r\n**Additional Details:**\r\nMAS Violated : MAS 2.4.3\r\nScreenReader : VoiceOver\r\n\r\n**Repro Steps:**\r\n1. Launch VS Code while VoiceOver is ON.\r\n2. Navigate to Activity Bar and select \"View Debug \" button.\r\n3. Navigate to \"All Exceptions\" and \"User Handled Exceptions\" tick boxes in \"Breakpoints\" section.\r\n4. Check/Uncheck checkboxes and use \"Tab\" each time to focus them.\r\n\r\n**Actual:**\r\nKeyboard focus does not remain on the tick box when any state is changed. \"Tab\" is needed to bring back tick box on focus for first tick box and for second several tabs are used to bring back focus.\r\n\r\n**Expected:**\r\nKeyboard focus should remain on the tick box on which any state change action is performed.\r\n\r\n**Recommendations:**\r\nRefer below link which is repository of bug fixes code snippets:\r\nhttps://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx\r\n\r\n**User Impact:**\r\nThe keyboard only users will find difficulty in navigating between these tick boxes since they would need to \"Tab\" again and again to bring focus back to same control once their states are changed.\r\n\r\n**MAS Reference:**\r\nMAS 2.4.3 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={0de7fbe1-ad7e-48e5-bcbb-8d986691e2b9}\r\n\r\n**Attachment For Reference:**\r\n[A11y_VSCode_ViewDebug_Keyboard_Mac_TickBoxFocusRetentionIssue.pptx](https://github.com/Microsoft/vscode/files/2115346/A11y_VSCode_ViewDebug_Keyboard_Mac_TickBoxFocusRetentionIssue.pptx)\r\n\r\nDoes this issue occur when all extensions are disabled?: Yes",
"title": "[Accessibility]A11y_VSCode_ViewDebug_Keyboard: Keyboard focus does not remain on the same tick box when checked/unchecked.",
"type": "issue"
},
{
"action": "created",
"author": "chrmarti",
"comment_id": 398405569,
"datetime": 1529416183000,
"text": "/duplicate #52299",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues [here](https://aka.ms/vscodeissuesearch). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!",
"previous": {
"meta": "This message directly preceded comment from bot *vscodebot[bot]* by author *chrmarti*:",
"text": "/duplicate #52299"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *vscodebot[bot]* by author *chrmarti*:",
"text": "/duplicate #52299"
}
}
] |
[
{
"action": "opened",
"author": "tengqm",
"comment_id": null,
"datetime": 1510649379000,
"text": "/kind bug\r\n\r\n*What happened**:\r\nWhen requesting a Pod creation with alpha.kubernetes.io/nvidia-gpu specified, I was hoping that the creation is a failure because I didn't enable the Accelerators feature gate. However, it succeeded. The pod is stuck in Pending status which is fine.\r\n\r\n**What you expected to happen**:\r\nI'm expecting that a Pod requesting GPU will be rejected when its container resource requirements are validated. Having the GPU usage guarded by the feature gate will help cleaning removing it in future when device plugin stabilizes.\r\n\r\n**How to reproduce it (as minimally and precisely as possible)**:\r\nDisable Accelerators feature gate and create a Pod with GPU request or limit, the pod is successfully created. It means that the feature gate is not doing its job.\r\n\r\n**Anything else we need to know?**:\r\n\r\n**Environment**:\r\n- Kubernetes version (use `kubectl version`):\r\n- Cloud provider or hardware configuration:\r\n- OS (e.g. from /etc/os-release):\r\n- Kernel (e.g. `uname -a`):\r\n- Install tools:\r\n- Others:",
"title": "Pods with GPU requests should be rejected early if Accelerators feature gate is off",
"type": "issue"
},
{
"action": "created",
"author": "dims",
"comment_id": 344731151,
"datetime": 1510780676000,
"text": "/sig node",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mindprince",
"comment_id": 375757687,
"datetime": 1521829285000,
"text": "/close\r\n\r\nThis is deprecated in 1.10 and going to be removed in 1.11: https://github.com/kubernetes/kubernetes/pull/61498",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "Issues go stale after 90d of inactivity.\nMark the issue as fresh with `/remove-lifecycle stale`.\nStale issues rot after an additional 30d of inactivity and eventually close.\n\nIf this issue is safe to close now please do so with `/close`.\n\nSend feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta).\n/lifecycle stale",
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *dims*:",
"text": "/sig node"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *fejta-bot* by author *dims*:",
"text": "/sig node"
}
}
] |
[
{
"action": "opened",
"author": "joeltine",
"comment_id": null,
"datetime": 1438298462000,
"text": "Fixes https://github.com/google/closure-library/issues/345",
"title": "Remove mention of __proto__ being a safe key",
"type": "issue"
},
{
"action": "created",
"author": "joeltine",
"comment_id": 126519152,
"datetime": 1438298656000,
"text": "I signed it!",
"title": null,
"type": "comment"
}
] |
[
{
"bot": "CLAs look good, thanks!\n\n<!-- ok -->",
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *joeltine*:",
"text": "I signed it!"
}
}
] |
[
{
"previous": {
"meta": "This message directly preceded comment from bot *googlebot* by author *joeltine*:",
"text": "I signed it!"
}
}
] |
End of preview. Expand
in Data Studio
- Downloads last month
- 3