Systemd is bad parsing
I agree with most of the critique, but I don't quite get the part about the use of assert.<p>The code in question quite clearly doesn't use C's standard assert macro, but a custom macro called assert_return (which I <i>guess</i> checks for a condition, and returns from the function instead of aborting the program).<p>So basically:<p><pre><code>    if (!condition) {
        return err;
    }
</code></pre>
How else would one check for invalid input to the function?