I got robbed of my first kernel contribution
The maintainer&#x27;s patch is better.<p>1. It doesn&#x27;t lose the fpidx &lt; (PT_FPSCR - PT_FPR0) test from the 32 bit case.<p>2. In the put function, it doesn&#x27;t lose the *data = child-&gt;thread.fp_state.fpscr; fallback assignment, which is taken when fpidx is out of bounds.<p>3. It avoids the pointless FPRINDEX macro which reduces to identity if TS_FPRWIDTH is 1. The original patch&#x27;s commit message says &quot;On PPC32 it&#x27;s ok to assume that TS_FPRWIDTH is 1&quot;, but then includes this anyway:<p><pre><code>  #define FPRNUMBER(i) (((i) - PT_FPR0) &gt;&gt; 1)
  #define FPRHALF(i) (((i) - PT_FPR0) &amp; 1)
  #define FPRINDEX(i) TS_FPRWIDTH * FPRNUMBER(i) * 2 + FPRHALF(i)
</code></pre>
Sorry, just because you found this trivially fixable array mismatch doesn&#x27;t mean your buggy patch has to be accepted the way it is.<p>The maintainer should, however, acknowledge that Miculas didn&#x27;t simply report the problem, but that Miculas investigated identified the root cause, and had his own version of almost the same simple fix.<p>&quot;Reported-By&quot; lacks the precision to express that it was thoroughly investigated by that party, and root-caused.