Datasets:
Tasks:
Text Generation
Formats:
parquet
Sub-tasks:
language-modeling
Languages:
Danish
Size:
1M - 10M
License:
Add domsdatabasen
#74
by
kris927b
- opened
Addition of domsdatabasen.dk
This pull request adds data from domsdatabasen.dk, along with a create.py script to reproduce the dataset/update it.
- I have run the test suite using
make testand all tests pass - I have added/changed a dataset and have
- I have updated descriptive statistics using
make update-descriptive-statistics - I have bumped the version use
make bump-version
- I have updated descriptive statistics using
- If I have added a
create.pyscript I have added the script dependencies required to run that script. - I have updated the CHANGELOG.md if appropriate
@KennethEnevoldsen will you have a look?
I have yet to bump the version and add changelog. Waiting for PR/73 to close first.
kris927b
changed pull request status to
open
I have now merged the PR/73 changes into this, and bumped version and added changelog.
- Why do we see the edits for pr/73?
- For the script, I think it looks fine. Note that you can create additional scripts to import from if you need to structure things
- I would move
os.environinside theif mainormainfunction (so that it is not set at import) # Download PDFs in parallelseems like unused code - would delete- I would move
## Dataset Descriptionup so that it is above the added segments (which I would say fall under## Dataset Description
Otherwise, looks great! Pretty cool to see that we are approaching 5B tokens
Thanks for the review @KennethEnevoldsen !
I have fixed the things you have pointed out.
To answer 1., I think the reason is because this PR started before PR/73 was merged. As a result, merging those changes into this branch makes them show up here as well.
If no other objections, then I will merge this in.
kris927b
changed pull request status to
merged