[XLNet] attention_mask / input_mask - Why two `attention_mask` inputs?
For whatever reason XLNet accepts both an `attention_mask` and a `input_mask`. As far as I understand `attention_mask` = 1 - `input_mask`. I don't think having the same input twice (one is the inverse of the other) has any advantage. We should remove `input_mask` IMO (first depreciate, then remove). Also, `attention_mask` should be put in the 2nd positino to make model compatible with torchscript.
I agree! Deprecation until v4.0.0 seems like a reasonable solution,<|||||>(We'll need at least one release with it before 4.0.0 if we want to remove the deprecation at 4.0.0)<|||||>This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
