Re-styling in seq2seq attention
# What does this PR do?

After commenting the same things on multiple new models, I looked around and found everyone was copying this code I don't like from `BartAttention`. So fixing the source to avoid seeing it in the future :-)
Tests should be fixed now as well: https://github.com/huggingface/transformers/pull/11615