Datasets:

akumoth

/

peewee-issues

like 0

{ "login": "ripperdoc", "id": 1027509, "node_id": "MDQ6VXNlcjEwMjc1MDk=", "avatar_url": "https://avatars.githubusercontent.com/u/1027509?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ripperdoc", "html_url": "https://github.com/ripperdoc", "followers_url": "https://api.github.com/users/ripperdoc/followers", "following_url": "https://api.github.com/users/ripperdoc/following{/other_user}", "gists_url": "https://api.github.com/users/ripperdoc/gists{/gist_id}", "starred_url": "https://api.github.com/users/ripperdoc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ripperdoc/subscriptions", "organizations_url": "https://api.github.com/users/ripperdoc/orgs", "repos_url": "https://api.github.com/users/ripperdoc/repos", "events_url": "https://api.github.com/users/ripperdoc/events{/privacy}", "received_events_url": "https://api.github.com/users/ripperdoc/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I added a little helper here:\nhttps://github.com/coleifer/peewee/commit/a5ec7bb90b1882db95c6f4eae94ea373f7f6a50f\n", "Great, thanks!\n", "@coleifer Can you please give an example of how to use that helper function?\n", "That function actually went away. Now you can just call:\n\n``` python\nq = MyModel.select().where(MyModel.id == 3)\nprint q.sql()\nsql, params = q.sql()\n```\n", "@coleifer What if the result of `q = MyModel.select().where(MyModel.id == 3)` fails and caused an error? Is it possible to get the query that was sent to the DB and failed?", "You can log all queries.\r\n\r\n```python\r\nimport logging\r\nlogger = logging.getLogger('peewee')\r\nlogger.addHandler(logging.StreamHandler())\r\nlogger.setLevel(logging.DEBUG)\r\n```\r\n\r\nOr you can add try/except or use an interactive debugger...it's just Python, remember!", "http://docs.peewee-orm.com/en/latest/peewee/database.html#logging-queries", "@TimothyBramlett you can use the logging package:\r\n\r\n```\r\nimport logging\r\nlogging.basicConfig(level=logging.DEBUG)\r\n```\r\n\r\nPeewee will print all queries that it sends to the DB.", "As per peewee `3.13`, if you are connecting to a postgres database with peewee's underlying `psycopg2` (thanks @coleifer), you can print SQL queries by first getting the cursor, then calling the `mogrify()` method for your query.\r\n\r\n```python\r\nquery = <YOUR PEEWEE QUERY>\r\n\r\ncur = database.cursor()\r\nprint(cur.mogrify(*query.sql()))\r\n```\r\nWhere `database` is the Peewee Database object representing the connection to your database.", "`mogrify` may be a psycopg2-only thing, and no supported by other drivers. For example, the standard lib sqlite3 does not provide this method." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/114/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tmoertel", "id": 21773, "node_id": "MDQ6VXNlcjIxNzcz", "avatar_url": "https://avatars.githubusercontent.com/u/21773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tmoertel", "html_url": "https://github.com/tmoertel", "followers_url": "https://api.github.com/users/tmoertel/followers", "following_url": "https://api.github.com/users/tmoertel/following{/other_user}", "gists_url": "https://api.github.com/users/tmoertel/gists{/gist_id}", "starred_url": "https://api.github.com/users/tmoertel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tmoertel/subscriptions", "organizations_url": "https://api.github.com/users/tmoertel/orgs", "repos_url": "https://api.github.com/users/tmoertel/repos", "events_url": "https://api.github.com/users/tmoertel/events{/privacy}", "received_events_url": "https://api.github.com/users/tmoertel/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/113/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/113", "html_url": "https://github.com/coleifer/peewee/pull/113", "diff_url": "https://github.com/coleifer/peewee/pull/113.diff", "patch_url": "https://github.com/coleifer/peewee/pull/113.patch", "merged_at": "2012-10-08T21:39:00" }

{ "login": "jhorman", "id": 323697, "node_id": "MDQ6VXNlcjMyMzY5Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/323697?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jhorman", "html_url": "https://github.com/jhorman", "followers_url": "https://api.github.com/users/jhorman/followers", "following_url": "https://api.github.com/users/jhorman/following{/other_user}", "gists_url": "https://api.github.com/users/jhorman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jhorman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jhorman/subscriptions", "organizations_url": "https://api.github.com/users/jhorman/orgs", "repos_url": "https://api.github.com/users/jhorman/repos", "events_url": "https://api.github.com/users/jhorman/events{/privacy}", "received_events_url": "https://api.github.com/users/jhorman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I wonder if it would work just to create a model and have it specify its db_table attribute as the view. If the view \"looks\" like one of your existing models, you should also be able to subclass the exisitng model, e.g.:\n\n``` python\n\nclass MyModel(Model):\n # fields ...\n\nclass MyViewModel(MyModel):\n class Meta:\n db_table = 'this_is_actually_the_view'\n```\n\nIf I'm missing something essential to the issue please let me know but I belive the above should work.\n\nMore to the point, you have raised some excellent points about places where the API is brittle. I've rewritten peewee from the ground up and am finishing the work before merging it into master, but you can check the branch:\nhttps://github.com/coleifer/peewee/tree/unstable/2.0\n\nIt provides better hooks with a lot less insanity :)\n", "In this case I am using different views for different queries. I have a \"Video\" object, and I have 3 different views for pulling out videos based on some complicated rules. I forgot to mention that I was going to use RawQuery, which would have almost worked, except RawQuery and flask-peewee don't work well together. flask-peewee assumes a SelectQuery in a few places (like PaginatedQuery).\n\nI will check out the branch in the meantime too though.\n", "Cool, so just to clarify it won't work to do something like:\n\n``` python\n\nclass VideoViewOne(Video):\n class Meta:\n db_table = 'video_view_one'\n\nclass VideoViewTwo(Video):\n class Meta:\n db_table = 'video_view_two'\n```\n\nAnd then:\n\n``` python\n\nVideoViewOne.select() # <--- pull video objects out of the view \"video_view_one\"\n```\n", "Oh... um.... yeah that might work. I think I will need to see how that plays with my flask-peewee setup. Thanks for the tip.\n", "Just wanted to say I finally made the jump to your 2.0 release. Really nice. I really like the changes to the query language. I also was able to kill my fork and extend flask-peewee with my JSONField stuff pretty easily.\n\nThanks for a nice set of frameworks.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/112/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "obensonne", "id": 121881, "node_id": "MDQ6VXNlcjEyMTg4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/121881?v=4", "gravatar_id": "", "url": "https://api.github.com/users/obensonne", "html_url": "https://github.com/obensonne", "followers_url": "https://api.github.com/users/obensonne/followers", "following_url": "https://api.github.com/users/obensonne/following{/other_user}", "gists_url": "https://api.github.com/users/obensonne/gists{/gist_id}", "starred_url": "https://api.github.com/users/obensonne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/obensonne/subscriptions", "organizations_url": "https://api.github.com/users/obensonne/orgs", "repos_url": "https://api.github.com/users/obensonne/repos", "events_url": "https://api.github.com/users/obensonne/events{/privacy}", "received_events_url": "https://api.github.com/users/obensonne/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I am aware of the DRY issues, which is why I doc'd it and mentioned my reasons for defining defaults in python.\n\nAs to your question, the InsertQuery behaves correctly but `create` is apparently adding everyting regardless of whether you specify it or not. I will take a look into making create behave more like insert, as I think you're right about letting the db handle it where possible.\n\n``` python\n\nIn [1]: from peewee import *\n\nIn [2]: class Example(Model):\n ...: f1 = IntegerField(default=1)\n ...: f2 = CharField(default='hello')\n ...: f3 = CharField()\n ...: f4 = IntegerField()\n ...: \n\nIn [3]: Example.insert().sql()\nOut[3]: ('INSERT INTO \"example\" (\"f1\",\"f2\") VALUES (?,?)', [1, u'hello'])\n\nIn [4]: Example.insert(f3='bar').sql()\nOut[4]: \n('INSERT INTO \"example\" (\"f1\",\"f2\",\"f3\") VALUES (?,?,?)',\n [1, u'hello', u'bar'])\n```\n", "Thanks for the quick response.\n\nIndeed the query returned by `insert()` is what I'd expect. Would be great if `create()` has a similar behavior.\n\nDo you plan to work on this on your own or do you prefer a patch/pull request.\n", "Unfortunately this issue is not resolved yet.\n\nWhile `Model.create()` now works as exepected, `Model.save()` still creates an update query with all defined fields. Here it would be useful if only fields actually set are be included in the query. I can think of 2 solutions:\n1. Either use a special `unset` value (next to `None`) to distinguish not specified and `NULL` values, or\n2. Implement a `Model.__setattr__()` method which keeps track of set fields. Then, only these set fields plus the ones passed to the model constructor plus fields with defined defaults are used for the corresponding update query.\n\nOf course this is only needed for model instances created by `Model(**query)`, not for instances retrieved from database queries.\n\nI guess this is a bit more tricky. I know I could use `Model.update(...).execute()`, but setting fields with attribute-style access is much more convinient.\n", "This is all working in branch unstable/2.0 for what its worth.\n\nFixing in current will require using sentinel values most likely. If you want to patch it I can merge something, but since its working in the latest branch I'll probably pass for now on writing it myself.\n", "Great to hear that this already works in 2.0. I did not test it yet but I guess the unstable branch is just fine for me (instead of patchng 1.0). How _experimental_ is the unstable branch?\n", "Weeelllll, pretty. The API is not too different, but i haven't yet upgraded flask-peewee or wtf-peewee to work with it. Soon i'm going to merge it into master, just need to get everything documented.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/111/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "zffl", "id": 186776, "node_id": "MDQ6VXNlcjE4Njc3Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/186776?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zffl", "html_url": "https://github.com/zffl", "followers_url": "https://api.github.com/users/zffl/followers", "following_url": "https://api.github.com/users/zffl/following{/other_user}", "gists_url": "https://api.github.com/users/zffl/gists{/gist_id}", "starred_url": "https://api.github.com/users/zffl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zffl/subscriptions", "organizations_url": "https://api.github.com/users/zffl/orgs", "repos_url": "https://api.github.com/users/zffl/repos", "events_url": "https://api.github.com/users/zffl/events{/privacy}", "received_events_url": "https://api.github.com/users/zffl/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yeah...its weird, i'm not in love with the api...but here's how you do it:\n\n``` python\n\nC.select({A: ['c1'], C: ['c4', Count('id')]}).group_by('c4').join(B).join(A).group_by('c1')\n```\n1. First we select the columns -- you had that part right except you were just missing the Count('id') in the list of \"C\" columns. `from peewee import Count`\n2. Then while the \"query context\" is \"C\", we'll group by `c4`\n3. Then join from c -> b, b -> a\n4. Now the query context is \"A\", we'll group by `c1`\n\nThis yields:\n\n``` sql\n\nSELECT t1.\"c4\", COUNT(t1.\"id\") AS count, t3.\"c1\"\nFROM \"c\" AS t1 \nINNER JOIN \"b\" AS t2 ON t1.\"c3_id\" = t2.\"id\"\nINNER JOIN \"a\" AS t3 ON t2.\"c2_id\" = t3.\"id\" \nGROUP BY t1.\"c4\", t3.\"c1\"\n```\n\nI'm working on a rewrite of peewee in branch unstable/2.0 -- it will improve on some of these inconsistencies.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/110/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "davidthewatson", "id": 150892, "node_id": "MDQ6VXNlcjE1MDg5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/150892?v=4", "gravatar_id": "", "url": "https://api.github.com/users/davidthewatson", "html_url": "https://github.com/davidthewatson", "followers_url": "https://api.github.com/users/davidthewatson/followers", "following_url": "https://api.github.com/users/davidthewatson/following{/other_user}", "gists_url": "https://api.github.com/users/davidthewatson/gists{/gist_id}", "starred_url": "https://api.github.com/users/davidthewatson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davidthewatson/subscriptions", "organizations_url": "https://api.github.com/users/davidthewatson/orgs", "repos_url": "https://api.github.com/users/davidthewatson/repos", "events_url": "https://api.github.com/users/davidthewatson/events{/privacy}", "received_events_url": "https://api.github.com/users/davidthewatson/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This sounds very evil.\n", "Without sounding pedantic, could you elaborate on the ambiguous pronoun \"this\"? That is, are you saying that model sharing across processes is evil or that attribute level model accessor affordances existing across processes is evil? If so, why? This seemed like a perfectly reasonable use of peewee to me.\n", "a peewee model is just a class...changes made in one python interpreter will not affect another interpreter process. if you need to, shuffle messages around via IPC that do the attribute manipulation.\n\ni said it was evil because a related_name is really an internal API used by code, so i was confused why code would need to change it.\n", "when you get a chance, please update me with the status of this or provide more info so i can help resolve\n", "In the example below, D is the model class representing the related_name d which was being used to access the values from the downstream process. This is, of course, broken, as you pointed out, because the downstream process hasn't manifested the attributes like the upstream process. Thus, this breaks because the related_name attribute d doesn't exist:\n\na.b.c.d[0].e\n\nThe solution is to use a get query in place of the missing related_name attribute:\n\nD.get(c=self.a.b.c).e\n\nwhich works fine.\n\nThis is, of course, writ large to show the relationships. The actual code uses functional shorthand to flatten the joins. \n\nI thought this might be a useful piece of documentation. Perhaps obvious, but wasn't immediately apparent to me until I thought through the related_name issue. It seemed from your earlier answer that related_name may be intended for internal use only. Should I never be using related_name attributes outside the model they're defined in?\n\nI wanted to point this out, because, while my use of peewee maybe somewhat beyond its intended usage, these things can and do work. And I love peewee!\n", "Hmm... I suppose I'm still not 100% sure what the related name issue is. Can we talk about two of my favorite models, User and tweet (which Fks to user)?\n\n``` python\n\nclass User(Model):\n username = CharField()\n\nclass Tweet(Model):\n user = ForeignKeyField(User, related_name='tweets')\n message = CharField()\n```\n\nCan you show me, using those two models, the issue?\n", "Yeah, no problem.\n\nThe first process creates a user which has associated tweets. The second process needs to act on a user's associated tweets but the tweets related_name doesn't exist:\n\nProcess #1: \n\nuser.tweets\n\nProcess #2:\nuser = User.get(username=\"charlie\")\nTweet.get(user=user)\n", "closing for now\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/109/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "widoyo", "id": 43075, "node_id": "MDQ6VXNlcjQzMDc1", "avatar_url": "https://avatars.githubusercontent.com/u/43075?v=4", "gravatar_id": "", "url": "https://api.github.com/users/widoyo", "html_url": "https://github.com/widoyo", "followers_url": "https://api.github.com/users/widoyo/followers", "following_url": "https://api.github.com/users/widoyo/following{/other_user}", "gists_url": "https://api.github.com/users/widoyo/gists{/gist_id}", "starred_url": "https://api.github.com/users/widoyo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/widoyo/subscriptions", "organizations_url": "https://api.github.com/users/widoyo/orgs", "repos_url": "https://api.github.com/users/widoyo/repos", "events_url": "https://api.github.com/users/widoyo/events{/privacy}", "received_events_url": "https://api.github.com/users/widoyo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Can you share your model code with me? Just the class definition should be fine. If you can get me the SQL create table query as well that you ran that'd be great (ModelClass.create_table_query() i think). Were these models autogenerated by peewee or were they pre-existing?\n", "I'm not sure if you have tried this, but you might write:\n\n``` python\nclass MyModel(db.Model):\n ID = PrimaryKeyField()\n some_field = CharField()\n```\n\nThat should work correctly, and in my testing locally appears to do the right thing.\n", "I use pre existing database, I use Gammu with postgresql database.\n\n...sql\n-- Table: sentitems\n\n-- DROP TABLE sentitems;\n\nCREATE TABLE sentitems\n(\n \"ID\" serial NOT NULL,\n \"UDH\" text NOT NULL,\n \"SMSCNumber\" character varying(20) NOT NULL DEFAULT ''::character varying,\n \"Class\" integer NOT NULL DEFAULT (-1),\n \"TextDecoded\" text NOT NULL DEFAULT ''::text,\n \"SenderID\" character varying(255) NOT NULL,\n \"SequencePosition\" integer NOT NULL DEFAULT 1,\n \"Status\" character varying(255) NOT NULL DEFAULT 'SendingOK'::character\nvarying,\n \"StatusError\" integer NOT NULL DEFAULT (-1),\n \"TPMR\" integer NOT NULL DEFAULT (-1),\n \"RelativeValidity\" integer NOT NULL DEFAULT (-1),\n \"CreatorID\" text NOT NULL,\n id_folder integer NOT NULL DEFAULT 3,\n)\n...\n\nAnd my model is\n\n...python\nclass Sent(db.Model, PgModel):\n ID = pw.PrimaryKeyField()\n body = pw.TextField(db_column='TextDecoded')\n destination = pw.CharField(max_length=20, db_column='DestinationNumber')\n\n```\nclass Meta:\n db_table = 'sentitems'\n```\n\n...\n\nand the error is:\n\n```\npsycopg2.ProgrammingError\n\nProgrammingError: column \"id\" does not exist LINE 1: SELECT COUNT(ID) FROM\n\"sentitems\" ^\n```\n\nWhen I rename column 'ID' into 'id' there is no \"programming error\".\nThe programming error is because of \"SELECT COUNT(ID) FROM ...\", it is not\nerror when \"SELECT COUNT('ID') FROM ...\", I have tried from SQL command on\nPostgresql.\n\nOn Mon, Sep 17, 2012 at 11:35 PM, Charles Leifer\[email protected]:\n\n> Can you share your model code with me? Just the class definition should be\n> fine. If you can get me the SQL create table query as well that you ran\n> that'd be great (ModelClass.create_table_query() i think). Were these\n> models autogenerated by peewee or were they pre-existing?\n\n## \n\nWidoyo\n", "Hmm -- something strange is going on. Is it only SELECT COUNT() queries that don't work? Is the SQL you pasted generated by dumping your existing database, or is it something else? I'm curious to see exactly what your _current_ database schema looks like\n", "The problem could be on the postgresql with column named ID. Sql generated\nfrom pgadminIII\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/108/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "zffl", "id": 186776, "node_id": "MDQ6VXNlcjE4Njc3Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/186776?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zffl", "html_url": "https://github.com/zffl", "followers_url": "https://api.github.com/users/zffl/followers", "following_url": "https://api.github.com/users/zffl/following{/other_user}", "gists_url": "https://api.github.com/users/zffl/gists{/gist_id}", "starred_url": "https://api.github.com/users/zffl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zffl/subscriptions", "organizations_url": "https://api.github.com/users/zffl/orgs", "repos_url": "https://api.github.com/users/zffl/repos", "events_url": "https://api.github.com/users/zffl/events{/privacy}", "received_events_url": "https://api.github.com/users/zffl/received_events", "type": "User", "site_admin": false }

[]

[]

[ "When you initialize a model instance, it will initialize fields to their default values, e.g.:\n\n``` python\n\n>>> from tests import *\n>>> dv = DefaultVals() # <-- pub date defaults to datetime.datetime.now\n>>> dv.pub_date\ndatetime.datetime(2012, 9, 9, 11, 31, 37, 797693)\n```\n\nWhen you call `save()` it rounds up all the field values on the instance and passes them along to the insert query.\n\nHowever when using `insert` directly it will only use the values you pass in explicitly. This is not explicitly by design. I'll have to think on whether to keep the current behavior (insert is explicit and ignores defaults) or whether it will implicitly fill in missing values with the field defaults.\n", "Insert will now respect defaults when they are not specified\n", "I think this fix might have been un-fixed.\n\n```\nm = DatModel()\nm.foo = None\nm.save()\n```\n\nThis results in an Integrity error (NOT NULL constraint failed) if `DatModel.foo` has `null=False`.\n\nI already found out that in the current version in pip, nothing besides `Model.__init__` calls `ModelOptions.get_default_dict` (The fix introduced a call to it in `InsertQuery.__init__`).\n", "I'm not sure I'm understanding correctly, because if you explicitly set foo to None, peewee will not override it. Given that, makes sense to me there would follow an exception if foo was not null.\n", "Oh, but I see your point in reference to this particular issue and the way it was resolved.\n\nSo, to clarify, the fix should still be in place. Check out InsertQuery._iter_rows(). Basically it's applying defaults there. But when you are working with a model and explicitly set a field to a value, that takes precedence over a default.\n", "Thanks for the clarification. But now I'm wondering what the correct way of setting the value of a field (of a previously existing instance, so UPDATE) back to its default. Do I have to manually evaluate `DatModel.datfield._meta.default` or is there a way to make peewee do it?\n", "Just do: obj.field = ModelClass.field.default (add parentheses if it's a callable).\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/107/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mrjoes", "id": 179880, "node_id": "MDQ6VXNlcjE3OTg4MA==", "avatar_url": "https://avatars.githubusercontent.com/u/179880?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mrjoes", "html_url": "https://github.com/mrjoes", "followers_url": "https://api.github.com/users/mrjoes/followers", "following_url": "https://api.github.com/users/mrjoes/following{/other_user}", "gists_url": "https://api.github.com/users/mrjoes/gists{/gist_id}", "starred_url": "https://api.github.com/users/mrjoes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mrjoes/subscriptions", "organizations_url": "https://api.github.com/users/mrjoes/orgs", "repos_url": "https://api.github.com/users/mrjoes/repos", "events_url": "https://api.github.com/users/mrjoes/events{/privacy}", "received_events_url": "https://api.github.com/users/mrjoes/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I found this in documentation: http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#multi-threaded-applications but in Flask autoreload case, I'm not using threads. Can use these options to work around it though.\n", "Looks like the werkzeug debugger uses multiple threads:\n\nhttps://github.com/mitsuhiko/werkzeug/blob/master/werkzeug/serving.py#L585\n\nTo suppress these errors you can configure your database `threadlocals=True` or use the sqlite driver's `check_same_thread=False`\n", "`check_same_thread=False` is useful.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/106/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jamorton", "id": 18852, "node_id": "MDQ6VXNlcjE4ODUy", "avatar_url": "https://avatars.githubusercontent.com/u/18852?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jamorton", "html_url": "https://github.com/jamorton", "followers_url": "https://api.github.com/users/jamorton/followers", "following_url": "https://api.github.com/users/jamorton/following{/other_user}", "gists_url": "https://api.github.com/users/jamorton/gists{/gist_id}", "starred_url": "https://api.github.com/users/jamorton/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jamorton/subscriptions", "organizations_url": "https://api.github.com/users/jamorton/orgs", "repos_url": "https://api.github.com/users/jamorton/repos", "events_url": "https://api.github.com/users/jamorton/events{/privacy}", "received_events_url": "https://api.github.com/users/jamorton/received_events", "type": "User", "site_admin": false }

[]

[]

[ "If you take a look at the Database class, there are some undocumented methods that may be of help:\n\nhttps://github.com/coleifer/peewee/blob/master/peewee.py#L456\n\nSay you're renaming a field... from 'foo' to 'bar':\n\n`database.execute(database.rename_column_sql(FooModel, 'foo', 'bar'))`\n\nI'll see about getting this into the docs.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/105/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "diwakergupta", "id": 15990, "node_id": "MDQ6VXNlcjE1OTkw", "avatar_url": "https://avatars.githubusercontent.com/u/15990?v=4", "gravatar_id": "", "url": "https://api.github.com/users/diwakergupta", "html_url": "https://github.com/diwakergupta", "followers_url": "https://api.github.com/users/diwakergupta/followers", "following_url": "https://api.github.com/users/diwakergupta/following{/other_user}", "gists_url": "https://api.github.com/users/diwakergupta/gists{/gist_id}", "starred_url": "https://api.github.com/users/diwakergupta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/diwakergupta/subscriptions", "organizations_url": "https://api.github.com/users/diwakergupta/orgs", "repos_url": "https://api.github.com/users/diwakergupta/repos", "events_url": "https://api.github.com/users/diwakergupta/events{/privacy}", "received_events_url": "https://api.github.com/users/diwakergupta/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee uses metaclasses to give you \"declarative\" models. Your models and the fields you define as class attributes are valuable metadata and I cribbed the notion of using a metaclass to introspect these. It would be arguably more pythonic to do it differently, but this is the API I have chosen. You can see the details:\n\nhttps://github.com/coleifer/peewee/blob/master/peewee.py#L2566\n", "I'm not contesting the way Peewee does things. I'm merely asking if there's\nany way to make pylint + peewee happy short of disabling that error (which\ncan mask legit bugs in other code)\n\nOn Fri, Aug 17, 2012 at 6:42 AM, Charles Leifer [email protected]:\n\n> Peewee uses metaclasses to give you \"declarative\" models. Your models and\n> the fields you define as class attributes are valuable metadata and I\n> cribbed the notion of using a metaclass to introspect these. It would be\n> arguably more pythonic to do it differently, but this is the API I have\n> chosen. You can see the details:\n> \n> https://github.com/coleifer/peewee/blob/master/peewee.py#L2566\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/104#issuecomment-7818122.\n\n## \n\nhttp://floatingsun.net\n", "Ahh, totally -- I am not very familiar with pylint so I'm not sure what hooks it provides to say \"i know what i'm doing here\". If you come up with a patch I'd consider merging.\n", "This may be helpful http://stackoverflow.com/questions/115977/using-pylint-with-django\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/104/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "zffl", "id": 186776, "node_id": "MDQ6VXNlcjE4Njc3Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/186776?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zffl", "html_url": "https://github.com/zffl", "followers_url": "https://api.github.com/users/zffl/followers", "following_url": "https://api.github.com/users/zffl/following{/other_user}", "gists_url": "https://api.github.com/users/zffl/gists{/gist_id}", "starred_url": "https://api.github.com/users/zffl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zffl/subscriptions", "organizations_url": "https://api.github.com/users/zffl/orgs", "repos_url": "https://api.github.com/users/zffl/repos", "events_url": "https://api.github.com/users/zffl/events{/privacy}", "received_events_url": "https://api.github.com/users/zffl/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This issue goes more-or-less to some of the core assumptions I made -- many things are simpler if multiple joins to the same table aren't allowed -- for example:\n- in a complex query, the columns you select are represented as a dictionary keyed by model. if a model appears twice (i.e. is joined on twice) how do you represent which to select from?\n- when multiple models are joined on how do you express which you are querying in the where clause?\n\nI don't think I'll be able to fix this anytime soon, in other words. Sorry! Looks like sqa can do this but is kinda hacky: http://stackoverflow.com/questions/5780516/how-to-join-detail-twice-on-a-master-in-sqlalchemy\n", "One year on, it this still the case? I thought the Alias capability which allows for self joins would cause a new table alias to be created, but it doesn't appear to be the case.\n", "I see now that it works if you use the aliased model in a join, but it can't be used as the root of a select query.\n", "Correct -- you should be able to construct joins with aliased models, but not actually select them. OK to close this out?\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/103/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tmoertel", "id": 21773, "node_id": "MDQ6VXNlcjIxNzcz", "avatar_url": "https://avatars.githubusercontent.com/u/21773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tmoertel", "html_url": "https://github.com/tmoertel", "followers_url": "https://api.github.com/users/tmoertel/followers", "following_url": "https://api.github.com/users/tmoertel/following{/other_user}", "gists_url": "https://api.github.com/users/tmoertel/gists{/gist_id}", "starred_url": "https://api.github.com/users/tmoertel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tmoertel/subscriptions", "organizations_url": "https://api.github.com/users/tmoertel/orgs", "repos_url": "https://api.github.com/users/tmoertel/repos", "events_url": "https://api.github.com/users/tmoertel/events{/privacy}", "received_events_url": "https://api.github.com/users/tmoertel/received_events", "type": "User", "site_admin": false }

[]

[]

[ "There is a small problem in the implementation, which is that it does not take into account non-integer primary keys. That could be worked around though. I agree with this patch from the point-of-view that it simplifies the API but am not sure if it is worth changing the behavior of the entire `where` method (which calls `parseq`) to allow \"naked\" values to be passed in and implicitly taken to express `== <pk>`. I would suggest, if you want this, to implement a `get_pk` method on `Model`.\n", "Thanks for your feedback.\n\nLeaving aside for the moment non-integer primary keys, which I'll be happy to fix, let's assume that we add `get_pk`. Even if we have this method, won't we still need the equivalent for `where` filtering and the like?\n\nFor example, consider the following code, in which we want to get a blog entry given by an entry identifier, provided that the entry is owned by the blog that matches a given blog identifier and that the blog is owned by the currently logged in user:\n\n``` python\nclass User(Model):\n \"\"\"A person who can own blogs.\"\"\"\n # more fields here\n\nclass Blog(Model):\n \"\"\"A blog, which can own entries.\"\"\"\n owner = ForeignKeyField(User)\n # more fields here\n\nclass Entry(Model):\n \"\"\"A post to a blog.\"\"\"\n blog = ForeignKeyField(Blog)\n # more fields here\n\n\ndef read_entry(user, blog_id, entry_id):\n \"\"\"Handle request for /blog/<blog_id>/entry/<entry_id>.\n\n Args:\n user: Authenticated User-model instance for the logged-in user.\n blog_id: Blog identifier from URL.\n entry_id: Entry identifier from URL.\n\n Returns:\n Rendered HTML.\n\n Raises:\n Abort(404): if no such blog entry is visible to the user.\n\n \"\"\"\n query = (Entry.select().where(id=entry_id)\n .join(Blog).where(id=blog_id, owner=user))\n try:\n entry = query.get()\n except Entry.DoesNotExist:\n raise Abort(404)\n return render(\"entry\", entry=entry)\n```\n\nIt's easy to write this kind of code for specific model instances, where you know the names of all the primary keys in advance. But for generic code that gets passed Entry-like models and Blog-like models and their respective instance identifiers at run time, you can't write the code (reliably) without having it pry into peewee's internals to find what the models' primary keys are called:\n\n``` python\ndef read_general_entry(user, blog_model, blog_id, entry_model, entry_id):\n blog_pkname = blog_model._meta.pk_name\n entry_pkname = entry_model._meta.pk_name\n query = (Entry.select().where(**{entry_pkname: entry_id})\n .join(Blog).where(owner=user, **{blog_pkname: blog_id}))\n # the rest as before\n```\n\nWithout something like the change I'm proposing, is there any clean way to solve problems like the above from user code?\n\nAs an alternative to \"naked\" identifier values, would you be more agreeable to adding a PK class that could be used wherever Q could? So you could write\n\n``` python\nentry = entry_model.get(PK(entry_id))\nentry = entry_model.select().where(PK(entry_id).join(blog_model).where(PK(blog_id), user=user)\n```\n\nThoughts?\n", "While all of your suggestions have merit, I think I'm going to pass for now on adding something like this. Adding yet another method of querying to the (already large) available methods seems like a bad plan. _\"Syntactic sugar causes cancer of the semicolon\"_.\n", "Thanks for your response.\n\nCan I ask a favor? Given the current API, how would you recommend that I write model-generic code? (I can't figure out how to do it without prying into peewee's implementation internals (or requiring that all models use the same primary-key name). Am I missing something?)\n", "If you take a look here, https://github.com/coleifer/flask-peewee/blob/master/flask_peewee/admin.py#L142\n\nBasically, you're right:\n\n``` python\n\ndef get_pk(klass, pk):\n return klass.get(**{klass._meta.pk_name: pk})\n```\n", "What do you think about adding a public `get_pk_name()` method to models? It won't be super-convenient to use (`**{klass.get_pk_name(): pk}` doesn't exactly flow off the keyboard), but at least people won't have to make their code dependent upon peewee's internal implementation when they need knowledge of the primary key. That's the kind of thing that gets flagged at code reviews.\n\nBut maybe such a change would go against the grain of peewee's design? (My hunch about why there's not already something like `get_pk_name()` is that you wanted peewee to be smart enough that people wouldn't _have_ to know the names of keys: during joins and other common operations, peewee would just take care of that stuff. I figured that leaving the method off was your way of ensuring that users would come to you with those cases where peewee's current design wasn't able to be fully transparent about keys, so you could consider ways of making it transparent for those cases. All of this is to say: I'll understand if you don't want to add such a method. I wouldn't.)\n", "i've gone ahead and added `get_pk_dict` and `get_pk_name` methods to `Model` -- added in 04dace3bc9f71d93bbbfd7ab27e74bb81b59875b and 023d481199d6cea7d1ca223e3e46535496a81368\n\nHope this helps!\n", "Works for me :-)\n\nThanks.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/102/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/102", "html_url": "https://github.com/coleifer/peewee/pull/102", "diff_url": "https://github.com/coleifer/peewee/pull/102.diff", "patch_url": "https://github.com/coleifer/peewee/pull/102.patch", "merged_at": null }

{ "login": "ternus", "id": 77170, "node_id": "MDQ6VXNlcjc3MTcw", "avatar_url": "https://avatars.githubusercontent.com/u/77170?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ternus", "html_url": "https://github.com/ternus", "followers_url": "https://api.github.com/users/ternus/followers", "following_url": "https://api.github.com/users/ternus/following{/other_user}", "gists_url": "https://api.github.com/users/ternus/gists{/gist_id}", "starred_url": "https://api.github.com/users/ternus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ternus/subscriptions", "organizations_url": "https://api.github.com/users/ternus/orgs", "repos_url": "https://api.github.com/users/ternus/repos", "events_url": "https://api.github.com/users/ternus/events{/privacy}", "received_events_url": "https://api.github.com/users/ternus/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @ternus sorry I missed your messages in IRC. Will look into this today, thnx for the excellent report :)\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/101/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/101", "html_url": "https://github.com/coleifer/peewee/pull/101", "diff_url": "https://github.com/coleifer/peewee/pull/101.diff", "patch_url": "https://github.com/coleifer/peewee/pull/101.patch", "merged_at": "2012-07-14T16:17:03" }

{ "login": "mkosler", "id": 1159095, "node_id": "MDQ6VXNlcjExNTkwOTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1159095?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mkosler", "html_url": "https://github.com/mkosler", "followers_url": "https://api.github.com/users/mkosler/followers", "following_url": "https://api.github.com/users/mkosler/following{/other_user}", "gists_url": "https://api.github.com/users/mkosler/gists{/gist_id}", "starred_url": "https://api.github.com/users/mkosler/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mkosler/subscriptions", "organizations_url": "https://api.github.com/users/mkosler/orgs", "repos_url": "https://api.github.com/users/mkosler/repos", "events_url": "https://api.github.com/users/mkosler/events{/privacy}", "received_events_url": "https://api.github.com/users/mkosler/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yes, non-nullable is the same as required. Not null means if you do not store something there, the database will complain. Adding a required would be redundant.\n", "Well, then I think there must be a bug, because like I said, when I do this in the python shell, it doesn't yell at me. This is the model I am using for this:\n\n```\nclass User(BaseModel):\n username = CharField(unique = True)\n password = CharField(max_length = 40)\n email = CharField(unique = True)\n date_joined = DateField(default = datetime.date.today())\n website = CharField(null = True)\n logged_in = BooleanField()\n is_mod = BooleanField()\n is_admin = BooleanField()\n```\n\nBaseModel just sets the Meta class to the correct database. Here is what I run in the shell to show the issue:\n\n```\n>>> from models import *\n>>> user = User.create(username = 'test')\n>>> user.save() # redundant, but whatever\n>>> print user.password\nNone\n>>> user2 = User.get()\n>>> print user2.username\ntest\n>>> print user2.password\n\n>>> \n```\n\nFrom my understanding, the only field that should be allowed to be left blank is `website`, but I've clearly left every field besides username blank.\n\nI am using flask-script to get shell access, via `python manage.py shell`. Here's all the other libraries I am using:\n\n```\nFlask==0.9\nFlask-Script==0.3.3\nJinja2==2.6\nWTForms==1.0.1\nWerkzeug==0.8.3\nargparse==1.2.1\npasslib==1.6\npeewee==0.9.9\nwsgiref==0.1.2\n```\n", "It appears peewee is setting it to an empty string when no value is present (as opposed to letting it fall through to the database and raising an integrity error). This is probably a bug...working on a test case\n", "Hrm... I'm torn on this one. Looking a little closer, it appears that Field() is wrapping up the value passed to the db. It has the following check:\n\n``` python\n\n def db_value(self, value):\n if (self.null and value is None):\n return None\n return self.column.db_value(value)\n```\n\nThe column converts the value to a suitable type, e.g. VarCharColumn does `unicode(value or '')`.\n\nI'm thinking that this behavior is acceptable. The best I can say is its a gray area. If you want to store NULLs then make the field nullable, otherwise an empty string (or \"0\", etc) will be put in to avoid the integrity error.\n", "Then could we get a required attribute at some point? If I'm using the shell as my admin interface during development, I could easily pollute my DB with inconsistent data.\n", "Grr... i keep waffling on this.\n\nI think that the only acceptable answer is to allow NULL values to get sent back regardless, and let the integrity error happen if the field isn't null. Working on a testcase and a patch.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/100/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jonatanfan", "id": 1277652, "node_id": "MDQ6VXNlcjEyNzc2NTI=", "avatar_url": "https://avatars.githubusercontent.com/u/1277652?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonatanfan", "html_url": "https://github.com/jonatanfan", "followers_url": "https://api.github.com/users/jonatanfan/followers", "following_url": "https://api.github.com/users/jonatanfan/following{/other_user}", "gists_url": "https://api.github.com/users/jonatanfan/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonatanfan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonatanfan/subscriptions", "organizations_url": "https://api.github.com/users/jonatanfan/orgs", "repos_url": "https://api.github.com/users/jonatanfan/repos", "events_url": "https://api.github.com/users/jonatanfan/events{/privacy}", "received_events_url": "https://api.github.com/users/jonatanfan/received_events", "type": "User", "site_admin": false }

[]

[]

[ "dupe of #98\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/99/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jonatanfan", "id": 1277652, "node_id": "MDQ6VXNlcjEyNzc2NTI=", "avatar_url": "https://avatars.githubusercontent.com/u/1277652?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonatanfan", "html_url": "https://github.com/jonatanfan", "followers_url": "https://api.github.com/users/jonatanfan/followers", "following_url": "https://api.github.com/users/jonatanfan/following{/other_user}", "gists_url": "https://api.github.com/users/jonatanfan/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonatanfan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonatanfan/subscriptions", "organizations_url": "https://api.github.com/users/jonatanfan/orgs", "repos_url": "https://api.github.com/users/jonatanfan/repos", "events_url": "https://api.github.com/users/jonatanfan/events{/privacy}", "received_events_url": "https://api.github.com/users/jonatanfan/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/98/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "edavis", "id": 622509, "node_id": "MDQ6VXNlcjYyMjUwOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/622509?v=4", "gravatar_id": "", "url": "https://api.github.com/users/edavis", "html_url": "https://github.com/edavis", "followers_url": "https://api.github.com/users/edavis/followers", "following_url": "https://api.github.com/users/edavis/following{/other_user}", "gists_url": "https://api.github.com/users/edavis/gists{/gist_id}", "starred_url": "https://api.github.com/users/edavis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/edavis/subscriptions", "organizations_url": "https://api.github.com/users/edavis/orgs", "repos_url": "https://api.github.com/users/edavis/repos", "events_url": "https://api.github.com/users/edavis/events{/privacy}", "received_events_url": "https://api.github.com/users/edavis/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Good looking out!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/97/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/97", "html_url": "https://github.com/coleifer/peewee/pull/97", "diff_url": "https://github.com/coleifer/peewee/pull/97.diff", "patch_url": "https://github.com/coleifer/peewee/pull/97.patch", "merged_at": "2012-07-02T03:29:09" }

{ "login": "karlb", "id": 144773, "node_id": "MDQ6VXNlcjE0NDc3Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/144773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karlb", "html_url": "https://github.com/karlb", "followers_url": "https://api.github.com/users/karlb/followers", "following_url": "https://api.github.com/users/karlb/following{/other_user}", "gists_url": "https://api.github.com/users/karlb/gists{/gist_id}", "starred_url": "https://api.github.com/users/karlb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karlb/subscriptions", "organizations_url": "https://api.github.com/users/karlb/orgs", "repos_url": "https://api.github.com/users/karlb/repos", "events_url": "https://api.github.com/users/karlb/events{/privacy}", "received_events_url": "https://api.github.com/users/karlb/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I can call db.get_cursor().executemany, of course. It just expected executemany to be usable whereever execute can be used. So this is not important at all.\n", "Yeah, I have not implemented executemany or executescript. Many of the db-api 2.0 methods, while used internally, are not exposed -- this is intentional. If you do need them, you can do like you've suggested, get a cursor.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/96/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "cevarief", "id": 850737, "node_id": "MDQ6VXNlcjg1MDczNw==", "avatar_url": "https://avatars.githubusercontent.com/u/850737?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cevarief", "html_url": "https://github.com/cevarief", "followers_url": "https://api.github.com/users/cevarief/followers", "following_url": "https://api.github.com/users/cevarief/following{/other_user}", "gists_url": "https://api.github.com/users/cevarief/gists{/gist_id}", "starred_url": "https://api.github.com/users/cevarief/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cevarief/subscriptions", "organizations_url": "https://api.github.com/users/cevarief/orgs", "repos_url": "https://api.github.com/users/cevarief/repos", "events_url": "https://api.github.com/users/cevarief/events{/privacy}", "received_events_url": "https://api.github.com/users/cevarief/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I don't know much about firebird -- will have to look into it. Currently, peewee's internal db calls rely on the driver supporting the python db-api 2.0. It looks like kinterbasdb supports this, so integration should be really easy. I was thinking personally that the next driver i'd like to look at is [apsw](http://apidoc.apsw.googlecode.com/hg/index.html), which provides much richer support for sqlite than the sqlite3 driver (virtual tables, etc). If you want to see firebird, i'd suggest taking a crack at it yourself, the implementation should be simple - take a look at the code.\n\nYou will need to implement at the very least:\n- an adapter class, which handles connecting to the database (here is [mysql](https://github.com/coleifer/peewee/blob/master/peewee.py#L224))\n- a database class that uses the given adapter (here is [mysql](https://github.com/coleifer/peewee/blob/master/peewee.py#L537))\n\nIt is unlikely i'll be adding firebird support any time soon without learning a bit more about it and its advantages over, say, postgres mysql or sqlite which seem to run the gamut from prototype to large-scale production, but if you're inclined i'd be happy to merge in your changes if you write an implementation.\n", "I've written some docs on writing a database backend:\n\nhttp://peewee.readthedocs.org/en/latest/peewee/database.html#writing-a-database-driver\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/95/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "b1naryth1ef", "id": 599433, "node_id": "MDQ6VXNlcjU5OTQzMw==", "avatar_url": "https://avatars.githubusercontent.com/u/599433?v=4", "gravatar_id": "", "url": "https://api.github.com/users/b1naryth1ef", "html_url": "https://github.com/b1naryth1ef", "followers_url": "https://api.github.com/users/b1naryth1ef/followers", "following_url": "https://api.github.com/users/b1naryth1ef/following{/other_user}", "gists_url": "https://api.github.com/users/b1naryth1ef/gists{/gist_id}", "starred_url": "https://api.github.com/users/b1naryth1ef/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/b1naryth1ef/subscriptions", "organizations_url": "https://api.github.com/users/b1naryth1ef/orgs", "repos_url": "https://api.github.com/users/b1naryth1ef/repos", "events_url": "https://api.github.com/users/b1naryth1ef/events{/privacy}", "received_events_url": "https://api.github.com/users/b1naryth1ef/received_events", "type": "User", "site_admin": false }

[]

[]

[ "How does this come about? How is it being passed in via connect_kwargs?\n", "Hmm, i'm kind of baffled -- where is \"self.threadlocals\" referenced? In my code it appears that it is just used in the scope of the init method, where the `__local` is instantiated. Can you explain more the rationale?\n", "I was consistently having problems with starting an sqlite instance, and giving it the threadlocals var. Tested on both 2.6/2.7 and few os's. Looked into it, and it seems threadlocals wasnt actually being passed in under the threadlocals kwarg, but rather inside the *\\* catch all. Again, this isnt really a proper fix to it. \n", "Ahhh never mind, I see. The `self.` isnt required. This was more of a fix of threadlocals not being passed correctly.\n", "can you please send me your code that was not working properly so i can test it here? i've not encountered this problem myself.\n", "```\nfrom peewee import *\nimport thread\n\ndb = SqliteDatabase('test', threadlocals=True)\ndb.connect()\n\nclass Test():\n uid = IntegerField()\n\nTest.create_table()\n\nt = Test(1)\nt.save()\n\nq = lambda: [i for i in Test.select().where(uid=1)\n\nthread.start_new_thread(q, ())\n```\n\nSomething like that.\n", "Sorry but that code has a number of problems. you're not specifying your database when you define your model. your model doesn't subclass Model. I'm also not clear on how that demonstrates the actual issue.\n", "Sorry wrote that on the fly. This code gives the error:\n\n```\nfrom peewee import *\nimport thread\n\ndb = SqliteDatabase('test.db', threadlocals=True)\ndb.connect()\n\nclass Test(model):\n uid = IntegerField()\n\nTest.create_table()\n\nt = Test(uid=1)\nt.save()\n\ndef testQuery():\n print [i for i in Test.select().where(uid=1)]\n\nthread.start_new_thread(testQuery, ())\n```\n\nThe example outputs this on both a Mac laptop and Linux box:\n\n```\n-1214440592\nUnhandled exception in thread started by <function testing at 0xb7bffbfc>\nTraceback (most recent call last):\n File \"<stdin>\", line 2, in testing\n File \"/usr/local/lib/python2.6/dist-packages/peewee-0.9.7-py2.6.egg/peewee.py\", line 1646, in __iter__\n return iter(self.execute())\n File \"/usr/local/lib/python2.6/dist-packages/peewee-0.9.7-py2.6.egg/peewee.py\", line 1638, in execute\n self._qr = QueryResultWrapper(self.model, self.raw_execute(sql, params), meta)\n File \"/usr/local/lib/python2.6/dist-packages/peewee-0.9.7-py2.6.egg/peewee.py\", line 1287, in raw_execute\n return self.database.execute(query, params, self.require_commit)\n File \"/usr/local/lib/python2.6/dist-packages/peewee-0.9.7-py2.6.egg/peewee.py\", line 322, in execute\n cursor = self.get_cursor()\n File \"/usr/local/lib/python2.6/dist-packages/peewee-0.9.7-py2.6.egg/peewee.py\", line 319, in get_cursor\n return self.get_conn().cursor()\nsqlite3.ProgrammingError: SQLite objects created in a thread can only be used in that same thread.The object was created in thread id -1211824448 and this is thread id -1214440592\n```\n\nThe problem is passing threadlocals into peewees Database class, as I mentioned a few comments above.\n", "You need to tell peewee to use the database you instantiated:\n\n``` python\n\nclass Test(model):\n uid = IntegerField()\n\n class Meta:\n database = db\n```\n", "And now I fell silly! My only note is that this is a just little unclear/ambiguous in the docs. Might consider moving the `Best Practices` up a bit, or make it more clear that its important/required. Thanks much for your help!\n", "No sweat, mane -- i'll spruce up the docs. This works fine for me, btw:\n\n``` python\n\nfrom peewee import *\nimport threading\n\ndb = SqliteDatabase('test.db', threadlocals=True)\ndb.connect()\n\nclass Test(Model):\n uid = IntegerField()\n class Meta:\n database=db\n\nTest.create_table(True)\n\nt = Test(uid=1)\nt.save()\n\ndef testQuery():\n print [i for i in Test.select().where(uid=1)]\n\nt = threading.Thread(target=testQuery)\nt.start()\nt.join()\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/94/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/94", "html_url": "https://github.com/coleifer/peewee/pull/94", "diff_url": "https://github.com/coleifer/peewee/pull/94.diff", "patch_url": "https://github.com/coleifer/peewee/pull/94.patch", "merged_at": null }

{ "login": "ddorian", "id": 1592898, "node_id": "MDQ6VXNlcjE1OTI4OTg=", "avatar_url": "https://avatars.githubusercontent.com/u/1592898?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddorian", "html_url": "https://github.com/ddorian", "followers_url": "https://api.github.com/users/ddorian/followers", "following_url": "https://api.github.com/users/ddorian/following{/other_user}", "gists_url": "https://api.github.com/users/ddorian/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddorian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddorian/subscriptions", "organizations_url": "https://api.github.com/users/ddorian/orgs", "repos_url": "https://api.github.com/users/ddorian/repos", "events_url": "https://api.github.com/users/ddorian/events{/privacy}", "received_events_url": "https://api.github.com/users/ddorian/received_events", "type": "User", "site_admin": false }

[]

[]

[ "i'm on the fence about this, should they be implemented as a check constraint or solely in python? if you assign something that is an invalid choice, should it error out? if so, what type of error?\n", "i checked django, it seems you can assign invalid values to a field that specifies `choices`. you can also save these invalid choices. probably just for modelform validation. so, options:\n- db-level check constraint -- bad because if you want to change your choices that means schema change\n- python-level on save\n- python-level on assignment\n- none at all, just for metadata and other libraries (flask-peewee, wtf-peewee)\n\nI'm leaning towards none at all, same as django.\n", "Maybe it should output a warning in DEBUG mode\n", "I've added this in commit 2d076f069baf715d6dfd0070df861f0b3f417724\n\nI've also added integration in the wtf-peewee bindings (wtforms form library integration)\nhttps://github.com/coleifer/wtf-peewee/commits/master\n\nI've also added a small example to the flask-peewee app:\nhttps://github.com/coleifer/flask-peewee/commit/225f85d68fe39c0271b7a1a00b55ede1ede7f41f\n\nFinally, there's no debug mode per se with peewee, so there's no warning\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/93/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rouge8", "id": 237005, "node_id": "MDQ6VXNlcjIzNzAwNQ==", "avatar_url": "https://avatars.githubusercontent.com/u/237005?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rouge8", "html_url": "https://github.com/rouge8", "followers_url": "https://api.github.com/users/rouge8/followers", "following_url": "https://api.github.com/users/rouge8/following{/other_user}", "gists_url": "https://api.github.com/users/rouge8/gists{/gist_id}", "starred_url": "https://api.github.com/users/rouge8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rouge8/subscriptions", "organizations_url": "https://api.github.com/users/rouge8/orgs", "repos_url": "https://api.github.com/users/rouge8/repos", "events_url": "https://api.github.com/users/rouge8/events{/privacy}", "received_events_url": "https://api.github.com/users/rouge8/received_events", "type": "User", "site_admin": false }

[]

[]

[ "thanks for catching this, i pushed a new version 0.9.7 and a new git tag.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/92/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "applegrew", "id": 434574, "node_id": "MDQ6VXNlcjQzNDU3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/434574?v=4", "gravatar_id": "", "url": "https://api.github.com/users/applegrew", "html_url": "https://github.com/applegrew", "followers_url": "https://api.github.com/users/applegrew/followers", "following_url": "https://api.github.com/users/applegrew/following{/other_user}", "gists_url": "https://api.github.com/users/applegrew/gists{/gist_id}", "starred_url": "https://api.github.com/users/applegrew/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/applegrew/subscriptions", "organizations_url": "https://api.github.com/users/applegrew/orgs", "repos_url": "https://api.github.com/users/applegrew/repos", "events_url": "https://api.github.com/users/applegrew/events{/privacy}", "received_events_url": "https://api.github.com/users/applegrew/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Not sure on the application of the float option, since there's a floatfield already. As far as rounding, I suppose that would be handled by the DB when you specify a precision on the column, but this might need to be looked into a little more.\n", "- Yes there is `FloatField` but it does not allow us to define number of decimals I need, (e.g. only two for currencies). Because of dynamic nature of Python it is difficult to work with codes where there is a possibility of mixing `float` data with the `Decimal` ones. So, it is important to normalize them to one type - maybe float. Well now I agree that in such a scenario it would indicate a design issue or there should be central point where the code should convert the `Decimal` returned to `float`, but then again I don't see anyway to implement custom getters and setters in Peewee `Model` to do it centrally. I will leave this open to your good judgement.\n- DBs are responsible to accurately store the data, so if any data passed to it needs to be rounded which will result in loss of precision then it is going to throw a warning. This can happen when our `Decimal` has more decimals, or if we pass a `float`. Storing `23.221` in a `Decimal(5,2)` column in MySql throws 'Error 1265: Data truncation' warning, and I don't see any way to turn this off in DB. Even this warning is treated as error in Peewee, disrupting normal flow. By specifying `decimal_places` user has already consented with fact that he wants only that many decimals. Peewee already has enough information to lend user this helping hand. I really do not like warnings in my code. Now it can be argued that some users might want to warned about this loss. That is why I have added the `auto_round` flag to let user turn this behavior on or off. In fact it is off by default so that Peewee's current behavior do not change.\n", "Added in 4c3af4ccc83dad38a369a1b8e3121de1d6838a7b -- thanks for the help!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/91/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/91", "html_url": "https://github.com/coleifer/peewee/pull/91", "diff_url": "https://github.com/coleifer/peewee/pull/91.diff", "patch_url": "https://github.com/coleifer/peewee/pull/91.patch", "merged_at": null }

{ "login": "sdobz", "id": 948178, "node_id": "MDQ6VXNlcjk0ODE3OA==", "avatar_url": "https://avatars.githubusercontent.com/u/948178?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sdobz", "html_url": "https://github.com/sdobz", "followers_url": "https://api.github.com/users/sdobz/followers", "following_url": "https://api.github.com/users/sdobz/following{/other_user}", "gists_url": "https://api.github.com/users/sdobz/gists{/gist_id}", "starred_url": "https://api.github.com/users/sdobz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sdobz/subscriptions", "organizations_url": "https://api.github.com/users/sdobz/orgs", "repos_url": "https://api.github.com/users/sdobz/repos", "events_url": "https://api.github.com/users/sdobz/events{/privacy}", "received_events_url": "https://api.github.com/users/sdobz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks so much for the excellent bug report, I've added a fix and a testcase.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/90/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coderbuzz", "id": 1284811, "node_id": "MDQ6VXNlcjEyODQ4MTE=", "avatar_url": "https://avatars.githubusercontent.com/u/1284811?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderbuzz", "html_url": "https://github.com/coderbuzz", "followers_url": "https://api.github.com/users/coderbuzz/followers", "following_url": "https://api.github.com/users/coderbuzz/following{/other_user}", "gists_url": "https://api.github.com/users/coderbuzz/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderbuzz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderbuzz/subscriptions", "organizations_url": "https://api.github.com/users/coderbuzz/orgs", "repos_url": "https://api.github.com/users/coderbuzz/repos", "events_url": "https://api.github.com/users/coderbuzz/events{/privacy}", "received_events_url": "https://api.github.com/users/coderbuzz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is correct, calling a model's save method will wholesale update the row in the database with the field data present on the model instance **at the time of saving**. item2 will not automatically receive changes made to item1, since they are separate instances. This is intended behavior.\n\nIf you want to only update a single column, use `update`:\n\n``` python\n\nItemModel.update(other_field=item2.other_field).where(id=item2.id).execute()\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/89/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "maiksprenger", "id": 509427, "node_id": "MDQ6VXNlcjUwOTQyNw==", "avatar_url": "https://avatars.githubusercontent.com/u/509427?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maiksprenger", "html_url": "https://github.com/maiksprenger", "followers_url": "https://api.github.com/users/maiksprenger/followers", "following_url": "https://api.github.com/users/maiksprenger/following{/other_user}", "gists_url": "https://api.github.com/users/maiksprenger/gists{/gist_id}", "starred_url": "https://api.github.com/users/maiksprenger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maiksprenger/subscriptions", "organizations_url": "https://api.github.com/users/maiksprenger/orgs", "repos_url": "https://api.github.com/users/maiksprenger/repos", "events_url": "https://api.github.com/users/maiksprenger/events{/privacy}", "received_events_url": "https://api.github.com/users/maiksprenger/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/88/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/88", "html_url": "https://github.com/coleifer/peewee/pull/88", "diff_url": "https://github.com/coleifer/peewee/pull/88.diff", "patch_url": "https://github.com/coleifer/peewee/pull/88.patch", "merged_at": null }

{ "login": "maiksprenger", "id": 509427, "node_id": "MDQ6VXNlcjUwOTQyNw==", "avatar_url": "https://avatars.githubusercontent.com/u/509427?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maiksprenger", "html_url": "https://github.com/maiksprenger", "followers_url": "https://api.github.com/users/maiksprenger/followers", "following_url": "https://api.github.com/users/maiksprenger/following{/other_user}", "gists_url": "https://api.github.com/users/maiksprenger/gists{/gist_id}", "starred_url": "https://api.github.com/users/maiksprenger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maiksprenger/subscriptions", "organizations_url": "https://api.github.com/users/maiksprenger/orgs", "repos_url": "https://api.github.com/users/maiksprenger/repos", "events_url": "https://api.github.com/users/maiksprenger/events{/privacy}", "received_events_url": "https://api.github.com/users/maiksprenger/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/87/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "wtld", "id": 1318746, "node_id": "MDQ6VXNlcjEzMTg3NDY=", "avatar_url": "https://avatars.githubusercontent.com/u/1318746?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wtld", "html_url": "https://github.com/wtld", "followers_url": "https://api.github.com/users/wtld/followers", "following_url": "https://api.github.com/users/wtld/following{/other_user}", "gists_url": "https://api.github.com/users/wtld/gists{/gist_id}", "starred_url": "https://api.github.com/users/wtld/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wtld/subscriptions", "organizations_url": "https://api.github.com/users/wtld/orgs", "repos_url": "https://api.github.com/users/wtld/repos", "events_url": "https://api.github.com/users/wtld/events{/privacy}", "received_events_url": "https://api.github.com/users/wtld/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/86/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "redapple", "id": 886296, "node_id": "MDQ6VXNlcjg4NjI5Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/886296?v=4", "gravatar_id": "", "url": "https://api.github.com/users/redapple", "html_url": "https://github.com/redapple", "followers_url": "https://api.github.com/users/redapple/followers", "following_url": "https://api.github.com/users/redapple/following{/other_user}", "gists_url": "https://api.github.com/users/redapple/gists{/gist_id}", "starred_url": "https://api.github.com/users/redapple/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/redapple/subscriptions", "organizations_url": "https://api.github.com/users/redapple/orgs", "repos_url": "https://api.github.com/users/redapple/repos", "events_url": "https://api.github.com/users/redapple/events{/privacy}", "received_events_url": "https://api.github.com/users/redapple/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I ran w/some of your ideas and have added functionality for switching search path and specifying schema when introspecting:\n\nbc465f467d0f3ccbf03c1b49ea2b2ecb04c0c765\n963cfe41c9af773be934e36fb5e3a17eaeb85ff6\n", "Cool.\nI'll continue learning peewee.\nCheers,\nPaul.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/85/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/85", "html_url": "https://github.com/coleifer/peewee/pull/85", "diff_url": "https://github.com/coleifer/peewee/pull/85.diff", "patch_url": "https://github.com/coleifer/peewee/pull/85.patch", "merged_at": null }

{ "login": "tmoertel", "id": 21773, "node_id": "MDQ6VXNlcjIxNzcz", "avatar_url": "https://avatars.githubusercontent.com/u/21773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tmoertel", "html_url": "https://github.com/tmoertel", "followers_url": "https://api.github.com/users/tmoertel/followers", "following_url": "https://api.github.com/users/tmoertel/following{/other_user}", "gists_url": "https://api.github.com/users/tmoertel/gists{/gist_id}", "starred_url": "https://api.github.com/users/tmoertel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tmoertel/subscriptions", "organizations_url": "https://api.github.com/users/tmoertel/orgs", "repos_url": "https://api.github.com/users/tmoertel/repos", "events_url": "https://api.github.com/users/tmoertel/events{/privacy}", "received_events_url": "https://api.github.com/users/tmoertel/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Wow, this is pretty interesting stuff. I'm a little bit grossed out by inspecting stack frames, I wonder if it might make sense to use the model metaclass to track subclasses or something explicit even. Not sure about merging yet, i've been playing with a branch features/extras where i've added a support for \"signals\" a-la django, and this might be a good thing to add there. Perhaps a module named 'discover.py' and a model subclass that can track subclasses somehow, then the utilities can live there.\n", "Thanks for the feedback.\n\nYeah, the part of the code I'm least happy with is the stack-inspection stuff. Alternatives:\n1. Always require the caller to supply a module to scan, eliminating the need to detect the caller's module.\n2. Change the interface to take not a module but any collection of objects, which is then filtered to return only the models within it. That way, you can find the models in the current module by passing `globals()` and in any other module by passing `vars(the_other_module)`:\n \n models1 = find_models(globals().items()) # current module\n models2 = find_models(vars(some_other_module).items())\n\nOf course, these API designs are based on the belief that people tend to organize their models within modules. If it turns out that something other than modules makes a more natural unit of organization, I probably ought to make the discovery API ask for that thing instead. \n\nAnd maybe _base model_ is that more natural thing. If so, I can modify the discovery logic to take a base model:\n\n```\nmodels = discover_submodels(BaseModel)\n```\n\nIf peewee already tracked the subclasses derived from a base model, I could use that knowledge for the discovery process. For now, however, I could just scan the base model's module for submodels. The discovery wouldn't cross module boundaries, but maybe it doesn't need to.\n\nWhat do you think about these alternative approaches?\n\nIn any case, I put the convenience methods for creating/dropping tables into separate commits so that they can be used independently of the discovery logic. Do you have any interest in those methods?\n", "I thought a bit more about what you wrote. Your idea of finding all the models derived from a base model seems pretty good, so I whipped up an implementation:`find_submodels`. I also renamed the module-based discovery method to `find_models_in_module` for parity and got rid of the stack-inspection logic.\n", "Any reason not to use `__subclasses__` and call it recursively?\n", "Nope, `__subclasses__` works just great. See most-recent commit for a revised `find_submodels` that uses it.\n\nI've made the exclusion semantics such that if you exclude a model, its descendants are also excluded. I'm not sure about this choice, however. I suspect that some people create base models in the middle of their model hierarchies for sharing purposes.\n", "I've added a generic function to find subclasses recursively: e6b199074023237d9c1bdeef5bb2b13d3b47fd13\n\nI've added your model sorting function: a43911fee25a15e6dd47f\n\nAnd lastly, the create/drop many: f8482d0728bcc6e\n\nThanks for suggesting these improvements!\n", "You're welcome! Thanks for peewee :-)\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/84/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/84", "html_url": "https://github.com/coleifer/peewee/pull/84", "diff_url": "https://github.com/coleifer/peewee/pull/84.diff", "patch_url": "https://github.com/coleifer/peewee/pull/84.patch", "merged_at": null }

{ "login": "maxekman", "id": 821518, "node_id": "MDQ6VXNlcjgyMTUxOA==", "avatar_url": "https://avatars.githubusercontent.com/u/821518?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maxekman", "html_url": "https://github.com/maxekman", "followers_url": "https://api.github.com/users/maxekman/followers", "following_url": "https://api.github.com/users/maxekman/following{/other_user}", "gists_url": "https://api.github.com/users/maxekman/gists{/gist_id}", "starred_url": "https://api.github.com/users/maxekman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maxekman/subscriptions", "organizations_url": "https://api.github.com/users/maxekman/orgs", "repos_url": "https://api.github.com/users/maxekman/repos", "events_url": "https://api.github.com/users/maxekman/events{/privacy}", "received_events_url": "https://api.github.com/users/maxekman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "First off, thanks for the suggestions -- I appreciate your interest in the project! This is a pretty nice API that django has, but i don't believe its something I'll add. The 'reverse relation' is exposed as a simple select query, and I think that is a good fit. The \"automatic\" filter is there on the select queyr, but i don't like adding an automatic attribute on creation or deletion. The code is not really much shorter, either:\n\n``` python\n\n# django-like api\nblog.entries.add(title='awesome post', content='lorem ipsum')\n\n# current api\nEntry.create(blog=blog, title='awesome post', content='lorem ipsum')\n```\n\nFor now, i'm going to pass on this one.\n", "Fair enough, I was not sure about it either, just read about it in the Django docs. Pretty cool though that the Django docs works somewhat for your project as well.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/83/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "maxekman", "id": 821518, "node_id": "MDQ6VXNlcjgyMTUxOA==", "avatar_url": "https://avatars.githubusercontent.com/u/821518?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maxekman", "html_url": "https://github.com/maxekman", "followers_url": "https://api.github.com/users/maxekman/followers", "following_url": "https://api.github.com/users/maxekman/following{/other_user}", "gists_url": "https://api.github.com/users/maxekman/gists{/gist_id}", "starred_url": "https://api.github.com/users/maxekman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maxekman/subscriptions", "organizations_url": "https://api.github.com/users/maxekman/orgs", "repos_url": "https://api.github.com/users/maxekman/repos", "events_url": "https://api.github.com/users/maxekman/events{/privacy}", "received_events_url": "https://api.github.com/users/maxekman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm on the fence about this...feel like the signals should be able to exist at the application level as opposed to the database level.\n", "Sure, as I see it they should be on each model, that's how I was imagining to use them.\n\nI my FSM case I would load the local in-memory FSM object after the model is loaded from the db, and I would imagine doing it on a post_init method of my actual model that have the FSM field.\n\nA naming convention would probably be the best option, for example having the above methods as abstract methods on peewee.Model and just override any of them you wish to use in your own models.\n\nAnother option is setting each callback you want to use on the class level in your model.\n", "Since save() and delete_instance() can easily be overridden and will do the right thing, I'll leave them as-is. I have added a hook on the model instance named `prepared` which will be called when the row is ready and has received data from the db cursor. You can now write:\n\n``` python\n\nclass FSM(Model):\n state = CharField()\n\n def prepared(self):\n self.do_something_with_state()\n```\n\nThis will be called when a model is populated from the db, whether called by\n- select\n- filter\n- get\n\nIt will not be called when \"related\" models are selected, though, for instance\n\n``` python\n\nfor entry in Entry.select({Entry: '*', Blog: '*'}):\n # entry will be prepared, but entry.blog will not\n pass\n```\n", "Cool, will try it out!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/82/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "maxekman", "id": 821518, "node_id": "MDQ6VXNlcjgyMTUxOA==", "avatar_url": "https://avatars.githubusercontent.com/u/821518?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maxekman", "html_url": "https://github.com/maxekman", "followers_url": "https://api.github.com/users/maxekman/followers", "following_url": "https://api.github.com/users/maxekman/following{/other_user}", "gists_url": "https://api.github.com/users/maxekman/gists{/gist_id}", "starred_url": "https://api.github.com/users/maxekman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maxekman/subscriptions", "organizations_url": "https://api.github.com/users/maxekman/orgs", "repos_url": "https://api.github.com/users/maxekman/repos", "events_url": "https://api.github.com/users/maxekman/events{/privacy}", "received_events_url": "https://api.github.com/users/maxekman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I think I know what causes the \"running more times than there are items in the container\" problem. See [this comment from earlier today](https://github.com/coleifer/peewee/issues/12#issuecomment-5614404) on a related issue for the details.\n", "@tmoertel nailed it in that comment. Basically, there are a couple workarounds -- you found one, which is to consume the cursor first storing the models in memory.\n\n``` python\n\nfor item in list(a_container.items):\n Other.create(name = item.name, container = a_container)\n```\n\nAnother possibility is to use transactions:\n\n``` python\n\ndb = SqliteDatabase(':memory:')\n\[email protected]_on_success\ndef create_others(a_container):\n for item in a_container.items:\n Other.create(name = item.name, container = a_container)\n```\n\nOr do it by hand...\n\n``` python\n\ndb.set_autocommit(False)\nfor item in a_container.items:\n Other.create(name = item.name, container = a_container)\ndb.commit()\ndb.set_autocommit(True)\n```\n\nOr you can turn autocommit off and do everything by hand:\n\n``` python\n\ndb = SqliteDatabase(':memory:', autocommit=False)\n\n# model definitions, etc\n\nfor item in a_container.items:\n Other.create(name = item.name, container = a_container)\ndb.commit()\n```\n", "Thanks for all the help!\n", "Is it possible by the way to create a transaction syntax using the \"with\" statement? That could be a really neat way to handle it, and you wouldn't need a function as with the decorator.\n\nHere is something similar: http://blog.gramant.com/2011/04/29/python-transactions-with-statement/\n\nThoughts?\n", "Great idea, added it: https://github.com/coleifer/peewee/blob/master/tests.py#L3376\n", "I've added some docs on working with transactions, http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#working-with-transactions\n", "That's excellent! Really quick feedback.\n", "I have tried this now and it's a really nice syntax addition!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/81/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "davidthewatson", "id": 150892, "node_id": "MDQ6VXNlcjE1MDg5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/150892?v=4", "gravatar_id": "", "url": "https://api.github.com/users/davidthewatson", "html_url": "https://github.com/davidthewatson", "followers_url": "https://api.github.com/users/davidthewatson/followers", "following_url": "https://api.github.com/users/davidthewatson/following{/other_user}", "gists_url": "https://api.github.com/users/davidthewatson/gists{/gist_id}", "starred_url": "https://api.github.com/users/davidthewatson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davidthewatson/subscriptions", "organizations_url": "https://api.github.com/users/davidthewatson/orgs", "repos_url": "https://api.github.com/users/davidthewatson/repos", "events_url": "https://api.github.com/users/davidthewatson/events{/privacy}", "received_events_url": "https://api.github.com/users/davidthewatson/received_events", "type": "User", "site_admin": false }

[]

[]

[ "What is the db_now() function? btw, i truncated your stacktrace, there were hundreds of lines of dupe data.\n", "I should add that I do not experience this problem locally and the test suite is passing. Have you tried running the example app that ships w/flask-peewee and do you observe the same thing?\n", "Hmm, another consideration -- do you have another model which foreign keys to `Pool` and specifies a `related_name`? The reason I ask is that the `__get__()` is a method on the `ReverseForeignRelatedObject`...the only reason I can think that it would be called when doing the `get_field_dict()` is if its name collided with an existing field name. Can you do some interactive debugging and find out what field is causing the recursion? That might help.\n", "Yep, that's it. I had two models that specified related_name='id' which is obviously stupid. I just didn't see how that was going to manifest at runtime and that its effect was catastrophic. Thanks for your help.\n", "Glad it fixed it -- yes, related_name is used for the back-side of a foreign key, so 0..n related models. Typically they are expressed as a plural, i.e. `for message in user.messages:` Where Message has a Foreign key to user that looks like `user = ForeignKeyField(User, related_name='messages')`\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/80/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "maxekman", "id": 821518, "node_id": "MDQ6VXNlcjgyMTUxOA==", "avatar_url": "https://avatars.githubusercontent.com/u/821518?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maxekman", "html_url": "https://github.com/maxekman", "followers_url": "https://api.github.com/users/maxekman/followers", "following_url": "https://api.github.com/users/maxekman/following{/other_user}", "gists_url": "https://api.github.com/users/maxekman/gists{/gist_id}", "starred_url": "https://api.github.com/users/maxekman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maxekman/subscriptions", "organizations_url": "https://api.github.com/users/maxekman/orgs", "repos_url": "https://api.github.com/users/maxekman/repos", "events_url": "https://api.github.com/users/maxekman/events{/privacy}", "received_events_url": "https://api.github.com/users/maxekman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I've been thinking about how to fix this... I'm going to assume that a model is \"actually used\" whenever the db connection is either explicitly or implicitly opened. If that's the case, then it really isn't a problem to structure your code such that you modify the underlying db connection on-the-fly. The most important thing is that you don't want a bunch of `Database` instances running around, since each will open its own connection to the server -- in other words, there should be only one `Database` for each database you intend to connect to.\n\nWhat I think I'll do is allow a user to set a db to \"deferred\" when initializing, then if you attempt to connect to the db (either by explicitly calling connect() or by trying to issue a query) it will raise an exception if the db hasn't been properly initialized.\n", "If readthedocs ever updates, you can find docs here http://readthedocs.org/docs/peewee/en/latest/peewee/cookbook.html#deferring-initialization -- the basic idea is passing `None` as the db name will mark the db as deferred and an exception will be raised if you try and use it. You can then properly init the db by calling `db.init()`:\n\n``` python\n\n>>> db = SqliteDatabase(None)\n>>> db.deferred\nTrue\n\n>>> db.connect()\nException raised\n\n>>> db.init(':memory:')\n>>> db.connect()\n```\n", "Very nice, I'll give this a try later. Is it published to pypi yet?\n", "Just pushed a new version, 0.9.6 -- let me know how it works out!\n", "This works perfectly!\n\nThe new best practice is probably to use a uninitialized db in the base model:\n\n``` python\nclass BaseModel(peewee.Model):\n class Meta:\n database = peewee.SqliteDatabase(None)\n```\n\nAnd later init it:\n\n``` python\nBaseModel.Meta.database.init('db.sqlite')\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/79/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "DDevine", "id": 913394, "node_id": "MDQ6VXNlcjkxMzM5NA==", "avatar_url": "https://avatars.githubusercontent.com/u/913394?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DDevine", "html_url": "https://github.com/DDevine", "followers_url": "https://api.github.com/users/DDevine/followers", "following_url": "https://api.github.com/users/DDevine/following{/other_user}", "gists_url": "https://api.github.com/users/DDevine/gists{/gist_id}", "starred_url": "https://api.github.com/users/DDevine/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DDevine/subscriptions", "organizations_url": "https://api.github.com/users/DDevine/orgs", "repos_url": "https://api.github.com/users/DDevine/repos", "events_url": "https://api.github.com/users/DDevine/events{/privacy}", "received_events_url": "https://api.github.com/users/DDevine/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This sounds like a configuration issue. Please refer to the docs here:\n\nhttp://peewee.readthedocs.org/en/latest/peewee/cookbook.html#creating-a-database-connection-and-tables\n\n``` python\n\ndb = SqliteDatabase('database.db')\n\nclass Entry(Model):\n # foo bar baz\n\n class Meta:\n database = db # <--- I bet you're missing this\n```\n", "I bet you're right. Sorry!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/78/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rouge8", "id": 237005, "node_id": "MDQ6VXNlcjIzNzAwNQ==", "avatar_url": "https://avatars.githubusercontent.com/u/237005?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rouge8", "html_url": "https://github.com/rouge8", "followers_url": "https://api.github.com/users/rouge8/followers", "following_url": "https://api.github.com/users/rouge8/following{/other_user}", "gists_url": "https://api.github.com/users/rouge8/gists{/gist_id}", "starred_url": "https://api.github.com/users/rouge8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rouge8/subscriptions", "organizations_url": "https://api.github.com/users/rouge8/orgs", "repos_url": "https://api.github.com/users/rouge8/repos", "events_url": "https://api.github.com/users/rouge8/events{/privacy}", "received_events_url": "https://api.github.com/users/rouge8/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/77/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/77", "html_url": "https://github.com/coleifer/peewee/pull/77", "diff_url": "https://github.com/coleifer/peewee/pull/77.diff", "patch_url": "https://github.com/coleifer/peewee/pull/77.patch", "merged_at": "2012-04-25T17:11:44" }

{ "login": "huaitwooos", "id": 1182693, "node_id": "MDQ6VXNlcjExODI2OTM=", "avatar_url": "https://avatars.githubusercontent.com/u/1182693?v=4", "gravatar_id": "", "url": "https://api.github.com/users/huaitwooos", "html_url": "https://github.com/huaitwooos", "followers_url": "https://api.github.com/users/huaitwooos/followers", "following_url": "https://api.github.com/users/huaitwooos/following{/other_user}", "gists_url": "https://api.github.com/users/huaitwooos/gists{/gist_id}", "starred_url": "https://api.github.com/users/huaitwooos/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/huaitwooos/subscriptions", "organizations_url": "https://api.github.com/users/huaitwooos/orgs", "repos_url": "https://api.github.com/users/huaitwooos/repos", "events_url": "https://api.github.com/users/huaitwooos/events{/privacy}", "received_events_url": "https://api.github.com/users/huaitwooos/received_events", "type": "User", "site_admin": false }

[]

[]

[ "updated formatting\n", "I'm not quite clear on what is throwing that error, can you provide a little more information?\n", "if i delete[ , microsecond=usec], the error will goto line 1994.\n\n<pre>\nTraceback (most recent call last):\n File \"C:\\Download\\dev\\peewee-0.9.4\\a.py\", line 1, in <module>\n import peewee\n File \"C:\\Download\\dev\\peewee-0.9.4\\peewee.py\", line 1994\n return datetime.time(*time.strptime(value, '%H:%M:%S')[3:6], microsecond=usec)\n ^\nSyntaxError: invalid syntax\n</pre>\n", "So it sounds like windows python2.5 doesn't like microsecond? I did a quick google and didn't find anything that jumped out at me.\n", "JUST has ERROR ON PYTHON2.5.4. it's OK on Python2.7+windows.\n\nI found two way to solve the problem on python 2.5.4:\n- put microsencond keyword before the time.time.strptime(...):\n <pre>\n return datetime.datetime(microsecond=usec,*time.strptime('2011-2-3 12:23:34', '%Y-%m-%d %H:%M:%S')[:6])\n </pre>\n- use a dict ref:\n <pre>\n return datetime.datetime(*_time.strptime('2011-2-3 12:23:34', '%Y-%m-%d %H:%M:%S')[:6], *_*{'microsecond':usec})\n </pre>\n", "Fixed in 41de298683da7397b875597573a22a6683e19a6e -- thanks for the suggestions and for reporting the issue\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/76/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Alquimista", "id": 185971, "node_id": "MDQ6VXNlcjE4NTk3MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/185971?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Alquimista", "html_url": "https://github.com/Alquimista", "followers_url": "https://api.github.com/users/Alquimista/followers", "following_url": "https://api.github.com/users/Alquimista/following{/other_user}", "gists_url": "https://api.github.com/users/Alquimista/gists{/gist_id}", "starred_url": "https://api.github.com/users/Alquimista/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Alquimista/subscriptions", "organizations_url": "https://api.github.com/users/Alquimista/orgs", "repos_url": "https://api.github.com/users/Alquimista/repos", "events_url": "https://api.github.com/users/Alquimista/events{/privacy}", "received_events_url": "https://api.github.com/users/Alquimista/received_events", "type": "User", "site_admin": false }

[]

[]

[ "already fixed, thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/75/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/75", "html_url": "https://github.com/coleifer/peewee/pull/75", "diff_url": "https://github.com/coleifer/peewee/pull/75.diff", "patch_url": "https://github.com/coleifer/peewee/pull/75.patch", "merged_at": null }

{ "login": "Alquimista", "id": 185971, "node_id": "MDQ6VXNlcjE4NTk3MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/185971?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Alquimista", "html_url": "https://github.com/Alquimista", "followers_url": "https://api.github.com/users/Alquimista/followers", "following_url": "https://api.github.com/users/Alquimista/following{/other_user}", "gists_url": "https://api.github.com/users/Alquimista/gists{/gist_id}", "starred_url": "https://api.github.com/users/Alquimista/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Alquimista/subscriptions", "organizations_url": "https://api.github.com/users/Alquimista/orgs", "repos_url": "https://api.github.com/users/Alquimista/repos", "events_url": "https://api.github.com/users/Alquimista/events{/privacy}", "received_events_url": "https://api.github.com/users/Alquimista/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/74/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "prggmr", "id": 207314, "node_id": "MDQ6VXNlcjIwNzMxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/207314?v=4", "gravatar_id": "", "url": "https://api.github.com/users/prggmr", "html_url": "https://github.com/prggmr", "followers_url": "https://api.github.com/users/prggmr/followers", "following_url": "https://api.github.com/users/prggmr/following{/other_user}", "gists_url": "https://api.github.com/users/prggmr/gists{/gist_id}", "starred_url": "https://api.github.com/users/prggmr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/prggmr/subscriptions", "organizations_url": "https://api.github.com/users/prggmr/orgs", "repos_url": "https://api.github.com/users/prggmr/repos", "events_url": "https://api.github.com/users/prggmr/events{/privacy}", "received_events_url": "https://api.github.com/users/prggmr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "It definitely sounds like there's a problem somewhere. I'd like to know a little bit more before I set about trying to replicate -- what database engine were you using? Did you try dropping down to the db driver and issuing raw SQL queries, and if so did this fix the problem? Were you iterating over a large number of rows from the database?\n\nThanks for reporting, I'm eager to look into this.\n", "I was using MySQL (MySQLdb).\n\nDropping peewee and using the MySQLdb itself with plain SQL queries and no ORM interaction has solved the issue.\n\nAs for the database table size it slowly progressed regardless of table size but it ultimately failed when running on a table with ~8 million records with a total record set for the entire database being around ~12 million at the point of failure, with each record running at a minimum of 2 queries per record, a select and then an insert or update depending on if the record exists.\n\nFrom my previous experience the import would run roughly for 3 - 4 hours before consuming the servers entire memory of 4GB currently it is about to hit the 6 hour mark without using more than 0.3% of the servers memory which is the expected behavior.\n", "Thanks for the info. I'll see about doing some profiling.\n", "Initial results -- I am not able to replicate your issue. Using python2.7, MySQLdb, peewee 0.9.4. Wrote a little script using guppy to do memory profiling. It shows memory before starting querying after initial objects have been loaded up, then shows memory usage after every 100K iterations (it does not change). I was surprised by my results so I modified the script to add items to a dictionary in the loop and observed memory growing, so I know that its working right.\n\nHere's my script:\n\n``` python\nimport random\nfrom guppy import hpy\nfrom peewee import *\nfrom peewee import InsertQuery, UpdateQuery\n\n\ndb = MySQLDatabase('prof', user='root')\ndb.connect()\n\n\nclass TestModel(Model):\n data = CharField()\n\n class Meta:\n database = db\n\n\ndef main():\n TestModel.drop_table(True)\n TestModel.create_table()\n\n h = hpy()\n orig = num_records = 1000000\n every = 100000\n print 'Initial\\n========'\n print h.heap()\n print '\\n'\n\n while num_records:\n num_records -= 1\n data = str(random.randint(1, 100000))\n\n if TestModel.select().where(data=data).exists():\n InsertQuery(TestModel, data=data).execute()\n else:\n # this essential no-ops but we'll call update anyways\n UpdateQuery(TestModel, data=data).where(data=data).execute()\n\n if num_records % every == 0:\n print 'After %d records:\\n=================' % (orig - num_records)\n print h.heap()\n print '\\n\\n'\n #if raw_input('Continue? Yn ') == 'n':\n # break\n\nif __name__ == '__main__':\n main()\n```\n\nAnd here is a link to the output:\nhttps://gist.github.com/efadb58837aff2b64224\n\nCan you think of anything I'm missing here?\n", "Oh shit, realized I've got a bug... that first if block needs to be \"if not\" rather than \"if\". Will update after doing somemore testing.\n", "After changing it and about 100K records in still not seeing memory usage increasing.\n", "This may have already been addressed in a recent version since it can be something as simple as a missed circular reference somewhere ... once I get some time I will do some more analysis of everything and provide some more concrete data on the usage and a way to easily replicate if still possible.\n\nI'm using 0.7 or 0.8 I believe ... downloaded back at the end of January.\n", "Forgot to close this ... again thanks for looking into to it and since it seems to not exist in the current version I may just need to update ... if time allows ...\n", "@nwhitingx yeah I am guessing there was a circular reference somewhere....never got to the number of records you were experiencing failure at, but also didn't see a steady increase in RAM usage. please update the ticket or open a new one if updating your checkout doesn't fix.\n", "Did you have any luck with a newer version, or did you still run into memory issues?\n", "I have not had the time to upgrade and test the newer version as I'm completely swamped with work right now once I get some time this is on my TODO list as I'm very interested in finding where this leak was occurring.\n", "i have this problem too. I am using peewee 3.11.2 , PyMySQL 0.9.3 and python 3.6\r\ni have 20m records in my database so , to reduce ram usage, i query for 100k records each time. the problem is that records are the same and must have the same size but each query causes more ram usage than the previous one.(e.g. first query uses 100MB of ram but the 30th one uses 5GB)", "Without code it's impossible to help. There are many ways to profile your memory usage.\r\n\r\nBest recommendation is to use the `.iterator()` method of query to get a \"one-shot\" iterator that doesn't cache rows in memory." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/73/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "karlb", "id": 144773, "node_id": "MDQ6VXNlcjE0NDc3Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/144773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karlb", "html_url": "https://github.com/karlb", "followers_url": "https://api.github.com/users/karlb/followers", "following_url": "https://api.github.com/users/karlb/following{/other_user}", "gists_url": "https://api.github.com/users/karlb/gists{/gist_id}", "starred_url": "https://api.github.com/users/karlb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karlb/subscriptions", "organizations_url": "https://api.github.com/users/karlb/orgs", "repos_url": "https://api.github.com/users/karlb/repos", "events_url": "https://api.github.com/users/karlb/events{/privacy}", "received_events_url": "https://api.github.com/users/karlb/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/72/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/72", "html_url": "https://github.com/coleifer/peewee/pull/72", "diff_url": "https://github.com/coleifer/peewee/pull/72.diff", "patch_url": "https://github.com/coleifer/peewee/pull/72.patch", "merged_at": null }

{ "login": "smokedice", "id": 1133455, "node_id": "MDQ6VXNlcjExMzM0NTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1133455?v=4", "gravatar_id": "", "url": "https://api.github.com/users/smokedice", "html_url": "https://github.com/smokedice", "followers_url": "https://api.github.com/users/smokedice/followers", "following_url": "https://api.github.com/users/smokedice/following{/other_user}", "gists_url": "https://api.github.com/users/smokedice/gists{/gist_id}", "starred_url": "https://api.github.com/users/smokedice/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/smokedice/subscriptions", "organizations_url": "https://api.github.com/users/smokedice/orgs", "repos_url": "https://api.github.com/users/smokedice/repos", "events_url": "https://api.github.com/users/smokedice/events{/privacy}", "received_events_url": "https://api.github.com/users/smokedice/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/71/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Places to test:\n- setting up joins (follow_joins)\n- select query count()\n- parse select query special case for when just an id is selected .select(\"id\") -> .select({Model: ['id']})\n- convert_subquery\n- annotate_query\n- foreign related object lookup\n- foreign key field\n- model save\n- model collect_queries\n- delete instance\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/70/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jdearl", "id": 1612844, "node_id": "MDQ6VXNlcjE2MTI4NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1612844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jdearl", "html_url": "https://github.com/jdearl", "followers_url": "https://api.github.com/users/jdearl/followers", "following_url": "https://api.github.com/users/jdearl/following{/other_user}", "gists_url": "https://api.github.com/users/jdearl/gists{/gist_id}", "starred_url": "https://api.github.com/users/jdearl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jdearl/subscriptions", "organizations_url": "https://api.github.com/users/jdearl/orgs", "repos_url": "https://api.github.com/users/jdearl/repos", "events_url": "https://api.github.com/users/jdearl/events{/privacy}", "received_events_url": "https://api.github.com/users/jdearl/received_events", "type": "User", "site_admin": false }

[]

[]

[ "First off, thank you so much for including the SQL, makes debugging so much easier :)\n\nSince a product can have multiple items, the value of the aggregate functions has meaning and that is why you get meaningful results. The big question is what you expect \"price1\" to be. By the \"?\" interpolation I gather you're using sqlite -- trying this query in postgresql would most likely not work since it is a bit stricter.\n", "Yes, it's a bit contrived :)\n\nIn the case of the SQLite 3.7.11 it would return the same price as\nMAX(price1). Also, I'm not extremely familiar with PostgreSQL, but I\nbelieve the latest versions allow such queries also.\n\nI'm totally fine if you don't want to allow this. It was just a\nlittle confusing, because I was able to provide a list of fields to\nProduct, but not to Item. I do agree though, price1 isn't really\nuseful.\n\nSort of related, would R() work in this case? For example:\n\nR('GROUP_CONCAT(image) AS image')\n", "Yeah, in my opinion this is one of those things that give ORMs a bad rap. For a detailed description of a possible solution, check out https://groups.google.com/forum/?fromgroups#!topic/peewee-orm/RLd2r-eKp7w\n\nYou're doing an inner join but you want, in a sense, a right join on item and peewee doesn't support this...and as you said, the value of price1 is \"indeterminate\" but should probably be a list. The way I would fix this is to query Item and group by product. I'm not familiar with the group_concat function but would be interested in learning more.\n", "Thanks!\nBtw, I didn't realize there was a peewee forum!\n", "If you want to try this out, its kidn of hacky but might do what you want:\nhttp://peewee.readthedocs.org/en/latest/peewee/querying.html#speeding-up-simple-select-queries\n", "That works great, thank you! Good choice in method name :)\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/69/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jdearl", "id": 1612844, "node_id": "MDQ6VXNlcjE2MTI4NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1612844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jdearl", "html_url": "https://github.com/jdearl", "followers_url": "https://api.github.com/users/jdearl/followers", "following_url": "https://api.github.com/users/jdearl/following{/other_user}", "gists_url": "https://api.github.com/users/jdearl/gists{/gist_id}", "starred_url": "https://api.github.com/users/jdearl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jdearl/subscriptions", "organizations_url": "https://api.github.com/users/jdearl/orgs", "repos_url": "https://api.github.com/users/jdearl/repos", "events_url": "https://api.github.com/users/jdearl/events{/privacy}", "received_events_url": "https://api.github.com/users/jdearl/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I think the first 2 should probably work as expected with the existing DateTimeField, but the last should probably be given its own \"DateField\" a-la django (and maybe a TimeField as well for times). Thanks for reporting\n", "Is it possible to cast them to a DateTime with 0's? That's sorta what I'd expect to happen. I'm coming from Ruby, and Sequel or the Ruby SQLite adapter appears to do be doing this.\n\nI also added that the field is defined as a peewee DateTimeField().\n", "Totally, if the DateTimeField encounters something like example 3 it should zero out the times.\n", "Great!\n", "Thanks for fixing :)\n", "Would be really good if we could pass in the format string into the field constructor. I have dates in a sqlite db of '9 January 2009' so I'd like to pass the format in:\n\ntransaction_date = DateField(format='%d %B %Y')\n\nI'll fork and suggest something....\n", "Thanks for suggesting this fix, I've added it here:\n", "here's the commit: 0d9708a0f97685144aa7a9773755832dab459b07\n\nthe way it works is you can pass in \"formats\" kwarg in the field constructor containing a list of various formats to try.\n", "Legend Charles - you beat me to it :)\n\nLove Peewee btw - its my ORM of choice. In fact I don't choose any\nother these days - solid.\n\nThanks for the rapid help.\n\nBen\n\nOn Mon, May 14, 2012 at 5:30 PM, Charles Leifer\[email protected]\nwrote:\n\n> here's the commit: 0d9708a0f97685144aa7a9773755832dab459b07\n> \n> the way it works is you can pass in \"formats\" kwarg in the field constructor containing a list of various formats to try.\n> \n> ---\n> \n> Reply to this email directly or view it on GitHub:\n> https://github.com/coleifer/peewee/issues/68#issuecomment-5694864\n\n## \n\nBen Hughes\nChange & Innovation Lead\nBright Approach Ltd.\nTel: +447427600266\nTwitter: @bwghughes\nhttp://about.me/bwghughes\n", "No problem, glad to hear you're liking peewee!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/68/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "LeoDT", "id": 685203, "node_id": "MDQ6VXNlcjY4NTIwMw==", "avatar_url": "https://avatars.githubusercontent.com/u/685203?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LeoDT", "html_url": "https://github.com/LeoDT", "followers_url": "https://api.github.com/users/LeoDT/followers", "following_url": "https://api.github.com/users/LeoDT/following{/other_user}", "gists_url": "https://api.github.com/users/LeoDT/gists{/gist_id}", "starred_url": "https://api.github.com/users/LeoDT/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LeoDT/subscriptions", "organizations_url": "https://api.github.com/users/LeoDT/orgs", "repos_url": "https://api.github.com/users/LeoDT/repos", "events_url": "https://api.github.com/users/LeoDT/events{/privacy}", "received_events_url": "https://api.github.com/users/LeoDT/received_events", "type": "User", "site_admin": false }

[]

[]

[ "hey.....\n", "Try closing your connections. Is your server multithreaded by chance?\n", "If I close the connections, this problem seems solved.\nBut is it good to reconnect mysql every request?\n\nMultithreaded by chance? How to check this?\n", "Yeah you should not reuse your conns across requests. Use a connection pooler if you're concerned about performance. Django opens a connection per request, fwiw.\n", "In case you're interested, I've got a mixin for retrying failed queries in 017e4e4952f0b429dd21f0e90465a0f644cf6015 . Docs:\n\nhttp://docs.peewee-orm.com/en/latest/peewee/database.html#automatic-reconnect\n", "I know its a very old post but, I cant seem to find this class in latest documentation. \r\nWas this removed for some reason? (automatic-reconnect)", "Yes, but you can implement it yourself. Perhaps I'll add it back, since this trips up a lot of MySQL users -- particularly error 2006.\r\n\r\nThe thing is...this error indicates that you have a long-lived idle connection. MySQL closes idle connections after a certain time (which I think is configurable). So it may be a problem with the way your application is using db connections.", "I've reimplemented it: af914ccad7d09c070000da4153f88aef69b6e44f\r\n\r\nYou can now use the `ReconnectMixin` along with your `MySQLDatabase` to get auto-reconnect logic for certain types of errors.", "Thank you ! :) ", "I found that you've re-added a `ReconnectMixin` in the playhouse, but no docs on that was found in the documentation site. I came across that by your answers on stackoverflow. Could you please:\r\n\r\n1. Add docs.\r\n2. Tell us when to use ReconnectMixin and when to use a connection pool?", "It is not documented in the online docs because its use is not recommended... it is available because MySQL users seem to run into the same problem frequently but are ill-equipped to find a more correct solution.\r\n\r\nThe class itself has a docstring, though. Hopefully it is clear:\r\n\r\n```python\r\n \"\"\"\r\n Mixin class that attempts to automatically reconnect to the database under\r\n certain error conditions.\r\n\r\n For example, MySQL servers will typically close connections that are idle\r\n for 28800 seconds (\"wait_timeout\" setting). If your application makes use\r\n of long-lived connections, you may find your connections are closed after\r\n a period of no activity. This mixin will attempt to reconnect automatically\r\n when these errors occur.\r\n\r\n This mixin class probably should not be used with Postgres (unless you\r\n REALLY know what you are doing) and definitely has no business being used\r\n with Sqlite. If you wish to use with Postgres, you will need to adapt the\r\n `reconnect_errors` attribute to something appropriate for Postgres.\r\n \"\"\"\r\n```\r\n\r\nThe jist of it is that [MySQL server may terminate an idle connection after a certain timeout has elapsed](https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_wait_timeout). An idle connection typically indicates your program has failed to clean up resources. This is mentioned in the peewee docs [here](http://docs.peewee-orm.com/en/latest/peewee/database.html#error-2006-mysql-server-has-gone-away) and [here](http://docs.peewee-orm.com/en/latest/peewee/database.html#framework-integration). Automatically reconnecting and retrying the query that was rejected seems like a recipe for trouble to me.\r\n\r\nThe connection pool is used when you want to avoid the latency introduced by frequent opening/closing of connections - e.g., a web-app. That's pretty much it." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/67/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "wong2", "id": 321947, "node_id": "MDQ6VXNlcjMyMTk0Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/321947?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wong2", "html_url": "https://github.com/wong2", "followers_url": "https://api.github.com/users/wong2/followers", "following_url": "https://api.github.com/users/wong2/following{/other_user}", "gists_url": "https://api.github.com/users/wong2/gists{/gist_id}", "starred_url": "https://api.github.com/users/wong2/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wong2/subscriptions", "organizations_url": "https://api.github.com/users/wong2/orgs", "repos_url": "https://api.github.com/users/wong2/repos", "events_url": "https://api.github.com/users/wong2/events{/privacy}", "received_events_url": "https://api.github.com/users/wong2/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Forgot to say that I just tested it in MySQL.\n", "Does this not work? https://github.com/coleifer/peewee/blob/master/peewee.py#L244\n", "I think that is the charset when connecting to MySQL, it doesn't specify the default charset for creating tables so when I insert Chinese words to the table, they are garbled\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/66/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/66", "html_url": "https://github.com/coleifer/peewee/pull/66", "diff_url": "https://github.com/coleifer/peewee/pull/66.diff", "patch_url": "https://github.com/coleifer/peewee/pull/66.patch", "merged_at": null }

{ "login": "karlb", "id": 144773, "node_id": "MDQ6VXNlcjE0NDc3Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/144773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karlb", "html_url": "https://github.com/karlb", "followers_url": "https://api.github.com/users/karlb/followers", "following_url": "https://api.github.com/users/karlb/following{/other_user}", "gists_url": "https://api.github.com/users/karlb/gists{/gist_id}", "starred_url": "https://api.github.com/users/karlb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karlb/subscriptions", "organizations_url": "https://api.github.com/users/karlb/orgs", "repos_url": "https://api.github.com/users/karlb/repos", "events_url": "https://api.github.com/users/karlb/events{/privacy}", "received_events_url": "https://api.github.com/users/karlb/received_events", "type": "User", "site_admin": false }

[]

[]

[ "this is probably an issue in more places than just this\n", "As a workaround you could try using the db_column attribute on your field named \"model\":\n\n``` python\n\nclass MyModel(Model):\n model_alias = CharField(db_column='model')\n```\n", "So far my project works fine with the change in the pull request (without workaround). Should I look for more places in the code with this problem and submit another pull request, or is there another plan?\n", "I apologize for taking a while getting to this, I'll see about merging something up in the next day or two.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/65/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/65", "html_url": "https://github.com/coleifer/peewee/pull/65", "diff_url": "https://github.com/coleifer/peewee/pull/65.diff", "patch_url": "https://github.com/coleifer/peewee/pull/65.patch", "merged_at": null }

{ "login": "medwards", "id": 7339, "node_id": "MDQ6VXNlcjczMzk=", "avatar_url": "https://avatars.githubusercontent.com/u/7339?v=4", "gravatar_id": "", "url": "https://api.github.com/users/medwards", "html_url": "https://github.com/medwards", "followers_url": "https://api.github.com/users/medwards/followers", "following_url": "https://api.github.com/users/medwards/following{/other_user}", "gists_url": "https://api.github.com/users/medwards/gists{/gist_id}", "starred_url": "https://api.github.com/users/medwards/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/medwards/subscriptions", "organizations_url": "https://api.github.com/users/medwards/orgs", "repos_url": "https://api.github.com/users/medwards/repos", "events_url": "https://api.github.com/users/medwards/events{/privacy}", "received_events_url": "https://api.github.com/users/medwards/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/64/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/64", "html_url": "https://github.com/coleifer/peewee/pull/64", "diff_url": "https://github.com/coleifer/peewee/pull/64.diff", "patch_url": "https://github.com/coleifer/peewee/pull/64.patch", "merged_at": "2012-03-21T12:59:15" }

{ "login": "ManinTheVan", "id": 1532983, "node_id": "MDQ6VXNlcjE1MzI5ODM=", "avatar_url": "https://avatars.githubusercontent.com/u/1532983?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ManinTheVan", "html_url": "https://github.com/ManinTheVan", "followers_url": "https://api.github.com/users/ManinTheVan/followers", "following_url": "https://api.github.com/users/ManinTheVan/following{/other_user}", "gists_url": "https://api.github.com/users/ManinTheVan/gists{/gist_id}", "starred_url": "https://api.github.com/users/ManinTheVan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ManinTheVan/subscriptions", "organizations_url": "https://api.github.com/users/ManinTheVan/orgs", "repos_url": "https://api.github.com/users/ManinTheVan/repos", "events_url": "https://api.github.com/users/ManinTheVan/events{/privacy}", "received_events_url": "https://api.github.com/users/ManinTheVan/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yeah, only works like this in where clauses right now. Will look into it\n", "I'm actually not sure whether this is a valid use-case -- in your example you are querying for the first letter of a constant (\"myFirstName\") -- what is the benefit of doing that?\n\nI'm assuming the query you're hoping to generate is something like (using sqlite style parameter interpolation):\n\n``` python\n>>> query = User.select(['id', 'username', R('LOWER(SUBSTR( %s, 1, 1))', 'myFirstName' , 'first_letter')])\n>>> query.sql()\n('SELECT \"id\", LOWER(SUBSTR(?, 1, 1)) AS first_letter FROM \"users\"', ['myFirstName'])\n```\n\nBut if you know the \"first_letter\" is always going to be 'm' why add it to the query? If you hope to use that alias as part of the where clause you could instead write:\n\n``` python\n>>> query = User.select().where(R('LOWER(SUBSTR(username, 1, 1))=%s', 'm'))\n>>> query.sql()\n('SELECT \"id\", \"username\" FROM \"users\" WHERE LOWER(SUBSTR(username, 1, 1))=?', ['m'])\n```\n\nAm I missing something? I've got this written in a branch but as I was thinking about it I had a hard time thinking of how it would be useful. Thanks!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/63/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kryskool", "id": 337842, "node_id": "MDQ6VXNlcjMzNzg0Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/337842?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kryskool", "html_url": "https://github.com/kryskool", "followers_url": "https://api.github.com/users/kryskool/followers", "following_url": "https://api.github.com/users/kryskool/following{/other_user}", "gists_url": "https://api.github.com/users/kryskool/gists{/gist_id}", "starred_url": "https://api.github.com/users/kryskool/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kryskool/subscriptions", "organizations_url": "https://api.github.com/users/kryskool/orgs", "repos_url": "https://api.github.com/users/kryskool/repos", "events_url": "https://api.github.com/users/kryskool/events{/privacy}", "received_events_url": "https://api.github.com/users/kryskool/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/62/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/62", "html_url": "https://github.com/coleifer/peewee/pull/62", "diff_url": "https://github.com/coleifer/peewee/pull/62.diff", "patch_url": "https://github.com/coleifer/peewee/pull/62.patch", "merged_at": "2012-03-12T20:19:15" }

{ "login": "gnezim", "id": 617210, "node_id": "MDQ6VXNlcjYxNzIxMA==", "avatar_url": "https://avatars.githubusercontent.com/u/617210?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gnezim", "html_url": "https://github.com/gnezim", "followers_url": "https://api.github.com/users/gnezim/followers", "following_url": "https://api.github.com/users/gnezim/following{/other_user}", "gists_url": "https://api.github.com/users/gnezim/gists{/gist_id}", "starred_url": "https://api.github.com/users/gnezim/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gnezim/subscriptions", "organizations_url": "https://api.github.com/users/gnezim/orgs", "repos_url": "https://api.github.com/users/gnezim/repos", "events_url": "https://api.github.com/users/gnezim/events{/privacy}", "received_events_url": "https://api.github.com/users/gnezim/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Glad you like the library! Here's what I'd suggest you try -- you can pass 2-tuples into select clauses to specify aliases:\n\n``` python\n\nCC_map.select({\n CC_map: [('id', 'cc_map_id'), 'currency_id'],\n Currencies: ['currency_abbr'],\n}).order_by('country_id').where(country_id=country_id).join(Currencies, on='currency_id')\n```\n", "In 0.9.2 that does the trick. Thanks\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/61/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "emestee", "id": 1101501, "node_id": "MDQ6VXNlcjExMDE1MDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1101501?v=4", "gravatar_id": "", "url": "https://api.github.com/users/emestee", "html_url": "https://github.com/emestee", "followers_url": "https://api.github.com/users/emestee/followers", "following_url": "https://api.github.com/users/emestee/following{/other_user}", "gists_url": "https://api.github.com/users/emestee/gists{/gist_id}", "starred_url": "https://api.github.com/users/emestee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/emestee/subscriptions", "organizations_url": "https://api.github.com/users/emestee/orgs", "repos_url": "https://api.github.com/users/emestee/repos", "events_url": "https://api.github.com/users/emestee/events{/privacy}", "received_events_url": "https://api.github.com/users/emestee/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You need to set the arguments using keywords max_digits and decimal_places:\n\n```\nclass Foo(Model):\n foo_field = DecimalField(decimal_places=2)\n```\n\n```\n+-------+---------------+------+-----+---------+----------------+\n| Field | Type | Null | Key | Default | Extra |\n+-------+---------------+------+-----+---------+----------------+\n| id | int(11) | NO | PRI | NULL | auto_increment |\n| df | decimal(10,2) | NO | | NULL | |\n+-------+---------------+------+-----+---------+----------------+\n```\n", "Apologies, I feel pretty silly for not paying attention to the documentation.\n\nPlease do note that the docs says the decimal_places argument is simply _places_ at http://charlesleifer.com/docs/peewee/peewee/fields.html#field-types-table\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/60/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "stodge", "id": 95512, "node_id": "MDQ6VXNlcjk1NTEy", "avatar_url": "https://avatars.githubusercontent.com/u/95512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stodge", "html_url": "https://github.com/stodge", "followers_url": "https://api.github.com/users/stodge/followers", "following_url": "https://api.github.com/users/stodge/following{/other_user}", "gists_url": "https://api.github.com/users/stodge/gists{/gist_id}", "starred_url": "https://api.github.com/users/stodge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stodge/subscriptions", "organizations_url": "https://api.github.com/users/stodge/orgs", "repos_url": "https://api.github.com/users/stodge/repos", "events_url": "https://api.github.com/users/stodge/events{/privacy}", "received_events_url": "https://api.github.com/users/stodge/received_events", "type": "User", "site_admin": false }

[]

[]

[ "My apologies - I got it working. :)\n", "Yeah just set the database name to \":memory:\"\nOn Feb 25, 2012 8:57 PM, \"Mike Stoddart\" <\[email protected]>\nwrote:\n\n> I may have missed this in the docs, but does Peewee support in memory\n> SQLite databases? Thanks\n> \n> ---\n> \n> Reply to this email directly or view it on GitHub:\n> https://github.com/coleifer/peewee/issues/59\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/59/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "prggmr", "id": 207314, "node_id": "MDQ6VXNlcjIwNzMxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/207314?v=4", "gravatar_id": "", "url": "https://api.github.com/users/prggmr", "html_url": "https://github.com/prggmr", "followers_url": "https://api.github.com/users/prggmr/followers", "following_url": "https://api.github.com/users/prggmr/following{/other_user}", "gists_url": "https://api.github.com/users/prggmr/gists{/gist_id}", "starred_url": "https://api.github.com/users/prggmr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/prggmr/subscriptions", "organizations_url": "https://api.github.com/users/prggmr/orgs", "repos_url": "https://api.github.com/users/prggmr/repos", "events_url": "https://api.github.com/users/prggmr/events{/privacy}", "received_events_url": "https://api.github.com/users/prggmr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "See commit 7b76eca5b14211d70aa8231b2c1b65cb6a6e5b36 not sure how that other one got so messed up ... \n", "I will pass on merging this. Traversing the FK lookup is a convenient shorthand, and not really painful if doing in small amounts. If you're following this relationship in a loop, though, then you are costing yourself N+1 queries for the size of the result set. This can be boiled down to a single quiery using the explicit select syntax:\n\n```\n# loop over all the blog entries\nEntry.select({\n Entry: ['pk', 'title', 'blog'],\n Blog: ['id', 'title'],\n User: ['username'],\n}).join(Blog).join(User)\n\n# Yields the following SQL:\nSELECT t1.\"pk\", t1.\"title\", t1.\"blog_id\", t2.\"id\", t2.\"title\", t3.\"username\" \nFROM \"entry\" AS t1 \nINNER JOIN \"blog\" AS t2 \n ON t1.\"blog_id\" = t2.\"id\"\nLEFT OUTER JOIN \"users\" AS t3\n ON t2.\"id\" = t3.\"blog_id\"\n```\n\nthen, traversing lookups will not cost you an extra query and the related models will only be populated with the field syo uexplicitly selected.\n\nAs for the other thing, the R() objects, i'd definitley be interested in seeing a diff!\n", "Defiantly makes sense in terms of loop performance but in my case models are only queried for a single result and returned giving the cost of +1 query outweighed by the benefit of a standardized select with less overall code.\n\nAs for the R object all I simply did was put together the following.\n\nNote that this could probably be better as this was a quick fix but for my purposes of needing complex where expressions joined directly with a Q object has worked so far without problems.\n\n```\nclass R(object):\n def __init__(self, *params):\n self.params = params\n self.parent = None\n\n def sql_select(self):\n if len(self.params) == 2:\n return self.params\n else:\n raise ValueError('Incorrect number of argument provided for R() expression')\n\n def connect(self, connector):\n if self.parent is None:\n self.parent = Node(connector)\n self.parent.children.append(self)\n\n def __or__(self, rhs):\n self.connect('OR')\n return self.parent | rhs\n\n def __and__(self, rhs):\n self.connect('AND')\n return self.parent & rhs\n\n def sql_where(self):\n return self.params[0], self.params[1:]\n```\n\nDisregard last found a possible solution.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/58/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/58", "html_url": "https://github.com/coleifer/peewee/pull/58", "diff_url": "https://github.com/coleifer/peewee/pull/58.diff", "patch_url": "https://github.com/coleifer/peewee/pull/58.patch", "merged_at": null }

{ "login": "stodge", "id": 95512, "node_id": "MDQ6VXNlcjk1NTEy", "avatar_url": "https://avatars.githubusercontent.com/u/95512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stodge", "html_url": "https://github.com/stodge", "followers_url": "https://api.github.com/users/stodge/followers", "following_url": "https://api.github.com/users/stodge/following{/other_user}", "gists_url": "https://api.github.com/users/stodge/gists{/gist_id}", "starred_url": "https://api.github.com/users/stodge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stodge/subscriptions", "organizations_url": "https://api.github.com/users/stodge/orgs", "repos_url": "https://api.github.com/users/stodge/repos", "events_url": "https://api.github.com/users/stodge/events{/privacy}", "received_events_url": "https://api.github.com/users/stodge/received_events", "type": "User", "site_admin": false }

[]

[]

[ "the database name isn't needed until a connection is opened, so you _could_ manually set the name at runtime before a query gets executed or a connection opened. what is your use-case? its kind of tricky considering that your model definitions are already written, unless you are creating those dynamically as well.\n", "I found a solution. I can create the models and database name dynamically at runtime from json descriptions. Initial testing shows it works. Thanks\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/57/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ksamuel", "id": 221886, "node_id": "MDQ6VXNlcjIyMTg4Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/221886?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ksamuel", "html_url": "https://github.com/ksamuel", "followers_url": "https://api.github.com/users/ksamuel/followers", "following_url": "https://api.github.com/users/ksamuel/following{/other_user}", "gists_url": "https://api.github.com/users/ksamuel/gists{/gist_id}", "starred_url": "https://api.github.com/users/ksamuel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ksamuel/subscriptions", "organizations_url": "https://api.github.com/users/ksamuel/orgs", "repos_url": "https://api.github.com/users/ksamuel/repos", "events_url": "https://api.github.com/users/ksamuel/events{/privacy}", "received_events_url": "https://api.github.com/users/ksamuel/received_events", "type": "User", "site_admin": false }

[]

[]

[ "+1\n", "http://www.youtube.com/watch?v=FsJhfwbfMvU\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/56/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "teserak", "id": 447351, "node_id": "MDQ6VXNlcjQ0NzM1MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/447351?v=4", "gravatar_id": "", "url": "https://api.github.com/users/teserak", "html_url": "https://github.com/teserak", "followers_url": "https://api.github.com/users/teserak/followers", "following_url": "https://api.github.com/users/teserak/following{/other_user}", "gists_url": "https://api.github.com/users/teserak/gists{/gist_id}", "starred_url": "https://api.github.com/users/teserak/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/teserak/subscriptions", "organizations_url": "https://api.github.com/users/teserak/orgs", "repos_url": "https://api.github.com/users/teserak/repos", "events_url": "https://api.github.com/users/teserak/events{/privacy}", "received_events_url": "https://api.github.com/users/teserak/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/55/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/54/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "wtld", "id": 1318746, "node_id": "MDQ6VXNlcjEzMTg3NDY=", "avatar_url": "https://avatars.githubusercontent.com/u/1318746?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wtld", "html_url": "https://github.com/wtld", "followers_url": "https://api.github.com/users/wtld/followers", "following_url": "https://api.github.com/users/wtld/following{/other_user}", "gists_url": "https://api.github.com/users/wtld/gists{/gist_id}", "starred_url": "https://api.github.com/users/wtld/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wtld/subscriptions", "organizations_url": "https://api.github.com/users/wtld/orgs", "repos_url": "https://api.github.com/users/wtld/repos", "events_url": "https://api.github.com/users/wtld/events{/privacy}", "received_events_url": "https://api.github.com/users/wtld/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Would you mind sharing your model definiton?\n", "``` python\nclass BaseModel(peewee.Model):\n\n class Meta:\n database = database\n\nclass Test(BaseModel):\n name = peewee.CharField()\n\nTest.create_table()\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/53/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "23doors", "id": 1051101, "node_id": "MDQ6VXNlcjEwNTExMDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1051101?v=4", "gravatar_id": "", "url": "https://api.github.com/users/23doors", "html_url": "https://github.com/23doors", "followers_url": "https://api.github.com/users/23doors/followers", "following_url": "https://api.github.com/users/23doors/following{/other_user}", "gists_url": "https://api.github.com/users/23doors/gists{/gist_id}", "starred_url": "https://api.github.com/users/23doors/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/23doors/subscriptions", "organizations_url": "https://api.github.com/users/23doors/orgs", "repos_url": "https://api.github.com/users/23doors/repos", "events_url": "https://api.github.com/users/23doors/events{/privacy}", "received_events_url": "https://api.github.com/users/23doors/received_events", "type": "User", "site_admin": false }

[]

[]

[ "If you iterate over a QueryResultWrapper, the object that wraps a db cursor when doing a select queyr, results will be cached in memory (if iterating over a large data set you can use the queryresultwrapper.iterator() which doesn't cache things).\n\nBeyond that there is no caching, nor do i think there should be. ORM level caching always seemed a little sketchy to me, probably the best place to put caching is higher up, in the application.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/52/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/51/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[ { "id": 191751, "node_id": "MDU6TGFiZWwxOTE3NTE=", "url": "https://api.github.com/repos/coleifer/peewee/labels/Feature", "name": "Feature", "color": "02e10c", "default": false, "description": null } ]

[]

[ "Woohoo!! Added!\n\nhttp://charlesleifer.com/docs/peewee/peewee/querying.html#sql-functions-raw-expressions-and-the-r-object\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/50/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "karlb", "id": 144773, "node_id": "MDQ6VXNlcjE0NDc3Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/144773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karlb", "html_url": "https://github.com/karlb", "followers_url": "https://api.github.com/users/karlb/followers", "following_url": "https://api.github.com/users/karlb/following{/other_user}", "gists_url": "https://api.github.com/users/karlb/gists{/gist_id}", "starred_url": "https://api.github.com/users/karlb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karlb/subscriptions", "organizations_url": "https://api.github.com/users/karlb/orgs", "repos_url": "https://api.github.com/users/karlb/repos", "events_url": "https://api.github.com/users/karlb/events{/privacy}", "received_events_url": "https://api.github.com/users/karlb/received_events", "type": "User", "site_admin": false }

[]

[]

[ "self-trolled 46f073de8f2a9760b30f7581a2c29bf563c8c066\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/49/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/49", "html_url": "https://github.com/coleifer/peewee/pull/49", "diff_url": "https://github.com/coleifer/peewee/pull/49.diff", "patch_url": "https://github.com/coleifer/peewee/pull/49.patch", "merged_at": null }

{ "login": "ghost", "id": 10137, "node_id": "MDQ6VXNlcjEwMTM3", "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghost", "html_url": "https://github.com/ghost", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "organizations_url": "https://api.github.com/users/ghost/orgs", "repos_url": "https://api.github.com/users/ghost/repos", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "received_events_url": "https://api.github.com/users/ghost/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/48/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "davidthewatson", "id": 150892, "node_id": "MDQ6VXNlcjE1MDg5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/150892?v=4", "gravatar_id": "", "url": "https://api.github.com/users/davidthewatson", "html_url": "https://github.com/davidthewatson", "followers_url": "https://api.github.com/users/davidthewatson/followers", "following_url": "https://api.github.com/users/davidthewatson/following{/other_user}", "gists_url": "https://api.github.com/users/davidthewatson/gists{/gist_id}", "starred_url": "https://api.github.com/users/davidthewatson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davidthewatson/subscriptions", "organizations_url": "https://api.github.com/users/davidthewatson/orgs", "repos_url": "https://api.github.com/users/davidthewatson/repos", "events_url": "https://api.github.com/users/davidthewatson/events{/privacy}", "received_events_url": "https://api.github.com/users/davidthewatson/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yeah, RawQuery is best for querying against a particualr \"model\" as it willr eturn instances. To execute arbitrary queries you could look in the code and see what's happening, but basically:\n\n`database.execute(\"some sql\", (any, parameters, here))`\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/47/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jokull", "id": 701, "node_id": "MDQ6VXNlcjcwMQ==", "avatar_url": "https://avatars.githubusercontent.com/u/701?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jokull", "html_url": "https://github.com/jokull", "followers_url": "https://api.github.com/users/jokull/followers", "following_url": "https://api.github.com/users/jokull/following{/other_user}", "gists_url": "https://api.github.com/users/jokull/gists{/gist_id}", "starred_url": "https://api.github.com/users/jokull/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jokull/subscriptions", "organizations_url": "https://api.github.com/users/jokull/orgs", "repos_url": "https://api.github.com/users/jokull/repos", "events_url": "https://api.github.com/users/jokull/events{/privacy}", "received_events_url": "https://api.github.com/users/jokull/received_events", "type": "User", "site_admin": false }

[]

[]

[ "What's failing with the postgresql tests?\n", "The return values from psycopg2 are `str` types, non-decoded. Rev 4a2ba5b adds encoding and decoding and the tests pass.\n\nHere's the result before the patch:\n\n# \n\n## FAIL: test_unicode_lookup (tests.UnicodeFieldTests)\n\nTraceback (most recent call last):\n File \"/Users/jokull/Code/peewee/tests.py\", line 1104, in test_unicode_lookup\n self.assertEqual(a1.title, a.title)\nAssertionError: 'L\\xc3\\xbd\\xc3\\xb0veldi\\xc3\\xb0 \\xc3\\x8dsland' != u'L\\xfd\\xf0veldi\\xf0 \\xcdsland'\n\n# \n\n## FAIL: test_unicode_value (tests.UnicodeFieldTests)\n\nTraceback (most recent call last):\n File \"/Users/jokull/Code/peewee/tests.py\", line 1097, in test_unicode_value\n self.assertEqual(a.title, u'Lýðveldið Ísland')\nAssertionError: 'L\\xc3\\xbd\\xc3\\xb0veldi\\xc3\\xb0 \\xc3\\x8dsland' != u'L\\xfd\\xf0veldi\\xf0 \\xcdsland'\n", "I'm confused...is this working?\n", "First commit is the test case so u can see what fails. Second commit fixes it.\n\nSent from my iPhone\n\nOn Jan 19, 2012, at 9:43 PM, Charles Leifer\[email protected]\nwrote:\n\n> I'm confused...is this working?\n> \n> ---\n> \n> Reply to this email directly or view it on GitHub:\n> https://github.com/coleifer/peewee/pull/46#issuecomment-3574890\n", "For what it's worth the Django ORM does this too.\n", "Thanks for all your work on this! Merged into master and verified your tests against psql & sqlite. Tested against MySQL as well and am getting failures:\n\n```\n======================================================================\nFAIL: test_unicode_lookup (tests.UnicodeFieldTests)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n File \"/home/charles/code/peewee/tests.py\", line 1012, in test_unicode_lookup\n self.assertEqual(a1.title, a.title)\nAssertionError: 'L\\xfd\\xf0veldi\\xf0 \\xcdsland' != u'L\\xfd\\xf0veldi\\xf0 \\xcdsland'\n\n======================================================================\nFAIL: test_unicode_value (tests.UnicodeFieldTests)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n File \"/home/charles/code/peewee/tests.py\", line 1005, in test_unicode_value\n self.assertEqual(a.title, u'Lýðveldið Ísland')\nAssertionError: 'L\\xfd\\xf0veldi\\xf0 \\xcdsland' != u'L\\xfd\\xf0veldi\\xf0 \\xcdsland'\n```\n", "Fixed in 0c3b2ef62a83bfdd964be1739817a34d87ea4548\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/46/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/46", "html_url": "https://github.com/coleifer/peewee/pull/46", "diff_url": "https://github.com/coleifer/peewee/pull/46.diff", "patch_url": "https://github.com/coleifer/peewee/pull/46.patch", "merged_at": "2012-01-20T18:08:25" }

{ "login": "jokull", "id": 701, "node_id": "MDQ6VXNlcjcwMQ==", "avatar_url": "https://avatars.githubusercontent.com/u/701?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jokull", "html_url": "https://github.com/jokull", "followers_url": "https://api.github.com/users/jokull/followers", "following_url": "https://api.github.com/users/jokull/following{/other_user}", "gists_url": "https://api.github.com/users/jokull/gists{/gist_id}", "starred_url": "https://api.github.com/users/jokull/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jokull/subscriptions", "organizations_url": "https://api.github.com/users/jokull/orgs", "repos_url": "https://api.github.com/users/jokull/repos", "events_url": "https://api.github.com/users/jokull/events{/privacy}", "received_events_url": "https://api.github.com/users/jokull/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Testcases ought to clear that up\n", "Do you want me to create a UnicodeCharFieldTestCase?\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/45/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/45", "html_url": "https://github.com/coleifer/peewee/pull/45", "diff_url": "https://github.com/coleifer/peewee/pull/45.diff", "patch_url": "https://github.com/coleifer/peewee/pull/45.patch", "merged_at": null }

{ "login": "karlb", "id": 144773, "node_id": "MDQ6VXNlcjE0NDc3Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/144773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karlb", "html_url": "https://github.com/karlb", "followers_url": "https://api.github.com/users/karlb/followers", "following_url": "https://api.github.com/users/karlb/following{/other_user}", "gists_url": "https://api.github.com/users/karlb/gists{/gist_id}", "starred_url": "https://api.github.com/users/karlb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karlb/subscriptions", "organizations_url": "https://api.github.com/users/karlb/orgs", "repos_url": "https://api.github.com/users/karlb/repos", "events_url": "https://api.github.com/users/karlb/events{/privacy}", "received_events_url": "https://api.github.com/users/karlb/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Right now the column name is closely tied to the field name -- will see about disentangling this.\n", "To add some to this,\n\nIf you setup a ForeignKey without a \"_id\" it is created in the table with an \"_id\" appended to the name, e.g. field name blog will have a column name of \"blog_id\" in the table ( at least for MySQL ).\n\n```\nclass Comment(peewee.Model):\n id = PrimaryKeyField()\n blog = ForeignKeyField(Blog)\n```\n\nIf I then attempt to create a new record\n\n```\npeewee.InsertQuery(Comment, blog = a_blog_object)\n```\n\nYou recieve the following\n\n```\nAttributeError: Field name blog not found.\n```\n\nRunning the same with id appended\n\n```\npeewee.InsertQuery(Comment, blog_id = a_blog_object)\n```\n\nWorks as expected.\n\nAlso creating a field with \"_id\" in the name results in the column name doubling the \"_id\".\n\nE.g.\n\nblog_id results in blog_id_id\n\nI'm using version 0.8.\n", "OK...wow, this one was a bummer to fix. I had started with the assumption that field names and columns were interchangeable, but there was a weird special case where foreign key fields would get an \"_id\" tacked onto them. The actual id would be stored on the model instance in the \"_id\" field, and the object at the fields name would be a descriptor that would lookup/cache the related object. There was a lot of disentangling to do to separate out places where we're accessing and querying fields by name versus by column, but i'm pretty confident that i've got this one fixed.\n\nThe default behavior has not changed -- in other words, \"_id\" is still added on -- but if you want you can manually specify the underlying column for any field:\n\n```\n class Blog(Model):\n name = CharField(db_column='mySweetPhpName')\n\n class Entry(Model):\n name = CharField()\n blog = ForeignKeyField(db_column='blog') # <-- actually stores it in \"blog\" in the database\n```\n\nI think i've got good test coverage for this, but if you run into any bugs with it let meknow!\n", "Works great. Thanks a lot!\n", "Might it be possible to adapt 'pwiz.py' to add the ',db_column=' argument for every foreign key column?\n", "@dstruck -- Any reason this is preferable?\n", "Expected that pwiz would use the column names from the existing tables to generate the models. As I tend to use \"id_user\", \"id_center\" instead of \"user_id\" or \"center_id\", this clashed with the default behaviour of peewee to append \"_id\" to foreign key columns.\n\nThis is an example to show the \"issue\":\n\n``` python\n'''\n-- create two test tables in postgresql\n\nCREATE TABLE list_user(\nid SERIAL PRIMARY KEY\n,name TEXT\n);\n\nINSERT INTO list_user (name) VALUES ('test');\n\nCREATE TABLE sample(\nid SERIAL PRIMARY KEY\n,id_user INT REFERENCES list_user\n,data TEXT\n);\n'''\n\n################################################################################\n# classes generated by pwiz.py\n# pwiz.py -e postgresql test > model.txt\nfrom peewee import *\n\ndatabase = PostgresqlDatabase('test', **{})\n\nclass UnknownFieldType(object):\n pass\n\nclass BaseModel(Model):\n class Meta:\n database = database\n\nclass List_User(BaseModel):\n name = TextField(null=True)\n\n class Meta:\n db_table = 'list_user'\n\nclass Sample(BaseModel):\n data = TextField(null=True)\n id_user = ForeignKeyField(null=True, rel_model=List_User)\n\n class Meta:\n db_table = 'sample'\n################################################################################\n\n# test\nentry = Sample(id_user=1,data=\"test123\")\nentry.save()\n\n'''\nerror message produced by this test:\n\npsycopg2.ProgrammingError: column \"id_user_id\" of relation \"sample\" does not exist\nLINE 1: INSERT INTO \"sample\" (\"data\", \"id_user_id\") VALUES ('test123...\n'''\n```\n", "I will try and write some tests for this code as it is sometimes a bit buggy and difficult to verify.\n", "Thanks for the fix. Will test it on our databases and report back if I find any other issue.\n\nps: never was a fan of orm's, always worked directly with databases, but peewee might change my opinion ;-)\n", "would be nice to add `db_column` in api docs\n", "It is: http://docs.peewee-orm.com/en/latest/peewee/api.html#fields\n\nAnd: http://docs.peewee-orm.com/en/latest/peewee/models.html#field-initialization-arguments\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/44/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "aflower", "id": 1042834, "node_id": "MDQ6VXNlcjEwNDI4MzQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1042834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aflower", "html_url": "https://github.com/aflower", "followers_url": "https://api.github.com/users/aflower/followers", "following_url": "https://api.github.com/users/aflower/following{/other_user}", "gists_url": "https://api.github.com/users/aflower/gists{/gist_id}", "starred_url": "https://api.github.com/users/aflower/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aflower/subscriptions", "organizations_url": "https://api.github.com/users/aflower/orgs", "repos_url": "https://api.github.com/users/aflower/repos", "events_url": "https://api.github.com/users/aflower/events{/privacy}", "received_events_url": "https://api.github.com/users/aflower/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Tracking on #42, closing\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/43/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/43", "html_url": "https://github.com/coleifer/peewee/pull/43", "diff_url": "https://github.com/coleifer/peewee/pull/43.diff", "patch_url": "https://github.com/coleifer/peewee/pull/43.patch", "merged_at": null }

{ "login": "aflower", "id": 1042834, "node_id": "MDQ6VXNlcjEwNDI4MzQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1042834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aflower", "html_url": "https://github.com/aflower", "followers_url": "https://api.github.com/users/aflower/followers", "following_url": "https://api.github.com/users/aflower/following{/other_user}", "gists_url": "https://api.github.com/users/aflower/gists{/gist_id}", "starred_url": "https://api.github.com/users/aflower/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aflower/subscriptions", "organizations_url": "https://api.github.com/users/aflower/orgs", "repos_url": "https://api.github.com/users/aflower/repos", "events_url": "https://api.github.com/users/aflower/events{/privacy}", "received_events_url": "https://api.github.com/users/aflower/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for reporting, looking -- the quote thing may not work as I think mysql likes backticks, but this is definitelysomething that needs to be addressed.\n", "Nice fix!\n", "peewee now quotes columns and table names as well...closing\n360e55f28a606dfeabc68a5c7dcabb9e109ec0bd\n6b2a8278d9a068b71ae110f37626d053bdbcec1d\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/42/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }