<p dir="auto"><code class="notranslate">our_rand_r</code> is a fast and simple random generator defined in <code class="notranslate">sklearn/tree/_tree.pyx</code></p>
<p dir="auto">Problems:</p>
<ul dir="auto">
<li>The functions only return 0s if seeded with 0. We need to audit the use of this function and make sure it is never seeded with 0.</li>
<li>The code is duplicated (<code class="notranslate">sklearn/linear_model/cd_fast.pyx</code>) and will be in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="78080071" data-permission-text="Title is private" data-url="https://github.com/scikit-learn/scikit-learn/issues/4738" data-hovercard-type="pull_request" data-hovercard-url="/scikit-learn/scikit-learn/pull/4738/hovercard" href="https://github.com/scikit-learn/scikit-learn/pull/4738">#4738</a>, in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="89295417" data-permission-text="Title is private" data-url="https://github.com/scikit-learn/scikit-learn/issues/4873" data-hovercard-type="pull_request" data-hovercard-url="/scikit-learn/scikit-learn/pull/4873/hovercard" href="https://github.com/scikit-learn/scikit-learn/pull/4873">#4873</a>, and possibly other PR . My first attempt to re-use only one code (by moving the inline function in _tree.pxd file) has failed: Every tests passed on Linux (Travis) but it broke 45 tests on Windows (AppVeyor), I did not figure out why.</li>
</ul>
<p dir="auto">Right now the output of travis is too large to render, partially because a lot of deprecation warnings and partially because of warnings from the common tests. The common tests should catch all the deprecation warnings and probably also convergence warnings or numerical warnings (we decrease the number of iterations for faster testing).</p>