output
stringlengths 1
18.7k
| input
stringlengths 1
18.7k
|
|---|---|
We're still in an early integration phase so :+1:
| Ketan Umare Please go ahead. We only use the Kustomize setup for testing cluster. Production is different as you know.
|
what currently shows up under the Logs section when you click on a task in the UI?
| Does anyone have experience with kubernetes pod logging? I'm trying to get the kubernetes logs to show up with the corresponding node in the Flyte console but wondering if this is possible / if there are any examples I should be looking at?
|
Currently it just says No logs found
| what currently shows up under the Logs section when you click on a task in the UI?
|
Vrinda Vasavada there are 2 options today - Stackdriver and/or kubernetes dashboard
It needs to be configured
I can help with that
| Currently it just says No logs found
|
you’re probably missing a migration
| anyone seen this error with flyteadmin:
```$ flyteadmin --logtostderr --config /etc/flyte/config/flyteadmin_config.yaml migrate seed-projects jeevb-sandbox
...
{"json":{"src":"seed_data.go:22"},"level":"warning","msg":"failed to save project [jeevb-sandbox]","ts":"2020-09-28T19:45:33Z"}
{"json":{"src":"migrate.go:122"},"level":"fatal","msg":"Could not add projects to database with err: pq: column \"labels\" of relation \"projects\" does not exist","ts":"2020-09-28T19:45:33Z"}```
running with: `<http://docker.io/lyft/flyteadmin:v0.3.5|docker.io/lyft/flyteadmin:v0.3.5>`
|
thanks for following up Yee. when are the migrations applied for flyteadmin?
im running the command after `flyteadmin` is up and running
| you’re probably missing a migration
|
hmm
| thanks for following up Yee. when are the migrations applied for flyteadmin?
im running the command after `flyteadmin` is up and running
|
oh wait
| hmm
|
that is unfortunately something that is deployment-specific. this is the migration in question <https://github.com/lyft/flyteadmin/commit/eb9236eea8af44791d87c0f4113b92d0da32fa0f#diff-d4e6d4b7fe6e051b604a13e2838a96ceR255>
| oh wait
|
ah interesting. this is with a fresh sandbox. seems odd that it wont just work out of the box
| that is unfortunately something that is deployment-specific. this is the migration in question <https://github.com/lyft/flyteadmin/commit/eb9236eea8af44791d87c0f4113b92d0da32fa0f#diff-d4e6d4b7fe6e051b604a13e2838a96ceR255>
|
0.3.5 should definitely have it. and in the sandbox case, migrations are run as part of the init container <https://github.com/lyft/flyte/blob/master/deployment/sandbox/flyte_generated.yaml#L1150>
oops, wrong line
it absolutely should work out of the box.
| ah interesting. this is with a fresh sandbox. seems odd that it wont just work out of the box
|
ah i know why. this is user error. my apologies.
| 0.3.5 should definitely have it. and in the sandbox case, migrations are run as part of the init container <https://github.com/lyft/flyte/blob/master/deployment/sandbox/flyte_generated.yaml#L1150>
oops, wrong line
it absolutely should work out of the box.
|
what was it?
| ah i know why. this is user error. my apologies.
|
we have specific kustomize overrides for images that i need to clean up.
| what was it?
|
:ok_hand:
are you back from leave already?
| we have specific kustomize overrides for images that i need to clean up.
|
yea just got back today
| :ok_hand:
are you back from leave already?
|
welcome back!
| yea just got back today
|
hmm this is weird
Yee should we write an example to reproduce this?
| Hey all, Am seeing a bizarre behaviour, not sure if it is expected or if i am doing something wrong:
I was uploading a workflow that uses `Types.Generic` and `[Types.Generic]` as an ouptut, and I was having issues because it seemed that the workflows where uploading successfully, but when i launch the workflow it does not include the tasks that used the `Types.Generic` outputs. I switched to `Types.Blob` and things worked again. any idea if that is expected?
|
for sure
| hmm this is weird
Yee should we write an example to reproduce this?
|
ok
i guess no other way
| for sure
|
if you don't mind copying/pasting code from your end Thomas that would be helpful too (but we understand there are IP concerns)
| ok
i guess no other way
|
Thomas Vetterli i tried it quickly in this PR <https://github.com/lyft/flytesnacks/pull/40>
and it seems to work
maybe the version of flytekit?
| if you don't mind copying/pasting code from your end Thomas that would be helpful too (but we understand there are IP concerns)
|
ah awesome, will try a simple example on my end as well, see what happens. Thanks for trying it out
| Thomas Vetterli i tried it quickly in this PR <https://github.com/lyft/flytesnacks/pull/40>
and it seems to work
maybe the version of flytekit?
|
Yes Hongxin Liang the month end release is still pending
| Hi. When do we plan to cut a new release of flyteadmin?
|
Great, thanks! We are waiting for a stackdriver log link fix to be pushed out. Not urgent though.
| Yes Hongxin Liang the month end release is still pending
|
fyi Yee just cut <https://github.com/lyft/flyteadmin/releases/tag/v0.3.7>
| Great, thanks! We are waiting for a stackdriver log link fix to be pushed out. Not urgent though.
|
Is there a recording of this that we can view George Snelling
| <!here> reminder everybody:
Flyte bi-weekly community sync tomorrow at 9:00 am Pacific. (4pm UTC) Chang-Hong Hsu will show off some Sagemaker integration for Flyte-orchestrated distributed ML training workflows. Ketan Umare will show off some of the great tutorial work Yuvraj (union.ai) has contributed.
Zoom: <https://us04web.zoom.us/j/71298741279?pwd=TDR1RUppQmxGaDRFdzBOa2lHN1dsZz09>
Meeting ID: 712 9874 1279
Password: 7stPGd
|
Ian very sorry, I forgot to post. Just a sec…
Looks like Zoom stores the recordings on the host’s local computer, which in this case is my home machine. I’ll return home in a few hours and will upload it then.
| Is there a recording of this that we can view George Snelling
|
No rush, so long as there is something can get it later.
| Ian very sorry, I forgot to post. Just a sec…
Looks like Zoom stores the recordings on the host’s local computer, which in this case is my home machine. I’ll return home in a few hours and will upload it then.
|
George Snelling did you get the recording? I will also send out the notes with the recording
| No rush, so long as there is something can get it later.
|
I missed the housekeeping but got all of Chang-Hong Hsu’s demo.
| George Snelling did you get the recording? I will also send out the notes with the recording
|
ohhh thats ok, i will put a little more of the comment in the notes
| I missed the housekeeping but got all of Chang-Hong Hsu’s demo.
|
George Snelling wanted to check in on the video
| ohhh thats ok, i will put a little more of the comment in the notes
|
Ian here you go:
<https://drive.google.com/file/d/1x8riVGRlVM3R_ShLMOP16BT63OQgGSI3/view?usp=sharing>
Also linked from the <https://docs.google.com/document/d/1Jb6eOPOzvTaHjtPEVy7OR2O5qK1MhEs3vv56DX2dacM/edit#heading=h.c5ha25xc546e|Meeting Notes>. Apologies for the delay.
| George Snelling wanted to check in on the video
|
hey Jeev B I don't know that we have best practices but there are several options you can use
you can inject secrets as env variables or mount them at a specific file path
then in the config you can specify them like so:
```cluster_resources:
templatePath: pkg/clusterresource/sampletemplates
templateData:
foo:
valueFrom:
env: MY_VARIABLE
bar:
valueFrom:
filePath: "/mnt/wherever"```
| what's the current best practices around propagating secrets via clusterresource_templates?
|
can we specify configmaps or secrets here?
would be super cool if we can create the objects in the flyte deployment namespace and have them be propagated to the project-domain namespaces!
Katrina Rogan the `filePath` here, is within the flyteadmin pod?
so that way, i could mount secrets/configmaps into flyteadmin, and have them be propagated to the child namespaces?
| hey Jeev B I don't know that we have best practices but there are several options you can use
you can inject secrets as env variables or mount them at a specific file path
then in the config you can specify them like so:
```cluster_resources:
templatePath: pkg/clusterresource/sampletemplates
templateData:
foo:
valueFrom:
env: MY_VARIABLE
bar:
valueFrom:
filePath: "/mnt/wherever"```
|
Jeev B yep that's correct
| can we specify configmaps or secrets here?
would be super cool if we can create the objects in the flyte deployment namespace and have them be propagated to the project-domain namespaces!
Katrina Rogan the `filePath` here, is within the flyteadmin pod?
so that way, i could mount secrets/configmaps into flyteadmin, and have them be propagated to the child namespaces?
|
oh sweet
i love this. thanks!
| Jeev B yep that's correct
|
awesome, glad to hear! i'll file an issue to track your secret suggestion (or if you'd like to, please do!) that's a cool alternative to have too
| oh sweet
i love this. thanks!
|
Katrina Rogan i think there might be one issue with this: when creating cluster resource templates that are secrets, the values should be base64 encoded.
per here: <https://github.com/lyft/flyteadmin/blob/316ce8cbb7a9df0791c77f4335835b3399ee44b8/pkg/runtime/interfaces/cluster_resource_configuration.go#L25>
it sounds like the best way to go about this is to create config maps as cluster resource templates and pass secrets into the configmaps
| awesome, glad to hear! i'll file an issue to track your secret suggestion (or if you'd like to, please do!) that's a cool alternative to have too
|
oh what we've done is mount the base 64 encoded value
| Katrina Rogan i think there might be one issue with this: when creating cluster resource templates that are secrets, the values should be base64 encoded.
per here: <https://github.com/lyft/flyteadmin/blob/316ce8cbb7a9df0791c77f4335835b3399ee44b8/pkg/runtime/interfaces/cluster_resource_configuration.go#L25>
it sounds like the best way to go about this is to create config maps as cluster resource templates and pass secrets into the configmaps
|
Yes we have. We don’t have expertise. If you can help I can take forward the work
Ruslan Stanevich any help? Yuvraj (union.ai) was interested to
| Hello Everyone :wave:
Have you ever considered publishing a Helm chart for Flyte?
From the first sight, Helm should make it easier to configure for different Flyte installation (AWS, GCP, dev, etc). And potentially it’ll reduce the total number of lines of configuration code.
From our experience, we have transferred all K8s system controllers to Helm (we use it only as templating engine) and this simplified the maintenance and rollout updates on different k8s clusters.
Or you have some concerns about this?
|
HI Ketan Umare
I have several ideas how to do it.
I’ll take a look at this in the following week and will try to share PoC.
| Yes we have. We don’t have expertise. If you can help I can take forward the work
Ruslan Stanevich any help? Yuvraj (union.ai) was interested to
|
Ruslan Stanevich ping me if anything needed, I am available for POC.
| HI Ketan Umare
I have several ideas how to do it.
I’ll take a look at this in the following week and will try to share PoC.
|
thanks Yuvraj (union.ai) !
will do :fist:
So, I see the Flyte helm chart smth like this.
For now it contains minimal customizations for chart but it can be extended.
The Chart contains 2 configurations:
• Sandbox installation (`values-sandbox.yaml`) has been tested on Minikube with `tests/endtoent.yaml`
• EKS installation (`values-eks.yaml`) has been tested on development EKS cluster. Yes, some data is hidden, like bucket name, account number and etc.
on our main Flyte installation:
• we use Istio as ingress controller instead of Contour.
• we don’t use Kubernetes secrets, but use vault-init-agent.
• and some additional customizations
Actually, it needs additional time for improvement but I’d like share the first attempt.
| Ruslan Stanevich ping me if anything needed, I am available for POC.
|
Ruslan Stanevich do you mind making a PR :pray:
:slightly_smiling_face:
Also does this helm chart work with kustomize?
or is this completely separate?
Yuvraj (union.ai) ^
| thanks Yuvraj (union.ai) !
will do :fist:
So, I see the Flyte helm chart smth like this.
For now it contains minimal customizations for chart but it can be extended.
The Chart contains 2 configurations:
• Sandbox installation (`values-sandbox.yaml`) has been tested on Minikube with `tests/endtoent.yaml`
• EKS installation (`values-eks.yaml`) has been tested on development EKS cluster. Yes, some data is hidden, like bucket name, account number and etc.
on our main Flyte installation:
• we use Istio as ingress controller instead of Contour.
• we don’t use Kubernetes secrets, but use vault-init-agent.
• and some additional customizations
Actually, it needs additional time for improvement but I’d like share the first attempt.
|
That's a separate thing
| Ruslan Stanevich do you mind making a PR :pray:
:slightly_smiling_face:
Also does this helm chart work with kustomize?
or is this completely separate?
Yuvraj (union.ai) ^
|
It should. If it’s not working, then it’s a bug can you please file it, we can tackle ASAP
| Ketan Umare: are the `default-affinity` in k8s plugin spec not meant to work with `sidecar` tasks? `default-tolerations` work, but not `default-node-selector` or `default-affinity`.
|
ok good to know. will do
| It should. If it’s not working, then it’s a bug can you please file it, we can tackle ASAP
|
mind tagging me on the issue? I'll try to take a look soon
| ok good to know. will do
|
ok i havent had a chance to reproduce properly and write it up
ill make time on monday to do that
| mind tagging me on the issue? I'll try to take a look soon
|
no worries, Katrina Rogan we can try it out right?
i can TAL a look at the code
Just need to ensure this is used - <https://github.com/lyft/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/pod_helper.go#L24>
and we dont use it in sidecar - <https://github.com/lyft/flyteplugins/blob/master/go/tasks/plugins/k8s/sidecar/sidecar.go#L89>
Jeev B you are right
should be a simple fix
| ok i havent had a chance to reproduce properly and write it up
ill make time on monday to do that
|
ah ok
Ketan Umare does that explain why tolerations work?
| no worries, Katrina Rogan we can try it out right?
i can TAL a look at the code
Just need to ensure this is used - <https://github.com/lyft/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/pod_helper.go#L24>
and we dont use it in sidecar - <https://github.com/lyft/flyteplugins/blob/master/go/tasks/plugins/k8s/sidecar/sidecar.go#L89>
Jeev B you are right
should be a simple fix
|
ya there is code there somehow that we added tolerations specifically
we should just move this block to “Build” <https://github.com/lyft/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/pod_helper.go#L48-L61>
Katrina Rogan ^ wdyt?
| ah ok
Ketan Umare does that explain why tolerations work?
|
sweet
| ya there is code there somehow that we added tolerations specifically
we should just move this block to “Build” <https://github.com/lyft/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/pod_helper.go#L48-L61>
Katrina Rogan ^ wdyt?
|
sorry updated the link ^
| sweet
|
sounds good to me
| sorry updated the link ^
|
Katrina Rogan would you get a chance to work on this ^?
| sounds good to me
|
.
I can look today
also Jeev B do you have an issue filed for this? if not i can make one, just didn't want to duplicate :slightly_smiling_face:
| Katrina Rogan would you get a chance to work on this ^?
|
i don't have one, no. sorry!
| .
I can look today
also Jeev B do you have an issue filed for this? if not i can make one, just didn't want to duplicate :slightly_smiling_face:
|
no worries at all!
| i don't have one, no. sorry!
|
i was going to make one today, but I figured the problem was already clear...
note to self to make one anyway next time!
| no worries at all!
|
hey Jeev B have you run all the latest migrations?
| has anyone seen an error like this:
```[system] unable to retrieve launchplan information ... caused by: [SystemError] Could not fetch launch plan definition from Admin, caused by: rpc error: code = Unknown desc = failed database operation with bind message supplies 4 parameters, but prepared statement "" requires 9```
|
Weirdly implies a malformed query and this is one of the most used api
| hey Jeev B have you run all the latest migrations?
|
just crashed again with a similar issue:
```[system] unable to retrieve launchplan information ..., caused by: [SystemError] Could not fetch launch plan definition from Admin, caused by: rpc error: code = Unknown desc = failed database operation with bind message supplies 4 parameters, but prepared statement "" requires 1```
Katrina Rogan:
```Init Containers:
run-migrations:
Image: <http://docker.io/lyft/flyteadmin:v0.3.5@sha256:234bbb911f960e47445afb1577978f23495f65428682f27754e8f8192b83f10e|docker.io/lyft/flyteadmin:v0.3.5@sha256:234bbb911f960e47445afb1577978f23495f65428682f27754e8f8192b83f10e>```
that's all I'm doing. should i be doing something else as well?
ah...its possible that I tried running with a more recent version of flyteadmin, and then downgraded. that might've revved by db forward. could that potentially be a problem?
| Weirdly implies a malformed query and this is one of the most used api
|
run migrations should be all you need, but if you reverted admin you might need to rollback the migrations that are newer than your current version of admin
| just crashed again with a similar issue:
```[system] unable to retrieve launchplan information ..., caused by: [SystemError] Could not fetch launch plan definition from Admin, caused by: rpc error: code = Unknown desc = failed database operation with bind message supplies 4 parameters, but prepared statement "" requires 1```
Katrina Rogan:
```Init Containers:
run-migrations:
Image: <http://docker.io/lyft/flyteadmin:v0.3.5@sha256:234bbb911f960e47445afb1577978f23495f65428682f27754e8f8192b83f10e|docker.io/lyft/flyteadmin:v0.3.5@sha256:234bbb911f960e47445afb1577978f23495f65428682f27754e8f8192b83f10e>```
that's all I'm doing. should i be doing something else as well?
ah...its possible that I tried running with a more recent version of flyteadmin, and then downgraded. that might've revved by db forward. could that potentially be a problem?
|
ah i see
this is in a dev env. ill just wipe the DBs and try again to be sure.
| run migrations should be all you need, but if you reverted admin you might need to rollback the migrations that are newer than your current version of admin
|
Ok just saw this thread
| ah i see
this is in a dev env. ill just wipe the DBs and try again to be sure.
|
this is still happening:
```[system] unable to retrieve launchplan information ..., caused by: [SystemError] Could not fetch launch plan definition from Admin, caused by: rpc error: code = Unknown desc = failed database operation with bind message supplies 4 parameters, but prepared statement "" requires 1```
this is with a fresh DB. interestingly enough this is failing on a run that had previously succeeded and I had relaunched.
dump of some of the logs. looks like this is happening quite a bit.
| Ok just saw this thread
|
woah weird, is this only happening for executions queries now or launch plan ones too? also which version of admin are you on now?
also are you seeing these errors when during an execution or are these from hitting a specific admin endpoint/console page?
| this is still happening:
```[system] unable to retrieve launchplan information ..., caused by: [SystemError] Could not fetch launch plan definition from Admin, caused by: rpc error: code = Unknown desc = failed database operation with bind message supplies 4 parameters, but prepared statement "" requires 1```
this is with a fresh DB. interestingly enough this is failing on a run that had previously succeeded and I had relaunched.
dump of some of the logs. looks like this is happening quite a bit.
|
The execution queries aren’t causing the workflow to crash, but the launch plan one is. i imagine this would happen even if i was running headless. i’m using flyteadmin 0.3.5. interestingly, the issue isn’t always reproducible. so far the same workflow with the same inputs has succeeded twice and failed twice.
| woah weird, is this only happening for executions queries now or launch plan ones too? also which version of admin are you on now?
also are you seeing these errors when during an execution or are these from hitting a specific admin endpoint/console page?
|
That just sounds odd
Let’s look at the schema of the table
| The execution queries aren’t causing the workflow to crash, but the launch plan one is. i imagine this would happen even if i was running headless. i’m using flyteadmin 0.3.5. interestingly, the issue isn’t always reproducible. so far the same workflow with the same inputs has succeeded twice and failed twice.
|
interestingly this has been running fine in our sandbox running postgres:10.1. the prod sql instance is running postgres 11. i've downgraded that now, and will try to reproduce again. will post the schema here in a bit
```flyte=> \d+ executions
Table "public.executions"
Column | Type | Collation | Nullable | Default | Storage | Stats target | Description
--------------------------+--------------------------+-----------+----------+----------------------------------------+----------+--------------+-------------
id | integer | | not null | nextval('executions_id_seq'::regclass) | plain | |
created_at | timestamp with time zone | | | | plain | |
updated_at | timestamp with time zone | | | | plain | |
deleted_at | timestamp with time zone | | | | plain | |
execution_project | text | | not null | | extended | |
execution_domain | text | | not null | | extended | |
execution_name | text | | not null | | extended | |
launch_plan_id | integer | | | | plain | |
workflow_id | integer | | | | plain | |
task_id | integer | | | | plain | |
phase | text | | | | extended | |
closure | bytea | | | | extended | |
spec | bytea | | not null | | extended | |
started_at | timestamp with time zone | | | | plain | |
execution_created_at | timestamp with time zone | | | | plain | |
execution_updated_at | timestamp with time zone | | | | plain | |
duration | bigint | | | | plain | |
abort_cause | text | | | | extended | |
mode | integer | | | | plain | |
source_execution_id | integer | | | | plain | |
parent_node_execution_id | integer | | | | plain | |
cluster | text | | | | extended | |
inputs_uri | text | | | | extended | |
user_inputs_uri | text | | | | extended | |
error_kind | text | | | | extended | |
error_code | text | | | | extended | |
Indexes:
"executions_pkey" PRIMARY KEY, btree (execution_project, execution_domain, execution_name)
"idx_executions_deleted_at" btree (deleted_at)
"idx_executions_error_kind" btree (error_kind)
"idx_executions_id" btree (id)
"idx_executions_launch_plan_id" btree (launch_plan_id)
"idx_executions_task_id" btree (task_id)
"idx_executions_workflow_id" btree (workflow_id)```
```flyte=> \d+ launch_plans
Table "public.launch_plans"
Column | Type | Collation | Nullable | Default | Storage | Stats target | Description
---------------+--------------------------+-----------+----------+------------------------------------------+----------+--------------+-------------
id | integer | | not null | nextval('launch_plans_id_seq'::regclass) | plain | |
created_at | timestamp with time zone | | | | plain | |
updated_at | timestamp with time zone | | | | plain | |
deleted_at | timestamp with time zone | | | | plain | |
project | text | | not null | | extended | |
domain | text | | not null | | extended | |
name | text | | not null | | extended | |
version | text | | not null | | extended | |
spec | bytea | | not null | | extended | |
workflow_id | integer | | | | plain | |
closure | bytea | | not null | | extended | |
state | integer | | | 0 | plain | |
digest | bytea | | | | extended | |
schedule_type | text | | | | extended | |
Indexes:
"launch_plans_pkey" PRIMARY KEY, btree (project, domain, name, version)
"idx_launch_plans_deleted_at" btree (deleted_at)
"idx_launch_plans_id" btree (id)
"idx_launch_plans_workflow_id" btree (workflow_id)
"lp_project_domain_idx" btree (project, domain)
"lp_project_domain_name_idx" btree (project, domain, name)```
| That just sounds odd
Let’s look at the schema of the table
|
Any luck with the postgres version downgrade?
| interestingly this has been running fine in our sandbox running postgres:10.1. the prod sql instance is running postgres 11. i've downgraded that now, and will try to reproduce again. will post the schema here in a bit
```flyte=> \d+ executions
Table "public.executions"
Column | Type | Collation | Nullable | Default | Storage | Stats target | Description
--------------------------+--------------------------+-----------+----------+----------------------------------------+----------+--------------+-------------
id | integer | | not null | nextval('executions_id_seq'::regclass) | plain | |
created_at | timestamp with time zone | | | | plain | |
updated_at | timestamp with time zone | | | | plain | |
deleted_at | timestamp with time zone | | | | plain | |
execution_project | text | | not null | | extended | |
execution_domain | text | | not null | | extended | |
execution_name | text | | not null | | extended | |
launch_plan_id | integer | | | | plain | |
workflow_id | integer | | | | plain | |
task_id | integer | | | | plain | |
phase | text | | | | extended | |
closure | bytea | | | | extended | |
spec | bytea | | not null | | extended | |
started_at | timestamp with time zone | | | | plain | |
execution_created_at | timestamp with time zone | | | | plain | |
execution_updated_at | timestamp with time zone | | | | plain | |
duration | bigint | | | | plain | |
abort_cause | text | | | | extended | |
mode | integer | | | | plain | |
source_execution_id | integer | | | | plain | |
parent_node_execution_id | integer | | | | plain | |
cluster | text | | | | extended | |
inputs_uri | text | | | | extended | |
user_inputs_uri | text | | | | extended | |
error_kind | text | | | | extended | |
error_code | text | | | | extended | |
Indexes:
"executions_pkey" PRIMARY KEY, btree (execution_project, execution_domain, execution_name)
"idx_executions_deleted_at" btree (deleted_at)
"idx_executions_error_kind" btree (error_kind)
"idx_executions_id" btree (id)
"idx_executions_launch_plan_id" btree (launch_plan_id)
"idx_executions_task_id" btree (task_id)
"idx_executions_workflow_id" btree (workflow_id)```
```flyte=> \d+ launch_plans
Table "public.launch_plans"
Column | Type | Collation | Nullable | Default | Storage | Stats target | Description
---------------+--------------------------+-----------+----------+------------------------------------------+----------+--------------+-------------
id | integer | | not null | nextval('launch_plans_id_seq'::regclass) | plain | |
created_at | timestamp with time zone | | | | plain | |
updated_at | timestamp with time zone | | | | plain | |
deleted_at | timestamp with time zone | | | | plain | |
project | text | | not null | | extended | |
domain | text | | not null | | extended | |
name | text | | not null | | extended | |
version | text | | not null | | extended | |
spec | bytea | | not null | | extended | |
workflow_id | integer | | | | plain | |
closure | bytea | | not null | | extended | |
state | integer | | | 0 | plain | |
digest | bytea | | | | extended | |
schedule_type | text | | | | extended | |
Indexes:
"launch_plans_pkey" PRIMARY KEY, btree (project, domain, name, version)
"idx_launch_plans_deleted_at" btree (deleted_at)
"idx_launch_plans_id" btree (id)
"idx_launch_plans_workflow_id" btree (workflow_id)
"lp_project_domain_idx" btree (project, domain)
"lp_project_domain_name_idx" btree (project, domain, name)```
|
first run is going with postgres 10
| Any luck with the postgres version downgrade?
|
erm what do you mean?
| first run is going with postgres 10
|
so i downgraded to postgres 10 and kicked off the same workflow/inputs. did you mean something else?
| erm what do you mean?
|
Nope that exactly, I was just wondering if you see issues with that workflow?
| so i downgraded to postgres 10 and kicked off the same workflow/inputs. did you mean something else?
|
not yet. i will know in about 30 mins or so. will keep you posted! :slightly_smiling_face:
Katrina Rogan: it already crashed:
```[system] unable to retrieve launchplan information orchid:main:sunflower.workflows.flyte_workflows.fastq_to_bam_workflow.TRIM_FASTQS_AND_ALIGN_LAUNCH_PLAN:67ea184a8384cea6207037d9da31ff1a28c54b011354e5df261c9bf6be62787d, caused by: [SystemError] Could not fetch launch plan definition from Admin, caused by: rpc error: code = Unknown desc = failed database operation with bind message supplies 4 parameters, but prepared statement "" requires 3```
2 of 4 executions have failed so far.
| Nope that exactly, I was just wondering if you see issues with that workflow?
|
Jeev B are you sure you are only running one instance of flyteadmin?
| not yet. i will know in about 30 mins or so. will keep you posted! :slightly_smiling_face:
Katrina Rogan: it already crashed:
```[system] unable to retrieve launchplan information orchid:main:sunflower.workflows.flyte_workflows.fastq_to_bam_workflow.TRIM_FASTQS_AND_ALIGN_LAUNCH_PLAN:67ea184a8384cea6207037d9da31ff1a28c54b011354e5df261c9bf6be62787d, caused by: [SystemError] Could not fetch launch plan definition from Admin, caused by: rpc error: code = Unknown desc = failed database operation with bind message supplies 4 parameters, but prepared statement "" requires 3```
2 of 4 executions have failed so far.
|
yes.
| Jeev B are you sure you are only running one instance of flyteadmin?
|
if you are running more replicas, are they all running the latest version?
| yes.
|
```> kubectl get po
NAME READY STATUS RESTARTS AGE
cloud-sql-proxy-6dd6c8f4dc-29j6x 2/2 Running 0 22m
cloud-sql-proxy-6dd6c8f4dc-7gqxp 2/2 Running 0 22m
cloud-sql-proxy-6dd6c8f4dc-mgfjc 2/2 Running 0 22m
datacatalog-5669546cdd-mrn4f 1/1 Running 0 22m
flyteadmin-7cbd6b6f8f-xk4vc 3/3 Running 0 22m
flyteconsole-c8bcc85d9-gt9vc 2/2 Running 0 9d
flytepropeller-cf596c85b-z2db9 1/1 Running 0 22m
syncresources-1603645860-rfzxf 0/1 Completed 0 18s```
| if you are running more replicas, are they all running the latest version?
|
so this non determinism may be because you have 2 versions of flyteadmin
I hope its not cloudsqlproxy
| ```> kubectl get po
NAME READY STATUS RESTARTS AGE
cloud-sql-proxy-6dd6c8f4dc-29j6x 2/2 Running 0 22m
cloud-sql-proxy-6dd6c8f4dc-7gqxp 2/2 Running 0 22m
cloud-sql-proxy-6dd6c8f4dc-mgfjc 2/2 Running 0 22m
datacatalog-5669546cdd-mrn4f 1/1 Running 0 22m
flyteadmin-7cbd6b6f8f-xk4vc 3/3 Running 0 22m
flyteconsole-c8bcc85d9-gt9vc 2/2 Running 0 9d
flytepropeller-cf596c85b-z2db9 1/1 Running 0 22m
syncresources-1603645860-rfzxf 0/1 Completed 0 18s```
|
hmm... interesting point. i might be able to test that.
| so this non determinism may be because you have 2 versions of flyteadmin
I hope its not cloudsqlproxy
|
also talking to Katrina
| hmm... interesting point. i might be able to test that.
|
to wrap this up: this was an issue with our pgbouncer pooling mode. we were initially running transaction pooling mode, but switching to session pooling mode has resolved these issues. see: <https://www.pgbouncer.org/features.html|https://www.pgbouncer.org/features.html>
| also talking to Katrina
|
HI Jeev B can you describe why do you have the need to use pgbouncer? We just connect to Cloud Sql Proxy and it is working just fine for us
| to wrap this up: this was an issue with our pgbouncer pooling mode. we were initially running transaction pooling mode, but switching to session pooling mode has resolved these issues. see: <https://www.pgbouncer.org/features.html|https://www.pgbouncer.org/features.html>
|
yup! about a year ago, cloud-sql instances had a limit of 100 concurrent connections. for some other application we needed more than that, and we just made 1 reusable kustomize template for cloud-sql-proxy with pgbouncer as a sidecar. pgbouncer basically allows us to circumvent cloud-sql's limit by pooling connections.
this may not be necessary anymore. i just haven't had the chance to revisit.
Nelson Arapé more info here: <https://cloud.google.com/sql/docs/quotas#cloud-sql-for-postgresql-connection-limits>
looks like this isn't necessarily a problem anymore
| HI Jeev B can you describe why do you have the need to use pgbouncer? We just connect to Cloud Sql Proxy and it is working just fine for us
|
we’re running v0.3.5. haven’t upgraded to 0.3.6 or 0.3.7. last i tried we were getting 400/500s with gcp in flyteconsole while trying to view inputs/outputs.
| Jeev B is this latest version
|
Ya we need to add a version api
Someone is working on that
But in your overlay did you remove the run migrations
| we’re running v0.3.5. haven’t upgraded to 0.3.6 or 0.3.7. last i tried we were getting 400/500s with gcp in flyteconsole while trying to view inputs/outputs.
|
no. should i?
i imagine it should just complete if it doesnt have any new migrations to run anyway right?
| Ya we need to add a version api
Someone is working on that
But in your overlay did you remove the run migrations
|
I you shouldnt
Ya
Is this breaking production?
| no. should i?
i imagine it should just complete if it doesnt have any new migrations to run anyway right?
|
no we don’t have this in prod yet. demoing to core team on thursday though
we have been working off of ephemeral sandboxes so far, and this is working in a full prod-like env.
so we probably have some tuning to do as well
| I you shouldnt
Ya
Is this breaking production?
|
Ohh demo on Thursday that sounds critical
How can I help debug
| no we don’t have this in prod yet. demoing to core team on thursday though
we have been working off of ephemeral sandboxes so far, and this is working in a full prod-like env.
so we probably have some tuning to do as well
|
oh wow! thanks. we’re going to be running stress tests early next week. will likely need help if we’re running into issues.
| Ohh demo on Thursday that sounds critical
How can I help debug
|
Yes please do
I can just paste over all our prod config to you guys
Most important settings are going to be workflowrevisioncache and kube client settings
So before you run the stress test let’s chat Monday and I can relay all these settings
Actually I know Spotify is also scaling up things so if you want we can basically do a channel and do a VC call to explain the settings
Docs should follow one day
| oh wow! thanks. we’re going to be running stress tests early next week. will likely need help if we’re running into issues.
|
that would be awesome! I’ll ping you on Monday!
| Yes please do
I can just paste over all our prod config to you guys
Most important settings are going to be workflowrevisioncache and kube client settings
So before you run the stress test let’s chat Monday and I can relay all these settings
Actually I know Spotify is also scaling up things so if you want we can basically do a channel and do a VC call to explain the settings
Docs should follow one day
|
the problem has been completely resolved. would still love your docs/tips on scaling/stress-testing though.
| Jeev B let us know if we are still on for 10:00 am
|
ya so do we want to catch up at 10
i can
just let me know
| the problem has been completely resolved. would still love your docs/tips on scaling/stress-testing though.
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.