issue_id
int64
2.03k
426k
title
stringlengths
9
251
body
stringlengths
1
32.8k
status
stringclasses
6 values
after_fix_sha
stringlengths
7
7
project_name
stringclasses
6 values
repo_url
stringclasses
6 values
repo_name
stringclasses
6 values
language
stringclasses
1 value
issue_url
null
before_fix_sha
null
pull_url
null
commit_datetime
unknown
report_datetime
unknown
updated_file
stringlengths
2
187
file_content
stringlengths
0
368k
5,418
Bug 5418 bracket marker stays in editor
private void showDebugSourcePage(String typeName) { if (dialog.open() == dialog.OK) { } 1. set the cursor after the opening bracket (after dialog.OK) 2. press enter 3. The bracket box includes all characters insterted by the auto indenter
resolved fixed
d287924
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-01T19:13:57Z"
"2001-11-01T15:53:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/JavaSourceViewerConfiguration.java
package org.eclipse.jdt.ui.text; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.text.DefaultTextDoubleClickStrategy; import org.eclipse.jface.text.DefaultInformationControl; import org.eclipse.jface.text.IAutoIndentStrategy; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IInformationControl; import org.eclipse.jface.text.IInformationControlCreator; import org.eclipse.jface.text.ITextDoubleClickStrategy; import org.eclipse.jface.text.ITextHover; import org.eclipse.jface.text.TextAttribute; import org.eclipse.jface.text.contentassist.ContentAssistant; import org.eclipse.jface.text.contentassist.IContentAssistant; import org.eclipse.jface.text.formatter.ContentFormatter; import org.eclipse.jface.text.formatter.IContentFormatter; import org.eclipse.jface.text.formatter.IFormattingStrategy; import org.eclipse.jface.text.information.IInformationPresenter; import org.eclipse.jface.text.information.IInformationProvider; import org.eclipse.jface.text.information.InformationPresenter; import org.eclipse.jface.text.internal.html.HoverBrowserControl; import org.eclipse.jface.text.presentation.IPresentationReconciler; import org.eclipse.jface.text.presentation.PresentationReconciler; import org.eclipse.jface.text.reconciler.IReconciler; import org.eclipse.jface.text.reconciler.MonoReconciler; import org.eclipse.jface.text.rules.RuleBasedDamagerRepairer; import org.eclipse.jface.text.rules.RuleBasedScanner; import org.eclipse.jface.text.rules.Token; import org.eclipse.jface.text.source.IAnnotationHover; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.SourceViewerConfiguration; import org.eclipse.ui.texteditor.ITextEditor; import org.eclipse.jdt.internal.ui.text.HTMLTextPresenter; import org.eclipse.jdt.internal.ui.text.JavaAnnotationHover; import org.eclipse.jdt.internal.ui.text.JavaPartitionScanner; import org.eclipse.jdt.internal.ui.text.java.JavaAutoIndentStrategy; import org.eclipse.jdt.internal.ui.text.java.JavaCompletionProcessor; import org.eclipse.jdt.internal.ui.text.java.JavaDoubleClickSelector; import org.eclipse.jdt.internal.ui.text.java.JavaFormattingStrategy; import org.eclipse.jdt.internal.ui.text.java.JavaReconcilingStrategy; import org.eclipse.jdt.internal.ui.text.java.hover.JavaTextHover; import org.eclipse.jdt.internal.ui.text.javadoc.JavaDocAutoIndentStrategy; import org.eclipse.jdt.internal.ui.text.javadoc.JavaDocCompletionProcessor; /** * Configuration for a source viewer which shows Java code. * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> */ public class JavaSourceViewerConfiguration extends SourceViewerConfiguration { private JavaTextTools fJavaTextTools; private ITextEditor fTextEditor; /** * Creates a new Java source viewer configuration for viewers in the given editor * using the given Java tools. * * @param tools the Java tools to be used * @param editor the editor in which the configured viewer(s) will reside */ public JavaSourceViewerConfiguration(JavaTextTools tools, ITextEditor editor) { fJavaTextTools= tools; fTextEditor= editor; } /** * Returns the Java source code scanner for this configuration. * * @return the Java source code scanner */ protected RuleBasedScanner getCodeScanner() { return fJavaTextTools.getCodeScanner(); } /** * Returns the JavaDoc scanner for this configuration. * * @return the JavaDoc scanner */ protected RuleBasedScanner getJavaDocScanner() { return fJavaTextTools.getJavaDocScanner(); } /** * Returns the color manager for this configuration. * * @return the color manager */ protected IColorManager getColorManager() { return fJavaTextTools.getColorManager(); } /** * Returns the editor in which the configured viewer(s) will reside. * * @return the enclosing editor */ protected ITextEditor getEditor() { return fTextEditor; } /* * @see ISourceViewerConfiguration#getPresentationReconciler(ISourceViewer) */ public IPresentationReconciler getPresentationReconciler(ISourceViewer sourceViewer) { IColorManager manager= getColorManager(); PresentationReconciler reconciler= new PresentationReconciler(); RuleBasedDamagerRepairer dr= new RuleBasedDamagerRepairer(getCodeScanner()); reconciler.setDamager(dr, IDocument.DEFAULT_CONTENT_TYPE); reconciler.setRepairer(dr, IDocument.DEFAULT_CONTENT_TYPE); dr= new RuleBasedDamagerRepairer(getJavaDocScanner()); reconciler.setDamager(dr, JavaPartitionScanner.JAVA_DOC); reconciler.setRepairer(dr, JavaPartitionScanner.JAVA_DOC); RuleBasedScanner scanner= new RuleBasedScanner(); scanner.setDefaultReturnToken(new Token(new TextAttribute(manager.getColor(IJavaColorConstants.JAVA_MULTI_LINE_COMMENT)))); dr= new RuleBasedDamagerRepairer(scanner); reconciler.setDamager(dr, JavaPartitionScanner.JAVA_MULTI_LINE_COMMENT); reconciler.setRepairer(dr, JavaPartitionScanner.JAVA_MULTI_LINE_COMMENT); scanner= new RuleBasedScanner(); scanner.setDefaultReturnToken(new Token(new TextAttribute(manager.getColor(IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT)))); dr= new RuleBasedDamagerRepairer(scanner); reconciler.setDamager(dr, JavaPartitionScanner.JAVA_SINGLE_LINE_COMMENT); reconciler.setRepairer(dr, JavaPartitionScanner.JAVA_SINGLE_LINE_COMMENT); return reconciler; } /* * @see SourceViewerConfiguration#getContentAssistant(ISourceViewer) */ public IContentAssistant getContentAssistant(ISourceViewer sourceViewer) { ContentAssistant assistant= new ContentAssistant(); assistant.setContentAssistProcessor(new JavaCompletionProcessor(getEditor()), IDocument.DEFAULT_CONTENT_TYPE); assistant.setContentAssistProcessor(new JavaDocCompletionProcessor(getEditor()), JavaPartitionScanner.JAVA_DOC); assistant.enableAutoActivation(true); assistant.setAutoActivationDelay(500); assistant.setProposalPopupOrientation(assistant.PROPOSAL_OVERLAY); assistant.setContextInformationPopupOrientation(assistant.CONTEXT_INFO_ABOVE); assistant.setInformationControlCreator(getInformationControlCreator(sourceViewer)); Color background= getColorManager().getColor(new RGB(254, 241, 233)); assistant.setContextInformationPopupBackground(background); assistant.setContextSelectorBackground(background); assistant.setProposalSelectorBackground(background); return assistant; } /* * @see SourceViewerConfiguration#getReconciler(ISourceViewer) */ public IReconciler getReconciler(ISourceViewer sourceViewer) { if (getEditor() != null && getEditor().isEditable()) { MonoReconciler reconciler= new MonoReconciler(new JavaReconcilingStrategy(getEditor()), false); reconciler.setDelay(500); return reconciler; } return null; } /* * @see SourceViewerConfiguration#getAutoIndentStrategy(ISourceViewer, String) */ public IAutoIndentStrategy getAutoIndentStrategy(ISourceViewer sourceViewer, String contentType) { if (JavaPartitionScanner.JAVA_DOC.equals(contentType) || JavaPartitionScanner.JAVA_MULTI_LINE_COMMENT.equals(contentType)) return new JavaDocAutoIndentStrategy(); return new JavaAutoIndentStrategy(); } /* * @see SourceViewerConfiguration#getDoubleClickStrategy(ISourceViewer, String) */ public ITextDoubleClickStrategy getDoubleClickStrategy(ISourceViewer sourceViewer, String contentType) { if (JavaPartitionScanner.JAVA_DOC.equals(contentType) || JavaPartitionScanner.JAVA_MULTI_LINE_COMMENT.equals(contentType) || JavaPartitionScanner.JAVA_SINGLE_LINE_COMMENT.equals(contentType)) return new DefaultTextDoubleClickStrategy(); return new JavaDoubleClickSelector(); } /* * @see SourceViewerConfiguration#getDefaultPrefix(ISourceViewer, String) */ public String[] getDefaultPrefixes(ISourceViewer sourceViewer, String contentType) { return new String[] { "//", "" }; } /* * @see SourceViewerConfiguration#getIndentPrefixes(ISourceViewer, String) */ public String[] getIndentPrefixes(ISourceViewer sourceViewer, String contentType) { return new String[] {"\t", " ", ""}; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ } /* * @see SourceViewerConfiguration#getTabWidth(ISourceViewer) */ public int getTabWidth(ISourceViewer sourceViewer) { return 4; } /* * @see SourceViewerConfiguration#getAnnotationHover(ISourceViewer) */ public IAnnotationHover getAnnotationHover(ISourceViewer sourceViewer) { return new JavaAnnotationHover(); } /* * @see SourceViewerConfiguration#getTextHover(ISourceViewer, String) */ public ITextHover getTextHover(ISourceViewer sourceViewer, String contentType) { return new JavaTextHover(getEditor()); } /* * @see SourceViewerConfiguration#getConfiguredContentTypes(ISourceViewer) */ public String[] getConfiguredContentTypes(ISourceViewer sourceViewer) { return new String[] { IDocument.DEFAULT_CONTENT_TYPE, JavaPartitionScanner.JAVA_DOC, JavaPartitionScanner.JAVA_MULTI_LINE_COMMENT, JavaPartitionScanner.JAVA_SINGLE_LINE_COMMENT }; } /* * @see SourceViewerConfiguration#getContentFormatter(ISourceViewer) */ public IContentFormatter getContentFormatter(ISourceViewer sourceViewer) { ContentFormatter formatter= new ContentFormatter(); IFormattingStrategy strategy= new JavaFormattingStrategy(sourceViewer); formatter.setFormattingStrategy(strategy, IDocument.DEFAULT_CONTENT_TYPE); formatter.enablePartitionAwareFormatting(false); formatter.setPartitionManagingPositionCategories(fJavaTextTools.getPartitionManagingPositionCategories()); return formatter; } /* * @see SourceViewerConfiguration#getHoverControlCreator(ISourceViewer) */ public IInformationControlCreator getInformationControlCreator(ISourceViewer sourceViewer) { return getInformationControlCreator(sourceViewer, true); } private IInformationControlCreator getInformationControlCreator(ISourceViewer sourceViewer, final boolean cutDown) { return new IInformationControlCreator() { public IInformationControl createInformationControl(Shell parent) { int style= cutDown ? SWT.NONE : (SWT.V_SCROLL | SWT.H_SCROLL); return new DefaultInformationControl(parent, style, new HTMLTextPresenter(cutDown)); // return new HoverBrowserControl(parent); } }; } /* * @see SourceViewerConfiguration#getInformationPresenter(ISourceViewer) */ public IInformationPresenter getInformationPresenter(ISourceViewer sourceViewer) { InformationPresenter presenter= new InformationPresenter(getInformationControlCreator(sourceViewer, false)); IInformationProvider provider= new JavaTextHover(getEditor()); presenter.setInformationProvider(provider, IDocument.DEFAULT_CONTENT_TYPE); presenter.setInformationProvider(provider, JavaPartitionScanner.JAVA_DOC); presenter.setSizeConstraints(60, 10, true, true); return presenter; } }
5,452
Bug 5452 Typehierarchy: can't see full label in method list
The label is shown with "..." even though the view has a horizontal scrollbar. This is critical since when showin inherited members the lable can be long.
resolved fixed
3cee768
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-02T14:45:01Z"
"2001-11-02T08:33:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/MethodsViewer.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.typehierarchy; import java.util.Set; import org.eclipse.swt.SWT; import org.eclipse.swt.events.ControlAdapter; import org.eclipse.swt.events.ControlEvent; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Item; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.ScrollBar; import org.eclipse.swt.widgets.Table; import org.eclipse.swt.widgets.TableColumn; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.action.ToolBarManager; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.TableViewer; import org.eclipse.jface.viewers.Viewer; import org.eclipse.ui.IMemento; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchPartSite; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.actions.GenerateGroup; import org.eclipse.jdt.internal.ui.actions.OpenSourceReferenceAction; import org.eclipse.jdt.internal.ui.search.JavaSearchGroup; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.viewsupport.IProblemChangedListener; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementSorter; import org.eclipse.jdt.internal.ui.viewsupport.MarkerErrorTickProvider; import org.eclipse.jdt.internal.ui.viewsupport.ProblemItemMapper; /** * Method viewer shows a list of methods of a input type. * Offers filter actions. * No dependency to the type hierarchy view */ public class MethodsViewer extends TableViewer implements IProblemChangedListener { private ProblemItemMapper fProblemItemMapper; /** * Sorter that uses the unmodified labelprovider (No declaring class names) */ private static class MethodsViewerSorter extends JavaElementSorter { public MethodsViewerSorter() { } public int compare(Viewer viewer, Object e1, Object e2) { int cat1 = category(e1); int cat2 = category(e2); if (cat1 != cat2) return cat1 - cat2; // cat1 == cat2 String name1= JavaElementLabels.getElementLabel((IJavaElement) e1, JavaElementLabels.ALL_DEFAULT); String name2= JavaElementLabels.getElementLabel((IJavaElement) e2, JavaElementLabels.ALL_DEFAULT); return getCollator().compare(name1, name2); } } private static final String TAG_HIDEFIELDS= "hidefields"; //$NON-NLS-1$ private static final String TAG_HIDESTATIC= "hidestatic"; //$NON-NLS-1$ private static final String TAG_HIDENONPUBLIC= "hidenonpublic"; //$NON-NLS-1$ private static final String TAG_SHOWINHERITED= "showinherited"; //$NON-NLS-1$ private static final String TAG_VERTICAL_SCROLL= "mv_vertical_scroll"; //$NON-NLS-1$ private MethodsViewerFilterAction[] fFilterActions; private MethodsViewerFilter fFilter; private OpenSourceReferenceAction fOpen; private ShowInheritedMembersAction fShowInheritedMembersAction; private ContextMenuGroup[] fStandardGroups; public MethodsViewer(Composite parent, IWorkbenchPart part) { super(new Table(parent, SWT.MULTI)); fProblemItemMapper= new ProblemItemMapper(); final Table table= getTable(); final TableColumn column= new TableColumn(table, SWT.NULL | SWT.MULTI | SWT.FULL_SELECTION); table.addControlListener(new ControlAdapter() { public void controlResized(ControlEvent e) { int width= table.getSize().x- 2*table.getBorderWidth(); if (width < 0) { width= 0; } column.setWidth(width); } }); JavaElementLabelProvider lprovider= new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT); lprovider.setErrorTickManager(new MarkerErrorTickProvider()); MethodsContentProvider contentProvider= new MethodsContentProvider(); setLabelProvider(lprovider); setContentProvider(contentProvider); fOpen= new OpenSourceReferenceAction(this); addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent event) { fOpen.run(); } }); fFilter= new MethodsViewerFilter(); // fields String title= TypeHierarchyMessages.getString("MethodsViewer.hide_fields.label"); //$NON-NLS-1$ String helpContext= IJavaHelpContextIds.FILTER_FIELDS_ACTION; MethodsViewerFilterAction hideFields= new MethodsViewerFilterAction(this, title, MethodsViewerFilter.FILTER_FIELDS, helpContext, false); hideFields.setDescription(TypeHierarchyMessages.getString("MethodsViewer.hide_fields.description")); //$NON-NLS-1$ hideFields.setToolTipChecked(TypeHierarchyMessages.getString("MethodsViewer.hide_fields.tooltip.checked")); //$NON-NLS-1$ hideFields.setToolTipUnchecked(TypeHierarchyMessages.getString("MethodsViewer.hide_fields.tooltip.unchecked")); //$NON-NLS-1$ JavaPluginImages.setLocalImageDescriptors(hideFields, "fields_co.gif"); //$NON-NLS-1$ // static title= TypeHierarchyMessages.getString("MethodsViewer.hide_static.label"); //$NON-NLS-1$ helpContext= IJavaHelpContextIds.FILTER_STATIC_ACTION; MethodsViewerFilterAction hideStatic= new MethodsViewerFilterAction(this, title, MethodsViewerFilter.FILTER_STATIC, helpContext, false); hideStatic.setDescription(TypeHierarchyMessages.getString("MethodsViewer.hide_static.description")); //$NON-NLS-1$ hideStatic.setToolTipChecked(TypeHierarchyMessages.getString("MethodsViewer.hide_static.tooltip.checked")); //$NON-NLS-1$ hideStatic.setToolTipUnchecked(TypeHierarchyMessages.getString("MethodsViewer.hide_static.tooltip.unchecked")); //$NON-NLS-1$ JavaPluginImages.setLocalImageDescriptors(hideStatic, "static_co.gif"); //$NON-NLS-1$ // non-public title= TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.label"); //$NON-NLS-1$ helpContext= IJavaHelpContextIds.FILTER_PUBLIC_ACTION; MethodsViewerFilterAction hideNonPublic= new MethodsViewerFilterAction(this, title, MethodsViewerFilter.FILTER_NONPUBLIC, helpContext, false); hideNonPublic.setDescription(TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.description")); //$NON-NLS-1$ hideNonPublic.setToolTipChecked(TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.tooltip.checked")); //$NON-NLS-1$ hideNonPublic.setToolTipUnchecked(TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.tooltip.unchecked")); //$NON-NLS-1$ JavaPluginImages.setLocalImageDescriptors(hideNonPublic, "public_co.gif"); //$NON-NLS-1$ // order corresponds to order in toolbar fFilterActions= new MethodsViewerFilterAction[] { hideFields, hideStatic, hideNonPublic }; addFilter(fFilter); fShowInheritedMembersAction= new ShowInheritedMembersAction(this, false); showInheritedMethods(false); fStandardGroups= new ContextMenuGroup[] { new JavaSearchGroup(), new GenerateGroup() }; setSorter(new MethodsViewerSorter()); } /** * Show inherited methods */ public void showInheritedMethods(boolean on) { MethodsContentProvider cprovider= (MethodsContentProvider) getContentProvider(); try { cprovider.showInheritedMethods(on); fShowInheritedMembersAction.setChecked(on); JavaElementLabelProvider lprovider= (JavaElementLabelProvider) getLabelProvider(); if (on) { lprovider.turnOn(JavaElementLabelProvider.SHOW_POST_QUALIFIED); } else { lprovider.turnOff(JavaElementLabelProvider.SHOW_POST_QUALIFIED); } refresh(); } catch (JavaModelException e) { ExceptionHandler.handle(e, getControl().getShell(), TypeHierarchyMessages.getString("MethodsViewer.toggle.error.title"), TypeHierarchyMessages.getString("MethodsViewer.toggle.error.message")); //$NON-NLS-2$ //$NON-NLS-1$ } } /** * Returns <code>true</code> if inherited methods are shown. */ public boolean isShowInheritedMethods() { return ((MethodsContentProvider) getContentProvider()).isShowInheritedMethods(); } /** * Filters the method list */ public void setMemberFilter(int filterProperty, boolean set) { if (set) { fFilter.addFilter(filterProperty); } else { fFilter.removeFilter(filterProperty); } for (int i= 0; i < fFilterActions.length; i++) { if (fFilterActions[i].getFilterProperty() == filterProperty) { fFilterActions[i].setChecked(set); } } refresh(); } /** * Returns <code>true</code> if the given filter is set. */ public boolean hasMemberFilter(int filterProperty) { return fFilter.hasFilter(filterProperty); } /** * Saves the state of the filter actions */ public void saveState(IMemento memento) { memento.putString(TAG_HIDEFIELDS, String.valueOf(hasMemberFilter(MethodsViewerFilter.FILTER_FIELDS))); memento.putString(TAG_HIDESTATIC, String.valueOf(hasMemberFilter(MethodsViewerFilter.FILTER_STATIC))); memento.putString(TAG_HIDENONPUBLIC, String.valueOf(hasMemberFilter(MethodsViewerFilter.FILTER_NONPUBLIC))); memento.putString(TAG_SHOWINHERITED, String.valueOf(isShowInheritedMethods())); ScrollBar bar= getTable().getVerticalBar(); int position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_VERTICAL_SCROLL, String.valueOf(position)); } /** * Restores the state of the filter actions */ public void restoreState(IMemento memento) { boolean set= Boolean.valueOf(memento.getString(TAG_HIDEFIELDS)).booleanValue(); setMemberFilter(MethodsViewerFilter.FILTER_FIELDS, set); set= Boolean.valueOf(memento.getString(TAG_HIDESTATIC)).booleanValue(); setMemberFilter(MethodsViewerFilter.FILTER_STATIC, set); set= Boolean.valueOf(memento.getString(TAG_HIDENONPUBLIC)).booleanValue(); setMemberFilter(MethodsViewerFilter.FILTER_NONPUBLIC, set); set= Boolean.valueOf(memento.getString(TAG_SHOWINHERITED)).booleanValue(); showInheritedMethods(set); ScrollBar bar= getTable().getVerticalBar(); if (bar != null) { Integer vScroll= memento.getInteger(TAG_VERTICAL_SCROLL); if (vScroll != null) { bar.setSelection(vScroll.intValue()); } } } /** * Attaches a contextmenu listener to the table */ public void initContextMenu(IMenuListener menuListener, String popupId, IWorkbenchPartSite viewSite) { MenuManager menuMgr= new MenuManager(); menuMgr.setRemoveAllWhenShown(true); menuMgr.addMenuListener(menuListener); Menu menu= menuMgr.createContextMenu(getTable()); getTable().setMenu(menu); viewSite.registerContextMenu(popupId, menuMgr, this); } /** * Fills up the context menu with items for the method viewer * Should be called by the creator of the context menu */ public void contributeToContextMenu(IMenuManager menu) { menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, fOpen); ContextMenuGroup.add(menu, fStandardGroups, this); } /** * Fills up the tool bar with items for the method viewer * Should be called by the creator of the tool bar */ public void contributeToToolBar(ToolBarManager tbm) { tbm.add(fShowInheritedMembersAction); tbm.add(new Separator()); tbm.add(fFilterActions[0]); // fields tbm.add(fFilterActions[1]); // static tbm.add(fFilterActions[2]); // public } /* * @see IProblemChangedListener#problemsChanged */ public void problemsChanged(final Set changed) { Control control= getControl(); if (control != null && !control.isDisposed()) { control.getDisplay().asyncExec(new Runnable() { public void run() { fProblemItemMapper.problemsChanged(changed, (ILabelProvider)getLabelProvider()); } }); } } /* * @see StructuredViewer#associate(Object, Item) */ protected void associate(Object element, Item item) { if (item.getData() != element) { fProblemItemMapper.addToMap(element, item); } super.associate(element, item); } /* * @see StructuredViewer#disassociate(Item) */ protected void disassociate(Item item) { fProblemItemMapper.removeFromMap(item.getData(), item); super.disassociate(item); } }
5,474
Bug 5474 should not use tool tips for labels
To be consistent with other preference pages, the debug preference labels for step filtering (filter sythetic methods, etc), should not specify tool tips. Instead, the relevant information should just be in the label.
verified fixed
63aabcb
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-02T23:43:07Z"
"2001-11-02T16:53:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java
package org.eclipse.jdt.internal.ui.preferences; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.ArrayList; import java.util.HashSet; import java.util.Iterator; import java.util.List; import java.util.Set; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.debug.core.JDIDebugModel; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.IPreferencesConstants; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.dialogs.ElementListSelectionDialog; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.ui.IJavaElementSearchConstants; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.CheckboxTableViewer; import org.eclipse.jface.viewers.ICellEditorValidator; import org.eclipse.jface.viewers.ICellModifier; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredContentProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.ITableLabelProvider; import org.eclipse.jface.viewers.LabelProvider; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.Viewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.TableEditor; import org.eclipse.swt.events.FocusAdapter; import org.eclipse.swt.events.FocusEvent; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Table; import org.eclipse.swt.widgets.TableItem; import org.eclipse.swt.widgets.Text; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.dialogs.SelectionDialog; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.model.WorkbenchViewerSorter; /** * Preference page for debug preferences that apply specifically to * Java Debugging. */ public class JavaDebugPreferencePage extends PreferencePage implements IWorkbenchPreferencePage, Listener { // Preference store keys private static final String SHOW_HEX= IPreferencesConstants.SHOW_HEX_VALUES; private static final String SHOW_CHARS= IPreferencesConstants.SHOW_CHAR_VALUES; private static final String SHOW_UNSIGNED= IPreferencesConstants.SHOW_UNSIGNED_VALUES; private static final String DEFAULT_NEW_FILTER_TEXT = ""; private static final Image IMG_CUNIT = JavaPluginImages.get(JavaPluginImages.IMG_OBJS_CUNIT); private static final Image IMG_PKG = JavaPluginImages.get(JavaPluginImages.IMG_OBJS_PACKAGE); // Preference widgets private Button fHexButton; private Button fCharButton; private Button fUnsignedButton; private CheckboxTableViewer fFilterViewer; private Table fFilterTable; private Button fUseFiltersCheckbox; private Button fAddPackageButton; private Button fAddTypeButton; private Button fRemoveFilterButton; private Button fAddFilterButton; private Button fFilterSyntheticButton; private Button fFilterStaticButton; private Button fFilterConstructorButton; private Text fEditorText; private TableEditor fTableEditor; private TableItem fNewTableItem; private StepFilter fNewStepFilter; // table columns private static final String[] TABLE_COLUMN_PROPERTIES = {"filter_name"}; //$NON-NLS-1$ private static final int FILTERNAME_PROP= 0; private StepFilterContentProvider fStepFilterContentProvider; private ICellEditorValidator fCellValidator; /** * Model object that represents a single entry in the table */ protected class StepFilter { private String fName; private boolean fChecked; public StepFilter(String name, boolean checked) { setName(name); setChecked(checked); } public String getName() { return fName; } public void setName(String name) { fName = name; } public boolean isChecked() { return fChecked; } public void setChecked(boolean checked) { fChecked = checked; } } /** * Content provider for the table. Content consists of instances of StepFilter. */ protected class StepFilterContentProvider implements IStructuredContentProvider { private CheckboxTableViewer fViewer; private List fFilters; public StepFilterContentProvider(CheckboxTableViewer viewer) { fViewer = viewer; List active = JDIDebugModel.getActiveStepFilters(); List inactive = JDIDebugModel.getInactiveStepFilters(); populateFilters(active, inactive); } public void setDefaults() { fViewer.remove(fFilters.toArray()); List active = JDIDebugModel.getDefaultActiveStepFilters(); List inactive = JDIDebugModel.getDefaultInactiveStepFilters(); populateFilters(active, inactive); fFilterSyntheticButton.setSelection(JDIDebugModel.getDefaultFilterSynthetic()); fFilterStaticButton.setSelection(JDIDebugModel.getDefaultFilterStatic()); fFilterConstructorButton.setSelection(JDIDebugModel.getDefaultFilterConstructor()); boolean useStepFilters = JDIDebugModel.getDefaultUseStepFilters(); fUseFiltersCheckbox.setSelection(useStepFilters); toggleStepFilterWidgetsEnabled(useStepFilters); } protected void populateFilters(List activeList, List inactiveList) { fFilters = new ArrayList(activeList.size() + inactiveList.size()); populateList(activeList, true); populateList(inactiveList, false); } protected void populateList(List list, boolean checked) { Iterator iterator = list.iterator(); while (iterator.hasNext()) { String name = (String)iterator.next(); addFilter(name, checked); } } public StepFilter addFilter(String name, boolean checked) { StepFilter filter = new StepFilter(name, checked); if (!fFilters.contains(filter)) { fFilters.add(filter); fViewer.add(filter); fViewer.setChecked(filter, checked); } return filter; } public void saveFilters() { JDIDebugModel.setUseStepFilters(fUseFiltersCheckbox.getSelection()); JDIDebugModel.setFilterSynthetic(fFilterSyntheticButton.getSelection()); JDIDebugModel.setFilterStatic(fFilterStaticButton.getSelection()); JDIDebugModel.setFilterConstructor(fFilterConstructorButton.getSelection()); List active = new ArrayList(fFilters.size()); List inactive = new ArrayList(fFilters.size()); Iterator iterator = fFilters.iterator(); while (iterator.hasNext()) { StepFilter filter = (StepFilter)iterator.next(); String name = filter.getName(); if (filter.isChecked()) { active.add(name); } else { inactive.add(name); } } JDIDebugModel.setActiveStepFilters(active); JDIDebugModel.setInactiveStepFilters(inactive); } public void removeFilters(Object[] filters) { for (int i = 0; i < filters.length; i++) { StepFilter filter = (StepFilter)filters[i]; fFilters.remove(filter); } fViewer.remove(filters); } public void toggleFilter(StepFilter filter) { boolean newState = !filter.isChecked(); filter.setChecked(newState); fViewer.setChecked(filter, newState); } /* * @see IStructuredContentProvider#getElements(Object) */ public Object[] getElements(Object inputElement) { return fFilters.toArray(); } /* * @see IContentProvider#inputChanged(Viewer, Object, Object) */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { } /* * @see IContentProvider#dispose() */ public void dispose() { } } /** * Support for editing entries in filter table. */ protected class CellModifier implements ICellModifier { public CellModifier() { } /* * @see ICellModifier#canModify(Object, String) */ public boolean canModify(Object element, String property) { return isNameProperty(property); } /* * @see ICellModifier#getValue(Object, String) */ public Object getValue(Object element, String property) { if (isNameProperty(property)) { StepFilter filter = (StepFilter)element; return filter.getName(); } return null; } /* * @see ICellModifier#modify(Object, String, Object) */ public void modify(Object element, String property, Object value) { if (value != null) { if (isNameProperty(property) && element instanceof TableItem) { String stringValue = (String) value; TableItem tableItem = (TableItem)element; StepFilter filter = (StepFilter)tableItem.getData(); filter.setName(stringValue); tableItem.setText(stringValue); } } } private boolean isNameProperty(String property) { return property.equals(TABLE_COLUMN_PROPERTIES[FILTERNAME_PROP]); } }; /** * Label provider for StepFilter model objects */ protected class StepFilterLabelProvider extends LabelProvider implements ITableLabelProvider { /* * @see ITableLabelProvider#getColumnText(Object, int) */ public String getColumnText(Object object, int column) { if (column == 0) { return ((StepFilter)object).getName(); } return ""; //$NON-NLS-1$ } /* * @see ILabelProvider#getText(Object) */ public String getText(Object element) { return ((StepFilter)element).getName(); } /* * @see ITableLabelProvider#getColumnImage(Object, int) */ public Image getColumnImage(Object object, int column) { String name = ((StepFilter)object).getName(); if (name.endsWith(".*")) { return IMG_PKG; } else { return IMG_CUNIT; } } } public JavaDebugPreferencePage() { super(); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); } /** * Set the default preferences for this page. */ public static void initDefaults(IPreferenceStore store) { store.setDefault(SHOW_HEX, false); store.setDefault(SHOW_CHARS, false); store.setDefault(SHOW_UNSIGNED, false); } /** * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { WorkbenchHelp.setHelp(getControl(), new DialogPageContextComputer(this, IJavaHelpContextIds.JAVA_BASE_PREFERENCE_PAGE)); //The main composite Composite composite = new Composite(parent, SWT.NULL); GridLayout layout = new GridLayout(); layout.numColumns = 1; composite.setLayout(layout); GridData data = new GridData(); data.verticalAlignment = GridData.FILL; data.horizontalAlignment = GridData.FILL; composite.setLayoutData(data); createPrimitiveDisplayPreferences(composite); createSpace(composite); createStepFilterPreferences(composite); setValues(); return composite; } /** * Create the primitive display preferences composite widget */ private void createPrimitiveDisplayPreferences(Composite parent) { Composite comp= createLabelledComposite(parent, 1, "Primitive type display options"); fHexButton= createCheckButton(comp, "Display &hexadecimal values (byte, short, char, int, long)"); fCharButton= createCheckButton(comp, "Display ASCII &character values (byte, short, int, long)"); fUnsignedButton= createCheckButton(comp, "Display &unsigned values (byte)"); } /** * Create a group to contain the step filter related widgetry */ private void createStepFilterPreferences(Composite parent) { Composite comp = createLabelledComposite(parent, 1, "Step filters"); // top level container Composite container = new Composite(comp, SWT.NONE); GridLayout layout = new GridLayout(); layout.numColumns = 2; layout.marginHeight = 0; layout.marginWidth = 0; container.setLayout(layout); // use filters checkbox fUseFiltersCheckbox = new Button(container, SWT.CHECK); fUseFiltersCheckbox.setText("Use &step filters"); fUseFiltersCheckbox.setToolTipText("Toggle whether step filters are used at all"); GridData gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalSpan = 2; fUseFiltersCheckbox.setLayoutData(gd); fUseFiltersCheckbox.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent se) { toggleStepFilterWidgetsEnabled(fUseFiltersCheckbox.getSelection()); } public void widgetDefaultSelected(SelectionEvent se) { } }); // filter table fFilterViewer = new CheckboxTableViewer(container, SWT.BORDER | SWT.MULTI | SWT.FULL_SELECTION); fFilterTable = fFilterViewer.getTable(); fTableEditor = new TableEditor(fFilterTable); fFilterViewer.setLabelProvider(new StepFilterLabelProvider()); fFilterViewer.setSorter(new WorkbenchViewerSorter()); fStepFilterContentProvider = new StepFilterContentProvider(fFilterViewer); fFilterViewer.setContentProvider(fStepFilterContentProvider); fFilterViewer.setInput(JDIDebugModel.getAllStepFilters()); gd = new GridData(GridData.FILL_BOTH | GridData.GRAB_HORIZONTAL | GridData.GRAB_VERTICAL); gd.heightHint = 150; gd.widthHint = 300; fFilterViewer.getTable().setLayoutData(gd); fFilterViewer.addCheckStateListener(new ICheckStateListener() { public void checkStateChanged(CheckStateChangedEvent event) { StepFilter filter = (StepFilter)event.getElement(); fStepFilterContentProvider.toggleFilter(filter); } }); fFilterViewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { ISelection selection = event.getSelection(); if (selection.isEmpty()) { fRemoveFilterButton.setEnabled(false); } else { fRemoveFilterButton.setEnabled(true); } } }); // button container Composite buttonContainer = new Composite(container, SWT.NONE); gd = new GridData(GridData.FILL_VERTICAL); buttonContainer.setLayoutData(gd); GridLayout buttonLayout = new GridLayout(); buttonLayout.numColumns = 1; buttonLayout.marginHeight = 0; buttonLayout.marginWidth = 0; buttonContainer.setLayout(buttonLayout); // Add filter button fAddFilterButton = new Button(buttonContainer, SWT.PUSH); fAddFilterButton.setText("Add &Filter"); fAddFilterButton.setToolTipText("Key in the name of a new step filter"); gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING); fAddFilterButton.setLayoutData(gd); fAddFilterButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent se) { addActiveFilter(); } public void widgetDefaultSelected(SelectionEvent se) { } }); // Add type button fAddTypeButton = new Button(buttonContainer, SWT.PUSH); fAddTypeButton.setText("Add &Type..."); fAddTypeButton.setToolTipText("Choose a java type and add it to step filters"); gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING); fAddTypeButton.setLayoutData(gd); fAddTypeButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent se) { addType(); } public void widgetDefaultSelected(SelectionEvent se) { } }); // Add package button fAddPackageButton = new Button(buttonContainer, SWT.PUSH); fAddPackageButton.setText("Add &Package..."); fAddPackageButton.setToolTipText("Choose a package and add it to step filters"); gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING); fAddPackageButton.setLayoutData(gd); fAddPackageButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent se) { addPackage(); } public void widgetDefaultSelected(SelectionEvent se) { } }); // Remove button fRemoveFilterButton = new Button(buttonContainer, SWT.PUSH); fRemoveFilterButton.setText("&Remove"); fRemoveFilterButton.setToolTipText("Remove all selected step filters"); gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING); fRemoveFilterButton.setLayoutData(gd); fRemoveFilterButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent se) { removeFilters(); } public void widgetDefaultSelected(SelectionEvent se) { } }); fRemoveFilterButton.setEnabled(false); // filter synthetic checkbox fFilterSyntheticButton = new Button(container, SWT.CHECK); fFilterSyntheticButton.setText("Filter s&ynthetic methods (requires VM support)"); fFilterSyntheticButton.setToolTipText("Don't stop in synthetic (compiler-generated) methods"); gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalSpan = 2; fFilterSyntheticButton.setLayoutData(gd); // filter static checkbox fFilterStaticButton = new Button(container, SWT.CHECK); fFilterStaticButton.setText("Filter static &initializers"); fFilterStaticButton.setToolTipText("Don't stop in static initialization code"); gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalSpan = 2; fFilterStaticButton.setLayoutData(gd); // filter constructor checkbox fFilterConstructorButton = new Button(container, SWT.CHECK); fFilterConstructorButton.setText("Filter co&nstructors"); fFilterConstructorButton.setToolTipText("Don't stop in constructors"); gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalSpan = 2; fFilterConstructorButton.setLayoutData(gd); fFilterSyntheticButton.setSelection(JDIDebugModel.getFilterSynthetic()); fFilterStaticButton.setSelection(JDIDebugModel.getFilterStatic()); fFilterConstructorButton.setSelection(JDIDebugModel.getFilterConstructor()); boolean enabled = JDIDebugModel.useStepFilters(); fUseFiltersCheckbox.setSelection(enabled); toggleStepFilterWidgetsEnabled(enabled); } private void toggleStepFilterWidgetsEnabled(boolean enabled) { fFilterViewer.getTable().setEnabled(enabled); fAddPackageButton.setEnabled(enabled); fAddTypeButton.setEnabled(enabled); fAddFilterButton.setEnabled(enabled); fFilterSyntheticButton.setEnabled(enabled); fFilterStaticButton.setEnabled(enabled); fFilterConstructorButton.setEnabled(enabled); if (!enabled) { fRemoveFilterButton.setEnabled(enabled); } else if (!fFilterViewer.getSelection().isEmpty()) { fRemoveFilterButton.setEnabled(true); } } /** * Create a new filter in the table (with the default 'new filter' value), * then open up an in-place editor on it. */ private void addActiveFilter() { fNewStepFilter = fStepFilterContentProvider.addFilter(DEFAULT_NEW_FILTER_TEXT, true); fNewTableItem = fFilterTable.getItem(0); editFilter(); } private void editFilter() { // if a previous edit is still in progress, finish it if (fEditorText != null) { validateChangeAndCleanup(); } // create & configure Text widget for editor fEditorText = new Text(fFilterTable, SWT.BORDER | SWT.SINGLE); GridData gd = new GridData(GridData.FILL_BOTH); fEditorText.setLayoutData(gd); // set the editor fTableEditor.horizontalAlignment = SWT.LEFT; fTableEditor.grabHorizontal = true; fTableEditor.setEditor(fEditorText, fNewTableItem, 0); // get the editor ready to use fEditorText.setText(fNewStepFilter.getName()); fEditorText.selectAll(); setEditorListeners(fEditorText); fEditorText.setFocus(); } private void setEditorListeners(Text text) { // CR means commit the changes, ESC means abort and don't commit text.addKeyListener(new KeyAdapter() { public void keyReleased(KeyEvent event) { if (event.character == SWT.CR) { validateChangeAndCleanup(); } else if (event.character == SWT.ESC) { removeNewFilter(); cleanupEditor(); } } }); // Consider loss of focus on the editor to mean the same as CR text.addFocusListener(new FocusAdapter() { public void focusLost(FocusEvent event) { validateChangeAndCleanup(); } }); // Consume traversal events from the text widget so that CR doesn't // traverse away to dialog's default button. Without this, hitting // CR in the text field closes the entire dialog. text.addListener(SWT.Traverse, new Listener() { public void handleEvent(Event event) { event.doit = false; } }); } private void validateChangeAndCleanup() { String trimmedValue = fEditorText.getText().trim(); // if the new value is blank, remove the filter if (trimmedValue.length() < 1) { removeNewFilter(); } // if it's invalid, beep and leave the sitting in the editor else if (!validateEditorInput(trimmedValue)) { getShell().getDisplay().beep(); return; // otherwise, commit the new value } else { fNewTableItem.setText(trimmedValue); fNewStepFilter.setName(trimmedValue); } cleanupEditor(); } /** * Cleanup all widgetry & resources used by the in-place editing */ private void cleanupEditor() { if (fEditorText != null) { fEditorText.dispose(); fEditorText = null; fNewStepFilter = null; fNewTableItem = null; fTableEditor.setEditor(null, null, 0); } } private void removeNewFilter() { fStepFilterContentProvider.removeFilters(new Object[] {fNewStepFilter}); } /** * A valid step filter is simply one that is not empty (all spaces), * and has no embedded spaces. Beyond this, a string cannot be * validated as corresponding to an existing type or package (and * this is probably not even desirable). */ private boolean validateEditorInput(String trimmedValue) { int embeddedSpace = trimmedValue.indexOf(' '); if (embeddedSpace != -1) { return false; } return true; } private void addType() { Shell shell= JavaPlugin.getActiveWorkbenchShell(); SelectionDialog dialog= null; try { dialog= JavaUI.createTypeDialog(shell, new ProgressMonitorDialog(shell), SearchEngine.createWorkspaceScope(), IJavaElementSearchConstants.CONSIDER_TYPES, false); } catch (JavaModelException jme) { String title= "Add type to step filters"; String message= "Could not open type selection dialog for step filters"; ExceptionHandler.handle(jme, title, message); return; } dialog.setTitle("Add type to step filters"); dialog.setMessage("Select a type to filter when stepping"); if (dialog.open() == IDialogConstants.CANCEL_ID) { return; } Object[] types= dialog.getResult(); if (types != null && types.length > 0) { IType type = (IType)types[0]; fStepFilterContentProvider.addFilter(type.getFullyQualifiedName(), true); } } private void addPackage() { Shell shell= JavaPlugin.getActiveWorkbenchShell(); SelectionDialog dialog = null; try { dialog = createAllPackagesDialog(shell); } catch (JavaModelException jme) { String title= "Add package to step filters"; String message= "Could not open package selection dialog for step filters"; ExceptionHandler.handle(jme, title, message); return; } dialog.setTitle("Add package to step filters"); dialog.setMessage("Select a package to filter when stepping"); if (dialog.open() == IDialogConstants.CANCEL_ID) { return; } Object[] packages= dialog.getResult(); if (packages != null && packages.length > 0) { IJavaElement pkg = (IJavaElement)packages[0]; String filter = pkg.getElementName(); if (filter.length() < 1) { filter = "(default package)"; } else { filter += ".*"; //$NON-NLS-1$ } fStepFilterContentProvider.addFilter(filter, true); } } private void removeFilters() { IStructuredSelection selection = (IStructuredSelection)fFilterViewer.getSelection(); fStepFilterContentProvider.removeFilters(selection.toArray()); } /** * Ignore package fragments that contain only non-java resources, and make sure * that each fragment is added to the list only once. */ private SelectionDialog createAllPackagesDialog(Shell shell) throws JavaModelException{ IWorkspaceRoot wsroot= JavaPlugin.getWorkspace().getRoot(); IJavaModel model= JavaCore.create(wsroot); IJavaProject[] projects= model.getJavaProjects(); Set packageNameSet= new HashSet(); List packageList = new ArrayList(); for (int i = 0; i < projects.length; i++) { IPackageFragment[] pkgs= projects[i].getPackageFragments(); for (int j = 0; j < pkgs.length; j++) { IPackageFragment pkg = pkgs[j]; if (!pkg.hasChildren() && (pkg.getNonJavaResources().length > 0)) { continue; } if (packageNameSet.add(pkg.getElementName())) { packageList.add(pkg); } } } int flags= JavaElementLabelProvider.SHOW_DEFAULT; ElementListSelectionDialog dialog= new ElementListSelectionDialog(shell, new JavaElementLabelProvider(flags)); dialog.setIgnoreCase(false); dialog.setElements(packageList.toArray()); // XXX inefficient return dialog; } /** * @see IWorkbenchPreferencePage#init(IWorkbench) */ public void init(IWorkbench workbench) { } /** * @see PreferencePage#performOk() * Also, notifies interested listeners */ public boolean performOk() { storeValues(); getPreferenceStore().firePropertyChangeEvent(IPreferencesConstants.VARIABLE_RENDERING, new Boolean(true), new Boolean(false)); fStepFilterContentProvider.saveFilters(); return true; } /** * Sets the default preferences */ protected void performDefaults() { setDefaultValues(); super.performDefaults(); } private void setDefaultValues() { IPreferenceStore store = getPreferenceStore(); fHexButton.setSelection(store.getDefaultBoolean(SHOW_HEX)); fCharButton.setSelection(store.getDefaultBoolean(SHOW_CHARS)); fUnsignedButton.setSelection(store.getDefaultBoolean(SHOW_UNSIGNED)); fStepFilterContentProvider.setDefaults(); } /** * Creates a button with the given label and sets the default * configuration data. */ private Button createCheckButton(Composite parent, String label) { Button button= new Button(parent, SWT.CHECK | SWT.LEFT); button.setText(label); button.addListener(SWT.Selection, this); // FieldEditor GridData GridData data = new GridData(); button.setLayoutData(data); return button; } /** * Creates composite control and sets the default layout data. * * @param parent the parent of the new composite * @param numColumns the number of columns for the new composite * @param labelText the text label of the new composite * @return the newly-created composite */ private Composite createLabelledComposite(Composite parent, int numColumns, String labelText) { Composite comp = new Composite(parent, SWT.NONE); //GridLayout GridLayout layout = new GridLayout(); layout.numColumns = numColumns; comp.setLayout(layout); //GridData GridData gd= new GridData(); gd.verticalAlignment = GridData.FILL; gd.horizontalAlignment = GridData.FILL; comp.setLayoutData(gd); //Label Label label = new Label(comp, SWT.NONE); label.setText(labelText); gd = new GridData(); gd.horizontalSpan = numColumns; label.setLayoutData(gd); return comp; } /** * Create a vertical space to separate groups of controls. */ private void createSpace(Composite parent) { Label vfiller = new Label(parent, SWT.LEFT); GridData gridData = new GridData(); gridData.horizontalAlignment = GridData.BEGINNING; gridData.grabExcessHorizontalSpace = false; gridData.verticalAlignment = GridData.CENTER; gridData.grabExcessVerticalSpace = false; vfiller.setLayoutData(gridData); } /** * @see Listener#handleEvent(Event) */ public void handleEvent(Event event) { } /** * Set the values of the component widgets based on the * values in the preference store */ private void setValues() { IPreferenceStore store = getPreferenceStore(); fHexButton.setSelection(store.getBoolean(SHOW_HEX)); fCharButton.setSelection(store.getBoolean(SHOW_CHARS)); fUnsignedButton.setSelection(store.getBoolean(SHOW_UNSIGNED)); } /** * Store the preference values based on the state of the * component widgets */ private void storeValues() { IPreferenceStore store = getPreferenceStore(); store.setValue(SHOW_HEX, fHexButton.getSelection()); store.setValue(SHOW_CHARS, fCharButton.getSelection()); store.setValue(SHOW_UNSIGNED, fUnsignedButton.getSelection()); } }
4,928
Bug 4928 Java perspective should have placeholder for Navigator
build 204 I sometimes want to show the Navigator in the Java perspective. It currently opens over the outline. I would prefer it to open over the packages view, since they're of the same flavour and I usually want one or the other, not both at the same time. It also means my flow still goes from left to right: choose something in the Navigator or packages view, it appears in the editor and outline view to the right.
resolved fixed
e48f52e
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T14:00:19Z"
"2001-10-12T15:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaPerspectiveFactory.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui; import org.eclipse.ui.IFolderLayout; import org.eclipse.ui.IPageLayout; import org.eclipse.ui.IPerspectiveFactory; import org.eclipse.search.ui.SearchUI; import org.eclipse.debug.ui.IDebugUIConstants; import org.eclipse.jdt.ui.JavaUI; public class JavaPerspectiveFactory implements IPerspectiveFactory { /** * Constructs a new Default layout engine. */ public JavaPerspectiveFactory() { super(); } public void createInitialLayout(IPageLayout layout) { String editorArea = layout.getEditorArea(); IFolderLayout folder= layout.createFolder("left", IPageLayout.LEFT, (float)0.25, editorArea); //$NON-NLS-1$ folder.addView(JavaUI.ID_PACKAGES); folder.addView(JavaUI.ID_TYPE_HIERARCHY); IFolderLayout outputfolder= layout.createFolder("bottom", IPageLayout.BOTTOM, (float)0.75, editorArea); //$NON-NLS-1$ outputfolder.addView(IPageLayout.ID_TASK_LIST); outputfolder.addView(SearchUI.SEARCH_RESULT_VIEW_ID); outputfolder.addView(IDebugUIConstants.ID_CONSOLE_VIEW); layout.addView(IPageLayout.ID_OUTLINE, IPageLayout.RIGHT, (float)0.75, editorArea); layout.addActionSet(IDebugUIConstants.DEBUG_ACTION_SET); layout.addActionSet(JavaUI.ID_ACTION_SET); layout.addActionSet(IUIConstants.ID_REFACTORING_ACTION_SET); // views - java layout.addShowViewShortcut(JavaUI.ID_PACKAGES); layout.addShowViewShortcut(JavaUI.ID_TYPE_HIERARCHY); layout.addShowViewShortcut(SearchUI.SEARCH_RESULT_VIEW_ID); // views - debugging layout.addShowViewShortcut(IDebugUIConstants.ID_PROCESS_VIEW); layout.addShowViewShortcut(IDebugUIConstants.ID_CONSOLE_VIEW); // views - standard workbench layout.addShowViewShortcut(IPageLayout.ID_OUTLINE); layout.addShowViewShortcut(IPageLayout.ID_TASK_LIST); layout.addShowViewShortcut(IPageLayout.ID_RES_NAV); // new actions - Java project creation wizard layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewPackageCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewClassCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewInterfaceCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewSnippetCreationWizard"); //$NON-NLS-1$ } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/DeclarationsSearchGroup.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; /** * Contribute Java search specific menu elements. */ public class DeclarationsSearchGroup extends JavaSearchSubGroup { public static final String GROUP_NAME= SearchMessages.getString("group.declarations"); //$NON-NLS-1$ protected ElementSearchAction[] getActions() { return new ElementSearchAction[] { new FindDeclarationsAction(), new FindDeclarationsInHierarchyAction(), new FindDeclarationsInWorkingSetAction() }; } protected String getName() { return GROUP_NAME; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/ElementSearchAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import java.lang.reflect.InvocationTargetException; import org.eclipse.core.resources.IWorkspaceDescription; import org.eclipse.core.runtime.CoreException; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.search.ui.SearchUI; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; /** * Abstract class for all search actions which work on java elements. */ public abstract class ElementSearchAction extends JavaElementAction { public ElementSearchAction(String label, Class[] validTypes) { super(label, validTypes); } public void run(IJavaElement element) { SearchUI.activateSearchResultView(); Shell shell= JavaPlugin.getActiveWorkbenchShell(); JavaSearchOperation op= null; try { op= makeOperation(element); if (op == null) return; } catch (JavaModelException ex) { ExceptionHandler.handle(ex, shell, SearchMessages.getString("Search.Error.search.title"), SearchMessages.getString("Search.Error.search.message")); //$NON-NLS-1$ //$NON-NLS-2$ return; } IWorkspaceDescription workspaceDesc= JavaPlugin.getWorkspace().getDescription(); boolean isAutoBuilding= workspaceDesc.isAutoBuilding(); if (isAutoBuilding) { // disable auto-build during search operation workspaceDesc.setAutoBuilding(false); try { JavaPlugin.getWorkspace().setDescription(workspaceDesc); } catch (CoreException ex) { ExceptionHandler.handle(ex, shell, SearchMessages.getString("Search.Error.setDescription.title"), SearchMessages.getString("Search.Error.setDescription.message")); //$NON-NLS-1$ //$NON-NLS-2$ } } try { new ProgressMonitorDialog(shell).run(true, true, op); } catch (InvocationTargetException ex) { ExceptionHandler.handle(ex, shell, SearchMessages.getString("Search.Error.search.title"), SearchMessages.getString("Search.Error.search.message")); //$NON-NLS-1$ //$NON-NLS-2$ } catch(InterruptedException e) { } finally { if (isAutoBuilding) { // enable auto-building again workspaceDesc= JavaPlugin.getWorkspace().getDescription(); workspaceDesc.setAutoBuilding(true); try { JavaPlugin.getWorkspace().setDescription(workspaceDesc); } catch (CoreException ex) { ExceptionHandler.handle(ex, shell, SearchMessages.getString("Search.Error.setDescription.title"), SearchMessages.getString("Search.Error.setDescription.message")); //$NON-NLS-1$ //$NON-NLS-2$ } } } } protected JavaSearchOperation makeOperation(IJavaElement element) throws JavaModelException { IType type= getType(element); return new JavaSearchOperation(JavaPlugin.getWorkspace(), element, getLimitTo(), getScope(type), getScopeDescription(type), getCollector()); }; protected abstract int getLimitTo(); protected IJavaSearchScope getScope(IType element) throws JavaModelException { return SearchEngine.createWorkspaceScope(); } protected JavaSearchResultCollector getCollector() { return new JavaSearchResultCollector(); } protected String getScopeDescription(IType type) { return SearchMessages.getString("WorkspaceScope"); //$NON-NLS-1$ } protected IType getType(IJavaElement element) { IType type= null; if (element.getElementType() == IJavaElement.TYPE) type= (IType)element; else if (element instanceof IMember) type= ((IMember)element).getDeclaringType(); if (type != null) { ICompilationUnit cu= type.getCompilationUnit(); if (cu != null && cu.isWorkingCopy()) type= (IType)cu.getOriginal(type); return type; } return null; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/FindDeclarationsInWorkingSetAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import org.eclipse.ui.dialogs.SelectionDialog; import org.eclipse.search.ui.IWorkingSet; import org.eclipse.search.ui.SearchUI; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchConstants; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.internal.ui.JavaPlugin; public class FindDeclarationsInWorkingSetAction extends FindDeclarationsAction { public FindDeclarationsInWorkingSetAction() { setText(SearchMessages.getString("Search.FindDeclarationsInWorkingSetAction.label")); //$NON-NLS-1$ setToolTipText(SearchMessages.getString("Search.FindDeclarationsInWorkingSetAction.tooltip")); //$NON-NLS-1$ } protected JavaSearchOperation makeOperation(IJavaElement element) throws JavaModelException { IWorkingSet workingSet= queryWorkingSet(); if (workingSet == null) return null; if (element.getElementType() == IJavaElement.METHOD) { IMethod method= (IMethod)element; int searchFor= IJavaSearchConstants.METHOD; if (method.isConstructor()) searchFor= IJavaSearchConstants.CONSTRUCTOR; String pattern= PrettySignature.getUnqualifiedMethodSignature(method); return new JavaSearchOperation(JavaPlugin.getWorkspace(), pattern, searchFor, getLimitTo(), getScope(workingSet), getScopeDescription(workingSet), getCollector()); } else return new JavaSearchOperation(JavaPlugin.getWorkspace(), element, getLimitTo(), getScope(workingSet), getScopeDescription(workingSet), getCollector()); }; private IJavaSearchScope getScope(IWorkingSet workingSet) throws JavaModelException { return JavaSearchScopeFactory.getInstance().createJavaSearchScope(workingSet); } private String getScopeDescription(IWorkingSet workingSet) { return SearchMessages.getFormattedString("WorkingSetScope", new String[] {workingSet.getName()}); //$NON-NLS-1$ } private IWorkingSet queryWorkingSet() throws JavaModelException { SelectionDialog dialog= SearchUI.createWorkingSetDialog(JavaPlugin.getActiveWorkbenchShell()); if (dialog.open() == dialog.OK) return (IWorkingSet)dialog.getResult()[0]; else return null; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/FindImplementorsInWorkingSetAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import org.eclipse.ui.dialogs.SelectionDialog; import org.eclipse.search.ui.IWorkingSet; import org.eclipse.search.ui.SearchUI; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.internal.ui.JavaPlugin; public class FindImplementorsInWorkingSetAction extends FindImplementorsAction { public FindImplementorsInWorkingSetAction() { setText(SearchMessages.getString("Search.FindImplementorsInWorkingSetAction.label")); //$NON-NLS-1$ setToolTipText(SearchMessages.getString("Search.FindImplementorsInWorkingSetAction.tooltip")); //$NON-NLS-1$ } protected JavaSearchOperation makeOperation(IJavaElement element) throws JavaModelException { IWorkingSet workingSet= queryWorkingSet(); if (workingSet == null) return null; return new JavaSearchOperation(JavaPlugin.getWorkspace(), element, getLimitTo(), getScope(workingSet), getScopeDescription(workingSet), getCollector()); }; private IJavaSearchScope getScope(IWorkingSet workingSet) throws JavaModelException { return JavaSearchScopeFactory.getInstance().createJavaSearchScope(workingSet); } private String getScopeDescription(IWorkingSet workingSet) { return SearchMessages.getFormattedString("WorkingSetScope", new String[] {workingSet.getName()}); //$NON-NLS-1$ } private IWorkingSet queryWorkingSet() throws JavaModelException { SelectionDialog dialog= SearchUI.createWorkingSetDialog(JavaPlugin.getActiveWorkbenchShell()); if (dialog.open() == dialog.OK) return (IWorkingSet)dialog.getResult()[0]; else return null; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/FindReadReferencesInWorkingSetAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import org.eclipse.jdt.core.IField; import org.eclipse.jdt.core.search.IJavaSearchConstants; public class FindReadReferencesInWorkingSetAction extends FindReferencesInWorkingSetAction { public FindReadReferencesInWorkingSetAction() { super(SearchMessages.getString("Search.FindReadReferencesInWorkingSetAction.label"), new Class[] {IField.class} ); //$NON-NLS-1$ setToolTipText(SearchMessages.getString("Search.FindReadReferencesInWorkingSetAction.tooltip")); //$NON-NLS-1$ } protected int getLimitTo() { return IJavaSearchConstants.READ_REFERENCES; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/FindReferencesInWorkingSetAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import org.eclipse.ui.dialogs.SelectionDialog; import org.eclipse.search.ui.IWorkingSet; import org.eclipse.search.ui.SearchUI; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.internal.ui.JavaPlugin; public class FindReferencesInWorkingSetAction extends FindReferencesAction { public FindReferencesInWorkingSetAction() { setText(SearchMessages.getString("Search.FindReferencesInWorkingSetAction.label")); //$NON-NLS-1$ setToolTipText(SearchMessages.getString("Search.FindReferencesInWorkingSetAction.tooltip")); //$NON-NLS-1$ } FindReferencesInWorkingSetAction(String label, Class[] validTypes) { super(label, validTypes); } protected JavaSearchOperation makeOperation(IJavaElement element) throws JavaModelException { IWorkingSet workingSet= queryWorkingSet(); if (workingSet == null) return null; return new JavaSearchOperation(JavaPlugin.getWorkspace(), element, getLimitTo(), getScope(workingSet), getScopeDescription(workingSet), getCollector()); }; private IJavaSearchScope getScope(IWorkingSet workingSet) throws JavaModelException { return JavaSearchScopeFactory.getInstance().createJavaSearchScope(workingSet); } private String getScopeDescription(IWorkingSet workingSet) { return SearchMessages.getFormattedString("WorkingSetScope", new String[] {workingSet.getName()}); //$NON-NLS-1$ } private IWorkingSet queryWorkingSet() throws JavaModelException { SelectionDialog dialog= SearchUI.createWorkingSetDialog(JavaPlugin.getActiveWorkbenchShell()); if (dialog.open() == dialog.OK) return (IWorkingSet)dialog.getResult()[0]; else return null; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/FindWriteReferencesInWorkingSetAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import org.eclipse.jdt.core.IField; import org.eclipse.jdt.core.search.IJavaSearchConstants; public class FindWriteReferencesInWorkingSetAction extends FindReferencesInWorkingSetAction { public FindWriteReferencesInWorkingSetAction() { super(SearchMessages.getString("Search.FindWriteReferencesInWorkingSetAction.label"), new Class[] {IField.class} ); //$NON-NLS-1$ setToolTipText(SearchMessages.getString("Search.FindWriteReferencesInWorkingSetAction.tooltip")); //$NON-NLS-1$ } protected int getLimitTo() { return IJavaSearchConstants.WRITE_REFERENCES; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import java.io.BufferedReader; import java.io.IOException; import java.io.StringReader; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.List; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.swt.SWT; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Combo; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Group; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.DialogPage; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.model.IWorkbenchAdapter; import org.eclipse.search.ui.ISearchPage; import org.eclipse.search.ui.ISearchPageContainer; import org.eclipse.search.ui.ISearchResultViewEntry; import org.eclipse.search.ui.IWorkingSet; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICodeAssist; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IField; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchConstants; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.ElementListSelectionDialog; import org.eclipse.jdt.internal.ui.javaeditor.IClassFileEditorInput; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.util.RowLayouter; public class JavaSearchPage extends DialogPage implements ISearchPage, IJavaSearchConstants { public static final String EXTENSION_POINT_ID= "org.eclipse.jdt.ui.JavaSearchPage"; //$NON-NLS-1$ private static List fgPreviousSearchPatterns= new ArrayList(20); private Combo fPattern; private String fInitialPattern; private boolean fFirstTime= true; private ISearchPageContainer fContainer; private Button[] fSearchFor; private String[] fSearchForText= { SearchMessages.getString("SearchPage.searchFor.type"), //$NON-NLS-1$ SearchMessages.getString("SearchPage.searchFor.method"), //$NON-NLS-1$ SearchMessages.getString("SearchPage.searchFor.package"), //$NON-NLS-1$ SearchMessages.getString("SearchPage.searchFor.constructor"), //$NON-NLS-1$ SearchMessages.getString("SearchPage.searchFor.field")}; //$NON-NLS-1$ private Button[] fLimitTo; private String[] fLimitToText= { SearchMessages.getString("SearchPage.limitTo.declarations"), //$NON-NLS-1$ SearchMessages.getString("SearchPage.limitTo.implementors"), //$NON-NLS-1$ SearchMessages.getString("SearchPage.limitTo.references"), //$NON-NLS-1$ SearchMessages.getString("SearchPage.limitTo.allOccurrences"), //$NON-NLS-1$ SearchMessages.getString("SearchPage.limitTo.readReferences"), //$NON-NLS-1$ SearchMessages.getString("SearchPage.limitTo.writeReferences")}; //$NON-NLS-1$ private IJavaElement fJavaElement; private static class SearchPatternData { int searchFor; int limitTo; String pattern; IJavaElement javaElement; int scope; IWorkingSet workingSet; public SearchPatternData(int s, int l, String p, IJavaElement element) { this(s, l, p, element, ISearchPageContainer.WORKSPACE_SCOPE, null); } public SearchPatternData(int s, int l, String p, IJavaElement element, int scope, IWorkingSet workingSet) { searchFor= s; limitTo= l; pattern= p; javaElement= element; this.scope= scope; this.workingSet= workingSet; } } //---- Action Handling ------------------------------------------------ public boolean performAction() { SearchPatternData data= getPatternData(); IWorkspace workspace= JavaPlugin.getWorkspace(); // Setup search scope IJavaSearchScope scope= null; String scopeDescription= ""; //$NON-NLS-1$ switch (getContainer().getSelectedScope()) { case ISearchPageContainer.WORKSPACE_SCOPE: scopeDescription= SearchMessages.getString("WorkspaceScope"); //$NON-NLS-1$ scope= SearchEngine.createWorkspaceScope(); break; case ISearchPageContainer.SELECTION_SCOPE: scopeDescription= SearchMessages.getString("SelectionScope"); //$NON-NLS-1$ scope= JavaSearchScopeFactory.getInstance().createJavaSearchScope(getSelection()); break; case ISearchPageContainer.WORKING_SET_SCOPE: IWorkingSet workingSet= getContainer().getSelectedWorkingSet(); // should not happen - just to be sure if (workingSet == null) return false; scopeDescription= SearchMessages.getFormattedString("WorkingSetScope", new String[] {workingSet.getName()}); //$NON-NLS-1$ scope= JavaSearchScopeFactory.getInstance().createJavaSearchScope(getContainer().getSelectedWorkingSet()); } JavaSearchResultCollector collector= new JavaSearchResultCollector(); JavaSearchOperation op= null; if (data.javaElement != null && getPattern().equals(fInitialPattern)) op= new JavaSearchOperation(workspace, data.javaElement, data.limitTo, scope, scopeDescription, collector); else { data.javaElement= null; op= new JavaSearchOperation(workspace, data.pattern, data.searchFor, data.limitTo, scope, scopeDescription, collector); } Shell shell= getControl().getShell(); try { getContainer().getRunnableContext().run(true, true, op); } catch (InvocationTargetException ex) { ExceptionHandler.handle(ex, shell, SearchMessages.getString("Search.Error.search.title"), SearchMessages.getString("Search.Error.search.message")); //$NON-NLS-2$ //$NON-NLS-1$ return false; } catch (InterruptedException ex) { return false; } return true; } private int getLimitTo() { for (int i= 0; i < fLimitTo.length; i++) { if (fLimitTo[i].getSelection()) return i; } return -1; } private void setLimitTo(int searchFor) { fLimitTo[DECLARATIONS].setEnabled(true); fLimitTo[IMPLEMENTORS].setEnabled(false); fLimitTo[REFERENCES].setEnabled(true); fLimitTo[ALL_OCCURRENCES].setEnabled(true); fLimitTo[READ_REFERENCES].setEnabled(false); fLimitTo[WRITE_REFERENCES].setEnabled(false); if (!(searchFor == TYPE || searchFor == INTERFACE) && fLimitTo[IMPLEMENTORS].getSelection()) { fLimitTo[IMPLEMENTORS].setSelection(false); fLimitTo[REFERENCES].setSelection(true); } if (!(searchFor == FIELD) && (getLimitTo() == READ_REFERENCES || getLimitTo() == WRITE_REFERENCES)) { fLimitTo[getLimitTo()].setSelection(false); fLimitTo[REFERENCES].setSelection(true); } switch (searchFor) { case TYPE | INTERFACE: fLimitTo[IMPLEMENTORS].setEnabled(true); case FIELD: fLimitTo[READ_REFERENCES].setEnabled(true); fLimitTo[WRITE_REFERENCES].setEnabled(true); break; default : break; } } private String[] getPreviousSearchPatterns() { // Search results are not persistent int patternCount= fgPreviousSearchPatterns.size(); String [] patterns= new String[patternCount]; for (int i= 0; i < patternCount; i++) patterns[i]= ((SearchPatternData) fgPreviousSearchPatterns.get(patternCount - 1 - i)).pattern; return patterns; } private int getSearchFor() { for (int i= 0; i < fSearchFor.length; i++) { if (fSearchFor[i].getSelection()) return i; } Assert.isTrue(false, SearchMessages.getString("SearchPage.shouldNeverHappen")); //$NON-NLS-1$ return -1; } private String getPattern() { return fPattern.getText(); } /** * Return search pattern data and update previous searches. * An existing entry will be updated. */ private SearchPatternData getPatternData() { String pattern= getPattern(); SearchPatternData match= null; int i= 0; int size= fgPreviousSearchPatterns.size(); while (match == null && i < size) { match= (SearchPatternData) fgPreviousSearchPatterns.get(i); i++; if (!pattern.equals(match.pattern)) match= null; }; if (match == null) { match= new SearchPatternData( getSearchFor(), getLimitTo(), getPattern(), fJavaElement, getContainer().getSelectedScope(), getContainer().getSelectedWorkingSet()); fgPreviousSearchPatterns.add(match); } else { match.searchFor= getSearchFor(); match.limitTo= getLimitTo(); match.javaElement= fJavaElement; match.scope= getContainer().getSelectedScope(); match.workingSet= getContainer().getSelectedWorkingSet(); }; return match; } /* * Implements method from IDialogPage */ public void setVisible(boolean visible) { if (visible && fPattern != null) { if (fFirstTime) { fFirstTime= false; // Set item and text here to prevent page from resizing fPattern.setItems(getPreviousSearchPatterns()); initSelections(); } fPattern.setFocus(); getContainer().setPerformActionEnabled(fPattern.getText().length() > 0 && getContainer().hasValidScope()); } super.setVisible(visible); } public boolean isValid() { return true; } //---- Widget creation ------------------------------------------------ /** * Creates the page's content. */ public void createControl(Composite parent) { GridData gd; Composite result= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.makeColumnsEqualWidth= true; layout.horizontalSpacing= 10; result.setLayout(layout); RowLayouter layouter= new RowLayouter(layout.numColumns); gd= new GridData(); gd.horizontalAlignment= gd.FILL; layouter.setDefaultGridData(gd, 0); layouter.setDefaultGridData(gd, 1); layouter.setDefaultSpan(); layouter.perform(createExpression(result)); layouter.perform(createSearchFor(result), createLimitTo(result), -1); SelectionAdapter javaElementInitializer= new SelectionAdapter() { public void widgetSelected(SelectionEvent event) { fJavaElement= null; setLimitTo(getSearchFor()); } }; fSearchFor[TYPE].addSelectionListener(javaElementInitializer); fSearchFor[METHOD].addSelectionListener(javaElementInitializer); fSearchFor[FIELD].addSelectionListener(javaElementInitializer); fSearchFor[CONSTRUCTOR].addSelectionListener(javaElementInitializer); fSearchFor[PACKAGE].addSelectionListener(javaElementInitializer); setControl(result); WorkbenchHelp.setHelp(result, new Object[] { IJavaHelpContextIds.JAVA_SEARCH_PAGE }); } private Control createExpression(Composite parent) { Group result= new Group(parent, SWT.NONE); result.setText(SearchMessages.getString("SearchPage.expression.label")); //$NON-NLS-1$ GridLayout layout= new GridLayout(); layout.numColumns= 1; result.setLayout(layout); // Pattern combo fPattern= new Combo(result, SWT.SINGLE | SWT.BORDER); fPattern.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { handlePatternSelected(); } }); fPattern.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { getContainer().setPerformActionEnabled(getPattern().length() > 0 && getContainer().hasValidScope()); } }); GridData gd= new GridData(GridData.FILL_HORIZONTAL); gd.widthHint= convertWidthInCharsToPixels(30); fPattern.setLayoutData(gd); // Pattern info Label label= new Label(result, SWT.LEFT); label.setText(SearchMessages.getString("SearchPage.expression.pattern")); //$NON-NLS-1$ return result; } private void handlePatternSelected() { if (fPattern.getSelectionIndex() < 0) return; int index= fgPreviousSearchPatterns.size() - 1 - fPattern.getSelectionIndex(); SearchPatternData values= (SearchPatternData) fgPreviousSearchPatterns.get(index); for (int i= 0; i < fSearchFor.length; i++) fSearchFor[i].setSelection(false); for (int i= 0; i < fLimitTo.length; i++) fLimitTo[i].setSelection(false); fSearchFor[values.searchFor].setSelection(true); setLimitTo(values.searchFor); fLimitTo[values.limitTo].setSelection(true); fInitialPattern= values.pattern; fPattern.setText(fInitialPattern); fJavaElement= values.javaElement; if (values.workingSet != null) getContainer().setSelectedWorkingSet(values.workingSet); else getContainer().setSelectedScope(values.scope); } private Control createSearchFor(Composite parent) { Group result= new Group(parent, SWT.NONE); result.setText(SearchMessages.getString("SearchPage.searchFor.label")); //$NON-NLS-1$ GridLayout layout= new GridLayout(); layout.numColumns= 3; result.setLayout(layout); result.setLayoutData(new GridData(GridData.FILL_VERTICAL)); fSearchFor= new Button[fSearchForText.length]; for (int i= 0; i < fSearchForText.length; i++) { Button button= new Button(result, SWT.RADIO); button.setText(fSearchForText[i]); fSearchFor[i]= button; } return result; } private Control createLimitTo(Composite parent) { Group result= new Group(parent, SWT.NONE); result.setText(SearchMessages.getString("SearchPage.limitTo.label")); //$NON-NLS-1$ GridLayout layout= new GridLayout(); layout.numColumns= 2; result.setLayout(layout); fLimitTo= new Button[fLimitToText.length]; for (int i= 0; i < fLimitToText.length; i++) { Button button= new Button(result, SWT.RADIO); button.setText(fLimitToText[i]); fLimitTo[i]= button; } return result; } private void initSelections() { fJavaElement= null; ISelection selection= getSelection(); SearchPatternData values= null; values= tryTypedTextSelection(selection); if (values == null) values= trySelection(selection); if (values == null) values= trySimpleTextSelection(selection); if (values == null) values= getDefaultInitValues(); fSearchFor[values.searchFor].setSelection(true); setLimitTo(values.searchFor); fLimitTo[values.limitTo].setSelection(true); fInitialPattern= values.pattern; fPattern.setText(fInitialPattern); fJavaElement= values.javaElement; } private SearchPatternData tryTypedTextSelection(ISelection selection) { if (selection instanceof ITextSelection) { IEditorPart e= getEditorPart(); if (e != null) { ITextSelection ts= (ITextSelection)selection; ICodeAssist assist= getCodeAssist(e); if (assist != null) { IJavaElement[] elements= null; try { elements= assist.codeSelect(ts.getOffset(), ts.getLength()); } catch (JavaModelException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.createJavaElement.title"), SearchMessages.getString("Search.Error.createJavaElement.message")); //$NON-NLS-2$ //$NON-NLS-1$ } if (elements != null && elements.length > 0) { if (elements.length == 1) fJavaElement= elements[0]; else fJavaElement= chooseFromList(elements); if (fJavaElement != null) return determineInitValuesFrom(fJavaElement); } } } } return null; } private ICodeAssist getCodeAssist(IEditorPart editorPart) { IEditorInput input= editorPart.getEditorInput(); if (input instanceof IClassFileEditorInput) return ((IClassFileEditorInput)input).getClassFile(); IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); return manager.getWorkingCopy(input); } private SearchPatternData trySelection(ISelection selection) { SearchPatternData result= null; if (selection == null) return result; Object o= null; if (selection instanceof IStructuredSelection) o= ((IStructuredSelection)selection).getFirstElement(); if (o instanceof IJavaElement) { fJavaElement= (IJavaElement)o; result= determineInitValuesFrom(fJavaElement); } else if (o instanceof ISearchResultViewEntry) { fJavaElement= getJavaElement(((ISearchResultViewEntry)o).getSelectedMarker()); result= determineInitValuesFrom(fJavaElement); } else if (o instanceof IAdaptable) { IJavaElement element= (IJavaElement)((IAdaptable)o).getAdapter(IJavaElement.class); if (element != null) { result= determineInitValuesFrom(element); } else { IWorkbenchAdapter adapter= (IWorkbenchAdapter)((IAdaptable)o).getAdapter(IWorkbenchAdapter.class); result= new SearchPatternData(TYPE, REFERENCES, adapter.getLabel(o), null); } } return result; } private IJavaElement getJavaElement(IMarker marker) { try { return JavaCore.create((String)marker.getAttribute(IJavaSearchUIConstants.ATT_JE_HANDLE_ID)); } catch (CoreException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.createJavaElement.title"), SearchMessages.getString("Search.Error.createJavaElement.message")); //$NON-NLS-2$ //$NON-NLS-1$ return null; } } private SearchPatternData determineInitValuesFrom(IJavaElement element) { if (element == null) return null; int searchFor= UNKNOWN; int limitTo= UNKNOWN; String pattern= null; switch (element.getElementType()) { case IJavaElement.PACKAGE_FRAGMENT: searchFor= PACKAGE; limitTo= REFERENCES; pattern= element.getElementName(); break; case IJavaElement.PACKAGE_FRAGMENT_ROOT: searchFor= PACKAGE; limitTo= REFERENCES; pattern= element.getElementName(); break; case IJavaElement.PACKAGE_DECLARATION: searchFor= PACKAGE; limitTo= REFERENCES; pattern= element.getElementName(); break; case IJavaElement.IMPORT_DECLARATION: pattern= element.getElementName(); IImportDeclaration declaration= (IImportDeclaration)element; if (declaration.isOnDemand()) { searchFor= PACKAGE; int index= pattern.lastIndexOf('.'); pattern= pattern.substring(0, index); } else { searchFor= TYPE; } limitTo= DECLARATIONS; break; case IJavaElement.TYPE: searchFor= TYPE; limitTo= REFERENCES; pattern= JavaModelUtil.getFullyQualifiedName((IType)element); break; case IJavaElement.COMPILATION_UNIT: ICompilationUnit cu= (ICompilationUnit)element; String mainTypeName= element.getElementName().substring(0, element.getElementName().indexOf(".")); //$NON-NLS-1$ IType mainType= cu.getType(mainTypeName); mainTypeName= JavaModelUtil.getTypeQualifiedName(mainType); try { mainType= JavaModelUtil.findTypeInCompilationUnit(cu, mainTypeName); if (mainType == null) { // fetch type which is declared first in the file IType[] types= cu.getTypes(); if (types.length > 0) mainType= types[0]; else break; } } catch (JavaModelException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.javaElementAccess.title"), SearchMessages.getString("Search.Error.javaElementAccess.message")); //$NON-NLS-2$ //$NON-NLS-1$ break; } searchFor= TYPE; element= mainType; limitTo= REFERENCES; pattern= JavaModelUtil.getFullyQualifiedName((IType)mainType); break; case IJavaElement.CLASS_FILE: IClassFile cf= (IClassFile)element; try { mainType= cf.getType(); } catch (JavaModelException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.javaElementAccess.title"), SearchMessages.getString("Search.Error.javaElementAccess.message")); //$NON-NLS-2$ //$NON-NLS-1$ break; } if (mainType == null) break; element= mainType; searchFor= TYPE; limitTo= REFERENCES; pattern= JavaModelUtil.getFullyQualifiedName(mainType); break; case IJavaElement.FIELD: searchFor= FIELD; limitTo= REFERENCES; IType type= ((IField)element).getDeclaringType(); StringBuffer buffer= new StringBuffer(); buffer.append(JavaModelUtil.getFullyQualifiedName(type)); buffer.append('.'); buffer.append(element.getElementName()); pattern= buffer.toString(); break; case IJavaElement.METHOD: searchFor= METHOD; try { IMethod method= (IMethod)element; if (method.isConstructor()) searchFor= CONSTRUCTOR; } catch (JavaModelException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.javaElementAccess.title"), SearchMessages.getString("Search.Error.javaElementAccess.message")); //$NON-NLS-2$ //$NON-NLS-1$ break; } limitTo= REFERENCES; pattern= PrettySignature.getMethodSignature((IMethod)element); break; } if (searchFor != UNKNOWN && limitTo != UNKNOWN && pattern != null) return new SearchPatternData(searchFor, limitTo, pattern, element); return null; } private SearchPatternData trySimpleTextSelection(ISelection selection) { SearchPatternData result= null; if (selection instanceof ITextSelection) { BufferedReader reader= new BufferedReader(new StringReader(((ITextSelection)selection).getText())); String text; try { text= reader.readLine(); if (text == null) text= ""; //$NON-NLS-1$ } catch (IOException ex) { text= ""; //$NON-NLS-1$ } result= new SearchPatternData(TYPE, REFERENCES, text, null); } return result; } private SearchPatternData getDefaultInitValues() { return new SearchPatternData(TYPE, REFERENCES, "", null); //$NON-NLS-1$ } private IJavaElement chooseFromList(IJavaElement[] openChoices) { ILabelProvider labelProvider= new JavaElementLabelProvider( JavaElementLabelProvider.SHOW_DEFAULT | JavaElementLabelProvider.SHOW_CONTAINER_QUALIFICATION); ElementListSelectionDialog dialog= new ElementListSelectionDialog(getShell(), labelProvider); dialog.setTitle(SearchMessages.getString("SearchElementSelectionDialog.title")); //$NON-NLS-1$ dialog.setMessage(SearchMessages.getString("SearchElementSelectionDialog.message")); //$NON-NLS-1$ dialog.setElements(openChoices); if (dialog.open() == dialog.OK) return (IJavaElement)dialog.getFirstResult(); return null; } /* * Implements method from ISearchPage */ public void setContainer(ISearchPageContainer container) { fContainer= container; } /** * Returns the search page's container. */ private ISearchPageContainer getContainer() { return fContainer; } /** * Returns the current active selection. */ private ISelection getSelection() { return fContainer.getSelection(); } /** * Returns the current active editor part. */ private IEditorPart getEditorPart() { IWorkbenchWindow window= JavaPlugin.getActiveWorkbenchWindow(); if (window != null) { IWorkbenchPage page= window.getActivePage(); if (page != null) return page.getActiveEditor(); } return null; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchSubGroup.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import org.eclipse.jface.action.GroupMarker; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.util.Assert; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.actions.GroupContext; import org.eclipse.jdt.ui.IContextMenuConstants; /** * Contribute Java search specific menu elements. */ public abstract class JavaSearchSubGroup extends ContextMenuGroup { public static final String GROUP_ID= IContextMenuConstants.GROUP_SEARCH; private final ElementSearchAction[] fActions; public JavaSearchSubGroup() { fActions= getActions(); } abstract protected ElementSearchAction[] getActions(); abstract protected String getName(); public void fill(IMenuManager manager, GroupContext context) { MenuManager javaSearchMM= new MenuManager(getName(), GROUP_ID); for (int i= 0; i < fActions.length; i++) { ElementSearchAction action= fActions[i]; if (action.canOperateOn(context.getSelection())) javaSearchMM.add(action); } if (!javaSearchMM.isEmpty()) manager.add(javaSearchMM); } public MenuManager getMenuManagerForGroup(boolean isTextSelectionEmpty) { MenuManager javaSearchMM= new MenuManager(getName(), GROUP_ID); //$NON-NLS-1$ if (!isTextSelectionEmpty) { for (int i= 0; i < fActions.length; i++) javaSearchMM.add(fActions[i]); } return javaSearchMM; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/LRUWorkingSetList.java
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/ReadReferencesSearchGroup.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; /** * Contribute Java search specific menu elements. */ public class ReadReferencesSearchGroup extends JavaSearchSubGroup { public static final String GROUP_NAME= SearchMessages.getString("group.readReferences"); //$NON-NLS-1$ protected ElementSearchAction[] getActions() { return new ElementSearchAction[] { new FindReadReferencesAction(), new FindReadReferencesInHierarchyAction(), new FindReadReferencesInWorkingSetAction(), }; } protected String getName() { return GROUP_NAME; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/ReferencesSearchGroup.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; /** * Contribute Java search specific menu elements. */ public class ReferencesSearchGroup extends JavaSearchSubGroup { public static final String GROUP_NAME= SearchMessages.getString("group.references"); //$NON-NLS-1$ protected ElementSearchAction[] getActions() { return new ElementSearchAction[] { new FindReferencesAction(), new FindReferencesInHierarchyAction(), new FindReferencesInWorkingSetAction(), }; } protected String getName() { return GROUP_NAME; } }
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/WorkingSetAction.java
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/WorkingSetComparator.java
3,672
Bug 3672 DCR: Add working set support
Would be nice to have the VAME Search "Scope" feature. This allows the user to filter searches, which reduces both the time to do the search, and the number of results found - so that more of the results are known to be useful. In VAME, the user could edit a search scope (for example, only search in these 3 projects), and give it a name (for example "SWT"), and then the named scope would show up in all of the search context menus, for example, if a class was selected, the context menu would allow searches on: - References [to the class] -> Workspace [in the whole workspace] -> Hierarchy [in the current hierarchy (the one the class is in)] -> Project [in the current project (the one the class is in)] -> SWT [in the user- defined set of projects named "SWT" - this is the "search scope" or "scope set"] - Declarations [of the class] -> Workspace -> Hierarchy -> Project -> SWT Also, the search dialog would allow temporary scopes to be specified for each individual search. See the VAME Searching for more details. (or ask me - I use search a lot - CM) Currently, all searches in Eclipse are done on the whole workspace. This is sub-optimal. NOTES: EG (5/17/01 11:12:48 AM) Missing working sets to. Can't be done for June. DM (10/4/01 3:07:48 PM) Added "Selection" scope DM (10/9/01 9:31:44 AM) Will now have to add temporary implementation for working sets: IWorkingSet WorkingSet -> IWorkingSet WorkingSetSelectionDialog WorkingSetContentProvider WorkingSetLabelProvider
verified fixed
7049e8f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-07T16:23:46Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/WriteReferencesSearchGroup.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; /** * Contribute Java search specific menu elements. */ public class WriteReferencesSearchGroup extends JavaSearchSubGroup { public static final String GROUP_NAME= SearchMessages.getString("group.writeReferences"); //$NON-NLS-1$ protected ElementSearchAction[] getActions() { return new ElementSearchAction[] { new FindWriteReferencesAction(), new FindWriteReferencesInHierarchyAction(), new FindWriteReferencesInWorkingSetAction(), }; } protected String getName() { return GROUP_NAME; } }
5,356
Bug 5356 Search Result descriptions don't use singular
Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match
resolved fixed
acb4754
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-08T17:09:19Z"
"2001-10-30T16:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchOperation.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.ui.actions.WorkspaceModifyOperation; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.search.IJavaSearchConstants; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.internal.ui.JavaPluginImages; public class JavaSearchOperation extends WorkspaceModifyOperation { private IWorkspace fWorkspace; private IJavaElement fElementPattern; private int fLimitTo; private String fStringPattern; private int fSearchFor; private IJavaSearchScope fScope; private String fScopeDescription; private JavaSearchResultCollector fCollector; protected JavaSearchOperation( IWorkspace workspace, int limitTo, IJavaSearchScope scope, String scopeDescription, JavaSearchResultCollector collector) { fWorkspace= workspace; fLimitTo= limitTo; fScope= scope; fScopeDescription= scopeDescription; fCollector= collector; fCollector.setOperation(this); } public JavaSearchOperation( IWorkspace workspace, IJavaElement pattern, int limitTo, IJavaSearchScope scope, String scopeDescription, JavaSearchResultCollector collector) { this(workspace, limitTo, scope, scopeDescription, collector); fElementPattern= pattern; } public JavaSearchOperation( IWorkspace workspace, String pattern, int searchFor, int limitTo, IJavaSearchScope scope, String scopeDescription, JavaSearchResultCollector collector) { this(workspace, limitTo, scope, scopeDescription, collector); fStringPattern= pattern; fSearchFor= searchFor; } protected void execute(IProgressMonitor monitor) throws CoreException { fCollector.setProgressMonitor(monitor); SearchEngine engine= new SearchEngine(); if (fElementPattern != null) engine.search(fWorkspace, fElementPattern, fLimitTo, fScope, fCollector); else engine.search(fWorkspace, fStringPattern, fSearchFor, fLimitTo, fScope, fCollector); } String getDescription() { String desc= null; if (fElementPattern != null) { if (fLimitTo == IJavaSearchConstants.REFERENCES && fElementPattern.getElementType() == IJavaElement.METHOD) desc= PrettySignature.getUnqualifiedMethodSignature((IMethod)fElementPattern); else desc= fElementPattern.getElementName(); if ("".equals(desc) && fElementPattern.getElementType() == IJavaElement.PACKAGE_FRAGMENT) //$NON-NLS-1$ desc= SearchMessages.getString("JavaSearchOperation.default_package"); //$NON-NLS-1$ } else desc= fStringPattern; String[] args= new String[] {desc, "{0}", fScopeDescription}; //$NON-NLS-1$ switch (fLimitTo) { case IJavaSearchConstants.IMPLEMENTORS: return SearchMessages.getFormattedString("JavaSearchOperation.implementorsPostfix", args); //$NON-NLS-1$ case IJavaSearchConstants.DECLARATIONS: return SearchMessages.getFormattedString("JavaSearchOperation.declarationsPostfix", args); //$NON-NLS-1$ case IJavaSearchConstants.REFERENCES: return SearchMessages.getFormattedString("JavaSearchOperation.referencesPostfix", args); //$NON-NLS-1$ case IJavaSearchConstants.ALL_OCCURRENCES: return SearchMessages.getFormattedString("JavaSearchOperation.occurrencesPostfix", args); //$NON-NLS-1$ case IJavaSearchConstants.READ_REFERENCES: return SearchMessages.getFormattedString("JavaSearchOperation.readReferencesPostfix", args); //$NON-NLS-1$ case IJavaSearchConstants.WRITE_REFERENCES: return SearchMessages.getFormattedString("JavaSearchOperation.writeReferencesPostfix", args); //$NON-NLS-1$ default: return SearchMessages.getFormattedString("JavaSearchOperation.occurrencesPostfix", args); //$NON-NLS-1$; } } ImageDescriptor getImageDescriptor() { if (fLimitTo == IJavaSearchConstants.IMPLEMENTORS || fLimitTo == IJavaSearchConstants.DECLARATIONS) return JavaPluginImages.DESC_OBJS_SEARCH_DECL; else return JavaPluginImages.DESC_OBJS_SEARCH_REF; } }
5,356
Bug 5356 Search Result descriptions don't use singular
Text and Java search result descriptions (visible in Search view's title toot tip and Search histories) don't show singular text version if there's exactly one match
resolved fixed
acb4754
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-08T17:09:19Z"
"2001-10-30T16:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import java.text.MessageFormat; import java.util.HashMap; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.viewers.IInputSelectionProvider; import org.eclipse.jface.viewers.ISelection; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.search.ui.IContextMenuContributor; import org.eclipse.search.ui.ISearchResultView; import org.eclipse.search.ui.ISearchResultViewEntry; import org.eclipse.search.ui.SearchUI; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.search.IJavaSearchResultCollector; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.GroupContext; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.OpenTypeHierarchyUtil; import org.eclipse.jdt.internal.ui.util.SelectionUtil; public class JavaSearchResultCollector implements IJavaSearchResultCollector { private static final String MATCH= SearchMessages.getString("SearchResultCollector.match"); //$NON-NLS-1$ private static final String MATCHES= SearchMessages.getString("SearchResultCollector.matches"); //$NON-NLS-1$ private static final String DONE= SearchMessages.getString("SearchResultCollector.done"); //$NON-NLS-1$ private static final String SEARCHING= SearchMessages.getString("SearchResultCollector.searching"); //$NON-NLS-1$ private static final Integer POTENTIAL_MATCH_VALUE= new Integer(POTENTIAL_MATCH); private IProgressMonitor fMonitor; private IContextMenuContributor fContextMenu; private ISearchResultView fView; private JavaSearchOperation fOperation; private int fMatchCount= 0; private Integer[] fMessageFormatArgs= new Integer[1]; private class ContextMenuContributor implements IContextMenuContributor { public void fill(IMenuManager menu, IInputSelectionProvider inputProvider) { JavaPlugin.createStandardGroups(menu); new JavaSearchGroup().fill(menu, new GroupContext(inputProvider)); OpenTypeHierarchyUtil.addToMenu(getWorbenchWindow(), menu, convertSelection(inputProvider.getSelection())); } private Object convertSelection(ISelection selection) { Object element= SelectionUtil.getSingleElement(selection); if (!(element instanceof ISearchResultViewEntry)) return null; IMarker marker= ((ISearchResultViewEntry)element).getSelectedMarker(); try { return JavaCore.create((String) ((IMarker) marker).getAttribute(IJavaSearchUIConstants.ATT_JE_HANDLE_ID)); } catch (CoreException ex) { ExceptionHandler.log(ex, SearchMessages.getString("Search.Error.createJavaElement.message")); //$NON-NLS-1$ return null; } } } public JavaSearchResultCollector() { fContextMenu= new ContextMenuContributor(); } /** * @see IJavaSearchResultCollector#aboutToStart(). */ public void aboutToStart() { fView= SearchUI.getSearchResultView(); fMatchCount= 0; if (fView != null) { fView.searchStarted( JavaSearchPage.EXTENSION_POINT_ID, fOperation.getDescription(), fOperation.getImageDescriptor(), fContextMenu, JavaSearchResultLabelProvider.INSTANCE, new GotoMarkerAction(), new GroupByKeyComputer(), fOperation); } if (!getProgressMonitor().isCanceled()) getProgressMonitor().subTask(SEARCHING); } /** * @see IJavaSearchResultCollector#accept */ public void accept(IResource resource, int start, int end, IJavaElement enclosingElement, int accuracy) throws CoreException { IMarker marker= resource.createMarker(SearchUI.SEARCH_MARKER); HashMap attributes; Object groupKey= enclosingElement; if (accuracy == POTENTIAL_MATCH) { attributes= new HashMap(6); attributes.put(IJavaSearchUIConstants.ATT_ACCURACY, POTENTIAL_MATCH_VALUE); if (groupKey == null) groupKey= "?:null"; //$NON-NLS-1$ else groupKey= "?:" + enclosingElement.getHandleIdentifier(); //$NON-NLS-1$ } else attributes= new HashMap(5); JavaCore.addJavaElementMarkerAttributes(attributes, enclosingElement); attributes.put(IJavaSearchUIConstants.ATT_JE_HANDLE_ID, enclosingElement.getHandleIdentifier()); attributes.put(IMarker.CHAR_START, new Integer(Math.max(start, 0))); attributes.put(IMarker.CHAR_END, new Integer(Math.max(end, 0))); if (enclosingElement instanceof IMember && ((IMember)enclosingElement).isBinary()) attributes.put(IWorkbenchPage.EDITOR_ID_ATTR, JavaUI.ID_CF_EDITOR); else attributes.put(IWorkbenchPage.EDITOR_ID_ATTR, JavaUI.ID_CU_EDITOR); marker.setAttributes(attributes); fView.addMatch(enclosingElement.getElementName(), groupKey, resource, marker); fMatchCount++; if (!getProgressMonitor().isCanceled()) getProgressMonitor().subTask(getFormattedMatchesString(fMatchCount)); } /** * @see IJavaSearchResultCollector#done(). */ public void done() { if (!getProgressMonitor().isCanceled()) { String matchesString= getFormattedMatchesString(fMatchCount); getProgressMonitor().setTaskName(MessageFormat.format(DONE, new String[]{matchesString})); } if (fView != null) fView.searchFinished(); // Cut no longer unused references because the collector might be re-used fView= null; fMonitor= null; } /** * @see IJavaSearchResultCollector#getProgressMonitor(). */ public IProgressMonitor getProgressMonitor() { return fMonitor; }; void setProgressMonitor(IProgressMonitor pm) { fMonitor= pm; } void setOperation(JavaSearchOperation operation) { fOperation= operation; } private String getFormattedMatchesString(int count) { if (fMatchCount == 1) return MATCH; fMessageFormatArgs[0]= new Integer(count); return MessageFormat.format(MATCHES, fMessageFormatArgs); } private IWorkbenchWindow getWorbenchWindow() { IWorkbenchWindow wbWindow= null; if (fView != null && fView.getSite() != null) wbWindow= fView.getSite().getWorkbenchWindow(); if (wbWindow == null) wbWindow= JavaPlugin.getActiveWorkbenchWindow(); return wbWindow; } }
5,587
Bug 5587 Step Over jumps to caller
Build 20011105 - set breakpoint in org.eclipse.ui.internal.ShowViewAction's constructor, on line indicated by [BP] below (note source has been modified since 20011105): protected ShowViewAction(IWorkbenchWindow window, IViewDescriptor desc) { super(""); String accel = desc.getAccelerator(); String label = desc.getLabel(); [BP] setText(accel == null ? label : label + "@" + accel); setImageDescriptor(desc.getImageDescriptor()); setToolTipText(label); WorkbenchHelp.setHelp(this, new Object[] {IHelpContextIds.SHOW_VIEW_ACTION}); this.window = window; this.desc = desc; } - when breakpoint was hit, I clicked on the Step Over button - it had the same effect as run to return, and stepping back to the caller. - it left me in ShowViewMenu.getAction, on line marked ***: private IAction getAction(String id) { // Keep a cache, rather than creating a new action each time, // so that image caching in ActionContributionItem works. IAction action = (IAction) actions.get(id); if (action == null) { IViewRegistry reg = WorkbenchPlugin.getDefault().getViewRegistry (); IViewDescriptor desc = reg.find(id); if (desc != null) { *** action = new ShowViewAction(getWindow(), desc); actions.put(id, action); } } return action; }
verified fixed
a1fa1cd
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-08T17:14:34Z"
"2001-11-06T18:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaDebugPreferencePage.java
package org.eclipse.jdt.internal.ui.preferences; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.ArrayList; import java.util.HashSet; import java.util.Iterator; import java.util.List; import java.util.Set; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.debug.core.JDIDebugModel; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.IPreferencesConstants; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.dialogs.ElementListSelectionDialog; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.ui.IJavaElementSearchConstants; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.CheckboxTableViewer; import org.eclipse.jface.viewers.ICellEditorValidator; import org.eclipse.jface.viewers.ICellModifier; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredContentProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.ITableLabelProvider; import org.eclipse.jface.viewers.LabelProvider; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.Viewer; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.TableEditor; import org.eclipse.swt.events.FocusAdapter; import org.eclipse.swt.events.FocusEvent; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Table; import org.eclipse.swt.widgets.TableItem; import org.eclipse.swt.widgets.Text; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.dialogs.SelectionDialog; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.model.WorkbenchViewerSorter; /** * Preference page for debug preferences that apply specifically to * Java Debugging. */ public class JavaDebugPreferencePage extends PreferencePage implements IWorkbenchPreferencePage, Listener { // Preference store keys private static final String SHOW_HEX= IPreferencesConstants.SHOW_HEX_VALUES; private static final String SHOW_CHARS= IPreferencesConstants.SHOW_CHAR_VALUES; private static final String SHOW_UNSIGNED= IPreferencesConstants.SHOW_UNSIGNED_VALUES; private static final String DEFAULT_NEW_FILTER_TEXT = ""; private static final Image IMG_CUNIT = JavaPluginImages.get(JavaPluginImages.IMG_OBJS_CUNIT); private static final Image IMG_PKG = JavaPluginImages.get(JavaPluginImages.IMG_OBJS_PACKAGE); // Preference widgets private Button fHexButton; private Button fCharButton; private Button fUnsignedButton; private CheckboxTableViewer fFilterViewer; private Table fFilterTable; private Button fUseFiltersCheckbox; private Button fAddPackageButton; private Button fAddTypeButton; private Button fRemoveFilterButton; private Button fAddFilterButton; private Button fFilterSyntheticButton; private Button fFilterStaticButton; private Button fFilterConstructorButton; private Text fEditorText; private TableEditor fTableEditor; private TableItem fNewTableItem; private StepFilter fNewStepFilter; // table columns private static final String[] TABLE_COLUMN_PROPERTIES = {"filter_name"}; //$NON-NLS-1$ private static final int FILTERNAME_PROP= 0; private StepFilterContentProvider fStepFilterContentProvider; private ICellEditorValidator fCellValidator; /** * Model object that represents a single entry in the table */ protected class StepFilter { private String fName; private boolean fChecked; public StepFilter(String name, boolean checked) { setName(name); setChecked(checked); } public String getName() { return fName; } public void setName(String name) { fName = name; } public boolean isChecked() { return fChecked; } public void setChecked(boolean checked) { fChecked = checked; } } /** * Content provider for the table. Content consists of instances of StepFilter. */ protected class StepFilterContentProvider implements IStructuredContentProvider { private CheckboxTableViewer fViewer; private List fFilters; public StepFilterContentProvider(CheckboxTableViewer viewer) { fViewer = viewer; List active = JDIDebugModel.getActiveStepFilters(); List inactive = JDIDebugModel.getInactiveStepFilters(); populateFilters(active, inactive); } public void setDefaults() { fViewer.remove(fFilters.toArray()); List active = JDIDebugModel.getDefaultActiveStepFilters(); List inactive = JDIDebugModel.getDefaultInactiveStepFilters(); populateFilters(active, inactive); fFilterSyntheticButton.setSelection(JDIDebugModel.getDefaultFilterSynthetic()); fFilterStaticButton.setSelection(JDIDebugModel.getDefaultFilterStatic()); fFilterConstructorButton.setSelection(JDIDebugModel.getDefaultFilterConstructor()); boolean useStepFilters = JDIDebugModel.getDefaultUseStepFilters(); fUseFiltersCheckbox.setSelection(useStepFilters); toggleStepFilterWidgetsEnabled(useStepFilters); } protected void populateFilters(List activeList, List inactiveList) { fFilters = new ArrayList(activeList.size() + inactiveList.size()); populateList(activeList, true); populateList(inactiveList, false); } protected void populateList(List list, boolean checked) { Iterator iterator = list.iterator(); while (iterator.hasNext()) { String name = (String)iterator.next(); addFilter(name, checked); } } public StepFilter addFilter(String name, boolean checked) { StepFilter filter = new StepFilter(name, checked); if (!fFilters.contains(filter)) { fFilters.add(filter); fViewer.add(filter); fViewer.setChecked(filter, checked); } return filter; } public void saveFilters() { JDIDebugModel.setUseStepFilters(fUseFiltersCheckbox.getSelection()); JDIDebugModel.setFilterSynthetic(fFilterSyntheticButton.getSelection()); JDIDebugModel.setFilterStatic(fFilterStaticButton.getSelection()); JDIDebugModel.setFilterConstructor(fFilterConstructorButton.getSelection()); List active = new ArrayList(fFilters.size()); List inactive = new ArrayList(fFilters.size()); Iterator iterator = fFilters.iterator(); while (iterator.hasNext()) { StepFilter filter = (StepFilter)iterator.next(); String name = filter.getName(); if (filter.isChecked()) { active.add(name); } else { inactive.add(name); } } JDIDebugModel.setActiveStepFilters(active); JDIDebugModel.setInactiveStepFilters(inactive); } public void removeFilters(Object[] filters) { for (int i = 0; i < filters.length; i++) { StepFilter filter = (StepFilter)filters[i]; fFilters.remove(filter); } fViewer.remove(filters); } public void toggleFilter(StepFilter filter) { boolean newState = !filter.isChecked(); filter.setChecked(newState); fViewer.setChecked(filter, newState); } /* * @see IStructuredContentProvider#getElements(Object) */ public Object[] getElements(Object inputElement) { return fFilters.toArray(); } /* * @see IContentProvider#inputChanged(Viewer, Object, Object) */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { } /* * @see IContentProvider#dispose() */ public void dispose() { } } /** * Support for editing entries in filter table. */ protected class CellModifier implements ICellModifier { public CellModifier() { } /* * @see ICellModifier#canModify(Object, String) */ public boolean canModify(Object element, String property) { return isNameProperty(property); } /* * @see ICellModifier#getValue(Object, String) */ public Object getValue(Object element, String property) { if (isNameProperty(property)) { StepFilter filter = (StepFilter)element; return filter.getName(); } return null; } /* * @see ICellModifier#modify(Object, String, Object) */ public void modify(Object element, String property, Object value) { if (value != null) { if (isNameProperty(property) && element instanceof TableItem) { String stringValue = (String) value; TableItem tableItem = (TableItem)element; StepFilter filter = (StepFilter)tableItem.getData(); filter.setName(stringValue); tableItem.setText(stringValue); } } } private boolean isNameProperty(String property) { return property.equals(TABLE_COLUMN_PROPERTIES[FILTERNAME_PROP]); } }; /** * Label provider for StepFilter model objects */ protected class StepFilterLabelProvider extends LabelProvider implements ITableLabelProvider { /* * @see ITableLabelProvider#getColumnText(Object, int) */ public String getColumnText(Object object, int column) { if (column == 0) { return ((StepFilter)object).getName(); } return ""; //$NON-NLS-1$ } /* * @see ILabelProvider#getText(Object) */ public String getText(Object element) { return ((StepFilter)element).getName(); } /* * @see ITableLabelProvider#getColumnImage(Object, int) */ public Image getColumnImage(Object object, int column) { String name = ((StepFilter)object).getName(); if (name.endsWith(".*")) { return IMG_PKG; } else { return IMG_CUNIT; } } } public JavaDebugPreferencePage() { super(); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); } /** * Set the default preferences for this page. */ public static void initDefaults(IPreferenceStore store) { store.setDefault(SHOW_HEX, false); store.setDefault(SHOW_CHARS, false); store.setDefault(SHOW_UNSIGNED, false); } /** * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { WorkbenchHelp.setHelp(getControl(), new DialogPageContextComputer(this, IJavaHelpContextIds.JAVA_BASE_PREFERENCE_PAGE)); //The main composite Composite composite = new Composite(parent, SWT.NULL); GridLayout layout = new GridLayout(); layout.numColumns = 1; composite.setLayout(layout); GridData data = new GridData(); data.verticalAlignment = GridData.FILL; data.horizontalAlignment = GridData.FILL; composite.setLayoutData(data); createPrimitiveDisplayPreferences(composite); createSpace(composite); createStepFilterPreferences(composite); setValues(); return composite; } /** * Create the primitive display preferences composite widget */ private void createPrimitiveDisplayPreferences(Composite parent) { Composite comp= createLabelledComposite(parent, 1, "Primitive type display options"); fHexButton= createCheckButton(comp, "Display &hexadecimal values (byte, short, char, int, long)"); fCharButton= createCheckButton(comp, "Display ASCII &character values (byte, short, int, long)"); fUnsignedButton= createCheckButton(comp, "Display &unsigned values (byte)"); } /** * Create a group to contain the step filter related widgetry */ private void createStepFilterPreferences(Composite parent) { Composite comp = createLabelledComposite(parent, 1, "Step filters"); // top level container Composite container = new Composite(comp, SWT.NONE); GridLayout layout = new GridLayout(); layout.numColumns = 2; layout.marginHeight = 0; layout.marginWidth = 0; container.setLayout(layout); // use filters checkbox fUseFiltersCheckbox = new Button(container, SWT.CHECK); fUseFiltersCheckbox.setText("Use &step filters"); fUseFiltersCheckbox.setToolTipText("Toggle whether step filters are used at all"); GridData gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalSpan = 2; fUseFiltersCheckbox.setLayoutData(gd); fUseFiltersCheckbox.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent se) { toggleStepFilterWidgetsEnabled(fUseFiltersCheckbox.getSelection()); } public void widgetDefaultSelected(SelectionEvent se) { } }); // filter table fFilterViewer = new CheckboxTableViewer(container, SWT.BORDER | SWT.MULTI | SWT.FULL_SELECTION); fFilterTable = fFilterViewer.getTable(); fTableEditor = new TableEditor(fFilterTable); fFilterViewer.setLabelProvider(new StepFilterLabelProvider()); fFilterViewer.setSorter(new WorkbenchViewerSorter()); fStepFilterContentProvider = new StepFilterContentProvider(fFilterViewer); fFilterViewer.setContentProvider(fStepFilterContentProvider); fFilterViewer.setInput(JDIDebugModel.getAllStepFilters()); gd = new GridData(GridData.FILL_BOTH | GridData.GRAB_HORIZONTAL | GridData.GRAB_VERTICAL); gd.heightHint = 150; gd.widthHint = 300; fFilterViewer.getTable().setLayoutData(gd); fFilterViewer.addCheckStateListener(new ICheckStateListener() { public void checkStateChanged(CheckStateChangedEvent event) { StepFilter filter = (StepFilter)event.getElement(); fStepFilterContentProvider.toggleFilter(filter); } }); fFilterViewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { ISelection selection = event.getSelection(); if (selection.isEmpty()) { fRemoveFilterButton.setEnabled(false); } else { fRemoveFilterButton.setEnabled(true); } } }); // button container Composite buttonContainer = new Composite(container, SWT.NONE); gd = new GridData(GridData.FILL_VERTICAL); buttonContainer.setLayoutData(gd); GridLayout buttonLayout = new GridLayout(); buttonLayout.numColumns = 1; buttonLayout.marginHeight = 0; buttonLayout.marginWidth = 0; buttonContainer.setLayout(buttonLayout); // Add filter button fAddFilterButton = new Button(buttonContainer, SWT.PUSH); fAddFilterButton.setText("Add &Filter"); fAddFilterButton.setToolTipText("Key in the name of a new step filter"); gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING); fAddFilterButton.setLayoutData(gd); fAddFilterButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent se) { addActiveFilter(); } public void widgetDefaultSelected(SelectionEvent se) { } }); // Add type button fAddTypeButton = new Button(buttonContainer, SWT.PUSH); fAddTypeButton.setText("Add &Type..."); fAddTypeButton.setToolTipText("Choose a java type and add it to step filters"); gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING); fAddTypeButton.setLayoutData(gd); fAddTypeButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent se) { addType(); } public void widgetDefaultSelected(SelectionEvent se) { } }); // Add package button fAddPackageButton = new Button(buttonContainer, SWT.PUSH); fAddPackageButton.setText("Add &Package..."); fAddPackageButton.setToolTipText("Choose a package and add it to step filters"); gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING); fAddPackageButton.setLayoutData(gd); fAddPackageButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent se) { addPackage(); } public void widgetDefaultSelected(SelectionEvent se) { } }); // Remove button fRemoveFilterButton = new Button(buttonContainer, SWT.PUSH); fRemoveFilterButton.setText("&Remove"); fRemoveFilterButton.setToolTipText("Remove all selected step filters"); gd = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_BEGINNING); fRemoveFilterButton.setLayoutData(gd); fRemoveFilterButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent se) { removeFilters(); } public void widgetDefaultSelected(SelectionEvent se) { } }); fRemoveFilterButton.setEnabled(false); // filter synthetic checkbox fFilterSyntheticButton = new Button(container, SWT.CHECK); fFilterSyntheticButton.setText("Filter s&ynthetic methods (requires VM support)"); gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalSpan = 2; fFilterSyntheticButton.setLayoutData(gd); // filter static checkbox fFilterStaticButton = new Button(container, SWT.CHECK); fFilterStaticButton.setText("Filter static &initializers"); gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalSpan = 2; fFilterStaticButton.setLayoutData(gd); // filter constructor checkbox fFilterConstructorButton = new Button(container, SWT.CHECK); fFilterConstructorButton.setText("Filter co&nstructors"); gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING); gd.horizontalSpan = 2; fFilterConstructorButton.setLayoutData(gd); fFilterSyntheticButton.setSelection(JDIDebugModel.getFilterSynthetic()); fFilterStaticButton.setSelection(JDIDebugModel.getFilterStatic()); fFilterConstructorButton.setSelection(JDIDebugModel.getFilterConstructor()); boolean enabled = JDIDebugModel.useStepFilters(); fUseFiltersCheckbox.setSelection(enabled); toggleStepFilterWidgetsEnabled(enabled); } private void toggleStepFilterWidgetsEnabled(boolean enabled) { fFilterViewer.getTable().setEnabled(enabled); fAddPackageButton.setEnabled(enabled); fAddTypeButton.setEnabled(enabled); fAddFilterButton.setEnabled(enabled); fFilterSyntheticButton.setEnabled(enabled); fFilterStaticButton.setEnabled(enabled); fFilterConstructorButton.setEnabled(enabled); if (!enabled) { fRemoveFilterButton.setEnabled(enabled); } else if (!fFilterViewer.getSelection().isEmpty()) { fRemoveFilterButton.setEnabled(true); } } /** * Create a new filter in the table (with the default 'new filter' value), * then open up an in-place editor on it. */ private void addActiveFilter() { fNewStepFilter = fStepFilterContentProvider.addFilter(DEFAULT_NEW_FILTER_TEXT, true); fNewTableItem = fFilterTable.getItem(0); editFilter(); } private void editFilter() { // if a previous edit is still in progress, finish it if (fEditorText != null) { validateChangeAndCleanup(); } // create & configure Text widget for editor fEditorText = new Text(fFilterTable, SWT.BORDER | SWT.SINGLE); GridData gd = new GridData(GridData.FILL_BOTH); fEditorText.setLayoutData(gd); // set the editor fTableEditor.horizontalAlignment = SWT.LEFT; fTableEditor.grabHorizontal = true; fTableEditor.setEditor(fEditorText, fNewTableItem, 0); // get the editor ready to use fEditorText.setText(fNewStepFilter.getName()); fEditorText.selectAll(); setEditorListeners(fEditorText); fEditorText.setFocus(); } private void setEditorListeners(Text text) { // CR means commit the changes, ESC means abort and don't commit text.addKeyListener(new KeyAdapter() { public void keyReleased(KeyEvent event) { if (event.character == SWT.CR) { validateChangeAndCleanup(); } else if (event.character == SWT.ESC) { removeNewFilter(); cleanupEditor(); } } }); // Consider loss of focus on the editor to mean the same as CR text.addFocusListener(new FocusAdapter() { public void focusLost(FocusEvent event) { validateChangeAndCleanup(); } }); // Consume traversal events from the text widget so that CR doesn't // traverse away to dialog's default button. Without this, hitting // CR in the text field closes the entire dialog. text.addListener(SWT.Traverse, new Listener() { public void handleEvent(Event event) { event.doit = false; } }); } private void validateChangeAndCleanup() { String trimmedValue = fEditorText.getText().trim(); // if the new value is blank, remove the filter if (trimmedValue.length() < 1) { removeNewFilter(); } // if it's invalid, beep and leave the sitting in the editor else if (!validateEditorInput(trimmedValue)) { getShell().getDisplay().beep(); return; // otherwise, commit the new value } else { fNewTableItem.setText(trimmedValue); fNewStepFilter.setName(trimmedValue); } cleanupEditor(); } /** * Cleanup all widgetry & resources used by the in-place editing */ private void cleanupEditor() { if (fEditorText != null) { fEditorText.dispose(); fEditorText = null; fNewStepFilter = null; fNewTableItem = null; fTableEditor.setEditor(null, null, 0); } } private void removeNewFilter() { fStepFilterContentProvider.removeFilters(new Object[] {fNewStepFilter}); } /** * A valid step filter is simply one that is not empty (all spaces), * and has no embedded spaces. Beyond this, a string cannot be * validated as corresponding to an existing type or package (and * this is probably not even desirable). */ private boolean validateEditorInput(String trimmedValue) { int embeddedSpace = trimmedValue.indexOf(' '); if (embeddedSpace != -1) { return false; } return true; } private void addType() { Shell shell= JavaPlugin.getActiveWorkbenchShell(); SelectionDialog dialog= null; try { dialog= JavaUI.createTypeDialog(shell, new ProgressMonitorDialog(shell), SearchEngine.createWorkspaceScope(), IJavaElementSearchConstants.CONSIDER_TYPES, false); } catch (JavaModelException jme) { String title= "Add type to step filters"; String message= "Could not open type selection dialog for step filters"; ExceptionHandler.handle(jme, title, message); return; } dialog.setTitle("Add type to step filters"); dialog.setMessage("Select a type to filter when stepping"); if (dialog.open() == IDialogConstants.CANCEL_ID) { return; } Object[] types= dialog.getResult(); if (types != null && types.length > 0) { IType type = (IType)types[0]; fStepFilterContentProvider.addFilter(type.getFullyQualifiedName(), true); } } private void addPackage() { Shell shell= JavaPlugin.getActiveWorkbenchShell(); SelectionDialog dialog = null; try { dialog = createAllPackagesDialog(shell); } catch (JavaModelException jme) { String title= "Add package to step filters"; String message= "Could not open package selection dialog for step filters"; ExceptionHandler.handle(jme, title, message); return; } dialog.setTitle("Add package to step filters"); dialog.setMessage("Select a package to filter when stepping"); if (dialog.open() == IDialogConstants.CANCEL_ID) { return; } Object[] packages= dialog.getResult(); if (packages != null && packages.length > 0) { IJavaElement pkg = (IJavaElement)packages[0]; String filter = pkg.getElementName(); if (filter.length() < 1) { filter = "(default package)"; } else { filter += ".*"; //$NON-NLS-1$ } fStepFilterContentProvider.addFilter(filter, true); } } private void removeFilters() { IStructuredSelection selection = (IStructuredSelection)fFilterViewer.getSelection(); fStepFilterContentProvider.removeFilters(selection.toArray()); } /** * Ignore package fragments that contain only non-java resources, and make sure * that each fragment is added to the list only once. */ private SelectionDialog createAllPackagesDialog(Shell shell) throws JavaModelException{ IWorkspaceRoot wsroot= JavaPlugin.getWorkspace().getRoot(); IJavaModel model= JavaCore.create(wsroot); IJavaProject[] projects= model.getJavaProjects(); Set packageNameSet= new HashSet(); List packageList = new ArrayList(); for (int i = 0; i < projects.length; i++) { IPackageFragment[] pkgs= projects[i].getPackageFragments(); for (int j = 0; j < pkgs.length; j++) { IPackageFragment pkg = pkgs[j]; if (!pkg.hasChildren() && (pkg.getNonJavaResources().length > 0)) { continue; } if (packageNameSet.add(pkg.getElementName())) { packageList.add(pkg); } } } int flags= JavaElementLabelProvider.SHOW_DEFAULT; ElementListSelectionDialog dialog= new ElementListSelectionDialog(shell, new JavaElementLabelProvider(flags)); dialog.setIgnoreCase(false); dialog.setElements(packageList.toArray()); // XXX inefficient return dialog; } /** * @see IWorkbenchPreferencePage#init(IWorkbench) */ public void init(IWorkbench workbench) { } /** * @see PreferencePage#performOk() * Also, notifies interested listeners */ public boolean performOk() { storeValues(); getPreferenceStore().firePropertyChangeEvent(IPreferencesConstants.VARIABLE_RENDERING, new Boolean(true), new Boolean(false)); fStepFilterContentProvider.saveFilters(); return true; } /** * Sets the default preferences */ protected void performDefaults() { setDefaultValues(); super.performDefaults(); } private void setDefaultValues() { IPreferenceStore store = getPreferenceStore(); fHexButton.setSelection(store.getDefaultBoolean(SHOW_HEX)); fCharButton.setSelection(store.getDefaultBoolean(SHOW_CHARS)); fUnsignedButton.setSelection(store.getDefaultBoolean(SHOW_UNSIGNED)); fStepFilterContentProvider.setDefaults(); } /** * Creates a button with the given label and sets the default * configuration data. */ private Button createCheckButton(Composite parent, String label) { Button button= new Button(parent, SWT.CHECK | SWT.LEFT); button.setText(label); button.addListener(SWT.Selection, this); // FieldEditor GridData GridData data = new GridData(); button.setLayoutData(data); return button; } /** * Creates composite control and sets the default layout data. * * @param parent the parent of the new composite * @param numColumns the number of columns for the new composite * @param labelText the text label of the new composite * @return the newly-created composite */ private Composite createLabelledComposite(Composite parent, int numColumns, String labelText) { Composite comp = new Composite(parent, SWT.NONE); //GridLayout GridLayout layout = new GridLayout(); layout.numColumns = numColumns; comp.setLayout(layout); //GridData GridData gd= new GridData(); gd.verticalAlignment = GridData.FILL; gd.horizontalAlignment = GridData.FILL; comp.setLayoutData(gd); //Label Label label = new Label(comp, SWT.NONE); label.setText(labelText); gd = new GridData(); gd.horizontalSpan = numColumns; label.setLayoutData(gd); return comp; } /** * Create a vertical space to separate groups of controls. */ private void createSpace(Composite parent) { Label vfiller = new Label(parent, SWT.LEFT); GridData gridData = new GridData(); gridData.horizontalAlignment = GridData.BEGINNING; gridData.grabExcessHorizontalSpace = false; gridData.verticalAlignment = GridData.CENTER; gridData.grabExcessVerticalSpace = false; vfiller.setLayoutData(gridData); } /** * @see Listener#handleEvent(Event) */ public void handleEvent(Event event) { } /** * Set the values of the component widgets based on the * values in the preference store */ private void setValues() { IPreferenceStore store = getPreferenceStore(); fHexButton.setSelection(store.getBoolean(SHOW_HEX)); fCharButton.setSelection(store.getBoolean(SHOW_CHARS)); fUnsignedButton.setSelection(store.getBoolean(SHOW_UNSIGNED)); } /** * Store the preference values based on the state of the * component widgets */ private void storeValues() { IPreferenceStore store = getPreferenceStore(); store.setValue(SHOW_HEX, fHexButton.getSelection()); store.setValue(SHOW_CHARS, fCharButton.getSelection()); store.setValue(SHOW_UNSIGNED, fUnsignedButton.getSelection()); } }
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
org.eclipse.jdt.ui/core
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/code/ExtractMethodAnalyzer.java
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
org.eclipse.jdt.ui/core
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/code/ExtractMethodRefactoring.java
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
org.eclipse.jdt.ui/core
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/code/StatementAnalyzer.java
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
org.eclipse.jdt.ui/core
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/code/flow/FlowContext.java
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
org.eclipse.jdt.ui/core
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/code/flow/FlowInfo.java
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
org.eclipse.jdt.ui/core
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/code/flow/ForFlowInfo.java
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
org.eclipse.jdt.ui/core
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/code/flow/InputFlowAnalyzer.java
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
org.eclipse.jdt.ui/core
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/code/flow/WhileFlowInfo.java
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
org.eclipse.jdt.ui/core
5,404
Bug 5404 Extract method with 'continue' statement not possible
1. Open WorkingSetReader (1.1) 2. Select the full for-statement in readXML(): for (int k= 0; k < contents.getLength(); k++) {...} 3. Extract method ==> dialog says, it's not possible to do so because of the 'continue' statement
resolved fixed
9a725c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-09T14:28:35Z"
"2001-11-01T10:20:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/util/SelectionAnalyzer.java
4,103
Bug 4103 Should have shortcuts for new file and folder (1GIF4F6)
Another vote for adding File and Folder to the new menu in the Java perspective. NOTES:
verified fixed
1022fe5
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-10T17:11:57Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaPerspectiveFactory.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui; import org.eclipse.ui.IFolderLayout; import org.eclipse.ui.IPageLayout; import org.eclipse.ui.IPerspectiveFactory; import org.eclipse.search.ui.SearchUI; import org.eclipse.debug.ui.IDebugUIConstants; import org.eclipse.jdt.ui.JavaUI; public class JavaPerspectiveFactory implements IPerspectiveFactory { /** * Constructs a new Default layout engine. */ public JavaPerspectiveFactory() { super(); } public void createInitialLayout(IPageLayout layout) { String editorArea = layout.getEditorArea(); IFolderLayout folder= layout.createFolder("left", IPageLayout.LEFT, (float)0.25, editorArea); //$NON-NLS-1$ folder.addView(JavaUI.ID_PACKAGES); folder.addView(JavaUI.ID_TYPE_HIERARCHY); folder.addPlaceholder(IPageLayout.ID_RES_NAV); IFolderLayout outputfolder= layout.createFolder("bottom", IPageLayout.BOTTOM, (float)0.75, editorArea); //$NON-NLS-1$ outputfolder.addView(IPageLayout.ID_TASK_LIST); outputfolder.addView(SearchUI.SEARCH_RESULT_VIEW_ID); outputfolder.addView(IDebugUIConstants.ID_CONSOLE_VIEW); layout.addView(IPageLayout.ID_OUTLINE, IPageLayout.RIGHT, (float)0.75, editorArea); layout.addActionSet(IDebugUIConstants.DEBUG_ACTION_SET); layout.addActionSet(JavaUI.ID_ACTION_SET); layout.addActionSet(IUIConstants.ID_REFACTORING_ACTION_SET); // views - java layout.addShowViewShortcut(JavaUI.ID_PACKAGES); layout.addShowViewShortcut(JavaUI.ID_TYPE_HIERARCHY); layout.addShowViewShortcut(SearchUI.SEARCH_RESULT_VIEW_ID); // views - debugging layout.addShowViewShortcut(IDebugUIConstants.ID_PROCESS_VIEW); layout.addShowViewShortcut(IDebugUIConstants.ID_CONSOLE_VIEW); // views - standard workbench layout.addShowViewShortcut(IPageLayout.ID_OUTLINE); layout.addShowViewShortcut(IPageLayout.ID_TASK_LIST); layout.addShowViewShortcut(IPageLayout.ID_RES_NAV); // new actions - Java project creation wizard layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewPackageCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewClassCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewInterfaceCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewSnippetCreationWizard"); //$NON-NLS-1$ } }
5,774
Bug 5774 Unpredicatable behaviour on double click in packages view
from EC: If you double click a file in the packages view, it opens the file (technically, compilation unit I believe) -- if not already open. However, if the file is already open, a single click selects it as the active editor tag; a double click expands its structure in the packages view. This is unpredictable behavior ;
resolved fixed
d13ebe7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-11T14:10:11Z"
"2001-11-11T14:46:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.packageview; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IPath; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IOpenable; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.compare.JavaAddElementFromHistory; import org.eclipse.jdt.internal.ui.compare.JavaReplaceWithEditionAction; import org.eclipse.jdt.internal.ui.dnd.DelegatingDragAdapter; import org.eclipse.jdt.internal.ui.dnd.DelegatingDropAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.dnd.TransferDragSourceListener; import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener; import org.eclipse.jdt.internal.ui.javaeditor.IClassFileEditorInput; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.javaeditor.JarEntryEditorInput; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.IPreferencesConstants; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringAction; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringGroup; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; import org.eclipse.jdt.internal.ui.reorg.DeleteAction; import org.eclipse.jdt.internal.ui.reorg.ReorgGroup; import org.eclipse.jdt.internal.ui.search.JavaSearchGroup; import org.eclipse.jdt.internal.ui.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.util.OpenTypeHierarchyUtil; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementSorter; import org.eclipse.jdt.internal.ui.viewsupport.MarkerErrorTickProvider; import org.eclipse.jdt.internal.ui.viewsupport.ProblemTreeViewer; import org.eclipse.jdt.internal.ui.viewsupport.StatusBarUpdater; import org.eclipse.jdt.internal.ui.wizards.NewGroup; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.IPackagesViewPart; import org.eclipse.jdt.ui.JavaElementContentProvider; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.DecoratingLabelProvider; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ILabelDecorator; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.ITreeViewerListener; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.TreeExpansionEvent; import org.eclipse.jface.viewers.TreeViewer; import org.eclipse.search.ui.IWorkingSet; import org.eclipse.search.ui.SearchUI; import org.eclipse.swt.SWT; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DragSource; import org.eclipse.swt.dnd.FileTransfer; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.ScrollBar; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Tree; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IMemento; import org.eclipse.ui.IPartListener; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IViewSite; import org.eclipse.ui.IWorkbenchActionConstants; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.PartInitException; import org.eclipse.ui.actions.OpenPerspectiveMenu; import org.eclipse.ui.actions.OpenWithMenu; import org.eclipse.ui.actions.RefreshAction; import org.eclipse.ui.dialogs.PropertyDialogAction; import org.eclipse.ui.help.ViewContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.ISetSelectionTarget; import org.eclipse.ui.part.ViewPart; import org.eclipse.ui.views.internal.framelist.BackAction; import org.eclipse.ui.views.internal.framelist.ForwardAction; import org.eclipse.ui.views.internal.framelist.FrameList; import org.eclipse.ui.views.internal.framelist.GoIntoAction; import org.eclipse.ui.views.internal.framelist.UpAction; /** * The ViewPart for the ProjectExplorer. It listens to part activation events. * When selection linking with the editor is enabled the view selection tracks * the active editor page. Similarly when a resource is selected in the packages * view the corresponding editor is activated. */ public class PackageExplorerPart extends ViewPart implements ISetSelectionTarget, IMenuListener, IPackagesViewPart, IPropertyChangeListener { public final static String VIEW_ID= JavaUI.ID_PACKAGES; // Persistance tags. static final String TAG_SELECTION= "selection"; //$NON-NLS-1$ static final String TAG_EXPANDED= "expanded"; //$NON-NLS-1$ static final String TAG_ELEMENT= "element"; //$NON-NLS-1$ static final String TAG_PATH= "path"; //$NON-NLS-1$ static final String TAG_VERTICAL_POSITION= "verticalPosition"; //$NON-NLS-1$ static final String TAG_HORIZONTAL_POSITION= "horizontalPosition"; //$NON-NLS-1$ static final String TAG_FILTERS = "filters"; //$NON-NLS-1$ static final String TAG_FILTER = "filter"; //$NON-NLS-1$ static final String TAG_SHOWLIBRARIES = "showLibraries"; //$NON-NLS-1$ static final String TAG_SHOWBINARIES = "showBinaries"; //$NON-NLS-1$ static final String TAG_WORKINGSET = "workingset"; //$NON-NLS-1$ private JavaElementPatternFilter fPatternFilter= new JavaElementPatternFilter(); private LibraryFilter fLibraryFilter= new LibraryFilter(); private BinaryProjectFilter fBinaryFilter= new BinaryProjectFilter(); private WorkingSetFilter fWorkingSetFilter= new WorkingSetFilter(); private ProblemTreeViewer fViewer; private PackagesFrameSource fFrameSource; private FrameList fFrameList; private ContextMenuGroup[] fStandardGroups; private Menu fContextMenu; private OpenResourceAction fOpenCUAction; private Action fOpenToAction; private Action fShowTypeHierarchyAction; private Action fShowNavigatorAction; private Action fPropertyDialogAction; private RefactoringAction fDeleteAction; private RefreshAction fRefreshAction; private BackAction fBackAction; private ForwardAction fForwardAction; private GoIntoAction fZoomInAction; private UpAction fUpAction; private GotoTypeAction fGotoTypeAction; private GotoPackageAction fGotoPackageAction; private AddBookmarkAction fAddBookmarkAction; private FilterSelectionAction fFilterAction; private ShowLibrariesAction fShowLibrariesAction; private ShowBinariesAction fShowBinariesAction; private FilterWorkingSetAction fFilterWorkingSetAction; private RemoveWorkingSetFilterAction fRemoveWorkingSetAction; private IMemento fMemento; private ISelectionChangedListener fSelectionListener; private IPartListener fPartListener= new IPartListener() { public void partActivated(IWorkbenchPart part) { if (part instanceof IEditorPart) editorActivated((IEditorPart) part); } public void partBroughtToTop(IWorkbenchPart part) { } public void partClosed(IWorkbenchPart part) { } public void partDeactivated(IWorkbenchPart part) { } public void partOpened(IWorkbenchPart part) { } }; private ITreeViewerListener fExpansionListener= new ITreeViewerListener() { public void treeCollapsed(TreeExpansionEvent event) { } public void treeExpanded(TreeExpansionEvent event) { Object element= event.getElement(); if (element instanceof ICompilationUnit || element instanceof IClassFile) expandMainType(element); } }; public PackageExplorerPart() { } /* (non-Javadoc) * Method declared on IViewPart. */ public void init(IViewSite site, IMemento memento) throws PartInitException { super.init(site, memento); fMemento= memento; } /** * Initializes the default preferences */ public static void initDefaults(IPreferenceStore store) { store.setDefault(TAG_SHOWLIBRARIES, true); store.setDefault(TAG_SHOWBINARIES, true); } /** * Returns the package explorer part of the active perspective. If * there isn't any package explorer part <code>null</code> is returned. */ public static PackageExplorerPart getFromActivePerspective() { IViewPart view= JavaPlugin.getActivePage().findView(VIEW_ID); if (view instanceof PackageExplorerPart) return (PackageExplorerPart)view; return null; } /** * Makes the package explorer part visible in the active perspective. If there * isn't a package explorer part registered <code>null</code> is returned. * Otherwise the opened view part is returned. */ public static PackageExplorerPart openInActivePerspective() { try { return (PackageExplorerPart)JavaPlugin.getActivePage().showView(VIEW_ID); } catch(PartInitException pe) { return null; } } public void dispose() { if (fViewer != null) JavaPlugin.getDefault().getProblemMarkerManager().removeListener(fViewer); if (fContextMenu != null && !fContextMenu.isDisposed()) fContextMenu.dispose(); getSite().getPage().removePartListener(fPartListener); JavaPlugin.getDefault().getPreferenceStore().removePropertyChangeListener(this); if (fViewer != null) fViewer.removeTreeListener(fExpansionListener); super.dispose(); } /** * Implementation of IWorkbenchPart.createPartControl(Composite) */ public void createPartControl(Composite parent) { fViewer= new ProblemTreeViewer(parent, SWT.MULTI | SWT.H_SCROLL | SWT.V_SCROLL); boolean showCUChildren= JavaBasePreferencePage.showCompilationUnitChildren(); fViewer.setContentProvider(new JavaElementContentProvider(showCUChildren, false)); JavaPlugin.getDefault().getProblemMarkerManager().addListener(fViewer); JavaPlugin.getDefault().getPreferenceStore().addPropertyChangeListener(this); JavaElementLabelProvider labelProvider= new JavaElementLabelProvider(getLabelProviderFlags()); labelProvider.setErrorTickManager(new MarkerErrorTickProvider()); fViewer.setLabelProvider(new DecoratingLabelProvider(labelProvider, null)); fViewer.setSorter(new JavaElementSorter()); fViewer.addFilter(new EmptyInnerPackageFilter()); fViewer.setUseHashlookup(true); fViewer.addFilter(fPatternFilter); fViewer.addFilter(fLibraryFilter); //fViewer.addFilter(fBinaryFilter); fViewer.addFilter(fWorkingSetFilter); if(fMemento != null) restoreFilters(); else initFilterFromPreferences(); // Set input after filter and sorter has been set. This avoids resorting // and refiltering. fViewer.setInput(findInputElement()); initDragAndDrop(); initFrameList(); initKeyListener(); updateTitle(); MenuManager menuMgr= new MenuManager("#PopupMenu"); //$NON-NLS-1$ menuMgr.setRemoveAllWhenShown(true); menuMgr.addMenuListener(this); fContextMenu= menuMgr.createContextMenu(fViewer.getTree()); fViewer.getTree().setMenu(fContextMenu); getSite().registerContextMenu(menuMgr, fViewer); makeActions(); // call before registering for selection changes fSelectionListener= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { handleSelectionChanged(event); } }; fViewer.addSelectionChangedListener(fSelectionListener); fViewer.addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent event) { handleDoubleClick(event); } }); fViewer.getControl().addKeyListener(new KeyAdapter() { public void keyPressed(KeyEvent e) { handleKeyPressed(e); } }); getSite().setSelectionProvider(fViewer); getSite().getPage().addPartListener(fPartListener); IStatusLineManager slManager= getViewSite().getActionBars().getStatusLineManager(); fViewer.addSelectionChangedListener(new StatusBarUpdater(slManager)); fViewer.addTreeListener(fExpansionListener); if (fMemento != null) restoreState(fMemento); fMemento= null; // Set help for the view // fixed for 1GETAYN: ITPJUI:WIN - F1 help does nothing WorkbenchHelp.setHelp(fViewer.getControl(), new ViewContextComputer(this, IJavaHelpContextIds.PACKAGE_VIEW)); fillActionBars(); } private void fillActionBars() { IActionBars actionBars= getViewSite().getActionBars(); IToolBarManager toolBar= actionBars.getToolBarManager(); toolBar.add(fBackAction); toolBar.add(fForwardAction); toolBar.add(fUpAction); actionBars.updateActionBars(); IMenuManager menu= actionBars.getMenuManager(); menu.add(fFilterAction); menu.add(fShowLibrariesAction); //menu.add(fShowBinariesAction); menu.add(fFilterWorkingSetAction); menu.add(fRemoveWorkingSetAction); menu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS)); menu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS+"-end"));//$NON-NLS-1$ } private Object findInputElement() { Object input= getSite().getPage().getInput(); if (input instanceof IWorkspace) { return JavaCore.create(((IWorkspace)input).getRoot()); } else if (input instanceof IContainer) { return JavaCore.create((IContainer)input); } //1GERPRT: ITPJUI:ALL - Packages View is empty when shown in Type Hierarchy Perspective // we can't handle the input // fall back to show the workspace return JavaCore.create(JavaPlugin.getWorkspace().getRoot()); } /** * Answer the property defined by key. */ public Object getAdapter(Class key) { if (key.equals(ISelectionProvider.class)) return fViewer; return super.getAdapter(key); } /** * Returns the tool tip text for the given element. */ String getToolTipText(Object element) { String result; if (!(element instanceof IResource)) { result= ((ILabelProvider) getViewer().getLabelProvider()).getText(element); } else { IPath path= ((IResource) element).getFullPath(); if (path.isRoot()) { result= PackagesMessages.getString("PackageExplorer.title"); //$NON-NLS-1$ } else { result= path.makeRelative().toString(); } } IWorkingSet ws= fWorkingSetFilter.getWorkingSet(); if (ws == null) return result; String wsstr= "Working Set: "+ws.getName(); if (result.length() == 0) return wsstr; return result + " - " + wsstr; } public String getTitleToolTip() { if (fViewer == null) return super.getTitleToolTip(); return getToolTipText(fViewer.getInput()); } /** * @see IWorkbenchPart#setFocus() */ public void setFocus() { fViewer.getTree().setFocus(); } /** * Sets the working set to be used for filtering this part */ public void setWorkingSet(IWorkingSet ws) { fWorkingSetFilter.setWorkingSet(ws); firePropertyChange(IWorkbenchPart.PROP_TITLE); fFilterWorkingSetAction.setChecked(ws != null); fRemoveWorkingSetAction.setEnabled(ws != null); } /** * Returns the shell to use for opening dialogs. * Used in this class, and in the actions. */ private Shell getShell() { return fViewer.getTree().getShell(); } /** * Returns the selection provider. */ private ISelectionProvider getSelectionProvider() { return fViewer; } /** * Returns the current selection. */ private ISelection getSelection() { return fViewer.getSelection(); } //---- Action handling ---------------------------------------------------------- /** * Called when the context menu is about to open. * Override to add your own context dependent menu contributions. */ public void menuAboutToShow(IMenuManager menu) { JavaPlugin.createStandardGroups(menu); IStructuredSelection selection= (IStructuredSelection) fViewer.getSelection(); boolean selectionHasElements= !selection.isEmpty(); Object element= selection.getFirstElement(); // updateActions(selection); if (selection.size() == 1 && fViewer.isExpandable(element)) menu.appendToGroup(IContextMenuConstants.GROUP_GOTO, fZoomInAction); addGotoMenu(menu); fOpenCUAction.update(); if (fOpenCUAction.isEnabled()) menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, fOpenCUAction); addOpenWithMenu(menu, selection); addOpenToMenu(menu, selection); addRefactoring(menu); if (selection.size() == 1) { menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, new JavaReplaceWithEditionAction(fViewer)); menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, new JavaAddElementFromHistory(null, fViewer)); } ContextMenuGroup.add(menu, fStandardGroups, fViewer); if (fAddBookmarkAction.canOperateOnSelection()) menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, fAddBookmarkAction); menu.appendToGroup(IContextMenuConstants.GROUP_BUILD, fRefreshAction); fRefreshAction.selectionChanged(selection); if (selectionHasElements) { // update the action to use the right selection since the refresh // action doesn't listen to selection changes. menu.appendToGroup(IContextMenuConstants.GROUP_PROPERTIES, fPropertyDialogAction); } } void addGotoMenu(IMenuManager menu) { MenuManager gotoMenu= new MenuManager(PackagesMessages.getString("PackageExplorer.gotoTitle")); //$NON-NLS-1$ menu.appendToGroup(IContextMenuConstants.GROUP_GOTO, gotoMenu); gotoMenu.add(fBackAction); gotoMenu.add(fForwardAction); gotoMenu.add(fUpAction); gotoMenu.add(fGotoTypeAction); gotoMenu.add(fGotoPackageAction); } private void makeActions() { ISelectionProvider provider= getSelectionProvider(); fOpenCUAction= new OpenResourceAction(provider); fPropertyDialogAction= new PropertyDialogAction(getShell(), provider); // fShowTypeHierarchyAction= new ShowTypeHierarchyAction(provider); fShowNavigatorAction= new ShowInNavigatorAction(provider); fAddBookmarkAction= new AddBookmarkAction(provider); fStandardGroups= new ContextMenuGroup[] { new NewGroup(), new BuildGroup(), new ReorgGroup(), new JavaSearchGroup() }; fDeleteAction= new DeleteAction(StructuredSelectionProvider.createFrom(provider)); fRefreshAction= new RefreshAction(getShell()); fFilterAction = new FilterSelectionAction(getShell(), this, PackagesMessages.getString("PackageExplorer.filters")); //$NON-NLS-1$ fShowLibrariesAction = new ShowLibrariesAction(this, PackagesMessages.getString("PackageExplorer.referencedLibs")); //$NON-NLS-1$ fShowBinariesAction = new ShowBinariesAction(getShell(), this, PackagesMessages.getString("PackageExplorer.binaryProjects")); //$NON-NLS-1$ fFilterWorkingSetAction = new FilterWorkingSetAction(getShell(), this, "Filter Working Set..."); //$NON-NLS-1$ fRemoveWorkingSetAction = new RemoveWorkingSetFilterAction(getShell(), this, "Remove Working Set Filter"); //$NON-NLS-1$ fBackAction= new BackAction(fFrameList); fForwardAction= new ForwardAction(fFrameList); fZoomInAction= new GoIntoAction(fFrameList); fUpAction= new UpAction(fFrameList); fGotoTypeAction= new GotoTypeAction(this); fGotoPackageAction= new GotoPackageAction(this); IActionBars actionService= getViewSite().getActionBars(); actionService.setGlobalActionHandler(IWorkbenchActionConstants.DELETE, fDeleteAction); } private void addRefactoring(IMenuManager menu){ MenuManager refactoring= new MenuManager(PackagesMessages.getString("PackageExplorer.refactoringTitle")); //$NON-NLS-1$ ContextMenuGroup.add(refactoring, new ContextMenuGroup[] { new RefactoringGroup() }, fViewer); if (!refactoring.isEmpty()) menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, refactoring); } private void addOpenToMenu(IMenuManager menu, IStructuredSelection selection) { if (selection.size() != 1) return; IAdaptable element= (IAdaptable) selection.getFirstElement(); IResource resource= (IResource)element.getAdapter(IResource.class); if ((resource instanceof IContainer)) { // Create a menu flyout. MenuManager submenu = new MenuManager(PackagesMessages.getString("PackageExplorer.openPerspective")); //$NON-NLS-1$ submenu.add(new OpenPerspectiveMenu(getSite().getWorkbenchWindow(), resource)); menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, submenu); } OpenTypeHierarchyUtil.addToMenu(getSite().getWorkbenchWindow(), menu, element); } private void addOpenWithMenu(IMenuManager menu, IStructuredSelection selection) { // If one file is selected get it. // Otherwise, do not show the "open with" menu. if (selection.size() != 1) return; IAdaptable element= (IAdaptable)selection.getFirstElement(); Object resource= element.getAdapter(IResource.class); if (!(resource instanceof IFile)) return; // Create a menu flyout. MenuManager submenu= new MenuManager(PackagesMessages.getString("PackageExplorer.openWith")); //$NON-NLS-1$ submenu.add(new OpenWithMenu(getSite().getPage(), (IFile) resource)); // Add the submenu. menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, submenu); } private boolean isSelectionOfType(ISelection s, Class clazz, boolean considerUnderlyingResource) { if (! (s instanceof IStructuredSelection) || s.isEmpty()) return false; IStructuredSelection selection= (IStructuredSelection)s; Iterator iter= selection.iterator(); while (iter.hasNext()) { Object o= iter.next(); if (clazz.isInstance(o)) return true; if (considerUnderlyingResource) { if (! (o instanceof IJavaElement)) return false; IJavaElement element= (IJavaElement)o; Object resource= element.getAdapter(IResource.class); if (! clazz.isInstance(resource)) return false; } } return true; } //---- Event handling ---------------------------------------------------------- private void initDragAndDrop() { int ops= DND.DROP_COPY | DND.DROP_MOVE; final LocalSelectionTransfer lt= LocalSelectionTransfer.getInstance(); Transfer[] transfers= new Transfer[] {lt, FileTransfer.getInstance()}; // Drop Adapter TransferDropTargetListener[] dropListeners= new TransferDropTargetListener[] { new SelectionTransferDropAdapter(fViewer), new FileTransferDropAdapter(fViewer) }; fViewer.addDropSupport(ops, transfers, new DelegatingDropAdapter(dropListeners)); // Drag Adapter Control control= fViewer.getControl(); TransferDragSourceListener[] dragListeners= new TransferDragSourceListener[] { new SelectionTransferDragAdapter(fViewer), new FileTransferDragAdapter(fViewer) }; DragSource source= new DragSource(control, ops); // Note, that the transfer agents are set by the delegating drag adapter itself. source.addDragListener(new DelegatingDragAdapter(dragListeners)); } /** * Handles key events in viewer. */ void handleKeyPressed(KeyEvent event) { if (event.character == SWT.DEL && event.stateMask == 0){ fDeleteAction.update(); if (fDeleteAction.isEnabled()) fDeleteAction.run(); } } /** * Handles double clicks in viewer. * Opens editor if file double-clicked. */ private void handleDoubleClick(DoubleClickEvent event) { IStructuredSelection s= (IStructuredSelection) event.getSelection(); Object element= s.getFirstElement(); // if the resource is already open then always open it if (EditorUtility.isOpenInEditor(element) == null) { if (fOpenCUAction.isEnabled()) { fOpenCUAction.run(); return; } } if (fViewer.isExpandable(element)) { if (JavaBasePreferencePage.doubleClockGoesInto()) { // don't zoom into compilation units and class files if (element instanceof IOpenable && !(element instanceof ICompilationUnit) && !(element instanceof IClassFile)) { fZoomInAction.run(); } } else { fViewer.setExpandedState(element, !fViewer.getExpandedState(element)); expandMainType(element); } } } /** * Handles selection changed in viewer. * Updates global actions. * Links to editor (if option enabled) */ private void handleSelectionChanged(SelectionChangedEvent event) { IStructuredSelection sel= (IStructuredSelection) event.getSelection(); //updateGlobalActions(sel); fZoomInAction.update(); linkToEditor(sel); } public void selectReveal(ISelection selection) { ISelection javaSelection= convertSelection(selection); fViewer.setSelection(javaSelection, true); } private ISelection convertSelection(ISelection s) { List converted= new ArrayList(); if (s instanceof StructuredSelection) { Object[] elements= ((StructuredSelection)s).toArray(); for (int i= 0; i < elements.length; i++) { Object e= elements[i]; if (e instanceof IJavaElement) converted.add(e); else if (e instanceof IResource) { IJavaElement element= JavaCore.create((IResource)e); if (element != null) converted.add(element); else converted.add(e); } } } return new StructuredSelection(converted.toArray()); } public void selectAndReveal(Object element) { selectReveal(new StructuredSelection(element)); } /** * Returns whether the preference to link selection to active editor is enabled. */ boolean isLinkingEnabled() { return JavaBasePreferencePage.linkPackageSelectionToEditor(); } /** * Links to editor (if option enabled) */ private void linkToEditor(IStructuredSelection selection) { //if (!isLinkingEnabled()) // return; Object obj= selection.getFirstElement(); Object element= null; if (selection.size() == 1) { if (obj instanceof IJavaElement) { IJavaElement cu= JavaModelUtil.findElementOfKind((IJavaElement)obj, IJavaElement.COMPILATION_UNIT); if (cu != null) element= getResourceFor(cu); if (element == null) element= JavaModelUtil.findElementOfKind((IJavaElement)obj, IJavaElement.CLASS_FILE); } else if (obj instanceof IFile) element= obj; if (element == null) return; IWorkbenchPage page= getSite().getPage(); IEditorPart editorArray[]= page.getEditors(); for (int i= 0; i < editorArray.length; ++i) { IEditorPart editor= editorArray[i]; Object input= getElementOfInput(editor.getEditorInput()); if (input != null && input.equals(element)) { page.bringToTop(editor); if (obj instanceof IJavaElement) EditorUtility.revealInEditor(editor, (IJavaElement) obj); return; } } } } private IResource getResourceFor(Object element) { if (element instanceof IJavaElement) { if (element instanceof IWorkingCopy) { IWorkingCopy wc= (IWorkingCopy)element; IJavaElement original= wc.getOriginalElement(); if (original != null) element= original; } try { element= ((IJavaElement)element).getUnderlyingResource(); } catch (JavaModelException e) { return null; } } if (!(element instanceof IResource) || ((IResource)element).isPhantom()) { return null; } return (IResource)element; } public void saveState(IMemento memento) { if (fViewer == null) { // part has not been created if (fMemento != null) //Keep the old state; memento.putMemento(fMemento); return; } saveExpansionState(memento); saveSelectionState(memento); saveScrollState(memento, fViewer.getTree()); savePatternFilterState(memento); saveFilterState(memento); saveWorkingSetState(memento); } protected void saveFilterState(IMemento memento) { boolean showLibraries= getLibraryFilter().getShowLibraries(); String show= "true"; //$NON-NLS-1$ if (!showLibraries) show= "false"; //$NON-NLS-1$ memento.putString(TAG_SHOWLIBRARIES, show); //save binary filter boolean showBinaries= getBinaryFilter().getShowBinaries(); String showBinString= "true"; //$NON-NLS-1$ if (!showBinaries) showBinString= "false"; //$NON-NLS-1$ memento.putString(TAG_SHOWBINARIES, showBinString); } protected void savePatternFilterState(IMemento memento) { String filters[] = getPatternFilter().getPatterns(); if(filters.length > 0) { IMemento filtersMem = memento.createChild(TAG_FILTERS); for (int i = 0; i < filters.length; i++){ IMemento child = filtersMem.createChild(TAG_FILTER); child.putString(TAG_ELEMENT,filters[i]); } } } protected void saveScrollState(IMemento memento, Tree tree) { ScrollBar bar= tree.getVerticalBar(); int position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_VERTICAL_POSITION, String.valueOf(position)); //save horizontal position bar= tree.getHorizontalBar(); position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_HORIZONTAL_POSITION, String.valueOf(position)); } protected void saveSelectionState(IMemento memento) { Object elements[]= ((IStructuredSelection) fViewer.getSelection()).toArray(); if (elements.length > 0) { IMemento selectionMem= memento.createChild(TAG_SELECTION); for (int i= 0; i < elements.length; i++) { IMemento elementMem= selectionMem.createChild(TAG_ELEMENT); // we can only persist JavaElements for now Object o= elements[i]; if (o instanceof IJavaElement) elementMem.putString(TAG_PATH, ((IJavaElement) elements[i]).getHandleIdentifier()); } } } protected void saveExpansionState(IMemento memento) { Object expandedElements[]= fViewer.getExpandedElements(); if (expandedElements.length > 0) { IMemento expandedMem= memento.createChild(TAG_EXPANDED); for (int i= 0; i < expandedElements.length; i++) { IMemento elementMem= expandedMem.createChild(TAG_ELEMENT); // we can only persist JavaElements for now Object o= expandedElements[i]; if (o instanceof IJavaElement) elementMem.putString(TAG_PATH, ((IJavaElement) expandedElements[i]).getHandleIdentifier()); } } } protected void saveWorkingSetState(IMemento memento) { IWorkingSet ws= getWorkingSetFilter().getWorkingSet(); if (ws != null) { memento.putString(TAG_WORKINGSET, ws.getName()); } } void restoreState(IMemento memento) { restoreExpansionState(memento); restoreSelectionState(memento); restoreScrollState(memento, fViewer.getTree()); } protected void restoreScrollState(IMemento memento, Tree tree) { ScrollBar bar= tree.getVerticalBar(); if (bar != null) { try { String posStr= memento.getString(TAG_VERTICAL_POSITION); int position; position= new Integer(posStr).intValue(); bar.setSelection(position); } catch (NumberFormatException e) { // ignore, don't set scrollposition } } bar= tree.getHorizontalBar(); if (bar != null) { try { String posStr= memento.getString(TAG_HORIZONTAL_POSITION); int position; position= new Integer(posStr).intValue(); bar.setSelection(position); } catch (NumberFormatException e) { // ignore don't set scroll position } } } protected void restoreSelectionState(IMemento memento) { IMemento childMem; childMem= memento.getChild(TAG_SELECTION); if (childMem != null) { ArrayList list= new ArrayList(); IMemento[] elementMem= childMem.getChildren(TAG_ELEMENT); for (int i= 0; i < elementMem.length; i++) { Object element= JavaCore.create(elementMem[i].getString(TAG_PATH)); list.add(element); } fViewer.setSelection(new StructuredSelection(list)); } } protected void restoreExpansionState(IMemento memento) { IMemento childMem= memento.getChild(TAG_EXPANDED); if (childMem != null) { ArrayList elements= new ArrayList(); IMemento[] elementMem= childMem.getChildren(TAG_ELEMENT); for (int i= 0; i < elementMem.length; i++) { Object element= JavaCore.create(elementMem[i].getString(TAG_PATH)); elements.add(element); } fViewer.setExpandedElements(elements.toArray()); } } /** * Create the KeyListener for doing the refresh on the viewer. */ private void initKeyListener() { fViewer.getControl().addKeyListener(new KeyAdapter() { public void keyReleased(KeyEvent event) { doKeyPressed(event.keyCode); } }); } private void doKeyPressed(int key) { if (key == SWT.F5) { fRefreshAction.selectionChanged( (IStructuredSelection) fViewer.getSelection()); if (fRefreshAction.isEnabled()) fRefreshAction.run(); } else if (key == SWT.F4) { OpenTypeHierarchyUtil.open(getSelection(), getSite().getWorkbenchWindow()); } else if (key == SWT.F3) { fOpenCUAction.update(); if (fOpenCUAction.isEnabled()) fOpenCUAction.run(); } } void initFrameList() { fFrameSource= new PackagesFrameSource(this); fFrameList= new FrameList(fFrameSource); fFrameSource.connectTo(fFrameList); } /** * An editor has been activated. Set the selection in this Packages Viewer * to be the editor's input, if linking is enabled. */ void editorActivated(IEditorPart editor) { if (!isLinkingEnabled()) return; Object input= getElementOfInput(editor.getEditorInput()); Object element= null; if (input instanceof IFile) element= JavaCore.create((IFile)input); if (element == null) // try a non Java resource element= input; if (element != null) { // if the current selection is a child of the new // selection then ignore it. IStructuredSelection oldSelection= (IStructuredSelection)getSelection(); if (oldSelection.size() == 1) { Object o= oldSelection.getFirstElement(); if (o instanceof IMember) { IMember m= (IMember)o; if (element.equals(m.getCompilationUnit())) return; if (element.equals(m.getClassFile())) return; } } ISelection newSelection= new StructuredSelection(element); if (!fViewer.getSelection().equals(newSelection)) { try { fViewer.removeSelectionChangedListener(fSelectionListener); fViewer.setSelection(newSelection); } finally { fViewer.addSelectionChangedListener(fSelectionListener); } } } } /** * A compilation unit or class was expanded, expand * the main type. */ void expandMainType(Object element) { try { IType type= null; if (element instanceof ICompilationUnit) { ICompilationUnit cu= (ICompilationUnit)element; IType[] types= cu.getTypes(); if (types.length > 0) type= types[0]; } else if (element instanceof IClassFile) { IClassFile cf= (IClassFile)element; type= cf.getType(); } if (type != null) { final IType type2= type; Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.getDisplay().asyncExec(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.expandToLevel(type2, 1); } }); } } } catch(JavaModelException e) { // no reveal } } /** * Returns the element contained in the EditorInput */ Object getElementOfInput(IEditorInput input) { if (input instanceof IClassFileEditorInput) return ((IClassFileEditorInput)input).getClassFile(); else if (input instanceof IFileEditorInput) return ((IFileEditorInput)input).getFile(); else if (input instanceof JarEntryEditorInput) return ((JarEntryEditorInput)input).getStorage(); return null; } /** * Returns the Viewer. */ TreeViewer getViewer() { return fViewer; } /** * Returns the pattern filter for this view. * @return the pattern filter */ JavaElementPatternFilter getPatternFilter() { return fPatternFilter; } /** * Returns the library filter for this view. * @return the library filter */ LibraryFilter getLibraryFilter() { return fLibraryFilter; } /** * Returns the working set filter for this view. * @return the working set filter */ WorkingSetFilter getWorkingSetFilter() { return fWorkingSetFilter; } /** * Returns the Binary filter for this view. * @return the binary filter */ BinaryProjectFilter getBinaryFilter() { return fBinaryFilter; } void restoreFilters() { IMemento filtersMem= fMemento.getChild(TAG_FILTERS); if(filtersMem != null) { IMemento children[]= filtersMem.getChildren(TAG_FILTER); String filters[]= new String[children.length]; for (int i = 0; i < children.length; i++) { filters[i]= children[i].getString(TAG_ELEMENT); } getPatternFilter().setPatterns(filters); } else { getPatternFilter().setPatterns(new String[0]); } //restore library String show= fMemento.getString(TAG_SHOWLIBRARIES); if (show != null) getLibraryFilter().setShowLibraries(show.equals("true")); //$NON-NLS-1$ else initLibraryFilterFromPreferences(); //restore binary fileter String showbin= fMemento.getString(TAG_SHOWBINARIES); if (showbin != null) getBinaryFilter().setShowBinaries(showbin.equals("true")); //$NON-NLS-1$ else initBinaryFilterFromPreferences(); //restore working set String workingSetName= fMemento.getString(TAG_WORKINGSET); if (workingSetName != null) { IWorkingSet ws= SearchUI.findWorkingSet(workingSetName); if (ws != null) { getWorkingSetFilter().setWorkingSet(ws); } } } void initFilterFromPreferences() { initBinaryFilterFromPreferences(); initLibraryFilterFromPreferences(); } void initLibraryFilterFromPreferences() { JavaPlugin plugin= JavaPlugin.getDefault(); boolean show= plugin.getPreferenceStore().getBoolean(TAG_SHOWLIBRARIES); getLibraryFilter().setShowLibraries(show); } void initBinaryFilterFromPreferences() { JavaPlugin plugin= JavaPlugin.getDefault(); boolean showbin= plugin.getPreferenceStore().getBoolean(TAG_SHOWBINARIES); getBinaryFilter().setShowBinaries(showbin); } /** * Updates the title text and title tool tip. * Called whenever the input of the viewer changes. */ void updateTitle() { Object input= getViewer().getInput(); String viewName= getConfigurationElement().getAttribute("name"); //$NON-NLS-1$ if (input == null || (input instanceof IJavaModel)) { setTitle(viewName); setTitleToolTip(""); //$NON-NLS-1$ } else { ILabelProvider labelProvider = (ILabelProvider) getViewer().getLabelProvider(); String inputText= labelProvider.getText(input); String title= PackagesMessages.getFormattedString("PackageExplorer.argTitle", new String[] { viewName, inputText }); //$NON-NLS-1$ setTitle(title); setTitleToolTip(getToolTipText(input)); } } /** * Sets the decorator for the package explorer. * * @param decorator a label decorator or <code>null</code> for no decorations. */ public void setLabelDecorator(ILabelDecorator decorator) { JavaElementLabelProvider javaProvider= new JavaElementLabelProvider(getLabelProviderFlags()); javaProvider.setErrorTickManager(new MarkerErrorTickProvider()); if (decorator == null) { fViewer.setLabelProvider(javaProvider); } else { fViewer.setLabelProvider(new DecoratingLabelProvider(javaProvider, decorator)); } } /** * Gets the standard label flags */ private int getLabelProviderFlags() { return JavaElementLabelProvider.SHOW_BASICS | JavaElementLabelProvider.SHOW_OVERLAY_ICONS | JavaElementLabelProvider.SHOW_SMALL_ICONS | JavaElementLabelProvider.SHOW_VARIABLE | JavaElementLabelProvider.SHOW_PARAMETERS; } /* * @see IPropertyChangeListener#propertyChange(PropertyChangeEvent) */ public void propertyChange(PropertyChangeEvent event) { if (event.getProperty() != IPreferencesConstants.SHOW_CU_CHILDREN) return; if (fViewer != null) { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); boolean b= store.getBoolean(IPreferencesConstants.SHOW_CU_CHILDREN); ((JavaElementContentProvider)fViewer.getContentProvider()).setProvideMembers(b); fViewer.refresh(); } } }
4,089
Bug 4089 Editor tooltip for class files should show full path (1GI74EF)
When you hover over the editor tab for a .class file, it just shows you the simple file name. It should show the full path, as for other editors. NOTES:
verified fixed
c33aca1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-11T16:40:02Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/InternalClassFileEditorInput.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IMemento; import org.eclipse.ui.IPersistableElement; /** * Class file considered as editor input. */ public class InternalClassFileEditorInput implements IClassFileEditorInput, IPersistableElement { private IClassFile fClassFile; public InternalClassFileEditorInput(IClassFile classFile) { fClassFile= classFile; } /* * @see Object#equals(Object) */ public boolean equals(Object obj) { if (this == obj) return true; if (!(obj instanceof InternalClassFileEditorInput)) return false; InternalClassFileEditorInput other= (InternalClassFileEditorInput) obj; return fClassFile.equals(other.fClassFile); } /* * @see Object#hashCode */ public int hashCode() { return fClassFile.hashCode(); } /* * @see IClassFileEditorInput#getClassFile() */ public IClassFile getClassFile() { return fClassFile; } /* * @see IEditorInput#getPersistable() */ public IPersistableElement getPersistable() { return this; } /* * @see IEditorInput#getName() */ public String getName() { return fClassFile.getElementName(); } /* * @see IEditorInput#getFullPath() */ public String getFullPath() { return fClassFile.getElementName(); } /* * @see IEditorInput#getContentType() */ public String getContentType() { return "class"; //$NON-NLS-1$ } /* * @see IEditorInput#getToolTipText() */ public String getToolTipText() { return fClassFile.getElementName(); } /* * @see IEditorInput#getImageDescriptor() */ public ImageDescriptor getImageDescriptor() { try { if (fClassFile.isClass()) return JavaPluginImages.DESC_OBJS_CFILECLASS; return JavaPluginImages.DESC_OBJS_CFILEINT; } catch (JavaModelException e) { // fall through } return JavaPluginImages.DESC_OBJS_CFILE; } /* * @see IEditorInput#exists() */ public boolean exists() { return fClassFile.exists(); } /* * @see IAdaptable#getAdapter(Class) */ public Object getAdapter(Class adapter) { if (adapter == IClassFile.class) return fClassFile; return fClassFile.getAdapter(adapter); } /* * @see IPersistableElement#saveState(IMemento) */ public void saveState(IMemento memento) { ClassFileEditorInputFactory.saveState(memento, this); } /* * @see IPersistableElement#getFactoryId() */ public String getFactoryId() { return ClassFileEditorInputFactory.ID; } }
5,699
Bug 5699 Add ResourceTransfer to packages view
The packages view should add the ResoruceTransfer as a drag source to its list of transfers
resolved fixed
eb077ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T15:13:53Z"
"2001-11-09T10:00:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dnd/JdtTreeViewerDropAdapter.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dnd; import org.eclipse.swt.dnd.DropTargetEvent; import org.eclipse.swt.widgets.TreeItem; import org.eclipse.jface.viewers.AbstractTreeViewer; public class JdtTreeViewerDropAdapter extends JdtViewerDropAdapter { /** * The time the mouse first started hovering over the current target */ protected long hoverStart= 0; /** * The amount of time to hover over a tree item before expanding it */ private static final long HOVER_THRESHOLD= 1500; public JdtTreeViewerDropAdapter(AbstractTreeViewer viewer, int style) { super(viewer, style); } public void dragOver(DropTargetEvent event) { //this method implements the UI behaviour that when the user hovers //over an unexpanded tree item long enough, it will auto-expand. Object oldTarget= fTarget; super.dragOver(event); if (oldTarget != fTarget) { hoverStart= System.currentTimeMillis(); } else { //if we've been hovering over this item awhile, expand it. if (hoverStart > 0 && (System.currentTimeMillis() - hoverStart) > HOVER_THRESHOLD) { expandSelection((TreeItem) event.item); hoverStart= 0; } } } private void expandSelection(TreeItem item) { if (item == null) return; Object element= item.getData(); if (element == null) return; ((AbstractTreeViewer)getViewer()).expandToLevel(element, 1); } }
5,699
Bug 5699 Add ResourceTransfer to packages view
The packages view should add the ResoruceTransfer as a drag source to its list of transfers
resolved fixed
eb077ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T15:13:53Z"
"2001-11-09T10:00:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dnd/JdtViewerDropAdapter.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dnd; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DropTargetEvent; import org.eclipse.swt.dnd.DropTargetListener; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Item; import org.eclipse.swt.widgets.TableItem; import org.eclipse.swt.widgets.TreeItem; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.StructuredViewer; /** * An drag and drop adapter to be used together with structured viewers. * The adpater delegates the <code>dragEnter</code>, <code>dragOperationChanged * </code>, <code>dragOver</code> and <code>dropAccept</code> method to the < * code>validateDrop</code> method. Furthermore it adds location feedback. */ public class JdtViewerDropAdapter implements DropTargetListener { /** * Constant describing the position of the cursor relative * to the target object. This means the mouse is positioned * slightly before the target. */ protected static final int LOCATION_BEFORE= 1; /** * Constant describing the position of the cursor relative * to the target object. This means the mouse is positioned * slightly after the target. */ protected static final int LOCATION_AFTER= 2; /** * Constant describing the position of the cursor relative * to the target object. This means the mouse is positioned * directly on the target. */ protected static final int LOCATION_ON= 3; /** * Constant describing the position of the cursor relative * to the target object. This means the mouse is not positioned * over or near any valid target. */ protected static final int LOCATION_NONE= 4; /** * The threshold used to determine if the mouse is before or after * a item. */ private static final int LOCATION_EPSILON= 5; /** * The threshold used to determine if the mouse is near the border * and scrollinh should occur. */ private static final int SCROLL_EPSILON= 20; /** * Style to enable location feedback. */ public static final int INSERTION_FEEDBACK= 1 << 1; private int fStyle; private StructuredViewer fViewer; private int fRequestedOperation; private int fLastOperation; private long fLastScroll; protected int fLocation; protected Object fTarget; public JdtViewerDropAdapter(StructuredViewer viewer, int style) { fViewer= viewer; Assert.isNotNull(fViewer); fStyle= style; fLastOperation= -1; } /** * Returns the viewer this adapter is working on. */ protected StructuredViewer getViewer() { return fViewer; } //---- Hooks to override ----------------------------------------------------- /** * The actual drop has occurred. Calls <code>drop(Object target, DropTargetEvent event) * </code>. * @see DropTargetListener.drop(DropTargetEvent) */ public void drop(DropTargetEvent event) { drop(fTarget, event); } /** * The actual drop has occurred. * @param target the drop target in form of a domain element. * @param event the drop traget event */ public void drop(Object target, DropTargetEvent event) { } /** * Validates if the drop is valid. The method calls <code>validateDrop * (Object target, DropTargetEvent event). Implementors can alter the * <code>currentDataType</code> field and the <code>detail</code> field * to give feedback about drop acceptence. */ public void validateDrop(DropTargetEvent event) { validateDrop(fTarget, event, fRequestedOperation); } /** * Validates if the drop on the current target is valid. The method * can alter the <code>currentDataType</code> field and the <code> * detail</code> field to give feedback about drop acceptence. * @param target the drop target in form of a domain element. * @param event the drop traget event * @param operation the operation requested by the user. */ public void validateDrop(Object target, DropTargetEvent event, int operation) { } public void dragEnter(DropTargetEvent event) { fLastScroll= System.currentTimeMillis(); dragOperationChanged(event); } public void dragLeave(DropTargetEvent event) { fTarget= null; fLocation= LOCATION_NONE; fLastScroll= 0; } public void dragOperationChanged(DropTargetEvent event) { fRequestedOperation= event.detail; fTarget= computeTarget(event); fLocation= computeLocation(event); validateDrop(event); fLastOperation= event.detail; computeFeedback(event); } public void dragOver(DropTargetEvent event) { Object oldTarget= fTarget; fTarget= scrollIfNeeded(event.x, event.y); // didn't scroll. So use normal target. if (fTarget == null) fTarget= computeTarget(event); //set the location feedback int oldLocation= fLocation; fLocation= computeLocation(event); if (oldLocation != fLocation || oldTarget != fTarget || fLastOperation != event.detail) { validateDrop(event); fLastOperation= event.detail; } else { event.detail= fLastOperation; } computeFeedback(event); } public void dropAccept(DropTargetEvent event) { fTarget= computeTarget(event); validateDrop(event); fLastOperation= event.detail; } /** * Returns the data hold by <code>event.item</code>. Inside a viewer * this corresponds to the items data model element. */ protected Object computeTarget(DropTargetEvent event) { return event.item == null ? null : event.item.getData(); } /** * Returns the position of the given coordinates relative to the given target. * The position is determined to be before, after, or on the item, based on * some threshold value. The return value is one of the LOCATION_* constants * defined in this class. */ final protected int computeLocation(DropTargetEvent event) { if (!(event.item instanceof Item)) { return LOCATION_NONE; } Item item= (Item) event.item; Point coordinates= new Point(event.x, event.y); coordinates= fViewer.getControl().toControl(coordinates); Rectangle bounds= getBounds(item); if (bounds == null) { return LOCATION_NONE; } if ((coordinates.y - bounds.y) < LOCATION_EPSILON) { return LOCATION_BEFORE; } if ((bounds.y + bounds.height - coordinates.y) < LOCATION_EPSILON) { return LOCATION_AFTER; } return LOCATION_ON; } /** * Returns the bounds of the given item, or <code>null</code> if it is not a * valid type of item. */ private Rectangle getBounds(Item item) { if (item instanceof TreeItem) { return ((TreeItem) item).getBounds(); } if (item instanceof TableItem) { return ((TableItem) item).getBounds(0); } return null; } /** * Scrolls the widget if the given coordinates are within epsilon * of the widget borders. If scolling occurs, the viewer selection * is set to be the newly revealed widget. Returns true if scrolling * actually, occurred, and false otherwise. */ protected Object scrollIfNeeded(int x, int y) { long time= System.currentTimeMillis(); if (time - fLastScroll < 500) return null; fLastScroll= time; Control control= fViewer.getControl(); Point point= control.toControl(new Point(x, y)); Rectangle bounds= control.getBounds(); Item item= null; if (point.y < SCROLL_EPSILON) { item= fViewer.scrollUp(x, y); } else { if ((bounds.height - bounds.y - point.y) < SCROLL_EPSILON) { item= fViewer.scrollDown(x, y); } } if (item != null) return item.getData(); return null; } /** * Sets the drag under feedback corresponding to the value of <code>fLocation</code> * and the <code>INSERTION_FEEDBACK</code> style bit. */ protected void computeFeedback(DropTargetEvent event) { int old= event.feedback; boolean insertionFeedback= (fStyle & INSERTION_FEEDBACK) != 0; if (!insertionFeedback && fLocation != LOCATION_NONE) { event.feedback= DND.FEEDBACK_SELECT; } else { if (fLocation == LOCATION_BEFORE) { event.feedback= DND.FEEDBACK_INSERT_BEFORE; } else if (fLocation == LOCATION_AFTER) { event.feedback= DND.FEEDBACK_INSERT_AFTER; } } } /** * Sets the dop operation to </code>DROP_NODE<code>. */ protected void clearDropOperation(DropTargetEvent event) { event.detail= DND.DROP_NONE; } /** * Returns the requested drop operation. */ protected int getRequestedOperation() { return fRequestedOperation; } }
5,699
Bug 5699 Add ResourceTransfer to packages view
The packages view should add the ResoruceTransfer as a drag source to its list of transfers
resolved fixed
eb077ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T15:13:53Z"
"2001-11-09T10:00:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dnd/ResourceTransferDragAdapter.java
5,699
Bug 5699 Add ResourceTransfer to packages view
The packages view should add the ResoruceTransfer as a drag source to its list of transfers
resolved fixed
eb077ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T15:13:53Z"
"2001-11-09T10:00:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/FileTransferDropAdapter.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.packageview; import java.io.File; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.List; import java.util.ResourceBundle; import org.eclipse.swt.SWT; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DropTargetEvent; import org.eclipse.swt.dnd.FileTransfer; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.Dialog; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.viewers.AbstractTreeViewer; import org.eclipse.core.resources.IContainer; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Path; import org.eclipse.ui.dialogs.IOverwriteQuery; import org.eclipse.ui.wizards.datatransfer.FileSystemStructureProvider; import org.eclipse.ui.wizards.datatransfer.ImportOperation; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dnd.JdtTreeViewerDropAdapter; import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.SWTUtil; /** * Adapter to handle file drop from other applications. */ class FileTransferDropAdapter extends JdtTreeViewerDropAdapter implements IOverwriteQuery, TransferDropTargetListener { FileTransferDropAdapter(AbstractTreeViewer viewer) { super(viewer, SWT.NONE); } //---- IOverwriteQuery ------------------------------------------------------------ public String queryOverwrite(String file) { String[] returnCodes= {YES, NO, ALL, CANCEL}; int returnVal= openDialog(getViewer().getControl(), file); return returnVal < 0 ? CANCEL : returnCodes[returnVal]; } private int openDialog(final Control control, final String file) { final int[] result= { Dialog.CANCEL }; control.getDisplay().syncExec(new Runnable() { public void run() { String title= PackagesMessages.getString("DropAdapter.question"); //$NON-NLS-1$ String msg= PackagesMessages.getFormattedString("DropAdapter.alreadyExists", file); //$NON-NLS-1$ String[] options= {IDialogConstants.YES_LABEL, IDialogConstants.NO_LABEL, IDialogConstants.YES_TO_ALL_LABEL, IDialogConstants.CANCEL_LABEL}; MessageDialog dialog= new MessageDialog(control.getShell(), title, null, msg, MessageDialog.QUESTION, options, 0); result[0]= dialog.open(); } }); return result[0]; } //---- TransferDropTargetListener interface --------------------------------------- public Transfer getTransfer() { return FileTransfer.getInstance(); } //---- Actual DND ----------------------------------------------------------------- public void validateDrop(Object target, DropTargetEvent event, int operation) { event.detail= DND.DROP_NONE; boolean isPackageFragment= target instanceof IPackageFragment; boolean isJavaProject= target instanceof IJavaProject; boolean isPackageFragmentRoot= target instanceof IPackageFragmentRoot; if (!(isPackageFragment || isJavaProject || isPackageFragmentRoot)) return; IJavaElement element= (IJavaElement)target; if (!element.isReadOnly()) event.detail= DND.DROP_COPY; return; } public void drop(Object javaTarget, DropTargetEvent event) { int operation= event.detail; event.detail= DND.DROP_NONE; Object data= event.data; if (data == null || operation != DND.DROP_COPY) return; IContainer target= null; try { target= (IContainer)((IJavaElement)javaTarget).getCorrespondingResource(); } catch (JavaModelException e) { return; } List files= checkFiles(SWTUtil.getShell(event.widget),(String[])data, target.getLocation()); if (files.size() > 0) { Shell shell= JavaPlugin.getActiveWorkbenchShell(); ImportOperation op= new ImportOperation(target.getFullPath(), FileSystemStructureProvider.INSTANCE, this, files); op.setCreateContainerStructure(false); ProgressMonitorDialog dialog= new ProgressMonitorDialog(shell); try { dialog.run(true, true, op); } catch (InvocationTargetException e) { String title= PackagesMessages.getString("DropAdapter.errorTitle"); //$NON-NLS-1$ String message= PackagesMessages.getString("DropAdapter.errorMessage"); //$NON-NLS-1$ ExceptionHandler.handle(e, title, message); return; } catch (InterruptedException e) { return; } // Special case since ImportOperation doesn't throw a CoreException on // failure. IStatus status= op.getStatus(); if (! status.isOK()) { String title= PackagesMessages.getString("DropAdapter.errorTitle"); //$NON-NLS-1$ String message= PackagesMessages.getString("DropAdapter.errorMessage"); //$NON-NLS-1$ ErrorDialog.openError(shell, title, message, status, IStatus.ERROR | IStatus.WARNING); return; } // The files we have really handled. event.data= files.toArray(new String[files.size()]); // Import always performs a copy. event.detail= DND.DROP_COPY; return; } else { event.data= null; return; } } private List checkFiles(Shell shell, String[] files, IPath target) { List result= new ArrayList(10); int lengthCompare= target.segmentCount() + 1; for (int i= 0; i < files.length; i++) { String file= files[i]; IPath path= new Path(file); String error= null; if (path.equals(target)) { error= PackagesMessages.getFormattedString("DropAdapter.errorSame", target.lastSegment()); //$NON-NLS-1$ } else if (path.isPrefixOf(target)) { error= PackagesMessages.getFormattedString("DropAdapter.errorSubfolder", path.lastSegment()); //$NON-NLS-1$ } if (error != null) { MessageDialog.openError(shell, PackagesMessages.getString("DropAdapter.errorTitle"), error); //$NON-NLS-1$ return new ArrayList(0); } // A copy onto itself ? if (target.isPrefixOf(path) && lengthCompare == path.segmentCount()) continue; result.add(new File(file)); } return result; } }
5,699
Bug 5699 Add ResourceTransfer to packages view
The packages view should add the ResoruceTransfer as a drag source to its list of transfers
resolved fixed
eb077ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T15:13:53Z"
"2001-11-09T10:00:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.packageview; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IPath; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IOpenable; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.compare.JavaAddElementFromHistory; import org.eclipse.jdt.internal.ui.compare.JavaReplaceWithEditionAction; import org.eclipse.jdt.internal.ui.dnd.DelegatingDragAdapter; import org.eclipse.jdt.internal.ui.dnd.DelegatingDropAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.dnd.TransferDragSourceListener; import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener; import org.eclipse.jdt.internal.ui.javaeditor.IClassFileEditorInput; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.javaeditor.JarEntryEditorInput; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.IPreferencesConstants; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringAction; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringGroup; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; import org.eclipse.jdt.internal.ui.reorg.DeleteAction; import org.eclipse.jdt.internal.ui.reorg.ReorgGroup; import org.eclipse.jdt.internal.ui.search.JavaSearchGroup; import org.eclipse.jdt.internal.ui.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.util.OpenTypeHierarchyUtil; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementSorter; import org.eclipse.jdt.internal.ui.viewsupport.MarkerErrorTickProvider; import org.eclipse.jdt.internal.ui.viewsupport.ProblemTreeViewer; import org.eclipse.jdt.internal.ui.viewsupport.StatusBarUpdater; import org.eclipse.jdt.internal.ui.wizards.NewGroup; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.IPackagesViewPart; import org.eclipse.jdt.ui.JavaElementContentProvider; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.DecoratingLabelProvider; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ILabelDecorator; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.ITreeViewerListener; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.TreeExpansionEvent; import org.eclipse.jface.viewers.TreeViewer; import org.eclipse.search.ui.IWorkingSet; import org.eclipse.search.ui.SearchUI; import org.eclipse.swt.SWT; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DragSource; import org.eclipse.swt.dnd.FileTransfer; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.ScrollBar; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Tree; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IMemento; import org.eclipse.ui.IPartListener; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IViewSite; import org.eclipse.ui.IWorkbenchActionConstants; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.PartInitException; import org.eclipse.ui.actions.OpenPerspectiveMenu; import org.eclipse.ui.actions.OpenWithMenu; import org.eclipse.ui.actions.RefreshAction; import org.eclipse.ui.dialogs.PropertyDialogAction; import org.eclipse.ui.help.ViewContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.ISetSelectionTarget; import org.eclipse.ui.part.ViewPart; import org.eclipse.ui.views.internal.framelist.BackAction; import org.eclipse.ui.views.internal.framelist.ForwardAction; import org.eclipse.ui.views.internal.framelist.FrameList; import org.eclipse.ui.views.internal.framelist.GoIntoAction; import org.eclipse.ui.views.internal.framelist.UpAction; /** * The ViewPart for the ProjectExplorer. It listens to part activation events. * When selection linking with the editor is enabled the view selection tracks * the active editor page. Similarly when a resource is selected in the packages * view the corresponding editor is activated. */ public class PackageExplorerPart extends ViewPart implements ISetSelectionTarget, IMenuListener, IPackagesViewPart, IPropertyChangeListener { public final static String VIEW_ID= JavaUI.ID_PACKAGES; // Persistance tags. static final String TAG_SELECTION= "selection"; //$NON-NLS-1$ static final String TAG_EXPANDED= "expanded"; //$NON-NLS-1$ static final String TAG_ELEMENT= "element"; //$NON-NLS-1$ static final String TAG_PATH= "path"; //$NON-NLS-1$ static final String TAG_VERTICAL_POSITION= "verticalPosition"; //$NON-NLS-1$ static final String TAG_HORIZONTAL_POSITION= "horizontalPosition"; //$NON-NLS-1$ static final String TAG_FILTERS = "filters"; //$NON-NLS-1$ static final String TAG_FILTER = "filter"; //$NON-NLS-1$ static final String TAG_SHOWLIBRARIES = "showLibraries"; //$NON-NLS-1$ static final String TAG_SHOWBINARIES = "showBinaries"; //$NON-NLS-1$ static final String TAG_WORKINGSET = "workingset"; //$NON-NLS-1$ private JavaElementPatternFilter fPatternFilter= new JavaElementPatternFilter(); private LibraryFilter fLibraryFilter= new LibraryFilter(); private BinaryProjectFilter fBinaryFilter= new BinaryProjectFilter(); private WorkingSetFilter fWorkingSetFilter= new WorkingSetFilter(); private ProblemTreeViewer fViewer; private PackagesFrameSource fFrameSource; private FrameList fFrameList; private ContextMenuGroup[] fStandardGroups; private Menu fContextMenu; private OpenResourceAction fOpenCUAction; private Action fOpenToAction; private Action fShowTypeHierarchyAction; private Action fShowNavigatorAction; private Action fPropertyDialogAction; private RefactoringAction fDeleteAction; private RefreshAction fRefreshAction; private BackAction fBackAction; private ForwardAction fForwardAction; private GoIntoAction fZoomInAction; private UpAction fUpAction; private GotoTypeAction fGotoTypeAction; private GotoPackageAction fGotoPackageAction; private AddBookmarkAction fAddBookmarkAction; private FilterSelectionAction fFilterAction; private ShowLibrariesAction fShowLibrariesAction; private ShowBinariesAction fShowBinariesAction; private FilterWorkingSetAction fFilterWorkingSetAction; private RemoveWorkingSetFilterAction fRemoveWorkingSetAction; private IMemento fMemento; private ISelectionChangedListener fSelectionListener; private IPartListener fPartListener= new IPartListener() { public void partActivated(IWorkbenchPart part) { if (part instanceof IEditorPart) editorActivated((IEditorPart) part); } public void partBroughtToTop(IWorkbenchPart part) { } public void partClosed(IWorkbenchPart part) { } public void partDeactivated(IWorkbenchPart part) { } public void partOpened(IWorkbenchPart part) { } }; private ITreeViewerListener fExpansionListener= new ITreeViewerListener() { public void treeCollapsed(TreeExpansionEvent event) { } public void treeExpanded(TreeExpansionEvent event) { Object element= event.getElement(); if (element instanceof ICompilationUnit || element instanceof IClassFile) expandMainType(element); } }; public PackageExplorerPart() { } /* (non-Javadoc) * Method declared on IViewPart. */ public void init(IViewSite site, IMemento memento) throws PartInitException { super.init(site, memento); fMemento= memento; } /** * Initializes the default preferences */ public static void initDefaults(IPreferenceStore store) { store.setDefault(TAG_SHOWLIBRARIES, true); store.setDefault(TAG_SHOWBINARIES, true); } /** * Returns the package explorer part of the active perspective. If * there isn't any package explorer part <code>null</code> is returned. */ public static PackageExplorerPart getFromActivePerspective() { IViewPart view= JavaPlugin.getActivePage().findView(VIEW_ID); if (view instanceof PackageExplorerPart) return (PackageExplorerPart)view; return null; } /** * Makes the package explorer part visible in the active perspective. If there * isn't a package explorer part registered <code>null</code> is returned. * Otherwise the opened view part is returned. */ public static PackageExplorerPart openInActivePerspective() { try { return (PackageExplorerPart)JavaPlugin.getActivePage().showView(VIEW_ID); } catch(PartInitException pe) { return null; } } public void dispose() { if (fViewer != null) JavaPlugin.getDefault().getProblemMarkerManager().removeListener(fViewer); if (fContextMenu != null && !fContextMenu.isDisposed()) fContextMenu.dispose(); getSite().getPage().removePartListener(fPartListener); JavaPlugin.getDefault().getPreferenceStore().removePropertyChangeListener(this); if (fViewer != null) fViewer.removeTreeListener(fExpansionListener); super.dispose(); } /** * Implementation of IWorkbenchPart.createPartControl(Composite) */ public void createPartControl(Composite parent) { fViewer= new ProblemTreeViewer(parent, SWT.MULTI | SWT.H_SCROLL | SWT.V_SCROLL); boolean showCUChildren= JavaBasePreferencePage.showCompilationUnitChildren(); fViewer.setContentProvider(new JavaElementContentProvider(showCUChildren, false)); JavaPlugin.getDefault().getProblemMarkerManager().addListener(fViewer); JavaPlugin.getDefault().getPreferenceStore().addPropertyChangeListener(this); JavaElementLabelProvider labelProvider= new JavaElementLabelProvider(getLabelProviderFlags()); labelProvider.setErrorTickManager(new MarkerErrorTickProvider()); fViewer.setLabelProvider(new DecoratingLabelProvider(labelProvider, null)); fViewer.setSorter(new JavaElementSorter()); fViewer.addFilter(new EmptyInnerPackageFilter()); fViewer.setUseHashlookup(true); fViewer.addFilter(fPatternFilter); fViewer.addFilter(fLibraryFilter); //fViewer.addFilter(fBinaryFilter); fViewer.addFilter(fWorkingSetFilter); if(fMemento != null) restoreFilters(); else initFilterFromPreferences(); // Set input after filter and sorter has been set. This avoids resorting // and refiltering. fViewer.setInput(findInputElement()); initDragAndDrop(); initFrameList(); initKeyListener(); updateTitle(); MenuManager menuMgr= new MenuManager("#PopupMenu"); //$NON-NLS-1$ menuMgr.setRemoveAllWhenShown(true); menuMgr.addMenuListener(this); fContextMenu= menuMgr.createContextMenu(fViewer.getTree()); fViewer.getTree().setMenu(fContextMenu); getSite().registerContextMenu(menuMgr, fViewer); makeActions(); // call before registering for selection changes fSelectionListener= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { handleSelectionChanged(event); } }; fViewer.addSelectionChangedListener(fSelectionListener); fViewer.addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent event) { handleDoubleClick(event); } }); fViewer.getControl().addKeyListener(new KeyAdapter() { public void keyPressed(KeyEvent e) { handleKeyPressed(e); } }); getSite().setSelectionProvider(fViewer); getSite().getPage().addPartListener(fPartListener); IStatusLineManager slManager= getViewSite().getActionBars().getStatusLineManager(); fViewer.addSelectionChangedListener(new StatusBarUpdater(slManager)); fViewer.addTreeListener(fExpansionListener); if (fMemento != null) restoreState(fMemento); fMemento= null; // Set help for the view // fixed for 1GETAYN: ITPJUI:WIN - F1 help does nothing WorkbenchHelp.setHelp(fViewer.getControl(), new ViewContextComputer(this, IJavaHelpContextIds.PACKAGE_VIEW)); fillActionBars(); } private void fillActionBars() { IActionBars actionBars= getViewSite().getActionBars(); IToolBarManager toolBar= actionBars.getToolBarManager(); toolBar.add(fBackAction); toolBar.add(fForwardAction); toolBar.add(fUpAction); actionBars.updateActionBars(); IMenuManager menu= actionBars.getMenuManager(); menu.add(fFilterAction); menu.add(fShowLibrariesAction); //menu.add(fShowBinariesAction); menu.add(fFilterWorkingSetAction); menu.add(fRemoveWorkingSetAction); menu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS)); menu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS+"-end"));//$NON-NLS-1$ } private Object findInputElement() { Object input= getSite().getPage().getInput(); if (input instanceof IWorkspace) { return JavaCore.create(((IWorkspace)input).getRoot()); } else if (input instanceof IContainer) { return JavaCore.create((IContainer)input); } //1GERPRT: ITPJUI:ALL - Packages View is empty when shown in Type Hierarchy Perspective // we can't handle the input // fall back to show the workspace return JavaCore.create(JavaPlugin.getWorkspace().getRoot()); } /** * Answer the property defined by key. */ public Object getAdapter(Class key) { if (key.equals(ISelectionProvider.class)) return fViewer; return super.getAdapter(key); } /** * Returns the tool tip text for the given element. */ String getToolTipText(Object element) { String result; if (!(element instanceof IResource)) { result= ((ILabelProvider) getViewer().getLabelProvider()).getText(element); } else { IPath path= ((IResource) element).getFullPath(); if (path.isRoot()) { result= PackagesMessages.getString("PackageExplorer.title"); //$NON-NLS-1$ } else { result= path.makeRelative().toString(); } } IWorkingSet ws= fWorkingSetFilter.getWorkingSet(); if (ws == null) return result; String wsstr= "Working Set: "+ws.getName(); if (result.length() == 0) return wsstr; return result + " - " + wsstr; } public String getTitleToolTip() { if (fViewer == null) return super.getTitleToolTip(); return getToolTipText(fViewer.getInput()); } /** * @see IWorkbenchPart#setFocus() */ public void setFocus() { fViewer.getTree().setFocus(); } /** * Sets the working set to be used for filtering this part */ public void setWorkingSet(IWorkingSet ws) { fWorkingSetFilter.setWorkingSet(ws); firePropertyChange(IWorkbenchPart.PROP_TITLE); fFilterWorkingSetAction.setChecked(ws != null); fRemoveWorkingSetAction.setEnabled(ws != null); } /** * Returns the shell to use for opening dialogs. * Used in this class, and in the actions. */ private Shell getShell() { return fViewer.getTree().getShell(); } /** * Returns the selection provider. */ private ISelectionProvider getSelectionProvider() { return fViewer; } /** * Returns the current selection. */ private ISelection getSelection() { return fViewer.getSelection(); } //---- Action handling ---------------------------------------------------------- /** * Called when the context menu is about to open. * Override to add your own context dependent menu contributions. */ public void menuAboutToShow(IMenuManager menu) { JavaPlugin.createStandardGroups(menu); IStructuredSelection selection= (IStructuredSelection) fViewer.getSelection(); boolean selectionHasElements= !selection.isEmpty(); Object element= selection.getFirstElement(); // updateActions(selection); if (selection.size() == 1 && fViewer.isExpandable(element)) menu.appendToGroup(IContextMenuConstants.GROUP_GOTO, fZoomInAction); addGotoMenu(menu); fOpenCUAction.update(); if (fOpenCUAction.isEnabled()) menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, fOpenCUAction); addOpenWithMenu(menu, selection); addOpenToMenu(menu, selection); addRefactoring(menu); if (selection.size() == 1) { menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, new JavaReplaceWithEditionAction(fViewer)); menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, new JavaAddElementFromHistory(null, fViewer)); } ContextMenuGroup.add(menu, fStandardGroups, fViewer); if (fAddBookmarkAction.canOperateOnSelection()) menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, fAddBookmarkAction); menu.appendToGroup(IContextMenuConstants.GROUP_BUILD, fRefreshAction); fRefreshAction.selectionChanged(selection); if (selectionHasElements) { // update the action to use the right selection since the refresh // action doesn't listen to selection changes. menu.appendToGroup(IContextMenuConstants.GROUP_PROPERTIES, fPropertyDialogAction); } } void addGotoMenu(IMenuManager menu) { MenuManager gotoMenu= new MenuManager(PackagesMessages.getString("PackageExplorer.gotoTitle")); //$NON-NLS-1$ menu.appendToGroup(IContextMenuConstants.GROUP_GOTO, gotoMenu); gotoMenu.add(fBackAction); gotoMenu.add(fForwardAction); gotoMenu.add(fUpAction); gotoMenu.add(fGotoTypeAction); gotoMenu.add(fGotoPackageAction); } private void makeActions() { ISelectionProvider provider= getSelectionProvider(); fOpenCUAction= new OpenResourceAction(provider); fPropertyDialogAction= new PropertyDialogAction(getShell(), provider); // fShowTypeHierarchyAction= new ShowTypeHierarchyAction(provider); fShowNavigatorAction= new ShowInNavigatorAction(provider); fAddBookmarkAction= new AddBookmarkAction(provider); fStandardGroups= new ContextMenuGroup[] { new NewGroup(), new BuildGroup(), new ReorgGroup(), new JavaSearchGroup() }; fDeleteAction= new DeleteAction(StructuredSelectionProvider.createFrom(provider)); fRefreshAction= new RefreshAction(getShell()); fFilterAction = new FilterSelectionAction(getShell(), this, PackagesMessages.getString("PackageExplorer.filters")); //$NON-NLS-1$ fShowLibrariesAction = new ShowLibrariesAction(this, PackagesMessages.getString("PackageExplorer.referencedLibs")); //$NON-NLS-1$ fShowBinariesAction = new ShowBinariesAction(getShell(), this, PackagesMessages.getString("PackageExplorer.binaryProjects")); //$NON-NLS-1$ fFilterWorkingSetAction = new FilterWorkingSetAction(getShell(), this, "Filter Working Set..."); //$NON-NLS-1$ fRemoveWorkingSetAction = new RemoveWorkingSetFilterAction(getShell(), this, "Remove Working Set Filter"); //$NON-NLS-1$ fBackAction= new BackAction(fFrameList); fForwardAction= new ForwardAction(fFrameList); fZoomInAction= new GoIntoAction(fFrameList); fUpAction= new UpAction(fFrameList); fGotoTypeAction= new GotoTypeAction(this); fGotoPackageAction= new GotoPackageAction(this); IActionBars actionService= getViewSite().getActionBars(); actionService.setGlobalActionHandler(IWorkbenchActionConstants.DELETE, fDeleteAction); } private void addRefactoring(IMenuManager menu){ MenuManager refactoring= new MenuManager(PackagesMessages.getString("PackageExplorer.refactoringTitle")); //$NON-NLS-1$ ContextMenuGroup.add(refactoring, new ContextMenuGroup[] { new RefactoringGroup() }, fViewer); if (!refactoring.isEmpty()) menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, refactoring); } private void addOpenToMenu(IMenuManager menu, IStructuredSelection selection) { if (selection.size() != 1) return; IAdaptable element= (IAdaptable) selection.getFirstElement(); IResource resource= (IResource)element.getAdapter(IResource.class); if ((resource instanceof IContainer)) { // Create a menu flyout. MenuManager submenu = new MenuManager(PackagesMessages.getString("PackageExplorer.openPerspective")); //$NON-NLS-1$ submenu.add(new OpenPerspectiveMenu(getSite().getWorkbenchWindow(), resource)); menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, submenu); } OpenTypeHierarchyUtil.addToMenu(getSite().getWorkbenchWindow(), menu, element); } private void addOpenWithMenu(IMenuManager menu, IStructuredSelection selection) { // If one file is selected get it. // Otherwise, do not show the "open with" menu. if (selection.size() != 1) return; IAdaptable element= (IAdaptable)selection.getFirstElement(); Object resource= element.getAdapter(IResource.class); if (!(resource instanceof IFile)) return; // Create a menu flyout. MenuManager submenu= new MenuManager(PackagesMessages.getString("PackageExplorer.openWith")); //$NON-NLS-1$ submenu.add(new OpenWithMenu(getSite().getPage(), (IFile) resource)); // Add the submenu. menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, submenu); } private boolean isSelectionOfType(ISelection s, Class clazz, boolean considerUnderlyingResource) { if (! (s instanceof IStructuredSelection) || s.isEmpty()) return false; IStructuredSelection selection= (IStructuredSelection)s; Iterator iter= selection.iterator(); while (iter.hasNext()) { Object o= iter.next(); if (clazz.isInstance(o)) return true; if (considerUnderlyingResource) { if (! (o instanceof IJavaElement)) return false; IJavaElement element= (IJavaElement)o; Object resource= element.getAdapter(IResource.class); if (! clazz.isInstance(resource)) return false; } } return true; } //---- Event handling ---------------------------------------------------------- private void initDragAndDrop() { int ops= DND.DROP_COPY | DND.DROP_MOVE; final LocalSelectionTransfer lt= LocalSelectionTransfer.getInstance(); Transfer[] transfers= new Transfer[] {lt, FileTransfer.getInstance()}; // Drop Adapter TransferDropTargetListener[] dropListeners= new TransferDropTargetListener[] { new SelectionTransferDropAdapter(fViewer), new FileTransferDropAdapter(fViewer) }; fViewer.addDropSupport(ops, transfers, new DelegatingDropAdapter(dropListeners)); // Drag Adapter Control control= fViewer.getControl(); TransferDragSourceListener[] dragListeners= new TransferDragSourceListener[] { new SelectionTransferDragAdapter(fViewer), new FileTransferDragAdapter(fViewer) }; DragSource source= new DragSource(control, ops); // Note, that the transfer agents are set by the delegating drag adapter itself. source.addDragListener(new DelegatingDragAdapter(dragListeners)); } /** * Handles key events in viewer. */ void handleKeyPressed(KeyEvent event) { if (event.character == SWT.DEL && event.stateMask == 0){ fDeleteAction.update(); if (fDeleteAction.isEnabled()) fDeleteAction.run(); } } /** * Handles double clicks in viewer. * Opens editor if file double-clicked. */ private void handleDoubleClick(DoubleClickEvent event) { IStructuredSelection s= (IStructuredSelection) event.getSelection(); Object element= s.getFirstElement(); if (fOpenCUAction.isEnabled()) { fOpenCUAction.run(); return; } if (fViewer.isExpandable(element)) { if (JavaBasePreferencePage.doubleClockGoesInto()) { // don't zoom into compilation units and class files if (element instanceof IOpenable && !(element instanceof ICompilationUnit) && !(element instanceof IClassFile)) { fZoomInAction.run(); } } else { fViewer.setExpandedState(element, !fViewer.getExpandedState(element)); //expandMainType(element); } } } /** * Handles selection changed in viewer. * Updates global actions. * Links to editor (if option enabled) */ private void handleSelectionChanged(SelectionChangedEvent event) { IStructuredSelection sel= (IStructuredSelection) event.getSelection(); //updateGlobalActions(sel); fZoomInAction.update(); linkToEditor(sel); } public void selectReveal(ISelection selection) { ISelection javaSelection= convertSelection(selection); fViewer.setSelection(javaSelection, true); } private ISelection convertSelection(ISelection s) { List converted= new ArrayList(); if (s instanceof StructuredSelection) { Object[] elements= ((StructuredSelection)s).toArray(); for (int i= 0; i < elements.length; i++) { Object e= elements[i]; if (e instanceof IJavaElement) converted.add(e); else if (e instanceof IResource) { IJavaElement element= JavaCore.create((IResource)e); if (element != null) converted.add(element); else converted.add(e); } } } return new StructuredSelection(converted.toArray()); } public void selectAndReveal(Object element) { selectReveal(new StructuredSelection(element)); } /** * Returns whether the preference to link selection to active editor is enabled. */ boolean isLinkingEnabled() { return JavaBasePreferencePage.linkPackageSelectionToEditor(); } /** * Links to editor (if option enabled) */ private void linkToEditor(IStructuredSelection selection) { //if (!isLinkingEnabled()) // return; Object obj= selection.getFirstElement(); Object element= null; if (selection.size() == 1) { if (obj instanceof IJavaElement) { IJavaElement cu= JavaModelUtil.findElementOfKind((IJavaElement)obj, IJavaElement.COMPILATION_UNIT); if (cu != null) element= getResourceFor(cu); if (element == null) element= JavaModelUtil.findElementOfKind((IJavaElement)obj, IJavaElement.CLASS_FILE); } else if (obj instanceof IFile) element= obj; if (element == null) return; IWorkbenchPage page= getSite().getPage(); IEditorPart editorArray[]= page.getEditors(); for (int i= 0; i < editorArray.length; ++i) { IEditorPart editor= editorArray[i]; Object input= getElementOfInput(editor.getEditorInput()); if (input != null && input.equals(element)) { page.bringToTop(editor); if (obj instanceof IJavaElement) EditorUtility.revealInEditor(editor, (IJavaElement) obj); return; } } } } private IResource getResourceFor(Object element) { if (element instanceof IJavaElement) { if (element instanceof IWorkingCopy) { IWorkingCopy wc= (IWorkingCopy)element; IJavaElement original= wc.getOriginalElement(); if (original != null) element= original; } try { element= ((IJavaElement)element).getUnderlyingResource(); } catch (JavaModelException e) { return null; } } if (!(element instanceof IResource) || ((IResource)element).isPhantom()) { return null; } return (IResource)element; } public void saveState(IMemento memento) { if (fViewer == null) { // part has not been created if (fMemento != null) //Keep the old state; memento.putMemento(fMemento); return; } saveExpansionState(memento); saveSelectionState(memento); saveScrollState(memento, fViewer.getTree()); savePatternFilterState(memento); saveFilterState(memento); saveWorkingSetState(memento); } protected void saveFilterState(IMemento memento) { boolean showLibraries= getLibraryFilter().getShowLibraries(); String show= "true"; //$NON-NLS-1$ if (!showLibraries) show= "false"; //$NON-NLS-1$ memento.putString(TAG_SHOWLIBRARIES, show); //save binary filter boolean showBinaries= getBinaryFilter().getShowBinaries(); String showBinString= "true"; //$NON-NLS-1$ if (!showBinaries) showBinString= "false"; //$NON-NLS-1$ memento.putString(TAG_SHOWBINARIES, showBinString); } protected void savePatternFilterState(IMemento memento) { String filters[] = getPatternFilter().getPatterns(); if(filters.length > 0) { IMemento filtersMem = memento.createChild(TAG_FILTERS); for (int i = 0; i < filters.length; i++){ IMemento child = filtersMem.createChild(TAG_FILTER); child.putString(TAG_ELEMENT,filters[i]); } } } protected void saveScrollState(IMemento memento, Tree tree) { ScrollBar bar= tree.getVerticalBar(); int position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_VERTICAL_POSITION, String.valueOf(position)); //save horizontal position bar= tree.getHorizontalBar(); position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_HORIZONTAL_POSITION, String.valueOf(position)); } protected void saveSelectionState(IMemento memento) { Object elements[]= ((IStructuredSelection) fViewer.getSelection()).toArray(); if (elements.length > 0) { IMemento selectionMem= memento.createChild(TAG_SELECTION); for (int i= 0; i < elements.length; i++) { IMemento elementMem= selectionMem.createChild(TAG_ELEMENT); // we can only persist JavaElements for now Object o= elements[i]; if (o instanceof IJavaElement) elementMem.putString(TAG_PATH, ((IJavaElement) elements[i]).getHandleIdentifier()); } } } protected void saveExpansionState(IMemento memento) { Object expandedElements[]= fViewer.getExpandedElements(); if (expandedElements.length > 0) { IMemento expandedMem= memento.createChild(TAG_EXPANDED); for (int i= 0; i < expandedElements.length; i++) { IMemento elementMem= expandedMem.createChild(TAG_ELEMENT); // we can only persist JavaElements for now Object o= expandedElements[i]; if (o instanceof IJavaElement) elementMem.putString(TAG_PATH, ((IJavaElement) expandedElements[i]).getHandleIdentifier()); } } } protected void saveWorkingSetState(IMemento memento) { IWorkingSet ws= getWorkingSetFilter().getWorkingSet(); if (ws != null) { memento.putString(TAG_WORKINGSET, ws.getName()); } } void restoreState(IMemento memento) { restoreExpansionState(memento); restoreSelectionState(memento); restoreScrollState(memento, fViewer.getTree()); } protected void restoreScrollState(IMemento memento, Tree tree) { ScrollBar bar= tree.getVerticalBar(); if (bar != null) { try { String posStr= memento.getString(TAG_VERTICAL_POSITION); int position; position= new Integer(posStr).intValue(); bar.setSelection(position); } catch (NumberFormatException e) { // ignore, don't set scrollposition } } bar= tree.getHorizontalBar(); if (bar != null) { try { String posStr= memento.getString(TAG_HORIZONTAL_POSITION); int position; position= new Integer(posStr).intValue(); bar.setSelection(position); } catch (NumberFormatException e) { // ignore don't set scroll position } } } protected void restoreSelectionState(IMemento memento) { IMemento childMem; childMem= memento.getChild(TAG_SELECTION); if (childMem != null) { ArrayList list= new ArrayList(); IMemento[] elementMem= childMem.getChildren(TAG_ELEMENT); for (int i= 0; i < elementMem.length; i++) { Object element= JavaCore.create(elementMem[i].getString(TAG_PATH)); list.add(element); } fViewer.setSelection(new StructuredSelection(list)); } } protected void restoreExpansionState(IMemento memento) { IMemento childMem= memento.getChild(TAG_EXPANDED); if (childMem != null) { ArrayList elements= new ArrayList(); IMemento[] elementMem= childMem.getChildren(TAG_ELEMENT); for (int i= 0; i < elementMem.length; i++) { Object element= JavaCore.create(elementMem[i].getString(TAG_PATH)); elements.add(element); } fViewer.setExpandedElements(elements.toArray()); } } /** * Create the KeyListener for doing the refresh on the viewer. */ private void initKeyListener() { fViewer.getControl().addKeyListener(new KeyAdapter() { public void keyReleased(KeyEvent event) { doKeyPressed(event.keyCode); } }); } private void doKeyPressed(int key) { if (key == SWT.F5) { fRefreshAction.selectionChanged( (IStructuredSelection) fViewer.getSelection()); if (fRefreshAction.isEnabled()) fRefreshAction.run(); } else if (key == SWT.F4) { OpenTypeHierarchyUtil.open(getSelection(), getSite().getWorkbenchWindow()); } else if (key == SWT.F3) { fOpenCUAction.update(); if (fOpenCUAction.isEnabled()) fOpenCUAction.run(); } } void initFrameList() { fFrameSource= new PackagesFrameSource(this); fFrameList= new FrameList(fFrameSource); fFrameSource.connectTo(fFrameList); } /** * An editor has been activated. Set the selection in this Packages Viewer * to be the editor's input, if linking is enabled. */ void editorActivated(IEditorPart editor) { if (!isLinkingEnabled()) return; Object input= getElementOfInput(editor.getEditorInput()); Object element= null; if (input instanceof IFile) element= JavaCore.create((IFile)input); if (element == null) // try a non Java resource element= input; if (element != null) { // if the current selection is a child of the new // selection then ignore it. IStructuredSelection oldSelection= (IStructuredSelection)getSelection(); if (oldSelection.size() == 1) { Object o= oldSelection.getFirstElement(); if (o instanceof IMember) { IMember m= (IMember)o; if (element.equals(m.getCompilationUnit())) return; if (element.equals(m.getClassFile())) return; } } ISelection newSelection= new StructuredSelection(element); if (!fViewer.getSelection().equals(newSelection)) { try { fViewer.removeSelectionChangedListener(fSelectionListener); fViewer.setSelection(newSelection); } finally { fViewer.addSelectionChangedListener(fSelectionListener); } } } } /** * A compilation unit or class was expanded, expand * the main type. */ void expandMainType(Object element) { try { IType type= null; if (element instanceof ICompilationUnit) { ICompilationUnit cu= (ICompilationUnit)element; IType[] types= cu.getTypes(); if (types.length > 0) type= types[0]; } else if (element instanceof IClassFile) { IClassFile cf= (IClassFile)element; type= cf.getType(); } if (type != null) { final IType type2= type; Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.getDisplay().asyncExec(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.expandToLevel(type2, 1); } }); } } } catch(JavaModelException e) { // no reveal } } /** * Returns the element contained in the EditorInput */ Object getElementOfInput(IEditorInput input) { if (input instanceof IClassFileEditorInput) return ((IClassFileEditorInput)input).getClassFile(); else if (input instanceof IFileEditorInput) return ((IFileEditorInput)input).getFile(); else if (input instanceof JarEntryEditorInput) return ((JarEntryEditorInput)input).getStorage(); return null; } /** * Returns the Viewer. */ TreeViewer getViewer() { return fViewer; } /** * Returns the pattern filter for this view. * @return the pattern filter */ JavaElementPatternFilter getPatternFilter() { return fPatternFilter; } /** * Returns the library filter for this view. * @return the library filter */ LibraryFilter getLibraryFilter() { return fLibraryFilter; } /** * Returns the working set filter for this view. * @return the working set filter */ WorkingSetFilter getWorkingSetFilter() { return fWorkingSetFilter; } /** * Returns the Binary filter for this view. * @return the binary filter */ BinaryProjectFilter getBinaryFilter() { return fBinaryFilter; } void restoreFilters() { IMemento filtersMem= fMemento.getChild(TAG_FILTERS); if(filtersMem != null) { IMemento children[]= filtersMem.getChildren(TAG_FILTER); String filters[]= new String[children.length]; for (int i = 0; i < children.length; i++) { filters[i]= children[i].getString(TAG_ELEMENT); } getPatternFilter().setPatterns(filters); } else { getPatternFilter().setPatterns(new String[0]); } //restore library String show= fMemento.getString(TAG_SHOWLIBRARIES); if (show != null) getLibraryFilter().setShowLibraries(show.equals("true")); //$NON-NLS-1$ else initLibraryFilterFromPreferences(); //restore binary fileter String showbin= fMemento.getString(TAG_SHOWBINARIES); if (showbin != null) getBinaryFilter().setShowBinaries(showbin.equals("true")); //$NON-NLS-1$ else initBinaryFilterFromPreferences(); //restore working set String workingSetName= fMemento.getString(TAG_WORKINGSET); if (workingSetName != null) { IWorkingSet ws= SearchUI.findWorkingSet(workingSetName); if (ws != null) { getWorkingSetFilter().setWorkingSet(ws); } } } void initFilterFromPreferences() { initBinaryFilterFromPreferences(); initLibraryFilterFromPreferences(); } void initLibraryFilterFromPreferences() { JavaPlugin plugin= JavaPlugin.getDefault(); boolean show= plugin.getPreferenceStore().getBoolean(TAG_SHOWLIBRARIES); getLibraryFilter().setShowLibraries(show); } void initBinaryFilterFromPreferences() { JavaPlugin plugin= JavaPlugin.getDefault(); boolean showbin= plugin.getPreferenceStore().getBoolean(TAG_SHOWBINARIES); getBinaryFilter().setShowBinaries(showbin); } /** * Updates the title text and title tool tip. * Called whenever the input of the viewer changes. */ void updateTitle() { Object input= getViewer().getInput(); String viewName= getConfigurationElement().getAttribute("name"); //$NON-NLS-1$ if (input == null || (input instanceof IJavaModel)) { setTitle(viewName); setTitleToolTip(""); //$NON-NLS-1$ } else { ILabelProvider labelProvider = (ILabelProvider) getViewer().getLabelProvider(); String inputText= labelProvider.getText(input); String title= PackagesMessages.getFormattedString("PackageExplorer.argTitle", new String[] { viewName, inputText }); //$NON-NLS-1$ setTitle(title); setTitleToolTip(getToolTipText(input)); } } /** * Sets the decorator for the package explorer. * * @param decorator a label decorator or <code>null</code> for no decorations. */ public void setLabelDecorator(ILabelDecorator decorator) { JavaElementLabelProvider javaProvider= new JavaElementLabelProvider(getLabelProviderFlags()); javaProvider.setErrorTickManager(new MarkerErrorTickProvider()); if (decorator == null) { fViewer.setLabelProvider(javaProvider); } else { fViewer.setLabelProvider(new DecoratingLabelProvider(javaProvider, decorator)); } } /** * Gets the standard label flags */ private int getLabelProviderFlags() { return JavaElementLabelProvider.SHOW_BASICS | JavaElementLabelProvider.SHOW_OVERLAY_ICONS | JavaElementLabelProvider.SHOW_SMALL_ICONS | JavaElementLabelProvider.SHOW_VARIABLE | JavaElementLabelProvider.SHOW_PARAMETERS; } /* * @see IPropertyChangeListener#propertyChange(PropertyChangeEvent) */ public void propertyChange(PropertyChangeEvent event) { if (event.getProperty() != IPreferencesConstants.SHOW_CU_CHILDREN) return; if (fViewer != null) { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); boolean b= store.getBoolean(IPreferencesConstants.SHOW_CU_CHILDREN); ((JavaElementContentProvider)fViewer.getContentProvider()).setProvideMembers(b); fViewer.refresh(); } } }
5,699
Bug 5699 Add ResourceTransfer to packages view
The packages view should add the ResoruceTransfer as a drag source to its list of transfers
resolved fixed
eb077ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T15:13:53Z"
"2001-11-09T10:00:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/SelectionTransferDropAdapter.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.packageview; import java.util.List; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.core.refactoring.Assert; import org.eclipse.jdt.internal.core.refactoring.reorg.CopyRefactoring; import org.eclipse.jdt.internal.core.refactoring.reorg.MoveRefactoring; import org.eclipse.jdt.internal.core.refactoring.reorg.ReorgRefactoring; import org.eclipse.jdt.internal.core.refactoring.text.ITextBufferChangeCreator; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dnd.JdtTreeViewerDropAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; import org.eclipse.jdt.internal.ui.refactoring.changes.DocumentTextBufferChangeCreator; import org.eclipse.jdt.internal.ui.reorg.CopyAction; import org.eclipse.jdt.internal.ui.reorg.MoveAction; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.viewers.AbstractTreeViewer; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.swt.SWT; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DropTargetEvent; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.widgets.Shell; import org.eclipse.ui.texteditor.IDocumentProvider; public class SelectionTransferDropAdapter extends JdtTreeViewerDropAdapter implements TransferDropTargetListener { private List fElements; private MoveRefactoring fMoveRefactoring; private int fCanMoveElements; private CopyRefactoring fCopyRefactoring; private int fCanCopyElements; public SelectionTransferDropAdapter(AbstractTreeViewer viewer) { super(viewer, SWT.NONE); } //---- TransferDropTargetListener interface --------------------------------------- public Transfer getTransfer() { return LocalSelectionTransfer.getInstance(); } //---- Actual DND ----------------------------------------------------------------- public void dragEnter(DropTargetEvent event) { clear(); super.dragEnter(event); } public void dragLeave(DropTargetEvent event) { clear(); super.dragLeave(event); } private void clear() { fElements= null; fMoveRefactoring= null; fCanMoveElements= 0; fCopyRefactoring= null; fCanCopyElements= 0; } public void validateDrop(Object target, DropTargetEvent event, int operation) { event.detail= DND.DROP_NONE; if (fElements == null) { ISelection s= LocalSelectionTransfer.getInstance().getSelection(); if (!(s instanceof IStructuredSelection)) return; fElements= ((IStructuredSelection)s).toList(); } boolean success= false; try { if (operation == DND.DROP_COPY) { success= handleValidateCopy(target, event); } else if (operation == DND.DROP_MOVE) { success= handleValidateMove(target, event); } } catch (JavaModelException e){ ExceptionHandler.handle(e, "Drag'n'drop", "Unexpected exception. See log for details."); success= false; } if (success) event.detail= operation; } public void drop(Object target, DropTargetEvent event) { try{ if (event.detail == DND.DROP_MOVE) { handleDropMove(target, event); } else if (event.detail == DND.DROP_COPY) { handleDropCopy(target, event); } // The drag source listener must not perform any operation // since this drop adapter did the remove of the source even // if we moved something. event.detail= DND.DROP_NONE; } catch (JavaModelException e){ ExceptionHandler.handle(e, "Drag'n'drop", "Unexpected exception. See log for details."); } } private boolean handleValidateMove(Object target, DropTargetEvent event) throws JavaModelException{ if (fMoveRefactoring == null){ IDocumentProvider documentProvider= JavaPlugin.getDefault().getCompilationUnitDocumentProvider(); ITextBufferChangeCreator changeCreator= new DocumentTextBufferChangeCreator(documentProvider); fMoveRefactoring= new MoveRefactoring(fElements, changeCreator); } if (!canMoveElements()) return false; return fMoveRefactoring.isValidDestination(target); } private boolean canMoveElements() { if (fCanMoveElements == 0) { fCanMoveElements= 2; if (! canActivate(fMoveRefactoring)) fCanMoveElements= 1; } return fCanMoveElements == 2; } private boolean canActivate(ReorgRefactoring ref){ try{ return ref.checkActivation(new NullProgressMonitor()).isOK(); } catch(JavaModelException e){ ExceptionHandler.handle(e, "Drag'n'drop", "Unexpected exception. See log for details."); return false; } } private void handleDropMove(final Object target, DropTargetEvent event) throws JavaModelException{ new DragNDropMoveAction(StructuredSelectionProvider.createFrom(getViewer()), target).run(); } private boolean handleValidateCopy(Object target, DropTargetEvent event) throws JavaModelException{ if (fCopyRefactoring == null) fCopyRefactoring= new CopyRefactoring(fElements); if (!canCopyElements()) return false; return fCopyRefactoring.isValidDestination(target); } private boolean canCopyElements() { if (fCanCopyElements == 0) { fCanCopyElements= 2; if (!canActivate(fCopyRefactoring)) fCanCopyElements= 1; } return fCanCopyElements == 2; } private void handleDropCopy(final Object target, DropTargetEvent event) throws JavaModelException{ CopyAction action= new CopyAction("#COPY", StructuredSelectionProvider.createFrom(getViewer())){ protected Object selectDestination(ReorgRefactoring ref) { return target; } }; action.run(); } //-- private static class DragNDropMoveAction extends MoveAction{ private Object fTarget; private static final int PREVIEW_ID= IDialogConstants.CLIENT_ID + 1; public DragNDropMoveAction(StructuredSelectionProvider provider, Object target){ super("#MOVE", provider); Assert.isNotNull(target); fTarget= target; } protected Object selectDestination(ReorgRefactoring ref) { return fTarget; } protected boolean isOkToProceed(ReorgRefactoring refactoring) throws JavaModelException{ if (!super.isOkToProceed(refactoring)) return false; return askIfUpdateReferences((MoveRefactoring)refactoring); } //returns false iff canceled or error private boolean askIfUpdateReferences(MoveRefactoring ref) throws JavaModelException{ if (! ref.canUpdateReferences()){ setShowPreview(false); return true; } switch (askIfUpdateReferences()){ case IDialogConstants.CANCEL_ID: setShowPreview(false); return false; case IDialogConstants.NO_ID: ref.setUpdateReferences(false); setShowPreview(false); return true; case IDialogConstants.YES_ID: ref.setUpdateReferences(true); setShowPreview(false); return true; case PREVIEW_ID: ref.setUpdateReferences(true); setShowPreview(true); return true; default: Assert.isTrue(false); //not expected to get here return false; } } private static int askIfUpdateReferences(){ Shell shell= JavaPlugin.getActiveWorkbenchShell().getShell(); String title= "Move"; String preview= "Pre&view"; String question= "Do you want to update references to the moved element(s)? Press '" + preview + "' to see the preview of the reference updates."; String[] labels= new String[] {IDialogConstants.YES_LABEL, IDialogConstants.NO_LABEL, preview, IDialogConstants.CANCEL_LABEL }; final MessageDialog dialog = new MessageDialog(shell, title, null, question, MessageDialog.QUESTION, labels, 2); //preview is default shell.getDisplay().syncExec(new Runnable() { public void run() { dialog.open(); } }); int result = dialog.getReturnCode(); if (result == 0) return IDialogConstants.YES_ID; if (result == 1) return IDialogConstants.NO_ID; if (result == 2) return PREVIEW_ID; return IDialogConstants.CANCEL_ID; } } }
5,699
Bug 5699 Add ResourceTransfer to packages view
The packages view should add the ResoruceTransfer as a drag source to its list of transfers
resolved fixed
eb077ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T15:13:53Z"
"2001-11-09T10:00:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyTransferDropAdapter.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.typehierarchy; import org.eclipse.swt.SWT; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DropTargetEvent; import org.eclipse.swt.dnd.Transfer; import org.eclipse.jface.viewers.AbstractTreeViewer; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.internal.ui.actions.AddMethodStubAction; import org.eclipse.jdt.internal.ui.dnd.JdtTreeViewerDropAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener; public class TypeHierarchyTransferDropAdapter extends JdtTreeViewerDropAdapter implements TransferDropTargetListener { private AddMethodStubAction fAddMethodStubAction; public TypeHierarchyTransferDropAdapter(AbstractTreeViewer viewer) { super(viewer, SWT.NONE); fAddMethodStubAction= new AddMethodStubAction(); } //---- TransferDropTargetListener interface --------------------------------------- public Transfer getTransfer() { return LocalSelectionTransfer.getInstance(); } //---- Actual DND ----------------------------------------------------------------- public void validateDrop(Object target, DropTargetEvent event, int operation) { event.detail= DND.DROP_NONE; ISelection selection= LocalSelectionTransfer.getInstance().getSelection(); if (target instanceof IType) { if (AddMethodStubAction.canActionBeAdded((IType)target, selection)) { if (operation == DND.DROP_NONE) { operation= DND.DROP_COPY; // use copy as default operation } event.detail= operation; } } return; } public void drop(Object target, DropTargetEvent event) { ISelection selection= LocalSelectionTransfer.getInstance().getSelection(); if (target instanceof IType) { if (fAddMethodStubAction.init((IType)target, selection)) { fAddMethodStubAction.run(); } } return; } }
5,183
Bug 5183 Wrong return type for extract method
protected ITextBuffer doCreate(IFile file) throws CoreException { FileEditorInput input= new FileEditorInput(file); IDocument document= fDocumentProvider.getDocument(input); if (document != null) { return new TextBuffer(document); } else { InputStreamReader in= null; /*]*/try { document= new Document(); in= new InputStreamReader(new BufferedInputStream(file.getContents())); StringBuffer buffer= new StringBuffer(); char[] readBuffer= new char[2048]; int n= in.read(readBuffer); while (n > 0) { buffer.append(readBuffer, 0, n); n= in.read(readBuffer); } document.set(buffer.toString()); return new TextBuffer(document); } catch (IOException x) { IStatus s= new Status(IStatus.ERROR, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, x.getMessage(), x); throw new CoreException(s); } finally { if (in != null) { try { in.close(); } catch (IOException x) { } } }/*[*/ } } Extracting a method from the code /*]*/.../*[*/ doesn't return the created text buffer.
resolved fixed
7fe550b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T18:01:02Z"
"2001-10-23T18:00:00Z"
org.eclipse.jdt.ui/core
5,183
Bug 5183 Wrong return type for extract method
protected ITextBuffer doCreate(IFile file) throws CoreException { FileEditorInput input= new FileEditorInput(file); IDocument document= fDocumentProvider.getDocument(input); if (document != null) { return new TextBuffer(document); } else { InputStreamReader in= null; /*]*/try { document= new Document(); in= new InputStreamReader(new BufferedInputStream(file.getContents())); StringBuffer buffer= new StringBuffer(); char[] readBuffer= new char[2048]; int n= in.read(readBuffer); while (n > 0) { buffer.append(readBuffer, 0, n); n= in.read(readBuffer); } document.set(buffer.toString()); return new TextBuffer(document); } catch (IOException x) { IStatus s= new Status(IStatus.ERROR, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, x.getMessage(), x); throw new CoreException(s); } finally { if (in != null) { try { in.close(); } catch (IOException x) { } } }/*[*/ } } Extracting a method from the code /*]*/.../*[*/ doesn't return the created text buffer.
resolved fixed
7fe550b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T18:01:02Z"
"2001-10-23T18:00:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/code/ExceptionAnalyzer.java
5,183
Bug 5183 Wrong return type for extract method
protected ITextBuffer doCreate(IFile file) throws CoreException { FileEditorInput input= new FileEditorInput(file); IDocument document= fDocumentProvider.getDocument(input); if (document != null) { return new TextBuffer(document); } else { InputStreamReader in= null; /*]*/try { document= new Document(); in= new InputStreamReader(new BufferedInputStream(file.getContents())); StringBuffer buffer= new StringBuffer(); char[] readBuffer= new char[2048]; int n= in.read(readBuffer); while (n > 0) { buffer.append(readBuffer, 0, n); n= in.read(readBuffer); } document.set(buffer.toString()); return new TextBuffer(document); } catch (IOException x) { IStatus s= new Status(IStatus.ERROR, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, x.getMessage(), x); throw new CoreException(s); } finally { if (in != null) { try { in.close(); } catch (IOException x) { } } }/*[*/ } } Extracting a method from the code /*]*/.../*[*/ doesn't return the created text buffer.
resolved fixed
7fe550b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T18:01:02Z"
"2001-10-23T18:00:00Z"
org.eclipse.jdt.ui/core
5,183
Bug 5183 Wrong return type for extract method
protected ITextBuffer doCreate(IFile file) throws CoreException { FileEditorInput input= new FileEditorInput(file); IDocument document= fDocumentProvider.getDocument(input); if (document != null) { return new TextBuffer(document); } else { InputStreamReader in= null; /*]*/try { document= new Document(); in= new InputStreamReader(new BufferedInputStream(file.getContents())); StringBuffer buffer= new StringBuffer(); char[] readBuffer= new char[2048]; int n= in.read(readBuffer); while (n > 0) { buffer.append(readBuffer, 0, n); n= in.read(readBuffer); } document.set(buffer.toString()); return new TextBuffer(document); } catch (IOException x) { IStatus s= new Status(IStatus.ERROR, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, x.getMessage(), x); throw new CoreException(s); } finally { if (in != null) { try { in.close(); } catch (IOException x) { } } }/*[*/ } } Extracting a method from the code /*]*/.../*[*/ doesn't return the created text buffer.
resolved fixed
7fe550b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T18:01:02Z"
"2001-10-23T18:00:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/code/ReturnAnalyzer.java
3,471
Bug 3471 Leading '/' in src page of Java wizard is misleading (1G842TH)
1. create new java project "jp" with Create Java Project wizard. 2. in wizard goto second ("Source") page Observe: the Build Output Folder is "/jp/bin" Since this looks like a Unix pathname I interpret the leading "/" as an indication for a absolute pathname. Other tools use something like: {WORKBENCH}/jp/bin or shell variable syntax: $WORKBENCH/jp/bin NOTES: EG (1/30/01 10:34:33 AM) desktop is using the same convention for presenting paths. General issue: how to show a workbench relative path
resolved wontfix
d8eedf7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T18:21:09Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/BuildPathsBlock.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards.buildpaths; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Arrays; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Widget; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IProjectDescription; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.Path; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.resource.ImageRegistry; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.ui.ISharedImages; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.model.WorkbenchContentProvider; import org.eclipse.ui.model.WorkbenchLabelProvider; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.JavaConventions; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.launching.JavaRuntime; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.ISelectionValidator; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.util.CoreUtility; import org.eclipse.jdt.internal.ui.util.SWTUtil; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; import org.eclipse.jdt.internal.ui.viewsupport.ImageDisposer; import org.eclipse.jdt.internal.ui.wizards.IStatusChangeListener; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; import org.eclipse.jdt.internal.ui.wizards.TypedElementSelectionValidator; import org.eclipse.jdt.internal.ui.wizards.TypedViewerFilter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.CheckedListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IStringButtonAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.ListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringButtonDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringDialogField; import org.eclipse.jdt.internal.ui.wizards.swt.MGridData; import org.eclipse.jdt.internal.ui.wizards.swt.MGridLayout; public class BuildPathsBlock { private IWorkspaceRoot fWorkspaceRoot; private CheckedListDialogField fClassPathList; private StringDialogField fBuildPathDialogField; private StatusInfo fClassPathStatus; private StatusInfo fBuildPathStatus; private IJavaProject fCurrJProject; private IPath fOutputLocationPath; private IStatusChangeListener fContext; private Control fSWTWidget; private boolean fIsNewProject; private SourceContainerWorkbookPage fSourceContainerPage; private ProjectsWorkbookPage fProjectsPage; private LibrariesWorkbookPage fLibrariesPage; private BuildPathBasePage fCurrPage; public BuildPathsBlock(IWorkspaceRoot root, IStatusChangeListener context, boolean isNewProject) { fWorkspaceRoot= root; fContext= context; fIsNewProject= isNewProject; fSourceContainerPage= null; fLibrariesPage= null; fProjectsPage= null; fCurrPage= null; BuildPathAdapter adapter= new BuildPathAdapter(); String[] buttonLabels= new String[] { /* 0 */ NewWizardMessages.getString("BuildPathsBlock.classpath.up.button"), //$NON-NLS-1$ /* 1 */ NewWizardMessages.getString("BuildPathsBlock.classpath.down.button"), //$NON-NLS-1$ /* 2 */ null, /* 3 */ NewWizardMessages.getString("BuildPathsBlock.classpath.checkall.button"), //$NON-NLS-1$ /* 4 */ NewWizardMessages.getString("BuildPathsBlock.classpath.uncheckall.button") //$NON-NLS-1$ }; fClassPathList= new CheckedListDialogField(null, buttonLabels, new CPListLabelProvider()); fClassPathList.setDialogFieldListener(adapter); fClassPathList.setLabelText(NewWizardMessages.getString("BuildPathsBlock.classpath.label")); fClassPathList.setUpButtonIndex(0); fClassPathList.setDownButtonIndex(1); fClassPathList.setCheckAllButtonIndex(3); fClassPathList.setUncheckAllButtonIndex(4); if (isNewProject) { fBuildPathDialogField= new StringDialogField(); } else { StringButtonDialogField dialogField= new StringButtonDialogField(adapter); dialogField.setButtonLabel(NewWizardMessages.getString("BuildPathsBlock.buildpath.button")); //$NON-NLS-1$ fBuildPathDialogField= dialogField; } fBuildPathDialogField.setDialogFieldListener(adapter); fBuildPathDialogField.setLabelText(NewWizardMessages.getString("BuildPathsBlock.buildpath.label")); //$NON-NLS-1$ fBuildPathStatus= new StatusInfo(); fClassPathStatus= new StatusInfo(); fCurrJProject= null; } // -------- UI creation --------- public Control createControl(Composite parent) { fSWTWidget= parent; Composite composite= new Composite(parent, SWT.NONE); MGridLayout layout= new MGridLayout(); layout.marginWidth= 0; layout.minimumWidth= SWTUtil.convertWidthInCharsToPixels(80, composite); layout.minimumHeight= SWTUtil.convertHeightInCharsToPixels(20, composite); layout.numColumns= 1; composite.setLayout(layout); TabFolder folder= new TabFolder(composite, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new MGridData(MGridData.FILL_BOTH)); folder.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { tabChanged(e.item); } }); ImageRegistry imageRegistry= JavaPlugin.getDefault().getImageRegistry(); TabItem item; fSourceContainerPage= new SourceContainerWorkbookPage(fWorkspaceRoot, fClassPathList, fBuildPathDialogField, fIsNewProject); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.source")); //$NON-NLS-1$ item.setImage(imageRegistry.get(JavaPluginImages.IMG_OBJS_PACKFRAG_ROOT)); item.setData(fSourceContainerPage); item.setControl(fSourceContainerPage.getControl(folder)); IWorkbench workbench= JavaPlugin.getDefault().getWorkbench(); Image projectImage= workbench.getSharedImages().getImage(ISharedImages.IMG_OBJ_PROJECT); fProjectsPage= new ProjectsWorkbookPage(fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.projects")); //$NON-NLS-1$ item.setImage(projectImage); item.setData(fProjectsPage); item.setControl(fProjectsPage.getControl(folder)); fLibrariesPage= new LibrariesWorkbookPage(fWorkspaceRoot, fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.libraries")); //$NON-NLS-1$ item.setImage(imageRegistry.get(JavaPluginImages.IMG_OBJS_LIBRARY)); item.setData(fLibrariesPage); item.setControl(fLibrariesPage.getControl(folder)); // a non shared image Image cpoImage= JavaPluginImages.DESC_TOOL_CLASSPATH_ORDER.createImage(); composite.addDisposeListener(new ImageDisposer(cpoImage)); ClasspathOrderingWorkbookPage ordpage= new ClasspathOrderingWorkbookPage(fClassPathList); item= new TabItem(folder, SWT.NONE); item.setText(NewWizardMessages.getString("BuildPathsBlock.tab.order")); //$NON-NLS-1$ item.setImage(cpoImage); item.setData(ordpage); item.setControl(ordpage.getControl(folder)); if (fCurrJProject != null) { fSourceContainerPage.init(fCurrJProject); fLibrariesPage.init(fCurrJProject); fProjectsPage.init(fCurrJProject); } Composite editorcomp= new Composite(composite, SWT.NONE); DialogField[] editors= new DialogField[] { fBuildPathDialogField }; LayoutUtil.doDefaultLayout(editorcomp, editors, true, 0, 0, 0, 0); editorcomp.setLayoutData(new MGridData(MGridData.FILL_HORIZONTAL)); if (fIsNewProject) { folder.setSelection(0); fCurrPage= fSourceContainerPage; } else { folder.setSelection(3); fCurrPage= ordpage; } WorkbenchHelp.setHelp(composite, new Object[] { IJavaHelpContextIds.BUILD_PATH_BLOCK }); return composite; } private Shell getShell() { if (fSWTWidget != null) { return fSWTWidget.getShell(); } return JavaPlugin.getActiveWorkbenchShell(); } /** * Initializes the classpath for the given project. Multiple calls to init are allowed, * but all existing settings will be cleared and replace by the given or default paths. * @param project The java project to configure. Does not have to exist. * @param outputLocation The output location to be set in the page. If <code>null</code> * is passed, jdt default settings are used, or - if the project is an existing Java project - the * output location of the existing project * @param classpathEntries The classpath entries to be set in the page. If <code>null</code> * is passed, jdt default settings are used, or - if the project is an existing Java project - the * classpath entries of the existing project */ public void init(IJavaProject jproject, IPath outputLocation, IClasspathEntry[] classpathEntries) { fCurrJProject= jproject; boolean projExists= false; try { IProject project= fCurrJProject.getProject(); projExists= (project.exists() && project.hasNature(JavaCore.NATURE_ID)); if (projExists) { if (outputLocation == null) { outputLocation= fCurrJProject.getOutputLocation(); } if (classpathEntries == null) { classpathEntries= fCurrJProject.getRawClasspath(); } } } catch (CoreException e) { JavaPlugin.log(e.getStatus()); } if (outputLocation == null) { outputLocation= getDefaultBuildPath(jproject); } List newClassPath; if (classpathEntries == null) { newClassPath= getDefaultClassPath(jproject); } else { newClassPath= new ArrayList(); for (int i= 0; i < classpathEntries.length; i++) { IClasspathEntry curr= classpathEntries[i]; int entryKind= curr.getEntryKind(); IPath path= curr.getPath(); boolean isExported= curr.isExported(); // get the resource IResource res= null; boolean isMissing= false; if (entryKind != IClasspathEntry.CPE_VARIABLE) { res= fWorkspaceRoot.findMember(path); if (res == null) { isMissing= (entryKind != IClasspathEntry.CPE_LIBRARY || !path.toFile().isFile()); } } else { IPath resolvedPath= JavaCore.getResolvedVariablePath(path); isMissing= (resolvedPath == null) || !resolvedPath.toFile().isFile(); } CPListElement elem= new CPListElement(entryKind, path, res, curr.getSourceAttachmentPath(), curr.getSourceAttachmentRootPath(), isExported); if (projExists) { elem.setIsMissing(isMissing); } newClassPath.add(elem); } } List exportedEntries = new ArrayList(); for (int i= 0; i < newClassPath.size(); i++) { CPListElement curr= (CPListElement) newClassPath.get(i); if (curr.isExported() || curr.getEntryKind() == IClasspathEntry.CPE_SOURCE) { exportedEntries.add(curr); } } // inits the dialog field fBuildPathDialogField.setText(outputLocation.toString()); fClassPathList.setElements(newClassPath); fClassPathList.setCheckedElements(exportedEntries); if (fSourceContainerPage != null) { fSourceContainerPage.init(fCurrJProject); fProjectsPage.init(fCurrJProject); fLibrariesPage.init(fCurrJProject); } doStatusLineUpdate(); } // -------- public api -------- /** * Returns the Java project. Can return <code>null<code> if the page has not * been initialized. */ public IJavaProject getJavaProject() { return fCurrJProject; } /** * Returns the current output location. Note that the path returned must not be valid. */ public IPath getOutputLocation() { return new Path(fBuildPathDialogField.getText()); } /** * Returns the current class path (raw). Note that the entries returned must not be valid. */ public IClasspathEntry[] getRawClassPath() { List elements= fClassPathList.getElements(); int nElements= elements.size(); IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; for (int i= 0; i < nElements; i++) { CPListElement currElement= (CPListElement) elements.get(i); entries[i]= currElement.getClasspathEntry(); } return entries; } // -------- evaluate default settings -------- private List getDefaultClassPath(IJavaProject jproj) { List list= new ArrayList(); IResource srcFolder; if (JavaBasePreferencePage.useSrcAndBinFolders()) { srcFolder= jproj.getProject().getFolder("src"); //$NON-NLS-1$ } else { srcFolder= jproj.getProject(); } list.add(new CPListElement(IClasspathEntry.CPE_SOURCE, srcFolder.getFullPath(), srcFolder)); IPath libPath= new Path(JavaRuntime.JRELIB_VARIABLE); IPath attachPath= new Path(JavaRuntime.JRESRC_VARIABLE); IPath attachRoot= new Path(JavaRuntime.JRESRCROOT_VARIABLE); CPListElement elem= new CPListElement(IClasspathEntry.CPE_VARIABLE, libPath, null, attachPath, attachRoot, false); list.add(elem); return list; } private IPath getDefaultBuildPath(IJavaProject jproj) { if (JavaBasePreferencePage.useSrcAndBinFolders()) { return jproj.getProject().getFullPath().append("bin"); //$NON-NLS-1$ } else { return jproj.getProject().getFullPath(); } } private class BuildPathAdapter implements IStringButtonAdapter, IDialogFieldListener { // -------- IStringButtonAdapter -------- public void changeControlPressed(DialogField field) { buildPathChangeControlPressed(field); } // ---------- IDialogFieldListener -------- public void dialogFieldChanged(DialogField field) { buildPathDialogFieldChanged(field); } } private void buildPathChangeControlPressed(DialogField field) { if (field == fBuildPathDialogField) { IContainer container= chooseContainer(); if (container != null) { fBuildPathDialogField.setText(container.getFullPath().toString()); } } } private void buildPathDialogFieldChanged(DialogField field) { if (field == fClassPathList) { updateClassPathStatus(); updateBuildPathStatus(); } else if (field == fBuildPathDialogField) { updateBuildPathStatus(); } doStatusLineUpdate(); } // -------- verification ------------------------------- private void doStatusLineUpdate() { IStatus res= findMostSevereStatus(); fContext.statusChanged(res); } private IStatus findMostSevereStatus() { return StatusUtil.getMoreSevere(fClassPathStatus, fBuildPathStatus); } /** * Validates the build path. */ private void updateClassPathStatus() { fClassPathStatus.setOK(); List elements= fClassPathList.getElements(); boolean entryMissing= false; IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; for (int i= elements.size()-1 ; i >= 0 ; i--) { CPListElement currElement= (CPListElement)elements.get(i); boolean isChecked= fClassPathList.isChecked(currElement); if (currElement.getEntryKind() == IClasspathEntry.CPE_SOURCE) { if (!isChecked) { fClassPathList.setCheckedWithoutUpdate(currElement, true); } } else { currElement.setExported(isChecked); } entries[i]= currElement.getClasspathEntry(); entryMissing= entryMissing || currElement.isMissing(); } if (entryMissing) { fClassPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.EntryMissing")); //$NON-NLS-1$ } if (fCurrJProject.hasClasspathCycle(entries)) { fClassPathStatus.setWarning(NewWizardMessages.getString("BuildPathsBlock.warning.CycleInClassPath")); //$NON-NLS-1$ } } /** * Validates output location & build path. */ private void updateBuildPathStatus() { fOutputLocationPath= null; String text= fBuildPathDialogField.getText(); if ("".equals(text)) { //$NON-NLS-1$ fBuildPathStatus.setError(NewWizardMessages.getString("BuildPathsBlock.error.EnterBuildPath")); //$NON-NLS-1$ return; } IPath path= new Path(text); IResource res= fWorkspaceRoot.findMember(path); if (res != null) { // if exists, must be a folder or project if (res.getType() == IResource.FILE) { fBuildPathStatus.setError(NewWizardMessages.getString("BuildPathsBlock.error.InvalidBuildPath")); //$NON-NLS-1$ return; } } else { // allows the build path to be in a different project, but must exists and be open IPath projPath= path.uptoSegment(1); if (!projPath.equals(fCurrJProject.getProject().getFullPath())) { IProject proj= (IProject)fWorkspaceRoot.findMember(projPath); if (proj == null || !proj.isOpen()) { fBuildPathStatus.setError(NewWizardMessages.getString("BuildPathsBlock.error.BuildPathProjNotExists")); //$NON-NLS-1$ return; } } } fOutputLocationPath= path; List elements= fClassPathList.getElements(); IClasspathEntry[] entries= new IClasspathEntry[elements.size()]; for (int i= elements.size()-1 ; i >= 0 ; i--) { CPListElement currElement= (CPListElement)elements.get(i); entries[i]= currElement.getClasspathEntry(); } IStatus status= JavaConventions.validateClasspath(fCurrJProject, entries, path); if (!status.isOK()) { fBuildPathStatus.setError(status.getMessage()); return; } fBuildPathStatus.setOK(); } // -------- creation ------------------------------- /** * Creates a runnable that sets the configured build paths. */ public IRunnableWithProgress getRunnable() { final List classPathEntries= fClassPathList.getElements(); final IPath path= getOutputLocation(); return new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException { if (monitor == null) { monitor= new NullProgressMonitor(); } monitor.beginTask(NewWizardMessages.getString("BuildPathsBlock.operationdesc"), 12); //$NON-NLS-1$ try { createJavaProject(classPathEntries, path, monitor); } catch (CoreException e) { throw new InvocationTargetException(e); } finally { monitor.done(); } } }; } /** * Creates the Java project and sets the configured build path and output location. * If the project already exists only build paths are updated. */ private void createJavaProject(List classPathEntries, IPath buildPath, IProgressMonitor monitor) throws CoreException { IProject project= fCurrJProject.getProject(); if (!project.exists()) { project.create(null); } if (!project.isOpen()) { project.open(null); } // create java nature if (!project.hasNature(JavaCore.NATURE_ID)) { addNatureToProject(project, JavaCore.NATURE_ID, null); } monitor.worked(1); String[] prevRequiredProjects= fCurrJProject.getRequiredProjectNames(); // create and set the output path first if (!fWorkspaceRoot.exists(buildPath)) { IFolder folder= fWorkspaceRoot.getFolder(buildPath); CoreUtility.createFolder(folder, true, true, null); } monitor.worked(1); fCurrJProject.setOutputLocation(buildPath, new SubProgressMonitor(monitor, 3)); int nEntries= classPathEntries.size(); IClasspathEntry[] classpath= new IClasspathEntry[nEntries]; // create and set the class path for (int i= 0; i < nEntries; i++) { CPListElement entry= ((CPListElement)classPathEntries.get(i)); IResource res= entry.getResource(); if ((res instanceof IFolder) && !res.exists()) { CoreUtility.createFolder((IFolder)res, true, true, null); } classpath[i]= entry.getClasspathEntry(); } monitor.worked(1); fCurrJProject.setRawClasspath(classpath, new SubProgressMonitor(monitor, 5)); updateReferencedProjects(fCurrJProject, prevRequiredProjects, new SubProgressMonitor(monitor, 1)); } // --------- project dependencies ----------- /** * @param jproject The Java project after changing the class path * @param prevRequiredProjects The required projects before changing the class path */ private static void updateReferencedProjects(IJavaProject jproject, String[] prevRequiredProjects, IProgressMonitor monitor) throws CoreException { String[] newRequiredProjects= jproject.getRequiredProjectNames(); ArrayList prevEntries= new ArrayList(Arrays.asList(prevRequiredProjects)); ArrayList newEntries= new ArrayList(Arrays.asList(newRequiredProjects)); IProject proj= jproject.getProject(); IProjectDescription projDesc= proj.getDescription(); ArrayList newRefs= new ArrayList(); IProject[] referencedProjects= projDesc.getReferencedProjects(); for (int i= 0; i < referencedProjects.length; i++) { String curr= referencedProjects[i].getName(); if (newEntries.remove(curr) || !prevEntries.contains(curr)) { newRefs.add(referencedProjects[i]); } } IWorkspaceRoot root= proj.getWorkspace().getRoot(); for (int i= 0; i < newEntries.size(); i++) { String curr= (String) newEntries.get(i); newRefs.add(root.getProject(curr)); } projDesc.setReferencedProjects((IProject[]) newRefs.toArray(new IProject[newRefs.size()])); proj.setDescription(projDesc, monitor); } /** * Adds a nature to a project */ private static void addNatureToProject(IProject proj, String natureId, IProgressMonitor monitor) throws CoreException { IProjectDescription description = proj.getDescription(); String[] prevNatures= description.getNatureIds(); String[] newNatures= new String[prevNatures.length + 1]; System.arraycopy(prevNatures, 0, newNatures, 0, prevNatures.length); newNatures[prevNatures.length]= natureId; description.setNatureIds(newNatures); proj.setDescription(description, monitor); } // ---------- util method ------------ private IContainer chooseContainer() { Class[] acceptedClasses= new Class[] { IProject.class, IFolder.class }; ISelectionValidator validator= new TypedElementSelectionValidator(acceptedClasses, false); IProject[] allProjects= fWorkspaceRoot.getProjects(); ArrayList rejectedElements= new ArrayList(allProjects.length); IProject currProject= fCurrJProject.getProject(); for (int i= 0; i < allProjects.length; i++) { if (!allProjects[i].equals(currProject)) { rejectedElements.add(allProjects[i]); } } ViewerFilter filter= new TypedViewerFilter(acceptedClasses, rejectedElements.toArray()); ILabelProvider lp= new WorkbenchLabelProvider(); ITreeContentProvider cp= new WorkbenchContentProvider(); IResource initSelection= null; if (fOutputLocationPath != null) { initSelection= fWorkspaceRoot.findMember(fOutputLocationPath); } ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), lp, cp); dialog.setTitle(NewWizardMessages.getString("BuildPathsBlock.ChooseOutputFolderDialog.title")); //$NON-NLS-1$ dialog.setValidator(validator); dialog.setMessage(NewWizardMessages.getString("BuildPathsBlock.ChooseOutputFolderDialog.description")); //$NON-NLS-1$ dialog.addFilter(filter); dialog.setInput(fWorkspaceRoot); dialog.setInitialSelection(initSelection); if (dialog.open() == dialog.OK) { return (IContainer)dialog.getFirstResult(); } return null; } // -------- tab switching ---------- private void tabChanged(Widget widget) { if (widget instanceof TabItem) { BuildPathBasePage newPage= (BuildPathBasePage) ((TabItem) widget).getData(); if (fCurrPage != null) { List selection= fCurrPage.getSelection(); if (!selection.isEmpty()) { newPage.setSelection(selection); } } fCurrPage= newPage; } } }
3,471
Bug 3471 Leading '/' in src page of Java wizard is misleading (1G842TH)
1. create new java project "jp" with Create Java Project wizard. 2. in wizard goto second ("Source") page Observe: the Build Output Folder is "/jp/bin" Since this looks like a Unix pathname I interpret the leading "/" as an indication for a absolute pathname. Other tools use something like: {WORKBENCH}/jp/bin or shell variable syntax: $WORKBENCH/jp/bin NOTES: EG (1/30/01 10:34:33 AM) desktop is using the same convention for presenting paths. General issue: how to show a workbench relative path
resolved wontfix
d8eedf7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T18:21:09Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards.buildpaths; import java.util.ArrayList; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.Path; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.ui.model.WorkbenchContentProvider; import org.eclipse.ui.model.WorkbenchLabelProvider; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.ISelectionValidator; import org.eclipse.jdt.internal.ui.util.SWTUtil; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; import org.eclipse.jdt.internal.ui.wizards.TypedElementSelectionValidator; import org.eclipse.jdt.internal.ui.wizards.TypedViewerFilter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IListAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.ListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringDialogField; import org.eclipse.jdt.internal.ui.wizards.swt.MGridData; import org.eclipse.jdt.internal.ui.wizards.swt.MGridLayout; public class SourceContainerWorkbookPage extends BuildPathBasePage { private ListDialogField fClassPathList; private IJavaProject fCurrJProject; private IPath fProjPath; private Control fSWTControl; private IWorkspaceRoot fWorkspaceRoot; private SelectionButtonDialogField fProjectRadioButton; private SelectionButtonDialogField fFolderRadioButton; private ListDialogField fFoldersList; private CPListElement fProjectCPEntry; private StringDialogField fOutputLocationField; private boolean fIsProjSelected; public SourceContainerWorkbookPage(IWorkspaceRoot root, ListDialogField classPathList, StringDialogField outputLocationField, boolean isNewProject) { fWorkspaceRoot= root; fClassPathList= classPathList; fProjectCPEntry= null; fOutputLocationField= outputLocationField; fSWTControl= null; SourceContainerAdapter adapter= new SourceContainerAdapter(); fProjectRadioButton= new SelectionButtonDialogField(SWT.RADIO); fProjectRadioButton.setDialogFieldListener(adapter); fProjectRadioButton.setLabelText(NewWizardMessages.getString("SourceContainerWorkbookPage.rb1.label")); //$NON-NLS-1$ fFolderRadioButton= new SelectionButtonDialogField(SWT.RADIO); fFolderRadioButton.setDialogFieldListener(adapter); fFolderRadioButton.setLabelText(NewWizardMessages.getString("SourceContainerWorkbookPage.rb2.label")); //$NON-NLS-1$ String[] buttonLabels; int removeIndex; if (isNewProject) { buttonLabels= new String[] { /* 0 */ NewWizardMessages.getString("SourceContainerWorkbookPage.folders.addnew.button"), //$NON-NLS-1$ /* 1 */ null, /* 2 */ NewWizardMessages.getString("SourceContainerWorkbookPage.folders.remove.button") //$NON-NLS-1$ }; removeIndex= 2; } else { buttonLabels= new String[] { /* 0 */ NewWizardMessages.getString("SourceContainerWorkbookPage.folders.addnew.button"), //$NON-NLS-1$ /* 1 */ NewWizardMessages.getString("SourceContainerWorkbookPage.folders.addnew.addexisting.button"), //$NON-NLS-1$ /* 2 */ null, /* 3 */ NewWizardMessages.getString("SourceContainerWorkbookPage.folders.remove.button") //$NON-NLS-1$ }; removeIndex= 3; } fFoldersList= new ListDialogField(adapter, buttonLabels, new CPListLabelProvider()); fFoldersList.setDialogFieldListener(adapter); fFoldersList.setLabelText(NewWizardMessages.getString("SourceContainerWorkbookPage.folders.label")); //$NON-NLS-1$ fFoldersList.setRemoveButtonIndex(removeIndex); fFolderRadioButton.attachDialogField(fFoldersList); } public void init(IJavaProject jproject) { fCurrJProject= jproject; fProjPath= fCurrJProject.getProject().getFullPath(); updateFoldersList(); } private void updateFoldersList() { fIsProjSelected= false; List srcelements= new ArrayList(fClassPathList.getSize()); List cpelements= fClassPathList.getElements(); for (int i= 0; i < cpelements.size(); i++) { CPListElement cpe= (CPListElement)cpelements.get(i); if (cpe.getEntryKind() == IClasspathEntry.CPE_SOURCE) { if (fProjPath.equals(cpe.getPath())) { srcelements.clear(); // remember the entry to ensure a unique CPListElement for the project-cpentry fProjectCPEntry= cpe; fIsProjSelected= true; break; } else { srcelements.add(cpe); } } } fFoldersList.setElements(srcelements); // fix for 1G47IYV: ITPJUI:WINNT - Both radio buttons get selected in Project properties fFolderRadioButton.setSelection(!fIsProjSelected); fProjectRadioButton.setSelection(fIsProjSelected); } public Control getControl(Composite parent) { Composite composite= new Composite(parent, SWT.NONE); MGridLayout layout= new MGridLayout(); layout.minimumWidth= SWTUtil.convertWidthInCharsToPixels(80, composite); layout.numColumns= 2; composite.setLayout(layout); fProjectRadioButton.doFillIntoGrid(composite, 2); fFolderRadioButton.doFillIntoGrid(composite, 2); Control control= fFoldersList.getListControl(composite); MGridData gd= new MGridData(MGridData.FILL_BOTH); gd.horizontalIndent= 10; control.setLayoutData(gd); control= fFoldersList.getButtonBox(composite); gd= new MGridData(gd.VERTICAL_ALIGN_FILL + gd.HORIZONTAL_ALIGN_FILL); control.setLayoutData(gd); int buttonBarWidth= SWTUtil.convertWidthInCharsToPixels(24, composite); fFoldersList.setButtonsMinWidth(buttonBarWidth); fFoldersList.getTableViewer().setSorter(new CPListElementSorter()); fSWTControl= composite; return composite; } private Shell getShell() { if (fSWTControl != null) { return fSWTControl.getShell(); } return JavaPlugin.getActiveWorkbenchShell(); } private class SourceContainerAdapter implements IListAdapter, IDialogFieldListener { // -------- IListAdapter -------- public void customButtonPressed(DialogField field, int index) { sourcePageCustomButtonPressed(field, index); } public void selectionChanged(DialogField field) {} // ---------- IDialogFieldListener -------- public void dialogFieldChanged(DialogField field) { sourcePageDialogFieldChanged(field); } } private void sourcePageCustomButtonPressed(DialogField field, int index) { if (field == fFoldersList) { List elementsToAdd= new ArrayList(10); switch (index) { case 0: /* add new */ CPListElement srcentry= createNewSourceContainer(); if (srcentry != null) { elementsToAdd.add(srcentry); } break; case 1: /* add existing */ CPListElement[] srcentries= chooseSourceContainers(); if (srcentries != null) { for (int i= 0; i < srcentries.length; i++) { elementsToAdd.add(srcentries[i]); } } break; } if (!elementsToAdd.isEmpty()) { fFoldersList.addElements(elementsToAdd); fFoldersList.postSetSelection(new StructuredSelection(elementsToAdd)); // if no source folders up to now if (fFoldersList.getSize() == elementsToAdd.size()) { askForChangingBuildPathDialog(); } } } } private void sourcePageDialogFieldChanged(DialogField field) { if (fCurrJProject == null) { // not initialized return; } if (field == fFolderRadioButton) { if (fFolderRadioButton.isSelected()) { fIsProjSelected= false; updateClasspathList(); if (fFoldersList.getSize() > 0) { askForChangingBuildPathDialog(); } } } else if (field == fProjectRadioButton) { if (fProjectRadioButton.isSelected()) { fIsProjSelected= true; updateClasspathList(); } } else if (field == fFoldersList) { updateClasspathList(); } } private void updateClasspathList() { List cpelements= fClassPathList.getElements(); List srcelements; if (fIsProjSelected) { srcelements= new ArrayList(1); if (fProjectCPEntry == null) { // never initialized before: create a new one fProjectCPEntry= newCPSourceElement(fCurrJProject.getProject()); } srcelements.add(fProjectCPEntry); } else { srcelements= fFoldersList.getElements(); } boolean changeDone= false; // backwards, as entries will be deleted for (int i= cpelements.size() - 1; i >= 0 ; i--) { CPListElement cpe= (CPListElement)cpelements.get(i); if (cpe.getEntryKind() == IClasspathEntry.CPE_SOURCE) { // if it is a source folder, but not one of the accepted entries, remove it // at the same time, for the entries seen, remove them from the accepted list if (!srcelements.remove(cpe)) { cpelements.remove(i); changeDone= true; } } } for (int i= 0; i < srcelements.size(); i++) { cpelements.add(srcelements.get(i)); } if (changeDone || (srcelements.size() > 0)) { fClassPathList.setElements(cpelements); } } private CPListElement createNewSourceContainer() { IProject proj= fCurrJProject.getProject(); String title= NewWizardMessages.getString("SourceContainerWorkbookPage.NewSourceFolderDialog.title"); //$NON-NLS-1$ NewContainerDialog dialog= new NewContainerDialog(getShell(), title, proj, getExistingContainers()); dialog.setMessage(NewWizardMessages.getFormattedString("SourceContainerWorkbookPage.NewSourceFolderDialog.description", fProjPath.toString())); //$NON-NLS-1$ if (dialog.open() == dialog.OK) { IFolder folder= dialog.getFolder(); return newCPSourceElement(folder); } return null; } /** * Asks to change the output folder to 'proj/bin' when no source folders were existing */ private void askForChangingBuildPathDialog() { IPath outputFolder= new Path(fOutputLocationField.getText()); if (outputFolder.equals(fCurrJProject.getProject().getFullPath())) { IPath newPath= outputFolder.append("bin"); String title= NewWizardMessages.getString("SourceContainerWorkbookPage.ChangeOutputLocationDialog.title"); //$NON-NLS-1$ String message= NewWizardMessages.getFormattedString("SourceContainerWorkbookPage.ChangeOutputLocationDialog.message", newPath); //$NON-NLS-1$ if (MessageDialog.openQuestion(getShell(), title, message)) { fOutputLocationField.setText(newPath.toString()); } } } private CPListElement[] chooseSourceContainers() { Class[] acceptedClasses= new Class[] { IFolder.class }; ISelectionValidator validator= new TypedElementSelectionValidator(acceptedClasses, true); acceptedClasses= new Class[] { IFolder.class }; ViewerFilter filter= new TypedViewerFilter(acceptedClasses, getExistingContainers()); ILabelProvider lp= new WorkbenchLabelProvider(); ITreeContentProvider cp= new WorkbenchContentProvider(); ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), lp, cp); dialog.setValidator(validator); dialog.setTitle(NewWizardMessages.getString("SourceContainerWorkbookPage.ExistingSourceFolderDialog.title")); //$NON-NLS-1$ dialog.setMessage(NewWizardMessages.getString("SourceContainerWorkbookPage.ExistingSourceFolderDialog.description")); //$NON-NLS-1$ dialog.addFilter(filter); dialog.setInput(fCurrJProject.getProject()); if (dialog.open() == dialog.OK) { Object[] elements= dialog.getResult(); CPListElement[] res= new CPListElement[elements.length]; for (int i= 0; i < res.length; i++) { IResource elem= (IResource)elements[i]; res[i]= newCPSourceElement(elem); } return res; } return null; } private IContainer[] getExistingContainers() { List res= new ArrayList(); List cplist= fFoldersList.getElements(); for (int i= 0; i < cplist.size(); i++) { CPListElement elem= (CPListElement)cplist.get(i); IResource resource= elem.getResource(); if (resource instanceof IContainer) { // defensive code res.add(resource); } } return (IContainer[]) res.toArray(new IContainer[res.size()]); } private CPListElement newCPSourceElement(IResource res) { Assert.isNotNull(res); return new CPListElement(IClasspathEntry.CPE_SOURCE, res.getFullPath(), res); } /* * @see BuildPathBasePage#getSelection */ public List getSelection() { if (fIsProjSelected) { ArrayList list= new ArrayList(1); list.add(fProjectCPEntry); return list; } else { return fFoldersList.getSelectedElements(); } } /* * @see BuildPathBasePage#setSelection */ public void setSelection(List selElements) { if (!fIsProjSelected) { filterSelection(selElements, IClasspathEntry.CPE_SOURCE); fFoldersList.selectElements(new StructuredSelection(selElements)); } } }
5,492
Bug 5492 Open in Hierarchy method list is enabled even when nothing is selected
206 1) Ensure no item is selected in the hierachy view's member list 2) Right click - not on an item 3) Open is present and enabled 4) Select Open, nothing happens
resolved fixed
0bf8b4b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T19:32:54Z"
"2001-11-02T19:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/MethodsViewer.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.typehierarchy; import java.util.Set; import org.eclipse.swt.SWT; import org.eclipse.swt.events.ControlAdapter; import org.eclipse.swt.events.ControlEvent; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Item; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.ScrollBar; import org.eclipse.swt.widgets.Table; import org.eclipse.swt.widgets.TableColumn; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.action.ToolBarManager; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.TableViewer; import org.eclipse.jface.viewers.Viewer; import org.eclipse.ui.IMemento; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchPartSite; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.actions.GenerateGroup; import org.eclipse.jdt.internal.ui.actions.OpenJavaElementAction; import org.eclipse.jdt.internal.ui.search.JavaSearchGroup; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.viewsupport.IProblemChangedListener; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementSorter; import org.eclipse.jdt.internal.ui.viewsupport.MarkerErrorTickProvider; import org.eclipse.jdt.internal.ui.viewsupport.ProblemItemMapper; /** * Method viewer shows a list of methods of a input type. * Offers filter actions. * No dependency to the type hierarchy view */ public class MethodsViewer extends TableViewer implements IProblemChangedListener { private ProblemItemMapper fProblemItemMapper; /** * Sorter that uses the unmodified labelprovider (No declaring class names) */ private static class MethodsViewerSorter extends JavaElementSorter { public MethodsViewerSorter() { } public int compare(Viewer viewer, Object e1, Object e2) { int cat1 = category(e1); int cat2 = category(e2); if (cat1 != cat2) return cat1 - cat2; // cat1 == cat2 String name1= JavaElementLabels.getElementLabel((IJavaElement) e1, JavaElementLabels.ALL_DEFAULT); String name2= JavaElementLabels.getElementLabel((IJavaElement) e2, JavaElementLabels.ALL_DEFAULT); return getCollator().compare(name1, name2); } } private static final String TAG_HIDEFIELDS= "hidefields"; //$NON-NLS-1$ private static final String TAG_HIDESTATIC= "hidestatic"; //$NON-NLS-1$ private static final String TAG_HIDENONPUBLIC= "hidenonpublic"; //$NON-NLS-1$ private static final String TAG_SHOWINHERITED= "showinherited"; //$NON-NLS-1$ private static final String TAG_VERTICAL_SCROLL= "mv_vertical_scroll"; //$NON-NLS-1$ private MethodsViewerFilterAction[] fFilterActions; private MethodsViewerFilter fFilter; private OpenJavaElementAction fOpen; private TableColumn fTableColumn; private ShowInheritedMembersAction fShowInheritedMembersAction; private ContextMenuGroup[] fStandardGroups; public MethodsViewer(Composite parent, IWorkbenchPart part) { super(new Table(parent, SWT.MULTI)); fProblemItemMapper= new ProblemItemMapper(); fTableColumn= new TableColumn(getTable(), SWT.NULL | SWT.MULTI | SWT.FULL_SELECTION); getTable().addControlListener(new ControlAdapter() { public void controlResized(ControlEvent e) { adjustTableColumnSize(); } }); JavaElementLabelProvider lprovider= new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT); lprovider.setErrorTickManager(new MarkerErrorTickProvider()); MethodsContentProvider contentProvider= new MethodsContentProvider(); setLabelProvider(lprovider); setContentProvider(contentProvider); fOpen= new OpenJavaElementAction(this); addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent event) { fOpen.run(); } }); fFilter= new MethodsViewerFilter(); // fields String title= TypeHierarchyMessages.getString("MethodsViewer.hide_fields.label"); //$NON-NLS-1$ String helpContext= IJavaHelpContextIds.FILTER_FIELDS_ACTION; MethodsViewerFilterAction hideFields= new MethodsViewerFilterAction(this, title, MethodsViewerFilter.FILTER_FIELDS, helpContext, false); hideFields.setDescription(TypeHierarchyMessages.getString("MethodsViewer.hide_fields.description")); //$NON-NLS-1$ hideFields.setToolTipChecked(TypeHierarchyMessages.getString("MethodsViewer.hide_fields.tooltip.checked")); //$NON-NLS-1$ hideFields.setToolTipUnchecked(TypeHierarchyMessages.getString("MethodsViewer.hide_fields.tooltip.unchecked")); //$NON-NLS-1$ JavaPluginImages.setLocalImageDescriptors(hideFields, "fields_co.gif"); //$NON-NLS-1$ // static title= TypeHierarchyMessages.getString("MethodsViewer.hide_static.label"); //$NON-NLS-1$ helpContext= IJavaHelpContextIds.FILTER_STATIC_ACTION; MethodsViewerFilterAction hideStatic= new MethodsViewerFilterAction(this, title, MethodsViewerFilter.FILTER_STATIC, helpContext, false); hideStatic.setDescription(TypeHierarchyMessages.getString("MethodsViewer.hide_static.description")); //$NON-NLS-1$ hideStatic.setToolTipChecked(TypeHierarchyMessages.getString("MethodsViewer.hide_static.tooltip.checked")); //$NON-NLS-1$ hideStatic.setToolTipUnchecked(TypeHierarchyMessages.getString("MethodsViewer.hide_static.tooltip.unchecked")); //$NON-NLS-1$ JavaPluginImages.setLocalImageDescriptors(hideStatic, "static_co.gif"); //$NON-NLS-1$ // non-public title= TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.label"); //$NON-NLS-1$ helpContext= IJavaHelpContextIds.FILTER_PUBLIC_ACTION; MethodsViewerFilterAction hideNonPublic= new MethodsViewerFilterAction(this, title, MethodsViewerFilter.FILTER_NONPUBLIC, helpContext, false); hideNonPublic.setDescription(TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.description")); //$NON-NLS-1$ hideNonPublic.setToolTipChecked(TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.tooltip.checked")); //$NON-NLS-1$ hideNonPublic.setToolTipUnchecked(TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.tooltip.unchecked")); //$NON-NLS-1$ JavaPluginImages.setLocalImageDescriptors(hideNonPublic, "public_co.gif"); //$NON-NLS-1$ // order corresponds to order in toolbar fFilterActions= new MethodsViewerFilterAction[] { hideFields, hideStatic, hideNonPublic }; addFilter(fFilter); fShowInheritedMembersAction= new ShowInheritedMembersAction(this, false); showInheritedMethods(false); fStandardGroups= new ContextMenuGroup[] { new JavaSearchGroup(), new GenerateGroup() }; setSorter(new MethodsViewerSorter()); } /** * Show inherited methods */ public void showInheritedMethods(boolean on) { MethodsContentProvider cprovider= (MethodsContentProvider) getContentProvider(); try { cprovider.showInheritedMethods(on); fShowInheritedMembersAction.setChecked(on); JavaElementLabelProvider lprovider= (JavaElementLabelProvider) getLabelProvider(); if (on) { lprovider.turnOn(JavaElementLabelProvider.SHOW_POST_QUALIFIED); } else { lprovider.turnOff(JavaElementLabelProvider.SHOW_POST_QUALIFIED); } refresh(); adjustTableColumnSize(); } catch (JavaModelException e) { ExceptionHandler.handle(e, getControl().getShell(), TypeHierarchyMessages.getString("MethodsViewer.toggle.error.title"), TypeHierarchyMessages.getString("MethodsViewer.toggle.error.message")); //$NON-NLS-2$ //$NON-NLS-1$ } } private void adjustTableColumnSize() { if (fTableColumn != null && !fTableColumn.isDisposed()) { fTableColumn.pack(); } } /* * @see Viewer#inputChanged(Object, Object) */ protected void inputChanged(Object input, Object oldInput) { super.inputChanged(input, oldInput); adjustTableColumnSize(); } /** * Returns <code>true</code> if inherited methods are shown. */ public boolean isShowInheritedMethods() { return ((MethodsContentProvider) getContentProvider()).isShowInheritedMethods(); } /** * Filters the method list */ public void setMemberFilter(int filterProperty, boolean set) { if (set) { fFilter.addFilter(filterProperty); } else { fFilter.removeFilter(filterProperty); } for (int i= 0; i < fFilterActions.length; i++) { if (fFilterActions[i].getFilterProperty() == filterProperty) { fFilterActions[i].setChecked(set); } } refresh(); } /** * Returns <code>true</code> if the given filter is set. */ public boolean hasMemberFilter(int filterProperty) { return fFilter.hasFilter(filterProperty); } /** * Saves the state of the filter actions */ public void saveState(IMemento memento) { memento.putString(TAG_HIDEFIELDS, String.valueOf(hasMemberFilter(MethodsViewerFilter.FILTER_FIELDS))); memento.putString(TAG_HIDESTATIC, String.valueOf(hasMemberFilter(MethodsViewerFilter.FILTER_STATIC))); memento.putString(TAG_HIDENONPUBLIC, String.valueOf(hasMemberFilter(MethodsViewerFilter.FILTER_NONPUBLIC))); memento.putString(TAG_SHOWINHERITED, String.valueOf(isShowInheritedMethods())); ScrollBar bar= getTable().getVerticalBar(); int position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_VERTICAL_SCROLL, String.valueOf(position)); } /** * Restores the state of the filter actions */ public void restoreState(IMemento memento) { boolean set= Boolean.valueOf(memento.getString(TAG_HIDEFIELDS)).booleanValue(); setMemberFilter(MethodsViewerFilter.FILTER_FIELDS, set); set= Boolean.valueOf(memento.getString(TAG_HIDESTATIC)).booleanValue(); setMemberFilter(MethodsViewerFilter.FILTER_STATIC, set); set= Boolean.valueOf(memento.getString(TAG_HIDENONPUBLIC)).booleanValue(); setMemberFilter(MethodsViewerFilter.FILTER_NONPUBLIC, set); set= Boolean.valueOf(memento.getString(TAG_SHOWINHERITED)).booleanValue(); showInheritedMethods(set); ScrollBar bar= getTable().getVerticalBar(); if (bar != null) { Integer vScroll= memento.getInteger(TAG_VERTICAL_SCROLL); if (vScroll != null) { bar.setSelection(vScroll.intValue()); } } } /** * Attaches a contextmenu listener to the table */ public void initContextMenu(IMenuListener menuListener, String popupId, IWorkbenchPartSite viewSite) { MenuManager menuMgr= new MenuManager(); menuMgr.setRemoveAllWhenShown(true); menuMgr.addMenuListener(menuListener); Menu menu= menuMgr.createContextMenu(getTable()); getTable().setMenu(menu); viewSite.registerContextMenu(popupId, menuMgr, this); } /** * Fills up the context menu with items for the method viewer * Should be called by the creator of the context menu */ public void contributeToContextMenu(IMenuManager menu) { menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, fOpen); ContextMenuGroup.add(menu, fStandardGroups, this); } /** * Fills up the tool bar with items for the method viewer * Should be called by the creator of the tool bar */ public void contributeToToolBar(ToolBarManager tbm) { tbm.add(fShowInheritedMembersAction); tbm.add(new Separator()); tbm.add(fFilterActions[0]); // fields tbm.add(fFilterActions[1]); // static tbm.add(fFilterActions[2]); // public } /* * @see IProblemChangedListener#problemsChanged */ public void problemsChanged(final Set changed) { Control control= getControl(); if (control != null && !control.isDisposed()) { control.getDisplay().asyncExec(new Runnable() { public void run() { fProblemItemMapper.problemsChanged(changed, (ILabelProvider)getLabelProvider()); } }); } } /* * @see StructuredViewer#associate(Object, Item) */ protected void associate(Object element, Item item) { if (item.getData() != element) { fProblemItemMapper.addToMap(element, item); } super.associate(element, item); } /* * @see StructuredViewer#disassociate(Item) */ protected void disassociate(Item item) { fProblemItemMapper.removeFromMap(item.getData(), item); super.disassociate(item); } }
5,492
Bug 5492 Open in Hierarchy method list is enabled even when nothing is selected
206 1) Ensure no item is selected in the hierachy view's member list 2) Right click - not on an item 3) Open is present and enabled 4) Select Open, nothing happens
resolved fixed
0bf8b4b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T19:32:54Z"
"2001-11-02T19:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewer.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.typehierarchy; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.Tree; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IContentProvider; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.IStructuredContentProvider; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchPartSite; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.actions.GenerateGroup; import org.eclipse.jdt.internal.ui.actions.OpenJavaElementAction; import org.eclipse.jdt.internal.ui.actions.ShowInPackageViewAction; import org.eclipse.jdt.internal.ui.search.JavaSearchGroup; import org.eclipse.jdt.internal.ui.viewsupport.IProblemChangedListener; import org.eclipse.jdt.internal.ui.viewsupport.MarkerErrorTickProvider; import org.eclipse.jdt.internal.ui.viewsupport.ProblemTreeViewer; import org.eclipse.jdt.internal.ui.wizards.NewGroup; public abstract class TypeHierarchyViewer extends ProblemTreeViewer implements IProblemChangedListener { private OpenJavaElementAction fOpen; private ShowInPackageViewAction fShowInPackageViewAction; private ContextMenuGroup[] fStandardGroups; public TypeHierarchyViewer(Composite parent, IContentProvider contentProvider, ILabelProvider lprovider, IWorkbenchPart part) { super(new Tree(parent, SWT.SINGLE)); setContentProvider(contentProvider); setLabelProvider(lprovider); setSorter(new ViewerSorter() { public boolean isSorterProperty(Object element, Object property) { return true; } public int category(Object element) { if (element instanceof IType) { try { return (((IType)element).isInterface()) ? 2 : 1; } catch (JavaModelException e) { } } else if (element instanceof IMember) { return 0; } return 3; } }); fOpen= new OpenJavaElementAction(this); addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent event) { fOpen.run(); } }); fShowInPackageViewAction= new ShowInPackageViewAction(); fStandardGroups= new ContextMenuGroup[] { new JavaSearchGroup(), new NewGroup(), new GenerateGroup() }; } /** * Attaches a contextmenu listener to the tree */ public void initContextMenu(IMenuListener menuListener, String popupId, IWorkbenchPartSite viewSite) { MenuManager menuMgr= new MenuManager(); menuMgr.setRemoveAllWhenShown(true); menuMgr.addMenuListener(menuListener); Menu menu= menuMgr.createContextMenu(getTree()); getTree().setMenu(menu); viewSite.registerContextMenu(popupId, menuMgr, this); } /** * Fills up the context menu with items for the hierarchy viewer * Should be called by the creator of the context menu */ public void contributeToContextMenu(IMenuManager menu) { menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, fOpen); // XXX need to decide when to contribute the Show in PackagesView action // if (fShowInPackageViewAction.canOperateOn()) menu.appendToGroup(IContextMenuConstants.GROUP_SHOW, fShowInPackageViewAction); ContextMenuGroup.add(menu, fStandardGroups, this); } /** * Set the member filter */ public void setMemberFilter(IMember[] memberFilter) { getHierarchyContentProvider().setMemberFilter(memberFilter); } /** * Returns if method filtering is enabled. */ public boolean isMethodFiltering() { return getHierarchyContentProvider().getMemberFilter() != null; } /** * Returns true if the hierarchy contains elements. Returns one of them * With member filtering it is possible that no elements are visible */ public Object containsElements() { Object[] elements= ((IStructuredContentProvider)getContentProvider()).getElements(null); if (elements.length > 0) { return elements[0]; } return null; } /** * Returns true if the hierarchy contains element the element. */ public boolean isElementShown(Object element) { return findItem(element) != null; } /** * Updates the content of this viewer: refresh and expanding the tree in the way wanted. */ public abstract void updateContent(); /** * Returns the title for the current view */ public abstract String getTitle(); /* * @see StructuredViewer#setContentProvider * Content provider must be of type TypeHierarchyContentProvider */ public void setContentProvider(IContentProvider cp) { Assert.isTrue(cp instanceof TypeHierarchyContentProvider); super.setContentProvider(cp); } protected TypeHierarchyContentProvider getHierarchyContentProvider() { return (TypeHierarchyContentProvider)getContentProvider(); } }
4,937
Bug 4937 Display view contents not restored properly
Exit a workspace with a display view present that has content with formatting. When the workspace starts up and the display is viewed, the restored content will have lost the formatting.
verified fixed
f9ed641
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T20:35:09Z"
"2001-10-12T18:06:40Z"
org.eclipse.jdt.ui/ui
4,937
Bug 4937 Display view contents not restored properly
Exit a workspace with a display view present that has content with formatting. When the workspace starts up and the display is viewed, the restored content will have lost the formatting.
verified fixed
f9ed641
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T20:35:09Z"
"2001-10-12T18:06:40Z"
debug/org/eclipse/jdt/internal/debug/ui/display/DisplayView.java
3,883
Bug 3883 error dialog in display is too scary (1GF24YQ)
AK (6/9/01 4:25:35 PM) press the display or the inspect buttons in the display view (with no stack frame context) you see an Error dialog. these should be reserved for really error conditions - like internal errors. NOTES: EG (6/9/2001 12:03:13 PM) not critical
verified fixed
37812f0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T22:32:33Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui
3,883
Bug 3883 error dialog in display is too scary (1GF24YQ)
AK (6/9/01 4:25:35 PM) press the display or the inspect buttons in the display view (with no stack frame context) you see an Error dialog. these should be reserved for really error conditions - like internal errors. NOTES: EG (6/9/2001 12:03:13 PM) not critical
verified fixed
37812f0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-12T22:32:33Z"
"2001-10-11T03:13:20Z"
debug/org/eclipse/jdt/internal/debug/ui/display/DisplayView.java
3,770
Bug 3770 Java Preference page needs better grouping (1GERREW)
EG (6/3/2001 1:57:32 PM) the Java preference page needs space between the different groups. Package view related prefs should come together. There should be whitespace before the hierarchy preference setting. NOTES: EG (6/4/2001 12:00:42 PM) adding white space is work since we are using the preference dialog fields. This is not critcal, but the order of the packages view prefs should change. EG (6/5/2001 9:56:40 AM) defer
resolved fixed
c1e5823
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-13T14:45:02Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaBasePreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ // AW package org.eclipse.jdt.internal.ui.preferences; import org.eclipse.swt.widgets.Composite; import org.eclipse.jface.preference.BooleanFieldEditor; import org.eclipse.jface.preference.FieldEditorPreferencePage; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.RadioGroupFieldEditor; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.IPreferencesConstants; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; /* * The page for setting java plugin preferences. */ public class JavaBasePreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage { public JavaBasePreferencePage() { super(GRID); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(JavaUIMessages.getString("JavaBasePreferencePage.description")); //$NON-NLS-1$ } public static void initDefaults(IPreferenceStore store) { store.setDefault(IPreferencesConstants.LINK_PACKAGES_TO_EDITOR, true); store.setDefault(IPreferencesConstants.SHOW_CU_CHILDREN, true); store.setDefault(IPreferencesConstants.LINK_TYPEHIERARCHY_TO_EDITOR, false); store.setDefault(IPreferencesConstants.OPEN_TYPE_HIERARCHY, IPreferencesConstants.OPEN_TYPE_HIERARCHY_IN_VIEW_PART); store.setDefault(IPreferencesConstants.SRCBIN_FOLDERS_IN_NEWPROJ, false); store.setDefault(IPreferencesConstants.DOUBLE_CLICK_GOES_INTO, false); } /** * @see PreferencePage#createControl(Composite) */ public void createControl(Composite parent) { // added for 1GEUGE6: ITPJUI:WIN2000 - Help is the same on all preference pages super.createControl(parent); WorkbenchHelp.setHelp(getControl(), new DialogPageContextComputer(this, IJavaHelpContextIds.JAVA_BASE_PREFERENCE_PAGE)); } protected void createFieldEditors() { Composite parent= getFieldEditorParent(); BooleanFieldEditor boolEditor= new BooleanFieldEditor( IPreferencesConstants.LINK_PACKAGES_TO_EDITOR, JavaUIMessages.getString("JavaBasePreferencePage.linkPackageView"), //$NON-NLS-1$ parent ); addField(boolEditor); boolEditor= new BooleanFieldEditor( IPreferencesConstants.LINK_TYPEHIERARCHY_TO_EDITOR, JavaUIMessages.getString("JavaBasePreferencePage.linkTypeHierarchy"), //$NON-NLS-1$ parent ); addField(boolEditor); boolEditor= new BooleanFieldEditor( IPreferencesConstants.DOUBLE_CLICK_GOES_INTO, JavaUIMessages.getString("JavaBasePreferencePage.dblClick"), //$NON-NLS-1$ parent ); addField(boolEditor); boolEditor= new BooleanFieldEditor( IPreferencesConstants.SHOW_CU_CHILDREN, JavaUIMessages.getString("JavaBasePreferencePage.cuChildren"), //$NON-NLS-1$ parent ); addField(boolEditor); boolEditor= new BooleanFieldEditor( IPreferencesConstants.SRCBIN_FOLDERS_IN_NEWPROJ, JavaUIMessages.getString("JavaBasePreferencePage.folders"), //$NON-NLS-1$ parent ); addField(boolEditor); RadioGroupFieldEditor editor= new RadioGroupFieldEditor( IPreferencesConstants.OPEN_TYPE_HIERARCHY, JavaUIMessages.getString("JavaBasePreferencePage.openTypeHierarchy"), //$NON-NLS-1$ 1, new String[][] { {JavaUIMessages.getString("JavaBasePreferencePage.inPerspective"), IPreferencesConstants.OPEN_TYPE_HIERARCHY_IN_PERSPECTIVE}, //$NON-NLS-1$ {JavaUIMessages.getString("JavaBasePreferencePage.inView"), IPreferencesConstants.OPEN_TYPE_HIERARCHY_IN_VIEW_PART} //$NON-NLS-1$ }, parent); addField(editor); } public void init(IWorkbench workbench) { } public static boolean useSrcAndBinFolders() { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); return store.getBoolean(IPreferencesConstants.SRCBIN_FOLDERS_IN_NEWPROJ); } public static boolean linkPackageSelectionToEditor() { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); return store.getBoolean(IPreferencesConstants.LINK_PACKAGES_TO_EDITOR); } public static boolean showCompilationUnitChildren() { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); return store.getBoolean(IPreferencesConstants.SHOW_CU_CHILDREN); } public static boolean linkTypeHierarchySelectionToEditor() { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); return store.getBoolean(IPreferencesConstants.LINK_TYPEHIERARCHY_TO_EDITOR); } public static boolean openTypeHierarchyInPerspective() { return IPreferencesConstants.OPEN_TYPE_HIERARCHY_IN_PERSPECTIVE.equals( JavaPlugin.getDefault().getPreferenceStore().getString(IPreferencesConstants.OPEN_TYPE_HIERARCHY)); } public static boolean openTypeHierarchInViewPart() { return IPreferencesConstants.OPEN_TYPE_HIERARCHY_IN_VIEW_PART.equals( JavaPlugin.getDefault().getPreferenceStore().getString(IPreferencesConstants.OPEN_TYPE_HIERARCHY)); } public static boolean doubleClockGoesInto() { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); return store.getBoolean(IPreferencesConstants.DOUBLE_CLICK_GOES_INTO); } }
3,770
Bug 3770 Java Preference page needs better grouping (1GERREW)
EG (6/3/2001 1:57:32 PM) the Java preference page needs space between the different groups. Package view related prefs should come together. There should be whitespace before the hierarchy preference setting. NOTES: EG (6/4/2001 12:00:42 PM) adding white space is work since we are using the preference dialog fields. This is not critcal, but the order of the packages view prefs should change. EG (6/5/2001 9:56:40 AM) defer
resolved fixed
c1e5823
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-13T14:45:02Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/SpacerFieldEditor.java
5,832
Bug 5832 Template Pref page: Edit: Copy/paste context menu
The text field to edit the templates should have a context menu with copy/paste.
resolved fixed
783cbe5
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-13T17:08:59Z"
"2001-11-13T11:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/EditTemplateDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.graphics.Font; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Combo; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Text; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.DocumentEvent; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IDocumentListener; import org.eclipse.jface.text.contentassist.IContentAssistant; import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.window.Window; import org.eclipse.ui.texteditor.ITextEditor; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.StatusDialog; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.text.template.Template; import org.eclipse.jdt.internal.ui.text.template.TemplateCollector; import org.eclipse.jdt.internal.ui.text.template.TemplateContext; import org.eclipse.jdt.internal.ui.text.template.TemplateInterpolator; import org.eclipse.jdt.internal.ui.text.template.TemplateMessages; import org.eclipse.jdt.internal.ui.text.template.TemplateVariableDialog; import org.eclipse.jdt.internal.ui.text.template.VariableEvaluator; import org.eclipse.jdt.internal.ui.util.SWTUtil; /** * Dialog to edit a template. */ public class EditTemplateDialog extends StatusDialog { // disable content assist private static class SimpleJavaSourceViewerConfiguration extends JavaSourceViewerConfiguration { SimpleJavaSourceViewerConfiguration(JavaTextTools tools, ITextEditor editor) { super(tools, editor); } /* * @see SourceViewerConfiguration#getContentAssistant(ISourceViewer) */ public IContentAssistant getContentAssistant(ISourceViewer sourceViewer) { return null; } } private static class TemplateVerifier implements VariableEvaluator { private String fErrorMessage; private boolean fHasAdjacentVariables; private boolean fEndsWithVariable; public void reset() { fErrorMessage= null; fHasAdjacentVariables= false; fEndsWithVariable= false; } public void acceptError(String message) { if (fErrorMessage == null) fErrorMessage= message; } public void acceptText(String text) { if (text.length() > 0) fEndsWithVariable= false; } public void acceptVariable(String variable) { if (fEndsWithVariable) fHasAdjacentVariables= true; fEndsWithVariable= true; } public boolean hasErrors() { return fHasAdjacentVariables || (fErrorMessage != null); } public String getErrorMessage() { if (fHasAdjacentVariables) return TemplateMessages.getString("EditTemplateDialog.error.adjacent.variables"); //$NON-NLS-1$ return fErrorMessage; } } private Template fTemplate; private Text fNameText; private Text fDescriptionText; private Combo fContextCombo; private SourceViewer fPatternEditor; private Button fInsertVariableButton; private TemplateInterpolator fInterpolator= new TemplateInterpolator(); private TemplateVerifier fVerifier= new TemplateVerifier(); private boolean fSuppressError= true; // #4354 public EditTemplateDialog(Shell parent, Template template, boolean edit) { super(parent); if (edit) setTitle(TemplateMessages.getString("EditTemplateDialog.title.edit")); else setTitle(TemplateMessages.getString("EditTemplateDialog.title.new")); fTemplate= template; } /* * @see Dialog#createDialogArea(Composite) */ protected Control createDialogArea(Composite ancestor) { Composite parent= new Composite(ancestor, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; parent.setLayout(layout); parent.setLayoutData(new GridData(GridData.FILL_BOTH)); createLabel(parent, TemplateMessages.getString("EditTemplateDialog.name")); //$NON-NLS-1$ Composite composite= new Composite(parent, SWT.NONE); composite.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); layout= new GridLayout(); layout.numColumns= 3; layout.marginWidth= 0; layout.marginHeight= 0; composite.setLayout(layout); fNameText= createText(composite); fNameText.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { if (fSuppressError && (fNameText.getText().trim().length() != 0)) fSuppressError= false; updateButtons(); } }); createLabel(composite, TemplateMessages.getString("EditTemplateDialog.context")); //$NON-NLS-1$ fContextCombo= new Combo(composite, SWT.READ_ONLY); fContextCombo.setItems(new String[] {TemplateContext.JAVA, TemplateContext.JAVADOC}); createLabel(parent, TemplateMessages.getString("EditTemplateDialog.description")); //$NON-NLS-1$ fDescriptionText= createText(parent); composite= new Composite(parent, SWT.NONE); composite.setLayoutData(new GridData(GridData.FILL_VERTICAL)); layout= new GridLayout(); layout.marginWidth= 0; layout.marginHeight= 0; composite.setLayout(layout); Label patternLabel= createLabel(composite, TemplateMessages.getString("EditTemplateDialog.pattern")); //$NON-NLS-1$ fPatternEditor= createEditor(parent); Label filler= new Label(composite, SWT.NONE); filler.setLayoutData(new GridData(GridData.FILL_VERTICAL)); fInsertVariableButton= new Button(composite, SWT.NONE); fInsertVariableButton.setLayoutData(getButtonGridData(fInsertVariableButton)); fInsertVariableButton.setText(TemplateMessages.getString("EditTemplateDialog.insert.variable")); //$NON-NLS-1$ fInsertVariableButton.addSelectionListener(new SelectionListener() { public void widgetSelected(SelectionEvent e) { insertVariable(); } public void widgetDefaultSelected(SelectionEvent e) {} }); // initialize fields fNameText.setText(fTemplate.getName()); fDescriptionText.setText(fTemplate.getDescription()); fContextCombo.select(getIndex(fTemplate.getContext())); fPatternEditor.getDocument().set(fTemplate.getPattern()); return composite; } private static GridData getButtonGridData(Button button) { GridData data= new GridData(GridData.FILL_HORIZONTAL); data.heightHint= SWTUtil.getButtonHeigthHint(button); return data; } private static Label createLabel(Composite parent, String name) { Label label= new Label(parent, SWT.NULL); label.setText(name); label.setLayoutData(new GridData()); return label; } private static Text createText(Composite parent) { Text text= new Text(parent, SWT.BORDER); text.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); return text; } private SourceViewer createEditor(Composite parent) { SourceViewer viewer= new SourceViewer(parent, null, SWT.BORDER | SWT.V_SCROLL | SWT.H_SCROLL); JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); viewer.configure(new SimpleJavaSourceViewerConfiguration(tools, null)); viewer.setEditable(true); IDocument document= new Document(); document.addDocumentListener(new IDocumentListener() { public void documentAboutToBeChanged(DocumentEvent event) {} public void documentChanged(DocumentEvent event) { fInterpolator.interpolate(event.getDocument().get(), fVerifier); updateButtons(); } }); viewer.setDocument(document); Font font= JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT); viewer.getTextWidget().setFont(font); Control control= viewer.getControl(); GridData data= new GridData(GridData.FILL_BOTH); data.widthHint= convertWidthInCharsToPixels(60); data.heightHint= convertHeightInCharsToPixels(5); control.setLayoutData(data); return viewer; } private static int getIndex(String context) { if (context.equals(TemplateContext.JAVA)) return 0; else if (context.equals(TemplateContext.JAVADOC)) return 1; else return -1; } protected void okPressed() { // read back fields fTemplate.setName(fNameText.getText()); fTemplate.setDescription(fDescriptionText.getText()); fTemplate.setContext(fContextCombo.getText()); fTemplate.setPattern(fPatternEditor.getTextWidget().getText()); super.okPressed(); } private void updateButtons() { boolean valid= fNameText.getText().trim().length() != 0; StatusInfo status= new StatusInfo(); if (!valid) { if (fSuppressError) status.setError(""); //$NON-NLS-1$ else status.setError(TemplateMessages.getString("EditTemplateDialog.error.noname")); //$NON-NLS-1$ } else if (fVerifier.hasErrors()) { status.setError(fVerifier.getErrorMessage()); } updateStatus(status); } private void insertVariable() { TemplateVariableDialog dialog= new TemplateVariableDialog(getShell(), TemplateCollector.getVariables()); if (dialog.open() == Window.OK) { String variable= "${" + dialog.getSelectedName() + "}"; //$NON-NLS-1$ //$NON-NLS-2$ StyledText text= fPatternEditor.getTextWidget(); Point selection= text.getSelection(); text.replaceTextRange(selection.x, selection.y - selection.x, variable); int caretOffset= selection.x + variable.length(); text.setSelection(caretOffset, caretOffset); } } }
5,791
Bug 5791 NPE in SocketUtil
Launch Eclipse using JDK 1.4 as JRE. From the launched eclispe, launch another program in debug mode, using JDK 1.4. This produces an NPE in SocketUtil: java.lang.reflect.InvocationTargetException at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:277) at org.eclipse.jface.dialogs.ProgressMonitorDialog.run (ProgressMonitorDialog.java:335) at org.eclipse.jdt.internal.ui.launcher.JavaApplicationLauncherDelegate.doLaunch (JavaApplicationLauncherDelegate.java:181) at org.eclipse.jdt.internal.ui.launcher.JavaApplicationLauncherDelegate.launchEleme nt(JavaApplicationLauncherDelegate.java:81) at org.eclipse.jdt.internal.ui.launcher.JavaApplicationLauncherDelegate.launch (JavaApplicationLauncherDelegate.java:93) at org.eclipse.debug.internal.core.Launcher.launch(Launcher.java:104) at org.eclipse.debug.internal.ui.RelaunchActionDelegate.relaunch (RelaunchActionDelegate.java:37) at org.eclipse.debug.internal.ui.RelaunchActionDelegate.relaunch (RelaunchActionDelegate.java:46) at org.eclipse.debug.internal.ui.RelaunchHistoryLaunchAction$1.run (RelaunchHistoryLaunchAction.java:49) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:56) at org.eclipse.debug.internal.ui.RelaunchHistoryLaunchAction.run (RelaunchHistoryLaunchAction.java:47) at org.eclipse.jface.action.Action.runWithEvent(Action.java:453) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:54) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:635) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1365) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1167) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:727) at org.eclipse.ui.internal.Workbench.run(Workbench.java:710) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at SlimLauncher.main(SlimLauncher.java:14) Caused by: java.lang.NullPointerException at java.net.Socket.<init>(Socket.java:285) at java.net.Socket.<init>(Socket.java:121) at org.eclipse.jdt.internal.ui.launcher.SocketUtil.findUnusedLocalPort (SocketUtil.java:21) at org.eclipse.jdt.internal.ui.launcher.JDK12DebugLauncher.run (JDK12DebugLauncher.java:60) at org.eclipse.jdt.internal.ui.launcher.JavaApplicationLauncherDelegate$1.run (JavaApplicationLauncherDelegate.java:170) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run (ModalContext.java:98)
verified fixed
504d14b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T00:40:20Z"
"2001-11-12T15:46:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/launcher/JDK12DebugLauncher.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.launcher; import java.io.File; import java.io.IOException; import java.io.InterruptedIOException; import java.util.List; import java.util.Map; import java.util.Vector; import org.eclipse.core.runtime.CoreException; import org.eclipse.debug.core.DebugPlugin; import org.eclipse.debug.core.model.IDebugTarget; import org.eclipse.debug.core.model.IProcess; import org.eclipse.jdi.Bootstrap; import org.eclipse.jdt.debug.core.JDIDebugModel; import org.eclipse.jdt.launching.IVMInstall; import org.eclipse.jdt.launching.JavaRuntime; import org.eclipse.jdt.launching.VMRunnerConfiguration; import org.eclipse.jdt.launching.VMRunnerResult; import com.sun.jdi.VirtualMachine; import com.sun.jdi.connect.Connector; import com.sun.jdi.connect.IllegalConnectorArgumentsException; import com.sun.jdi.connect.ListeningConnector; import com.sun.jdi.connect.Connector.IntegerArgument; /** * A launcher for running java main classes. Uses JDI to launch a vm in debug * mode. */ public class JDK12DebugLauncher extends JDK12Launcher { public interface IRetryQuery { boolean queryRetry(); } private IRetryQuery fRetryQuery; /** * Creates a new lauchner */ public JDK12DebugLauncher(IVMInstall vmInstance, IRetryQuery query) { super(vmInstance); fRetryQuery= query; } /** * @see IVMRunner#run */ public VMRunnerResult run(VMRunnerConfiguration config) throws CoreException { int port= SocketUtil.findUnusedLocalPort(null, 5000, 15000); if (port == -1) { throw new CoreException(createStatus(LauncherMessages.getString("jdkLauncher.noPort"), null)); //$NON-NLS-1$ } String location= getJDKLocation(""); //$NON-NLS-1$ if ("".equals(location)) { //$NON-NLS-1$ throw new CoreException(createStatus(LauncherMessages.getString("jdkLauncher.error.noJDKHome"), null)); //$NON-NLS-1$ } String program= location+File.separator+"bin"+File.separator+"java"; //$NON-NLS-2$ //$NON-NLS-1$ File javawexe= new File(program+"w.exe"); //$NON-NLS-1$ File javaw= new File(program+"w"); //$NON-NLS-1$ if (javaw.isFile()) program= javaw.getAbsolutePath(); else if (javawexe.isFile()) program= javawexe.getAbsolutePath(); Vector arguments= new Vector(); arguments.addElement(program); String[] bootCP= config.getBootClassPath(); if (bootCP.length > 0) { arguments.add("-Xbootclasspath:"+convertClassPath(bootCP)); //$NON-NLS-1$ } String[] cp= config.getClassPath(); if (cp.length > 0) { arguments.add("-classpath"); //$NON-NLS-1$ arguments.add(convertClassPath(cp)); } addArguments(config.getVMArguments(), arguments); arguments.add("-Xdebug"); //$NON-NLS-1$ arguments.add("-Xnoagent"); //$NON-NLS-1$ arguments.add("-Djava.compiler=NONE"); //$NON-NLS-1$ arguments.add("-Xrunjdwp:transport=dt_socket,address=127.0.0.1:" + port); //$NON-NLS-1$ arguments.add(config.getClassToLaunch()); addArguments(config.getProgramArguments(), arguments); String[] cmdLine= new String[arguments.size()]; arguments.copyInto(cmdLine); ListeningConnector connector= getConnector(); if (connector == null) { throw new CoreException(createStatus(LauncherMessages.getString("jdkLauncher.error.noConnector"), null)); //$NON-NLS-1$ } Map map= connector.defaultArguments(); int timeout= fVMInstance.getDebuggerTimeout(); specifyArguments(map, port, timeout); Process p= null; try { try { connector.startListening(map); try { p= Runtime.getRuntime().exec(cmdLine); } catch (IOException e) { if (p != null) { p.destroy(); } throw new CoreException(createStatus(LauncherMessages.getString("jdkLauncher.error.title"), e)); //$NON-NLS-1$ } IProcess process= DebugPlugin.getDefault().newProcess(p, renderProcessLabel(cmdLine)); process.setAttribute(JavaRuntime.ATTR_CMDLINE, renderCommandLine(cmdLine)); //try { // Thread.currentThread().sleep(5000); //} catch (InterruptedException e) { //} boolean retry= false; do { try { VirtualMachine vm= connector.accept(map); setTimeout(vm); IDebugTarget debugTarget= JDIDebugModel.newDebugTarget(vm, renderDebugTarget(config.getClassToLaunch(), port), process, true, false); return new VMRunnerResult(debugTarget, new IProcess[] { process }); } catch (InterruptedIOException e) { retry= fRetryQuery.queryRetry(); } } while (retry); } finally { connector.stopListening(map); } } catch (IOException e) { throw new CoreException(createStatus(LauncherMessages.getString("jdkLauncher.error.connect"), e)); //$NON-NLS-1$ } catch (IllegalConnectorArgumentsException e) { throw new CoreException(createStatus(LauncherMessages.getString("jdkLauncher.error.connect"), e)); //$NON-NLS-1$ } if (p != null) p.destroy(); return null; } private void setTimeout(VirtualMachine vm) { if (vm instanceof org.eclipse.jdi.VirtualMachine) { int timeout= fVMInstance.getDebuggerTimeout(); org.eclipse.jdi.VirtualMachine vm2= (org.eclipse.jdi.VirtualMachine)vm; vm2.setRequestTimeout(timeout); } } protected void specifyArguments(Map map, int portNumber, int timeout) { // XXX: Revisit - allows us to put a quote (") around the classpath Connector.IntegerArgument port= (Connector.IntegerArgument) map.get("port"); //$NON-NLS-1$ port.setValue(portNumber); Connector.IntegerArgument timeoutArg= (Connector.IntegerArgument) map.get("timeout"); //$NON-NLS-1$ timeoutArg.setValue(timeout); } protected ListeningConnector getConnector() { List connectors= Bootstrap.virtualMachineManager().listeningConnectors(); for (int i= 0; i < connectors.size(); i++) { ListeningConnector c= (ListeningConnector) connectors.get(i); if ("com.sun.jdi.SocketListen".equals(c.name())) //$NON-NLS-1$ return c; } return null; } }
5,766
Bug 5766 Update refs in String/Java Doc should be off by default
When renaming an element then the options to Update references in Strings/Java Doc/Comments is on by default it should be off.
resolved fixed
a58bec4
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T15:20:26Z"
"2001-11-10T22:06:40Z"
org.eclipse.jdt.ui/ui
5,766
Bug 5766 Update refs in String/Java Doc should be off by default
When renaming an element then the options to Update references in Strings/Java Doc/Comments is on by default it should be off.
resolved fixed
a58bec4
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T15:20:26Z"
"2001-11-10T22:06:40Z"
refactoring/org/eclipse/jdt/internal/ui/refactoring/RenameInputWizardPage.java
3,607
Bug 3607 Open Type: can't enter fully qualified name (1GCJUJX)
EG (4/21/2001 4:17:12 PM) it should be possible to enter fully qualified name NOTES: PA (5/31/01 2:44:32 PM) it isn't. MA (15.08.2001 18:10:01) Filter with the simple name from the current entered name, and select the package using the qualifier.
verified fixed
7bf340f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T15:46:44Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/AbstractElementListSelectionDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dialogs; import java.util.ArrayList; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.BusyIndicator; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Text; import org.eclipse.core.runtime.IStatus; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.ILabelProvider; /** * An abstract class to select elements out of a list of elements. */ public abstract class AbstractElementListSelectionDialog extends SelectionStatusDialog { private ILabelProvider fRenderer; private boolean fIgnoreCase= true; private boolean fIsMultipleSelection= false; private boolean fMatchEmptyString= true; private boolean fAllowDuplicates= true; private Label fMessage; private FilteredList fFilteredList; private Text fFilterText; private ISelectionValidator fValidator; private String fFilter= null; private String fEmptyListMessage= ""; //$NON-NLS-1$ private String fEmptySelectionMessage= ""; //$NON-NLS-1$ private int fWidth= 60; private int fHeight= 18; /** * Constructs a list selection dialog. * @param renderer The label renderer used * @param ignoreCase Decides if the match string ignores lower/upppr case * @param multipleSelection Allow multiple selection */ protected AbstractElementListSelectionDialog(Shell parent, ILabelProvider renderer) { super(parent); fRenderer= renderer; } /** * Handles default selection (double click). * By default, the OK button is pressed. */ protected void handleDefaultSelected() { if (validateCurrentSelection()) buttonPressed(IDialogConstants.OK_ID); } /** * Specifies if sorting, filtering and folding is case sensitive. */ public void setIgnoreCase(boolean ignoreCase) { fIgnoreCase= ignoreCase; } /** * Returns if sorting, filtering and folding is case sensitive. */ public boolean isCaseIgnored() { return fIgnoreCase; } /** * Specifies whether everything or nothing should be filtered on * empty filter string. */ public void setMatchEmptyString(boolean matchEmptyString) { fMatchEmptyString= matchEmptyString; } /** * Specifies if multiple selection is allowed. */ public void setMultipleSelection(boolean multipleSelection) { fIsMultipleSelection= multipleSelection; } /** * Specifies whether duplicate entries are displayed or not. */ public void setAllowDuplicates(boolean allowDuplicates) { fAllowDuplicates= allowDuplicates; } /** * Sets the list size in unit of characters. * @param width the width of the list. * @param height the height of the list. */ public void setSize(int width, int height) { fWidth= width; fHeight= height; } /** * Sets the message to be displayed if the list is empty. * @param message the message to be displayed. */ public void setEmptyListMessage(String message) { fEmptyListMessage= message; } /** * Sets the message to be displayed if the selection is empty. * @param message the message to be displayed. */ public void setEmptySelectionMessage(String message) { fEmptySelectionMessage= message; } /** * Sets an optional validator to check if the selection is valid. * The validator is invoked whenever the selection changes. * @param validator the validator to validate the selection. */ public void setValidator(ISelectionValidator validator) { fValidator= validator; } /** * Sets the elements of the list (widget). * To be called within open(). * @param elements the elements of the list. */ protected void setListElements(Object[] elements) { Assert.isNotNull(fFilteredList); fFilteredList.setElements(elements); } /** * Sets the filter pattern. * @param filter the filter pattern. */ public void setFilter(String filter) { if (fFilterText == null) fFilter= filter; else fFilterText.setText(filter); } /** * Returns the current filter pattern. * @return returns the current filter pattern or <code>null<code> if filter was not set. */ public String getFilter() { if (fFilteredList == null) return fFilter; else return fFilteredList.getFilter(); } /** * Returns the indices referring the current selection. * To be called within open(). * @return returns the indices of the current selection. */ protected int[] getSelectionIndices() { Assert.isNotNull(fFilteredList); return fFilteredList.getSelectionIndices(); } /** * Returns an index referring the first current selection. * To be called within open(). * @return returns the indices of the current selection. */ protected int getSelectionIndex() { Assert.isNotNull(fFilteredList); return fFilteredList.getSelectionIndex(); } /** * Sets the selection referenced by an array of elements. * To be called within open(). * @param selection the indices of the selection. */ protected void setSelection(Object[] selection) { Assert.isNotNull(fFilteredList); fFilteredList.setSelection(selection); } /** * Returns an array of the currently selected elements. * To be called within or after open(). * @return returns an array of the currently selected elements. */ protected Object[] getSelectedElements() { Assert.isNotNull(fFilteredList); return fFilteredList.getSelection(); } /** * Returns all elements which are folded together to one entry in the list. * @param index the index selecting the entry in the list. * @return returns an array of elements folded together. */ public Object[] getFoldedElements(int index) { Assert.isNotNull(fFilteredList); return fFilteredList.getFoldedElements(index); } /** * Creates the message text widget and sets layout data. * @param composite the parent composite of the message area. */ protected Label createMessageArea(Composite composite) { Label label= super.createMessageArea(composite); GridData data= new GridData(); data.grabExcessVerticalSpace= false; data.grabExcessHorizontalSpace= true; data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.BEGINNING; label.setLayoutData(data); fMessage= label; return label; } /** * Handles a selection changed event. * By default, the current selection is validated. */ protected void handleSelectionChanged() { validateCurrentSelection(); } /** * Validates the current selection and updates the status line * accordingly. */ protected boolean validateCurrentSelection() { Assert.isNotNull(fFilteredList); IStatus status; Object[] elements= getSelectedElements(); if (elements.length > 0) { if (fValidator != null) { status= fValidator.validate(elements); } else { status= new StatusInfo(); } } else { if (fFilteredList.isEmpty()) { status= new StatusInfo(IStatus.ERROR, fEmptyListMessage); } else { status= new StatusInfo(IStatus.ERROR, fEmptySelectionMessage); } } updateStatus(status); return status.isOK(); } /* * @see Dialog#cancelPressed */ protected void cancelPressed() { setResult(null); super.cancelPressed(); } /** * Creates a filtered list. * @param parent the parent composite. * @return returns the filtered list widget. */ protected FilteredList createFilteredList(Composite parent) { int flags= SWT.BORDER | SWT.V_SCROLL | SWT.H_SCROLL | (fIsMultipleSelection ? SWT.MULTI : SWT.SINGLE); FilteredList list= new FilteredList(parent, flags, fRenderer, fIgnoreCase, fAllowDuplicates, fMatchEmptyString); GridData data= new GridData(); data.widthHint= convertWidthInCharsToPixels(fWidth); data.heightHint= convertHeightInCharsToPixels(fHeight); data.grabExcessVerticalSpace= true; data.grabExcessHorizontalSpace= true; data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.FILL; list.setLayoutData(data); list.setFilter((fFilter == null ? "" : fFilter)); //$NON-NLS-1$ list.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { handleDefaultSelected(); } public void widgetSelected(SelectionEvent e) { handleSelectionChanged(); } }); fFilteredList= list; return list; } protected Text createFilterText(Composite parent) { Text text= new Text(parent, SWT.BORDER); GridData data= new GridData(); data.grabExcessVerticalSpace= false; data.grabExcessHorizontalSpace= true; data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.BEGINNING; text.setLayoutData(data); text.setText((fFilter == null ? "" : fFilter)); //$NON-NLS-1$ Listener listener= new Listener() { public void handleEvent(Event e) { fFilteredList.setFilter(fFilterText.getText()); } }; text.addListener(SWT.Modify, listener); fFilterText= text; return text; } /* * @see Window#open() */ public int open() { BusyIndicator.showWhile(null, new Runnable() { public void run() { access$superOpen(); } }); return getReturnCode(); } private void access$superOpen() { super.open(); } /* * @see Window#create(Shell) */ public void create() { super.create(); Assert.isNotNull(fFilteredList); if (fFilteredList.isEmpty()) { handleEmptyList(); } else { validateCurrentSelection(); fFilterText.selectAll(); fFilterText.setFocus(); } } /** * Handles empty list by disabling widgets. */ protected void handleEmptyList() { fMessage.setEnabled(false); fFilterText.setEnabled(false); fFilteredList.setEnabled(false); } }
3,607
Bug 3607 Open Type: can't enter fully qualified name (1GCJUJX)
EG (4/21/2001 4:17:12 PM) it should be possible to enter fully qualified name NOTES: PA (5/31/01 2:44:32 PM) it isn't. MA (15.08.2001 18:10:01) Filter with the simple name from the current entered name, and select the package using the qualifier.
verified fixed
7bf340f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T15:46:44Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/FilteredList.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dialogs; import java.util.ArrayList; import java.util.Comparator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.events.DisposeEvent; import org.eclipse.swt.events.DisposeListener; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.Table; import org.eclipse.swt.widgets.TableItem; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jdt.internal.core.refactoring.util.Selection; import org.eclipse.jdt.internal.ui.util.StringMatcher; import org.eclipse.jdt.internal.ui.util.TypeInfo; /** * A composite widget which holds a list of elements for user selection. * The elements are sorted alphabetically. * Optionally, the elements can be filtered and duplicate entries can * be hidden (folding). */ public class FilteredList extends Composite { private Table fList; private ILabelProvider fRenderer; private boolean fMatchEmtpyString= true; private boolean fIgnoreCase; private boolean fAllowDuplicates; private String fFilter= ""; //$NON-NLS-1$ private TwoArrayQuickSorter fSorter; private Object[] fElements= new Object[0]; private Label[] fLabels; private int[] fFoldedIndices; private int fFoldedCount; private int[] fFilteredIndices; private int fFilteredCount; private static class Label { public final String string; public final Image image; public Label(String string, Image image) { this.string= string; this.image= image; } public boolean equals(Label label) { if (label == null) return false; return string.equals(label.string) && image.equals(label.image); } } private static class LabelComparator implements Comparator { private boolean fIgnoreCase; LabelComparator(boolean ignoreCase) { fIgnoreCase= ignoreCase; } public int compare(Object left, Object right) { Label leftLabel= (Label) left; Label rightLabel= (Label) right; int value= fIgnoreCase ? leftLabel.string.compareToIgnoreCase(rightLabel.string) : leftLabel.string.compareTo(rightLabel.string); if (value != 0) return value; // images are allowed to be null if (leftLabel.image == null) { return (rightLabel.image == null) ? 0 : -1; } else if (rightLabel.image == null) { return +1; } else { // XXX works only for max. two image types return leftLabel.image.equals(rightLabel.image) ? 0 : 1; } } } /** * Constructs a new instance of a filtered list. * @param parent the parent composite. * @param style the widget style. * @param renderer the label renderer. * @param ignoreCase specifies whether sorting and folding is case sensitive. * @param allowDuplicates specifies whether folding of duplicates is desired. * @param matchEmptyString specifies whether empty filter strings should filter everything or nothing. */ public FilteredList(Composite parent, int style, ILabelProvider renderer, boolean ignoreCase, boolean allowDuplicates, boolean matchEmptyString) { super(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; setLayout(layout); fList= new Table(this, style); fList.setLayoutData(new GridData(GridData.FILL_BOTH)); fList.addDisposeListener(new DisposeListener() { public void widgetDisposed(DisposeEvent e) { fRenderer.dispose(); } }); fRenderer= renderer; fIgnoreCase= ignoreCase; fSorter= new TwoArrayQuickSorter(new LabelComparator(ignoreCase)); fAllowDuplicates= allowDuplicates; fMatchEmtpyString= matchEmptyString; } /** * Sets the list of elements. * @param elements the elements to be shown in the list. */ public void setElements(Object[] elements) { if (elements == null) { fElements= new Object[0]; } else { // copy list for sorting fElements= new Object[elements.length]; System.arraycopy(elements, 0, fElements, 0, elements.length); } int length= fElements.length; // fill labels fLabels= new Label[length]; for (int i= 0; i != length; i++) fLabels[i]= new Label( fRenderer.getText(fElements[i]), fRenderer.getImage(fElements[i])); fSorter.sort(fLabels, fElements); fFoldedIndices= new int[length]; fFoldedCount= fold(); fFilteredIndices= new int[length]; fFilteredCount= filter(); updateList(); } /** * Tests if the list (before folding and filtering) is empty. * @return returns <code>true</code> if the list is empty, <code>false</code> otherwise. */ public boolean isEmpty() { return (fElements == null) || (fElements.length == 0); } /** * Adds a selection listener to the list. * @param listener the selection listener to be added. */ public void addSelectionListener(SelectionListener listener) { fList.addSelectionListener(listener); } /** * Removes a selection listener from the list. * @param listener the selection listener to be removed. */ public void removeSelectionListener(SelectionListener listener) { fList.removeSelectionListener(listener); } /** * Sets the selection of the list. * @param selection an array of indices specifying the selection. */ public void setSelection(int[] selection) { fList.setSelection(selection); } /** * Returns the selection of the list. * @return returns an array of indices specifying the current selection. */ public int[] getSelectionIndices() { return fList.getSelectionIndices(); } /** * Returns the selection of the list. * This is a convenience function for <code>getSelectionIndices()</code>. * @return returns the index of the selection, -1 for no selection. */ public int getSelectionIndex() { return fList.getSelectionIndex(); } /** * Sets the selection of the list. * @param elements the array of elements to be selected. */ public void setSelection(Object[] elements) { if ((elements == null) || (fElements == null)) return; // fill indices int[] indices= new int[elements.length]; for (int i= 0; i != elements.length; i++) { int j; for (j= 0; j != fFilteredCount; j++) { int k = fFilteredIndices[j]; int max= (k == fFoldedCount - 1) ? fElements.length : fFoldedIndices[k + 1]; int l; for (l= fFoldedIndices[k]; l != max; l++) { // found matching element? if (fElements[l].equals(elements[i])) { indices[i]= j; break; } } if (l != max) break; } // not found if (j == fFilteredCount) indices[i] = 0; } fList.setSelection(indices); } /** * Returns an array of the selected elements. The type of the elements * returned in the list are the same as the ones passed with * <code>setElements</code>. The array does not contain the rendered strings. * @return returns the array of selected elements. */ public Object[] getSelection() { if (fList.isDisposed() || (fList.getSelectionCount() == 0)) return new Object[0]; int[] indices= fList.getSelectionIndices(); Object[] elements= new Object[indices.length]; for (int i= 0; i != indices.length; i++) elements[i]= fElements[fFoldedIndices[fFilteredIndices[indices[i]]]]; return elements; } /** * Sets the filter pattern. Current only prefix filter patterns are supported. * @param filter the filter pattern. */ public void setFilter(String filter) { fFilter= (filter == null) ? "" : filter; //$NON-NLS-1$ fFilteredCount= filter(); updateList(); } /** * Returns the filter pattern. * @return returns the filter pattern. */ public String getFilter() { return fFilter; } /** * Returns all elements which are folded together to one entry in the list. * @param index the index selecting the entry in the list. * @return returns an array of elements folded together, <code>null</code> if index is out of range. */ public Object[] getFoldedElements(int index) { if ((index < 0) || (index >= fFilteredCount)) return null; index= fFilteredIndices[index]; int start= fFoldedIndices[index]; int count= (index == fFoldedCount - 1) ? fElements.length - start : fFoldedIndices[index + 1] - start; Object[] elements= new Object[count]; for (int i= 0; i != count; i++) elements[i]= fElements[start + i]; return elements; } /* * Folds duplicate entries. Two elements are considered as a pair of * duplicates if they coiincide in the rendered string and image. * @return returns the number of elements after folding. */ private int fold() { int length= fElements.length; if (fAllowDuplicates) { for (int i= 0; i != length; i++) fFoldedIndices[i]= i; // identity mapping return length; } else { int k= 0; Label last= null; for (int i= 0; i != length; i++) { Label current= fLabels[i]; if (! current.equals(last)) { fFoldedIndices[k]= i; k++; last= current; } } return k; } } /* * Filters the list with the filter pattern. * @return returns the number of elements after filtering. */ private int filter() { if (((fFilter == null) || (fFilter.length() == 0)) && !fMatchEmtpyString) return 0; StringMatcher matcher= new StringMatcher(fFilter + "*", fIgnoreCase, false); //$NON-NLS-1$ int k= 0; for (int i= 0; i != fFoldedCount; i++) { int j = fFoldedIndices[i]; if (matcher.match(fLabels[j].string)) fFilteredIndices[k++]= i; } return k; } /* * Updates the list widget. */ private void updateList() { if (fList.isDisposed()) return; fList.setRedraw(false); // resize table int itemCount= fList.getItemCount(); if (fFilteredCount < itemCount) fList.remove(0, itemCount - fFilteredCount - 1); else if (fFilteredCount > itemCount) for (int i= 0; i != fFilteredCount - itemCount; i++) new TableItem(fList, SWT.NONE); // fill table TableItem[] items= fList.getItems(); for (int i= 0; i != fFilteredCount; i++) { TableItem item= items[i]; Label label= fLabels[fFoldedIndices[fFilteredIndices[i]]]; item.setText(label.string); item.setImage(label.image); } // select first item if any if (fList.getItemCount() > 0) fList.setSelection(0); fList.setRedraw(true); fList.notifyListeners(SWT.Selection, new Event()); } }
3,607
Bug 3607 Open Type: can't enter fully qualified name (1GCJUJX)
EG (4/21/2001 4:17:12 PM) it should be possible to enter fully qualified name NOTES: PA (5/31/01 2:44:32 PM) it isn't. MA (15.08.2001 18:10:01) Filter with the simple name from the current entered name, and select the package using the qualifier.
verified fixed
7bf340f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T15:46:44Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/TypeSelectionDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dialogs; import java.util.ArrayList; import java.util.List; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.operation.IRunnableContext; import org.eclipse.jface.util.Assert; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.util.AllTypesSearchEngine; import org.eclipse.jdt.internal.ui.util.TypeInfo; import org.eclipse.jdt.internal.ui.util.TypeInfoLabelProvider; /** * A dialog to select a type from a list of types. */ public class TypeSelectionDialog extends TwoPaneElementSelector { private IRunnableContext fRunnableContext; private IJavaSearchScope fScope; private int fStyle; /** * Constructs a type selection dialog. * @param parent the parent shell. * @param context the runnable context. * @param scope the java search scope. * @param style the widget style. */ public TypeSelectionDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style) { super(parent, new TypeInfoLabelProvider(0), new TypeInfoLabelProvider(TypeInfoLabelProvider.SHOW_PACKAGE_ONLY + TypeInfoLabelProvider.SHOW_ROOT_POSTFIX)); Assert.isNotNull(context); Assert.isNotNull(scope); fRunnableContext= context; fScope= scope; fStyle= style; setUpperListLabel(JavaUIMessages.getString("TypeSelectionDialog.upperLabel")); //$NON-NLS-1$ setLowerListLabel(JavaUIMessages.getString("TypeSelectionDialog.lowerLabel")); //$NON-NLS-1$ } public void create() { if (getFilter() == null) setFilter("A"); //$NON-NLS-1$ super.create(); } /** * @see Window#open() */ public int open() { AllTypesSearchEngine engine= new AllTypesSearchEngine(JavaPlugin.getWorkspace()); List typeList= engine.searchTypes(fRunnableContext, fScope, fStyle); if (typeList.isEmpty()) { String title= JavaUIMessages.getString("TypeSelectionDialog.notypes.title"); //$NON-NLS-1$ String message= JavaUIMessages.getString("TypeSelectionDialog.notypes.message"); //$NON-NLS-1$ MessageDialog.openInformation(getShell(), title, message); return CANCEL; } TypeInfo[] typeRefs= (TypeInfo[])typeList.toArray(new TypeInfo[typeList.size()]); setElements(typeRefs); return super.open(); } /** * @see SelectionStatusDialog#computeResult() */ protected void computeResult() { TypeInfo ref= (TypeInfo) getLowerSelectedElement(); if (ref == null) return; try { IType type= ref.resolveType(fScope); if (type == null) { // not a class file or compilation unit String title= JavaUIMessages.getString("TypeSelectionDialog.errorTitle"); //$NON-NLS-1$ String message= JavaUIMessages.getString("TypeSelectionDialog.errorMessage"); //$NON-NLS-1$ MessageDialog.openError(getShell(), title, message); setResult(null); } else { List result= new ArrayList(1); result.add(type); setResult(result); } } catch (JavaModelException e) { String title= JavaUIMessages.getString("TypeSelectionDialog.errorTitle"); //$NON-NLS-1$ String message= JavaUIMessages.getString("TypeSelectionDialog.errorMessage"); //$NON-NLS-1$ MessageDialog.openError(getShell(), title, message); setResult(null); } } }
3,607
Bug 3607 Open Type: can't enter fully qualified name (1GCJUJX)
EG (4/21/2001 4:17:12 PM) it should be possible to enter fully qualified name NOTES: PA (5/31/01 2:44:32 PM) it isn't. MA (15.08.2001 18:10:01) Filter with the simple name from the current entered name, and select the package using the qualifier.
verified fixed
7bf340f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T15:46:44Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/util/TypeInfoLabelProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.util; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jface.viewers.LabelProvider; import org.eclipse.swt.graphics.Image; public class TypeInfoLabelProvider extends LabelProvider { public static final int SHOW_FULLYQUALIFIED= 0x01; public static final int SHOW_PACKAGE_POSTFIX= 0x02; public static final int SHOW_PACKAGE_ONLY= 0x04; public static final int SHOW_ROOT_POSTFIX= 0x08; private static final Image CLASS_ICON= JavaPluginImages.get(JavaPluginImages.IMG_OBJS_CLASS); private static final Image INTERFACE_ICON= JavaPluginImages.get(JavaPluginImages.IMG_OBJS_INTERFACE); private static final Image PKG_ICON= JavaPluginImages.get(JavaPluginImages.IMG_OBJS_PACKAGE); private int fFlags; public TypeInfoLabelProvider(int flags) { fFlags= flags; } private boolean isSet(int flag) { return (fFlags & flag) != 0; } private String getPackageName(TypeInfo typeRef) { String packName= typeRef.getPackageName(); if (packName.length() == 0) return JavaUIMessages.getString("TypeInfoLabelProvider.default_package"); //$NON-NLS-1$ else return packName; } /* non java-doc * @see ILabelProvider#getText */ public String getText(Object element) { if (! (element instanceof TypeInfo)) return super.getText(element); TypeInfo typeRef= (TypeInfo) element; StringBuffer buf= new StringBuffer(); if (isSet(SHOW_PACKAGE_ONLY)) { buf.append(getPackageName(typeRef)); }else { if (isSet(SHOW_FULLYQUALIFIED)) buf.append(typeRef.getFullyQualifiedName()); else buf.append(typeRef.getTypeQualifiedName()); if (isSet(SHOW_PACKAGE_POSTFIX)) { buf.append(JavaUIMessages.getString("TypeInfoLabelProvider.dash")); //$NON-NLS-1$ buf.append(getPackageName(typeRef)); } } if (isSet(SHOW_ROOT_POSTFIX)) { buf.append(JavaUIMessages.getString("TypeInfoLabelProvider.dash"));//$NON-NLS-1$ buf.append(typeRef.getPackageFragmentRootPath().toString()); } return buf.toString(); } /* non java-doc * @see ILabelProvider#getImage */ public Image getImage(Object element) { if (! (element instanceof TypeInfo)) return super.getImage(element); if (isSet(SHOW_PACKAGE_ONLY)) return PKG_ICON; else return ((TypeInfo) element).isInterface() ? INTERFACE_ICON : CLASS_ICON; } }
5,722
Bug 5722 Selecting font crashes eclipse with a javacore
Eclipse V2.0 Build 20011107 OS: RedHat Linux 7.1 JDK version: /opt/IBMJava2-13/bin/ ./java -version java version "1.3.0" Java(TM) 2 Runtime Environment, Standard Edition (build 1.3.0) Classic VM (build 1.3.0, J2RE 1.3.0 IBM build cx130-20010925 (JIT enabled: jitc)) To Reproduce: Startup eclipse (i had a fresh zip with no workspace and i specified no options) Open Window->Preferences->WorkBench->Font Select Text font ( my inital value here was "adobe-courier-regular-12" ) Click Change to bring up font dialog change the font size to 14. And click ok to dismiss the font dialog Click Apply on preferences page. Click OK on preferences Page. At this point eclipse crashes with ----- SIGSEGV 11 '(*) segmentation violation' in process 2524 si_signo [11]: SIGSEGV: (*) segmentation violation si_errno [0]: Success si_code [1]: SEGV_MAPERR [addr: 0x18433808] stackpointer=0xbffc19d8 Writing java dump to javacore2524.1005335380.txt ... OK -----javacore2524.1005335380.txt contents------------------- Fri Nov 9 14:49:40 2001 SIGSEGV received at 14458be5 in unknown. Processing terminated. J2RE 1.3.0 IBM build cx130-20010925 /opt/IBMJava2-13/jre/bin/exe/java -classpath ./startup.jar org.eclipse.core.launcher.Main -ws motif -application org.eclipse.ui.workbench -endsplash ./eclipse -endsplash 2523 System Properties ----------------- Java Home Dir: /opt/IBMJava2-13/jre Java DLL Dir: /opt/IBMJava2-13/jre/bin Sys Classpath: /opt/IBMJava2-13/jre/lib/rt.jar:/opt/IBMJava2-13/jre/lib/i18n.jar:/opt/IBMJava2-13/jre/classes User Args: -Djava.class.path=/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java/sqlj.zip:/home/db2inst1/sqllib/function:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java/runtime.zip:. -Djava.class.path=./startup.jar Current Thread Details ---------------------- PID:2524 "main" (TID:0x403487e0, sys_thread_t:0x804ff88, state:R, native ID:0x400) prio=5 at org.eclipse.swt.internal.motif.OS.XtSetValues(Native Method) at org.eclipse.swt.widgets.WidgetTable.remove(WidgetTable.java:94) at org.eclipse.swt.widgets.Widget.deregister(Widget.java:236) at org.eclipse.swt.widgets.Scrollable.deregister(Scrollable.java:136) at org.eclipse.swt.widgets.Widget.releaseWidget(Widget.java:651) at org.eclipse.swt.widgets.Control.releaseWidget(Control.java:1448) at org.eclipse.swt.widgets.Scrollable.releaseWidget(Scrollable.java:291) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Canvas.releaseWidget(Canvas.java:129) at org.eclipse.swt.widgets.Decorations.releaseWidget(Decorations.java:327) at org.eclipse.swt.widgets.Shell.releaseWidget(Shell.java:851) at org.eclipse.swt.widgets.Widget.dispose(Widget.java:276) at org.eclipse.swt.widgets.Shell.dispose(Shell.java:562) at org.eclipse.jface.window.Window.close(Window.java:194) at org.eclipse.jface.preference.PreferenceDialog.close(PreferenceDialog.java:204) at org.eclipse.jface.preference.PreferenceDialog.okPressed(PreferenceDialog.java:523) at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(PreferenceDialog.java:166) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:211) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:85) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:489) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java(Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:47) at org.eclipse.jface.action.Action.runWithEvent(Action.java:453) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent(ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0(ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:489) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1561) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1411) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:727) at org.eclipse.ui.internal.Workbench.run(Workbench.java:710) at org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362) ----- Native Stack ----- ------------------------------------------------------------------------- Operating Environment --------------------- Host : solipsist.(none) OS Level : 2.4.2-2.#1 Sun Apr 8 20:41:30 EDT 2001 glibc Version : 2.2.2 No. of Procs : 1 Memory Info: total: used: free: shared: buffers: cached: Mem: 393633792 325152768 68481024 0 27418624 164200448 Swap: 526376960 0 526376960 MemTotal: 384408 kB MemFree: 66876 kB MemShared: 0 kB Buffers: 26776 kB Cached: 160352 kB Active: 150980 kB Inact_dirty: 34480 kB Inact_clean: 1668 kB Inact_target: 856 kB HighTotal: 0 kB HighFree: 0 kB LowTotal: 384408 kB LowFree: 66876 kB SwapTotal: 514040 kB SwapFree: 514040 kB User Limits (in bytes except for NOFILE and NPROC) - RLIMIT_FSIZE : infinity RLIMIT_DATA : infinity RLIMIT_STACK : 2093056 RLIMIT_CORE : 1024000000 RLIMIT_NOFILE : 1024 RLIMIT_NPROC : 12286 Application Environment ----------------------- Signal Handlers - SIGQUIT : intrDispatchMD (libhpi.so) SIGILL : intrDispatchMD (libhpi.so) SIGTRAP : intrDispatchMD (libhpi.so) SIGABRT : intrDispatchMD (libhpi.so) SIGFPE : intrDispatchMD (libhpi.so) SIGBUS : intrDispatchMD (libhpi.so) SIGSEGV : intrDispatchMD (libhpi.so) SIGPIPE : ignored SIGUSR1 : sigusr1Handler (libhpi.so) SIGUSR2 : get_self (libhpi.so) Environment Variables - PWD=/home/manahan/eclipse WRASTER_COLOR_RESOLUTION0=4 COLORFGBG=default;default;0 LD_ASSUME_KERNEL=2.2.5 COLORTERM_BCE=Eterm WINDOWID=25165889 ETERM_VERSION=0.9.1 HOSTNAME=solipsist DB2INSTANCE=db2inst1 LD_LIBRARY_PATH=/opt/IBMJava2-13/jre/bin:/opt/IBMJava2-13/jre/bin/classic:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/lib HISTFILESIZE=500 QTDIR=/usr/lib/qt-2.3.0 CLASSPATH=/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java/sqlj.zip:/home/db2inst1/sqllib/function:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java/runtime.zip:. LESSOPEN=|/usr/bin/lesspipe.sh %s KDEDIR=/usr USER=manahan LS_COLORS= MACHTYPE=i386-redhat-linux-gnu ETERM_USER_ROOT=/home/manahan/.Eterm/themes/Eterm WMAKER_BIN_NAME=/usr/local/bin/wmaker MAIL=/var/spool/mail/manahan INPUTRC=/etc/inputrc BASH_ENV=/home/manahan/.bashrc XMODIFIERS=@im=none LANG=en_US JAVAHOME=/opt/IBMJava2-13/jre LIBPATH=:/home/db2inst1/sqllib/lib COLORTERM=Eterm DISPLAY=:0.0 LOGNAME=manahan SHLVL=1 SHELL=/bin/bash HOSTTYPE=i386 CDPATH=.:/home/manahan:/work:/usr OSTYPE=linux-gnu HISTSIZE=500 IFS= HOME=/home/manahan TERM=Eterm SSH_ASKPASS=/usr/libexec/openssh/gnome-ssh-askpass PATH=.:/opt/IBMJava2-13/bin:.:/bin:/usr/bin:/usr/X11R6/bin:/usr/local/bin:/home/db2inst1/sqllib/java12:/home/manahan/bin:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/bin:/home/db2inst1/sqllib/adm:/home/db2inst1/sqllib/misc:/home/manahan/bin ETERM_THEME_ROOT=/home/manahan/.Eterm/themes/Eterm IBM_JAVA_COMMAND_LINE=/opt/IBMJava2-13/jre/bin/exe/java -classpath ./startup.jar org.eclipse.core.launcher.Main -ws motif -application org.eclipse.ui.workbench -endsplash ./eclipse -endsplash 2523 JAVA_MAIN_VM=1076546644 Memory map ---------- 08048000-0804c000 r-xp 00000000 03:06 35165 /opt/IBMJava2-13/jre/bin/exe/java 0804c000-0804d000 rw-p 00003000 03:06 35165 /opt/IBMJava2-13/jre/bin/exe/java 0804d000-08909000 rwxp 00000000 00:00 0 40000000-40016000 r-xp 00000000 03:06 240591 /lib/ld-2.2.2.so 40016000-40017000 rw-p 00015000 03:06 240591 /lib/ld-2.2.2.so 40017000-40018000 rw-p 00000000 00:00 0 40018000-4001a000 r-xp 00000000 03:06 20255 /opt/IBMJava2-13/jre/bin/libxhpi.so 4001a000-4001b000 rw-p 00001000 03:06 20255 /opt/IBMJava2-13/jre/bin/libxhpi.so 4001b000-4001c000 r--p 00000000 03:06 176389 /usr/lib/locale/en_US/LC_IDENTIFICATION 4001c000-4001d000 r--p 00000000 03:06 176390 /usr/lib/locale/en_US/LC_MEASUREMENT 4001d000-4001e000 r--p 00000000 03:06 176393 /usr/lib/locale/en_US/LC_TELEPHONE 4001e000-4001f000 r--p 00000000 03:06 176388 /usr/lib/locale/en_US/LC_ADDRESS 4001f000-40020000 r--p 00000000 03:06 176391 /usr/lib/locale/en_US/LC_NAME 40020000-40021000 r--p 00000000 03:06 176392 /usr/lib/locale/en_US/LC_PAPER 40021000-40022000 r--p 00000000 03:06 304681 /usr/lib/locale/en_US/LC_MESSAGES/SYS_LC_MESSAGES 40022000-40023000 r--p 00000000 03:06 128301 /usr/lib/locale/en_US/LC_MONETARY 40023000-40024000 r--p 00000000 03:06 176394 /usr/lib/locale/en_US/LC_TIME 40024000-40025000 r--p 00000000 03:06 32123 /usr/lib/locale/en_US/LC_NUMERIC 40025000-40026000 rw-p 00000000 00:00 0 40026000-40027000 rw-p 00000000 00:00 0 40027000-40036000 r-xp 00000000 03:06 240636 /lib/libpthread-0.9.so 40036000-4003e000 rw-p 0000e000 03:06 240636 /lib/libpthread-0.9.so 4003e000-40051000 r-xp 00000000 03:06 240609 /lib/libnsl-2.2.2.so 40051000-40053000 rw-p 00012000 03:06 240609 /lib/libnsl-2.2.2.so 40053000-40055000 rw-p 00000000 00:00 0 40055000-40058000 r-xp 00000000 03:06 240604 /lib/libdl-2.2.2.so 40058000-40059000 rw-p 00002000 03:06 240604 /lib/libdl-2.2.2.so 40059000-40182000 r-xp 00000000 03:06 240600 /lib/libc-2.2.2.so 40182000-40187000 rw-p 00128000 03:06 240600 /lib/libc-2.2.2.so 40187000-4018b000 rw-p 00000000 00:00 0 4018b000-402ac000 r-xp 00000000 03:06 35162 /opt/IBMJava2-13/jre/bin/classic/libjvm.so 402ac000-402b8000 rw-p 00120000 03:06 35162 /opt/IBMJava2-13/jre/bin/classic/libjvm.so 402b8000-402d1000 rw-p 00000000 00:00 0 402d1000-402f4000 r-xp 00000000 03:06 240606 /lib/libm-2.2.2.so 402f4000-402f5000 rw-p 00022000 03:06 240606 /lib/libm-2.2.2.so 402f5000-40304000 r-xp 00000000 03:06 20233 /opt/IBMJava2-13/jre/bin/libhpi.so 40304000-40306000 rw-p 0000e000 03:06 20233 /opt/IBMJava2-13/jre/bin/libhpi.so 40306000-44306000 rwxp 00000000 00:00 0 44306000-44407000 rwxp 00000000 00:00 0 44407000-44508000 rwxp 00000000 00:00 0 44508000-44534000 r-xp 00000000 03:06 20237 /opt/IBMJava2-13/jre/bin/libjava.so 44534000-4453b000 rw-p 0002b000 03:06 20237 /opt/IBMJava2-13/jre/bin/libjava.so 4453b000-44549000 r-xp 00000000 03:06 20257 /opt/IBMJava2-13/jre/bin/libzip.so 44549000-4454c000 rw-p 0000d000 03:06 20257 /opt/IBMJava2-13/jre/bin/libzip.so 4454c000-44567000 r--p 00000000 03:06 192455 /usr/lib/locale/en_US/LC_CTYPE 44567000-4456d000 r--p 00000000 03:06 304675 /usr/lib/locale/en_US/LC_COLLATE 4456d000-4456f000 r-xp 00000000 03:06 48382 /usr/lib/gconv/ISO8859-1.so 4456f000-44570000 rw-p 00001000 03:06 48382 /usr/lib/gconv/ISO8859-1.so 44570000-44571000 rw-p 00000000 00:00 0 4457c000-44586000 r-xp 00000000 03:06 240625 /lib/libnss_files-2.2.2.so 44586000-44587000 rw-p 00009000 03:06 240625 /lib/libnss_files-2.2.2.so 44587000-44593000 r-xp 00000000 03:06 242574 /usr/X11R6/lib/libXext.so.6.4 44593000-44595000 rw-p 0000b000 03:06 242574 /usr/X11R6/lib/libXext.so.6.4 44595000-4459b000 r-xp 00000000 03:06 242584 /usr/X11R6/lib/libXp.so.6.2 4459b000-4459d000 rw-p 00005000 03:06 242584 /usr/X11R6/lib/libXp.so.6.2 4459d000-445a5000 r-xp 00000000 03:06 242564 /usr/X11R6/lib/libSM.so.6.0 445a5000-445a6000 rw-p 00007000 03:06 242564 /usr/X11R6/lib/libSM.so.6.0 445a6000-445ba000 r-xp 00000000 03:06 242560 /usr/X11R6/lib/libICE.so.6.3 445ba000-445bb000 rw-p 00013000 03:06 242560 /usr/X11R6/lib/libICE.so.6.3 445bb000-445bd000 rw-p 00000000 00:00 0 445c8000-445eb000 rw-p 00000000 00:00 0 445eb000-4477c000 r-xp 00000000 03:06 20245 /opt/IBMJava2-13/jre/bin/libjitc.so 4477c000-44783000 rw-p 00190000 03:06 20245 /opt/IBMJava2-13/jre/bin/libjitc.so 44783000-44784000 rw-p 00000000 00:00 0 44784000-44805000 rw-p 00000000 00:00 0 44805000-44886000 rw-p 00000000 00:00 0 44886000-44c87000 rw-p 00000000 00:00 0 44c87000-44d08000 rw-p 00000000 00:00 0 44d08000-44d89000 rw-p 00000000 00:00 0 44d89000-44e0a000 rw-p 00000000 00:00 0 44e0a000-44e8b000 rw-p 00000000 00:00 0 44e8b000-44f0c000 rw-p 00000000 00:00 0 44f0c000-44f8d000 rw-p 00000000 00:00 0 44f8d000-4500e000 rw-p 00000000 00:00 0 4500e000-4508f000 rw-p 00000000 00:00 0 4508f000-45175000 rw-p 00000000 00:00 0 45175000-451f6000 rw-p 00000000 00:00 0 451f6000-45277000 rw-p 00000000 00:00 0 45277000-4536b000 rw-p 00000000 00:00 0 4536b000-45448000 rw-p 00000000 00:00 0 45448000-45525000 rw-p 00000000 00:00 0 45525000-45602000 rw-p 00000000 00:00 0 45602000-45683000 rw-p 00000000 00:00 0 45683000-456c9000 r-xp 00000000 03:09 32096 /home/manahan/eclipse/plugins/org.eclipse.swt/ws/motif/libswt-linux-2012.so 456c9000-456cc000 rw-p 00045000 03:09 32096 /home/manahan/eclipse/plugins/org.eclipse.swt/ws/motif/libswt-linux-2012.so 456cc000-45850000 r-xp 00000000 03:09 80259 /home/manahan/eclipse/libXm.so.2 45850000-45863000 rw-p 00183000 03:09 80259 /home/manahan/eclipse/libXm.so.2 45863000-45864000 rw-p 00000000 00:00 0 45864000-4593f000 r-xp 00000000 03:06 242566 /usr/X11R6/lib/libX11.so.6.2 4593f000-45943000 rw-p 000da000 03:06 242566 /usr/X11R6/lib/libX11.so.6.2 45943000-45944000 rw-p 00000000 00:00 0 45944000-4598c000 r-xp 00000000 03:06 242590 /usr/X11R6/lib/libXt.so.6.0 4598c000-45990000 rw-p 00047000 03:06 242590 /usr/X11R6/lib/libXt.so.6.0 45990000-45991000 rw-p 00000000 00:00 0 45991000-45aa2000 rw-p 00000000 00:00 0 45aa2000-45bf2000 rw-p 00000000 00:00 0 45bf2000-45d72000 rw-p 00000000 00:00 0 45d72000-45f01000 rw-p 00000000 00:00 0 45f01000-45f82000 rw-p 00000000 00:00 0 bf3be000-bf3bf000 ---p 00000000 00:00 0 bf3bf000-bf3c2000 rwxp 00001000 00:00 0 bf3c2000-bf3c3000 r--p 00004000 00:00 0 bf3c3000-bf400000 rwxp 00005000 00:00 0 bf5be000-bf5bf000 ---p 00000000 00:00 0 bf5bf000-bf5c2000 rwxp 00001000 00:00 0 bf5c2000-bf5c3000 r--p 00004000 00:00 0 bf5c3000-bf600000 rwxp 00005000 00:00 0 bf7be000-bf7bf000 ---p 00000000 00:00 0 bf7bf000-bf7c2000 rwxp 00001000 00:00 0 bf7c2000-bf7c3000 r--p 00004000 00:00 0 bf7c3000-bf800000 rwxp 00005000 00:00 0 bffbd000-bffc2000 rwxp fffbe000 00:00 0 bffc2000-bffc3000 r--p fffc3000 00:00 0 bffc3000-c0000000 rwxp fffc4000 00:00 0 Full Thread Dump ---------------- PID:2536 "Finalizer" (TID:0x40348708, sys_thread_t:0x80d3c30, state:CW, native ID:0xc04) prio=8 at java.lang.Object.wait(Native Method) at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:114) at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:129) at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:168) ----- Native Stack ----- pthread_setconcurrency at 0x40030b19 in libpthread.so.0 pthread_cond_wait at 0x4002ce2c in libpthread.so.0 condvarWait at 0x402fc225 in libhpi.so sysMonitorWait at 0x402fdf15 in libhpi.so lkMonitorWait at 0x402424b4 in libjvm.so JVM_MonitorWait at 0x40207ade in libjvm.so ?? ivq_doinvoke_I__ at 0x40263951 in libjvm.so ivq_doinvoke_I__ at 0x40263951 in libjvm.so EJivq_doinvoke_V__ at 0x4025eb09 in libjvm.so ?? ------------------------------------------------------------------------- PID:2535 "Reference Handler" (TID:0x40348750, sys_thread_t:0x80cfed8, state:CW, native ID:0x803) prio=10 at java.lang.Object.wait(Native Method) at java.lang.Object.wait(Object.java:421) at java.lang.ref.Reference$ReferenceHandler.run(Reference.java:116) ----- Native Stack ----- pthread_setconcurrency at 0x40030b19 in libpthread.so.0 pthread_cond_wait at 0x4002ce2c in libpthread.so.0 condvarWait at 0x402fc225 in libhpi.so sysMonitorWait at 0x402fdf15 in libhpi.so lkMonitorWait at 0x402424b4 in libjvm.so JVM_MonitorWait at 0x40207ade in libjvm.so ?? ivoq_doinvoke_V__ at 0x40263ea1 in libjvm.so EJivq_doinvoke_V__ at 0x4025eb09 in libjvm.so ?? ------------------------------------------------------------------------- PID:2534 "Signal dispatcher" (TID:0x40348798, sys_thread_t:0x80cb590, state:CW, native ID:0x402) prio=5 ----- Native Stack ----- ?? ------------------------------------------------------------------------- PID:2524 "main" (TID:0x403487e0, sys_thread_t:0x804ff88, state:R, native ID:0x400) prio=5 at org.eclipse.swt.internal.motif.OS.XtSetValues(Native Method) at org.eclipse.swt.widgets.WidgetTable.remove(WidgetTable.java:94) at org.eclipse.swt.widgets.Widget.deregister(Widget.java:236) at org.eclipse.swt.widgets.Scrollable.deregister(Scrollable.java:136) at org.eclipse.swt.widgets.Widget.releaseWidget(Widget.java:651) at org.eclipse.swt.widgets.Control.releaseWidget(Control.java:1448) at org.eclipse.swt.widgets.Scrollable.releaseWidget(Scrollable.java:291) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Canvas.releaseWidget(Canvas.java:129) at org.eclipse.swt.widgets.Decorations.releaseWidget(Decorations.java:327) at org.eclipse.swt.widgets.Shell.releaseWidget(Shell.java:851) at org.eclipse.swt.widgets.Widget.dispose(Widget.java:276) at org.eclipse.swt.widgets.Shell.dispose(Shell.java:562) at org.eclipse.jface.window.Window.close(Window.java:194) at org.eclipse.jface.preference.PreferenceDialog.close(PreferenceDialog.java:204) at org.eclipse.jface.preference.PreferenceDialog.okPressed(PreferenceDialog.java:523) at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(PreferenceDialog.java:166) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:211) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:85) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:489) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java(Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:47) at org.eclipse.jface.action.Action.runWithEvent(Action.java:453) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent(ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0(ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:489) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1561) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1411) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:727) at org.eclipse.ui.internal.Workbench.run(Workbench.java:710) at org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362) ----- Native Stack ----- ------------------------------------------------------------------------- Monitor pool info: Initial monitor count: 32 Minimum number of free monitors before expansion: 5 Pool will next be expanded by: 16 Current total number of monitors: 32 Current number of free monitors: 28 Monitor Pool Dump (inflated object-monitors): sys_mon_t:0x0804f4f8 infl_mon_t: 0x0804f0c8: java.lang.ref.Reference$Lock@4034FE48/4034FE50: <unowned> Waiting to be notified: "Reference Handler" (0x80cfed8) sys_mon_t:0x0804f588 infl_mon_t: 0x0804f108: java.lang.ref.ReferenceQueue$Lock@40352A20/40352A28: <unowned> Waiting to be notified: "Finalizer" (0x80d3c30) JVM System Monitor Dump (registered monitors): ACS Heap lock: <unowned> System Heap lock: <unowned> Sleep lock: <unowned> Method trace lock: <unowned> UTF8 Cache lock: <unowned> Heap lock: owner "main" (0x804ff88) 1 entry Rewrite Code lock: <unowned> Monitor Cache lock: owner "main" (0x804ff88) 1 entry JNI Pinning lock: <unowned> JNI Global Reference lock: <unowned> Classloader lock: <unowned> Linking class lock: <unowned> Binclass lock: <unowned> Monitor Registry lock: owner "main" (0x804ff88) 1 entry Thread queue lock: owner "main" (0x804ff88) 1 entry Thread identifiers (as used in flat monitors): ident 5 "Finalizer" (0x80d3c30) ee 0x080d3a58 ident 4 "Reference Handler" (0x80cfed8) ee 0x080cfd00 ident 3 "Signal dispatcher" (0x80cb590) ee 0x080cb3b8 ident 2 "main" (0x804ff88) ee 0x0804fdb0 Java Object Monitor Dump (flat & inflated object-monitors): java.lang.Class@40320D28/40320D30 locknflags 00020000 Flat locked by threadIdent 2. Entrycount 1 java.lang.ref.Reference$Lock@4034FE48/4034FE50 locknflags 80000200 Monitor inflated infl_mon 0x0804f0c8 java.lang.ref.ReferenceQueue$Lock@40352A20/40352A28 locknflags 80000400 Monitor inflated infl_mon 0x0804f108 ------
resolved fixed
9481d71
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T18:19:40Z"
"2001-11-09T21:06:40Z"
org.eclipse.jdt.ui/core
5,722
Bug 5722 Selecting font crashes eclipse with a javacore
Eclipse V2.0 Build 20011107 OS: RedHat Linux 7.1 JDK version: /opt/IBMJava2-13/bin/ ./java -version java version "1.3.0" Java(TM) 2 Runtime Environment, Standard Edition (build 1.3.0) Classic VM (build 1.3.0, J2RE 1.3.0 IBM build cx130-20010925 (JIT enabled: jitc)) To Reproduce: Startup eclipse (i had a fresh zip with no workspace and i specified no options) Open Window->Preferences->WorkBench->Font Select Text font ( my inital value here was "adobe-courier-regular-12" ) Click Change to bring up font dialog change the font size to 14. And click ok to dismiss the font dialog Click Apply on preferences page. Click OK on preferences Page. At this point eclipse crashes with ----- SIGSEGV 11 '(*) segmentation violation' in process 2524 si_signo [11]: SIGSEGV: (*) segmentation violation si_errno [0]: Success si_code [1]: SEGV_MAPERR [addr: 0x18433808] stackpointer=0xbffc19d8 Writing java dump to javacore2524.1005335380.txt ... OK -----javacore2524.1005335380.txt contents------------------- Fri Nov 9 14:49:40 2001 SIGSEGV received at 14458be5 in unknown. Processing terminated. J2RE 1.3.0 IBM build cx130-20010925 /opt/IBMJava2-13/jre/bin/exe/java -classpath ./startup.jar org.eclipse.core.launcher.Main -ws motif -application org.eclipse.ui.workbench -endsplash ./eclipse -endsplash 2523 System Properties ----------------- Java Home Dir: /opt/IBMJava2-13/jre Java DLL Dir: /opt/IBMJava2-13/jre/bin Sys Classpath: /opt/IBMJava2-13/jre/lib/rt.jar:/opt/IBMJava2-13/jre/lib/i18n.jar:/opt/IBMJava2-13/jre/classes User Args: -Djava.class.path=/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java/sqlj.zip:/home/db2inst1/sqllib/function:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java/runtime.zip:. -Djava.class.path=./startup.jar Current Thread Details ---------------------- PID:2524 "main" (TID:0x403487e0, sys_thread_t:0x804ff88, state:R, native ID:0x400) prio=5 at org.eclipse.swt.internal.motif.OS.XtSetValues(Native Method) at org.eclipse.swt.widgets.WidgetTable.remove(WidgetTable.java:94) at org.eclipse.swt.widgets.Widget.deregister(Widget.java:236) at org.eclipse.swt.widgets.Scrollable.deregister(Scrollable.java:136) at org.eclipse.swt.widgets.Widget.releaseWidget(Widget.java:651) at org.eclipse.swt.widgets.Control.releaseWidget(Control.java:1448) at org.eclipse.swt.widgets.Scrollable.releaseWidget(Scrollable.java:291) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Canvas.releaseWidget(Canvas.java:129) at org.eclipse.swt.widgets.Decorations.releaseWidget(Decorations.java:327) at org.eclipse.swt.widgets.Shell.releaseWidget(Shell.java:851) at org.eclipse.swt.widgets.Widget.dispose(Widget.java:276) at org.eclipse.swt.widgets.Shell.dispose(Shell.java:562) at org.eclipse.jface.window.Window.close(Window.java:194) at org.eclipse.jface.preference.PreferenceDialog.close(PreferenceDialog.java:204) at org.eclipse.jface.preference.PreferenceDialog.okPressed(PreferenceDialog.java:523) at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(PreferenceDialog.java:166) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:211) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:85) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:489) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java(Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:47) at org.eclipse.jface.action.Action.runWithEvent(Action.java:453) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent(ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0(ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:489) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1561) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1411) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:727) at org.eclipse.ui.internal.Workbench.run(Workbench.java:710) at org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362) ----- Native Stack ----- ------------------------------------------------------------------------- Operating Environment --------------------- Host : solipsist.(none) OS Level : 2.4.2-2.#1 Sun Apr 8 20:41:30 EDT 2001 glibc Version : 2.2.2 No. of Procs : 1 Memory Info: total: used: free: shared: buffers: cached: Mem: 393633792 325152768 68481024 0 27418624 164200448 Swap: 526376960 0 526376960 MemTotal: 384408 kB MemFree: 66876 kB MemShared: 0 kB Buffers: 26776 kB Cached: 160352 kB Active: 150980 kB Inact_dirty: 34480 kB Inact_clean: 1668 kB Inact_target: 856 kB HighTotal: 0 kB HighFree: 0 kB LowTotal: 384408 kB LowFree: 66876 kB SwapTotal: 514040 kB SwapFree: 514040 kB User Limits (in bytes except for NOFILE and NPROC) - RLIMIT_FSIZE : infinity RLIMIT_DATA : infinity RLIMIT_STACK : 2093056 RLIMIT_CORE : 1024000000 RLIMIT_NOFILE : 1024 RLIMIT_NPROC : 12286 Application Environment ----------------------- Signal Handlers - SIGQUIT : intrDispatchMD (libhpi.so) SIGILL : intrDispatchMD (libhpi.so) SIGTRAP : intrDispatchMD (libhpi.so) SIGABRT : intrDispatchMD (libhpi.so) SIGFPE : intrDispatchMD (libhpi.so) SIGBUS : intrDispatchMD (libhpi.so) SIGSEGV : intrDispatchMD (libhpi.so) SIGPIPE : ignored SIGUSR1 : sigusr1Handler (libhpi.so) SIGUSR2 : get_self (libhpi.so) Environment Variables - PWD=/home/manahan/eclipse WRASTER_COLOR_RESOLUTION0=4 COLORFGBG=default;default;0 LD_ASSUME_KERNEL=2.2.5 COLORTERM_BCE=Eterm WINDOWID=25165889 ETERM_VERSION=0.9.1 HOSTNAME=solipsist DB2INSTANCE=db2inst1 LD_LIBRARY_PATH=/opt/IBMJava2-13/jre/bin:/opt/IBMJava2-13/jre/bin/classic:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/lib HISTFILESIZE=500 QTDIR=/usr/lib/qt-2.3.0 CLASSPATH=/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java/sqlj.zip:/home/db2inst1/sqllib/function:/home/db2inst1/sqllib/java12/db2java.zip:/home/db2inst1/sqllib/java/runtime.zip:. LESSOPEN=|/usr/bin/lesspipe.sh %s KDEDIR=/usr USER=manahan LS_COLORS= MACHTYPE=i386-redhat-linux-gnu ETERM_USER_ROOT=/home/manahan/.Eterm/themes/Eterm WMAKER_BIN_NAME=/usr/local/bin/wmaker MAIL=/var/spool/mail/manahan INPUTRC=/etc/inputrc BASH_ENV=/home/manahan/.bashrc XMODIFIERS=@im=none LANG=en_US JAVAHOME=/opt/IBMJava2-13/jre LIBPATH=:/home/db2inst1/sqllib/lib COLORTERM=Eterm DISPLAY=:0.0 LOGNAME=manahan SHLVL=1 SHELL=/bin/bash HOSTTYPE=i386 CDPATH=.:/home/manahan:/work:/usr OSTYPE=linux-gnu HISTSIZE=500 IFS= HOME=/home/manahan TERM=Eterm SSH_ASKPASS=/usr/libexec/openssh/gnome-ssh-askpass PATH=.:/opt/IBMJava2-13/bin:.:/bin:/usr/bin:/usr/X11R6/bin:/usr/local/bin:/home/db2inst1/sqllib/java12:/home/manahan/bin:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/java12:/home/db2inst1/sqllib/bin:/home/db2inst1/sqllib/adm:/home/db2inst1/sqllib/misc:/home/manahan/bin ETERM_THEME_ROOT=/home/manahan/.Eterm/themes/Eterm IBM_JAVA_COMMAND_LINE=/opt/IBMJava2-13/jre/bin/exe/java -classpath ./startup.jar org.eclipse.core.launcher.Main -ws motif -application org.eclipse.ui.workbench -endsplash ./eclipse -endsplash 2523 JAVA_MAIN_VM=1076546644 Memory map ---------- 08048000-0804c000 r-xp 00000000 03:06 35165 /opt/IBMJava2-13/jre/bin/exe/java 0804c000-0804d000 rw-p 00003000 03:06 35165 /opt/IBMJava2-13/jre/bin/exe/java 0804d000-08909000 rwxp 00000000 00:00 0 40000000-40016000 r-xp 00000000 03:06 240591 /lib/ld-2.2.2.so 40016000-40017000 rw-p 00015000 03:06 240591 /lib/ld-2.2.2.so 40017000-40018000 rw-p 00000000 00:00 0 40018000-4001a000 r-xp 00000000 03:06 20255 /opt/IBMJava2-13/jre/bin/libxhpi.so 4001a000-4001b000 rw-p 00001000 03:06 20255 /opt/IBMJava2-13/jre/bin/libxhpi.so 4001b000-4001c000 r--p 00000000 03:06 176389 /usr/lib/locale/en_US/LC_IDENTIFICATION 4001c000-4001d000 r--p 00000000 03:06 176390 /usr/lib/locale/en_US/LC_MEASUREMENT 4001d000-4001e000 r--p 00000000 03:06 176393 /usr/lib/locale/en_US/LC_TELEPHONE 4001e000-4001f000 r--p 00000000 03:06 176388 /usr/lib/locale/en_US/LC_ADDRESS 4001f000-40020000 r--p 00000000 03:06 176391 /usr/lib/locale/en_US/LC_NAME 40020000-40021000 r--p 00000000 03:06 176392 /usr/lib/locale/en_US/LC_PAPER 40021000-40022000 r--p 00000000 03:06 304681 /usr/lib/locale/en_US/LC_MESSAGES/SYS_LC_MESSAGES 40022000-40023000 r--p 00000000 03:06 128301 /usr/lib/locale/en_US/LC_MONETARY 40023000-40024000 r--p 00000000 03:06 176394 /usr/lib/locale/en_US/LC_TIME 40024000-40025000 r--p 00000000 03:06 32123 /usr/lib/locale/en_US/LC_NUMERIC 40025000-40026000 rw-p 00000000 00:00 0 40026000-40027000 rw-p 00000000 00:00 0 40027000-40036000 r-xp 00000000 03:06 240636 /lib/libpthread-0.9.so 40036000-4003e000 rw-p 0000e000 03:06 240636 /lib/libpthread-0.9.so 4003e000-40051000 r-xp 00000000 03:06 240609 /lib/libnsl-2.2.2.so 40051000-40053000 rw-p 00012000 03:06 240609 /lib/libnsl-2.2.2.so 40053000-40055000 rw-p 00000000 00:00 0 40055000-40058000 r-xp 00000000 03:06 240604 /lib/libdl-2.2.2.so 40058000-40059000 rw-p 00002000 03:06 240604 /lib/libdl-2.2.2.so 40059000-40182000 r-xp 00000000 03:06 240600 /lib/libc-2.2.2.so 40182000-40187000 rw-p 00128000 03:06 240600 /lib/libc-2.2.2.so 40187000-4018b000 rw-p 00000000 00:00 0 4018b000-402ac000 r-xp 00000000 03:06 35162 /opt/IBMJava2-13/jre/bin/classic/libjvm.so 402ac000-402b8000 rw-p 00120000 03:06 35162 /opt/IBMJava2-13/jre/bin/classic/libjvm.so 402b8000-402d1000 rw-p 00000000 00:00 0 402d1000-402f4000 r-xp 00000000 03:06 240606 /lib/libm-2.2.2.so 402f4000-402f5000 rw-p 00022000 03:06 240606 /lib/libm-2.2.2.so 402f5000-40304000 r-xp 00000000 03:06 20233 /opt/IBMJava2-13/jre/bin/libhpi.so 40304000-40306000 rw-p 0000e000 03:06 20233 /opt/IBMJava2-13/jre/bin/libhpi.so 40306000-44306000 rwxp 00000000 00:00 0 44306000-44407000 rwxp 00000000 00:00 0 44407000-44508000 rwxp 00000000 00:00 0 44508000-44534000 r-xp 00000000 03:06 20237 /opt/IBMJava2-13/jre/bin/libjava.so 44534000-4453b000 rw-p 0002b000 03:06 20237 /opt/IBMJava2-13/jre/bin/libjava.so 4453b000-44549000 r-xp 00000000 03:06 20257 /opt/IBMJava2-13/jre/bin/libzip.so 44549000-4454c000 rw-p 0000d000 03:06 20257 /opt/IBMJava2-13/jre/bin/libzip.so 4454c000-44567000 r--p 00000000 03:06 192455 /usr/lib/locale/en_US/LC_CTYPE 44567000-4456d000 r--p 00000000 03:06 304675 /usr/lib/locale/en_US/LC_COLLATE 4456d000-4456f000 r-xp 00000000 03:06 48382 /usr/lib/gconv/ISO8859-1.so 4456f000-44570000 rw-p 00001000 03:06 48382 /usr/lib/gconv/ISO8859-1.so 44570000-44571000 rw-p 00000000 00:00 0 4457c000-44586000 r-xp 00000000 03:06 240625 /lib/libnss_files-2.2.2.so 44586000-44587000 rw-p 00009000 03:06 240625 /lib/libnss_files-2.2.2.so 44587000-44593000 r-xp 00000000 03:06 242574 /usr/X11R6/lib/libXext.so.6.4 44593000-44595000 rw-p 0000b000 03:06 242574 /usr/X11R6/lib/libXext.so.6.4 44595000-4459b000 r-xp 00000000 03:06 242584 /usr/X11R6/lib/libXp.so.6.2 4459b000-4459d000 rw-p 00005000 03:06 242584 /usr/X11R6/lib/libXp.so.6.2 4459d000-445a5000 r-xp 00000000 03:06 242564 /usr/X11R6/lib/libSM.so.6.0 445a5000-445a6000 rw-p 00007000 03:06 242564 /usr/X11R6/lib/libSM.so.6.0 445a6000-445ba000 r-xp 00000000 03:06 242560 /usr/X11R6/lib/libICE.so.6.3 445ba000-445bb000 rw-p 00013000 03:06 242560 /usr/X11R6/lib/libICE.so.6.3 445bb000-445bd000 rw-p 00000000 00:00 0 445c8000-445eb000 rw-p 00000000 00:00 0 445eb000-4477c000 r-xp 00000000 03:06 20245 /opt/IBMJava2-13/jre/bin/libjitc.so 4477c000-44783000 rw-p 00190000 03:06 20245 /opt/IBMJava2-13/jre/bin/libjitc.so 44783000-44784000 rw-p 00000000 00:00 0 44784000-44805000 rw-p 00000000 00:00 0 44805000-44886000 rw-p 00000000 00:00 0 44886000-44c87000 rw-p 00000000 00:00 0 44c87000-44d08000 rw-p 00000000 00:00 0 44d08000-44d89000 rw-p 00000000 00:00 0 44d89000-44e0a000 rw-p 00000000 00:00 0 44e0a000-44e8b000 rw-p 00000000 00:00 0 44e8b000-44f0c000 rw-p 00000000 00:00 0 44f0c000-44f8d000 rw-p 00000000 00:00 0 44f8d000-4500e000 rw-p 00000000 00:00 0 4500e000-4508f000 rw-p 00000000 00:00 0 4508f000-45175000 rw-p 00000000 00:00 0 45175000-451f6000 rw-p 00000000 00:00 0 451f6000-45277000 rw-p 00000000 00:00 0 45277000-4536b000 rw-p 00000000 00:00 0 4536b000-45448000 rw-p 00000000 00:00 0 45448000-45525000 rw-p 00000000 00:00 0 45525000-45602000 rw-p 00000000 00:00 0 45602000-45683000 rw-p 00000000 00:00 0 45683000-456c9000 r-xp 00000000 03:09 32096 /home/manahan/eclipse/plugins/org.eclipse.swt/ws/motif/libswt-linux-2012.so 456c9000-456cc000 rw-p 00045000 03:09 32096 /home/manahan/eclipse/plugins/org.eclipse.swt/ws/motif/libswt-linux-2012.so 456cc000-45850000 r-xp 00000000 03:09 80259 /home/manahan/eclipse/libXm.so.2 45850000-45863000 rw-p 00183000 03:09 80259 /home/manahan/eclipse/libXm.so.2 45863000-45864000 rw-p 00000000 00:00 0 45864000-4593f000 r-xp 00000000 03:06 242566 /usr/X11R6/lib/libX11.so.6.2 4593f000-45943000 rw-p 000da000 03:06 242566 /usr/X11R6/lib/libX11.so.6.2 45943000-45944000 rw-p 00000000 00:00 0 45944000-4598c000 r-xp 00000000 03:06 242590 /usr/X11R6/lib/libXt.so.6.0 4598c000-45990000 rw-p 00047000 03:06 242590 /usr/X11R6/lib/libXt.so.6.0 45990000-45991000 rw-p 00000000 00:00 0 45991000-45aa2000 rw-p 00000000 00:00 0 45aa2000-45bf2000 rw-p 00000000 00:00 0 45bf2000-45d72000 rw-p 00000000 00:00 0 45d72000-45f01000 rw-p 00000000 00:00 0 45f01000-45f82000 rw-p 00000000 00:00 0 bf3be000-bf3bf000 ---p 00000000 00:00 0 bf3bf000-bf3c2000 rwxp 00001000 00:00 0 bf3c2000-bf3c3000 r--p 00004000 00:00 0 bf3c3000-bf400000 rwxp 00005000 00:00 0 bf5be000-bf5bf000 ---p 00000000 00:00 0 bf5bf000-bf5c2000 rwxp 00001000 00:00 0 bf5c2000-bf5c3000 r--p 00004000 00:00 0 bf5c3000-bf600000 rwxp 00005000 00:00 0 bf7be000-bf7bf000 ---p 00000000 00:00 0 bf7bf000-bf7c2000 rwxp 00001000 00:00 0 bf7c2000-bf7c3000 r--p 00004000 00:00 0 bf7c3000-bf800000 rwxp 00005000 00:00 0 bffbd000-bffc2000 rwxp fffbe000 00:00 0 bffc2000-bffc3000 r--p fffc3000 00:00 0 bffc3000-c0000000 rwxp fffc4000 00:00 0 Full Thread Dump ---------------- PID:2536 "Finalizer" (TID:0x40348708, sys_thread_t:0x80d3c30, state:CW, native ID:0xc04) prio=8 at java.lang.Object.wait(Native Method) at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:114) at java.lang.ref.ReferenceQueue.remove(ReferenceQueue.java:129) at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:168) ----- Native Stack ----- pthread_setconcurrency at 0x40030b19 in libpthread.so.0 pthread_cond_wait at 0x4002ce2c in libpthread.so.0 condvarWait at 0x402fc225 in libhpi.so sysMonitorWait at 0x402fdf15 in libhpi.so lkMonitorWait at 0x402424b4 in libjvm.so JVM_MonitorWait at 0x40207ade in libjvm.so ?? ivq_doinvoke_I__ at 0x40263951 in libjvm.so ivq_doinvoke_I__ at 0x40263951 in libjvm.so EJivq_doinvoke_V__ at 0x4025eb09 in libjvm.so ?? ------------------------------------------------------------------------- PID:2535 "Reference Handler" (TID:0x40348750, sys_thread_t:0x80cfed8, state:CW, native ID:0x803) prio=10 at java.lang.Object.wait(Native Method) at java.lang.Object.wait(Object.java:421) at java.lang.ref.Reference$ReferenceHandler.run(Reference.java:116) ----- Native Stack ----- pthread_setconcurrency at 0x40030b19 in libpthread.so.0 pthread_cond_wait at 0x4002ce2c in libpthread.so.0 condvarWait at 0x402fc225 in libhpi.so sysMonitorWait at 0x402fdf15 in libhpi.so lkMonitorWait at 0x402424b4 in libjvm.so JVM_MonitorWait at 0x40207ade in libjvm.so ?? ivoq_doinvoke_V__ at 0x40263ea1 in libjvm.so EJivq_doinvoke_V__ at 0x4025eb09 in libjvm.so ?? ------------------------------------------------------------------------- PID:2534 "Signal dispatcher" (TID:0x40348798, sys_thread_t:0x80cb590, state:CW, native ID:0x402) prio=5 ----- Native Stack ----- ?? ------------------------------------------------------------------------- PID:2524 "main" (TID:0x403487e0, sys_thread_t:0x804ff88, state:R, native ID:0x400) prio=5 at org.eclipse.swt.internal.motif.OS.XtSetValues(Native Method) at org.eclipse.swt.widgets.WidgetTable.remove(WidgetTable.java:94) at org.eclipse.swt.widgets.Widget.deregister(Widget.java:236) at org.eclipse.swt.widgets.Scrollable.deregister(Scrollable.java:136) at org.eclipse.swt.widgets.Widget.releaseWidget(Widget.java:651) at org.eclipse.swt.widgets.Control.releaseWidget(Control.java:1448) at org.eclipse.swt.widgets.Scrollable.releaseWidget(Scrollable.java:291) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Composite.releaseChildren(Composite.java:489) at org.eclipse.swt.widgets.Composite.releaseWidget(Composite.java:495) at org.eclipse.swt.widgets.Canvas.releaseWidget(Canvas.java:129) at org.eclipse.swt.widgets.Decorations.releaseWidget(Decorations.java:327) at org.eclipse.swt.widgets.Shell.releaseWidget(Shell.java:851) at org.eclipse.swt.widgets.Widget.dispose(Widget.java:276) at org.eclipse.swt.widgets.Shell.dispose(Shell.java:562) at org.eclipse.jface.window.Window.close(Window.java:194) at org.eclipse.jface.preference.PreferenceDialog.close(PreferenceDialog.java:204) at org.eclipse.jface.preference.PreferenceDialog.okPressed(PreferenceDialog.java:523) at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(PreferenceDialog.java:166) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:211) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:85) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:489) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java(Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:47) at org.eclipse.jface.action.Action.runWithEvent(Action.java:453) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent(ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0(ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:489) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1561) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1411) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:727) at org.eclipse.ui.internal.Workbench.run(Workbench.java:710) at org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362) ----- Native Stack ----- ------------------------------------------------------------------------- Monitor pool info: Initial monitor count: 32 Minimum number of free monitors before expansion: 5 Pool will next be expanded by: 16 Current total number of monitors: 32 Current number of free monitors: 28 Monitor Pool Dump (inflated object-monitors): sys_mon_t:0x0804f4f8 infl_mon_t: 0x0804f0c8: java.lang.ref.Reference$Lock@4034FE48/4034FE50: <unowned> Waiting to be notified: "Reference Handler" (0x80cfed8) sys_mon_t:0x0804f588 infl_mon_t: 0x0804f108: java.lang.ref.ReferenceQueue$Lock@40352A20/40352A28: <unowned> Waiting to be notified: "Finalizer" (0x80d3c30) JVM System Monitor Dump (registered monitors): ACS Heap lock: <unowned> System Heap lock: <unowned> Sleep lock: <unowned> Method trace lock: <unowned> UTF8 Cache lock: <unowned> Heap lock: owner "main" (0x804ff88) 1 entry Rewrite Code lock: <unowned> Monitor Cache lock: owner "main" (0x804ff88) 1 entry JNI Pinning lock: <unowned> JNI Global Reference lock: <unowned> Classloader lock: <unowned> Linking class lock: <unowned> Binclass lock: <unowned> Monitor Registry lock: owner "main" (0x804ff88) 1 entry Thread queue lock: owner "main" (0x804ff88) 1 entry Thread identifiers (as used in flat monitors): ident 5 "Finalizer" (0x80d3c30) ee 0x080d3a58 ident 4 "Reference Handler" (0x80cfed8) ee 0x080cfd00 ident 3 "Signal dispatcher" (0x80cb590) ee 0x080cb3b8 ident 2 "main" (0x804ff88) ee 0x0804fdb0 Java Object Monitor Dump (flat & inflated object-monitors): java.lang.Class@40320D28/40320D30 locknflags 00020000 Flat locked by threadIdent 2. Entrycount 1 java.lang.ref.Reference$Lock@4034FE48/4034FE50 locknflags 80000200 Monitor inflated infl_mon 0x0804f0c8 java.lang.ref.ReferenceQueue$Lock@40352A20/40352A28 locknflags 80000400 Monitor inflated infl_mon 0x0804f108 ------
resolved fixed
9481d71
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T18:19:40Z"
"2001-11-09T21:06:40Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/reorg/DeleteRefactoring.java
5,873
Bug 5873 Open Type Dialog doesn't behave as expected for former VAJ users
When using the 'Open Type' dialog in VisualAge for Java, you can type a few letters of the class name, and then use the UP/DOWN arrow keys to quickly select the desired type from the list. In Eclipse, you are required to hit the TAB key or use the mouse to move the focus to the list of types. Since a large number of Eclipse users are likely current/former VAJ users (who would likely consider this a bug), it would be nice if the Eclipse behavior could be changed to match VAJ.
resolved fixed
60187c1
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T19:14:02Z"
"2001-11-13T22:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/AbstractElementListSelectionDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dialogs; import java.util.ArrayList; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.BusyIndicator; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Text; import org.eclipse.core.runtime.IStatus; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.ILabelProvider; /** * An abstract class to select elements out of a list of elements. */ public abstract class AbstractElementListSelectionDialog extends SelectionStatusDialog { private ILabelProvider fRenderer; private boolean fIgnoreCase= true; private boolean fIsMultipleSelection= false; private boolean fMatchEmptyString= true; private boolean fAllowDuplicates= true; private Label fMessage; protected FilteredList fFilteredList; private Text fFilterText; private ISelectionValidator fValidator; private String fFilter= null; private String fEmptyListMessage= ""; //$NON-NLS-1$ private String fEmptySelectionMessage= ""; //$NON-NLS-1$ private int fWidth= 60; private int fHeight= 18; /** * Constructs a list selection dialog. * @param renderer The label renderer used * @param ignoreCase Decides if the match string ignores lower/upppr case * @param multipleSelection Allow multiple selection */ protected AbstractElementListSelectionDialog(Shell parent, ILabelProvider renderer) { super(parent); fRenderer= renderer; } /** * Handles default selection (double click). * By default, the OK button is pressed. */ protected void handleDefaultSelected() { if (validateCurrentSelection()) buttonPressed(IDialogConstants.OK_ID); } /** * Specifies if sorting, filtering and folding is case sensitive. */ public void setIgnoreCase(boolean ignoreCase) { fIgnoreCase= ignoreCase; } /** * Returns if sorting, filtering and folding is case sensitive. */ public boolean isCaseIgnored() { return fIgnoreCase; } /** * Specifies whether everything or nothing should be filtered on * empty filter string. */ public void setMatchEmptyString(boolean matchEmptyString) { fMatchEmptyString= matchEmptyString; } /** * Specifies if multiple selection is allowed. */ public void setMultipleSelection(boolean multipleSelection) { fIsMultipleSelection= multipleSelection; } /** * Specifies whether duplicate entries are displayed or not. */ public void setAllowDuplicates(boolean allowDuplicates) { fAllowDuplicates= allowDuplicates; } /** * Sets the list size in unit of characters. * @param width the width of the list. * @param height the height of the list. */ public void setSize(int width, int height) { fWidth= width; fHeight= height; } /** * Sets the message to be displayed if the list is empty. * @param message the message to be displayed. */ public void setEmptyListMessage(String message) { fEmptyListMessage= message; } /** * Sets the message to be displayed if the selection is empty. * @param message the message to be displayed. */ public void setEmptySelectionMessage(String message) { fEmptySelectionMessage= message; } /** * Sets an optional validator to check if the selection is valid. * The validator is invoked whenever the selection changes. * @param validator the validator to validate the selection. */ public void setValidator(ISelectionValidator validator) { fValidator= validator; } /** * Sets the elements of the list (widget). * To be called within open(). * @param elements the elements of the list. */ protected void setListElements(Object[] elements) { Assert.isNotNull(fFilteredList); fFilteredList.setElements(elements); } /** * Sets the filter pattern. * @param filter the filter pattern. */ public void setFilter(String filter) { if (fFilterText == null) fFilter= filter; else fFilterText.setText(filter); } /** * Returns the current filter pattern. * @return returns the current filter pattern or <code>null<code> if filter was not set. */ public String getFilter() { if (fFilteredList == null) return fFilter; else return fFilteredList.getFilter(); } /** * Returns the indices referring the current selection. * To be called within open(). * @return returns the indices of the current selection. */ protected int[] getSelectionIndices() { Assert.isNotNull(fFilteredList); return fFilteredList.getSelectionIndices(); } /** * Returns an index referring the first current selection. * To be called within open(). * @return returns the indices of the current selection. */ protected int getSelectionIndex() { Assert.isNotNull(fFilteredList); return fFilteredList.getSelectionIndex(); } /** * Sets the selection referenced by an array of elements. * To be called within open(). * @param selection the indices of the selection. */ protected void setSelection(Object[] selection) { Assert.isNotNull(fFilteredList); fFilteredList.setSelection(selection); } /** * Returns an array of the currently selected elements. * To be called within or after open(). * @return returns an array of the currently selected elements. */ protected Object[] getSelectedElements() { Assert.isNotNull(fFilteredList); return fFilteredList.getSelection(); } /** * Returns all elements which are folded together to one entry in the list. * @param index the index selecting the entry in the list. * @return returns an array of elements folded together. */ public Object[] getFoldedElements(int index) { Assert.isNotNull(fFilteredList); return fFilteredList.getFoldedElements(index); } /** * Creates the message text widget and sets layout data. * @param composite the parent composite of the message area. */ protected Label createMessageArea(Composite composite) { Label label= super.createMessageArea(composite); GridData data= new GridData(); data.grabExcessVerticalSpace= false; data.grabExcessHorizontalSpace= true; data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.BEGINNING; label.setLayoutData(data); fMessage= label; return label; } /** * Handles a selection changed event. * By default, the current selection is validated. */ protected void handleSelectionChanged() { validateCurrentSelection(); } /** * Validates the current selection and updates the status line * accordingly. */ protected boolean validateCurrentSelection() { Assert.isNotNull(fFilteredList); IStatus status; Object[] elements= getSelectedElements(); if (elements.length > 0) { if (fValidator != null) { status= fValidator.validate(elements); } else { status= new StatusInfo(); } } else { if (fFilteredList.isEmpty()) { status= new StatusInfo(IStatus.ERROR, fEmptyListMessage); } else { status= new StatusInfo(IStatus.ERROR, fEmptySelectionMessage); } } updateStatus(status); return status.isOK(); } /* * @see Dialog#cancelPressed */ protected void cancelPressed() { setResult(null); super.cancelPressed(); } /** * Creates a filtered list. * @param parent the parent composite. * @return returns the filtered list widget. */ protected FilteredList createFilteredList(Composite parent) { int flags= SWT.BORDER | SWT.V_SCROLL | SWT.H_SCROLL | (fIsMultipleSelection ? SWT.MULTI : SWT.SINGLE); FilteredList list= new FilteredList(parent, flags, fRenderer, fIgnoreCase, fAllowDuplicates, fMatchEmptyString); GridData data= new GridData(); data.widthHint= convertWidthInCharsToPixels(fWidth); data.heightHint= convertHeightInCharsToPixels(fHeight); data.grabExcessVerticalSpace= true; data.grabExcessHorizontalSpace= true; data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.FILL; list.setLayoutData(data); list.setFilter((fFilter == null ? "" : fFilter)); //$NON-NLS-1$ list.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { handleDefaultSelected(); } public void widgetSelected(SelectionEvent e) { handleSelectionChanged(); } }); fFilteredList= list; return list; } protected Text createFilterText(Composite parent) { Text text= new Text(parent, SWT.BORDER); GridData data= new GridData(); data.grabExcessVerticalSpace= false; data.grabExcessHorizontalSpace= true; data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.BEGINNING; text.setLayoutData(data); text.setText((fFilter == null ? "" : fFilter)); //$NON-NLS-1$ Listener listener= new Listener() { public void handleEvent(Event e) { fFilteredList.setFilter(fFilterText.getText()); } }; text.addListener(SWT.Modify, listener); fFilterText= text; return text; } /* * @see Window#open() */ public int open() { BusyIndicator.showWhile(null, new Runnable() { public void run() { access$superOpen(); } }); return getReturnCode(); } private void access$superOpen() { super.open(); } /* * @see Window#create(Shell) */ public void create() { super.create(); Assert.isNotNull(fFilteredList); if (fFilteredList.isEmpty()) { handleEmptyList(); } else { validateCurrentSelection(); fFilterText.selectAll(); fFilterText.setFocus(); } } /** * Handles empty list by disabling widgets. */ protected void handleEmptyList() { fMessage.setEnabled(false); fFilterText.setEnabled(false); fFilteredList.setEnabled(false); } }
5,886
Bug 5886 refactoring wizard: NPE
1. run self encapsulate field 2. press 'next' on the first page - you get the preview' 3. press 'back' on the preview page java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ChangeElementTreeViewer.initializeChildr en(ChangeElementTreeViewer.java:61) at org.eclipse.jdt.internal.ui.refactoring.ChangeElementTreeViewer.inputChanged (ChangeElementTreeViewer.java:57) at org.eclipse.jface.viewers.ContentViewer.setInput (ContentViewer.java:234) at org.eclipse.jface.viewers.StructuredViewer.setInput (StructuredViewer.java:659) at org.eclipse.jdt.internal.ui.refactoring.NewPreviewWizardPage.setChange (NewPreviewWizardPage.java:132) at org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard.setChange (RefactoringWizard.java:110) at org.eclipse.jdt.internal.ui.refactoring.UserInputWizardPage.setVisible (UserInputWizardPage.java:94) at org.eclipse.jdt.internal.ui.refactoring.TextInputWizardPage.setVisible (TextInputWizardPage.java:153) at org.eclipse.jface.wizard.WizardDialog.showPage(WizardDialog.java:882) at org.eclipse.jface.wizard.WizardDialog.backPressed (WizardDialog.java:291) at org.eclipse.jface.wizard.WizardDialog.buttonPressed (WizardDialog.java:303) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:211) at org.eclipse.swt.widgets.TypedListener.handleEvent (TypedListener.java:85) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:635) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1365) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1167) at org.eclipse.jface.window.Window.runEventLoop(Window.java:536) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringAction.activateRefact oringWizard(RefactoringAction.java:65) at org.eclipse.jdt.internal.ui.reorg.RefactoringSupportFactory$RenameSupport.rename (RefactoringSupportFactory.java:57) at org.eclipse.jdt.internal.ui.reorg.RenameAction.run (RenameAction.java:27) at org.eclipse.jface.action.Action.runWithEvent(Action.java:453) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:635) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1365) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1167) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:729) at org.eclipse.ui.internal.Workbench.run(Workbench.java:712) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52) at ZRHMain.main(ZRHMain.java:14) Log: Wed Nov 14 15:07:59 GMT+01:00 2001
resolved fixed
05272cb
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T19:23:28Z"
"2001-11-14T15:00:00Z"
org.eclipse.jdt.ui/ui
5,886
Bug 5886 refactoring wizard: NPE
1. run self encapsulate field 2. press 'next' on the first page - you get the preview' 3. press 'back' on the preview page java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ChangeElementTreeViewer.initializeChildr en(ChangeElementTreeViewer.java:61) at org.eclipse.jdt.internal.ui.refactoring.ChangeElementTreeViewer.inputChanged (ChangeElementTreeViewer.java:57) at org.eclipse.jface.viewers.ContentViewer.setInput (ContentViewer.java:234) at org.eclipse.jface.viewers.StructuredViewer.setInput (StructuredViewer.java:659) at org.eclipse.jdt.internal.ui.refactoring.NewPreviewWizardPage.setChange (NewPreviewWizardPage.java:132) at org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard.setChange (RefactoringWizard.java:110) at org.eclipse.jdt.internal.ui.refactoring.UserInputWizardPage.setVisible (UserInputWizardPage.java:94) at org.eclipse.jdt.internal.ui.refactoring.TextInputWizardPage.setVisible (TextInputWizardPage.java:153) at org.eclipse.jface.wizard.WizardDialog.showPage(WizardDialog.java:882) at org.eclipse.jface.wizard.WizardDialog.backPressed (WizardDialog.java:291) at org.eclipse.jface.wizard.WizardDialog.buttonPressed (WizardDialog.java:303) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:211) at org.eclipse.swt.widgets.TypedListener.handleEvent (TypedListener.java:85) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:635) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1365) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1167) at org.eclipse.jface.window.Window.runEventLoop(Window.java:536) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringAction.activateRefact oringWizard(RefactoringAction.java:65) at org.eclipse.jdt.internal.ui.reorg.RefactoringSupportFactory$RenameSupport.rename (RefactoringSupportFactory.java:57) at org.eclipse.jdt.internal.ui.reorg.RenameAction.run (RenameAction.java:27) at org.eclipse.jface.action.Action.runWithEvent(Action.java:453) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:635) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1365) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1167) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:729) at org.eclipse.ui.internal.Workbench.run(Workbench.java:712) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52) at ZRHMain.main(ZRHMain.java:14) Log: Wed Nov 14 15:07:59 GMT+01:00 2001
resolved fixed
05272cb
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-14T19:23:28Z"
"2001-11-14T15:00:00Z"
refactoring/org/eclipse/jdt/internal/ui/refactoring/ChangeElementTreeViewer.java
5,804
Bug 5804 Bug in ClassFileEditor.getCorrespondingElement
protected IJavaElement getCorrespondingElement(IJavaElement element) { IJavaElement parent= JavaModelUtil.findParentOfKind(element, IJavaElement.CLASS_FILE); return (parent == this ? element : null); } 'this' is a ClassFileEditor, so parent will never be 'this'
resolved fixed
1b248b4
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-15T11:10:25Z"
"2001-11-12T18:33:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.action.IMenuManager; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorSite; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IMemento; import org.eclipse.ui.PartInitException; import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.util.JavaModelUtil; /** * Java specific text editor. */ public class ClassFileEditor extends JavaEditor { /** * Default constructor. */ public ClassFileEditor() { super(); setDocumentProvider(JavaPlugin.getDefault().getClassFileDocumentProvider()); setEditorContextMenuId("#ClassFileEditorContext"); //$NON-NLS-1$ setRulerContextMenuId("#ClassFileRulerContext"); //$NON-NLS-1$ setOutlinerContextMenuId("#ClassFileOutlinerContext"); //$NON-NLS-1$ } /** * @see AbstractTextEditor#createActions */ protected void createActions() { super.createActions(); setAction(ITextEditorActionConstants.SAVE, null); setAction(ITextEditorActionConstants.REVERT_TO_SAVED, null); setAction("AddBreakpoint", new AddBreakpointAction(this)); //$NON-NLS-1$ setAction("ManageBreakpoints", new BreakpointRulerAction(getVerticalRuler(), this)); //$NON-NLS-1$ /* * 1GF82PL: ITPJUI:ALL - Need to be able to add bookmark to classfile * * // replace default action with class file specific ones * * setAction(ITextEditorActionConstants.BOOKMARK, new AddClassFileMarkerAction("AddBookmark.", this, IMarker.BOOKMARK, true)); //$NON-NLS-1$ * setAction(ITextEditorActionConstants.ADD_TASK, new AddClassFileMarkerAction("AddTask.", this, IMarker.TASK, false)); //$NON-NLS-1$ * setAction(ITextEditorActionConstants.RULER_MANAGE_BOOKMARKS, new ClassFileMarkerRulerAction("ManageBookmarks.", getVerticalRuler(), this, IMarker.BOOKMARK, true)); //$NON-NLS-1$ * setAction(ITextEditorActionConstants.RULER_MANAGE_TASKS, new ClassFileMarkerRulerAction("ManageTasks.", getVerticalRuler(), this, IMarker.TASK, true)); //$NON-NLS-1$ */ setAction(ITextEditorActionConstants.BOOKMARK, null); setAction(ITextEditorActionConstants.ADD_TASK, null); setAction(ITextEditorActionConstants.RULER_MANAGE_BOOKMARKS, null); setAction(ITextEditorActionConstants.RULER_MANAGE_TASKS, null); setAction(ITextEditorActionConstants.RULER_DOUBLE_CLICK, getAction("ManageBreakpoints")); //$NON-NLS-1$ } /* * @see JavaEditor#getElementAt */ protected IJavaElement getElementAt(int offset) { if (getEditorInput() instanceof IClassFileEditorInput) { try { IClassFileEditorInput input= (IClassFileEditorInput) getEditorInput(); return input.getClassFile().getElementAt(offset); } catch (JavaModelException x) { } } return null; } /* * @see JavaEditor#getCorrespondingElement(IJavaElement) */ protected IJavaElement getCorrespondingElement(IJavaElement element) { IJavaElement parent= JavaModelUtil.findParentOfKind(element, IJavaElement.CLASS_FILE); return (parent == this ? element : null); } /** * @see EditorPart#init(IEditorSite, IEditorInput) */ public void init(IEditorSite site, IEditorInput input) throws PartInitException { if (input instanceof IFileEditorInput) { IFile file= ((IFileEditorInput) input).getFile(); IClassFileEditorInput classFileInput= new ExternalClassFileEditorInput(file); if (classFileInput.getClassFile() != null) input= classFileInput; } if (!(input instanceof IClassFileEditorInput)) throw new PartInitException(JavaEditorMessages.getString("ClassFileEditor.error.invalid_input_message")); //$NON-NLS-1$ super.init(site, input); } /** * @see IEditorPart#saveState(IMemento) */ public void saveState(IMemento memento) { } /** * @see AbstractTextEditor#editorContextMenuAboutToShow */ public void editorContextMenuAboutToShow(IMenuManager menu) { super.editorContextMenuAboutToShow(menu); if (getEditorInput() instanceof IClassFileEditorInput) { IClassFileEditorInput input= (IClassFileEditorInput) getEditorInput(); IClassFile file= input.getClassFile(); try { if (file.getSource() != null) addAction(menu, ITextEditorActionConstants.GROUP_ADD, "AddBreakpoint"); //$NON-NLS-1$ } catch (JavaModelException x) { // ignore } } } /** * @see AbstractTextEditor#rulerContextMenuAboutToShow */ protected void rulerContextMenuAboutToShow(IMenuManager menu) { super.rulerContextMenuAboutToShow(menu); if (getEditorInput() instanceof IClassFileEditorInput) { IClassFileEditorInput input= (IClassFileEditorInput) getEditorInput(); IClassFile file= input.getClassFile(); try { if (file.getSource() != null) addAction(menu, "ManageBreakpoints"); //$NON-NLS-1$ } catch (JavaModelException x) { // ignore } } } /** * @see JavaEditor#setOutlinePageInput(JavaOutlinePage, IEditorInput) */ protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input) { if (page != null && input instanceof IClassFileEditorInput) { IClassFileEditorInput cfi= (IClassFileEditorInput) input; page.setInput(cfi.getClassFile()); } } /* * 1GEPKT5: ITPJUI:Linux - Source in editor for external classes is editable * Removed methods isSaveOnClosedNeeded and isDirty. * Added method isEditable. */ /** * @see AbstractTextEditor#isEditable() */ public boolean isEditable() { return false; } /* * @see AbstractTextEditor#doSetInput(IEditorInput) */ protected void doSetInput(IEditorInput input) throws CoreException { if (input instanceof ExternalClassFileEditorInput) { ExternalClassFileEditorInput classFileInput= (ExternalClassFileEditorInput) input; IFile file= classFileInput.getFile(); try { file.refreshLocal(IResource.DEPTH_INFINITE, null); } catch (CoreException x) { JavaPlugin.log(x); } } super.doSetInput(input); } }
5,818
Bug 5818 Debugger Source Lookup page claims project is closed
I have a Java project in my workspace, and it is not closed. Upon starting the workbench, Project->Properties->Debugger Source Lookup, the page claims that debugger source lookup is not available for closed projects. If I force a build of the project, it works as expected. If I close the workbench and restart, I get the same problem. 20011106
verified fixed
6601def
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-15T22:16:48Z"
"2001-11-12T21:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/launcher/JavaProjectPropertyPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.launcher; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Label; import org.eclipse.core.resources.IProject; import org.eclipse.core.runtime.CoreException; import org.eclipse.ui.dialogs.PropertyPage; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.internal.ui.JavaPlugin; /* * The page for setting java runtime */ public abstract class JavaProjectPropertyPage extends PropertyPage { private boolean fHasJavaContents; public final Control createContents(Composite parent) { IJavaProject jproject= getJavaProject(); if (jproject != null && jproject.isOpen()) { fHasJavaContents= true; return createJavaContents(parent); } else { return createClosedContents(parent); } } protected abstract boolean performJavaOk(); protected abstract Control createJavaContents(Composite parent); protected Control createClosedContents(Composite parent) { Label label= new Label(parent, SWT.LEFT); label.setText(LauncherMessages.getString("javaProjectPropertyPage.closed")); return label; } final public boolean performOk() { if (fHasJavaContents) { return performJavaOk(); } return true; } protected IJavaProject getJavaProject() { Object obj= getElement(); if (obj instanceof IProject) { IProject p= (IProject)obj; try { if (p.hasNature(JavaCore.NATURE_ID)) { return JavaCore.create(p); } } catch (CoreException e) { JavaPlugin.log(e.getStatus()); } } else if (obj instanceof IJavaProject) { return (IJavaProject)obj; } return null; } }
5,889
Bug 5889 NPE on copying source folder
try copying a source folder to another project: java.lang.NullPointerException at org.eclipse.core.runtime.Path.append(Path.java(Compiled Code)) at org.eclipse.jdt.internal.core.refactoring.changes.AddToClasspathChange.<init> (AddToClasspathChange.java:39) at org.eclipse.jdt.internal.core.refactoring.reorg.CopyRefactoring.createChange (CopyRefactoring.java:143) at org.eclipse.jdt.internal.core.refactoring.reorg.ReorgRefactoring.createChange (ReorgRefactoring.java:188) at org.eclipse.jdt.internal.core.refactoring.reorg.ReorgRefactoring.createChange (ReorgRefactoring.java:175) at org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation.run (CreateChangeOperation.java:102) at org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation.run (PerformChangeOperation.java:118) at org.eclipse.jface.operation.ModalContext.runInCurrentThread (ModalContext.java:296) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:249) at org.eclipse.jface.dialogs.ProgressMonitorDialog.run (ProgressMonitorDialog.java:335) at org.eclipse.jdt.internal.ui.reorg.ReorgAction.perform (ReorgAction.java:52) at org.eclipse.jdt.internal.ui.reorg.ReorgDestinationAction.doReorg (ReorgDestinationAction.java:151) at org.eclipse.jdt.internal.ui.reorg.ReorgDestinationAction.run (ReorgDestinationAction.java:93) at org.eclipse.jface.action.Action.runWithEvent(Action.java:453) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:635) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1365) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1167) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:729) at org.eclipse.ui.internal.Workbench.run(Workbench.java:712) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52) at ZRHMain.main(ZRHMain.java:14) Log: Wed Nov 14 15:32:40 GMT+01:00 2001
resolved fixed
315711d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-16T16:35:18Z"
"2001-11-14T15:00:00Z"
org.eclipse.jdt.ui/core
5,889
Bug 5889 NPE on copying source folder
try copying a source folder to another project: java.lang.NullPointerException at org.eclipse.core.runtime.Path.append(Path.java(Compiled Code)) at org.eclipse.jdt.internal.core.refactoring.changes.AddToClasspathChange.<init> (AddToClasspathChange.java:39) at org.eclipse.jdt.internal.core.refactoring.reorg.CopyRefactoring.createChange (CopyRefactoring.java:143) at org.eclipse.jdt.internal.core.refactoring.reorg.ReorgRefactoring.createChange (ReorgRefactoring.java:188) at org.eclipse.jdt.internal.core.refactoring.reorg.ReorgRefactoring.createChange (ReorgRefactoring.java:175) at org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation.run (CreateChangeOperation.java:102) at org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation.run (PerformChangeOperation.java:118) at org.eclipse.jface.operation.ModalContext.runInCurrentThread (ModalContext.java:296) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:249) at org.eclipse.jface.dialogs.ProgressMonitorDialog.run (ProgressMonitorDialog.java:335) at org.eclipse.jdt.internal.ui.reorg.ReorgAction.perform (ReorgAction.java:52) at org.eclipse.jdt.internal.ui.reorg.ReorgDestinationAction.doReorg (ReorgDestinationAction.java:151) at org.eclipse.jdt.internal.ui.reorg.ReorgDestinationAction.run (ReorgDestinationAction.java:93) at org.eclipse.jface.action.Action.runWithEvent(Action.java:453) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:635) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1365) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1167) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:729) at org.eclipse.ui.internal.Workbench.run(Workbench.java:712) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52) at ZRHMain.main(ZRHMain.java:14) Log: Wed Nov 14 15:32:40 GMT+01:00 2001
resolved fixed
315711d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-16T16:35:18Z"
"2001-11-14T15:00:00Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/reorg/CopyRefactoring.java
6,008
Bug 6008 deleting a source folder does not remove it from classpath
see summary
resolved fixed
2f25eb8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-16T17:13:26Z"
"2001-11-16T14:13:20Z"
org.eclipse.jdt.ui/core
6,008
Bug 6008 deleting a source folder does not remove it from classpath
see summary
resolved fixed
2f25eb8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-16T17:13:26Z"
"2001-11-16T14:13:20Z"
refactoring/org/eclipse/jdt/internal/core/refactoring/reorg/DeleteRefactoring.java
5,810
Bug 5810 Walkback during text delete/save in Java Editor
Log: Mon Nov 12 14:53:10 EST 2001 4 org.eclipse.jdt.ui 1 Internal Error Java Model Exception: Java Model Status [org.eclipse.swt.custom does not exist.] at org.eclipse.jdt.internal.core.JavaElement.newNotPresentException (JavaElement.java:442) at org.eclipse.jdt.internal.core.JavaElement.openHierarchy (JavaElement.java:471) at org.eclipse.jdt.internal.core.JavaElement.getElementInfo (JavaElement.java(Compiled Code)) at org.eclipse.jdt.internal.core.SourceRefElement.getSourceRange (SourceRefElement.java(Compiled Code)) at org.eclipse.jdt.internal.core.JavaElement.getSourceElementAt (JavaElement.java:375) at org.eclipse.jdt.internal.core.CompilationUnit.getElementAt (CompilationUnit.java:282) at org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider$Adapter.asStruct uredSelection(StructuredSelectionProvider.java:74) at org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider$Adapter.asStruct uredSelection(StructuredSelectionProvider.java:48) at org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider$SelectionService Adapter.getSelection(StructuredSelectionProvider.java:142) at org.eclipse.jdt.internal.ui.actions.OpenSuperImplementationAction.getMethod (OpenSuperImplementationAction.java:69) at org.eclipse.jdt.internal.ui.actions.OpenSuperImplementationAction.canOperateOn (OpenSuperImplementationAction.java:61) at org.eclipse.jdt.internal.ui.actions.OpenSuperImplementationAction.update (OpenSuperImplementationAction.java:57) at org.eclipse.ui.texteditor.AbstractTextEditor.addAction (AbstractTextEditor.java:1694) at org.eclipse.jdt.internal.ui.javaeditor.JavaEditor.editorContextMenuAboutToShow (JavaEditor.java:137) at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor.editorContextMenuAb outToShow(CompilationUnitEditor.java:482) at org.eclipse.ui.texteditor.AbstractTextEditor$2.menuAboutToShow (AbstractTextEditor.java:658) at org.eclipse.jface.action.MenuManager.fireAboutToShow (MenuManager.java:220) at org.eclipse.jface.action.MenuManager.handleAboutToShow (MenuManager.java:253) at org.eclipse.jface.action.MenuManager.access$0(MenuManager.java:250) at org.eclipse.jface.action.MenuManager$1.menuShown (MenuManager.java:280) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:2901) at org.eclipse.swt.widgets.Control.windowProc(Control.java(Compiled Code)) at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java (Compiled Code)) at org.eclipse.swt.widgets.Display.windowProc(Display.java(Compiled Code)) at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method) at org.eclipse.swt.widgets.Menu.setVisible(Menu.java:740) at org.eclipse.swt.widgets.Control.WM_CONTEXTMENU(Control.java:2726) at org.eclipse.swt.widgets.Control.windowProc(Control.java(Compiled Code)) at org.eclipse.swt.widgets.Display.windowProc(Display.java(Compiled Code)) at org.eclipse.swt.internal.win32.OS.CallWindowProcA(Native Method) at org.eclipse.swt.internal.BidiUtil.windowProc(BidiUtil.java(Compiled Code)) at org.eclipse.swt.internal.BidiUtil.windowProc(BidiUtil.java(Compiled Code)) at org.eclipse.swt.internal.win32.OS.DefWindowProcA(Native Method) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java (Compiled Code)) at org.eclipse.swt.widgets.Scrollable.callWindowProc(Scrollable.java (Compiled Code)) at org.eclipse.swt.widgets.Control.WM_RBUTTONUP(Control.java:3560) at org.eclipse.swt.widgets.Control.windowProc(Control.java(Compiled Code)) at org.eclipse.swt.widgets.Display.windowProc(Display.java(Compiled Code)) at org.eclipse.swt.internal.win32.OS.CallWindowProcA(Native Method) at org.eclipse.swt.internal.BidiUtil.windowProc(BidiUtil.java(Compiled Code)) at org.eclipse.swt.internal.BidiUtil.windowProc(BidiUtil.java(Compiled Code)) at org.eclipse.swt.internal.win32.OS.DispatchMessageA(Native Method) at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:710) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362) 4 org.eclipse.jdt.core 969 org.eclipse.swt.custom does not exist.
resolved fixed
f73c16a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-19T17:52:57Z"
"2001-11-12T18:33:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OpenSuperImplementationAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.actions; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IAction; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IObjectActionDelegate; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.texteditor.IUpdate; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.util.JavaModelUtil; /** * On a selected method; opens the implementation in the super type (if existing) */ public class OpenSuperImplementationAction extends Action implements IUpdate, IObjectActionDelegate { private int fFoo; private StructuredSelectionProvider fSelectionProvider; /** * Use only for IWorkbenchWindowActionDelegates! */ public OpenSuperImplementationAction() { this(null); } public OpenSuperImplementationAction(StructuredSelectionProvider provider) { super(); setText(JavaUIMessages.getString("OpenSuperImplementationAction.label")); //$NON-NLS-1$ setDescription(JavaUIMessages.getString("OpenSuperImplementationAction.description")); //$NON-NLS-1$ setToolTipText(JavaUIMessages.getString("OpenSuperImplementationAction.tooltip")); //$NON-NLS-1$ fSelectionProvider= provider; } public void update() { setEnabled(canOperateOn()); } private boolean canOperateOn() { return getMethod() != null; } private IMethod getMethod() { if (fSelectionProvider == null) { return null; } IStructuredSelection selection= fSelectionProvider.getSelection(StructuredSelectionProvider.FLAGS_DO_ELEMENT_AT_OFFSET); if (selection.size() != 1) return null; try { Object element= selection.getFirstElement(); if (element instanceof IMethod) { IMethod method= (IMethod) element; int flags= method.getFlags(); if (!Flags.isStatic(flags) && !Flags.isPrivate(flags)) { return method; } } } catch (JavaModelException e) { JavaPlugin.log(e); } return null; } public void run() { IMethod method= getMethod(); if (method == null) { return; } try { IType declaringType= method.getDeclaringType(); ICompilationUnit cu= declaringType.getCompilationUnit(); if (cu != null && cu.isWorkingCopy()) { declaringType= (IType) cu.getOriginal(declaringType); if (!declaringType.exists()) { return; } } ITypeHierarchy hierarchy= declaringType.newSupertypeHierarchy(null); IMethod impl= JavaModelUtil.findMethodImplementationInHierarchy(hierarchy, method.getElementName(), method.getParameterTypes(), method.isConstructor()); if (impl != null) { IEditorPart part= EditorUtility.openInEditor(impl); EditorUtility.revealInEditor(part, impl); } } catch (CoreException e) { JavaPlugin.log(e); String title= JavaUIMessages.getString("OpenSuperImplementationAction.error.title"); String message= JavaUIMessages.getString("OpenSuperImplementationAction.error.message"); ErrorDialog.openError(JavaPlugin.getActiveWorkbenchShell(), title, message, e.getStatus()); } } /* * @see IActionDelegate#run(IAction) */ public void run(IAction action) { run(); } /* * @see IActionDelegate#selectionChanged(IAction, ISelection) */ public void selectionChanged(IAction action, ISelection selection) { } /* * @see IObjectActionDelegate#setActivePart(IAction, IWorkbenchPart) */ public void setActivePart(IAction action, IWorkbenchPart targetPart) { fSelectionProvider= StructuredSelectionProvider.createFrom(targetPart.getSite().getWorkbenchWindow().getSelectionService()); } }
5,820
Bug 5820 Close all editors brings up hierarchy of object
Build: 1107 1. Open a Java editor in the Java perspective 2. Select the project 3. Hit Ctrl-Shift-F4 The hierarchy for Object appears after ~30 seconds. This is very confusing.
verified fixed
13251cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-19T17:53:15Z"
"2001-11-13T00:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerPart.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.packageview; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IPath; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IOpenable; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.compare.JavaAddElementFromHistory; import org.eclipse.jdt.internal.ui.compare.JavaReplaceWithEditionAction; import org.eclipse.jdt.internal.ui.dnd.DelegatingDragAdapter; import org.eclipse.jdt.internal.ui.dnd.DelegatingDropAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.dnd.ResourceTransferDragAdapter; import org.eclipse.jdt.internal.ui.dnd.TransferDragSourceListener; import org.eclipse.jdt.internal.ui.dnd.TransferDropTargetListener; import org.eclipse.jdt.internal.ui.javaeditor.IClassFileEditorInput; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.javaeditor.JarEntryEditorInput; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.IPreferencesConstants; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringAction; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringGroup; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; import org.eclipse.jdt.internal.ui.reorg.DeleteAction; import org.eclipse.jdt.internal.ui.reorg.ReorgGroup; import org.eclipse.jdt.internal.ui.search.JavaSearchGroup; import org.eclipse.jdt.internal.ui.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.util.OpenTypeHierarchyUtil; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementSorter; import org.eclipse.jdt.internal.ui.viewsupport.MarkerErrorTickProvider; import org.eclipse.jdt.internal.ui.viewsupport.ProblemTreeViewer; import org.eclipse.jdt.internal.ui.viewsupport.StatusBarUpdater; import org.eclipse.jdt.internal.ui.wizards.NewGroup; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.IPackagesViewPart; import org.eclipse.jdt.ui.JavaElementContentProvider; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.DecoratingLabelProvider; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ILabelDecorator; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.ITreeViewerListener; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.TreeExpansionEvent; import org.eclipse.jface.viewers.TreeViewer; import org.eclipse.search.ui.IWorkingSet; import org.eclipse.search.ui.SearchUI; import org.eclipse.swt.SWT; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DragSource; import org.eclipse.swt.dnd.DropTargetEvent; import org.eclipse.swt.dnd.FileTransfer; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.ScrollBar; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Tree; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IMemento; import org.eclipse.ui.IPartListener; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IViewSite; import org.eclipse.ui.IWorkbenchActionConstants; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.PartInitException; import org.eclipse.ui.actions.OpenPerspectiveMenu; import org.eclipse.ui.actions.OpenWithMenu; import org.eclipse.ui.actions.RefreshAction; import org.eclipse.ui.dialogs.PropertyDialogAction; import org.eclipse.ui.help.ViewContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.ISetSelectionTarget; import org.eclipse.ui.part.ResourceTransfer; import org.eclipse.ui.part.ViewPart; import org.eclipse.ui.views.internal.framelist.BackAction; import org.eclipse.ui.views.internal.framelist.ForwardAction; import org.eclipse.ui.views.internal.framelist.FrameList; import org.eclipse.ui.views.internal.framelist.GoIntoAction; import org.eclipse.ui.views.internal.framelist.UpAction; /** * The ViewPart for the ProjectExplorer. It listens to part activation events. * When selection linking with the editor is enabled the view selection tracks * the active editor page. Similarly when a resource is selected in the packages * view the corresponding editor is activated. */ public class PackageExplorerPart extends ViewPart implements ISetSelectionTarget, IMenuListener, IPackagesViewPart, IPropertyChangeListener { public final static String VIEW_ID= JavaUI.ID_PACKAGES; // Persistance tags. static final String TAG_SELECTION= "selection"; //$NON-NLS-1$ static final String TAG_EXPANDED= "expanded"; //$NON-NLS-1$ static final String TAG_ELEMENT= "element"; //$NON-NLS-1$ static final String TAG_PATH= "path"; //$NON-NLS-1$ static final String TAG_VERTICAL_POSITION= "verticalPosition"; //$NON-NLS-1$ static final String TAG_HORIZONTAL_POSITION= "horizontalPosition"; //$NON-NLS-1$ static final String TAG_FILTERS = "filters"; //$NON-NLS-1$ static final String TAG_FILTER = "filter"; //$NON-NLS-1$ static final String TAG_SHOWLIBRARIES = "showLibraries"; //$NON-NLS-1$ static final String TAG_SHOWBINARIES = "showBinaries"; //$NON-NLS-1$ static final String TAG_WORKINGSET = "workingset"; //$NON-NLS-1$ private JavaElementPatternFilter fPatternFilter= new JavaElementPatternFilter(); private LibraryFilter fLibraryFilter= new LibraryFilter(); private BinaryProjectFilter fBinaryFilter= new BinaryProjectFilter(); private WorkingSetFilter fWorkingSetFilter= new WorkingSetFilter(); private ProblemTreeViewer fViewer; private PackagesFrameSource fFrameSource; private FrameList fFrameList; private ContextMenuGroup[] fStandardGroups; private Menu fContextMenu; private OpenResourceAction fOpenCUAction; private Action fOpenToAction; private Action fShowTypeHierarchyAction; private Action fShowNavigatorAction; private Action fPropertyDialogAction; private RefactoringAction fDeleteAction; private RefreshAction fRefreshAction; private BackAction fBackAction; private ForwardAction fForwardAction; private GoIntoAction fZoomInAction; private UpAction fUpAction; private GotoTypeAction fGotoTypeAction; private GotoPackageAction fGotoPackageAction; private AddBookmarkAction fAddBookmarkAction; private FilterSelectionAction fFilterAction; private ShowLibrariesAction fShowLibrariesAction; private ShowBinariesAction fShowBinariesAction; private FilterWorkingSetAction fFilterWorkingSetAction; private RemoveWorkingSetFilterAction fRemoveWorkingSetAction; private IMemento fMemento; private ISelectionChangedListener fSelectionListener; private IPartListener fPartListener= new IPartListener() { public void partActivated(IWorkbenchPart part) { if (part instanceof IEditorPart) editorActivated((IEditorPart) part); } public void partBroughtToTop(IWorkbenchPart part) { } public void partClosed(IWorkbenchPart part) { } public void partDeactivated(IWorkbenchPart part) { } public void partOpened(IWorkbenchPart part) { } }; private ITreeViewerListener fExpansionListener= new ITreeViewerListener() { public void treeCollapsed(TreeExpansionEvent event) { } public void treeExpanded(TreeExpansionEvent event) { Object element= event.getElement(); if (element instanceof ICompilationUnit || element instanceof IClassFile) expandMainType(element); } }; public PackageExplorerPart() { } /* (non-Javadoc) * Method declared on IViewPart. */ public void init(IViewSite site, IMemento memento) throws PartInitException { super.init(site, memento); fMemento= memento; } /** * Initializes the default preferences */ public static void initDefaults(IPreferenceStore store) { store.setDefault(TAG_SHOWLIBRARIES, true); store.setDefault(TAG_SHOWBINARIES, true); } /** * Returns the package explorer part of the active perspective. If * there isn't any package explorer part <code>null</code> is returned. */ public static PackageExplorerPart getFromActivePerspective() { IViewPart view= JavaPlugin.getActivePage().findView(VIEW_ID); if (view instanceof PackageExplorerPart) return (PackageExplorerPart)view; return null; } /** * Makes the package explorer part visible in the active perspective. If there * isn't a package explorer part registered <code>null</code> is returned. * Otherwise the opened view part is returned. */ public static PackageExplorerPart openInActivePerspective() { try { return (PackageExplorerPart)JavaPlugin.getActivePage().showView(VIEW_ID); } catch(PartInitException pe) { return null; } } public void dispose() { if (fViewer != null) JavaPlugin.getDefault().getProblemMarkerManager().removeListener(fViewer); if (fContextMenu != null && !fContextMenu.isDisposed()) fContextMenu.dispose(); getSite().getPage().removePartListener(fPartListener); JavaPlugin.getDefault().getPreferenceStore().removePropertyChangeListener(this); if (fViewer != null) fViewer.removeTreeListener(fExpansionListener); super.dispose(); } /** * Implementation of IWorkbenchPart.createPartControl(Composite) */ public void createPartControl(Composite parent) { fViewer= new ProblemTreeViewer(parent, SWT.MULTI | SWT.H_SCROLL | SWT.V_SCROLL); boolean showCUChildren= JavaBasePreferencePage.showCompilationUnitChildren(); fViewer.setContentProvider(new JavaElementContentProvider(showCUChildren, false)); JavaPlugin.getDefault().getProblemMarkerManager().addListener(fViewer); JavaPlugin.getDefault().getPreferenceStore().addPropertyChangeListener(this); JavaElementLabelProvider labelProvider= new JavaElementLabelProvider(getLabelProviderFlags()); labelProvider.setErrorTickManager(new MarkerErrorTickProvider()); fViewer.setLabelProvider(new DecoratingLabelProvider(labelProvider, null)); fViewer.setSorter(new JavaElementSorter()); fViewer.addFilter(new EmptyInnerPackageFilter()); fViewer.setUseHashlookup(true); fViewer.addFilter(fPatternFilter); fViewer.addFilter(fLibraryFilter); //fViewer.addFilter(fBinaryFilter); fViewer.addFilter(fWorkingSetFilter); if(fMemento != null) restoreFilters(); else initFilterFromPreferences(); // Set input after filter and sorter has been set. This avoids resorting // and refiltering. fViewer.setInput(findInputElement()); initDragAndDrop(); initFrameList(); initKeyListener(); updateTitle(); MenuManager menuMgr= new MenuManager("#PopupMenu"); //$NON-NLS-1$ menuMgr.setRemoveAllWhenShown(true); menuMgr.addMenuListener(this); fContextMenu= menuMgr.createContextMenu(fViewer.getTree()); fViewer.getTree().setMenu(fContextMenu); getSite().registerContextMenu(menuMgr, fViewer); makeActions(); // call before registering for selection changes fSelectionListener= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { handleSelectionChanged(event); } }; fViewer.addSelectionChangedListener(fSelectionListener); fViewer.addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent event) { handleDoubleClick(event); } }); fViewer.getControl().addKeyListener(new KeyAdapter() { public void keyPressed(KeyEvent e) { handleKeyPressed(e); } }); getSite().setSelectionProvider(fViewer); getSite().getPage().addPartListener(fPartListener); IStatusLineManager slManager= getViewSite().getActionBars().getStatusLineManager(); fViewer.addSelectionChangedListener(new StatusBarUpdater(slManager)); fViewer.addTreeListener(fExpansionListener); if (fMemento != null) restoreState(fMemento); fMemento= null; // Set help for the view // fixed for 1GETAYN: ITPJUI:WIN - F1 help does nothing WorkbenchHelp.setHelp(fViewer.getControl(), new ViewContextComputer(this, IJavaHelpContextIds.PACKAGE_VIEW)); fillActionBars(); } private void fillActionBars() { IActionBars actionBars= getViewSite().getActionBars(); IToolBarManager toolBar= actionBars.getToolBarManager(); toolBar.add(fBackAction); toolBar.add(fForwardAction); toolBar.add(fUpAction); actionBars.updateActionBars(); IMenuManager menu= actionBars.getMenuManager(); menu.add(fFilterAction); menu.add(fShowLibrariesAction); //menu.add(fShowBinariesAction); menu.add(fFilterWorkingSetAction); menu.add(fRemoveWorkingSetAction); menu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS)); menu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS+"-end"));//$NON-NLS-1$ } private Object findInputElement() { Object input= getSite().getPage().getInput(); if (input instanceof IWorkspace) { return JavaCore.create(((IWorkspace)input).getRoot()); } else if (input instanceof IContainer) { return JavaCore.create((IContainer)input); } //1GERPRT: ITPJUI:ALL - Packages View is empty when shown in Type Hierarchy Perspective // we can't handle the input // fall back to show the workspace return JavaCore.create(JavaPlugin.getWorkspace().getRoot()); } /** * Answer the property defined by key. */ public Object getAdapter(Class key) { if (key.equals(ISelectionProvider.class)) return fViewer; return super.getAdapter(key); } /** * Returns the tool tip text for the given element. */ String getToolTipText(Object element) { String result; if (!(element instanceof IResource)) { result= ((ILabelProvider) getViewer().getLabelProvider()).getText(element); } else { IPath path= ((IResource) element).getFullPath(); if (path.isRoot()) { result= PackagesMessages.getString("PackageExplorer.title"); //$NON-NLS-1$ } else { result= path.makeRelative().toString(); } } IWorkingSet ws= fWorkingSetFilter.getWorkingSet(); if (ws == null) return result; String wsstr= "Working Set: "+ws.getName(); if (result.length() == 0) return wsstr; return result + " - " + wsstr; } public String getTitleToolTip() { if (fViewer == null) return super.getTitleToolTip(); return getToolTipText(fViewer.getInput()); } /** * @see IWorkbenchPart#setFocus() */ public void setFocus() { fViewer.getTree().setFocus(); } /** * Sets the working set to be used for filtering this part */ public void setWorkingSet(IWorkingSet ws) { fWorkingSetFilter.setWorkingSet(ws); firePropertyChange(IWorkbenchPart.PROP_TITLE); fFilterWorkingSetAction.setChecked(ws != null); fRemoveWorkingSetAction.setEnabled(ws != null); } /** * Returns the shell to use for opening dialogs. * Used in this class, and in the actions. */ private Shell getShell() { return fViewer.getTree().getShell(); } /** * Returns the selection provider. */ private ISelectionProvider getSelectionProvider() { return fViewer; } /** * Returns the current selection. */ private ISelection getSelection() { return fViewer.getSelection(); } //---- Action handling ---------------------------------------------------------- /** * Called when the context menu is about to open. * Override to add your own context dependent menu contributions. */ public void menuAboutToShow(IMenuManager menu) { JavaPlugin.createStandardGroups(menu); IStructuredSelection selection= (IStructuredSelection) fViewer.getSelection(); boolean selectionHasElements= !selection.isEmpty(); Object element= selection.getFirstElement(); // updateActions(selection); if (selection.size() == 1 && fViewer.isExpandable(element)) menu.appendToGroup(IContextMenuConstants.GROUP_GOTO, fZoomInAction); addGotoMenu(menu); fOpenCUAction.update(); if (fOpenCUAction.isEnabled()) menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, fOpenCUAction); addOpenWithMenu(menu, selection); addOpenToMenu(menu, selection); addRefactoring(menu); if (selection.size() == 1) { menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, new JavaReplaceWithEditionAction(fViewer)); menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, new JavaAddElementFromHistory(null, fViewer)); } ContextMenuGroup.add(menu, fStandardGroups, fViewer); if (fAddBookmarkAction.canOperateOnSelection()) menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, fAddBookmarkAction); menu.appendToGroup(IContextMenuConstants.GROUP_BUILD, fRefreshAction); fRefreshAction.selectionChanged(selection); if (selectionHasElements) { // update the action to use the right selection since the refresh // action doesn't listen to selection changes. menu.appendToGroup(IContextMenuConstants.GROUP_PROPERTIES, fPropertyDialogAction); } } void addGotoMenu(IMenuManager menu) { MenuManager gotoMenu= new MenuManager(PackagesMessages.getString("PackageExplorer.gotoTitle")); //$NON-NLS-1$ menu.appendToGroup(IContextMenuConstants.GROUP_GOTO, gotoMenu); gotoMenu.add(fBackAction); gotoMenu.add(fForwardAction); gotoMenu.add(fUpAction); gotoMenu.add(fGotoTypeAction); gotoMenu.add(fGotoPackageAction); } private void makeActions() { ISelectionProvider provider= getSelectionProvider(); fOpenCUAction= new OpenResourceAction(provider); fPropertyDialogAction= new PropertyDialogAction(getShell(), provider); // fShowTypeHierarchyAction= new ShowTypeHierarchyAction(provider); fShowNavigatorAction= new ShowInNavigatorAction(provider); fAddBookmarkAction= new AddBookmarkAction(provider); fStandardGroups= new ContextMenuGroup[] { new NewGroup(), new BuildGroup(), new ReorgGroup(), new JavaSearchGroup() }; fDeleteAction= new DeleteAction(StructuredSelectionProvider.createFrom(provider)); fRefreshAction= new RefreshAction(getShell()); fFilterAction = new FilterSelectionAction(getShell(), this, PackagesMessages.getString("PackageExplorer.filters")); //$NON-NLS-1$ fShowLibrariesAction = new ShowLibrariesAction(this, PackagesMessages.getString("PackageExplorer.referencedLibs")); //$NON-NLS-1$ fShowBinariesAction = new ShowBinariesAction(getShell(), this, PackagesMessages.getString("PackageExplorer.binaryProjects")); //$NON-NLS-1$ fFilterWorkingSetAction = new FilterWorkingSetAction(getShell(), this, "Filter Working Set..."); //$NON-NLS-1$ fRemoveWorkingSetAction = new RemoveWorkingSetFilterAction(getShell(), this, "Remove Working Set Filter"); //$NON-NLS-1$ fBackAction= new BackAction(fFrameList); fForwardAction= new ForwardAction(fFrameList); fZoomInAction= new GoIntoAction(fFrameList); fUpAction= new UpAction(fFrameList); fGotoTypeAction= new GotoTypeAction(this); fGotoPackageAction= new GotoPackageAction(this); IActionBars actionService= getViewSite().getActionBars(); actionService.setGlobalActionHandler(IWorkbenchActionConstants.DELETE, fDeleteAction); } private void addRefactoring(IMenuManager menu){ MenuManager refactoring= new MenuManager(PackagesMessages.getString("PackageExplorer.refactoringTitle")); //$NON-NLS-1$ ContextMenuGroup.add(refactoring, new ContextMenuGroup[] { new RefactoringGroup() }, fViewer); if (!refactoring.isEmpty()) menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, refactoring); } private void addOpenToMenu(IMenuManager menu, IStructuredSelection selection) { if (selection.size() != 1) return; IAdaptable element= (IAdaptable) selection.getFirstElement(); IResource resource= (IResource)element.getAdapter(IResource.class); if ((resource instanceof IContainer)) { // Create a menu flyout. MenuManager submenu = new MenuManager(PackagesMessages.getString("PackageExplorer.openPerspective")); //$NON-NLS-1$ submenu.add(new OpenPerspectiveMenu(getSite().getWorkbenchWindow(), resource)); menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, submenu); } OpenTypeHierarchyUtil.addToMenu(getSite().getWorkbenchWindow(), menu, element); } private void addOpenWithMenu(IMenuManager menu, IStructuredSelection selection) { // If one file is selected get it. // Otherwise, do not show the "open with" menu. if (selection.size() != 1) return; IAdaptable element= (IAdaptable)selection.getFirstElement(); Object resource= element.getAdapter(IResource.class); if (!(resource instanceof IFile)) return; // Create a menu flyout. MenuManager submenu= new MenuManager(PackagesMessages.getString("PackageExplorer.openWith")); //$NON-NLS-1$ submenu.add(new OpenWithMenu(getSite().getPage(), (IFile) resource)); // Add the submenu. menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, submenu); } private boolean isSelectionOfType(ISelection s, Class clazz, boolean considerUnderlyingResource) { if (! (s instanceof IStructuredSelection) || s.isEmpty()) return false; IStructuredSelection selection= (IStructuredSelection)s; Iterator iter= selection.iterator(); while (iter.hasNext()) { Object o= iter.next(); if (clazz.isInstance(o)) return true; if (considerUnderlyingResource) { if (! (o instanceof IJavaElement)) return false; IJavaElement element= (IJavaElement)o; Object resource= element.getAdapter(IResource.class); if (! clazz.isInstance(resource)) return false; } } return true; } //---- Event handling ---------------------------------------------------------- private void initDragAndDrop() { int ops= DND.DROP_COPY | DND.DROP_MOVE; final LocalSelectionTransfer lt= LocalSelectionTransfer.getInstance(); Transfer[] transfers= new Transfer[] { lt, ResourceTransfer.getInstance(), FileTransfer.getInstance()}; // Drop Adapter TransferDropTargetListener[] dropListeners= new TransferDropTargetListener[] { new SelectionTransferDropAdapter(fViewer), new FileTransferDropAdapter(fViewer) }; fViewer.addDropSupport(ops, transfers, new DelegatingDropAdapter(dropListeners)); // Drag Adapter Control control= fViewer.getControl(); TransferDragSourceListener[] dragListeners= new TransferDragSourceListener[] { new SelectionTransferDragAdapter(fViewer), new ResourceTransferDragAdapter(fViewer), new FileTransferDragAdapter(fViewer) }; DragSource source= new DragSource(control, ops); // Note, that the transfer agents are set by the delegating drag adapter itself. source.addDragListener(new DelegatingDragAdapter(dragListeners)); } /** * Handles key events in viewer. */ void handleKeyPressed(KeyEvent event) { if (event.character == SWT.DEL && event.stateMask == 0){ fDeleteAction.update(); if (fDeleteAction.isEnabled()) fDeleteAction.run(); } } /** * Handles double clicks in viewer. * Opens editor if file double-clicked. */ private void handleDoubleClick(DoubleClickEvent event) { IStructuredSelection s= (IStructuredSelection) event.getSelection(); Object element= s.getFirstElement(); if (fOpenCUAction.isEnabled()) { fOpenCUAction.run(); return; } if (fViewer.isExpandable(element)) { if (JavaBasePreferencePage.doubleClockGoesInto()) { // don't zoom into compilation units and class files if (element instanceof IOpenable && !(element instanceof ICompilationUnit) && !(element instanceof IClassFile)) { fZoomInAction.run(); } } else { fViewer.setExpandedState(element, !fViewer.getExpandedState(element)); //expandMainType(element); } } } /** * Handles selection changed in viewer. * Updates global actions. * Links to editor (if option enabled) */ private void handleSelectionChanged(SelectionChangedEvent event) { IStructuredSelection sel= (IStructuredSelection) event.getSelection(); //updateGlobalActions(sel); fZoomInAction.update(); linkToEditor(sel); } public void selectReveal(ISelection selection) { ISelection javaSelection= convertSelection(selection); fViewer.setSelection(javaSelection, true); } private ISelection convertSelection(ISelection s) { List converted= new ArrayList(); if (s instanceof StructuredSelection) { Object[] elements= ((StructuredSelection)s).toArray(); for (int i= 0; i < elements.length; i++) { Object e= elements[i]; if (e instanceof IJavaElement) converted.add(e); else if (e instanceof IResource) { IJavaElement element= JavaCore.create((IResource)e); if (element != null) converted.add(element); else converted.add(e); } } } return new StructuredSelection(converted.toArray()); } public void selectAndReveal(Object element) { selectReveal(new StructuredSelection(element)); } /** * Returns whether the preference to link selection to active editor is enabled. */ boolean isLinkingEnabled() { return JavaBasePreferencePage.linkPackageSelectionToEditor(); } /** * Links to editor (if option enabled) */ private void linkToEditor(IStructuredSelection selection) { //if (!isLinkingEnabled()) // return; Object obj= selection.getFirstElement(); Object element= null; if (selection.size() == 1) { if (obj instanceof IJavaElement) { IJavaElement cu= JavaModelUtil.findElementOfKind((IJavaElement)obj, IJavaElement.COMPILATION_UNIT); if (cu != null) element= getResourceFor(cu); if (element == null) element= JavaModelUtil.findElementOfKind((IJavaElement)obj, IJavaElement.CLASS_FILE); } else if (obj instanceof IFile) element= obj; if (element == null) return; IWorkbenchPage page= getSite().getPage(); IEditorPart editorArray[]= page.getEditors(); for (int i= 0; i < editorArray.length; ++i) { IEditorPart editor= editorArray[i]; Object input= getElementOfInput(editor.getEditorInput()); if (input != null && input.equals(element)) { page.bringToTop(editor); if (obj instanceof IJavaElement) EditorUtility.revealInEditor(editor, (IJavaElement) obj); return; } } } } private IResource getResourceFor(Object element) { if (element instanceof IJavaElement) { if (element instanceof IWorkingCopy) { IWorkingCopy wc= (IWorkingCopy)element; IJavaElement original= wc.getOriginalElement(); if (original != null) element= original; } try { element= ((IJavaElement)element).getUnderlyingResource(); } catch (JavaModelException e) { return null; } } if (!(element instanceof IResource) || ((IResource)element).isPhantom()) { return null; } return (IResource)element; } public void saveState(IMemento memento) { if (fViewer == null) { // part has not been created if (fMemento != null) //Keep the old state; memento.putMemento(fMemento); return; } saveExpansionState(memento); saveSelectionState(memento); saveScrollState(memento, fViewer.getTree()); savePatternFilterState(memento); saveFilterState(memento); saveWorkingSetState(memento); } protected void saveFilterState(IMemento memento) { boolean showLibraries= getLibraryFilter().getShowLibraries(); String show= "true"; //$NON-NLS-1$ if (!showLibraries) show= "false"; //$NON-NLS-1$ memento.putString(TAG_SHOWLIBRARIES, show); //save binary filter boolean showBinaries= getBinaryFilter().getShowBinaries(); String showBinString= "true"; //$NON-NLS-1$ if (!showBinaries) showBinString= "false"; //$NON-NLS-1$ memento.putString(TAG_SHOWBINARIES, showBinString); } protected void savePatternFilterState(IMemento memento) { String filters[] = getPatternFilter().getPatterns(); if(filters.length > 0) { IMemento filtersMem = memento.createChild(TAG_FILTERS); for (int i = 0; i < filters.length; i++){ IMemento child = filtersMem.createChild(TAG_FILTER); child.putString(TAG_ELEMENT,filters[i]); } } } protected void saveScrollState(IMemento memento, Tree tree) { ScrollBar bar= tree.getVerticalBar(); int position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_VERTICAL_POSITION, String.valueOf(position)); //save horizontal position bar= tree.getHorizontalBar(); position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_HORIZONTAL_POSITION, String.valueOf(position)); } protected void saveSelectionState(IMemento memento) { Object elements[]= ((IStructuredSelection) fViewer.getSelection()).toArray(); if (elements.length > 0) { IMemento selectionMem= memento.createChild(TAG_SELECTION); for (int i= 0; i < elements.length; i++) { IMemento elementMem= selectionMem.createChild(TAG_ELEMENT); // we can only persist JavaElements for now Object o= elements[i]; if (o instanceof IJavaElement) elementMem.putString(TAG_PATH, ((IJavaElement) elements[i]).getHandleIdentifier()); } } } protected void saveExpansionState(IMemento memento) { Object expandedElements[]= fViewer.getExpandedElements(); if (expandedElements.length > 0) { IMemento expandedMem= memento.createChild(TAG_EXPANDED); for (int i= 0; i < expandedElements.length; i++) { IMemento elementMem= expandedMem.createChild(TAG_ELEMENT); // we can only persist JavaElements for now Object o= expandedElements[i]; if (o instanceof IJavaElement) elementMem.putString(TAG_PATH, ((IJavaElement) expandedElements[i]).getHandleIdentifier()); } } } protected void saveWorkingSetState(IMemento memento) { IWorkingSet ws= getWorkingSetFilter().getWorkingSet(); if (ws != null) { memento.putString(TAG_WORKINGSET, ws.getName()); } } void restoreState(IMemento memento) { restoreExpansionState(memento); restoreSelectionState(memento); restoreScrollState(memento, fViewer.getTree()); } protected void restoreScrollState(IMemento memento, Tree tree) { ScrollBar bar= tree.getVerticalBar(); if (bar != null) { try { String posStr= memento.getString(TAG_VERTICAL_POSITION); int position; position= new Integer(posStr).intValue(); bar.setSelection(position); } catch (NumberFormatException e) { // ignore, don't set scrollposition } } bar= tree.getHorizontalBar(); if (bar != null) { try { String posStr= memento.getString(TAG_HORIZONTAL_POSITION); int position; position= new Integer(posStr).intValue(); bar.setSelection(position); } catch (NumberFormatException e) { // ignore don't set scroll position } } } protected void restoreSelectionState(IMemento memento) { IMemento childMem; childMem= memento.getChild(TAG_SELECTION); if (childMem != null) { ArrayList list= new ArrayList(); IMemento[] elementMem= childMem.getChildren(TAG_ELEMENT); for (int i= 0; i < elementMem.length; i++) { Object element= JavaCore.create(elementMem[i].getString(TAG_PATH)); list.add(element); } fViewer.setSelection(new StructuredSelection(list)); } } protected void restoreExpansionState(IMemento memento) { IMemento childMem= memento.getChild(TAG_EXPANDED); if (childMem != null) { ArrayList elements= new ArrayList(); IMemento[] elementMem= childMem.getChildren(TAG_ELEMENT); for (int i= 0; i < elementMem.length; i++) { Object element= JavaCore.create(elementMem[i].getString(TAG_PATH)); elements.add(element); } fViewer.setExpandedElements(elements.toArray()); } } /** * Create the KeyListener for doing the refresh on the viewer. */ private void initKeyListener() { fViewer.getControl().addKeyListener(new KeyAdapter() { public void keyReleased(KeyEvent event) { doKeyPressed(event.keyCode); } }); } private void doKeyPressed(int key) { if (key == SWT.F5) { fRefreshAction.selectionChanged( (IStructuredSelection) fViewer.getSelection()); if (fRefreshAction.isEnabled()) fRefreshAction.run(); } else if (key == SWT.F4) { OpenTypeHierarchyUtil.open(getSelection(), getSite().getWorkbenchWindow()); } else if (key == SWT.F3) { fOpenCUAction.update(); if (fOpenCUAction.isEnabled()) fOpenCUAction.run(); } } void initFrameList() { fFrameSource= new PackagesFrameSource(this); fFrameList= new FrameList(fFrameSource); fFrameSource.connectTo(fFrameList); } /** * An editor has been activated. Set the selection in this Packages Viewer * to be the editor's input, if linking is enabled. */ void editorActivated(IEditorPart editor) { if (!isLinkingEnabled()) return; Object input= getElementOfInput(editor.getEditorInput()); Object element= null; if (input instanceof IFile) element= JavaCore.create((IFile)input); if (element == null) // try a non Java resource element= input; if (element != null) { // if the current selection is a child of the new // selection then ignore it. IStructuredSelection oldSelection= (IStructuredSelection)getSelection(); if (oldSelection.size() == 1) { Object o= oldSelection.getFirstElement(); if (o instanceof IMember) { IMember m= (IMember)o; if (element.equals(m.getCompilationUnit())) return; if (element.equals(m.getClassFile())) return; } } ISelection newSelection= new StructuredSelection(element); if (!fViewer.getSelection().equals(newSelection)) { try { fViewer.removeSelectionChangedListener(fSelectionListener); fViewer.setSelection(newSelection); } finally { fViewer.addSelectionChangedListener(fSelectionListener); } } } } /** * A compilation unit or class was expanded, expand * the main type. */ void expandMainType(Object element) { try { IType type= null; if (element instanceof ICompilationUnit) { ICompilationUnit cu= (ICompilationUnit)element; IType[] types= cu.getTypes(); if (types.length > 0) type= types[0]; } else if (element instanceof IClassFile) { IClassFile cf= (IClassFile)element; type= cf.getType(); } if (type != null) { final IType type2= type; Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) { ctrl.getDisplay().asyncExec(new Runnable() { public void run() { Control ctrl= fViewer.getControl(); if (ctrl != null && !ctrl.isDisposed()) fViewer.expandToLevel(type2, 1); } }); } } } catch(JavaModelException e) { // no reveal } } /** * Returns the element contained in the EditorInput */ Object getElementOfInput(IEditorInput input) { if (input instanceof IClassFileEditorInput) return ((IClassFileEditorInput)input).getClassFile(); else if (input instanceof IFileEditorInput) return ((IFileEditorInput)input).getFile(); else if (input instanceof JarEntryEditorInput) return ((JarEntryEditorInput)input).getStorage(); return null; } /** * Returns the Viewer. */ TreeViewer getViewer() { return fViewer; } /** * Returns the pattern filter for this view. * @return the pattern filter */ JavaElementPatternFilter getPatternFilter() { return fPatternFilter; } /** * Returns the library filter for this view. * @return the library filter */ LibraryFilter getLibraryFilter() { return fLibraryFilter; } /** * Returns the working set filter for this view. * @return the working set filter */ WorkingSetFilter getWorkingSetFilter() { return fWorkingSetFilter; } /** * Returns the Binary filter for this view. * @return the binary filter */ BinaryProjectFilter getBinaryFilter() { return fBinaryFilter; } void restoreFilters() { IMemento filtersMem= fMemento.getChild(TAG_FILTERS); if(filtersMem != null) { IMemento children[]= filtersMem.getChildren(TAG_FILTER); String filters[]= new String[children.length]; for (int i = 0; i < children.length; i++) { filters[i]= children[i].getString(TAG_ELEMENT); } getPatternFilter().setPatterns(filters); } else { getPatternFilter().setPatterns(new String[0]); } //restore library String show= fMemento.getString(TAG_SHOWLIBRARIES); if (show != null) getLibraryFilter().setShowLibraries(show.equals("true")); //$NON-NLS-1$ else initLibraryFilterFromPreferences(); //restore binary fileter String showbin= fMemento.getString(TAG_SHOWBINARIES); if (showbin != null) getBinaryFilter().setShowBinaries(showbin.equals("true")); //$NON-NLS-1$ else initBinaryFilterFromPreferences(); //restore working set String workingSetName= fMemento.getString(TAG_WORKINGSET); if (workingSetName != null) { IWorkingSet ws= SearchUI.findWorkingSet(workingSetName); if (ws != null) { getWorkingSetFilter().setWorkingSet(ws); } } } void initFilterFromPreferences() { initBinaryFilterFromPreferences(); initLibraryFilterFromPreferences(); } void initLibraryFilterFromPreferences() { JavaPlugin plugin= JavaPlugin.getDefault(); boolean show= plugin.getPreferenceStore().getBoolean(TAG_SHOWLIBRARIES); getLibraryFilter().setShowLibraries(show); } void initBinaryFilterFromPreferences() { JavaPlugin plugin= JavaPlugin.getDefault(); boolean showbin= plugin.getPreferenceStore().getBoolean(TAG_SHOWBINARIES); getBinaryFilter().setShowBinaries(showbin); } /** * Updates the title text and title tool tip. * Called whenever the input of the viewer changes. */ void updateTitle() { Object input= getViewer().getInput(); String viewName= getConfigurationElement().getAttribute("name"); //$NON-NLS-1$ if (input == null || (input instanceof IJavaModel)) { setTitle(viewName); setTitleToolTip(""); //$NON-NLS-1$ } else { ILabelProvider labelProvider = (ILabelProvider) getViewer().getLabelProvider(); String inputText= labelProvider.getText(input); String title= PackagesMessages.getFormattedString("PackageExplorer.argTitle", new String[] { viewName, inputText }); //$NON-NLS-1$ setTitle(title); setTitleToolTip(getToolTipText(input)); } } /** * Sets the decorator for the package explorer. * * @param decorator a label decorator or <code>null</code> for no decorations. */ public void setLabelDecorator(ILabelDecorator decorator) { JavaElementLabelProvider javaProvider= new JavaElementLabelProvider(getLabelProviderFlags()); javaProvider.setErrorTickManager(new MarkerErrorTickProvider()); if (decorator == null) { fViewer.setLabelProvider(javaProvider); } else { fViewer.setLabelProvider(new DecoratingLabelProvider(javaProvider, decorator)); } } /** * Gets the standard label flags */ private int getLabelProviderFlags() { return JavaElementLabelProvider.SHOW_BASICS | JavaElementLabelProvider.SHOW_OVERLAY_ICONS | JavaElementLabelProvider.SHOW_SMALL_ICONS | JavaElementLabelProvider.SHOW_VARIABLE | JavaElementLabelProvider.SHOW_PARAMETERS; } /* * @see IPropertyChangeListener#propertyChange(PropertyChangeEvent) */ public void propertyChange(PropertyChangeEvent event) { if (event.getProperty() != IPreferencesConstants.SHOW_CU_CHILDREN) return; if (fViewer != null) { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); boolean b= store.getBoolean(IPreferencesConstants.SHOW_CU_CHILDREN); ((JavaElementContentProvider)fViewer.getContentProvider()).setProvideMembers(b); fViewer.refresh(); } } }
5,820
Bug 5820 Close all editors brings up hierarchy of object
Build: 1107 1. Open a Java editor in the Java perspective 2. Select the project 3. Hit Ctrl-Shift-F4 The hierarchy for Object appears after ~30 seconds. This is very confusing.
verified fixed
13251cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-19T17:53:15Z"
"2001-11-13T00:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.typehierarchy; import java.util.ArrayList; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.BusyIndicator; import org.eclipse.swt.custom.CLabel; import org.eclipse.swt.custom.SashForm; import org.eclipse.swt.custom.ViewForm; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DragSource; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.events.KeyListener; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.ScrollBar; import org.eclipse.swt.widgets.ToolBar; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.action.ToolBarManager; import org.eclipse.jface.dialogs.IDialogSettings; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.IBasicPropertyConstants; import org.eclipse.jface.viewers.IInputSelectionProvider; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.Viewer; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IMemento; import org.eclipse.ui.IPartListener; import org.eclipse.ui.IViewSite; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.PartInitException; import org.eclipse.ui.actions.OpenWithMenu; import org.eclipse.ui.help.ViewContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.PageBook; import org.eclipse.ui.part.ViewPart; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.ITypeHierarchyViewPart; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.AddMethodStubAction; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.compare.JavaReplaceWithEditionAction; import org.eclipse.jdt.internal.ui.dnd.BasicSelectionTransferDragAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.packageview.BuildGroup; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringGroup; import org.eclipse.jdt.internal.ui.reorg.ReorgGroup; import org.eclipse.jdt.internal.ui.util.OpenTypeHierarchyUtil; import org.eclipse.jdt.internal.ui.viewsupport.IProblemChangedListener; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.MarkerErrorTickProvider; import org.eclipse.jdt.internal.ui.viewsupport.StatusBarUpdater; /** * view showing the supertypes/subtypes of its input. */ public class TypeHierarchyViewPart extends ViewPart implements ITypeHierarchyViewPart { public static final int VIEW_ID_TYPE= 2; public static final int VIEW_ID_SUPER= 0; public static final int VIEW_ID_SUB= 1; public static final int VIEW_ORIENTATION_VERTICAL= 0; public static final int VIEW_ORIENTATION_HORIZONTAL= 1; public static final int VIEW_ORIENTATION_SINGLE= 2; private static final String DIALOGSTORE_HIERARCHYVIEW= "TypeHierarchyViewPart.hierarchyview"; //$NON-NLS-1$ private static final String DIALOGSTORE_VIEWORIENTATION= "TypeHierarchyViewPart.orientation"; //$NON-NLS-1$ private static final String TAG_INPUT= "input"; //$NON-NLS-1$ private static final String TAG_VIEW= "view"; //$NON-NLS-1$ private static final String TAG_ORIENTATION= "orientation"; //$NON-NLS-1$ private static final String TAG_RATIO= "ratio"; //$NON-NLS-1$ private static final String TAG_SELECTION= "selection"; //$NON-NLS-1$ private static final String TAG_VERTICAL_SCROLL= "vertical_scroll"; //$NON-NLS-1$ // the selected type in the hierarchy view private IType fSelectedType; // input element or null private IJavaElement fInputElement; // history of inut elements. No duplicates private ArrayList fInputHistory; private IMemento fMemento; private IProblemChangedListener fHierarchyProblemListener; private TypeHierarchyLifeCycle fHierarchyLifeCycle; private ITypeHierarchyLifeCycleListener fTypeHierarchyLifeCycleListener; private MethodsViewer fMethodsViewer; private int fCurrentViewerIndex; private TypeHierarchyViewer[] fAllViewers; private boolean fIsEnableMemberFilter; private SashForm fTypeMethodsSplitter; private PageBook fViewerbook; private PageBook fPagebook; private Label fNoHierarchyShownLabel; private Label fEmptyTypesViewer; private ViewForm fTypeViewerViewForm; private ViewForm fMethodViewerViewForm; private CLabel fMethodViewerPaneLabel; private JavaElementLabelProvider fPaneLabelProvider; private IDialogSettings fDialogSettings; private ToggleViewAction[] fViewActions; private HistoryDropDownAction fHistoryDropDownAction; private ToggleOrientationAction[] fToggleOrientationActions; private int fCurrentOrientation; private EnableMemberFilterAction fEnableMemberFilterAction; private AddMethodStubAction fAddStubAction; private FocusOnTypeAction fFocusOnTypeAction; private FocusOnSelectionAction fFocusOnSelectionAction; private IPartListener fPartListener; public TypeHierarchyViewPart() { fSelectedType= null; fInputElement= null; fHierarchyLifeCycle= new TypeHierarchyLifeCycle(); fTypeHierarchyLifeCycleListener= new ITypeHierarchyLifeCycleListener() { public void typeHierarchyChanged(TypeHierarchyLifeCycle typeHierarchy, IType[] changedTypes) { doTypeHierarchyChanged(typeHierarchy, changedTypes); } }; fHierarchyLifeCycle.addChangedListener(fTypeHierarchyLifeCycleListener); fHierarchyProblemListener= null; fIsEnableMemberFilter= false; fInputHistory= new ArrayList(); fAllViewers= null; fViewActions= new ToggleViewAction[] { new ToggleViewAction(this, VIEW_ID_TYPE), new ToggleViewAction(this, VIEW_ID_SUPER), new ToggleViewAction(this, VIEW_ID_SUB) }; fDialogSettings= JavaPlugin.getDefault().getDialogSettings(); fHistoryDropDownAction= new HistoryDropDownAction(this); fToggleOrientationActions= new ToggleOrientationAction[] { new ToggleOrientationAction(this, VIEW_ORIENTATION_VERTICAL), new ToggleOrientationAction(this, VIEW_ORIENTATION_HORIZONTAL), new ToggleOrientationAction(this, VIEW_ORIENTATION_SINGLE) }; fEnableMemberFilterAction= new EnableMemberFilterAction(this, false); fFocusOnTypeAction= new FocusOnTypeAction(this); fPaneLabelProvider= new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_BASICS); fPaneLabelProvider.setErrorTickManager(new MarkerErrorTickProvider()); fAddStubAction= new AddMethodStubAction(); fFocusOnSelectionAction= new FocusOnSelectionAction(this); fPartListener= new IPartListener() { public void partActivated(IWorkbenchPart part) { if (part instanceof IEditorPart) editorActivated((IEditorPart) part); } public void partBroughtToTop(IWorkbenchPart part) {} public void partClosed(IWorkbenchPart part) {} public void partDeactivated(IWorkbenchPart part) {} public void partOpened(IWorkbenchPart part) {} }; } /** * Adds the entry if new. Inserted at the beginning of the history entries list. */ private void addHistoryEntry(IJavaElement entry) { if (fInputHistory.contains(entry)) { fInputHistory.remove(entry); } fInputHistory.add(0, entry); } private void updateHistoryEntries() { for (int i= fInputHistory.size() - 1; i >= 0; i--) { IJavaElement type= (IJavaElement) fInputHistory.get(i); if (!type.exists()) { fInputHistory.remove(i); } } } /** * Goes to the selected entry, without updating the order of history entries. */ public void gotoHistoryEntry(IJavaElement entry) { if (fInputHistory.contains(entry)) { updateInput(entry); } } /** * Gets all history entries. */ public IJavaElement[] getHistoryEntries() { updateHistoryEntries(); return (IJavaElement[]) fInputHistory.toArray(new IJavaElement[fInputHistory.size()]); } /** * Sets the history entries */ public void setHistoryEntries(IJavaElement[] elems) { fInputHistory.clear(); for (int i= 0; i < elems.length; i++) { fInputHistory.add(elems[i]); } updateHistoryEntries(); } /** * Selects an member in the methods list */ public void selectMember(IMember member) { ICompilationUnit cu= member.getCompilationUnit(); if (cu != null && cu.isWorkingCopy()) { member= (IMember) cu.getOriginal(member); if (member == null) { return; } } Control methodControl= fMethodsViewer.getControl(); if (methodControl != null && !methodControl.isDisposed()) { fMethodsViewer.getControl().setFocus(); } fMethodsViewer.setSelection(new StructuredSelection(member), true); } /** * @deprecated */ public IType getInput() { if (fInputElement instanceof IType) { return (IType) fInputElement; } return null; } /** * Sets the input to a new type * @deprecated */ public void setInput(IType type) { setInputElement(type); } /** * Returns the input element of the type hierarchy. * Can be of type <code>IType</code> or <code>IPackageFragment</code> */ public IJavaElement getInputElement() { return fInputElement; } /** * Sets the input to a new element. */ public void setInputElement(IJavaElement element) { if (element != null) { if (element instanceof IMember) { ICompilationUnit cu= ((IMember) element).getCompilationUnit(); if (cu != null && cu.isWorkingCopy()) { element= cu.getOriginal(element); } if (element.getElementType() == IJavaElement.METHOD || element.getElementType() == IJavaElement.FIELD || element.getElementType() == IJavaElement.INITIALIZER) { element= ((IMember) element).getDeclaringType(); } } } if (element != null && !element.equals(fInputElement)) { addHistoryEntry(element); } updateInput(element); } /** * Changes the input to a new type */ private void updateInput(IJavaElement inputElement) { IJavaElement prevInput= fInputElement; fInputElement= inputElement; if (fInputElement == null) { clearInput(); } else { // turn off member filtering enableMemberFilter(false); try { fHierarchyLifeCycle.ensureRefreshedTypeHierarchy(fInputElement); } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); clearInput(); return; } fPagebook.showPage(fTypeMethodsSplitter); if (inputElement.getElementType() != IJavaElement.TYPE) { setView(VIEW_ID_TYPE); } if (!fInputElement.equals(prevInput)) { updateHierarchyViewer(); } updateSelection(fInputElement); updateToolbarButtons(); updateTitle(); } } private void clearInput() { fInputElement= null; fHierarchyLifeCycle.freeHierarchy(); updateHierarchyViewer(); updateToolbarButtons(); } /* * @see IWorbenchPart#setFocus */ public void setFocus() { fPagebook.setFocus(); } /* * @see IWorkbenchPart#dispose */ public void dispose() { fHierarchyLifeCycle.freeHierarchy(); fHierarchyLifeCycle.removeChangedListener(fTypeHierarchyLifeCycleListener); fPaneLabelProvider.dispose(); getSite().getPage().removePartListener(fPartListener); if (fHierarchyProblemListener != null) { JavaPlugin.getDefault().getProblemMarkerManager().removeListener(fHierarchyProblemListener); } if (fMethodsViewer != null) { JavaPlugin.getDefault().getProblemMarkerManager().removeListener(fMethodsViewer); } super.dispose(); } private Control createTypeViewerControl(Composite parent) { fViewerbook= new PageBook(parent, SWT.NULL); ISelectionChangedListener selectionChangedListener= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { typeSelectionChanged(event.getSelection()); } }; KeyListener keyListener= createKeyListener(); HierarchyLabelProvider lprovider= new HierarchyLabelProvider(this, new MarkerErrorTickProvider()); // Create the viewers TypeHierarchyViewer superTypesViewer= new SuperTypeHierarchyViewer(fViewerbook, fHierarchyLifeCycle, lprovider, this); initializeTypesViewer(superTypesViewer, selectionChangedListener, keyListener, IContextMenuConstants.TARGET_ID_SUPERTYPES_VIEW); TypeHierarchyViewer subTypesViewer= new SubTypeHierarchyViewer(fViewerbook, fHierarchyLifeCycle, lprovider, this); initializeTypesViewer(subTypesViewer, selectionChangedListener, keyListener, IContextMenuConstants.TARGET_ID_SUBTYPES_VIEW); TypeHierarchyViewer vajViewer= new TraditionalHierarchyViewer(fViewerbook, fHierarchyLifeCycle, lprovider, this); initializeTypesViewer(vajViewer, selectionChangedListener, keyListener, IContextMenuConstants.TARGET_ID_HIERARCHY_VIEW); fAllViewers= new TypeHierarchyViewer[3]; fAllViewers[VIEW_ID_SUPER]= superTypesViewer; fAllViewers[VIEW_ID_SUB]= subTypesViewer; fAllViewers[VIEW_ID_TYPE]= vajViewer; int currViewerIndex; try { currViewerIndex= fDialogSettings.getInt(DIALOGSTORE_HIERARCHYVIEW); if (currViewerIndex < 0 || currViewerIndex > 2) { currViewerIndex= VIEW_ID_TYPE; } } catch (NumberFormatException e) { currViewerIndex= VIEW_ID_TYPE; } fEmptyTypesViewer= new Label(fViewerbook, SWT.LEFT); for (int i= 0; i < fAllViewers.length; i++) { fAllViewers[i].setInput(fAllViewers[i]); } // force the update fCurrentViewerIndex= -1; setView(currViewerIndex); return fViewerbook; } private KeyListener createKeyListener() { return new KeyAdapter() { public void keyPressed(KeyEvent event) { if (event.stateMask == SWT.NONE) { if (event.keyCode == SWT.F4) { OpenTypeHierarchyUtil.open(getSite().getSelectionProvider().getSelection(), getSite().getWorkbenchWindow()); return; } else if (event.keyCode == SWT.F5) { updateHierarchyViewer(); return; } } viewPartKeyShortcuts(event); } }; } private void initializeTypesViewer(final TypeHierarchyViewer typesViewer, ISelectionChangedListener selectionChangedListener, KeyListener keyListener, String cotextHelpId) { typesViewer.getControl().setVisible(false); typesViewer.getControl().addKeyListener(keyListener); typesViewer.initContextMenu(new IMenuListener() { public void menuAboutToShow(IMenuManager menu) { fillTypesViewerContextMenu(typesViewer, menu); } }, cotextHelpId, getSite()); typesViewer.addSelectionChangedListener(selectionChangedListener); } private Control createMethodViewerControl(Composite parent) { fMethodsViewer= new MethodsViewer(parent, this); fMethodsViewer.initContextMenu(new IMenuListener() { public void menuAboutToShow(IMenuManager menu) { fillMethodsViewerContextMenu(menu); } }, IContextMenuConstants.TARGET_ID_MEMBERS_VIEW, getSite()); fMethodsViewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { methodSelectionChanged(event.getSelection()); } }); Control control= fMethodsViewer.getTable(); control.addKeyListener(createKeyListener()); JavaPlugin.getDefault().getProblemMarkerManager().addListener(fMethodsViewer); return control; } private void initDragAndDrop() { Transfer[] transfers= new Transfer[] { LocalSelectionTransfer.getInstance() }; int ops= DND.DROP_COPY; DragSource source= new DragSource(fMethodsViewer.getControl(), ops); source.setTransfer(transfers); source.addDragListener(new BasicSelectionTransferDragAdapter(fMethodsViewer)); for (int i= 0; i < fAllViewers.length; i++) { TypeHierarchyViewer curr= fAllViewers[i]; curr.addDropSupport(ops, transfers, new TypeHierarchyTransferDropAdapter(curr)); } } private void viewPartKeyShortcuts(KeyEvent event) { if (event.stateMask == SWT.CTRL) { if (event.character == '1') { setView(VIEW_ID_TYPE); } else if (event.character == '2') { setView(VIEW_ID_SUPER); } else if (event.character == '3') { setView(VIEW_ID_SUB); } } } /** * Returns the inner component in a workbench part. * @see IWorkbenchPart#createPartControl */ public void createPartControl(Composite container) { fPagebook= new PageBook(container, SWT.NONE); // page 1 of pagebook (viewers) fTypeMethodsSplitter= new SashForm(fPagebook, SWT.VERTICAL); fTypeMethodsSplitter.setVisible(false); fTypeViewerViewForm= new ViewForm(fTypeMethodsSplitter, SWT.NONE); Control typeViewerControl= createTypeViewerControl(fTypeViewerViewForm); fTypeViewerViewForm.setContent(typeViewerControl); fMethodViewerViewForm= new ViewForm(fTypeMethodsSplitter, SWT.NONE); fTypeMethodsSplitter.setWeights(new int[] {35, 65}); Control methodViewerPart= createMethodViewerControl(fMethodViewerViewForm); fMethodViewerViewForm.setContent(methodViewerPart); fMethodViewerPaneLabel= new CLabel(fMethodViewerViewForm, SWT.NONE); fMethodViewerViewForm.setTopLeft(fMethodViewerPaneLabel); initDragAndDrop(); ToolBar methodViewerToolBar= new ToolBar(fMethodViewerViewForm, SWT.FLAT | SWT.WRAP); fMethodViewerViewForm.setTopCenter(methodViewerToolBar); // page 2 of pagebook (no hierarchy label) fNoHierarchyShownLabel= new Label(fPagebook, SWT.TOP + SWT.LEFT + SWT.WRAP); fNoHierarchyShownLabel.setText(TypeHierarchyMessages.getString("TypeHierarchyViewPart.empty")); //$NON-NLS-1$ MenuManager menu= new MenuManager(); menu.add(fFocusOnTypeAction); fNoHierarchyShownLabel.setMenu(menu.createContextMenu(fNoHierarchyShownLabel)); fPagebook.showPage(fNoHierarchyShownLabel); int orientation; try { orientation= fDialogSettings.getInt(DIALOGSTORE_VIEWORIENTATION); if (orientation < 0 || orientation > 2) { orientation= VIEW_ORIENTATION_VERTICAL; } } catch (NumberFormatException e) { orientation= VIEW_ORIENTATION_VERTICAL; } // force the update fCurrentOrientation= -1; // will fill the main tool bar setOrientation(orientation); // set the filter menu items IActionBars actionBars= getViewSite().getActionBars(); IMenuManager viewMenu= actionBars.getMenuManager(); for (int i= 0; i < fToggleOrientationActions.length; i++) { viewMenu.add(fToggleOrientationActions[i]); } // fill the method viewer toolbar ToolBarManager lowertbmanager= new ToolBarManager(methodViewerToolBar); lowertbmanager.add(fEnableMemberFilterAction); lowertbmanager.add(new Separator()); fMethodsViewer.contributeToToolBar(lowertbmanager); lowertbmanager.update(true); // selection provider int nHierarchyViewers= fAllViewers.length; Viewer[] trackedViewers= new Viewer[nHierarchyViewers + 1]; for (int i= 0; i < nHierarchyViewers; i++) { trackedViewers[i]= fAllViewers[i]; } trackedViewers[nHierarchyViewers]= fMethodsViewer; ISelectionProvider selProvider= new SelectionProviderMediator(trackedViewers); IStatusLineManager slManager= getViewSite().getActionBars().getStatusLineManager(); selProvider.addSelectionChangedListener(new StatusBarUpdater(slManager)); getSite().setSelectionProvider(selProvider); getSite().getPage().addPartListener(fPartListener); IJavaElement input= determineInputElement(); if (fMemento != null) { restoreState(fMemento, input); } else if (input != null) { setInputElement(input); } else { setViewerVisibility(false); } // fixed for 1GETAYN: ITPJUI:WIN - F1 help does nothing WorkbenchHelp.setHelp(fPagebook, new ViewContextComputer(this, IJavaHelpContextIds.TYPE_HIERARCHY_VIEW)); } /** * called from ToggleOrientationAction. * @param orientation VIEW_ORIENTATION_SINGLE, VIEW_ORIENTATION_HORIZONTAL or VIEW_ORIENTATION_VERTICAL */ public void setOrientation(int orientation) { if (fCurrentOrientation != orientation) { boolean methodViewerNeedsUpdate= false; if (fMethodViewerViewForm != null && !fMethodViewerViewForm.isDisposed() && fTypeMethodsSplitter != null && !fTypeMethodsSplitter.isDisposed()) { if (orientation == VIEW_ORIENTATION_SINGLE) { fMethodViewerViewForm.setVisible(false); enableMemberFilter(false); updateMethodViewer(null); } else { if (fCurrentOrientation == VIEW_ORIENTATION_SINGLE) { fMethodViewerViewForm.setVisible(true); methodViewerNeedsUpdate= true; } boolean horizontal= orientation == VIEW_ORIENTATION_HORIZONTAL; fTypeMethodsSplitter.setOrientation(horizontal ? SWT.HORIZONTAL : SWT.VERTICAL); updateMainToolbar(horizontal); } fTypeMethodsSplitter.layout(); } for (int i= 0; i < fToggleOrientationActions.length; i++) { fToggleOrientationActions[i].setChecked(orientation == fToggleOrientationActions[i].getOrientation()); } fCurrentOrientation= orientation; if (methodViewerNeedsUpdate) { updateMethodViewer(fSelectedType); } fDialogSettings.put(DIALOGSTORE_VIEWORIENTATION, orientation); } } private void updateMainToolbar(boolean horizontal) { IActionBars actionBars= getViewSite().getActionBars(); IToolBarManager tbmanager= actionBars.getToolBarManager(); if (horizontal) { clearMainToolBar(tbmanager); ToolBar typeViewerToolBar= new ToolBar(fTypeViewerViewForm, SWT.FLAT | SWT.WRAP); fillMainToolBar(new ToolBarManager(typeViewerToolBar)); fTypeViewerViewForm.setTopLeft(typeViewerToolBar); } else { fTypeViewerViewForm.setTopLeft(null); fillMainToolBar(tbmanager); } } private void fillMainToolBar(IToolBarManager tbmanager) { tbmanager.removeAll(); tbmanager.add(fHistoryDropDownAction); for (int i= 0; i < fViewActions.length; i++) { tbmanager.add(fViewActions[i]); } tbmanager.update(false); } private void clearMainToolBar(IToolBarManager tbmanager) { tbmanager.removeAll(); tbmanager.update(false); } /** * Creates the context menu for the hierarchy viewers */ private void fillTypesViewerContextMenu(TypeHierarchyViewer viewer, IMenuManager menu) { JavaPlugin.createStandardGroups(menu); // viewer entries viewer.contributeToContextMenu(menu); IStructuredSelection selection= (IStructuredSelection)viewer.getSelection(); if (JavaBasePreferencePage.openTypeHierarchyInPerspective()) { addOpenPerspectiveItem(menu, selection); } addOpenWithMenu(menu, selection); menu.appendToGroup(IContextMenuConstants.GROUP_SHOW, fFocusOnTypeAction); if (fFocusOnSelectionAction.canActionBeAdded()) menu.appendToGroup(IContextMenuConstants.GROUP_SHOW, fFocusOnSelectionAction); addRefactoring(menu, viewer); ContextMenuGroup.add(menu, new ContextMenuGroup[] { new BuildGroup(), new ReorgGroup() }, viewer); } /** * Creates the context menu for the method viewer */ private void fillMethodsViewerContextMenu(IMenuManager menu) { JavaPlugin.createStandardGroups(menu); // viewer entries fMethodsViewer.contributeToContextMenu(menu); if (fSelectedType != null && fAddStubAction.init(fSelectedType, fMethodsViewer.getSelection())) { menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, fAddStubAction); } menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, new JavaReplaceWithEditionAction(fMethodsViewer)); addOpenWithMenu(menu, (IStructuredSelection)fMethodsViewer.getSelection()); addRefactoring(menu, fMethodsViewer); ContextMenuGroup.add(menu, new ContextMenuGroup[] { new BuildGroup(), new ReorgGroup() }, fMethodsViewer); } private void addRefactoring(IMenuManager menu, IInputSelectionProvider viewer){ MenuManager refactoring= new MenuManager(TypeHierarchyMessages.getString("TypeHierarchyViewPart.menu.refactor")); //$NON-NLS-1$ ContextMenuGroup.add(refactoring, new ContextMenuGroup[] { new RefactoringGroup() }, viewer); if (!refactoring.isEmpty()) menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, refactoring); } private void addOpenWithMenu(IMenuManager menu, IStructuredSelection selection) { // If one file is selected get it. // Otherwise, do not show the "open with" menu. if (selection.size() != 1) return; Object element= selection.getFirstElement(); if (!(element instanceof IJavaElement)) return; IResource resource= null; try { resource= ((IJavaElement)element).getUnderlyingResource(); } catch(JavaModelException e) { // ignore } if (!(resource instanceof IFile)) return; // Create a menu flyout. MenuManager submenu= new MenuManager(TypeHierarchyMessages.getString("TypeHierarchyViewPart.menu.open")); //$NON-NLS-1$ submenu.add(new OpenWithMenu(getSite().getPage(), (IFile) resource)); // Add the submenu. menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, submenu); } private void addOpenPerspectiveItem(IMenuManager menu, IStructuredSelection selection) { OpenTypeHierarchyUtil.addToMenu(getSite().getWorkbenchWindow(), menu, selection); } /** * Toggles between the empty viewer page and the hierarchy */ private void setViewerVisibility(boolean showHierarchy) { if (showHierarchy) { fViewerbook.showPage(getCurrentViewer().getControl()); } else { fViewerbook.showPage(fEmptyTypesViewer); } } /** * Sets the member filter. <code>null</code> disables member filtering. */ private void setMemberFilter(IMember[] memberFilter) { Assert.isNotNull(fAllViewers); for (int i= 0; i < fAllViewers.length; i++) { fAllViewers[i].setMemberFilter(memberFilter); } updateHierarchyViewer(); updateTitle(); } private void updateSelection(IJavaElement elem) { ISelection sel= null; if (elem.getElementType() != IJavaElement.TYPE) { Object obj= getCurrentViewer().containsElements(); if (obj != null) { sel= new StructuredSelection(obj); } else { sel= StructuredSelection.EMPTY; } } else { sel= new StructuredSelection(elem); } getCurrentViewer().setSelection(sel); } /** * When the input changed or the hierarchy pane becomes visible, * <code>updateHierarchyViewer<code> brings up the correct view and refreshes * the current tree */ private void updateHierarchyViewer() { if (fInputElement == null) { fPagebook.showPage(fNoHierarchyShownLabel); } else { if (getCurrentViewer().containsElements() != null) { Runnable runnable= new Runnable() { public void run() { getCurrentViewer().updateContent(); } }; BusyIndicator.showWhile(getDisplay(), runnable); if (!isChildVisible(fViewerbook, getCurrentViewer().getControl())) { setViewerVisibility(true); } } else { fEmptyTypesViewer.setText(TypeHierarchyMessages.getFormattedString("TypeHierarchyViewPart.nodecl", fInputElement.getElementName())); //$NON-NLS-1$ setViewerVisibility(false); } } } private void updateMethodViewer(IType input) { if (input != fMethodsViewer.getInput() && !fIsEnableMemberFilter && fCurrentOrientation != VIEW_ORIENTATION_SINGLE) { if (input != null) { fMethodViewerPaneLabel.setText(fPaneLabelProvider.getText(input)); fMethodViewerPaneLabel.setImage(fPaneLabelProvider.getImage(input)); } else { fMethodViewerPaneLabel.setText(""); //$NON-NLS-1$ fMethodViewerPaneLabel.setImage(null); } fMethodsViewer.setInput(input); } } private void methodSelectionChanged(ISelection sel) { if (sel instanceof IStructuredSelection) { List selected= ((IStructuredSelection)sel).toList(); int nSelected= selected.size(); if (fIsEnableMemberFilter) { IMember[] memberFilter= null; if (nSelected > 0) { memberFilter= new IMember[nSelected]; selected.toArray(memberFilter); } setMemberFilter(memberFilter); } if (nSelected == 1) { revealElementInEditor(selected.get(0)); } } } private void typeSelectionChanged(ISelection sel) { if (sel instanceof IStructuredSelection) { List selected= ((IStructuredSelection)sel).toList(); int nSelected= selected.size(); if (nSelected != 0) { List types= new ArrayList(nSelected); for (int i= nSelected-1; i >= 0; i--) { Object elem= selected.get(i); if (elem instanceof IType && !types.contains(elem)) { types.add(elem); } } if (types.size() == 1) { fSelectedType= (IType) types.get(0); updateMethodViewer(fSelectedType); } else if (types.size() == 0) { // method selected, no change } if (nSelected == 1) { revealElementInEditor(selected.get(0)); } } else { fSelectedType= null; updateMethodViewer(null); } } } private void revealElementInEditor(Object elem) { // only allow revealing when the type hierarchy is the active pagae // no revealing after selection events due to model changes if (getSite().getPage().getActivePart() != this) { return; } IEditorPart editorPart= EditorUtility.isOpenInEditor(elem); if (editorPart != null && (elem instanceof IJavaElement)) { try { EditorUtility.openInEditor(elem, false); EditorUtility.revealInEditor(editorPart, (IJavaElement) elem); } catch (CoreException e) { JavaPlugin.log(e); } } } private Display getDisplay() { if (fPagebook != null && !fPagebook.isDisposed()) { return fPagebook.getDisplay(); } return null; } private boolean isChildVisible(Composite pb, Control child) { Control[] children= pb.getChildren(); for (int i= 0; i < children.length; i++) { if (children[i] == child && children[i].isVisible()) return true; } return false; } private void updateTitle() { String title= getCurrentViewer().getTitle(); setTitle(getCurrentViewer().getTitle()); String tooltip; if (fInputElement != null) { String[] args= new String[] { title, JavaElementLabels.getElementLabel(fInputElement, JavaElementLabels.ALL_DEFAULT) }; tooltip= TypeHierarchyMessages.getFormattedString("TypeHierarchyViewPart.tooltip", args); //$NON-NLS-1$ } else { tooltip= title; } setTitleToolTip(tooltip); } private void updateToolbarButtons() { boolean isType= fInputElement instanceof IType; for (int i= 0; i < fViewActions.length; i++) { ToggleViewAction action= fViewActions[i]; if (action.getViewerIndex() == VIEW_ID_TYPE) { action.setEnabled(fInputElement != null); } else { action.setEnabled(isType); } } } /** * Sets the current view (see view id) * called from ToggleViewAction. Must be called after creation of the viewpart. */ public void setView(int viewerIndex) { Assert.isNotNull(fAllViewers); if (viewerIndex < fAllViewers.length && fCurrentViewerIndex != viewerIndex) { fCurrentViewerIndex= viewerIndex; updateHierarchyViewer(); if (fInputElement != null) { ISelection currSelection= getCurrentViewer().getSelection(); if (currSelection == null || currSelection.isEmpty()) { updateSelection(fInputElement); } if (!fIsEnableMemberFilter) { typeSelectionChanged(getCurrentViewer().getSelection()); } } updateTitle(); if (fHierarchyProblemListener != null) { JavaPlugin.getDefault().getProblemMarkerManager().removeListener(fHierarchyProblemListener); } fHierarchyProblemListener= getCurrentViewer(); JavaPlugin.getDefault().getProblemMarkerManager().addListener(fHierarchyProblemListener); fDialogSettings.put(DIALOGSTORE_HIERARCHYVIEW, viewerIndex); getCurrentViewer().getTree().setFocus(); } for (int i= 0; i < fViewActions.length; i++) { ToggleViewAction action= fViewActions[i]; action.setChecked(fCurrentViewerIndex == action.getViewerIndex()); } } /** * Gets the curret active view index. */ public int getViewIndex() { return fCurrentViewerIndex; } private TypeHierarchyViewer getCurrentViewer() { return fAllViewers[fCurrentViewerIndex]; } /** * called from EnableMemberFilterAction. * Must be called after creation of the viewpart. */ public void enableMemberFilter(boolean on) { if (on != fIsEnableMemberFilter) { fIsEnableMemberFilter= on; if (!on) { Object methodViewerInput= fMethodsViewer.getInput(); setMemberFilter(null); if (methodViewerInput != null && getCurrentViewer().isElementShown(methodViewerInput)) { // avoid that the method view changes content by selecting the previous input getCurrentViewer().setSelection(new StructuredSelection(methodViewerInput)); } else if (fSelectedType != null) { // choose a input that exists getCurrentViewer().setSelection(new StructuredSelection(fSelectedType)); updateMethodViewer(fSelectedType); } } else { methodSelectionChanged(fMethodsViewer.getSelection()); } } fEnableMemberFilterAction.setChecked(on); } /** * Called from ITypeHierarchyLifeCycleListener. * Can be called from any thread */ private void doTypeHierarchyChanged(final TypeHierarchyLifeCycle typeHierarchy, final IType[] changedTypes) { Display display= getDisplay(); if (display != null) { display.asyncExec(new Runnable() { public void run() { doTypeHierarchyChangedOnViewers(changedTypes); } }); } } private void doTypeHierarchyChangedOnViewers(IType[] changedTypes) { if (changedTypes == null) { // hierarchy change if (fHierarchyLifeCycle.getHierarchy() == null || !fHierarchyLifeCycle.getHierarchy().exists()) { clearInput(); } else { try { fHierarchyLifeCycle.ensureRefreshedTypeHierarchy(fInputElement); } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); clearInput(); return; } updateHierarchyViewer(); } } else { // elements in hierarchy modified if (getCurrentViewer().isMethodFiltering()) { if (changedTypes.length == 1) { getCurrentViewer().refresh(changedTypes[0]); } else { updateHierarchyViewer(); } } else { getCurrentViewer().update(changedTypes, new String[] { IBasicPropertyConstants.P_TEXT, IBasicPropertyConstants.P_IMAGE } ); } } } /** * Determines the input element to be used initially . */ private IJavaElement determineInputElement() { Object input= getSite().getPage().getInput(); if (input instanceof IJavaElement) { return (IJavaElement) input; } return null; } /* * @see IViewPart#init */ public void init(IViewSite site, IMemento memento) throws PartInitException { super.init(site, memento); fMemento= memento; } /* * @see ViewPart#saveState(IMemento) */ public void saveState(IMemento memento) { if (fPagebook == null) { // part has not been created if (fMemento != null) { //Keep the old state; memento.putMemento(fMemento); } return; } if (fInputElement != null) { memento.putString(TAG_INPUT, fInputElement.getHandleIdentifier()); } memento.putInteger(TAG_VIEW, getViewIndex()); memento.putInteger(TAG_ORIENTATION, fCurrentOrientation); int weigths[]= fTypeMethodsSplitter.getWeights(); int ratio= (weigths[0] * 1000) / (weigths[0] + weigths[1]); memento.putInteger(TAG_RATIO, ratio); ScrollBar bar= getCurrentViewer().getTree().getVerticalBar(); int position= bar != null ? bar.getSelection() : 0; memento.putInteger(TAG_VERTICAL_SCROLL, position); IJavaElement selection= (IJavaElement)((IStructuredSelection) getCurrentViewer().getSelection()).getFirstElement(); if (selection != null) { memento.putString(TAG_SELECTION, selection.getHandleIdentifier()); } fMethodsViewer.saveState(memento); } /** * Restores the type hierarchy settings from a memento. */ private void restoreState(IMemento memento, IJavaElement defaultInput) { IJavaElement input= defaultInput; String elementId= memento.getString(TAG_INPUT); if (elementId != null) { input= JavaCore.create(elementId); if (!input.exists()) { input= null; } } setInputElement(input); Integer viewerIndex= memento.getInteger(TAG_VIEW); if (viewerIndex != null) { setView(viewerIndex.intValue()); } Integer orientation= memento.getInteger(TAG_ORIENTATION); if (orientation != null) { setOrientation(orientation.intValue()); } Integer ratio= memento.getInteger(TAG_RATIO); if (ratio != null) { fTypeMethodsSplitter.setWeights(new int[] { ratio.intValue(), 1000 - ratio.intValue() }); } ScrollBar bar= getCurrentViewer().getTree().getVerticalBar(); if (bar != null) { Integer vScroll= memento.getInteger(TAG_VERTICAL_SCROLL); if (vScroll != null) { bar.setSelection(vScroll.intValue()); } } String selectionId= memento.getString(TAG_SELECTION); if (selectionId != null) { IJavaElement elem= JavaCore.create(selectionId); if (getCurrentViewer().isElementShown(elem)) { getCurrentViewer().setSelection(new StructuredSelection(elem)); } } fMethodsViewer.restoreState(memento); } /** * Link selection to active editor. */ private void editorActivated(IEditorPart editor) { if (!JavaBasePreferencePage.linkTypeHierarchySelectionToEditor()) { return; } if (fInputElement == null) { // no type hierarchy shown return; } IJavaElement elem= (IJavaElement)editor.getEditorInput().getAdapter(IJavaElement.class); try { TypeHierarchyViewer currentViewer= getCurrentViewer(); if (elem instanceof IClassFile) { IType type= ((IClassFile)elem).getType(); if (currentViewer.isElementShown(type)) { currentViewer.setSelection(new StructuredSelection(type)); } } else if (elem instanceof ICompilationUnit) { IType[] allTypes= ((ICompilationUnit)elem).getAllTypes(); for (int i= 0; i < allTypes.length; i++) { if (currentViewer.isElementShown(allTypes[i])) { currentViewer.setSelection(new StructuredSelection(allTypes[i])); return; } } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } } }
6,051
Bug 6051 IllegalArgumentException in Initializer constructor
Build 20011115 Trying to browse the (newly added) static initializer of JavaModelManager: Log: Mon Nov 19 12:20:19 CET 2001 1 org.eclipse.core.resources 4 Unhandled exception caught in event loop. Unhandled exception caught in event loop. Reason: Log: Mon Nov 19 12:20:19 CET 2001 4 org.eclipse.ui 0 java.lang.IllegalArgumentException java.lang.IllegalArgumentException at org.eclipse.jdt.internal.core.Initializer.<init>(Initializer.java:24) at org.eclipse.jdt.internal.core.SourceType.getInitializer(SourceType.ja va:132) at org.eclipse.jdt.internal.ui.util.JavaModelUtil.findMemberInCompilatio nUnit(JavaModelUtil.java:161) at org.eclipse.jdt.internal.ui.util.JavaModelUtil.findInCompilationUnit( JavaModelUtil.java:208) at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.getWorkingCopy(E ditorUtility.java:272) at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor.getCorre spondingElement(CompilationUnitEditor.java:525) at org.eclipse.jdt.internal.ui.javaeditor.JavaEditor.setSelection(JavaEd itor.java:257) at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.revealInEditor(E ditorUtility.java:110) at org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart.linkToEdi tor(PackageExplorerPart.java:762) at org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart.handleSel ectionChanged(PackageExplorerPart.java:691) at org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart.access$0( PackageExplorerPart.java:687) at org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart$3.selecti onChanged(PackageExplorerPart.java:317) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java:147 ) at org.eclipse.jface.viewers.StructuredViewer.updateSelection(Structured Viewer.java:907) at org.eclipse.jface.viewers.StructuredViewer.handleSelect(StructuredVie wer.java:463) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected(Abstrac tTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java: 85) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:54) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:635) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1365) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1167) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:729) at org.eclipse.ui.internal.Workbench.run(Workbench.java:712) at org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoa der.java:820) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52) java.lang.IllegalArgumentException
resolved fixed
4029c4d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-19T18:14:44Z"
"2001-11-19T11:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/util/JavaModelUtil.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.util; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.Path; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IOpenable; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.Signature; /** * Utility methods for the Java Model. */ public class JavaModelUtil { /** * Finds a type by its qualified type name (dot separated). * @param jproject The java project to search in * @param str The fully qualified name (type name with enclosing type names and package (all separated by dots)) * @return The type found, or null if not existing * The method does not find inner types. Waiting for a Java Core solution */ public static IType findType(IJavaProject jproject, String fullyQualifiedName) throws JavaModelException { String pathStr= fullyQualifiedName.replace('.', '/') + ".java"; //$NON-NLS-1$ IJavaElement jelement= jproject.findElement(new Path(pathStr)); if (jelement == null) { // try to find it as inner type String qualifier= Signature.getQualifier(fullyQualifiedName); if (qualifier.length() > 0) { IType type= findType(jproject, qualifier); // recursive! if (type != null) { IType res= type.getType(Signature.getSimpleName(fullyQualifiedName)); if (res.exists()) { return res; } } } } else if (jelement.getElementType() == IJavaElement.COMPILATION_UNIT) { String simpleName= Signature.getSimpleName(fullyQualifiedName); return ((ICompilationUnit) jelement).getType(simpleName); } else if (jelement.getElementType() == IJavaElement.CLASS_FILE) { return ((IClassFile) jelement).getType(); } return null; } /** * Finds a type by package and type name. * @param jproject the java project to search in * @param pack The package name * @param typeQualifiedName the type qualified name (type name with enclosing type names (separated by dots)) * @return the type found, or null if not existing */ public static IType findType(IJavaProject jproject, String pack, String typeQualifiedName) throws JavaModelException { // should be supplied from java core int dot= typeQualifiedName.indexOf('.'); if (dot == -1) { return findType(jproject, concatenateName(pack, typeQualifiedName)); } IPath packPath; if (pack.length() > 0) { packPath= new Path(pack.replace('.', '/')); } else { packPath= new Path(""); //$NON-NLS-1$ } // fixed for 1GEXEI6: ITPJUI:ALL - Incorrect error message on class creation wizard IPath path= packPath.append(typeQualifiedName.substring(0, dot) + ".java"); //$NON-NLS-1$ IJavaElement elem= jproject.findElement(path); if (elem instanceof ICompilationUnit) { return findTypeInCompilationUnit((ICompilationUnit)elem, typeQualifiedName); } else if (elem instanceof IClassFile) { path= packPath.append(typeQualifiedName.replace('.', '$') + ".class"); //$NON-NLS-1$ elem= jproject.findElement(path); if (elem instanceof IClassFile) { return ((IClassFile)elem).getType(); } } return null; } /** * Finds a type container by container name. * The returned element will be of type <code>IType</code> or a <code>IPackageFragment</code>. * <code>null</code> is returned if the type container could not be found. * @param jproject The Java project defining the context to search * @param typeContainerName A dot separarted name of the type container * @see #getTypeContainerName() */ public static IJavaElement findTypeContainer(IJavaProject jproject, String typeContainerName) throws JavaModelException { // try to find it as type IJavaElement result= findType(jproject, typeContainerName); if (result == null) { // find it as package IPath path= new Path(typeContainerName.replace('.', '/')); result= jproject.findElement(path); if (!(result instanceof IPackageFragment)) { result= null; } } return result; } /** * Finds a type in a compilation unit. Typical usage is to find the corresponding * type in a working copy. * @param cu the compilation unit to search in * @param typeQualifiedName the type qualified name (type name with enclosing type names (separated by dots)) * @return the type found, or null if not existing */ public static IType findTypeInCompilationUnit(ICompilationUnit cu, String typeQualifiedName) throws JavaModelException { IType[] types= cu.getAllTypes(); for (int i= 0; i < types.length; i++) { String currName= getTypeQualifiedName(types[i]); if (typeQualifiedName.equals(currName)) { return types[i]; } } return null; } /** * Finds a a member in a compilation unit. Typical usage is to find the corresponding * member in a working copy. * @param cu the compilation unit (eg. working copy) to search in * @param member the member (eg. from the original) * @return the member found, or null if not existing */ public static IMember findMemberInCompilationUnit(ICompilationUnit cu, IMember member) throws JavaModelException { if (member.getElementType() == IJavaElement.TYPE) { return findTypeInCompilationUnit(cu, getTypeQualifiedName((IType)member)); } else { IType declaringType= findTypeInCompilationUnit(cu, getTypeQualifiedName(member.getDeclaringType())); if (declaringType != null) { IMember result= null; switch (member.getElementType()) { case IJavaElement.FIELD: result= declaringType.getField(member.getElementName()); break; case IJavaElement.METHOD: IMethod meth= (IMethod) member; result= findMethod(meth.getElementName(), meth.getParameterTypes(), meth.isConstructor(), declaringType); break; case IJavaElement.INITIALIZER: result= declaringType.getInitializer(0); break; } if (result != null && result.exists()) { return result; } } } return null; } /** * Returns the element contained in the given set with the same name * as the given key. * * @param set the set to choose from * @param key the key to look for * @return the member of the given set with the same name as the given key */ private static IJavaElement find(IJavaElement[] set, IJavaElement key) { if (set == null) return null; String name= key.getElementName(); if (name == null) return null; for (int i= 0; i < set.length; i++) { if (name.equals(set[i].getElementName())) return set[i]; } return null; } /** * Returns the element of the given compilation unit which is "equal" to the * given element. Note that the given element usually has a parent different * from the given compilation unit. * * @param cu the cu to search in * @param element the element to look for * @return an element of the given cu "equal" to the given element */ public static IJavaElement findInCompilationUnit(ICompilationUnit cu, IJavaElement element) throws JavaModelException { if (element instanceof IMember) return findMemberInCompilationUnit(cu, (IMember) element); int type= element.getElementType(); switch (type) { case IJavaElement.IMPORT_CONTAINER: return cu.getImportContainer(); case IJavaElement.PACKAGE_DECLARATION: return find(cu.getPackageDeclarations(), element); case IJavaElement.IMPORT_DECLARATION: return find(cu.getImports(), element); case IJavaElement.COMPILATION_UNIT: return cu; } return null; } /** * Returns the qualified type name of the given type using '.' as separators. * This is a replace for IType.getTypeQualifiedName() * which uses '$' as separators. As '$' is also a valid character in an id * this is ambiguous. JavaCore PR: 1GCFUNT */ public static String getTypeQualifiedName(IType type) { StringBuffer buf= new StringBuffer(); getTypeQualifiedName(type, buf); return buf.toString(); } private static void getTypeQualifiedName(IType type, StringBuffer buf) { IType outerType= type.getDeclaringType(); if (outerType != null) { getTypeQualifiedName(outerType, buf); buf.append('.'); } buf.append(type.getElementName()); } /** * Returns the fully qualified name of the given type using '.' as separators. * This is a replace for IType.getFullyQualifiedTypeName * which uses '$' as separators. As '$' is also a valid character in an id * this is ambiguous. JavaCore PR: 1GCFUNT */ public static String getFullyQualifiedName(IType type) { StringBuffer buf= new StringBuffer(); String packName= type.getPackageFragment().getElementName(); if (packName.length() > 0) { buf.append(packName); buf.append('.'); } getTypeQualifiedName(type, buf); return buf.toString(); } /** * Returns the fully qualified name of a type's container. (package name or enclosing type name) */ public static String getTypeContainerName(IType type) { IType outerType= type.getDeclaringType(); if (outerType != null) { return getFullyQualifiedName(outerType); } else { return type.getPackageFragment().getElementName(); } } /** * Returns the raw class path entry corresponding to a package fragment root * or null if there isn't a corresponding entry. */ public static IClasspathEntry getRawClasspathEntry(IPackageFragmentRoot root) throws JavaModelException { IPath path= root.getPath(); IClasspathEntry[] entries= root.getJavaProject().getRawClasspath(); for (int i= 0; i < entries.length; i++) { IClasspathEntry curr= entries[i]; if (curr.getEntryKind() == IClasspathEntry.CPE_VARIABLE) { curr= JavaCore.getResolvedClasspathEntry(curr); } if (curr != null && curr.getContentKind() == root.getKind() && path.equals(curr.getPath())) { return entries[i]; } } return null; } /** * Concatenates two names. Uses a dot for separation. * Both strings can be empty or <code>null</code>. */ public static String concatenateName(String name1, String name2) { StringBuffer buf= new StringBuffer(); if (name1 != null && name1.length() > 0) { buf.append(name1); if (name2 != null && name2.length() > 0) { buf.append('.'); buf.append(name2); } } return buf.toString(); } /** * Evaluates if a member (possible from another package) is visible from * elements in a package. * @param member The member to test the visibility for * @param pack The package in focus */ public static boolean isVisible(IMember member, IPackageFragment pack) throws JavaModelException { int otherflags= member.getFlags(); if (Flags.isPublic(otherflags) || Flags.isProtected(otherflags)) { return true; } else if (Flags.isPrivate(otherflags)) { return false; } IPackageFragment otherpack= (IPackageFragment) findParentOfKind(member, IJavaElement.PACKAGE_FRAGMENT); return (pack != null && pack.equals(otherpack)); } /** * Returns true if the element is on the build path of the given project */ public static boolean isOnBuildPath(IJavaProject jproject, IJavaElement element) throws JavaModelException { IPath rootPath; if (element.getElementType() == IJavaElement.JAVA_PROJECT) { rootPath= ((IJavaProject)element).getProject().getFullPath(); } else { IPackageFragmentRoot root= getPackageFragmentRoot(element); if (root == null) { return false; } rootPath= root.getPath(); } return jproject.findPackageFragmentRoot(rootPath) != null; } /** * Returns the package fragment root of <code>IJavaElement</code>. If the given * element is already a package fragment root, the element itself is returned. */ public static IPackageFragmentRoot getPackageFragmentRoot(IJavaElement element) { return (IPackageFragmentRoot)findElementOfKind(element, IJavaElement.PACKAGE_FRAGMENT_ROOT); } /** * Returns the first openable parent. If the given element is openable, the element * itself is returned. */ public static IOpenable getOpenable(IJavaElement element) { while (element != null && !(element instanceof IOpenable)) { element= element.getParent(); } return (IOpenable) element; } /** * Returns the parent of the supplied java element that conforms to the given * parent type or <code>null</code>, if such a parent doesn't exit. */ public static IJavaElement findParentOfKind(IJavaElement element, int kind) { if (element == null) return null; return findElementOfKind(element.getParent(), kind); } /** * Returns the first java element that conforms to the given type walking the * java element's parent relationship. If the given element alrady conforms to * the given kind, the element is returned. * Returns <code>null</code> if no such element exits. */ public static IJavaElement findElementOfKind(IJavaElement element, int kind) { while (element != null && element.getElementType() != kind) element= element.getParent(); return element; } /** * Finds a method in a type. * This searches for a method with the same name and signature. Parameter types are only * compared by the simple name, no resolving for the fully qualified type name is done. * Constructors are only compared by parameters, not the name. * @param name The name of the method to find * @param paramTypes The type signatures of the parameters e.g. <code>{"QString;","I"}</code> * @param isConstructor If the method is a constructor * @return The first found method or <code>null</code>, if nothing found */ public static IMethod findMethod(String name, String[] paramTypes, boolean isConstructor, IType type) throws JavaModelException { return findMethod(name, paramTypes, isConstructor, type.getMethods()); } /** * Finds a method by name. * This searches for a method with a name and signature. Parameter types are only * compared by the simple name, no resolving for the fully qualified type name is done. * Constructors are only compared by parameters, not the name. * @param name The name of the method to find * @param paramTypes The type signatures of the parameters e.g. <code>{"QString;","I"}</code> * @param isConstructor If the method is a constructor * @param methods The methods to search in * @return The found method or <code>null</code>, if nothing found */ public static IMethod findMethod(String name, String[] paramTypes, boolean isConstructor, IMethod[] methods) throws JavaModelException { for (int i= methods.length - 1; i >= 0; i--) { if (isSameMethodSignature(name, paramTypes, isConstructor, methods[i])) { return methods[i]; } } return null; } /** * Finds a method declararion in a type's hierarchy. The search is top down, so this * returns the first declaration of the method in the hierarchy. * This searches for a method with a name and signature. Parameter types are only * compared by the simple name, no resolving for the fully qualified type name is done. * Constructors are only compared by parameters, not the name. * @param name The name of the method to find * @param paramTypes The type signatures of the parameters e.g. <code>{"QString;","I"}</code> * @param isConstructor If the method is a constructor * @return The first method found or null, if nothing found */ public static IMethod findMethodDeclarationInHierarchy(ITypeHierarchy hierarchy, String name, String[] paramTypes, boolean isConstructor) throws JavaModelException { IType[] superTypes= hierarchy.getAllSupertypes(hierarchy.getType()); for (int i= superTypes.length - 1; i >= 0; i--) { IMethod found= findMethod(name, paramTypes, isConstructor, superTypes[i]); if (found != null) { return found; } } return null; } /** * Finds a method implementation in a type's hierarchy. The search is bottom-up, so this * returns the overwritten method. * This searches for a method with a name and signature. Parameter types are only * compared by the simple name, no resolving for the fully qualified type name is done. * Constructors are only compared by parameters, not the name. * @param name The name of the method to find * @param paramTypes The type signatures of the parameters e.g. <code>{"QString;","I"}</code> * @param isConstructor If the method is a constructor * @return The first method found or null, if nothing found */ public static IMethod findMethodImplementationInHierarchy(ITypeHierarchy hierarchy, String name, String[] paramTypes, boolean isConstructor) throws JavaModelException { IType[] superTypes= hierarchy.getAllSupertypes(hierarchy.getType()); for (int i= 0; i < superTypes.length; i++) { IMethod found= findMethod(name, paramTypes, isConstructor, superTypes[i]); if (found != null) { return found; } } return null; } /** * Tests if a method equals to the given signature. * Parameter types are only compared by the simple name, no resolving for * the fully qualified type name is done. Constructors are only compared by * parameters, not the name. * @param Name of the method * @param The type signatures of the parameters e.g. <code>{"QString;","I"}</code> * @param Specifies if the method is a constructor * @return Returns <code>true</code> if the method has the given name and parameter types and constructor state. */ public static boolean isSameMethodSignature(String name, String[] paramTypes, boolean isConstructor, IMethod curr) throws JavaModelException { if (isConstructor || name.equals(curr.getElementName())) { if (isConstructor == curr.isConstructor()) { String[] currParamTypes= curr.getParameterTypes(); if (paramTypes.length == currParamTypes.length) { for (int i= 0; i < paramTypes.length; i++) { String t1= Signature.getSimpleName(Signature.toString(paramTypes[i])); String t2= Signature.getSimpleName(Signature.toString(currParamTypes[i])); if (!t1.equals(t2)) { return false; } } return true; } } } return false; } /** * Checks whether the given type has a valid main method or not. */ public static boolean hasMainMethod(IType type) throws JavaModelException { String[] paramSignature= { Signature.createArraySignature(Signature.createTypeSignature("String", false), 1) }; IMethod method= findMethod("main", paramSignature, false, type); if (method != null) { int flags= method.getFlags(); return Flags.isStatic(flags) && Flags.isPublic(flags) && Signature.SIG_VOID.equals(method.getReturnType()); } return false; } /** * Tests if a method is a main method. Does not resolve the parameter types. * Method must exist. */ public static boolean isMainMethod(IMethod method) throws JavaModelException { if ("main".equals(method.getElementName()) && Signature.SIG_VOID.equals(method.getReturnType())) { //$NON-NLS-1$ int flags= method.getFlags(); if (Flags.isStatic(flags) && Flags.isPublic(flags)) { String[] paramTypes= method.getParameterTypes(); if (paramTypes.length == 1) { String name= Signature.toString(paramTypes[0]); return "String[]".equals(Signature.getSimpleName(name)); //$NON-NLS-1$ } } } return false; } /** * Resolves a type name in the context of the declaring type. * @param refTypeSig the type name in signature notation (for example 'QVector') * this can also be an array type, but dimensions will be ignored. * @param declaringType the context for resolving (type where the reference was made in) * @return returns the fully qualified type name or build-in-type name. * if a unresoved type couldn't be resolved null is returned */ public static String getResolvedTypeName(String refTypeSig, IType declaringType) throws JavaModelException { int arrayCount= Signature.getArrayCount(refTypeSig); char type= refTypeSig.charAt(arrayCount); if (type == Signature.C_UNRESOLVED) { int semi= refTypeSig.indexOf(Signature.C_SEMICOLON, arrayCount + 1); if (semi == -1) { throw new IllegalArgumentException(); } String name= refTypeSig.substring(arrayCount + 1, semi); String[][] resolvedNames= declaringType.resolveType(name); if (resolvedNames != null && resolvedNames.length > 0) { return JavaModelUtil.concatenateName(resolvedNames[0][0], resolvedNames[0][1]); } return null; } else { return Signature.toString(refTypeSig.substring(arrayCount)); } } }
6,054
Bug 6054 renaming a read-only package resets the read-only flag [refactoring]
as said in the summery: renaming a read-only package resets the read-only flag
resolved fixed
60dde0a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-19T19:03:29Z"
"2001-11-19T11:40:00Z"
org.eclipse.jdt.ui.tests.refactoring/resources/RenamePackage/testReadOnly/in/r/A.java
6,054
Bug 6054 renaming a read-only package resets the read-only flag [refactoring]
as said in the summery: renaming a read-only package resets the read-only flag
resolved fixed
60dde0a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-19T19:03:29Z"
"2001-11-19T11:40:00Z"
org.eclipse.jdt.ui.tests.refactoring/resources/RenamePackage/testReadOnly/out/p1/A.java
6,054
Bug 6054 renaming a read-only package resets the read-only flag [refactoring]
as said in the summery: renaming a read-only package resets the read-only flag
resolved fixed
60dde0a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-19T19:03:29Z"
"2001-11-19T11:40:00Z"
org.eclipse.jdt.ui.tests.refactoring/test
6,054
Bug 6054 renaming a read-only package resets the read-only flag [refactoring]
as said in the summery: renaming a read-only package resets the read-only flag
resolved fixed
60dde0a
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-19T19:03:29Z"
"2001-11-19T11:40:00Z"
cases/org/eclipse/jdt/ui/tests/refactoring/RenamePackageTests.java
6,050
Bug 6050 Avoid references to preference pages
Preference pages are optional. It should be possible to add and remove them from the code without further impact on the system. I.e. preference pages should not be used as accessors to preference settings. (See JavaCompletionProcessor)
resolved fixed
a28ec98
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-20T11:02:04Z"
"2001-11-19T11:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/WorkInProgressPreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import org.eclipse.swt.widgets.Composite; import org.eclipse.jface.preference.BooleanFieldEditor; import org.eclipse.jface.preference.FieldEditorPreferencePage; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; /* * The page for setting 'work in progress' features preferences. */ public class WorkInProgressPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage { private static final String CODE_ASSIST_EXPERIMENTAL= "org.eclipse.jdt.ui.text.codeassist.experimental"; //$NON-NLS-1$ public WorkInProgressPreferencePage() { super(GRID); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(JavaUIMessages.getString("WorkInProgressPreferencePage.description")); //$NON-NLS-1$ } public static void initDefaults(IPreferenceStore store) { store.setDefault(CODE_ASSIST_EXPERIMENTAL, false); } /** * @see PreferencePage#createControl(Composite) */ public void createControl(Composite parent) { super.createControl(parent); WorkbenchHelp.setHelp(getControl(), new DialogPageContextComputer(this, IJavaHelpContextIds.WORK_IN_PROGRESS_PREFERENCE_PAGE)); } protected void createFieldEditors() { Composite parent= getFieldEditorParent(); BooleanFieldEditor boolEditor= new BooleanFieldEditor( CODE_ASSIST_EXPERIMENTAL, JavaUIMessages.getString("WorkInProgressPreferencePage.codeassist.experimental"), //$NON-NLS-1$ parent ); addField(boolEditor); } public void init(IWorkbench workbench) { } public static boolean fillArgumentsOnMethodCompletion() { IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore(); return store.getBoolean(CODE_ASSIST_EXPERIMENTAL); } }
6,050
Bug 6050 Avoid references to preference pages
Preference pages are optional. It should be possible to add and remove them from the code without further impact on the system. I.e. preference pages should not be used as accessors to preference settings. (See JavaCompletionProcessor)
resolved fixed
a28ec98
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-20T11:02:04Z"
"2001-11-19T11:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ExperimentalPreference.java
6,050
Bug 6050 Avoid references to preference pages
Preference pages are optional. It should be possible to add and remove them from the code without further impact on the system. I.e. preference pages should not be used as accessors to preference settings. (See JavaCompletionProcessor)
resolved fixed
a28ec98
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-20T11:02:04Z"
"2001-11-19T11:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProcessor.java
package org.eclipse.jdt.internal.ui.text.java; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import org.eclipse.swt.graphics.Point; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.ITextViewer; import org.eclipse.jface.text.contentassist.ICompletionProposal; import org.eclipse.jface.text.contentassist.IContentAssistProcessor; import org.eclipse.jface.text.contentassist.IContextInformation; import org.eclipse.jface.text.contentassist.IContextInformationValidator; import org.eclipse.ui.IEditorPart; import java.util.Arrays; import java.util.Comparator; import java.util.Hashtable; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.preferences.WorkInProgressPreferencePage; import org.eclipse.jdt.internal.ui.text.template.TemplateContext; import org.eclipse.jdt.internal.ui.text.template.TemplateEngine; /** * Java completion processor. */ public class JavaCompletionProcessor implements IContentAssistProcessor { private static class CompletionProposalComparator implements Comparator { public int compare(Object o1, Object o2) { ICompletionProposal c1= (ICompletionProposal) o1; ICompletionProposal c2= (ICompletionProposal) o2; return c1.getDisplayString().compareTo(c2.getDisplayString()); } }; private final static String VISIBILITY= "org.eclipse.jdt.core.codeComplete.visibilityCheck"; private final static String ENABLED= "enabled"; private final static String DISABLED= "disabled"; private IEditorPart fEditor; private ResultCollector fCollector; private IWorkingCopyManager fManager; private IContextInformationValidator fValidator; private char[] fProposalAutoActivationSet; private Comparator fComparator; private TemplateEngine fTemplateEngine; private ExperimentalResultCollector fExperimentalCollector; public JavaCompletionProcessor(IEditorPart editor) { fEditor= editor; fCollector= new ResultCollector(); fManager= JavaPlugin.getDefault().getWorkingCopyManager(); fTemplateEngine= new TemplateEngine(TemplateContext.JAVA); fExperimentalCollector= new ExperimentalResultCollector(); } /** * Sets this processor's set of characters triggering the activation of the * completion proposal computation. * * @param activationSet the activation set */ public void setCompletionProposalAutoActivationCharacters(char[] activationSet) { fProposalAutoActivationSet= activationSet; } /** * Tells this processor to restrict its proposal to those element * visible in the actual invocation context. * * @param restrict <code>true</code> if proposals should be restricted */ public void restrictProposalsToVisibility(boolean restrict) { Hashtable options= JavaCore.getOptions(); Object value= options.get(VISIBILITY); if (value instanceof String) { String newValue= restrict ? ENABLED : DISABLED; if ( !newValue.equals((String) value)) { options.put(VISIBILITY, newValue); JavaCore.setOptions(options); } } } /** * Tells this processor to order the proposals alphabetically. * * @param order <code>true</code> if proposals should be ordered. */ public void orderProposalsAlphabetically(boolean order) { fComparator= order ? new CompletionProposalComparator() : null; } /** * Tells this processor to restrict is proposals to those * starting with matching cases. * * @param restrict <code>true</code> if proposals should be restricted */ public void restrictProposalsToMatchingCases(boolean restrict) { // not yet supported } /** * @see IContentAssistProcessor#getErrorMessage() */ public String getErrorMessage() { return fCollector.getErrorMessage(); } /** * @see IContentAssistProcessor#getContextInformationValidator() */ public IContextInformationValidator getContextInformationValidator() { if (fValidator == null) fValidator= new JavaParameterListValidator(); return fValidator; } /** * @see IContentAssistProcessor#getContextInformationAutoActivationCharacters() */ public char[] getContextInformationAutoActivationCharacters() { return null; } /** * @see IContentAssistProcessor#getCompletionProposalAutoActivationCharacters() */ public char[] getCompletionProposalAutoActivationCharacters() { return fProposalAutoActivationSet; } /** * @see IContentAssistProcessor#computeContextInformation(ITextViewer, int) */ public IContextInformation[] computeContextInformation(ITextViewer viewer, int offset) { return null; } /** * @see IContentAssistProcessor#computeCompletionProposals(ITextViewer, int) */ public ICompletionProposal[] computeCompletionProposals(ITextViewer viewer, int offset) { ICompilationUnit unit= fManager.getWorkingCopy(fEditor.getEditorInput()); IDocument document= viewer.getDocument(); ICompletionProposal[] results; if (WorkInProgressPreferencePage.fillArgumentsOnMethodCompletion()) { try { if (unit != null) { fExperimentalCollector.reset(viewer, offset, unit.getJavaProject(), unit); Point selection= viewer.getSelectedRange(); if (selection.y > 0) fExperimentalCollector.setReplacementLength(selection.y); unit.codeComplete(offset, fExperimentalCollector); } } catch (JavaModelException x) { Shell shell= viewer.getTextWidget().getShell(); ErrorDialog.openError(shell, JavaTextMessages.getString("CompletionProcessor.error.accessing.title"), JavaTextMessages.getString("CompletionProcessor.error.accessing.message"), x.getStatus()); //$NON-NLS-2$ //$NON-NLS-1$ } results= fExperimentalCollector.getResults(); } else { try { if (unit != null) { fCollector.reset(offset, unit.getJavaProject(), unit); Point selection= viewer.getSelectedRange(); if (selection.y > 0) fCollector.setReplacementLength(selection.y); unit.codeComplete(offset, fCollector); } } catch (JavaModelException x) { Shell shell= viewer.getTextWidget().getShell(); ErrorDialog.openError(shell, JavaTextMessages.getString("CompletionProcessor.error.accessing.title"), JavaTextMessages.getString("CompletionProcessor.error.accessing.message"), x.getStatus()); //$NON-NLS-2$ //$NON-NLS-1$ } results= fCollector.getResults(); } try { fTemplateEngine.reset(); fTemplateEngine.complete(viewer, offset, unit); } catch (JavaModelException x) { Shell shell= viewer.getTextWidget().getShell(); ErrorDialog.openError(shell, JavaTextMessages.getString("CompletionProcessor.error.accessing.title"), JavaTextMessages.getString("CompletionProcessor.error.accessing.message"), x.getStatus()); //$NON-NLS-2$ //$NON-NLS-1$ } ICompletionProposal[] templateResults= fTemplateEngine.getResults(); // concatenate arrays ICompletionProposal[] total= new ICompletionProposal[results.length + templateResults.length]; System.arraycopy(templateResults, 0, total, 0, templateResults.length); System.arraycopy(results, 0, total, templateResults.length, results.length); /* * Order here and not in result collector to make sure that the order * applies to all proposals and not just those of the compilation unit. */ return order(total); } /** * Order the given proposals. */ private ICompletionProposal[] order(ICompletionProposal[] proposals) { if (fComparator != null) Arrays.sort(proposals, fComparator); return proposals; } }
5,765
Bug 5765 New Class button in empty workspace should be more supportive
User feedback: "Confused how to create my first project" We should be more supportive in the UI for this special case since it is a first time experience with the UI. Therefore when the workbench is empty we should offer to create a new Java project. Minimal solution is to show an info dialog that explains that user should create a project first and offer a button to open the Java project wizard. The same is true for the new package and new interface buttons.
resolved fixed
ed4c009
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-20T14:08:51Z"
"2001-11-10T19:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/AbstractOpenWizardAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.actions; import java.util.Iterator; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IAction; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.wizard.Wizard; import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.IWorkbenchWindowActionDelegate; import org.eclipse.ui.IWorkbenchWizard; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; public abstract class AbstractOpenWizardAction extends Action implements IWorkbenchWindowActionDelegate { private Class[] fActivatedOnTypes; private boolean fAcceptEmptySelection; private boolean fNoChecking; /** * Creates a AbstractOpenWizardAction. * @param label The label of the action * @param acceptEmptySelection Specifies if the action allows an empty selection */ public AbstractOpenWizardAction(String label, boolean acceptEmptySelection) { this(label, null, acceptEmptySelection); } /** * Creates a AbstractOpenWizardAction. * @param label The label of the action * @param activatedOnTypes The action is only enabled when all objects in the selection * are of the given types. <code>null</code> will allow all types. * @param acceptEmptySelection Specifies if the action allows an empty selection */ public AbstractOpenWizardAction(String label, Class[] activatedOnTypes, boolean acceptEmptySelection) { super(label); fActivatedOnTypes= activatedOnTypes; fAcceptEmptySelection= acceptEmptySelection; } /** * Creates a AbstractOpenWizardAction with no restrictions on types, and does allow * an empty selection. */ protected AbstractOpenWizardAction() { fActivatedOnTypes= null; fAcceptEmptySelection= true; fNoChecking= true; } protected IWorkbench getWorkbench() { return JavaPlugin.getDefault().getWorkbench(); } private boolean isOfAcceptedType(Object obj) { if (fActivatedOnTypes != null) { for (int i= 0; i < fActivatedOnTypes.length; i++) { if (fActivatedOnTypes[i].isInstance(obj)) { return true; } } return false; } return true; } private boolean isEnabled(IStructuredSelection selection) { Iterator iter= selection.iterator(); while (iter.hasNext()) { Object obj= iter.next(); if (!isOfAcceptedType(obj) || !shouldAcceptElement(obj)) { return false; } } return true; } /** * Can be overridden to add more checks. * obj is guaranteed to be instance of one of the accepted types */ protected boolean shouldAcceptElement(Object obj) { return true; } /** * Creates the specific wizard. * (to be implemented by a subclass) */ abstract protected Wizard createWizard(); protected IStructuredSelection getCurrentSelection() { IWorkbenchWindow window= JavaPlugin.getActiveWorkbenchWindow(); if (window != null) { ISelection selection= window.getSelectionService().getSelection(); if (selection instanceof IStructuredSelection) { return (IStructuredSelection) selection; } } return null; } /** * The user has invoked this action. */ public void run() { if (!fNoChecking && !canActionBeAdded()) { return; } Wizard wizard= createWizard(); if (wizard instanceof IWorkbenchWizard) { ((IWorkbenchWizard)wizard).init(getWorkbench(), getCurrentSelection()); } WizardDialog dialog= new WizardDialog(JavaPlugin.getActiveWorkbenchShell(), wizard); dialog.create(); dialog.getShell().setText(JavaUIMessages.getString("AbstractOpenWizardAction.title")); //$NON-NLS-1$ dialog.open(); } /** * Tests if the action can be run on the current selection. */ public boolean canActionBeAdded() { IStructuredSelection selection= getCurrentSelection(); if (selection == null || selection.isEmpty()) { return fAcceptEmptySelection; } return isEnabled(selection); } /* * @see IActionDelegate#run(IAction) */ public void run(IAction action) { run(); } /* * @see IWorkbenchWindowActionDelegate#dispose() */ public void dispose() { } /* * @see IWorkbenchWindowActionDelegate#init(IWorkbenchWindow) */ public void init(IWorkbenchWindow window) { } /* * @see IActionDelegate#selectionChanged(IAction, ISelection) */ public void selectionChanged(IAction action, ISelection selection) { // selection taken from selectionprovider } }
5,765
Bug 5765 New Class button in empty workspace should be more supportive
User feedback: "Confused how to create my first project" We should be more supportive in the UI for this special case since it is a first time experience with the UI. Therefore when the workbench is empty we should offer to create a new Java project. Minimal solution is to show an info dialog that explains that user should create a project first and offer a button to open the Java project wizard. The same is true for the new package and new interface buttons.
resolved fixed
ed4c009
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-20T14:08:51Z"
"2001-11-10T19:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/AbstractOpenWizardAction.java
5,765
Bug 5765 New Class button in empty workspace should be more supportive
User feedback: "Confused how to create my first project" We should be more supportive in the UI for this special case since it is a first time experience with the UI. Therefore when the workbench is empty we should offer to create a new Java project. Minimal solution is to show an info dialog that explains that user should create a project first and offer a button to open the Java project wizard. The same is true for the new package and new interface buttons.
resolved fixed
ed4c009
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-20T14:08:51Z"
"2001-11-10T19:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/ContainerPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards; import org.eclipse.swt.widgets.Composite; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Path; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.JavaElementContentProvider; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.ISelectionValidator; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementSorter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IStringButtonAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringButtonDialogField; public abstract class ContainerPage extends NewElementWizardPage { /** * container field id */ protected static final String CONTAINER= "ContainerPage.container"; //$NON-NLS-1$ /** * Status of last validation */ protected IStatus fContainerStatus; private StringButtonDialogField fContainerDialogField; /* * package fragment root corresponding to the input type (can be null) */ private IPackageFragmentRoot fCurrRoot; private IWorkspaceRoot fWorkspaceRoot; public ContainerPage(String name, IWorkspaceRoot root) { super(name); fWorkspaceRoot= root; ContainerFieldAdapter adapter= new ContainerFieldAdapter(); fContainerDialogField= new StringButtonDialogField(adapter); fContainerDialogField.setDialogFieldListener(adapter); fContainerDialogField.setLabelText(NewWizardMessages.getString("ContainerPage.container.label")); //$NON-NLS-1$ fContainerDialogField.setButtonLabel(NewWizardMessages.getString("ContainerPage.container.button")); //$NON-NLS-1$ fContainerStatus= new StatusInfo(); fCurrRoot= null; } /** * Initializes the fields provided by the container page with a given * Java element as selection. * @param elem The initial selection of this page or null if no * selection was available */ protected void initContainerPage(IJavaElement elem) { IPackageFragmentRoot initRoot= null; if (elem != null) { initRoot= JavaModelUtil.getPackageFragmentRoot(elem); if (initRoot == null || initRoot.isArchive()) { IJavaProject jproject= elem.getJavaProject(); try { initRoot= null; IPackageFragmentRoot[] roots= jproject.getPackageFragmentRoots(); for (int i= 0; i < roots.length; i++) { if (roots[i].getKind() == IPackageFragmentRoot.K_SOURCE) { initRoot= roots[i]; break; } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } if (initRoot == null) { initRoot= jproject.getPackageFragmentRoot(""); //$NON-NLS-1$ } } } setPackageFragmentRoot(initRoot, true); } /** * Creates the controls for the container field. * @param parent The parent composite * @param nColumns The number of columns to span */ protected void createContainerControls(Composite parent, int nColumns) { fContainerDialogField.doFillIntoGrid(parent, nColumns); } protected void setFocusOnContainer() { fContainerDialogField.setFocus(); } // -------- ContainerFieldAdapter -------- private class ContainerFieldAdapter implements IStringButtonAdapter, IDialogFieldListener { // -------- IStringButtonAdapter public void changeControlPressed(DialogField field) { containerChangeControlPressed(field); } // -------- IDialogFieldListener public void dialogFieldChanged(DialogField field) { containerDialogFieldChanged(field); } } private void containerChangeControlPressed(DialogField field) { // take the current jproject as init element of the dialog IPackageFragmentRoot root= getPackageFragmentRoot(); root= chooseSourceContainer(root); if (root != null) { setPackageFragmentRoot(root, true); } } private void containerDialogFieldChanged(DialogField field) { if (field == fContainerDialogField) { fContainerStatus= containerChanged(); } // tell all others handleFieldChanged(CONTAINER); } // ----------- validation ---------- /** * Called after the container field has changed. * Updates the model and returns the status. * Model is only valid if returned status is OK */ protected IStatus containerChanged() { StatusInfo status= new StatusInfo(); fCurrRoot= null; String str= getContainerText(); if ("".equals(str)) { //$NON-NLS-1$ status.setError(NewWizardMessages.getString("ContainerPage.error.EnterContainerName")); //$NON-NLS-1$ return status; } IPath path= new Path(str); IResource res= fWorkspaceRoot.findMember(path); if (res != null) { int resType= res.getType(); if (resType == IResource.PROJECT || resType == IResource.FOLDER) { IProject proj= res.getProject(); if (!proj.isOpen()) { status.setError(NewWizardMessages.getFormattedString("ContainerPage.error.ProjectClosed", proj.getFullPath().toString())); //$NON-NLS-1$ return status; } IJavaProject jproject= JavaCore.create(proj); fCurrRoot= jproject.getPackageFragmentRoot(res); if (fCurrRoot.exists()) { try { if (!proj.hasNature(JavaCore.NATURE_ID)) { if (resType == IResource.PROJECT) { status.setWarning(NewWizardMessages.getString("ContainerPage.warning.NotAJavaProject")); //$NON-NLS-1$ } else { status.setWarning(NewWizardMessages.getString("ContainerPage.warning.NotInAJavaProject")); //$NON-NLS-1$ } return status; } } catch (CoreException e) { status.setWarning(NewWizardMessages.getString("ContainerPage.warning.NotAJavaProject")); //$NON-NLS-1$ } try { if (!JavaModelUtil.isOnBuildPath(jproject, fCurrRoot)) { status.setWarning(NewWizardMessages.getFormattedString("ContainerPage.warning.NotOnClassPath", str)); //$NON-NLS-1$ } } catch (JavaModelException e) { status.setWarning(NewWizardMessages.getFormattedString("ContainerPage.warning.NotOnClassPath", str)); //$NON-NLS-1$ } if (fCurrRoot.isArchive()) { status.setError(NewWizardMessages.getFormattedString("ContainerPage.error.ContainerIsBinary", str)); //$NON-NLS-1$ return status; } } return status; } else { status.setError(NewWizardMessages.getFormattedString("ContainerPage.error.NotAFolder", str)); //$NON-NLS-1$ return status; } } else { status.setError(NewWizardMessages.getFormattedString("ContainerPage.error.ContainerDoesNotExist", str)); //$NON-NLS-1$ return status; } } // -------- update message ---------------- /** * Called when a field on a page changed. Every sub type is responsible to * call this method when a field on its page has changed. * Subtypes override (extend) the method to add verification when own field has a * dependency to an other field. (for example the class name input must be verified * again, when the package field changes (check for duplicated class names)) * @param fieldName The name of the field that has changed (field id) */ protected void handleFieldChanged(String fieldName) { } // ---- get ---------------- /** * Returns the workspace root. */ public IWorkspaceRoot getWorkspaceRoot() { return fWorkspaceRoot; } /** * Returns the PackageFragmentRoot corresponding to the current input. * @return the PackageFragmentRoot or <code>null</code> if the current * input is not a valid source folder */ public IPackageFragmentRoot getPackageFragmentRoot() { return fCurrRoot; } /** * Returns the text of the container field. */ public String getContainerText() { return fContainerDialogField.getText(); } /** * Sets the current PackageFragmentRoot (model and text field). * @param canBeModified Selects if the container field can be changed by the user */ public void setPackageFragmentRoot(IPackageFragmentRoot root, boolean canBeModified) { fCurrRoot= root; String str= (root == null) ? "" : root.getPath().makeRelative().toString(); //$NON-NLS-1$ fContainerDialogField.setText(str); fContainerDialogField.setEnabled(canBeModified); } // ------------- choose source container dialog private IPackageFragmentRoot chooseSourceContainer(IJavaElement initElement) { Class[] acceptedClasses= new Class[] { IPackageFragmentRoot.class, IJavaProject.class }; ISelectionValidator validator= new TypedElementSelectionValidator(acceptedClasses, false) { public boolean isSelectedValid(Object element) { try { if (element instanceof IJavaProject) { IJavaProject jproject= (IJavaProject)element; IPath path= jproject.getProject().getFullPath(); return (jproject.findPackageFragmentRoot(path) != null); } else if (element instanceof IPackageFragmentRoot) { return (((IPackageFragmentRoot)element).getKind() == IPackageFragmentRoot.K_SOURCE); } return true; } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); // just log, no ui in validation } return false; } }; acceptedClasses= new Class[] { IJavaModel.class, IPackageFragmentRoot.class, IJavaProject.class }; ViewerFilter filter= new TypedViewerFilter(acceptedClasses) { public boolean select(Viewer viewer, Object parent, Object element) { if (element instanceof IPackageFragmentRoot) { try { return (((IPackageFragmentRoot)element).getKind() == IPackageFragmentRoot.K_SOURCE); } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); // just log, no ui in validation return false; } } return super.select(viewer, parent, element); } }; JavaElementContentProvider provider= new JavaElementContentProvider(); ILabelProvider labelProvider= new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT); ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), labelProvider, provider); dialog.setValidator(validator); dialog.setSorter(new JavaElementSorter()); dialog.setTitle(NewWizardMessages.getString("ContainerPage.ChooseSourceContainerDialog.title")); //$NON-NLS-1$ dialog.setMessage(NewWizardMessages.getString("ContainerPage.ChooseSourceContainerDialog.description")); //$NON-NLS-1$ dialog.addFilter(filter); dialog.setInput(JavaCore.create(fWorkspaceRoot)); dialog.setInitialSelection(initElement); if (dialog.open() == dialog.OK) { Object element= dialog.getFirstResult(); if (element instanceof IJavaProject) { IJavaProject jproject= (IJavaProject)element; return jproject.getPackageFragmentRoot(jproject.getProject()); } else if (element instanceof IPackageFragmentRoot) { return (IPackageFragmentRoot)element; } return null; } return null; } }
5,765
Bug 5765 New Class button in empty workspace should be more supportive
User feedback: "Confused how to create my first project" We should be more supportive in the UI for this special case since it is a first time experience with the UI. Therefore when the workbench is empty we should offer to create a new Java project. Minimal solution is to show an info dialog that explains that user should create a project first and offer a button to open the Java project wizard. The same is true for the new package and new interface buttons.
resolved fixed
ed4c009
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-20T14:08:51Z"
"2001-11-10T19:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/NewClassCreationWizardPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards; import java.util.ArrayList; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Composite; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.codemanipulation.IImportsStructure; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.util.SWTUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogFieldGroup; import org.eclipse.jdt.internal.ui.wizards.swt.MGridLayout; public class NewClassCreationWizardPage extends TypePage { private final static String PAGE_NAME= "NewClassCreationWizardPage"; //$NON-NLS-1$ private SelectionButtonDialogFieldGroup fMethodStubsButtons; public NewClassCreationWizardPage(IWorkspaceRoot root) { super(true, PAGE_NAME, root); setTitle(NewWizardMessages.getString("NewClassCreationWizardPage.title")); //$NON-NLS-1$ setDescription(NewWizardMessages.getString("NewClassCreationWizardPage.description")); //$NON-NLS-1$ String[] buttonNames3= new String[] { NewWizardMessages.getString("NewClassCreationWizardPage.methods.main"), NewWizardMessages.getString("NewClassCreationWizardPage.methods.constructors"), //$NON-NLS-1$ //$NON-NLS-2$ NewWizardMessages.getString("NewClassCreationWizardPage.methods.inherited") //$NON-NLS-1$ }; fMethodStubsButtons= new SelectionButtonDialogFieldGroup(SWT.CHECK, buttonNames3, 1); fMethodStubsButtons.setLabelText(NewWizardMessages.getString("NewClassCreationWizardPage.methods.label")); //$NON-NLS-1$ } // -------- Initialization --------- /** * Should be called from the wizard with the input element. */ public void init(IStructuredSelection selection) { IJavaElement jelem= null; if (selection != null && !selection.isEmpty()) { Object selectedElement= selection.getFirstElement(); if (selectedElement instanceof IAdaptable) { IAdaptable adaptable= (IAdaptable) selectedElement; jelem= (IJavaElement) adaptable.getAdapter(IJavaElement.class); if (jelem == null) { IResource resource= (IResource) adaptable.getAdapter(IResource.class); if (resource != null) { IProject proj= resource.getProject(); if (proj != null) { jelem= JavaCore.create(proj); } } } } } if (jelem == null) { jelem= EditorUtility.getActiveEditorJavaInput(); } initContainerPage(jelem); initTypePage(jelem); updateStatus(findMostSevereStatus()); } // ------ validation -------- /** * Finds the most severe error (if there is one) */ private IStatus findMostSevereStatus() { return StatusUtil.getMostSevere(new IStatus[] { fContainerStatus, isEnclosingTypeSelected() ? fEnclosingTypeStatus : fPackageStatus, fTypeNameStatus, fModifierStatus, fSuperClassStatus, fSuperInterfacesStatus }); } /* * @see ContainerPage#handleFieldChanged */ protected void handleFieldChanged(String fieldName) { super.handleFieldChanged(fieldName); updateStatus(findMostSevereStatus()); } // ------ ui -------- /* * @see WizardPage#createControl */ public void createControl(Composite parent) { Composite composite= new Composite(parent, SWT.NONE); int nColumns= 4; MGridLayout layout= new MGridLayout(); layout.minimumWidth= SWTUtil.convertWidthInCharsToPixels(80, composite); layout.numColumns= nColumns; composite.setLayout(layout); createContainerControls(composite, nColumns); createPackageControls(composite, nColumns); createEnclosingTypeControls(composite, nColumns); createSeparator(composite, nColumns); createTypeNameControls(composite, nColumns); createModifierControls(composite, nColumns); // createSeparator(composite, nColumns); createSuperClassControls(composite, nColumns); createSuperInterfacesControls(composite, nColumns); //createSeparator(composite, nColumns); createMethodStubSelectionControls(composite, nColumns); setControl(composite); setFocus(); WorkbenchHelp.setHelp(composite, new DialogPageContextComputer(this, IJavaHelpContextIds.NEW_CLASS_WIZARD_PAGE)); } protected void createMethodStubSelectionControls(Composite composite, int nColumns) { LayoutUtil.setHorizontalSpan(fMethodStubsButtons.getLabelControl(composite), nColumns); DialogField.createEmptySpace(composite); LayoutUtil.setHorizontalSpan(fMethodStubsButtons.getSelectionButtonsGroup(composite), nColumns - 1); } // ---- creation ---------------- /* * @see TypePage#evalMethods */ protected String[] evalMethods(IType type, IImportsStructure imports, IProgressMonitor monitor) throws CoreException { List newMethods= new ArrayList(); boolean doConstr= fMethodStubsButtons.isSelected(1); boolean doInherited= fMethodStubsButtons.isSelected(2); String[] meth= constructInheritedMethods(type, doConstr, doInherited, imports, new SubProgressMonitor(monitor, 1)); for (int i= 0; i < meth.length; i++) { newMethods.add(meth[i]); } if (monitor != null) { monitor.done(); } if (fMethodStubsButtons.isSelected(0)) { String main= "public static void main(String[] args) {}"; //$NON-NLS-1$ newMethods.add(main); } return (String[]) newMethods.toArray(new String[newMethods.size()]); } }
5,765
Bug 5765 New Class button in empty workspace should be more supportive
User feedback: "Confused how to create my first project" We should be more supportive in the UI for this special case since it is a first time experience with the UI. Therefore when the workbench is empty we should offer to create a new Java project. Minimal solution is to show an info dialog that explains that user should create a project first and offer a button to open the Java project wizard. The same is true for the new package and new interface buttons.
resolved fixed
ed4c009
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-20T14:08:51Z"
"2001-11-10T19:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/NewGroup.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.wizard.Wizard; import org.eclipse.ui.actions.NewWizardAction; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.actions.AbstractOpenWizardAction; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.actions.GroupContext; import org.eclipse.jdt.internal.ui.util.JavaModelUtil; public class NewGroup extends ContextMenuGroup { private AbstractOpenWizardAction fNewProjectAction; private AbstractOpenWizardAction fNewPackageAction; private AbstractOpenWizardAction fNewClassAction; private AbstractOpenWizardAction fNewInterfaceAction; private AbstractOpenWizardAction fNewPackageRootAction; private AbstractOpenWizardAction fNewSnippetAction; private NewWizardAction fNewWizardAction; private boolean fActionsCreated; public static final String GROUP_NAME= IContextMenuConstants.GROUP_NEW; public NewGroup() { } private void createActions() { if (fActionsCreated) return; String label= NewWizardMessages.getString("NewGroup.wizards_add_package.label"); //$NON-NLS-1$ Class[] acceptedTypes= new Class[] { IJavaProject.class, IPackageFragmentRoot.class }; fNewPackageAction= new OpenPackageWizardAction(label, acceptedTypes); fNewPackageAction.setImageDescriptor(JavaPluginImages.DESC_TOOL_NEWPACKAGE); fNewPackageAction.setToolTipText(NewWizardMessages.getString("NewGroup.wizards_add_package.tooltip")); //$NON-NLS-1$ fNewPackageAction.setDescription(NewWizardMessages.getString("NewGroup.wizards_add_package.description")); //$NON-NLS-1$ label= NewWizardMessages.getString("NewGroup.wizards_add_class.label"); //$NON-NLS-1$ acceptedTypes= new Class[] { IJavaProject.class, IPackageFragmentRoot.class, IPackageFragment.class, ICompilationUnit.class, IClassFile.class }; fNewClassAction= new OpenClassWizardAction(label, acceptedTypes); fNewClassAction.setImageDescriptor(JavaPluginImages.DESC_TOOL_NEWCLASS); fNewClassAction.setToolTipText(NewWizardMessages.getString("NewGroup.wizards_add_class.tooltip")); //$NON-NLS-1$ fNewClassAction.setDescription(NewWizardMessages.getString("NewGroup.wizards_add_class.description")); //$NON-NLS-1$ label= NewWizardMessages.getString("NewGroup.wizards_add_interface.label"); //$NON-NLS-1$ fNewInterfaceAction= new OpenInterfaceWizardAction(label, acceptedTypes); fNewInterfaceAction.setImageDescriptor(JavaPluginImages.DESC_TOOL_NEWINTERFACE); fNewInterfaceAction.setToolTipText(NewWizardMessages.getString("NewGroup.wizards_add_interface.tooltip")); //$NON-NLS-1$ fNewInterfaceAction.setDescription(NewWizardMessages.getString("NewGroup.wizards_add_interface.description")); //$NON-NLS-1$ acceptedTypes= new Class[] { IJavaProject.class }; label= NewWizardMessages.getString("NewGroup.wizards_add_snippet.label"); //$NON-NLS-1$ fNewSnippetAction= new OpenSnippetWizardAction(label, acceptedTypes); fNewSnippetAction.setImageDescriptor(JavaPluginImages.DESC_TOOL_NEWSNIPPET); fNewSnippetAction.setToolTipText(NewWizardMessages.getString("NewGroup.wizards_add_snippet.tooltip")); //$NON-NLS-1$ fNewSnippetAction.setDescription(NewWizardMessages.getString("NewGroup.wizards_add_snippet.description")); //$NON-NLS-1$ label= NewWizardMessages.getString("NewGroup.wizards_add_packageroot.label"); //$NON-NLS-1$ acceptedTypes= new Class[] { IJavaProject.class }; fNewPackageRootAction= new AbstractOpenWizardAction(label, acceptedTypes, false) { protected Wizard createWizard() { return new NewSourceFolderCreationWizard(); } protected boolean shouldAcceptElement(Object obj) { return !isOnBuildPath(obj); } }; fNewPackageRootAction.setImageDescriptor(JavaPluginImages.DESC_TOOL_NEWPACKROOT); fNewPackageRootAction.setToolTipText(NewWizardMessages.getString("NewGroup.wizards_add_packageroot.tooltip")); //$NON-NLS-1$ fNewPackageRootAction.setDescription(NewWizardMessages.getString("NewGroup.wizards_add_packageroot.description")); //$NON-NLS-1$ label= NewWizardMessages.getString("NewGroup.wizards_add_project.label"); //$NON-NLS-1$ acceptedTypes= new Class[] { IJavaModel.class }; fNewProjectAction= new OpenProjectWizardAction(label, acceptedTypes); fNewProjectAction.setImageDescriptor(JavaPluginImages.DESC_TOOL_NEWPROJECT); fNewProjectAction.setToolTipText(NewWizardMessages.getString("NewGroup.wizards_add_project.tooltip")); //$NON-NLS-1$ fNewProjectAction.setDescription(NewWizardMessages.getString("NewGroup.wizards_add_project.description")); //$NON-NLS-1$ fNewWizardAction= new NewWizardAction(); fActionsCreated= true; } static boolean isOnBuildPath(Object obj) { try { if (obj instanceof IJavaElement) { IJavaElement elem= (IJavaElement)obj; return JavaModelUtil.isOnBuildPath(elem.getJavaProject(), elem); } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } return false; } static boolean isInArchive(Object obj) { if (obj instanceof IJavaElement) { IPackageFragmentRoot root= JavaModelUtil.getPackageFragmentRoot((IJavaElement)obj); return (root != null) && root.isArchive(); } return false; } /** * fill the context menu with new-wizard actions */ public void fill(IMenuManager menu, GroupContext context) { createActions(); int i= 0; MenuManager manager= new MenuManager(NewWizardMessages.getString("NewGroup.wizards_add")); //$NON-NLS-1$ if (fNewProjectAction.canActionBeAdded()) { manager.add(fNewProjectAction); i++; } if (fNewPackageRootAction.canActionBeAdded()) { manager.add(fNewPackageRootAction); i++; } if (fNewPackageAction.canActionBeAdded()) { manager.add(fNewPackageAction); i++; } if (fNewClassAction.canActionBeAdded()) { manager.add(fNewClassAction); i++; } if (fNewInterfaceAction.canActionBeAdded()) { manager.add(fNewInterfaceAction); i++; } if (fNewSnippetAction.canActionBeAdded()) { manager.add(fNewSnippetAction); i++; } boolean added= i != 0; if (added) { manager.add(new Separator()); manager.add(fNewWizardAction); } else manager.add(fNewWizardAction); menu.appendToGroup(GROUP_NAME, manager); } public String getGroupName() { return GROUP_NAME; } }
5,765
Bug 5765 New Class button in empty workspace should be more supportive
User feedback: "Confused how to create my first project" We should be more supportive in the UI for this special case since it is a first time experience with the UI. Therefore when the workbench is empty we should offer to create a new Java project. Minimal solution is to show an info dialog that explains that user should create a project first and offer a button to open the Java project wizard. The same is true for the new package and new interface buttons.
resolved fixed
ed4c009
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2001-11-20T14:08:51Z"
"2001-11-10T19:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/NewInterfaceCreationWizardPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Composite; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IStatus; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.dialogs.StatusUtil; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.util.SWTUtil; import org.eclipse.jdt.internal.ui.wizards.swt.MGridLayout; public class NewInterfaceCreationWizardPage extends TypePage { private final static String PAGE_NAME= "NewInterfaceCreationWizardPage"; //$NON-NLS-1$ public NewInterfaceCreationWizardPage(IWorkspaceRoot root) { super(false, PAGE_NAME, root); setTitle(NewWizardMessages.getString("NewInterfaceCreationWizardPage.title")); //$NON-NLS-1$ setDescription(NewWizardMessages.getString("NewInterfaceCreationWizardPage.description")); //$NON-NLS-1$ } // -------- Initialization --------- /** * Should be called from the wizard with the input element. */ public void init(IStructuredSelection selection) { IJavaElement jelem= null; if (selection != null && !selection.isEmpty()) { Object selectedElement= selection.getFirstElement(); if (selectedElement instanceof IAdaptable) { IAdaptable adaptable= (IAdaptable) selectedElement; jelem= (IJavaElement) adaptable.getAdapter(IJavaElement.class); if (jelem == null) { IResource resource= (IResource) adaptable.getAdapter(IResource.class); if (resource != null) { IProject proj= resource.getProject(); if (proj != null) { jelem= JavaCore.create(proj); } } } } } if (jelem == null) { jelem= EditorUtility.getActiveEditorJavaInput(); } initContainerPage(jelem); initTypePage(jelem); updateStatus(findMostSevereStatus()); } // ------ validation -------- /** * Finds the most severe error (if there is one) */ private IStatus findMostSevereStatus() { return StatusUtil.getMostSevere(new IStatus[] { fContainerStatus, isEnclosingTypeSelected() ? fEnclosingTypeStatus : fPackageStatus, fTypeNameStatus, fModifierStatus, fSuperInterfacesStatus }); } /** * @see ContainerPage#handleFieldChanged */ protected void handleFieldChanged(String fieldName) { super.handleFieldChanged(fieldName); updateStatus(findMostSevereStatus()); } // ------ ui -------- /** * @see WizardPage#createControl */ public void createControl(Composite parent) { Composite composite= new Composite(parent, SWT.NONE); int nColumns= 4; MGridLayout layout= new MGridLayout(); layout.minimumWidth= SWTUtil.convertWidthInCharsToPixels(80, composite); layout.numColumns= nColumns; composite.setLayout(layout); createContainerControls(composite, nColumns); createPackageControls(composite, nColumns); createEnclosingTypeControls(composite, nColumns); createSeparator(composite, nColumns); createTypeNameControls(composite, nColumns); createModifierControls(composite, nColumns); // createSeparator(composite, nColumns); createSuperInterfacesControls(composite, nColumns); setControl(composite); setFocus(); WorkbenchHelp.setHelp(composite, new DialogPageContextComputer(this, IJavaHelpContextIds.NEW_INTERFACE_WIZARD_PAGE)); } }