Answers.Body: <p>It sounds like you've identified a bug &mdash; <em>and</em> found a fix. Excellent! </p>
  
  <p>I can confirm this bug by observing the fatal error message displaying a funky character before "Sorry" as shown below. </p>
  
  <p><a href="https://i.sstatic.net/wt9ri.png" rel="nofollow noreferrer"><img src="https://i.sstatic.net/wt9ri.png" alt="fatal error"></a></p>
  
  <p>Here are some next steps that I'd recommend for you here:</p>
  
  <ol>
  <li>Report the bug in CiviCRM's issue-tracker, <a href="https://issues.civicrm.org/jira" rel="nofollow noreferrer">Jira</a>. If you're new to reporting issues, read over these <a href="https://docs.civicrm.org/dev/en/latest/tools/issue-tracking/#guidelines" rel="nofollow noreferrer">issue-reporting guidelines in our Developer Guide</a>.</li>
  <li>After reporting the bug, you can choose to stop there and wait for someone else to fix it. <em>But</em>, given that this issue has a relatively minor impact, developers will be unlikely to volunteer their time on it unless you offer <em>funding</em> to the <a href="https://civicrm.org/paid-issue-queue" rel="nofollow noreferrer">Core Team</a> or to an independent <a href="https://civicrm.org/partners-contributors" rel="nofollow noreferrer">expert</a>.</li>
  <li><p>Since you've already dug into the code yourself, I'd encourage you to work on <a href="https://docs.civicrm.org/dev/en/latest/core/contributing/" rel="nofollow noreferrer">contributing a fix</a>. Here are some tips: </p>
  
  <ul>
  <li>Use <code>git blame</code> (possibly via GitHub's <a href="https://github.com/civicrm/civicrm-core/blame/master/templates/CRM/common/fatal.tpl#L49" rel="nofollow noreferrer">web-based git blame</a>) on that line of code to see if there are recent commits which are relevant to the issue. Ah ha! In this case we can see that  someone recently made a change to <a href="https://github.com/civicrm/civicrm-core/commit/bc8360e14fc2b8a0da7c64895ece45ba53378755" rel="nofollow noreferrer">"use class crm-i instead of fa"</a>.</li>
  <li><p>It would be prudent to look deeper into that commit to try and understand it. I haven't gone too deep, but I did notice that the commit also changed the warning at the top of the "Option Groups" page (<code>/civicrm/admin/options?reset=1</code>), and that message seems to be displaying okay right now: </p>
  
  <p><a href="https://i.sstatic.net/1ScFH.png" rel="nofollow noreferrer"><img src="https://i.sstatic.net/1ScFH.png" alt="warning"></a></p></li>
  <li><p>From the above, I'd recommend considering whether your fix should be limited only to the fatal error page (which might be behaving differently than other pages due to different CSS being included in it)</p></li>
  <li>If you're stuck or want input from other developers, hop on <a href="https://chat.civicrm.org" rel="nofollow noreferrer">Mattermost</a>.</li>
  </ul></li>
  </ol>
  
  <p>All-in-all, this answer is just intended to be a push in the right direction towards using other tools (i.e. Jira, GitHub, and Mattermost instead of StackExchange) for reporting (and hopefully fixing) this bug. In some ways you're lucky to have found a bug which will (probably) be super easy to fix! Fixing this bug would be a great stepping stone towards improving CiviCRM in bigger ways too!</p>
  
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2017-09-03T01:15:59.877Z
Answers.Text: After digging a little deeper, I see that you are exactly right about an extra css being needed in the fatal error template.  Thank you for showing the way.
  
  To fix the problem the correct way, insert this line:
  
      `@import url(/sites/all/modules/civicrm/css/crm-i.css);`
      
  between lines 36 and 37 in templates/CRM/common/fatal.tpl.
  
  Use of class=fa is deprecated.  I will create an account on the issue tracker and file a bug report.
Answers.UserDisplayName: charlie
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2017-09-04T03:46:54.000Z
Answers.Text: Thanks for filing https://issues.civicrm.org/jira/browse/CRM-21139 - I've submitted a PR to fix it.
Answers.UserDisplayName: Coleman
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2017-09-02T00:26:42.800Z
Answers.LastActivityDate: 2017-09-02T01:24:21.027Z
Answers.LastEditDate: 2017-09-02T01:24:21.027Z
Answers.UserDisplayName: Sean
Answers.Body: <p>Sean provided an excellent answer for dealing with the bug on the fatal error page.</p>
  
  <p>Here, I'm just addressing the question of why the <code>fa</code> class is missing.  You noticed that none of CiviCRM's icons have it.</p>
  
  <p>CiviCRM is different from many systems because it's subject to a wide variety of CMS themes and settings where it's installed.  When we went to set up Font Awesome, the icon library used in 4.7, Coleman and I were concerned that there could be a clash between CiviCRM's implementation of Font Awesome and one potentially used by the CMS.</p>
  
  <p>For example, Font Awesome 5 is coming soon, advertising all new icons.  While I'd hope that the characters used for each icon would be the same in the new font, there's no guarantee that they would be: the class name is intended to be the identifier.  If CiviCRM expected Font Awesome 4 and the CMS used 5, or vice-versa, using the <code>fa</code> class could yield inconsitent results.  We chose to use <code>crm-i</code> instead.</p>
  
  <p>The separate class also gives us more flexibility on custom icons.  We can create new icons and tie them to the <code>crm-i</code> class along with a specific icon name class, and they'll be treated the same as our off-the-shelf icons.  If later versions of Font Awesome include an icon with the same name, we can safely continue as-is without messing up parts of the CMS thst might use that new icon.</p>
  
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2017-09-07T11:40:46.593Z
Answers.LastActivityDate: 2017-09-07T11:40:46.593Z
Answers.UserDisplayName: Andie Hunt
Body: <p>The Font-Awesome icons are not showing properly.  I believe this is because the required class "fa" is missing everywhere where one of the icons is supposed to display.  I have tested this by modifying templates/CRM/common/fatal.tpl, adding "fa" in the appropriate place in line 49.  Without the fa class the browser shows a blob character; with the fa class the correct icon shows as desired.  Quite a number of templates are affected (assuming I am correct).</p>
  
  <p>I'm running CiviCRM 4.7.23 (with no local customization) on Drupal 7.56.</p>
  
Tags: <4.7>
Title: Font-Awesome icons not showing -- missing class=fa?
ThreadText: # Font-Awesome icons not showing -- missing class=fa?
  
  (Asked by: username_0 on 2017-09-01)
  
  The Font-Awesome icons are not showing properly. I believe this is because the required class "fa" is missing everywhere where one of the icons is supposed to display. I have tested this by modifying templates/CRM/common/fatal.tpl, adding "fa" in the appropriate place in line 49. Without the fa class the browser shows a blob character; with the fa class the correct icon shows as desired. Quite a number of templates are affected (assuming I am correct).
  
  I'm running CiviCRM 4.7.23 (with no local customization) on Drupal 7.56.
  
  **Tags:** 4.7
  
  
  ---
  
  ## 2 answers
  
  ### Answer by username_1 on 2017-09-02. Score: 3
  
  It sounds like you've identified a bug — *and* found a fix. Excellent!
  
  I can confirm this bug by observing the fatal error message displaying a funky character before "Sorry" as shown below.
  
  [![fatal error](https://i.sstatic.net/wt9ri.png)](https://i.sstatic.net/wt9ri.png)
  
  Here are some next steps that I'd recommend for you here:
  
  1. Report the bug in CiviCRM's issue-tracker, [Jira](https://issues.civicrm.org/jira). If you're new to reporting issues, read over these [issue-reporting guidelines in our Developer Guide](https://docs.civicrm.org/dev/en/latest/tools/issue-tracking/#guidelines).
  2. After reporting the bug, you can choose to stop there and wait for someone else to fix it. *But*, given that this issue has a relatively minor impact, developers will be unlikely to volunteer their time on it unless you offer *funding* to the [Core Team](https://civicrm.org/paid-issue-queue) or to an independent [expert](https://civicrm.org/partners-contributors).
  3. Since you've already dug into the code yourself, I'd encourage you to work on [contributing a fix](https://docs.civicrm.org/dev/en/latest/core/contributing/). Here are some tips:
  
     * Use `git blame` (possibly via GitHub's [web-based git blame](https://github.com/civicrm/civicrm-core/blame/master/templates/CRM/common/fatal.tpl#L49)) on that line of code to see if there are recent commits which are relevant to the issue. Ah ha! In this case we can see that someone recently made a change to ["use class crm-i instead of fa"](https://github.com/civicrm/civicrm-core/commit/bc8360e14fc2b8a0da7c64895ece45ba53378755).
     * It would be prudent to look deeper into that commit to try and understand it. I haven't gone too deep, but I did notice that the commit also changed the warning at the top of the "Option Groups" page (`/civicrm/admin/options?reset=1`), and that message seems to be displaying okay right now:
  
       [![warning](https://i.sstatic.net/1ScFH.png)](https://i.sstatic.net/1ScFH.png)
     * From the above, I'd recommend considering whether your fix should be limited only to the fatal error page (which might be behaving differently than other pages due to different CSS being included in it)
     * If you're stuck or want input from other developers, hop on [Mattermost](https://chat.civicrm.org).
  
  All-in-all, this answer is just intended to be a push in the right direction towards using other tools (i.e. Jira, GitHub, and Mattermost instead of StackExchange) for reporting (and hopefully fixing) this bug. In some ways you're lucky to have found a bug which will (probably) be super easy to fix! Fixing this bug would be a great stepping stone towards improving CiviCRM in bigger ways too!
  
  > **Comments:**
  > **username_0**: After digging a little deeper, I see that you are exactly right about an extra css being needed in the fatal error template.  Thank you for showing the way.  To fix the problem the correct way, insert this line:      `@import url(/sites/all/modules/civicrm/css/crm-i.css);`      between lines 36 and 37 in templates/CRM/common/fatal.tpl.  Use of class=fa is deprecated.  I will create an account on the issue tracker and file a bug report.  
  > **username_2**: Thanks for filing https://issues.civicrm.org/jira/browse/CRM-21139 - I've submitted a PR to fix it.  
  
  ---
  
  ### Answer by username_3 on 2017-09-07. Score: 1
  
  username_1 provided an excellent answer for dealing with the bug on the fatal error page.
  
  Here, I'm just addressing the question of why the `fa` class is missing. You noticed that none of CiviCRM's icons have it.
  
  CiviCRM is different from many systems because it's subject to a wide variety of CMS themes and settings where it's installed. When we went to set up Font Awesome, the icon library used in 4.7, username_2 and I were concerned that there could be a clash between CiviCRM's implementation of Font Awesome and one potentially used by the CMS.
  
  For example, Font Awesome 5 is coming soon, advertising all new icons. While I'd hope that the characters used for each icon would be the same in the new font, there's no guarantee that they would be: the class name is intended to be the identifier. If CiviCRM expected Font Awesome 4 and the CMS used 5, or vice-versa, using the `fa` class could yield inconsitent results. We chose to use `crm-i` instead.
  
  The separate class also gives us more flexibility on custom icons. We can create new icons and tie them to the `crm-i` class along with a specific icon name class, and they'll be treated the same as our off-the-shelf icons. If later versions of Font Awesome include an icon with the same name, we can safely continue as-is without messing up parts of the CMS thst might use that new icon.
  
  
  ---
  
  