Answers.Body: <p>I posted this to gitlab here <a href="https://lab.civicrm.org/dev/core/issues/250" rel="nofollow noreferrer">https://lab.civicrm.org/dev/core/issues/250</a> and the issue turned out to be related to odd records in my database. </p>
  
  <p>this query, from Elieen exposed the bad row</p>
  
  <pre><code>SELECT p.id, p.name, p.class_name, p.is_active, pt.id, pt.class_name, pt.name
  FROM civicrm_payment_processor p
  LEFT JOIN civicrm_payment_processor_type pt ON pt.id = p.payment_processor_type_id
  +----+--------------------+----------------------+-----------+------+----------------------+---------+
  | id | name               | class_name           | is_active | id   | class_name           | name    |
  +----+--------------------+----------------------+-----------+------+----------------------+---------+
  |  1 | Dummy Processor    | Payment_PayPalImpl   |         1 |   10 | Payment_Dummy        | Dummy   |
  |  2 | Dummy Processor    | Payment_Dummy        |         1 |   10 | Payment_Dummy        | Dummy   |
  </code></pre>
  
  <p>so I updated the row in civicrm_payment_processor to change Payment_PayPalImpl to Payment_Dummy and everything works without the modification to civi code. </p>
  
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2018-08-10T02:03:01.573Z
Answers.LastActivityDate: 2018-08-10T02:03:01.573Z
Answers.UserDisplayName: ericG
Answers.Body: <p>I have had the same message after updating from 5.2.1 to 5.3.2. I have 2 sites, neither have any contributions configured, either thru paypal or anyone else. Both sites were upgraded. The other is working fine but this one cannot get into civi from drupal entry.</p>
  
  <p>Civi\Payment\Exception\PaymentProcessorException: CRM_Core_Payment_PayPalImpl: Payment processor type is not defined! in CRM_Core_Payment_PayPalImpl->__construct() (line 73 of /mysite/public_html/drupal/sites/all/modules/civicrm/CRM/Core/Payment/PayPalImpl.php).</p>
  
  <p>I took the advice of editing out line 73 and all is good.</p>
  
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2018-08-11T09:34:47.237Z
Answers.Text: @ericg's [solution to correct the entries in DB table `civicrm_payment_processor`](https://civicrm.stackexchange.com/a/26081/149) looks like the right answer, please try that instead?
Answers.UserDisplayName: Chris Burgess
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2018-08-09T23:44:43.617Z
Answers.LastActivityDate: 2018-08-10T00:34:01.247Z
Answers.LastEditDate: 2018-08-10T00:34:01.247Z
Answers.UserDisplayName: Hock
Body: <p>upon upgrade from 4.7.31 to 5.3 the site could not load any civi pages, it would give a generic error message. </p>
  
  <p>in the log I see:</p>
  
  <p>Civi\Payment\Exception\PaymentProcessorException: CRM_Core_Payment_PayPalImpl: Payment processor type is not defined! in CRM_Core_Payment_PayPalImpl->__construct() (line 73 of /var/www/xxxxxx/sites/all/modules/civicrm/CRM/Core/Payment/PayPalImpl.php).</p>
  
  <p>but this site does not use paypal, it uses authorizenet so I have no idea why this is causing a fatal error</p>
  
  <p>my temp workaround was to just comment out line 73 of PayPalImpl.php but I'll need to verify that payments still work. Anyone else have a similar issue with 5.3?</p>
  
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-09T19:53:42.187Z
Comments.Text: I've confirmed that authorizenet payments work fine with this line commented out; I'll see if I can dig deeper into this bug later, please post a comment if you've hit this same issue so I know if this is a real bug or just my server
Comments.UserDisplayName: ericG
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-10T09:37:18.783Z
Comments.Text: Please create an issue for this on https://lab.civicrm.org/dev/core/issues
Comments.UserDisplayName: Aidan
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-10T09:44:12.663Z
Comments.Text: @ericG I would be checking to see what is going on in the `isPayPalType` function as that is returning FALSE which is causing the error to be thrown as per https://github.com/civicrm/civicrm-core/commit/8acddb67077a09d8ca05e0bc367d2e9598cd8c91#diff-96a0ea19e8ac102ef100c35b3b3d1c31
Comments.UserDisplayName: Seamus Lee
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-10T13:02:21.157Z
Comments.Text: what rows do you have in civicrm_payment_processor table?
Comments.UserDisplayName: user4278
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-10T14:27:16.817Z
Comments.Text: At a guess, I would say that you have probably got some paypal contributions but don't have a paypal processor configured?
Comments.UserDisplayName: Matthew Wire
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-10T15:11:06.850Z
Comments.Text: all rows in the payment_processor_table and payment_processor_table_type are either the default/dummy or authorizenet. 
  no payments, to my knowledge, have ever been taken via paypal
Comments.UserDisplayName: ericG
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-10T23:10:08.187Z
Comments.Text: I think this is something specific to this one site, I have upgraded a few other clients today that also do not use paypal and can't replicate this error on those sites
Comments.UserDisplayName: ericG
Tags: <upgrade><payment-processor>
Title: error on upgrade to 5.3
ThreadText: # error on upgrade to 5.3
  
  (Asked by: username_0 on 2018-07-09)
  
  upon upgrade from 4.7.31 to 5.3 the site could not load any civi pages, it would give a generic error message.
  
  in the log I see:
  
  Civi\Payment\Exception\PaymentProcessorException: CRM\_Core\_Payment\_PayPalImpl: Payment processor type is not defined! in CRM\_Core\_Payment\_PayPalImpl->\_\_construct() (line 73 of /var/www/xxxxxx/sites/all/modules/civicrm/CRM/Core/Payment/PayPalImpl.php).
  
  but this site does not use paypal, it uses authorizenet so I have no idea why this is causing a fatal error
  
  my temp workaround was to just comment out line 73 of PayPalImpl.php but I'll need to verify that payments still work. Anyone else have a similar issue with 5.3?
  
  **Tags:** upgrade, payment-processor
  
  > **Comments:**
  > **username_0**: I've confirmed that authorizenet payments work fine with this line commented out; I'll see if I can dig deeper into this bug later, please post a comment if you've hit this same issue so I know if this is a real bug or just my server  
  > **username_1**: Please create an issue for this on https://lab.civicrm.org/dev/core/issues  
  > **username_2**: @username_0 I would be checking to see what is going on in the `isPayPalType` function as that is returning FALSE which is causing the error to be thrown as per https://github.com/civicrm/civicrm-core/commit/8acddb67077a09d8ca05e0bc367d2e9598cd8c91#diff-96a0ea19e8ac102ef100c35b3b3d1c31  
  > **username_3**: what rows do you have in civicrm_payment_processor table?  
  > **username_4**: At a guess, I would say that you have probably got some paypal contributions but don't have a paypal processor configured?  
  > **username_0**: all rows in the payment_processor_table and payment_processor_table_type are either the default/dummy or authorizenet.  no payments, to my knowledge, have ever been taken via paypal  
  > **username_0**: I think this is something specific to this one site, I have upgraded a few other clients today that also do not use paypal and can't replicate this error on those sites  
  
  ---
  
  ## 2 answers
  
  ### Answer by username_0 on 2018-08-10. Score: 1
  
  I posted this to gitlab here <https://lab.civicrm.org/dev/core/issues/250> and the issue turned out to be related to odd records in my database.
  
  this query, from Elieen exposed the bad row
  
  ```
  SELECT p.id, p.name, p.class_name, p.is_active, pt.id, pt.class_name, pt.name
  FROM civicrm_payment_processor p
  LEFT JOIN civicrm_payment_processor_type pt ON pt.id = p.payment_processor_type_id
  +----+--------------------+----------------------+-----------+------+----------------------+---------+
  | id | name               | class_name           | is_active | id   | class_name           | name    |
  +----+--------------------+----------------------+-----------+------+----------------------+---------+
  |  1 | Dummy Processor    | Payment_PayPalImpl   |         1 |   10 | Payment_Dummy        | Dummy   |
  |  2 | Dummy Processor    | Payment_Dummy        |         1 |   10 | Payment_Dummy        | Dummy   |
  
  ```
  
  so I updated the row in civicrm\_payment\_processor to change Payment\_PayPalImpl to Payment\_Dummy and everything works without the modification to civi code.
  
  
  ---
  
  ### Answer by username_5 on 2018-08-09. Score: 0
  
  I have had the same message after updating from 5.2.1 to 5.3.2. I have 2 sites, neither have any contributions configured, either thru paypal or anyone else. Both sites were upgraded. The other is working fine but this one cannot get into civi from drupal entry.
  
  Civi\Payment\Exception\PaymentProcessorException: CRM\_Core\_Payment\_PayPalImpl: Payment processor type is not defined! in CRM\_Core\_Payment\_PayPalImpl->\_\_construct() (line 73 of /mysite/public\_html/drupal/sites/all/modules/civicrm/CRM/Core/Payment/PayPalImpl.php).
  
  I took the advice of editing out line 73 and all is good.
  
  > **Comments:**
  > **username_6**: @username_0's [solution to correct the entries in DB table `civicrm_payment_processor`](https://civicrm.stackexchange.com/a/26081/149) looks like the right answer, please try that instead?  
  
  ---
  
  