<p>According to the bitcoin.it wiki, as Stephen Gornick linked to in a comment, this should be the code review process:</p>

<blockquote>
  <p>Pull requests are discussed on the forums and if there is consensus they're safe, tested, useful, well written, match coding style, etc. then they're merged into the 'master' branch.</p>
</blockquote>

<p>Assuming the bitcointalk.org forums, I can't really find any pull request discussion. On Github it seems pull requests do get discussed though, for example: <a href="https://github.com/bitcoin/bitcoin/pull/1795" rel="nofollow">Bloom filter pull request</a>.</p>

CC BY-SA 3.0
2012-11-17T18:36:28.457Z
2012-11-17T18:36:28.457Z
Luc
<p>There are n developers with commit privileged.</p>

<p>After one of them merges a pull request, how many eyes review that code? When? Is a complete (holistic) code review done before releasing a version? Does every line gets reviewed by at least one other person?</p>

CC BY-SA 3.0
2012-08-02T01:26:24.197Z
Support documents: http://en.bitcoin.it/wiki/Release_process
 http://en.bitcoin.it/wiki/Development_process
Stephen Gornick
<bitcoin-core>
What is the formal code review process of the standard client?
ripper234
# What is the formal code review process of the standard client?

(Asked by: username_0 on 2012-08-02)

There are n developers with commit privileged.

After one of them merges a pull request, how many eyes review that code? When? Is a complete (holistic) code review done before releasing a version? Does every line gets reviewed by at least one other person?

**Tags:** bitcoin-core

> **Comments:**
> **username_1**: Support documents: http://en.bitcoin.it/wiki/Release_process  http://en.bitcoin.it/wiki/Development_process  

---

## 1 answers

### Answer by username_2 on 2012-11-17. Score: 2

According to the bitcoin.it wiki, as username_1 linked to in a comment, this should be the code review process:

> Pull requests are discussed on the forums and if there is consensus they're safe, tested, useful, well written, match coding style, etc. then they're merged into the 'master' branch.

Assuming the bitcointalk.org forums, I can't really find any pull request discussion. On Github it seems pull requests do get discussed though, for example: [Bloom filter pull request](https://github.com/bitcoin/bitcoin/pull/1795).


---

