On Thu, Dec 01, 2016 at 09:58:10AM +0000, Stephen Finucane wrote: >. > > Sorry for missing this - I can't run 'make distcheck' on my machine as > it throws obscure "Permission denied" errors that I haven't been able > to suss out yet.
Advertising
This particular error comes from plain "make", not "make check" or "make distcheck". It's emitted by this chunk of Makefile.am. You don't see it? Maybe the code in the makefile needs some improvement. # If we're checked out from a Git repository, make sure that every # file that is in Git is distributed. # # We only enable this check when GNU make is in use because the # Makefile in datapath/linux, needed to get the list of files to # distribute, requires GNU make extensions. if GNU_MAKE ALL_LOCAL += dist-hook-git dist-hook-git: distfiles @if test -e $(srcdir)/.git && (git --version) >/dev/null 2>&1; then \ (cd datapath && $(MAKE) distfiles); \ (cat distfiles; sed 's|^|datapath/|' datapath/distfiles) | \ LC_ALL=C sort -u > all-distfiles; \ (cd $(srcdir) && git ls-files) | grep -v '\.gitignore$$' | \ LC_ALL=C sort -u > all-gitfiles; \ LC_ALL=C comm -1 -3 all-distfiles all-gitfiles > missing-distfiles; \ if test -s missing-distfiles; then \ echo "The following files are in git but not the distribution:"; \ cat missing-distfiles; \ exit 1; \ fi; \ fi CLEANFILES += all-distfiles all-gitfiles missing-distfiles # The following is based on commands for the Automake "distdir" target. distfiles: Makefile @srcdirstrip=`echo "$(srcdir)" | sed 's/[].[^$$\\*]/\\\\&/g'`; \ topsrcdirstrip=`echo "$(top_srcdir)" | sed 's/[].[^$$\\*]/\\\\&/g'`; \ list='$(DISTFILES)'; \ for file in $$list; do echo $$file; done | \ sed -e "s|^$$srcdirstrip/||;t" \ -e "s|^$$topsrcdirstrip/|$(top_builddir)/|;t" | \ LC_ALL=C sort -u > $@ CLEANFILES += distfiles endif .PHONY: dist-hook-git > Out of curiosity though, why did 'AUTHORS' (sans 'rst' suffix) not > need to be tracked? Some form of Autotools magic? Automake always distributes AUTHORS because the GNU standards say that it should exist. _______________________________________________ dev mailing list d...@openvswitch.org