
Yes. Overrides is what has been fixed in 2.1.4
Likely the behavior needs to be configurable, so that both 2.1.3 and 2.1.4 behaviors should be supported somehow.
Oleg Nenashev you mean that not being able to override a global env is the intended behavior?
Btw the issue does not limits to overriding variable, it is the main feature of injecting a new variable in the build process that fails for me
At least I verified with a few println() that the code is still executed, but anything placed in the hashmap is not saved properly
def map... if (!binding.variables.containsKey('VAR1') || binding.variables.get('VAR1').equals("")) { map['VAR1'] = TOTO; } return map;
2.1.3 => VAR1=TOTO if VAR1 is undefined (expected)
2.1.4 => VAR1=null if VAR1 is undefined (not expected)
Created warning on Wiki:
Probably I should depublish the release for now
Yeah, I was looking for a way to lock the plugin to 2.1.3 and not being notified of newest updates of one plugin I guess it is not possible ? We use to update Jenkins always but have been forced to close connection to Jenkins update servers to not get the regression update. The downgrade button is nice with the plugin but I believe it misses a button like "Shutdown update notifications" per plugins
Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
Log:
Add compatibility notice for
JENKINS-47364 and JENKINS-47370
Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
Log:
Merge pull request #127 from oleg-nenashev/2.1.4-compat-notice
Add compatibility notice for
JENKINS-47364 and JENKINS-47370
Compare:
If you are not going to touch this issue anymore this is serious problem here, as administrator It's impossible to communicate to the team the DO NOT UPDATE EnvInject I have to ban all jenkins domains in the host Linux configuration level to stop Jenkins updates
My suggestion (only if you are not going to improve this fix causing regressions)
- branch the 2.1.3 version to a newer plugin called "Environment Injector Plugin (Old compatibility version)"
So we can stick to this version, because I believe we need Jenkins updates while we dont need EnvInject updates anymore and want it as it is working actually, the fix you published for it was not affecting us.
I am going to make the change, not sure when. I am traveling since mid-October, and unfortunately I had no time to work on it. Everybody is welcome to submit a pull request.
> as administrator It's impossible to communicate to the team the DO NOT UPDATE EnvInjec
If your users are able to install and update plugins, IMHO you have a larger problem than EnvInject. Common users should have no access to plugin management if they ignore warnings in Web UI and changelogs. If you do not see the warning in the Update Manager on your instance, let me know.
> branch the 2.1.3 version to a newer plugin called "Environment Injector Plugin (Old compatibility version)"
It cannot be easily done in such way due to the risk of binary conflicts. Anyway, I am going to improve the configuration and to at least offer the opt-out flag.
This issue sounds very much like JENKINS-14437..
Confirmed here, after reverting to 2.1.3 all the problems gone. 2.1.4 need more testing.