Hi, > > > > -public class CannotRedoException > > > > - extends RuntimeException > > > > +public class CannotRedoException extends RuntimeException > > > > { > > > > > > The old version is according to our formatting rules. The new version is > > > not. > > > > Well, last time I asked about that on IRC I was told (by tromey AFAIR) > > that the new version is correct. > > Don't ask on IRC, read the documentation. ;-) Well, I did, but obviously not good enough. > >From the hacking guide (hacking.texinfo): > > Wrap always before extends, implements, throws, and labels. I havent found this statement, so yeah you are right. > > > > /** > > > > * Constructs a new instance of a <code>CannotRedoException</code>. > > > > */ > > > > public CannotRedoException() > > > > { > > > > + super(); > > > > } > > > > > > You know that this is implicit and not needed. We try to avoid implicit > > > stuff. > > > > Yeah, I had the choice between calling super() and adding a comment. > > Calling super() seemed more natural to me. If it's agreed that super(); > > should be avoided, then I'll replace it with a comment instead. > > I would prefer a comment here. Ok. /Roman
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil