bug in demo code
#2
by
undefined-x
- opened
three bug in demo code
1.
def get_assistant():
inputs = tokenizer.apply_chat_template(
messages,
return_tensors="pt",
add_generation_prompt=True,
return_dict=True,
).to(model.device)
out = model.generate(input_ids=input["input_ids"], **generate_kwargs)
return tokenizer.decode(out[0][inputs["input_ids"].shape[1]:], skip_special_tokens=True).strip()
8th line shoud be out = model.generate(input_ids=inputs["input_ids"], **generate_kwargs) missing s in variable input
missing
import reandimport json... You useremodule andjsonmodule in funcget_func_name_argsshould set "max_new_tokens" in
generate_kwargs, because default prompt length(input+output) is 20 in methodmodel.generate... It's useless in many scenarios. doc ref
Please review the code carefully before releasing the model.....
- three bugs in func
get_observation,
- .
fucntion_nametypo - . none return
- missing
enumeratein 7th line...
the correct func is following
def get_observation(function_name, args):
if function_name == "search":
mock_search_res = [
{"title": "t1", "url":"url1", "snippet": "snippet_content_1"},
{"title": "t2", "url":"url2", "snippet": "snippet_content_2"}
]
content = "\n\n".join([f"【{i}†{res['title']}†{res['url']}\n{res['snippet']}】" for i, res in enumerate(mock_search_res)])
elif function_name == "click":
mock_click_res = "main content"
content = mock_click_res
elif function_name == "open":
mock_open_res = "main_content"
content = mock_open_res
else:
raise ValueError("unspport function name!")
return content
please fix it.
Knowledge Engineering Group (KEG) & Data Mining at Tsinghua University org
•
edited about 18 hours ago
We have changed the code. Thank you for your support.