Update main.py

main.py

@@ -16,7 +16,6 @@ from src.detection import YOLOv11Detector
 from src.comparison import DamageComparator
 from src.visualization import DamageVisualizer
 
-
 app = FastAPI(
     title="Car Damage Detection API",
     description="YOLOv11-based car damage detection and comparison system",
@@ -38,12 +37,15 @@ comparator = DamageComparator()
 visualizer = DamageVisualizer()
 
 # Create necessary directories
-Path("uploads").mkdir(exist_ok=True)
-Path("results").mkdir(exist_ok=True)
+UPLOADS_DIR = Path("uploads")
+RESULTS_DIR = Path("results")
+UPLOADS_DIR.mkdir(exist_ok=True)
+RESULTS_DIR.mkdir(exist_ok=True)
 
 # Mount static files directory
 app.mount("/uploads", StaticFiles(directory="uploads"), name="uploads")
 
+
 @app.get("/")
 async def root():
     """Root endpoint"""
@@ -59,23 +61,12 @@ async def root():
     }
 
 
-def save_temp_file(upload_file: UploadFile) -> str:
-    """Save an uploaded file into /tmp and return the temp file path"""
-    tmp_dir = Path("/tmp")
-    tmp_dir.mkdir(exist_ok=True)
-
-    temp_path = tmp_dir / upload_file.filename
-
-    with open(temp_path, "wb") as buffer:
-        shutil.copyfileobj(upload_file.file, buffer)
-    return str(temp_path)
-
-    
 @app.get("/health")
 async def health_check():
     """Health check endpoint"""
     return {"status": "healthy", "model": "YOLOv11"}
 
+
 @app.post("/detect")
 async def detect_single_image(file: UploadFile = File(...)):
     """
@@ -100,11 +91,18 @@ async def detect_single_image(file: UploadFile = File(...)):
         # Create visualization
         visualized = visualizer.draw_detections(image_bgr, detections, 'new_damage')
 
-
+        # Generate unique filename
         filename = f"detection_{datetime.now().strftime('%Y%m%d_%H%M%S')}_{uuid.uuid4().hex[:8]}.jpg"
-        output_path = Path("/tmp") / filename
+
+        # ✅ FIX: Use consistent relative path
+        output_path = UPLOADS_DIR / filename
+
+        # Save visualization image
         cv2.imwrite(str(output_path), visualized)
 
+        # Generate URL for accessing the image
+        image_url = f"http://localhost:8000/uploads/{filename}"
+
         return JSONResponse({
             "status": "success",
             "detections": detections,
@@ -112,28 +110,32 @@ async def detect_single_image(file: UploadFile = File(...)):
                 "total_damages": len(detections['boxes']),
                 "damage_types": list(set(detections['classes']))
             },
-            "visualized_image_path": f"/tmp/{filename}",
+            # ✅ FIX: Correct paths
+            "visualized_image_path": f"uploads/{filename}",
+            "visualized_image_url": image_url,
+            "filename": filename
         })
 
     except Exception as e:
         raise HTTPException(status_code=500, detail=f"Detection failed: {str(e)}")
 
+
 @app.post("/compare")
 async def compare_vehicle_damages(
-    # Before delivery images (6 positions)
-    before_1: UploadFile = File(..., description="Before - Position 1"),
-    before_2: UploadFile = File(..., description="Before - Position 2"),
-    before_3: UploadFile = File(..., description="Before - Position 3"),
-    before_4: UploadFile = File(..., description="Before - Position 4"),
-    before_5: UploadFile = File(..., description="Before - Position 5"),
-    before_6: UploadFile = File(..., description="Before - Position 6"),
-    # After delivery images (6 positions)
-    after_1: UploadFile = File(..., description="After - Position 1"),
-    after_2: UploadFile = File(..., description="After - Position 2"),
-    after_3: UploadFile = File(..., description="After - Position 3"),
-    after_4: UploadFile = File(..., description="After - Position 4"),
-    after_5: UploadFile = File(..., description="After - Position 5"),
-    after_6: UploadFile = File(..., description="After - Position 6"),
+        # Before delivery images (6 positions)
+        before_1: UploadFile = File(..., description="Before - Position 1"),
+        before_2: UploadFile = File(..., description="Before - Position 2"),
+        before_3: UploadFile = File(..., description="Before - Position 3"),
+        before_4: UploadFile = File(..., description="Before - Position 4"),
+        before_5: UploadFile = File(..., description="Before - Position 5"),
+        before_6: UploadFile = File(..., description="Before - Position 6"),
+        # After delivery images (6 positions)
+        after_1: UploadFile = File(..., description="After - Position 1"),
+        after_2: UploadFile = File(..., description="After - Position 2"),
+        after_3: UploadFile = File(..., description="After - Position 3"),
+        after_4: UploadFile = File(..., description="After - Position 4"),
+        after_5: UploadFile = File(..., description="After - Position 5"),
+        after_6: UploadFile = File(..., description="After - Position 6"),
 ):
     """
     Compare vehicle damages before and after delivery
@@ -201,25 +203,34 @@ async def compare_vehicle_damages(
                 comparison
             )
 
-            # Save visualization image with unique filename
-            vis_filename = f"comparison_{timestamp_str}_{session_id}_pos{i+1}.jpg"
-            vis_path = Path("/tmp") / vis_filename
-            cv2.imwrite(str(vis_path), vis_img)
+            # ✅ FIX: Save visualization image with consistent path
+            vis_filename = f"comparison_{timestamp_str}_{session_id}_pos{i + 1}.jpg"
+            vis_path = UPLOADS_DIR / vis_filename  # Use consistent relative path
 
+            # Save the image
+            success = cv2.imwrite(str(vis_path), vis_img)
+            if not success:
+                print(f"⚠️ Warning: Failed to save visualization for position {i + 1}")
+            else:
+                print(f"✅ Saved: {vis_path}")
+
+            # Generate URL for accessing the image
             vis_url = f"http://localhost:8000/uploads/{vis_filename}"
             all_visualizations.append(vis_url)
 
             # Store position result
             position_results.append({
-                f"position_{i+1}": {
+                f"position_{i + 1}": {
                     "case": comparison['case'],
                     "message": comparison['message'],
                     "statistics": comparison['statistics'],
                     "new_damages": comparison['new_damages'],
                     "matched_damages": comparison['matched_damages'],
                     "repaired_damages": comparison['repaired_damages'],
-                    "visualization_path": f"/tmp/{vis_filename}",
-                    "visualization_url": vis_url
+                    # ✅ FIX: Correct paths
+                    "visualization_path": f"uploads/{vis_filename}",
+                    "visualization_url": vis_url,
+                    "filename": vis_filename
                 }
             })
 
@@ -235,13 +246,20 @@ async def compare_vehicle_damages(
             overall_message = "Error from the beginning, not during the delivery process -> Delivery completed"
 
         # Create summary grid visualization
-        grid_results = [res[f"position_{i+1}"] for i, res in enumerate(position_results)]
+        grid_results = [res[f"position_{i + 1}"] for i, res in enumerate(position_results)]
         grid_img = visualizer.create_summary_grid(grid_results, image_pairs)
 
-        # Save grid summary image
+        # ✅ FIX: Save grid summary image with consistent path
         grid_filename = f"summary_grid_{timestamp_str}_{session_id}.jpg"
-        grid_path = Path("uploads") / grid_filename
-        cv2.imwrite(str(grid_path), grid_img)
+        grid_path = UPLOADS_DIR / grid_filename  # Already correct in original
+
+        # Save the grid image
+        grid_success = cv2.imwrite(str(grid_path), grid_img)
+        if not grid_success:
+            print(f"⚠️ Warning: Failed to save grid summary")
+        else:
+            print(f"✅ Saved grid: {grid_path}")
+
         grid_url = f"http://localhost:8000/uploads/{grid_filename}"
 
         # Generate timestamp for tracking
@@ -261,8 +279,10 @@ async def compare_vehicle_damages(
                 }
             },
             "position_results": position_results,
-            "summary_visualization_path": f"/uploads/{grid_filename}",
+            # ✅ FIX: Correct paths
+            "summary_visualization_path": f"uploads/{grid_filename}",
             "summary_visualization_url": grid_url,
+            "all_visualizations": all_visualizations,  # Added for convenience
             "recommendations": {
                 "action_required": total_new_damages > 0,
                 "suggested_action": "Investigate delivery process" if total_new_damages > 0 else "Proceed with delivery completion"