Removed JS (#20)

- Removed JS (6d5a5902a790fb59f1f57ec6ee7e668ad6fe2995)


Co-authored-by: Kai <[email protected]>

app.py

@@ -3,7 +3,8 @@ import random
 import pandas as pd
 import os
 import threading
-import time  # Added for sleep
+import time
+from pathlib import Path
 from utils.data_loader import get_random_example
 from utils.models import generate_summaries, model_names
 from utils.ui_helpers import toggle_context_display, update_feedback, get_context_html
@@ -21,8 +22,19 @@ feedback_options = {
                "Model B: Incomplete", "Model B: Hallucinate", "Model B: Irrelevant", "Model B: Incorrect refusal (if applicable)"]
 }
 
-def load_context():
-    """Load a new question and context (fast operation)"""
+def load_context(set_interrupt=False):
+    """
+    Load a new question and context
+    
+    Parameters:
+    - set_interrupt: If True, will interrupt any ongoing inference before loading
+    """
+    if set_interrupt:
+        # Interrupt any ongoing inference
+        generation_interrupt.set()
+        time.sleep(0.2)  # Short delay to allow threads to detect interrupt
+        
+    # Always clear the flag before starting new work
     generation_interrupt.clear()
     example = get_random_example()
     
@@ -85,13 +97,14 @@ def process_generation_result(result):
             "", "", "", "", None, [], False, load_leaderboard_data(),
             gr.update(value="Generation was interrupted or failed. Please try again."),
             gr.update(value="Generation was interrupted or failed. Please try again."),
-            gr.update(interactive=True, elem_classes=["vote-button"]),
-            gr.update(interactive=True, elem_classes=["vote-button"]),
-            gr.update(interactive=True, elem_classes=["vote-button"]),
-            gr.update(interactive=True, elem_classes=["vote-button", "vote-button-neither"]),
+            # Keep voting buttons disabled when generation fails or is interrupted
+            gr.update(interactive=False, elem_classes=["vote-button"]),
+            gr.update(interactive=False, elem_classes=["vote-button"]),
+            gr.update(interactive=False, elem_classes=["vote-button"]),
+            gr.update(interactive=False, elem_classes=["vote-button", "vote-button-neither"]),
             gr.update(choices=[], value=[], interactive=False, visible=False),
             gr.update(visible=False),
-            gr.update(interactive=False, visible=True),
+            gr.update(interactive=True, visible=True),
             gr.update(visible=False),
             gr.update(interactive=True),
             gr.update(elem_classes=[])
@@ -105,6 +118,7 @@ def process_generation_result(result):
         None, [], False, agg_results,
         gr.update(value=result["summary_a"]),
         gr.update(value=result["summary_b"]),
+        # Enable voting buttons only when both summaries are ready
         gr.update(interactive=True, elem_classes=["vote-button"]),
         gr.update(interactive=True, elem_classes=["vote-button"]),
         gr.update(interactive=True, elem_classes=["vote-button"]),
@@ -167,6 +181,7 @@ def show_loading_state():
     return [
         gr.update(value="Loading new question and summaries...", interactive=False),
         gr.update(value="Loading new question and summaries...", interactive=False),
+        # Disable voting buttons during loading
         gr.update(interactive=False),
         gr.update(interactive=False),
         gr.update(interactive=False),
@@ -175,9 +190,8 @@ def show_loading_state():
 
 def handle_new_example_click():
     """Handle clicking 'Get new example' button"""
-    generation_interrupt.set()  # Interrupt any ongoing generation
-    time.sleep(0.2)  # Added delay to allow threads to detect the interrupt
-    return load_context()[0]
+    # Use the centralized approach - set_interrupt=True tells load_context to handle interruption
+    return load_context(set_interrupt=True)[0]
 
 def update_ui_for_new_context(example):
     """Update UI with new context information"""
@@ -196,22 +210,10 @@ with gr.Blocks(theme=gr.themes.Default(
 )) as demo:
     # Load CSS
     css_path = os.path.join(os.getcwd(), 'static', 'styles.css')
-    
-    # Make sure the JavaScript directory exists
-    os.makedirs(os.path.join(os.getcwd(), 'static', 'js'), exist_ok=True)
-    
-    # Load the files
     with open(css_path, 'r') as f:
         css_content = f.read()
     
-    # Create HTML components with CSS and JavaScript links
     gr.HTML(f"<style>{css_content}</style>")
-    
-    # Load JavaScript file via script tag
-    js_path = os.path.join(os.getcwd(), 'static', 'js', 'scroll_helpers.js')
-    # Use relative path for the script source
-    js_path_relative = 'static/js/scroll_helpers.js'
-    gr.HTML(f'<script src="{js_path_relative}"></script>')
 
     # State Variables
     current_example = gr.State({})
@@ -290,10 +292,11 @@ with gr.Blocks(theme=gr.themes.Default(
                 # Voting section
                 gr.Markdown("### 🏅 Cast Your Vote", elem_classes="section-heading")
                 with gr.Row():
-                    vote_button_a = gr.Button("⬅️ Summary A is Better", elem_classes=["vote-button"])
-                    vote_button_tie = gr.Button("🤝 Tie / Equally Good", elem_classes=["vote-button"])
-                    vote_button_b = gr.Button("➡️ Summary B is Better", elem_classes=["vote-button"])
-                    vote_button_neither = gr.Button("❌ Neither is Good", elem_classes=["vote-button", "vote-button-neither"])
+                    # Start with voting buttons disabled
+                    vote_button_a = gr.Button("⬅️ Summary A is Better", elem_classes=["vote-button"], interactive=False)
+                    vote_button_tie = gr.Button("🤝 Tie / Equally Good", elem_classes=["vote-button"], interactive=False)
+                    vote_button_b = gr.Button("➡️ Summary B is Better", elem_classes=["vote-button"], interactive=False)
+                    vote_button_neither = gr.Button("❌ Neither is Good", elem_classes=["vote-button", "vote-button-neither"], interactive=False)
 
                 # Feedback and Submit sections
                 with gr.Group(elem_classes=["feedback-section"], visible=False) as feedback_section:
@@ -337,7 +340,6 @@ The Elo rating system provides a more accurate ranking than simple win rates:
             
             results_table_display = gr.HTML(label="Model Performance")
 
-    # Event handling
     # Toggle context display
     context_toggle_btn.click(
         fn=toggle_context_display,
@@ -346,8 +348,9 @@ The Elo rating system provides a more accurate ranking than simple win rates:
     )
     
     # Initial loading - context first, then summaries
+    # Uses load_context without interruption since it's the first load
     demo.load(
-        fn=load_context,
+        fn=load_context,  # Default is set_interrupt=False
         inputs=[],
         outputs=[current_example, query_display, context_description, context_display, 
                 context_toggle_btn, show_full_context]
@@ -376,7 +379,7 @@ The Elo rating system provides a more accurate ranking than simple win rates:
             outputs=[summary_a_display, summary_b_display, vote_button_a, 
                     vote_button_b, vote_button_tie, vote_button_neither]
         ).then(
-            fn=handle_new_example_click,
+            fn=handle_new_example_click,  # Now uses the centralized approach
             inputs=[],
             outputs=[current_example]
         ).then(