Update app.py and trim_portfolio.py to change threshold parameters from integers to floats, enhancing precision in portfolio trimming functionality and ensuring consistent data handling.

app.py

@@ -912,10 +912,10 @@ with tab2:
                 with st.form(key='trim_form'):
                     performance_type = st.selectbox("Select Sorting variable", ['median', 'Finish_percentile'])
                     own_type = st.selectbox("Select trimming variable", ['Own', 'Geomean', 'Weighted Own'])
-                    performance_threshold_high = st.number_input("Select performance threshold (will only trim if sorting variable is lower than this)", value=st.session_state['portfolio'][performance_type].max(), min_value=0, step=1)
-                    performance_threshold_low = st.number_input("Select performance threshold (will only trim if sorting variable is higher than this)", value=0, min_value=0, step=1)
-                    own_threshold_high = st.number_input("Select own threshold (will only trim if trimming variable is lower than this)", value=st.session_state['portfolio'][own_type].max(), min_value=0, step=1)
-                    own_threshold_low = st.number_input("Select own threshold (will only trim if trimming variable is higher than this)", value=0, min_value=0, step=1)
+                    performance_threshold_high = st.number_input("Select performance threshold (will only trim if sorting variable is lower than this)", value=st.session_state['portfolio'][performance_type].max(), min_value=0.0, step=1.0)
+                    performance_threshold_low = st.number_input("Select performance threshold (will only trim if sorting variable is higher than this)", value=0.0, min_value=0.0, step=1.0)
+                    own_threshold_high = st.number_input("Select own threshold (will only trim if trimming variable is lower than this)", value=st.session_state['portfolio'][own_type].max(), min_value=0.0, step=1.0)
+                    own_threshold_low = st.number_input("Select own threshold (will only trim if trimming variable is higher than this)", value=0.0, min_value=0.0, step=1.0)
                     submitted = st.form_submit_button("Trim")
                     if submitted:
                         st.write('initiated')

global_func/trim_portfolio.py

@@ -1,6 +1,6 @@
 import pandas as pd
 
-def trim_portfolio(portfolio: pd.DataFrame, performance_type: str, own_type: str, performance_threshold_high: int, performance_threshold_low: int, own_threshold_high: int, own_threshold_low: int):
+def trim_portfolio(portfolio: pd.DataFrame, performance_type: str, own_type: str, performance_threshold_high: float, performance_threshold_low: float, own_threshold_high: float, own_threshold_low: float):
     if performance_type == 'Finish_percentile':
         working_portfolio = portfolio.sort_values(by=performance_type, ascending = True).reset_index(drop=True)
     else: