Refactor player ID and position handling in grab_contest_data function

- Updated the logic for processing player IDs to only include valid entries, enhancing data accuracy.
- Improved the handling of position mapping by ensuring the number of player IDs matches the actual positions, with warnings for mismatches.
- These changes contribute to ongoing efforts to enhance data integrity and improve user experience within the application.

global_func/grab_contest_data.py

@@ -12,29 +12,18 @@ def grab_contest_data(sport, contest_name, contest_id_map, contest_date):
     def format_lineup_string(lineup_hash, positions):
         """Replaces colons in a lineup hash with sequential positions."""
         # Remove the leading colon and split by the remaining colons
-        player_ids = lineup_hash.lstrip(':').split(':')
+        # Only split on colons that are between numbers
+        player_ids = [pid for pid in lineup_hash.lstrip(':').split(':') if pid.isdigit() or pid == '-1']
         
-        # For MLB, we need to handle the specific position order
-        if len(player_ids) == 9:  # 9-player lineup
-            # Map positions to the correct order for a 9-player lineup
-            position_map = {
-                0: '1B ',
-                1: ' 2B ',
-                2: ' 3B ',
-                3: ' C ',
-                4: ' OF ',
-                5: ' OF ',
-                6: ' P ',
-                7: ' P ',
-                8: ' SS '
-            }
-            # Use the mapped positions instead of the full position list
-            actual_positions = [position_map[i] for i in range(len(player_ids))]
-        else:
-            # For other cases, use the standard position list
-            actual_positions = positions[:len(player_ids)]
+        # Get the actual positions needed for this lineup
+        actual_positions = positions[:len(player_ids)]
+        
+        # Check if the number of IDs matches the number of positions
+        if len(player_ids) != len(actual_positions):
+            print(f"Warning: Mismatch for hash {lineup_hash}. IDs: {len(player_ids)}, Positions: {len(actual_positions)}")
+            return lineup_hash
 
-        # Combine positions and player IDs
+        # Combine positions and player IDs, only for valid player IDs
         combined_parts = []
         for pos, pid in zip(actual_positions, player_ids):
             if pid == '-1':  # Handle empty slots