andrew bennetts rkijuaqjbmqrgqppuzzlingorg raghuram devarakonda wrote hi submitted patch httpwwwpythonorgsf1704547 allows osrename replace destination file exists windows part discussion tracker martin suggested pythondev discuss change movefile_replace_existing mean rename existing file actually atomic find msdn docs say ive seen suggest probably isnt atomic doesnt offer advantage shutilmove see fact would damage usefulness osrename currently atomic platforms afaik even though succeed time movefile_replace_existing miraculously turns atomic opinion feature would useful would like crossplatform way python feature called osrename years done something else platforms changing invite unnecessary breakage new function would better perhaps optional flag propose osatomic_rename also assume replace files use currently osrename windows uses api movefile fails destination file exists patch replaces api movefileex uses flag movefile_replace_existing causes destination file replaced exists however change subtle existing code depends current osrename behaviour windows code silently broken destination file overwritten functionality replacing important would like know best way supporting deemed change good go asis optional parameter osrename say win_replace used callers explicitly request replacing id ok flag crossplatform name require_atomic replace something like think new function makes sense though must also point patch uses another flag movefile_copy_allowed effectively allowing renamed files separate file systems renaming case atomic used flag support current functionality bad idea disallow renames brings line behaviour many unix flavors also potential break code silently dont quite follow youre saying id operation called rename sometimes atomic sometimes wasnt lastly found old discussion topic list httpmailpythonorgpipermailpythondev2001may014957html even though guido indicated doesnt support api change thread posting see one mention movefileex thread movefileex solve atomicity problem guido raised thread dont think think situation still andrew _______________________________________________ pythondev mailing list zvlllneumpythonorg httpmailpythonorgmailmanlistinfopythondev unsubscribe httpmailpythonorgmailmanoptionspythondevpythondev40tangomucom wed 06 aug 2008 094821 1000 pythondev osrename windows