text_combined: axel hecht l19vqeygooglemailcom 20071113 axel hecht quest adding slave commands end adding import line hacked buildbot start script something cleaner might nice havent looked buildbottac yet maybe thatd cleaner actually tried seems work quite nicely better least hacking buildbot_slave starter script axel 20071112 aaron maxwell update mastercfg example quite right managed mix buildbotslavecommandssvn buildbotstepssourcesvn originally thought patch generally valuable im certain find good way subclass buildbotslavecommandssvn registered mastercfg actually easy dont mind adding subclass buildbotslavecommandspy directly ended clearly ideal still think patch value would like see integrated nothing else encapsulates svn version command imo makes whole class extensible flexible theres also selfishness personally find useful im trying let influence okay guess thats brian committer sorry dont know everyone yet something youd like check let know help regardless thanks buildbot aaron tuesday 06 november 2007 145952 aaron maxwell wrote hi based feedback experiments think much better patch httpredsymbolnetbuildbotcommandspy_2patch ive pasted well basically introduces method svngetsvnversioncommand returns shell command used determine svn version default returns svnversion line whats 076 someone like needs different calculation subclass illustrate heres mastercfg buildbotstepssource import svn class snapsvnsvn def getsvnversioncommandself use current working directory want get recent checkin revision trunk branchfoo rather trunksnaplogic return getcommandsvnversion c primary_factoryaddstepsnapsvn namechecking haltonfailuretrue lot cleaner extensible first patch think brian patch might consider integrating trunk anything need changed feedback appreciated convenience heres patch contents sorry laid confusingly basically added getsvnversioncommand method made smaller changes parsegotrevision buildbotslavecommandspyorig 20071029 205559000000000 0700 buildbotslavecommandspy 20071106 142614000000000 0800 149415 149424 selfcommand c return cstart def parsegotrevisionself def getsvnversioncommandself get shell command used determine svn revision number checkedout code return list strings passable command argument shellcommand svn checkout operations finish checked revision 16657 svn update operations finish line revision 16654 dont use instead run svnversion svnversion_command getcommandsvnversion older versions svnversion 114 require wc_path argument newer ones 131 command svnversion_command c shellcommandselfbuilder command return svnversion_command def parsegotrevisionself c shellcommandselfbuilder selfgetsvnversioncommand ospathjoinselfbuilderbasedir selfsrcdir environselfenv sendstdoutfalse sendstderrfalse sendrcfalse 151016 151916 cusepty false cstart def _parseres r cstdoutstrip support removing svnversion indicator modified r1 r r1 r_raw cstdoutstrip extract revision version number string r r_rawrstripms r rsplit1 got_version none try got_version intr except valueerror msg svnparsegotrevision unable parse output svnversion r svnversion r_raw logmsgmsg selfsendstatusheader msg n return got_version aaron maxwell qolysnaplogicorg httpsnaplogicorg snaplogic inc data integration last mile sfnet email sponsored splunk inc still grepping log files find problems stop search log events configuration files using ajax browser download free copy splunk httpgetsplunkcom buildbotdevel mailing list sfnet email sponsored splunk inc still grepping log files find problems stop search log events configuration files using ajax browser download free copy splunk httpgetsplunkcom fri 08 aug 2008 051233 0100 buildbotdevel svnparsegotrevision patch v 2