he was commissioned into the 3rd (militia) battalion, south wales borderers in 1891, and was promoted lieutenant in 1893 and captain in 1907. during the boer war he commanded a prisoner of war camp in ireland. he resigned his commission in 1906, but in 1907 joined the 1st (volunteer) battalion (later the brecknockshire battalion), resigning in 1911. during the first world war he returned to his regiment to command a musketry training camp in pembrokeshire, retiring with the rank of major.