after working as a solicitor, he became a lecturer in law at the university of edinburgh in 1980 where he was subsequently appointed to the chair of property law in 1994 and then the chair of scots law in 2008.