I’m not expert enough in the tokenizers to best advise you for this model. Maybe @thomwolf or @anthony could have more insight?
Documentation is a must before opening the PR, and no it does not hinder readability, it’s actually supposed to explain what the code does 
For the decoupling we can help if you need it, but it will need to be done before the PR is merged anyway.