well, per the paper above, french and english share enough words that it worked ok for them.
As far as copying the weights, I think that means the second embedding has already been allocated. And then we throw it away. That seems a bit ‘unclean’ to me. What if the embedding is huge?
Would prefer to be able to create the embedding once, then re-use it. In idiomatic pytorch.