Has anyone gotten good T5 results with/without EOS? I tried updating the tokenizer to add , but it doesn’t seem to help zero shot performance on wmt_en_ro:
From a fork of this repo, you can run
git fetch upstream
git checkout t5tok

to get a version of the tokenizer that adds EOS.
When I ran eval on wmt_en_ro (without finetuning) I got
t5tok (with `<s>`):27.65
master (no EOS): 27.87

The commands to reproduce are in this PR description 1
Would love to know results on other datasets!