Find all the real values of $a,b,c,e,d,f$ for which $A$ is diagonalizable $\newcommand{\span}{\text{span}}$
The matrix in question is:
$$A=\begin{pmatrix}
 2&0&0&0\\
    a&-1&0&0\\
    b&c&-1&0\\
    d&e&f&2
\end{pmatrix}$$
This was on a test that I had and I got it wrong because I needed to add more conditions, what I did was:
Since A is a upper triangular matrix the eigenvalues of A are the values on the diagonal so $$\lambda_1=\lambda_4=2 \qquad \lambda_2=\lambda_3=-1$$
For $$\lambda_1=\lambda_4=2$$ we have:
$(A-2I)=\begin{pmatrix}
 2&0&0&0\\
    a&-1&0&0\\
    b&c&-1&0\\
    d&e&f&2
\end{pmatrix}-\begin{pmatrix}
     2&0&0&0\\
0&2&0&0\\
0&0&2&0\\
0&0&0&2
\end{pmatrix}=
\begin{pmatrix}
 0&0&0&0\\
    a&-1&0&0\\
    b&c&-1&0\\
    d&e&f&0
\end{pmatrix}$
Since we need that the geometric multiplicity equals the algebraic multiplicity (which is $2$) we need to have 2 linearly independent vectors on each solution for the eigenvalues, so by making $a=b=c=d=e=f=0$ we get:
$$\begin{pmatrix}
 0&0&0&0\\
    0&-1&0&0\\
    0&0&-1&0\\
    0&0&0&0
\end{pmatrix}$$
The will give us the eigenspace $E_{2}=\span\left(\begin{bmatrix}1\\0\\0\\0\end{bmatrix},\begin{bmatrix}0\\0\\0\\1\end{bmatrix}\right)$
By a similar process for $\lambda_2=\lambda_3=-1$ we get $E_{-1}=\span\left(\begin{bmatrix}0\\1\\0\\0\end{bmatrix},\begin{bmatrix}0\\0\\1\\0\end{bmatrix}\right)$
What are the remaining conditions, or values, that I need on $a,b,c,d,e,f$ for $A$ to be diagonalizable. Any help would be really appreciated.

Ummm. A matrix is diagonalizable if and only if the minimal polynomial  is squarefree.
Your characteristic polynomial is $ (\lambda +1)^2 (\lambda - 2)^2.$  Both factors occur in the minimal polynomial with exponent either $1$   or $2.$   We need both exponents $1,$    so that the minimal poly becomes $ (\lambda +1) (\lambda - 2)= \lambda^2 - \lambda - 2.$
This happens when
$$  A^2 - A - 2I = 0  $$
calculating
$$
A^2 - A - 2 I =
\left(
\begin{array}{cccc}
0&0&0&0 \\
0&0&0&0 \\
ac&-3c&0&0 \\
ae+bf+3d& cf&0&0 
\end{array}
\right)
$$
