events.action: opened
events.author: KrisC369
events.masked_author: username_0
events.text: Major pull request to update master branch to include lastest work from development.
  This is in preparation of the next release.
  
  <!-- Reviewable:start -->
  ---
  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/krisc369/gridflex-simulator/41)
  <!-- Reviewable:end -->
events.title: Develop
events.type: issue
events.action: created
events.author: KrisC369
events.masked_author: username_0
events.text: Won't resolve. Empty body in component implementation is expected.
  
  ---
  
  *[game/src/main/java/be/kuleuven/cs/gametheory/AbstractGame.java, line 26 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99b6xIuYBMXo2lq-r2-26:-KgstA2aoCA2ryFyaInG:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/game/src/main/java/be/kuleuven/cs/gametheory/AbstractGame.java#L26)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Perhaps 'agents' could be replaced by a local variable.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[game/src/main/java/be/kuleuven/cs/gametheory/AbstractGame.java, line 27 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99b6xIuYBMXo2lq-r2-27:-Kgssjh05N2qdqh_zU0w:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/game/src/main/java/be/kuleuven/cs/gametheory/AbstractGame.java#L27)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Perhaps 'actions' could be replaced by a local variable.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[game/src/main/java/be/kuleuven/cs/gametheory/AbstractGame.java, line 29 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99b6xIuYBMXo2lq-r2-29:-KgsskF9y8yX__WKiyNU:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/game/src/main/java/be/kuleuven/cs/gametheory/AbstractGame.java#L29)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused private fields such as 'reps'.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest.java, line 28 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99b6xIuYBMXo2mF-r2-28:-Kgssm-XDipY5BQJI3Jk:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest.java#L28)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused imports such as 'junit.framework.TestCase.assertTrue'](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest.java, line 148 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99b6xIuYBMXo2mF-r2-148:-Kgssn5H7HbRjHfcRVkR:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest.java#L148)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Unnecessary use of fully qualified name 'Assert.assertEquals' due to existing static import 'org.junit.Assert.assertEquals'](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest_Issues.java, line 16 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99b6xIuYBMXo2mG-r2-16:-KgssnvUWgn73CjQQkm9:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest_Issues.java#L16)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused private fields such as 'logger'.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest_Issues.java, line 30 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99b6xIuYBMXo2mG-r2-30:-KgssoWB5aJlzg_MozBN:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest_Issues.java#L30)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused private methods such as 'reset()'.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest_Issues.java, line 35 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99b6xIuYBMXo2mG-r2-35:-Kgssp61PUATIinxzYHr:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest_Issues.java#L35)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Method names should not contain underscores](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest_Issues.java, line 41 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99b6xIuYBMXo2mG-r2-41:-KgssphvVoGJrW44oDXR:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest_Issues.java#L41)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Method names should not contain underscores](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest_Issues.java, line 47 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99b6xIuYBMXo2mG-r2-47:-KgssqNokpsf-WbOOe8F:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/persistence/src/test/java/be/kuleuven/cs/gridflex/persistence/MapDBMemoizationContextTest_Issues.java#L47)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Method names should not contain underscores](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/benchmark/BenchmarkSolver.java, line 15 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99diRJa-uW2z77s-r2-15:-Kgssr1iGO8iy2ZazrTU:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/benchmark/BenchmarkSolver.java#L15)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused private fields such as 'logger'.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/data/CsvResultWriter.java, line 31 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99diRJa-uW2z77u-r2-31:-KgssrjHCBmmu0t775pH:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/data/CsvResultWriter.java#L31)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/data/CsvResultWriter.java, line 106 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99diRJa-uW2z77u-r2-106:-KgsssNybKSqUSzr2RPX:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/data/CsvResultWriter.java#L106)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid long parameter lists.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/utils/WriteFileCreator.java, line 17 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99diRJa-uW2z78--r2-17:-Kgsstv-senWozt017l4:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/utils/WriteFileCreator.java#L17)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/utils/WriteFileCreator.java, line 18 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99diRJa-uW2z78--r2-18:-KgssuNhyqS8XGWqN9iC:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/utils/WriteFileCreator.java#L18)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/utils/WriteFileCreator.java, line 34 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99diRJa-uW2z78--r2-34:-Kgssv3UAN5OJTYuKPog:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/utils/WriteFileCreator.java#L34)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [System.exit() should not be used in J2EE/JEE apps](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/wgmf/AbstractWgmfGameRunner.java, line 33 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99diRJa-uW2z780-r2-33:-Kgssx_M5BbNIJ9yR6-o:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/wgmf/AbstractWgmfGameRunner.java#L33)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused private fields such as 'logger'.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/wgmf/ExecutionStrategy.java, line 158 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99diRJa-uW2z781-r2-158:-KgsszEw1JyEc59s54eD:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/project/src/main/java/be/kuleuven/cs/gridflex/experimentation/tosg/wgmf/ExecutionStrategy.java#L158)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Perhaps 'extractor' could be replaced by a local variable.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[solve/src/main/java/be/kuleuven/cs/gridflex/solvers/heuristic/domain/Allocation.java, line 26 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99eLecZrWxISfmB-r2-26:-Kgst03rso8VbUnVxUu-:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/solve/src/main/java/be/kuleuven/cs/gridflex/solvers/heuristic/domain/Allocation.java#L26)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused private fields such as 'SIZE'.](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[solve/src/main/java/be/kuleuven/cs/gridflex/solvers/memoization/ImmutableViews/AllocResultsView.java, line 1 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99eLecZrWxISfmH-r2-1:-Kgst2qg3c8yHBy_VgJw:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/solve/src/main/java/be/kuleuven/cs/gridflex/solvers/memoization/ImmutableViews/AllocResultsView.java#L1)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Package name contains upper case characters](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[solve/src/main/java/be/kuleuven/cs/gridflex/solvers/memoization/ImmutableViews/FlexibilityProviderView.java, line 1 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99eLecZrWxISfmI-r2-1:-Kgst3F3aD7HhK66-Cdy:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/solve/src/main/java/be/kuleuven/cs/gridflex/solvers/memoization/ImmutableViews/FlexibilityProviderView.java#L1)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Package name contains upper case characters](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[solve/src/main/java/be/kuleuven/cs/gridflex/solvers/memoization/ImmutableViews/ImmutableSolverProblemContextView.java, line 1 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99eLecZrWxISfmJ-r2-1:-Kgst4lPpnriN2KLwYA9:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/solve/src/main/java/be/kuleuven/cs/gridflex/solvers/memoization/ImmutableViews/ImmutableSolverProblemContextView.java#L1)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Package name contains upper case characters](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  *[solve/src/main/java/be/kuleuven/cs/gridflex/solvers/memoization/ImmutableViews/package-info.java, line 7 at r2](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41#-Kgsg99eLecZrWxISfmK-r2-7:-Kgst621KtQ6ZduHOcgo:b-896fix) ([raw file](https://github.com/krisc369/gridflex-simulator/blob/47eb8e1220536c78807970f341310dec63a4d286/solve/src/main/java/be/kuleuven/cs/gridflex/solvers/memoization/ImmutableViews/package-info.java#L7)):*
  <details><summary><i>Previously, codacy-bot (Codacy Bot) wrote…</i></summary><blockquote>
  
  ![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Package name contains upper case characters](https://www.codacy.com/app/kristofconinx369/Flexsim/pullRequest?prid=591955)
  </blockquote></details>
  
  Done.
  
  ---
  
  
  *Comments from [Reviewable](https://reviewable.io:443/reviews/krisc369/gridflex-simulator/41)*
  <!-- Sent from Reviewable.io -->
events.type: comment