events.action: opened
events.author: binlijin
events.text: …ly for meta).
events.title: HBASE-22280 Separate read/write handler for priority request(especial…
events.type: issue
events.action: created
events.author: carp84
events.text: Please also check the `mvninstall`, `checkstyle` and UT error reported by robot
events.type: comment
events.action: created
events.author: saintstack
events.text: Any updates here @binlijin ? Thanks.
events.type: comment
events.action: created
events.author: binlijin
events.text: @saintstack  i can not do the contribution now for some reason, someone else can take it over.
events.type: comment
events.action: created
events.author: binlijin
events.text: @carp84 fix the ut, the test need at least two write handler when use separate read/write handlers.
events.type: comment
events.action: created
events.author: carp84
events.type: comment
events.action: created
events.author: binlijin
events.text: @carp84  run this tests and passed locally,  they're not related to the patch.
events.type: comment
data_with_bots.bot: :broken_heart: **-1 overall**
  
  
  
  
  
  
  | Vote | Subsystem | Runtime | Comment |
  |:----:|----------:|--------:|:--------|
  | 0 | reexec | 30 | Docker mode activated. |
  ||| _ Prechecks _ |
  | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
  | +1 | @author | 0 | The patch does not contain any @author tags. |
  | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
  ||| _ master Compile Tests _ |
  | +1 | mvninstall | 349 | master passed |
  | +1 | compile | 85 | master passed |
  | +1 | checkstyle | 79 | master passed |
  | +1 | shadedjars | 345 | branch has no errors when building our shaded downstream artifacts. |
  | +1 | findbugs | 418 | master passed |
  | +1 | javadoc | 52 | master passed |
  ||| _ Patch Compile Tests _ |
  | -1 | mvninstall | 267 | root in the patch failed. |
  | +1 | compile | 90 | the patch passed |
  | +1 | javac | 90 | the patch passed |
  | -1 | checkstyle | 85 | hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) |
  | +1 | whitespace | 0 | The patch has no whitespace issues. |
  | -1 | shadedjars | 315 | patch has 11 errors when building our shaded downstream artifacts. |
  | -1 | hadoopcheck | 184 | The patch causes 11 errors with Hadoop v2.8.5. |
  | -1 | hadoopcheck | 368 | The patch causes 11 errors with Hadoop v2.9.2. |
  | -1 | hadoopcheck | 570 | The patch causes 11 errors with Hadoop v3.1.2. |
  | +1 | findbugs | 345 | the patch passed |
  | +1 | javadoc | 55 | the patch passed |
  ||| _ Other Tests _ |
  | -1 | unit | 98 | hbase-server in the patch failed. |
  | +1 | asflicense | 19 | The patch does not generate ASF License warnings. |
  | | | 3296 | |
  
  
  | Subsystem | Report/Notes |
  |----------:|:-------------|
  | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/Dockerfile |
  | GITHUB PR | https://github.com/apache/hbase/pull/202 |
  | Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
  | uname | Linux 4571e48797fb 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux |
  | Build tool | maven |
  | Personality | /testptch/patchprocess/precommit/personality/provided.sh |
  | git revision | master / ada772a1d3 |
  | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
  | Default Java | 1.8.0_181 |
  | findbugs | v3.1.11 |
  | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-mvninstall-root.txt |
  | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/diff-checkstyle-hbase-server.txt |
  | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-shadedjars.txt |
  | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-2.8.5.txt |
  | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-2.9.2.txt |
  | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-3.1.2.txt |
  | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-unit-hbase-server.txt |
  |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/testReport/ |
  | Max. process+thread count | 50 (vs. ulimit of 10000) |
  | modules | C: hbase-server U: hbase-server |
  | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/console |
  | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
  
  
  This message was automatically generated.
data_with_bots.meta: This message directly preceded comment from bot *Apache-HBase* by author *carp84*:
data_with_bots.text: Please also check the `mvninstall`, `checkstyle` and UT error reported by robot
data_with_bots.bot: :broken_heart: **-1 overall**
  
  
  
  
  
  
  | Vote | Subsystem | Runtime | Comment |
  |:----:|----------:|--------:|:--------|
  | 0 | reexec | 31 | Docker mode activated. |
  ||| _ Prechecks _ |
  | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
  | +1 | @author | 0 | The patch does not contain any @author tags. |
  | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
  ||| _ master Compile Tests _ |
  | +1 | mvninstall | 230 | master passed |
  | +1 | compile | 50 | master passed |
  | +1 | checkstyle | 65 | master passed |
  | +1 | shadedjars | 261 | branch has no errors when building our shaded downstream artifacts. |
  | +1 | findbugs | 204 | master passed |
  | +1 | javadoc | 30 | master passed |
  ||| _ Patch Compile Tests _ |
  | -1 | mvninstall | 155 | root in the patch failed. |
  | +1 | compile | 53 | the patch passed |
  | +1 | javac | 53 | the patch passed |
  | -1 | checkstyle | 67 | hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) |
  | +1 | whitespace | 0 | The patch has no whitespace issues. |
  | -1 | shadedjars | 207 | patch has 11 errors when building our shaded downstream artifacts. |
  | -1 | hadoopcheck | 115 | The patch causes 11 errors with Hadoop v2.8.5. |
  | -1 | hadoopcheck | 229 | The patch causes 11 errors with Hadoop v2.9.2. |
  | -1 | hadoopcheck | 349 | The patch causes 11 errors with Hadoop v3.1.2. |
  | +1 | findbugs | 207 | the patch passed |
  | +1 | javadoc | 33 | the patch passed |
  ||| _ Other Tests _ |
  | -1 | unit | 55 | hbase-server in the patch failed. |
  | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
  | | | 2068 | |
  
  
  | Subsystem | Report/Notes |
  |----------:|:-------------|
  | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/Dockerfile |
  | GITHUB PR | https://github.com/apache/hbase/pull/202 |
  | Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
  | uname | Linux abb2e4ccaa87 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux |
  | Build tool | maven |
  | Personality | /testptch/patchprocess/precommit/personality/provided.sh |
  | git revision | master / 438bf3284e |
  | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
  | Default Java | 1.8.0_181 |
  | findbugs | v3.1.11 |
  | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-mvninstall-root.txt |
  | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/diff-checkstyle-hbase-server.txt |
  | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-shadedjars.txt |
  | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-2.8.5.txt |
  | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-2.9.2.txt |
  | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-3.1.2.txt |
  | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-unit-hbase-server.txt |
  |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/testReport/ |
  | Max. process+thread count | 96 (vs. ulimit of 10000) |
  | modules | C: hbase-server U: hbase-server |
  | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/console |
  | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
  
  
  This message was automatically generated.
data_with_bots.meta: This message directly preceded comment from bot *Apache-HBase* by author *binlijin*:
data_with_bots.text: @saintstack  i can not do the contribution now for some reason, someone else can take it over.
data_with_bots.bot: :broken_heart: **-1 overall**
  
  
  
  
  
  
  | Vote | Subsystem | Runtime | Comment |
  |:----:|----------:|--------:|:--------|
  | +0 :ok: |  reexec  |   0m 33s |  Docker mode activated.  |
  ||| _ Prechecks _ |
  | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
  | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
  | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
  | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 2 new or modified test files.  |
  ||| _ master Compile Tests _ |
  | +1 :green_heart: |  mvninstall  |   5m 23s |  master passed  |
  | +1 :green_heart: |  compile  |   0m 55s |  master passed  |
  | +1 :green_heart: |  checkstyle  |   1m 20s |  master passed  |
  | +1 :green_heart: |  shadedjars  |   4m 39s |  branch has no errors when building our shaded downstream artifacts.  |
  | +1 :green_heart: |  javadoc  |   0m 38s |  master passed  |
  | +0 :ok: |  spotbugs  |   4m  9s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
  | +1 :green_heart: |  findbugs  |   4m  6s |  master passed  |
  ||| _ Patch Compile Tests _ |
  | +1 :green_heart: |  mvninstall  |   5m  3s |  the patch passed  |
  | +1 :green_heart: |  compile  |   0m 55s |  the patch passed  |
  | +1 :green_heart: |  javac  |   0m 55s |  the patch passed  |
  | +1 :green_heart: |  checkstyle  |   1m 19s |  the patch passed  |
  | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
  | +1 :green_heart: |  shadedjars  |   4m 36s |  patch has no errors when building our shaded downstream artifacts.  |
  | +1 :green_heart: |  hadoopcheck  |  15m 31s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
  | +1 :green_heart: |  javadoc  |   0m 37s |  the patch passed  |
  | +1 :green_heart: |  findbugs  |   4m  8s |  the patch passed  |
  ||| _ Other Tests _ |
  | -1 :x: |  unit  | 167m 23s |  hbase-server in the patch failed.  |
  | +1 :green_heart: |  asflicense  |   0m 34s |  The patch does not generate ASF License warnings.  |
  |  |   | 224m 12s |   |
  
  
  | Reason | Tests |
  |-------:|:------|
  | Failed junit tests | hadoop.hbase.master.TestClusterRestartFailoverSplitWithoutZk |
  |   | hadoop.hbase.replication.TestReplicationDroppedTables |
  |   | hadoop.hbase.master.TestClusterRestartFailover |
  
  
  | Subsystem | Report/Notes |
  |----------:|:-------------|
  | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/Dockerfile |
  | GITHUB PR | https://github.com/apache/hbase/pull/202 |
  | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
  | uname | Linux d9f62458b8d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
  | Build tool | maven |
  | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh |
  | git revision | master / 4ea792246f |
  | Default Java | 1.8.0_181 |
  | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-unit-hbase-server.txt |
  |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/testReport/ |
  | Max. process+thread count | 5054 (vs. ulimit of 10000) |
  | modules | C: hbase-server U: hbase-server |
  | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/console |
  | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
  | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
  
  
  This message was automatically generated.
data_with_bots.meta: This message directly preceded comment from bot *Apache-HBase* by author *binlijin*:
data_with_bots.text: @carp84 fix the ut, the test need at least two write handler when use separate read/write handlers.
data_without_bots.meta: This message directly preceded comment from bot *Apache-HBase* by author *carp84*:
data_without_bots.text: Please also check the `mvninstall`, `checkstyle` and UT error reported by robot
data_without_bots.meta: This message directly preceded comment from bot *Apache-HBase* by author *binlijin*:
data_without_bots.text: @saintstack  i can not do the contribution now for some reason, someone else can take it over.
data_without_bots.meta: This message directly preceded comment from bot *Apache-HBase* by author *binlijin*:
data_without_bots.text: @carp84 fix the ut, the test need at least two write handler when use separate read/write handlers.