events.action: opened
events.author: nikhita
events.text: Fixes kubernetes/apiextensions-apiserver#28
  
  `go-openapi/validate` had a bug https://github.com/go-openapi/validate/issues/13 where it did not properly validate enums for integers. This hits users of CRD validation. This was fixed in https://github.com/go-openapi/validate/pull/14.
  
  I had bumped `go-openapi/validate` for subresources in https://github.com/kubernetes/kubernetes/pull/55168 in this commit: https://github.com/kubernetes/kubernetes/commit/66a4e5122a2d810ada2f23af803d1e44256dd260 (to get the fix https://github.com/go-openapi/validate/pull/36 in). This bump picked up the fix for enum validation, so this bug does not affect 1.10 users.
  
  This PR cherry picks the above commit to the `release-1.9` branch to fix the bug for 1.9 users.
  
  This is not an automated cherry pick. My understanding is that automated cherry picks are for cherry-picking complete PRs and this cherry picks _a commit_ in a PR https://github.com/kubernetes/kubernetes/pull/55168. Adding an explicit hold to make sure this is ok.
  /hold
  
  
  **Release note**:
  <!--  Write your release note:
  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE".
  -->
  ```release-note
  NONE
  ```
  
  /cc mbohlool sttts liggitt 
  /assign mbohlool
events.title: [1.9] bump(go-openapi/validate): d509235108fcf6ab4913d2dcb3a2260c0db2108e
events.type: issue
events.action: created
events.author: nikhita
events.text: /kind bug
  /area custom-resources
  /sig api-machinery
events.type: comment
events.action: created
events.author: mbohlool
events.text: @nikhita it is ok to sometimes do manual cherrypicks. Please just add justification on why this is needed as a cherrypick and what is the user impact.
events.type: comment
events.action: created
events.author: cblecker
events.text: @nikhita staging godeps need to be updated here too
events.type: comment
events.action: created
events.author: jennybuckley
events.text: /cc @jpbetz
events.type: comment
events.action: created
events.author: jpbetz
events.text: Backporting this as a single commit looks fine to me. Removing hold.
events.type: comment
events.action: created
events.author: cblecker
events.text: @nikhita This still need attention (staging godeps need to be updated)
events.type: comment
events.action: created
events.author: nikhita
events.text: There is a still a discussion on how we should proceed with it. https://github.com/kubernetes/apiextensions-apiserver/issues/28#issuecomment-372751580.
  
  Until that is agreed upon, I think we should not merge this.
events.type: comment
events.action: created
events.author: cblecker
events.text: @nikhita Understood.
  /hold
events.type: comment
events.action: created
events.author: mbohlool
events.text: any update on this?
events.type: comment
events.action: created
events.author: mbohlool
events.text: Closing this in favor of #63604
events.type: comment
data_with_bots.bot: @nikhita: The following test **failed**, say `/retest` to rerun them all:
  
  Test name | Commit | Details | Rerun command
  --- | --- | --- | ---
  pull-kubernetes-e2e-kops-aws | 65b2ec140712a9d6bf28311dea3c8ff54201451b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/61106/pull-kubernetes-e2e-kops-aws/79319/) | `/test pull-kubernetes-e2e-kops-aws`
  
  [Full PR test history](https://k8s-gubernator.appspot.com/pr/61106). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/nikhita). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.
  
  <details>
  
  Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
  </details>
  <!-- test report -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *nikhita*:
data_with_bots.text: /kind bug
  /area custom-resources
  /sig api-machinery
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *nikhita*:
data_without_bots.text: /kind bug
  /area custom-resources
  /sig api-machinery