events.action: opened
events.author: liyinan926
events.text: **What this PR does / why we need it**:
  This PR setup and added initial integration tests for the DaemonSet controller. All tests included were ported from their unit test counterparts that currently use fake client, informers, reactor, etc. 
  
  **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: #52191.
  
  **Special notes for your reviewer**:
  @kow3ns 
  
  **Release note**:
  ```release-note
  NONE
  ```
events.title: Initial integration test setup for DaemonSet controller
events.type: issue
events.action: created
events.author: liyinan926
events.text: /unassign @bowei
  /unassign @ixdy
  /assign @kow3ns
events.type: comment
events.action: created
events.author: xiangpengzhao
events.text: /ok-to-test
events.type: comment
events.action: created
events.author: liyinan926
events.text: /retest
events.type: comment
events.action: created
events.author: liyinan926
events.text: /retest
events.type: comment
events.action: created
events.author: liyinan926
events.text: @kow3ns can you take a look?
events.type: comment
events.action: created
events.author: liyinan926
events.text: @kow3ns this is the PR I mentioned.
events.type: comment
events.action: created
events.author: liyinan926
events.text: /retest
events.type: comment
events.action: created
events.author: kow3ns
events.text: /approve
events.type: comment
events.action: created
events.author: liyinan926
events.text: Updated the BUILD file.
events.type: comment
events.action: created
events.author: liyinan926
events.text: /assign @mikedanese
events.type: comment
events.action: created
events.author: cjwagner
events.text: /retest
events.type: comment
events.action: created
events.author: xiangpengzhao
events.text: ```
  I1027 00:16:13.422] Verifying hack/make-rules/../../hack/verify-bazel.sh
  I1027 00:16:31.893] diff -Naupr /go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD /tmp/verify-bazel.xWgF3c/go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD
  I1027 00:16:31.893] --- /go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD	2017-10-27 00:10:16.262995885 +0000
  I1027 00:16:31.893] +++ /tmp/verify-bazel.xWgF3c/go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD	2017-10-27 00:16:25.471230559 +0000
  I1027 00:16:31.894] @@ -15,7 +15,6 @@ go_test(
  I1027 00:16:31.894]      importpath = "k8s.io/kubernetes/test/integration/daemonset",
  I1027 00:16:31.894]      tags = ["integration"],
  I1027 00:16:31.894]      deps = [
  I1027 00:16:31.894] -        "//pkg/api:go_default_library",
  I1027 00:16:31.894]          "//pkg/api/v1/pod:go_default_library",
  I1027 00:16:31.895]          "//pkg/controller/daemon:go_default_library",
  I1027 00:16:31.895]          "//test/integration/framework:go_default_library",
  I1027 00:16:31.895] 
  I1027 00:16:31.895] Run ./hack/update-bazel.sh
  I1027 00:16:32.636] FAILED   hack/make-rules/../../hack/verify-bazel.sh	19s
  ```
events.type: comment
events.action: created
events.author: liyinan926
events.text: Fixed the bazel build file.
events.type: comment
events.action: created
events.author: liyinan926
events.text: @mikedanese Can you take a look? Thanks!
events.type: comment
events.action: created
events.author: mikedanese
events.text: /approve
events.type: comment
data_with_bots.bot: @liyinan926: The following test **failed**, say `/retest` to rerun them all:
  
  Test name | Commit | Details | Rerun command
  --- | --- | --- | ---
  pull-kubernetes-federation-e2e-gce | 28e06c7efcc6942ea7e53f4a9b5932b226e5d752 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26313/) | `/test pull-kubernetes-federation-e2e-gce`
  
  [Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.
  
  <details>
  
  Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
  </details>
  <!-- test report -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *xiangpengzhao*:
data_with_bots.text: /ok-to-test
data_with_bots.bot: @liyinan926: The following tests **failed**, say `/retest` to rerun them all:
  
  Test name | Commit | Details | Rerun command
  --- | --- | --- | ---
  pull-kubernetes-federation-e2e-gce | 28e06c7efcc6942ea7e53f4a9b5932b226e5d752 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26313/) | `/test pull-kubernetes-federation-e2e-gce`
  pull-kubernetes-e2e-gce-etcd3 | 28e06c7efcc6942ea7e53f4a9b5932b226e5d752 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-e2e-gce-etcd3/53455/) | `/test pull-kubernetes-e2e-gce-etcd3`
  
  [Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.
  
  <details>
  
  Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
  </details>
  <!-- test report -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:
data_with_bots.text: /retest
data_with_bots.bot: @liyinan926: The following tests **failed**, say `/retest` to rerun them all:
  
  Test name | Commit | Details | Rerun command
  --- | --- | --- | ---
  pull-kubernetes-federation-e2e-gce | c0511d2b88b595835392b90fd6a5ff2e8059a066 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26674/) | `/test pull-kubernetes-federation-e2e-gce`
  pull-kubernetes-unit | 4a1cb7ac1747ee53c197593294ed5b3159f2e1cc | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-unit/60024/) | `/test pull-kubernetes-unit`
  
  [Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.
  
  <details>
  
  Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
  </details>
  <!-- test report -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:
data_with_bots.text: @kow3ns this is the PR I mentioned.
data_with_bots.bot: @liyinan926: The following tests **failed**, say `/retest` to rerun them all:
  
  Test name | Commit | Details | Rerun command
  --- | --- | --- | ---
  pull-kubernetes-federation-e2e-gce | c0511d2b88b595835392b90fd6a5ff2e8059a066 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26674/) | `/test pull-kubernetes-federation-e2e-gce`
  pull-kubernetes-verify | 4a1cb7ac1747ee53c197593294ed5b3159f2e1cc | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-verify/57679/) | `/test pull-kubernetes-verify`
  pull-kubernetes-unit | 4a1cb7ac1747ee53c197593294ed5b3159f2e1cc | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-unit/60041/) | `/test pull-kubernetes-unit`
  
  [Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.
  
  <details>
  
  Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
  </details>
  <!-- test report -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:
data_with_bots.text: /retest
data_with_bots.bot: [APPROVALNOTIFIER] This PR is **NOT APPROVED**
  
  This pull-request has been approved by: *<a href="https://github.com/kubernetes/kubernetes/pull/52192#issuecomment-339738626" title="Approved">kow3ns</a>*, *<a href="https://github.com/kubernetes/kubernetes/pull/52192#" title="Author self-approved">liyinan926</a>*
  We suggest the following additional approver: **mikedanese**
  
  Assign the PR to them by writing `/assign @mikedanese` in a comment when ready.
  
  Associated issue: *52191*
  
  The full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
  
  <details open>
  Needs approval from an approver in each of these OWNERS Files:
  
  - **[pkg/controller/daemon/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/OWNERS)**
  - ~~[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)~~ [kow3ns]
  
  You can indicate your approval by writing `/approve` in a comment
  You can cancel your approval by writing `/approve cancel` in a comment
  </details>
  <!-- META={"approvers":["mikedanese"]} -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-merge-robot* by author *kow3ns*:
data_with_bots.text: /approve
data_with_bots.bot: @liyinan926: The following tests **failed**, say `/retest` to rerun them all:
  
  Test name | Commit | Details | Rerun command
  --- | --- | --- | ---
  pull-kubernetes-federation-e2e-gce | c0511d2b88b595835392b90fd6a5ff2e8059a066 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26674/) | `/test pull-kubernetes-federation-e2e-gce`
  pull-kubernetes-unit | 84919af28b997746587b247dd417f5fbd6ce049c | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-unit/60850/) | `/test pull-kubernetes-unit`
  
  [Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.
  
  <details>
  
  Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
  </details>
  <!-- test report -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:
data_with_bots.text: /assign @mikedanese
data_with_bots.bot: @liyinan926: The following tests **failed**, say `/retest` to rerun them all:
  
  Test name | Commit | Details | Rerun command
  --- | --- | --- | ---
  pull-kubernetes-federation-e2e-gce | c0511d2b88b595835392b90fd6a5ff2e8059a066 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-federation-e2e-gce/26674/) | `/test pull-kubernetes-federation-e2e-gce`
  pull-kubernetes-unit | 81b163341045a8219ce3f7b89d8c3d8a97f77a2b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52192/pull-kubernetes-unit/60927/) | `/test pull-kubernetes-unit`
  
  [Full PR test history](https://k8s-gubernator.appspot.com/pr/52192). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/liyinan926). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.
  
  <details>
  
  Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
  </details>
  <!-- test report -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *cjwagner*:
data_with_bots.text: /retest
data_with_bots.bot: [APPROVALNOTIFIER] This PR is **APPROVED**
  
  This pull-request has been approved by: *<a href="https://github.com/kubernetes/kubernetes/pull/52192#issuecomment-339738626" title="Approved">kow3ns</a>*, *<a href="https://github.com/kubernetes/kubernetes/pull/52192#" title="Author self-approved">liyinan926</a>*, *<a href="https://github.com/kubernetes/kubernetes/pull/52192#issuecomment-340847492" title="Approved">mikedanese</a>*
  
  Associated issue: *52191*
  
  The full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
  
  <details >
  Needs approval from an approver in each of these OWNERS Files:
  
  - ~~[pkg/controller/daemon/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/OWNERS)~~ [mikedanese]
  - ~~[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)~~ [kow3ns,mikedanese]
  
  You can indicate your approval by writing `/approve` in a comment
  You can cancel your approval by writing `/approve cancel` in a comment
  </details>
  <!-- META={"approvers":[]} -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-merge-robot* by author *mikedanese*:
data_with_bots.text: /approve
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *xiangpengzhao*:
data_without_bots.text: /ok-to-test
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:
data_without_bots.text: /retest
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:
data_without_bots.text: @kow3ns this is the PR I mentioned.
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:
data_without_bots.text: /retest
data_without_bots.meta: This message directly preceded comment from bot *k8s-merge-robot* by author *kow3ns*:
data_without_bots.text: /approve
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *liyinan926*:
data_without_bots.text: /assign @mikedanese
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *cjwagner*:
data_without_bots.text: /retest
data_without_bots.meta: This message directly preceded comment from bot *k8s-merge-robot* by author *mikedanese*:
data_without_bots.text: /approve