events.action: opened
events.author: sebastienvas
events.text: Remove all the persistent volumes things, since we have using CRDs for more than a year now.
events.title: Update boskos stateful set to use RollingUpdate (default @v1)
events.type: issue
events.action: created
events.author: sebastienvas
events.text: /assign @Katharine
events.type: comment
events.action: created
events.author: krzyzacy
events.text: /lgtm
  /hold
events.type: comment
events.action: created
events.author: krzyzacy
events.text: (feel free to hold cancel when you are around)
events.type: comment
events.action: created
events.author: sebastienvas
events.text: is this going to auto deploy ?
  I don't think I have access to that cluster
events.type: comment
events.action: created
events.author: Katharine
events.text: I don't believe this will auto-deploy. Oncall (currently @mirandachrist) should probably deploy this after it merges.
events.type: comment
events.action: created
events.author: stevekuznetsov
events.text: Why isn't `boskos` a Deployment?
events.type: comment
events.action: created
events.author: sebastienvas
events.text: Good point. However in order to deploy this we want to make sure the stateful set is deleted before. Not sure how on call wants to handle this.
events.type: comment
events.action: created
events.author: stevekuznetsov
events.text: I think it would be best to list the `kubectl` commands you expect here so that on-call can just execute them and post the output. I think we'd want to manually delete the StatefulSet, then the PV, then apply the Deployment.
events.type: comment
events.action: created
events.author: sebastienvas
events.text: correct:
  kubectl delete -n test-pods statefulset boskos
  wait for pod to be gone
  kubectl delete -n test-pods pv boskos-storage
  kubectl apply -f boskos/deployment.yaml
events.type: comment
events.action: created
events.author: chases2
events.text: /hold cancel
  /lgtm
events.type: comment
events.action: created
events.author: chases2
events.text: In order to remove the persistent volume, the persistent volume claim also needed to be removed. On the k8s build cluster, this was named `boskos-volume-boskos-0`.
  
  ```
  statefulset.apps "boskos" deleted
  
  persistentvolume "boskos-storage" deleted
  
  clusterrole.rbac.authorization.k8s.io/boskos unchanged
  serviceaccount/boskos unchanged
  clusterrolebinding.rbac.authorization.k8s.io/crd-creator unchanged
  deployment.apps/boskos created
  ```
  
  ```
  kubectl delete -n test-pods pvc boskos-volume-boskos-0
  persistentvolumeclaim "boskos-volume-boskos-0" deleted
  ```
events.type: comment
events.action: created
events.author: sebastienvas
events.text: Thanks @chases2
events.type: comment
data_with_bots.bot: LGTM label has been added.  <details>Git tree hash: 8320f0242159894b11361ebbdba0d02a25bd5932</details>
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:
data_with_bots.text: /lgtm
  /hold
data_with_bots.bot: New changes are detected. LGTM label has been removed.
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *stevekuznetsov*:
data_with_bots.text: Why isn't `boskos` a Deployment?
data_with_bots.bot: LGTM label has been added.  <details>Git tree hash: 81241b6b27cebb3c40a214c02f7719749d3948e4</details>
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *chases2*:
data_with_bots.text: /hold cancel
  /lgtm
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:
data_without_bots.text: /lgtm
  /hold
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *stevekuznetsov*:
data_without_bots.text: Why isn't `boskos` a Deployment?
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *chases2*:
data_without_bots.text: /hold cancel
  /lgtm