events.action: opened
events.author: friedaxvictoria
events.text: Before: The user could only view their bookmarked people on the dashboard.
  
  Now: User can switch between their team and bookmarks. If the user doesn't have any bookmarks, the dashboard will automatically display the team and next to the dashboard button it says how to bookmark somebody. Otherwise, the bookmarks are the default view. If the user isn't logged in, there won't be the option to look at the team. 
  
  Open question: Currently, the team is displayed in the following order: supervisor, assistents, employees, and learners. Should we add subheadings to showcase the different groups or leave it the way it is now?
events.title: feat(dashboard): Show Team on Dashboard
events.type: issue
events.action: created
events.author: paule96
events.text: there is a bug. If you navigate direct to https://pr-592.demo-phonebook.me/en/dashboard nothing is to see.
events.type: comment
events.action: created
events.author: DanielHabenicht
events.text: already mentioned in my comments ;)
events.type: comment
events.action: created
events.author: paule96
events.text: /azp run T-Systems-MMS.phonebook-preview
events.type: comment
events.action: created
events.author: paule96
events.text: sad demo broken. :) So I can't check the stuff..
events.type: comment
events.action: created
events.author: friedaxvictoria
events.text: For some reason the mock user doesn't work in the preview. The id that I used is a person and can be found in the preview but unfortunately it doesn't register as the user which is the reason why you can't see the team...
events.type: comment
events.action: created
events.author: friedaxvictoria
events.text: @DanielHabenicht Do you know how I can define a Mock UserTreeNode[] and not a UserTreeNode to compare with the Mock Person's OrgUnit?
events.type: comment
events.action: created
events.author: DanielHabenicht
events.text: Just use `Partial<UserTreeNode>`
events.type: comment
events.action: created
events.author: friedaxvictoria
events.text: To use it in getNodeForUser(user, organigram, 0), the organigram needs to be a UnitTreeNode[]. It doesn't accept Partial <UnitTreeNode>.
events.type: comment
events.action: created
events.author: DanielHabenicht
events.text: Then just cast it to UserTreeNode:
  
  Your Object `as UserTreeNode[]`
events.type: comment
events.action: created
events.author: friedaxvictoria
events.text: Doesn't really work either. The only version that isn't an error is organigram: UnitTreeNode[] = []. I don't know whether that will work though because there is an error with the user as well. I copied a mock person's data and the data itself seems to be fine but apparently the Person is missing properties (isLearner, isSupervisor, isAssistent, isOfStatus). However, these 'properties' are functions from Person.ts and I can't add them to the Mock Person.
events.type: comment
events.action: created
events.author: paule96
events.text: /azbot
events.type: comment
events.action: created
events.author: paule96
events.text: /az
events.type: comment
events.action: created
events.author: mschwrdtnr
events.text: /azp run T-Systems-MMS.phonebook-preview
events.type: comment
events.action: created
events.author: paule96
events.text: This stuff is broken?
  
  ![image](https://user-images.githubusercontent.com/11291885/80919156-d0f42d80-8d68-11ea-985a-28020fdd2b82.png)
events.type: comment
events.action: created
events.author: paule96
events.text: also this switch doesn't working:
  
  ![image](https://user-images.githubusercontent.com/11291885/80919162-dea9b300-8d68-11ea-8bcb-f727de22d7e8.png)
events.type: comment
events.action: created
events.author: friedaxvictoria
events.text: @paule96 My cards aren't broken. There is a bit of an issue with the small cards, though. I'll see what I can do about that. 
  The switch only works for the booksmarks so far. Should we implement it for the team as well @DanielHabenicht?
events.type: comment
events.action: created
events.author: friedaxvictoria
events.text: The Layout switch should now be working for the team as well. If you don't want that we can change it back although I would hide the button when the team is on display if this is the case. Otherwise, I think it would get to confusing. 
  
  The cards also shouldn't spread out anymore. Furthermore, I had to add another if-statement to the organigram.service.ts since it only checked the first node of every depth. If the user is in the second or third node, it would return null. @DanielHabenicht
events.type: comment
events.action: created
events.author: paule96
events.text: no it's looks good 👍 I will start reviewing this code to night.
events.type: comment
events.action: created
events.author: DanielHabenicht
events.text: @friedaxvictoria waiting for merge
events.type: comment
events.action: created
events.author: DanielHabenicht
events.text: do you? @paule96
events.type: comment
events.action: created
events.author: friedaxvictoria
events.text: The function getUnitTreeById() has been added and it works when the UnitTreeNodes have been loaded. At the moment, the dashboard is finished loading before the UnitTreeNodes are. Therefore, the getUnitTreeById() is emty and doesn't return the user's UnitTreeNode. It is just a matter of getting the nodes before returning the dashboard.
events.type: comment
events.action: created
events.author: DanielHabenicht
events.text: forgot to push functions are still not there
events.type: comment
events.action: created
events.author: friedaxvictoria
events.text: I added the function and deleted some imports. However, I can’t check in localhost whether everything is all right because I can’t seem to get localhost to work in my browser...
events.type: comment
events.action: created
events.author: DanielHabenicht
events.text: /azp run T-Systems-MMS.phonebook-preview
events.type: comment
events.action: created
events.author: mschwrdtnr
events.text: @paule96 Please test it again locally
events.type: comment
events.action: created
events.author: DanielHabenicht
events.text: /azp run T-Systems-MMS.phonebook-preview
events.type: comment
events.action: created
events.author: paule96
events.text: /azp run T-Systems-MMS.phonebook-preview
events.type: comment
events.action: created
events.author: DanielHabenicht
events.text: Preview is not working at the moment ;(
events.type: comment
events.action: created
events.author: DanielHabenicht
events.text: /azp run T-Systems-MMS.phonebook-preview
events.type: comment
data_with_bots.bot: <samp>
  Azure Pipelines successfully started running 1 pipeline(s).<br>
  
  </samp>
data_with_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *paule96*:
data_with_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_with_bots.bot: Preview Environment ready at https://pr-592.demo-phonebook.me
data_with_bots.meta: This message directly preceded comment from bot *mmsgithub-ci* by author *paule96*:
data_with_bots.text: sad demo broken. :) So I can't check the stuff..
data_with_bots.bot: <samp>
  Azure Pipelines successfully started running 1 pipeline(s).<br>
  
  </samp>
data_with_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *mschwrdtnr*:
data_with_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_with_bots.bot: Preview Environment ready at https://pr-592.demo-phonebook.me
data_with_bots.meta: This message directly preceded comment from bot *mmsgithub-ci* by author *DanielHabenicht*:
data_with_bots.text: @friedaxvictoria waiting for merge
data_with_bots.bot: <samp>
  Azure Pipelines successfully started running 1 pipeline(s).<br>
  
  </samp>
data_with_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *DanielHabenicht*:
data_with_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_with_bots.bot: <samp>
  Azure Pipelines successfully started running 1 pipeline(s).<br>
  
  </samp>
data_with_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *DanielHabenicht*:
data_with_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_with_bots.bot: <samp>
  Azure Pipelines successfully started running 1 pipeline(s).<br>
  
  </samp>
data_with_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *paule96*:
data_with_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_with_bots.bot: <samp>
  Azure Pipelines successfully started running 1 pipeline(s).<br>
  
  </samp>
data_with_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *DanielHabenicht*:
data_with_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_without_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *paule96*:
data_without_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_without_bots.meta: This message directly preceded comment from bot *mmsgithub-ci* by author *paule96*:
data_without_bots.text: sad demo broken. :) So I can't check the stuff..
data_without_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *mschwrdtnr*:
data_without_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_without_bots.meta: This message directly preceded comment from bot *mmsgithub-ci* by author *DanielHabenicht*:
data_without_bots.text: @friedaxvictoria waiting for merge
data_without_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *DanielHabenicht*:
data_without_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_without_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *DanielHabenicht*:
data_without_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_without_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *paule96*:
data_without_bots.text: /azp run T-Systems-MMS.phonebook-preview
data_without_bots.meta: This message directly preceded comment from bot *azure-pipelines[bot]* by author *DanielHabenicht*:
data_without_bots.text: /azp run T-Systems-MMS.phonebook-preview