events.action: opened
events.author: SataQiu
events.text: <!--  Thanks for sending a pull request!  Here are some tips for you:
  
  1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:
  https://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label
  3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md
  4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  -->
  
  **What type of PR is this?**
  
  /kind cleanup
  
  **What this PR does / why we need it**:
  Refactor k8s.io/kubernetes/pkg/version -> k8s.io/client-go/pkg/version
  
  **Which issue(s) this PR fixes**:
  <!--
  *Automatically closes linked issue when PR is merged.
  Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
  _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
  -->
  Ref kubernetes/kubeadm#1600
  
  **Special notes for your reviewer**:
  
  **Does this PR introduce a user-facing change?**:
  <!--
  If no, just write "NONE" in the release-note block below.
  If yes, a release note is required:
  Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
  -->
  ```release-note
  NONE
  ```
events.title: [kubeadm] refactor k8s.io/kubernetes/pkg/version -> k8s.io/client-go/pkg/version
events.type: issue
events.action: created
events.author: SataQiu
events.text: /hold
  @yagonobre 
  Thanks! I will try to add more changes.
events.type: comment
events.action: created
events.author: neolit123
events.text: /priority backlog
  /approve
events.type: comment
events.action: created
events.author: SataQiu
events.text: /test pull-kubernetes-bazel-test
events.type: comment
events.action: created
events.author: SataQiu
events.text: /test pull-kubernetes-bazel-build
events.type: comment
events.action: created
events.author: SataQiu
events.text: /test pull-kubernetes-e2e-gce-device-plugin-gpu
  /test pull-kubernetes-integration
  /test pull-kubernetes-kubemark-e2e-gce-big
events.type: comment
events.action: created
events.author: SataQiu
events.text: /test pull-kubernetes-bazel-build
events.type: comment
events.action: created
events.author: SataQiu
events.text: /hold cancel
events.type: comment
events.action: created
events.author: SataQiu
events.text: /test pull-kubernetes-e2e-gce-device-plugin-gpu
events.type: comment
events.action: created
events.author: SataQiu
events.text: /assign @fejta
events.type: comment
events.action: created
events.author: SataQiu
events.text: @neolit123 What puzzles me is how do we resolve the dependency on pkg/version for cmd/kubeadm/BUILD
events.type: comment
events.action: created
events.author: SataQiu
events.text: /unassign @fejta
events.type: comment
events.action: created
events.author: SataQiu
events.text: @neolit123  Updated!
events.type: comment
events.action: created
events.author: SataQiu
events.text: @rosti Could you please look at it again?
events.type: comment
events.action: created
events.author: neolit123
events.text: /retest
events.type: comment
events.action: created
events.author: neolit123
events.text: /retest
events.type: comment
data_with_bots.bot: [APPROVALNOTIFIER] This PR is **APPROVED**
  
  This pull-request has been approved by: *<a href="https://github.com/kubernetes/kubernetes/pull/78929#issuecomment-502107966" title="Approved">neolit123</a>*, *<a href="https://github.com/kubernetes/kubernetes/pull/78929#" title="Author self-approved">SataQiu</a>*
  
  The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).
  
  The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)
  
  <details >
  Needs approval from an approver in each of these files:
  
  - ~~[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)~~ [neolit123]
  
  Approvers can indicate their approval by writing `/approve` in a comment
  Approvers can cancel approval by writing `/approve cancel` in a comment
  </details>
  <!-- META={"approvers":[]} -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *neolit123*:
data_with_bots.text: /priority backlog
  /approve
data_with_bots.bot: @SataQiu: The following tests **failed**, say `/retest` to rerun them all:
  
  Test name | Commit | Details | Rerun command
  --- | --- | --- | ---
  pull-kubernetes-integration | 50048a4c0973c606a5672ae70d9e8f0425e80dba | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/78929/pull-kubernetes-integration/1139913839949647872/) | `/test pull-kubernetes-integration`
  pull-kubernetes-e2e-gce-device-plugin-gpu | 50048a4c0973c606a5672ae70d9e8f0425e80dba | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/78929/pull-kubernetes-e2e-gce-device-plugin-gpu/1139913839966425088/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`
  
  [Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=78929). [Your PR dashboard](https://gubernator.k8s.io/pr/SataQiu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.
  
  <details>
  
  Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
  </details>
  <!-- test report -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *SataQiu*:
data_with_bots.text: /test pull-kubernetes-bazel-test
data_with_bots.bot: [APPROVALNOTIFIER] This PR is **APPROVED**
  
  This pull-request has been approved by: *<a href="https://github.com/kubernetes/kubernetes/pull/78929#issuecomment-502107966" title="Approved">neolit123</a>*, *<a href="https://github.com/kubernetes/kubernetes/pull/78929#" title="Author self-approved">SataQiu</a>*
  
  The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).
  
  The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)
  
  <details >
  Needs approval from an approver in each of these files:
  
  - ~~[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)~~ [neolit123]
  
  Approvers can indicate their approval by writing `/approve` in a comment
  Approvers can cancel approval by writing `/approve cancel` in a comment
  </details>
  <!-- META={"approvers":[]} -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *SataQiu*:
data_with_bots.text: @neolit123 What puzzles me is how do we resolve the dependency on pkg/version for cmd/kubeadm/BUILD
data_with_bots.bot: @SataQiu: The following test **failed**, say `/retest` to rerun them all:
  
  Test name | Commit | Details | Rerun command
  --- | --- | --- | ---
  pull-kubernetes-integration | 10ddd7caf04c91d23191a209e228f077efbff3a5 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/78929/pull-kubernetes-integration/1143101076514279426/) | `/test pull-kubernetes-integration`
  
  [Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=78929). [Your PR dashboard](https://gubernator.k8s.io/pr/SataQiu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.
  
  <details>
  
  Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
  </details>
  <!-- test report -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *SataQiu*:
data_with_bots.text: @rosti Could you please look at it again?
data_with_bots.bot: @SataQiu: The following test **failed**, say `/retest` to rerun them all:
  
  Test name | Commit | Details | Rerun command
  --- | --- | --- | ---
  pull-kubernetes-integration | 10ddd7caf04c91d23191a209e228f077efbff3a5 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/78929/pull-kubernetes-integration/1143150019726020608/) | `/test pull-kubernetes-integration`
  
  [Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=78929). [Your PR dashboard](https://gubernator.k8s.io/pr/SataQiu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.
  
  <details>
  
  Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
  </details>
  <!-- test report -->
data_with_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *neolit123*:
data_with_bots.text: /retest
data_with_bots.bot: /retest
  This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to [fejta](https://github.com/fejta)).
  
  Review the [full test history](https://gubernator.k8s.io/pr/78929) for this PR.
  
  Silence the bot with an `/lgtm cancel` or `/hold` comment for consistent failures.
data_with_bots.meta: This message directly preceded comment from bot *fejta-bot* by author *neolit123*:
data_with_bots.text: /retest
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *neolit123*:
data_without_bots.text: /priority backlog
  /approve
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *SataQiu*:
data_without_bots.text: /test pull-kubernetes-bazel-test
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *SataQiu*:
data_without_bots.text: @neolit123 What puzzles me is how do we resolve the dependency on pkg/version for cmd/kubeadm/BUILD
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *SataQiu*:
data_without_bots.text: @rosti Could you please look at it again?
data_without_bots.meta: This message directly preceded comment from bot *k8s-ci-robot* by author *neolit123*:
data_without_bots.text: /retest
data_without_bots.meta: This message directly preceded comment from bot *fejta-bot* by author *neolit123*:
data_without_bots.text: /retest