opened
verult
Cherry pick of #71681 on release-1.11.

#71681: Add e2e test for file exec
Automated cherry pick of #71681: Add e2e test for file exec
issue
created
verult
/kind bug
/priority important-soon
/assign @msau42 
/sig storage
comment
created
verult
This is adding a new test case for a bug found with certain kernel versions.

/assign @foxish
comment
created
verult
Addressed comments
comment
created
foxish
@msau42, is this good to go?
comment
created
verult
Fixed the gofmt error, but I'm not sure where the bazel build error came from. Maybe a flake?

@msau42 btw I changed the test image from Nginx to NginxSlim (since the former isn't defined in 1.11). Also simplified the test function a bit by removing the bits tailored to the new e2e testing framework
comment
created
msau42
/lgtm
/approve
comment
created
verult
@foxish good to go!
comment
[APPROVALNOTIFIER] This PR is **NOT APPROVED**

This pull-request has been approved by: *<a href="https://github.com/kubernetes/kubernetes/pull/72795#" title="Author self-approved">verult</a>*
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: **foxish**

If they are not already assigned, you can assign the PR to them by writing `/assign @foxish` in a comment when ready.

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details open>
Needs approval from an approver in each of these files:

- **[test/e2e/storage/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.11/test/e2e/storage/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["foxish"]} -->
This message directly preceded comment from bot *k8s-ci-robot* by author *verult*:
Addressed comments
[APPROVALNOTIFIER] This PR is **NOT APPROVED**

This pull-request has been approved by: *<a href="https://github.com/kubernetes/kubernetes/pull/72795#" title="Author self-approved">verult</a>*
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: **foxish**

If they are not already assigned, you can assign the PR to them by writing `/assign @foxish` in a comment when ready.

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details open>
Needs approval from an approver in each of these files:

- **[test/e2e/storage/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.11/test/e2e/storage/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["foxish"]} -->
This message directly preceded comment from bot *k8s-ci-robot* by author *foxish*:
@msau42, is this good to go?
[APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/kubernetes/kubernetes/pull/72795#issuecomment-453690350" title="Approved">msau42</a>*, *<a href="https://github.com/kubernetes/kubernetes/pull/72795#" title="Author self-approved">verult</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[test/e2e/storage/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.11/test/e2e/storage/OWNERS)~~ [msau42]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->
This message directly preceded comment from bot *k8s-ci-robot* by author *msau42*:
/lgtm
/approve
This message directly preceded comment from bot *k8s-ci-robot* by author *verult*:
Addressed comments
This message directly preceded comment from bot *k8s-ci-robot* by author *foxish*:
@msau42, is this good to go?
This message directly preceded comment from bot *k8s-ci-robot* by author *msau42*:
/lgtm
/approve