opened
vikaschoudhary16
openshift/kubernetes-drain got updated to list daemonsets as part of `apps` group: https://github.com/openshift/kubernetes-drain/commit/97b0f2710aa6579a688c834e4c2c919adf1912d0#diff-b35cc60e9fab98b13f2a1f43795d4d00

Accordingly cluster-role should be updated. Otherwise we get error like this on Drain():
```
daemonsets.apps "node-ca" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-image-registry": node-ca-sc9p8; daemonsets.apps "machine-config-daemon" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-machine-config-operator": machine-config-daemon-zd5j9; daemonsets.apps "node-exporter" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-monitoring": node-exporter-xnc6f; daemonsets.apps "multus" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-multus": multus-fc6jv; daemonsets.apps "ovs" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-sdn": ovs-f49pj; daemonsets.apps "sdn" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-sdn": sdn-b79c2; daemonsets.apps "tuned" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-cluster-node-tuning-operator": tuned-xzgzh; daemonsets.apps "dns-default" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-controllers" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-dns": dns-default-c495j
```

This PR is required to get the CI green on https://github.com/openshift/cluster-api-provider-aws/pull/243
Modify machine-api-controller clusterrole for daemonsets
issue
created
enxebre
/approve
comment
created
frobware
/lgtm
comment
created
frobware
/lgtm
comment
created
frobware
/lgtm cancel
comment
created
ingvagabund
/lgtm
comment
created
enxebre
/cherrypick release-4.1
comment
[APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/openshift/machine-api-operator/pull/366#issuecomment-516308917" title="Approved">enxebre</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=openshift%2Fmachine-api-operator).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[OWNERS](https://github.com/openshift/machine-api-operator/blob/master/OWNERS)~~ [enxebre]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->
This message directly preceded comment from bot *openshift-ci-robot* by author *enxebre*:
/approve
@vikaschoudhary16: The following test **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
ci/prow/e2e-aws-operator | 0790249b26deb5d6fbf4bcfb6d8858cbc50e04cc | [link](https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_machine-api-operator/366/pull-ci-openshift-machine-api-operator-master-e2e-aws-operator/1228) | `/test e2e-aws-operator`

[Full PR test history](https://prow.svc.ci.openshift.org/pr-history?org=openshift&repo=machine-api-operator&pr=366). [Your PR dashboard](https://prow.svc.ci.openshift.org/pr?query=is:pr+state:open+author:vikaschoudhary16). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/machine-api-operator/issues?q=is:issue+is:open) when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
This message directly preceded comment from bot *openshift-ci-robot* by author *frobware*:
/lgtm
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
</details>
This message directly preceded comment from bot *openshift-cherrypick-robot* by author *enxebre*:
/cherrypick release-4.1
This message directly preceded comment from bot *openshift-ci-robot* by author *enxebre*:
/approve
This message directly preceded comment from bot *openshift-ci-robot* by author *frobware*:
/lgtm
This message directly preceded comment from bot *openshift-cherrypick-robot* by author *enxebre*:
/cherrypick release-4.1