opened
dalanlan
Fix #17205
[ubuntu] fix etcd flag 
issue
created
dalanlan
ping @davidopp
comment
created
davidopp
@resouer @yichengq @xiang90
comment
created
resouer
I did not see error in kube-in-docker, but as #17422 was in. I'm ok with this.
comment
created
dalanlan
Based on @xiang90 's comment, i think it would be fine to set `advertise-client-urls` 
- 1. http://${master_ip}:4001
- 2. http://127.0.0.1:4001, given that there is single etcd, and `--no-sync` for `etcdctl` 
I'm comfortable with either and adopt option 1 for now.
comment
created
resouer
lgtm  cc @davidopp
comment
created
davidopp
LGTM
comment
Labelling this PR as size/S
This message directly preceded comment from bot *k8s-merge-robot* by author *resouer*:
I did not see error in kube-in-docker, but as #17422 was in. I'm ok with this.
Automatic merge from submit-queue
This message directly preceded comment from bot *k8s-merge-robot* by author *davidopp*:
LGTM
This message directly preceded comment from bot *k8s-merge-robot* by author *resouer*:
I did not see error in kube-in-docker, but as #17422 was in. I'm ok with this.
This message directly preceded comment from bot *k8s-merge-robot* by author *davidopp*:
LGTM