opened
makortel
#### PR description:

#29553 implies that all data dependencies for modules in Tasks must be specified to keep those modules alive and running (in principle the proper dependencies should be declared anyway, that PR makes it necessary also in practice). It turned out that the `DQMRootOutputModule` currently does not declare dependencies on all the DQM analyzers. Easiest fix is to do `consumesMany<DQMToken, ...>` for both Lumi and Run products.

Actually I tried first to use the `outputCommands` (which by the for some reason is
https://github.com/cms-sw/cmssw/blob/3f89112fddb9bd4f384fa7acacc5fb81720bee16/Configuration/EventContent/python/EventContent_cff.py#L356-L357
which to me doesn't seem to make much sense), but that would require making `DQMToken` persistable, which would require an underscore a forbidden character for all modules producing `DQMToken`. An underscore appears to be in wide use for DQM modules, which is why I scrapped that approach (I did some amount of migration to no-underscore module labels, if DQM is interested I can make pull request(s) of what I did).

#### PR validation:

Limited matrix runs.
Make DQMRootOutputModule to depend on all DQM modules via DQMTokens
issue
created
makortel
FYI @schneiml
comment
created
makortel
@cmsbuild, please test
comment
created
jfernan2
+1
comment
created
silviodonato
+1
comment
created
schneiml
@makortel uh, so I was wrong?

Thanks a lot, anyways!
comment
+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29586/14911

- This PR adds an extra 16KB to repository
This message directly preceded comment from bot *cmsbuild* by author *makortel*:
FYI @schneiml
The tests are being triggered in jenkins.
This message directly preceded comment from bot *cmsbuild* by author *makortel*:
@cmsbuild, please test
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)
This message directly preceded comment from bot *cmsbuild* by author *jfernan2*:
+1
This message directly preceded comment from bot *cmsbuild* by author *makortel*:
FYI @schneiml
This message directly preceded comment from bot *cmsbuild* by author *makortel*:
@cmsbuild, please test
This message directly preceded comment from bot *cmsbuild* by author *jfernan2*:
+1