opened
sebastienvas
Remove all the persistent volumes things, since we have using CRDs for more than a year now.
Update boskos stateful set to use RollingUpdate (default @v1)
issue
created
sebastienvas
/assign @Katharine
comment
created
krzyzacy
/lgtm
/hold
comment
created
krzyzacy
(feel free to hold cancel when you are around)
comment
created
sebastienvas
is this going to auto deploy ?
I don't think I have access to that cluster
comment
created
Katharine
I don't believe this will auto-deploy. Oncall (currently @mirandachrist) should probably deploy this after it merges.
comment
created
stevekuznetsov
Why isn't `boskos` a Deployment?
comment
created
sebastienvas
Good point. However in order to deploy this we want to make sure the stateful set is deleted before. Not sure how on call wants to handle this.
comment
created
stevekuznetsov
I think it would be best to list the `kubectl` commands you expect here so that on-call can just execute them and post the output. I think we'd want to manually delete the StatefulSet, then the PV, then apply the Deployment.
comment
created
sebastienvas
correct:
kubectl delete -n test-pods statefulset boskos
wait for pod to be gone
kubectl delete -n test-pods pv boskos-storage
kubectl apply -f boskos/deployment.yaml
comment
created
chases2
/hold cancel
/lgtm
comment
created
chases2
In order to remove the persistent volume, the persistent volume claim also needed to be removed. On the k8s build cluster, this was named `boskos-volume-boskos-0`.

```
statefulset.apps "boskos" deleted

persistentvolume "boskos-storage" deleted

clusterrole.rbac.authorization.k8s.io/boskos unchanged
serviceaccount/boskos unchanged
clusterrolebinding.rbac.authorization.k8s.io/crd-creator unchanged
deployment.apps/boskos created
```

```
kubectl delete -n test-pods pvc boskos-volume-boskos-0
persistentvolumeclaim "boskos-volume-boskos-0" deleted
```
comment
created
sebastienvas
Thanks @chases2
comment
LGTM label has been added.  <details>Git tree hash: 8320f0242159894b11361ebbdba0d02a25bd5932</details>
This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:
/lgtm
/hold
New changes are detected. LGTM label has been removed.
This message directly preceded comment from bot *k8s-ci-robot* by author *stevekuznetsov*:
Why isn't `boskos` a Deployment?
LGTM label has been added.  <details>Git tree hash: 81241b6b27cebb3c40a214c02f7719749d3948e4</details>
This message directly preceded comment from bot *k8s-ci-robot* by author *chases2*:
/hold cancel
/lgtm
This message directly preceded comment from bot *k8s-ci-robot* by author *krzyzacy*:
/lgtm
/hold
This message directly preceded comment from bot *k8s-ci-robot* by author *stevekuznetsov*:
Why isn't `boskos` a Deployment?
This message directly preceded comment from bot *k8s-ci-robot* by author *chases2*:
/hold cancel
/lgtm