opened
itaysk
implements https://github.com/istio/api/pull/709
fix https://github.com/istio/istio/issues/9595
New header manipulation API
issue
created
rshriram
/ok-to-test
comment
created
rshriram
High level comment: if the appendFlag was recently introduced (after Istio 1.0, which is most likely), please guard the config generation pieces with a proxy version check, so that for 1.0 proxies, its only append/remove, while for 1.1 proxies, its set/append/remove [if and only if this functionality didn't exist by Istio 1.0 (around June).
comment
created
GregHanson
/test e2e-dashboard
comment
created
GregHanson
/test e2e-dashboard
comment
created
rshriram
Can you sync your branch to release 1.1 fully and see if the test failure goes away?

@douglas-Reid any idea why this dashboard test is failing for unrelated code?
comment
created
itaysk
Rebased
comment
created
GregHanson
/approve
/lgtm
comment
created
hklai
/retest
comment
created
GregHanson
/test e2e-dashboard
comment
created
GregHanson
/test istio-pilot-e2e-envoyv2-v1alpha3
comment
@itaysk: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
prow//e2e-simpleTests-minProfile.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/e2e-simpleTestsMinProfile/182) | `/test e2e-simpleTestsMinProfile`
prow/istio-pilot-multicluster-e2e.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/istio-pilot-multicluster-e2e/5648) | `/test istio-pilot-multicluster-e2e`
prow/e2e-dashboard.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/e2e-dashboard/8703) | `/test e2e-dashboard`



<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
This message directly preceded comment from bot *istio-testing* by author *GregHanson*:
/test e2e-dashboard
@itaysk: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
prow//e2e-simpleTests-minProfile.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/e2e-simpleTestsMinProfile/182) | `/test e2e-simpleTestsMinProfile`
prow/istio-pilot-multicluster-e2e.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/istio-pilot-multicluster-e2e/5648) | `/test istio-pilot-multicluster-e2e`
prow/e2e-dashboard.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/e2e-dashboard/8725) | `/test e2e-dashboard`



<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
This message directly preceded comment from bot *istio-testing* by author *GregHanson*:
/test e2e-dashboard
[APPROVALNOTIFIER] This PR is **APPROVED**

This pull-request has been approved by: *<a href="https://github.com/istio/istio/pull/10233#issuecomment-445032848" title="LGTM">GregHanson</a>*, *<a href="https://github.com/istio/istio/pull/10233#" title="Author self-approved">itaysk</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- ~~[pilot/OWNERS](https://github.com/istio/istio/blob/release-1.1/pilot/OWNERS)~~ [GregHanson]
- ~~[tests/e2e/tests/pilot/OWNERS](https://github.com/istio/istio/blob/release-1.1/tests/e2e/tests/pilot/OWNERS)~~ [GregHanson]

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->
This message directly preceded comment from bot *istio-testing* by author *GregHanson*:
/approve
/lgtm
/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Review the [full test history](https://k8s-gubernator.appspot.com/jobs/istio-prow/pr-logs/pull/istio_istio/10233) for this PR.
`/lgtm cancel` will stop retrying.
This message directly preceded comment from bot *istio-release-robot* by author *hklai*:
/retest
@itaysk: The following tests **failed**, say `/retest` to rerun them all:

Test name | Commit | Details | Rerun command
--- | --- | --- | ---
prow//e2e-simpleTests-minProfile.sh | 43329fd55bf8648a5ceef2b8f0a5b578a7e42b3a | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/e2e-simpleTestsMinProfile/182) | `/test e2e-simpleTestsMinProfile`
prow/istio-pilot-e2e-envoyv2-v1alpha3.sh | 278c98e7240c3cc348ef2569bbf1816359dd218f | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/10233/istio-pilot-e2e-envoyv2-v1alpha3/12112) | `/test istio-pilot-e2e-envoyv2-v1alpha3`



<details>

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
</details>
<!-- test report -->
This message directly preceded comment from bot *istio-testing* by author *GregHanson*:
/test e2e-dashboard
This message directly preceded comment from bot *istio-testing* by author *GregHanson*:
/test e2e-dashboard
This message directly preceded comment from bot *istio-testing* by author *GregHanson*:
/test e2e-dashboard
This message directly preceded comment from bot *istio-testing* by author *GregHanson*:
/approve
/lgtm
This message directly preceded comment from bot *istio-release-robot* by author *hklai*:
/retest
This message directly preceded comment from bot *istio-testing* by author *GregHanson*:
/test e2e-dashboard