opened
Ladas
Service should load all_vms from nested services

Then parent service page shows all vms of all nested services, which is a nice overview.
Service should load all_vms from nested services
issue
created
Ladas
@bzwei @gmcculloug if you have any insight guys, it would be nice. Point is to see all VMs in the top level service.
comment
created
bzwei
cc @kbrock
comment
created
kbrock
Thanks bill. @ladas let's talk Monday. I would like to know where the old code was not bringing back all the vms. Sounds like you found a bug. But I'm guessing the bug is not in the call to all_vms vs direct_vms
comment
created
kbrock
:+1: with this pr.

I think the failure may be a bad test. @Ladas could you take a look at the return values and determine the underlying cause?
comment
created
Ladas
@kbrock test should be fixed now
comment
created
kbrock
@Ladas is this for darga?
comment
<rubocop />Checked commit https://github.com/Ladas/manageiq/commit/29f597bf28130d0425c7ba1d09fb299d9b5458e2 with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. :trophy:
This message directly preceded comment from bot *miq-bot* by author *Ladas*:
@kbrock test should be fixed now
This message directly preceded comment from bot *miq-bot* by author *Ladas*:
@kbrock test should be fixed now