opened
davidlange6
for comment about what clang-tidy does to CMSSW (and likely big and not mergeable - this is what clang-tidy check boost-use-to-string does on the tip of CMSSW_9_3_X as of a few days ago
clang check boost-use-to-string
issue
created
davidlange6
please test
comment
created
davidlange6
please test
comment
created
slava77
-1

this technically looks OK, but it should compile
comment
created
ianna
+1
comment
created
dmitrijus
+1
comment
created
davidlange6
please test

the compilation error seems unrelated - i wonder if it reproduces
comment
created
davidlange6
please test
comment
created
davidlange6
merge
comment
The tests are being triggered in jenkins.
This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:
please test
-1

Tested at: 294f8bfa46271bea3ae7cae33cb8b9c86d00ef04


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: 
https://github.com/cms-sw/cmssw/commit/06199984952d9a6468923f7f1e47bed589272363
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/summary.html

I found follow errors while testing this PR

**Failed tests:  Build**

* **Build**:

I found an error when building: 
 
 <pre>>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/CSCObjects/test/stubs/CSCPedestalReadAnalyzer.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Archive.h:11:0,
                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Test.h:9,
                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Alignment/test/testSerializationAlignment.cpp:1:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/eos/portable_oarchive.hpp: In function 'void testSerialization() [with T = unsigned int]':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/eos/portable_oarchive.hpp:319:17: error: 'originalObject' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    if (T temp = t)
                 ^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Alignment/test/testSerializationAlignment.cpp:1:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Test.h:55:7: note: 'originalObject' was declared here
     T originalObject;
</pre>


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: 
https://github.com/cms-sw/cmssw/commit/06199984952d9a6468923f7f1e47bed589272363
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19645/21318/git-merge-result
This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:
please test
The tests are being triggered in jenkins.
This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:
please test

the compilation error seems unrelated - i wonder if it reproduces
The tests are being triggered in jenkins.
This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:
please test
This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:
please test
This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:
please test
This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:
please test

the compilation error seems unrelated - i wonder if it reproduces
This message directly preceded comment from bot *cmsbuild* by author *davidlange6*:
please test