{"query_id": "q-en-kubernetes-8e3c1b5434af24681841213f17bfec0a8ba7d713665fc9b8d51a3bd3e2bb8fcb", "query": "A temporary workaround is to seed our random number generators. But really, apiserver should assign a guaranteed-unique identifier upon resource creation.\nInternally we use RFC4122 UUIDs for identifying pods. Any objections to making this part of the pod setup? I guess it would really be a string (like \"id\") but with the strong suggestion that it be an encoded UUID. Or we could use docker-style 256 bit randoms, but that might get confusing. If we further lock down container names to RFC1035 labels, we can use <uuid.<nameas the docker container name, which seems much nicer than the current dashes and underscores :) What think?\nBoth points sound great to me. These encoded names are just plain ugly:) Id is also a required field (network containers break otherwise), so it seems weird to have them marked as 'omitempty'. This is probably more an issue for config files than anything else.\nWas going to get familiar and try to fix this - sounds like the suggestion is to add \"ID string\" to Container, and fail PodRegistryStorage.Create() if Container.ID is empty? Or should PodRegistryStorage.Create() populate unset DesiredState.Manifest.Containers[].ID that are empty? Latter seems more flexible (server controls default UUID generation for clients)\nI started in on some validation logic this morning. It's not clear whether unique ID is something users should have to spec or not. I lean towards not. That means the master (api server?) Has to generate a uuid upon acceptance. That uuid would have to flow down to Kubelet. Is that in the same vein as you were thinking? On Jun 25, 2014 6:35 PM, \"Clayton Coleman\" wrote:\nAs an API consumer I like not having to specify things that the server can do for me - having to generate a UUID on the command line to curl a new pod into existence feels wrong. I started but didn't pass down to kubelet yet.\nOne thing to note with global unique identifier is static containers. Today we setup cAdvisor as a static container and have no way to assign it a unique ID globally. , Clayton Coleman wrote:\nStatic as in \"defined on each host via a config file\"? Would it make sense for the Kubelet to auto assign a UUID for containers pulled from files based on the host MAC and the position in the file (or a SHA1 of the contents of the manifest plus the host MAC)?\nAre you setting it up by config file? Can we generate a new uuid when we write the config file, or do we want it to be identical across machines (google prod style)? We cod do something like: if Kubelet finds a config without a uuid, it will assign it a uuid and log it. Internally we go one step further and define \"master space\" where each configuration originator can choose an ID and then manage ids within that space, meaning the master doesn't have to generate a UUID at all just a unique masterspace + pod name. Do we need to go that far? Uuids are notoriously human-hostile. On Jun 25, 2014 7:38 PM, \"Victor Marmol\" wrote:\nYes, it is a static file we leave on the machine. I don't think we have the ability to assign it a unique ID (outside of running some custom init script). Having the Kubelet assign it a UUID seems reasonable to me. , Clayton Coleman wrote:\nTo be clearer on masterspace. Each new pod gets fields such as: Masterspace: Name: \"a name unique within this masterspace\". I am sultaneously trying to argue that new should be DNS compatible, which lits them to 64 lowercase alphanums, and gives names semantic meaning. Making then bad as unique IDs. Need to think more about this... On Jun 25, 2014 7:46 PM, \"Tim Hockin\" wrote:\nI want the container names from the different sources to have different namespaces, so there won't be any collisions. E.g., kubelet prepends/appends \".etcd\" (or something) to etcd-sourced containers, \".cfg\" to containers from the config file, \".http\" to containers from the manifest url, etc. Then it is up to each source to stay unique. Api server can stay unique via uuid or counting up. Config files & manifest url stay unique by humans not screwing up; kubelet rejects them otherwise. This has the nice effect that the container name produced from a config file is predictable without having to do a lookup. This would be good for our own container vm image and anything like it.\nThis started structured and turned into a stream0-of-consiousness, sorry. I agree that unique names are desirable, but I'm not sure \"etcd\" and \"httpd\" are sufficient. The reason we have masterspace internally is because we also need to attach metadata about the master that created a pod (e.g. which cluster it thought it was in, what magic number it had (generation number) and so on). Here's what I think I have convinced myself of, so far. 1) All pods have a required name string, which is human-friendly and DNS friendly (probably rfc1035 subdomain rather than label). 2) All pods which are running have a uuid (suggest RFC4122 but could be something else). This of this as a cluster-wide PID. It has no semantic meaning and changes whenever a pod is started on a new host. 3) The kubelet API includes this uuid. If the uuid field is not specified, the kubelet will assign a new UUID. This does not have the property that Daniel wants - predictable container names. The problem is that you putting semantic meaning into the unique ID. There's a reason that databse best practices involve surrogate keys and that UNIX syscalls operate on PIDs rather than command names. Consider what happens if we get a phantom instance on a split network - both pods end up with the same name - not unique any more. That said, I could maybe be convinced. If we put the rule that the pod name had to be unique within a masterspace, we could sort of punt the problem a bit, for now. E.g. Pod { masterspace = \"\" id = \"\" containers [ { name = \"apache\" be created with container name If the apiserver did not care about phantoms, it could leave off the id8675309 noise. for Google people, this should look very familiar. I still have a vague foreboding about making the uniqueness be the master's problem, but it would get rid of the need for opaque UUIDs. Or would it? We need to handle static pods (e.g. cAdvisor). If they are allowed to collide, then some hyopthetical cluster-data aggregator can not use ID as primary key, and we will need to disambiguate queries by hostname. Blech. What if the rule is that masterspace is optional. If not specified, kubelet will make something up derived from the source. So cAdvsor would say: Pod { #no masterspace id = \"cadvisor\" containers [ { name = \"cadvisor\" be created with container name <host_fqdnThis still sort of sucks in that you can't aggregate by masterspace, e.g. \"give me a list of all containers in the cadvisor masterspace\". But maybe that's better served by labels anyway. Yes, I think so. Thoughts? I could go wither way (UUIDs or masterspace + unique name). Or does someone have other ideas? I feel like this got complicated pretty fast. Tim , Daniel Smith wrote:\nJust to be clear, I only think that the property of predictable names is desirable for containers that come from the manifest url and maybe the container, because without that property, is unhelpful. But you've got me somewhat convinced that maybe I shouldn't care so much about that. I don't know if we want to wait to solve naming in general before we accept a better solution than what we do currently.\nI could put my weight behind either approach. The problem with UUIDs (be they RFC4122 or SHA or whatever) is that they suck for humans. The problem with !UUIDs is that we have to count on the \"master\" to get uniqueness right. , Daniel Smith wrote:\n\"I feel like this got complicated pretty fast.\" Yup:) [I think I've read & parsed all of the comments, but I could be mistaken] I like the idea of DNS-styled hierarchical namespaces. I'm not super worried about multiple masters scheduling over the same cluster of minions, but it does make multi-tenant masters easier (i.e. a provider is running a master, and customers run their minions). It's also something that people are used to. I think it's also reasonable to require that users produce unique names for managing in the system. Machine-generated unique IDs are more useful for running containers (i.e. a global PID). Having this be globally unique is really handy for things like log aggregation, etc. Why not always have the kubelet generate that? The master can learn it when it lists the running containers. It's worth noting that the only restriction of docker names is that they are unique to the host. We can still encode useful human data (manifest+container names) in addition to the unique ID into the if we only parse out the unique ID! FWIW, I'm just polishing my ID cleanups to remove dead (or dieing) code. My goal was to normalize on docker IDs for many/most things inside the kubelet. I should have it out for review tomorrow.\nAlso, clarifying some terminology might be handy. Here's how I think of things (could easily be wrong!): is a collection of . are an instance of a . They can be running (or not). They are assigned to a host. Things that confuse me: have an Id. have a name. have an Id. Seems like the manifest should only have a name (but this gets to the discussion above about names vs ids). has a which really just wraps . Seems like overkill.\n, Justin Huff wrote: I'm more worried about \"masters\" that are config files crafted by humans without coordination. Those should not accidentally collide :) Here \"users\" == apiserver? Yeah, this is doable (and is in fact closer to what we do internally) I think it is useful, but not critical that docker-reported names be human-friendly. I'm keenly interested in this, and I'd like to stabilize it all ASAP. Please do not merge this change until I have had time to feedback on it. Caveat: I am part-time the rest of this week.\n, Justin Huff wrote: The names as defined in pkg/api are somewhat confusing. It all depends on perspective. We really have two APIs here (user -master; master -kubelet), and we're cramming the spec into one file. We should consider whether we really want to do that. From Kubelet's POV ContainerManifest == Pod. Yes, let's settle the discussion about UUIDs vs Names before we rename things. and then lets rename things. I think this was to leave room for growth. Kubelet should do the same and define a Pod type that has an api.ContainerManifest and maybe the UUID (if we do that). BTW: I have a change pending (not sent yet) to do validation of a ContainerManifest - so it will reject manifests that, for example, do not have an ID. The core of it is done, but it needs a test and has some open questions. Hope to have it out tomorrow.\nWhew! This is long. This issue started with no context about what we're trying to do. Starting with the end: Yes, we should clean up the identifiers. Currently, every object/resource includes JSONBase, which has an ID (which probably should be Id). ContainerManifest also has an Id. Container has Name. Port has Name. I'll point out that Container and Port are not standalone resources right now. ContainerManifest is the way it is due to compatibility with the container-vm release. What are we trying to do? I saw several things mentioned in this issue: Human-friendly, memorable, semantically meaningful, short-ish references in operations Predictable references in operations and/or configuration files Unambiguous references in space, such as pods/containers created by multiple masters or by static configuration Unambiguous references in time, such as for logging Idempotent creation () Auto-generation of DNS names () Identification of sets for aggregation Both unique identifiers and human-friendly names have value. Human-friendly names can only be unique in space, not in time. We should use \"Id\" for the former and \"Name\" for the latter. Names could be used to ensure idempotent (at most once) creation, though a non-indexed resource value could be used for that, also. The replicationController would treat \"Name\" in the template as a prefix and would append relatively short random numbers for uniqueness. Static pods could be treated similarly. Label selectors should be used for set formation / aggregation. If users are providing Names, we could also use them for DNS (). I'd use \"domain\" rather than \"masterspace\". Argh, my laptop needs to be rebooted...\nContinuing... I agree we want a mechanism that permits unique id allocation by Kubelets and that doesn't require centralized and/or persistent state. I like UUIDs. There are the issues of ensuring unique MAC addresses in VMs and/or namespaces, and determinism for testing, but I think we've found ways around these issues. I've considered not having human-friendly names for pods before and just using labels instead. Labels are predictable and human-friendly, but don't require uniqueness, and don't require concatenating lots of identifying info together in order to ensure uniqueness, which users WILL do for names (and they'll want to parameterize them). They aren't short, though. Also, I guess part of the problem is that Docker doesn't support labels. We should push on that. Idempotence could be ensured by a client-generated cookie, such as a fingerprint/hash or PR number. It wouldn't be required for static configs. DNS names for instances aren't super-useful if they aren't predictable and DNS-like human-friendly names aren't that friendly if they are long. Short nicknames don't have to be predictable (so they could have a short uniquifying suffix) and don't even need to be semantically relevant -- just memorable (hence Docker's silly auto-generated names, I guess). Services need predictable DNS names, OTOH, and ports need predictable names (for DNS SRV lookup or ENV vars or whatever), and pod-relative hostnames of containers should be predictable, so they can communicate with each other, though I don't know that they actually need to be FQDNs. Other types of services (e.g., master-elected services) and groups will need predictable DNS names, also. Is the main motivation for names for pods to be consistent across all resource types? If so, I could buy into DNS-like hierarchical names for them. I'd use something like \"domain\" or \"namespace\" instead of \"masterspace\".\nPod-relative hostnames and stable internal names are definitely valuable - and limiting \"name\" to rfc1035 subdomain has been extremely valuable in practice to us on OpenShift. Quasi-uniqueness I assume? How predictable? As a concrete example, with something like Zookeeper you need the container to have an identifier/name that is stable across restarts / reschedules in a shared config (so not a pod ID). I'd assumed you'd model this with a set of replication controllers (vs a shared controller) so you had 3 replication controllers with 1 item each, and you'd be able to either set an ENV per pod, or use the name in order to apply that. If name changes over pod instances that rules out the reuse there.\nOne last thought from me; it occurs to me that docker already generates a long container id. Perhaps we can consider using that directly as our spatial/temporal unique identifier, and use this hypothetical dns-style solution as the friendly human name. We'd need to investigate just how unique docker's id's are, and we may not want to depend on docker for that, but it would reduce the number of IDs needed. Also, as a footnote, if we end up with both pod.ID and Manifest.ID, IMO they should be the same identifier.\nFor clarity, let me suggest the convention that \"name\" means a friendly mostly human readable string, possibly in the style of dns names, and that \"id\" means an opaque, machine generated identifier, guaranteed unique at some level of resolution. Maybe everyone except for me is already using this convention. :) But I want to talk about ids and names in general without referring to a particular implementation. I think, in that case, the rep. controller itself has a name, which it can use to make names for the pods it creates (prepend/append indices or something). IDs for the pods could still be generated by the apisever or wherever we decide they need to be generated. I was trying to say that since there's a 1:1 relationship between pods and manifests, we shouldn't make different IDs for each.\nTrying to collect thoughts and ideas into a proposal. It's tricky considering it from all angles (users, apiserver, replication controllers, kubelet). My background is node-centric, so I am counting on people to smack me if I say something dumb for higher-levels :) I have to run out right now, but I'm hoping we can distill the discussion into a design O(soon). NB: We spec names as RFC 1035 compatible, though we might extend that to allow purely numeric tokens (e.g. ) but I forget which RFC that is. Docker names allow underscores, which kubelet reserves for use in infrastructure containers. From kubelet's point of view: 1) All pods have a namespace string, which is human-friendly and DNS friendly (rfc1035 subdomain fragment). For example: \"\". This is used to indicate the provenance of the pod. If the namespace is not specified when creating a pod, kubelet will assign a namespace derived from the source. For example, a file \"\" on host \" \" might get masterspace \" file-\" (the big mess is a base32 encoding of the path). 2) All pods have a name string, which is human-friendly and DNS friendly (rfc1035 subdomain fragment). For example: \"\". These names are typically NOT user-provided, but are generated from infrastructure. For example, if the user asked for a job named \"myjob\" the apiserver must uniquify that into a pod name. 3) The namespace + name pair is assumed to be unique. This provides simple idempotency, for example when re-reading a config file. Open: Do we need UUIDs at all? For what purpose? The only argument I can come up with is to protect against accidentally non-unique names at cluster scope (e.g. in a giant database of namespace, name, uuid, stats) you could disambiguate colliding namespace+names pairs with uuid. Other justifications? From the apiserver's point of view: 1) The apiserver has a configured namespace. 2) All incoming pods have a name. I don't know what the formatting and uniqueness rules are here. 3) Upon acceptance, a pod is assigned a unique ID of some sort. 4) Upon assignment to a minion, the name and unique ID become the pod name. Open: Should the unique ID persist if the pod is moved to a new minion? Maybe we need two IDs - one that sticks across moves and one that does not? , Daniel Smith wrote:\nNumeric host names:\nRegarding the open question: is a pod on a new minion the same as the old pod? Is a move an action that is logically part of kubernetes, or is only \"remove\" and \"create new\" available? If it's the former, it seems like the ID should be the same, if it's the later it seems like it should be different. We have a use case for being able to move a pod from minion to minion (and any volumes that come with it) - however, since this requires the volume data on disk to be in a resting state, it's not an operation that seems to lend itself well to the replication controller (since the move is inherently stateful). So I would expect this to be managed as an operation above the replication controller, vs part of it. One namespace per apiserver can be limiting if the namespace is automatically bound to DNS and you're dealing with very large numbers of containers, but it doesn't sound unreasonable if you are using wildcard DNS.\nBTW, it looks like docker IDs are more or less just 32 random bytes: They enforce them to be unique per-machine:\nUnique ids disambiguate among multiple instances reusing the same name over time, such as when polling termination status. Beware of moving unique ids. Once we do that, they are no longer unique, such as in the cases of live migration or even just preloading. If we do move ids, we should have 2 ids, the movable one at the cluster level and a non-movable one at the node level, and the movable ids would correspond to zero or more of the non-movable ids.\nOK, collecting thoughts again. If this is acceptable, I (or Clayton) can write up a short .md file covering identifiers. There are still a few FIXME comments in here. Please tell me if I am capturing any of this incorrectly. Global: We spec most names as RFC 1035/1123 compatible. Docker allows container names to include underscores, which we reserves for use by infrastructure. From kubelet's point of view: 1) All pods have a namespace string, which is human-friendly and DNS friendly (an rfc1035/1132 subdomain). For example: \"\". This is used to indicate the provenance of the pod. If the namespace is not specified when creating a pod, kubelet will assign a namespace derived from the source of the pod. For example, a file \"\" on host \"\" might get masterspace \" file-\" (the big mess is a base32 encoding of the path). (FIXME: do we need this if we have a UUID as spec'ed below?) 2) All pods have a name string, which is human-friendly and DNS friendly (an rfc1035/1132 subdomain fragment). For example: \"\". These names are typically NOT user-provided, but are generated by infrastructure. For example, if the user asked for a job named \"myjob\" the apiserver must uniquify that into a pod name. 3) The namespace + name pair is assumed to be unique. This provides simple idempotency, for example when re-reading a config file. 4) When starting an instance of a pod for the first time (i.e. not restarting an existing pod), kubelet will assign an rfc4122 compatible UUID to the pod. This provides an ID that is guaranteed unique across time and space. If the pod is stopped and an identical pod (same namespace + name) is started, a new UUID will be assigned. 5) Kubelet will use the aforementioned identifiers to produce unique container names, for example \"\". NB: The UUID is per-pod, not to be confused with Docker's own container IDs which are per-container. From the apiserver's point of view: 1) The apiserver has a configured namespace, for example \"\". 2) All incoming pods have a name assigned by the originator of the pod (be they human users or other infrastructure). Pod names must be unique in space, but not time. 3) Upon acceptance, a pod is assigned a unique ID (FIXME: just spec it as rfc4122 again? could maybe be simpler here?). This provides an easy way to disambiguate successive pods with the same name. This ID will persist for the lifetime of the pod, across restarts and moves. (FIXME: is this really needed or is name good enough?) 4) Upon assignment to a minion, the name and unique ID become the pod name. 5) The namespace + name together must be less no more than 255 characters long. If DNS service is to be configured automatically (not a feature yet, but has been discussed), the pod namespace + name will already be DNS compliant. , bgrant0607 wrote:\nI think this seems like a good outline! Two comments: config files, maybe use a hash of the file vs a base64 encoding of the path as the component of the namespace. Just seems more natural. \"These names are typically NOT user-provided, but are generated by infrastructure.\" I'd consider being more explicit about that behavior, even if it's as simple as a \"unique prefix will be to the name\". This sorta touches on the whole id/name discussion....\nAnother positive attribute of unique ids: they are typically more concise than names, and are therefore more efficient to use in cross references in logs. Based on experience in Omega, I think there's no question that we need unique ids. Also, if you play around with Docker for a short while, you'll find a pile of old objects that only have unique ids and can no longer be referenced by name. How do you query them, resurrect them, or delete them once their names have been recycled? Is there a compelling reason to use a different kind of unique identifier in the apiserver than in the kubelet? I don't think so. We could probably shorten it (e.g., remove the locator) when we combine it with the name to form the name for kubelet.\nDefinitely prefer hash of something in the config file (maybe hash of the JSON of the pod's manifest or something) for use in the namsepace component.\nI'm happy to write this up as part of (along with some more tests and the apiserver implications) once folks reach closure.\nOne minor note regarding Docker ecosystem - \"name\" is currently being used in Docker for a lot of lightweight integrations (linking, sky dock dns, hostname in container). A side effect of any generated name for a Docker container is that those lightweight integrations may become more difficult for end admins. Is there a practical way to make the name appropriately unique on the minion without breaking those potential integrations (making the name a subdomain fragment by omitting '.' for instance)\nI would also like to see us drive labels all the way down into Docker. That would enable us to abandon much of what we are encoding into the name today. Brendan On Fri, Jun 27, 2014, 8:39 AM, Clayton Coleman wrote:\n+1 to what brendanburns@ wrote. Labels provide much cleaner solutions for many use cases.\n, Justin Huff wrote: This is an implementation detail - human-friendliness of docker's names is a nice-to-have not critical, I think. Yeah, where is the line between \"ID\" and \"name\"? The apiserver COULD just send a UUID for the name, but I think we want the structure and content of a pod spec to stay largely the same throughout the entire system, at least for now. I don't think we've got any consensus on diverging it, anyway. For that reason, I think \"name\" makes sense. It is more human readable than not.\n+1 to labels , brendanburns wrote:\nWhat would break on those? We're not proposing to do anything with name that is not totally valid as per standalone Docker? , Clayton Coleman wrote:\nIt's not that the names aren't valid for Docker, its that something consuming those names (as a dns prefix a la skydock, or as a hostname) would break due to length or format on the Kube generated name. I don't think that is a blocker to the proposed naming patterns above, but it's a consideration when thinking about how other software that plays well with Docker might react. Concrete ideas might be to reduce the generated names' length and avoid using '.' as a separator.\nI would argue (for the sake of arguing) that anyone who was making assumptions about container names deserves to be broken. But yeah, let's keep an eye on it. , Clayton Coleman wrote:\nAgree, naming is hard\nWriting up a summary md - does this belong in api/doc, , or another location?\nI would go for or something , Clayton Coleman wrote:\nReferenced pull includes a summary of this discussion, open questions: implication 3-1 (agree/disagree)? I defined \"pod unique name\" and \"pod unique identifier\" to represent thockin's kubelet items 3 and 4", "positive_passages": [{"docid": "doc-en-kubernetes-5dd7f9d7b2c41055c3179e98f959d918190addabd96cb3e159fee76199a87051", "text": "<ins> # Identifiers and Names in Kubernetes A summarization of the goals and recommendations for identifiers and names in Kubernetes.  Described in [GitHub issue #199](https://github.com/GoogleCloudPlatform/kubernetes/issues/199). ## Definitions identifier : an opaque machine generated value guaranteed to be unique in a certain space name : a human readable string intended to help an end user distinguish between similar but distinct entities [rfc1035](http://www.ietf.org/rfc/rfc1035.txt)/[rfc1123](http://www.ietf.org/rfc/rfc1123.txt) label (DNS_LABEL) : An alphanumeric (a-z, A-Z, and 0-9) string less than 64 characters, with the '-' character allowed anywhere except the first or last character, suitable for use as a hostname or segment in a domain name. [rfc1035](http://www.ietf.org/rfc/rfc1035.txt)/[rfc1123](http://www.ietf.org/rfc/rfc1123.txt) subdomain (DNS_SUBDOMAIN) : One or more rfc1035/rfc1123 labels separated by '.' with a maximum length of 255 characters namespace string (NAMESPACE) : An rfc1035/rfc1123 subdomain no longer than 191 characters (255-63-1) source namespace string : The namespace string of a source of pod definitions on a host [rfc4122](http://www.ietf.org/rfc/rfc4122.txt) universally unique identifier (UUID) : A 128 bit generated value that is extremely unilkely to collide across time and space and requires no central coordination pod unique name : the combination of a pod's source namespace string and name string on a host pod unique identifier : the identifier associated with a single execution of a pod on a host, which changes on each restart.  Must be a UUID ## Objectives for names and identifiers 1) Uniquely identify an instance of a pod on the apiserver and on the kubelet 2) Uniquely identify an instance of a container within a pod on the apiserver and on the kubelet 3) Uniquely identify a single execution of a container in time for logging or reporting 4) The structure of a pod specification should stay largely the same throughout the entire system 5) Provide human-friendly, memorable, semantically meaningful, short-ish references in container and pod operations 6) Provide predictable container and pod references in operations and/or configuration files 7) Allow idempotent creation of API resources (#148) 8) Allow DNS names to be automatically generated for individual containers or pods (#146) ## Implications 1) Each container name within a container manifest must be unique within that manifest 2) Each pod instance on the apiserver must have a unique identifier across space and time (UUID) 1) The apiserver may set this identifier if not specified by a client 2) This identifier will persist even if moved across hosts 3) Each pod instance on the apiserver must have a name string which is human-friendly, dns-friendly (DNS_LABEL), and unique in the apiserver space 1) The apiserver may set this name string if not specified by a client 4) Each apiserver must have a configured namespace string (NAMESPACE) that is unique across all apiservers that share its configured minions 5) Each source of pod configuration to a kubelet must have a source namespace string (NAMESPACE) that is unique across all sources available to that kubelet 6) All pod instances on a host must have a name string which is human-friendly, dns-friendly, and unique per namespace string (DNS_LABEL) 7) The combination of the name string and source namespace string on a kubelet must be unique and is referred to as the pod unique name 8) When starting an instance of a pod on a kubelet the first time, a new pod unique identifier (UUID) should be assigned to that pod instance 1) If that pod is restarted, it must retain the pod unique identifier it previously had 2) If the pod is stopped and a new instance with the same pod unique name is started, it must be assigned a new pod unique identifier 9) The kubelet should use the pod unique name and pod unique identifier to produce a Docker container name (--name) </ins>", "commid": "kubernetes_pr_334"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fa1ebef63f76d15ef1c28364f7447772418ff92e79eefd59fa95d78576bc8628", "query": "If you are using a private docker registry, you first need to call something like and provide a user/pass/email. Any further calls to will pick up your identity from a file in $HOME/.dockercfg. Before a kubelet starts a container, it calls the equivalent of . Unfortunately, the auth information is not picked up from $HOME/.dockercfg, and there is no alternate way to configure it. The kubelet needs to support docker registry auth.\nHere's where the auth should be getting passed to the docker client:\nI'm not certain, but it looks like authenticated docker pulls would have worked before this patch:\nSee .\nah, search skills failed me again", "positive_passages": [{"docid": "doc-en-kubernetes-d0b2a1694e137a25f0c9d773183746b4cbbfdc14bd5ba535205288f1c6c3991e", "text": "<ins> # Maintainers Eric Paris <eparis@redhat.com> </ins>", "commid": "kubernetes_pr_1647"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fa1ebef63f76d15ef1c28364f7447772418ff92e79eefd59fa95d78576bc8628", "query": "If you are using a private docker registry, you first need to call something like and provide a user/pass/email. Any further calls to will pick up your identity from a file in $HOME/.dockercfg. Before a kubelet starts a container, it calls the equivalent of . Unfortunately, the auth information is not picked up from $HOME/.dockercfg, and there is no alternate way to configure it. The kubelet needs to support docker registry auth.\nHere's where the auth should be getting passed to the docker client:\nI'm not certain, but it looks like authenticated docker pulls would have worked before this patch:\nSee .\nah, search skills failed me again", "positive_passages": [{"docid": "doc-en-kubernetes-a70238982f99fadc61e7ce926d51d6c8b6faa8bfc5da0332d4165249799ad153", "text": "<ins> #!bash # # bash completion file for core kubecfg commands # # This script provides completion of non replication controller options # # To enable the completions either: #  - place this file in /etc/bash_completion.d #  or #  - copy this file and add the line below to your .bashrc after #    bash completion features are loaded #     . kubecfg # # Note: # Currently, the completions will not work if the apiserver daemon is not # running on localhost on the standard port 8080 __contains_word () { local w word=$1; shift for w in \"$@\"; do [[ $w = \"$word\" ]] && return done return 1 } # This should be provided by the bash-completions, but give a really simple # stoopid version just in case.  It works most of the time. if ! declare -F _get_comp_words_by_ref >/dev/null 2>&1; then _get_comp_words_by_ref () { while [ $# -gt 0 ]; do case \"$1\" in cur) cur=${COMP_WORDS[COMP_CWORD]} ;; prev) prev=${COMP_WORDS[COMP_CWORD-1]} ;; words) words=(\"${COMP_WORDS[@]}\") ;; cword) cword=$COMP_CWORD ;; -n) shift # we don't handle excludes ;; esac shift done } fi __has_service() { local i for ((i=0; i < cword; i++)); do local word=${words[i]} # strip everything after a / so things like pods/[id] match word=${word%%/*} if __contains_word \"${word}\" \"${services[@]}\" && ! __contains_word \"${words[i-1]}\" \"${opts[@]}\"; then return 0 fi done return 1 } # call kubecfg list $1, # exclude blank lines # skip the header stuff kubecfg prints on the first 2 lines # append $1/ to the first column and use that in compgen __kubecfg_parse_list() { local kubecfg_output if kubecfg_output=$(kubecfg list \"$1\" 2>/dev/null); then out=($(echo \"${kubecfg_output}\" | awk -v prefix=\"$1\" '/^$/ {next} NR > 2 {print prefix\"/\"$1}')) COMPREPLY=( $( compgen -W \"${out[*]}\" -- \"$cur\" ) ) fi } _kubecfg_specific_service_match() { case \"$cur\" in pods/*) __kubecfg_parse_list pods ;; minions/*) __kubecfg_parse_list minions ;; replicationControllers/*) __kubecfg_parse_list replicationControllers ;; services/*) __kubecfg_parse_list services ;; *) if __has_service; then return 0 fi compopt -o nospace COMPREPLY=( $( compgen -S / -W \"${services[*]}\" -- \"$cur\" ) ) ;; esac } _kubecfg_service_match() { if __has_service; then return 0 fi COMPREPLY=( $( compgen -W \"${services[*]}\" -- \"$cur\" ) ) } _kubecfg() { local opts=( -h -c ) local create_services=(pods replicationControllers services) local update_services=(replicationControllers) local all_services=(pods replicationControllers services minions) local services=(\"${all_services[@]}\") local json_commands=(create update) local all_commands=(create update get list delete stop rm rollingupdate resize) local commands=(\"${all_commands[@]}\") COMPREPLY=() local command local cur prev words cword _get_comp_words_by_ref -n : cur prev words cword if __contains_word \"$prev\" \"${opts[@]}\"; then case $prev in -c) _filedir '@(json|yml|yaml)' return 0 ;; -h) return 0 ;; esac fi if [[ \"$cur\" = -* ]]; then COMPREPLY=( $(compgen -W \"${opts[*]}\" -- \"$cur\") ) return 0 fi # if you passed -c, you are limited to create or update if __contains_word \"-c\" \"${words[@]}\"; then services=(\"${create_services[@]}\" \"${update_services[@]}\") commands=(\"${json_commands[@]}\") fi # figure out which command they are running, remembering that arguments to # options don't count as the command!  So a hostname named 'create' won't # trip things up local i for ((i=0; i < cword; i++)); do if __contains_word \"${words[i]}\" \"${commands[@]}\" && ! __contains_word \"${words[i-1]}\" \"${opts[@]}\"; then command=${words[i]} break fi done # tell the list of possible commands if [[ -z ${command} ]]; then COMPREPLY=( $( compgen -W \"${commands[*]}\" -- \"$cur\" ) ) return 0 fi # remove services which you can't update given your command if [[ ${command} == \"create\" ]]; then services=(\"${create_services[@]}\") elif [[ ${command} == \"update\" ]]; then services=(\"${update_services[@]}\") fi case $command in create | list) _kubecfg_service_match ;; update | get | delete) _kubecfg_specific_service_match ;; *) ;; esac return 0 } complete -F _kubecfg kubecfg # ex: ts=4 sw=4 et filetype=sh </ins>", "commid": "kubernetes_pr_1647"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fa1ebef63f76d15ef1c28364f7447772418ff92e79eefd59fa95d78576bc8628", "query": "If you are using a private docker registry, you first need to call something like and provide a user/pass/email. Any further calls to will pick up your identity from a file in $HOME/.dockercfg. Before a kubelet starts a container, it calls the equivalent of . Unfortunately, the auth information is not picked up from $HOME/.dockercfg, and there is no alternate way to configure it. The kubelet needs to support docker registry auth.\nHere's where the auth should be getting passed to the docker client:\nI'm not certain, but it looks like authenticated docker pulls would have worked before this patch:\nSee .\nah, search skills failed me again", "positive_passages": [{"docid": "doc-en-kubernetes-3b11a81468f6a5ac23a5c5152bea0f7aaadbb57189a6cd5f4abeb0c3a33cdcd4", "text": "<del> #!bash # # bash completion file for core kubecfg commands # # This script provides completion of non replication controller options # # To enable the completions either: #  - place this file in /etc/bash_completion.d #  or #  - copy this file and add the line below to your .bashrc after #    bash completion features are loaded #     . kubecfg # # Note: # Currently, the completions will not work if the apiserver daemon is not # running on localhost on the standard port 8080 __contains_word () { local w word=$1; shift for w in \"$@\"; do [[ $w = \"$word\" ]] && return done return 1 } # This should be provided by the bash-completions, but give a really simple # stoopid version just in case.  It works most of the time. if ! declare -F _get_comp_words_by_ref >/dev/null 2>&1; then _get_comp_words_by_ref () { while [ $# -gt 0 ]; do case \"$1\" in cur) cur=${COMP_WORDS[COMP_CWORD]} ;; prev) prev=${COMP_WORDS[COMP_CWORD-1]} ;; words) words=(\"${COMP_WORDS[@]}\") ;; cword) cword=$COMP_CWORD ;; -n) shift # we don't handle excludes ;; esac shift done } fi __has_service() { local i for ((i=0; i < cword; i++)); do local word=${words[i]} # strip everything after a / so things like pods/[id] match word=${word%%/*} if __contains_word \"${word}\" \"${services[@]}\" && ! __contains_word \"${words[i-1]}\" \"${opts[@]}\"; then return 0 fi done return 1 } # call kubecfg list $1, # exclude blank lines # skip the header stuff kubecfg prints on the first 2 lines # append $1/ to the first column and use that in compgen __kubecfg_parse_list() { local kubecfg_output if kubecfg_output=$(kubecfg list \"$1\" 2>/dev/null); then out=($(echo \"${kubecfg_output}\" | awk -v prefix=\"$1\" '/^$/ {next} NR > 2 {print prefix\"/\"$1}')) COMPREPLY=( $( compgen -W \"${out[*]}\" -- \"$cur\" ) ) fi } _kubecfg_specific_service_match() { case \"$cur\" in pods/*) __kubecfg_parse_list pods ;; minions/*) __kubecfg_parse_list minions ;; replicationControllers/*) __kubecfg_parse_list replicationControllers ;; services/*) __kubecfg_parse_list services ;; *) if __has_service; then return 0 fi compopt -o nospace COMPREPLY=( $( compgen -S / -W \"${services[*]}\" -- \"$cur\" ) ) ;; esac } _kubecfg_service_match() { if __has_service; then return 0 fi COMPREPLY=( $( compgen -W \"${services[*]}\" -- \"$cur\" ) ) } _kubecfg() { local opts=( -h -c ) local create_services=(pods replicationControllers services) local update_services=(replicationControllers) local all_services=(pods replicationControllers services minions) local services=(\"${all_services[@]}\") local json_commands=(create update) local all_commands=(create update get list delete stop rm rollingupdate resize) local commands=(\"${all_commands[@]}\") COMPREPLY=() local command local cur prev words cword _get_comp_words_by_ref -n : cur prev words cword if __contains_word \"$prev\" \"${opts[@]}\"; then case $prev in -c) _filedir '@(json|yml|yaml)' return 0 ;; -h) return 0 ;; esac fi if [[ \"$cur\" = -* ]]; then COMPREPLY=( $(compgen -W \"${opts[*]}\" -- \"$cur\") ) return 0 fi # if you passed -c, you are limited to create or update if __contains_word \"-c\" \"${words[@]}\"; then services=(\"${create_services[@]}\" \"${update_services[@]}\") commands=(\"${json_commands[@]}\") fi # figure out which command they are running, remembering that arguments to # options don't count as the command!  So a hostname named 'create' won't # trip things up local i for ((i=0; i < cword; i++)); do if __contains_word \"${words[i]}\" \"${commands[@]}\" && ! __contains_word \"${words[i-1]}\" \"${opts[@]}\"; then command=${words[i]} break fi done # tell the list of possible commands if [[ -z ${command} ]]; then COMPREPLY=( $( compgen -W \"${commands[*]}\" -- \"$cur\" ) ) return 0 fi # remove services which you can't update given your command if [[ ${command} == \"create\" ]]; then services=(\"${create_services[@]}\") elif [[ ${command} == \"update\" ]]; then services=(\"${update_services[@]}\") fi case $command in create | list) _kubecfg_service_match ;; update | get | delete) _kubecfg_specific_service_match ;; *) ;; esac return 0 } complete -F _kubecfg kubecfg # ex: ts=4 sw=4 et filetype=sh </del>", "commid": "kubernetes_pr_1647"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-24df73a6db05c45f0cac4e827cf56a2dc89af2bfb599ee7ed6ea71c4b1f5c613", "query": "Should be able to tell from logs if a minion isn't present because cloud provider didn't tell us about it, or if it's failing health checks.", "positive_passages": [{"docid": "doc-en-kubernetes-745d381fa41da15f155ef8da60ae55fcca0f06dadec83246b90b044f9bd74fa6", "text": "} if status == health.Healthy { result = append(result, minion) <ins> } else { glog.Errorf(\"%s failed a health check, ignoring.\", minion) </ins> } } return result, nil", "commid": "kubernetes_pr_1019"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-823174cd7a80c2aabbd968d214ca3d07426d76d7cc3a412fb0316f4befd8fbf6", "query": "https://travis- Seems surprising-- I will look into it later if no one else does first.\nGot another flake. Looking into it.", "positive_passages": [{"docid": "doc-en-kubernetes-fc8264fb7df08567e2d75f8f24c25060160872ae681efacdb33ce35d071441bd", "text": "func TestErrorsToAPIStatus(t *testing.T) { cases := map[error]api.Status{ <del> NewAlreadyExistsErr(\"foo\", \"bar\"): api.Status{ </del> <ins> NewAlreadyExistsErr(\"foo\", \"bar\"): { </ins> Status:  api.StatusFailure, Code:    http.StatusConflict, Reason:  \"already_exists\",", "commid": "kubernetes_pr_858"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-823174cd7a80c2aabbd968d214ca3d07426d76d7cc3a412fb0316f4befd8fbf6", "query": "https://travis- Seems surprising-- I will look into it later if no one else does first.\nGot another flake. Looking into it.", "positive_passages": [{"docid": "doc-en-kubernetes-e0b3f5c2bdc6e8c560cf17ee8d76c4cb251d10eff3595b5e6d934d97d3fecc66", "text": "ID:   \"bar\", }, }, <del> NewConflictErr(\"foo\", \"bar\", errors.New(\"failure\")): api.Status{ </del> <ins> NewConflictErr(\"foo\", \"bar\", errors.New(\"failure\")): { </ins> Status:  api.StatusFailure, Code:    http.StatusConflict, Reason:  \"conflict\",", "commid": "kubernetes_pr_858"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-823174cd7a80c2aabbd968d214ca3d07426d76d7cc3a412fb0316f4befd8fbf6", "query": "https://travis- Seems surprising-- I will look into it later if no one else does first.\nGot another flake. Looking into it.", "positive_passages": [{"docid": "doc-en-kubernetes-98ebd6b80d6b9f12ac1b115a06371f14a92cdb96c50946e24109e61012d9efca", "text": "} func TestSyncCreateTimeout(t *testing.T) { <ins> testOver := make(chan struct{}) defer close(testOver) </ins> storage := SimpleRESTStorage{ injectedFunction: func(obj interface{}) (interface{}, error) { <del> time.Sleep(5 * time.Millisecond) </del> <ins> // Eliminate flakes by ensuring the create operation takes longer than this test. <-testOver </ins> return obj, nil }, }", "commid": "kubernetes_pr_858"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-823174cd7a80c2aabbd968d214ca3d07426d76d7cc3a412fb0316f4befd8fbf6", "query": "https://travis- Seems surprising-- I will look into it later if no one else does first.\nGot another flake. Looking into it.", "positive_passages": [{"docid": "doc-en-kubernetes-69e82608088ae166fb63f35140cfbc8c4e5e7037b4dcc6b261029d67a4c00790", "text": "} func TestOpGet(t *testing.T) { <del> simpleStorage := &SimpleRESTStorage{} </del> <ins> testOver := make(chan struct{}) defer close(testOver) simpleStorage := &SimpleRESTStorage{ injectedFunction: func(obj interface{}) (interface{}, error) { // Eliminate flakes by ensuring the create operation takes longer than this test. <-testOver return obj, nil }, } </ins> handler := New(map[string]RESTStorage{ \"foo\": simpleStorage, }, codec, \"/prefix/version\")", "commid": "kubernetes_pr_858"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-41a4a9d51023611803efc4b60b5824c1d1fbca7fe22577f19d7270fd74d5ef0d", "query": "if you delete a service and restart it the port is no longer accessible To reproduce: 1) start a pod 2) start a service All works fine port is assigned - traffic flows 3) delete service 4) start service the port is now not assigned Here are sample configs: pod: Service:\nI thought this was a known issue, but I could not find another issue on the same topic. Note that all containers started after the first instance of the service was created will have environment variables referring to that instance and won't see environment variables referring to the new instance until they restart. This is a fundamental shortcoming of the current approach.\nI understand what you just replied but that is not the issue here. The problem is that when you delete a service , no other service can resuse that port successfully. The port is removed from a netstat listing. When a new service tries to use that port it gets allocated but you can not communicate to the pod through it. It is hosed until I re-install the cluster. (I have not tried rebooting the cluster) BTW this is a bug not a design issue.\nAh. The previous issue I was thinking of was . It sounds like the issue hasn't been completely resolved.\nI will take a look at this today.\nSorry for the problem, has the fix. --brendan\nThanks! On Aug 19, 2014, at 2:26 PM, brendandburns wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-bee0dfa0415af80051e30433b1014e5509d82a22f43a90957446c5df8414bd2b", "text": "for _, service := range services { activeServices.Insert(service.ID) info, exists := proxier.getServiceInfo(service.ID) <del> if exists && info.port == service.Port { </del> <ins> if exists && info.active && info.port == service.Port { </ins> continue } <del> if exists { </del> <ins> if exists && info.port != service.Port { </ins> proxier.StopProxy(service.ID) } glog.Infof(\"Adding a new service %s on port %d\", service.ID, service.Port)", "commid": "kubernetes_pr_956"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-41a4a9d51023611803efc4b60b5824c1d1fbca7fe22577f19d7270fd74d5ef0d", "query": "if you delete a service and restart it the port is no longer accessible To reproduce: 1) start a pod 2) start a service All works fine port is assigned - traffic flows 3) delete service 4) start service the port is now not assigned Here are sample configs: pod: Service:\nI thought this was a known issue, but I could not find another issue on the same topic. Note that all containers started after the first instance of the service was created will have environment variables referring to that instance and won't see environment variables referring to the new instance until they restart. This is a fundamental shortcoming of the current approach.\nI understand what you just replied but that is not the issue here. The problem is that when you delete a service , no other service can resuse that port successfully. The port is removed from a netstat listing. When a new service tries to use that port it gets allocated but you can not communicate to the pod through it. It is hosed until I re-install the cluster. (I have not tried rebooting the cluster) BTW this is a bug not a design issue.\nAh. The previous issue I was thinking of was . It sounds like the issue hasn't been completely resolved.\nI will take a look at this today.\nSorry for the problem, has the fix. --brendan\nThanks! On Aug 19, 2014, at 2:26 PM, brendandburns wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-03513259d836d47077e1b4fe013229e0eeeb501e38350b0eccfa472ed8d62a98", "text": "} } <ins> func TestProxyUpdateDeleteUpdate(t *testing.T) { lb := NewLoadBalancerRR() lb.OnUpdate([]api.Endpoints{{JSONBase: api.JSONBase{ID: \"echo\"}, Endpoints: []string{net.JoinHostPort(\"127.0.0.1\", port)}}}) p := NewProxier(lb) proxyPort, err := p.addServiceOnUnusedPort(\"echo\") if err != nil { t.Fatalf(\"error adding new service: %#v\", err) } conn, err := net.Dial(\"tcp\", net.JoinHostPort(\"127.0.0.1\", proxyPort)) if err != nil { t.Fatalf(\"error connecting to proxy: %v\", err) } conn.Close() p.OnUpdate([]api.Service{}) if err := waitForClosedPort(p, proxyPort); err != nil { t.Fatalf(err.Error()) } proxyPortNum, _ := strconv.Atoi(proxyPort) p.OnUpdate([]api.Service{ {JSONBase: api.JSONBase{ID: \"echo\"}, Port: proxyPortNum}, }) testEchoConnection(t, \"127.0.0.1\", proxyPort) } </ins> func TestProxyUpdatePort(t *testing.T) { lb := NewLoadBalancerRR() lb.OnUpdate([]api.Endpoints{{JSONBase: api.JSONBase{ID: \"echo\"}, Endpoints: []string{net.JoinHostPort(\"127.0.0.1\", port)}}})", "commid": "kubernetes_pr_956"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-41a4a9d51023611803efc4b60b5824c1d1fbca7fe22577f19d7270fd74d5ef0d", "query": "if you delete a service and restart it the port is no longer accessible To reproduce: 1) start a pod 2) start a service All works fine port is assigned - traffic flows 3) delete service 4) start service the port is now not assigned Here are sample configs: pod: Service:\nI thought this was a known issue, but I could not find another issue on the same topic. Note that all containers started after the first instance of the service was created will have environment variables referring to that instance and won't see environment variables referring to the new instance until they restart. This is a fundamental shortcoming of the current approach.\nI understand what you just replied but that is not the issue here. The problem is that when you delete a service , no other service can resuse that port successfully. The port is removed from a netstat listing. When a new service tries to use that port it gets allocated but you can not communicate to the pod through it. It is hosed until I re-install the cluster. (I have not tried rebooting the cluster) BTW this is a bug not a design issue.\nAh. The previous issue I was thinking of was . It sounds like the issue hasn't been completely resolved.\nI will take a look at this today.\nSorry for the problem, has the fix. --brendan\nThanks! On Aug 19, 2014, at 2:26 PM, brendandburns wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-5f6b46d36e3704a92aa12d61d2641b75938a38d1e9db1833bbd7f60535ed958d", "text": "} testEchoConnection(t, \"127.0.0.1\", newPort) } <ins> func TestProxyUpdatePortLetsGoOfOldPort(t *testing.T) { lb := NewLoadBalancerRR() lb.OnUpdate([]api.Endpoints{{JSONBase: api.JSONBase{ID: \"echo\"}, Endpoints: []string{net.JoinHostPort(\"127.0.0.1\", port)}}}) p := NewProxier(lb) proxyPort, err := p.addServiceOnUnusedPort(\"echo\") if err != nil { t.Fatalf(\"error adding new service: %#v\", err) } // add a new dummy listener in order to get a port that is free l, _ := net.Listen(\"tcp\", \":0\") _, newPort, _ := net.SplitHostPort(l.Addr().String()) portNum, _ := strconv.Atoi(newPort) l.Close() // Wait for the socket to actually get free. if err := waitForClosedPort(p, newPort); err != nil { t.Fatalf(err.Error()) } if proxyPort == newPort { t.Errorf(\"expected difference, got %s %s\", newPort, proxyPort) } p.OnUpdate([]api.Service{ {JSONBase: api.JSONBase{ID: \"echo\"}, Port: portNum}, }) if err := waitForClosedPort(p, proxyPort); err != nil { t.Fatalf(err.Error()) } testEchoConnection(t, \"127.0.0.1\", newPort) proxyPortNum, _ := strconv.Atoi(proxyPort) p.OnUpdate([]api.Service{ {JSONBase: api.JSONBase{ID: \"echo\"}, Port: proxyPortNum}, }) if err := waitForClosedPort(p, newPort); err != nil { t.Fatalf(err.Error()) } testEchoConnection(t, \"127.0.0.1\", proxyPort) } </ins>", "commid": "kubernetes_pr_956"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99e02bbd6dfd36028985d05c078261611bf34deff196750e9774a0cbdb8c8a20", "query": "We have an e2e test that runs the guestbook example. We should also have one that runs through the other example.", "positive_passages": [{"docid": "doc-en-kubernetes-a5df071292da4751cd50d7569ef1932600ef8908f38a48124af25581a2f4dd3c", "text": "trap \"teardown\" EXIT <del> POD_ID_LIST=$($CLOUDCFG -json -l name=myNginx list pods | jq \".items[].id\") </del> <ins> POD_ID_LIST=$($CLOUDCFG '-template={{range.Items}}{{.ID}} {{end}}' -l name=myNginx list pods) </ins> # Container turn up on a clean cluster can take a while for the docker image pull. ALL_RUNNING=0 while [ $ALL_RUNNING -ne 1 ]; do", "commid": "kubernetes_pr_965"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99e02bbd6dfd36028985d05c078261611bf34deff196750e9774a0cbdb8c8a20", "query": "We have an e2e test that runs the guestbook example. We should also have one that runs through the other example.", "positive_passages": [{"docid": "doc-en-kubernetes-45f4ec9c4c966259384749e6d930a90f2d36f4eda8e3a67079db6cfe942c3555", "text": "sleep 5 ALL_RUNNING=1 for id in $POD_ID_LIST; do <del> CURRENT_STATUS=$(remove-quotes $($CLOUDCFG -json get \"pods/$(remove-quotes ${id})\" | jq '.currentState.info[\"mynginx\"].State.Running and .currentState.info[\"net\"].State.Running')) </del> <ins> CURRENT_STATUS=$($CLOUDCFG -template '{{and .CurrentState.Info.mynginx.State.Running .CurrentState.Info.net.State.Running}}' get pods/$id) </ins> if [ \"$CURRENT_STATUS\" != \"true\" ]; then ALL_RUNNING=0 fi", "commid": "kubernetes_pr_965"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99e02bbd6dfd36028985d05c078261611bf34deff196750e9774a0cbdb8c8a20", "query": "We have an e2e test that runs the guestbook example. We should also have one that runs through the other example.", "positive_passages": [{"docid": "doc-en-kubernetes-6e2bda87e8c7f1ac4e6bab4e661bd8aa237e5e1a8fe59dde0b7c6d74659b0c34", "text": "sleep 5 <del> POD_LIST_1=$($CLOUDCFG -json list pods | jq \".items[].id\") </del> <ins> POD_LIST_1=$($CLOUDCFG '-template={{range.Items}}{{.ID}} {{end}}' list pods) </ins> echo \"Pods running: ${POD_LIST_1}\" $CLOUDCFG stop redisSlaveController", "commid": "kubernetes_pr_965"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99e02bbd6dfd36028985d05c078261611bf34deff196750e9774a0cbdb8c8a20", "query": "We have an e2e test that runs the guestbook example. We should also have one that runs through the other example.", "positive_passages": [{"docid": "doc-en-kubernetes-648f4f93b9e8c651b3e943319bf38b385595c6af065de8d48cb05602612e8bb9", "text": "$CLOUDCFG delete services/redismaster $CLOUDCFG delete pods/redis-master-2 <del> POD_LIST_2=$($CLOUDCFG -json list pods | jq \".items[].id\") </del> <ins> POD_LIST_2=$($CLOUDCFG '-template={{range.Items}}{{.ID}} {{end}}' list pods) </ins> echo \"Pods running after shutdown: ${POD_LIST_2}\" exit 0", "commid": "kubernetes_pr_965"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99e02bbd6dfd36028985d05c078261611bf34deff196750e9774a0cbdb8c8a20", "query": "We have an e2e test that runs the guestbook example. We should also have one that runs through the other example.", "positive_passages": [{"docid": "doc-en-kubernetes-5e8c4d1ed3c082bc29e8fd243c98005ab4f37bcc7223ebf6c8d65da27ab06e3c", "text": "<ins> #!/bin/bash # Copyright 2014 Google Inc. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the \"License\"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #     http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an \"AS IS\" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # Launches an nginx container and verifies it can be reached. Assumes that # we're being called by hack/e2e-test.sh (we use some env vars it sets up). # Exit on error set -e source \"${KUBE_REPO_ROOT}/cluster/kube-env.sh\" source \"${KUBE_REPO_ROOT}/cluster/$KUBERNETES_PROVIDER/util.sh\" function validate() { POD_ID_LIST=$($CLOUDCFG '-template={{range.Items}}{{.ID}} {{end}}' -l name=$controller list pods) # Container turn up on a clean cluster can take a while for the docker image pull. ALL_RUNNING=0 while [ $ALL_RUNNING -ne 1 ]; do echo \"Waiting for all containers in pod to come up.\" sleep 5 ALL_RUNNING=1 for id in $POD_ID_LIST; do CURRENT_STATUS=$($CLOUDCFG -template '{{and .CurrentState.Info.datacontroller.State.Running .CurrentState.Info.net.State.Running}}' get pods/$id) if [ \"$CURRENT_STATUS\" != \"true\" ]; then ALL_RUNNING=0 fi done done ids=($POD_ID_LIST) if [ ${#ids[@]} -ne $1 ]; then echo \"Unexpected number of pods: ${#ids[@]}\" exit 1 fi } controller=dataController # Launch a container $CLOUDCFG -p 8080:80 run brendanburns/data 2 $controller function teardown() { echo \"Cleaning up test artifacts\" $CLOUDCFG stop $controller $CLOUDCFG rm $controller } trap \"teardown\" EXIT validate 2 $CLOUDCFG resize $controller 1 validate 1 $CLOUDCFG resize $controller 2 validate 2 # TODO: test rolling update here, but to do so, we need to make the update blocking # $CLOUDCFG -u=20s rollingupdate $controller # # Wait for the replica controller to recreate # sleep 10 # # validate 2 exit 0 </ins>", "commid": "kubernetes_pr_965"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99e02bbd6dfd36028985d05c078261611bf34deff196750e9774a0cbdb8c8a20", "query": "We have an e2e test that runs the guestbook example. We should also have one that runs through the other example.", "positive_passages": [{"docid": "doc-en-kubernetes-e93d0912014231880624770df242c0fba29a38c39974928ffe51a12efc7d001e", "text": "LEAVE_UP=${2:-0} TEAR_DOWN=${3:-0} <del> HAVE_JQ=$(which jq) if [[ -z ${HAVE_JQ} ]]; then echo \"Please install jq, e.g.: 'sudo apt-get install jq' or, \" echo \"'sudo yum install jq' or, \" echo \"if you're on a mac with homebrew, 'brew install jq'.\" exit 1 fi </del> # Exit on error set -e", "commid": "kubernetes_pr_965"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-09fca157bd43c35013d3772434f9998a9623afc2f92a2c7f553134f7bdea5afe", "query": "Running vagrant from scratch gives the error: For vagrant cluster, the last minion cannot be detected. The /tmp/minions file only shows two minions, but after a while, using the same command, i.e. will get three minions. There is a race between kube-up and validate-, we should wait a while before panic.\nI can look to fix this.", "positive_passages": [{"docid": "doc-en-kubernetes-e4d50f5d87bfdfd1daf6fe4b2eb739aecb09d1fff0a82b55268e35ac6511abb4", "text": "for (( i=0; i <${NUM_MINIONS}; i++)) do KUBE_MINION_IP_ADDRESSES[$i]=\"${MINION_IP_BASE}$[$i+2]\" MINION_NAMES[$i]=\"${MINION_IP_BASE}$[$i+2]\" <del> done </del>  No newline at end of file <ins> VAGRANT_MINION_NAMES[$i]=\"minion-$[$i+1]\" done </ins>", "commid": "kubernetes_pr_1155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-09fca157bd43c35013d3772434f9998a9623afc2f92a2c7f553134f7bdea5afe", "query": "Running vagrant from scratch gives the error: For vagrant cluster, the last minion cannot be detected. The /tmp/minions file only shows two minions, but after a while, using the same command, i.e. will get three minions. There is a race between kube-up and validate-, we should wait a while before panic.\nI can look to fix this.", "positive_passages": [{"docid": "doc-en-kubernetes-3790b2eb6255d6d16694cf30d96e497f273431a7167b431c4b10880786cd294e", "text": "source $(dirname ${BASH_SOURCE})/${KUBE_CONFIG_FILE-\"config-default.sh\"} function detect-master () { <del> echo \"KUBE_MASTER_IP: $KUBE_MASTER_IP\" echo \"KUBE_MASTER: $KUBE_MASTER\" </del> <ins> echo \"KUBE_MASTER_IP: $KUBE_MASTER_IP\" echo \"KUBE_MASTER: $KUBE_MASTER\" </ins> } # Get minion IP addresses and store in KUBE_MINION_IP_ADDRESSES[] function detect-minions { <del> echo \"Minions already detected\" </del> <ins> echo \"Minions already detected\" </ins> } # Verify prereqs on host machine", "commid": "kubernetes_pr_1155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-09fca157bd43c35013d3772434f9998a9623afc2f92a2c7f553134f7bdea5afe", "query": "Running vagrant from scratch gives the error: For vagrant cluster, the last minion cannot be detected. The /tmp/minions file only shows two minions, but after a while, using the same command, i.e. will get three minions. There is a race between kube-up and validate-, we should wait a while before panic.\nI can look to fix this.", "positive_passages": [{"docid": "doc-en-kubernetes-cba7902427a9b9b98d6a55fc48c3ec056d7cd6ea5a0735514bdbf4e9d40b745e", "text": "} # Instantiate a kubernetes cluster <del> function kube-up { vagrant up </del> <ins> function kube-up { get-password vagrant up echo \"Each machine instance has been created.\" echo \"  Now waiting for the Salt provisioning process to complete on each machine.\" echo \"  This can take some time based on your network, disk, and cpu speed.\" echo \"  It is possible for an error to occur during Salt provision of cluster and this could loop forever.\" # verify master has all required daemons echo \"Validating master\" MACHINE=\"master\" REQUIRED_DAEMON=(\"salt-master\" \"salt-minion\" \"apiserver\" \"nginx\" \"controller-manager\" \"scheduler\") VALIDATED=\"1\" until [ \"$VALIDATED\" -eq \"0\" ]; do VALIDATED=\"0\" for daemon in ${REQUIRED_DAEMON[@]}; do vagrant ssh $MACHINE -c \"which $daemon\" >/dev/null 2>&1 || { printf \".\"; VALIDATED=\"1\"; sleep 2; } done done # verify each minion has all required daemons for (( i=0; i<${#MINION_NAMES[@]}; i++)); do echo \"Validating ${VAGRANT_MINION_NAMES[$i]}\" MACHINE=${VAGRANT_MINION_NAMES[$i]} REQUIRED_DAEMON=(\"salt-minion\" \"kubelet\" \"docker\") VALIDATED=\"1\" until [ \"$VALIDATED\" -eq \"0\" ]; do VALIDATED=\"0\" for daemon in ${REQUIRED_DAEMON[@]}; do vagrant ssh $MACHINE -c \"which $daemon\" >/dev/null 2>&1 || { printf \".\"; VALIDATED=\"1\"; sleep 2; } done done done echo echo \"Waiting for each minion to be registered with cloud provider\" for (( i=0; i<${#MINION_NAMES[@]}; i++)); do COUNT=\"0\" until [ \"$COUNT\" -eq \"1\" ]; do $(dirname $0)/kubecfg.sh -template '{{range.Items}}{{.ID}}:{{end}}' list minions > /tmp/minions COUNT=$(grep -c ${MINION_NAMES[i]} /tmp/minions) || { printf \".\"; sleep 2; COUNT=\"0\"; } done done echo echo \"Kubernetes cluster created.\" echo echo \"Kubernetes cluster is running.  Access the master at:\" echo echo \"  https://${user}:${passwd}@${KUBE_MASTER_IP}\" </ins> } # Delete a kubernetes cluster function kube-down { <del> vagrant destroy -f </del> <ins> vagrant destroy -f </ins> } # Update a kubernetes cluster with latest source function kube-push { <del> vagrant provision </del> <ins> vagrant provision </ins> } # Execute prior to running tests to build a release if required for env function test-build-release { <del> echo \"Vagrant provider can skip release build\" </del> <ins> echo \"Vagrant provider can skip release build\" </ins> } # Execute prior to running tests to initialize required structure function test-setup { <del> echo \"Vagrant test setup complete\" </del> <ins> echo \"Vagrant test setup complete\" </ins> } # Execute after running tests to perform any required clean-up function test-teardown { <del> echo \"Vagrant ignores tear-down\" </del> <ins> echo \"Vagrant ignores tear-down\" </ins> } # Set the {user} and {password} environment values required to interact with provider function get-password { <del> export user=vagrant export passwd=vagrant echo \"Using credentials: $user:$passwd\" </del> <ins> export user=vagrant export passwd=vagrant echo \"Using credentials: $user:$passwd\" </ins> }", "commid": "kubernetes_pr_1155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b9fbe44fc01f631378bc467f73c902ae0e65f3298439f7434f4b3f0d323b9e8e", "query": "As a sysadmin When using the Vagrant cluster provided And logged in as the vagrant user to the master or minions I would like to be able to call docker commands wihout requiring the 'sudo' prefix. For Fedora =19 and RHEL=7 this can be enabled by adding the vagrant user to the docker group in /etc/groups\nThis should be trivial, but its tricker to do because of the whole salt configuration process as the docker group is only created on each kubernetes-minion once docker is installed by the salt-minion. To do this properly, we would need a salt state change for this, and new flag in to let you specify additional users that should be in the docker group.", "positive_passages": [{"docid": "doc-en-kubernetes-a2705aed7e9007718f2ef62b604c4ccd0380b585086a92b695ecbe989d1d0d66", "text": "'roles:kubernetes-pool-vsphere': - match: grain - static-routes <ins> 'roles:kubernetes-pool-vagrant': - match: grain - vagrant </ins>", "commid": "kubernetes_pr_1282"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b9fbe44fc01f631378bc467f73c902ae0e65f3298439f7434f4b3f0d323b9e8e", "query": "As a sysadmin When using the Vagrant cluster provided And logged in as the vagrant user to the master or minions I would like to be able to call docker commands wihout requiring the 'sudo' prefix. For Fedora =19 and RHEL=7 this can be enabled by adding the vagrant user to the docker group in /etc/groups\nThis should be trivial, but its tricker to do because of the whole salt configuration process as the docker group is only created on each kubernetes-minion once docker is installed by the salt-minion. To do this properly, we would need a salt state change for this, and new flag in to let you specify additional users that should be in the docker group.", "positive_passages": [{"docid": "doc-en-kubernetes-04e5bd356c557b98d8e015e8de5daab053b70313bf448a52cf22b41022efeb45", "text": "<ins> vagrant: user.present: - optional_groups: - docker - remove_groups: False - require: - pkg: docker-io </ins>", "commid": "kubernetes_pr_1282"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b9fbe44fc01f631378bc467f73c902ae0e65f3298439f7434f4b3f0d323b9e8e", "query": "As a sysadmin When using the Vagrant cluster provided And logged in as the vagrant user to the master or minions I would like to be able to call docker commands wihout requiring the 'sudo' prefix. For Fedora =19 and RHEL=7 this can be enabled by adding the vagrant user to the docker group in /etc/groups\nThis should be trivial, but its tricker to do because of the whole salt configuration process as the docker group is only created on each kubernetes-minion once docker is installed by the salt-minion. To do this properly, we would need a salt state change for this, and new flag in to let you specify additional users that should be in the docker group.", "positive_passages": [{"docid": "doc-en-kubernetes-137926659c3f142ee294c3f02865497aea6ae6f6fdf025f24431d037f7c82edd", "text": "etcd_servers: $MASTER_IP roles: - kubernetes-pool <ins> - kubernetes-pool-vagrant </ins> cbr-cidr: $MINION_IP_RANGE minion_ip: $MINION_IP EOF", "commid": "kubernetes_pr_1282"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a987b5e3b3353d21d7a8120b4ee9be1106a65ade9430df500d1a08c675d1ca1a", "query": "When creating replication controller (e.g. frontend php-redis from guestbook example), scheduler gets stuck and never recovers. This is a race, I have to run several times to see the error (A script to delete controller and pods, then create new controller, leave enough time in between for k8s to react). I've created PR for an attempted fix.\nI saw this too while following the guest book and creating the php/frontend step. In my case, I had 2 minions while the replication controller configuration had configured 3 replicas, so 2 pods got scheduled -each on another minion, the third pod had empty Host (saw that when doing 'list pods'), and the 3 of them were stuck in \"waiting\" status. I deleted the controller and the pods, fixed the configuration in json file to be 2 replicas and recreated the controller and everything worked. Does your fix take care of this use case? (too many replicas, too few minions/one of the pods is not scheduled)\nThis is different from your use case. If you have more replicas than minions, then the scheduler will get stuck for sure (with the error msg probably being 'failed to find a fit for pod'). AFAICT, it's not support yet.\nIf you remove the HostPorts, it should work for you. thanks for report.\n, thanks for your replies. I understand why it isn't working, but I'd expect one of the 2 options to happen instead of the current situation: the creation of replication controller if there are less minions than replicas, AND there is a hostPort property. In other words - validation of the content during creation. least schedule all replicas that can get a minion (in my case 2 out of 3) and leave only one at \"waiting\". Is there an issue open about the use case I describe?\nshould be true today. is less possible than it seems like-- minions can come and go, and become over or under loaded in the time between creation and when the pod shows up at the scheduler. So even if we check up front, we still have to check again later, and sometimes the first check will pass but not the second.", "positive_passages": [{"docid": "doc-en-kubernetes-f3959c6de3539f23b7d34fce4582fef8eb76afd91fb0856f55c645adaf76ec9c", "text": "return map[string][]api.Pod{}, err } for _, scheduledPod := range pods { <del> host := scheduledPod.CurrentState.Host </del> <ins> host := scheduledPod.DesiredState.Host </ins> machineToPods[host] = append(machineToPods[host], scheduledPod) } return machineToPods, nil", "commid": "kubernetes_pr_1752"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a987b5e3b3353d21d7a8120b4ee9be1106a65ade9430df500d1a08c675d1ca1a", "query": "When creating replication controller (e.g. frontend php-redis from guestbook example), scheduler gets stuck and never recovers. This is a race, I have to run several times to see the error (A script to delete controller and pods, then create new controller, leave enough time in between for k8s to react). I've created PR for an attempted fix.\nI saw this too while following the guest book and creating the php/frontend step. In my case, I had 2 minions while the replication controller configuration had configured 3 replicas, so 2 pods got scheduled -each on another minion, the third pod had empty Host (saw that when doing 'list pods'), and the 3 of them were stuck in \"waiting\" status. I deleted the controller and the pods, fixed the configuration in json file to be 2 replicas and recreated the controller and everything worked. Does your fix take care of this use case? (too many replicas, too few minions/one of the pods is not scheduled)\nThis is different from your use case. If you have more replicas than minions, then the scheduler will get stuck for sure (with the error msg probably being 'failed to find a fit for pod'). AFAICT, it's not support yet.\nIf you remove the HostPorts, it should work for you. thanks for report.\n, thanks for your replies. I understand why it isn't working, but I'd expect one of the 2 options to happen instead of the current situation: the creation of replication controller if there are less minions than replicas, AND there is a hostPort property. In other words - validation of the content during creation. least schedule all replicas that can get a minion (in my case 2 out of 3) and leave only one at \"waiting\". Is there an issue open about the use case I describe?\nshould be true today. is less possible than it seems like-- minions can come and go, and become over or under loaded in the time between creation and when the pod shows up at the scheduler. So even if we check up front, we still have to check again later, and sometimes the first check will pass but not the second.", "positive_passages": [{"docid": "doc-en-kubernetes-46b84c8226a3127ae7cfce6a2900a9480392f426f142978e647fd0c5a0aa1385", "text": "{CPU: 2000}, }, }, <ins> Host: \"machine1\", </ins> } cpuAndMemory := api.PodState{ Manifest: api.ContainerManifest{", "commid": "kubernetes_pr_1752"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a987b5e3b3353d21d7a8120b4ee9be1106a65ade9430df500d1a08c675d1ca1a", "query": "When creating replication controller (e.g. frontend php-redis from guestbook example), scheduler gets stuck and never recovers. This is a race, I have to run several times to see the error (A script to delete controller and pods, then create new controller, leave enough time in between for k8s to react). I've created PR for an attempted fix.\nI saw this too while following the guest book and creating the php/frontend step. In my case, I had 2 minions while the replication controller configuration had configured 3 replicas, so 2 pods got scheduled -each on another minion, the third pod had empty Host (saw that when doing 'list pods'), and the 3 of them were stuck in \"waiting\" status. I deleted the controller and the pods, fixed the configuration in json file to be 2 replicas and recreated the controller and everything worked. Does your fix take care of this use case? (too many replicas, too few minions/one of the pods is not scheduled)\nThis is different from your use case. If you have more replicas than minions, then the scheduler will get stuck for sure (with the error msg probably being 'failed to find a fit for pod'). AFAICT, it's not support yet.\nIf you remove the HostPorts, it should work for you. thanks for report.\n, thanks for your replies. I understand why it isn't working, but I'd expect one of the 2 options to happen instead of the current situation: the creation of replication controller if there are less minions than replicas, AND there is a hostPort property. In other words - validation of the content during creation. least schedule all replicas that can get a minion (in my case 2 out of 3) and leave only one at \"waiting\". Is there an issue open about the use case I describe?\nshould be true today. is less possible than it seems like-- minions can come and go, and become over or under loaded in the time between creation and when the pod shows up at the scheduler. So even if we check up front, we still have to check again later, and sometimes the first check will pass but not the second.", "positive_passages": [{"docid": "doc-en-kubernetes-372c9d87de6ea0cb06368e2b96c94eca4d59b034eddb2c083764aabbf65ed16a", "text": "{CPU: 2000, Memory: 3000}, }, }, <ins> Host: \"machine2\", </ins> } tests := []struct { pod          api.Pod", "commid": "kubernetes_pr_1752"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a987b5e3b3353d21d7a8120b4ee9be1106a65ade9430df500d1a08c675d1ca1a", "query": "When creating replication controller (e.g. frontend php-redis from guestbook example), scheduler gets stuck and never recovers. This is a race, I have to run several times to see the error (A script to delete controller and pods, then create new controller, leave enough time in between for k8s to react). I've created PR for an attempted fix.\nI saw this too while following the guest book and creating the php/frontend step. In my case, I had 2 minions while the replication controller configuration had configured 3 replicas, so 2 pods got scheduled -each on another minion, the third pod had empty Host (saw that when doing 'list pods'), and the 3 of them were stuck in \"waiting\" status. I deleted the controller and the pods, fixed the configuration in json file to be 2 replicas and recreated the controller and everything worked. Does your fix take care of this use case? (too many replicas, too few minions/one of the pods is not scheduled)\nThis is different from your use case. If you have more replicas than minions, then the scheduler will get stuck for sure (with the error msg probably being 'failed to find a fit for pod'). AFAICT, it's not support yet.\nIf you remove the HostPorts, it should work for you. thanks for report.\n, thanks for your replies. I understand why it isn't working, but I'd expect one of the 2 options to happen instead of the current situation: the creation of replication controller if there are less minions than replicas, AND there is a hostPort property. In other words - validation of the content during creation. least schedule all replicas that can get a minion (in my case 2 out of 3) and leave only one at \"waiting\". Is there an issue open about the use case I describe?\nshould be true today. is less possible than it seems like-- minions can come and go, and become over or under loaded in the time between creation and when the pod shows up at the scheduler. So even if we check up front, we still have to check again later, and sometimes the first check will pass but not the second.", "positive_passages": [{"docid": "doc-en-kubernetes-34a15a11d883ec2f0419d3400e0d9e285eda5150fbd4a825490cf895a25a93c5", "text": "expectedList: []HostPriority{{\"machine1\", 0}, {\"machine2\", 0}}, test:         \"no resources requested\", pods: []api.Pod{ <del> {CurrentState: machine1State, Labels: labels2}, {CurrentState: machine1State, Labels: labels1}, {CurrentState: machine2State, Labels: labels1}, {CurrentState: machine2State, Labels: labels1}, </del> <ins> {DesiredState: machine1State, Labels: labels2}, {DesiredState: machine1State, Labels: labels1}, {DesiredState: machine2State, Labels: labels1}, {DesiredState: machine2State, Labels: labels1}, </ins> }, }, {", "commid": "kubernetes_pr_1752"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a987b5e3b3353d21d7a8120b4ee9be1106a65ade9430df500d1a08c675d1ca1a", "query": "When creating replication controller (e.g. frontend php-redis from guestbook example), scheduler gets stuck and never recovers. This is a race, I have to run several times to see the error (A script to delete controller and pods, then create new controller, leave enough time in between for k8s to react). I've created PR for an attempted fix.\nI saw this too while following the guest book and creating the php/frontend step. In my case, I had 2 minions while the replication controller configuration had configured 3 replicas, so 2 pods got scheduled -each on another minion, the third pod had empty Host (saw that when doing 'list pods'), and the 3 of them were stuck in \"waiting\" status. I deleted the controller and the pods, fixed the configuration in json file to be 2 replicas and recreated the controller and everything worked. Does your fix take care of this use case? (too many replicas, too few minions/one of the pods is not scheduled)\nThis is different from your use case. If you have more replicas than minions, then the scheduler will get stuck for sure (with the error msg probably being 'failed to find a fit for pod'). AFAICT, it's not support yet.\nIf you remove the HostPorts, it should work for you. thanks for report.\n, thanks for your replies. I understand why it isn't working, but I'd expect one of the 2 options to happen instead of the current situation: the creation of replication controller if there are less minions than replicas, AND there is a hostPort property. In other words - validation of the content during creation. least schedule all replicas that can get a minion (in my case 2 out of 3) and leave only one at \"waiting\". Is there an issue open about the use case I describe?\nshould be true today. is less possible than it seems like-- minions can come and go, and become over or under loaded in the time between creation and when the pod shows up at the scheduler. So even if we check up front, we still have to check again later, and sometimes the first check will pass but not the second.", "positive_passages": [{"docid": "doc-en-kubernetes-dcf0382711b8744399fbfdf088830137ab3c091eba6b4a21deceaa2a9aed1bc9", "text": "expectedList: []HostPriority{{\"machine1\", 37 /* int(75% / 2) */}, {\"machine2\", 62 /* int( 75% + 50% / 2) */}}, test:         \"no resources requested\", pods: []api.Pod{ <del> {DesiredState: cpuOnly, CurrentState: machine1State}, {DesiredState: cpuAndMemory, CurrentState: machine2State}, </del> <ins> {DesiredState: cpuOnly}, {DesiredState: cpuAndMemory}, </ins> }, }, {", "commid": "kubernetes_pr_1752"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a987b5e3b3353d21d7a8120b4ee9be1106a65ade9430df500d1a08c675d1ca1a", "query": "When creating replication controller (e.g. frontend php-redis from guestbook example), scheduler gets stuck and never recovers. This is a race, I have to run several times to see the error (A script to delete controller and pods, then create new controller, leave enough time in between for k8s to react). I've created PR for an attempted fix.\nI saw this too while following the guest book and creating the php/frontend step. In my case, I had 2 minions while the replication controller configuration had configured 3 replicas, so 2 pods got scheduled -each on another minion, the third pod had empty Host (saw that when doing 'list pods'), and the 3 of them were stuck in \"waiting\" status. I deleted the controller and the pods, fixed the configuration in json file to be 2 replicas and recreated the controller and everything worked. Does your fix take care of this use case? (too many replicas, too few minions/one of the pods is not scheduled)\nThis is different from your use case. If you have more replicas than minions, then the scheduler will get stuck for sure (with the error msg probably being 'failed to find a fit for pod'). AFAICT, it's not support yet.\nIf you remove the HostPorts, it should work for you. thanks for report.\n, thanks for your replies. I understand why it isn't working, but I'd expect one of the 2 options to happen instead of the current situation: the creation of replication controller if there are less minions than replicas, AND there is a hostPort property. In other words - validation of the content during creation. least schedule all replicas that can get a minion (in my case 2 out of 3) and leave only one at \"waiting\". Is there an issue open about the use case I describe?\nshould be true today. is less possible than it seems like-- minions can come and go, and become over or under loaded in the time between creation and when the pod shows up at the scheduler. So even if we check up front, we still have to check again later, and sometimes the first check will pass but not the second.", "positive_passages": [{"docid": "doc-en-kubernetes-a4a702dd6323660ceb6ec0175d4b7ac1325e2ce32c22c8373aee95551a31c4ab", "text": "expectedList: []HostPriority{{\"machine1\", 0}, {\"machine2\", 0}}, test:         \"zero minion resources\", pods: []api.Pod{ <del> {DesiredState: cpuOnly, CurrentState: machine1State}, {DesiredState: cpuAndMemory, CurrentState: machine2State}, </del> <ins> {DesiredState: cpuOnly}, {DesiredState: cpuAndMemory}, </ins> }, }, }", "commid": "kubernetes_pr_1752"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4bb1462c8ab8a913aa37a2b81374b4383daa9203c50249aab71f7ef3e87e35d5", "query": "the file and line for these log statements is in the That's not helpful I1031 11:09:06. ] 'foo' has no storage object I1031 11:09:06. ] 'pods' is not a redirector I'd rather see Maybe use runtime.Caller in httplog to somehow fake the log to come from the caller's file/line.\nYeah-- actually this should be a feature of the glog package. Would be awesome to do:\nFollowup: glog is an opensource copy of a google-internal library; there's already something enabling this internally; we'll try to get a new version pushed externally in the next week or so. Then we can fix this.\nAwesome. On Oct 31, 2014 2:53 PM, \"Daniel Smith\" wrote:\nshould meet your requirements.\n+1, I would love to have this.", "positive_passages": [{"docid": "doc-en-kubernetes-7698bb34ffd9ec8a6d11e5fd2cee506f6fa6228ef67d6aaf07fe94d8c787c421", "text": "// Addf logs info immediately. func (passthroughLogger) Addf(format string, data ...interface{}) { <del> glog.Infof(format, data...) </del> <ins> glog.InfoDepth(1, fmt.Sprintf(format, data...)) </ins> } // DefaultStacktracePred is the default implementation of StacktracePred.", "commid": "kubernetes_pr_2917"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4bb1462c8ab8a913aa37a2b81374b4383daa9203c50249aab71f7ef3e87e35d5", "query": "the file and line for these log statements is in the That's not helpful I1031 11:09:06. ] 'foo' has no storage object I1031 11:09:06. ] 'pods' is not a redirector I'd rather see Maybe use runtime.Caller in httplog to somehow fake the log to come from the caller's file/line.\nYeah-- actually this should be a feature of the glog package. Would be awesome to do:\nFollowup: glog is an opensource copy of a google-internal library; there's already something enabling this internally; we'll try to get a new version pushed externally in the next week or so. Then we can fix this.\nAwesome. On Oct 31, 2014 2:53 PM, \"Daniel Smith\" wrote:\nshould meet your requirements.\n+1, I would love to have this.", "positive_passages": [{"docid": "doc-en-kubernetes-ae3ad765b06428df0b1a5022cd02406f89d573d141b4922d9688e14d7bd0c4d2", "text": "// Log is intended to be called once at the end of your request handler, via defer func (rl *respLogger) Log() { latency := time.Since(rl.startTime) <del> glog.V(2).Infof(\"%s %s: (%v) %v%v%v\", rl.req.Method, rl.req.RequestURI, latency, rl.status, rl.statusStack, rl.addedInfo) </del> <ins> if glog.V(2) { glog.InfoDepth(1, fmt.Sprintf(\"%s %s: (%v) %v%v%v\", rl.req.Method, rl.req.RequestURI, latency, rl.status, rl.statusStack, rl.addedInfo)) } </ins> } // Header implements http.ResponseWriter.", "commid": "kubernetes_pr_2917"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cbed3b419c4c061a7654b2a666cebe928bfe0af38a566faf794d9f808fca93d4", "query": "I suspect this is dues to the recent change to container VMs as the base image? ifconfig docker0 - exists but should not. iptables-save | grep docker - 4 docker rules that should not exist.\nIs this still relevant?\nwas still a containervm turd the last time I checked. It's just not causing any harm.\nYeah, no harm, just ugly. , Zach Loafman wrote:\nI think we should remove the docker0 from minion nodes, but do we still need this for master node? cc/\nThis is required by running etcd server as pod with flannel on gce nodes. Please sync your cluster with this fix.", "positive_passages": [{"docid": "doc-en-kubernetes-61d2511b799716e3fd58db162df560893be639b45fe46cdd70cc01a9fe45639f", "text": "echo \"    echo 'Waiting for metadata MINION_IP_RANGE...'\" echo \"    sleep 3\" echo \"done\" <ins> echo \"\" echo \"# Remove docker artifacts on minion nodes\" echo \"iptables -t nat -F\" echo \"ifconfig docker0 down\" echo \"brctl delbr docker0\" echo \"\" </ins> echo \"EXTRA_DOCKER_OPTS='${EXTRA_DOCKER_OPTS}'\" echo \"ENABLE_DOCKER_REGISTRY_CACHE='${ENABLE_DOCKER_REGISTRY_CACHE:-false}'\" grep -v \"^#\" \"${KUBE_ROOT}/cluster/gce/templates/common.sh\"", "commid": "kubernetes_pr_4976"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3a47714aea9d63183fb02abaef06e69a4e2b29d7c7283e834a03eb83ec0694c5", "query": "It looks like we always try and hit the metadata server even if we aren't on GCE. We then print an error out. This should either be silent (assume after X attempts that we aren't on GCE?) or should only be activated with an option. Email thread: !topic/google-containers/w-ei5Xs6K0Y\ncc:\nFYI, the way the credentialprovider logic is set up, providers are asked once per keyring creation whether they are enabled. If they are enabled, then they are asked to provide their contribution to .dockercfg each time the lazy keyring is accessed. For efficiency, there is a caching provider, which composes with heavier providers and stores their .dockercfg contribution for a predetermined TTL. What was happening here was that \"Enabled()\" for our GCE-metadata implementations was logging about errors fetching \"http://metadata\", where the entire \"Enabled()\" check is \"err == nil\".\nI believe that this was fixed by", "positive_passages": [{"docid": "doc-en-kubernetes-b3bc097dba99bc444f17af7a6f314791a179e75e7dda6e34b492903e2787f6bd", "text": "return readDockerConfigFileFromBytes(contents) } <ins> // HttpError wraps a non-StatusOK error code as an error. type HttpError struct { StatusCode int Url        string } // Error implements error func (he *HttpError) Error() string { return fmt.Sprintf(\"http status code: %d while fetching url %s\", he.StatusCode, he.Url) } </ins> func ReadUrl(url string, client *http.Client, header *http.Header) (body []byte, err error) { req, err := http.NewRequest(\"GET\", url, nil) if err != nil { <del> glog.Errorf(\"while creating request to read %s: %v\", url, err) </del> return nil, err } if header != nil {", "commid": "kubernetes_pr_2674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3a47714aea9d63183fb02abaef06e69a4e2b29d7c7283e834a03eb83ec0694c5", "query": "It looks like we always try and hit the metadata server even if we aren't on GCE. We then print an error out. This should either be silent (assume after X attempts that we aren't on GCE?) or should only be activated with an option. Email thread: !topic/google-containers/w-ei5Xs6K0Y\ncc:\nFYI, the way the credentialprovider logic is set up, providers are asked once per keyring creation whether they are enabled. If they are enabled, then they are asked to provide their contribution to .dockercfg each time the lazy keyring is accessed. For efficiency, there is a caching provider, which composes with heavier providers and stores their .dockercfg contribution for a predetermined TTL. What was happening here was that \"Enabled()\" for our GCE-metadata implementations was logging about errors fetching \"http://metadata\", where the entire \"Enabled()\" check is \"err == nil\".\nI believe that this was fixed by", "positive_passages": [{"docid": "doc-en-kubernetes-6b5c235cd01619ad8e36ace30dd56047eada04de549b796b673e294b4294c902", "text": "} resp, err := client.Do(req) if err != nil { <del> glog.Errorf(\"while trying to read %s: %v\", url, err) </del> return nil, err } defer resp.Body.Close() if resp.StatusCode != http.StatusOK { <del> err := fmt.Errorf(\"http status code: %d while fetching url %s\", resp.StatusCode, url) glog.Errorf(\"while trying to read %s: %v\", url, err) </del> glog.V(2).Infof(\"body of failing http response: %v\", resp.Body) <del> return nil, err </del> <ins> return nil, &HttpError{ StatusCode: resp.StatusCode, Url:        url, } </ins> } contents, err := ioutil.ReadAll(resp.Body) if err != nil { <del> glog.Errorf(\"while trying to read %s: %v\", url, err) </del> return nil, err }", "commid": "kubernetes_pr_2674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3a47714aea9d63183fb02abaef06e69a4e2b29d7c7283e834a03eb83ec0694c5", "query": "It looks like we always try and hit the metadata server even if we aren't on GCE. We then print an error out. This should either be silent (assume after X attempts that we aren't on GCE?) or should only be activated with an option. Email thread: !topic/google-containers/w-ei5Xs6K0Y\ncc:\nFYI, the way the credentialprovider logic is set up, providers are asked once per keyring creation whether they are enabled. If they are enabled, then they are asked to provide their contribution to .dockercfg each time the lazy keyring is accessed. For efficiency, there is a caching provider, which composes with heavier providers and stores their .dockercfg contribution for a predetermined TTL. What was happening here was that \"Enabled()\" for our GCE-metadata implementations was logging about errors fetching \"http://metadata\", where the entire \"Enabled()\" check is \"err == nil\".\nI believe that this was fixed by", "positive_passages": [{"docid": "doc-en-kubernetes-1ce57414992a7ad2b8a61e9d6358e24d096c58632cbf3d94233c449cf6b79991", "text": "func (g *dockerConfigKeyProvider) Provide() credentialprovider.DockerConfig { // Read the contents of the google-dockercfg metadata key and // parse them as an alternate .dockercfg <del> if cfg, err := credentialprovider.ReadDockerConfigFileFromUrl(dockerConfigKey, g.Client, metadataHeader); err == nil { </del> <ins> if cfg, err := credentialprovider.ReadDockerConfigFileFromUrl(dockerConfigKey, g.Client, metadataHeader); err != nil { glog.Errorf(\"while reading 'google-dockercfg' metadata: %v\", err) } else { </ins> return cfg }", "commid": "kubernetes_pr_2674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3a47714aea9d63183fb02abaef06e69a4e2b29d7c7283e834a03eb83ec0694c5", "query": "It looks like we always try and hit the metadata server even if we aren't on GCE. We then print an error out. This should either be silent (assume after X attempts that we aren't on GCE?) or should only be activated with an option. Email thread: !topic/google-containers/w-ei5Xs6K0Y\ncc:\nFYI, the way the credentialprovider logic is set up, providers are asked once per keyring creation whether they are enabled. If they are enabled, then they are asked to provide their contribution to .dockercfg each time the lazy keyring is accessed. For efficiency, there is a caching provider, which composes with heavier providers and stores their .dockercfg contribution for a predetermined TTL. What was happening here was that \"Enabled()\" for our GCE-metadata implementations was logging about errors fetching \"http://metadata\", where the entire \"Enabled()\" check is \"err == nil\".\nI believe that this was fixed by", "positive_passages": [{"docid": "doc-en-kubernetes-c49221226005afebb55e5b8c82f053a20a3e44eeaaba4e089fc1c0ea9e33bb0b", "text": "// Provide implements DockerConfigProvider func (g *dockerConfigUrlKeyProvider) Provide() credentialprovider.DockerConfig { // Read the contents of the google-dockercfg-url key and load a .dockercfg from there <del> if url, err := credentialprovider.ReadUrl(dockerConfigUrlKey, g.Client, metadataHeader); err == nil { </del> <ins> if url, err := credentialprovider.ReadUrl(dockerConfigUrlKey, g.Client, metadataHeader); err != nil { glog.Errorf(\"while reading 'google-dockercfg-url' metadata: %v\", err) } else { </ins> if strings.HasPrefix(string(url), \"http\") { <del> if cfg, err := credentialprovider.ReadDockerConfigFileFromUrl(string(url), g.Client, nil); err == nil { </del> <ins> if cfg, err := credentialprovider.ReadDockerConfigFileFromUrl(string(url), g.Client, nil); err != nil { glog.Errorf(\"while reading 'google-dockercfg-url'-specified url: %s, %v\", string(url), err) } else { </ins> return cfg } } else {", "commid": "kubernetes_pr_2674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3a47714aea9d63183fb02abaef06e69a4e2b29d7c7283e834a03eb83ec0694c5", "query": "It looks like we always try and hit the metadata server even if we aren't on GCE. We then print an error out. This should either be silent (assume after X attempts that we aren't on GCE?) or should only be activated with an option. Email thread: !topic/google-containers/w-ei5Xs6K0Y\ncc:\nFYI, the way the credentialprovider logic is set up, providers are asked once per keyring creation whether they are enabled. If they are enabled, then they are asked to provide their contribution to .dockercfg each time the lazy keyring is accessed. For efficiency, there is a caching provider, which composes with heavier providers and stores their .dockercfg contribution for a predetermined TTL. What was happening here was that \"Enabled()\" for our GCE-metadata implementations was logging about errors fetching \"http://metadata\", where the entire \"Enabled()\" check is \"err == nil\".\nI believe that this was fixed by", "positive_passages": [{"docid": "doc-en-kubernetes-654cfee1af2701040a81e275a84f9457c9a5b22b4da527179ad1d1646b217f59", "text": "tokenJsonBlob, err := credentialprovider.ReadUrl(metadataToken, g.Client, metadataHeader) if err != nil { <ins> glog.Errorf(\"while reading access token endpoint: %v\", err) </ins> return cfg } email, err := credentialprovider.ReadUrl(metadataEmail, g.Client, metadataHeader) if err != nil { <ins> glog.Errorf(\"while reading email endpoint: %v\", err) </ins> return cfg }", "commid": "kubernetes_pr_2674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-142e8decd8d12f564814b0a08026ec0c2500ddcd8040f0182edc6a7f51b222f8", "query": "0/8 is with a company's intranet, so it can be insecure. This is similiar to \"For GCE, allow insecure registries anywhere in 10.0.0.0/8\" Thanks!\nLinking to and .\nThis was", "positive_passages": [{"docid": "doc-en-kubernetes-5bdb878a76504e2bf239961639672bc380bb42b9bd2322c9afb7439331c98d3f", "text": "# Optional: Enable node logging. ENABLE_NODE_LOGGING=true LOGGING_DESTINATION=elasticsearch # options: elasticsearch, gcp <ins> # Don't require https for registries in our local RFC1918 network EXTRA_DOCKER_OPTS=\"--insecure-registry 10.0.0.0/8\" </ins>", "commid": "kubernetes_pr_2620"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-142e8decd8d12f564814b0a08026ec0c2500ddcd8040f0182edc6a7f51b222f8", "query": "0/8 is with a company's intranet, so it can be insecure. This is similiar to \"For GCE, allow insecure registries anywhere in 10.0.0.0/8\" Thanks!\nLinking to and .\nThis was", "positive_passages": [{"docid": "doc-en-kubernetes-9d730cd43a86d1d194c08a666b7c4ea237baff9e736083247c4b512d4bfaccff", "text": "LOGGING_DESTINATION=elasticsearch # options: elasticsearch, gcp ENABLE_CLUSTER_MONITORING=false <ins> # Don't require https for registries in our local RFC1918 network EXTRA_DOCKER_OPTS=\"--insecure-registry 10.0.0.0/8\" </ins>", "commid": "kubernetes_pr_2620"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-142e8decd8d12f564814b0a08026ec0c2500ddcd8040f0182edc6a7f51b222f8", "query": "0/8 is with a company's intranet, so it can be insecure. This is similiar to \"For GCE, allow insecure registries anywhere in 10.0.0.0/8\" Thanks!\nLinking to and .\nThis was", "positive_passages": [{"docid": "doc-en-kubernetes-e2b8f67c6c6914e7094a331cffc57628b1c018982fe24aca865cb2743d3b3c14", "text": "cloud: gce EOF <ins> DOCKER_OPTS=\"\" if [[ -n \"${EXTRA_DOCKER_OPTS-}\" ]]; then DOCKER_OPTS=\"${EXTRA_DOCKER_OPTS}\" fi </ins> # Decide if enable the cache <del> if [[ \"${ENABLE_DOCKER_REGISTRY_CACHE}\" == \"true\" ]]; then </del> <ins> if [[ \"${ENABLE_DOCKER_REGISTRY_CACHE}\" == \"true\" ]]; then </ins> REGION=$(echo \"${ZONE}\" | cut -f 1,2 -d -) echo \"Enable docker registry cache at region: \" $REGION <del> DOCKER_OPTS=\"--registry-mirror=\"https://${REGION}.docker-cache.clustermaster.net\"\" </del> <ins> DOCKER_OPTS=\"${DOCKER_OPTS} --registry-mirror='https://${REGION}.docker-cache.clustermaster.net'\" fi </ins> <del> cat <<EOF >>/etc/salt/minion.d/grains.conf </del> <ins> if [[ -n \"{DOCKER_OPTS}\" ]]; then cat <<EOF >>/etc/salt/minion.d/grains.conf </ins> docker_opts: $DOCKER_OPTS EOF fi", "commid": "kubernetes_pr_2620"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-142e8decd8d12f564814b0a08026ec0c2500ddcd8040f0182edc6a7f51b222f8", "query": "0/8 is with a company's intranet, so it can be insecure. This is similiar to \"For GCE, allow insecure registries anywhere in 10.0.0.0/8\" Thanks!\nLinking to and .\nThis was", "positive_passages": [{"docid": "doc-en-kubernetes-5d98b5dccb9509ca8d0bdfb67b6e15c16ed4a7753c80e3325ec0e19fe46263d7", "text": "echo \"ZONE='${ZONE}'\" echo \"MASTER_NAME='${MASTER_NAME}'\" echo \"MINION_IP_RANGE='${MINION_IP_RANGES[$i]}'\" <ins> echo \"EXTRA_DOCKER_OPTS='${EXTRA_DOCKER_OPTS}'\" </ins> echo \"ENABLE_DOCKER_REGISTRY_CACHE='${ENABLE_DOCKER_REGISTRY_CACHE:-false}'\" grep -v \"^#\" \"${KUBE_ROOT}/cluster/gce/templates/common.sh\" grep -v \"^#\" \"${KUBE_ROOT}/cluster/gce/templates/salt-minion.sh\"", "commid": "kubernetes_pr_2620"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-142e8decd8d12f564814b0a08026ec0c2500ddcd8040f0182edc6a7f51b222f8", "query": "0/8 is with a company's intranet, so it can be insecure. This is similiar to \"For GCE, allow insecure registries anywhere in 10.0.0.0/8\" Thanks!\nLinking to and .\nThis was", "positive_passages": [{"docid": "doc-en-kubernetes-fe8f820400f1edc5d05f4f6403cece3f14d841eec9396013f16753e8c8aa16bf", "text": "<ins> DOCKER_OPTS=\"\" </ins> {% if grains.docker_opts is defined %} <del> {% set docker_opts = grains.docker_opts %} {% else %} {% set docker_opts = \"\" %} </del> <ins> DOCKER_OPTS=\"${DOCKER_OPTS} {{grains.docker_opts}}\" </ins> {% endif %} <del> DOCKER_OPTS=\"{{docker_opts}} --bridge cbr0 --iptables=false --ip-masq=false -r=false\" </del> <ins> DOCKER_OPTS=\"${DOCKER_OPTS} --bridge cbr0 --iptables=false --ip-masq=false -r=false\" </ins>", "commid": "kubernetes_pr_2620"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c802a37aad85dfdce2d6232f30f1e039273d58e19f8aa63b8acb725eeb2b6040", "query": "it's impossible to GET replication controllers on v3. on v1 on the same server it works fine. example request: GET on http://localhost:8080/api/v1beta3/replicationControllers returns 404 http://localhost:8080/api/v1beta1/replicationControllers returns 200\nv1beta3 moved to all lower case URL Would give that a try first Sent from my iPhone\nlooks like it's working. but it breaks backwards for clients who worked with v1. For instance, in my gem I can't now smoothly work with both versions because I need to treat the name of the resource differently. why don't at least redirect those who call replicationControllers to the lowercase too? Also, there's no way to know which resources are available and their names. A lot of REST api on their most top level at least publish the links to main resources, but if I call: http://localhost:8080/api/v1beta3/ it returns 404\nBecause we are actively trying to drop support for mixed case prior to 1.0, I did not continue supporting the old url paths. If you look at the go client, we have a \"legacy\" flag we use to control this and a few other behaviors.\nwell yes, but breaking backwards creates more work for the users... more \"if this version ...\" kind of stuff.\nWe got v1bet1/2 wrong and don't want to carry it forever. Stopping it early before v1 is our priority.\nok :( are the REST apis going through any kind of design review or code review?\nv1beta1 is really an alpha quality API. It grew organically and did not go through any kind of design review, as evidenced by the many issues you've filed. We want to get rid of it ASAP. We intend v1beta3 to be the \"release candidate\" for the v1 API, which will be the stable API. As for knowing what exists, you can now browse or GET . Additionally, pull is in progress, and will return a list of valid paths to GET .\nthanks. will check swagger for now", "positive_passages": [{"docid": "doc-en-kubernetes-fe567d9cf78409720bcbb87b1ad6339cb18b53dd88041da1d575419b6cc2df05", "text": "<ins> # The Kubernetes API Primary system and API concepts are documented in the [User guide](user-guide.md). Overall API conventions are described in the [API conventions doc](api-conventions.md). Complete API details are documented via [Swagger](http://swagger.io/). The Kubernetes apiserver (aka \"master\") exports an API that can be used to retrieve the [Swagger spec](https://github.com/swagger-api/swagger-spec/tree/master/schemas/v1.2) for the Kubernetes API, by default at `/swaggerapi`, and a UI you can use to browse the API documentation at `/swaggerui`. We also periodically update a [statically generated UI](http://kubernetes.io/third_party/swagger-ui/). Remote access to the API is discussed in the [access doc](accessing_the_api.md). The Kubernetes API also serves as the foundation for the declarative configuration schema for the system. The [Kubectl](kubectl.md) command-line tool can be used to create, update, delete, and get API objects. Kubernetes also stores its serialized state (currently in [etcd](https://coreos.com/docs/distributed-configuration/getting-started-with-etcd/)) in terms of the API resources. Kubernetes itself is decomposed into multiple components, which interact through its API. ## API changes In our experience, any system that is successful needs to grow and change as new use cases emerge or existing ones change. Therefore, we expect the Kubernetes API to continuously change and grow. However, we intend to not break compatibility with existing clients, for an extended period of time. In general, new API resources and new resource fields can be expected to be added frequently. Elimination of resources or fields will require following a deprecation process. The precise deprecation policy for eliminating features is TBD, but once we reach our 1.0 milestone, there will be a specific policy. What constitutes a compatible change and how to change the API are detailed by the [API change document](devel/api_changes.md). ## API versioning Fine-grain resource evolution alone makes it difficult to eliminate fields or restructure resource representations. Therefore, Kubernetes supports multiple API versions, each at a different API path prefix, such as `/api/v1beta3`. These are simply different interfaces to read and/or modify the same underlying resources. In general, all API resources are accessible via all API versions, though there may be some cases in the future where that is not true. Distinct API versions present more clear, consistent views of system resources and behavior than intermingled, independently evolved resources. They also provide a more straightforward mechanism for controlling access to end-of-lifed and/or experimental APIs. The [API and release versioning proposal](versioning.md) describes the current thinking on the API version evolution process. ## v1beta1 and v1beta2 are deprecated; please move to v1beta3 ASAP As of April 1, 2015, the Kubernetes v1beta3 API has been enabled by default, and the v1beta1 and v1beta2 APIs are deprecated. v1beta3 should be considered the v1 release-candidate API, and the v1 API is expected to be substantially similar. As \"pre-release\" APIs, v1beta1, v1beta2, and v1beta3 will be eliminated once the v1 API is available, by the end of June 2015. ## v1beta3 conversion tips We're working to convert all documentation and examples to v1beta3. Most examples already contain a v1beta3 subdirectory with the API objects translated to v1beta3. A simple [API conversion tool](cluster_management.md#switching-your-config-files-to-a-new-api-version) has been written to simplify the translation process. Use `kubectl create --validate` in order to validate your json or yaml against our Swagger spec. Some important differences between v1beta1/2 and v1beta3: * The resource `id` is now called `name`. * `name`, `labels`, `annotations`, and other metadata are now nested in a map called `metadata` * `desiredState` is now called `spec`, and `currentState` is now called `status` * `/minions` has been moved to `/nodes`, and the resource has kind `Node` * The namespace is required (for all namespaced resources) and has moved from a URL parameter to the path: `/api/v1beta3/namespaces/{namespace}/{resource_collection}/{resource_name}` * The names of all resource collections are now lower cased - instead of `replicationControllers`, use `replicationcontrollers`. * To watch for changes to a resource, open an HTTP or Websocket connection to the collection URL and provide the `?watch=true` URL parameter along with the desired `resourceVersion` parameter to watch from. * The container `entrypoint` has been renamed to `command`, and `command` has been renamed to `args`. * Container, volume, and node resources are expressed as nested maps (e.g., `resources{cpu:1}`) rather than as individual fields, and resource values support [scaling suffixes](resources.md#resource-quantities) rather than fixed scales (e.g., milli-cores). * Restart policy is represented simply as a string (e.g., \"Always\") rather than as a nested map (\"always{}\"). * The volume `source` is inlined into `volume` rather than nested. </ins>", "commid": "kubernetes_pr_6391"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-988dd0ceccf3dcde8b8ea1670f138b61545b1a8185bf62f096fafbe67e654232", "query": "For example, kubernetes-ro service appears with empty selector (this service was created by the hack/local cluster) - is that ok? What meaning such service has if it has no entity to fwd traffic to?\nkubernetes and kubernetes-ro are currently \"virtual\" - they are not backed by running pods, but by the master itself. , abonas wrote:\nif that's internal impl, why is it exposed to user? let's say a client pulls all entities and builds a UI around it. then a service with no selector arrives, and it's internal to kube - how the client should know not to present it/touch it? (similar to the \"net\" container in pods)\nIt's exposed exactly FOR users - so they can find the apiserver. It has a corresponding Endpoints object, it gets a portal IP and a kube-proxy rule, and it gets service env vars and a DNS name. The fact that it is virtual is an implementation detail. That it exists is all users should need to know. , abonas wrote:\nAnd FWIW, the master components may one day actually be pods... , Tim Hockin wrote:\nthanks for the explanation. so any general rule how to distinguish kube pods/services from user defined?\nDo we need to distinguish them? We could add labels, I guess, if it is really important to distinguish them.\nsometimes users would want to see only the things they defined and not implementation details of the system.\nOne could argue this is why the users should be using labels. I'm not against defining labels for \"special\" stuff, but it's new territory, so we should enter with caution. , abonas wrote:\nI think the right answer might be to put them in a special \"cluster\" or \"system\" namespace. , Tim Hockin wrote:\nSee If we put them in a \"kubernetes\" ns, the DNS name would be :) I'm not against segmenting them into a different namespace. We just need to decide on what that namespace is called, plumb through that configuration, decide on compatibility for a short while or not, and decide if that namespace is \"special\" or just \"different\" - i.e. should the skydns, heapster, etc pods go into this namespace? , Brendan Burns wrote:\nAs said, the services are there for applications that need to contact the apiserver. Additionally, nil selectors can be used by users to import external services. Adding labels to the kubernetes services won't help. Users need to manage their objects using labels. /cc\nYeah, lots of consumers will expose \"special\" services. IN fact, in many clusters the \"special\" services will outweigh the unspecial ones. At this point, the namespace they are in is completely arbitrary, and I think because it is a name, it should be free for the end user to choose where they are surfaced.\nPer the proposal here: , I think the namespace should continue to hold these services, and they require no special labels. I sense comment is made without thinking through what Kubernetes operators do to bootstrap a cluster. I think it's reasonable that namespace holds everything you need to run, and operators may or may not choose to segment their data in other namespaces. If they want to not see this information, its an exact reason for why they should use their own namespace. I don't think we need anything new here.\n- I'm not clear on your meaning. Did you mean that we should make the \"cluster admin\" namespace a config param that everyone knows about and can be different cluster-to-cluster? Or did you mean that default is as arbitrary a name as any other? I'd be fine moving things out of default into \"kube\" or \"kubernetes\" or \"cluster\" or something, but I am less convinced that a flag is a good thing. , Clayton Coleman wrote:\n- wherever we stick this stuff, it should be the namespace that is initially bootstrapped, which today is . I continue to believe that is as good a name as any other. I do not see a need to do more here.\nI think as soon as you bring naming into the picture, making decisions based on names gets very tricky (what if I want my logging service to be everywhere?). If there is a magic namespace that exposes things to the rest of the cluster, we should ask whether there's only one magic namespace, or multiple? Are services supposed to cross namespaces? It's great that pods can find the master... but that's not the only thing they'll need to find in each namespace. And baking in special names (or customizable names) into your app code is fragile, because then your code only works inside Kubernetes. I'm just trying to pump the brakes on special services prior to us designing them... :) ----- Original Message -----\noh, to be clear, I don't want \"special\" services - I am merely asking if moving non-user-defined objects (where that is defined very loosely) out of \"default\" is worthwhile. I tend to agree with Derek that it's not worth energy. , Clayton Coleman wrote:\nagree with you that lots of consumers will expose \"special\" services We should not use the (namespace + k8s-service + skydns) mechanism for publishing the location of those special services. We should decouple the choice of namespace to run the pods of the service in from the well-known dns address of special services. Otherwise, it will be hard to move the pods of the service to another namespace, which people will definitely want to do as they grow. Instead, we need a place to publish well-known services which is not tied to the namespace of the pods of that service.\nyou open a whole new topic. I've noodled with the idea of a Name resource type. We would generate a Name for each Service as \"service.namespace\", but users could also add their own Name resources. , Eric Tune wrote:\nI'd like to understand better your comment regarding nil selectors used to export external services - can you elaborate? give an example? my understanding is that service redirects traffic to pods based on labels. with nil selector service does nothing, so why is it a service in the first place? I'm pro decoupling special services/internal implementation services from user defined entities. whether by separate namespace, or by saying that the default namespace is reserved, or by any other solution. because otherwise internal implementation and user defined content are mixed and that's no good for a proper management. just tagging you so you could see this issue and the related discussions.\nServices abstract backends - they don't have to abstract pods. Some examples: You want to have an external database cluster in production, but in test you use your own databases. You would have a service for both and use the environment variables, but the production service has a nil selector with its endpoints set to the database cluster. You want to have an empty service because you're reserving a name (that isn't accessible yet) but will be in the future You want to point your service to a service in another namespace or on another cluster. You set the endpoints for your service to the publicIPs of the other service. ----- Original Message -----\n, thanks. regarding the last point - I was under impression (based on some other discussion) that there would not be cross namespace interaction? that entities can can access only entities in the same namespace?\nCross-namespace is currently allowed and I think has to be allowed, though perhaps (in the fullness of time) that can be policy based rather than wide open. , abonas wrote:\nplease see this correspondence. my understanding is that there is isolation\nResponded there. I think there's some less-than-crystal-clear words in play. , abonas wrote:\n+1 to Eric's comment about ensuring there is a consistent manner for system services like kubernetes-ro, if that's not fixes for all clusters it's going to be a nightmare to write reusable containers for multiple different clusters. I don't care if we do that by using a constant namespace, or by giving system services two different names, but there needs to be at least one name that is constant. Regarding default vs. cluster namespace, I think the issue is one of clutter as a user is starting to understand k8s, you turn up a new cluster, launch a pod, or service, and it's hard to find your one object on the sea of system created pods and services. It's visual clutter that confuses people as they onboard. On Jan 23, 2015 3:01 PM, \"Tim Hockin\" wrote:\n- can you drop me a line (my github name at google) - I want to ask you something, and you have no contact info :) , abonas wrote:\nsorry for naive question but why would I care as an user that wants to run its existing workload on Kubernetes about kubernetes-ro ? If I write an application that uses kubernetes-ro then I'm locked into Kubernetes. I understand the need for kubernetes-ro being accessible by cluster level services such as monitoring, logging. I also can imagine that a power user might want to start its own cluster services that use kubernetes-ro. I don't see clearly why would majority of users care about kubernetes-ro being visible from their container. I see a reason for the cluster services being visible and accessible for Kubernetes developer, but from an user perspective such services only make the system more complex: why do I see these services (pods,rc) ? are they related to my application ? should I care about them (especially when I use hosted Kubernetes) ? why does my container get all these environment variables for cluster services ?\nI will update file to explain why one would have service without a selector.\nRight now, every service goes everywhere for simplicity. Name spacing and filtering probably make sense in the long run, but it's not a high priority for v1.0 Brendan On Mar 4, 2015 5:02 AM, \"Rafa\u0142 Soko\u0142owski\" wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-a44f6cb5e869eccf248b8ac505e27244011ef25c2c80e1233583629299af7a4f", "text": "`service`, a client can simply connect to $MYAPP_SERVICE_HOST on port $MYAPP_SERVICE_PORT. <ins> ## Service without selector Services, in addition to providing clean abstraction to access pods, can also abstract any kind of backend: - you want to have an external database cluster in production, but in test you use your own databases. - you want to point your service to a service in another [`namespace`](namespaces.md) or on another cluster. - you are migrating your workload to Kubernetes and some of your backends run outside of Kubernetes. In any of these scenarios you can define a service without a selector: ```json \"kind\": \"Service\", \"apiVersion\": \"v1beta1\", \"id\": \"myapp\", \"port\": 8765 ``` then you can explicitly map the service to a specific endpoint(s): ```json \"kind\": \"Endpoints\", \"apiVersion\": \"v1beta1\", \"id\": \"myapp\", \"endpoints\": [\"173.194.112.206:80\"] ``` Access to the service without a selector works the same as if it had selector. The traffic will be routed to endpoints defined by the user (`173.194.112.206:80` in case of this example). </ins> ## How do they work? Each node in a Kubernetes cluster runs a `service proxy`.  This application", "commid": "kubernetes_pr_5024"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e9e89a316cb39ee57596a3170474f837d1fc36ca6f45ccf3902663a7708546fe", "query": "As long as we have it in the API, it should maybe be renamed to gcePersistentDisk ?\nSGTM", "positive_passages": [{"docid": "doc-en-kubernetes-625074686ee19c90e3f328d639a9cbdc472bd6a9cc867c967232109cc7c209a0", "text": "EmptyDir *EmptyDir `json:\"emptyDir\"` // GCEPersistentDisk represents a GCE Disk resource that is attached to a // kubelet's host machine and then exposed to the pod. <del> GCEPersistentDisk *GCEPersistentDisk `json:\"persistentDisk\"` </del> <ins> GCEPersistentDisk *GCEPersistentDisk `json:\"gcePersistentDisk\"` </ins> // GitRepo represents a git repository at a particular revision. GitRepo *GitRepo `json:\"gitRepo\"` }", "commid": "kubernetes_pr_3900"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7289a91ca3371479da7fb74d0ceced629b874ff7b3b9f9b433395853883821d6", "query": "This whole set of tests (if it can't be run) should be omitted from the test execution, otherwise folks running on Mac can't verify everything else is clean in a sane fashion. Passive aggressive assign to Tim, I may get around to fixing this before he does.\nLast I checked Travis + Go didn't work. We should check again, and enable OS X builds in Travis if it's possible.\nYou could argue that if the unsupported mount () is being called in a test, there is a problem anyway - it has to run as root. Will investigate. On Jan 25, 2015 9:09 AM, \"Brendan Burns\" wrote:\nWithout a Mac to test on, I feel like this would be better fixed by someone who uses Mac... Probably: just rename to I just discovered \"implicit build constraints\", sigh. Go is crossing from user-friendly to sort of absurd, IMO.", "positive_passages": [{"docid": "doc-en-kubernetes-3dced0d2b2fe488bc7ddcbc632906d4f82fbd404f84d89e75d2a5d4b449d937e", "text": "<del> // +build !windows /* Copyright 2014 Google Inc. All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package gce_pd import ( \"os\" \"syscall\" ) // Determine if a directory is a mountpoint, by comparing the device for the directory // with the device for it's parent.  If they are the same, it's not a mountpoint, if they're // different, it is. func isMountPoint(file string) (bool, error) { stat, err := os.Stat(file) if err != nil { return false, err } rootStat, err := os.Lstat(file + \"/..\") if err != nil { return false, err } // If the directory has the same device as parent, then it's not a mountpoint. return stat.Sys().(*syscall.Stat_t).Dev != rootStat.Sys().(*syscall.Stat_t).Dev, nil } </del>", "commid": "kubernetes_pr_3827"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7289a91ca3371479da7fb74d0ceced629b874ff7b3b9f9b433395853883821d6", "query": "This whole set of tests (if it can't be run) should be omitted from the test execution, otherwise folks running on Mac can't verify everything else is clean in a sane fashion. Passive aggressive assign to Tim, I may get around to fixing this before he does.\nLast I checked Travis + Go didn't work. We should check again, and enable OS X builds in Travis if it's possible.\nYou could argue that if the unsupported mount () is being called in a test, there is a problem anyway - it has to run as root. Will investigate. On Jan 25, 2015 9:09 AM, \"Brendan Burns\" wrote:\nWithout a Mac to test on, I feel like this would be better fixed by someone who uses Mac... Probably: just rename to I just discovered \"implicit build constraints\", sigh. Go is crossing from user-friendly to sort of absurd, IMO.", "positive_passages": [{"docid": "doc-en-kubernetes-0c4488e8c76d6924ce0614a130538ccd156d3678806d22eb36812f8700034843", "text": "<ins> // +build !windows /* Copyright 2014 Google Inc. All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package gce_pd import ( \"os\" \"syscall\" ) // Determine if a directory is a mountpoint, by comparing the device for the directory // with the device for it's parent.  If they are the same, it's not a mountpoint, if they're // different, it is. func isMountPoint(file string) (bool, error) { stat, err := os.Stat(file) if err != nil { return false, err } rootStat, err := os.Lstat(file + \"/..\") if err != nil { return false, err } // If the directory has the same device as parent, then it's not a mountpoint. return stat.Sys().(*syscall.Stat_t).Dev != rootStat.Sys().(*syscall.Stat_t).Dev, nil } </ins>", "commid": "kubernetes_pr_3827"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7289a91ca3371479da7fb74d0ceced629b874ff7b3b9f9b433395853883821d6", "query": "This whole set of tests (if it can't be run) should be omitted from the test execution, otherwise folks running on Mac can't verify everything else is clean in a sane fashion. Passive aggressive assign to Tim, I may get around to fixing this before he does.\nLast I checked Travis + Go didn't work. We should check again, and enable OS X builds in Travis if it's possible.\nYou could argue that if the unsupported mount () is being called in a test, there is a problem anyway - it has to run as root. Will investigate. On Jan 25, 2015 9:09 AM, \"Brendan Burns\" wrote:\nWithout a Mac to test on, I feel like this would be better fixed by someone who uses Mac... Probably: just rename to I just discovered \"implicit build constraints\", sigh. Go is crossing from user-friendly to sort of absurd, IMO.", "positive_passages": [{"docid": "doc-en-kubernetes-c354a22747dabbc29c10835a65caaaf90444e20a88e58aeb5b00ffd068dcb814", "text": "<del> // +build !linux </del> <ins> // +build windows </ins> /* Copyright 2014 Google Inc. All rights reserved.", "commid": "kubernetes_pr_3827"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d0f38e058dd83a69064953b4bc0c2c3ffa6cae2ccfd3a071336c45d6b39f4940", "query": "wrote: I just ran across this the other day. but I am seeing the error in the service. Here is a sample of the output. I am running v0.8.2. I can get the behavior to go away temporarily by rebooting the node or restarting the service but it always seems to come back eventually.", "positive_passages": [{"docid": "doc-en-kubernetes-404ceebe195f6393af475b3e59bce772c69e27b5c00cbcacfe7a7e702c9a9a29", "text": "} if event.Type == watch.Error { util.HandleError(fmt.Errorf(\"error from watch during sync: %v\", errors.FromObject(event.Object))) <ins> // Clear the resource version, this may cause us to skip some elements on the watch, // but we'll catch them on the synchronize() call, so it works out. *resourceVersion = \"\" </ins> continue } glog.V(4).Infof(\"Got watch: %#v\", event) rc, ok := event.Object.(*api.ReplicationController) if !ok { <ins> if status, ok := event.Object.(*api.Status); ok { if status.Status == api.StatusFailure { glog.Errorf(\"failed to watch: %v\", status) // Clear resource version here, as above, this won't hurt consistency, but we // should consider introspecting more carefully here. (or make the apiserver smarter) // \"why not both?\" *resourceVersion = \"\" continue } } </ins> util.HandleError(fmt.Errorf(\"unexpected object: %#v\", event.Object)) continue }", "commid": "kubernetes_pr_4102"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4be2baac657b91c8150c9eaeb075c4073519ae9c3e811b2f182b2a22b3be9af8", "query": "We found yesterday that cAdvisor wasn't being started properly in 0.9.0 and 0.9.1 due to an issue with manifest file format changes (, fixed in ). If any of our e2e tests even checked that cAdvisor was running or exposing metrics on all nodes, it would have been caught before release. We should add at least some coverage for it to catch bugs like this.\nIf any of you are up for adding an e2e test for cadvisor, that'd be much appreciated!\nI will work on adding one for cadvisor. , Alex Mohr wrote:\nWe already have a e2e test, which validate monitoring of Clusters using cAdvisor. We should figure out why the test passed without detecting such failure, and improve that test.\nThe existing test will succeed even if some of the nodes do not have cadvisor running. We can enhance the monitoring test to specifically check for cadvisor's health as well. , Dawn Chen wrote:\nThis test seems to be failing deterministically.\nThis was after fix to retry, but we're not exactly sure why.\nOnce I have emerged from the e2e test for cluster level logging with Elasticsearch quagmire (soon I hope -- perhaps by Wednesday) then I might also be willing to lend a hand with this since some of the experience might be relevant.\nActually latest error looks like So it's still not coming up after 5 minutes. The question is how long should it be taking to come up, given that the cadvisor containers get scheduled basically on node creation. The test finished in < 1s on my e2e cluster that has been up for awhile.\nOr there's an actual bug here. can you look into it?\n(I looked at the Jenkins log, and this test ran a good 10 minutes after startup, so it probably had 15 minutes to finish coming up. That seems wrong, given that cAdvisor is actually the first container we ever schedule, and it gets scheduled raw.)\nSorry, I hadn't seen -- not sure if that fixes this?\nNo, there are failures after as well. On Feb 20, 2015 5:39 PM, \"David Oppenheimer\" wrote:\nI don't see any issue with the test itself. The test attempts to access a REST endpoint ('/stats') via the proxy on the api-server. Is it possible that the api-server doesn't get to a stable state for a while?\nThis test executes after several others that hit the apiserver? On Feb 22, 2015 4:15 PM, \"Vish Kannan\" wrote:\nNoob question: How can we tell if it runs this test after the other tests?\nYou can't tell deterministically (i.e. it's not hardcoded). I was merely commenting that in several runs where this fails, it has run after many other tests. We've been randomizing the spec order for a while. You can look at the Jenkins console logs to get the random seed for a given run: And the console logs have the order just by manually scanning the horizontal bars, but it's kind of pain. (That seed was off of go/k8s-test/job/kubernetes-e2e-gce/2638/consoleFull)\nThe reason for this failure is . I am closing this issue since the test itself is fine.", "positive_passages": [{"docid": "doc-en-kubernetes-d998d01d6651bff9e21e9c2387fc7a64b5509059ec20c69804d524105991c41c", "text": "<ins> /* Copyright 2015 Google Inc. All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package e2e import ( \"fmt\" \"time\" \"github.com/GoogleCloudPlatform/kubernetes/pkg/client\" . \"github.com/onsi/ginkgo\" ) var _ = Describe(\"Cadvisor\", func() { var c *client.Client BeforeEach(func() { var err error c, err = loadClient() expectNoError(err) }) It(\"cadvisor should be healthy on every node.\", func() { CheckCadvisorHealthOnAllNodes(c) }) }) func CheckCadvisorHealthOnAllNodes(c *client.Client) { By(\"getting list of nodes\") nodeList, err := c.Nodes().List() expectNoError(err) for _, node := range nodeList.Items { // cadvisor is not accessible directly unless its port (4194 by default) is exposed. // Here, we access '/stats/' REST endpoint on the kubelet which polls cadvisor internally. statsResource := fmt.Sprintf(\"api/v1beta1/proxy/minions/%s/stats/\", node.Name) By(fmt.Sprintf(\"Querying stats from node %s using url %s\", node.Name, statsResource)) _, err = c.Get().AbsPath(statsResource).Timeout(1 * time.Second).Do().Raw() expectNoError(err) } } </ins>", "commid": "kubernetes_pr_4506"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9c9d5bfd1ce2491596aef565e138702c57296cb976abe91eb5a2e9202f8205ed", "query": "W0128 18:44:26. ] Pod from test failed validation, ignoring: namespace: required value '' E0128 18:44:26. ] Could not construct reference to: '&api.BoundPod{TypeMeta:api.TypeMeta{Kind:\"\", APIVersion:\"\"}, ObjectMeta:api.ObjectMeta{Name:\"foo\", Namespace:\"\", SelfLink:\"\", UID:\"foo\", ResourceVersion:\"\", CreationTimestamp:util.Time{Time:time.Time{sec:0, nsec:0x0, loc:(time.Location)(nil)}}, Labels:map[string]string(nil), Annotations:map[string]string{\"\":\"\"}}, Spec:api.PodSpec{Volumes:[]api.Volume(nil), Containers:[]api.Container(nil), RestartPolicy:api.RestartPolicy{Always:(api.RestartPolicyAlways)(0xe3d670), OnFailure:(api.RestartPolicyOnFailure)(nil), Never:(api.RestartPolicyNever)(nil)}, DNSPolicy:\"ClusterFirst\", NodeSelector:map[string]string(nil), Host:\"\"}}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'failedValidation' 'Error validating pod foo.<empty-namespacefrom test, ignoring: namespace: required value E0128 18:44:28. ] Unable to read config path \"randomnonexistentpath\": path does not exist, ignoring --- FAIL: TestReadFromFileWithoutID (0.20 seconds) Expected update, timeout instead", "positive_passages": [{"docid": "doc-en-kubernetes-16f48068bcbca3bf360a382ec6a85c2d5022a889ab7256594b881254c3965af9", "text": "t.Fatalf(\"Expected %#v, Got %#v\", expected, update) } <del> case <-time.After(2 * time.Millisecond): </del> <ins> case <-time.After(time.Second): </ins> t.Errorf(\"Expected update, timeout instead\") } }", "commid": "kubernetes_pr_3887"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9c9d5bfd1ce2491596aef565e138702c57296cb976abe91eb5a2e9202f8205ed", "query": "W0128 18:44:26. ] Pod from test failed validation, ignoring: namespace: required value '' E0128 18:44:26. ] Could not construct reference to: '&api.BoundPod{TypeMeta:api.TypeMeta{Kind:\"\", APIVersion:\"\"}, ObjectMeta:api.ObjectMeta{Name:\"foo\", Namespace:\"\", SelfLink:\"\", UID:\"foo\", ResourceVersion:\"\", CreationTimestamp:util.Time{Time:time.Time{sec:0, nsec:0x0, loc:(time.Location)(nil)}}, Labels:map[string]string(nil), Annotations:map[string]string{\"\":\"\"}}, Spec:api.PodSpec{Volumes:[]api.Volume(nil), Containers:[]api.Container(nil), RestartPolicy:api.RestartPolicy{Always:(api.RestartPolicyAlways)(0xe3d670), OnFailure:(api.RestartPolicyOnFailure)(nil), Never:(api.RestartPolicyNever)(nil)}, DNSPolicy:\"ClusterFirst\", NodeSelector:map[string]string(nil), Host:\"\"}}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'failedValidation' 'Error validating pod foo.<empty-namespacefrom test, ignoring: namespace: required value E0128 18:44:28. ] Unable to read config path \"randomnonexistentpath\": path does not exist, ignoring --- FAIL: TestReadFromFileWithoutID (0.20 seconds) Expected update, timeout instead", "positive_passages": [{"docid": "doc-en-kubernetes-97e3688f0778a62ea4ed90bf19a2fc7f7a5a3e031710b474dbddf49dd3fed16f", "text": "t.Errorf(\"Unexpected UID: %s\", update.Pods[0].ObjectMeta.UID) } <del> case <-time.After(2 * time.Millisecond): </del> <ins> case <-time.After(time.Second): </ins> t.Errorf(\"Expected update, timeout instead\") } }", "commid": "kubernetes_pr_3887"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-48b6be9a789fe76ef913476cd055a1bb3da8978c4034069a469636df6a1d0695", "query": "writes: As we start looking into etcd and event memory pressure [], we should look into switching over to etcd 2.0 which was released today.\ncc/\n+1 On Jan 28, 2015 5:29 PM, \"Dawn Chen\" wrote:\nMy long-running cluster tests resulted in a hard-crash on etcd: We should move to 2.0 ASAP in the hopes of (a) fixing the issue and if not (b) prioritizing the fix since we'll be complaining about head. Abhi, is this something you can pick up and drive to land in O(days) please?\nCalling this P0 as it blocks further long-running cluster stability testing.\nI will do this today. , Alex Mohr wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-a16830786ad922ae371a556faf596d13c124c91ae32b8e6ca7d5a57ee9b59ce6", "text": "#    shasum <tar> # 6. Update this file with new tar version and new hash <del> {% set etcd_version=\"v0.4.6\" %} </del> <ins> {% set etcd_version=\"v2.0.0\" %} </ins> {% set etcd_tar_url=\"https://storage.googleapis.com/kubernetes-release/etcd/etcd-%s-linux-amd64.tar.gz\" | format(etcd_version)  %} <del> {% set etcd_tar_hash=\"sha1=5db514e30b9f340eda00671230d5136855ae14d7\" %} </del> <ins> {% set etcd_tar_hash=\"sha1=b3cd41d1748bf882a58a98c9585fd5849b943811\" %} </ins> etcd-tar: archive:", "commid": "kubernetes_pr_3960"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-48b6be9a789fe76ef913476cd055a1bb3da8978c4034069a469636df6a1d0695", "query": "writes: As we start looking into etcd and event memory pressure [], we should look into switching over to etcd 2.0 which was released today.\ncc/\n+1 On Jan 28, 2015 5:29 PM, \"Dawn Chen\" wrote:\nMy long-running cluster tests resulted in a hard-crash on etcd: We should move to 2.0 ASAP in the hopes of (a) fixing the issue and if not (b) prioritizing the fix since we'll be complaining about head. Abhi, is this something you can pick up and drive to land in O(days) please?\nCalling this P0 as it blocks further long-running cluster stability testing.\nI will do this today. , Alex Mohr wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-683e6658148ffee96574ea294ab137472d5de55ee1fce20d75fcd621f3d6478f", "text": "DESC=\"The etcd key-value share configuration service\" NAME=etcd DAEMON=/usr/local/bin/$NAME <del> DAEMON_ARGS=\"-peer-addr $HOSTNAME:7001 -name $HOSTNAME\" </del> <ins> # DAEMON_ARGS=\"-peer-addr $HOSTNAME:7001 -name $HOSTNAME\" host_ip=$(hostname -i) DAEMON_ARGS=\"-addr ${host_ip}:4001 -bind-addr ${host_ip}:4001 -data-dir /var/etcd -initial-advertise-peer-urls http://${HOSTNAME}:2380 -name ${HOSTNAME} -initial-cluster ${HOSTNAME}=http://${HOSTNAME}:2380\" </ins> DAEMON_LOG_FILE=/var/log/$NAME.log PIDFILE=/var/run/$NAME.pid SCRIPTNAME=/etc/init.d/$NAME", "commid": "kubernetes_pr_3960"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-48b6be9a789fe76ef913476cd055a1bb3da8978c4034069a469636df6a1d0695", "query": "writes: As we start looking into etcd and event memory pressure [], we should look into switching over to etcd 2.0 which was released today.\ncc/\n+1 On Jan 28, 2015 5:29 PM, \"Dawn Chen\" wrote:\nMy long-running cluster tests resulted in a hard-crash on etcd: We should move to 2.0 ASAP in the hopes of (a) fixing the issue and if not (b) prioritizing the fix since we'll be complaining about head. Abhi, is this something you can pick up and drive to land in O(days) please?\nCalling this P0 as it blocks further long-running cluster stability testing.\nI will do this today. , Alex Mohr wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-4897f940020ebbc6d789c1b604af7826318164ed84f0fcb9f572550b09d8a6ca", "text": "exit 1 fi <ins> version=$(etcd -version | cut -d \" \" -f 3) if [[ \"${version}\" < \"2.0.0\" ]]; then kube::log::usage \"etcd version 2.0.0 or greater required.\" exit 1 fi </ins> # Start etcd ETCD_DIR=$(mktemp -d -t test-etcd.XXXXXX) <del> etcd -name test -data-dir ${ETCD_DIR} -addr ${host}:${port} >/dev/null 2>/dev/null & </del> <ins> kube::log::usage \"etcd -data-dir ${ETCD_DIR} -addr ${host}:${port} >/dev/null 2>/dev/null\" etcd -data-dir ${ETCD_DIR} -addr ${host}:${port} >/dev/null 2>/dev/null & </ins> ETCD_PID=$! <del> kube::util::wait_for_url \"http://${host}:${port}/v2/keys/\" \"etcd: \" </del> <ins> echo \"Waiting for etcd to come up.\" while true; do if curl -L http://127.0.0.1:4001/v2/keys/test -XPUT -d value=\"test\"; then break fi done kube::util::wait_for_url \"http://${host}:${port}/v2/keys/test\" \"etcd: \" </ins> } kube::etcd::cleanup() {", "commid": "kubernetes_pr_3960"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-48b6be9a789fe76ef913476cd055a1bb3da8978c4034069a469636df6a1d0695", "query": "writes: As we start looking into etcd and event memory pressure [], we should look into switching over to etcd 2.0 which was released today.\ncc/\n+1 On Jan 28, 2015 5:29 PM, \"Dawn Chen\" wrote:\nMy long-running cluster tests resulted in a hard-crash on etcd: We should move to 2.0 ASAP in the hopes of (a) fixing the issue and if not (b) prioritizing the fix since we'll be complaining about head. Abhi, is this something you can pick up and drive to land in O(days) please?\nCalling this P0 as it blocks further long-running cluster stability testing.\nI will do this today. , Alex Mohr wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-7cfd15081eef595237856b11fd1d8b4236ac17462447857f3ecdac70ffe3764a", "text": "KUBE_ROOT=$(dirname \"${BASH_SOURCE}\")/../.. <del> ETCD_VERSION=${ETCD_VERSION:-v0.4.6} </del> <ins> ETCD_VERSION=${ETCD_VERSION:-v2.0.0} </ins> cd \"${KUBE_ROOT}/third_party\" curl -sL https://github.com/coreos/etcd/releases/download/${ETCD_VERSION}/etcd-${ETCD_VERSION}-linux-amd64.tar.gz ", "commid": "kubernetes_pr_3960"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-618a17ee1a2bfcaa30e720bd6c59c3ac91ee900494c2c92ac1b2427757bb09d9", "query": "reported a variety of failure modes in .\n+1\nI figured I'd add to this issue rather than create a new one. I attempted to create a vagrant cluster today (dev tree is up to date) with 1 Master and 1 Minion and the cluster creation is stuck in the 'Validating master' loop ( for over 10 minutes in the validating loop ). salt-master and salt-minion logs seem to be empty ( they don't appear to be running, in fact ).\nI still have the cluster running in case anybody wants additional information.\n/cc please let me know if there is any other information about my vagrant setup that I need to post here.\nI have been working to get more stability in this environment over last few days. Can you try again from HEAD after this merges:\nCan you also verify that you built a release prior to running cluster/Kube-up?\nyes, I started from scratch and built a release before running cluster/kube- - cluster/kube- seems to fail fairly early in case there is no release build available.\nIt looks like got merged. I'll try again and get back to you.\nThe vagrant cluster seems to come up ( completes master and minion validation ). However, there is new credentials related error that is showing up at the end of running cluster/kube- :\nI'll add one more problem I've encountered. Runing from head:\nNew to me. Will investigate more tomorrow. Sent from my iPhone\nAlso new to me :-) - will see if I can reproduce either. Sent from my iPhone\nYour credendials and certificates are not working with new environment. Just delete your .kubernetesvagrant* files and recreate the cluster. It would be nice to automate this task, if you tear down the cluster.\nI am able to reproduce the 502 Bad Gateway error and am working on determining what changed in order to provide a resolution over the last couple days. Please assign this issue to me.\nThe issue appears to me that the kube-apiserver is not getting provisioned by salt correctly. Parsing Salt logs to determine why.\nLooks like the file is not getting laid down by salt for some reason ;-)\nThe Jinja template was changed as part of identifying the cluster. Fixing up now, and will send a PR to close this issue.\nthat was it, thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-6e3c74340fb0c64c805550bd7e7f70304bcbe8e68ef36a554bf030df27c671f3", "text": "# The IP of the master export MASTER_IP=\"10.245.1.2\" <del> export INSTANCE_PREFIX=kubernetes </del> <ins> export INSTANCE_PREFIX=\"kubernetes\" </ins> export MASTER_NAME=\"${INSTANCE_PREFIX}-master\" # Map out the IPs, names and container subnets of each minion", "commid": "kubernetes_pr_4903"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-618a17ee1a2bfcaa30e720bd6c59c3ac91ee900494c2c92ac1b2427757bb09d9", "query": "reported a variety of failure modes in .\n+1\nI figured I'd add to this issue rather than create a new one. I attempted to create a vagrant cluster today (dev tree is up to date) with 1 Master and 1 Minion and the cluster creation is stuck in the 'Validating master' loop ( for over 10 minutes in the validating loop ). salt-master and salt-minion logs seem to be empty ( they don't appear to be running, in fact ).\nI still have the cluster running in case anybody wants additional information.\n/cc please let me know if there is any other information about my vagrant setup that I need to post here.\nI have been working to get more stability in this environment over last few days. Can you try again from HEAD after this merges:\nCan you also verify that you built a release prior to running cluster/Kube-up?\nyes, I started from scratch and built a release before running cluster/kube- - cluster/kube- seems to fail fairly early in case there is no release build available.\nIt looks like got merged. I'll try again and get back to you.\nThe vagrant cluster seems to come up ( completes master and minion validation ). However, there is new credentials related error that is showing up at the end of running cluster/kube- :\nI'll add one more problem I've encountered. Runing from head:\nNew to me. Will investigate more tomorrow. Sent from my iPhone\nAlso new to me :-) - will see if I can reproduce either. Sent from my iPhone\nYour credendials and certificates are not working with new environment. Just delete your .kubernetesvagrant* files and recreate the cluster. It would be nice to automate this task, if you tear down the cluster.\nI am able to reproduce the 502 Bad Gateway error and am working on determining what changed in order to provide a resolution over the last couple days. Please assign this issue to me.\nThe issue appears to me that the kube-apiserver is not getting provisioned by salt correctly. Parsing Salt logs to determine why.\nLooks like the file is not getting laid down by salt for some reason ;-)\nThe Jinja template was changed as part of identifying the cluster. Fixing up now, and will send a PR to close this issue.\nthat was it, thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-d5c5378f24fb46bd45f685f67eaff4fbed9650af9553afa78f5caa2dd351db0c", "text": "dns_replicas: '$(echo \"$DNS_REPLICAS\" | sed -e \"s/'/''/g\")' dns_server: '$(echo \"$DNS_SERVER_IP\" | sed -e \"s/'/''/g\")' dns_domain: '$(echo \"$DNS_DOMAIN\" | sed -e \"s/'/''/g\")' <ins> instance_prefix: '$(echo \"$INSTANCE_PREFIX\" | sed -e \"s/'/''/g\")' </ins> EOF # Configure the salt-master", "commid": "kubernetes_pr_4903"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1898b360a97767b2693ea582431a164ade42bd7fbf892fdd653b38d513260c90", "query": "contains function get-password. This uses a template which gets the current context. But a user who has not yet used the kubectl contexts feature has no context set. This causes a nil pointer deref while evaluating the template.\nI think kube-up creates the needed entries in the .kubeconfig file. But it calls get-password before it does that. Need to allow the kubectl config view command to fail.\nokay, I have a fix.", "positive_passages": [{"docid": "doc-en-kubernetes-a7467afaa396090f75d283b1bdff2292a8e93c42902eb7951ab7c56a69e5bdaf", "text": "#   KUBE_PASSWORD function get-password { # go template to extract the auth-path of the current-context user <del> local template='{{$ctx := index . \"current-context\"}}{{$user := index . \"contexts\" $ctx \"user\"}}{{index . \"users\" $user \"auth-path\"}}' </del> <ins> local template='{{with $ctx := index . \"current-context\"}}{{$user := index . \"contexts\" $ctx \"user\"}}{{index . \"users\" $user \"auth-path\"}}{{end}}' </ins> local file=$(\"${KUBE_ROOT}/cluster/kubectl.sh\" config view -o template --template=\"${template}\") <del> if [[ -r \"$file\" ]]; then </del> <ins> if [[ ! -z \"$file\" && -r \"$file\" ]]; then </ins> KUBE_USER=$(cat \"$file\" | python -c 'import json,sys;print json.load(sys.stdin)[\"User\"]') KUBE_PASSWORD=$(cat \"$file\" | python -c 'import json,sys;print json.load(sys.stdin)[\"Password\"]') return", "commid": "kubernetes_pr_4353"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2d8db3db60a856068241611a4e608d0c0eb92592804309234e8facba95234683", "query": "I have been following the instructions here: to try to explore the kube UI. by executing: I get the following which shows it successfully started: When I try to access the page I get a 404:\ncould you try running ? I believe is a typo of\nAlso, try accessing instead.\nthanks", "positive_passages": [{"docid": "doc-en-kubernetes-9239655b41b76696f68403bf206d47e9ae1a33eb75da975d968e4ae07d6e8c28", "text": "Start the server: ```sh <del> cluster/kubectl.sh proxy -www=$PWD/www </del> <ins> cluster/kubectl.sh proxy --www=$PWD/www </ins> ``` The UI should now be running on [localhost](http://localhost:8001/static/index.html#/groups//selector)", "commid": "kubernetes_pr_4611"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-33e3eb0cb35f85a754b3ee3944c38e72c05cb6c9cd3f09473af5448c1ac03388", "query": "I tried to create a pod without containers to see if it's supported or not. (does a pod without containers have a meaning in k8s?) I was getting \"conflict 409 already exists\" error although I used a new pod with a new name/id, so it's not clear whether it's supported or not, and whether this error is a mistake (409 instead of 400)\nWhat is the reason to create pod without specifiing image / creating container? Please provide a use case when such functionality is necessry.\n- to me it's not necessary. However if it's not supported, a validation should prevent it not to allow corrupted entities. And if it is supported, it will be good to understand why. For instance, service with nil selector is supported, though it might not make sense to some users. see this:\nYes, it should be allowed, and I'm pretty sure it used to work. Could you please post your object schema here or somewhere?\nwhat do you mean by object schema? an example json of such pod or something broader? and btw what meaning a pod has without containers?\ncc\nI'm fine with banning this for now. The use cases where it would be useful (e.g., reserving resources, staging deployment, prefetching images, ...) aren't currently well supported. When we add the features that could take advantage of this (e.g., pod-level resources, additional of containers during update, container volumes, pod/volume init hooks), then we can make it legal again at that point.\nin that case, a clear error message coming from REST would be in place when a pod with no containers is recieved by the server :)\nI'll look into this. AFAIU we want to return meaningful error if user specifies pod with no containers. Is my understanding correct?\nCorrect. We should do it in validateContainers:\ncc\nshould we document this somewhere (e.g. ). Validation is not versioned, so any change would apply to all existing APIs.\nYes, it should be documented, in the field descriptions, such as:\nI'll send a PR for this.\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-6484546cff8dc36e27c9001cd1d1cb7e711f9fdc498f6376049f601a5982a344", "text": "// PodSpec is a description of a pod type PodSpec struct { <del> Volumes       []Volume      `json:\"volumes\"` </del> <ins> Volumes []Volume `json:\"volumes\"` // Required: there must be at least one container in a pod. </ins> Containers    []Container   `json:\"containers\"` RestartPolicy RestartPolicy `json:\"restartPolicy,omitempty\"` // Required: Set DNS policy.", "commid": "kubernetes_pr_5703"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-33e3eb0cb35f85a754b3ee3944c38e72c05cb6c9cd3f09473af5448c1ac03388", "query": "I tried to create a pod without containers to see if it's supported or not. (does a pod without containers have a meaning in k8s?) I was getting \"conflict 409 already exists\" error although I used a new pod with a new name/id, so it's not clear whether it's supported or not, and whether this error is a mistake (409 instead of 400)\nWhat is the reason to create pod without specifiing image / creating container? Please provide a use case when such functionality is necessry.\n- to me it's not necessary. However if it's not supported, a validation should prevent it not to allow corrupted entities. And if it is supported, it will be good to understand why. For instance, service with nil selector is supported, though it might not make sense to some users. see this:\nYes, it should be allowed, and I'm pretty sure it used to work. Could you please post your object schema here or somewhere?\nwhat do you mean by object schema? an example json of such pod or something broader? and btw what meaning a pod has without containers?\ncc\nI'm fine with banning this for now. The use cases where it would be useful (e.g., reserving resources, staging deployment, prefetching images, ...) aren't currently well supported. When we add the features that could take advantage of this (e.g., pod-level resources, additional of containers during update, container volumes, pod/volume init hooks), then we can make it legal again at that point.\nin that case, a clear error message coming from REST would be in place when a pod with no containers is recieved by the server :)\nI'll look into this. AFAIU we want to return meaningful error if user specifies pod with no containers. Is my understanding correct?\nCorrect. We should do it in validateContainers:\ncc\nshould we document this somewhere (e.g. ). Validation is not versioned, so any change would apply to all existing APIs.\nYes, it should be documented, in the field descriptions, such as:\nI'll send a PR for this.\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-85ed6f05622e5d94e6078804248e939e6930f1133f0ffced90b92effd011e26e", "text": "// PodSpec is a description of a pod type PodSpec struct { <del> Volumes       []Volume      `json:\"volumes\" description:\"list of volumes that can be mounted by containers belonging to the pod\"` Containers    []Container   `json:\"containers\" description:\"list of containers belonging to the pod; containers cannot currently be added or removed\"` </del> <ins> Volumes []Volume `json:\"volumes\" description:\"list of volumes that can be mounted by containers belonging to the pod\"` // Required: there must be at least one container in a pod. Containers    []Container   `json:\"containers\" description:\"list of containers belonging to the pod; containers cannot currently be added or removed; there must be at least one container in a Pod\"` </ins> RestartPolicy RestartPolicy `json:\"restartPolicy,omitempty\" description:\"restart policy for all containers within the pod; one of RestartPolicyAlways, RestartPolicyOnFailure, RestartPolicyNever\"` // Optional: Set DNS policy.  Defaults to \"ClusterFirst\" DNSPolicy DNSPolicy `json:\"dnsPolicy,omitempty\" description:\"DNS policy for containers within the pod; one of 'ClusterFirst' or 'Default'\"`", "commid": "kubernetes_pr_5703"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-33e3eb0cb35f85a754b3ee3944c38e72c05cb6c9cd3f09473af5448c1ac03388", "query": "I tried to create a pod without containers to see if it's supported or not. (does a pod without containers have a meaning in k8s?) I was getting \"conflict 409 already exists\" error although I used a new pod with a new name/id, so it's not clear whether it's supported or not, and whether this error is a mistake (409 instead of 400)\nWhat is the reason to create pod without specifiing image / creating container? Please provide a use case when such functionality is necessry.\n- to me it's not necessary. However if it's not supported, a validation should prevent it not to allow corrupted entities. And if it is supported, it will be good to understand why. For instance, service with nil selector is supported, though it might not make sense to some users. see this:\nYes, it should be allowed, and I'm pretty sure it used to work. Could you please post your object schema here or somewhere?\nwhat do you mean by object schema? an example json of such pod or something broader? and btw what meaning a pod has without containers?\ncc\nI'm fine with banning this for now. The use cases where it would be useful (e.g., reserving resources, staging deployment, prefetching images, ...) aren't currently well supported. When we add the features that could take advantage of this (e.g., pod-level resources, additional of containers during update, container volumes, pod/volume init hooks), then we can make it legal again at that point.\nin that case, a clear error message coming from REST would be in place when a pod with no containers is recieved by the server :)\nI'll look into this. AFAIU we want to return meaningful error if user specifies pod with no containers. Is my understanding correct?\nCorrect. We should do it in validateContainers:\ncc\nshould we document this somewhere (e.g. ). Validation is not versioned, so any change would apply to all existing APIs.\nYes, it should be documented, in the field descriptions, such as:\nI'll send a PR for this.\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-8f5013ede8864d4a4f033efd03c33f59b04400995c2fee31addc5a9a891f4f2d", "text": "// PodSpec is a description of a pod type PodSpec struct { <del> Volumes       []Volume      `json:\"volumes\" description:\"list of volumes that can be mounted by containers belonging to the pod\"` Containers    []Container   `json:\"containers\" description:\"list of containers belonging to the pod; cannot be updated; containers cannot currently be added or removed\"` </del> <ins> Volumes []Volume `json:\"volumes\" description:\"list of volumes that can be mounted by containers belonging to the pod\"` // Required: there must be at least one container in a pod. Containers    []Container   `json:\"containers\" description:\"list of containers belonging to the pod; cannot be updated; containers cannot currently be added or removed; there must be at least one container in a Pod\"` </ins> RestartPolicy RestartPolicy `json:\"restartPolicy,omitempty\" description:\"restart policy for all containers within the pod; one of RestartPolicyAlways, RestartPolicyOnFailure, RestartPolicyNever\"` // Optional: Set DNS policy.  Defaults to \"ClusterFirst\" DNSPolicy DNSPolicy `json:\"dnsPolicy,omitempty\" description:\"DNS policy for containers within the pod; one of 'ClusterFirst' or 'Default'\"`", "commid": "kubernetes_pr_5703"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8bb108261f9ea31f2e1442aeb830b4a2731925b51c70e95fc60efadb69675c81", "query": "We use capitals for Pod fields (ex: Status.Host) and camelCase for Event fields (ex: involvedObject.resourceVersion). We should be consistent. Should it be capitals? camelCase? Or should we be case insensitive?\nIMO, we should use camelCase for pod fields, to match the way it's serialized in JSON.\nI agree with The goal here is to be consistent with the API, not with the internal Go representation.\nI'd like to fix this before v1beta3 is cast in stone.\nok. Event field selectors are correct then. I will update the selectors for pods to make them camelCase.\nI am wondering if I should change this only for v1beta3 or for 1 and 2 as well? This will be a breaking change for beta1 and 2 if we decide to do that.\nv1beta3 only, though that's hard, we should reconsider. We're contemplating another \"breakage day\", and I doubt this is widely used.", "positive_passages": [{"docid": "doc-en-kubernetes-70e1511db8a028ea8c2bc85a3c0c946e9059511717d715dadfc9db9d818cb540", "text": "case \"name\": return \"name\", value, nil case \"DesiredState.Host\": <del> return \"Status.Host\", value, nil </del> <ins> return \"status.host\", value, nil </ins> case \"DesiredState.Status\": podStatus := PodStatus(value) var internalValue newer.PodPhase newer.Scheme.Convert(&podStatus, &internalValue) <del> return \"Status.Phase\", string(internalValue), nil </del> <ins> return \"status.phase\", string(internalValue), nil </ins> default: return \"\", \"\", fmt.Errorf(\"field label not supported: %s\", label) }", "commid": "kubernetes_pr_5220"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8bb108261f9ea31f2e1442aeb830b4a2731925b51c70e95fc60efadb69675c81", "query": "We use capitals for Pod fields (ex: Status.Host) and camelCase for Event fields (ex: involvedObject.resourceVersion). We should be consistent. Should it be capitals? camelCase? Or should we be case insensitive?\nIMO, we should use camelCase for pod fields, to match the way it's serialized in JSON.\nI agree with The goal here is to be consistent with the API, not with the internal Go representation.\nI'd like to fix this before v1beta3 is cast in stone.\nok. Event field selectors are correct then. I will update the selectors for pods to make them camelCase.\nI am wondering if I should change this only for v1beta3 or for 1 and 2 as well? This will be a breaking change for beta1 and 2 if we decide to do that.\nv1beta3 only, though that's hard, we should reconsider. We're contemplating another \"breakage day\", and I doubt this is widely used.", "positive_passages": [{"docid": "doc-en-kubernetes-9ea43e3f33eeb3743dd7f22ee659669331a52a93e2eb10bfdfb6d516602d326a", "text": "switch label { case \"name\": fallthrough <del> case \"Status.Phase\": </del> <ins> case \"status.phase\": </ins> fallthrough <del> case \"Status.Host\": </del> <ins> case \"status.host\": </ins> return label, value, nil default: return \"\", \"\", fmt.Errorf(\"field label not supported: %s\", label)", "commid": "kubernetes_pr_5220"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8bb108261f9ea31f2e1442aeb830b4a2731925b51c70e95fc60efadb69675c81", "query": "We use capitals for Pod fields (ex: Status.Host) and camelCase for Event fields (ex: involvedObject.resourceVersion). We should be consistent. Should it be capitals? camelCase? Or should we be case insensitive?\nIMO, we should use camelCase for pod fields, to match the way it's serialized in JSON.\nI agree with The goal here is to be consistent with the API, not with the internal Go representation.\nI'd like to fix this before v1beta3 is cast in stone.\nok. Event field selectors are correct then. I will update the selectors for pods to make them camelCase.\nI am wondering if I should change this only for v1beta3 or for 1 and 2 as well? This will be a breaking change for beta1 and 2 if we decide to do that.\nv1beta3 only, though that's hard, we should reconsider. We're contemplating another \"breakage day\", and I doubt this is widely used.", "positive_passages": [{"docid": "doc-en-kubernetes-13947009bc9f7b46fc829ab3204d7997466abf7c3810b798776b65c05d4e7241", "text": "label:       \"label=qux\", expectedIDs: util.NewStringSet(\"qux\"), }, { <del> field:       \"Status.Phase=Failed\", </del> <ins> field:       \"status.phase=Failed\", </ins> expectedIDs: util.NewStringSet(\"baz\"), }, { <del> field:       \"Status.Host=barhost\", </del> <ins> field:       \"status.host=barhost\", </ins> expectedIDs: util.NewStringSet(\"bar\"), }, { <del> field:       \"Status.Host=\", </del> <ins> field:       \"status.host=\", </ins> expectedIDs: util.NewStringSet(\"foo\", \"baz\", \"qux\", \"zot\"), }, { <del> field:       \"Status.Host!=\", </del> <ins> field:       \"status.host!=\", </ins> expectedIDs: util.NewStringSet(\"bar\"), }, }", "commid": "kubernetes_pr_5220"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8bb108261f9ea31f2e1442aeb830b4a2731925b51c70e95fc60efadb69675c81", "query": "We use capitals for Pod fields (ex: Status.Host) and camelCase for Event fields (ex: involvedObject.resourceVersion). We should be consistent. Should it be capitals? camelCase? Or should we be case insensitive?\nIMO, we should use camelCase for pod fields, to match the way it's serialized in JSON.\nI agree with The goal here is to be consistent with the API, not with the internal Go representation.\nI'd like to fix this before v1beta3 is cast in stone.\nok. Event field selectors are correct then. I will update the selectors for pods to make them camelCase.\nI am wondering if I should change this only for v1beta3 or for 1 and 2 as well? This will be a breaking change for beta1 and 2 if we decide to do that.\nv1beta3 only, though that's hard, we should reconsider. We're contemplating another \"breakage day\", and I doubt this is widely used.", "positive_passages": [{"docid": "doc-en-kubernetes-1c5c249d845c52b7f0673d42c2280fe388cae07d2186046b45c0b90b81ec0ff7", "text": "func PodToSelectableFields(pod *api.Pod) labels.Set { return labels.Set{ \"name\":         pod.Name, <del> \"Status.Phase\": string(pod.Status.Phase), \"Status.Host\":  pod.Status.Host, </del> <ins> \"status.phase\": string(pod.Status.Phase), \"status.host\":  pod.Status.Host, </ins> } }", "commid": "kubernetes_pr_5220"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8bb108261f9ea31f2e1442aeb830b4a2731925b51c70e95fc60efadb69675c81", "query": "We use capitals for Pod fields (ex: Status.Host) and camelCase for Event fields (ex: involvedObject.resourceVersion). We should be consistent. Should it be capitals? camelCase? Or should we be case insensitive?\nIMO, we should use camelCase for pod fields, to match the way it's serialized in JSON.\nI agree with The goal here is to be consistent with the API, not with the internal Go representation.\nI'd like to fix this before v1beta3 is cast in stone.\nok. Event field selectors are correct then. I will update the selectors for pods to make them camelCase.\nI am wondering if I should change this only for v1beta3 or for 1 and 2 as well? This will be a breaking change for beta1 and 2 if we decide to do that.\nv1beta3 only, though that's hard, we should reconsider. We're contemplating another \"breakage day\", and I doubt this is widely used.", "positive_passages": [{"docid": "doc-en-kubernetes-3cffa85d874fce7a91b30059510244f0bfd0ee6dcca9b7598659c0f0d33d1e5e", "text": "case \"v1beta1\", \"v1beta2\": return \"DesiredState.Host\" default: <del> return \"Status.Host\" </del> <ins> return \"status.host\" </ins> } }", "commid": "kubernetes_pr_5220"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f30562564cb56eba266b9f312736a73e9a741562f4b1725bf5d9e724708ac4cc", "query": "As Satnam mentioned in PR , our Fluentd pod tends to not collect the first chunk of logs from each container. I've noticed that it seems to miss different amounts of logs depending on how quickly the container generates them, so it may be a timing issue. cc\nSee", "positive_passages": [{"docid": "doc-en-kubernetes-d974c948cd5e284562a0eb13316116d1c4c247db3126c1374594721930e1ada1", "text": "id: fluentd-to-gcp containers: - name: fluentd-gcp-container <del> image: kubernetes/fluentd-gcp:1.0 </del> <ins> image: kubernetes/fluentd-gcp:1.1 </ins> volumeMounts: - name: containers mountPath: /var/lib/docker/containers", "commid": "kubernetes_pr_5529"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f30562564cb56eba266b9f312736a73e9a741562f4b1725bf5d9e724708ac4cc", "query": "As Satnam mentioned in PR , our Fluentd pod tends to not collect the first chunk of logs from each container. I've noticed that it seems to miss different amounts of logs depending on how quickly the container generates them, so it may be a timing issue. cc\nSee", "positive_passages": [{"docid": "doc-en-kubernetes-fa76cdaaa31be376377ee41866579e41ccf0a8555e0690328e46ba3e07efcb70", "text": ".PHONY:\tbuild push <del> TAG = 1.0 </del> <ins> TAG = 1.1 </ins> build: sudo docker build -t kubernetes/fluentd-gcp:$(TAG) .", "commid": "kubernetes_pr_5529"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f30562564cb56eba266b9f312736a73e9a741562f4b1725bf5d9e724708ac4cc", "query": "As Satnam mentioned in PR , our Fluentd pod tends to not collect the first chunk of logs from each container. I've noticed that it seems to miss different amounts of logs depending on how quickly the container generates them, so it may be a timing issue. cc\nSee", "positive_passages": [{"docid": "doc-en-kubernetes-1a9de9bdee26d83ba471fedfe873f0807689d9d7ba9fd258368953654fa49de9", "text": "path /var/lib/docker/containers/*/*-json.log pos_file /var/lib/docker/containers/containers.log.pos time_format %Y-%m-%dT%H:%M:%S <del> tag docker.container.* </del> <ins> tag docker.* read_from_head true </ins> </source> <del> <match docker.container.**> </del> <ins> <match docker.**> </ins> type google_cloud flush_interval 5s # Never wait longer than 5 minutes between retries.", "commid": "kubernetes_pr_5529"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-055ba99112a20fcfdd2bfe16fad9fecdba21385acc682dc56530d866ddb24088", "query": "Follow up from\nBumping this up to P1 given that 0.12.2 wasn't able to create a service with an external load balancer and we didn't notice before cutting the release.\nNo, to be clearer, 0.12.2 wasn't able to create a service with ELB on GKE. That was on our side entirely.\nBut it doesn't invalidate the need for this.\nThe example is using ELB.\nare you actively working on this? If not, I'd be up for doing it today.\nMaybe not actively but I know what to, however I won't be able to finish it today, so if you think you can do it today please move forward.\nWe run the e2e tests on GKE, so if we had a test for creating an ELB we would have known that the 0.12.2 release wouldn't work on GKE. I don't see how your point applies. The e2e tests are in place so that we don't have to test each feature manually to verify that it is working, and we only found out that this feature was broken on GKE after we pushed 0.12.2, hence the need for an e2e test.\nI think and you are in fact in agreement\nright now, k8petstore tests the external load balancer by curling down the amount of transactions ingested from the REST API. im playing with porting it as a e2e test now. The code in the shell script is a little raw, but you can see that it specifies a PUBLIC_IP and then curls down from it at the end ().\nthat sounds great. What I'd really like to see here though (and what is going to do early next week) is a very simple test that isolates creating a service with an ELB to verify that creating a load balancer works in isolation from a complex test of other parts of the system. This will give us a really clear signal when the test starts to fail instead of needing to debug lots of moving parts when we see a test failure.", "positive_passages": [{"docid": "doc-en-kubernetes-bc33c6c589a1b7b1392f2ca9bb3a18ec63283e63a2570d5983352667921d9e33", "text": "import ( \"fmt\" <ins> \"io/ioutil\" \"net/http\" </ins> \"sort\" <ins> \"strings\" </ins> \"time\" \"github.com/GoogleCloudPlatform/kubernetes/pkg/api\"", "commid": "kubernetes_pr_5772"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-055ba99112a20fcfdd2bfe16fad9fecdba21385acc682dc56530d866ddb24088", "query": "Follow up from\nBumping this up to P1 given that 0.12.2 wasn't able to create a service with an external load balancer and we didn't notice before cutting the release.\nNo, to be clearer, 0.12.2 wasn't able to create a service with ELB on GKE. That was on our side entirely.\nBut it doesn't invalidate the need for this.\nThe example is using ELB.\nare you actively working on this? If not, I'd be up for doing it today.\nMaybe not actively but I know what to, however I won't be able to finish it today, so if you think you can do it today please move forward.\nWe run the e2e tests on GKE, so if we had a test for creating an ELB we would have known that the 0.12.2 release wouldn't work on GKE. I don't see how your point applies. The e2e tests are in place so that we don't have to test each feature manually to verify that it is working, and we only found out that this feature was broken on GKE after we pushed 0.12.2, hence the need for an e2e test.\nI think and you are in fact in agreement\nright now, k8petstore tests the external load balancer by curling down the amount of transactions ingested from the REST API. im playing with porting it as a e2e test now. The code in the shell script is a little raw, but you can see that it specifies a PUBLIC_IP and then curls down from it at the end ().\nthat sounds great. What I'd really like to see here though (and what is going to do early next week) is a very simple test that isolates creating a service with an ELB to verify that creating a load balancer works in isolation from a complex test of other parts of the system. This will give us a really clear signal when the test starts to fail instead of needing to debug lots of moving parts when we see a test failure.", "positive_passages": [{"docid": "doc-en-kubernetes-792316d300c2c14b4ff41fefe9f89b3357d5505d15217c97651bddd5de293fc7", "text": "}() }, 240.0) <ins> It(\"should be able to create a functioning external load balancer\", func() { serviceName := \"external-lb-test\" ns := api.NamespaceDefault labels := map[string]string{ \"key0\": \"value0\", } service := &api.Service{ ObjectMeta: api.ObjectMeta{ Name: serviceName, }, Spec: api.ServiceSpec{ Port:                       80, Selector:                   labels, TargetPort:                 util.NewIntOrStringFromInt(80), CreateExternalLoadBalancer: true, }, } By(\"cleaning up previous service \" + serviceName + \" from namespace \" + ns) c.Services(ns).Delete(serviceName) By(\"creating service \" + serviceName + \" with external load balancer in namespace \" + ns) result, err := c.Services(ns).Create(service) Expect(err).NotTo(HaveOccurred()) defer func(ns, serviceName string) { // clean up when we're done By(\"deleting service \" + serviceName + \" in namespace \" + ns) err := c.Services(ns).Delete(serviceName) Expect(err).NotTo(HaveOccurred()) }(ns, serviceName) if len(result.Spec.PublicIPs) != 1 { Failf(\"got unexpected number (%d) of public IPs for externally load balanced service: %v\", result.Spec.PublicIPs, result) } ip := result.Spec.PublicIPs[0] port := result.Spec.Port pod := &api.Pod{ TypeMeta: api.TypeMeta{ Kind:       \"Pod\", APIVersion: \"v1beta1\", }, ObjectMeta: api.ObjectMeta{ Name:   \"elb-test-\" + string(util.NewUUID()), Labels: labels, }, Spec: api.PodSpec{ Containers: []api.Container{ { Name:  \"webserver\", Image: \"kubernetes/test-webserver\", }, }, }, } By(\"creating pod to be part of service \" + serviceName) podClient := c.Pods(api.NamespaceDefault) defer func() { By(\"deleting pod \" + pod.Name) defer GinkgoRecover() podClient.Delete(pod.Name) }() if _, err := podClient.Create(pod); err != nil { Failf(\"Failed to create pod %s: %v\", pod.Name, err) } expectNoError(waitForPodRunning(c, pod.Name)) By(\"hitting the pod through the service's external load balancer\") var resp *http.Response for t := time.Now(); time.Since(t) < 4*time.Minute; time.Sleep(5 * time.Second) { resp, err = http.Get(fmt.Sprintf(\"http://%s:%d\", ip, port)) if err == nil { break } } Expect(err).NotTo(HaveOccurred()) defer resp.Body.Close() body, err := ioutil.ReadAll(resp.Body) Expect(err).NotTo(HaveOccurred()) if resp.StatusCode != 200 { Failf(\"received non-success return status %q trying to access pod through load balancer; got body: %s\", resp.Status, string(body)) } if !strings.Contains(string(body), \"test-webserver\") { Failf(\"received response body without expected substring 'test-webserver': %s\", string(body)) } }) </ins> It(\"should correctly serve identically named services in different namespaces on different external IP addresses\", func() { serviceNames := []string{\"services-namespace-test0\"} // Could add more here, but then it takes longer. namespaces := []string{\"namespace0\", \"namespace1\"}   // As above.", "commid": "kubernetes_pr_5772"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8b90e794a405b333388e6df8baae871c4efe69af9084fc8c039b202f7304993d", "query": "We already \"healthcheck\" kubelet and docker periodically, but miss one for kube-proxy.\nIt would make sense to do (only bind to localhost) at the same time we add the healthchecking configuration.", "positive_passages": [{"docid": "doc-en-kubernetes-72de335dd829a82140eb7c112dc208a30920157e1177a07be64d42712c85e186", "text": "- user: root - group: root - mode: 644 <ins> /etc/monit/conf.d/kube-proxy: file: - managed - source: salt://monit/kube-proxy - user: root - group: root - mode: 644 </ins> {% endif %} monit-service: service: - running <del> - name: monit </del> <ins> - name: monit </ins> - watch: <del> - pkg: monit </del> <ins> - pkg: monit </ins> - file: /etc/monit/conf.d/* {% endif %}", "commid": "kubernetes_pr_5984"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8b90e794a405b333388e6df8baae871c4efe69af9084fc8c039b202f7304993d", "query": "We already \"healthcheck\" kubelet and docker periodically, but miss one for kube-proxy.\nIt would make sense to do (only bind to localhost) at the same time we add the healthchecking configuration.", "positive_passages": [{"docid": "doc-en-kubernetes-3701f5e9bc547f0927e7e901d14d5fff36a9c803b0f591700698c66174802914", "text": "<ins> check process kube-proxy with pidfile /var/run/kube-proxy.pid group kube-proxy start program = \"/etc/init.d/kube-proxy start\" stop program = \"/etc/init.d/kube-proxy stop\" if does not exist then restart if failed port 10249 protocol HTTP request \"/healthz\" with timeout 10 seconds then restart </ins>", "commid": "kubernetes_pr_5984"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1e28174cedbb4bdd2cadfc4485cd269e35cba0fa67cd75c639195b8163f8326", "query": "stack trace here: it's due to a shared variable:\nHi thanks for reporting the issue with a patch! Do you want to submit a PR so that you can take the credit for your fix? :)\ndone , Yu-Ju Hong wrote: 585.241.9488 (voice) 650.649.6071 (fax)\nFYI, I think the same bug may still exist in your new PR.\nThere are multiple p\nThere are multiple PRs in flight, so I don't know which one you have in mind. One of them removes probing logic from controller altogether.\nI was referring to , but I didn't read that PR closely so the bug may longer exist there. Again, just a FYI. :)", "positive_passages": [{"docid": "doc-en-kubernetes-b9dbe25ff76cefd6cbdd9391e75cf09df87912fa1e04ae8351971c113fe8ae15", "text": "// Start syncing node list from cloudprovider. if syncNodeList && nc.isRunningCloudProvider() { go util.Forever(func() { <del> if err = nc.SyncCloudNodes(); err != nil { </del> <ins> if err := nc.SyncCloudNodes(); err != nil { </ins> glog.Errorf(\"Error syncing cloud: %v\", err) } }, period)", "commid": "kubernetes_pr_6418"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1e28174cedbb4bdd2cadfc4485cd269e35cba0fa67cd75c639195b8163f8326", "query": "stack trace here: it's due to a shared variable:\nHi thanks for reporting the issue with a patch! Do you want to submit a PR so that you can take the credit for your fix? :)\ndone , Yu-Ju Hong wrote: 585.241.9488 (voice) 650.649.6071 (fax)\nFYI, I think the same bug may still exist in your new PR.\nThere are multiple p\nThere are multiple PRs in flight, so I don't know which one you have in mind. One of them removes probing logic from controller altogether.\nI was referring to , but I didn't read that PR closely so the bug may longer exist there. Again, just a FYI. :)", "positive_passages": [{"docid": "doc-en-kubernetes-442221afe3f5835f71768ab201c205c080345d3dfc3e3e1b33c8a72c2b868606", "text": "// Start syncing or monitoring node status. if syncNodeStatus { go util.Forever(func() { <del> if err = nc.SyncProbedNodeStatus(); err != nil { </del> <ins> if err := nc.SyncProbedNodeStatus(); err != nil { </ins> glog.Errorf(\"Error syncing status: %v\", err) } }, period) } else { go util.Forever(func() { <del> if err = nc.MonitorNodeStatus(); err != nil { </del> <ins> if err := nc.MonitorNodeStatus(); err != nil { </ins> glog.Errorf(\"Error monitoring node status: %v\", err) } }, nodeMonitorPeriod)", "commid": "kubernetes_pr_6418"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1ff2227b578e0892bac06941b2b21a44da67a8fc722cc77d63c9a7ab123d81a8", "query": "Appears to deadlock or otherwise hang after a few seconds and then hit the 5-minute timeout. From start of log: followed by stack traces of zillions of goroutines that mostly report being blocked for 4+ minutes. Recent instances: https://travis- https://travis- cc\nI tried to reproduce the issue by run kubelet unittests 200 times (100 for v1beta1, and 100 for v1beta3), but failed to reproduce the issue. I poked around, and found the only difference between my local machine and test machine is that I am running go 1.4.2 and test machine is running 1.3 (both failure cases posted by are with 1.3.0). I remembered from online I saw a deadlock issue reported against old golang version, but haven't found that issue yet. I will continue trying to reproduce the issue.\nSaw this in travis runs too: https://travis-\nYes, there have been multiple failures today. Check shippable, also.\nFWIW, these are not all kubelet tests failing, but all of them have many kubelet go routines in the trace - mostly stuck in managePodLoop().\nI reran a couple of thousands time last night before I leave, and all passed. Yu-Ju just pointed out that the failure posted above by is go1.4. Shippable is in a really bad shape today, tons of different tests are failed, which should be handled separately.\nOk, with some hacky debugging message into kubelet package, even I couldn't reproduce the very failure reported here, I made some progress on understanding the issue here. Basically there are two issues: 1) The flaky tests reported here are TestServeExecInContainer. All reports posted here have the same stack trace below: 2) There are tons of goroutines, especially one created for each pod. Kubelet leak those goroutines. One can see when test initial run, there are 106 goroutines. Test itself create another 41 goroutines, but none of them are created for podWorkder.\nFWIW, the tests in were creating go routines it didn't need at all. I just removed them in\nThanks for cleanup. Now the number down to 91:\ncc/\nDid something change related to this recently? I haven't heard any flakiness reports for a long time, and now they're starting up again. Any ideas? Sent from my iPhone\nI didn't see any changes related to this feature. Actually I even couldn't reproduce it on my desktop. Please note that the comment I made above all those leftover goroutines are separate issue thought.\nThis has exposed a deadlock in spdystream. I'll work with to come up with a fix.\nUpstream issue\nCool ncdc@ ! dchen1107 by the way, I've run across a few similar bugs recently where their reproducibility hinges mainly on how the test cluster was brought up. If the test cluster comes up right, then the tests pass 100% forever. If the cluster comes up bad, the tests fail, sometimes forever. Were you rerunning your tests against the same test cluster? Or rebuilding your test cluster between every test invocation?\nThis is unittests, not e2e. We saw test flakiness through travis and shippable, but never on my desktop.\nThis will hopefully fix the deadlock: I will do a bump commit once it's merged.\nThanks for your quick fix. I will clean up goroutines after that.\nit's entirely possible there's some bugs in my exec & port forwarding code around leaking goroutines. Are you going to take an initial look to see what's sticking around?\nYes, your test leak some goroutine, but other tests too.", "positive_passages": [{"docid": "doc-en-kubernetes-64f9b86f5ec6dfefe00b1c68860c6178cc467215741af45f44f7faf5a2753ac8", "text": "}, { \"ImportPath\": \"github.com/docker/spdystream\", <del> \"Rev\": \"e731c8f9f19ffd7e51a469a2de1580c1dfbb4fae\" </del> <ins> \"Rev\": \"99515db39d3dad9607e0293f18152f3d59da76dc\" </ins> }, { \"ImportPath\": \"github.com/elazarl/go-bindata-assetfs\",", "commid": "kubernetes_pr_6632"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1ff2227b578e0892bac06941b2b21a44da67a8fc722cc77d63c9a7ab123d81a8", "query": "Appears to deadlock or otherwise hang after a few seconds and then hit the 5-minute timeout. From start of log: followed by stack traces of zillions of goroutines that mostly report being blocked for 4+ minutes. Recent instances: https://travis- https://travis- cc\nI tried to reproduce the issue by run kubelet unittests 200 times (100 for v1beta1, and 100 for v1beta3), but failed to reproduce the issue. I poked around, and found the only difference between my local machine and test machine is that I am running go 1.4.2 and test machine is running 1.3 (both failure cases posted by are with 1.3.0). I remembered from online I saw a deadlock issue reported against old golang version, but haven't found that issue yet. I will continue trying to reproduce the issue.\nSaw this in travis runs too: https://travis-\nYes, there have been multiple failures today. Check shippable, also.\nFWIW, these are not all kubelet tests failing, but all of them have many kubelet go routines in the trace - mostly stuck in managePodLoop().\nI reran a couple of thousands time last night before I leave, and all passed. Yu-Ju just pointed out that the failure posted above by is go1.4. Shippable is in a really bad shape today, tons of different tests are failed, which should be handled separately.\nOk, with some hacky debugging message into kubelet package, even I couldn't reproduce the very failure reported here, I made some progress on understanding the issue here. Basically there are two issues: 1) The flaky tests reported here are TestServeExecInContainer. All reports posted here have the same stack trace below: 2) There are tons of goroutines, especially one created for each pod. Kubelet leak those goroutines. One can see when test initial run, there are 106 goroutines. Test itself create another 41 goroutines, but none of them are created for podWorkder.\nFWIW, the tests in were creating go routines it didn't need at all. I just removed them in\nThanks for cleanup. Now the number down to 91:\ncc/\nDid something change related to this recently? I haven't heard any flakiness reports for a long time, and now they're starting up again. Any ideas? Sent from my iPhone\nI didn't see any changes related to this feature. Actually I even couldn't reproduce it on my desktop. Please note that the comment I made above all those leftover goroutines are separate issue thought.\nThis has exposed a deadlock in spdystream. I'll work with to come up with a fix.\nUpstream issue\nCool ncdc@ ! dchen1107 by the way, I've run across a few similar bugs recently where their reproducibility hinges mainly on how the test cluster was brought up. If the test cluster comes up right, then the tests pass 100% forever. If the cluster comes up bad, the tests fail, sometimes forever. Were you rerunning your tests against the same test cluster? Or rebuilding your test cluster between every test invocation?\nThis is unittests, not e2e. We saw test flakiness through travis and shippable, but never on my desktop.\nThis will hopefully fix the deadlock: I will do a bump commit once it's merged.\nThanks for your quick fix. I will clean up goroutines after that.\nit's entirely possible there's some bugs in my exec & port forwarding code around leaking goroutines. Are you going to take an initial look to see what's sticking around?\nYes, your test leak some goroutine, but other tests too.", "positive_passages": [{"docid": "doc-en-kubernetes-053f8acab286a5f198c08967aa78b86517c62614d9910c64e78f4c53d8852bce", "text": "if timer != nil { timer.Stop() } <ins> // Start a goroutine to drain resetChan. This is needed because we've seen // some unit tests with large numbers of goroutines get into a situation // where resetChan fills up, at least 1 call to Write() is still trying to // send to resetChan, the connection gets closed, and this case statement // attempts to grab the write lock that Write() already has, causing a // deadlock. // // See https://github.com/docker/spdystream/issues/49 for more details. go func() { for _ = range resetChan { } }() </ins> i.writeLock.Lock() close(resetChan) i.resetChan = nil i.writeLock.Unlock() break Loop } }", "commid": "kubernetes_pr_6632"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fd524e6826dc66b2f73439575ef5cd8d63e3e397dffa3cbe39f71d1f2888b60e", "query": "goroutine 11 [running]: net/http.(ServeMux).Handle(0xc20800a8a0, 0x9e9490, 0xd, 0x7f7d12f190a0, 0xb0e7c0) +0x244 net/http.(ServeMux).HandleFunc(0xc20800a8a0, 0x9e9490, 0xd, 0xb0e7c0) +0x6d net/http.HandleFunc(0x9e9490, 0xd, 0xb0e7c0) +0x48 \u00b7001() +0x58 created by (*SchedulerServer).Run +0x1c7\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-2c22877a1660934c80a26cc59f123aad314705efbd22f89e40a359fceb84225b", "text": "client.BindClientConfigFlags(fs, &s.ClientConfig) fs.StringVar(&s.AlgorithmProvider, \"algorithm_provider\", s.AlgorithmProvider, \"The scheduling algorithm provider to use\") fs.StringVar(&s.PolicyConfigFile, \"policy_config_file\", s.PolicyConfigFile, \"File with scheduler policy configuration\") <del> fs.BoolVar(&s.EnableProfiling, \"profiling\", false, \"Enable profiling via web interface host:port/debug/pprof/\") </del> <ins> fs.BoolVar(&s.EnableProfiling, \"profiling\", true, \"Enable profiling via web interface host:port/debug/pprof/\") </ins> } // Run runs the specified SchedulerServer.  This should never exit.", "commid": "kubernetes_pr_6623"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fd524e6826dc66b2f73439575ef5cd8d63e3e397dffa3cbe39f71d1f2888b60e", "query": "goroutine 11 [running]: net/http.(ServeMux).Handle(0xc20800a8a0, 0x9e9490, 0xd, 0x7f7d12f190a0, 0xb0e7c0) +0x244 net/http.(ServeMux).HandleFunc(0xc20800a8a0, 0x9e9490, 0xd, 0xb0e7c0) +0x6d net/http.HandleFunc(0x9e9490, 0xd, 0xb0e7c0) +0x48 \u00b7001() +0x58 created by (*SchedulerServer).Run +0x1c7\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-83c484a5085fa9d343f73b464d909c72a7ccd5d390861b384eb9e569aa4520bb", "text": "} go func() { <ins> mux := http.NewServeMux() </ins> if s.EnableProfiling { <del> http.HandleFunc(\"/debug/pprof/\", pprof.Index) http.HandleFunc(\"/debug/pprof/profile\", pprof.Profile) http.HandleFunc(\"/debug/pprof/symbol\", pprof.Symbol) </del> <ins> mux.HandleFunc(\"/debug/pprof/\", pprof.Index) mux.HandleFunc(\"/debug/pprof/profile\", pprof.Profile) mux.HandleFunc(\"/debug/pprof/symbol\", pprof.Symbol) </ins> } <del> http.Handle(\"/metrics\", prometheus.Handler()) http.ListenAndServe(net.JoinHostPort(s.Address.String(), strconv.Itoa(s.Port)), nil) </del> <ins> mux.Handle(\"/metrics\", prometheus.Handler()) server := &http.Server{ Addr:    net.JoinHostPort(s.Address.String(), strconv.Itoa(s.Port)), Handler: mux, } glog.Fatal(server.ListenAndServe()) </ins> }() configFactory := factory.NewConfigFactory(kubeClient)", "commid": "kubernetes_pr_6623"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-859a8b847337ca2cf9879726f3bdb71f0db5559ee2589591ceae612e41f71a1b", "query": "There is a funny subtle behvaiour in get namespaces, in which if i call more than one time, it seems that the removal from Terminating state is accelarated. It seems this might indicate a bug, or maybe its not a bug and the eventual semantics of is a little funny sometimes. in any case, here's what we are seeing : 1) when i delete a namespace the first time usning kubectl, we get a state change to . that is correct, of course. 2) but ... if make the call a second time, then the same status line is immediately removed from . Expected behaviour : A second call to \"kubectl delete ...\" shouldn't have any effect on the timing of removal of a namespace from 'Terminating' state*... So i guess there is some \"eventual consistency\" subtle bug that is resolved by repeated calls to\nsuggests this may not be e bug, maybe its just the etcd eventual deleter thingy.\nLooks to definitely be a bug. The 2nd delete seems to have interrupted the delete process and artifacts (like events) from the namespace still exist in etcd.\ninvestigating...\noops, see the error, will submit a fix.\nI have a fix, but need a test case, will submit PR tomorrow AM", "positive_passages": [{"docid": "doc-en-kubernetes-a8e7be87469f3db4b87b353f0c5442e105958d66686a072ebeba0ec2f9c5238f", "text": "allErrs := errs.ValidationErrorList{} allErrs = append(allErrs, ValidateObjectMetaUpdate(&oldNamespace.ObjectMeta, &newNamespace.ObjectMeta).Prefix(\"metadata\")...) newNamespace.Spec = oldNamespace.Spec <ins> if newNamespace.DeletionTimestamp.IsZero() { if newNamespace.Status.Phase != api.NamespaceActive { allErrs = append(allErrs, errs.NewFieldInvalid(\"Status.Phase\", newNamespace.Status.Phase, \"A namespace may only be in active status if it does not have a deletion timestamp.\")) } } else { if newNamespace.Status.Phase != api.NamespaceTerminating { allErrs = append(allErrs, errs.NewFieldInvalid(\"Status.Phase\", newNamespace.Status.Phase, \"A namespace may only be in terminating status if it has a deletion timestamp.\")) } } </ins> return allErrs }", "commid": "kubernetes_pr_6686"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-859a8b847337ca2cf9879726f3bdb71f0db5559ee2589591ceae612e41f71a1b", "query": "There is a funny subtle behvaiour in get namespaces, in which if i call more than one time, it seems that the removal from Terminating state is accelarated. It seems this might indicate a bug, or maybe its not a bug and the eventual semantics of is a little funny sometimes. in any case, here's what we are seeing : 1) when i delete a namespace the first time usning kubectl, we get a state change to . that is correct, of course. 2) but ... if make the call a second time, then the same status line is immediately removed from . Expected behaviour : A second call to \"kubectl delete ...\" shouldn't have any effect on the timing of removal of a namespace from 'Terminating' state*... So i guess there is some \"eventual consistency\" subtle bug that is resolved by repeated calls to\nsuggests this may not be e bug, maybe its just the etcd eventual deleter thingy.\nLooks to definitely be a bug. The 2nd delete seems to have interrupted the delete process and artifacts (like events) from the namespace still exist in etcd.\ninvestigating...\noops, see the error, will submit a fix.\nI have a fix, but need a test case, will submit PR tomorrow AM", "positive_passages": [{"docid": "doc-en-kubernetes-e2e629b206b5725045db59a13a56bbb1e07d0387eef65c90c0f5625c5a672282", "text": "} func TestValidateNamespaceStatusUpdate(t *testing.T) { <ins> now := util.Now() </ins> tests := []struct { oldNamespace api.Namespace namespace    api.Namespace valid        bool }{ <del> {api.Namespace{}, api.Namespace{}, true}, </del> <ins> {api.Namespace{}, api.Namespace{ Status: api.NamespaceStatus{ Phase: api.NamespaceActive, }, }, true}, </ins> {api.Namespace{ ObjectMeta: api.ObjectMeta{ Name: \"foo\"}}, api.Namespace{ ObjectMeta: api.ObjectMeta{ <del> Name: \"foo\"}, </del> <ins> Name:              \"foo\", DeletionTimestamp: &now}, </ins> Status: api.NamespaceStatus{ Phase: api.NamespaceTerminating, },", "commid": "kubernetes_pr_6686"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-859a8b847337ca2cf9879726f3bdb71f0db5559ee2589591ceae612e41f71a1b", "query": "There is a funny subtle behvaiour in get namespaces, in which if i call more than one time, it seems that the removal from Terminating state is accelarated. It seems this might indicate a bug, or maybe its not a bug and the eventual semantics of is a little funny sometimes. in any case, here's what we are seeing : 1) when i delete a namespace the first time usning kubectl, we get a state change to . that is correct, of course. 2) but ... if make the call a second time, then the same status line is immediately removed from . Expected behaviour : A second call to \"kubectl delete ...\" shouldn't have any effect on the timing of removal of a namespace from 'Terminating' state*... So i guess there is some \"eventual consistency\" subtle bug that is resolved by repeated calls to\nsuggests this may not be e bug, maybe its just the etcd eventual deleter thingy.\nLooks to definitely be a bug. The 2nd delete seems to have interrupted the delete process and artifacts (like events) from the namespace still exist in etcd.\ninvestigating...\noops, see the error, will submit a fix.\nI have a fix, but need a test case, will submit PR tomorrow AM", "positive_passages": [{"docid": "doc-en-kubernetes-bef27bef5c19cde72d5a3fb04023d8a16b2c68eb91d6f8f4b4b7eeaffab2c5a2", "text": "Name: \"foo\"}}, api.Namespace{ ObjectMeta: api.ObjectMeta{ <ins> Name: \"foo\"}, Status: api.NamespaceStatus{ Phase: api.NamespaceTerminating, }, }, false}, {api.Namespace{ ObjectMeta: api.ObjectMeta{ Name: \"foo\"}}, api.Namespace{ ObjectMeta: api.ObjectMeta{ </ins> Name: \"bar\"}, Status: api.NamespaceStatus{ Phase: api.NamespaceTerminating,", "commid": "kubernetes_pr_6686"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-859a8b847337ca2cf9879726f3bdb71f0db5559ee2589591ceae612e41f71a1b", "query": "There is a funny subtle behvaiour in get namespaces, in which if i call more than one time, it seems that the removal from Terminating state is accelarated. It seems this might indicate a bug, or maybe its not a bug and the eventual semantics of is a little funny sometimes. in any case, here's what we are seeing : 1) when i delete a namespace the first time usning kubectl, we get a state change to . that is correct, of course. 2) but ... if make the call a second time, then the same status line is immediately removed from . Expected behaviour : A second call to \"kubectl delete ...\" shouldn't have any effect on the timing of removal of a namespace from 'Terminating' state*... So i guess there is some \"eventual consistency\" subtle bug that is resolved by repeated calls to\nsuggests this may not be e bug, maybe its just the etcd eventual deleter thingy.\nLooks to definitely be a bug. The 2nd delete seems to have interrupted the delete process and artifacts (like events) from the namespace still exist in etcd.\ninvestigating...\noops, see the error, will submit a fix.\nI have a fix, but need a test case, will submit PR tomorrow AM", "positive_passages": [{"docid": "doc-en-kubernetes-4523f688787ea72a5eee2a31a0921a8a91901ec4be3d23639647dc18b5f3c47c", "text": "for i, test := range tests { test.namespace.ObjectMeta.ResourceVersion = \"1\" test.oldNamespace.ObjectMeta.ResourceVersion = \"1\" <del> errs := ValidateNamespaceStatusUpdate(&test.oldNamespace, &test.namespace) </del> <ins> errs := ValidateNamespaceStatusUpdate(&test.namespace, &test.oldNamespace) </ins> if test.valid && len(errs) > 0 { t.Errorf(\"%d: Unexpected error: %v\", i, errs) t.Logf(\"%#v vs %#v\", test.oldNamespace.ObjectMeta, test.namespace.ObjectMeta)", "commid": "kubernetes_pr_6686"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-859a8b847337ca2cf9879726f3bdb71f0db5559ee2589591ceae612e41f71a1b", "query": "There is a funny subtle behvaiour in get namespaces, in which if i call more than one time, it seems that the removal from Terminating state is accelarated. It seems this might indicate a bug, or maybe its not a bug and the eventual semantics of is a little funny sometimes. in any case, here's what we are seeing : 1) when i delete a namespace the first time usning kubectl, we get a state change to . that is correct, of course. 2) but ... if make the call a second time, then the same status line is immediately removed from . Expected behaviour : A second call to \"kubectl delete ...\" shouldn't have any effect on the timing of removal of a namespace from 'Terminating' state*... So i guess there is some \"eventual consistency\" subtle bug that is resolved by repeated calls to\nsuggests this may not be e bug, maybe its just the etcd eventual deleter thingy.\nLooks to definitely be a bug. The 2nd delete seems to have interrupted the delete process and artifacts (like events) from the namespace still exist in etcd.\ninvestigating...\noops, see the error, will submit a fix.\nI have a fix, but need a test case, will submit PR tomorrow AM", "positive_passages": [{"docid": "doc-en-kubernetes-18bb6e3dc3203f351dbdc9bcd95190486b4cd69262f5530f27a34e45ef25a378", "text": "namespace := nsObj.(*api.Namespace) // upon first request to delete, we switch the phase to start namespace termination <del> if namespace.DeletionTimestamp == nil { </del> <ins> if namespace.DeletionTimestamp.IsZero() { </ins> now := util.Now() namespace.DeletionTimestamp = &now namespace.Status.Phase = api.NamespaceTerminating", "commid": "kubernetes_pr_6686"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-859a8b847337ca2cf9879726f3bdb71f0db5559ee2589591ceae612e41f71a1b", "query": "There is a funny subtle behvaiour in get namespaces, in which if i call more than one time, it seems that the removal from Terminating state is accelarated. It seems this might indicate a bug, or maybe its not a bug and the eventual semantics of is a little funny sometimes. in any case, here's what we are seeing : 1) when i delete a namespace the first time usning kubectl, we get a state change to . that is correct, of course. 2) but ... if make the call a second time, then the same status line is immediately removed from . Expected behaviour : A second call to \"kubectl delete ...\" shouldn't have any effect on the timing of removal of a namespace from 'Terminating' state*... So i guess there is some \"eventual consistency\" subtle bug that is resolved by repeated calls to\nsuggests this may not be e bug, maybe its just the etcd eventual deleter thingy.\nLooks to definitely be a bug. The 2nd delete seems to have interrupted the delete process and artifacts (like events) from the namespace still exist in etcd.\ninvestigating...\noops, see the error, will submit a fix.\nI have a fix, but need a test case, will submit PR tomorrow AM", "positive_passages": [{"docid": "doc-en-kubernetes-b51a6f6ad150d42c3ad2c2aac15dafd3233c0e6c88413c75cde1e341a9077c5d", "text": "// prior to final deletion, we must ensure that finalizers is empty if len(namespace.Spec.Finalizers) != 0 { <del> err = fmt.Errorf(\"Unable to delete namespace %v because finalizers is not empty %v\", namespace.Name, namespace.Spec.Finalizers) </del> <ins> err = fmt.Errorf(\"Namespace %v termination is in progress, waiting for %v\", namespace.Name, namespace.Spec.Finalizers) return nil, err </ins> } return r.Etcd.Delete(ctx, name, nil) }", "commid": "kubernetes_pr_6686"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-859a8b847337ca2cf9879726f3bdb71f0db5559ee2589591ceae612e41f71a1b", "query": "There is a funny subtle behvaiour in get namespaces, in which if i call more than one time, it seems that the removal from Terminating state is accelarated. It seems this might indicate a bug, or maybe its not a bug and the eventual semantics of is a little funny sometimes. in any case, here's what we are seeing : 1) when i delete a namespace the first time usning kubectl, we get a state change to . that is correct, of course. 2) but ... if make the call a second time, then the same status line is immediately removed from . Expected behaviour : A second call to \"kubectl delete ...\" shouldn't have any effect on the timing of removal of a namespace from 'Terminating' state*... So i guess there is some \"eventual consistency\" subtle bug that is resolved by repeated calls to\nsuggests this may not be e bug, maybe its just the etcd eventual deleter thingy.\nLooks to definitely be a bug. The 2nd delete seems to have interrupted the delete process and artifacts (like events) from the namespace still exist in etcd.\ninvestigating...\noops, see the error, will submit a fix.\nI have a fix, but need a test case, will submit PR tomorrow AM", "positive_passages": [{"docid": "doc-en-kubernetes-54ae05a93453d5828d9cb0fcc62d9ce1e8af2c9df4a3b559e1cba98cfa50d57e", "text": "if err != nil { t.Fatalf(\"unexpected error: %v\", err) } <ins> } func TestDeleteNamespaceWithIncompleteFinalizers(t *testing.T) { now := util.Now() fakeEtcdClient, helper := newHelper(t) fakeEtcdClient.ChangeIndex = 1 fakeEtcdClient.Data[\"/registry/namespaces/foo\"] = tools.EtcdResponseWithError{ R: &etcd.Response{ Node: &etcd.Node{ Value: runtime.EncodeOrDie(latest.Codec, &api.Namespace{ ObjectMeta: api.ObjectMeta{ Name:              \"foo\", DeletionTimestamp: &now, }, Spec: api.NamespaceSpec{ Finalizers: []api.FinalizerName{api.FinalizerKubernetes}, }, Status: api.NamespaceStatus{Phase: api.NamespaceActive}, }), ModifiedIndex: 1, CreatedIndex:  1, }, }, } storage, _, _ := NewStorage(helper) _, err := storage.Delete(api.NewDefaultContext(), \"foo\", nil) if err == nil { t.Fatalf(\"expected error: %v\", err) } } </ins> <del> // TODO: when we add life-cycle, this will go to Terminating, and then we need to test Terminating to gone </del> <ins> func TestDeleteNamespaceWithCompleteFinalizers(t *testing.T) { now := util.Now() fakeEtcdClient, helper := newHelper(t) fakeEtcdClient.ChangeIndex = 1 fakeEtcdClient.Data[\"/registry/namespaces/foo\"] = tools.EtcdResponseWithError{ R: &etcd.Response{ Node: &etcd.Node{ Value: runtime.EncodeOrDie(latest.Codec, &api.Namespace{ ObjectMeta: api.ObjectMeta{ Name:              \"foo\", DeletionTimestamp: &now, }, Spec: api.NamespaceSpec{ Finalizers: []api.FinalizerName{}, }, Status: api.NamespaceStatus{Phase: api.NamespaceActive}, }), ModifiedIndex: 1, CreatedIndex:  1, }, }, } storage, _, _ := NewStorage(helper) _, err := storage.Delete(api.NewDefaultContext(), \"foo\", nil) if err != nil { t.Fatalf(\"unexpected error: %v\", err) } </ins> }", "commid": "kubernetes_pr_6686"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-859a8b847337ca2cf9879726f3bdb71f0db5559ee2589591ceae612e41f71a1b", "query": "There is a funny subtle behvaiour in get namespaces, in which if i call more than one time, it seems that the removal from Terminating state is accelarated. It seems this might indicate a bug, or maybe its not a bug and the eventual semantics of is a little funny sometimes. in any case, here's what we are seeing : 1) when i delete a namespace the first time usning kubectl, we get a state change to . that is correct, of course. 2) but ... if make the call a second time, then the same status line is immediately removed from . Expected behaviour : A second call to \"kubectl delete ...\" shouldn't have any effect on the timing of removal of a namespace from 'Terminating' state*... So i guess there is some \"eventual consistency\" subtle bug that is resolved by repeated calls to\nsuggests this may not be e bug, maybe its just the etcd eventual deleter thingy.\nLooks to definitely be a bug. The 2nd delete seems to have interrupted the delete process and artifacts (like events) from the namespace still exist in etcd.\ninvestigating...\noops, see the error, will submit a fix.\nI have a fix, but need a test case, will submit PR tomorrow AM", "positive_passages": [{"docid": "doc-en-kubernetes-1b33fed19f7ef15b640606726c76c5869145649cdb356928e732a50e9f6cfb9c", "text": "\"testing\" \"github.com/GoogleCloudPlatform/kubernetes/pkg/api\" <ins> \"github.com/GoogleCloudPlatform/kubernetes/pkg/util\" </ins> ) func TestNamespaceStrategy(t *testing.T) {", "commid": "kubernetes_pr_6686"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-859a8b847337ca2cf9879726f3bdb71f0db5559ee2589591ceae612e41f71a1b", "query": "There is a funny subtle behvaiour in get namespaces, in which if i call more than one time, it seems that the removal from Terminating state is accelarated. It seems this might indicate a bug, or maybe its not a bug and the eventual semantics of is a little funny sometimes. in any case, here's what we are seeing : 1) when i delete a namespace the first time usning kubectl, we get a state change to . that is correct, of course. 2) but ... if make the call a second time, then the same status line is immediately removed from . Expected behaviour : A second call to \"kubectl delete ...\" shouldn't have any effect on the timing of removal of a namespace from 'Terminating' state*... So i guess there is some \"eventual consistency\" subtle bug that is resolved by repeated calls to\nsuggests this may not be e bug, maybe its just the etcd eventual deleter thingy.\nLooks to definitely be a bug. The 2nd delete seems to have interrupted the delete process and artifacts (like events) from the namespace still exist in etcd.\ninvestigating...\noops, see the error, will submit a fix.\nI have a fix, but need a test case, will submit PR tomorrow AM", "positive_passages": [{"docid": "doc-en-kubernetes-f6f7c6384c04bab0a1dd81fa2e794f07858a9d7b47b566b9cf486eeda7169e53", "text": "if StatusStrategy.AllowCreateOnUpdate() { t.Errorf(\"Namespaces should not allow create on update\") } <ins> now := util.Now() </ins> oldNamespace := &api.Namespace{ ObjectMeta: api.ObjectMeta{Name: \"foo\", ResourceVersion: \"10\"}, Spec:       api.NamespaceSpec{Finalizers: []api.FinalizerName{\"kubernetes\"}}, Status:     api.NamespaceStatus{Phase: api.NamespaceActive}, } namespace := &api.Namespace{ <del> ObjectMeta: api.ObjectMeta{Name: \"foo\", ResourceVersion: \"9\"}, </del> <ins> ObjectMeta: api.ObjectMeta{Name: \"foo\", ResourceVersion: \"9\", DeletionTimestamp: &now}, </ins> Status:     api.NamespaceStatus{Phase: api.NamespaceTerminating}, } StatusStrategy.PrepareForUpdate(namespace, oldNamespace)", "commid": "kubernetes_pr_6686"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c0bb3600e99710565f99e8be4bd669de365f6aed46898aff519521ca79dfa0d", "query": "GCE has a length limit of 63 characters for its load balancer components (target pools and forwarding rules), and AWS has a length limit of 32 characters. Our current load balancer name construction of clustername-namespace-servicename can exceed both limits, especially AWS's. We should use a shorter name construction method less likely to hit these limits.\nThanks for filing this Alex. My suggestion would be to use a simple UID, as per utils.NewUID(). We'll need to store the mapping from {clustername, namespace, servicename} -UID somewhere stable like etcd. Using anything based directly on {cluster, namespace, name}, for example a stable hash of each, has the problem that the aforementioned tuple is not unique over time. This raises the possibility of e.g. the following scenario: creates mycluster/mynamespace/myservicename, which creates external load balancer named stablehash(mycluster,mynamespace,myservicename) deletes mycluster/mynamespace/myservicename, but at the time MyCloudProvider is down, so kubernetes can't delete ELB named stablehash(mycluster,mynamespace,myservicename). Kubernetes keeps trying in the background to delete the ELB. the mean time user creates a new service named the same as her old one mycluster/mynamespace/myservicename. Kubernetes tries to create an associated ELB named stablehash(mycluster,mynamespace,myservicename), but this fails, because the ELB exists already due to 2 above. ... etc. Badness ensues.\nAssigning to Chao Xu, as this makes for a good starter bug.\nHmmmm.... can't seem to assign to caesarxuchao yet. Not sure why.\nHe has to have write privileges on the repo before issues/PRs can be assigned to him.\nBut we have many contributors with issues assigned to them that are not in the kubernetes-write group (that only has 48 members). I must be missing something. How do I grant him write privileges on the repo?\nWe do? That's not how I understand it to work: If you want to add him, go .\nhas been because the load balancer name changes if the service's UID changes (e.g. if it's deleted and recreated). Think we can change this? A hash of cluster name, namespace, and service name should get around it, but there may be better ideas as well.\nSure. I'm not confident that I can fix this quickly. If it's urgent, maybe you can assign some one more experienced to fix it? One question: I guess the ELB's name should stay unchanged as long as the \"zone+namespace+service name\" doesn't change, am I right?\nI think I'm the guilty party here. I was unaware that when we create a new service with the same name as a previously existing service, that it needed to keep the same load balancer name and IP. This seems broken to me, but I may be missing the larger context. We can quite safely roll back the change while we decide on the best alternative solution. Q , Chao Xu wrote:\nI think the real breakage is that we don't have any way to claim an LB-IP at a larger lifespan than a single service. Alex, can you go back to OP and get a sense of what's happening there to trigger this? , Quinton Hoole wrote:\nWill do. Even if the name is kept consistent as it was before, with the way everything currently works the IP won't be consistent.\nyeah, I'm not positive that the name has to be consistent. What we need is a way to claim the same public IP address, and we already have that (at least for GCE) Assigning to me, and I'll validate the length requirements, make sure public ip assignment works for AWS and close out this issue.\nNote there are two separate things here: (1) a purely-name-based construction can exceed length limits given a single service and (2) some form of across-service consistency is apparently needed. (1) is trivially solvable by either always using a hash or alternatively using a two-stage process where you generate a desired name and only hashify if it's longer than the length limits by truncating it and appending a hash of said name.\nAWS's load balancer hasn't been merged yet, so there's not much to check out there. I'm going to be reducing the churn of load balancers later today, which should help prevent IP address changes for services that are modified.\nI think we need to be able to figure out which Service an LB is attached to from the Service, so that LBs can't get orphaned. regarding being able to claim an LB IP. I don't think that is covered in revamp... , Brendan Burns wrote:\nI think that we need to roll back and think this issue through a bit better. See comment on that PR.", "positive_passages": [{"docid": "doc-en-kubernetes-221c64b381a3e63c9a8504c0237f740ee33c62c5df53a0e58a4646ceb83c7e2a", "text": "package gce_cloud import ( <ins> \"crypto/md5\" </ins> \"fmt\" \"io\" \"io/ioutil\"", "commid": "kubernetes_pr_7609"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c0bb3600e99710565f99e8be4bd669de365f6aed46898aff519521ca79dfa0d", "query": "GCE has a length limit of 63 characters for its load balancer components (target pools and forwarding rules), and AWS has a length limit of 32 characters. Our current load balancer name construction of clustername-namespace-servicename can exceed both limits, especially AWS's. We should use a shorter name construction method less likely to hit these limits.\nThanks for filing this Alex. My suggestion would be to use a simple UID, as per utils.NewUID(). We'll need to store the mapping from {clustername, namespace, servicename} -UID somewhere stable like etcd. Using anything based directly on {cluster, namespace, name}, for example a stable hash of each, has the problem that the aforementioned tuple is not unique over time. This raises the possibility of e.g. the following scenario: creates mycluster/mynamespace/myservicename, which creates external load balancer named stablehash(mycluster,mynamespace,myservicename) deletes mycluster/mynamespace/myservicename, but at the time MyCloudProvider is down, so kubernetes can't delete ELB named stablehash(mycluster,mynamespace,myservicename). Kubernetes keeps trying in the background to delete the ELB. the mean time user creates a new service named the same as her old one mycluster/mynamespace/myservicename. Kubernetes tries to create an associated ELB named stablehash(mycluster,mynamespace,myservicename), but this fails, because the ELB exists already due to 2 above. ... etc. Badness ensues.\nAssigning to Chao Xu, as this makes for a good starter bug.\nHmmmm.... can't seem to assign to caesarxuchao yet. Not sure why.\nHe has to have write privileges on the repo before issues/PRs can be assigned to him.\nBut we have many contributors with issues assigned to them that are not in the kubernetes-write group (that only has 48 members). I must be missing something. How do I grant him write privileges on the repo?\nWe do? That's not how I understand it to work: If you want to add him, go .\nhas been because the load balancer name changes if the service's UID changes (e.g. if it's deleted and recreated). Think we can change this? A hash of cluster name, namespace, and service name should get around it, but there may be better ideas as well.\nSure. I'm not confident that I can fix this quickly. If it's urgent, maybe you can assign some one more experienced to fix it? One question: I guess the ELB's name should stay unchanged as long as the \"zone+namespace+service name\" doesn't change, am I right?\nI think I'm the guilty party here. I was unaware that when we create a new service with the same name as a previously existing service, that it needed to keep the same load balancer name and IP. This seems broken to me, but I may be missing the larger context. We can quite safely roll back the change while we decide on the best alternative solution. Q , Chao Xu wrote:\nI think the real breakage is that we don't have any way to claim an LB-IP at a larger lifespan than a single service. Alex, can you go back to OP and get a sense of what's happening there to trigger this? , Quinton Hoole wrote:\nWill do. Even if the name is kept consistent as it was before, with the way everything currently works the IP won't be consistent.\nyeah, I'm not positive that the name has to be consistent. What we need is a way to claim the same public IP address, and we already have that (at least for GCE) Assigning to me, and I'll validate the length requirements, make sure public ip assignment works for AWS and close out this issue.\nNote there are two separate things here: (1) a purely-name-based construction can exceed length limits given a single service and (2) some form of across-service consistency is apparently needed. (1) is trivially solvable by either always using a hash or alternatively using a two-stage process where you generate a desired name and only hashify if it's longer than the length limits by truncating it and appending a hash of said name.\nAWS's load balancer hasn't been merged yet, so there's not much to check out there. I'm going to be reducing the churn of load balancers later today, which should help prevent IP address changes for services that are modified.\nI think we need to be able to figure out which Service an LB is attached to from the Service, so that LBs can't get orphaned. regarding being able to claim an LB IP. I don't think that is covered in revamp... , Brendan Burns wrote:\nI think that we need to roll back and think this issue through a bit better. See comment on that PR.", "positive_passages": [{"docid": "doc-en-kubernetes-7c38531342edb56a5c8d7f0af677b0f3de4b3de5c422f21ebc94dfdcff3de8f3", "text": "\"google.golang.org/cloud/compute/metadata\" ) <ins> const LOAD_BALANCER_NAME_MAX_LENGTH = 63 </ins> // GCECloud is an implementation of Interface, TCPLoadBalancer and Instances for Google Compute Engine. type GCECloud struct { service          *compute.Service", "commid": "kubernetes_pr_7609"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c0bb3600e99710565f99e8be4bd669de365f6aed46898aff519521ca79dfa0d", "query": "GCE has a length limit of 63 characters for its load balancer components (target pools and forwarding rules), and AWS has a length limit of 32 characters. Our current load balancer name construction of clustername-namespace-servicename can exceed both limits, especially AWS's. We should use a shorter name construction method less likely to hit these limits.\nThanks for filing this Alex. My suggestion would be to use a simple UID, as per utils.NewUID(). We'll need to store the mapping from {clustername, namespace, servicename} -UID somewhere stable like etcd. Using anything based directly on {cluster, namespace, name}, for example a stable hash of each, has the problem that the aforementioned tuple is not unique over time. This raises the possibility of e.g. the following scenario: creates mycluster/mynamespace/myservicename, which creates external load balancer named stablehash(mycluster,mynamespace,myservicename) deletes mycluster/mynamespace/myservicename, but at the time MyCloudProvider is down, so kubernetes can't delete ELB named stablehash(mycluster,mynamespace,myservicename). Kubernetes keeps trying in the background to delete the ELB. the mean time user creates a new service named the same as her old one mycluster/mynamespace/myservicename. Kubernetes tries to create an associated ELB named stablehash(mycluster,mynamespace,myservicename), but this fails, because the ELB exists already due to 2 above. ... etc. Badness ensues.\nAssigning to Chao Xu, as this makes for a good starter bug.\nHmmmm.... can't seem to assign to caesarxuchao yet. Not sure why.\nHe has to have write privileges on the repo before issues/PRs can be assigned to him.\nBut we have many contributors with issues assigned to them that are not in the kubernetes-write group (that only has 48 members). I must be missing something. How do I grant him write privileges on the repo?\nWe do? That's not how I understand it to work: If you want to add him, go .\nhas been because the load balancer name changes if the service's UID changes (e.g. if it's deleted and recreated). Think we can change this? A hash of cluster name, namespace, and service name should get around it, but there may be better ideas as well.\nSure. I'm not confident that I can fix this quickly. If it's urgent, maybe you can assign some one more experienced to fix it? One question: I guess the ELB's name should stay unchanged as long as the \"zone+namespace+service name\" doesn't change, am I right?\nI think I'm the guilty party here. I was unaware that when we create a new service with the same name as a previously existing service, that it needed to keep the same load balancer name and IP. This seems broken to me, but I may be missing the larger context. We can quite safely roll back the change while we decide on the best alternative solution. Q , Chao Xu wrote:\nI think the real breakage is that we don't have any way to claim an LB-IP at a larger lifespan than a single service. Alex, can you go back to OP and get a sense of what's happening there to trigger this? , Quinton Hoole wrote:\nWill do. Even if the name is kept consistent as it was before, with the way everything currently works the IP won't be consistent.\nyeah, I'm not positive that the name has to be consistent. What we need is a way to claim the same public IP address, and we already have that (at least for GCE) Assigning to me, and I'll validate the length requirements, make sure public ip assignment works for AWS and close out this issue.\nNote there are two separate things here: (1) a purely-name-based construction can exceed length limits given a single service and (2) some form of across-service consistency is apparently needed. (1) is trivially solvable by either always using a hash or alternatively using a two-stage process where you generate a desired name and only hashify if it's longer than the length limits by truncating it and appending a hash of said name.\nAWS's load balancer hasn't been merged yet, so there's not much to check out there. I'm going to be reducing the churn of load balancers later today, which should help prevent IP address changes for services that are modified.\nI think we need to be able to figure out which Service an LB is attached to from the Service, so that LBs can't get orphaned. regarding being able to claim an LB IP. I don't think that is covered in revamp... , Brendan Burns wrote:\nI think that we need to roll back and think this issue through a bit better. See comment on that PR.", "positive_passages": [{"docid": "doc-en-kubernetes-9f0f66f1e2af5ad5cd1119dd9952c9a96f14b7b79017b33715264980b7ff9712", "text": "} } <ins> func normalizeName(name string) string { // If it's short enough, just leave it. if len(name) < LOAD_BALANCER_NAME_MAX_LENGTH-6 { return name } // Hash and truncate hash := md5.Sum([]byte(name)) truncated := name[0 : LOAD_BALANCER_NAME_MAX_LENGTH-6] shortHash := hash[0:6] return fmt.Sprintf(\"%s%s\", truncated, string(shortHash)) } </ins> // CreateTCPLoadBalancer is an implementation of TCPLoadBalancer.CreateTCPLoadBalancer. // TODO(a-robinson): Don't just ignore specified IP addresses. Check if they're // owned by the project and available to be used, and use them if they are. <del> func (gce *GCECloud) CreateTCPLoadBalancer(name, region string, externalIP net.IP, ports []int, hosts []string, affinityType api.AffinityType) (string, error) { </del> <ins> func (gce *GCECloud) CreateTCPLoadBalancer(origName, region string, externalIP net.IP, ports []int, hosts []string, affinityType api.AffinityType) (string, error) { name := normalizeName(origName) </ins> err := gce.makeTargetPool(name, region, hosts, translateAffinityType(affinityType)) if err != nil { if !isHTTPErrorCode(err, http.StatusConflict) {", "commid": "kubernetes_pr_7609"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c0bb3600e99710565f99e8be4bd669de365f6aed46898aff519521ca79dfa0d", "query": "GCE has a length limit of 63 characters for its load balancer components (target pools and forwarding rules), and AWS has a length limit of 32 characters. Our current load balancer name construction of clustername-namespace-servicename can exceed both limits, especially AWS's. We should use a shorter name construction method less likely to hit these limits.\nThanks for filing this Alex. My suggestion would be to use a simple UID, as per utils.NewUID(). We'll need to store the mapping from {clustername, namespace, servicename} -UID somewhere stable like etcd. Using anything based directly on {cluster, namespace, name}, for example a stable hash of each, has the problem that the aforementioned tuple is not unique over time. This raises the possibility of e.g. the following scenario: creates mycluster/mynamespace/myservicename, which creates external load balancer named stablehash(mycluster,mynamespace,myservicename) deletes mycluster/mynamespace/myservicename, but at the time MyCloudProvider is down, so kubernetes can't delete ELB named stablehash(mycluster,mynamespace,myservicename). Kubernetes keeps trying in the background to delete the ELB. the mean time user creates a new service named the same as her old one mycluster/mynamespace/myservicename. Kubernetes tries to create an associated ELB named stablehash(mycluster,mynamespace,myservicename), but this fails, because the ELB exists already due to 2 above. ... etc. Badness ensues.\nAssigning to Chao Xu, as this makes for a good starter bug.\nHmmmm.... can't seem to assign to caesarxuchao yet. Not sure why.\nHe has to have write privileges on the repo before issues/PRs can be assigned to him.\nBut we have many contributors with issues assigned to them that are not in the kubernetes-write group (that only has 48 members). I must be missing something. How do I grant him write privileges on the repo?\nWe do? That's not how I understand it to work: If you want to add him, go .\nhas been because the load balancer name changes if the service's UID changes (e.g. if it's deleted and recreated). Think we can change this? A hash of cluster name, namespace, and service name should get around it, but there may be better ideas as well.\nSure. I'm not confident that I can fix this quickly. If it's urgent, maybe you can assign some one more experienced to fix it? One question: I guess the ELB's name should stay unchanged as long as the \"zone+namespace+service name\" doesn't change, am I right?\nI think I'm the guilty party here. I was unaware that when we create a new service with the same name as a previously existing service, that it needed to keep the same load balancer name and IP. This seems broken to me, but I may be missing the larger context. We can quite safely roll back the change while we decide on the best alternative solution. Q , Chao Xu wrote:\nI think the real breakage is that we don't have any way to claim an LB-IP at a larger lifespan than a single service. Alex, can you go back to OP and get a sense of what's happening there to trigger this? , Quinton Hoole wrote:\nWill do. Even if the name is kept consistent as it was before, with the way everything currently works the IP won't be consistent.\nyeah, I'm not positive that the name has to be consistent. What we need is a way to claim the same public IP address, and we already have that (at least for GCE) Assigning to me, and I'll validate the length requirements, make sure public ip assignment works for AWS and close out this issue.\nNote there are two separate things here: (1) a purely-name-based construction can exceed length limits given a single service and (2) some form of across-service consistency is apparently needed. (1) is trivially solvable by either always using a hash or alternatively using a two-stage process where you generate a desired name and only hashify if it's longer than the length limits by truncating it and appending a hash of said name.\nAWS's load balancer hasn't been merged yet, so there's not much to check out there. I'm going to be reducing the churn of load balancers later today, which should help prevent IP address changes for services that are modified.\nI think we need to be able to figure out which Service an LB is attached to from the Service, so that LBs can't get orphaned. regarding being able to claim an LB IP. I don't think that is covered in revamp... , Brendan Burns wrote:\nI think that we need to roll back and think this issue through a bit better. See comment on that PR.", "positive_passages": [{"docid": "doc-en-kubernetes-0589cd5e0961021b139354ddc49080f986af63d6dd6d63a065c8eb71ea824f30", "text": "} // UpdateTCPLoadBalancer is an implementation of TCPLoadBalancer.UpdateTCPLoadBalancer. <del> func (gce *GCECloud) UpdateTCPLoadBalancer(name, region string, hosts []string) error { </del> <ins> func (gce *GCECloud) UpdateTCPLoadBalancer(origName, region string, hosts []string) error { name := normalizeName(origName) </ins> pool, err := gce.service.TargetPools.Get(gce.projectID, region, name).Do() if err != nil { return err", "commid": "kubernetes_pr_7609"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c0bb3600e99710565f99e8be4bd669de365f6aed46898aff519521ca79dfa0d", "query": "GCE has a length limit of 63 characters for its load balancer components (target pools and forwarding rules), and AWS has a length limit of 32 characters. Our current load balancer name construction of clustername-namespace-servicename can exceed both limits, especially AWS's. We should use a shorter name construction method less likely to hit these limits.\nThanks for filing this Alex. My suggestion would be to use a simple UID, as per utils.NewUID(). We'll need to store the mapping from {clustername, namespace, servicename} -UID somewhere stable like etcd. Using anything based directly on {cluster, namespace, name}, for example a stable hash of each, has the problem that the aforementioned tuple is not unique over time. This raises the possibility of e.g. the following scenario: creates mycluster/mynamespace/myservicename, which creates external load balancer named stablehash(mycluster,mynamespace,myservicename) deletes mycluster/mynamespace/myservicename, but at the time MyCloudProvider is down, so kubernetes can't delete ELB named stablehash(mycluster,mynamespace,myservicename). Kubernetes keeps trying in the background to delete the ELB. the mean time user creates a new service named the same as her old one mycluster/mynamespace/myservicename. Kubernetes tries to create an associated ELB named stablehash(mycluster,mynamespace,myservicename), but this fails, because the ELB exists already due to 2 above. ... etc. Badness ensues.\nAssigning to Chao Xu, as this makes for a good starter bug.\nHmmmm.... can't seem to assign to caesarxuchao yet. Not sure why.\nHe has to have write privileges on the repo before issues/PRs can be assigned to him.\nBut we have many contributors with issues assigned to them that are not in the kubernetes-write group (that only has 48 members). I must be missing something. How do I grant him write privileges on the repo?\nWe do? That's not how I understand it to work: If you want to add him, go .\nhas been because the load balancer name changes if the service's UID changes (e.g. if it's deleted and recreated). Think we can change this? A hash of cluster name, namespace, and service name should get around it, but there may be better ideas as well.\nSure. I'm not confident that I can fix this quickly. If it's urgent, maybe you can assign some one more experienced to fix it? One question: I guess the ELB's name should stay unchanged as long as the \"zone+namespace+service name\" doesn't change, am I right?\nI think I'm the guilty party here. I was unaware that when we create a new service with the same name as a previously existing service, that it needed to keep the same load balancer name and IP. This seems broken to me, but I may be missing the larger context. We can quite safely roll back the change while we decide on the best alternative solution. Q , Chao Xu wrote:\nI think the real breakage is that we don't have any way to claim an LB-IP at a larger lifespan than a single service. Alex, can you go back to OP and get a sense of what's happening there to trigger this? , Quinton Hoole wrote:\nWill do. Even if the name is kept consistent as it was before, with the way everything currently works the IP won't be consistent.\nyeah, I'm not positive that the name has to be consistent. What we need is a way to claim the same public IP address, and we already have that (at least for GCE) Assigning to me, and I'll validate the length requirements, make sure public ip assignment works for AWS and close out this issue.\nNote there are two separate things here: (1) a purely-name-based construction can exceed length limits given a single service and (2) some form of across-service consistency is apparently needed. (1) is trivially solvable by either always using a hash or alternatively using a two-stage process where you generate a desired name and only hashify if it's longer than the length limits by truncating it and appending a hash of said name.\nAWS's load balancer hasn't been merged yet, so there's not much to check out there. I'm going to be reducing the churn of load balancers later today, which should help prevent IP address changes for services that are modified.\nI think we need to be able to figure out which Service an LB is attached to from the Service, so that LBs can't get orphaned. regarding being able to claim an LB IP. I don't think that is covered in revamp... , Brendan Burns wrote:\nI think that we need to roll back and think this issue through a bit better. See comment on that PR.", "positive_passages": [{"docid": "doc-en-kubernetes-be640f38bac80d03141af601bc3f04dc941ec4aba3d66645438ffee1b9dd4be4", "text": "} // DeleteTCPLoadBalancer is an implementation of TCPLoadBalancer.DeleteTCPLoadBalancer. <del> func (gce *GCECloud) DeleteTCPLoadBalancer(name, region string) error { </del> <ins> func (gce *GCECloud) DeleteTCPLoadBalancer(origName, region string) error { name := normalizeName(origName) </ins> op, err := gce.service.ForwardingRules.Delete(gce.projectID, region, name).Do() if err != nil && isHTTPErrorCode(err, http.StatusNotFound) { glog.Infof(\"Forwarding rule %s already deleted. Continuing to delete target pool.\", name)", "commid": "kubernetes_pr_7609"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d40e4a6c562fc50ef12d5d4b4bfe6a402a7cb5ec672dfc45502a752fbe0291f6", "query": "Rackspace support has not ben updated in a few months. cluster/rackspace/cloud-config/minion-cloud- is using etcd_servers for kubelet and kube-proxy, but support for them has been removed since v0.9, I think. I'll remove it in a few days if no-one makes a counter-offer to get the config working with latest release.\nThere's been some work on this but it is blocked while we figure out some load-balancer design stuff. , Eric Tune wrote:\nOkay, I will remove the link to rackspace until it is fixed (). Leaving this issue open to remind us to delete it in, say, a month, if no progress is made.\ncc\nSee also\nI'd prefer to try to get things updated and keep support. However I don't want to continually become stale. every few months either.\nHi all, I want to use kubernetes on my existing rackspace infrastructure but I don't understand if rackspace suppor was removed or not. In Doc, under \"custom cloud solution\" it's linked but I wasn't able to deploy it neither with install method nor with . With i got a error (I have 16GB or RAM!). thanks in advance, Fx\nIt looks like no support has happened on Rackspace for a year.\nYou should not expect it to work, and we should delete rackspace support.\nACK.\nUnfortunately I think we'll need to drop support for Rackspace as a deployment target since I can't commit to keeping the deployment scripts up to date. Rackspace support as a cloudprovider should be maintained.\nI would be willing to support the Rackspace deployment target, if there is interest to keep it alive.\nThere would be definitely an interest from our side - sad to see that Rackspace has no interest in maintaining it\nNo problem, I will take over the maintenance. It will take me a bit of time to get caught up, but I will get it done as soon as possible.\nDo you think it would be hard to get the of LBaaS working ?\nSorry it took me a bit to respond. there is a quick update as to where I am. I was busy with some stuff, that prevented me from working on this. But that has been resolved, and should have updates by the end of next week. However what's causing the delays is the lack of a good API for Rackspace Cloud. I've used the gophercloud, it works but I'm not a fan. Additionally gophercloud doesn't have full API support (one of the things I'm not a fan). This would make it hard to implement LBaaS. I should have a better idea of your request sometime next week.\nI have seen this api docu: - is it the same as you saw? I think it should be doable with it.", "positive_passages": [{"docid": "doc-en-kubernetes-f0899a70d4d7701f5e40d31d72321d33920f5c1a816eb7c327d52b70543cc99c", "text": "<del> #!/bin/bash # Copyright 2015 The Kubernetes Authors. # # Licensed under the Apache License, Version 2.0 (the \"License\"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #     http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an \"AS IS\" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # Create generic token following GCE standard create_token() { echo $(cat /dev/urandom | base64 | tr -d \"=+/\" | dd bs=32 count=1 2> /dev/null) } get_tokens_from_csv() { KUBE_BEARER_TOKEN=$(awk -F, '/admin/ {print $1}' ${KUBE_TEMP}/${1}_tokens.csv) KUBELET_TOKEN=$(awk -F, '/kubelet/ {print $1}' ${KUBE_TEMP}/${1}_tokens.csv) KUBE_PROXY_TOKEN=$(awk -F, '/kube_proxy/ {print $1}' ${KUBE_TEMP}/${1}_tokens.csv) } generate_admin_token() { echo \"$(create_token),admin,admin\" >> ${KUBE_TEMP}/known_tokens.csv } # Creates a csv file each time called (i.e one per kubelet). generate_kubelet_tokens() { echo \"$(create_token),kubelet,kubelet\" > ${KUBE_TEMP}/${1}_tokens.csv echo \"$(create_token),kube_proxy,kube_proxy\" >> ${KUBE_TEMP}/${1}_tokens.csv } </del>", "commid": "kubernetes_pr_45032"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d40e4a6c562fc50ef12d5d4b4bfe6a402a7cb5ec672dfc45502a752fbe0291f6", "query": "Rackspace support has not ben updated in a few months. cluster/rackspace/cloud-config/minion-cloud- is using etcd_servers for kubelet and kube-proxy, but support for them has been removed since v0.9, I think. I'll remove it in a few days if no-one makes a counter-offer to get the config working with latest release.\nThere's been some work on this but it is blocked while we figure out some load-balancer design stuff. , Eric Tune wrote:\nOkay, I will remove the link to rackspace until it is fixed (). Leaving this issue open to remind us to delete it in, say, a month, if no progress is made.\ncc\nSee also\nI'd prefer to try to get things updated and keep support. However I don't want to continually become stale. every few months either.\nHi all, I want to use kubernetes on my existing rackspace infrastructure but I don't understand if rackspace suppor was removed or not. In Doc, under \"custom cloud solution\" it's linked but I wasn't able to deploy it neither with install method nor with . With i got a error (I have 16GB or RAM!). thanks in advance, Fx\nIt looks like no support has happened on Rackspace for a year.\nYou should not expect it to work, and we should delete rackspace support.\nACK.\nUnfortunately I think we'll need to drop support for Rackspace as a deployment target since I can't commit to keeping the deployment scripts up to date. Rackspace support as a cloudprovider should be maintained.\nI would be willing to support the Rackspace deployment target, if there is interest to keep it alive.\nThere would be definitely an interest from our side - sad to see that Rackspace has no interest in maintaining it\nNo problem, I will take over the maintenance. It will take me a bit of time to get caught up, but I will get it done as soon as possible.\nDo you think it would be hard to get the of LBaaS working ?\nSorry it took me a bit to respond. there is a quick update as to where I am. I was busy with some stuff, that prevented me from working on this. But that has been resolved, and should have updates by the end of next week. However what's causing the delays is the lack of a good API for Rackspace Cloud. I've used the gophercloud, it works but I'm not a fan. Additionally gophercloud doesn't have full API support (one of the things I'm not a fan). This would make it hard to implement LBaaS. I should have a better idea of your request sometime next week.\nI have seen this api docu: - is it the same as you saw? I think it should be doable with it.", "positive_passages": [{"docid": "doc-en-kubernetes-234fe7de88afd6e051cb253fc0993146b8838439e8d09380ad65bb1527880bfa", "text": "<del> #cloud-config write_files: - path: /etc/cloud.conf permissions: 0600 content: | [Global] auth-url = OS_AUTH_URL username = OS_USERNAME api-key = OS_PASSWORD tenant-id = OS_TENANT_NAME region = OS_REGION_NAME [LoadBalancer] subnet-id = 11111111-1111-1111-1111-111111111111 - path: /opt/bin/git-kubernetes-nginx.sh permissions: 0755 content: | #!/bin/bash git clone https://github.com/thommay/kubernetes_nginx /opt/kubernetes_nginx /usr/bin/cp /opt/.kubernetes_auth /opt/kubernetes_nginx/.kubernetes_auth /opt/kubernetes_nginx/git-kubernetes-nginx.sh - path: /opt/bin/download-release.sh permissions: 0755 content: | #!/bin/bash # This temp URL is only good for the length of time specified at cluster creation time. # Afterward, it will result in a 403. OBJECT_URL=\"CLOUD_FILES_URL\" if [ ! -s /opt/kubernetes.tar.gz ] then echo \"Downloading release ($OBJECT_URL)\" wget \"${OBJECT_URL}\" -O /opt/kubernetes.tar.gz echo \"Unpacking release\" rm -rf /opt/kubernetes || false tar xzf /opt/kubernetes.tar.gz -C /opt/ else echo \"kubernetes release found. Skipping download.\" fi - path: /opt/.kubernetes_auth permissions: 0600 content: | KUBE_USER:KUBE_PASSWORD coreos: etcd2: discovery: https://discovery.etcd.io/DISCOVERY_ID advertise-client-urls: http://$private_ipv4:2379,http://$private_ipv4:4001 initial-advertise-peer-urls: http://$private_ipv4:2380 listen-client-urls: http://0.0.0.0:2379,http://0.0.0.0:4001 listen-peer-urls: http://$private_ipv4:2380,http://$private_ipv4:7001 flannel: ip_masq: true interface: eth2 fleet: public-ip: $private_ipv4 metadata: kubernetes_role=master update: reboot-strategy: off units: - name: etcd2.service command: start - name: fleet.service command: start - name: flanneld.service drop-ins: - name: 50-flannel.conf content: | [Unit] Requires=etcd2.service After=etcd2.service [Service] ExecStartPre=-/usr/bin/etcdctl mk /coreos.com/network/config '{\"Network\":\"KUBE_NETWORK\", \"Backend\": {\"Type\": \"host-gw\"}}' command: start - name: generate-serviceaccount-key.service command: start content: | [Unit] Description=Generate service-account key file [Service] ExecStartPre=-/usr/bin/mkdir -p /var/run/kubernetes/ ExecStart=/bin/openssl genrsa -out /var/run/kubernetes/kube-serviceaccount.key 2048 2>/dev/null RemainAfterExit=yes Type=oneshot - name: docker.service command: start drop-ins: - name: 51-docker-mirror.conf content: | [Unit] # making sure that flanneld finished startup, otherwise containers # won't land in flannel's network... Requires=flanneld.service After=flanneld.service Restart=Always - name: download-release.service command: start content: | [Unit] Description=Downloads Kubernetes Release After=network-online.target Requires=network-online.target [Service] Type=oneshot RemainAfterExit=yes ExecStart=/usr/bin/bash /opt/bin/download-release.sh - name: kube-apiserver.service command: start content: | [Unit] Description=Kubernetes API Server Documentation=https://github.com/kubernetes/kubernetes After=network-online.target Requires=network-online.target After=download-release.service Requires=download-release.service Requires=generate-serviceaccount-key.service After=generate-serviceaccount-key.service [Service] ExecStartPre=/usr/bin/ln -sf /opt/kubernetes/server/bin/kube-apiserver /opt/bin/kube-apiserver ExecStartPre=/usr/bin/mkdir -p /var/lib/kube-apiserver ExecStart=/opt/bin/kube-apiserver  --address=127.0.0.1  --cloud-provider=rackspace  --cloud-config=/etc/cloud.conf  --etcd-servers=http://127.0.0.1:4001  --logtostderr=true  --port=8080  --service-cluster-ip-range=SERVICE_CLUSTER_IP_RANGE  --token-auth-file=/var/lib/kube-apiserver/known_tokens.csv  --v=2  --service-account-key-file=/var/run/kubernetes/kube-serviceaccount.key  --service-account-lookup=true  --admission-control=NamespaceLifecycle,NamespaceAutoProvision,LimitRanger,SecurityContextDeny,ServiceAccount,DefaultTolerationSeconds,ResourceQuota Restart=always RestartSec=5 - name: apiserver-advertiser.service command: start content: | [Unit] Description=Kubernetes Apiserver Advertiser After=etcd2.service Requires=etcd2.service After=master-apiserver.service [Service] ExecStart=/bin/sh -c 'etcdctl set /corekube/apiservers/$public_ipv4 $public_ipv4' Restart=always RestartSec=120 - name: kube-controller-manager.service command: start content: | [Unit] Description=Kubernetes Controller Manager Documentation=https://github.com/kubernetes/kubernetes After=network-online.target Requires=network-online.target After=kube-apiserver.service Requires=kube-apiserver.service [Service] ExecStartPre=/usr/bin/ln -sf /opt/kubernetes/server/bin/kube-controller-manager /opt/bin/kube-controller-manager ExecStart=/opt/bin/kube-controller-manager  --cloud-provider=rackspace  --cloud-config=/etc/cloud.conf  --logtostderr=true  --master=127.0.0.1:8080  --v=2  --service-account-private-key-file=/var/run/kubernetes/kube-serviceaccount.key  --root-ca-file=/run/kubernetes/apiserver.crt Restart=always RestartSec=5 - name: kube-scheduler.service command: start content: | [Unit] Description=Kubernetes Scheduler Documentation=https://github.com/kubernetes/kubernetes After=network-online.target Requires=network-online.target After=kube-apiserver.service Requires=kube-apiserver.service [Service] ExecStartPre=/usr/bin/ln -sf /opt/kubernetes/server/bin/kube-scheduler /opt/bin/kube-scheduler ExecStart=/opt/bin/kube-scheduler  --logtostderr=true  --master=127.0.0.1:8080 Restart=always RestartSec=5 #Running nginx service with --net=\"host\" is a necessary evil until running all k8s services in docker. - name: kubernetes-nginx.service command: start content: | [Unit] Description=Kubernetes Nginx Service After=network-online.target Requires=network-online.target After=docker.service Requires=docker.service [Service] ExecStartPre=/opt/bin/git-kubernetes-nginx.sh ExecStartPre=-/usr/bin/docker rm kubernetes_nginx ExecStart=/usr/bin/docker run --rm --net=\"host\" -p \"443:443\" -t --name \"kubernetes_nginx\" kubernetes_nginx ExecStop=/usr/bin/docker stop kubernetes_nginx Restart=always RestartSec=15 </del>", "commid": "kubernetes_pr_45032"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d40e4a6c562fc50ef12d5d4b4bfe6a402a7cb5ec672dfc45502a752fbe0291f6", "query": "Rackspace support has not ben updated in a few months. cluster/rackspace/cloud-config/minion-cloud- is using etcd_servers for kubelet and kube-proxy, but support for them has been removed since v0.9, I think. I'll remove it in a few days if no-one makes a counter-offer to get the config working with latest release.\nThere's been some work on this but it is blocked while we figure out some load-balancer design stuff. , Eric Tune wrote:\nOkay, I will remove the link to rackspace until it is fixed (). Leaving this issue open to remind us to delete it in, say, a month, if no progress is made.\ncc\nSee also\nI'd prefer to try to get things updated and keep support. However I don't want to continually become stale. every few months either.\nHi all, I want to use kubernetes on my existing rackspace infrastructure but I don't understand if rackspace suppor was removed or not. In Doc, under \"custom cloud solution\" it's linked but I wasn't able to deploy it neither with install method nor with . With i got a error (I have 16GB or RAM!). thanks in advance, Fx\nIt looks like no support has happened on Rackspace for a year.\nYou should not expect it to work, and we should delete rackspace support.\nACK.\nUnfortunately I think we'll need to drop support for Rackspace as a deployment target since I can't commit to keeping the deployment scripts up to date. Rackspace support as a cloudprovider should be maintained.\nI would be willing to support the Rackspace deployment target, if there is interest to keep it alive.\nThere would be definitely an interest from our side - sad to see that Rackspace has no interest in maintaining it\nNo problem, I will take over the maintenance. It will take me a bit of time to get caught up, but I will get it done as soon as possible.\nDo you think it would be hard to get the of LBaaS working ?\nSorry it took me a bit to respond. there is a quick update as to where I am. I was busy with some stuff, that prevented me from working on this. But that has been resolved, and should have updates by the end of next week. However what's causing the delays is the lack of a good API for Rackspace Cloud. I've used the gophercloud, it works but I'm not a fan. Additionally gophercloud doesn't have full API support (one of the things I'm not a fan). This would make it hard to implement LBaaS. I should have a better idea of your request sometime next week.\nI have seen this api docu: - is it the same as you saw? I think it should be doable with it.", "positive_passages": [{"docid": "doc-en-kubernetes-d74319ac30c5857ce1cd653923a9913ee799a474230ff450b2e5deef7e55d6e3", "text": "<del> #cloud-config write_files: - path: /opt/bin/regen-apiserver-list.sh permissions: 0755 content: | #!/bin/sh m=$(echo $(etcdctl ls --recursive /corekube/apiservers | cut -d/ -f4 | sort) | tr ' ' ,) mkdir -p /run/kubelet echo \"APISERVER_IPS=$m\" > /run/kubelet/apiservers.env echo \"FIRST_APISERVER_URL=https://${m%%,*}:6443\" >> /run/kubelet/apiservers.env - path: /opt/bin/download-release.sh permissions: 0755 content: | #!/bin/bash # This temp URL is only good for the length of time specified at cluster creation time. # Afterward, it will result in a 403. OBJECT_URL=\"CLOUD_FILES_URL\" if [ ! -s /opt/kubernetes.tar.gz ] then echo \"Downloading release ($OBJECT_URL)\" wget \"${OBJECT_URL}\" -O /opt/kubernetes.tar.gz echo \"Unpacking release\" rm -rf /opt/kubernetes || false tar xzf /opt/kubernetes.tar.gz -C /opt/ else echo \"kubernetes release found. Skipping download.\" fi - path: /run/config-kubelet.sh permissions: 0755 content: | #!/bin/bash -e set -x /usr/bin/mkdir -p /var/lib/kubelet cat > /var/lib/kubelet/kubeconfig << EOF apiVersion: v1 kind: Config users: - name: kubelet user: token: KUBELET_TOKEN clusters: - name: local cluster: insecure-skip-tls-verify: true contexts: - context: cluster: local user: kubelet name: service-account-context current-context: service-account-context EOF - path: /run/config-kube-proxy.sh permissions: 0755 content: | #!/bin/bash -e set -x /usr/bin/mkdir -p /var/lib/kube-proxy cat > /var/lib/kube-proxy/kubeconfig << EOF apiVersion: v1 kind: Config users: - name: kube-proxy user: token: KUBE_PROXY_TOKEN clusters: - name: local cluster: insecure-skip-tls-verify: true contexts: - context: cluster: local user: kube-proxy name: service-account-context current-context: service-account-context EOF coreos: etcd2: discovery: https://discovery.etcd.io/DISCOVERY_ID advertise-client-urls: http://$private_ipv4:2379,http://$private_ipv4:4001 initial-advertise-peer-urls: http://$private_ipv4:2380 listen-client-urls: http://0.0.0.0:2379,http://0.0.0.0:4001 listen-peer-urls: http://$private_ipv4:2380,http://$private_ipv4:7001 flannel: ip_masq: true interface: eth2 fleet: public-ip: $private_ipv4 metadata: kubernetes_role=minion update: reboot-strategy: off units: - name: etcd2.service command: start - name: fleet.service command: start - name: flanneld.service drop-ins: - name: 50-flannel.conf content: | [Unit] Requires=etcd2.service After=etcd2.service [Service] ExecStartPre=-/usr/bin/etcdctl mk /coreos.com/network/config '{\"Network\":\"KUBE_NETWORK\", \"Backend\": {\"Type\": \"host-gw\"}}' command: start - name: docker.service command: start drop-ins: - name: 51-docker-mirror.conf content: | [Unit] # making sure that flanneld finished startup, otherwise containers # won't land in flannel's network... Requires=flanneld.service After=flanneld.service Restart=Always - name: download-release.service command: start content: | [Unit] Description=Downloads Kubernetes Release After=network-online.target Requires=network-online.target [Service] Type=oneshot RemainAfterExit=yes ExecStart=/usr/bin/bash /opt/bin/download-release.sh - name: kubelet.service command: start content: | [Unit] Description=Kubernetes Kubelet Documentation=https://github.com/kubernetes/kubernetes After=network-online.target Requires=network-online.target After=docker.service Requires=docker.service After=download-release.service Requires=download-release.service After=apiserver-finder.service Requires=apiserver-finder.service [Service] EnvironmentFile=/run/kubelet/apiservers.env ExecStartPre=/run/config-kubelet.sh ExecStartPre=/usr/bin/ln -sf /opt/kubernetes/server/bin/kubelet /opt/bin/kubelet ExecStart=/opt/bin/kubelet  --address=$private_ipv4  --api-servers=${FIRST_APISERVER_URL}  --cluster-dns=DNS_SERVER_IP  --cluster-domain=DNS_DOMAIN  --healthz-bind-address=$private_ipv4  --hostname-override=$private_ipv4  --logtostderr=true  --v=2 Restart=always RestartSec=5 KillMode=process - name: kube-proxy.service command: start content: | [Unit] Description=Kubernetes Proxy Documentation=https://github.com/kubernetes/kubernetes After=network-online.target Requires=network-online.target After=docker.service Requires=docker.service After=download-release.service Requires=download-release.service After=apiserver-finder.service Requires=apiserver-finder.service [Service] EnvironmentFile=/run/kubelet/apiservers.env ExecStartPre=/run/config-kube-proxy.sh ExecStartPre=/usr/bin/ln -sf /opt/kubernetes/server/bin/kube-proxy /opt/bin/kube-proxy ExecStart=/opt/bin/kube-proxy  --bind-address=$private_ipv4  --kubeconfig=/var/lib/kube-proxy/kubeconfig  --logtostderr=true  --hostname-override=$private_ipv4  --master=${FIRST_APISERVER_URL} Restart=always RestartSec=5 - name: apiserver-finder.service command: start content: | [Unit] Description=Kubernetes Apiserver finder After=network-online.target Requires=network-online.target After=etcd2.service Requires=etcd2.service [Service] ExecStartPre=/opt/bin/regen-apiserver-list.sh ExecStart=/usr/bin/etcdctl exec-watch --recursive /corekube/apiservers -- /opt/bin/regen-apiserver-list.sh Restart=always RestartSec=30 - name: cbr0.netdev command: start content: | [NetDev] Kind=bridge Name=cbr0 - name: cbr0.network command: start content: | [Match] Name=cbr0 [Network] Address=10.240.INDEX.1/24 - name: nat.service command: start content: | [Unit] Description=NAT container->outside traffic [Service] ExecStart=/usr/sbin/iptables -t nat -A POSTROUTING -o eth0 -s 10.240.INDEX.0/24 -j MASQUERADE ExecStart=/usr/sbin/iptables -t nat -A POSTROUTING -o eth1 -s 10.240.INDEX.0/24 -j MASQUERADE RemainAfterExit=yes Type=oneshot </del>", "commid": "kubernetes_pr_45032"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d40e4a6c562fc50ef12d5d4b4bfe6a402a7cb5ec672dfc45502a752fbe0291f6", "query": "Rackspace support has not ben updated in a few months. cluster/rackspace/cloud-config/minion-cloud- is using etcd_servers for kubelet and kube-proxy, but support for them has been removed since v0.9, I think. I'll remove it in a few days if no-one makes a counter-offer to get the config working with latest release.\nThere's been some work on this but it is blocked while we figure out some load-balancer design stuff. , Eric Tune wrote:\nOkay, I will remove the link to rackspace until it is fixed (). Leaving this issue open to remind us to delete it in, say, a month, if no progress is made.\ncc\nSee also\nI'd prefer to try to get things updated and keep support. However I don't want to continually become stale. every few months either.\nHi all, I want to use kubernetes on my existing rackspace infrastructure but I don't understand if rackspace suppor was removed or not. In Doc, under \"custom cloud solution\" it's linked but I wasn't able to deploy it neither with install method nor with . With i got a error (I have 16GB or RAM!). thanks in advance, Fx\nIt looks like no support has happened on Rackspace for a year.\nYou should not expect it to work, and we should delete rackspace support.\nACK.\nUnfortunately I think we'll need to drop support for Rackspace as a deployment target since I can't commit to keeping the deployment scripts up to date. Rackspace support as a cloudprovider should be maintained.\nI would be willing to support the Rackspace deployment target, if there is interest to keep it alive.\nThere would be definitely an interest from our side - sad to see that Rackspace has no interest in maintaining it\nNo problem, I will take over the maintenance. It will take me a bit of time to get caught up, but I will get it done as soon as possible.\nDo you think it would be hard to get the of LBaaS working ?\nSorry it took me a bit to respond. there is a quick update as to where I am. I was busy with some stuff, that prevented me from working on this. But that has been resolved, and should have updates by the end of next week. However what's causing the delays is the lack of a good API for Rackspace Cloud. I've used the gophercloud, it works but I'm not a fan. Additionally gophercloud doesn't have full API support (one of the things I'm not a fan). This would make it hard to implement LBaaS. I should have a better idea of your request sometime next week.\nI have seen this api docu: - is it the same as you saw? I think it should be doable with it.", "positive_passages": [{"docid": "doc-en-kubernetes-890b30325ea00471731c55586f129e9f88b4c5191e31ff8f1c55e9b0eb69c6e6", "text": "<del> #!/bin/bash # Copyright 2014 The Kubernetes Authors. # # Licensed under the Apache License, Version 2.0 (the \"License\"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #     http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an \"AS IS\" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # Sane defaults for dev environments. The following variables can be easily overriden # by setting each as a ENV variable ahead of time: # KUBE_IMAGE, KUBE_MASTER_FLAVOR, KUBE_NODE_FLAVOR, NUM_NODES, NOVA_NETWORK and SSH_KEY_NAME # Shared KUBE_IMAGE=\"${KUBE_IMAGE-3eba4fbb-51da-4233-b699-8a4030561add}\" # CoreOS (Stable) SSH_KEY_NAME=\"${SSH_KEY_NAME-id_kubernetes}\" NOVA_NETWORK_LABEL=\"kubernetes-pool-net\" NOVA_NETWORK_CIDR=\"${NOVA_NETWORK-192.168.0.0/24}\" INSTANCE_PREFIX=\"kubernetes\" # Master KUBE_MASTER_FLAVOR=\"${KUBE_MASTER_FLAVOR-general1-1}\" MASTER_NAME=\"${INSTANCE_PREFIX}-master\" MASTER_TAG=\"tags=${INSTANCE_PREFIX}-master\" # Node KUBE_NODE_FLAVOR=\"${KUBE_NODE_FLAVOR-general1-2}\" NUM_NODES=\"${NUM_NODES-4}\" NODE_TAG=\"tags=${INSTANCE_PREFIX}-node\" NODE_NAMES=($(eval echo ${INSTANCE_PREFIX}-node-{1..${NUM_NODES}})) KUBE_NETWORK=\"10.240.0.0/16\" SERVICE_CLUSTER_IP_RANGE=\"10.0.0.0/16\"  # formerly PORTAL_NET # Optional: Enable node logging. ENABLE_NODE_LOGGING=false LOGGING_DESTINATION=elasticsearch # Optional: When set to true, Elasticsearch and Kibana will be setup as part of the cluster bring up. ENABLE_CLUSTER_LOGGING=false ELASTICSEARCH_LOGGING_REPLICAS=1 # Optional: Cluster monitoring to setup as part of the cluster bring up: #   none     - No cluster monitoring setup #   influxdb - Heapster, InfluxDB, and Grafana #   google   - Heapster, Google Cloud Monitoring, and Google Cloud Logging ENABLE_CLUSTER_MONITORING=\"${KUBE_ENABLE_CLUSTER_MONITORING:-influxdb}\" # Optional: Install cluster DNS. ENABLE_CLUSTER_DNS=\"${KUBE_ENABLE_CLUSTER_DNS:-true}\" DNS_SERVER_IP=\"10.0.0.10\" DNS_DOMAIN=\"cluster.local\" # Optional: Enable DNS horizontal autoscaler ENABLE_DNS_HORIZONTAL_AUTOSCALER=\"${KUBE_ENABLE_DNS_HORIZONTAL_AUTOSCALER:-false}\" # Optional: Install Kubernetes UI ENABLE_CLUSTER_UI=\"${KUBE_ENABLE_CLUSTER_UI:-true}\" </del>", "commid": "kubernetes_pr_45032"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d40e4a6c562fc50ef12d5d4b4bfe6a402a7cb5ec672dfc45502a752fbe0291f6", "query": "Rackspace support has not ben updated in a few months. cluster/rackspace/cloud-config/minion-cloud- is using etcd_servers for kubelet and kube-proxy, but support for them has been removed since v0.9, I think. I'll remove it in a few days if no-one makes a counter-offer to get the config working with latest release.\nThere's been some work on this but it is blocked while we figure out some load-balancer design stuff. , Eric Tune wrote:\nOkay, I will remove the link to rackspace until it is fixed (). Leaving this issue open to remind us to delete it in, say, a month, if no progress is made.\ncc\nSee also\nI'd prefer to try to get things updated and keep support. However I don't want to continually become stale. every few months either.\nHi all, I want to use kubernetes on my existing rackspace infrastructure but I don't understand if rackspace suppor was removed or not. In Doc, under \"custom cloud solution\" it's linked but I wasn't able to deploy it neither with install method nor with . With i got a error (I have 16GB or RAM!). thanks in advance, Fx\nIt looks like no support has happened on Rackspace for a year.\nYou should not expect it to work, and we should delete rackspace support.\nACK.\nUnfortunately I think we'll need to drop support for Rackspace as a deployment target since I can't commit to keeping the deployment scripts up to date. Rackspace support as a cloudprovider should be maintained.\nI would be willing to support the Rackspace deployment target, if there is interest to keep it alive.\nThere would be definitely an interest from our side - sad to see that Rackspace has no interest in maintaining it\nNo problem, I will take over the maintenance. It will take me a bit of time to get caught up, but I will get it done as soon as possible.\nDo you think it would be hard to get the of LBaaS working ?\nSorry it took me a bit to respond. there is a quick update as to where I am. I was busy with some stuff, that prevented me from working on this. But that has been resolved, and should have updates by the end of next week. However what's causing the delays is the lack of a good API for Rackspace Cloud. I've used the gophercloud, it works but I'm not a fan. Additionally gophercloud doesn't have full API support (one of the things I'm not a fan). This would make it hard to implement LBaaS. I should have a better idea of your request sometime next week.\nI have seen this api docu: - is it the same as you saw? I think it should be doable with it.", "positive_passages": [{"docid": "doc-en-kubernetes-59137f87b20aa7e948fbc3602a242c043eac9e77f42cbb0bd09bea40bcbc4e10", "text": "<del> #!/bin/bash # Copyright 2014 The Kubernetes Authors. # # Licensed under the Apache License, Version 2.0 (the \"License\"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #     http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an \"AS IS\" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # Bring up a Kubernetes cluster. # # If the full release name (gs://<bucket>/<release>) is passed in then we take # that directly.  If not then we assume we are doing development stuff and take # the defaults in the release config. # exit on any error set -e source $(dirname $0)/../kube-util.sh echo \"Starting cluster using provider: $KUBERNETES_PROVIDER\" verify-prereqs kube-up # skipping validation for now until since machines show up as private IPs # source $(dirname $0)/validate-cluster.sh echo \"Done\" </del>", "commid": "kubernetes_pr_45032"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d40e4a6c562fc50ef12d5d4b4bfe6a402a7cb5ec672dfc45502a752fbe0291f6", "query": "Rackspace support has not ben updated in a few months. cluster/rackspace/cloud-config/minion-cloud- is using etcd_servers for kubelet and kube-proxy, but support for them has been removed since v0.9, I think. I'll remove it in a few days if no-one makes a counter-offer to get the config working with latest release.\nThere's been some work on this but it is blocked while we figure out some load-balancer design stuff. , Eric Tune wrote:\nOkay, I will remove the link to rackspace until it is fixed (). Leaving this issue open to remind us to delete it in, say, a month, if no progress is made.\ncc\nSee also\nI'd prefer to try to get things updated and keep support. However I don't want to continually become stale. every few months either.\nHi all, I want to use kubernetes on my existing rackspace infrastructure but I don't understand if rackspace suppor was removed or not. In Doc, under \"custom cloud solution\" it's linked but I wasn't able to deploy it neither with install method nor with . With i got a error (I have 16GB or RAM!). thanks in advance, Fx\nIt looks like no support has happened on Rackspace for a year.\nYou should not expect it to work, and we should delete rackspace support.\nACK.\nUnfortunately I think we'll need to drop support for Rackspace as a deployment target since I can't commit to keeping the deployment scripts up to date. Rackspace support as a cloudprovider should be maintained.\nI would be willing to support the Rackspace deployment target, if there is interest to keep it alive.\nThere would be definitely an interest from our side - sad to see that Rackspace has no interest in maintaining it\nNo problem, I will take over the maintenance. It will take me a bit of time to get caught up, but I will get it done as soon as possible.\nDo you think it would be hard to get the of LBaaS working ?\nSorry it took me a bit to respond. there is a quick update as to where I am. I was busy with some stuff, that prevented me from working on this. But that has been resolved, and should have updates by the end of next week. However what's causing the delays is the lack of a good API for Rackspace Cloud. I've used the gophercloud, it works but I'm not a fan. Additionally gophercloud doesn't have full API support (one of the things I'm not a fan). This would make it hard to implement LBaaS. I should have a better idea of your request sometime next week.\nI have seen this api docu: - is it the same as you saw? I think it should be doable with it.", "positive_passages": [{"docid": "doc-en-kubernetes-5cc07505eede528b025ddf42d44e1c479ad850e9dfc786f78b8090e80c1bbb63", "text": "<del> #!/bin/bash # Copyright 2014 The Kubernetes Authors. # # Licensed under the Apache License, Version 2.0 (the \"License\"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #     http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an \"AS IS\" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # A library of helper functions for deploying on Rackspace # Use the config file specified in $KUBE_CONFIG_FILE, or default to # config-default.sh. KUBE_ROOT=$(dirname \"${BASH_SOURCE}\")/../.. source $(dirname ${BASH_SOURCE})/${KUBE_CONFIG_FILE-\"config-default.sh\"} source \"${KUBE_ROOT}/cluster/common.sh\" source \"${KUBE_ROOT}/cluster/rackspace/authorization.sh\" verify-prereqs() { # Make sure that prerequisites are installed. for x in nova swiftly; do if [ \"$(which $x)\" == \"\" ]; then echo \"cluster/rackspace/util.sh:  Can't find $x in PATH, please fix and retry.\" exit 1 fi done if [[ -z \"${OS_AUTH_URL-}\" ]]; then echo \"cluster/rackspace/util.sh: OS_AUTH_URL not set.\" echo -e \"texport OS_AUTH_URL=https://identity.api.rackspacecloud.com/v2.0/\" return 1 fi if [[ -z \"${OS_USERNAME-}\" ]]; then echo \"cluster/rackspace/util.sh: OS_USERNAME not set.\" echo -e \"texport OS_USERNAME=myusername\" return 1 fi if [[ -z \"${OS_PASSWORD-}\" ]]; then echo \"cluster/rackspace/util.sh: OS_PASSWORD not set.\" echo -e \"texport OS_PASSWORD=myapikey\" return 1 fi } rax-ssh-key() { if [ ! -f $HOME/.ssh/${SSH_KEY_NAME} ]; then echo \"cluster/rackspace/util.sh: Generating SSH KEY ${HOME}/.ssh/${SSH_KEY_NAME}\" ssh-keygen -f ${HOME}/.ssh/${SSH_KEY_NAME} -N '' > /dev/null fi if ! $(nova keypair-list | grep $SSH_KEY_NAME > /dev/null 2>&1); then echo \"cluster/rackspace/util.sh: Uploading key to Rackspace:\" echo -e \"tnova keypair-add ${SSH_KEY_NAME} --pub-key ${HOME}/.ssh/${SSH_KEY_NAME}.pub\" nova keypair-add ${SSH_KEY_NAME} --pub-key ${HOME}/.ssh/${SSH_KEY_NAME}.pub > /dev/null 2>&1 else echo \"cluster/rackspace/util.sh: SSH key ${SSH_KEY_NAME}.pub already uploaded\" fi } rackspace-set-vars() { CLOUDFILES_CONTAINER=\"kubernetes-releases-${OS_USERNAME}\" CONTAINER_PREFIX=${CONTAINER_PREFIX-devel/} find-release-tars } # Retrieves a tempurl from cloudfiles to make the release object publicly accessible temporarily. find-object-url() { rackspace-set-vars KUBE_TAR=${CLOUDFILES_CONTAINER}/${CONTAINER_PREFIX}/kubernetes-server-linux-amd64.tar.gz # Create temp URL good for 24 hours RELEASE_TMP_URL=$(swiftly -A ${OS_AUTH_URL} -U ${OS_USERNAME} -K ${OS_PASSWORD} tempurl GET ${KUBE_TAR} 86400 ) echo \"cluster/rackspace/util.sh: Object temp URL:\" echo -e \"t${RELEASE_TMP_URL}\" } ensure_dev_container() { SWIFTLY_CMD=\"swiftly -A ${OS_AUTH_URL} -U ${OS_USERNAME} -K ${OS_PASSWORD}\" if ! ${SWIFTLY_CMD} get ${CLOUDFILES_CONTAINER} > /dev/null 2>&1 ; then echo \"cluster/rackspace/util.sh: Container doesn't exist. Creating container ${CLOUDFILES_CONTAINER}\" ${SWIFTLY_CMD} put ${CLOUDFILES_CONTAINER} > /dev/null 2>&1 fi } # Copy kubernetes-server-linux-amd64.tar.gz to cloud files object store copy_dev_tarballs() { echo \"cluster/rackspace/util.sh: Uploading to Cloud Files\" ${SWIFTLY_CMD} put -i ${SERVER_BINARY_TAR}  ${CLOUDFILES_CONTAINER}/${CONTAINER_PREFIX}/kubernetes-server-linux-amd64.tar.gz > /dev/null 2>&1 echo \"Release pushed.\" } prep_known_tokens() { for (( i=0; i<${#NODE_NAMES[@]}; i++)); do generate_kubelet_tokens ${NODE_NAMES[i]} cat ${KUBE_TEMP}/${NODE_NAMES[i]}_tokens.csv >> ${KUBE_TEMP}/known_tokens.csv done # Generate tokens for other \"service accounts\".  Append to known_tokens. # # NB: If this list ever changes, this script actually has to # change to detect the existence of this file, kill any deleted # old tokens and add any new tokens (to handle the upgrade case). local -r service_accounts=(\"system:scheduler\" \"system:controller_manager\" \"system:logging\" \"system:monitoring\" \"system:dns\") for account in \"${service_accounts[@]}\"; do echo \"$(create_token),${account},${account}\" >> ${KUBE_TEMP}/known_tokens.csv done generate_admin_token } rax-boot-master() { DISCOVERY_URL=$(curl https://discovery.etcd.io/new?size=1) DISCOVERY_ID=$(echo \"${DISCOVERY_URL}\" | cut -f 4 -d /) echo \"cluster/rackspace/util.sh: etcd discovery URL: ${DISCOVERY_URL}\" # Copy cloud-config to KUBE_TEMP and work some sed magic sed -e \"s|DISCOVERY_ID|${DISCOVERY_ID}|\"  -e \"s|CLOUD_FILES_URL|${RELEASE_TMP_URL//&/&}|\"  -e \"s|KUBE_USER|${KUBE_USER}|\"  -e \"s|KUBE_PASSWORD|${KUBE_PASSWORD}|\"  -e \"s|SERVICE_CLUSTER_IP_RANGE|${SERVICE_CLUSTER_IP_RANGE}|\"  -e \"s|KUBE_NETWORK|${KUBE_NETWORK}|\"  -e \"s|OS_AUTH_URL|${OS_AUTH_URL}|\"  -e \"s|OS_USERNAME|${OS_USERNAME}|\"  -e \"s|OS_PASSWORD|${OS_PASSWORD}|\"  -e \"s|OS_TENANT_NAME|${OS_TENANT_NAME}|\"  -e \"s|OS_REGION_NAME|${OS_REGION_NAME}|\"  $(dirname $0)/rackspace/cloud-config/master-cloud-config.yaml > $KUBE_TEMP/master-cloud-config.yaml MASTER_BOOT_CMD=\"nova boot  --key-name ${SSH_KEY_NAME}  --flavor ${KUBE_MASTER_FLAVOR}  --image ${KUBE_IMAGE}  --meta ${MASTER_TAG}  --meta ETCD=${DISCOVERY_ID}  --user-data ${KUBE_TEMP}/master-cloud-config.yaml  --config-drive true  --nic net-id=${NETWORK_UUID}  ${MASTER_NAME}\" echo \"cluster/rackspace/util.sh: Booting ${MASTER_NAME} with following command:\" echo -e \"t$MASTER_BOOT_CMD\" $MASTER_BOOT_CMD } rax-boot-nodes() { cp $(dirname $0)/rackspace/cloud-config/node-cloud-config.yaml  ${KUBE_TEMP}/node-cloud-config.yaml for (( i=0; i<${#NODE_NAMES[@]}; i++)); do get_tokens_from_csv ${NODE_NAMES[i]} sed -e \"s|DISCOVERY_ID|${DISCOVERY_ID}|\"  -e \"s|CLOUD_FILES_URL|${RELEASE_TMP_URL//&/&}|\"  -e \"s|DNS_SERVER_IP|${DNS_SERVER_IP:-}|\"  -e \"s|DNS_DOMAIN|${DNS_DOMAIN:-}|\"  -e \"s|ENABLE_CLUSTER_DNS|${ENABLE_CLUSTER_DNS:-false}|\"  -e \"s|ENABLE_NODE_LOGGING|${ENABLE_NODE_LOGGING:-false}|\"  -e \"s|INDEX|$((i + 1))|g\"  -e \"s|KUBELET_TOKEN|${KUBELET_TOKEN}|\"  -e \"s|KUBE_NETWORK|${KUBE_NETWORK}|\"  -e \"s|KUBELET_TOKEN|${KUBELET_TOKEN}|\"  -e \"s|KUBE_PROXY_TOKEN|${KUBE_PROXY_TOKEN}|\"  -e \"s|LOGGING_DESTINATION|${LOGGING_DESTINATION:-}|\"  $(dirname $0)/rackspace/cloud-config/node-cloud-config.yaml > $KUBE_TEMP/node-cloud-config-$(($i + 1)).yaml NODE_BOOT_CMD=\"nova boot  --key-name ${SSH_KEY_NAME}  --flavor ${KUBE_NODE_FLAVOR}  --image ${KUBE_IMAGE}  --meta ${NODE_TAG}  --user-data ${KUBE_TEMP}/node-cloud-config-$(( i +1 )).yaml  --config-drive true  --nic net-id=${NETWORK_UUID}  ${NODE_NAMES[$i]}\" echo \"cluster/rackspace/util.sh: Booting ${NODE_NAMES[$i]} with following command:\" echo -e \"t$NODE_BOOT_CMD\" $NODE_BOOT_CMD done } rax-nova-network() { if ! $(nova network-list | grep $NOVA_NETWORK_LABEL > /dev/null 2>&1); then SAFE_CIDR=$(echo $NOVA_NETWORK_CIDR | tr -d '') NETWORK_CREATE_CMD=\"nova network-create $NOVA_NETWORK_LABEL $SAFE_CIDR\" echo \"cluster/rackspace/util.sh: Creating cloud network with following command:\" echo -e \"t${NETWORK_CREATE_CMD}\" $NETWORK_CREATE_CMD else echo \"cluster/rackspace/util.sh: Using existing cloud network $NOVA_NETWORK_LABEL\" fi } detect-nodes() { KUBE_NODE_IP_ADDRESSES=() for (( i=0; i<${#NODE_NAMES[@]}; i++)); do local node_ip=$(nova show --minimal ${NODE_NAMES[$i]}  | grep accessIPv4 | awk '{print $4}') echo \"cluster/rackspace/util.sh: Found ${NODE_NAMES[$i]} at ${node_ip}\" KUBE_NODE_IP_ADDRESSES+=(\"${node_ip}\") done if [ -z \"$KUBE_NODE_IP_ADDRESSES\" ]; then echo \"cluster/rackspace/util.sh: Could not detect Kubernetes node nodes.  Make sure you've launched a cluster with 'kube-up.sh'\" exit 1 fi } detect-master() { KUBE_MASTER=${MASTER_NAME} echo \"Waiting for ${MASTER_NAME} IP Address.\" echo echo \"  This will continually check to see if the master node has an IP address.\" echo KUBE_MASTER_IP=$(nova show $KUBE_MASTER --minimal | grep accessIPv4 | awk '{print $4}') while [ \"${KUBE_MASTER_IP-|}\" == \"|\" ]; do KUBE_MASTER_IP=$(nova show $KUBE_MASTER --minimal | grep accessIPv4 | awk '{print $4}') printf \".\" sleep 2 done echo \"${KUBE_MASTER} IP Address is ${KUBE_MASTER_IP}\" } # $1 should be the network you would like to get an IP address for detect-master-nova-net() { KUBE_MASTER=${MASTER_NAME} MASTER_IP=$(nova show $KUBE_MASTER --minimal | grep $1 | awk '{print $5}') } kube-up() { SCRIPT_DIR=$(CDPATH=\"\" cd $(dirname $0); pwd) rackspace-set-vars ensure_dev_container copy_dev_tarballs # Find the release to use.  Generally it will be passed when doing a 'prod' # install and will default to the release/config.sh version when doing a # developer up. find-object-url # Create a temp directory to hold scripts that will be uploaded to master/nodes KUBE_TEMP=$(mktemp -d -t kubernetes.XXXXXX) trap \"rm -rf ${KUBE_TEMP}\" EXIT load-or-gen-kube-basicauth python2.7 $(dirname $0)/../third_party/htpasswd/htpasswd.py -b -c ${KUBE_TEMP}/htpasswd $KUBE_USER $KUBE_PASSWORD HTPASSWD=$(cat ${KUBE_TEMP}/htpasswd) rax-nova-network NETWORK_UUID=$(nova network-list | grep -i ${NOVA_NETWORK_LABEL} | awk '{print $2}') # create and upload ssh key if necessary rax-ssh-key echo \"cluster/rackspace/util.sh: Starting Cloud Servers\" prep_known_tokens rax-boot-master rax-boot-nodes detect-master # TODO look for a better way to get the known_tokens to the master. This is needed over file injection since the files were too large on a 4 node cluster. $(scp -o StrictHostKeyChecking=no -i ~/.ssh/${SSH_KEY_NAME} ${KUBE_TEMP}/known_tokens.csv core@${KUBE_MASTER_IP}:/home/core/known_tokens.csv) $(sleep 2) $(ssh -o StrictHostKeyChecking=no -i ~/.ssh/${SSH_KEY_NAME} core@${KUBE_MASTER_IP} sudo /usr/bin/mkdir -p /var/lib/kube-apiserver) $(ssh -o StrictHostKeyChecking=no -i ~/.ssh/${SSH_KEY_NAME} core@${KUBE_MASTER_IP} sudo mv /home/core/known_tokens.csv /var/lib/kube-apiserver/known_tokens.csv) $(ssh -o StrictHostKeyChecking=no -i ~/.ssh/${SSH_KEY_NAME} core@${KUBE_MASTER_IP} sudo chown root:root /var/lib/kube-apiserver/known_tokens.csv) $(ssh -o StrictHostKeyChecking=no -i ~/.ssh/${SSH_KEY_NAME} core@${KUBE_MASTER_IP} sudo systemctl restart kube-apiserver) FAIL=0 for job in `jobs -p` do wait $job || let \"FAIL+=1\" done if (( $FAIL != 0 )); then echo \"${FAIL} commands failed.  Exiting.\" exit 2 fi echo \"Waiting for cluster initialization.\" echo echo \"  This will continually check to see if the API for kubernetes is reachable.\" echo \"  This might loop forever if there was some uncaught error during start\" echo \"  up.\" echo #This will fail until apiserver salt is updated until $(curl --insecure --user ${KUBE_USER}:${KUBE_PASSWORD} --max-time 5  --fail --output /dev/null --silent https://${KUBE_MASTER_IP}/healthz); do printf \".\" sleep 2 done echo \"Kubernetes cluster created.\" export KUBE_CERT=\"\" export KUBE_KEY=\"\" export CA_CERT=\"\" export CONTEXT=\"rackspace_${INSTANCE_PREFIX}\" create-kubeconfig # Don't bail on errors, we want to be able to print some info. set +e detect-nodes # ensures KUBECONFIG is set get-kubeconfig-basicauth echo \"All nodes may not be online yet, this is okay.\" echo echo \"Kubernetes cluster is running.  The master is running at:\" echo echo \"  https://${KUBE_MASTER_IP}\" echo echo \"The user name and password to use is located in ${KUBECONFIG:-$DEFAULT_KUBECONFIG}.\" echo echo \"Security note: The server above uses a self signed certificate.  This is\" echo \"    subject to \"Man in the middle\" type attacks.\" echo } # Perform preparations required to run e2e tests function prepare-e2e() { echo \"Rackspace doesn't need special preparations for e2e tests\" } </del>", "commid": "kubernetes_pr_45032"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e41c7a0a85635ba91742439b913fa4ee706ea1bfde3bc5546521b3318c03960", "query": "If another process is altering iptables rules at the time k8s attempts to add iptables rules it will fail with a locking error. k8s should use -w and retry after a delay. Below, an external process (openshift-sdn-node) modifies iptables at roughly the same time and k8s fails without retrying. Related to\nSorry, I misunderstood the -w flag, with it retry logic wouldn't be necessary as it'd wait. Perhaps simply retrying is a better solution as -w flag may not exist everywhere we'd like.\nLooks like -w was to iptables 1.4.20(August 2013).\nYeah, we have to be pretty back-compatible with iptables. We always retry after a few seconds - is there really a bug here? , Scott Dodson wrote:\nIt definitely seems like there is some sort of a problem. We see this randomly on system startup. In our environment OpenShift is launching kubernetes around the same time other systemd units are modifying the firewall config. If one of these others units has the lock kubernetes will report the error Scott mentions and then will never create the required nat'ing for services. Here's how to reproduce this: At this point if you run you will see the exact same error kubernetes reports. It's probably not obvious why you have to set the breakpoint at 257 but if you set the breakpoint at 260 and then step through the code it appears that the compiler has optimized lines 263 and 257 to be the same. In any case running will verify if you have the lock or not. Once you've verified you have the lock just restart OpenShift (running kubernetes v0.14.1-582-gb12d75d): At this point you can press in gdb to continue the iptables invocation and release the lock. Afterwards I will see output from cadvisor every once in a while, however the will show the firewall is still blank: I initially restarted Kubernetes with a blank firewall at 11:21 and yet at 11:38 I still have nothing:\nI probably should have made it more clear, I removed the lock by pressing 'c' in gdb to continue. That's when I started waiting. I'll update my comment to make that more clear.\nSo something for a holding the lock? I am out of your office for the rest of this week, but maybe you can figure out - is there a stale process holding a lock? What kind of lock is it? Flock or semaphore or ... ? On Apr 29, 2015 8:44 AM, \"Brenton Leanhardt\" wrote:\nWhat we're saying is that on startup it's fairly common for multiple systemd units to make firewall additions. If one of them grabs the lock (rarely for more than a few seconds) it will cause kubernetes to fail to initialize iptables and it will never fix itself. The lock only need be grabbed the microsecond kubernetes tries to initialize iptables for this bug to present itself. We know exactly which program in our environment was concurrently making iptables updates. The problem is that kubernetes doesn't appear to be retrying if it fails to initialize iptables.\nOn RHEL the lock is the xtables unix socket lock in iptables to allow multiple programs to update iptables concurrently. Other platforms may use a flock since that is the default upstream. To solve this kubernetes needs one more more of the following: pass the flag to as scott and the logs mention (possibly only available on some platforms). If kubernetes desides to wait for the lock it will need a timeout. retry the firewall initialization quickly and maybe backoff if it still can't get the lock It's probably worth noting that if iptables on a platform doesn't have iptables lock support concurrency is likely broken already in other ways for that platform.\nIt does retry all up tables ops. Unless it somehow gets pathologically phase locked with your agent, or there is some deeper bug. We have e2e tests that prove you can delete tables and it will recreate them. Are you saying that it never retries (did you set -v=4?) or that every retry fails? On RHEL the lock is the xtables unix socket lock in iptables to allow multiple programs to update iptables concurrently. Other platforms may use a flock since that is the default upstream. To solve this kubernetes needs one more more of the following: pass the -w flag to iptables as scott and the logs mention (possibly only available on some platforms). If kubernetes desides to wait for the lock it will need a timeout. retry the firewall initialization quickly and maybe backoff if it still can't get the lock It's probably worth noting that if iptables on a platform doesn't have iptables lock support concurrency is likely broken already in other ways for that platform. \u2014 Reply to this email directly or view it on GitHub .\nI can grab the lock for just the second that kubernetes needs it and then let it go. The kube-proxy nat'ing will never be rebuilt without intervention (restarting kubernetes). That seems like a bug to me and is what my original comment reproduces. In addition, once the environment is in this state it won't even pick up new service nat rules. Other nodes in my environment will pick them up but this one is dead. I highly suspect it has to do with the fact that iptables initialization is failing. We test all the time that once a system is up and running you can clean iptables and it will come back. This is a slightly different case.\nThis seems like a v1 blocker - we see this in every realistic environment we put the Kube-proxy in. Disagreement?\nI still don't understand this issue. It is demonstrably true that the kube-proxy retries all of the iptables logic periodically. It's possible (given the mention of \"won't even pick up new service nat rules\") that this locking tickles a bug in kube-proxy, but I am having trouble reproducing it. Can you run your kube-proxy with -v=4, trigger the bug, and then take a look at the logs? If this is real, yeah it's a 1.0 blocker.\nThe problem is in the initialization process. If you hold the lock while the kube-proxy tries to initialize itself then it will be wedged forever. What you're showing is the kube-proxy can repair the iptables rules after the initialization code has run. The logs I pasted earlier show that after the initialization fails at it will never try again. I tend to run at loglevel 4 by default but I'll try to find time today to run through this again.\nI have a fix coming - can you test the PR before commit?\nI ran the exact same test as mentioned in my original comment. While the debug lines have changed the end result is the same: grab the lock (at this point even will fail) start the kube-proxy release the lock (at this point works) wait.. try creating another service wait.. The rules never come back. Here are the logs:\nSure, I'll test the PR. I'm betting it will apply fairly cleanly on to my OpenShift codebase. If not I'll launch Kubernetes directly.\nMany of those log lines are not part of upstream. In fact, what upstream has is a glog.Fatalf() which will kill kube-proxy, and when it restarts it will try again. Did you guys break it by not actually exiting?\nLooks like we did. We need to put it into a restart loop. ----- Original Message -----\nis teh fix, though I assert we should not need it, and if you need it this fix may not help you anyway. I am still OK to commit this.\nAlthough NewProxier sucks because it doesn't return a usable error. I'll take the todo to clean up that part. ----- Original Message -----\nhey, it logs its error - nothing wrong with that :) , Clayton Coleman wrote:\n:)\nOpened and will move the rest back to openshift.\nI restarted docker and it worked then", "positive_passages": [{"docid": "doc-en-kubernetes-4c9dc51b3201feb404937f941349480ed18fc2def1112cedddbfe043047e10e6", "text": "return nil } glog.Infof(\"Setting Proxy IP to %v\", hostIP) <del> return CreateProxier(loadBalancer, listenIP, iptables, hostIP) </del> <ins> return createProxier(loadBalancer, listenIP, iptables, hostIP) </ins> } <del> func CreateProxier(loadBalancer LoadBalancer, listenIP net.IP, iptables iptables.Interface, hostIP net.IP) *Proxier { </del> <ins> func createProxier(loadBalancer LoadBalancer, listenIP net.IP, iptables iptables.Interface, hostIP net.IP) *Proxier { </ins> glog.Infof(\"Initializing iptables\") // Clean up old messes.  Ignore erors. iptablesDeleteOld(iptables)", "commid": "kubernetes_pr_8264"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e41c7a0a85635ba91742439b913fa4ee706ea1bfde3bc5546521b3318c03960", "query": "If another process is altering iptables rules at the time k8s attempts to add iptables rules it will fail with a locking error. k8s should use -w and retry after a delay. Below, an external process (openshift-sdn-node) modifies iptables at roughly the same time and k8s fails without retrying. Related to\nSorry, I misunderstood the -w flag, with it retry logic wouldn't be necessary as it'd wait. Perhaps simply retrying is a better solution as -w flag may not exist everywhere we'd like.\nLooks like -w was to iptables 1.4.20(August 2013).\nYeah, we have to be pretty back-compatible with iptables. We always retry after a few seconds - is there really a bug here? , Scott Dodson wrote:\nIt definitely seems like there is some sort of a problem. We see this randomly on system startup. In our environment OpenShift is launching kubernetes around the same time other systemd units are modifying the firewall config. If one of these others units has the lock kubernetes will report the error Scott mentions and then will never create the required nat'ing for services. Here's how to reproduce this: At this point if you run you will see the exact same error kubernetes reports. It's probably not obvious why you have to set the breakpoint at 257 but if you set the breakpoint at 260 and then step through the code it appears that the compiler has optimized lines 263 and 257 to be the same. In any case running will verify if you have the lock or not. Once you've verified you have the lock just restart OpenShift (running kubernetes v0.14.1-582-gb12d75d): At this point you can press in gdb to continue the iptables invocation and release the lock. Afterwards I will see output from cadvisor every once in a while, however the will show the firewall is still blank: I initially restarted Kubernetes with a blank firewall at 11:21 and yet at 11:38 I still have nothing:\nI probably should have made it more clear, I removed the lock by pressing 'c' in gdb to continue. That's when I started waiting. I'll update my comment to make that more clear.\nSo something for a holding the lock? I am out of your office for the rest of this week, but maybe you can figure out - is there a stale process holding a lock? What kind of lock is it? Flock or semaphore or ... ? On Apr 29, 2015 8:44 AM, \"Brenton Leanhardt\" wrote:\nWhat we're saying is that on startup it's fairly common for multiple systemd units to make firewall additions. If one of them grabs the lock (rarely for more than a few seconds) it will cause kubernetes to fail to initialize iptables and it will never fix itself. The lock only need be grabbed the microsecond kubernetes tries to initialize iptables for this bug to present itself. We know exactly which program in our environment was concurrently making iptables updates. The problem is that kubernetes doesn't appear to be retrying if it fails to initialize iptables.\nOn RHEL the lock is the xtables unix socket lock in iptables to allow multiple programs to update iptables concurrently. Other platforms may use a flock since that is the default upstream. To solve this kubernetes needs one more more of the following: pass the flag to as scott and the logs mention (possibly only available on some platforms). If kubernetes desides to wait for the lock it will need a timeout. retry the firewall initialization quickly and maybe backoff if it still can't get the lock It's probably worth noting that if iptables on a platform doesn't have iptables lock support concurrency is likely broken already in other ways for that platform.\nIt does retry all up tables ops. Unless it somehow gets pathologically phase locked with your agent, or there is some deeper bug. We have e2e tests that prove you can delete tables and it will recreate them. Are you saying that it never retries (did you set -v=4?) or that every retry fails? On RHEL the lock is the xtables unix socket lock in iptables to allow multiple programs to update iptables concurrently. Other platforms may use a flock since that is the default upstream. To solve this kubernetes needs one more more of the following: pass the -w flag to iptables as scott and the logs mention (possibly only available on some platforms). If kubernetes desides to wait for the lock it will need a timeout. retry the firewall initialization quickly and maybe backoff if it still can't get the lock It's probably worth noting that if iptables on a platform doesn't have iptables lock support concurrency is likely broken already in other ways for that platform. \u2014 Reply to this email directly or view it on GitHub .\nI can grab the lock for just the second that kubernetes needs it and then let it go. The kube-proxy nat'ing will never be rebuilt without intervention (restarting kubernetes). That seems like a bug to me and is what my original comment reproduces. In addition, once the environment is in this state it won't even pick up new service nat rules. Other nodes in my environment will pick them up but this one is dead. I highly suspect it has to do with the fact that iptables initialization is failing. We test all the time that once a system is up and running you can clean iptables and it will come back. This is a slightly different case.\nThis seems like a v1 blocker - we see this in every realistic environment we put the Kube-proxy in. Disagreement?\nI still don't understand this issue. It is demonstrably true that the kube-proxy retries all of the iptables logic periodically. It's possible (given the mention of \"won't even pick up new service nat rules\") that this locking tickles a bug in kube-proxy, but I am having trouble reproducing it. Can you run your kube-proxy with -v=4, trigger the bug, and then take a look at the logs? If this is real, yeah it's a 1.0 blocker.\nThe problem is in the initialization process. If you hold the lock while the kube-proxy tries to initialize itself then it will be wedged forever. What you're showing is the kube-proxy can repair the iptables rules after the initialization code has run. The logs I pasted earlier show that after the initialization fails at it will never try again. I tend to run at loglevel 4 by default but I'll try to find time today to run through this again.\nI have a fix coming - can you test the PR before commit?\nI ran the exact same test as mentioned in my original comment. While the debug lines have changed the end result is the same: grab the lock (at this point even will fail) start the kube-proxy release the lock (at this point works) wait.. try creating another service wait.. The rules never come back. Here are the logs:\nSure, I'll test the PR. I'm betting it will apply fairly cleanly on to my OpenShift codebase. If not I'll launch Kubernetes directly.\nMany of those log lines are not part of upstream. In fact, what upstream has is a glog.Fatalf() which will kill kube-proxy, and when it restarts it will try again. Did you guys break it by not actually exiting?\nLooks like we did. We need to put it into a restart loop. ----- Original Message -----\nis teh fix, though I assert we should not need it, and if you need it this fix may not help you anyway. I am still OK to commit this.\nAlthough NewProxier sucks because it doesn't return a usable error. I'll take the todo to clean up that part. ----- Original Message -----\nhey, it logs its error - nothing wrong with that :) , Clayton Coleman wrote:\n:)\nOpened and will move the rest back to openshift.\nI restarted docker and it worked then", "positive_passages": [{"docid": "doc-en-kubernetes-3447c1047c5b50c341e6518a25b0d5b781ccc191d100f4607e4d90a34aa51c01", "text": "}}, }}) <del> p := CreateProxier(lb, net.ParseIP(\"0.0.0.0\"), &fakeIptables{}, net.ParseIP(\"127.0.0.1\")) </del> <ins> p := createProxier(lb, net.ParseIP(\"0.0.0.0\"), &fakeIptables{}, net.ParseIP(\"127.0.0.1\")) </ins> waitForNumProxyLoops(t, p, 0) svcInfoP, err := p.addServiceOnPort(serviceP, \"TCP\", 0, time.Second)", "commid": "kubernetes_pr_8264"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e41c7a0a85635ba91742439b913fa4ee706ea1bfde3bc5546521b3318c03960", "query": "If another process is altering iptables rules at the time k8s attempts to add iptables rules it will fail with a locking error. k8s should use -w and retry after a delay. Below, an external process (openshift-sdn-node) modifies iptables at roughly the same time and k8s fails without retrying. Related to\nSorry, I misunderstood the -w flag, with it retry logic wouldn't be necessary as it'd wait. Perhaps simply retrying is a better solution as -w flag may not exist everywhere we'd like.\nLooks like -w was to iptables 1.4.20(August 2013).\nYeah, we have to be pretty back-compatible with iptables. We always retry after a few seconds - is there really a bug here? , Scott Dodson wrote:\nIt definitely seems like there is some sort of a problem. We see this randomly on system startup. In our environment OpenShift is launching kubernetes around the same time other systemd units are modifying the firewall config. If one of these others units has the lock kubernetes will report the error Scott mentions and then will never create the required nat'ing for services. Here's how to reproduce this: At this point if you run you will see the exact same error kubernetes reports. It's probably not obvious why you have to set the breakpoint at 257 but if you set the breakpoint at 260 and then step through the code it appears that the compiler has optimized lines 263 and 257 to be the same. In any case running will verify if you have the lock or not. Once you've verified you have the lock just restart OpenShift (running kubernetes v0.14.1-582-gb12d75d): At this point you can press in gdb to continue the iptables invocation and release the lock. Afterwards I will see output from cadvisor every once in a while, however the will show the firewall is still blank: I initially restarted Kubernetes with a blank firewall at 11:21 and yet at 11:38 I still have nothing:\nI probably should have made it more clear, I removed the lock by pressing 'c' in gdb to continue. That's when I started waiting. I'll update my comment to make that more clear.\nSo something for a holding the lock? I am out of your office for the rest of this week, but maybe you can figure out - is there a stale process holding a lock? What kind of lock is it? Flock or semaphore or ... ? On Apr 29, 2015 8:44 AM, \"Brenton Leanhardt\" wrote:\nWhat we're saying is that on startup it's fairly common for multiple systemd units to make firewall additions. If one of them grabs the lock (rarely for more than a few seconds) it will cause kubernetes to fail to initialize iptables and it will never fix itself. The lock only need be grabbed the microsecond kubernetes tries to initialize iptables for this bug to present itself. We know exactly which program in our environment was concurrently making iptables updates. The problem is that kubernetes doesn't appear to be retrying if it fails to initialize iptables.\nOn RHEL the lock is the xtables unix socket lock in iptables to allow multiple programs to update iptables concurrently. Other platforms may use a flock since that is the default upstream. To solve this kubernetes needs one more more of the following: pass the flag to as scott and the logs mention (possibly only available on some platforms). If kubernetes desides to wait for the lock it will need a timeout. retry the firewall initialization quickly and maybe backoff if it still can't get the lock It's probably worth noting that if iptables on a platform doesn't have iptables lock support concurrency is likely broken already in other ways for that platform.\nIt does retry all up tables ops. Unless it somehow gets pathologically phase locked with your agent, or there is some deeper bug. We have e2e tests that prove you can delete tables and it will recreate them. Are you saying that it never retries (did you set -v=4?) or that every retry fails? On RHEL the lock is the xtables unix socket lock in iptables to allow multiple programs to update iptables concurrently. Other platforms may use a flock since that is the default upstream. To solve this kubernetes needs one more more of the following: pass the -w flag to iptables as scott and the logs mention (possibly only available on some platforms). If kubernetes desides to wait for the lock it will need a timeout. retry the firewall initialization quickly and maybe backoff if it still can't get the lock It's probably worth noting that if iptables on a platform doesn't have iptables lock support concurrency is likely broken already in other ways for that platform. \u2014 Reply to this email directly or view it on GitHub .\nI can grab the lock for just the second that kubernetes needs it and then let it go. The kube-proxy nat'ing will never be rebuilt without intervention (restarting kubernetes). That seems like a bug to me and is what my original comment reproduces. In addition, once the environment is in this state it won't even pick up new service nat rules. Other nodes in my environment will pick them up but this one is dead. I highly suspect it has to do with the fact that iptables initialization is failing. We test all the time that once a system is up and running you can clean iptables and it will come back. This is a slightly different case.\nThis seems like a v1 blocker - we see this in every realistic environment we put the Kube-proxy in. Disagreement?\nI still don't understand this issue. It is demonstrably true that the kube-proxy retries all of the iptables logic periodically. It's possible (given the mention of \"won't even pick up new service nat rules\") that this locking tickles a bug in kube-proxy, but I am having trouble reproducing it. Can you run your kube-proxy with -v=4, trigger the bug, and then take a look at the logs? If this is real, yeah it's a 1.0 blocker.\nThe problem is in the initialization process. If you hold the lock while the kube-proxy tries to initialize itself then it will be wedged forever. What you're showing is the kube-proxy can repair the iptables rules after the initialization code has run. The logs I pasted earlier show that after the initialization fails at it will never try again. I tend to run at loglevel 4 by default but I'll try to find time today to run through this again.\nI have a fix coming - can you test the PR before commit?\nI ran the exact same test as mentioned in my original comment. While the debug lines have changed the end result is the same: grab the lock (at this point even will fail) start the kube-proxy release the lock (at this point works) wait.. try creating another service wait.. The rules never come back. Here are the logs:\nSure, I'll test the PR. I'm betting it will apply fairly cleanly on to my OpenShift codebase. If not I'll launch Kubernetes directly.\nMany of those log lines are not part of upstream. In fact, what upstream has is a glog.Fatalf() which will kill kube-proxy, and when it restarts it will try again. Did you guys break it by not actually exiting?\nLooks like we did. We need to put it into a restart loop. ----- Original Message -----\nis teh fix, though I assert we should not need it, and if you need it this fix may not help you anyway. I am still OK to commit this.\nAlthough NewProxier sucks because it doesn't return a usable error. I'll take the todo to clean up that part. ----- Original Message -----\nhey, it logs its error - nothing wrong with that :) , Clayton Coleman wrote:\n:)\nOpened and will move the rest back to openshift.\nI restarted docker and it worked then", "positive_passages": [{"docid": "doc-en-kubernetes-2692ea95d752e566ea380005856e9dd5663cbcdaa8e7b697eb6ad757627a431f", "text": "serviceQ := ServicePortName{types.NamespacedName{\"testnamespace\", \"echo\"}, \"q\"} serviceX := ServicePortName{types.NamespacedName{\"testnamespace\", \"echo\"}, \"x\"} <del> p := CreateProxier(lb, net.ParseIP(\"0.0.0.0\"), &fakeIptables{}, net.ParseIP(\"127.0.0.1\")) </del> <ins> p := createProxier(lb, net.ParseIP(\"0.0.0.0\"), &fakeIptables{}, net.ParseIP(\"127.0.0.1\")) </ins> waitForNumProxyLoops(t, p, 0) p.OnUpdate([]api.Service{{", "commid": "kubernetes_pr_8264"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e41c7a0a85635ba91742439b913fa4ee706ea1bfde3bc5546521b3318c03960", "query": "If another process is altering iptables rules at the time k8s attempts to add iptables rules it will fail with a locking error. k8s should use -w and retry after a delay. Below, an external process (openshift-sdn-node) modifies iptables at roughly the same time and k8s fails without retrying. Related to\nSorry, I misunderstood the -w flag, with it retry logic wouldn't be necessary as it'd wait. Perhaps simply retrying is a better solution as -w flag may not exist everywhere we'd like.\nLooks like -w was to iptables 1.4.20(August 2013).\nYeah, we have to be pretty back-compatible with iptables. We always retry after a few seconds - is there really a bug here? , Scott Dodson wrote:\nIt definitely seems like there is some sort of a problem. We see this randomly on system startup. In our environment OpenShift is launching kubernetes around the same time other systemd units are modifying the firewall config. If one of these others units has the lock kubernetes will report the error Scott mentions and then will never create the required nat'ing for services. Here's how to reproduce this: At this point if you run you will see the exact same error kubernetes reports. It's probably not obvious why you have to set the breakpoint at 257 but if you set the breakpoint at 260 and then step through the code it appears that the compiler has optimized lines 263 and 257 to be the same. In any case running will verify if you have the lock or not. Once you've verified you have the lock just restart OpenShift (running kubernetes v0.14.1-582-gb12d75d): At this point you can press in gdb to continue the iptables invocation and release the lock. Afterwards I will see output from cadvisor every once in a while, however the will show the firewall is still blank: I initially restarted Kubernetes with a blank firewall at 11:21 and yet at 11:38 I still have nothing:\nI probably should have made it more clear, I removed the lock by pressing 'c' in gdb to continue. That's when I started waiting. I'll update my comment to make that more clear.\nSo something for a holding the lock? I am out of your office for the rest of this week, but maybe you can figure out - is there a stale process holding a lock? What kind of lock is it? Flock or semaphore or ... ? On Apr 29, 2015 8:44 AM, \"Brenton Leanhardt\" wrote:\nWhat we're saying is that on startup it's fairly common for multiple systemd units to make firewall additions. If one of them grabs the lock (rarely for more than a few seconds) it will cause kubernetes to fail to initialize iptables and it will never fix itself. The lock only need be grabbed the microsecond kubernetes tries to initialize iptables for this bug to present itself. We know exactly which program in our environment was concurrently making iptables updates. The problem is that kubernetes doesn't appear to be retrying if it fails to initialize iptables.\nOn RHEL the lock is the xtables unix socket lock in iptables to allow multiple programs to update iptables concurrently. Other platforms may use a flock since that is the default upstream. To solve this kubernetes needs one more more of the following: pass the flag to as scott and the logs mention (possibly only available on some platforms). If kubernetes desides to wait for the lock it will need a timeout. retry the firewall initialization quickly and maybe backoff if it still can't get the lock It's probably worth noting that if iptables on a platform doesn't have iptables lock support concurrency is likely broken already in other ways for that platform.\nIt does retry all up tables ops. Unless it somehow gets pathologically phase locked with your agent, or there is some deeper bug. We have e2e tests that prove you can delete tables and it will recreate them. Are you saying that it never retries (did you set -v=4?) or that every retry fails? On RHEL the lock is the xtables unix socket lock in iptables to allow multiple programs to update iptables concurrently. Other platforms may use a flock since that is the default upstream. To solve this kubernetes needs one more more of the following: pass the -w flag to iptables as scott and the logs mention (possibly only available on some platforms). If kubernetes desides to wait for the lock it will need a timeout. retry the firewall initialization quickly and maybe backoff if it still can't get the lock It's probably worth noting that if iptables on a platform doesn't have iptables lock support concurrency is likely broken already in other ways for that platform. \u2014 Reply to this email directly or view it on GitHub .\nI can grab the lock for just the second that kubernetes needs it and then let it go. The kube-proxy nat'ing will never be rebuilt without intervention (restarting kubernetes). That seems like a bug to me and is what my original comment reproduces. In addition, once the environment is in this state it won't even pick up new service nat rules. Other nodes in my environment will pick them up but this one is dead. I highly suspect it has to do with the fact that iptables initialization is failing. We test all the time that once a system is up and running you can clean iptables and it will come back. This is a slightly different case.\nThis seems like a v1 blocker - we see this in every realistic environment we put the Kube-proxy in. Disagreement?\nI still don't understand this issue. It is demonstrably true that the kube-proxy retries all of the iptables logic periodically. It's possible (given the mention of \"won't even pick up new service nat rules\") that this locking tickles a bug in kube-proxy, but I am having trouble reproducing it. Can you run your kube-proxy with -v=4, trigger the bug, and then take a look at the logs? If this is real, yeah it's a 1.0 blocker.\nThe problem is in the initialization process. If you hold the lock while the kube-proxy tries to initialize itself then it will be wedged forever. What you're showing is the kube-proxy can repair the iptables rules after the initialization code has run. The logs I pasted earlier show that after the initialization fails at it will never try again. I tend to run at loglevel 4 by default but I'll try to find time today to run through this again.\nI have a fix coming - can you test the PR before commit?\nI ran the exact same test as mentioned in my original comment. While the debug lines have changed the end result is the same: grab the lock (at this point even will fail) start the kube-proxy release the lock (at this point works) wait.. try creating another service wait.. The rules never come back. Here are the logs:\nSure, I'll test the PR. I'm betting it will apply fairly cleanly on to my OpenShift codebase. If not I'll launch Kubernetes directly.\nMany of those log lines are not part of upstream. In fact, what upstream has is a glog.Fatalf() which will kill kube-proxy, and when it restarts it will try again. Did you guys break it by not actually exiting?\nLooks like we did. We need to put it into a restart loop. ----- Original Message -----\nis teh fix, though I assert we should not need it, and if you need it this fix may not help you anyway. I am still OK to commit this.\nAlthough NewProxier sucks because it doesn't return a usable error. I'll take the todo to clean up that part. ----- Original Message -----\nhey, it logs its error - nothing wrong with that :) , Clayton Coleman wrote:\n:)\nOpened and will move the rest back to openshift.\nI restarted docker and it worked then", "positive_passages": [{"docid": "doc-en-kubernetes-08371bdcb170d85f10964f5beebcbc7e6395698bcc3b36f2007dbbfe894f9887", "text": "}, }) <del> p := CreateProxier(lb, net.ParseIP(\"0.0.0.0\"), &fakeIptables{}, net.ParseIP(\"127.0.0.1\")) </del> <ins> p := createProxier(lb, net.ParseIP(\"0.0.0.0\"), &fakeIptables{}, net.ParseIP(\"127.0.0.1\")) </ins> waitForNumProxyLoops(t, p, 0) svcInfo, err := p.addServiceOnPort(service, \"UDP\", 0, time.Second)", "commid": "kubernetes_pr_8264"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e41c7a0a85635ba91742439b913fa4ee706ea1bfde3bc5546521b3318c03960", "query": "If another process is altering iptables rules at the time k8s attempts to add iptables rules it will fail with a locking error. k8s should use -w and retry after a delay. Below, an external process (openshift-sdn-node) modifies iptables at roughly the same time and k8s fails without retrying. Related to\nSorry, I misunderstood the -w flag, with it retry logic wouldn't be necessary as it'd wait. Perhaps simply retrying is a better solution as -w flag may not exist everywhere we'd like.\nLooks like -w was to iptables 1.4.20(August 2013).\nYeah, we have to be pretty back-compatible with iptables. We always retry after a few seconds - is there really a bug here? , Scott Dodson wrote:\nIt definitely seems like there is some sort of a problem. We see this randomly on system startup. In our environment OpenShift is launching kubernetes around the same time other systemd units are modifying the firewall config. If one of these others units has the lock kubernetes will report the error Scott mentions and then will never create the required nat'ing for services. Here's how to reproduce this: At this point if you run you will see the exact same error kubernetes reports. It's probably not obvious why you have to set the breakpoint at 257 but if you set the breakpoint at 260 and then step through the code it appears that the compiler has optimized lines 263 and 257 to be the same. In any case running will verify if you have the lock or not. Once you've verified you have the lock just restart OpenShift (running kubernetes v0.14.1-582-gb12d75d): At this point you can press in gdb to continue the iptables invocation and release the lock. Afterwards I will see output from cadvisor every once in a while, however the will show the firewall is still blank: I initially restarted Kubernetes with a blank firewall at 11:21 and yet at 11:38 I still have nothing:\nI probably should have made it more clear, I removed the lock by pressing 'c' in gdb to continue. That's when I started waiting. I'll update my comment to make that more clear.\nSo something for a holding the lock? I am out of your office for the rest of this week, but maybe you can figure out - is there a stale process holding a lock? What kind of lock is it? Flock or semaphore or ... ? On Apr 29, 2015 8:44 AM, \"Brenton Leanhardt\" wrote:\nWhat we're saying is that on startup it's fairly common for multiple systemd units to make firewall additions. If one of them grabs the lock (rarely for more than a few seconds) it will cause kubernetes to fail to initialize iptables and it will never fix itself. The lock only need be grabbed the microsecond kubernetes tries to initialize iptables for this bug to present itself. We know exactly which program in our environment was concurrently making iptables updates. The problem is that kubernetes doesn't appear to be retrying if it fails to initialize iptables.\nOn RHEL the lock is the xtables unix socket lock in iptables to allow multiple programs to update iptables concurrently. Other platforms may use a flock since that is the default upstream. To solve this kubernetes needs one more more of the following: pass the flag to as scott and the logs mention (possibly only available on some platforms). If kubernetes desides to wait for the lock it will need a timeout. retry the firewall initialization quickly and maybe backoff if it still can't get the lock It's probably worth noting that if iptables on a platform doesn't have iptables lock support concurrency is likely broken already in other ways for that platform.\nIt does retry all up tables ops. Unless it somehow gets pathologically phase locked with your agent, or there is some deeper bug. We have e2e tests that prove you can delete tables and it will recreate them. Are you saying that it never retries (did you set -v=4?) or that every retry fails? On RHEL the lock is the xtables unix socket lock in iptables to allow multiple programs to update iptables concurrently. Other platforms may use a flock since that is the default upstream. To solve this kubernetes needs one more more of the following: pass the -w flag to iptables as scott and the logs mention (possibly only available on some platforms). If kubernetes desides to wait for the lock it will need a timeout. retry the firewall initialization quickly and maybe backoff if it still can't get the lock It's probably worth noting that if iptables on a platform doesn't have iptables lock support concurrency is likely broken already in other ways for that platform. \u2014 Reply to this email directly or view it on GitHub .\nI can grab the lock for just the second that kubernetes needs it and then let it go. The kube-proxy nat'ing will never be rebuilt without intervention (restarting kubernetes). That seems like a bug to me and is what my original comment reproduces. In addition, once the environment is in this state it won't even pick up new service nat rules. Other nodes in my environment will pick them up but this one is dead. I highly suspect it has to do with the fact that iptables initialization is failing. We test all the time that once a system is up and running you can clean iptables and it will come back. This is a slightly different case.\nThis seems like a v1 blocker - we see this in every realistic environment we put the Kube-proxy in. Disagreement?\nI still don't understand this issue. It is demonstrably true that the kube-proxy retries all of the iptables logic periodically. It's possible (given the mention of \"won't even pick up new service nat rules\") that this locking tickles a bug in kube-proxy, but I am having trouble reproducing it. Can you run your kube-proxy with -v=4, trigger the bug, and then take a look at the logs? If this is real, yeah it's a 1.0 blocker.\nThe problem is in the initialization process. If you hold the lock while the kube-proxy tries to initialize itself then it will be wedged forever. What you're showing is the kube-proxy can repair the iptables rules after the initialization code has run. The logs I pasted earlier show that after the initialization fails at it will never try again. I tend to run at loglevel 4 by default but I'll try to find time today to run through this again.\nI have a fix coming - can you test the PR before commit?\nI ran the exact same test as mentioned in my original comment. While the debug lines have changed the end result is the same: grab the lock (at this point even will fail) start the kube-proxy release the lock (at this point works) wait.. try creating another service wait.. The rules never come back. Here are the logs:\nSure, I'll test the PR. I'm betting it will apply fairly cleanly on to my OpenShift codebase. If not I'll launch Kubernetes directly.\nMany of those log lines are not part of upstream. In fact, what upstream has is a glog.Fatalf() which will kill kube-proxy, and when it restarts it will try again. Did you guys break it by not actually exiting?\nLooks like we did. We need to put it into a restart loop. ----- Original Message -----\nis teh fix, though I assert we should not need it, and if you need it this fix may not help you anyway. I am still OK to commit this.\nAlthough NewProxier sucks because it doesn't return a usable error. I'll take the todo to clean up that part. ----- Original Message -----\nhey, it logs its error - nothing wrong with that :) , Clayton Coleman wrote:\n:)\nOpened and will move the rest back to openshift.\nI restarted docker and it worked then", "positive_passages": [{"docid": "doc-en-kubernetes-9918f6181845d4d93d373e98806ba39e99c86437fbb3fb95fe4b92f814c95a8f", "text": "}, }) <del> p := CreateProxier(lb, net.ParseIP(\"0.0.0.0\"), &fakeIptables{}, net.ParseIP(\"127.0.0.1\")) </del> <ins> p := createProxier(lb, net.ParseIP(\"0.0.0.0\"), &fakeIptables{}, net.ParseIP(\"127.0.0.1\")) </ins> waitForNumProxyLoops(t, p, 0) svcInfo, err := p.addServiceOnPort(service, \"TCP\", 0, time.Second)", "commid": "kubernetes_pr_8264"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-83d108f0f5dc476eb3ccc1bd3ac7ca0c88769da6703901d0bcbe64c096876bb1", "query": "Following on from the Kubelet should accept YAML pod specifications. Currnelty it supports only JSON pod specifications.", "positive_passages": [{"docid": "doc-en-kubernetes-f9874b24eec205868f1f38d0ed2b3fdc7edcb3e69b50bd6ef86bb89285c53d83", "text": "\"github.com/GoogleCloudPlatform/kubernetes/pkg/kubelet\" \"github.com/GoogleCloudPlatform/kubernetes/pkg/types\" \"github.com/GoogleCloudPlatform/kubernetes/pkg/util\" <ins> utilyaml \"github.com/GoogleCloudPlatform/kubernetes/pkg/util/yaml\" </ins> \"github.com/ghodss/yaml\" \"github.com/golang/glog\"", "commid": "kubernetes_pr_7515"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-83d108f0f5dc476eb3ccc1bd3ac7ca0c88769da6703901d0bcbe64c096876bb1", "query": "Following on from the Kubelet should accept YAML pod specifications. Currnelty it supports only JSON pod specifications.", "positive_passages": [{"docid": "doc-en-kubernetes-3430a45b60fa8a9bce11719db20d0e292df191242d85696bd5438217be95cbec", "text": "type defaultFunc func(pod *api.Pod) error func tryDecodeSinglePod(data []byte, defaultFn defaultFunc) (parsed bool, pod *api.Pod, err error) { <del> obj, err := api.Scheme.Decode(data) </del> <ins> // JSON is valid YAML, so this should work for everything. json, err := utilyaml.ToJSON(data) if err != nil { return false, nil, err } obj, err := api.Scheme.Decode(json) </ins> if err != nil { return false, pod, err }", "commid": "kubernetes_pr_7515"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-83d108f0f5dc476eb3ccc1bd3ac7ca0c88769da6703901d0bcbe64c096876bb1", "query": "Following on from the Kubelet should accept YAML pod specifications. Currnelty it supports only JSON pod specifications.", "positive_passages": [{"docid": "doc-en-kubernetes-539cf25e446796fb3f0dae58672c223b43b6a20296af51f15f49acd677bff184", "text": "} func tryDecodePodList(data []byte, defaultFn defaultFunc) (parsed bool, pods api.PodList, err error) { <del> obj, err := api.Scheme.Decode(data) </del> <ins> json, err := utilyaml.ToJSON(data) if err != nil { return false, api.PodList{}, err } obj, err := api.Scheme.Decode(json) </ins> if err != nil { return false, pods, err }", "commid": "kubernetes_pr_7515"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-83d108f0f5dc476eb3ccc1bd3ac7ca0c88769da6703901d0bcbe64c096876bb1", "query": "Following on from the Kubelet should accept YAML pod specifications. Currnelty it supports only JSON pod specifications.", "positive_passages": [{"docid": "doc-en-kubernetes-fa416530ef5408b8f05d686a75822492eadb2e92808e4558d8cef5c473ed1410", "text": "<ins> /* Copyright 2014 Google Inc. All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package config import ( \"reflect\" \"testing\" \"github.com/GoogleCloudPlatform/kubernetes/pkg/api\" \"github.com/GoogleCloudPlatform/kubernetes/pkg/api/testapi\" \"github.com/ghodss/yaml\" ) func noDefault(*api.Pod) error { return nil } func TestDecodeSinglePod(t *testing.T) { pod := &api.Pod{ TypeMeta: api.TypeMeta{ APIVersion: \"\", }, ObjectMeta: api.ObjectMeta{ Name:      \"test\", UID:       \"12345\", Namespace: \"mynamespace\", }, Spec: api.PodSpec{ RestartPolicy: api.RestartPolicyAlways, DNSPolicy:     api.DNSClusterFirst, Containers: []api.Container{{ Name:                   \"image\", Image:                  \"test/image\", ImagePullPolicy:        \"IfNotPresent\", TerminationMessagePath: \"/dev/termination-log\", }}, }, } json, err := testapi.Codec().Encode(pod) if err != nil { t.Errorf(\"unexpected error: %v\", err) } parsed, podOut, err := tryDecodeSinglePod(json, noDefault) if testapi.Version() == \"v1beta1\" { // v1beta1 conversion leaves empty lists that should be nil podOut.Spec.Containers[0].Resources.Limits = nil podOut.Spec.Containers[0].Resources.Requests = nil } if !parsed { t.Errorf(\"expected to have parsed file: (%s)\", string(json)) } if err != nil { t.Errorf(\"unexpected error: %v (%s)\", err, string(json)) } if !reflect.DeepEqual(pod, podOut) { t.Errorf(\"expected:n%#vngot:n%#vn%s\", pod, podOut, string(json)) } externalPod, err := testapi.Converter().ConvertToVersion(pod, \"v1beta3\") if err != nil { t.Errorf(\"unexpected error: %v\", err) } yaml, err := yaml.Marshal(externalPod) if err != nil { t.Errorf(\"unexpected error: %v\", err) } parsed, podOut, err = tryDecodeSinglePod(yaml, noDefault) if !parsed { t.Errorf(\"expected to have parsed file: (%s)\", string(yaml)) } if err != nil { t.Errorf(\"unexpected error: %v (%s)\", err, string(yaml)) } if !reflect.DeepEqual(pod, podOut) { t.Errorf(\"expected:n%#vngot:n%#vn%s\", pod, podOut, string(yaml)) } } func TestDecodePodList(t *testing.T) { pod := &api.Pod{ TypeMeta: api.TypeMeta{ APIVersion: \"\", }, ObjectMeta: api.ObjectMeta{ Name:      \"test\", UID:       \"12345\", Namespace: \"mynamespace\", }, Spec: api.PodSpec{ RestartPolicy: api.RestartPolicyAlways, DNSPolicy:     api.DNSClusterFirst, Containers: []api.Container{{ Name:                   \"image\", Image:                  \"test/image\", ImagePullPolicy:        \"IfNotPresent\", TerminationMessagePath: \"/dev/termination-log\", }}, }, } podList := &api.PodList{ Items: []api.Pod{*pod}, } json, err := testapi.Codec().Encode(podList) if err != nil { t.Errorf(\"unexpected error: %v\", err) } parsed, podListOut, err := tryDecodePodList(json, noDefault) if testapi.Version() == \"v1beta1\" { // v1beta1 conversion leaves empty lists that should be nil podListOut.Items[0].Spec.Containers[0].Resources.Limits = nil podListOut.Items[0].Spec.Containers[0].Resources.Requests = nil } if !parsed { t.Errorf(\"expected to have parsed file: (%s)\", string(json)) } if err != nil { t.Errorf(\"unexpected error: %v (%s)\", err, string(json)) } if !reflect.DeepEqual(podList, &podListOut) { t.Errorf(\"expected:n%#vngot:n%#vn%s\", podList, &podListOut, string(json)) } externalPodList, err := testapi.Converter().ConvertToVersion(podList, \"v1beta3\") if err != nil { t.Errorf(\"unexpected error: %v\", err) } yaml, err := yaml.Marshal(externalPodList) if err != nil { t.Errorf(\"unexpected error: %v\", err) } parsed, podListOut, err = tryDecodePodList(yaml, noDefault) if !parsed { t.Errorf(\"expected to have parsed file: (%s)\", string(yaml)) } if err != nil { t.Errorf(\"unexpected error: %v (%s)\", err, string(yaml)) } if !reflect.DeepEqual(podList, &podListOut) { t.Errorf(\"expected:n%#vngot:n%#vn%s\", pod, &podListOut, string(yaml)) } } </ins>", "commid": "kubernetes_pr_7515"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-528257a8d86f973b92cc017b02ead0ef3ea1934cb7f6381428f555668a8c1a21", "query": "As the title suggests, I can find no documentation on KUBEADMISSIONCONTROL (from the apiserver configuration), and I don't know golang well enough to determine the answer (yet) from the source code. Google search yields only 3 hits today, and all of them are copies of the configuration file itself with no commentary. As an admin, I'd be grateful for simple documentation on all the variables, their possible settings, and what those really mean. If that already exists, please identify where it exists. Though my formal issue is the documentation, the problem that leads me here is that my pods can't query the apiserver. Given the following, my connection is reset: Any assistance would be greatly appreciated, though my formal issue remains the lack of thorough documentation on the configuration. I'll continue learning golang in order to try to figure out what my problem may be.\nI agree a document is needed, will look to put something together describing what each option does.\nThanks! :)\nThat being said, I recommend we scope this issue to just documentation being needed, and if you need assistance with your other topic, treat it as a separate issue.\nQuite reasonable! If you think that documentation will be before the weekend, I'll wait until that's available and see if I can figure it out myself; otherwise, I'll make a separate issue for that.", "positive_passages": [{"docid": "doc-en-kubernetes-79c4280a882321b8dcfa3c1401200cbcd1da5d8baccc1d70fa767cc195e7bf1f", "text": "<ins> # Admission Controllers ## What are they? An admission control plug-in is a piece of code that intercepts requests to the Kubernetes API server prior to persistence of the object.  The plug-in code is in the API server process and must be compiled into the binary in order to be used at this time. Each admission control plug-in is run in sequence before a request is accepted into the cluster.  If any of the plug-ins in the sequence reject the request, the entire request is rejected immediately and an error is returned to the end-user. Admission control plug-ins may mutate the incoming object in some cases to apply system configured defaults.  In addition, admission control plug-ins may mutate related resources as part of request processing to do things like increment quota usage. ## Why do I need them? Many advanced features in Kubernetes require an admission control plug-in to be enabled in order to properly support the feature.  As a result, a Kubernetes API server that is not properly configured with the right set of admission control plug-ins is an incomplete server and will not support all the features you expect. ## How do I turn on an admission control plug-in? The Kubernetes API server supports a flag, ```admission_control``` that takes a comma-delimited, ordered list of admission control choices to invoke prior to modifying objects in the cluster. ## What does each plug-in do? ### AlwaysAdmit This plug-in will accept all incoming requests made to the Kubernetes API server. ### AlwaysDeny This plug-in will reject all mutating requests made to the Kubernetes API server.  It's largely intended for testing purposes and is not recommended for usage in a real deployment. ### DenyExecOnPrivileged This plug-in will intercept all requests to exec a command in a pod if that pod has a privileged container. If your cluster supports privileged containers, and you want to restrict the ability of end-users to exec commands in those containers, we strongly encourage enabling this plug-in. ### ServiceAccount This plug-in limits admission of Pod creation requests based on the Pod's ```ServiceAccount```. 1. If the pod does not have a ```ServiceAccount```, it modifies the pod's ```ServiceAccount``` to \"default\". 2. It ensures that the ```ServiceAccount``` referenced by a pod exists. 3. If ```LimitSecretReferences``` is true, it rejects the pod if the pod references ```Secret``` objects which the pods ```ServiceAccount``` does not reference. 4. If the pod does not contain any ```ImagePullSecrets```, the ```ImagePullSecrets``` of the ```ServiceAccount``` are added to the pod. 5. If ```MountServiceAccountToken``` is true, it adds a ```VolumeMount``` with the pod's ```ServiceAccount``` API token secret to containers in the pod. We strongly recommend using this plug-in if you intend to make use of Kubernetes ```ServiceAccount``` objects. ### SecurityContextDeny This plug-in will deny any ```SecurityContext``` that defines options that were not available on the ```Container```. ### ResourceQuota This plug-in will observe the incoming request and ensure that it does not violate any of the constraints enumerated in the ```ResourceQuota``` object in a ```Namespace```.  If you are using ```ResourceQuota``` objects in your Kubernetes deployment, you MUST use this plug-in to enforce quota constraints. It is strongly encouraged that this plug-in is configured last in the sequence of admission control plug-ins.  This is so that quota is not prematurely incremented only for the request to be rejected later in admission control. ### LimitRanger This plug-in will observe the incoming request and ensure that it does not violate any of the constraints enumerated in the ```LimitRange``` object in a ```Namespace```.  If you are using ```LimitRange``` objects in your Kubernetes deployment, you MUST use this plug-in to enforce those constraints. ### NamespaceExists This plug-in will observe all incoming requests that attempt to create a resource in a Kubernetes ```Namespace``` and reject the request if the ```Namespace``` was not previously created.  We strongly recommend running this plug-in to ensure integrity of your data. ### NamespaceAutoProvision (deprecated) This plug-in will observe all incoming requests that attempt to create a resource in a Kubernetes ```Namespace``` and create a new ```Namespace``` if one did not already exist previously. We strongly recommend ```NamespaceExists``` over ```NamespaceAutoProvision```. ### NamespaceLifecycle This plug-in enforces that a ```Namespace``` that is undergoing termination cannot have new content created in it. A ```Namespace``` deletion kicks off a sequence of operations that remove all content (pods, services, etc.) in that namespace.  In order to enforce integrity of that process, we strongly recommend running this plug-in. Once ```NamespaceAutoProvision``` is deprecated, we anticipate ```NamespaceLifecycle``` and ```NamespaceExists``` will be merged into a single plug-in that enforces the life-cycle of a ```Namespace``` in Kubernetes. ## Is there a recommended set of plug-ins to use? Yes. For Kubernetes 1.0, we strongly recommend running the following set of admission control plug-ins: ```shell --admission_control=NamespaceLifecycle,NamespaceExists,LimitRanger,SecurityContextDeny,ServiceAccount,ResourceQuota ``` </ins>", "commid": "kubernetes_pr_8936"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5cad7f0b9d7423b15ef1aff818cb7d7539e6f84907a939c490fb9042ee93c984", "query": "We seem to have an occasional consistency issue between the client and server versions on our Jenkins GCE e2e project. Build 6295 failed this morning because the client version was newer than the server version: The server version matches the build was was immediately running in 6294, which was aborted early. I wonder if (somehow) the cleanup didn't work properly? (Which is a bit worrying if so.) Here's the version from 6294: A short while later, build 6297 failed, this time with the client version older than the server version: This one makes a little bit more sense: there was a new build published between downloading the client/test tarballs and setting up the cluster. I'm guessing that somewhere in the cluster setup scripts the latest CI release file was read again, rather than using the version read for the client/test tarballs. (I haven't yet worked out where exactly it's read, but it should be an easier fix.) cc\nA side issue: we should probably figure out why the build git client is being marked dirty. Since we're checking out the head version from GitHub, it should ideally be a clean client.\nThe -dirty bit is now fixed by .\nThis is caused by different Jenkins jobs uploading to the same GCS bucket and clobbering each other. In we see: Over in\nThis also explains the issues seen in ; the job is also running in the same project.\nAh, good sleuthing. We avoided this issue in the PR builds by setting (used ), but maybe we should always be setting to include the Jenkins job name (and optionally executor/node number).\nThe original idea was to run every e2e job in it's own project, to avoid these sorts of name clashes. But we seem to have regressed and now have many jobs sharing the same projects. Is project-per-job not a better approach? It also helps with resource leaks and the likes. Just a thought.\nI'd argue this is actually uncovering a (dev) deployment bug; I should be able to deploy different versions of Kubernetes to the same project. I know you and I disagree (and probably always will) on the strategy here. :smile:\nfwiw I think I agree with that if project-per-job avoids this issue and helps identify resource leaks, it's a pragmatic near-term improvement in the state of the world that would result in more benefit than the cost of changing all the everythings to support multi-job-in-project. Re: devs deploying different versions of k8s to the same project, P3 feature request?\nI was just about to suggest the same thing. I will file a separate issue, and fix this in the short term an easier way. is out to make it easier to isolate a run to a project.\nAlso it seems like a reasonable thing (higher than P2) to want to deploy multiple clusters to the same project safely in prod, not just dev. Disagree?\nMultiple clusters in prod using well-defined build versions such as v1.1.4 = P0. Multiple clusters in prod using our cooked-up test-building system = non-goal?\nSGTM; this is prod code, though, not test code; it's used every time we call , regardless of whether it's a CI build or released version.\nFYI: kubernetes-e2e-gce-reboot/ has one reboot test failed due to kube-proxy image change. But that build doesn't include pr yet.\nlooks like it. That run used version , but the first build with was .", "positive_passages": [{"docid": "doc-en-kubernetes-e06112a56a76529d48d6921c89004d4d28702de270d0190309013ca2dca3f8c2", "text": "KUBE_PROMPT_FOR_UPDATE=y KUBE_SKIP_UPDATE=${KUBE_SKIP_UPDATE-\"n\"} <del> # Suffix to append to the staging path used for the server tars. Useful if # multiple versions of the server are being used in the same project # simultaneously (e.g. on Jenkins). KUBE_GCS_STAGING_PATH_SUFFIX=${KUBE_GCS_STAGING_PATH_SUFFIX-\"\"} </del> # How long (in seconds) to wait for cluster initialization. KUBE_CLUSTER_INITIALIZATION_TIMEOUT=${KUBE_CLUSTER_INITIALIZATION_TIMEOUT:-300}", "commid": "kubernetes_pr_20036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5cad7f0b9d7423b15ef1aff818cb7d7539e6f84907a939c490fb9042ee93c984", "query": "We seem to have an occasional consistency issue between the client and server versions on our Jenkins GCE e2e project. Build 6295 failed this morning because the client version was newer than the server version: The server version matches the build was was immediately running in 6294, which was aborted early. I wonder if (somehow) the cleanup didn't work properly? (Which is a bit worrying if so.) Here's the version from 6294: A short while later, build 6297 failed, this time with the client version older than the server version: This one makes a little bit more sense: there was a new build published between downloading the client/test tarballs and setting up the cluster. I'm guessing that somewhere in the cluster setup scripts the latest CI release file was read again, rather than using the version read for the client/test tarballs. (I haven't yet worked out where exactly it's read, but it should be an easier fix.) cc\nA side issue: we should probably figure out why the build git client is being marked dirty. Since we're checking out the head version from GitHub, it should ideally be a clean client.\nThe -dirty bit is now fixed by .\nThis is caused by different Jenkins jobs uploading to the same GCS bucket and clobbering each other. In we see: Over in\nThis also explains the issues seen in ; the job is also running in the same project.\nAh, good sleuthing. We avoided this issue in the PR builds by setting (used ), but maybe we should always be setting to include the Jenkins job name (and optionally executor/node number).\nThe original idea was to run every e2e job in it's own project, to avoid these sorts of name clashes. But we seem to have regressed and now have many jobs sharing the same projects. Is project-per-job not a better approach? It also helps with resource leaks and the likes. Just a thought.\nI'd argue this is actually uncovering a (dev) deployment bug; I should be able to deploy different versions of Kubernetes to the same project. I know you and I disagree (and probably always will) on the strategy here. :smile:\nfwiw I think I agree with that if project-per-job avoids this issue and helps identify resource leaks, it's a pragmatic near-term improvement in the state of the world that would result in more benefit than the cost of changing all the everythings to support multi-job-in-project. Re: devs deploying different versions of k8s to the same project, P3 feature request?\nI was just about to suggest the same thing. I will file a separate issue, and fix this in the short term an easier way. is out to make it easier to isolate a run to a project.\nAlso it seems like a reasonable thing (higher than P2) to want to deploy multiple clusters to the same project safely in prod, not just dev. Disagree?\nMultiple clusters in prod using well-defined build versions such as v1.1.4 = P0. Multiple clusters in prod using our cooked-up test-building system = non-goal?\nSGTM; this is prod code, though, not test code; it's used every time we call , regardless of whether it's a CI build or released version.\nFYI: kubernetes-e2e-gce-reboot/ has one reboot test failed due to kube-proxy image change. But that build doesn't include pr yet.\nlooks like it. That run used version , but the first build with was .", "positive_passages": [{"docid": "doc-en-kubernetes-91ef31c9ba0c2473d0e9da5ed4a4643c4cb38ca8a81fd5df7dfe87230fc05b92", "text": "gsutil mb \"${staging_bucket}\" fi <del> local -r staging_path=\"${staging_bucket}/devel${KUBE_GCS_STAGING_PATH_SUFFIX}\" </del> <ins> local -r staging_path=\"${staging_bucket}/${INSTANCE_PREFIX}-devel\" </ins> SERVER_BINARY_TAR_HASH=$(sha1sum-file \"${SERVER_BINARY_TAR}\") SALT_TAR_HASH=$(sha1sum-file \"${SALT_TAR}\")", "commid": "kubernetes_pr_20036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5cad7f0b9d7423b15ef1aff818cb7d7539e6f84907a939c490fb9042ee93c984", "query": "We seem to have an occasional consistency issue between the client and server versions on our Jenkins GCE e2e project. Build 6295 failed this morning because the client version was newer than the server version: The server version matches the build was was immediately running in 6294, which was aborted early. I wonder if (somehow) the cleanup didn't work properly? (Which is a bit worrying if so.) Here's the version from 6294: A short while later, build 6297 failed, this time with the client version older than the server version: This one makes a little bit more sense: there was a new build published between downloading the client/test tarballs and setting up the cluster. I'm guessing that somewhere in the cluster setup scripts the latest CI release file was read again, rather than using the version read for the client/test tarballs. (I haven't yet worked out where exactly it's read, but it should be an easier fix.) cc\nA side issue: we should probably figure out why the build git client is being marked dirty. Since we're checking out the head version from GitHub, it should ideally be a clean client.\nThe -dirty bit is now fixed by .\nThis is caused by different Jenkins jobs uploading to the same GCS bucket and clobbering each other. In we see: Over in\nThis also explains the issues seen in ; the job is also running in the same project.\nAh, good sleuthing. We avoided this issue in the PR builds by setting (used ), but maybe we should always be setting to include the Jenkins job name (and optionally executor/node number).\nThe original idea was to run every e2e job in it's own project, to avoid these sorts of name clashes. But we seem to have regressed and now have many jobs sharing the same projects. Is project-per-job not a better approach? It also helps with resource leaks and the likes. Just a thought.\nI'd argue this is actually uncovering a (dev) deployment bug; I should be able to deploy different versions of Kubernetes to the same project. I know you and I disagree (and probably always will) on the strategy here. :smile:\nfwiw I think I agree with that if project-per-job avoids this issue and helps identify resource leaks, it's a pragmatic near-term improvement in the state of the world that would result in more benefit than the cost of changing all the everythings to support multi-job-in-project. Re: devs deploying different versions of k8s to the same project, P3 feature request?\nI was just about to suggest the same thing. I will file a separate issue, and fix this in the short term an easier way. is out to make it easier to isolate a run to a project.\nAlso it seems like a reasonable thing (higher than P2) to want to deploy multiple clusters to the same project safely in prod, not just dev. Disagree?\nMultiple clusters in prod using well-defined build versions such as v1.1.4 = P0. Multiple clusters in prod using our cooked-up test-building system = non-goal?\nSGTM; this is prod code, though, not test code; it's used every time we call , regardless of whether it's a CI build or released version.\nFYI: kubernetes-e2e-gce-reboot/ has one reboot test failed due to kube-proxy image change. But that build doesn't include pr yet.\nlooks like it. That run used version , but the first build with was .", "positive_passages": [{"docid": "doc-en-kubernetes-5faed00eba9de025efb411dc4db0f452e8c9be1840c5183c9253147a0efde608", "text": "${GCE_SLOW_TESTS[@]:+${GCE_SLOW_TESTS[@]}}  )\"} : ${KUBE_GCE_INSTANCE_PREFIX:=\"e2e-gce-${NODE_NAME}-${EXECUTOR_NUMBER}\"} <del> : ${KUBE_GCS_STAGING_PATH_SUFFIX:=\"-${NODE_NAME}-${EXECUTOR_NUMBER}\"} </del> : ${PROJECT:=\"kubernetes-jenkins-pull\"} : ${ENABLE_DEPLOYMENTS:=true} # Override GCE defaults", "commid": "kubernetes_pr_20036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5cad7f0b9d7423b15ef1aff818cb7d7539e6f84907a939c490fb9042ee93c984", "query": "We seem to have an occasional consistency issue between the client and server versions on our Jenkins GCE e2e project. Build 6295 failed this morning because the client version was newer than the server version: The server version matches the build was was immediately running in 6294, which was aborted early. I wonder if (somehow) the cleanup didn't work properly? (Which is a bit worrying if so.) Here's the version from 6294: A short while later, build 6297 failed, this time with the client version older than the server version: This one makes a little bit more sense: there was a new build published between downloading the client/test tarballs and setting up the cluster. I'm guessing that somewhere in the cluster setup scripts the latest CI release file was read again, rather than using the version read for the client/test tarballs. (I haven't yet worked out where exactly it's read, but it should be an easier fix.) cc\nA side issue: we should probably figure out why the build git client is being marked dirty. Since we're checking out the head version from GitHub, it should ideally be a clean client.\nThe -dirty bit is now fixed by .\nThis is caused by different Jenkins jobs uploading to the same GCS bucket and clobbering each other. In we see: Over in\nThis also explains the issues seen in ; the job is also running in the same project.\nAh, good sleuthing. We avoided this issue in the PR builds by setting (used ), but maybe we should always be setting to include the Jenkins job name (and optionally executor/node number).\nThe original idea was to run every e2e job in it's own project, to avoid these sorts of name clashes. But we seem to have regressed and now have many jobs sharing the same projects. Is project-per-job not a better approach? It also helps with resource leaks and the likes. Just a thought.\nI'd argue this is actually uncovering a (dev) deployment bug; I should be able to deploy different versions of Kubernetes to the same project. I know you and I disagree (and probably always will) on the strategy here. :smile:\nfwiw I think I agree with that if project-per-job avoids this issue and helps identify resource leaks, it's a pragmatic near-term improvement in the state of the world that would result in more benefit than the cost of changing all the everythings to support multi-job-in-project. Re: devs deploying different versions of k8s to the same project, P3 feature request?\nI was just about to suggest the same thing. I will file a separate issue, and fix this in the short term an easier way. is out to make it easier to isolate a run to a project.\nAlso it seems like a reasonable thing (higher than P2) to want to deploy multiple clusters to the same project safely in prod, not just dev. Disagree?\nMultiple clusters in prod using well-defined build versions such as v1.1.4 = P0. Multiple clusters in prod using our cooked-up test-building system = non-goal?\nSGTM; this is prod code, though, not test code; it's used every time we call , regardless of whether it's a CI build or released version.\nFYI: kubernetes-e2e-gce-reboot/ has one reboot test failed due to kube-proxy image change. But that build doesn't include pr yet.\nlooks like it. That run used version , but the first build with was .", "positive_passages": [{"docid": "doc-en-kubernetes-2ec150b3d8333d0433b816cb43a5ff4257e730671431ce9d6b75f5ccaa2a7e42", "text": "export KUBE_GCE_ZONE=${E2E_ZONE} export KUBE_GCE_NETWORK=${E2E_NETWORK} export KUBE_GCE_INSTANCE_PREFIX=${KUBE_GCE_INSTANCE_PREFIX:-} <del> export KUBE_GCS_STAGING_PATH_SUFFIX=${KUBE_GCS_STAGING_PATH_SUFFIX:-} </del> export KUBE_GCE_NODE_PROJECT=${KUBE_GCE_NODE_PROJECT:-} export KUBE_GCE_NODE_IMAGE=${KUBE_GCE_NODE_IMAGE:-} export KUBE_OS_DISTRIBUTION=${KUBE_OS_DISTRIBUTION:-}", "commid": "kubernetes_pr_20036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3aad09bd638f4d0e6738065aebd7ae97fbb23d73b8dd9d1472c634994380848d", "query": "We need to be squelching the auth variables on upgrade anyways, but this complaint gets issued (and it proceeds anyways): cc", "positive_passages": [{"docid": "doc-en-kubernetes-a9eafe3272debeff63d61e53045a3064909a24dfb61be6506741a494fab9a116", "text": "KUBE_PROXY_TOKEN: $(yaml-quote ${KUBE_PROXY_TOKEN:-}) ADMISSION_CONTROL: $(yaml-quote ${ADMISSION_CONTROL:-}) MASTER_IP_RANGE: $(yaml-quote ${MASTER_IP_RANGE}) <del> CA_CERT: $(yaml-quote ${CA_CERT_BASE64}) </del> <ins> CA_CERT: $(yaml-quote ${CA_CERT_BASE64:-}) </ins> EOF if [[ \"${master}\" == \"true\" ]]; then", "commid": "kubernetes_pr_9074"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-661345ebb8c9ce30f7455d4bf53da418af157a4bd40a657033e168d627bd4150", "query": "In case of cluster crash and status recovery, the persistentVolumeClaimBinder would not re-add available volumes to its internal index. Users would not be able to claim those volumes.\nThis is really bad. I think we should just nix Pending phase and always consider every Available volume for indexing - map lookups are cheap.", "positive_passages": [{"docid": "doc-en-kubernetes-b3893d0cd50188792747a411e44b1be2c928909f6df0acc3db87c34d993db92f", "text": "// available volumes await a claim case api.VolumeAvailable: <ins> // TODO:  remove api.VolumePending phase altogether _, exists, err := volumeIndex.Get(volume) if err != nil { return err } if !exists { volumeIndex.Add(volume) } </ins> if volume.Spec.ClaimRef != nil { _, err := binderClient.GetPersistentVolumeClaim(volume.Spec.ClaimRef.Namespace, volume.Spec.ClaimRef.Name) if err == nil {", "commid": "kubernetes_pr_9282"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-661345ebb8c9ce30f7455d4bf53da418af157a4bd40a657033e168d627bd4150", "query": "In case of cluster crash and status recovery, the persistentVolumeClaimBinder would not re-add available volumes to its internal index. Users would not be able to claim those volumes.\nThis is really bad. I think we should just nix Pending phase and always consider every Available volume for indexing - map lookups are cheap.", "positive_passages": [{"docid": "doc-en-kubernetes-46da62bf3382b5305f544e79819f393501c0e121186ec9d1d36b19c5d1036f96", "text": "} } <ins> func TestMissingFromIndex(t *testing.T) { api.ForTesting_ReferencesAllowBlankSelfLinks = true o := testclient.NewObjects(api.Scheme, api.Scheme) if err := testclient.AddObjectsFromPath(\"../../examples/persistent-volumes/claims/claim-01.yaml\", o, api.Scheme); err != nil { t.Fatal(err) } if err := testclient.AddObjectsFromPath(\"../../examples/persistent-volumes/volumes/local-01.yaml\", o, api.Scheme); err != nil { t.Fatal(err) } client := &testclient.Fake{ReactFn: testclient.ObjectReaction(o, latest.RESTMapper)} pv, err := client.PersistentVolumes().Get(\"any\") if err != nil { t.Error(\"Unexpected error getting PV from client: %v\", err) } claim, error := client.PersistentVolumeClaims(\"ns\").Get(\"any\") if error != nil { t.Errorf(\"Unexpected error getting PVC from client: %v\", err) } volumeIndex := NewPersistentVolumeOrderedIndex() mockClient := &mockBinderClient{ volume: pv, claim:  claim, } // the default value of the PV is Pending. // if has previously been processed by the binder, it's status in etcd would be Available. // Only Pending volumes were being indexed and made ready for claims. pv.Status.Phase = api.VolumeAvailable // adds the volume to the index, making the volume available syncVolume(volumeIndex, mockClient, pv) if pv.Status.Phase != api.VolumeAvailable { t.Errorf(\"Expected phase %s but got %s\", api.VolumeBound, pv.Status.Phase) } // an initial sync for a claim will bind it to an unbound volume, triggers state change err = syncClaim(volumeIndex, mockClient, claim) if err != nil { t.Fatalf(\"Expected Clam to be bound, instead got an error: %+vn\", err) } // state change causes another syncClaim to update statuses syncClaim(volumeIndex, mockClient, claim) // claim updated volume's status, causing an update and syncVolume call syncVolume(volumeIndex, mockClient, pv) if pv.Spec.ClaimRef == nil { t.Errorf(\"Expected ClaimRef but got nil for pv.Status.ClaimRef: %+vn\", pv) } if pv.Status.Phase != api.VolumeBound { t.Errorf(\"Expected phase %s but got %s\", api.VolumeBound, pv.Status.Phase) } if claim.Status.Phase != api.ClaimBound { t.Errorf(\"Expected phase %s but got %s\", api.ClaimBound, claim.Status.Phase) } if len(claim.Status.AccessModes) != len(pv.Spec.AccessModes) { t.Errorf(\"Expected phase %s but got %s\", api.ClaimBound, claim.Status.Phase) } if claim.Status.AccessModes[0] != pv.Spec.AccessModes[0] { t.Errorf(\"Expected access mode %s but got %s\", claim.Status.AccessModes[0], pv.Spec.AccessModes[0]) } // pretend the user deleted their claim mockClient.claim = nil syncVolume(volumeIndex, mockClient, pv) if pv.Status.Phase != api.VolumeReleased { t.Errorf(\"Expected phase %s but got %s\", api.VolumeReleased, pv.Status.Phase) } } </ins> type mockBinderClient struct { volume *api.PersistentVolume claim  *api.PersistentVolumeClaim", "commid": "kubernetes_pr_9282"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a52b59c7d2fad26006f4e403c6ccd7d769148b1428731cb4cfa9b4cdf94eb1c4", "query": "The \"\" E2E test will sometimes fail because it fails to delete the PD used in the test after the test is finished. The error: Detailed test log: The disk that fails to delete still shows up in : My attempts to manually try to delete the PD fail with: (the work around for ) doesn't change anything here:\nis the disk still mounted ? It looks like the detach call did not succeed for some reason\nI'll have to get another repro and verify.\nokay cool. If you get a repro check to see if the disk is still mounted. If so then the cleanup code is not being called. If not then the clean up started, detach was called but failed for some reason; look in the logs for something like \"googleapi: some error about detaching\". It can also just be a race condition. That is, detach was called but is taking too long; if the disk does not detach then you cannot delete it.", "positive_passages": [{"docid": "doc-en-kubernetes-c525715b0238f5e5f4f523c2822e7128591ff26a4699b7f0b4ff011c4034daa1", "text": "<ins> /* Copyright 2015 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package operationmanager import ( \"fmt\" \"sync\" ) // Operation Manager is a thread-safe interface for keeping track of multiple pending async operations. type OperationManager interface { // Called when the operation with the given ID has started. // Creates a new channel with specified buffer size tracked with the specified ID. // Returns a read-only version of the newly created channel. // Returns an error if an entry with the specified ID already exists (previous entry must be removed by calling Close). Start(id string, bufferSize uint) (<-chan interface{}, error) // Called when the operation with the given ID has terminated. // Closes and removes the channel associated with ID. // Returns an error if no associated channel exists. Close(id string) error // Attempts to send msg to the channel associated with ID. // Returns an error if no associated channel exists. Send(id string, msg interface{}) error } // Returns a new instance of a channel manager. func NewOperationManager() OperationManager { return &operationManager{ chanMap: make(map[string]chan interface{}), } } type operationManager struct { sync.RWMutex chanMap map[string]chan interface{} } // Called when the operation with the given ID has started. // Creates a new channel with specified buffer size tracked with the specified ID. // Returns a read-only version of the newly created channel. // Returns an error if an entry with the specified ID already exists (previous entry must be removed by calling Close). func (cm *operationManager) Start(id string, bufferSize uint) (<-chan interface{}, error) { cm.Lock() defer cm.Unlock() if _, exists := cm.chanMap[id]; exists { return nil, fmt.Errorf(\"id %q already exists\", id) } cm.chanMap[id] = make(chan interface{}, bufferSize) return cm.chanMap[id], nil } // Called when the operation with the given ID has terminated. // Closes and removes the channel associated with ID. // Returns an error if no associated channel exists. func (cm *operationManager) Close(id string) error { cm.Lock() defer cm.Unlock() if _, exists := cm.chanMap[id]; !exists { return fmt.Errorf(\"id %q not found\", id) } close(cm.chanMap[id]) delete(cm.chanMap, id) return nil } // Attempts to send msg to the channel associated with ID. // Returns an error if no associated channel exists. func (cm *operationManager) Send(id string, msg interface{}) error { cm.RLock() defer cm.RUnlock() if _, exists := cm.chanMap[id]; !exists { return fmt.Errorf(\"id %q not found\", id) } cm.chanMap[id] <- msg return nil } </ins>", "commid": "kubernetes_pr_10169"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a52b59c7d2fad26006f4e403c6ccd7d769148b1428731cb4cfa9b4cdf94eb1c4", "query": "The \"\" E2E test will sometimes fail because it fails to delete the PD used in the test after the test is finished. The error: Detailed test log: The disk that fails to delete still shows up in : My attempts to manually try to delete the PD fail with: (the work around for ) doesn't change anything here:\nis the disk still mounted ? It looks like the detach call did not succeed for some reason\nI'll have to get another repro and verify.\nokay cool. If you get a repro check to see if the disk is still mounted. If so then the cleanup code is not being called. If not then the clean up started, detach was called but failed for some reason; look in the logs for something like \"googleapi: some error about detaching\". It can also just be a race condition. That is, detach was called but is taking too long; if the disk does not detach then you cannot delete it.", "positive_passages": [{"docid": "doc-en-kubernetes-a4a883cf3b183ce3156589275caf96982d8119e388734cc9eceb23949671d1d2", "text": "<ins> /* Copyright 2015 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ // Channel Manager keeps track of multiple channels package operationmanager import ( \"testing\" ) func TestStart(t *testing.T) { // Arrange cm := NewOperationManager() chanId := \"testChanId\" testMsg := \"test message\" // Act ch, startErr := cm.Start(chanId, 1 /* bufferSize */) sigErr := cm.Send(chanId, testMsg) // Assert if startErr != nil { t.Fatalf(\"Unexpected error on Start. Expected: <no error> Actual: <%v>\", startErr) } if sigErr != nil { t.Fatalf(\"Unexpected error on Send. Expected: <no error> Actual: <%v>\", sigErr) } if actual := <-ch; actual != testMsg { t.Fatalf(\"Unexpected testMsg value. Expected: <%v> Actual: <%v>\", testMsg, actual) } } func TestStartIdExists(t *testing.T) { // Arrange cm := NewOperationManager() chanId := \"testChanId\" // Act _, startErr1 := cm.Start(chanId, 1 /* bufferSize */) _, startErr2 := cm.Start(chanId, 1 /* bufferSize */) // Assert if startErr1 != nil { t.Fatalf(\"Unexpected error on Start1. Expected: <no error> Actual: <%v>\", startErr1) } if startErr2 == nil { t.Fatalf(\"Expected error on Start2. Expected: <id already exists error> Actual: <no error>\") } } func TestStartAndAdd2Chans(t *testing.T) { // Arrange cm := NewOperationManager() chanId1 := \"testChanId1\" chanId2 := \"testChanId2\" testMsg1 := \"test message 1\" testMsg2 := \"test message 2\" // Act ch1, startErr1 := cm.Start(chanId1, 1 /* bufferSize */) ch2, startErr2 := cm.Start(chanId2, 1 /* bufferSize */) sigErr1 := cm.Send(chanId1, testMsg1) sigErr2 := cm.Send(chanId2, testMsg2) // Assert if startErr1 != nil { t.Fatalf(\"Unexpected error on Start1. Expected: <no error> Actual: <%v>\", startErr1) } if startErr2 != nil { t.Fatalf(\"Unexpected error on Start2. Expected: <no error> Actual: <%v>\", startErr2) } if sigErr1 != nil { t.Fatalf(\"Unexpected error on Send1. Expected: <no error> Actual: <%v>\", sigErr1) } if sigErr2 != nil { t.Fatalf(\"Unexpected error on Send2. Expected: <no error> Actual: <%v>\", sigErr2) } if actual := <-ch1; actual != testMsg1 { t.Fatalf(\"Unexpected testMsg value. Expected: <%v> Actual: <%v>\", testMsg1, actual) } if actual := <-ch2; actual != testMsg2 { t.Fatalf(\"Unexpected testMsg value. Expected: <%v> Actual: <%v>\", testMsg2, actual) } } func TestStartAndAdd2ChansAndClose(t *testing.T) { // Arrange cm := NewOperationManager() chanId1 := \"testChanId1\" chanId2 := \"testChanId2\" testMsg1 := \"test message 1\" testMsg2 := \"test message 2\" // Act ch1, startErr1 := cm.Start(chanId1, 1 /* bufferSize */) ch2, startErr2 := cm.Start(chanId2, 1 /* bufferSize */) sigErr1 := cm.Send(chanId1, testMsg1) sigErr2 := cm.Send(chanId2, testMsg2) cm.Close(chanId1) sigErr3 := cm.Send(chanId1, testMsg1) // Assert if startErr1 != nil { t.Fatalf(\"Unexpected error on Start1. Expected: <no error> Actual: <%v>\", startErr1) } if startErr2 != nil { t.Fatalf(\"Unexpected error on Start2. Expected: <no error> Actual: <%v>\", startErr2) } if sigErr1 != nil { t.Fatalf(\"Unexpected error on Send1. Expected: <no error> Actual: <%v>\", sigErr1) } if sigErr2 != nil { t.Fatalf(\"Unexpected error on Send2. Expected: <no error> Actual: <%v>\", sigErr2) } if sigErr3 == nil { t.Fatalf(\"Expected error on Send3. Expected: <error> Actual: <no error>\", sigErr2) } if actual := <-ch1; actual != testMsg1 { t.Fatalf(\"Unexpected testMsg value. Expected: <%v> Actual: <%v>\", testMsg1, actual) } if actual := <-ch2; actual != testMsg2 { t.Fatalf(\"Unexpected testMsg value. Expected: <%v> Actual: <%v>\", testMsg2, actual) } } </ins>", "commid": "kubernetes_pr_10169"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a52b59c7d2fad26006f4e403c6ccd7d769148b1428731cb4cfa9b4cdf94eb1c4", "query": "The \"\" E2E test will sometimes fail because it fails to delete the PD used in the test after the test is finished. The error: Detailed test log: The disk that fails to delete still shows up in : My attempts to manually try to delete the PD fail with: (the work around for ) doesn't change anything here:\nis the disk still mounted ? It looks like the detach call did not succeed for some reason\nI'll have to get another repro and verify.\nokay cool. If you get a repro check to see if the disk is still mounted. If so then the cleanup code is not being called. If not then the clean up started, detach was called but failed for some reason; look in the logs for something like \"googleapi: some error about detaching\". It can also just be a race condition. That is, detach was called but is taking too long; if the disk does not detach then you cannot delete it.", "positive_passages": [{"docid": "doc-en-kubernetes-06c38035d3e3ad22def3ac553544caf143063d6448d863db6449f24ff2b9ce8f", "text": "package gce_pd import ( <del> \"errors\" </del> \"fmt\" \"os\" \"path\" <ins> \"path/filepath\" \"strings\" </ins> \"time\" \"github.com/GoogleCloudPlatform/kubernetes/pkg/cloudprovider\" \"github.com/GoogleCloudPlatform/kubernetes/pkg/cloudprovider/gce\" <ins> \"github.com/GoogleCloudPlatform/kubernetes/pkg/util\" </ins> \"github.com/GoogleCloudPlatform/kubernetes/pkg/util/exec\" \"github.com/GoogleCloudPlatform/kubernetes/pkg/util/mount\" <ins> \"github.com/GoogleCloudPlatform/kubernetes/pkg/util/operationmanager\" </ins> \"github.com/golang/glog\" ) <ins> const ( diskByIdPath         = \"/dev/disk/by-id/\" diskGooglePrefix     = \"google-\" diskScsiGooglePrefix = \"scsi-0Google_PersistentDisk_\" diskPartitionSuffix  = \"-part\" diskSDPath           = \"/dev/sd\" diskSDPattern        = \"/dev/sd*\" maxChecks            = 10 maxRetries           = 10 checkSleepDuration   = time.Second ) // Singleton operation manager for managing detach clean up go routines var detachCleanupManager = operationmanager.NewOperationManager() </ins> type GCEDiskUtil struct{} // Attaches a disk specified by a volume.GCEPersistentDisk to the current kubelet. // Mounts the disk to it's global path. <del> func (util *GCEDiskUtil) AttachAndMountDisk(pd *gcePersistentDisk, globalPDPath string) error { </del> <ins> func (diskUtil *GCEDiskUtil) AttachAndMountDisk(pd *gcePersistentDisk, globalPDPath string) error { glog.V(5).Infof(\"AttachAndMountDisk(pd, %q) where pd is %#vrn\", globalPDPath, pd) // Terminate any in progress verify detach go routines, this will block until the goroutine is ready to exit because the channel is unbuffered detachCleanupManager.Send(pd.pdName, true) sdBefore, err := filepath.Glob(diskSDPattern) if err != nil { glog.Errorf(\"Error filepath.Glob(\"%s\"): %vrn\", diskSDPattern, err) } sdBeforeSet := util.NewStringSet(sdBefore...) </ins> gce, err := cloudprovider.GetCloudProvider(\"gce\", nil) if err != nil { return err } if err := gce.(*gce_cloud.GCECloud).AttachDisk(pd.pdName, pd.readOnly); err != nil { return err } <del> devicePaths := []string{ path.Join(\"/dev/disk/by-id/\", \"google-\"+pd.pdName), path.Join(\"/dev/disk/by-id/\", \"scsi-0Google_PersistentDisk_\"+pd.pdName), } if pd.partition != \"\" { for i, path := range devicePaths { devicePaths[i] = path + \"-part\" + pd.partition } } //TODO(jonesdl) There should probably be better method than busy-waiting here. numTries := 0 devicePath := \"\" // Wait for the disk device to be created for { for _, path := range devicePaths { _, err := os.Stat(path) if err == nil { devicePath = path break } if err != nil && !os.IsNotExist(err) { return err } } if devicePath != \"\" { break } numTries++ if numTries == 10 { return errors.New(\"Could not attach disk: Timeout after 10s\") } time.Sleep(time.Second) </del> <ins> devicePath, err := verifyAttached(pd, sdBeforeSet, gce) if err != nil { return err </ins> } // Only mount the PD globally once.", "commid": "kubernetes_pr_10169"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a52b59c7d2fad26006f4e403c6ccd7d769148b1428731cb4cfa9b4cdf94eb1c4", "query": "The \"\" E2E test will sometimes fail because it fails to delete the PD used in the test after the test is finished. The error: Detailed test log: The disk that fails to delete still shows up in : My attempts to manually try to delete the PD fail with: (the work around for ) doesn't change anything here:\nis the disk still mounted ? It looks like the detach call did not succeed for some reason\nI'll have to get another repro and verify.\nokay cool. If you get a repro check to see if the disk is still mounted. If so then the cleanup code is not being called. If not then the clean up started, detach was called but failed for some reason; look in the logs for something like \"googleapi: some error about detaching\". It can also just be a race condition. That is, detach was called but is taking too long; if the disk does not detach then you cannot delete it.", "positive_passages": [{"docid": "doc-en-kubernetes-eae09b24dc0853551cbcc46d33e90c73a064d72a720c7c95fa6a7e78de906d3e", "text": "func (util *GCEDiskUtil) DetachDisk(pd *gcePersistentDisk) error { // Unmount the global PD mount, which should be the only one. globalPDPath := makeGlobalPDName(pd.plugin.host, pd.pdName) <ins> glog.V(5).Infof(\"DetachDisk(pd) where pd is %#v and the globalPDPath is %qrn\", pd, globalPDPath) // Terminate any in progress verify detach go routines, this will block until the goroutine is ready to exit because the channel is unbuffered detachCleanupManager.Send(pd.pdName, true) </ins> if err := pd.mounter.Unmount(globalPDPath); err != nil { return err }", "commid": "kubernetes_pr_10169"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a52b59c7d2fad26006f4e403c6ccd7d769148b1428731cb4cfa9b4cdf94eb1c4", "query": "The \"\" E2E test will sometimes fail because it fails to delete the PD used in the test after the test is finished. The error: Detailed test log: The disk that fails to delete still shows up in : My attempts to manually try to delete the PD fail with: (the work around for ) doesn't change anything here:\nis the disk still mounted ? It looks like the detach call did not succeed for some reason\nI'll have to get another repro and verify.\nokay cool. If you get a repro check to see if the disk is still mounted. If so then the cleanup code is not being called. If not then the clean up started, detach was called but failed for some reason; look in the logs for something like \"googleapi: some error about detaching\". It can also just be a race condition. That is, detach was called but is taking too long; if the disk does not detach then you cannot delete it.", "positive_passages": [{"docid": "doc-en-kubernetes-2fe6704755207fd584ed730e615faa8a9cb609d942f64ff07d10fb8e5fce4165", "text": "if err := gce.(*gce_cloud.GCECloud).DetachDisk(pd.pdName); err != nil { return err } <ins> // Verify disk detached, retry if needed. go verifyDetached(pd, gce) return nil } // Verifys the disk device to be created has been succesffully attached, and retries if it fails. func verifyAttached(pd *gcePersistentDisk, sdBeforeSet util.StringSet, gce cloudprovider.Interface) (string, error) { devicePaths := getDiskByIdPaths(pd) for numRetries := 0; numRetries < maxRetries; numRetries++ { for numChecks := 0; numChecks < maxChecks; numChecks++ { if err := udevadmChangeToNewDrives(sdBeforeSet); err != nil { // udevadm errors should not block disk attachment, log and continue glog.Errorf(\"%v\", err) } for _, path := range devicePaths { if pathExists, err := pathExists(path); err != nil { return \"\", err } else if pathExists { // A device path has succesfully been created for the PD glog.V(5).Infof(\"Succesfully attached GCE PD %q.\", pd.pdName) return path, nil } } // Sleep then check again glog.V(5).Infof(\"Waiting for GCE PD %q to attach.\", pd.pdName) time.Sleep(checkSleepDuration) } // Try attaching the disk again glog.Warningf(\"Timed out waiting for GCE PD %q to attach. Retrying attach.\", pd.pdName) if err := gce.(*gce_cloud.GCECloud).AttachDisk(pd.pdName, pd.readOnly); err != nil { return \"\", err } } return \"\", fmt.Errorf(\"Could not attach GCE PD %q. Timeout waiting for mount paths to be created.\", pd.pdName) } // Veify the specified persistent disk device has been succesfully detached, and retries if it fails. // This function is intended to be called asynchronously as a go routine. func verifyDetached(pd *gcePersistentDisk, gce cloudprovider.Interface) { defer util.HandleCrash() // Setting bufferSize to 0 so that when senders send, they are blocked until we recieve. This avoids the need to have a separate exit check. ch, err := detachCleanupManager.Start(pd.pdName, 0 /* bufferSize */) if err != nil { glog.Errorf(\"Error adding %q to detachCleanupManager: %v\", pd.pdName, err) return } defer detachCleanupManager.Close(pd.pdName) devicePaths := getDiskByIdPaths(pd) for numRetries := 0; numRetries < maxRetries; numRetries++ { for numChecks := 0; numChecks < maxChecks; numChecks++ { select { case <-ch: glog.Warningf(\"Terminating GCE PD %q detach verification. Another attach/detach call was made for this PD.\", pd.pdName) return default: allPathsRemoved := true for _, path := range devicePaths { if err := udevadmChangeToDrive(path); err != nil { // udevadm errors should not block disk detachment, log and continue glog.Errorf(\"%v\", err) } if exists, err := pathExists(path); err != nil { glog.Errorf(\"Error check path: %v\", err) return } else { allPathsRemoved = allPathsRemoved && !exists } } if allPathsRemoved { // All paths to the PD have been succefully removed glog.V(5).Infof(\"Succesfully detached GCE PD %q.\", pd.pdName) return } // Sleep then check again glog.V(5).Infof(\"Waiting for GCE PD %q to detach.\", pd.pdName) time.Sleep(checkSleepDuration) } } // Try detaching disk again glog.Warningf(\"Timed out waiting for GCE PD %q to detach. Retrying detach.\", pd.pdName) if err := gce.(*gce_cloud.GCECloud).DetachDisk(pd.pdName); err != nil { glog.Errorf(\"Error on retry detach PD %q: %v\", pd.pdName, err) return } } glog.Errorf(\"Could not detach GCE PD %q. One or more mount paths was not removed.\", pd.pdName) } // Returns list of all /dev/disk/by-id/* paths for given PD. func getDiskByIdPaths(pd *gcePersistentDisk) []string { devicePaths := []string{ path.Join(diskByIdPath, diskGooglePrefix+pd.pdName), path.Join(diskByIdPath, diskScsiGooglePrefix+pd.pdName), } if pd.partition != \"\" { for i, path := range devicePaths { devicePaths[i] = path + diskPartitionSuffix + pd.partition } } return devicePaths } // Checks if the specified path exists func pathExists(path string) (bool, error) { _, err := os.Stat(path) if err == nil { return true, nil } else if os.IsNotExist(err) { return false, nil } else { return false, err } } // Calls \"udevadm trigger --action=change\" for newly created \"/dev/sd*\" drives (exist only in after set). // This is workaround for Issue #7972. Once the underlying issue has been resolved, this may be removed. func udevadmChangeToNewDrives(sdBeforeSet util.StringSet) error { sdAfter, err := filepath.Glob(diskSDPattern) if err != nil { return fmt.Errorf(\"Error filepath.Glob(\"%s\"): %vrn\", diskSDPattern, err) } for _, sd := range sdAfter { if !sdBeforeSet.Has(sd) { return udevadmChangeToDrive(sd) } } return nil } // Calls \"udevadm trigger --action=change\" on the specified drive. // drivePath must be the the block device path to trigger on, in the format \"/dev/sd*\", or a symlink to it. // This is workaround for Issue #7972. Once the underlying issue has been resolved, this may be removed. func udevadmChangeToDrive(drivePath string) error { glog.V(5).Infof(\"udevadmChangeToDrive: drive=%q\", drivePath) // Evaluate symlink, if any drive, err := filepath.EvalSymlinks(drivePath) if err != nil { return fmt.Errorf(\"udevadmChangeToDrive: filepath.EvalSymlinks(%q) failed with %v.\", drivePath, err) } glog.V(5).Infof(\"udevadmChangeToDrive: symlink path is %q\", drive) // Check to make sure input is \"/dev/sd*\" if !strings.Contains(drive, diskSDPath) { return fmt.Errorf(\"udevadmChangeToDrive: expected input in the form \"%s\" but drive is %q.\", diskSDPattern, drive) } // Call \"udevadm trigger --action=change --property-match=DEVNAME=/dev/sd...\" _, err = exec.New().Command( \"udevadm\", \"trigger\", \"--action=change\", fmt.Sprintf(\"--property-match=DEVNAME=%s\", drive)).CombinedOutput() if err != nil { return fmt.Errorf(\"udevadmChangeToDrive: udevadm trigger failed for drive %q with %v.\", drive, err) } </ins> return nil }", "commid": "kubernetes_pr_10169"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a5f8a117915b8e2720ab3fe6bd6b6e9a9116553d4b98258a619803800705175", "query": "If the container_probe test runs on a node without the nginx image, it sometimes takes 90s to get the pod in running. Most of this time goes in pulling the image, so I'm assuming it's registry related hiccup. Using might make it more reliable. Example failure: Note the following event in the logs:\na) we should not be pulling from docker in our tests - too hit-or-miss b) we should replace nginx (132 MB) with (4.5 MB) whenever possible. , Prashanth B wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-02394522b4c086c8ae1fbee571a0c1ec3554c23be7b74645e7bf5c28425ad8de", "text": "var _ = Describe(\"Probing container\", func() { framework := Framework{BaseName: \"container-probe\"} var podClient client.PodInterface <del> probe := nginxProbeBuilder{} </del> <ins> probe := webserverProbeBuilder{} </ins> BeforeEach(func() { framework.beforeEach()", "commid": "kubernetes_pr_10758"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a5f8a117915b8e2720ab3fe6bd6b6e9a9116553d4b98258a619803800705175", "query": "If the container_probe test runs on a node without the nginx image, it sometimes takes 90s to get the pod in running. Most of this time goes in pulling the image, so I'm assuming it's registry related hiccup. Using might make it more reliable. Example failure: Note the following event in the logs:\na) we should not be pulling from docker in our tests - too hit-or-miss b) we should replace nginx (132 MB) with (4.5 MB) whenever possible. , Prashanth B wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-709c2e2d7d4c07c9e81c5ed03d075ca9967615f17e770dedbd88ac171d494193", "text": "expectNoError(err) startTime := time.Now() <del> expectNoError(wait.Poll(poll, 90*time.Second, func() (bool, error) { </del> <ins> Expect(wait.Poll(poll, 90*time.Second, func() (bool, error) { </ins> p, err := podClient.Get(p.Name) if err != nil { return false, err } <del> return api.IsPodReady(p), nil })) </del> <ins> ready := api.IsPodReady(p) if !ready { Logf(\"pod is not yet ready; pod has phase %q.\", p.Status.Phase) return false, nil } return true, nil })).NotTo(HaveOccurred(), \"pod never became ready\") </ins> if time.Since(startTime) < 30*time.Second { Failf(\"Pod became ready before it's initial delay\")", "commid": "kubernetes_pr_10758"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a5f8a117915b8e2720ab3fe6bd6b6e9a9116553d4b98258a619803800705175", "query": "If the container_probe test runs on a node without the nginx image, it sometimes takes 90s to get the pod in running. Most of this time goes in pulling the image, so I'm assuming it's registry related hiccup. Using might make it more reliable. Example failure: Note the following event in the logs:\na) we should not be pulling from docker in our tests - too hit-or-miss b) we should replace nginx (132 MB) with (4.5 MB) whenever possible. , Prashanth B wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-bdbd229e761a48d32c7cc732b77efd50ac5b1371ac849096c360ef4df6abce2e", "text": "isReady, err := podRunningReady(p) expectNoError(err) <del> Expect(isReady).To(BeTrue()) </del> <ins> Expect(isReady).To(BeTrue(), \"pod should be ready\") </ins> <del> Expect(getRestartCount(p) == 0).To(BeTrue()) </del> <ins> restartCount := getRestartCount(p) Expect(restartCount == 0).To(BeTrue(), \"pod should have a restart count of 0 but got %v\", restartCount) </ins> }) It(\"with readiness probe that fails should never be ready and never restart\", func() {", "commid": "kubernetes_pr_10758"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a5f8a117915b8e2720ab3fe6bd6b6e9a9116553d4b98258a619803800705175", "query": "If the container_probe test runs on a node without the nginx image, it sometimes takes 90s to get the pod in running. Most of this time goes in pulling the image, so I'm assuming it's registry related hiccup. Using might make it more reliable. Example failure: Note the following event in the logs:\na) we should not be pulling from docker in our tests - too hit-or-miss b) we should replace nginx (132 MB) with (4.5 MB) whenever possible. , Prashanth B wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-3f5411c63aee66c723080ba3a7cc71d4579cac651f48bdca6fd8fbae3a536c47", "text": "expectNoError(err) isReady, err := podRunningReady(p) <del> Expect(isReady).NotTo(BeTrue()) </del> <ins> Expect(isReady).NotTo(BeTrue(), \"pod should be not ready\") </ins> <del> Expect(getRestartCount(p) == 0).To(BeTrue()) </del> <ins> restartCount := getRestartCount(p) Expect(restartCount == 0).To(BeTrue(), \"pod should have a restart count of 0 but got %v\", restartCount) </ins> }) })", "commid": "kubernetes_pr_10758"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a5f8a117915b8e2720ab3fe6bd6b6e9a9116553d4b98258a619803800705175", "query": "If the container_probe test runs on a node without the nginx image, it sometimes takes 90s to get the pod in running. Most of this time goes in pulling the image, so I'm assuming it's registry related hiccup. Using might make it more reliable. Example failure: Note the following event in the logs:\na) we should not be pulling from docker in our tests - too hit-or-miss b) we should replace nginx (132 MB) with (4.5 MB) whenever possible. , Prashanth B wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-32f61a2f2c222e316f9166ad574f362eb0411d2a666c4ad79a9d2c7cf1e8b01f", "text": "func makePodSpec(readinessProbe, livenessProbe *api.Probe) *api.Pod { pod := &api.Pod{ <del> ObjectMeta: api.ObjectMeta{Name: \"nginx-\" + string(util.NewUUID())}, </del> <ins> ObjectMeta: api.ObjectMeta{Name: \"test-webserver-\" + string(util.NewUUID())}, </ins> Spec: api.PodSpec{ Containers: []api.Container{ { <del> Name:           \"nginx\", Image:          \"nginx\", </del> <ins> Name:           \"test-webserver\", Image:          \"gcr.io/google_containers/test-webserver\", </ins> LivenessProbe:  livenessProbe, ReadinessProbe: readinessProbe, },", "commid": "kubernetes_pr_10758"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a5f8a117915b8e2720ab3fe6bd6b6e9a9116553d4b98258a619803800705175", "query": "If the container_probe test runs on a node without the nginx image, it sometimes takes 90s to get the pod in running. Most of this time goes in pulling the image, so I'm assuming it's registry related hiccup. Using might make it more reliable. Example failure: Note the following event in the logs:\na) we should not be pulling from docker in our tests - too hit-or-miss b) we should replace nginx (132 MB) with (4.5 MB) whenever possible. , Prashanth B wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-86eff17049f2f0326241622643b4c947d261ff0eef5c6961b0dc37945723c667", "text": "return pod } <del> type nginxProbeBuilder struct { </del> <ins> type webserverProbeBuilder struct { </ins> failing      bool initialDelay bool } <del> func (b nginxProbeBuilder) withFailing() nginxProbeBuilder { </del> <ins> func (b webserverProbeBuilder) withFailing() webserverProbeBuilder { </ins> b.failing = true return b } <del> func (b nginxProbeBuilder) withInitialDelay() nginxProbeBuilder { </del> <ins> func (b webserverProbeBuilder) withInitialDelay() webserverProbeBuilder { </ins> b.initialDelay = true return b } <del> func (b nginxProbeBuilder) build() *api.Probe { </del> <ins> func (b webserverProbeBuilder) build() *api.Probe { </ins> probe := &api.Probe{ Handler: api.Handler{ HTTPGet: &api.HTTPGetAction{", "commid": "kubernetes_pr_10758"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e173b509db75d449d82cb27f028365138ce8184a0f33391f61ddb69043f21d65", "query": "I'm conducting PoC about distributed build using Kubernetes. Jenkins master distribute jenkins slave pods through Kubernetes API Server. When build is done, jenkins slave pod is also deleted by kubernetes API Server. But, kubernetes didn't delete container. (Pod is deleted well) After searching, I found kubelet\u2019s containerGC option. So, I adjusted below options to kubelet. --minimum-container-ttl-duration=0s --maximum-dead-containers=0 After adjusting both 2 options, container was deleted, too. But, kubernetes containerGC didn\u2019t delete host volume path. (/var/lib/docker/vfs/dir/..) Due to aufs\u2019s low performance, I used data volume of host instead of container inside. So, data volume was accumulated and host's inodes was fulled, too. Is there any solution to clean the containers wreckage? My environment was.. Docker: v1.6.2 Kubernetes: v0.18.2 (container based multi clustering)\nare you using the host volumes you created yourself? If this is the case, kubelet does not clean the volumes since they are external to kubelet. If not, kubelet should clean the volumes before container GC kicks in.\nNo.. volumes were created by kubenetes API server. LGTM. Will it be adjusted next release?\nYou said \"I used data volume of host instead of container inside\" which says you used a hostPath mount - correct? That is explicitly NOT managed by kubernetes - you've gone to the host, you get to manage it. But you also said \"Due to aufs\u2019s low performance\" - an emptyDir volume is NOT stored on aufs, but it IS managed with the pod. , gghonor wrote:\nThe issue as i understand it is dangling volumes, that is volumes that are created via a VOLUME directive in Dockerfile with no corresponding kubernetes volume in spec which therefore has no host path & is not cleaned up by the kubelet. These volumes reside in /var/lib/docker/vfs/. This waste of disk space has the potential to cause out of space errors on the node & therefore make the node unstable.\nAs the volume dir you mentioned is I assume you didn't specify any volume in your Kubernetes pod spec but did use the directive in your Dockerfile? As mentions I guess this isn't a Kubernetes managed volume as that would be in the Kubernetes volume dir, right? That dir is used by Docker for volumes specified in Dockerfiles or a docker container that is run with with no specified host path. The latter doesn't happen with Kubernetes managed containers AFAIK.\nThis makes sense. Thanks for the explanation :) I see the point of removing the dangling volumes. Even though kubelet doesn't manage those volumes, it doesn't hurt to remove them.\nDo we have a full understanding of their lifetime, though? We don't control them, I don't see how we can know when to delete them. Docker's volume implementation is just too under-defined to actually be useful. , Yu-Ju Hong wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-2af6a3a28337c77b2015a7dc3e4e63318a903b941f29da457b8d0ee76ae23e03", "text": "// Remove unidentified containers. for _, container := range unidentifiedContainers { glog.Infof(\"Removing unidentified dead container %q with ID %q\", container.name, container.id) <del> err = cgc.dockerClient.RemoveContainer(docker.RemoveContainerOptions{ID: container.id}) </del> <ins> err = cgc.dockerClient.RemoveContainer(docker.RemoveContainerOptions{ID: container.id, RemoveVolumes: true}) </ins> if err != nil { glog.Warningf(\"Failed to remove unidentified dead container %q: %v\", container.name, err) }", "commid": "kubernetes_pr_10821"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e173b509db75d449d82cb27f028365138ce8184a0f33391f61ddb69043f21d65", "query": "I'm conducting PoC about distributed build using Kubernetes. Jenkins master distribute jenkins slave pods through Kubernetes API Server. When build is done, jenkins slave pod is also deleted by kubernetes API Server. But, kubernetes didn't delete container. (Pod is deleted well) After searching, I found kubelet\u2019s containerGC option. So, I adjusted below options to kubelet. --minimum-container-ttl-duration=0s --maximum-dead-containers=0 After adjusting both 2 options, container was deleted, too. But, kubernetes containerGC didn\u2019t delete host volume path. (/var/lib/docker/vfs/dir/..) Due to aufs\u2019s low performance, I used data volume of host instead of container inside. So, data volume was accumulated and host's inodes was fulled, too. Is there any solution to clean the containers wreckage? My environment was.. Docker: v1.6.2 Kubernetes: v0.18.2 (container based multi clustering)\nare you using the host volumes you created yourself? If this is the case, kubelet does not clean the volumes since they are external to kubelet. If not, kubelet should clean the volumes before container GC kicks in.\nNo.. volumes were created by kubenetes API server. LGTM. Will it be adjusted next release?\nYou said \"I used data volume of host instead of container inside\" which says you used a hostPath mount - correct? That is explicitly NOT managed by kubernetes - you've gone to the host, you get to manage it. But you also said \"Due to aufs\u2019s low performance\" - an emptyDir volume is NOT stored on aufs, but it IS managed with the pod. , gghonor wrote:\nThe issue as i understand it is dangling volumes, that is volumes that are created via a VOLUME directive in Dockerfile with no corresponding kubernetes volume in spec which therefore has no host path & is not cleaned up by the kubelet. These volumes reside in /var/lib/docker/vfs/. This waste of disk space has the potential to cause out of space errors on the node & therefore make the node unstable.\nAs the volume dir you mentioned is I assume you didn't specify any volume in your Kubernetes pod spec but did use the directive in your Dockerfile? As mentions I guess this isn't a Kubernetes managed volume as that would be in the Kubernetes volume dir, right? That dir is used by Docker for volumes specified in Dockerfiles or a docker container that is run with with no specified host path. The latter doesn't happen with Kubernetes managed containers AFAIK.\nThis makes sense. Thanks for the explanation :) I see the point of removing the dangling volumes. Even though kubelet doesn't manage those volumes, it doesn't hurt to remove them.\nDo we have a full understanding of their lifetime, though? We don't control them, I don't see how we can know when to delete them. Docker's volume implementation is just too under-defined to actually be useful. , Yu-Ju Hong wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-a7bbe657281ccfb73f86bf819ae876fbfa00a9554e6de8a8edde6299c9159ad8", "text": "// Remove from oldest to newest (last to first). numToKeep := len(containers) - toRemove for i := numToKeep; i < len(containers); i++ { <del> err := cgc.dockerClient.RemoveContainer(docker.RemoveContainerOptions{ID: containers[i].id}) </del> <ins> err := cgc.dockerClient.RemoveContainer(docker.RemoveContainerOptions{ID: containers[i].id, RemoveVolumes: true}) </ins> if err != nil { glog.Warningf(\"Failed to remove dead container %q: %v\", containers[i].name, err) }", "commid": "kubernetes_pr_10821"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5e141256b52005c28fd1b24c7f05dfac8f617bee1bc04c7a011b4ab9fa62a6c6", "query": "The file: has instructions for AWS, GCE, and VMware. I'd like to see documentation for OpenStack as well. I'd be happy to do the work for this as I don't think it would take too much time. I'll add some instructions to this issue if its something that people think would be helpful.\nI would greatly appreciate any work you can do with this. I've been trying, unsuccessfully, to get the OpenStack integration working.\nOk, I created instructions in this gist: If it looks good to you I'll create a pull request and merge changes in the document after the GCE section (as it appears we're going in Alphabetical order? )\nSending a PR sounds good.", "positive_passages": [{"docid": "doc-en-kubernetes-95dd5f33db85c896c5e60ea2b5b219565cd75e89bd3e2b2246ffdcfa2ef6db7f", "text": "In one terminal, run `gcloud compute ssh master --ssh-flag=\"-L 8080:127.0.0.1:8080\"` and in a second run `gcloud compute ssh master --ssh-flag=\"-R 8080:127.0.0.1:8080\"`. <ins> ### OpenStack These instructions are for running on the command line.  Most of this you can also do through the Horizon dashboard. These instructions were tested on the Ice House release on a Metacloud distribution of OpenStack but should be similar if not the same across other versions/distributions of OpenStack. #### Make sure you can connect with OpenStack Make sure the environment variables are set for OpenStack such as: ```sh OS_TENANT_ID OS_PASSWORD OS_AUTH_URL OS_USERNAME OS_TENANT_NAME ``` Test this works with something like: ``` nova list ``` #### Get a Suitable CoreOS Image You'll need a [suitable version of CoreOS image for OpenStack] (https://coreos.com/os/docs/latest/booting-on-openstack.html) Once you download that, upload it to glance.  An example is shown below: ```sh glance image-create --name CoreOS723  --container-format bare --disk-format qcow2  --file coreos_production_openstack_image.img  --is-public True ``` #### Create security group ```sh nova secgroup-create kubernetes \"Kubernetes Security Group\" nova secgroup-add-rule kubernetes tcp 22 22   0.0.0.0/0 nova secgroup-add-rule kubernetes tcp 80 80   0.0.0.0/0 ``` #### Provision the Master ```sh nova boot  --image <image_name>  --key-name <my_key>  --flavor <flavor id>  --security-group kubernetes  --user-data files/master.yaml  kube-master ``` ```<image_name>``` is the CoreOS image name.  In our example we can use the image we created in the previous step and put in 'CoreOS723' ```<my_key>``` is the keypair name that you already generated to access the instance. ```<flavor_id>``` is the flavor ID you use to size the instance.  Run ```nova flavor-list``` to get the IDs.  3 on the system this was tested with gives the m1.large size. The important part is to ensure you have the files/master.yml as this is what will do all the post boot configuration. This path is relevant so we are assuming in this example that you are running the nova command in a directory where there is a subdirectory called files that has the master.yml file in it.  Absolute paths also work. Next, assign it a public IP address: ``` nova floating-ip-list ``` Get an IP address that's free and run: ``` nova floating-ip-associate kube-master <ip address> ``` where ```<ip address>``` is the IP address that was available from the ```nova floating-ip-list``` command. #### Provision Worker Nodes Edit ```node.yaml``` and replace all instances of ```<master-private-ip>``` with the private IP address of the master node.  You can get this by runnning ```nova show kube-master``` assuming you named your instance kube master.  This is not the floating IP address you just assigned it. ```sh nova boot  --image <image_name>  --key-name <my_key>  --flavor <flavor id>  --security-group kubernetes  --user-data files/node.yaml  minion01 ``` This is basically the same as the master nodes but with the node.yaml post-boot script instead of the master. </ins> ### VMware Fusion #### Create the master config-drive", "commid": "kubernetes_pr_12656"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0899495702d6e9ebf67f2fa89ae62937548eeddaa12f77ce123a9a812c22bf72", "query": "If is passed to the kubelet, container metrics are not included in the Prometheus metrics endpoint.", "positive_passages": [{"docid": "doc-en-kubernetes-bff761ca084cc59b8560d6888874fcb466797d1e3d96658bcf5f6917aa08cebd", "text": "Manager: m, } <del> // Export the HTTP endpoint if a port was specified. if port > 0 { err = cadvisorClient.exportHTTP(port) if err != nil { return nil, err } </del> <ins> err = cadvisorClient.exportHTTP(port) if err != nil { return nil, err </ins> } return cadvisorClient, nil }", "commid": "kubernetes_pr_13202"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0899495702d6e9ebf67f2fa89ae62937548eeddaa12f77ce123a9a812c22bf72", "query": "If is passed to the kubelet, container metrics are not included in the Prometheus metrics endpoint.", "positive_passages": [{"docid": "doc-en-kubernetes-bef7a0a0b9d6383f980516f985adc985a60d2fc3003a029bc2b4894f4315115d", "text": "} func (cc *cadvisorClient) exportHTTP(port uint) error { <ins> // Register the handlers regardless as this registers the prometheus // collector properly. </ins> mux := http.NewServeMux() err := cadvisorHttp.RegisterHandlers(mux, cc, \"\", \"\", \"\", \"\", \"/metrics\") if err != nil { return err } <del> serv := &http.Server{ Addr:    fmt.Sprintf(\":%d\", port), Handler: mux, } // TODO(vmarmol): Remove this when the cAdvisor port is once again free. // If export failed, retry in the background until we are able to bind. // This allows an existing cAdvisor to be killed before this one registers. go func() { defer util.HandleCrash() err := serv.ListenAndServe() for err != nil { glog.Infof(\"Failed to register cAdvisor on port %d, retrying. Error: %v\", port, err) time.Sleep(time.Minute) err = serv.ListenAndServe() </del> <ins> // Only start the http server if port > 0 if port > 0 { serv := &http.Server{ Addr:    fmt.Sprintf(\":%d\", port), Handler: mux, </ins> } <del> }() </del> <ins> // TODO(vmarmol): Remove this when the cAdvisor port is once again free. // If export failed, retry in the background until we are able to bind. // This allows an existing cAdvisor to be killed before this one registers. go func() { defer util.HandleCrash() err := serv.ListenAndServe() for err != nil { glog.Infof(\"Failed to register cAdvisor on port %d, retrying. Error: %v\", port, err) time.Sleep(time.Minute) err = serv.ListenAndServe() } }() } </ins> return nil }", "commid": "kubernetes_pr_13202"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0f36d617029b75ecdfb03cc044087fba40537f8a434f7633b301501da951ce4d", "query": "The first line logged from the integration test is the last line from the service account token test is then the test panics with: I think the tests are just running too close the the timeout. On successful runs, the tests take ~115 seconds, which is ridiculously close to the threshold. For example: see\nok, do you want to send a PR to increase the timeout to 3 or 4 minutes?\nSure, I can do that tonight", "positive_passages": [{"docid": "doc-en-kubernetes-b041b68e4ba1cfd8eaaf694db2f71f1cfa035aa7d484f0061a53a9be00b03e82", "text": "# KUBE_TEST_API_VERSIONS=${KUBE_TEST_API_VERSIONS:-\"v1,experimental/v1alpha1\"} KUBE_TEST_API_VERSIONS=${KUBE_TEST_API_VERSIONS:-\"v1,experimental/v1alpha1\"} <ins> # Give integration tests longer to run KUBE_TIMEOUT=${KUBE_TIMEOUT:--timeout 240s} </ins> KUBE_INTEGRATION_TEST_MAX_CONCURRENCY=${KUBE_INTEGRATION_TEST_MAX_CONCURRENCY:-\"-1\"} LOG_LEVEL=${LOG_LEVEL:-2}", "commid": "kubernetes_pr_14600"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0f36d617029b75ecdfb03cc044087fba40537f8a434f7633b301501da951ce4d", "query": "The first line logged from the integration test is the last line from the service account token test is then the test panics with: I think the tests are just running too close the the timeout. On successful runs, the tests take ~115 seconds, which is ridiculously close to the threshold. For example: see\nok, do you want to send a PR to increase the timeout to 3 or 4 minutes?\nSure, I can do that tonight", "positive_passages": [{"docid": "doc-en-kubernetes-8afe28bf0b2780d4439e6534f1cb824e93ac12596263051dbe57d53365747e98", "text": "# KUBE_RACE=\"-race\" KUBE_GOFLAGS=\"-tags 'integration no-docker' \"  KUBE_RACE=\"\"  <ins> KUBE_TIMEOUT=\"${KUBE_TIMEOUT}\"  </ins> KUBE_TEST_API_VERSIONS=\"$1\"  KUBE_API_VERSIONS=\"v1,experimental/v1alpha1\"  \"${KUBE_ROOT}/hack/test-go.sh\" test/integration", "commid": "kubernetes_pr_14600"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ae486ffe03a734aa443d42b073f2c6b23bd4d201c949d5702210dc739a9b466f", "query": "Nodes Network when a minion node becomes unreachable [replication controller] recreates pods scheduled on the unreachable minion node AND allows scheduling of pods on a minion after it rejoins the cluster(Failed 17 times in the last 30 runs. Stability: 43 %)Failed with 0 retries\nfor triage\nI'll look into this.\nI talked to about this and he had a pretty good guess in about two seconds about what the problem is. ReplicationController sync method does this: but DaemonSet controller doesn't. (I guess when DaemonSet was copy-pasted from ReplicationController, this was accidentally removed.) Pod reflector and syncer are running in separate goroutines, and if pod reflector doesn't run then syncer will think there are no pods on the node.\nTo be clear: this is about the test Controller Manager should not create/delete replicas across restart which is the one that is actually failing.\nI'm confused you're saying that this is about , but you're updating . I thought they are about two different tests...\nYes sorry, I put my comment in the wrong issue. Reassigning this one to you, and I'll copy my comment into the other one.\nFirst failure: We check if all namespace are deleted. If other tests failed to delete their namespace this test will fail. I'm going to delete this logic as we already check if we have successfully deleted our namespace. See also for some more details.\nSecond failure: We disable network by running the following command: I checked and it seems that it results in ing master to hang. I suspect that Kubelet hangs on updating node status and depending when it breaks the connection (by timeout) it will fit in test timeouts or not.\nWhat is the default timeout for connections using client libraries to apiserver? I'm checking the code, but can't find it.\nI'm not sure if we set one, but we should. I guess I would expect to see that in the config, w/ default set by this function: , Filip Grzadkowski wrote:\nSo: let's add a timeout, and revert .\nI think that adding a timeout and reverting are orthogonal. I we want to simulate network problems with node-master communication then using REJECT is better anyway. At the same time adding timeout makes sense for many other reasons.\nOK then, let's add a timeout and test both DROP and REJECT-- no sort of network problem should hang a component.\nI think it didn't hang. It just that the kubelet was retrying too slow and sometimes it fit test timeout, sometime it didn't.\nCould we reduce the timeout to make it always fit the test timeout? , Filip Grzadkowski\nI guess we can. I'll try tomorrow.\nIt seems we have a new type of failure: It seems that kubelet on a machine where network is blocked doesn't notice new pod. After reading logs I assume that kubelet doesn't notice that the watch is broken and doesn't try to relist everything. It notices new pod only after watch timeout.\nUgh, I hope we don't have to start sending watch heartbeats.\nIt seems that all recent failures are with the following error: which means the reason is here: - can you please take a look or delegate?\nI did some more debugging of it. I was looking into this failure: There is something strange happening here: run performTemporaryNetworkFailure: succesfully block the load from kubelet: the succesfully wait for node to become not ready: some time nodecontroller successfully removes the pod: replication controller creates a new pod: here is something I don't undertand - because of some reason, the test doesn't observe that the pod actually disappeared. - any thoughts on it?\nBTW - this is exactly the same situation in:\nOK - I think this is related to default 30s deletion grace period.\nYes - it seems that this is exactly the case. I will send out PR fixing this out for review.\nI'm reopening it for tracking. If there won't be any failures within next few days - I will move the test back from flaky and close this issue.\nThanks for fixing, .\nIt seems that the main issue is fixed. However, there was one failure in the last 30 runs: in which one pod simply didn't started (and it was \"preparation\" for the test, not the test itself).\nDuring next 2 days there was exactly one more failure of this test: it is exactly the same as the previous one. However, those are duplicates of So I'm going to move this test out of flaky suite.", "positive_passages": [{"docid": "doc-en-kubernetes-935a80e9380fb718b6022ed1a33deb275424039d5d4580430665f5fad71fa4a9", "text": "func rcByNameContainer(name string, replicas int, image string, labels map[string]string, c api.Container) *api.ReplicationController { // Add \"name\": name to the labels, overwriting if it exists. labels[\"name\"] = name <ins> gracePeriod := int64(0) </ins> return &api.ReplicationController{ TypeMeta: unversioned.TypeMeta{ Kind:       \"ReplicationController\",", "commid": "kubernetes_pr_17939"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ae486ffe03a734aa443d42b073f2c6b23bd4d201c949d5702210dc739a9b466f", "query": "Nodes Network when a minion node becomes unreachable [replication controller] recreates pods scheduled on the unreachable minion node AND allows scheduling of pods on a minion after it rejoins the cluster(Failed 17 times in the last 30 runs. Stability: 43 %)Failed with 0 retries\nfor triage\nI'll look into this.\nI talked to about this and he had a pretty good guess in about two seconds about what the problem is. ReplicationController sync method does this: but DaemonSet controller doesn't. (I guess when DaemonSet was copy-pasted from ReplicationController, this was accidentally removed.) Pod reflector and syncer are running in separate goroutines, and if pod reflector doesn't run then syncer will think there are no pods on the node.\nTo be clear: this is about the test Controller Manager should not create/delete replicas across restart which is the one that is actually failing.\nI'm confused you're saying that this is about , but you're updating . I thought they are about two different tests...\nYes sorry, I put my comment in the wrong issue. Reassigning this one to you, and I'll copy my comment into the other one.\nFirst failure: We check if all namespace are deleted. If other tests failed to delete their namespace this test will fail. I'm going to delete this logic as we already check if we have successfully deleted our namespace. See also for some more details.\nSecond failure: We disable network by running the following command: I checked and it seems that it results in ing master to hang. I suspect that Kubelet hangs on updating node status and depending when it breaks the connection (by timeout) it will fit in test timeouts or not.\nWhat is the default timeout for connections using client libraries to apiserver? I'm checking the code, but can't find it.\nI'm not sure if we set one, but we should. I guess I would expect to see that in the config, w/ default set by this function: , Filip Grzadkowski wrote:\nSo: let's add a timeout, and revert .\nI think that adding a timeout and reverting are orthogonal. I we want to simulate network problems with node-master communication then using REJECT is better anyway. At the same time adding timeout makes sense for many other reasons.\nOK then, let's add a timeout and test both DROP and REJECT-- no sort of network problem should hang a component.\nI think it didn't hang. It just that the kubelet was retrying too slow and sometimes it fit test timeout, sometime it didn't.\nCould we reduce the timeout to make it always fit the test timeout? , Filip Grzadkowski\nI guess we can. I'll try tomorrow.\nIt seems we have a new type of failure: It seems that kubelet on a machine where network is blocked doesn't notice new pod. After reading logs I assume that kubelet doesn't notice that the watch is broken and doesn't try to relist everything. It notices new pod only after watch timeout.\nUgh, I hope we don't have to start sending watch heartbeats.\nIt seems that all recent failures are with the following error: which means the reason is here: - can you please take a look or delegate?\nI did some more debugging of it. I was looking into this failure: There is something strange happening here: run performTemporaryNetworkFailure: succesfully block the load from kubelet: the succesfully wait for node to become not ready: some time nodecontroller successfully removes the pod: replication controller creates a new pod: here is something I don't undertand - because of some reason, the test doesn't observe that the pod actually disappeared. - any thoughts on it?\nBTW - this is exactly the same situation in:\nOK - I think this is related to default 30s deletion grace period.\nYes - it seems that this is exactly the case. I will send out PR fixing this out for review.\nI'm reopening it for tracking. If there won't be any failures within next few days - I will move the test back from flaky and close this issue.\nThanks for fixing, .\nIt seems that the main issue is fixed. However, there was one failure in the last 30 runs: in which one pod simply didn't started (and it was \"preparation\" for the test, not the test itself).\nDuring next 2 days there was exactly one more failure of this test: it is exactly the same as the previous one. However, those are duplicates of So I'm going to move this test out of flaky suite.", "positive_passages": [{"docid": "doc-en-kubernetes-e136b371e0079de48de6de26778afff56dd84dd7b1fb7223abd1eaab28d4c4ee", "text": "Labels: labels, }, Spec: api.PodSpec{ <del> Containers: []api.Container{c}, </del> <ins> Containers:                    []api.Container{c}, TerminationGracePeriodSeconds: &gracePeriod, </ins> }, }, },", "commid": "kubernetes_pr_17939"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ae486ffe03a734aa443d42b073f2c6b23bd4d201c949d5702210dc739a9b466f", "query": "Nodes Network when a minion node becomes unreachable [replication controller] recreates pods scheduled on the unreachable minion node AND allows scheduling of pods on a minion after it rejoins the cluster(Failed 17 times in the last 30 runs. Stability: 43 %)Failed with 0 retries\nfor triage\nI'll look into this.\nI talked to about this and he had a pretty good guess in about two seconds about what the problem is. ReplicationController sync method does this: but DaemonSet controller doesn't. (I guess when DaemonSet was copy-pasted from ReplicationController, this was accidentally removed.) Pod reflector and syncer are running in separate goroutines, and if pod reflector doesn't run then syncer will think there are no pods on the node.\nTo be clear: this is about the test Controller Manager should not create/delete replicas across restart which is the one that is actually failing.\nI'm confused you're saying that this is about , but you're updating . I thought they are about two different tests...\nYes sorry, I put my comment in the wrong issue. Reassigning this one to you, and I'll copy my comment into the other one.\nFirst failure: We check if all namespace are deleted. If other tests failed to delete their namespace this test will fail. I'm going to delete this logic as we already check if we have successfully deleted our namespace. See also for some more details.\nSecond failure: We disable network by running the following command: I checked and it seems that it results in ing master to hang. I suspect that Kubelet hangs on updating node status and depending when it breaks the connection (by timeout) it will fit in test timeouts or not.\nWhat is the default timeout for connections using client libraries to apiserver? I'm checking the code, but can't find it.\nI'm not sure if we set one, but we should. I guess I would expect to see that in the config, w/ default set by this function: , Filip Grzadkowski wrote:\nSo: let's add a timeout, and revert .\nI think that adding a timeout and reverting are orthogonal. I we want to simulate network problems with node-master communication then using REJECT is better anyway. At the same time adding timeout makes sense for many other reasons.\nOK then, let's add a timeout and test both DROP and REJECT-- no sort of network problem should hang a component.\nI think it didn't hang. It just that the kubelet was retrying too slow and sometimes it fit test timeout, sometime it didn't.\nCould we reduce the timeout to make it always fit the test timeout? , Filip Grzadkowski\nI guess we can. I'll try tomorrow.\nIt seems we have a new type of failure: It seems that kubelet on a machine where network is blocked doesn't notice new pod. After reading logs I assume that kubelet doesn't notice that the watch is broken and doesn't try to relist everything. It notices new pod only after watch timeout.\nUgh, I hope we don't have to start sending watch heartbeats.\nIt seems that all recent failures are with the following error: which means the reason is here: - can you please take a look or delegate?\nI did some more debugging of it. I was looking into this failure: There is something strange happening here: run performTemporaryNetworkFailure: succesfully block the load from kubelet: the succesfully wait for node to become not ready: some time nodecontroller successfully removes the pod: replication controller creates a new pod: here is something I don't undertand - because of some reason, the test doesn't observe that the pod actually disappeared. - any thoughts on it?\nBTW - this is exactly the same situation in:\nOK - I think this is related to default 30s deletion grace period.\nYes - it seems that this is exactly the case. I will send out PR fixing this out for review.\nI'm reopening it for tracking. If there won't be any failures within next few days - I will move the test back from flaky and close this issue.\nThanks for fixing, .\nIt seems that the main issue is fixed. However, there was one failure in the last 30 runs: in which one pod simply didn't started (and it was \"preparation\" for the test, not the test itself).\nDuring next 2 days there was exactly one more failure of this test: it is exactly the same as the previous one. However, those are duplicates of So I'm going to move this test out of flaky suite.", "positive_passages": [{"docid": "doc-en-kubernetes-f3dfe3bbb20982c454bb6cb44b63075a1252dd5c764644ce47d62feb98b744f8", "text": "// In case of failure or too long waiting time, an error is returned. func waitForRCPodToDisappear(c *client.Client, ns, rcName, podName string) error { label := labels.SelectorFromSet(labels.Set(map[string]string{\"name\": rcName})) <del> return waitForPodToDisappear(c, ns, podName, label, 20*time.Second, 5*time.Minute) </del> <ins> // NodeController evicts pod after 5 minutes, so we need timeout greater than that. // Additionally, there can be non-zero grace period, so we are setting 10 minutes // to be on the safe size. return waitForPodToDisappear(c, ns, podName, label, 20*time.Second, 10*time.Minute) </ins> } // waitForService waits until the service appears (exist == true), or disappears (exist == false)", "commid": "kubernetes_pr_17939"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-13f89768690da6fc511a0bb03e5ffac897995a7d8142248427cada30c91df786", "query": "runs foo and then waits for it to be ready or terminated. If the pod is terminated, it prints the log, and if it's not terminated, it attaches the output. However, it does not handle the case that the pod terminates between returning the ready status and attaching, as can be the case in the : Options to fix this: Fix kubectl: If attach fails, fall back to printing the logs If attach fails, check the status again and if it's terminated, print the logs Fix the flaky test: Prevent the container from exiting (e.g. `sh -c 'echo running in container && sleep 30') Prevent the container from entering ready state (e.g. )\nThanks for debugging. I think we should probably do both: If attach fails and the container is now terminated, fall back to printing logs Make the e2e more robust by not exiting for a while to ensure time to attach. I'm happy to review PRs", "positive_passages": [{"docid": "doc-en-kubernetes-534dbc6650b34e7f5dcb8c8837ce0894e9567283c054b5aecf11e6fd4cd22f59", "text": "return fmt.Errorf(\"pod %s is not running and cannot be attached to; current phase is %s\", p.PodName, pod.Status.Phase) } <del> containerName := p.ContainerName if len(containerName) == 0 { glog.V(4).Infof(\"defaulting container name to %s\", pod.Spec.Containers[0].Name) containerName = pod.Spec.Containers[0].Name } </del> // TODO: refactor with terminal helpers from the edit utility once that is merged var stdin io.Reader tty := p.TTY", "commid": "kubernetes_pr_14764"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-13f89768690da6fc511a0bb03e5ffac897995a7d8142248427cada30c91df786", "query": "runs foo and then waits for it to be ready or terminated. If the pod is terminated, it prints the log, and if it's not terminated, it attaches the output. However, it does not handle the case that the pod terminates between returning the ready status and attaching, as can be the case in the : Options to fix this: Fix kubectl: If attach fails, fall back to printing the logs If attach fails, check the status again and if it's terminated, print the logs Fix the flaky test: Prevent the container from exiting (e.g. `sh -c 'echo running in container && sleep 30') Prevent the container from entering ready state (e.g. )\nThanks for debugging. I think we should probably do both: If attach fails and the container is now terminated, fall back to printing logs Make the e2e more robust by not exiting for a while to ensure time to attach. I'm happy to review PRs", "positive_passages": [{"docid": "doc-en-kubernetes-2f7723bd834959ab791ba457ef1fdf85602b0e568ec9a6f7c2f335a53e2e7541", "text": "Name(pod.Name). Namespace(pod.Namespace). SubResource(\"attach\"). <del> Param(\"container\", containerName) </del> <ins> Param(\"container\", p.GetContainerName(pod)) </ins> return p.Attach.Attach(req, p.Config, stdin, p.Out, p.Err, tty) } <ins> // GetContainerName returns the name of the container to attach to, with a fallback. func (p *AttachOptions) GetContainerName(pod *api.Pod) string { if len(p.ContainerName) > 0 { return p.ContainerName } glog.V(4).Infof(\"defaulting container name to %s\", pod.Spec.Containers[0].Name) return pod.Spec.Containers[0].Name } </ins>", "commid": "kubernetes_pr_14764"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-13f89768690da6fc511a0bb03e5ffac897995a7d8142248427cada30c91df786", "query": "runs foo and then waits for it to be ready or terminated. If the pod is terminated, it prints the log, and if it's not terminated, it attaches the output. However, it does not handle the case that the pod terminates between returning the ready status and attaching, as can be the case in the : Options to fix this: Fix kubectl: If attach fails, fall back to printing the logs If attach fails, check the status again and if it's terminated, print the logs Fix the flaky test: Prevent the container from exiting (e.g. `sh -c 'echo running in container && sleep 30') Prevent the container from entering ready state (e.g. )\nThanks for debugging. I think we should probably do both: If attach fails and the container is now terminated, fall back to printing logs Make the e2e more robust by not exiting for a while to ensure time to attach. I'm happy to review PRs", "positive_passages": [{"docid": "doc-en-kubernetes-fc49718a23c59eabe25086439c45ec61a9eb2decc56a14d09c817366d6e8b300", "text": "return err } if status == api.PodSucceeded || status == api.PodFailed { <del> return handleLog(c, pod.Namespace, pod.Name, &api.PodLogOptions{Container: pod.Spec.Containers[0].Name}, opts.Out) </del> <ins> return handleLog(c, pod.Namespace, pod.Name, &api.PodLogOptions{Container: opts.GetContainerName(pod)}, opts.Out) </ins> } opts.Client = c opts.PodName = pod.Name opts.Namespace = pod.Namespace <del> return opts.Run() </del> <ins> if err := opts.Run(); err != nil { fmt.Fprintf(opts.Out, \"Error attaching, falling back to logs: %vn\", err) return handleLog(c, pod.Namespace, pod.Name, &api.PodLogOptions{Container: opts.GetContainerName(pod)}, opts.Out) } return nil </ins> } func getRestartPolicy(cmd *cobra.Command, interactive bool) (api.RestartPolicy, error) {", "commid": "kubernetes_pr_14764"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9b5fe03698914c610d32064544928591f0a004f7e1f0038b0626d93de3549b78", "query": "I'm seeing a bug where the network plugin fails to configure networking, and yet the containers for this pod are still deployed (without networking configured). It looks like the following is occurring: 1) Kubelet attempts to create infra container in 2) Network plugin fails, returns error code. 3) Kubelet detects error and skips pod creation but does not tear down the infra container 4) On the next call, the kubelet detects that the infra container is running and deploys the other containers in the pod. The fix here is for the kubelet to clean up the infra container in when it receives the error from the network plugin and before it returns. Here are some logs illustrating the steps I described above:\nCleaning up infra container on network plugin error sounds reasonable/", "positive_passages": [{"docid": "doc-en-kubernetes-b05a52db897a9e88e73403c317b6c0ebdacf4b13b37357be0ae15904fc49d948", "text": "if containerChanges.StartInfraContainer && (len(containerChanges.ContainersToStart) > 0) { glog.V(4).Infof(\"Creating pod infra container for %q\", podFullName) podInfraContainerID, err = dm.createPodInfraContainer(pod) <ins> if err != nil { glog.Errorf(\"Failed to create pod infra container: %v; Skipping pod %q\", err, podFullName) return err } </ins> // Call the networking plugin <del> if err == nil { err = dm.networkPlugin.SetUpPod(pod.Namespace, pod.Name, podInfraContainerID) } </del> <ins> err = dm.networkPlugin.SetUpPod(pod.Namespace, pod.Name, podInfraContainerID) </ins> if err != nil { glog.Errorf(\"Failed to create pod infra container: %v; Skipping pod %q\", err, podFullName) <ins> // Delete infra container if delErr := dm.KillContainerInPod(kubecontainer.ContainerID{ ID:   string(podInfraContainerID), Type: \"docker\"}, nil, pod); delErr != nil { glog.Warningf(\"Clear infra container failed for pod %q: %v\", podFullName, delErr) } </ins> return err }", "commid": "kubernetes_pr_15156"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bc481a4627aea373f2de65a2d965f4d31ac5088d41d6a75d1a607aee3be72971", "query": "Unit tests on our CI have apparently been failing for 2 weeks and no one noticed (oops!)... The PR that seems to have caused the failures is . The failing test is - . Full Test Log: I'm not sure why this is failing on our CI and not on shippable. Has anyone else seen something similar? That test only seems to fail on the second run through with . Our unit tests run in a container built specifically for testing k8s-mesos: The Dockerfile for the env: Is anyone else able to repro with the above env or their own?\n/cc\nthat test was around a week ago, it's doesn't seem possible to me that it was failing since 2 weeks ago. Anyway, we have few duplications of this issue: this one And the PR where is working on: It's a little bit difficult to me to follow all the conversations in all the differente places about the same bug, could it be possible to unificate some? Since you provided the environment I will try and take a look to reproduce it locally. Thanks!\nI think I've got a working patch in\nClosing in favor of &", "positive_passages": [{"docid": "doc-en-kubernetes-d17f0d3d055e0d41a00234c8e4268df879f0dbcffebdbcd166374b528301854f", "text": "package flocker import ( <ins> \"io/ioutil\" \"os\" </ins> \"testing\" flockerClient \"github.com/ClusterHQ/flocker-go\"", "commid": "kubernetes_pr_15158"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bc481a4627aea373f2de65a2d965f4d31ac5088d41d6a75d1a607aee3be72971", "query": "Unit tests on our CI have apparently been failing for 2 weeks and no one noticed (oops!)... The PR that seems to have caused the failures is . The failing test is - . Full Test Log: I'm not sure why this is failing on our CI and not on shippable. Has anyone else seen something similar? That test only seems to fail on the second run through with . Our unit tests run in a container built specifically for testing k8s-mesos: The Dockerfile for the env: Is anyone else able to repro with the above env or their own?\n/cc\nthat test was around a week ago, it's doesn't seem possible to me that it was failing since 2 weeks ago. Anyway, we have few duplications of this issue: this one And the PR where is working on: It's a little bit difficult to me to follow all the conversations in all the differente places about the same bug, could it be possible to unificate some? Since you provided the environment I will try and take a look to reproduce it locally. Thanks!\nI think I've got a working patch in\nClosing in favor of &", "positive_passages": [{"docid": "doc-en-kubernetes-801e85fc3efb9c48ee35aa40b2866b84d45ce6d9df2ad3b730824eaeb69f888f", "text": "const pluginName = \"kubernetes.io/flocker\" <del> func newInitializedVolumePlugMgr() volume.VolumePluginMgr { </del> <ins> func newInitializedVolumePlugMgr(t *testing.T) (volume.VolumePluginMgr, string) { </ins> plugMgr := volume.VolumePluginMgr{} <del> plugMgr.InitPlugins(ProbeVolumePlugins(), volume.NewFakeVolumeHost(\"/foo/bar\", nil, nil)) return plugMgr </del> <ins> dir, err := ioutil.TempDir(\"\", \"flocker\") assert.NoError(t, err) plugMgr.InitPlugins(ProbeVolumePlugins(), volume.NewFakeVolumeHost(dir, nil, nil)) return plugMgr, dir </ins> } func TestGetByName(t *testing.T) { assert := assert.New(t) <del> plugMgr := newInitializedVolumePlugMgr() </del> <ins> plugMgr, _ := newInitializedVolumePlugMgr(t) </ins> plug, err := plugMgr.FindPluginByName(pluginName) assert.NotNil(plug, \"Can't find the plugin by name\")", "commid": "kubernetes_pr_15158"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bc481a4627aea373f2de65a2d965f4d31ac5088d41d6a75d1a607aee3be72971", "query": "Unit tests on our CI have apparently been failing for 2 weeks and no one noticed (oops!)... The PR that seems to have caused the failures is . The failing test is - . Full Test Log: I'm not sure why this is failing on our CI and not on shippable. Has anyone else seen something similar? That test only seems to fail on the second run through with . Our unit tests run in a container built specifically for testing k8s-mesos: The Dockerfile for the env: Is anyone else able to repro with the above env or their own?\n/cc\nthat test was around a week ago, it's doesn't seem possible to me that it was failing since 2 weeks ago. Anyway, we have few duplications of this issue: this one And the PR where is working on: It's a little bit difficult to me to follow all the conversations in all the differente places about the same bug, could it be possible to unificate some? Since you provided the environment I will try and take a look to reproduce it locally. Thanks!\nI think I've got a working patch in\nClosing in favor of &", "positive_passages": [{"docid": "doc-en-kubernetes-83a3639b9e979760d052c677e590a3771ee40309575c1235f6b7ffab9ddc6061", "text": "func TestCanSupport(t *testing.T) { assert := assert.New(t) <del> plugMgr := newInitializedVolumePlugMgr() </del> <ins> plugMgr, _ := newInitializedVolumePlugMgr(t) </ins> plug, err := plugMgr.FindPluginByName(pluginName) assert.NoError(err)", "commid": "kubernetes_pr_15158"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bc481a4627aea373f2de65a2d965f4d31ac5088d41d6a75d1a607aee3be72971", "query": "Unit tests on our CI have apparently been failing for 2 weeks and no one noticed (oops!)... The PR that seems to have caused the failures is . The failing test is - . Full Test Log: I'm not sure why this is failing on our CI and not on shippable. Has anyone else seen something similar? That test only seems to fail on the second run through with . Our unit tests run in a container built specifically for testing k8s-mesos: The Dockerfile for the env: Is anyone else able to repro with the above env or their own?\n/cc\nthat test was around a week ago, it's doesn't seem possible to me that it was failing since 2 weeks ago. Anyway, we have few duplications of this issue: this one And the PR where is working on: It's a little bit difficult to me to follow all the conversations in all the differente places about the same bug, could it be possible to unificate some? Since you provided the environment I will try and take a look to reproduce it locally. Thanks!\nI think I've got a working patch in\nClosing in favor of &", "positive_passages": [{"docid": "doc-en-kubernetes-c8787d0a0fa0bd3bd32ca090d61337ea76a0092dd149b706653fa0b322a80046", "text": "func TestNewBuilder(t *testing.T) { assert := assert.New(t) <del> plugMgr := newInitializedVolumePlugMgr() </del> <ins> plugMgr, _ := newInitializedVolumePlugMgr(t) </ins> plug, err := plugMgr.FindPluginByName(pluginName) assert.NoError(err)", "commid": "kubernetes_pr_15158"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bc481a4627aea373f2de65a2d965f4d31ac5088d41d6a75d1a607aee3be72971", "query": "Unit tests on our CI have apparently been failing for 2 weeks and no one noticed (oops!)... The PR that seems to have caused the failures is . The failing test is - . Full Test Log: I'm not sure why this is failing on our CI and not on shippable. Has anyone else seen something similar? That test only seems to fail on the second run through with . Our unit tests run in a container built specifically for testing k8s-mesos: The Dockerfile for the env: Is anyone else able to repro with the above env or their own?\n/cc\nthat test was around a week ago, it's doesn't seem possible to me that it was failing since 2 weeks ago. Anyway, we have few duplications of this issue: this one And the PR where is working on: It's a little bit difficult to me to follow all the conversations in all the differente places about the same bug, could it be possible to unificate some? Since you provided the environment I will try and take a look to reproduce it locally. Thanks!\nI think I've got a working patch in\nClosing in favor of &", "positive_passages": [{"docid": "doc-en-kubernetes-6acb5dd0a7f69ec89e843d0e92e60f58bf978f0ae06134cef69b79b98895a710", "text": "assert := assert.New(t) <del> plugMgr := newInitializedVolumePlugMgr() </del> <ins> plugMgr, rootDir := newInitializedVolumePlugMgr(t) if rootDir != \"\" { defer os.RemoveAll(rootDir) } </ins> plug, err := plugMgr.FindPluginByName(flockerPluginName) assert.NoError(err)", "commid": "kubernetes_pr_15158"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d8539be161cacf223528437869590f13423a31b1176c381211bcba6b79e0cca", "query": "When trying to edit multiple resources, for example: will panic. Ref as the possible cause cc\nif was the cause, any fix needs to happen in 1.1 as well, was already cherry picked there\nAlso shows that we need a test for this case.\nis the cause. When we edit multiple resources (i.e., list-type objects), the list's Accessor.annotations (type ) is nil and will panic when UpdateApplyAnnotation tries to SetAnnotations ().", "positive_passages": [{"docid": "doc-en-kubernetes-f740146422fa9d92b4512091e13b031ffaa922c4132cc8fe40f7222b881d84d0", "text": "kube::test::get_object_assert 'rc mock2' \"{{${labels_field}.status}}\" 'replaced' fi fi <ins> # Command: kubectl edit multiple resources temp_editor=\"${KUBE_TEMP}/tmp-editor.sh\" echo -e '#!/bin/bashnsed -i \"s/status: replaced/status: edited/g\" $@' > \"${temp_editor}\" chmod +x \"${temp_editor}\" EDITOR=\"${temp_editor}\" kubectl edit \"${kube_flags[@]}\" -f \"${file}\" # Post-condition: mock service (and mock2) and mock rc (and mock2) are edited if [ \"$has_svc\" = true ]; then kube::test::get_object_assert 'services mock' \"{{${labels_field}.status}}\" 'edited' if [ \"$two_svcs\" = true ]; then kube::test::get_object_assert 'services mock2' \"{{${labels_field}.status}}\" 'edited' fi fi if [ \"$has_rc\" = true ]; then kube::test::get_object_assert 'rc mock' \"{{${labels_field}.status}}\" 'edited' if [ \"$two_rcs\" = true ]; then kube::test::get_object_assert 'rc mock2' \"{{${labels_field}.status}}\" 'edited' fi fi # cleaning rm \"${temp_editor}\" </ins> # Command # We need to set --overwrite, because otherwise, if the first attempt to run \"kubectl label\" # fails on some, but not all, of the resources, retries will fail because it tries to modify", "commid": "kubernetes_pr_15980"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d8539be161cacf223528437869590f13423a31b1176c381211bcba6b79e0cca", "query": "When trying to edit multiple resources, for example: will panic. Ref as the possible cause cc\nif was the cause, any fix needs to happen in 1.1 as well, was already cherry picked there\nAlso shows that we need a test for this case.\nis the cause. When we edit multiple resources (i.e., list-type objects), the list's Accessor.annotations (type ) is nil and will panic when UpdateApplyAnnotation tries to SetAnnotations ().", "positive_passages": [{"docid": "doc-en-kubernetes-ba767ac21fd089e7575dff088c09c108566a651f3d84cd52a921a99d67c1a972", "text": "} func (a genericAccessor) SetAnnotations(annotations map[string]string) { <ins> if a.annotations == nil { emptyAnnotations := make(map[string]string) a.annotations = &emptyAnnotations } </ins> *a.annotations = annotations }", "commid": "kubernetes_pr_15980"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d8539be161cacf223528437869590f13423a31b1176c381211bcba6b79e0cca", "query": "When trying to edit multiple resources, for example: will panic. Ref as the possible cause cc\nif was the cause, any fix needs to happen in 1.1 as well, was already cherry picked there\nAlso shows that we need a test for this case.\nis the cause. When we edit multiple resources (i.e., list-type objects), the list's Accessor.annotations (type ) is nil and will panic when UpdateApplyAnnotation tries to SetAnnotations ().", "positive_passages": [{"docid": "doc-en-kubernetes-ad36e5a41968266b5d487d1b5190950091462c03fc5c10c9979416c596cba087", "text": "defaultVersion := cmdutil.OutputVersion(cmd, clientConfig.Version) results := editResults{} for { <del> obj, err := resource.AsVersionedObject(infos, false, defaultVersion) </del> <ins> objs, err := resource.AsVersionedObjects(infos, defaultVersion) </ins> if err != nil { return preservedFile(err, results.file, out) } <ins> // if input object is a list, traverse and edit each item one at a time for _, obj := range objs { // TODO: add an annotating YAML printer that can print inline comments on each field, //   including descriptions or validation errors // generate the file to edit buf := &bytes.Buffer{} if err := results.header.writeTo(buf); err != nil { return preservedFile(err, results.file, out) } if err := printer.PrintObj(obj, buf); err != nil { return preservedFile(err, results.file, out) } original := buf.Bytes() </ins> <del> // TODO: add an annotating YAML printer that can print inline comments on each field, //   including descriptions or validation errors // generate the file to edit buf := &bytes.Buffer{} if err := results.header.writeTo(buf); err != nil { return preservedFile(err, results.file, out) } if err := printer.PrintObj(obj, buf); err != nil { return preservedFile(err, results.file, out) } original := buf.Bytes() // launch the editor edit := editor.NewDefaultEditor() edited, file, err := edit.LaunchTempFile(\"kubectl-edit-\", ext, buf) if err != nil { return preservedFile(err, results.file, out) } </del> <ins> // launch the editor edit := editor.NewDefaultEditor() edited, file, err := edit.LaunchTempFile(\"kubectl-edit-\", ext, buf) if err != nil { return preservedFile(err, results.file, out) } </ins> <del> // cleanup any file from the previous pass if len(results.file) > 0 { os.Remove(results.file) } </del> <ins> // cleanup any file from the previous pass if len(results.file) > 0 { os.Remove(results.file) } </ins> <del> glog.V(4).Infof(\"User edited:n%s\", string(edited)) fmt.Printf(\"User edited:n%s\", string(edited)) lines, err := hasLines(bytes.NewBuffer(edited)) if err != nil { return preservedFile(err, file, out) } if bytes.Equal(original, edited) { if len(results.edit) > 0 { preservedFile(nil, file, out) } else { os.Remove(file) </del> <ins> glog.V(4).Infof(\"User edited:n%s\", string(edited)) lines, err := hasLines(bytes.NewBuffer(edited)) if err != nil { return preservedFile(err, file, out) </ins> } <del> fmt.Fprintln(out, \"Edit cancelled, no changes made.\") return nil } if !lines { if len(results.edit) > 0 { preservedFile(nil, file, out) } else { os.Remove(file) </del> <ins> // Compare content without comments if bytes.Equal(stripComments(original), stripComments(edited)) { if len(results.edit) > 0 { preservedFile(nil, file, out) } else { os.Remove(file) } fmt.Fprintln(out, \"Edit cancelled, no changes made.\") continue } if !lines { if len(results.edit) > 0 { preservedFile(nil, file, out) } else { os.Remove(file) } fmt.Fprintln(out, \"Edit cancelled, saved file was empty.\") continue </ins> } <del> fmt.Fprintln(out, \"Edit cancelled, saved file was empty.\") return nil } results = editResults{ file: file, } </del> <ins> results = editResults{ file: file, } </ins> <del> // parse the edited file updates, err := rmap.InfoForData(edited, \"edited-file\") if err != nil { return preservedFile(err, file, out) } </del> <ins> // parse the edited file updates, err := rmap.InfoForData(edited, \"edited-file\") if err != nil { return fmt.Errorf(\"The edited file had a syntax error: %v\", err) } </ins> <del> // annotate the edited object for kubectl apply if err := kubectl.UpdateApplyAnnotation(updates); err != nil { return preservedFile(err, file, out) } </del> <ins> // annotate the edited object for kubectl apply if err := kubectl.UpdateApplyAnnotation(updates); err != nil { return preservedFile(err, file, out) } </ins> <del> visitor := resource.NewFlattenListVisitor(updates, rmap) </del> <ins> visitor := resource.NewFlattenListVisitor(updates, rmap) </ins> <del> // need to make sure the original namespace wasn't changed while editing if err = visitor.Visit(resource.RequireNamespace(cmdNamespace)); err != nil { return preservedFile(err, file, out) } </del> <ins> // need to make sure the original namespace wasn't changed while editing if err = visitor.Visit(resource.RequireNamespace(cmdNamespace)); err != nil { return preservedFile(err, file, out) } </ins> <del> // use strategic merge to create a patch originalJS, err := yaml.ToJSON(original) if err != nil { return preservedFile(err, file, out) } editedJS, err := yaml.ToJSON(edited) if err != nil { return preservedFile(err, file, out) } patch, err := strategicpatch.CreateStrategicMergePatch(originalJS, editedJS, obj) // TODO: change all jsonmerge to strategicpatch // for checking preconditions preconditions := []jsonmerge.PreconditionFunc{} if err != nil { glog.V(4).Infof(\"Unable to calculate diff, no merge is possible: %v\", err) return preservedFile(err, file, out) } else { preconditions = append(preconditions, jsonmerge.RequireKeyUnchanged(\"apiVersion\")) preconditions = append(preconditions, jsonmerge.RequireKeyUnchanged(\"kind\")) preconditions = append(preconditions, jsonmerge.RequireMetadataKeyUnchanged(\"name\")) results.version = defaultVersion } </del> <ins> // use strategic merge to create a patch originalJS, err := yaml.ToJSON(original) if err != nil { return preservedFile(err, file, out) } editedJS, err := yaml.ToJSON(edited) if err != nil { return preservedFile(err, file, out) } patch, err := strategicpatch.CreateStrategicMergePatch(originalJS, editedJS, obj) // TODO: change all jsonmerge to strategicpatch // for checking preconditions preconditions := []jsonmerge.PreconditionFunc{} if err != nil { glog.V(4).Infof(\"Unable to calculate diff, no merge is possible: %v\", err) return preservedFile(err, file, out) } else { preconditions = append(preconditions, jsonmerge.RequireKeyUnchanged(\"apiVersion\")) preconditions = append(preconditions, jsonmerge.RequireKeyUnchanged(\"kind\")) preconditions = append(preconditions, jsonmerge.RequireMetadataKeyUnchanged(\"name\")) results.version = defaultVersion } </ins> <del> if hold, msg := jsonmerge.TestPreconditionsHold(patch, preconditions); !hold { fmt.Fprintf(out, \"error: %s\", msg) return preservedFile(nil, file, out) } </del> <ins> if hold, msg := jsonmerge.TestPreconditionsHold(patch, preconditions); !hold { fmt.Fprintf(out, \"error: %s\", msg) return preservedFile(nil, file, out) } </ins> <del> err = visitor.Visit(func(info *resource.Info, err error) error { patched, err := resource.NewHelper(info.Client, info.Mapping).Patch(info.Namespace, info.Name, api.StrategicMergePatchType, patch) if err != nil { fmt.Fprintln(out, results.addError(err, info)) </del> <ins> err = visitor.Visit(func(info *resource.Info, err error) error { patched, err := resource.NewHelper(info.Client, info.Mapping).Patch(info.Namespace, info.Name, api.StrategicMergePatchType, patch) if err != nil { fmt.Fprintln(out, results.addError(err, info)) return nil } info.Refresh(patched, true) cmdutil.PrintSuccess(mapper, false, out, info.Mapping.Resource, info.Name, \"edited\") </ins> return nil <ins> }) if err != nil { return preservedFile(err, file, out) </ins> } <del> info.Refresh(patched, true) cmdutil.PrintSuccess(mapper, false, out, info.Mapping.Resource, info.Name, \"edited\") return nil }) if err != nil { return preservedFile(err, file, out) } if results.retryable > 0 { fmt.Fprintf(out, \"You can run `kubectl replace -f %s` to try this update again.n\", file) return errExit } if results.conflict > 0 { fmt.Fprintf(out, \"You must update your local resource version and run `kubectl replace -f %s` to overwrite the remote changes.n\", file) return errExit </del> <ins> if results.retryable > 0 { fmt.Fprintf(out, \"You can run `kubectl replace -f %s` to try this update again.n\", file) return errExit } if results.conflict > 0 { fmt.Fprintf(out, \"You must update your local resource version and run `kubectl replace -f %s` to overwrite the remote changes.n\", file) return errExit } if len(results.edit) == 0 { if results.notfound == 0 { os.Remove(file) } else { fmt.Fprintf(out, \"The edits you made on deleted resources have been saved to %qn\", file) } } </ins> } if len(results.edit) == 0 { <del> if results.notfound == 0 { os.Remove(file) } else { fmt.Fprintf(out, \"The edits you made on deleted resources have been saved to %qn\", file) } </del> return nil }", "commid": "kubernetes_pr_15980"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d8539be161cacf223528437869590f13423a31b1176c381211bcba6b79e0cca", "query": "When trying to edit multiple resources, for example: will panic. Ref as the possible cause cc\nif was the cause, any fix needs to happen in 1.1 as well, was already cherry picked there\nAlso shows that we need a test for this case.\nis the cause. When we edit multiple resources (i.e., list-type objects), the list's Accessor.annotations (type ) is nil and will panic when UpdateApplyAnnotation tries to SetAnnotations ().", "positive_passages": [{"docid": "doc-en-kubernetes-04bdb3d2bb63267cc2d28461f18221496da6ec0095e36e4d303c9ec939a231a7", "text": "} return false, nil } <ins> // stripComments will transform a YAML file into JSON, thus dropping any comments // in it. Note that if the given file has a syntax error, the transformation will // fail and we will manually drop all comments from the file. func stripComments(file []byte) []byte { stripped, err := yaml.ToJSON(file) if err != nil { stripped = manualStrip(file) } return stripped } // manualStrip is used for dropping comments from a YAML file func manualStrip(file []byte) []byte { stripped := []byte{} for _, line := range bytes.Split(file, []byte(\"n\")) { if bytes.HasPrefix(bytes.TrimSpace(line), []byte(\"#\")) { continue } stripped = append(stripped, line...) stripped = append(stripped, 'n') } return stripped } </ins>", "commid": "kubernetes_pr_15980"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc39169146c9455c303f0970f8a8e8f06dd10bfe4e4173704fe0272d20d254f8", "query": "We have to spend times on figuring out what are the mount error code means from issues and . In , the error message is and is great for diagnosing mount problem. The console message better be returned rather than just error code.", "positive_passages": [{"docid": "doc-en-kubernetes-a88437e65a3a8055f5357af04ee62d0026637c40bdca373d5645eb251088725e", "text": "command := exec.Command(\"mount\", mountArgs...) output, err := command.CombinedOutput() if err != nil { <del> glog.Errorf(\"Mount failed: %vnMounting arguments: %s %s %s %vnOutput: %sn\", </del> <ins> return fmt.Errorf(\"Mount failed: %vnMounting arguments: %s %s %s %vnOutput: %sn\", </ins> err, source, target, fstype, options, string(output)) } return err", "commid": "kubernetes_pr_16033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc39169146c9455c303f0970f8a8e8f06dd10bfe4e4173704fe0272d20d254f8", "query": "We have to spend times on figuring out what are the mount error code means from issues and . In , the error message is and is great for diagnosing mount problem. The console message better be returned rather than just error code.", "positive_passages": [{"docid": "doc-en-kubernetes-3b7a9165243d003230e6f2b8d01c3faa3345eb780025309de7344e15deeba32a", "text": "command := exec.Command(\"umount\", target) output, err := command.CombinedOutput() if err != nil { <del> glog.Errorf(\"Unmount failed: %vnUnmounting arguments: %snOutput: %sn\", err, target, string(output)) return err </del> <ins> return fmt.Errorf(\"Unmount failed: %vnUnmounting arguments: %snOutput: %sn\", err, target, string(output)) </ins> } return nil }", "commid": "kubernetes_pr_16033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-42a2dcc81f7ae4dc8763c9cd41f1b3c90a02e5ad103b4424eb3978e5cae8304c", "query": "Heapster pod: And logs: cc p0 for triage\nDid the required node scope change?\nIts either the API on the console or monitoring write scopes on the node. , Mike Danese wrote:\nI think this affects only GCE\nI will fix this issue since is on vacation.\nNeed to cherry pick so i'll leave open\nis out for review.\nhas been closed and the cherrypick here () has been merged so I'm closing this issue. Thanks everyone for the debugging.", "positive_passages": [{"docid": "doc-en-kubernetes-52fcfbd57004797122bff061220df57223172da5a11b583f491199c8465debdc", "text": "#   google         - Heapster, Google Cloud Monitoring, and Google Cloud Logging #   googleinfluxdb - Enable influxdb and google (except GCM) #   standalone     - Heapster only. Metrics available via Heapster REST API. <del> ENABLE_CLUSTER_MONITORING=\"${KUBE_ENABLE_CLUSTER_MONITORING:-googleinfluxdb}\" </del> <ins> ENABLE_CLUSTER_MONITORING=\"${KUBE_ENABLE_CLUSTER_MONITORING:-influxdb}\" </ins> # Optional: Enable node logging. ENABLE_NODE_LOGGING=\"${KUBE_ENABLE_NODE_LOGGING:-true}\"", "commid": "kubernetes_pr_16214"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-42a2dcc81f7ae4dc8763c9cd41f1b3c90a02e5ad103b4424eb3978e5cae8304c", "query": "Heapster pod: And logs: cc p0 for triage\nDid the required node scope change?\nIts either the API on the console or monitoring write scopes on the node. , Mike Danese wrote:\nI think this affects only GCE\nI will fix this issue since is on vacation.\nNeed to cherry pick so i'll leave open\nis out for review.\nhas been closed and the cherrypick here () has been merged so I'm closing this issue. Thanks everyone for the debugging.", "positive_passages": [{"docid": "doc-en-kubernetes-bb3448a2f8231e96978bd32caa3dfe4cef5816826281a0af9bc6816a74da177e", "text": "AUTOSCALER_MIN_NODES=\"${KUBE_AUTOSCALER_MIN_NODES:-1}\" AUTOSCALER_MAX_NODES=\"${KUBE_AUTOSCALER_MAX_NODES:-${NUM_MINIONS}}\" TARGET_NODE_UTILIZATION=\"${KUBE_TARGET_NODE_UTILIZATION:-0.7}\" <ins> ENABLE_CLUSTER_MONITORING=googleinfluxdb </ins> fi # Optional: Enable deployment experimental feature, not ready for production use.", "commid": "kubernetes_pr_16214"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4ab746f40c555f197660ba2d46053a482240358ec0954f57c2d8c122630e391", "query": "has TODOs for how to bring up cluster addons like monitoring and logging. We should fill these in. requested by user:", "positive_passages": [{"docid": "doc-en-kubernetes-f659f8b8c8d5851aa52621379991adbeae0a55441c3bc028f358bd52a40d22aa", "text": "# Kubernetes Cluster Admin Guide: Cluster Components <ins> **Table of Contents** <!-- BEGIN MUNGE: GENERATED_TOC --> - [Kubernetes Cluster Admin Guide: Cluster Components](#kubernetes-cluster-admin-guide-cluster-components) - [Master Components](#master-components) - [kube-apiserver](#kube-apiserver) - [etcd](#etcd) - [kube-controller-manager](#kube-controller-manager) - [kube-scheduler](#kube-scheduler) - [addons](#addons) - [DNS](#dns) - [User interface](#user-interface) - [Container Resource Monitoring](#container-resource-monitoring) - [Cluster-level Logging](#cluster-level-logging) - [Node components](#node-components) - [kubelet](#kubelet) - [kube-proxy](#kube-proxy) - [docker](#docker) - [rkt](#rkt) - [monit](#monit) - [fluentd](#fluentd) <!-- END MUNGE: GENERATED_TOC --> </ins> This document outlines the various binary components that need to run to deliver a functioning Kubernetes cluster.", "commid": "kubernetes_pr_16328"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4ab746f40c555f197660ba2d46053a482240358ec0954f57c2d8c122630e391", "query": "has TODOs for how to bring up cluster addons like monitoring and logging. We should fill these in. requested by user:", "positive_passages": [{"docid": "doc-en-kubernetes-f6f45ce8d69583315b55867b88f1db6794354dc05c3fbd3c33d9982a5cec832a", "text": "Addon objects are created in the \"kube-system\" namespace. <del> Example addons are: * [DNS](http://releases.k8s.io/HEAD/cluster/addons/dns/) provides cluster local DNS. * [kube-ui](http://releases.k8s.io/HEAD/cluster/addons/kube-ui/) provides a graphical UI for the cluster. * [fluentd-elasticsearch](http://releases.k8s.io/HEAD/cluster/addons/fluentd-elasticsearch/) provides log storage. Also see the [gcp version](http://releases.k8s.io/HEAD/cluster/addons/fluentd-gcp/). * [cluster-monitoring](http://releases.k8s.io/HEAD/cluster/addons/cluster-monitoring/) provides monitoring for the cluster. </del> <ins> #### DNS While the other addons are not strictly required, all Kubernetes clusters should have [cluster DNS](dns.md), as many examples rely on it. Cluster DNS is a DNS server, in addition to the other DNS server(s) in your environment, which serves DNS records for Kubernetes services. Containers started by Kubernetes automatically include this DNS server in their DNS searches. #### User interface The kube-ui provides a read-only overview of the cluster state.  Access [the UI using kubectl proxy](../user-guide/connecting-to-applications-proxy.md#connecting-to-the-kube-ui-service-from-your-local-workstation) #### Container Resource Monitoring [Container Resource Monitoring](../user-guide/monitoring.md) records generic time-series metrics about containers in a central database, and provides a UI for browsing that data. #### Cluster-level Logging [Container Logging](../user-guide/monitoring.md) saves container logs to a central log store with search/browsing interface.  There are two implementations: * [Cluster-level logging to Google Cloud Logging]( docs/user-guide/logging.md#cluster-level-logging-to-google-cloud-logging) * [Cluster-level Logging with Elasticsearch and Kibana]( docs/user-guide/logging.md#cluster-level-logging-with-elasticsearch-and-kibana) </ins> ## Node components", "commid": "kubernetes_pr_16328"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4ab746f40c555f197660ba2d46053a482240358ec0954f57c2d8c122630e391", "query": "has TODOs for how to bring up cluster addons like monitoring and logging. We should fill these in. requested by user:", "positive_passages": [{"docid": "doc-en-kubernetes-c00006965ef4bfc4ffcc3f9521519cd0b3dcdc0b42b97d0405c6385d72b23cc6", "text": "`monit` is a lightweight process babysitting system for keeping kubelet and docker running. <ins> ### fluentd `fluentd` is a daemon which helps provide [cluster-level logging](#cluster-level-logging). </ins> <!-- BEGIN MUNGE: GENERATED_ANALYTICS --> [![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/docs/admin/cluster-components.md?pixel)]()", "commid": "kubernetes_pr_16328"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4ab746f40c555f197660ba2d46053a482240358ec0954f57c2d8c122630e391", "query": "has TODOs for how to bring up cluster addons like monitoring and logging. We should fill these in. requested by user:", "positive_passages": [{"docid": "doc-en-kubernetes-906aecf5a78ae3aee282a885feeac406b1acfd719ea9462f0314052f03183e77", "text": "- [Scheduler pod template](#scheduler-pod-template) - [Controller Manager Template](#controller-manager-template) - [Starting and Verifying Apiserver, Scheduler, and Controller Manager](#starting-and-verifying-apiserver-scheduler-and-controller-manager) <del> - [Logging](#logging) - [Monitoring](#monitoring) - [DNS](#dns) </del> <ins> - [Starting Cluster Services](#starting-cluster-services) </ins> - [Troubleshooting](#troubleshooting) - [Running validate-cluster](#running-validate-cluster) - [Inspect pods and services](#inspect-pods-and-services)", "commid": "kubernetes_pr_16328"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4ab746f40c555f197660ba2d46053a482240358ec0954f57c2d8c122630e391", "query": "has TODOs for how to bring up cluster addons like monitoring and logging. We should fill these in. requested by user:", "positive_passages": [{"docid": "doc-en-kubernetes-c792047fe9a77e92289bf8618ccaee1fbd3a23a9fdfc1a8f17176feedfae1ce8", "text": "- Otherwise, if taking the firewall-based security approach - `--api-servers=http://$MASTER_IP` - `--config=/etc/kubernetes/manifests` <del> - `--cluster-dns=` to the address of the DNS server you will setup (see [Starting Addons](#starting-addons).) </del> <ins> - `--cluster-dns=` to the address of the DNS server you will setup (see [Starting Cluster Services](#starting-cluster-services).) </ins> - `--cluster-domain=` to the dns domain prefix to use for cluster DNS addresses. - `--docker-root=` - `--root-dir=`", "commid": "kubernetes_pr_16328"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4ab746f40c555f197660ba2d46053a482240358ec0954f57c2d8c122630e391", "query": "has TODOs for how to bring up cluster addons like monitoring and logging. We should fill these in. requested by user:", "positive_passages": [{"docid": "doc-en-kubernetes-3806feaac5ab9435de66d36611c127e2e09f0cdc692f275466ccd90bbe17df57", "text": "You should soon be able to see all your nodes by running the `kubectl get nodes` command. Otherwise, you will need to manually create node objects. <del> ### Logging **TODO** talk about starting Logging. ### Monitoring **TODO** talk about starting Monitoring. ### DNS **TODO** talk about starting DNS. </del> <ins> ### Starting Cluster Services You will want to complete your Kubernetes clusters by adding cluster-wide services.  These are sometimes called *addons*, and [an overview of their purpose is in the admin guide]( ../../docs/admin/cluster-components.md#addons). Notes for setting up each cluster service are given below: * Cluster DNS: * required for many kubernetes examples * [Setup instructions](http://releases.k8s.io/HEAD/cluster/addons/dns/) * [Admin Guide](../admin/dns.md) * Cluster-level Logging * Multiple implementations with different storage backends and UIs. * [Elasticsearch Backend Setup Instructions](http://releases.k8s.io/HEAD/cluster/addons/fluentd-elasticsearch/) * [Google Cloud Logging Backend Setup Instructions](http://releases.k8s.io/HEAD/cluster/addons/fluentd-gcp/). * Both require running fluentd on each node. * [User Guide](../user-guide/logging.md) * Container Resource Monitoring * [Setup instructions](http://releases.k8s.io/HEAD/cluster/addons/cluster-monitoring/) * GUI * [Setup instructions](http://releases.k8s.io/HEAD/cluster/addons/kube-ui/) cluster. </ins> ## Troubleshooting", "commid": "kubernetes_pr_16328"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4ab746f40c555f197660ba2d46053a482240358ec0954f57c2d8c122630e391", "query": "has TODOs for how to bring up cluster addons like monitoring and logging. We should fill these in. requested by user:", "positive_passages": [{"docid": "doc-en-kubernetes-d666f3b9348166c8e27cf0d6f177ecf3cb28d250971037c2ff5b8133da1ce2a0", "text": "# Connecting to applications: kubectl proxy and apiserver proxy <ins> <!-- BEGIN MUNGE: GENERATED_TOC --> - [Connecting to applications: kubectl proxy and apiserver proxy](#connecting-to-applications-kubectl-proxy-and-apiserver-proxy) - [Getting the apiserver proxy URL of kube-ui](#getting-the-apiserver-proxy-url-of-kube-ui) - [Connecting to the kube-ui service from your local workstation](#connecting-to-the-kube-ui-service-from-your-local-workstation) <!-- END MUNGE: GENERATED_TOC --> </ins> You have seen the [basics](accessing-the-cluster.md) about `kubectl proxy` and `apiserver proxy`. This guide shows how to use them together to access a service([kube-ui](ui.md)) running on the Kubernetes cluster from your workstation.", "commid": "kubernetes_pr_16328"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4ab746f40c555f197660ba2d46053a482240358ec0954f57c2d8c122630e391", "query": "has TODOs for how to bring up cluster addons like monitoring and logging. We should fill these in. requested by user:", "positive_passages": [{"docid": "doc-en-kubernetes-5334e52850e973dddc416900e9822fc089a9f2dffa3d330cd086fe3333eaf6d3", "text": "# Logging <ins> **Table of Contents** <!-- BEGIN MUNGE: GENERATED_TOC --> - [Logging](#logging) - [Logging by Kubernetes Components](#logging-by-kubernetes-components) - [Examining the logs of running containers](#examining-the-logs-of-running-containers) - [Cluster level logging to Google Cloud Logging](#cluster-level-logging-to-google-cloud-logging) - [Cluster level logging with Elasticsearch and Kibana](#cluster-level-logging-with-elasticsearch-and-kibana) - [Ingesting Application Log Files](#ingesting-application-log-files) - [Known issues](#known-issues) <!-- END MUNGE: GENERATED_TOC --> </ins> ## Logging by Kubernetes Components Kubernetes components, such as kubelet and apiserver, use the [glog](https://godoc.org/github.com/golang/glog) logging library.  Developer conventions for logging severity are described in [docs/devel/logging.md](../devel/logging.md).", "commid": "kubernetes_pr_16328"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cc8f7dd240ce03e902a3a6988aef93cbe00593e0f5081bd8380b06a0a728c5de", "query": "Currently watches only log when they complete, which can make analyzing kube-apiserver log files a bit tricky. (did component x never start watching after that list or did apiserver shut down?)", "positive_passages": [{"docid": "doc-en-kubernetes-48a353894265358f5dd25b1305911e3a8800bf102bd9b690eae3ba9dd32ad7e6", "text": "} if (opts.Watch || forceWatch) && rw != nil { <ins> glog.Infof(\"Started to log from %v for %v\", ctx, req.Request.URL.RequestURI()) </ins> watcher, err := rw.Watch(ctx, &opts) if err != nil { scope.err(err, res.ResponseWriter, req.Request)", "commid": "kubernetes_pr_37273"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1b90ac0e27eb7112950da48e761bdf56abe3dcf0ad8451e1546669339b5f8d17", "query": "We have found that on 1k nodes cluster scheduling takes 60-200 ms and becomes the bottleneck. We want to have a standard way to reproduce scheduling latency metrics result and benchmark scheduler as simple and fast as possible. Only with that can we: 1. figure out underlying behaviors and potential bottlenecks quickly; 2. publish results in a standard way and prevent future performance degradation. We have the following goals: Goal 1: Save time on testing. More accurate scheduling latency. We mock up kubelets and only measure scheduling latency and do not care about the latency to start the pod. This is different from Kubemark -- scheduled pods won\u2019t be run by mocked kubelets. We only need to set up the master components. Goal 2: Profiling runtime metrics and find out performance bottleneck. Write scheduler integration test. Take advantage of go test and profiling tools, like cpu-profiling, memory-profiling and block-profiling. This is very fine-grained metrics. Goal 3: Reproduce test result easily. We want to have a known place to do the performance related test for scheduler. Developers should just run one script to collect all the information they need. We have the following plans for writing scheduler tests: density test (by adding a new Go test) schedule 30k pods on 1000 (fake) nodes and 3k pods on 100 (fake) nodes print out scheduling rate every second let you learn the rate changes vs number of scheduled pods benchmark (by modifying the existing benchmark in integration or simply add a new one) make use of and report nanosecond/op. schedule b.N pods when the cluster has N nodes and P scheduled pods. Since it takes relatively long time to finish one round, b.N is small -- level of 10. We are new to k8s codebase. We also want to know where is the best place (directory) to commit in these tests? Any suggestions are welcomed!\n/cc\nThis extends\nSo density already does this... the one option it looks like you may want is custom control , real or fake is irrelevant as the e2e's just need to point to an api-server. re: benchmarks, seems like we could simply add to the unit-tests.\nAfter chatting with lets add this as an agenda item for the SIG meeting tomorrow.\n+1 for adding benchmark (howeveer this should be integration test, not unit-test in my opinion)\ncc The next SIG on scheduler meeting is on 12.07, isn't it? If there is one tomorrow, can I have the information please?\nretract, +1 to . I was adding this to the list given the context, but it crosses over into both.\nSlides from today's meeting:\nHere are are the action item notes from the SIG meeting: Everyone agrees this is a good idea and long overdue, but the question is where would this live: New category of tests? (isolated/sandbox\u2019d/component) The current testing structure allows to easily append. create new directory (component) + hack/script to execute Future \"we could\" gate on known good data, and fail performance regressions\n/cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-ae6f0afab15f5950f8fcde4833d6d37d3ed9ddb0a4ec362aec9f4e02741981c8", "text": "-o -path './test/e2e/*'  -o -path './test/e2e_node/*'  -o -path './test/integration/*'  <ins> -o -path './test/component/scheduler/perf/*'  </ins> ) -prune  ) -name '*_test.go' -print0 | xargs -0n1 dirname | sed 's|^./||' | sort -u )", "commid": "kubernetes_pr_18458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1b90ac0e27eb7112950da48e761bdf56abe3dcf0ad8451e1546669339b5f8d17", "query": "We have found that on 1k nodes cluster scheduling takes 60-200 ms and becomes the bottleneck. We want to have a standard way to reproduce scheduling latency metrics result and benchmark scheduler as simple and fast as possible. Only with that can we: 1. figure out underlying behaviors and potential bottlenecks quickly; 2. publish results in a standard way and prevent future performance degradation. We have the following goals: Goal 1: Save time on testing. More accurate scheduling latency. We mock up kubelets and only measure scheduling latency and do not care about the latency to start the pod. This is different from Kubemark -- scheduled pods won\u2019t be run by mocked kubelets. We only need to set up the master components. Goal 2: Profiling runtime metrics and find out performance bottleneck. Write scheduler integration test. Take advantage of go test and profiling tools, like cpu-profiling, memory-profiling and block-profiling. This is very fine-grained metrics. Goal 3: Reproduce test result easily. We want to have a known place to do the performance related test for scheduler. Developers should just run one script to collect all the information they need. We have the following plans for writing scheduler tests: density test (by adding a new Go test) schedule 30k pods on 1000 (fake) nodes and 3k pods on 100 (fake) nodes print out scheduling rate every second let you learn the rate changes vs number of scheduled pods benchmark (by modifying the existing benchmark in integration or simply add a new one) make use of and report nanosecond/op. schedule b.N pods when the cluster has N nodes and P scheduled pods. Since it takes relatively long time to finish one round, b.N is small -- level of 10. We are new to k8s codebase. We also want to know where is the best place (directory) to commit in these tests? Any suggestions are welcomed!\n/cc\nThis extends\nSo density already does this... the one option it looks like you may want is custom control , real or fake is irrelevant as the e2e's just need to point to an api-server. re: benchmarks, seems like we could simply add to the unit-tests.\nAfter chatting with lets add this as an agenda item for the SIG meeting tomorrow.\n+1 for adding benchmark (howeveer this should be integration test, not unit-test in my opinion)\ncc The next SIG on scheduler meeting is on 12.07, isn't it? If there is one tomorrow, can I have the information please?\nretract, +1 to . I was adding this to the list given the context, but it crosses over into both.\nSlides from today's meeting:\nHere are are the action item notes from the SIG meeting: Everyone agrees this is a good idea and long overdue, but the question is where would this live: New category of tests? (isolated/sandbox\u2019d/component) The current testing structure allows to easily append. create new directory (component) + hack/script to execute Future \"we could\" gate on known good data, and fail performance regressions\n/cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-8de89b8c6a4e02604401db70412de1e7eca7d6c16dfb784922be1063a768154a", "text": "<ins> <!-- BEGIN MUNGE: UNVERSIONED_WARNING --> <!-- BEGIN STRIP_FOR_RELEASE --> <img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\" width=\"25\" height=\"25\"> <img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\" width=\"25\" height=\"25\"> <img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\" width=\"25\" height=\"25\"> <img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\" width=\"25\" height=\"25\"> <img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\" width=\"25\" height=\"25\"> <h2>PLEASE NOTE: This document applies to the HEAD of the source tree</h2> If you are using a released version of Kubernetes, you should refer to the docs that go with that version. <strong> The latest release of this document can be found [here](http://releases.k8s.io/release-1.1/docs/proposals/choosing-scheduler.md). Documentation for other releases can be found at [releases.k8s.io](http://releases.k8s.io). </strong> -- <!-- END STRIP_FOR_RELEASE --> <!-- END MUNGE: UNVERSIONED_WARNING --> Scheduler Performance Test ====== Motivation ------ We already have a performance testing system -- Kubemark. However, Kubemark requires setting up and bootstrapping a whole cluster, which takes a lot of time. We want to have a standard way to reproduce scheduling latency metrics result and benchmark scheduler as simple and fast as possible. We have the following goals: - Save time on testing - The test and benchmark can be run in a single box. We only set up components necessary to scheduling without booting up a cluster. - Profiling runtime metrics to find out bottleneck - Write scheduler integration test but focus on performance measurement. Take advantage of go profiling tools and collect fine-grained metrics, like cpu-profiling, memory-profiling and block-profiling. - Reproduce test result easily - We want to have a known place to do the performance related test for scheduler. Developers should just run one script to collect all the information they need. Currently the test suite has the following: - density test (by adding a new Go test) - schedule 30k pods on 1000 (fake) nodes and 3k pods on 100 (fake) nodes - print out scheduling rate every second - let you learn the rate changes vs number of scheduled pods - benchmark - make use of `go test -bench` and report nanosecond/op. - schedule b.N pods when the cluster has N nodes and P scheduled pods. Since it takes relatively long time to finish one round, b.N is small: 10 - 100. How To Run ------ ``` cd kubernetes/test/component/scheduler/perf ./test-performance.sh ``` <!-- BEGIN MUNGE: GENERATED_ANALYTICS --> [![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/test/component/scheduler/perf/README.md?pixel)]() <!-- END MUNGE: GENERATED_ANALYTICS --> </ins>", "commid": "kubernetes_pr_18458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1b90ac0e27eb7112950da48e761bdf56abe3dcf0ad8451e1546669339b5f8d17", "query": "We have found that on 1k nodes cluster scheduling takes 60-200 ms and becomes the bottleneck. We want to have a standard way to reproduce scheduling latency metrics result and benchmark scheduler as simple and fast as possible. Only with that can we: 1. figure out underlying behaviors and potential bottlenecks quickly; 2. publish results in a standard way and prevent future performance degradation. We have the following goals: Goal 1: Save time on testing. More accurate scheduling latency. We mock up kubelets and only measure scheduling latency and do not care about the latency to start the pod. This is different from Kubemark -- scheduled pods won\u2019t be run by mocked kubelets. We only need to set up the master components. Goal 2: Profiling runtime metrics and find out performance bottleneck. Write scheduler integration test. Take advantage of go test and profiling tools, like cpu-profiling, memory-profiling and block-profiling. This is very fine-grained metrics. Goal 3: Reproduce test result easily. We want to have a known place to do the performance related test for scheduler. Developers should just run one script to collect all the information they need. We have the following plans for writing scheduler tests: density test (by adding a new Go test) schedule 30k pods on 1000 (fake) nodes and 3k pods on 100 (fake) nodes print out scheduling rate every second let you learn the rate changes vs number of scheduled pods benchmark (by modifying the existing benchmark in integration or simply add a new one) make use of and report nanosecond/op. schedule b.N pods when the cluster has N nodes and P scheduled pods. Since it takes relatively long time to finish one round, b.N is small -- level of 10. We are new to k8s codebase. We also want to know where is the best place (directory) to commit in these tests? Any suggestions are welcomed!\n/cc\nThis extends\nSo density already does this... the one option it looks like you may want is custom control , real or fake is irrelevant as the e2e's just need to point to an api-server. re: benchmarks, seems like we could simply add to the unit-tests.\nAfter chatting with lets add this as an agenda item for the SIG meeting tomorrow.\n+1 for adding benchmark (howeveer this should be integration test, not unit-test in my opinion)\ncc The next SIG on scheduler meeting is on 12.07, isn't it? If there is one tomorrow, can I have the information please?\nretract, +1 to . I was adding this to the list given the context, but it crosses over into both.\nSlides from today's meeting:\nHere are are the action item notes from the SIG meeting: Everyone agrees this is a good idea and long overdue, but the question is where would this live: New category of tests? (isolated/sandbox\u2019d/component) The current testing structure allows to easily append. create new directory (component) + hack/script to execute Future \"we could\" gate on known good data, and fail performance regressions\n/cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-63a9f94c7e22642097e3c1d84560088b8c72d74d97b74eba79b0875f49c2b35e", "text": "<ins> /* Copyright 2015 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package benchmark import ( \"testing\" \"time\" ) // BenchmarkScheduling100Nodes0Pods benchmarks the scheduling rate // when the cluster has 100 nodes and 0 scheduled pods func BenchmarkScheduling100Nodes0Pods(b *testing.B) { benchmarkScheduling(100, 0, b) } // BenchmarkScheduling100Nodes1000Pods benchmarks the scheduling rate // when the cluster has 100 nodes and 1000 scheduled pods func BenchmarkScheduling100Nodes1000Pods(b *testing.B) { benchmarkScheduling(100, 1000, b) } // BenchmarkScheduling1000Nodes0Pods benchmarks the scheduling rate // when the cluster has 1000 nodes and 0 scheduled pods func BenchmarkScheduling1000Nodes0Pods(b *testing.B) { benchmarkScheduling(1000, 0, b) } // BenchmarkScheduling1000Nodes1000Pods benchmarks the scheduling rate // when the cluster has 1000 nodes and 1000 scheduled pods func BenchmarkScheduling1000Nodes1000Pods(b *testing.B) { benchmarkScheduling(1000, 1000, b) } // benchmarkScheduling benchmarks scheduling rate with specific number of nodes // and specific number of pods already scheduled. Since an operation takes relatively // long time, b.N should be small: 10 - 100. func benchmarkScheduling(numNodes, numScheduledPods int, b *testing.B) { schedulerConfigFactory, finalFunc := mustSetupScheduler() defer finalFunc() c := schedulerConfigFactory.Client makeNodes(c, numNodes) makePods(c, numScheduledPods) for { scheduled := schedulerConfigFactory.ScheduledPodLister.Store.List() if len(scheduled) >= numScheduledPods { break } time.Sleep(1 * time.Second) } // start benchmark b.ResetTimer() makePods(c, b.N) for { // This can potentially affect performance of scheduler, since List() is done under mutex. // TODO: Setup watch on apiserver and wait until all pods scheduled. scheduled := schedulerConfigFactory.ScheduledPodLister.Store.List() if len(scheduled) >= numScheduledPods+b.N { break } // Note: This might introduce slight deviation in accuracy of benchmark results. // Since the total amount of time is relatively large, it might not be a concern. time.Sleep(100 * time.Millisecond) } } </ins>", "commid": "kubernetes_pr_18458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1b90ac0e27eb7112950da48e761bdf56abe3dcf0ad8451e1546669339b5f8d17", "query": "We have found that on 1k nodes cluster scheduling takes 60-200 ms and becomes the bottleneck. We want to have a standard way to reproduce scheduling latency metrics result and benchmark scheduler as simple and fast as possible. Only with that can we: 1. figure out underlying behaviors and potential bottlenecks quickly; 2. publish results in a standard way and prevent future performance degradation. We have the following goals: Goal 1: Save time on testing. More accurate scheduling latency. We mock up kubelets and only measure scheduling latency and do not care about the latency to start the pod. This is different from Kubemark -- scheduled pods won\u2019t be run by mocked kubelets. We only need to set up the master components. Goal 2: Profiling runtime metrics and find out performance bottleneck. Write scheduler integration test. Take advantage of go test and profiling tools, like cpu-profiling, memory-profiling and block-profiling. This is very fine-grained metrics. Goal 3: Reproduce test result easily. We want to have a known place to do the performance related test for scheduler. Developers should just run one script to collect all the information they need. We have the following plans for writing scheduler tests: density test (by adding a new Go test) schedule 30k pods on 1000 (fake) nodes and 3k pods on 100 (fake) nodes print out scheduling rate every second let you learn the rate changes vs number of scheduled pods benchmark (by modifying the existing benchmark in integration or simply add a new one) make use of and report nanosecond/op. schedule b.N pods when the cluster has N nodes and P scheduled pods. Since it takes relatively long time to finish one round, b.N is small -- level of 10. We are new to k8s codebase. We also want to know where is the best place (directory) to commit in these tests? Any suggestions are welcomed!\n/cc\nThis extends\nSo density already does this... the one option it looks like you may want is custom control , real or fake is irrelevant as the e2e's just need to point to an api-server. re: benchmarks, seems like we could simply add to the unit-tests.\nAfter chatting with lets add this as an agenda item for the SIG meeting tomorrow.\n+1 for adding benchmark (howeveer this should be integration test, not unit-test in my opinion)\ncc The next SIG on scheduler meeting is on 12.07, isn't it? If there is one tomorrow, can I have the information please?\nretract, +1 to . I was adding this to the list given the context, but it crosses over into both.\nSlides from today's meeting:\nHere are are the action item notes from the SIG meeting: Everyone agrees this is a good idea and long overdue, but the question is where would this live: New category of tests? (isolated/sandbox\u2019d/component) The current testing structure allows to easily append. create new directory (component) + hack/script to execute Future \"we could\" gate on known good data, and fail performance regressions\n/cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-d319af9459a1bddce3ef672a40a372b1a46ae2f612490b0de8a51ed5ef2c1406", "text": "<ins> /* Copyright 2015 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package benchmark import ( \"fmt\" \"testing\" \"time\" ) // TestSchedule100Node3KPods schedules 3k pods on 100 nodes. func TestSchedule100Node3KPods(t *testing.T) { schedulePods(100, 3000) } // TestSchedule1000Node30KPods schedules 30k pods on 1000 nodes. func TestSchedule1000Node30KPods(t *testing.T) { schedulePods(1000, 30000) } // schedulePods schedules specific number of pods on specific number of nodes. // This is used to learn the scheduling throughput on various // sizes of cluster and changes as more and more pods are scheduled. // It won't stop until all pods are scheduled. func schedulePods(numNodes, numPods int) { schedulerConfigFactory, destroyFunc := mustSetupScheduler() defer destroyFunc() c := schedulerConfigFactory.Client makeNodes(c, numNodes) makePods(c, numPods) prev := 0 start := time.Now() for { // This can potentially affect performance of scheduler, since List() is done under mutex. // Listing 10000 pods is an expensive operation, so running it frequently may impact scheduler. // TODO: Setup watch on apiserver and wait until all pods scheduled. scheduled := schedulerConfigFactory.ScheduledPodLister.Store.List() fmt.Printf(\"%dstrate: %dttotal: %dn\", time.Since(start)/time.Second, len(scheduled)-prev, len(scheduled)) if len(scheduled) >= numPods { return } prev = len(scheduled) time.Sleep(1 * time.Second) } } </ins>", "commid": "kubernetes_pr_18458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1b90ac0e27eb7112950da48e761bdf56abe3dcf0ad8451e1546669339b5f8d17", "query": "We have found that on 1k nodes cluster scheduling takes 60-200 ms and becomes the bottleneck. We want to have a standard way to reproduce scheduling latency metrics result and benchmark scheduler as simple and fast as possible. Only with that can we: 1. figure out underlying behaviors and potential bottlenecks quickly; 2. publish results in a standard way and prevent future performance degradation. We have the following goals: Goal 1: Save time on testing. More accurate scheduling latency. We mock up kubelets and only measure scheduling latency and do not care about the latency to start the pod. This is different from Kubemark -- scheduled pods won\u2019t be run by mocked kubelets. We only need to set up the master components. Goal 2: Profiling runtime metrics and find out performance bottleneck. Write scheduler integration test. Take advantage of go test and profiling tools, like cpu-profiling, memory-profiling and block-profiling. This is very fine-grained metrics. Goal 3: Reproduce test result easily. We want to have a known place to do the performance related test for scheduler. Developers should just run one script to collect all the information they need. We have the following plans for writing scheduler tests: density test (by adding a new Go test) schedule 30k pods on 1000 (fake) nodes and 3k pods on 100 (fake) nodes print out scheduling rate every second let you learn the rate changes vs number of scheduled pods benchmark (by modifying the existing benchmark in integration or simply add a new one) make use of and report nanosecond/op. schedule b.N pods when the cluster has N nodes and P scheduled pods. Since it takes relatively long time to finish one round, b.N is small -- level of 10. We are new to k8s codebase. We also want to know where is the best place (directory) to commit in these tests? Any suggestions are welcomed!\n/cc\nThis extends\nSo density already does this... the one option it looks like you may want is custom control , real or fake is irrelevant as the e2e's just need to point to an api-server. re: benchmarks, seems like we could simply add to the unit-tests.\nAfter chatting with lets add this as an agenda item for the SIG meeting tomorrow.\n+1 for adding benchmark (howeveer this should be integration test, not unit-test in my opinion)\ncc The next SIG on scheduler meeting is on 12.07, isn't it? If there is one tomorrow, can I have the information please?\nretract, +1 to . I was adding this to the list given the context, but it crosses over into both.\nSlides from today's meeting:\nHere are are the action item notes from the SIG meeting: Everyone agrees this is a good idea and long overdue, but the question is where would this live: New category of tests? (isolated/sandbox\u2019d/component) The current testing structure allows to easily append. create new directory (component) + hack/script to execute Future \"we could\" gate on known good data, and fail performance regressions\n/cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-1f73cfb3474ce8780fbdde136e86c355075a32f7e6d90dc9ffd41e79f895da29", "text": "<ins> #!/usr/bin/env bash # Copyright 2014 The Kubernetes Authors All rights reserved. # # Licensed under the Apache License, Version 2.0 (the \"License\"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #     http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an \"AS IS\" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. set -o errexit set -o nounset set -o pipefail pushd \"../../../..\" source \"./hack/lib/util.sh\" source \"./hack/lib/logging.sh\" source \"./hack/lib/etcd.sh\" popd cleanup() { kube::etcd::cleanup kube::log::status \"performance test cleanup complete\" } trap cleanup EXIT kube::etcd::start kube::log::status \"performance test start\" # TODO: set log-dir and prof output dir. DIR_BASENAME=$(basename `pwd`) go test -c -o \"${DIR_BASENAME}.test\" # We are using the benchmark suite to do profiling. Because it only runs a few pods and # theoretically it has less variance. \"./${DIR_BASENAME}.test\" -test.bench=. -test.run=xxxx -test.cpuprofile=prof.out -logtostderr=false kube::log::status \"benchmark tests finished\" # Running density tests. It might take a long time. \"./${DIR_BASENAME}.test\" -test.run=. -test.timeout=60m kube::log::status \"density tests finished\" </ins>", "commid": "kubernetes_pr_18458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1b90ac0e27eb7112950da48e761bdf56abe3dcf0ad8451e1546669339b5f8d17", "query": "We have found that on 1k nodes cluster scheduling takes 60-200 ms and becomes the bottleneck. We want to have a standard way to reproduce scheduling latency metrics result and benchmark scheduler as simple and fast as possible. Only with that can we: 1. figure out underlying behaviors and potential bottlenecks quickly; 2. publish results in a standard way and prevent future performance degradation. We have the following goals: Goal 1: Save time on testing. More accurate scheduling latency. We mock up kubelets and only measure scheduling latency and do not care about the latency to start the pod. This is different from Kubemark -- scheduled pods won\u2019t be run by mocked kubelets. We only need to set up the master components. Goal 2: Profiling runtime metrics and find out performance bottleneck. Write scheduler integration test. Take advantage of go test and profiling tools, like cpu-profiling, memory-profiling and block-profiling. This is very fine-grained metrics. Goal 3: Reproduce test result easily. We want to have a known place to do the performance related test for scheduler. Developers should just run one script to collect all the information they need. We have the following plans for writing scheduler tests: density test (by adding a new Go test) schedule 30k pods on 1000 (fake) nodes and 3k pods on 100 (fake) nodes print out scheduling rate every second let you learn the rate changes vs number of scheduled pods benchmark (by modifying the existing benchmark in integration or simply add a new one) make use of and report nanosecond/op. schedule b.N pods when the cluster has N nodes and P scheduled pods. Since it takes relatively long time to finish one round, b.N is small -- level of 10. We are new to k8s codebase. We also want to know where is the best place (directory) to commit in these tests? Any suggestions are welcomed!\n/cc\nThis extends\nSo density already does this... the one option it looks like you may want is custom control , real or fake is irrelevant as the e2e's just need to point to an api-server. re: benchmarks, seems like we could simply add to the unit-tests.\nAfter chatting with lets add this as an agenda item for the SIG meeting tomorrow.\n+1 for adding benchmark (howeveer this should be integration test, not unit-test in my opinion)\ncc The next SIG on scheduler meeting is on 12.07, isn't it? If there is one tomorrow, can I have the information please?\nretract, +1 to . I was adding this to the list given the context, but it crosses over into both.\nSlides from today's meeting:\nHere are are the action item notes from the SIG meeting: Everyone agrees this is a good idea and long overdue, but the question is where would this live: New category of tests? (isolated/sandbox\u2019d/component) The current testing structure allows to easily append. create new directory (component) + hack/script to execute Future \"we could\" gate on known good data, and fail performance regressions\n/cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-e876ffb1d503f96c82449b539492e05a30e494a6d3c73115a786c6b8442ab652", "text": "<ins> /* Copyright 2015 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package benchmark import ( \"net/http\" \"net/http/httptest\" \"github.com/golang/glog\" \"k8s.io/kubernetes/pkg/api\" \"k8s.io/kubernetes/pkg/api/resource\" \"k8s.io/kubernetes/pkg/api/testapi\" \"k8s.io/kubernetes/pkg/client/record\" client \"k8s.io/kubernetes/pkg/client/unversioned\" \"k8s.io/kubernetes/pkg/master\" \"k8s.io/kubernetes/plugin/pkg/scheduler\" _ \"k8s.io/kubernetes/plugin/pkg/scheduler/algorithmprovider\" \"k8s.io/kubernetes/plugin/pkg/scheduler/factory\" \"k8s.io/kubernetes/test/integration/framework\" ) // mustSetupScheduler starts the following components: // - k8s api server (a.k.a. master) // - scheduler // It returns scheduler config factory and destroyFunc which should be used to // remove resources after finished. // Notes on rate limiter: //   - The BindPodsRateLimiter is nil, meaning no rate limits. //   - client rate limit is set to 5000. func mustSetupScheduler() (schedulerConfigFactory *factory.ConfigFactory, destroyFunc func()) { framework.DeleteAllEtcdKeys() var m *master.Master masterConfig := framework.NewIntegrationTestMasterConfig() m = master.New(masterConfig) s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { m.Handler.ServeHTTP(w, req) })) c := client.NewOrDie(&client.Config{ Host:         s.URL, GroupVersion: testapi.Default.GroupVersion(), QPS:          5000.0, Burst:        5000, }) schedulerConfigFactory = factory.NewConfigFactory(c, nil) schedulerConfig, err := schedulerConfigFactory.Create() if err != nil { panic(\"Couldn't create scheduler config\") } eventBroadcaster := record.NewBroadcaster() schedulerConfig.Recorder = eventBroadcaster.NewRecorder(api.EventSource{Component: \"scheduler\"}) eventBroadcaster.StartRecordingToSink(c.Events(\"\")) scheduler.New(schedulerConfig).Run() destroyFunc = func() { glog.Infof(\"destroying\") close(schedulerConfig.StopEverything) s.Close() glog.Infof(\"destroyed\") } return } func makeNodes(c client.Interface, nodeCount int) { glog.Infof(\"making %d nodes\", nodeCount) baseNode := &api.Node{ ObjectMeta: api.ObjectMeta{ GenerateName: \"scheduler-test-node-\", }, Spec: api.NodeSpec{ ExternalID: \"foobar\", }, Status: api.NodeStatus{ Capacity: api.ResourceList{ api.ResourcePods:   *resource.NewQuantity(32, resource.DecimalSI), api.ResourceCPU:    resource.MustParse(\"4\"), api.ResourceMemory: resource.MustParse(\"32Gi\"), }, Phase: api.NodeRunning, Conditions: []api.NodeCondition{ {Type: api.NodeReady, Status: api.ConditionTrue}, }, }, } for i := 0; i < nodeCount; i++ { if _, err := c.Nodes().Create(baseNode); err != nil { panic(\"error creating node: \" + err.Error()) } } } // makePods will setup specified number of scheduled pods. // Currently it goes through scheduling path and it's very slow to setup large number of pods. // TODO: Setup pods evenly on all nodes and quickly/non-linearly. func makePods(c client.Interface, podCount int) { glog.Infof(\"making %d pods\", podCount) basePod := &api.Pod{ ObjectMeta: api.ObjectMeta{ GenerateName: \"scheduler-test-pod-\", }, Spec: api.PodSpec{ Containers: []api.Container{{ Name:  \"pause\", Image: \"gcr.io/google_containers/pause:1.0\", Resources: api.ResourceRequirements{ Limits: api.ResourceList{ api.ResourceCPU:    resource.MustParse(\"100m\"), api.ResourceMemory: resource.MustParse(\"500Mi\"), }, Requests: api.ResourceList{ api.ResourceCPU:    resource.MustParse(\"100m\"), api.ResourceMemory: resource.MustParse(\"500Mi\"), }, }, }}, }, } threads := 30 remaining := make(chan int, 1000) go func() { for i := 0; i < podCount; i++ { remaining <- i } close(remaining) }() for i := 0; i < threads; i++ { go func() { for { _, ok := <-remaining if !ok { return } for { _, err := c.Pods(\"default\").Create(basePod) if err == nil { break } } } }() } } </ins>", "commid": "kubernetes_pr_18458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1b90ac0e27eb7112950da48e761bdf56abe3dcf0ad8451e1546669339b5f8d17", "query": "We have found that on 1k nodes cluster scheduling takes 60-200 ms and becomes the bottleneck. We want to have a standard way to reproduce scheduling latency metrics result and benchmark scheduler as simple and fast as possible. Only with that can we: 1. figure out underlying behaviors and potential bottlenecks quickly; 2. publish results in a standard way and prevent future performance degradation. We have the following goals: Goal 1: Save time on testing. More accurate scheduling latency. We mock up kubelets and only measure scheduling latency and do not care about the latency to start the pod. This is different from Kubemark -- scheduled pods won\u2019t be run by mocked kubelets. We only need to set up the master components. Goal 2: Profiling runtime metrics and find out performance bottleneck. Write scheduler integration test. Take advantage of go test and profiling tools, like cpu-profiling, memory-profiling and block-profiling. This is very fine-grained metrics. Goal 3: Reproduce test result easily. We want to have a known place to do the performance related test for scheduler. Developers should just run one script to collect all the information they need. We have the following plans for writing scheduler tests: density test (by adding a new Go test) schedule 30k pods on 1000 (fake) nodes and 3k pods on 100 (fake) nodes print out scheduling rate every second let you learn the rate changes vs number of scheduled pods benchmark (by modifying the existing benchmark in integration or simply add a new one) make use of and report nanosecond/op. schedule b.N pods when the cluster has N nodes and P scheduled pods. Since it takes relatively long time to finish one round, b.N is small -- level of 10. We are new to k8s codebase. We also want to know where is the best place (directory) to commit in these tests? Any suggestions are welcomed!\n/cc\nThis extends\nSo density already does this... the one option it looks like you may want is custom control , real or fake is irrelevant as the e2e's just need to point to an api-server. re: benchmarks, seems like we could simply add to the unit-tests.\nAfter chatting with lets add this as an agenda item for the SIG meeting tomorrow.\n+1 for adding benchmark (howeveer this should be integration test, not unit-test in my opinion)\ncc The next SIG on scheduler meeting is on 12.07, isn't it? If there is one tomorrow, can I have the information please?\nretract, +1 to . I was adding this to the list given the context, but it crosses over into both.\nSlides from today's meeting:\nHere are are the action item notes from the SIG meeting: Everyone agrees this is a good idea and long overdue, but the question is where would this live: New category of tests? (isolated/sandbox\u2019d/component) The current testing structure allows to easily append. create new directory (component) + hack/script to execute Future \"we could\" gate on known good data, and fail performance regressions\n/cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-362efe3c289a2c4a353dcba34808269a82ddc616124e333476a68af0cc74238c", "text": "\"fmt\" \"net/http\" \"net/http/httptest\" <del> \"sync\" </del> \"testing\" \"time\"", "commid": "kubernetes_pr_18458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1b90ac0e27eb7112950da48e761bdf56abe3dcf0ad8451e1546669339b5f8d17", "query": "We have found that on 1k nodes cluster scheduling takes 60-200 ms and becomes the bottleneck. We want to have a standard way to reproduce scheduling latency metrics result and benchmark scheduler as simple and fast as possible. Only with that can we: 1. figure out underlying behaviors and potential bottlenecks quickly; 2. publish results in a standard way and prevent future performance degradation. We have the following goals: Goal 1: Save time on testing. More accurate scheduling latency. We mock up kubelets and only measure scheduling latency and do not care about the latency to start the pod. This is different from Kubemark -- scheduled pods won\u2019t be run by mocked kubelets. We only need to set up the master components. Goal 2: Profiling runtime metrics and find out performance bottleneck. Write scheduler integration test. Take advantage of go test and profiling tools, like cpu-profiling, memory-profiling and block-profiling. This is very fine-grained metrics. Goal 3: Reproduce test result easily. We want to have a known place to do the performance related test for scheduler. Developers should just run one script to collect all the information they need. We have the following plans for writing scheduler tests: density test (by adding a new Go test) schedule 30k pods on 1000 (fake) nodes and 3k pods on 100 (fake) nodes print out scheduling rate every second let you learn the rate changes vs number of scheduled pods benchmark (by modifying the existing benchmark in integration or simply add a new one) make use of and report nanosecond/op. schedule b.N pods when the cluster has N nodes and P scheduled pods. Since it takes relatively long time to finish one round, b.N is small -- level of 10. We are new to k8s codebase. We also want to know where is the best place (directory) to commit in these tests? Any suggestions are welcomed!\n/cc\nThis extends\nSo density already does this... the one option it looks like you may want is custom control , real or fake is irrelevant as the e2e's just need to point to an api-server. re: benchmarks, seems like we could simply add to the unit-tests.\nAfter chatting with lets add this as an agenda item for the SIG meeting tomorrow.\n+1 for adding benchmark (howeveer this should be integration test, not unit-test in my opinion)\ncc The next SIG on scheduler meeting is on 12.07, isn't it? If there is one tomorrow, can I have the information please?\nretract, +1 to . I was adding this to the list given the context, but it crosses over into both.\nSlides from today's meeting:\nHere are are the action item notes from the SIG meeting: Everyone agrees this is a good idea and long overdue, but the question is where would this live: New category of tests? (isolated/sandbox\u2019d/component) The current testing structure allows to easily append. create new directory (component) + hack/script to execute Future \"we could\" gate on known good data, and fail performance regressions\n/cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-680297b49a215c9cfb1528ef4979c0d18e911bef81f67b1fd58565fd68978733", "text": "} } } <del> func BenchmarkScheduling(b *testing.B) { framework.DeleteAllEtcdKeys() var m *master.Master s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { m.Handler.ServeHTTP(w, req) })) defer s.Close() masterConfig := framework.NewIntegrationTestMasterConfig() m = master.New(masterConfig) c := client.NewOrDie(&client.Config{ Host:         s.URL, GroupVersion: testapi.Default.GroupVersion(), QPS:          5000.0, Burst:        5000, }) schedulerConfigFactory := factory.NewConfigFactory(c, nil) schedulerConfig, err := schedulerConfigFactory.Create() if err != nil { b.Fatalf(\"Couldn't create scheduler config: %v\", err) } eventBroadcaster := record.NewBroadcaster() schedulerConfig.Recorder = eventBroadcaster.NewRecorder(api.EventSource{Component: \"scheduler\"}) eventBroadcaster.StartRecordingToSink(c.Events(\"\")) scheduler.New(schedulerConfig).Run() defer close(schedulerConfig.StopEverything) makeNNodes(c, 1000) N := b.N b.ResetTimer() makeNPods(c, N) for { objs := schedulerConfigFactory.ScheduledPodLister.Store.List() if len(objs) >= N { fmt.Printf(\"%v pods scheduled.n\", len(objs)) /* // To prove that this actually works: for _, o := range objs { fmt.Printf(\"%sn\", o.(*api.Pod).Spec.NodeName) } */ break } time.Sleep(time.Millisecond) } b.StopTimer() } func makeNNodes(c client.Interface, N int) { baseNode := &api.Node{ ObjectMeta: api.ObjectMeta{ GenerateName: \"scheduler-test-node-\", }, Spec: api.NodeSpec{ ExternalID: \"foobar\", }, Status: api.NodeStatus{ Capacity: api.ResourceList{ api.ResourcePods:   *resource.NewQuantity(32, resource.DecimalSI), api.ResourceCPU:    resource.MustParse(\"4\"), api.ResourceMemory: resource.MustParse(\"32Gi\"), }, Phase: api.NodeRunning, Conditions: []api.NodeCondition{ {Type: api.NodeReady, Status: api.ConditionTrue}, }, }, } for i := 0; i < N; i++ { if _, err := c.Nodes().Create(baseNode); err != nil { panic(\"error creating node: \" + err.Error()) } } } func makeNPods(c client.Interface, N int) { basePod := &api.Pod{ ObjectMeta: api.ObjectMeta{ GenerateName: \"scheduler-test-pod-\", }, Spec: api.PodSpec{ Containers: []api.Container{{ Name:  \"pause\", Image: \"gcr.io/google_containers/pause:1.0\", Resources: api.ResourceRequirements{ Limits: api.ResourceList{ api.ResourceCPU:    resource.MustParse(\"100m\"), api.ResourceMemory: resource.MustParse(\"500Mi\"), }, Requests: api.ResourceList{ api.ResourceCPU:    resource.MustParse(\"100m\"), api.ResourceMemory: resource.MustParse(\"500Mi\"), }, }, }}, }, } wg := sync.WaitGroup{} threads := 30 wg.Add(threads) remaining := make(chan int, N) go func() { for i := 0; i < N; i++ { remaining <- i } close(remaining) }() for i := 0; i < threads; i++ { go func() { defer wg.Done() for { _, ok := <-remaining if !ok { return } for { _, err := c.Pods(\"default\").Create(basePod) if err == nil { break } } } }() } wg.Wait() } </del>", "commid": "kubernetes_pr_18458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8a1317e390e9571143fd6d82d56b72619936bbd931877828728e077c4c54d6b4", "query": "I'm running application with several env variables. One of them has a key ending with ==. Another variable has a comma separated list of email addresses. While perfectly valid on *nix and windows, we can't pass these values into Kubernetes run command. It fails with \"error: invalid env:\" Example command: The parsing in should be more robust\nI volunteer myself to fix this.\nMaybe they can be passed from file? I mean s'rsly.. you need to lits 20 variables by hand?? I've specified them in yaml file already, but kubectl-run have no way to specify it.. without this, deployment is totally impossible when you need to run migrations first!", "positive_passages": [{"docid": "doc-en-kubernetes-1f04cbfb325986150059894c05be7f10e540b95dc139bf8c3ae60ecb20a8c994", "text": "func parseEnvs(envArray []string) ([]api.EnvVar, error) { envs := []api.EnvVar{} for _, env := range envArray { <del> parts := strings.Split(env, \"=\") if len(parts) != 2 || !validation.IsCIdentifier(parts[0]) || len(parts[1]) == 0 { </del> <ins> pos := strings.Index(env, \"=\") if pos == -1 { </ins> return nil, fmt.Errorf(\"invalid env: %v\", env) } <del> envVar := api.EnvVar{Name: parts[0], Value: parts[1]} </del> <ins> name := env[:pos] value := env[pos+1:] if len(name) == 0 || !validation.IsCIdentifier(name) || len(value) == 0 { return nil, fmt.Errorf(\"invalid env: %v\", env) } envVar := api.EnvVar{Name: name, Value: value} </ins> envs = append(envs, envVar) } return envs, nil", "commid": "kubernetes_pr_18997"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8a1317e390e9571143fd6d82d56b72619936bbd931877828728e077c4c54d6b4", "query": "I'm running application with several env variables. One of them has a key ending with ==. Another variable has a comma separated list of email addresses. While perfectly valid on *nix and windows, we can't pass these values into Kubernetes run command. It fails with \"error: invalid env:\" Example command: The parsing in should be more robust\nI volunteer myself to fix this.\nMaybe they can be passed from file? I mean s'rsly.. you need to lits 20 variables by hand?? I've specified them in yaml file already, but kubectl-run have no way to specify it.. without this, deployment is totally impossible when you need to run migrations first!", "positive_passages": [{"docid": "doc-en-kubernetes-f170dd73baf91cbb8b47cb5be66947022a231dc71697b76165f3c81a356329e9", "text": "} } } <ins> func TestParseEnv(t *testing.T) { tests := []struct { envArray  []string expected  []api.EnvVar expectErr bool test      string }{ { envArray: []string{ \"THIS_ENV=isOK\", \"HAS_COMMAS=foo,bar\", \"HAS_EQUALS=jJnro54iUu75xNy==\", }, expected: []api.EnvVar{ { Name:  \"THIS_ENV\", Value: \"isOK\", }, { Name:  \"HAS_COMMAS\", Value: \"foo,bar\", }, { Name:  \"HAS_EQUALS\", Value: \"jJnro54iUu75xNy==\", }, }, expectErr: false, test:      \"test case 1\", }, { envArray: []string{ \"WITH_OUT_EQUALS\", }, expected:  []api.EnvVar{}, expectErr: true, test:      \"test case 2\", }, { envArray: []string{ \"WITH_OUT_VALUES=\", }, expected:  []api.EnvVar{}, expectErr: true, test:      \"test case 3\", }, { envArray: []string{ \"=WITH_OUT_NAME\", }, expected:  []api.EnvVar{}, expectErr: true, test:      \"test case 4\", }, } for _, test := range tests { envs, err := parseEnvs(test.envArray) if !test.expectErr && err != nil { t.Errorf(\"unexpected error: %v (%s)\", err, test.test) } if test.expectErr && err != nil { continue } if !reflect.DeepEqual(envs, test.expected) { t.Errorf(\"nexpected:n%#vnsaw:n%#v (%s)\", test.expected, envs, test.test) } } } </ins>", "commid": "kubernetes_pr_18997"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-716ca225a252153ae82ca602b3860ed212a55f6220331030249e6fc7ae53f83d", "query": "Have not reproduced locally even after a few tens of runs.\nwhich version of Go are you using locally? This probably only repros on 1.5.1.\nThis was from Jenkins runs.\nThis is caused because an attempts counter is being read/written to without synchronization. I think this is caused by the event creation order not being guaranteed. I am looking a little deeper to track this down.\nGot a fix with 130k+ runs and no failures. Will send out PR shortly.", "positive_passages": [{"docid": "doc-en-kubernetes-011c6819da0d37c896c1382263d6beb095d37fa9a578eace4ab8c28bb736487d", "text": "eventCorrelator := NewEventCorrelator(util.RealClock{}) return eventBroadcaster.StartEventWatcher( func(event *api.Event) { <del> // Make a copy before modification, because there could be multiple listeners. // Events are safe to copy like this. eventCopy := *event event = &eventCopy result, err := eventCorrelator.EventCorrelate(event) if err != nil { util.HandleError(err) } if result.Skip { return } tries := 0 for { if recordEvent(sink, result.Event, result.Patch, result.Event.Count > 1, eventCorrelator) { break } tries++ if tries >= maxTriesPerEvent { glog.Errorf(\"Unable to write event '%#v' (retry limit exceeded!)\", event) break } // Randomize the first sleep so that various clients won't all be // synced up if the master goes down. if tries == 1 { time.Sleep(time.Duration(float64(sleepDuration) * randGen.Float64())) } else { time.Sleep(sleepDuration) } } </del> <ins> recordToSink(sink, event, eventCorrelator, randGen) </ins> }) } <ins> func recordToSink(sink EventSink, event *api.Event, eventCorrelator *EventCorrelator, randGen *rand.Rand) { // Make a copy before modification, because there could be multiple listeners. // Events are safe to copy like this. eventCopy := *event event = &eventCopy result, err := eventCorrelator.EventCorrelate(event) if err != nil { util.HandleError(err) } if result.Skip { return } tries := 0 for { if recordEvent(sink, result.Event, result.Patch, result.Event.Count > 1, eventCorrelator) { break } tries++ if tries >= maxTriesPerEvent { glog.Errorf(\"Unable to write event '%#v' (retry limit exceeded!)\", event) break } // Randomize the first sleep so that various clients won't all be // synced up if the master goes down. if tries == 1 { time.Sleep(time.Duration(float64(sleepDuration) * randGen.Float64())) } else { time.Sleep(sleepDuration) } } } </ins> func isKeyNotFoundError(err error) bool { statusErr, _ := err.(*errors.StatusError) // At the moment the server is returning 500 instead of a more specific", "commid": "kubernetes_pr_19368"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-716ca225a252153ae82ca602b3860ed212a55f6220331030249e6fc7ae53f83d", "query": "Have not reproduced locally even after a few tens of runs.\nwhich version of Go are you using locally? This probably only repros on 1.5.1.\nThis was from Jenkins runs.\nThis is caused because an attempts counter is being read/written to without synchronization. I think this is caused by the event creation order not being guaranteed. I am looking a little deeper to track this down.\nGot a fix with 130k+ runs and no failures. Will send out PR shortly.", "positive_passages": [{"docid": "doc-en-kubernetes-57ec4e332b5084ce82e4167e8a76c8b2120d36db60d48e45d20fd251394eaa1f", "text": "import ( \"encoding/json\" \"fmt\" <del> \"runtime\" </del> <ins> \"math/rand\" </ins> \"strconv\" \"testing\" \"time\"", "commid": "kubernetes_pr_19368"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-716ca225a252153ae82ca602b3860ed212a55f6220331030249e6fc7ae53f83d", "query": "Have not reproduced locally even after a few tens of runs.\nwhich version of Go are you using locally? This probably only repros on 1.5.1.\nThis was from Jenkins runs.\nThis is caused because an attempts counter is being read/written to without synchronization. I think this is caused by the event creation order not being guaranteed. I am looking a little deeper to track this down.\nGot a fix with 130k+ runs and no failures. Will send out PR shortly.", "positive_passages": [{"docid": "doc-en-kubernetes-e91b43f04052cb0e0f61297cd1bb6cdcc764f939b0a483ad7c047b0bd717bd8e", "text": "} func TestWriteEventError(t *testing.T) { <del> ref := &api.ObjectReference{ Kind:       \"Pod\", Name:       \"foo\", Namespace:  \"baz\", UID:        \"bar\", APIVersion: \"version\", } </del> type entry struct { timesToSendError int <del> attemptsMade     int </del> attemptsWanted   int err              error }", "commid": "kubernetes_pr_19368"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-716ca225a252153ae82ca602b3860ed212a55f6220331030249e6fc7ae53f83d", "query": "Have not reproduced locally even after a few tens of runs.\nwhich version of Go are you using locally? This probably only repros on 1.5.1.\nThis was from Jenkins runs.\nThis is caused because an attempts counter is being read/written to without synchronization. I think this is caused by the event creation order not being guaranteed. I am looking a little deeper to track this down.\nGot a fix with 130k+ runs and no failures. Will send out PR shortly.", "positive_passages": [{"docid": "doc-en-kubernetes-30c38c98fd647e0012edaa7c556e7762ff4f622e8236e90d7b1fd82dd9b6247a", "text": "err:              fmt.Errorf(\"A weird error\"), }, } <del> done := make(chan struct{}) eventBroadcaster := NewBroadcaster() defer eventBroadcaster.StartRecordingToSink( &testEventSink{ </del> <ins> eventCorrelator := NewEventCorrelator(util.RealClock{}) randGen := rand.New(rand.NewSource(time.Now().UnixNano())) for caseName, ent := range table { attempts := 0 sink := &testEventSink{ </ins> OnCreate: func(event *api.Event) (*api.Event, error) { <del> if event.Message == \"finished\" { close(done) return event, nil } item, ok := table[event.Message] if !ok { t.Errorf(\"Unexpected event: %#v\", event) return event, nil } item.attemptsMade++ if item.attemptsMade < item.timesToSendError { return nil, item.err </del> <ins> attempts++ if attempts < ent.timesToSendError { return nil, ent.err </ins> } return event, nil }, <del> }, ).Stop() clock := &util.FakeClock{time.Now()} recorder := recorderWithFakeClock(api.EventSource{Component: \"eventTest\"}, eventBroadcaster, clock) for caseName := range table { clock.Step(1 * time.Second) recorder.Event(ref, api.EventTypeNormal, \"Reason\", caseName) runtime.Gosched() } recorder.Event(ref, api.EventTypeNormal, \"Reason\", \"finished\") <-done for caseName, item := range table { if e, a := item.attemptsWanted, item.attemptsMade; e != a { t.Errorf(\"case %v: wanted %v, got %v attempts\", caseName, e, a) </del> <ins> } ev := &api.Event{} recordToSink(sink, ev, eventCorrelator, randGen) if attempts != ent.attemptsWanted { t.Errorf(\"case %v: wanted %d, got %d attempts\", caseName, ent.attemptsWanted, attempts) </ins> } } }", "commid": "kubernetes_pr_19368"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e505295a05058bec1cba89d2e6a4b223262484cf137dc1e912f1c7462280605a", "query": "Currently scheduler latency are observed regardless of failure. For example, binding latency is like: This could be a potential confusion if latency spikes happen because of failure. We should better handle it like separating error case from normal\n/cc\nI completely agree - are you going to change this?\nYes. I will do it.", "positive_passages": [{"docid": "doc-en-kubernetes-1aa67e7da57a6926f5eb84cc30c032433baff7c08ec249903c7f9422a484f221", "text": "var BindingSaturationReportInterval = 1 * time.Second var ( <del> E2eSchedulingLatency = prometheus.NewSummary( prometheus.SummaryOpts{ </del> <ins> E2eSchedulingLatency = prometheus.NewHistogram( prometheus.HistogramOpts{ </ins> Subsystem: schedulerSubsystem, Name:      \"e2e_scheduling_latency_microseconds\", Help:      \"E2e scheduling latency (scheduling algorithm + binding)\", <del> MaxAge:    time.Hour, </del> <ins> Buckets:   prometheus.ExponentialBuckets(1000, 2, 15), </ins> }, ) <del> SchedulingAlgorithmLatency = prometheus.NewSummary( prometheus.SummaryOpts{ </del> <ins> SchedulingAlgorithmLatency = prometheus.NewHistogram( prometheus.HistogramOpts{ </ins> Subsystem: schedulerSubsystem, Name:      \"scheduling_algorithm_latency_microseconds\", Help:      \"Scheduling algorithm latency\", <del> MaxAge:    time.Hour, </del> <ins> Buckets:   prometheus.ExponentialBuckets(1000, 2, 15), </ins> }, ) <del> BindingLatency = prometheus.NewSummary( prometheus.SummaryOpts{ </del> <ins> BindingLatency = prometheus.NewHistogram( prometheus.HistogramOpts{ </ins> Subsystem: schedulerSubsystem, Name:      \"binding_latency_microseconds\", Help:      \"Binding latency\", <del> MaxAge:    time.Hour, </del> <ins> Buckets:   prometheus.ExponentialBuckets(1000, 2, 15), </ins> }, ) BindingRateLimiterSaturation = prometheus.NewGauge(", "commid": "kubernetes_pr_19263"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e505295a05058bec1cba89d2e6a4b223262484cf137dc1e912f1c7462280605a", "query": "Currently scheduler latency are observed regardless of failure. For example, binding latency is like: This could be a potential confusion if latency spikes happen because of failure. We should better handle it like separating error case from normal\n/cc\nI completely agree - are you going to change this?\nYes. I will do it.", "positive_passages": [{"docid": "doc-en-kubernetes-bb1327adc32cb590cccc093a74a391d75fa1a2c72ee21374c94eb147af07655f", "text": "glog.V(3).Infof(\"Attempting to schedule: %+v\", pod) start := time.Now() <del> defer func() { metrics.E2eSchedulingLatency.Observe(metrics.SinceInMicroseconds(start)) }() </del> dest, err := s.config.Algorithm.Schedule(pod, s.config.NodeLister) <del> metrics.SchedulingAlgorithmLatency.Observe(metrics.SinceInMicroseconds(start)) </del> if err != nil { glog.V(1).Infof(\"Failed to schedule: %+v\", pod) s.config.Recorder.Eventf(pod, api.EventTypeWarning, \"FailedScheduling\", \"%v\", err) s.config.Error(pod, err) return } <ins> metrics.SchedulingAlgorithmLatency.Observe(metrics.SinceInMicroseconds(start)) </ins> b := &api.Binding{ ObjectMeta: api.ObjectMeta{Namespace: pod.Namespace, Name: pod.Name}, Target: api.ObjectReference{", "commid": "kubernetes_pr_19263"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e505295a05058bec1cba89d2e6a4b223262484cf137dc1e912f1c7462280605a", "query": "Currently scheduler latency are observed regardless of failure. For example, binding latency is like: This could be a potential confusion if latency spikes happen because of failure. We should better handle it like separating error case from normal\n/cc\nI completely agree - are you going to change this?\nYes. I will do it.", "positive_passages": [{"docid": "doc-en-kubernetes-8f07e6057d1d00a5e65c8d782c645c5555ee43241a25b1b7b0b9ebe5a73042e5", "text": "s.config.Modeler.LockedAction(func() { bindingStart := time.Now() err := s.config.Binder.Bind(b) <del> metrics.BindingLatency.Observe(metrics.SinceInMicroseconds(bindingStart)) </del> if err != nil { glog.V(1).Infof(\"Failed to bind pod: %+v\", err) s.config.Recorder.Eventf(pod, api.EventTypeNormal, \"FailedScheduling\", \"Binding rejected: %v\", err) s.config.Error(pod, err) return } <ins> metrics.BindingLatency.Observe(metrics.SinceInMicroseconds(bindingStart)) </ins> s.config.Recorder.Eventf(pod, api.EventTypeNormal, \"Scheduled\", \"Successfully assigned %v to %v\", pod.Name, dest) // tell the model to assume that this binding took effect. assumed := *pod assumed.Spec.NodeName = dest s.config.Modeler.AssumePod(&assumed) }) <ins> metrics.E2eSchedulingLatency.Observe(metrics.SinceInMicroseconds(start)) </ins> }", "commid": "kubernetes_pr_19263"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4030aa11852f25ec651e1fc5dd667b4297fe2300b704273273cd2ebda6e02fe8", "query": "I'll take a look at the failed builds and triage.\nI went through the recent reboot failures in kubernetes-e2e-gke-ci-reboot and here is a summary. [6481, 6486, 6488] Kubelet never came back from the reboot, and stopped posting node status. Throughout the test suite, the failed node stayed silent: It's hard to dig further due to the lack of clarity. Gathering log would at least help us rule out some possible causes . [6485] Heapster seems to crash loop quite frequently, and sometimes it failed the test (due to being not ready).. cc [6487] kube-proxy pod is running but not ready before the reboot test even started: This is not really a reboot test failure since the cluster was already in a bad state. We should make sure all the pods are ready after each test (e.g. \"should work after restarting kube-proxy\" ran before the failed reboot test). Another thing that would help is to increase the log level of the gke cluster. The log level of a gce cluster is 4, but I think gke is at the regular 2. Due to the low log level, it's unclear when kube-proxy started failing the readiness probe.\nFiled for (3).\nThe reboot tests basically haven't worked since 9pm last night: Interestingly, this lines up with the GKE equivalent for , but in that same window, has had no trouble. cc\nDigging into logs from the runs linked.\nAll of the gke-ci failures in are heapster crash-looping after a reboot.\nChanges to the heapster config in the last day: , . Nothing sticks out to me in those PRs.\nHeapster could be in crashloop if it cannot reach influxdb. But that is a bad design, and should fix it in today's heapster with image 18. I double checked them, it is image version 18.\nFrom , could be the num_nodes is unset, we give heapster no resource to run? If that is true, it could be point to the same version screw issue of our test infra.\nHeapster v0.18.4 will crashloop if InfluxDB isn't available. However we can update HEAD to v0.19.0, which will not crash if the backend goes down. I will send a PR to update InfluxDB version. , Dawn Chen wrote:\nGKE doesn't use InfluxDB, right?\nHeapster is the only kube-system pod that's not ready in the tests. If it relies on influxdb, shouldn't influxdb be not ready too?\nI like theory. My salt suggestion might've been horrible for unset ? I thought I did that correctly, but maybe my Python/Jinja was bad.\nYes, GKE doesn't use influxDB. My point is that if the backend storage is not ready, heapster is in crashloop. Vishnu made some changes to make heapster can run standalone, but looks like that fix is not included in heapster 18 based on his comment.\nOkay. I'm still trying to catch up. Why is heapster on GKE waiting on backend storage? And if is unset (e.g. we haven't finished running configure-), it looks like we just give the\nCatching others up: is seeing nodes that are actually hung with CPU pegged on reboot, so the heapster conversation may be a red herring.\nThere are plenty of tests that failed because kubelet didn't come back (and post status) after the reboot. There are a few that failed only because heapster was crash looping. They may be related or not...\nI spun up a GKE test cluster: and the heapster manifest looks fine, so I think I ruled out anything regarding\nI think is the winner. The reboot tests are a red herring.\nI'm actually just seeing heapster flap on a fresh cluster, no reboots.\nHeapster crashlooping is one problem. There are other cases, however, where kubelet just stops posting status all together. If heapster crashlooping can render kubelet unresponsive, that's a bug.\nis the serial console output from the node that got pegged (in ). I rebooted the node to see if it would repro, and it came back up fine. EDIT: the link to the jenkins run.\nI guess the serial console you posted is from build , the very recent one. I saw a similar one and the node never successfully come back. At this moment, I ignore those failures. The reboot failure caused by heapster crashloop is similar to what I observed 2 days ago for influxdb in gce cluster. The comment is at Can we retitle this one for (1)? Reboot test flakiness is caused by many reasons: version screw which is handled by test-infra, heapster and influxdb crashloop is handled by , kube-proxy not ready is handled by cluster team.\nOk. So we think we have the heapster flakes, versioning stuff, and kube-proxy stuff all taken care of elsewhere? I'm fine with targeting this issue at the \"node doesn't come back after reboot\" case. Is that what you were recommending?\nYes. 1) heapster in crashloop if backend is not ready is a known issue for a while, and fix is merged to heapster repositry for a while. We just need to upgrade our heapster after more testing (PR: ) 2) influxdb one requires more information, but we can handle them through 3) version screw is handled by test-infra through . already test/flake label for it 4) kube-proxy readiness issue is handled through\nwhere else should I be looking for hints on why that VM didn't come back to life until I kicked it? Or did I destroy any evidence we might have had?\nFun fact: I thought this might be related the timing of when I made the ContainerVM change on the GKE side, but I made that change for all releases 1.1.4. That picks up this test suite, too, because it's at , and it's green: So this is a divergence from master to 1.1, or between projects.\nThat suite does not run any reboot tests...\nDammit, I thought I scanned for that. Good call. We need to fix that.\nHere's the set of suites that run the reboot tests (thanks kubernetes-e2e-gce kubernetes-e2e-gce-reboot kubernetes-e2e-gke-ci kubernetes-e2e-gke-ci-reboot\nShouldn't we decided only X-reboot test suites run those reboot tests since they are disruptive?\nHm. builds 6478-6480 are all green and all after the (GKE-side) ContainerVM change, so we're looking for something else.\nThe container-vm change was merged at , which lines up with kubernetes-e2e-gke-ci-reboot 6481 (the beginning of the failures).\n6481 is the one with the new containervm change. It includes kubernetes-build/7822, which has the change.\n/ That's the OSS side change, which is irrelevant. GKE flipped at 19:45:55.\nAhhh. Fair enough.\nActually, and I just determined that the GKE-side change didn't make it out until 01:45:44, it looks like, so indeed nothing to do with ContainerVM.\nI took a more careful look at the serial output pasted, and this is interesting: We're actually in the middle of a clean shutdown, trying to unmount and failing. This same stacktrace repeats every 120s.\nI spun up an e2e cluster and with minimal testing have a node in the state of It's the same kernel hang on shutdown. ... and then I accidentally deleted it when I went to bisect, but ohwell. I'm sure I'll be able to get one back if I need.\nOkay, so I've confirmed that at the build level at , I can spin up a GKE cluster and reboot tests fail. I'm going to peel back to and see if they pass (because that matches ). ETA: For reference, I'm able to tickle this with just:\n7819 had a kernel hang on the second run as well, though slightly different signature (still aufs in the end):\nFor my next test, I'm peeling back to v1.1.4. We have no test coverage on reboots on the release branch of GKE right now, and I just want to guarantee this isn't some weird GCE hypervisor issue. And v1.1.4 is clean, at least for two runs worth.\nThis failed quickly on v1.1.5. Hrm. I'm wondering if my v1.1.4 test was a fluke, peeling back to try it there again. v1.1.5 only differs by ContainerVM (and go 1.4.3 vs 1.4.2), but all of our other timelines show that not being directly related. (Alternately, it's a lot easier on the newer kernel.) (Still no idea why the tests aren't triggered, but is.)\nwas very solid. I'm now trying on GKE test. This is a GKE unique thing, because after Friday morning at 1am, anything = will get deployed using the new ContainerVM. So I'm ret-conning a way to effectively try with the new ContainerVM, just to see if it's a contributing factor. It doesn't look like it should be. One of the other commits in the stream is a heapster version bump (from / ). If there's additional flapping or something caused by that (unique to GKE), it may be causing the hang. But that timeline doesn't match the line (relevant to , etc.)\nBad news bears: failed reboot tests. I'm having trouble rectifying this information with what we know about the timeline. But it does suggest there's a problem with ContainerVM at the very least, so there might be two problems here, so I'm rolling one back on GKE and we'll see what happens.\nI've manually confirmed that by reverting deployment of on GKE, I can run reboot tests at and a latest build. Using a special build of latest that will still trigger deployment of , reboot tests fail. Well, damn.\nGKE has been repushed and should, in theory, go back green soon. There's a lot I don't understand about this bug, and it's effectively going to stop us shipping and until we can figure it out.\nOkay, I think that reverting was not all that's necessary. We unfortunately haven't managed to collect a green on yet. That gives me some comfort, because it means that the timeline-discomfort I had previously was founded.\nHeh, I lied and right right writing that we collected our first one. Woo. I suspect will follow soon.\nHaven't we updated go to 1.5 on Friday as well? I don't know if we use the same version of go for GKE as we do in GKE, but in general we know it causes trouble. cc for Heapster thing.\nThe timeline there is off, too. The golang1.5.3 PR went in at , which is well after the trouble started.\nMorning status: Looks like we made a little greener, and didn't touch , so the patient had two viruses.\nOkay, this is my suspicion, but I can't quite piece together what's going on: For some reason, something in (? but that busted the Heapster config, so it's confusing me as to why), caused this. I'm basing this on: the timeline of the timeline of If you suppose that we injected a bug in build 7820 that caused about a 60-70% cointoss as to whether we regress (which is similar to the rate we're seeing now that has been rolled back on GKE), it's not unreasonable that was green for , and that's the only one you have to explain away on this theory. After that, it goes kind of red, and then at about 1am, comes in and wrecks completely as well. Pulling it back much further, to, say, build 7819, and you have to explain the entire range from 6477-6480 as green, which is a much lower probability. So my money is on build 7820. (7821 is revision-equivalent, so boring to talk about.)\nOh. It is Heapster. I spun up a 7819 cluster and a 7820 cluster, and the difference is that even though still had slightly busted Salt syntax, it was functional enough to create the replication controller, whereas on 7819, there's no Heapster replication controller at all. So I think the Heapster flapping is entirely the cause of the remaining issues, so we really need to get in ASAP.\nSo yesterday afternoon I was wondering why build 7820 triggered such a large regression when, say, the bump to heapster in didn't regress us at all. Build 7820 finally let the the fix in , which was actually important because GKE at HEAD wasn't deploying (until last night), it was deploying only , so the pillar wasn't configured. I'm still not exactly sure what's going on here, and I had intentionally left blank for a while during this investigation because it didn't seem like it should matter, but it's obvious that if 7820 is the culprit that it's interesting. I pushed a fix last night to GKE that adds on 1.2 clusters as well, and we've collected our first green dot. I don't know why is still flakey, though.\nEr, correction to my last comment. My change didn't make it out last night and won't be relevant until . The green is a fluke. Sad panda.\nPR introduced syntax error, PR fixed the error although it introduced another syntax issue which was finally fixed in . if you are testing anything make sure you are using version with merged. I agree with that the problem is not with Heapster accessing InfluxDB. Also the same problem takes places in autoscaling suite (described here ). We started observing such problems around Jan 19th. AFAIK once the container crashes kubelet invoke docker inspect on the failing container. How about invoking also docker logs then? It would be very useful for debugging purposes.\nYes, I understand that fixed the issue fully, but at build 7820 the cluster that's created actually spins up a cluster with a replication controller .yaml with resources. At build 7819, it doesn't. The syntax in is busted, but it's apparently not so busted. Previous to , in build 7819 (and builds previous), there was no controller .yaml at all, so there was a window where GKE wasn't spinning up Heapster at all. Hence my conclusion.\nThe syntax in is correct from Salt point of view, although the generated file has empty line in the begging and is not accepted by Api Server, so the RC is not created.\nThat's inconsistent with the fact that Heapster is starting on a 7820 (GKE) cluster.\nI have a new theory, which is that Heapster hasn't been running on GKE in 1.2 since , until .\nIt's not clear to me that upgrading heapster will solve this issue, since heapster doesn't rely on any backend on gke. Instead of asking kubelet to do that, it makes more sense for the test itself to get the logs through the apiserver. I think we should add that to the e2e test.\nI spun up a cluster from just prior to and this is the set of RCs I see: So basically, when went in, Heapster was enabled for the first time in GKE (master, not the release branches) in months and we started flipping out. This is a serious test coverage issue, obviously.\nI edited the above comment, but we would obviously catch this in the release branches because we have monitoring tied to Heapster related things. We need to be better here for CI.\nI made some investigation. The problem with crashlooping Heapster is due to: The issue was fixed in I'll create a patch release and bump the version.\nIt looks like is green. I'm hoping that , which is the first build past , will go green as well. (The cycle time on that build is waaaaay too long.)\nIt looks like we're good! is green now!\nfor node problem detector.", "positive_passages": [{"docid": "doc-en-kubernetes-ebc66d77e24ab237c98b3959ba34cfd7e3f3de49272b21894bcb582cbeb1e76d", "text": "apiVersion: v1 kind: ReplicationController metadata: <del> name: heapster-v11 </del> <ins> name: heapster-v12 </ins> namespace: kube-system labels: k8s-app: heapster <del> version: v11 </del> <ins> version: v12 </ins> kubernetes.io/cluster-service: \"true\" spec: replicas: 1 selector: k8s-app: heapster <del> version: v11 </del> <ins> version: v12 </ins> template: metadata: labels: k8s-app: heapster <del> version: v11 </del> <ins> version: v12 </ins> kubernetes.io/cluster-service: \"true\" spec: containers: <del> - image: gcr.io/google_containers/heapster:v0.18.4 </del> <ins> - image: gcr.io/google_containers/heapster:v0.18.5 </ins> name: heapster resources: # keep request = limit to keep this container in guaranteed class", "commid": "kubernetes_pr_20109"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f10bead500960ea3dde1ad0ae7083423c7980e31d3345e62b31b741d2afc29a2", "query": "I noticed this flake by looking at the submit queue. The test is simple, but when it fails, we have no good way to debug it. Below is the test in question. When the test fails, we should print the lines we got in each case.", "positive_passages": [{"docid": "doc-en-kubernetes-ad312c9b8752a10351c04c7fff0d1a3dbb6c3a97d2acaedd78373c30ebe599b2", "text": "By(\"restricting to a time range\") time.Sleep(1500 * time.Millisecond) // ensure that startup logs on the node are seen as older than 1s <del> out = runKubectlOrDie(\"log\", pod.Name, containerName, nsFlag, \"--since=1s\") recent := len(strings.Split(out, \"n\")) out = runKubectlOrDie(\"log\", pod.Name, containerName, nsFlag, \"--since=24h\") older := len(strings.Split(out, \"n\")) Expect(recent).To(BeNumerically(\"<\", older)) </del> <ins> recent_out := runKubectlOrDie(\"log\", pod.Name, containerName, nsFlag, \"--since=1s\") recent := len(strings.Split(recent_out, \"n\")) older_out := runKubectlOrDie(\"log\", pod.Name, containerName, nsFlag, \"--since=24h\") older := len(strings.Split(older_out, \"n\")) Expect(recent).To(BeNumerically(\"<\", older), \"expected recent(%v) to be less than older(%v)nrecent lines:n%vnolder lines:n%vn\", recent, older, recent_out, older_out) </ins> }) }) })", "commid": "kubernetes_pr_20289"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1b2bcc3aa22e5d5f53df9233e5f80a56f1f4bdaeb462b3a5016092de1417360c", "query": "hack/build-cross sets it without looking at the current value. And the value has to be an array, which is a bit awkward to use.\nThis could be improved indeed. Maybe something like and Haven't tested it though... But why would one want to change the value?\nI just wanted to build one, so I did the \"obvious\" thing: hack/dev-build-and-` It failed for multiple reasons :) , Lucas K\u00e4ldstr\u00f6m wrote:\nThis issue has been a major downer for me. It's much harder right now than it ought to be to articulate the few platforms for which you'd like to build each of server binaries, client binaries, test binaries, etc. Every time I've tried to do this \"the right way,\" I've spent hours looking at scripts and feeling frustrated that build options aren't documented better. Every time, I end up cutting my losses and resorting to temporary build script hacks instead, just to get the job done.\nDoesn't fix this issue exactly, but I've found that you can easily build only if you set .\nTaking a look at this today, I also thought that setting seems to be the most reasonable.\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-d35fa71ee8824da4b40155b19d1ccd789d268fb5501f57faebeb2059c716bfd1", "text": "readonly KUBE_NODE_BINARIES=(\"${KUBE_NODE_TARGETS[@]##*/}\") readonly KUBE_NODE_BINARIES_WIN=(\"${KUBE_NODE_BINARIES[@]/%/.exe}\") <del> if [[ \"${KUBE_FASTBUILD:-}\" == \"true\" ]]; then </del> <ins> if [[ -n \"${KUBE_BUILD_PLATFORMS:-}\" ]]; then readonly KUBE_SERVER_PLATFORMS=(${KUBE_BUILD_PLATFORMS}) readonly KUBE_NODE_PLATFORMS=(${KUBE_BUILD_PLATFORMS}) readonly KUBE_TEST_PLATFORMS=(${KUBE_BUILD_PLATFORMS}) readonly KUBE_CLIENT_PLATFORMS=(${KUBE_BUILD_PLATFORMS}) elif [[ \"${KUBE_FASTBUILD:-}\" == \"true\" ]]; then </ins> readonly KUBE_SERVER_PLATFORMS=(linux/amd64) readonly KUBE_NODE_PLATFORMS=(linux/amd64) if [[ \"${KUBE_BUILDER_OS:-}\" == \"darwin\"* ]]; then", "commid": "kubernetes_pr_46862"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-124a8f04c015bf597a839b5fc96d254a778164bb355fa6ee63ad65e704649190", "query": "The delete command for a replicaset hangs forever. This then manifests as phantom RSs when I delete and recreate a namespace.\n- delete is the gift that keeps on giving\ncc\nHad you already deleted the corresponding Deployment?\nI am still seeing this problem. Deployments and replica sets are sticking.\nFrom what I can tell, calling DELETE_COLLECTION on Deployments is returning: And since the controller assumes not found errors are equivalent to already deleted, it thinks the content is deleted. When I manually inspect, I still see the deployment and replica set laying around... //cc\nholding on this while i debug some more...\nThis was a false alarm, apologies.", "positive_passages": [{"docid": "doc-en-kubernetes-d7360ea6d6c919fd207a3604048922d88ad5448942a504e7efea9b7df4d6267d", "text": "pendingActionSet.Insert( strings.Join([]string{\"delete-collection\", \"daemonsets\", \"\"}, \"-\"), strings.Join([]string{\"delete-collection\", \"deployments\", \"\"}, \"-\"), <ins> strings.Join([]string{\"delete-collection\", \"replicasets\", \"\"}, \"-\"), </ins> strings.Join([]string{\"delete-collection\", \"jobs\", \"\"}, \"-\"), strings.Join([]string{\"delete-collection\", \"horizontalpodautoscalers\", \"\"}, \"-\"), strings.Join([]string{\"delete-collection\", \"ingresses\", \"\"}, \"-\"),", "commid": "kubernetes_pr_21055"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-124a8f04c015bf597a839b5fc96d254a778164bb355fa6ee63ad65e704649190", "query": "The delete command for a replicaset hangs forever. This then manifests as phantom RSs when I delete and recreate a namespace.\n- delete is the gift that keeps on giving\ncc\nHad you already deleted the corresponding Deployment?\nI am still seeing this problem. Deployments and replica sets are sticking.\nFrom what I can tell, calling DELETE_COLLECTION on Deployments is returning: And since the controller assumes not found errors are equivalent to already deleted, it thinks the content is deleted. When I manually inspect, I still see the deployment and replica set laying around... //cc\nholding on this while i debug some more...\nThis was a false alarm, apologies.", "positive_passages": [{"docid": "doc-en-kubernetes-7b0dd7f5dbd61c679b18815a61960cfd66d03ff942834df5cc612747b6780028", "text": "mockClient := fake.NewSimpleClientset(testInput.testNamespace) if containsVersion(versions, \"extensions/v1beta1\") { resources := []unversioned.APIResource{} <del> for _, resource := range []string{\"daemonsets\", \"deployments\", \"jobs\", \"horizontalpodautoscalers\", \"ingresses\"} { </del> <ins> for _, resource := range []string{\"daemonsets\", \"deployments\", \"replicasets\", \"jobs\", \"horizontalpodautoscalers\", \"ingresses\"} { </ins> resources = append(resources, unversioned.APIResource{Name: resource}) } mockClient.Resources = map[string]*unversioned.APIResourceList{", "commid": "kubernetes_pr_21055"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-124a8f04c015bf597a839b5fc96d254a778164bb355fa6ee63ad65e704649190", "query": "The delete command for a replicaset hangs forever. This then manifests as phantom RSs when I delete and recreate a namespace.\n- delete is the gift that keeps on giving\ncc\nHad you already deleted the corresponding Deployment?\nI am still seeing this problem. Deployments and replica sets are sticking.\nFrom what I can tell, calling DELETE_COLLECTION on Deployments is returning: And since the controller assumes not found errors are equivalent to already deleted, it thinks the content is deleted. When I manually inspect, I still see the deployment and replica set laying around... //cc\nholding on this while i debug some more...\nThis was a false alarm, apologies.", "positive_passages": [{"docid": "doc-en-kubernetes-20886b1a54b6a6fea2936c5a404a98df3b86a18a193dca840028f706711462b5", "text": "return estimate, err } } <ins> if containsResource(resources, \"replicasets\") { err = deleteReplicaSets(kubeClient.Extensions(), namespace) if err != nil { return estimate, err } } </ins> } return estimate, nil }", "commid": "kubernetes_pr_21055"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-124a8f04c015bf597a839b5fc96d254a778164bb355fa6ee63ad65e704649190", "query": "The delete command for a replicaset hangs forever. This then manifests as phantom RSs when I delete and recreate a namespace.\n- delete is the gift that keeps on giving\ncc\nHad you already deleted the corresponding Deployment?\nI am still seeing this problem. Deployments and replica sets are sticking.\nFrom what I can tell, calling DELETE_COLLECTION on Deployments is returning: And since the controller assumes not found errors are equivalent to already deleted, it thinks the content is deleted. When I manually inspect, I still see the deployment and replica set laying around... //cc\nholding on this while i debug some more...\nThis was a false alarm, apologies.", "positive_passages": [{"docid": "doc-en-kubernetes-d558f7e679a7a08fbb9fc9335effb80ce7a7605162c83bf10c9e5e7c2ae3f585", "text": "return expClient.Deployments(ns).DeleteCollection(nil, api.ListOptions{}) } <ins> func deleteReplicaSets(expClient extensions_unversioned.ExtensionsInterface, ns string) error { return expClient.ReplicaSets(ns).DeleteCollection(nil, api.ListOptions{}) } </ins> func deleteIngress(expClient extensions_unversioned.ExtensionsInterface, ns string) error { return expClient.Ingresses(ns).DeleteCollection(nil, api.ListOptions{}) }", "commid": "kubernetes_pr_21055"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-56abf1c19aeb772bfdf5543a20f43dcbe7bbdea78cd050790b056a5e979d3a30", "query": "http://pr- is another failure.\nAlso seen in http://pr-\nAgain. Not assigned to anyone, so I am sending to for routing\nAgain: Is there anyone working on this? I will spend some time looking into this.\nI think that the name of this issue is misleading - the issue seems to be unrelated to etcd_watcher Basically, if you look into this part of log: So it seems that, the WaitGroup that is problematic is in httptest.Server. So my feeling is that we are simply talking to a server that is already being close and this is ~roughly duplicate of We should just find where exactly the problem is and try to work-around it.\nI think this is exactly what we had before. I will send a PR with the fix today.", "positive_passages": [{"docid": "doc-en-kubernetes-fa29dbaf1f68f1094b74edc90b9e4c7d724f5a9da1b782e0631544c5a07fdd02", "text": "func TestClient(t *testing.T) { _, s := framework.RunAMaster(t) <del> defer s.Close() </del> <ins> // TODO: Uncomment when fix #19254 // defer s.Close() </ins> ns := api.NamespaceDefault framework.DeleteAllEtcdKeys()", "commid": "kubernetes_pr_21259"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-56abf1c19aeb772bfdf5543a20f43dcbe7bbdea78cd050790b056a5e979d3a30", "query": "http://pr- is another failure.\nAlso seen in http://pr-\nAgain. Not assigned to anyone, so I am sending to for routing\nAgain: Is there anyone working on this? I will spend some time looking into this.\nI think that the name of this issue is misleading - the issue seems to be unrelated to etcd_watcher Basically, if you look into this part of log: So it seems that, the WaitGroup that is problematic is in httptest.Server. So my feeling is that we are simply talking to a server that is already being close and this is ~roughly duplicate of We should just find where exactly the problem is and try to work-around it.\nI think this is exactly what we had before. I will send a PR with the fix today.", "positive_passages": [{"docid": "doc-en-kubernetes-f4d028b5b1309560e99b7143f8a068140491d08730d8e43ee670a7a791366fce", "text": "func TestSingleWatch(t *testing.T) { _, s := framework.RunAMaster(t) <del> defer s.Close() </del> <ins> // TODO: Uncomment when fix #19254 // defer s.Close() </ins> ns := \"blargh\" deleteAllEtcdKeys()", "commid": "kubernetes_pr_21259"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-56abf1c19aeb772bfdf5543a20f43dcbe7bbdea78cd050790b056a5e979d3a30", "query": "http://pr- is another failure.\nAlso seen in http://pr-\nAgain. Not assigned to anyone, so I am sending to for routing\nAgain: Is there anyone working on this? I will spend some time looking into this.\nI think that the name of this issue is misleading - the issue seems to be unrelated to etcd_watcher Basically, if you look into this part of log: So it seems that, the WaitGroup that is problematic is in httptest.Server. So my feeling is that we are simply talking to a server that is already being close and this is ~roughly duplicate of We should just find where exactly the problem is and try to work-around it.\nI think this is exactly what we had before. I will send a PR with the fix today.", "positive_passages": [{"docid": "doc-en-kubernetes-44d505dfad11f25e8977d0627b021585e0d05a9abfe242ed22c7db76f758817c", "text": "framework.DeleteAllEtcdKeys() defer framework.DeleteAllEtcdKeys() _, s := framework.RunAMaster(t) <del> defer s.Close() </del> <ins> // TODO: Uncomment when fix #19254 // defer s.Close() </ins> ns := api.NamespaceDefault client := client.NewOrDie(&client.Config{Host: s.URL, ContentConfig: client.ContentConfig{GroupVersion: testapi.Default.GroupVersion()}})", "commid": "kubernetes_pr_21259"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-56abf1c19aeb772bfdf5543a20f43dcbe7bbdea78cd050790b056a5e979d3a30", "query": "http://pr- is another failure.\nAlso seen in http://pr-\nAgain. Not assigned to anyone, so I am sending to for routing\nAgain: Is there anyone working on this? I will spend some time looking into this.\nI think that the name of this issue is misleading - the issue seems to be unrelated to etcd_watcher Basically, if you look into this part of log: So it seems that, the WaitGroup that is problematic is in httptest.Server. So my feeling is that we are simply talking to a server that is already being close and this is ~roughly duplicate of We should just find where exactly the problem is and try to work-around it.\nI think this is exactly what we had before. I will send a PR with the fix today.", "positive_passages": [{"docid": "doc-en-kubernetes-e4c3d6fa881908190861d750462cda2a30321e914c2da87cb87e21c85f2b0d43", "text": "func TestExperimentalPrefix(t *testing.T) { _, s := framework.RunAMaster(t) <del> defer s.Close() </del> <ins> // TODO: Uncomment when fix #19254 // defer s.Close() </ins> resp, err := http.Get(s.URL + \"/apis/extensions/\") if err != nil {", "commid": "kubernetes_pr_21259"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-56abf1c19aeb772bfdf5543a20f43dcbe7bbdea78cd050790b056a5e979d3a30", "query": "http://pr- is another failure.\nAlso seen in http://pr-\nAgain. Not assigned to anyone, so I am sending to for routing\nAgain: Is there anyone working on this? I will spend some time looking into this.\nI think that the name of this issue is misleading - the issue seems to be unrelated to etcd_watcher Basically, if you look into this part of log: So it seems that, the WaitGroup that is problematic is in httptest.Server. So my feeling is that we are simply talking to a server that is already being close and this is ~roughly duplicate of We should just find where exactly the problem is and try to work-around it.\nI think this is exactly what we had before. I will send a PR with the fix today.", "positive_passages": [{"docid": "doc-en-kubernetes-c5cfacfc94666286392440ca5c99f749f87451cebfe9173a090c5d7ac3ad1fb6", "text": "func TestWatchSucceedsWithoutArgs(t *testing.T) { _, s := framework.RunAMaster(t) <del> defer s.Close() </del> <ins> // TODO: Uncomment when fix #19254 // defer s.Close() </ins> resp, err := http.Get(s.URL + \"/api/v1/namespaces?watch=1\") if err != nil {", "commid": "kubernetes_pr_21259"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-56abf1c19aeb772bfdf5543a20f43dcbe7bbdea78cd050790b056a5e979d3a30", "query": "http://pr- is another failure.\nAlso seen in http://pr-\nAgain. Not assigned to anyone, so I am sending to for routing\nAgain: Is there anyone working on this? I will spend some time looking into this.\nI think that the name of this issue is misleading - the issue seems to be unrelated to etcd_watcher Basically, if you look into this part of log: So it seems that, the WaitGroup that is problematic is in httptest.Server. So my feeling is that we are simply talking to a server that is already being close and this is ~roughly duplicate of We should just find where exactly the problem is and try to work-around it.\nI think this is exactly what we had before. I will send a PR with the fix today.", "positive_passages": [{"docid": "doc-en-kubernetes-30af27f79b5fa46dada9eeef3c474ec72be9930047e15433de9c7b88e483ccc3", "text": "func TestAccept(t *testing.T) { _, s := framework.RunAMaster(t) <del> defer s.Close() </del> <ins> // TODO: Uncomment when fix #19254 // defer s.Close() </ins> resp, err := http.Get(s.URL + \"/api/\") if err != nil {", "commid": "kubernetes_pr_21259"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-56abf1c19aeb772bfdf5543a20f43dcbe7bbdea78cd050790b056a5e979d3a30", "query": "http://pr- is another failure.\nAlso seen in http://pr-\nAgain. Not assigned to anyone, so I am sending to for routing\nAgain: Is there anyone working on this? I will spend some time looking into this.\nI think that the name of this issue is misleading - the issue seems to be unrelated to etcd_watcher Basically, if you look into this part of log: So it seems that, the WaitGroup that is problematic is in httptest.Server. So my feeling is that we are simply talking to a server that is already being close and this is ~roughly duplicate of We should just find where exactly the problem is and try to work-around it.\nI think this is exactly what we had before. I will send a PR with the fix today.", "positive_passages": [{"docid": "doc-en-kubernetes-a072704031fb7f1d2c2a9b10f14f471ebfa5954d666f119cb7e47b20395ccfe5", "text": "func TestMasterProcessMetrics(t *testing.T) { _, s := framework.RunAMaster(t) <del> defer s.Close() </del> <ins> // TODO: Uncomment when fix #19254 // defer s.Close() </ins> metrics, err := scrapeMetrics(s) if err != nil {", "commid": "kubernetes_pr_21259"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-56abf1c19aeb772bfdf5543a20f43dcbe7bbdea78cd050790b056a5e979d3a30", "query": "http://pr- is another failure.\nAlso seen in http://pr-\nAgain. Not assigned to anyone, so I am sending to for routing\nAgain: Is there anyone working on this? I will spend some time looking into this.\nI think that the name of this issue is misleading - the issue seems to be unrelated to etcd_watcher Basically, if you look into this part of log: So it seems that, the WaitGroup that is problematic is in httptest.Server. So my feeling is that we are simply talking to a server that is already being close and this is ~roughly duplicate of We should just find where exactly the problem is and try to work-around it.\nI think this is exactly what we had before. I will send a PR with the fix today.", "positive_passages": [{"docid": "doc-en-kubernetes-0d675fe0f2ce234d3bb0767d7e74694adbb0ec9b1cd4dd072842ed25e8ee9952", "text": "func TestApiserverMetrics(t *testing.T) { _, s := framework.RunAMaster(t) <del> defer s.Close() </del> <ins> // TODO: Uncomment when fix #19254 // defer s.Close() </ins> // Make a request to the apiserver to ensure there's at least one data point // for the metrics we're expecting -- otherwise, they won't be exported.", "commid": "kubernetes_pr_21259"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-56abf1c19aeb772bfdf5543a20f43dcbe7bbdea78cd050790b056a5e979d3a30", "query": "http://pr- is another failure.\nAlso seen in http://pr-\nAgain. Not assigned to anyone, so I am sending to for routing\nAgain: Is there anyone working on this? I will spend some time looking into this.\nI think that the name of this issue is misleading - the issue seems to be unrelated to etcd_watcher Basically, if you look into this part of log: So it seems that, the WaitGroup that is problematic is in httptest.Server. So my feeling is that we are simply talking to a server that is already being close and this is ~roughly duplicate of We should just find where exactly the problem is and try to work-around it.\nI think this is exactly what we had before. I will send a PR with the fix today.", "positive_passages": [{"docid": "doc-en-kubernetes-47cea94ac5e65434685c617e73d9b7f1c5452ec6468319488d1e653ea664cfff", "text": "func TestPersistentVolumeRecycler(t *testing.T) { _, s := framework.RunAMaster(t) <del> defer s.Close() </del> <ins> // TODO: Uncomment when fix #19254 // defer s.Close() </ins> deleteAllEtcdKeys() // Use higher QPS and Burst, there is a test for race condition below, which", "commid": "kubernetes_pr_21259"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7ebf7acbde7789cdda053450cb89ee471a2ab525583ef16f7638edd03a598813", "query": "I'm following step by step tutorial on how to create resource quotas per namespace () looks like this: { \"apiVersion\": \"v1\", \"kind\": \"ResourceQuota\", \"metadata\": { \"name\": \"quota\", }, \"spec\": { \"hard\": { \"memory\": \"1Gi\", \"cpu\": \"20\", \"pods\": \"10\", \"services\": \"5\", \"replicationcontrollers\":\"20\", \"resourcequotas\":\"1\", }, } when i'm about to create quota it fails with: kubectl create -f --namespace=prod invalid character '}' looking for beginning of object key string Namespace \"prod\" exists: kubectl get namespace NAME LABELS STATUS AGE default &lt;noneActive 26d dev name=development Active 8d kube-system &lt;noneActive 26d prod name=production Active 8d kubectl version Client Version: version.Info{Major:\"1\", Minor:\"1\", GitVersion:\"v1.1.2\", GitCommit:\"\", GitTreeState:\"clean\"} Server Version: version.Info{Major:\"1\", Minor:\"1\", GitVersion:\"v1.1.2\", GitCommit:\"\", GitTreeState:\"clean\"}\nThose trailing commas are wrong. should look like: I'll submit a docs patch\nsweet. ta. That seem to do the trick: kubectl create -f --namespace=prod resourcequota \"quota\" created\nI'm going to reopen until the PR which fixes this merges, when it should autoclose...\nI'm following this tutorial on installing percona with kubectl, and I'm getting a similar error: When I run: kubectl create -f pmm-server- I get: error: json: line 1: invalid character \u2018\u00c2\u2019 looking for beginning of object key string", "positive_passages": [{"docid": "doc-en-kubernetes-708ab6b13e7b4be2147026b890fa9e148594788b5838ece69d729c71f50b4a45", "text": "\"apiVersion\": \"v1\", \"kind\": \"ResourceQuota\", \"metadata\": { <del> \"name\": \"quota\", </del> <ins> \"name\": \"quota\" </ins> }, \"spec\": { \"hard\": {", "commid": "kubernetes_pr_21388"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7ebf7acbde7789cdda053450cb89ee471a2ab525583ef16f7638edd03a598813", "query": "I'm following step by step tutorial on how to create resource quotas per namespace () looks like this: { \"apiVersion\": \"v1\", \"kind\": \"ResourceQuota\", \"metadata\": { \"name\": \"quota\", }, \"spec\": { \"hard\": { \"memory\": \"1Gi\", \"cpu\": \"20\", \"pods\": \"10\", \"services\": \"5\", \"replicationcontrollers\":\"20\", \"resourcequotas\":\"1\", }, } when i'm about to create quota it fails with: kubectl create -f --namespace=prod invalid character '}' looking for beginning of object key string Namespace \"prod\" exists: kubectl get namespace NAME LABELS STATUS AGE default &lt;noneActive 26d dev name=development Active 8d kube-system &lt;noneActive 26d prod name=production Active 8d kubectl version Client Version: version.Info{Major:\"1\", Minor:\"1\", GitVersion:\"v1.1.2\", GitCommit:\"\", GitTreeState:\"clean\"} Server Version: version.Info{Major:\"1\", Minor:\"1\", GitVersion:\"v1.1.2\", GitCommit:\"\", GitTreeState:\"clean\"}\nThose trailing commas are wrong. should look like: I'll submit a docs patch\nsweet. ta. That seem to do the trick: kubectl create -f --namespace=prod resourcequota \"quota\" created\nI'm going to reopen until the PR which fixes this merges, when it should autoclose...\nI'm following this tutorial on installing percona with kubectl, and I'm getting a similar error: When I run: kubectl create -f pmm-server- I get: error: json: line 1: invalid character \u2018\u00c2\u2019 looking for beginning of object key string", "positive_passages": [{"docid": "doc-en-kubernetes-869d1eb1156893b288bffb3f7fbcc8a5f8ec07d69880b865fbe21e8891c23e31", "text": "\"pods\": \"10\", \"services\": \"5\", \"replicationcontrollers\":\"20\", <del> \"resourcequotas\":\"1\", }, </del> <ins> \"resourcequotas\":\"1\" } </ins> } } EOF", "commid": "kubernetes_pr_21388"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8281098c4a3749f944133097833d93b74dab4d64a54e55b1ef6d2ac82651b4ee", "query": "The says this about the new GUI: It does not what? Seems important!\nHmm... That's interesting. Will fix.", "positive_passages": [{"docid": "doc-en-kubernetes-29265b8887cef3d94bd88b793941777bce7d10c31b014ef95aa5cda24f76744b", "text": "trigger scaling up and down the number of pods in your application. * <strong>New GUI</strong> (dashboard) allows you to get started quickly and enables the same functionality found in the CLI as a more approachable and discoverable way of <del> interacting with the system. Note: the GUI is eanbled by default for new cluster creation, however, it does not </del> <ins> interacting with the system. Note: the GUI is enabled by default in 1.2 clusters. </ins> <del> <img src=\"docs/images/newgui.png\" width=\"\" alt=\"XXX image\" title=\"XXX image tooltip\"> </del> <ins> <img src=\"docs/images/newgui.png\" width=\"\" alt=\"Dashboard UI screenshot showing cards that represent applications that run inside a cluster\" title=\"Dashboard UI apps screen\"> </ins> ## Other notable improvements", "commid": "kubernetes_pr_23324"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-eaf1a4d119ad0fb53a39512c42d412af412ec0302afd730bf3a1c25d36f547fb", "query": "When creating a new cluster on AWS with the 1.2 version I always get a failure when checking docker on the nodes, but after the check loop ends everything seems to work fine and all nodes are marked as ready. The instance types for nodes is\nThat is very surprising. Are you using any particular settings (to help me try to reproduce the problem)?\nThese are the exports I make before running kube-up:\nThe problem is the instances take a very long time to start up. I had to increase the timeout to 19.\nHey how did you increase the timeout? Didn't see a setting in config- that I could override. Getting the same issue as the poster.\nThanks , that did the trick!", "positive_passages": [{"docid": "doc-en-kubernetes-55141c12fad505112d65cce8fce967b4d367785b296f55f4f89760a8986281c7", "text": "local output=`check-minion ${minion_ip}` echo $output if [[ \"${output}\" != \"working\" ]]; then <del> if (( attempt > 9 )); then </del> <ins> if (( attempt > 20 )); then </ins> echo echo -e \"${color_red}Your cluster is unlikely to work correctly.\" >&2 echo \"Please run ./cluster/kube-down.sh and re-create the\" >&2", "commid": "kubernetes_pr_25405"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ff81b881a335ec393925d5c77ad19a1d9dde82cef6e119d6f7df449f9fa6f37d", "query": "I have been having the kube-controller-manager (running in a container) crash quite frequently with this error: I cant fathom what seems to cause it. It seems to happen consistently for a while (CrashLoopBackoff occurs) and then fixes itself after an undetermined amount of time. Kubectl version: Docker version: Networking: Calico (with the calico k8s policy agent) Please do let me know if there is any other information that I can supply. I appreciate I haven't given much to go off of. I am not sure what the steps to reproduce are...\ncc\nIt looks like a bug. I'll take a look. Thanks for reporting it.\nWeirdly, the description showed up in the email github sent me but it appears absent on the github issue?\nThe description was there when I read it but disappeared now.\nWell thats very odd! If you have it on your email, could you post it on here please (and I will update the description)? I unfortunately haven't got the error message to hand now...\nI took the liberty of just editing the OP.\nthanks a lot! Not sure what happened there!\ncould you paste the returned output at \"server-ip:port/api\" and \"server-ip:port/apis\"?\nSure.\nThanks \"\" has an empty preferred version and that's causing the error you reported. Is \"\" created via the thirdparty resource api? ()\naha! Good spot! Yes, it was created via that API. This is the Yaml file I used to create it: Here is the output of\nThanks for the confirmation Your configuration is correct. The preferred version is left empty by the thirdparty resource controller, while our discovery client has an assumption that the preferred version won't be empty. I'll patch the discovery client to tolerate an empty preferred version, and will discuss with on if we should make a default preferred version for a thirdparty resource.\nThanks a lot Great job on working it out :)\nSent to fix.\nWhat would be a workaround for this before the release, how can one specify the preferredVersion?\nAFAIK, there is no workaround. There is no way to specify the preferredVersion for the thirdPartyResource.\nI have a quick workaround to fix this : 1) Change the kubernetes to reflect the following : from : thirdpartyresources=true to : thirdpartyresources=false 2) Then restart 'kubelet' service OR reboot the K8S Master server systemctl restart kubelet 3) Revert back the changes done to kube- from : thirdpartyresources=false to : thirdpartyresources=true 4) Verify whether the above change on the above manifest file has been automatically picked up by the kubernetes API ps aux | grep -i thirdpartyresources 5) Finally you may restart kubelet service systemctl restart kubelet 6) Now verify whether the 'kube-controller-manager' is in a 'Running' state kubectl get pods --all-namespaces | grep -i controller-manager Hope this fix works for you guys as well !!", "positive_passages": [{"docid": "doc-en-kubernetes-bd257930c8ce2489746dd8e23105bcd86cba557753c9c2c2fe19297750ee378d", "text": "// ServerResourcesForGroupVersion returns the supported resources for a group and version. func (d *DiscoveryClient) ServerResourcesForGroupVersion(groupVersion string) (resources *unversioned.APIResourceList, err error) { url := url.URL{} <del> if groupVersion == \"v1\" { </del> <ins> if len(groupVersion) == 0 { return nil, fmt.Errorf(\"groupVersion shouldn't be empty\") } else if groupVersion == \"v1\" { </ins> url.Path = \"/api/\" + groupVersion } else { url.Path = \"/apis/\" + groupVersion", "commid": "kubernetes_pr_23985"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ff81b881a335ec393925d5c77ad19a1d9dde82cef6e119d6f7df449f9fa6f37d", "query": "I have been having the kube-controller-manager (running in a container) crash quite frequently with this error: I cant fathom what seems to cause it. It seems to happen consistently for a while (CrashLoopBackoff occurs) and then fixes itself after an undetermined amount of time. Kubectl version: Docker version: Networking: Calico (with the calico k8s policy agent) Please do let me know if there is any other information that I can supply. I appreciate I haven't given much to go off of. I am not sure what the steps to reproduce are...\ncc\nIt looks like a bug. I'll take a look. Thanks for reporting it.\nWeirdly, the description showed up in the email github sent me but it appears absent on the github issue?\nThe description was there when I read it but disappeared now.\nWell thats very odd! If you have it on your email, could you post it on here please (and I will update the description)? I unfortunately haven't got the error message to hand now...\nI took the liberty of just editing the OP.\nthanks a lot! Not sure what happened there!\ncould you paste the returned output at \"server-ip:port/api\" and \"server-ip:port/apis\"?\nSure.\nThanks \"\" has an empty preferred version and that's causing the error you reported. Is \"\" created via the thirdparty resource api? ()\naha! Good spot! Yes, it was created via that API. This is the Yaml file I used to create it: Here is the output of\nThanks for the confirmation Your configuration is correct. The preferred version is left empty by the thirdparty resource controller, while our discovery client has an assumption that the preferred version won't be empty. I'll patch the discovery client to tolerate an empty preferred version, and will discuss with on if we should make a default preferred version for a thirdparty resource.\nThanks a lot Great job on working it out :)\nSent to fix.\nWhat would be a workaround for this before the release, how can one specify the preferredVersion?\nAFAIK, there is no workaround. There is no way to specify the preferredVersion for the thirdPartyResource.\nI have a quick workaround to fix this : 1) Change the kubernetes to reflect the following : from : thirdpartyresources=true to : thirdpartyresources=false 2) Then restart 'kubelet' service OR reboot the K8S Master server systemctl restart kubelet 3) Revert back the changes done to kube- from : thirdpartyresources=false to : thirdpartyresources=true 4) Verify whether the above change on the above manifest file has been automatically picked up by the kubernetes API ps aux | grep -i thirdpartyresources 5) Finally you may restart kubelet service systemctl restart kubelet 6) Now verify whether the 'kube-controller-manager' is in a 'Running' state kubectl get pods --all-namespaces | grep -i controller-manager Hope this fix works for you guys as well !!", "positive_passages": [{"docid": "doc-en-kubernetes-a7a9ebbf68a63530274871dc065bcb1affd06fc90f6193644a7640863bf7c661", "text": "\"k8s.io/kubernetes/pkg/client/typed/discovery\" \"k8s.io/kubernetes/pkg/client/typed/dynamic\" \"k8s.io/kubernetes/pkg/runtime\" <ins> utilerrors \"k8s.io/kubernetes/pkg/util/errors\" </ins> \"k8s.io/kubernetes/pkg/util/sets\" \"github.com/golang/glog\"", "commid": "kubernetes_pr_23985"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ff81b881a335ec393925d5c77ad19a1d9dde82cef6e119d6f7df449f9fa6f37d", "query": "I have been having the kube-controller-manager (running in a container) crash quite frequently with this error: I cant fathom what seems to cause it. It seems to happen consistently for a while (CrashLoopBackoff occurs) and then fixes itself after an undetermined amount of time. Kubectl version: Docker version: Networking: Calico (with the calico k8s policy agent) Please do let me know if there is any other information that I can supply. I appreciate I haven't given much to go off of. I am not sure what the steps to reproduce are...\ncc\nIt looks like a bug. I'll take a look. Thanks for reporting it.\nWeirdly, the description showed up in the email github sent me but it appears absent on the github issue?\nThe description was there when I read it but disappeared now.\nWell thats very odd! If you have it on your email, could you post it on here please (and I will update the description)? I unfortunately haven't got the error message to hand now...\nI took the liberty of just editing the OP.\nthanks a lot! Not sure what happened there!\ncould you paste the returned output at \"server-ip:port/api\" and \"server-ip:port/apis\"?\nSure.\nThanks \"\" has an empty preferred version and that's causing the error you reported. Is \"\" created via the thirdparty resource api? ()\naha! Good spot! Yes, it was created via that API. This is the Yaml file I used to create it: Here is the output of\nThanks for the confirmation Your configuration is correct. The preferred version is left empty by the thirdparty resource controller, while our discovery client has an assumption that the preferred version won't be empty. I'll patch the discovery client to tolerate an empty preferred version, and will discuss with on if we should make a default preferred version for a thirdparty resource.\nThanks a lot Great job on working it out :)\nSent to fix.\nWhat would be a workaround for this before the release, how can one specify the preferredVersion?\nAFAIK, there is no workaround. There is no way to specify the preferredVersion for the thirdPartyResource.\nI have a quick workaround to fix this : 1) Change the kubernetes to reflect the following : from : thirdpartyresources=true to : thirdpartyresources=false 2) Then restart 'kubelet' service OR reboot the K8S Master server systemctl restart kubelet 3) Revert back the changes done to kube- from : thirdpartyresources=false to : thirdpartyresources=true 4) Verify whether the above change on the above manifest file has been automatically picked up by the kubernetes API ps aux | grep -i thirdpartyresources 5) Finally you may restart kubelet service systemctl restart kubelet 6) Now verify whether the 'kube-controller-manager' is in a 'Running' state kubectl get pods --all-namespaces | grep -i controller-manager Hope this fix works for you guys as well !!", "positive_passages": [{"docid": "doc-en-kubernetes-c5cc1a2ea43566482c53f5c70c517dbdeab000bfcbae9adfd76be20699245532", "text": "if err != nil { return results, err } <ins> allErrs := []error{} </ins> for _, apiGroup := range serverGroupList.Groups { preferredVersion := apiGroup.PreferredVersion apiResourceList, err := discoveryClient.ServerResourcesForGroupVersion(preferredVersion.GroupVersion) if err != nil { <del> return results, err </del> <ins> allErrs = append(allErrs, err) continue </ins> } groupVersion := unversioned.GroupVersion{Group: apiGroup.Name, Version: preferredVersion.Version} for _, apiResource := range apiResourceList.APIResources {", "commid": "kubernetes_pr_23985"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ff81b881a335ec393925d5c77ad19a1d9dde82cef6e119d6f7df449f9fa6f37d", "query": "I have been having the kube-controller-manager (running in a container) crash quite frequently with this error: I cant fathom what seems to cause it. It seems to happen consistently for a while (CrashLoopBackoff occurs) and then fixes itself after an undetermined amount of time. Kubectl version: Docker version: Networking: Calico (with the calico k8s policy agent) Please do let me know if there is any other information that I can supply. I appreciate I haven't given much to go off of. I am not sure what the steps to reproduce are...\ncc\nIt looks like a bug. I'll take a look. Thanks for reporting it.\nWeirdly, the description showed up in the email github sent me but it appears absent on the github issue?\nThe description was there when I read it but disappeared now.\nWell thats very odd! If you have it on your email, could you post it on here please (and I will update the description)? I unfortunately haven't got the error message to hand now...\nI took the liberty of just editing the OP.\nthanks a lot! Not sure what happened there!\ncould you paste the returned output at \"server-ip:port/api\" and \"server-ip:port/apis\"?\nSure.\nThanks \"\" has an empty preferred version and that's causing the error you reported. Is \"\" created via the thirdparty resource api? ()\naha! Good spot! Yes, it was created via that API. This is the Yaml file I used to create it: Here is the output of\nThanks for the confirmation Your configuration is correct. The preferred version is left empty by the thirdparty resource controller, while our discovery client has an assumption that the preferred version won't be empty. I'll patch the discovery client to tolerate an empty preferred version, and will discuss with on if we should make a default preferred version for a thirdparty resource.\nThanks a lot Great job on working it out :)\nSent to fix.\nWhat would be a workaround for this before the release, how can one specify the preferredVersion?\nAFAIK, there is no workaround. There is no way to specify the preferredVersion for the thirdPartyResource.\nI have a quick workaround to fix this : 1) Change the kubernetes to reflect the following : from : thirdpartyresources=true to : thirdpartyresources=false 2) Then restart 'kubelet' service OR reboot the K8S Master server systemctl restart kubelet 3) Revert back the changes done to kube- from : thirdpartyresources=false to : thirdpartyresources=true 4) Verify whether the above change on the above manifest file has been automatically picked up by the kubernetes API ps aux | grep -i thirdpartyresources 5) Finally you may restart kubelet service systemctl restart kubelet 6) Now verify whether the 'kube-controller-manager' is in a 'Running' state kubectl get pods --all-namespaces | grep -i controller-manager Hope this fix works for you guys as well !!", "positive_passages": [{"docid": "doc-en-kubernetes-2ec66b9ccd444984accc7065b122700d44eea6a74184d8617985ff3549462d69", "text": "results = append(results, groupVersion.WithResource(apiResource.Name)) } } <del> return results, nil </del> <ins> return results, utilerrors.NewAggregate(allErrs) </ins> }", "commid": "kubernetes_pr_23985"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7377f65a40865118420e0f4c4b965cad4b25ab1082e4c9d411d42ac66506315f", "query": "Minor improvement in UX maybe?\nWe have semi-ambiguous syntax because 'get pod/foo' is also valid. We should have define syntax for this early on. On Apr 8, 2016 7:13 PM, \"Prashanth B\" wrote:\n+1 for the UX improvement.\nget pod/foo != get pod ns/foo ?\n.... LOL\nThis would make SO much easier to use :+1:\nI dont disagree, but it is somewhat complicated to transition now. Maybe something like 'kind/ns:name' which would be less ambiguous and strictly compatible (ns:name is not a valid name, nor is it confusing wrt kind/name). Need to define precedence of this with --namespace flag and in-file namespace yaml. I also don't see it as a huge win, personally. It would have been nice from day1 but relatively minor now, IMO. But this is a decision for UX team - if someone sent a patch implementing something like it, or at least a proposal that worked through all the details, it would be a better starting place. On Apr 10, 2016 12:33 PM, \"Lucas K\u00e4ldstr\u00f6m\" wrote:\nThis is more like P0 to me. Somewhere else I complained about having to type too much and the kind/name syntax. My vote if for kind/ns:name, too.\ncc\nWhat is the scenario you're trying to simplify? You often need to use resources from multiple namespaces on the same command line?\ncc\nns:name is not a valid name for namespaces and our core resources, but it can be a valid name for extension resources in the Kube ecosystem, like users, roles, authorizations. We'd have to add more slashes\nAttaching the namespace to the \"name\" part won't work well because then you have to chose whether is \"list all resources in namespace token\" or \"get the resource named token in the current namespace\". To allow both cases, you must attach the information as a discretely tokenized part or as part of the \"resource\" part. I think that parses unambiguously since resource can't have dots groups can't have colons and namespaces can't have slashes.\nI can assign short names to namespaces and end up with a small kubectl get line, --namespace= just feels unnecessary. I guess it would feel more natural if I could also do . This isn't a huge deal for me personally because I just bash alias my way out of typing.\nIn my case, I work with multiple namespaces, not on the same command line (I use --all-namespaces frequently, too). I guess I could create bash aliases, but I also tend to reinstall the machines I run kubectl from on a regular basis.\n--all-namespaces is so long anyway that it makes me cringe. , Rudi C wrote:\nWhat api group syntax did we settle on? I don't see it documented anywhere. cc\nWith Ubernetes, we'll also have multi-cluster scenarios coming.\nSyntax is: <resource[[.<version].<group] , Brian Grant wrote:\nI think either a short option, like or could be a solution or suffix the namespace using \" .\nwas hoping to save for indicating a for the day when we'd be able to retrieve a historical version of an object via the API. Does not alias to like openshift?\nNo it does not.\nwould be an improvement for me: it's noticeably shorter than . Does introduce ambiguities with other flags? or introduce some other issue? or is the hope that there's a nicer unambiguous solution (e.g., something similar to the original proposal)?\nI don't know of any conflicts. I'm in favor of the short flag because it gets used all the time.\nI am fine with , really appreciate if you could help with this.\nWe originally had -n in Kube but took it out while we sorted out the other config. We went and it in OpenShift because it was used all the time, but forgot to add it in in kubectl. I think it's time to bring it back to kubectl. Other folks who care about this in kubectl should v oice objections in the next day or so, otherwise I think we have consensus to add as the alias for . Can someone scan over the flags in use today in kubectl and verify that no one has introduced a ? , TonyAdo wrote:\nAlready did, just client generation. has opened to add this. I've got a minor comments unrelated to the code and tagged to give him a chance to object.\nI'm also in favor for adding as a shorthand for", "positive_passages": [{"docid": "doc-en-kubernetes-f7c42836c5492a3992c6a08f63fbbd9a95873def027a376b07f15bef44b77eb0", "text": "* `-f`: Resource file * also used for `--follow` in `logs`, but should be deprecated in favor of `-F` <ins> * `-n`: Namespace scope </ins> * `-l`: Label selector * also used for `--labels` in `expose`, but should be deprecated * `-L`: Label columns", "commid": "kubernetes_pr_30630"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7377f65a40865118420e0f4c4b965cad4b25ab1082e4c9d411d42ac66506315f", "query": "Minor improvement in UX maybe?\nWe have semi-ambiguous syntax because 'get pod/foo' is also valid. We should have define syntax for this early on. On Apr 8, 2016 7:13 PM, \"Prashanth B\" wrote:\n+1 for the UX improvement.\nget pod/foo != get pod ns/foo ?\n.... LOL\nThis would make SO much easier to use :+1:\nI dont disagree, but it is somewhat complicated to transition now. Maybe something like 'kind/ns:name' which would be less ambiguous and strictly compatible (ns:name is not a valid name, nor is it confusing wrt kind/name). Need to define precedence of this with --namespace flag and in-file namespace yaml. I also don't see it as a huge win, personally. It would have been nice from day1 but relatively minor now, IMO. But this is a decision for UX team - if someone sent a patch implementing something like it, or at least a proposal that worked through all the details, it would be a better starting place. On Apr 10, 2016 12:33 PM, \"Lucas K\u00e4ldstr\u00f6m\" wrote:\nThis is more like P0 to me. Somewhere else I complained about having to type too much and the kind/name syntax. My vote if for kind/ns:name, too.\ncc\nWhat is the scenario you're trying to simplify? You often need to use resources from multiple namespaces on the same command line?\ncc\nns:name is not a valid name for namespaces and our core resources, but it can be a valid name for extension resources in the Kube ecosystem, like users, roles, authorizations. We'd have to add more slashes\nAttaching the namespace to the \"name\" part won't work well because then you have to chose whether is \"list all resources in namespace token\" or \"get the resource named token in the current namespace\". To allow both cases, you must attach the information as a discretely tokenized part or as part of the \"resource\" part. I think that parses unambiguously since resource can't have dots groups can't have colons and namespaces can't have slashes.\nI can assign short names to namespaces and end up with a small kubectl get line, --namespace= just feels unnecessary. I guess it would feel more natural if I could also do . This isn't a huge deal for me personally because I just bash alias my way out of typing.\nIn my case, I work with multiple namespaces, not on the same command line (I use --all-namespaces frequently, too). I guess I could create bash aliases, but I also tend to reinstall the machines I run kubectl from on a regular basis.\n--all-namespaces is so long anyway that it makes me cringe. , Rudi C wrote:\nWhat api group syntax did we settle on? I don't see it documented anywhere. cc\nWith Ubernetes, we'll also have multi-cluster scenarios coming.\nSyntax is: <resource[[.<version].<group] , Brian Grant wrote:\nI think either a short option, like or could be a solution or suffix the namespace using \" .\nwas hoping to save for indicating a for the day when we'd be able to retrieve a historical version of an object via the API. Does not alias to like openshift?\nNo it does not.\nwould be an improvement for me: it's noticeably shorter than . Does introduce ambiguities with other flags? or introduce some other issue? or is the hope that there's a nicer unambiguous solution (e.g., something similar to the original proposal)?\nI don't know of any conflicts. I'm in favor of the short flag because it gets used all the time.\nI am fine with , really appreciate if you could help with this.\nWe originally had -n in Kube but took it out while we sorted out the other config. We went and it in OpenShift because it was used all the time, but forgot to add it in in kubectl. I think it's time to bring it back to kubectl. Other folks who care about this in kubectl should v oice objections in the next day or so, otherwise I think we have consensus to add as the alias for . Can someone scan over the flags in use today in kubectl and verify that no one has introduced a ? , TonyAdo wrote:\nAlready did, just client generation. has opened to add this. I've got a minor comments unrelated to the code and tagged to give him a chance to object.\nI'm also in favor for adding as a shorthand for", "positive_passages": [{"docid": "doc-en-kubernetes-7082f7d23d04d4fbd4a9f593f9567d4396bce6c43ca6e71291ab9925b473b192", "text": "kubectl create \"${kube_flags[@]}\" --namespace=other -f docs/admin/limitrange/valid-pod.yaml # Post-condition: valid-pod POD is created kube::test::get_object_assert 'pods --namespace=other' \"{{range.items}}{{$id_field}}:{{end}}\" 'valid-pod:' <ins> # Post-condition: verify shorthand `-n other` has the same results as `--namespace=other` kube::test::get_object_assert 'pods -n other' \"{{range.items}}{{$id_field}}:{{end}}\" 'valid-pod:' </ins> ### Delete POD valid-pod in specific namespace # Pre-condition: valid-pod POD exists", "commid": "kubernetes_pr_30630"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7377f65a40865118420e0f4c4b965cad4b25ab1082e4c9d411d42ac66506315f", "query": "Minor improvement in UX maybe?\nWe have semi-ambiguous syntax because 'get pod/foo' is also valid. We should have define syntax for this early on. On Apr 8, 2016 7:13 PM, \"Prashanth B\" wrote:\n+1 for the UX improvement.\nget pod/foo != get pod ns/foo ?\n.... LOL\nThis would make SO much easier to use :+1:\nI dont disagree, but it is somewhat complicated to transition now. Maybe something like 'kind/ns:name' which would be less ambiguous and strictly compatible (ns:name is not a valid name, nor is it confusing wrt kind/name). Need to define precedence of this with --namespace flag and in-file namespace yaml. I also don't see it as a huge win, personally. It would have been nice from day1 but relatively minor now, IMO. But this is a decision for UX team - if someone sent a patch implementing something like it, or at least a proposal that worked through all the details, it would be a better starting place. On Apr 10, 2016 12:33 PM, \"Lucas K\u00e4ldstr\u00f6m\" wrote:\nThis is more like P0 to me. Somewhere else I complained about having to type too much and the kind/name syntax. My vote if for kind/ns:name, too.\ncc\nWhat is the scenario you're trying to simplify? You often need to use resources from multiple namespaces on the same command line?\ncc\nns:name is not a valid name for namespaces and our core resources, but it can be a valid name for extension resources in the Kube ecosystem, like users, roles, authorizations. We'd have to add more slashes\nAttaching the namespace to the \"name\" part won't work well because then you have to chose whether is \"list all resources in namespace token\" or \"get the resource named token in the current namespace\". To allow both cases, you must attach the information as a discretely tokenized part or as part of the \"resource\" part. I think that parses unambiguously since resource can't have dots groups can't have colons and namespaces can't have slashes.\nI can assign short names to namespaces and end up with a small kubectl get line, --namespace= just feels unnecessary. I guess it would feel more natural if I could also do . This isn't a huge deal for me personally because I just bash alias my way out of typing.\nIn my case, I work with multiple namespaces, not on the same command line (I use --all-namespaces frequently, too). I guess I could create bash aliases, but I also tend to reinstall the machines I run kubectl from on a regular basis.\n--all-namespaces is so long anyway that it makes me cringe. , Rudi C wrote:\nWhat api group syntax did we settle on? I don't see it documented anywhere. cc\nWith Ubernetes, we'll also have multi-cluster scenarios coming.\nSyntax is: <resource[[.<version].<group] , Brian Grant wrote:\nI think either a short option, like or could be a solution or suffix the namespace using \" .\nwas hoping to save for indicating a for the day when we'd be able to retrieve a historical version of an object via the API. Does not alias to like openshift?\nNo it does not.\nwould be an improvement for me: it's noticeably shorter than . Does introduce ambiguities with other flags? or introduce some other issue? or is the hope that there's a nicer unambiguous solution (e.g., something similar to the original proposal)?\nI don't know of any conflicts. I'm in favor of the short flag because it gets used all the time.\nI am fine with , really appreciate if you could help with this.\nWe originally had -n in Kube but took it out while we sorted out the other config. We went and it in OpenShift because it was used all the time, but forgot to add it in in kubectl. I think it's time to bring it back to kubectl. Other folks who care about this in kubectl should v oice objections in the next day or so, otherwise I think we have consensus to add as the alias for . Can someone scan over the flags in use today in kubectl and verify that no one has introduced a ? , TonyAdo wrote:\nAlready did, just client generation. has opened to add this. I've got a minor comments unrelated to the code and tagged to give him a chance to object.\nI'm also in favor for adding as a shorthand for", "positive_passages": [{"docid": "doc-en-kubernetes-48d66ad774532d0dbbe8b6adffab7748c21f8c94ec0bf36e7b950e96f6131805", "text": "return ContextOverrideFlags{ ClusterName:  FlagInfo{prefix + FlagClusterName, \"\", \"\", \"The name of the kubeconfig cluster to use\"}, AuthInfoName: FlagInfo{prefix + FlagAuthInfoName, \"\", \"\", \"The name of the kubeconfig user to use\"}, <del> Namespace:    FlagInfo{prefix + FlagNamespace, \"\", \"\", \"If present, the namespace scope for this CLI request\"}, </del> <ins> Namespace:    FlagInfo{prefix + FlagNamespace, \"n\", \"\", \"If present, the namespace scope for this CLI request\"}, </ins> } }", "commid": "kubernetes_pr_30630"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c7a72df11498e7300fcb7761274972d0c9f40da0bd1ab208df9d0e2fd8c6758c", "query": "I'd like to be able to sort by a timestamp, e.g. but that fails with an exception: I appreciate that the root of the problem is probably outside of kubernetes, yet I hope you'd agree that sorting by a timestamp is very useful functionality.\nAgree with sorting by timestamp.. Just make it clear, is of type: while only these types are allowed to be sorted:", "positive_passages": [{"docid": "doc-en-kubernetes-38a9426b08ffadf2279099038a2e5af7946b7df1054e32f3a362b1769c1d1fbf", "text": "kube::test::get_object_assert pods \"{{range.items}}{{$id_field}}:{{end}}\" '' # Command kubectl get pods --sort-by=\"{metadata.name}\" <ins> kubectl get pods --sort-by=\"{metadata.creationTimestamp}\" </ins> ############################ # Kubectl --all-namespaces #", "commid": "kubernetes_pr_25022"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c7a72df11498e7300fcb7761274972d0c9f40da0bd1ab208df9d0e2fd8c6758c", "query": "I'd like to be able to sort by a timestamp, e.g. but that fails with an exception: I appreciate that the root of the problem is probably outside of kubernetes, yet I hope you'd agree that sorting by a timestamp is very useful functionality.\nAgree with sorting by timestamp.. Just make it clear, is of type: while only these types are allowed to be sorted:", "positive_passages": [{"docid": "doc-en-kubernetes-aca8342ee1c5e44a8f739e20985c76ca873ac501f954372c53d32afd83853bcc", "text": "\"sort\" \"k8s.io/kubernetes/pkg/api/meta\" <ins> \"k8s.io/kubernetes/pkg/api/unversioned\" </ins> \"k8s.io/kubernetes/pkg/api/v1\" \"k8s.io/kubernetes/pkg/runtime\" <ins> \"k8s.io/kubernetes/pkg/util/integer\" </ins> \"k8s.io/kubernetes/pkg/util/jsonpath\" \"github.com/golang/glog\"", "commid": "kubernetes_pr_25022"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c7a72df11498e7300fcb7761274972d0c9f40da0bd1ab208df9d0e2fd8c6758c", "query": "I'd like to be able to sort by a timestamp, e.g. but that fails with an exception: I appreciate that the root of the problem is probably outside of kubernetes, yet I hope you'd agree that sorting by a timestamp is very useful functionality.\nAgree with sorting by timestamp.. Just make it clear, is of type: while only these types are allowed to be sorted:", "positive_passages": [{"docid": "doc-en-kubernetes-7e1b9fdf7c7136990101bfea47a8d7b5bbca77e41bcf8ceedd8c2cc8faa0065c", "text": "return i.String() < j.String(), nil case reflect.Ptr: return isLess(i.Elem(), j.Elem()) <ins> case reflect.Struct: // special case handling lessFuncList := []structLessFunc{timeLess} if ok, less := structLess(i, j, lessFuncList); ok { return less, nil } // fallback to the fields comparision for idx := 0; idx < i.NumField(); idx++ { less, err := isLess(i.Field(idx), j.Field(idx)) if err != nil || !less { return less, err } } return true, nil case reflect.Array, reflect.Slice: // note: the length of i and j may be different for idx := 0; idx < integer.IntMin(i.Len(), j.Len()); idx++ { less, err := isLess(i.Index(idx), j.Index(idx)) if err != nil || !less { return less, err } } return true, nil </ins> default: return false, fmt.Errorf(\"unsortable type: %v\", i.Kind()) } } <ins> // structLessFunc checks whether i and j could be compared(the first return value), // and if it could, return whether i is less than j(the second return value) type structLessFunc func(i, j reflect.Value) (bool, bool) // structLess returns whether i and j could be compared with the given function list func structLess(i, j reflect.Value, lessFuncList []structLessFunc) (bool, bool) { for _, lessFunc := range lessFuncList { if ok, less := lessFunc(i, j); ok { return ok, less } } return false, false } // compare two unversioned.Time values. func timeLess(i, j reflect.Value) (bool, bool) { if i.Type() != reflect.TypeOf(unversioned.Unix(0, 0)) { return false, false } return true, i.MethodByName(\"Before\").Call([]reflect.Value{j})[0].Bool() } </ins> func (r *RuntimeSort) Less(i, j int) bool { iObj := r.objs[i] jObj := r.objs[j]", "commid": "kubernetes_pr_25022"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c7a72df11498e7300fcb7761274972d0c9f40da0bd1ab208df9d0e2fd8c6758c", "query": "I'd like to be able to sort by a timestamp, e.g. but that fails with an exception: I appreciate that the root of the problem is probably outside of kubernetes, yet I hope you'd agree that sorting by a timestamp is very useful functionality.\nAgree with sorting by timestamp.. Just make it clear, is of type: while only these types are allowed to be sorted:", "positive_passages": [{"docid": "doc-en-kubernetes-0049f1d4d9f09ba884ed929e8105d3f80339d3d25434589bdec3084d7ae698f3", "text": "\"testing\" internal \"k8s.io/kubernetes/pkg/api\" <ins> \"k8s.io/kubernetes/pkg/api/unversioned\" </ins> api \"k8s.io/kubernetes/pkg/api/v1\" \"k8s.io/kubernetes/pkg/runtime\" )", "commid": "kubernetes_pr_25022"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c7a72df11498e7300fcb7761274972d0c9f40da0bd1ab208df9d0e2fd8c6758c", "query": "I'd like to be able to sort by a timestamp, e.g. but that fails with an exception: I appreciate that the root of the problem is probably outside of kubernetes, yet I hope you'd agree that sorting by a timestamp is very useful functionality.\nAgree with sorting by timestamp.. Just make it clear, is of type: while only these types are allowed to be sorted:", "positive_passages": [{"docid": "doc-en-kubernetes-a7b4e88da2e9cd1cccc0828cca6147047ef34b1b671cd6c1574c9ab06659cd1a", "text": "field: \"{.metadata.name}\", }, { <ins> name: \"random-order-timestamp\", obj: &api.PodList{ Items: []api.Pod{ { ObjectMeta: api.ObjectMeta{ CreationTimestamp: unversioned.Unix(300, 0), }, }, { ObjectMeta: api.ObjectMeta{ CreationTimestamp: unversioned.Unix(100, 0), }, }, { ObjectMeta: api.ObjectMeta{ CreationTimestamp: unversioned.Unix(200, 0), }, }, }, }, sort: &api.PodList{ Items: []api.Pod{ { ObjectMeta: api.ObjectMeta{ CreationTimestamp: unversioned.Unix(100, 0), }, }, { ObjectMeta: api.ObjectMeta{ CreationTimestamp: unversioned.Unix(200, 0), }, }, { ObjectMeta: api.ObjectMeta{ CreationTimestamp: unversioned.Unix(300, 0), }, }, }, }, field: \"{.metadata.creationTimestamp}\", }, { </ins> name: \"random-order-numbers\", obj: &api.ReplicationControllerList{ Items: []api.ReplicationController{", "commid": "kubernetes_pr_25022"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21b704a68514d2b400f1a4f479b12f48c6dc4bd890b9d4b14cffa5ee4c13d7d4", "query": "During\nany chance this is related to pass: https://k8s- fail: https://k8s- https://k8s-\nThis is because for some reason the submit queue rebuild didn't catch the flake before merging. Protobuf landed first, merging a new api object like petset should have failed.\nQuick fix is to rebuild the proto marshalers and push.\nAlso, hack/verify-generated- is broken, which probably is the root cause.\nLooking at it now\nThree problems: -generated-protobuf wasn't updated when we made update-generated-protobuf use docker, so it didn't fail out script was verifying the old API groups, not any of the new API groups that have been merged without protobuf serializations (although pkg/api/serialization_test should have failed, possibly the job didn't build with the latest master?), which caused the tests to fail\nSomething about the merge bot is broken - it merged without all the tests being green: . That's why this broke -\nSpawned since there is something wrong with update-generated-protobuf - will merge that to fix the failing test and then debug the generator in the morning.\nThe bot can race with pushes between when it starts testing and when it merges...", "positive_passages": [{"docid": "doc-en-kubernetes-480c578a70c385c4a31aa3b2f03cea53c276fbcba22e13088f675d78dfeae4f3", "text": "<ins> /* Copyright 2016 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ // Code generated by protoc-gen-gogo. // source: k8s.io/kubernetes/pkg/apis/apps/v1alpha1/generated.proto // DO NOT EDIT! /* Package v1alpha1 is a generated protocol buffer package. It is generated from these files: k8s.io/kubernetes/pkg/apis/apps/v1alpha1/generated.proto It has these top-level messages: PetSet PetSetList PetSetSpec PetSetStatus */ package v1alpha1 import proto \"github.com/gogo/protobuf/proto\" import fmt \"fmt\" import math \"math\" import _ \"github.com/gogo/protobuf/gogoproto\" import _ \"k8s.io/kubernetes/pkg/api/resource\" import k8s_io_kubernetes_pkg_api_unversioned \"k8s.io/kubernetes/pkg/api/unversioned\" import k8s_io_kubernetes_pkg_api_v1 \"k8s.io/kubernetes/pkg/api/v1\" import _ \"k8s.io/kubernetes/pkg/util/intstr\" import io \"io\" // Reference imports to suppress errors if they are not otherwise used. var _ = proto.Marshal var _ = fmt.Errorf var _ = math.Inf func (m *PetSet) Reset()         { *m = PetSet{} } func (m *PetSet) String() string { return proto.CompactTextString(m) } func (*PetSet) ProtoMessage()    {} func (m *PetSetList) Reset()         { *m = PetSetList{} } func (m *PetSetList) String() string { return proto.CompactTextString(m) } func (*PetSetList) ProtoMessage()    {} func (m *PetSetSpec) Reset()         { *m = PetSetSpec{} } func (m *PetSetSpec) String() string { return proto.CompactTextString(m) } func (*PetSetSpec) ProtoMessage()    {} func (m *PetSetStatus) Reset()         { *m = PetSetStatus{} } func (m *PetSetStatus) String() string { return proto.CompactTextString(m) } func (*PetSetStatus) ProtoMessage()    {} func init() { proto.RegisterType((*PetSet)(nil), \"k8s.io.kubernetes.pkg.apis.apps.v1alpha1.PetSet\") proto.RegisterType((*PetSetList)(nil), \"k8s.io.kubernetes.pkg.apis.apps.v1alpha1.PetSetList\") proto.RegisterType((*PetSetSpec)(nil), \"k8s.io.kubernetes.pkg.apis.apps.v1alpha1.PetSetSpec\") proto.RegisterType((*PetSetStatus)(nil), \"k8s.io.kubernetes.pkg.apis.apps.v1alpha1.PetSetStatus\") } func (m *PetSet) Marshal() (data []byte, err error) { size := m.Size() data = make([]byte, size) n, err := m.MarshalTo(data) if err != nil { return nil, err } return data[:n], nil } func (m *PetSet) MarshalTo(data []byte) (int, error) { var i int _ = i var l int _ = l data[i] = 0xa i++ i = encodeVarintGenerated(data, i, uint64(m.ObjectMeta.Size())) n1, err := m.ObjectMeta.MarshalTo(data[i:]) if err != nil { return 0, err } i += n1 data[i] = 0x12 i++ i = encodeVarintGenerated(data, i, uint64(m.Spec.Size())) n2, err := m.Spec.MarshalTo(data[i:]) if err != nil { return 0, err } i += n2 data[i] = 0x1a i++ i = encodeVarintGenerated(data, i, uint64(m.Status.Size())) n3, err := m.Status.MarshalTo(data[i:]) if err != nil { return 0, err } i += n3 return i, nil } func (m *PetSetList) Marshal() (data []byte, err error) { size := m.Size() data = make([]byte, size) n, err := m.MarshalTo(data) if err != nil { return nil, err } return data[:n], nil } func (m *PetSetList) MarshalTo(data []byte) (int, error) { var i int _ = i var l int _ = l data[i] = 0xa i++ i = encodeVarintGenerated(data, i, uint64(m.ListMeta.Size())) n4, err := m.ListMeta.MarshalTo(data[i:]) if err != nil { return 0, err } i += n4 if len(m.Items) > 0 { for _, msg := range m.Items { data[i] = 0x12 i++ i = encodeVarintGenerated(data, i, uint64(msg.Size())) n, err := msg.MarshalTo(data[i:]) if err != nil { return 0, err } i += n } } return i, nil } func (m *PetSetSpec) Marshal() (data []byte, err error) { size := m.Size() data = make([]byte, size) n, err := m.MarshalTo(data) if err != nil { return nil, err } return data[:n], nil } func (m *PetSetSpec) MarshalTo(data []byte) (int, error) { var i int _ = i var l int _ = l if m.Replicas != nil { data[i] = 0x8 i++ i = encodeVarintGenerated(data, i, uint64(*m.Replicas)) } if m.Selector != nil { data[i] = 0x12 i++ i = encodeVarintGenerated(data, i, uint64(m.Selector.Size())) n5, err := m.Selector.MarshalTo(data[i:]) if err != nil { return 0, err } i += n5 } data[i] = 0x1a i++ i = encodeVarintGenerated(data, i, uint64(m.Template.Size())) n6, err := m.Template.MarshalTo(data[i:]) if err != nil { return 0, err } i += n6 if len(m.VolumeClaimTemplates) > 0 { for _, msg := range m.VolumeClaimTemplates { data[i] = 0x22 i++ i = encodeVarintGenerated(data, i, uint64(msg.Size())) n, err := msg.MarshalTo(data[i:]) if err != nil { return 0, err } i += n } } data[i] = 0x2a i++ i = encodeVarintGenerated(data, i, uint64(len(m.ServiceName))) i += copy(data[i:], m.ServiceName) return i, nil } func (m *PetSetStatus) Marshal() (data []byte, err error) { size := m.Size() data = make([]byte, size) n, err := m.MarshalTo(data) if err != nil { return nil, err } return data[:n], nil } func (m *PetSetStatus) MarshalTo(data []byte) (int, error) { var i int _ = i var l int _ = l if m.ObservedGeneration != nil { data[i] = 0x8 i++ i = encodeVarintGenerated(data, i, uint64(*m.ObservedGeneration)) } data[i] = 0x10 i++ i = encodeVarintGenerated(data, i, uint64(m.Replicas)) return i, nil } func encodeFixed64Generated(data []byte, offset int, v uint64) int { data[offset] = uint8(v) data[offset+1] = uint8(v >> 8) data[offset+2] = uint8(v >> 16) data[offset+3] = uint8(v >> 24) data[offset+4] = uint8(v >> 32) data[offset+5] = uint8(v >> 40) data[offset+6] = uint8(v >> 48) data[offset+7] = uint8(v >> 56) return offset + 8 } func encodeFixed32Generated(data []byte, offset int, v uint32) int { data[offset] = uint8(v) data[offset+1] = uint8(v >> 8) data[offset+2] = uint8(v >> 16) data[offset+3] = uint8(v >> 24) return offset + 4 } func encodeVarintGenerated(data []byte, offset int, v uint64) int { for v >= 1<<7 { data[offset] = uint8(v&0x7f | 0x80) v >>= 7 offset++ } data[offset] = uint8(v) return offset + 1 } func (m *PetSet) Size() (n int) { var l int _ = l l = m.ObjectMeta.Size() n += 1 + l + sovGenerated(uint64(l)) l = m.Spec.Size() n += 1 + l + sovGenerated(uint64(l)) l = m.Status.Size() n += 1 + l + sovGenerated(uint64(l)) return n } func (m *PetSetList) Size() (n int) { var l int _ = l l = m.ListMeta.Size() n += 1 + l + sovGenerated(uint64(l)) if len(m.Items) > 0 { for _, e := range m.Items { l = e.Size() n += 1 + l + sovGenerated(uint64(l)) } } return n } func (m *PetSetSpec) Size() (n int) { var l int _ = l if m.Replicas != nil { n += 1 + sovGenerated(uint64(*m.Replicas)) } if m.Selector != nil { l = m.Selector.Size() n += 1 + l + sovGenerated(uint64(l)) } l = m.Template.Size() n += 1 + l + sovGenerated(uint64(l)) if len(m.VolumeClaimTemplates) > 0 { for _, e := range m.VolumeClaimTemplates { l = e.Size() n += 1 + l + sovGenerated(uint64(l)) } } l = len(m.ServiceName) n += 1 + l + sovGenerated(uint64(l)) return n } func (m *PetSetStatus) Size() (n int) { var l int _ = l if m.ObservedGeneration != nil { n += 1 + sovGenerated(uint64(*m.ObservedGeneration)) } n += 1 + sovGenerated(uint64(m.Replicas)) return n } func sovGenerated(x uint64) (n int) { for { n++ x >>= 7 if x == 0 { break } } return n } func sozGenerated(x uint64) (n int) { return sovGenerated(uint64((x << 1) ^ uint64((int64(x) >> 63)))) } func (m *PetSet) Unmarshal(data []byte) error { l := len(data) iNdEx := 0 for iNdEx < l { preIndex := iNdEx var wire uint64 for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ wire |= (uint64(b) & 0x7F) << shift if b < 0x80 { break } } fieldNum := int32(wire >> 3) wireType := int(wire & 0x7) if wireType == 4 { return fmt.Errorf(\"proto: PetSet: wiretype end group for non-group\") } if fieldNum <= 0 { return fmt.Errorf(\"proto: PetSet: illegal tag %d (wire type %d)\", fieldNum, wire) } switch fieldNum { case 1: if wireType != 2 { return fmt.Errorf(\"proto: wrong wireType = %d for field ObjectMeta\", wireType) } var msglen int for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ msglen |= (int(b) & 0x7F) << shift if b < 0x80 { break } } if msglen < 0 { return ErrInvalidLengthGenerated } postIndex := iNdEx + msglen if postIndex > l { return io.ErrUnexpectedEOF } if err := m.ObjectMeta.Unmarshal(data[iNdEx:postIndex]); err != nil { return err } iNdEx = postIndex case 2: if wireType != 2 { return fmt.Errorf(\"proto: wrong wireType = %d for field Spec\", wireType) } var msglen int for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ msglen |= (int(b) & 0x7F) << shift if b < 0x80 { break } } if msglen < 0 { return ErrInvalidLengthGenerated } postIndex := iNdEx + msglen if postIndex > l { return io.ErrUnexpectedEOF } if err := m.Spec.Unmarshal(data[iNdEx:postIndex]); err != nil { return err } iNdEx = postIndex case 3: if wireType != 2 { return fmt.Errorf(\"proto: wrong wireType = %d for field Status\", wireType) } var msglen int for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ msglen |= (int(b) & 0x7F) << shift if b < 0x80 { break } } if msglen < 0 { return ErrInvalidLengthGenerated } postIndex := iNdEx + msglen if postIndex > l { return io.ErrUnexpectedEOF } if err := m.Status.Unmarshal(data[iNdEx:postIndex]); err != nil { return err } iNdEx = postIndex default: iNdEx = preIndex skippy, err := skipGenerated(data[iNdEx:]) if err != nil { return err } if skippy < 0 { return ErrInvalidLengthGenerated } if (iNdEx + skippy) > l { return io.ErrUnexpectedEOF } iNdEx += skippy } } if iNdEx > l { return io.ErrUnexpectedEOF } return nil } func (m *PetSetList) Unmarshal(data []byte) error { l := len(data) iNdEx := 0 for iNdEx < l { preIndex := iNdEx var wire uint64 for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ wire |= (uint64(b) & 0x7F) << shift if b < 0x80 { break } } fieldNum := int32(wire >> 3) wireType := int(wire & 0x7) if wireType == 4 { return fmt.Errorf(\"proto: PetSetList: wiretype end group for non-group\") } if fieldNum <= 0 { return fmt.Errorf(\"proto: PetSetList: illegal tag %d (wire type %d)\", fieldNum, wire) } switch fieldNum { case 1: if wireType != 2 { return fmt.Errorf(\"proto: wrong wireType = %d for field ListMeta\", wireType) } var msglen int for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ msglen |= (int(b) & 0x7F) << shift if b < 0x80 { break } } if msglen < 0 { return ErrInvalidLengthGenerated } postIndex := iNdEx + msglen if postIndex > l { return io.ErrUnexpectedEOF } if err := m.ListMeta.Unmarshal(data[iNdEx:postIndex]); err != nil { return err } iNdEx = postIndex case 2: if wireType != 2 { return fmt.Errorf(\"proto: wrong wireType = %d for field Items\", wireType) } var msglen int for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ msglen |= (int(b) & 0x7F) << shift if b < 0x80 { break } } if msglen < 0 { return ErrInvalidLengthGenerated } postIndex := iNdEx + msglen if postIndex > l { return io.ErrUnexpectedEOF } m.Items = append(m.Items, PetSet{}) if err := m.Items[len(m.Items)-1].Unmarshal(data[iNdEx:postIndex]); err != nil { return err } iNdEx = postIndex default: iNdEx = preIndex skippy, err := skipGenerated(data[iNdEx:]) if err != nil { return err } if skippy < 0 { return ErrInvalidLengthGenerated } if (iNdEx + skippy) > l { return io.ErrUnexpectedEOF } iNdEx += skippy } } if iNdEx > l { return io.ErrUnexpectedEOF } return nil } func (m *PetSetSpec) Unmarshal(data []byte) error { l := len(data) iNdEx := 0 for iNdEx < l { preIndex := iNdEx var wire uint64 for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ wire |= (uint64(b) & 0x7F) << shift if b < 0x80 { break } } fieldNum := int32(wire >> 3) wireType := int(wire & 0x7) if wireType == 4 { return fmt.Errorf(\"proto: PetSetSpec: wiretype end group for non-group\") } if fieldNum <= 0 { return fmt.Errorf(\"proto: PetSetSpec: illegal tag %d (wire type %d)\", fieldNum, wire) } switch fieldNum { case 1: if wireType != 0 { return fmt.Errorf(\"proto: wrong wireType = %d for field Replicas\", wireType) } var v int32 for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ v |= (int32(b) & 0x7F) << shift if b < 0x80 { break } } m.Replicas = &v case 2: if wireType != 2 { return fmt.Errorf(\"proto: wrong wireType = %d for field Selector\", wireType) } var msglen int for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ msglen |= (int(b) & 0x7F) << shift if b < 0x80 { break } } if msglen < 0 { return ErrInvalidLengthGenerated } postIndex := iNdEx + msglen if postIndex > l { return io.ErrUnexpectedEOF } if m.Selector == nil { m.Selector = &k8s_io_kubernetes_pkg_api_unversioned.LabelSelector{} } if err := m.Selector.Unmarshal(data[iNdEx:postIndex]); err != nil { return err } iNdEx = postIndex case 3: if wireType != 2 { return fmt.Errorf(\"proto: wrong wireType = %d for field Template\", wireType) } var msglen int for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ msglen |= (int(b) & 0x7F) << shift if b < 0x80 { break } } if msglen < 0 { return ErrInvalidLengthGenerated } postIndex := iNdEx + msglen if postIndex > l { return io.ErrUnexpectedEOF } if err := m.Template.Unmarshal(data[iNdEx:postIndex]); err != nil { return err } iNdEx = postIndex case 4: if wireType != 2 { return fmt.Errorf(\"proto: wrong wireType = %d for field VolumeClaimTemplates\", wireType) } var msglen int for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ msglen |= (int(b) & 0x7F) << shift if b < 0x80 { break } } if msglen < 0 { return ErrInvalidLengthGenerated } postIndex := iNdEx + msglen if postIndex > l { return io.ErrUnexpectedEOF } m.VolumeClaimTemplates = append(m.VolumeClaimTemplates, k8s_io_kubernetes_pkg_api_v1.PersistentVolumeClaim{}) if err := m.VolumeClaimTemplates[len(m.VolumeClaimTemplates)-1].Unmarshal(data[iNdEx:postIndex]); err != nil { return err } iNdEx = postIndex case 5: if wireType != 2 { return fmt.Errorf(\"proto: wrong wireType = %d for field ServiceName\", wireType) } var stringLen uint64 for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ stringLen |= (uint64(b) & 0x7F) << shift if b < 0x80 { break } } intStringLen := int(stringLen) if intStringLen < 0 { return ErrInvalidLengthGenerated } postIndex := iNdEx + intStringLen if postIndex > l { return io.ErrUnexpectedEOF } m.ServiceName = string(data[iNdEx:postIndex]) iNdEx = postIndex default: iNdEx = preIndex skippy, err := skipGenerated(data[iNdEx:]) if err != nil { return err } if skippy < 0 { return ErrInvalidLengthGenerated } if (iNdEx + skippy) > l { return io.ErrUnexpectedEOF } iNdEx += skippy } } if iNdEx > l { return io.ErrUnexpectedEOF } return nil } func (m *PetSetStatus) Unmarshal(data []byte) error { l := len(data) iNdEx := 0 for iNdEx < l { preIndex := iNdEx var wire uint64 for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ wire |= (uint64(b) & 0x7F) << shift if b < 0x80 { break } } fieldNum := int32(wire >> 3) wireType := int(wire & 0x7) if wireType == 4 { return fmt.Errorf(\"proto: PetSetStatus: wiretype end group for non-group\") } if fieldNum <= 0 { return fmt.Errorf(\"proto: PetSetStatus: illegal tag %d (wire type %d)\", fieldNum, wire) } switch fieldNum { case 1: if wireType != 0 { return fmt.Errorf(\"proto: wrong wireType = %d for field ObservedGeneration\", wireType) } var v int64 for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ v |= (int64(b) & 0x7F) << shift if b < 0x80 { break } } m.ObservedGeneration = &v case 2: if wireType != 0 { return fmt.Errorf(\"proto: wrong wireType = %d for field Replicas\", wireType) } m.Replicas = 0 for shift := uint(0); ; shift += 7 { if shift >= 64 { return ErrIntOverflowGenerated } if iNdEx >= l { return io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ m.Replicas |= (int32(b) & 0x7F) << shift if b < 0x80 { break } } default: iNdEx = preIndex skippy, err := skipGenerated(data[iNdEx:]) if err != nil { return err } if skippy < 0 { return ErrInvalidLengthGenerated } if (iNdEx + skippy) > l { return io.ErrUnexpectedEOF } iNdEx += skippy } } if iNdEx > l { return io.ErrUnexpectedEOF } return nil } func skipGenerated(data []byte) (n int, err error) { l := len(data) iNdEx := 0 for iNdEx < l { var wire uint64 for shift := uint(0); ; shift += 7 { if shift >= 64 { return 0, ErrIntOverflowGenerated } if iNdEx >= l { return 0, io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ wire |= (uint64(b) & 0x7F) << shift if b < 0x80 { break } } wireType := int(wire & 0x7) switch wireType { case 0: for shift := uint(0); ; shift += 7 { if shift >= 64 { return 0, ErrIntOverflowGenerated } if iNdEx >= l { return 0, io.ErrUnexpectedEOF } iNdEx++ if data[iNdEx-1] < 0x80 { break } } return iNdEx, nil case 1: iNdEx += 8 return iNdEx, nil case 2: var length int for shift := uint(0); ; shift += 7 { if shift >= 64 { return 0, ErrIntOverflowGenerated } if iNdEx >= l { return 0, io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ length |= (int(b) & 0x7F) << shift if b < 0x80 { break } } iNdEx += length if length < 0 { return 0, ErrInvalidLengthGenerated } return iNdEx, nil case 3: for { var innerWire uint64 var start int = iNdEx for shift := uint(0); ; shift += 7 { if shift >= 64 { return 0, ErrIntOverflowGenerated } if iNdEx >= l { return 0, io.ErrUnexpectedEOF } b := data[iNdEx] iNdEx++ innerWire |= (uint64(b) & 0x7F) << shift if b < 0x80 { break } } innerWireType := int(innerWire & 0x7) if innerWireType == 4 { break } next, err := skipGenerated(data[start:]) if err != nil { return 0, err } iNdEx = start + next } return iNdEx, nil case 4: return iNdEx, nil case 5: iNdEx += 4 return iNdEx, nil default: return 0, fmt.Errorf(\"proto: illegal wireType %d\", wireType) } } panic(\"unreachable\") } var ( ErrInvalidLengthGenerated = fmt.Errorf(\"proto: negative length found during unmarshaling\") ErrIntOverflowGenerated   = fmt.Errorf(\"proto: integer overflow\") ) </ins>", "commid": "kubernetes_pr_24587"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21b704a68514d2b400f1a4f479b12f48c6dc4bd890b9d4b14cffa5ee4c13d7d4", "query": "During\nany chance this is related to pass: https://k8s- fail: https://k8s- https://k8s-\nThis is because for some reason the submit queue rebuild didn't catch the flake before merging. Protobuf landed first, merging a new api object like petset should have failed.\nQuick fix is to rebuild the proto marshalers and push.\nAlso, hack/verify-generated- is broken, which probably is the root cause.\nLooking at it now\nThree problems: -generated-protobuf wasn't updated when we made update-generated-protobuf use docker, so it didn't fail out script was verifying the old API groups, not any of the new API groups that have been merged without protobuf serializations (although pkg/api/serialization_test should have failed, possibly the job didn't build with the latest master?), which caused the tests to fail\nSomething about the merge bot is broken - it merged without all the tests being green: . That's why this broke -\nSpawned since there is something wrong with update-generated-protobuf - will merge that to fix the failing test and then debug the generator in the morning.\nThe bot can race with pushes between when it starts testing and when it merges...", "positive_passages": [{"docid": "doc-en-kubernetes-f78551fdd9a516f286253b61bc6635bab2691d8df7070e2079c175b1dd4307b4", "text": "<ins> /* Copyright 2016 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ // This file was autogenerated by go-to-protobuf. Do not edit it manually! syntax = 'proto2'; package k8s.io.kubernetes.pkg.apis.apps.v1alpha1; import \"k8s.io/kubernetes/pkg/api/resource/generated.proto\"; import \"k8s.io/kubernetes/pkg/api/unversioned/generated.proto\"; import \"k8s.io/kubernetes/pkg/api/v1/generated.proto\"; import \"k8s.io/kubernetes/pkg/util/intstr/generated.proto\"; // Package-wide variables from generator \"generated\". option go_package = \"v1alpha1\"; // PetSet represents a set of pods with consistent identities. // Identities are defined as: //  - Network: A single stable DNS and hostname. //  - Storage: As many VolumeClaims as requested. // The PetSet guarantees that a given network identity will always // map to the same storage identity. PetSet is currently in alpha // and subject to change without notice. message PetSet { optional k8s.io.kubernetes.pkg.api.v1.ObjectMeta metadata = 1; // Spec defines the desired identities of pets in this set. optional PetSetSpec spec = 2; // Status is the current status of Pets in this PetSet. This data // may be out of date by some window of time. optional PetSetStatus status = 3; } // PetSetList is a collection of PetSets. message PetSetList { optional k8s.io.kubernetes.pkg.api.unversioned.ListMeta metadata = 1; repeated PetSet items = 2; } // A PetSetSpec is the specification of a PetSet. message PetSetSpec { // Replicas is the desired number of replicas of the given Template. // These are replicas in the sense that they are instantiations of the // same Template, but individual replicas also have a consistent identity. // If unspecified, defaults to 1. // TODO: Consider a rename of this field. optional int32 replicas = 1; // Selector is a label query over pods that should match the replica count. // If empty, defaulted to labels on the pod template. // More info: http://releases.k8s.io/HEAD/docs/user-guide/labels.md#label-selectors optional k8s.io.kubernetes.pkg.api.unversioned.LabelSelector selector = 2; // Template is the object that describes the pod that will be created if // insufficient replicas are detected. Each pod stamped out by the PetSet // will fulfill this Template, but have a unique identity from the rest // of the PetSet. optional k8s.io.kubernetes.pkg.api.v1.PodTemplateSpec template = 3; // VolumeClaimTemplates is a list of claims that pets are allowed to reference. // The PetSet controller is responsible for mapping network identities to // claims in a way that maintains the identity of a pet. Every claim in // this list must have at least one matching (by name) volumeMount in one // container in the template. A claim in this list takes precedence over // any volumes in the template, with the same name. // TODO: Define the behavior if a claim already exists with the same name. repeated k8s.io.kubernetes.pkg.api.v1.PersistentVolumeClaim volumeClaimTemplates = 4; // ServiceName is the name of the service that governs this PetSet. // This service must exist before the PetSet, and is responsible for // the network identity of the set. Pets get DNS/hostnames that follow the // pattern: pet-specific-string.serviceName.default.svc.cluster.local // where \"pet-specific-string\" is managed by the PetSet controller. optional string serviceName = 5; } // PetSetStatus represents the current state of a PetSet. message PetSetStatus { // most recent generation observed by this autoscaler. optional int64 observedGeneration = 1; // Replicas is the number of actual replicas. optional int32 replicas = 2; } </ins>", "commid": "kubernetes_pr_24587"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0a43404a90a4502792529d6f593d8f07cbefedf62cf2856b9027033dd071c9f", "query": "Hi, Deployment patching with doesn't show up in the deployment rollout history: first: after: Is it a bug? Should it show up? Thanks, Peter\ncc\nWhich kubernetes and kubectl releases? Did the patch actually trigger a rollout?\nI also run the command from CI with the latest . So the problem affects the v1.2.3 kubectl as well\nWe should also fix the way we sort revisions - 10 should be after 9, not 1.\nCan confirm this. The issue is that the patch isn't updating , so the rollout history will just copy the value from the previous version. If you started with you get that for the patches. In my case I have a different line repeated. Builds 7 and 8 were built with different . I'm not sure why the patch worked once. Command I am calling is:\nIf no one is working on patch - i can try to make one.\nI'll like to work on this issue if you haven't started yet\nActually never mind I can look at something else :)\nHi, i see that you are the author of the following comment. I think that currently every valid change cause is discarded because of version conflict. Maybe you have some information why it happens?\ncommand instead generates a patch to update then applies that.\nIt was the same for patch, but for some reason was changed.\nThe intent was two fold. First, prevent the change-cause from ever failing patch the CLI command. change-cause isn't authoritative and the patch took hold, so a non-zero return code is inappropriate. Second, if the resource version change post-patch, before the update, the change-cause is unknown, something else touched it after the fact. A command that issues a instead of an could very easily break the history since patches will attempt to reapply themselves regardless of resource version in the face of conflicts. The object returned from the patch operation is the one that we use to avoid hitting a resource conflict with ourselves. Truth be told, I don't feel very strongly about getting the history right since it can be changed anyone with write access to the object, includes secrets that should be elided (--token for instance), ignores environment variables which affect outcome, ignores the actual path used to locate the binary you're running, and references paths that are only good from one location on one machine, so if you want to switch it back to a second patch, I don't mind as long as a failure to update the object doesn't cause a non-zero return from the command.\nCould there be a race between the call and the deployment updating itself to action the changes? On 19 May 2016 9:47 pm, \"David Eads\" wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-4c8b3952c76ccd4bec02c50ef2e9530c51c6ed23236f4f3b7bde1efe3e1eb3bc", "text": "if !options.Local { helper := resource.NewHelper(client, mapping) <del> patchedObject, err := helper.Patch(namespace, name, patchType, patchBytes) </del> <ins> _, err := helper.Patch(namespace, name, patchType, patchBytes) </ins> if err != nil { return err } if cmdutil.ShouldRecord(cmd, info) { <del> if err := cmdutil.RecordChangeCause(patchedObject, f.Command()); err == nil { // don't return an error on failure.  The patch itself succeeded, its only the hint for that change that failed // don't bother checking for failures of this replace, because a failure to indicate the hint doesn't fail the command // also, don't force the replacement.  If the replacement fails on a resourceVersion conflict, then it means this // record hint is likely to be invalid anyway, so avoid the bad hint resource.NewHelper(client, mapping).Replace(namespace, name, false, patchedObject) </del> <ins> // don't return an error on failure.  The patch itself succeeded, its only the hint for that change that failed // don't bother checking for failures of this replace, because a failure to indicate the hint doesn't fail the command // also, don't force the replacement.  If the replacement fails on a resourceVersion conflict, then it means this // record hint is likely to be invalid anyway, so avoid the bad hint patch, err := cmdutil.ChangeResourcePatch(info, f.Command()) if err == nil { helper.Patch(info.Namespace, info.Name, api.StrategicMergePatchType, patch) </ins> } } count++", "commid": "kubernetes_pr_25876"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0a43404a90a4502792529d6f593d8f07cbefedf62cf2856b9027033dd071c9f", "query": "Hi, Deployment patching with doesn't show up in the deployment rollout history: first: after: Is it a bug? Should it show up? Thanks, Peter\ncc\nWhich kubernetes and kubectl releases? Did the patch actually trigger a rollout?\nI also run the command from CI with the latest . So the problem affects the v1.2.3 kubectl as well\nWe should also fix the way we sort revisions - 10 should be after 9, not 1.\nCan confirm this. The issue is that the patch isn't updating , so the rollout history will just copy the value from the previous version. If you started with you get that for the patches. In my case I have a different line repeated. Builds 7 and 8 were built with different . I'm not sure why the patch worked once. Command I am calling is:\nIf no one is working on patch - i can try to make one.\nI'll like to work on this issue if you haven't started yet\nActually never mind I can look at something else :)\nHi, i see that you are the author of the following comment. I think that currently every valid change cause is discarded because of version conflict. Maybe you have some information why it happens?\ncommand instead generates a patch to update then applies that.\nIt was the same for patch, but for some reason was changed.\nThe intent was two fold. First, prevent the change-cause from ever failing patch the CLI command. change-cause isn't authoritative and the patch took hold, so a non-zero return code is inappropriate. Second, if the resource version change post-patch, before the update, the change-cause is unknown, something else touched it after the fact. A command that issues a instead of an could very easily break the history since patches will attempt to reapply themselves regardless of resource version in the face of conflicts. The object returned from the patch operation is the one that we use to avoid hitting a resource conflict with ourselves. Truth be told, I don't feel very strongly about getting the history right since it can be changed anyone with write access to the object, includes secrets that should be elided (--token for instance), ignores environment variables which affect outcome, ignores the actual path used to locate the binary you're running, and references paths that are only good from one location on one machine, so if you want to switch it back to a second patch, I don't mind as long as a failure to update the object doesn't cause a non-zero return from the command.\nCould there be a race between the call and the deployment updating itself to action the changes? On 19 May 2016 9:47 pm, \"David Eads\" wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-552d5a4f04229d194333866a2519858fcfa775d7c94f914661cab31949614a3f", "text": "} // TODO: if we ever want to go generic, this allows a clean -o yaml without trying to print columns or anything // rawExtension := &runtime.Unknown{ <del> // \tRaw: originalPatchedObjJS, </del> <ins> //\tRaw: originalPatchedObjJS, </ins> // } printer, err := f.PrinterForMapping(cmd, mapping, false)", "commid": "kubernetes_pr_25876"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-69b2bd17365c09a24925384c93384c1277cb9057b6c5ebf013176177cc0220c1", "query": "Running show failures at times: The expected queue is while got , see code here: I would give an idea that these cases have something similar, so referring and /cc\ncc\nI think so as well.\nThe debugging I to the test is obviously not correct - I'll fix that separately.\nI wonder if on very short intervals we're not getting a goroutine schedule swap, which causes this race to manifest (based on comments in the other thread).\nDoes heap insertion guarantee order if the heap value is equivalent? I don't think so.\nThis seems like it is that now() is not monotonically increasing, so we violate the add ordering condition. Since we already have a lock in most cases, we may want to either wrap now() to make it monotonic inc, or have the queue check for equality in the heap and add one nanosecond until there is no matching heap item. On Apr 29, 2016, at 7:12 PM, Marek Grabowski wrote: cc \u2014 You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub\nThanks for clarification, so it looks like we need to give some time break between doing , I'll see whether that helps.\nI believe this is a bug in rate limited queue, so we definitely need to fix it (esp. since it's happening in the real world)\nyou wrote Would you be a good person to pick an owner for this bug? Giving P1 since we think happens in real world and I don't understand severity.\nand I are probably the two who have touched it, I think as well but may be misremembering. It should be a straightforward fix to make now monotonic, I don't know when I can get to it\nMe neither. If it's P1 I most likely won't have time before v1.3.\nI think override the function call in as you did would resolve this issue, what do you think, if you agree with this, I am gonna to try that.\nIt would fix it, although I think this is broken in the core code, not just in the test. We suspect real workloads have been impacted by this.\nOpened to determine whether we actually need to fix the RLQ\nAssigning to per", "positive_passages": [{"docid": "doc-en-kubernetes-923cb8ada8358a523094eae019170a1e5e8ca2b7f6bba855c866e25d4dc620d5", "text": "} func TestDelNode(t *testing.T) { <ins> defer func() { now = time.Now }() var tick int64 now = func() time.Time { t := time.Unix(tick, 0) tick++ return t } </ins> evictor := NewRateLimitedTimedQueue(flowcontrol.NewFakeAlwaysRateLimiter()) evictor.Add(\"first\") evictor.Add(\"second\")", "commid": "kubernetes_pr_25636"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e9c2f49189e70f3f181de8a8d3d5cbdc6480a56bdc940348429fa13efb7c56f", "query": "When i doing an elasticsearch aggs with the following statement: then, i got this: Actually, i want the pod names like this:\nI have solved this problem by adding a index template for k8s logs. Now, I can aggregation pod names of the same namespace.\nHow are you sending your logs to elasticsearch? Using the default fluentd configuration?\nFirst, I use the default fluentd configuration. Secondly, My application is written with nodejs language, using library.", "positive_passages": [{"docid": "doc-en-kubernetes-b67a2b56f7ff6553e006aec95fcf10eec7d4745e8dff4dd997ef8fb60423670a", "text": "tar xf elasticsearch-1.5.2.tar.gz &&  rm elasticsearch-1.5.2.tar.gz <ins> RUN mkdir -p /elasticsearch-1.5.2/config/templates </ins> COPY elasticsearch.yml /elasticsearch-1.5.2/config/elasticsearch.yml <ins> COPY template-k8s-logstash.json /elasticsearch-1.5.2/config/templates/template-k8s-logstash.json </ins> COPY run.sh / COPY elasticsearch_logging_discovery /", "commid": "kubernetes_pr_25309"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e9c2f49189e70f3f181de8a8d3d5cbdc6480a56bdc940348429fa13efb7c56f", "query": "When i doing an elasticsearch aggs with the following statement: then, i got this: Actually, i want the pod names like this:\nI have solved this problem by adding a index template for k8s logs. Now, I can aggregation pod names of the same namespace.\nHow are you sending your logs to elasticsearch? Using the default fluentd configuration?\nFirst, I use the default fluentd configuration. Secondly, My application is written with nodejs language, using library.", "positive_passages": [{"docid": "doc-en-kubernetes-d349bc58d26d053ff0a1ab139347e36e4e8201866e5ef02e1ea52776812895ac", "text": "<ins> { \"template_k8s_logstash\" : { \"template\" : \"logstash-*\", \"settings\" : { \"index.refresh_interval\" : \"5s\" }, \"mappings\" : { \"_default_\" : { \"dynamic_templates\" : [ { \"kubernetes_field\" : { \"path_match\" : \"kubernetes.*\", \"mapping\" : { \"type\" : \"string\", \"index\" : \"not_analyzed\" } } } ] } } } } </ins>", "commid": "kubernetes_pr_25309"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-42f599f347213b163fe7149497631054b9aebf3a38dc08dc679e08b10e38a774", "query": "is and does not honor the platform it is invoked on. I noticed this when I needed to install etcd on my Mac (which, in turn, was required by and transitively by the pre-commit hooks) and later failed to execute it due to an incompatible binary.\nOh wow, that explains my failures. I ended up using homebrew.", "positive_passages": [{"docid": "doc-en-kubernetes-ba84c6f4da529065660bb3cfffed18866b79cbdae8000f458458ad8be2d7962e", "text": "kube::etcd::install() { ( cd \"${KUBE_ROOT}/third_party\" <del> curl -fsSL --retry 3 https://github.com/coreos/etcd/releases/download/v${ETCD_VERSION}/etcd-v${ETCD_VERSION}-linux-amd64.tar.gz | tar xzf - ln -fns \"etcd-v${ETCD_VERSION}-linux-amd64\" etcd </del> <ins> if [[ $(uname) == \"Darwin\" ]]; then download_file=\"etcd-v${ETCD_VERSION}-darwin-amd64.zip\" curl -fsSLO --retry 3 https://github.com/coreos/etcd/releases/download/v${ETCD_VERSION}/\"${download_file}\" unzip -o \"${download_file}\" ln -fns \"etcd-v${ETCD_VERSION}-darwin-amd64\" etcd rm \"${download_file}\" else curl -fsSL --retry 3 https://github.com/coreos/etcd/releases/download/v${ETCD_VERSION}/etcd-v${ETCD_VERSION}-linux-amd64.tar.gz | tar xzf - ln -fns \"etcd-v${ETCD_VERSION}-linux-amd64\" etcd fi </ins> kube::log::info \"etcd v${ETCD_VERSION} installed. To use:\" kube::log::info \"export PATH=${PATH}:$(pwd)/etcd\" )", "commid": "kubernetes_pr_26047"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5056a2515a29befdf589a74f13db031ed4142bbabfa8d2c37cafac2de4fccaea", "query": "I started the federation-apiserver and went to and got the following output: Expected: I should have got an empty v1.ServiceList Any idea on what we are doing wrong? Have you guys seen this error?\nI think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote:\nDeep copy generation was slightly broken as well - you may want to double check that they are registered. On May 23, 2016, at 5:50 PM, Daniel Smith wrote: I think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote: \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly or view it on GitHub\nI got the same error with latest branch, as I was swamping on service controller, so I use a previous version and worked around it.\ndeep copies were indeed missing, but adding them hasnt fixed the issue. Will debug more. is my PR to add the deep copies cc Please feel free to file issues for any such problem you face. We need to fix all these issues. Its good if we know about them early. Thanks!\nfixes this", "positive_passages": [{"docid": "doc-en-kubernetes-6b84738a94a23af0f56a7c8cf31220024d7d74d7993be985041a14472692bb8b", "text": "<ins> /* Copyright 2016 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package core import ( \"k8s.io/kubernetes/pkg/api\" \"k8s.io/kubernetes/pkg/fields\" \"k8s.io/kubernetes/pkg/labels\" \"k8s.io/kubernetes/pkg/runtime\" ) func addDefaultingFuncs(scheme *runtime.Scheme) { scheme.AddDefaultingFuncs( func(obj *api.ListOptions) { if obj.LabelSelector == nil { obj.LabelSelector = labels.Everything() } if obj.FieldSelector == nil { obj.FieldSelector = fields.Everything() } }, ) } func addConversionFuncs(scheme *runtime.Scheme) { scheme.AddConversionFuncs( api.Convert_unversioned_TypeMeta_To_unversioned_TypeMeta, api.Convert_unversioned_ListMeta_To_unversioned_ListMeta, api.Convert_intstr_IntOrString_To_intstr_IntOrString, api.Convert_unversioned_Time_To_unversioned_Time, api.Convert_Slice_string_To_unversioned_Time, api.Convert_string_To_labels_Selector, api.Convert_string_To_fields_Selector, api.Convert_Pointer_bool_To_bool, api.Convert_bool_To_Pointer_bool, api.Convert_Pointer_string_To_string, api.Convert_string_To_Pointer_string, api.Convert_labels_Selector_To_string, api.Convert_fields_Selector_To_string, api.Convert_resource_Quantity_To_resource_Quantity, ) } </ins>", "commid": "kubernetes_pr_26142"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5056a2515a29befdf589a74f13db031ed4142bbabfa8d2c37cafac2de4fccaea", "query": "I started the federation-apiserver and went to and got the following output: Expected: I should have got an empty v1.ServiceList Any idea on what we are doing wrong? Have you guys seen this error?\nI think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote:\nDeep copy generation was slightly broken as well - you may want to double check that they are registered. On May 23, 2016, at 5:50 PM, Daniel Smith wrote: I think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote: \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly or view it on GitHub\nI got the same error with latest branch, as I was swamping on service controller, so I use a previous version and worked around it.\ndeep copies were indeed missing, but adding them hasnt fixed the issue. Will debug more. is my PR to add the deep copies cc Please feel free to file issues for any such problem you face. We need to fix all these issues. Its good if we know about them early. Thanks!\nfixes this", "positive_passages": [{"docid": "doc-en-kubernetes-7594f092355a5bc5de3628251b80f8ee7d09e6e990b3b8284693c9a26ddfe3ac", "text": "<ins> /* Copyright 2016 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package core import ( \"k8s.io/kubernetes/pkg/api\" \"k8s.io/kubernetes/pkg/runtime\" ) func addDeepCopyFuncs(scheme *runtime.Scheme) { if err := scheme.AddGeneratedDeepCopyFuncs( api.DeepCopy_api_DeleteOptions, api.DeepCopy_api_ExportOptions, api.DeepCopy_api_List, api.DeepCopy_api_ListOptions, api.DeepCopy_api_ObjectMeta, api.DeepCopy_api_ObjectReference, api.DeepCopy_api_OwnerReference, api.DeepCopy_api_Service, api.DeepCopy_api_ServiceList, api.DeepCopy_api_ServicePort, api.DeepCopy_api_ServiceSpec, api.DeepCopy_api_ServiceStatus, ); err != nil { // if one of the deep copy functions is malformed, detect it immediately. panic(err) } } </ins>", "commid": "kubernetes_pr_26142"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5056a2515a29befdf589a74f13db031ed4142bbabfa8d2c37cafac2de4fccaea", "query": "I started the federation-apiserver and went to and got the following output: Expected: I should have got an empty v1.ServiceList Any idea on what we are doing wrong? Have you guys seen this error?\nI think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote:\nDeep copy generation was slightly broken as well - you may want to double check that they are registered. On May 23, 2016, at 5:50 PM, Daniel Smith wrote: I think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote: \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly or view it on GitHub\nI got the same error with latest branch, as I was swamping on service controller, so I use a previous version and worked around it.\ndeep copies were indeed missing, but adding them hasnt fixed the issue. Will debug more. is my PR to add the deep copies cc Please feel free to file issues for any such problem you face. We need to fix all these issues. Its good if we know about them early. Thanks!\nfixes this", "positive_passages": [{"docid": "doc-en-kubernetes-4bb9d79fd048482eaecc5f7b756e34b0dbbbd4b13e8aa133619f7ccf0277763a", "text": "&unversioned.APIGroup{}, &unversioned.APIResourceList{}, ) <ins> addDeepCopyFuncs(scheme) addDefaultingFuncs(scheme) addConversionFuncs(scheme) </ins> }", "commid": "kubernetes_pr_26142"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5056a2515a29befdf589a74f13db031ed4142bbabfa8d2c37cafac2de4fccaea", "query": "I started the federation-apiserver and went to and got the following output: Expected: I should have got an empty v1.ServiceList Any idea on what we are doing wrong? Have you guys seen this error?\nI think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote:\nDeep copy generation was slightly broken as well - you may want to double check that they are registered. On May 23, 2016, at 5:50 PM, Daniel Smith wrote: I think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote: \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly or view it on GitHub\nI got the same error with latest branch, as I was swamping on service controller, so I use a previous version and worked around it.\ndeep copies were indeed missing, but adding them hasnt fixed the issue. Will debug more. is my PR to add the deep copies cc Please feel free to file issues for any such problem you face. We need to fix all these issues. Its good if we know about them early. Thanks!\nfixes this", "positive_passages": [{"docid": "doc-en-kubernetes-9193350c46f90fcba863fe730753ca88a2c7e627b9f6e798745899178328a0f9", "text": "import ( \"fmt\" <del> \"k8s.io/kubernetes/pkg/api\" </del> \"k8s.io/kubernetes/pkg/api/v1\" \"k8s.io/kubernetes/pkg/runtime\" )", "commid": "kubernetes_pr_26142"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5056a2515a29befdf589a74f13db031ed4142bbabfa8d2c37cafac2de4fccaea", "query": "I started the federation-apiserver and went to and got the following output: Expected: I should have got an empty v1.ServiceList Any idea on what we are doing wrong? Have you guys seen this error?\nI think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote:\nDeep copy generation was slightly broken as well - you may want to double check that they are registered. On May 23, 2016, at 5:50 PM, Daniel Smith wrote: I think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote: \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly or view it on GitHub\nI got the same error with latest branch, as I was swamping on service controller, so I use a previous version and worked around it.\ndeep copies were indeed missing, but adding them hasnt fixed the issue. Will debug more. is my PR to add the deep copies cc Please feel free to file issues for any such problem you face. We need to fix all these issues. Its good if we know about them early. Thanks!\nfixes this", "positive_passages": [{"docid": "doc-en-kubernetes-607e84ced79aa2e76fd42d37a38cdd726e203cf299d4c370a9d77a45aac10bba", "text": "func addConversionFuncs(scheme *runtime.Scheme) { // Add non-generated conversion functions err := scheme.AddConversionFuncs( <del> v1.Convert_api_ServiceSpec_To_v1_ServiceSpec, </del> <ins> v1.Convert_v1_DeleteOptions_To_api_DeleteOptions, v1.Convert_api_DeleteOptions_To_v1_DeleteOptions, v1.Convert_v1_ExportOptions_To_api_ExportOptions, v1.Convert_api_ExportOptions_To_v1_ExportOptions, v1.Convert_v1_List_To_api_List, v1.Convert_api_List_To_v1_List, v1.Convert_v1_ListOptions_To_api_ListOptions, v1.Convert_api_ListOptions_To_v1_ListOptions, v1.Convert_v1_ObjectFieldSelector_To_api_ObjectFieldSelector, v1.Convert_api_ObjectFieldSelector_To_v1_ObjectFieldSelector, v1.Convert_v1_ObjectMeta_To_api_ObjectMeta, v1.Convert_api_ObjectMeta_To_v1_ObjectMeta, v1.Convert_v1_ObjectReference_To_api_ObjectReference, v1.Convert_api_ObjectReference_To_v1_ObjectReference, v1.Convert_v1_OwnerReference_To_api_OwnerReference, v1.Convert_api_OwnerReference_To_v1_OwnerReference, v1.Convert_v1_Service_To_api_Service, v1.Convert_api_Service_To_v1_Service, v1.Convert_v1_ServiceList_To_api_ServiceList, v1.Convert_api_ServiceList_To_v1_ServiceList, v1.Convert_v1_ServicePort_To_api_ServicePort, v1.Convert_api_ServicePort_To_v1_ServicePort, v1.Convert_v1_ServiceProxyOptions_To_api_ServiceProxyOptions, v1.Convert_api_ServiceProxyOptions_To_v1_ServiceProxyOptions, </ins> v1.Convert_v1_ServiceSpec_To_api_ServiceSpec, <ins> v1.Convert_api_ServiceSpec_To_v1_ServiceSpec, v1.Convert_v1_ServiceStatus_To_api_ServiceStatus, v1.Convert_api_ServiceStatus_To_v1_ServiceStatus, </ins> ) if err != nil { // If one of the conversion functions is malformed, detect it immediately.", "commid": "kubernetes_pr_26142"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5056a2515a29befdf589a74f13db031ed4142bbabfa8d2c37cafac2de4fccaea", "query": "I started the federation-apiserver and went to and got the following output: Expected: I should have got an empty v1.ServiceList Any idea on what we are doing wrong? Have you guys seen this error?\nI think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote:\nDeep copy generation was slightly broken as well - you may want to double check that they are registered. On May 23, 2016, at 5:50 PM, Daniel Smith wrote: I think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote: \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly or view it on GitHub\nI got the same error with latest branch, as I was swamping on service controller, so I use a previous version and worked around it.\ndeep copies were indeed missing, but adding them hasnt fixed the issue. Will debug more. is my PR to add the deep copies cc Please feel free to file issues for any such problem you face. We need to fix all these issues. Its good if we know about them early. Thanks!\nfixes this", "positive_passages": [{"docid": "doc-en-kubernetes-730e16fcf0872634daf133e83372c62bab09568914217adae36e316b4301ad9a", "text": "for _, kind := range []string{ \"Service\", } { <del> err = api.Scheme.AddFieldLabelConversionFunc(\"v1\", kind, </del> <ins> err = scheme.AddFieldLabelConversionFunc(\"v1\", kind, </ins> func(label, value string) (string, string, error) { switch label { case \"metadata.namespace\",", "commid": "kubernetes_pr_26142"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5056a2515a29befdf589a74f13db031ed4142bbabfa8d2c37cafac2de4fccaea", "query": "I started the federation-apiserver and went to and got the following output: Expected: I should have got an empty v1.ServiceList Any idea on what we are doing wrong? Have you guys seen this error?\nI think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote:\nDeep copy generation was slightly broken as well - you may want to double check that they are registered. On May 23, 2016, at 5:50 PM, Daniel Smith wrote: I think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote: \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly or view it on GitHub\nI got the same error with latest branch, as I was swamping on service controller, so I use a previous version and worked around it.\ndeep copies were indeed missing, but adding them hasnt fixed the issue. Will debug more. is my PR to add the deep copies cc Please feel free to file issues for any such problem you face. We need to fix all these issues. Its good if we know about them early. Thanks!\nfixes this", "positive_passages": [{"docid": "doc-en-kubernetes-71d428ebfbc7fa4fb0807eb410ca7f2bf521c711473b4462db452802b18c4739", "text": "<ins> /* Copyright 2016 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package v1 import ( \"k8s.io/kubernetes/pkg/api/v1\" \"k8s.io/kubernetes/pkg/runtime\" ) func addDeepCopyFuncs(scheme *runtime.Scheme) { if err := scheme.AddGeneratedDeepCopyFuncs( v1.DeepCopy_v1_DeleteOptions, v1.DeepCopy_v1_ExportOptions, v1.DeepCopy_v1_List, v1.DeepCopy_v1_ListOptions, v1.DeepCopy_v1_ObjectMeta, v1.DeepCopy_v1_ObjectReference, v1.DeepCopy_v1_OwnerReference, v1.DeepCopy_v1_Service, v1.DeepCopy_v1_ServiceList, v1.DeepCopy_v1_ServicePort, v1.DeepCopy_v1_ServiceSpec, v1.DeepCopy_v1_ServiceStatus, ); err != nil { // if one of the deep copy functions is malformed, detect it immediately. panic(err) } } </ins>", "commid": "kubernetes_pr_26142"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5056a2515a29befdf589a74f13db031ed4142bbabfa8d2c37cafac2de4fccaea", "query": "I started the federation-apiserver and went to and got the following output: Expected: I should have got an empty v1.ServiceList Any idea on what we are doing wrong? Have you guys seen this error?\nI think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote:\nDeep copy generation was slightly broken as well - you may want to double check that they are registered. On May 23, 2016, at 5:50 PM, Daniel Smith wrote: I think your deep copiers or conversion functions are not getting registered properly. If you look at my change in , some places are inappropriately registering with api.Scheme instead of the passed in scheme. Maybe you have that problem or a similar one, since I think you guys copied some code. , Nikhil Jindal wrote: \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly or view it on GitHub\nI got the same error with latest branch, as I was swamping on service controller, so I use a previous version and worked around it.\ndeep copies were indeed missing, but adding them hasnt fixed the issue. Will debug more. is my PR to add the deep copies cc Please feel free to file issues for any such problem you face. We need to fix all these issues. Its good if we know about them early. Thanks!\nfixes this", "positive_passages": [{"docid": "doc-en-kubernetes-0c27dc9269463d68be33f02fb16abc2a50d57f28e79ff20b73b070221e6ffb90", "text": "addKnownTypes(scheme) addConversionFuncs(scheme) addDefaultingFuncs(scheme) <ins> addDeepCopyFuncs(scheme) </ins> } // Adds the list of known types to api.Scheme.", "commid": "kubernetes_pr_26142"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c5413e82f6f4d07df951c5f23d8ac5d09ba356ec19c2b239217d4746388b00db", "query": "https://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nAbhishek ought not be responsible for this any more.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention...\n[FLAKE-PING] This flaky-test issue would love to have more attention...\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nwhat is the status of this issue?\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nNo idea. This should have nothing to do with me.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nAh kk just thought you might know something given the label.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nI know it didn't get any attention last release :)\nStatus is that I'm trying to fix it... I some code to the test to help debug why the flake was occurring as I wasn't able to repro it on my local cluster.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite} Happened on a presubmit run in .\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nThis seems to be related to issue", "positive_passages": [{"docid": "doc-en-kubernetes-7cd2e9a903ffb272eb913a3337912ccb3388d38e4f7b89795a67b5b463cf17f1", "text": "func assertManagedStatus( config *KubeletManagedHostConfig, podName string, expectedIsManaged bool, name string) { <del> // See https://github.com/kubernetes/kubernetes/issues/27023 </del> <ins> // TODO: workaround for https://github.com/kubernetes/kubernetes/issues/34256 </ins> // <del> // Retry until timeout for the right contents of /etc/hosts to show // up. There may be a low probability race here. We still fail the // test if retry was necessary, but at least we will know whether or // not it resolves or seems to be a permanent condition. // // If /etc/hosts is properly mounted, then this will succeed // immediately. </del> <ins> // Retry until timeout for the contents of /etc/hosts to show // up. Note: if /etc/hosts is properly mounted, then this will // succeed immediately. </ins> const retryTimeout = 30 * time.Second retryCount := 0 etcHostsContent := \"\" <del> matched := false </del> for startTime := time.Now(); time.Since(startTime) < retryTimeout; { etcHostsContent = config.getEtcHostsContent(podName, name) isManaged := strings.Contains(etcHostsContent, etcHostsPartialContent) if expectedIsManaged == isManaged { <del> matched = true break </del> <ins> return </ins> } <del> glog.Errorf( </del> <ins> glog.Warningf( </ins> \"For pod: %s, name: %s, expected %t, actual %t (/etc/hosts was %q), retryCount: %d\", podName, name, expectedIsManaged, isManaged, etcHostsContent, retryCount)", "commid": "kubernetes_pr_34357"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c5413e82f6f4d07df951c5f23d8ac5d09ba356ec19c2b239217d4746388b00db", "query": "https://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nAbhishek ought not be responsible for this any more.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention...\n[FLAKE-PING] This flaky-test issue would love to have more attention...\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nwhat is the status of this issue?\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nNo idea. This should have nothing to do with me.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nAh kk just thought you might know something given the label.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nI know it didn't get any attention last release :)\nStatus is that I'm trying to fix it... I some code to the test to help debug why the flake was occurring as I wasn't able to repro it on my local cluster.\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite} Happened on a presubmit run in .\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nhttps://k8s- Failed: [] KubeletManagedEtcHosts should test kubelet managed /etc/hosts file {Kubernetes e2e suite}\nThis seems to be related to issue", "positive_passages": [{"docid": "doc-en-kubernetes-9b19c9bacfa8a6878cf3519a632b8f7464e463be24090eac789eda0a8c7f263b", "text": "time.Sleep(100 * time.Millisecond) } <del> if retryCount > 0 { if matched { conditionText := \"should\" if !expectedIsManaged { conditionText = \"should not\" } framework.Failf( \"/etc/hosts file %s be kubelet managed (name: %s, retries: %d). /etc/hosts contains %q\", conditionText, name, retryCount, etcHostsContent) } else { framework.Failf( \"had to retry %d times to get matching content in /etc/hosts (name: %s)\", retryCount, name) } </del> <ins> if expectedIsManaged { framework.Failf( \"/etc/hosts file should be kubelet managed (name: %s, retries: %d). /etc/hosts contains %q\", name, retryCount, etcHostsContent) } else { framework.Failf( \"/etc/hosts file should no be kubelet managed (name: %s, retries: %d). /etc/hosts contains %q\", name, retryCount, etcHostsContent) </ins> } }", "commid": "kubernetes_pr_34357"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7679d12cc281cd209833defbf14abe814f6b5c54a99eb0fd89353cf78522b104", "query": "Hello Kubernetes, The order of the columns when you get events confused me. I was thinking, Turns out it's just a visual problem where these events are sorted correctly (by ), but the first column is . I think the first column should be because that's the order the events are listed.\nThis also confused me when I first saw it - I think this ordering would be more intuitive and help users discover the aggregation feature logically, instead of first having to grapple with why events are \"out of order\"\nShould the order be always LASTSEEN,FIRSTSEEN or just when using -w? I have an ugly PR for the latter, but perhaps we should just go for the former.", "positive_passages": [{"docid": "doc-en-kubernetes-df84244d39276a9a203153ee2d6c383335e287c0a4e6d0269e1f13c2d4ed4bf7", "text": "var endpointColumns = []string{\"NAME\", \"ENDPOINTS\", \"AGE\"} var nodeColumns = []string{\"NAME\", \"STATUS\", \"AGE\"} var daemonSetColumns = []string{\"NAME\", \"DESIRED\", \"CURRENT\", \"NODE-SELECTOR\", \"AGE\"} <del> var eventColumns = []string{\"FIRSTSEEN\", \"LASTSEEN\", \"COUNT\", \"NAME\", \"KIND\", \"SUBOBJECT\", \"TYPE\", \"REASON\", \"SOURCE\", \"MESSAGE\"} </del> <ins> var eventColumns = []string{\"LASTSEEN\", \"FIRSTSEEN\", \"COUNT\", \"NAME\", \"KIND\", \"SUBOBJECT\", \"TYPE\", \"REASON\", \"SOURCE\", \"MESSAGE\"} </ins> var limitRangeColumns = []string{\"NAME\", \"AGE\"} var resourceQuotaColumns = []string{\"NAME\", \"AGE\"} var namespaceColumns = []string{\"NAME\", \"STATUS\", \"AGE\"}", "commid": "kubernetes_pr_27549"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7679d12cc281cd209833defbf14abe814f6b5c54a99eb0fd89353cf78522b104", "query": "Hello Kubernetes, The order of the columns when you get events confused me. I was thinking, Turns out it's just a visual problem where these events are sorted correctly (by ), but the first column is . I think the first column should be because that's the order the events are listed.\nThis also confused me when I first saw it - I think this ordering would be more intuitive and help users discover the aggregation feature logically, instead of first having to grapple with why events are \"out of order\"\nShould the order be always LASTSEEN,FIRSTSEEN or just when using -w? I have an ugly PR for the latter, but perhaps we should just go for the former.", "positive_passages": [{"docid": "doc-en-kubernetes-cad1fa7eff47c69fcfd59f8fc7aa244645ffa6e26f50bc30b33322d5eb0ab108", "text": "if _, err := fmt.Fprintf( w, \"%st%st%dt%st%st%st%st%st%st%s\", <del> FirstTimestamp, </del> LastTimestamp, <ins> FirstTimestamp, </ins> event.Count, event.InvolvedObject.Name, event.InvolvedObject.Kind,", "commid": "kubernetes_pr_27549"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f95224274155bb39af2e05742451e79cefc1f176d05622797c3ba56ecf46808", "query": "is failing with: Examples:\nThis is the failing line of code...\nPASS: FAIL: Seems like this disappeared: Also this is flipped: we run the following\nmy leading theory is this is something in\nThe issue is that the above PR changed a bunch of to be and thus we no longer wait for getArchive() to complete before starting tests. And unfortunately the previous PR cannot be reverted\nAfter merging, kubelet-gce-e2e-ci still failed with the same issue. reopen the issue. Currently the failure blocked the merge-bot.\ndid stop the bleeding. Now kubelet-gce-e2e-ci is green: and merge-bot is unblocked.\nI think the \"go arc\" piece was a red herring. I suspect the issue is that the same PR tries to copy the binary into the archive directory, but PR stops building ginkgo, so the copy fails. That is why this line then fails...", "positive_passages": [{"docid": "doc-en-kubernetes-73295edc882161b8be65028842cfb0cb0d438b3beb196432dc1c73796c43fca1", "text": "var k8sBinDir = flag.String(\"k8s-bin-dir\", \"\", \"Directory containing k8s kubelet and kube-apiserver binaries.\") <del> var buildTargets = []string{ \"cmd/kubelet\", \"cmd/kube-apiserver\", \"test/e2e_node/e2e_node.test\", } </del> func buildGo() { glog.Infof(\"Building k8s binaries...\") k8sRoot, err := getK8sRootDir() if err != nil { glog.Fatalf(\"Failed to locate kubernetes root directory %v.\", err) } <del> cmd := exec.Command(filepath.Join(k8sRoot, \"hack/build-go.sh\"), buildTargets...) </del> <ins> cmd := exec.Command(filepath.Join(k8sRoot, \"hack/build-go.sh\")) </ins> cmd.Stdout = os.Stdout cmd.Stderr = os.Stderr err = cmd.Run()", "commid": "kubernetes_pr_27108"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f95224274155bb39af2e05742451e79cefc1f176d05622797c3ba56ecf46808", "query": "is failing with: Examples:\nThis is the failing line of code...\nPASS: FAIL: Seems like this disappeared: Also this is flipped: we run the following\nmy leading theory is this is something in\nThe issue is that the above PR changed a bunch of to be and thus we no longer wait for getArchive() to complete before starting tests. And unfortunately the previous PR cannot be reverted\nAfter merging, kubelet-gce-e2e-ci still failed with the same issue. reopen the issue. Currently the failure blocked the merge-bot.\ndid stop the bleeding. Now kubelet-gce-e2e-ci is green: and merge-bot is unblocked.\nI think the \"go arc\" piece was a red herring. I suspect the issue is that the same PR tries to copy the binary into the archive directory, but PR stops building ginkgo, so the copy fails. That is why this line then fails...", "positive_passages": [{"docid": "doc-en-kubernetes-92743c6358e0bad6ac9d7d238a92ee22571b88ffaefaedc04c71c8086c6a496e", "text": "return \"\", err } if _, err := os.Stat(filepath.Join(*k8sBinDir, bin)); err != nil { <del> return \"\", fmt.Errorf(\"Could not find %s under directory %s.\", bin, absPath) </del> <ins> return \"\", fmt.Errorf(\"Could not find kube-apiserver under directory %s.\", absPath) </ins> } return filepath.Join(absPath, bin), nil }", "commid": "kubernetes_pr_27108"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-137e73901e94fc53b23ce122acea4f6c63caaffb221f4c8fdcf70adeb68da5f7", "query": "When replacing an existing pod, the command fails as it tries to create a pod with a name that is still used by terminating pod. How does the option works? deletes a pod (e.g. mypod) creates a new pod with the same name (mypod) What happens? As the command tries to recreate the pod, it fails as the is in state. Thus it can not be created. The problem is the does not wait for a pod to be deleted. Reproducer: run mypod --image=yapei/hello-openshift --generator=run-pod/v1 get pod mypod -o yaml replace -f --force The last command ends with:\noption introduce by\nWith set to positive value, what should be the default behaviour of the command? When set to , should the command hang for and then create the pod? Or is there a way to create a callback (inside a scheduler?) that creates the pod once the current one is deleted?\nYou could watch for the resource to be deleted and create after you see the deletion happen\nhave you ever tried to set , I think this will do a non graceful deletion. should make sure the old resource is deleted before it creates a new resource, if not, that's a bug.\nThough the help says the is to be used only with , it returns the error above.\nThen I think there are two issues we need to track: 1. option should be ignored or just returns error if users are not using option. 2. should always make sure the old resource has been deleted before create the new resource.", "positive_passages": [{"docid": "doc-en-kubernetes-dab75e57b1154a44c86579560ea00a1304ab777c7f22cf03803fba62c4e37550", "text": "kubectl replace \"${kube_flags[@]}\" --force -f /tmp/tmp-valid-pod.json # Post-condition: spec.container.name = \"replaced-k8s-serve-hostname\" kube::test::get_object_assert 'pod valid-pod' \"{{(index .spec.containers 0).name}}\" 'replaced-k8s-serve-hostname' <ins> ## check replace --grace-period requires --force output_message=$(! kubectl replace \"${kube_flags[@]}\" --grace-period=1 -f /tmp/tmp-valid-pod.json 2>&1) kube::test::if_has_string \"${output_message}\" '--grace-period must have --force specified' ## check replace --timeout requires --force output_message=$(! kubectl replace \"${kube_flags[@]}\" --timeout=1s -f /tmp/tmp-valid-pod.json 2>&1) kube::test::if_has_string \"${output_message}\" '--timeout must have --force specified' </ins> #cleaning rm /tmp/tmp-valid-pod.json", "commid": "kubernetes_pr_31841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-137e73901e94fc53b23ce122acea4f6c63caaffb221f4c8fdcf70adeb68da5f7", "query": "When replacing an existing pod, the command fails as it tries to create a pod with a name that is still used by terminating pod. How does the option works? deletes a pod (e.g. mypod) creates a new pod with the same name (mypod) What happens? As the command tries to recreate the pod, it fails as the is in state. Thus it can not be created. The problem is the does not wait for a pod to be deleted. Reproducer: run mypod --image=yapei/hello-openshift --generator=run-pod/v1 get pod mypod -o yaml replace -f --force The last command ends with:\noption introduce by\nWith set to positive value, what should be the default behaviour of the command? When set to , should the command hang for and then create the pod? Or is there a way to create a callback (inside a scheduler?) that creates the pod once the current one is deleted?\nYou could watch for the resource to be deleted and create after you see the deletion happen\nhave you ever tried to set , I think this will do a non graceful deletion. should make sure the old resource is deleted before it creates a new resource, if not, that's a bug.\nThough the help says the is to be used only with , it returns the error above.\nThen I think there are two issues we need to track: 1. option should be ignored or just returns error if users are not using option. 2. should always make sure the old resource has been deleted before create the new resource.", "positive_passages": [{"docid": "doc-en-kubernetes-b8ab92bba877a2e277509e29b9f50eba1c508735654361e9f650e8fd7bd542b1", "text": "\"github.com/spf13/cobra\" \"github.com/golang/glog\" <ins> \"k8s.io/kubernetes/pkg/api/errors\" </ins> \"k8s.io/kubernetes/pkg/kubectl\" cmdutil \"k8s.io/kubernetes/pkg/kubectl/cmd/util\" \"k8s.io/kubernetes/pkg/kubectl/resource\" \"k8s.io/kubernetes/pkg/runtime\" <ins> \"k8s.io/kubernetes/pkg/util/wait\" </ins> ) // ReplaceOptions is the start of the data required to perform the operation.  As new fields are added, add them here instead of", "commid": "kubernetes_pr_31841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-137e73901e94fc53b23ce122acea4f6c63caaffb221f4c8fdcf70adeb68da5f7", "query": "When replacing an existing pod, the command fails as it tries to create a pod with a name that is still used by terminating pod. How does the option works? deletes a pod (e.g. mypod) creates a new pod with the same name (mypod) What happens? As the command tries to recreate the pod, it fails as the is in state. Thus it can not be created. The problem is the does not wait for a pod to be deleted. Reproducer: run mypod --image=yapei/hello-openshift --generator=run-pod/v1 get pod mypod -o yaml replace -f --force The last command ends with:\noption introduce by\nWith set to positive value, what should be the default behaviour of the command? When set to , should the command hang for and then create the pod? Or is there a way to create a callback (inside a scheduler?) that creates the pod once the current one is deleted?\nYou could watch for the resource to be deleted and create after you see the deletion happen\nhave you ever tried to set , I think this will do a non graceful deletion. should make sure the old resource is deleted before it creates a new resource, if not, that's a bug.\nThough the help says the is to be used only with , it returns the error above.\nThen I think there are two issues we need to track: 1. option should be ignored or just returns error if users are not using option. 2. should always make sure the old resource has been deleted before create the new resource.", "positive_passages": [{"docid": "doc-en-kubernetes-532d88d15463bb362b69ff6d72f0a2a13d139e5b4795fea68bb8c08a78cea5dc", "text": "return forceReplace(f, out, cmd, args, shortOutput, options) } <ins> if cmdutil.GetFlagInt(cmd, \"grace-period\") >= 0 { return fmt.Errorf(\"--grace-period must have --force specified\") } if cmdutil.GetFlagDuration(cmd, \"timeout\") != 0 { return fmt.Errorf(\"--timeout must have --force specified\") } </ins> mapper, typer := f.Object(cmdutil.GetIncludeThirdPartyAPIs(cmd)) r := resource.NewBuilder(mapper, typer, resource.ClientMapperFunc(f.ClientForMapping), f.Decoder(true)). Schema(schema).", "commid": "kubernetes_pr_31841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-137e73901e94fc53b23ce122acea4f6c63caaffb221f4c8fdcf70adeb68da5f7", "query": "When replacing an existing pod, the command fails as it tries to create a pod with a name that is still used by terminating pod. How does the option works? deletes a pod (e.g. mypod) creates a new pod with the same name (mypod) What happens? As the command tries to recreate the pod, it fails as the is in state. Thus it can not be created. The problem is the does not wait for a pod to be deleted. Reproducer: run mypod --image=yapei/hello-openshift --generator=run-pod/v1 get pod mypod -o yaml replace -f --force The last command ends with:\noption introduce by\nWith set to positive value, what should be the default behaviour of the command? When set to , should the command hang for and then create the pod? Or is there a way to create a callback (inside a scheduler?) that creates the pod once the current one is deleted?\nYou could watch for the resource to be deleted and create after you see the deletion happen\nhave you ever tried to set , I think this will do a non graceful deletion. should make sure the old resource is deleted before it creates a new resource, if not, that's a bug.\nThough the help says the is to be used only with , it returns the error above.\nThen I think there are two issues we need to track: 1. option should be ignored or just returns error if users are not using option. 2. should always make sure the old resource has been deleted before create the new resource.", "positive_passages": [{"docid": "doc-en-kubernetes-fc3384fd8a13d7e0f644848a247d424d80fef3ecf578423d688de74fb533c9c0", "text": "} //Replace will create a resource if it doesn't exist already, so ignore not found error ignoreNotFound := true <ins> timeout := cmdutil.GetFlagDuration(cmd, \"timeout\") </ins> // By default use a reaper to delete all related resources. if cmdutil.GetFlagBool(cmd, \"cascade\") { glog.Warningf(\"\"cascade\" is set, kubectl will delete and re-create all resources managed by this resource (e.g. Pods created by a ReplicationController). Consider using \"kubectl rolling-update\" if you want to update a ReplicationController together with its Pods.\") <del> err = ReapResult(r, f, out, cmdutil.GetFlagBool(cmd, \"cascade\"), ignoreNotFound, cmdutil.GetFlagDuration(cmd, \"timeout\"), cmdutil.GetFlagInt(cmd, \"grace-period\"), shortOutput, mapper, false) </del> <ins> err = ReapResult(r, f, out, cmdutil.GetFlagBool(cmd, \"cascade\"), ignoreNotFound, timeout, cmdutil.GetFlagInt(cmd, \"grace-period\"), shortOutput, mapper, false) </ins> } else { err = DeleteResult(r, out, ignoreNotFound, shortOutput, mapper) }", "commid": "kubernetes_pr_31841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-137e73901e94fc53b23ce122acea4f6c63caaffb221f4c8fdcf70adeb68da5f7", "query": "When replacing an existing pod, the command fails as it tries to create a pod with a name that is still used by terminating pod. How does the option works? deletes a pod (e.g. mypod) creates a new pod with the same name (mypod) What happens? As the command tries to recreate the pod, it fails as the is in state. Thus it can not be created. The problem is the does not wait for a pod to be deleted. Reproducer: run mypod --image=yapei/hello-openshift --generator=run-pod/v1 get pod mypod -o yaml replace -f --force The last command ends with:\noption introduce by\nWith set to positive value, what should be the default behaviour of the command? When set to , should the command hang for and then create the pod? Or is there a way to create a callback (inside a scheduler?) that creates the pod once the current one is deleted?\nYou could watch for the resource to be deleted and create after you see the deletion happen\nhave you ever tried to set , I think this will do a non graceful deletion. should make sure the old resource is deleted before it creates a new resource, if not, that's a bug.\nThough the help says the is to be used only with , it returns the error above.\nThen I think there are two issues we need to track: 1. option should be ignored or just returns error if users are not using option. 2. should always make sure the old resource has been deleted before create the new resource.", "positive_passages": [{"docid": "doc-en-kubernetes-24e12552e7d4bc11a4bae587cf87efb5ebd98d10e90aacd6e973fec59f38aece", "text": "return err } <ins> if timeout == 0 { timeout = kubectl.Timeout } r.Visit(func(info *resource.Info, err error) error { if err != nil { return err } return wait.PollImmediate(kubectl.Interval, timeout, func() (bool, error) { if err := info.Get(); !errors.IsNotFound(err) { return false, err } return true, nil }) }) </ins> r = resource.NewBuilder(mapper, typer, resource.ClientMapperFunc(f.UnstructuredClientForMapping), runtime.UnstructuredJSONScheme). Schema(schema). ContinueOnError().", "commid": "kubernetes_pr_31841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-137e73901e94fc53b23ce122acea4f6c63caaffb221f4c8fdcf70adeb68da5f7", "query": "When replacing an existing pod, the command fails as it tries to create a pod with a name that is still used by terminating pod. How does the option works? deletes a pod (e.g. mypod) creates a new pod with the same name (mypod) What happens? As the command tries to recreate the pod, it fails as the is in state. Thus it can not be created. The problem is the does not wait for a pod to be deleted. Reproducer: run mypod --image=yapei/hello-openshift --generator=run-pod/v1 get pod mypod -o yaml replace -f --force The last command ends with:\noption introduce by\nWith set to positive value, what should be the default behaviour of the command? When set to , should the command hang for and then create the pod? Or is there a way to create a callback (inside a scheduler?) that creates the pod once the current one is deleted?\nYou could watch for the resource to be deleted and create after you see the deletion happen\nhave you ever tried to set , I think this will do a non graceful deletion. should make sure the old resource is deleted before it creates a new resource, if not, that's a bug.\nThough the help says the is to be used only with , it returns the error above.\nThen I think there are two issues we need to track: 1. option should be ignored or just returns error if users are not using option. 2. should always make sure the old resource has been deleted before create the new resource.", "positive_passages": [{"docid": "doc-en-kubernetes-08fd3593414206bf9927f1077b4ff16d2bca233d5963e85ca60d73830883ca48", "text": "f, tf, codec, _ := NewAPIFactory() ns := dynamic.ContentConfig().NegotiatedSerializer tf.Printer = &testPrinter{} <ins> deleted := false </ins> tf.Client = &fake.RESTClient{ NegotiatedSerializer: ns, Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) { switch p, m := req.URL.Path, req.Method; { <del> case p == \"/namespaces/test/replicationcontrollers/redis-master\" && (m == http.MethodGet || m == http.MethodPut || m == http.MethodDelete): </del> <ins> case p == \"/namespaces/test/replicationcontrollers/redis-master\" && m == http.MethodDelete: deleted = true fallthrough case p == \"/namespaces/test/replicationcontrollers/redis-master\" && m == http.MethodPut: </ins> return &http.Response{StatusCode: http.StatusOK, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil <ins> case p == \"/namespaces/test/replicationcontrollers/redis-master\" && m == http.MethodGet: statusCode := http.StatusOK if deleted { statusCode = http.StatusNotFound } return &http.Response{StatusCode: statusCode, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil </ins> case p == \"/namespaces/test/replicationcontrollers\" && m == http.MethodPost: return &http.Response{StatusCode: http.StatusCreated, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil default:", "commid": "kubernetes_pr_31841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-137e73901e94fc53b23ce122acea4f6c63caaffb221f4c8fdcf70adeb68da5f7", "query": "When replacing an existing pod, the command fails as it tries to create a pod with a name that is still used by terminating pod. How does the option works? deletes a pod (e.g. mypod) creates a new pod with the same name (mypod) What happens? As the command tries to recreate the pod, it fails as the is in state. Thus it can not be created. The problem is the does not wait for a pod to be deleted. Reproducer: run mypod --image=yapei/hello-openshift --generator=run-pod/v1 get pod mypod -o yaml replace -f --force The last command ends with:\noption introduce by\nWith set to positive value, what should be the default behaviour of the command? When set to , should the command hang for and then create the pod? Or is there a way to create a callback (inside a scheduler?) that creates the pod once the current one is deleted?\nYou could watch for the resource to be deleted and create after you see the deletion happen\nhave you ever tried to set , I think this will do a non graceful deletion. should make sure the old resource is deleted before it creates a new resource, if not, that's a bug.\nThough the help says the is to be used only with , it returns the error above.\nThen I think there are two issues we need to track: 1. option should be ignored or just returns error if users are not using option. 2. should always make sure the old resource has been deleted before create the new resource.", "positive_passages": [{"docid": "doc-en-kubernetes-9ce6eebd0a6751e9f10424517d6511cd07cf2ee4f8d08dab07f363cf779479f4", "text": "f, tf, codec, _ := NewAPIFactory() ns := dynamic.ContentConfig().NegotiatedSerializer tf.Printer = &testPrinter{} <ins> redisMasterDeleted := false frontendDeleted := false </ins> tf.Client = &fake.RESTClient{ NegotiatedSerializer: ns, Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) { switch p, m := req.URL.Path, req.Method; { <del> case p == \"/namespaces/test/replicationcontrollers/redis-master\" && (m == http.MethodGet || m == http.MethodPut || m == http.MethodDelete): </del> <ins> case p == \"/namespaces/test/replicationcontrollers/redis-master\" && m == http.MethodDelete: redisMasterDeleted = true fallthrough case p == \"/namespaces/test/replicationcontrollers/redis-master\" && m == http.MethodPut: </ins> return &http.Response{StatusCode: http.StatusOK, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil <ins> case p == \"/namespaces/test/replicationcontrollers/redis-master\" && m == http.MethodGet: statusCode := http.StatusOK if redisMasterDeleted { statusCode = http.StatusNotFound } return &http.Response{StatusCode: statusCode, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil </ins> case p == \"/namespaces/test/replicationcontrollers\" && m == http.MethodPost: return &http.Response{StatusCode: http.StatusCreated, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil <del> case p == \"/namespaces/test/services/frontend\" && (m == http.MethodGet || m == http.MethodPut || m == http.MethodDelete): </del> <ins> case p == \"/namespaces/test/services/frontend\" && m == http.MethodDelete: frontendDeleted = true fallthrough case p == \"/namespaces/test/services/frontend\" && m == http.MethodPut: </ins> return &http.Response{StatusCode: http.StatusOK, Header: defaultHeader(), Body: objBody(codec, &svc.Items[0])}, nil <ins> case p == \"/namespaces/test/services/frontend\" && m == http.MethodGet: statusCode := http.StatusOK if frontendDeleted { statusCode = http.StatusNotFound } return &http.Response{StatusCode: statusCode, Header: defaultHeader(), Body: objBody(codec, &svc.Items[0])}, nil </ins> case p == \"/namespaces/test/services\" && m == http.MethodPost: return &http.Response{StatusCode: http.StatusCreated, Header: defaultHeader(), Body: objBody(codec, &svc.Items[0])}, nil default:", "commid": "kubernetes_pr_31841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-137e73901e94fc53b23ce122acea4f6c63caaffb221f4c8fdcf70adeb68da5f7", "query": "When replacing an existing pod, the command fails as it tries to create a pod with a name that is still used by terminating pod. How does the option works? deletes a pod (e.g. mypod) creates a new pod with the same name (mypod) What happens? As the command tries to recreate the pod, it fails as the is in state. Thus it can not be created. The problem is the does not wait for a pod to be deleted. Reproducer: run mypod --image=yapei/hello-openshift --generator=run-pod/v1 get pod mypod -o yaml replace -f --force The last command ends with:\noption introduce by\nWith set to positive value, what should be the default behaviour of the command? When set to , should the command hang for and then create the pod? Or is there a way to create a callback (inside a scheduler?) that creates the pod once the current one is deleted?\nYou could watch for the resource to be deleted and create after you see the deletion happen\nhave you ever tried to set , I think this will do a non graceful deletion. should make sure the old resource is deleted before it creates a new resource, if not, that's a bug.\nThough the help says the is to be used only with , it returns the error above.\nThen I think there are two issues we need to track: 1. option should be ignored or just returns error if users are not using option. 2. should always make sure the old resource has been deleted before create the new resource.", "positive_passages": [{"docid": "doc-en-kubernetes-fca4dad94514e5fc4023681bd6f559e7580d9a775d21b7fc0364bdcf0d05bb9b", "text": "f, tf, codec, _ := NewAPIFactory() ns := dynamic.ContentConfig().NegotiatedSerializer tf.Printer = &testPrinter{} <ins> created := map[string]bool{} </ins> tf.Client = &fake.RESTClient{ NegotiatedSerializer: ns, Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) { switch p, m := req.URL.Path, req.Method; { <del> case strings.HasPrefix(p, \"/namespaces/test/replicationcontrollers/\") && (m == http.MethodGet || m == http.MethodPut || m == http.MethodDelete): </del> <ins> case strings.HasPrefix(p, \"/namespaces/test/replicationcontrollers/\") && m == http.MethodPut: created[p] = true return &http.Response{StatusCode: http.StatusOK, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil case strings.HasPrefix(p, \"/namespaces/test/replicationcontrollers/\") && m == http.MethodGet: statusCode := http.StatusNotFound if created[p] { statusCode = http.StatusOK } return &http.Response{StatusCode: statusCode, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil case strings.HasPrefix(p, \"/namespaces/test/replicationcontrollers/\") && m == http.MethodDelete: delete(created, p) </ins> return &http.Response{StatusCode: http.StatusOK, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil case strings.HasPrefix(p, \"/namespaces/test/replicationcontrollers\") && m == http.MethodPost: return &http.Response{StatusCode: http.StatusCreated, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil", "commid": "kubernetes_pr_31841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-137e73901e94fc53b23ce122acea4f6c63caaffb221f4c8fdcf70adeb68da5f7", "query": "When replacing an existing pod, the command fails as it tries to create a pod with a name that is still used by terminating pod. How does the option works? deletes a pod (e.g. mypod) creates a new pod with the same name (mypod) What happens? As the command tries to recreate the pod, it fails as the is in state. Thus it can not be created. The problem is the does not wait for a pod to be deleted. Reproducer: run mypod --image=yapei/hello-openshift --generator=run-pod/v1 get pod mypod -o yaml replace -f --force The last command ends with:\noption introduce by\nWith set to positive value, what should be the default behaviour of the command? When set to , should the command hang for and then create the pod? Or is there a way to create a callback (inside a scheduler?) that creates the pod once the current one is deleted?\nYou could watch for the resource to be deleted and create after you see the deletion happen\nhave you ever tried to set , I think this will do a non graceful deletion. should make sure the old resource is deleted before it creates a new resource, if not, that's a bug.\nThough the help says the is to be used only with , it returns the error above.\nThen I think there are two issues we need to track: 1. option should be ignored or just returns error if users are not using option. 2. should always make sure the old resource has been deleted before create the new resource.", "positive_passages": [{"docid": "doc-en-kubernetes-7465e2e443409b35723bbed5e985b218c2aa9b654177a4817dce96b91d9781b9", "text": "NegotiatedSerializer: ns, Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) { switch p, m := req.URL.Path, req.Method; { <del> case p == \"/namespaces/test/replicationcontrollers/redis-master\" && m == http.MethodDelete: </del> <ins> case p == \"/namespaces/test/replicationcontrollers/redis-master\" && (m == http.MethodGet || m == http.MethodDelete): </ins> return &http.Response{StatusCode: http.StatusNotFound, Header: defaultHeader(), Body: stringBody(\"\")}, nil case p == \"/namespaces/test/replicationcontrollers\" && m == http.MethodPost: return &http.Response{StatusCode: http.StatusCreated, Header: defaultHeader(), Body: objBody(codec, &rc.Items[0])}, nil", "commid": "kubernetes_pr_31841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d760c5ea5685578ebb9830d3d5528d6365ffb387067e4c2605824d06bca490e", "query": "As mentioned in , the federation etcd will lose its state any time the pod dies, unless we modify to add a PVC. We'll also need to create a PV and modify the turnup script to create the backing volume in the cloud provider.\nFYI I believe this is a showstopper.\nOK. implied I could use to get this provisioned on-demand. AFAICT, , and since it makes our life easier I am trying to get this to work in my test cluster, but so far no joy. Any obvious mistake?\nI needed to not specify a .\nwhew! , Matt Liggett wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-87483e40644167a1658ef107f45d7914b2ad8c0af8314d640ad4742b4fb7c835", "text": "$host_kubectl create secret generic ${name} --from-file=\"${dir}/kubeconfig\" --namespace=\"${FEDERATION_NAMESPACE}\" done <del> $template \"${manifests_root}/federation-apiserver-\"{deployment,secrets}\".yaml\" | $host_kubectl create -f - $template \"${manifests_root}/federation-controller-manager-deployment.yaml\" | $host_kubectl create -f - </del> <ins> for file in federation-etcd-pvc.yaml federation-apiserver-{deployment,secrets}.yaml federation-controller-manager-deployment.yaml; do $template \"${manifests_root}/${file}\" | $host_kubectl create -f - done </ins> # Update the users kubeconfig to include federation-apiserver credentials. CONTEXT=federation-cluster ", "commid": "kubernetes_pr_28261"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d760c5ea5685578ebb9830d3d5528d6365ffb387067e4c2605824d06bca490e", "query": "As mentioned in , the federation etcd will lose its state any time the pod dies, unless we modify to add a PVC. We'll also need to create a PV and modify the turnup script to create the backing volume in the cloud provider.\nFYI I believe this is a showstopper.\nOK. implied I could use to get this provisioned on-demand. AFAICT, , and since it makes our life easier I am trying to get this to work in my test cluster, but so far no joy. Any obvious mistake?\nI needed to not specify a .\nwhew! , Matt Liggett wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-b82dd4044c6d2fe920fd4e2df0d5b7dd75d385481a6dc0a7f042aadfc815ab17", "text": "readOnly: true - name: etcd image: quay.io/coreos/etcd:v2.3.3 <ins> command: - /etcd - --data-dir - /var/etcd/data volumeMounts: - mountPath: /var/etcd name: varetcd </ins> volumes: - name: federation-apiserver-secrets secret: secretName: federation-apiserver-secrets <ins> - name: varetcd persistentVolumeClaim: claimName: {{.FEDERATION_APISERVER_DEPLOYMENT_NAME}}-etcd-claim </ins>", "commid": "kubernetes_pr_28261"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d760c5ea5685578ebb9830d3d5528d6365ffb387067e4c2605824d06bca490e", "query": "As mentioned in , the federation etcd will lose its state any time the pod dies, unless we modify to add a PVC. We'll also need to create a PV and modify the turnup script to create the backing volume in the cloud provider.\nFYI I believe this is a showstopper.\nOK. implied I could use to get this provisioned on-demand. AFAICT, , and since it makes our life easier I am trying to get this to work in my test cluster, but so far no joy. Any obvious mistake?\nI needed to not specify a .\nwhew! , Matt Liggett wrote:", "positive_passages": [{"docid": "doc-en-kubernetes-91dea5dc515e3fa361024740b93baf9c4f3ad1480272f6c7073bca63016f08f0", "text": "<ins> apiVersion: v1 kind: PersistentVolumeClaim metadata: name: {{.FEDERATION_APISERVER_DEPLOYMENT_NAME}}-etcd-claim annotations: volume.alpha.kubernetes.io/storage-class: \"yes\" namespace: {{.FEDERATION_NAMESPACE}} labels: app: federated-cluster spec: accessModes: - ReadWriteOnce resources: requests: storage: 10Gi </ins>", "commid": "kubernetes_pr_28261"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-54ee9a53c145bcb7f1ea4e17c59ef3f3aaba49d2a04dbd5ca8ea969af1a94c94", "query": "https://k8s- Failed: [] Container Runtime Conformance Test container runtime conformance blackbox test when running a container with a new image should not be able to pull from private registry without secret {E2eNode Suite}\nSame with , the fix is under review\nhttps://k8s- Failed: [] Container Runtime Conformance Test container runtime conformance blackbox test when running a container with a new image should not be able to pull from private registry without secret {E2eNode Suite}\nhttps://k8s- Failed: [] Container Runtime Conformance Test container runtime conformance blackbox test when running a container with a new image should not be able to pull from private registry without secret {E2eNode Suite}\nThe fix has been merged , close this one. Feel free to reopen if this happens again.", "positive_passages": [{"docid": "doc-en-kubernetes-e38dd6a6e96e736291bda9d7780e969a109cfe99d69c22cccfe74c96318796e7", "text": "Expect(container.Create()).To(Succeed()) defer container.Delete() <del> By(\"check the pod phase\") Eventually(container.GetPhase, retryTimeout, pollInterval).Should(Equal(testCase.phase)) Consistently(container.GetPhase, consistentCheckTimeout, pollInterval).Should(Equal(testCase.phase)) </del> <ins> // We need to check container state first. The default pod status is pending, If we check // pod phase first, and the expected pod phase is Pending, the container status may not // even show up when we check it. </ins> By(\"check the container state\") <del> status, err := container.GetStatus() Expect(err).NotTo(HaveOccurred()) Expect(GetContainerState(status.State)).To(Equal(testCase.state)) </del> <ins> getState := func() (ContainerState, error) { status, err := container.GetStatus() if err != nil { return ContainerStateUnknown, err } return GetContainerState(status.State), nil } Eventually(getState, retryTimeout, pollInterval).Should(Equal(testCase.state)) Consistently(getState, consistentCheckTimeout, pollInterval).Should(Equal(testCase.state)) By(\"check the pod phase\") Expect(container.GetPhase()).To(Equal(testCase.phase)) </ins> By(\"it should be possible to delete\") Expect(container.Delete()).To(Succeed())", "commid": "kubernetes_pr_28323"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3c64df687e12e254812ed26f14838f867cca01f1b7d5e271e2d52376c8409ae4", "query": "Either include non-arch specific stuff in every tar or break that out too. ref cc\ninterested in helping with this one?\nYes, I may help\nOK, I did not actually understand what was in , apparently. Alternate proposal: [ ] update all references that need just server binaries to download the server tarball directly [ ] same for places that just need (related to ) [ ] remove all arch-specific binary artifacts from and replace with a script which downloads the client/server tarballs as necessary. The alternative option, including all of the non-arch-specific code and docs in an arch-specific starts to get very tricky, since we run into a large cross product of client x server platforms/archs.", "positive_passages": [{"docid": "doc-en-kubernetes-675824e77431d37f2d4aaf04c6b142fd6ed6fa2751ac6658ff0ee368d3b24adc", "text": "kube::release::package_kube_manifests_tarball & kube::util::wait-for-jobs || { kube::log::error \"previous tarball phase failed\"; return 1; } <del> kube::release::package_full_tarball & # _full depends on all the previous phases </del> <ins> kube::release::package_final_tarball & # _final depends on some of the previous phases </ins> kube::release::package_test_tarball & # _test doesn't depend on anything kube::util::wait-for-jobs || { kube::log::error \"previous tarball phase failed\"; return 1; } }", "commid": "kubernetes_pr_35737"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3c64df687e12e254812ed26f14838f867cca01f1b7d5e271e2d52376c8409ae4", "query": "Either include non-arch specific stuff in every tar or break that out too. ref cc\ninterested in helping with this one?\nYes, I may help\nOK, I did not actually understand what was in , apparently. Alternate proposal: [ ] update all references that need just server binaries to download the server tarball directly [ ] same for places that just need (related to ) [ ] remove all arch-specific binary artifacts from and replace with a script which downloads the client/server tarballs as necessary. The alternative option, including all of the non-arch-specific code and docs in an arch-specific starts to get very tricky, since we run into a large cross product of client x server platforms/archs.", "positive_passages": [{"docid": "doc-en-kubernetes-1274bdfc7e0b08f1ac0effa73c36d9c3e4c0d18adc2061de0a80013af14e606a", "text": "kube::release::create_tarball \"${package_name}\" \"${release_stage}/..\" } <del> # This is all the stuff you need to run/install kubernetes.  This includes: #   - precompiled binaries for client </del> <ins> # This is all the platform-independent stuff you need to run/install kubernetes. # Arch-specific binaries will need to be downloaded separately (possibly by # using the bundled cluster/get-kube-binaries.sh script). # Included in this tarball: </ins> #   - Cluster spin up/down scripts and configs for various cloud providers <del> #   - tarballs for server binary and salt configs that are ready to be uploaded </del> <ins> #   - Tarballs for salt configs that are ready to be uploaded </ins> #     to master by whatever means appropriate. <del> function kube::release::package_full_tarball() { kube::log::status \"Building tarball: full\" </del> <ins> #   - Examples (which may or may not still work) #   - The remnants of the docs/ directory function kube::release::package_final_tarball() { kube::log::status \"Building tarball: final\" # This isn't a \"full\" tarball anymore, but the release lib still expects # artifacts under \"full/kubernetes/\" </ins> local release_stage=\"${RELEASE_STAGE}/full/kubernetes\" rm -rf \"${release_stage}\" mkdir -p \"${release_stage}\" <del> # Copy all of the client binaries in here, but not test or server binaries. # The server binaries are included with the server binary tarball. local platform for platform in \"${KUBE_CLIENT_PLATFORMS[@]}\"; do local client_bins=(\"${KUBE_CLIENT_BINARIES[@]}\") if [[ \"${platform%/*}\" == \"windows\" ]]; then client_bins=(\"${KUBE_CLIENT_BINARIES_WIN[@]}\") fi mkdir -p \"${release_stage}/platforms/${platform}\" cp \"${client_bins[@]/#/${LOCAL_OUTPUT_BINPATH}/${platform}/}\"  \"${release_stage}/platforms/${platform}\" done </del> <ins> mkdir -p \"${release_stage}/client\" cat <<EOF > \"${release_stage}/client/README\" Client binaries are no longer included in the Kubernetes final tarball. Run cluster/get-kube-binaries.sh to download client and server binaries. EOF </ins> # We want everything in /cluster except saltbase.  That is only needed on the # server.", "commid": "kubernetes_pr_35737"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3c64df687e12e254812ed26f14838f867cca01f1b7d5e271e2d52376c8409ae4", "query": "Either include non-arch specific stuff in every tar or break that out too. ref cc\ninterested in helping with this one?\nYes, I may help\nOK, I did not actually understand what was in , apparently. Alternate proposal: [ ] update all references that need just server binaries to download the server tarball directly [ ] same for places that just need (related to ) [ ] remove all arch-specific binary artifacts from and replace with a script which downloads the client/server tarballs as necessary. The alternative option, including all of the non-arch-specific code and docs in an arch-specific starts to get very tricky, since we run into a large cross product of client x server platforms/archs.", "positive_passages": [{"docid": "doc-en-kubernetes-3170fb7f02dc7755b373285863ac00ddaa47c08487393e642e3a3dca95eb7593", "text": "mkdir -p \"${release_stage}/server\" cp \"${RELEASE_DIR}/kubernetes-salt.tar.gz\" \"${release_stage}/server/\" <del> cp \"${RELEASE_DIR}\"/kubernetes-server-*.tar.gz \"${release_stage}/server/\" </del> cp \"${RELEASE_DIR}/kubernetes-manifests.tar.gz\" \"${release_stage}/server/\" <ins> cat <<EOF > \"${release_stage}/server/README\" Server binary tarballs are no longer included in the Kubernetes final tarball. Run cluster/get-kube-binaries.sh to download client and server binaries. EOF </ins> mkdir -p \"${release_stage}/third_party\" cp -R \"${KUBE_ROOT}/third_party/htpasswd\" \"${release_stage}/third_party/htpasswd\"", "commid": "kubernetes_pr_35737"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-749738408e786a27678c468a5520c46b775b406c0396b4fc77d0584fc060b72d", "query": "The code in doesn't work for me: does not pass on SIGTERM when the caller is in the same process group. Then the knocks out the process without giving it a chance to kill its child. The bit doesn't help: either the process has already been killed as above, or it gets killed now with SIGKILL; either way the process is still running. Oddly, it does work about one time in ten. I have no explanation for that. I am running from the command-line like this: , on 0-41-generic -Ubuntu SMP Fri Jun 24 11:28:43 UTC 2016 x8664 x8664 x86_64 GNU/Linux CC\nThe manual says \"This is the signal that the calling process will get when its parent dies.\"; it is applied to the process, so that will get killed if the process dies. That isn't what we are looking for:", "positive_passages": [{"docid": "doc-en-kubernetes-192782e70865eb918e6c7a61365c424de8a811f00bc804547686eb681701b61b", "text": "\"os/exec\" \"path\" \"path/filepath\" <del> \"reflect\" </del> \"strconv\" \"strings\" \"syscall\"", "commid": "kubernetes_pr_29380"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-749738408e786a27678c468a5520c46b775b406c0396b4fc77d0584fc060b72d", "query": "The code in doesn't work for me: does not pass on SIGTERM when the caller is in the same process group. Then the knocks out the process without giving it a chance to kill its child. The bit doesn't help: either the process has already been killed as above, or it gets killed now with SIGKILL; either way the process is still running. Oddly, it does work about one time in ten. I have no explanation for that. I am running from the command-line like this: , on 0-41-generic -Ubuntu SMP Fri Jun 24 11:28:43 UTC 2016 x8664 x8664 x86_64 GNU/Linux CC\nThe manual says \"This is the signal that the calling process will get when its parent dies.\"; it is applied to the process, so that will get killed if the process dies. That isn't what we are looking for:", "positive_passages": [{"docid": "doc-en-kubernetes-e29eb9f5b45e979e922a5ceacfcaae023c569a02eadb22832c4bb9888167d1c6", "text": "cmd.Cmd.Stdout = outfile cmd.Cmd.Stderr = outfile <del> // Killing the sudo command should kill the server as well. attrs := &syscall.SysProcAttr{} // Hack to set linux-only field without build tags. deathSigField := reflect.ValueOf(attrs).Elem().FieldByName(\"Pdeathsig\") if deathSigField.IsValid() { deathSigField.Set(reflect.ValueOf(syscall.SIGKILL)) } else { cmdErrorChan <- fmt.Errorf(\"Failed to set Pdeathsig field (non-linux build)\") return } cmd.Cmd.SysProcAttr = attrs </del> // Run the command err = cmd.Run() if err != nil {", "commid": "kubernetes_pr_29380"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-749738408e786a27678c468a5520c46b775b406c0396b4fc77d0584fc060b72d", "query": "The code in doesn't work for me: does not pass on SIGTERM when the caller is in the same process group. Then the knocks out the process without giving it a chance to kill its child. The bit doesn't help: either the process has already been killed as above, or it gets killed now with SIGKILL; either way the process is still running. Oddly, it does work about one time in ten. I have no explanation for that. I am running from the command-line like this: , on 0-41-generic -Ubuntu SMP Fri Jun 24 11:28:43 UTC 2016 x8664 x8664 x86_64 GNU/Linux CC\nThe manual says \"This is the signal that the calling process will get when its parent dies.\"; it is applied to the process, so that will get killed if the process dies. That isn't what we are looking for:", "positive_passages": [{"docid": "doc-en-kubernetes-df1a74591f1bae243d9b31a68c5d4dc241b531e54cf4b2a56410b3237791fe1c", "text": "const timeout = 10 * time.Second for _, signal := range []string{\"-TERM\", \"-KILL\"} { glog.V(2).Infof(\"Killing process %d (%s) with %s\", pid, name, signal) <del> _, err := exec.Command(\"sudo\", \"kill\", signal, strconv.Itoa(pid)).Output() </del> <ins> cmd := exec.Command(\"sudo\", \"kill\", signal, strconv.Itoa(pid)) // Run the 'kill' command in a separate process group so sudo doesn't ignore it cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true} _, err := cmd.Output() </ins> if err != nil { glog.Errorf(\"Error signaling process %d (%s) with %s: %v\", pid, name, signal, err) continue", "commid": "kubernetes_pr_29380"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-749738408e786a27678c468a5520c46b775b406c0396b4fc77d0584fc060b72d", "query": "The code in doesn't work for me: does not pass on SIGTERM when the caller is in the same process group. Then the knocks out the process without giving it a chance to kill its child. The bit doesn't help: either the process has already been killed as above, or it gets killed now with SIGKILL; either way the process is still running. Oddly, it does work about one time in ten. I have no explanation for that. I am running from the command-line like this: , on 0-41-generic -Ubuntu SMP Fri Jun 24 11:28:43 UTC 2016 x8664 x8664 x86_64 GNU/Linux CC\nThe manual says \"This is the signal that the calling process will get when its parent dies.\"; it is applied to the process, so that will get killed if the process dies. That isn't what we are looking for:", "positive_passages": [{"docid": "doc-en-kubernetes-2c34673f1128ad4c99654a24149be721ebdb0a8507b6771ad2341f1f5725ff8a", "text": "cmd.Cmd.Stdout = outfile cmd.Cmd.Stderr = outfile <del> // Killing the sudo command should kill the server as well. </del> <ins> // Death of this test process should kill the server as well. </ins> attrs := &syscall.SysProcAttr{} // Hack to set linux-only field without build tags. deathSigField := reflect.ValueOf(attrs).Elem().FieldByName(\"Pdeathsig\") if deathSigField.IsValid() { <del> deathSigField.Set(reflect.ValueOf(syscall.SIGKILL)) </del> <ins> deathSigField.Set(reflect.ValueOf(syscall.SIGTERM)) </ins> } else { cmdErrorChan <- fmt.Errorf(\"Failed to set Pdeathsig field (non-linux build)\") return", "commid": "kubernetes_pr_29685"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-749738408e786a27678c468a5520c46b775b406c0396b4fc77d0584fc060b72d", "query": "The code in doesn't work for me: does not pass on SIGTERM when the caller is in the same process group. Then the knocks out the process without giving it a chance to kill its child. The bit doesn't help: either the process has already been killed as above, or it gets killed now with SIGKILL; either way the process is still running. Oddly, it does work about one time in ten. I have no explanation for that. I am running from the command-line like this: , on 0-41-generic -Ubuntu SMP Fri Jun 24 11:28:43 UTC 2016 x8664 x8664 x86_64 GNU/Linux CC\nThe manual says \"This is the signal that the calling process will get when its parent dies.\"; it is applied to the process, so that will get killed if the process dies. That isn't what we are looking for:", "positive_passages": [{"docid": "doc-en-kubernetes-d48bc27e64c54a9f5e850899b2021dc0e74990571c18f5b2a72e072eb3b5c29d", "text": "const timeout = 10 * time.Second for _, signal := range []string{\"-TERM\", \"-KILL\"} { glog.V(2).Infof(\"Killing process %d (%s) with %s\", pid, name, signal) <del> _, err := exec.Command(\"sudo\", \"kill\", signal, strconv.Itoa(pid)).Output() </del> <ins> cmd := exec.Command(\"sudo\", \"kill\", signal, strconv.Itoa(pid)) // Run the 'kill' command in a separate process group so sudo doesn't ignore it attrs := &syscall.SysProcAttr{} // Hack to set unix-only field without build tags. setpgidField := reflect.ValueOf(attrs).Elem().FieldByName(\"Setpgid\") if setpgidField.IsValid() { setpgidField.Set(reflect.ValueOf(true)) } else { return fmt.Errorf(\"Failed to set Setpgid field (non-unix build)\") } cmd.SysProcAttr = attrs _, err := cmd.Output() </ins> if err != nil { glog.Errorf(\"Error signaling process %d (%s) with %s: %v\", pid, name, signal, err) continue", "commid": "kubernetes_pr_29685"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-df06935dc12cccd535d95a7add46acf8ed7f7b060e66bb7b117b3eccd06850f8", "query": "https://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention...\nThis has been marked with the \"needs attention\" label and needs to be addressed for the 1.4 release. Could you please close if it's fixed update on your progress to fix it make a case for it not to block the release or find a new owner who can do one of the above soon. Once you or the new owner update this issue and are actively working on it, you can remove the \"needs attention\" label.\nthe following message looks suspicious, looks a DNS issue?\nActually more like a network connectivity issue\ndo you happen to have the Dockerfile for these images? We better push them into\nI don't think this is a blocking issue. It looks a transient issue. Since the example is largely dependent on whether the image can be fetched and how long it takes to pull the image, it is very environment sensitive. I would recommend removing label. Longer term, we should move the images used in examples to gcr.\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nfor the last flake, based on , image pull (mattf/zookeeper:latest) started at 42:40, finished at 48:31, about 5min51sec, well passed 5 min\nstorm-nimbus, storm-worker and zookeeper are from they're all automated builds from github (quick link: and )\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}", "positive_passages": [{"docid": "doc-en-kubernetes-391fb937369b2ba03bdf1df5a52593de1b3863c8eb27d79ca1528d7547f084a1", "text": "workerControllerJson := mkpath(\"storm-worker-controller.json\") nsFlag := fmt.Sprintf(\"--namespace=%v\", ns) zookeeperPod := \"zookeeper\" <ins> nimbusPod := \"nimbus\" </ins> By(\"starting Zookeeper\") framework.RunKubectlOrDie(\"create\", \"-f\", zookeeperPodJson, nsFlag) framework.RunKubectlOrDie(\"create\", \"-f\", zookeeperServiceJson, nsFlag) <del> err := framework.WaitForPodNameRunningInNamespace(c, zookeeperPod, ns) </del> <ins> err := f.WaitForPodRunningSlow(zookeeperPod) </ins> Expect(err).NotTo(HaveOccurred()) By(\"checking if zookeeper is up and running\")", "commid": "kubernetes_pr_32135"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-df06935dc12cccd535d95a7add46acf8ed7f7b060e66bb7b117b3eccd06850f8", "query": "https://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention...\nThis has been marked with the \"needs attention\" label and needs to be addressed for the 1.4 release. Could you please close if it's fixed update on your progress to fix it make a case for it not to block the release or find a new owner who can do one of the above soon. Once you or the new owner update this issue and are actively working on it, you can remove the \"needs attention\" label.\nthe following message looks suspicious, looks a DNS issue?\nActually more like a network connectivity issue\ndo you happen to have the Dockerfile for these images? We better push them into\nI don't think this is a blocking issue. It looks a transient issue. Since the example is largely dependent on whether the image can be fetched and how long it takes to pull the image, it is very environment sensitive. I would recommend removing label. Longer term, we should move the images used in examples to gcr.\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nfor the last flake, based on , image pull (mattf/zookeeper:latest) started at 42:40, finished at 48:31, about 5min51sec, well passed 5 min\nstorm-nimbus, storm-worker and zookeeper are from they're all automated builds from github (quick link: and )\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] [Feature:Example] [] Storm should create and stop Zookeeper, Nimbus and Storm worker servers {Kubernetes e2e suite}", "positive_passages": [{"docid": "doc-en-kubernetes-870f2abc301ab35fecb026005d1e81e3dd7e93b5f8320215cb2b83d0f9d351c1", "text": "By(\"starting Nimbus\") framework.RunKubectlOrDie(\"create\", \"-f\", nimbusPodJson, nsFlag) framework.RunKubectlOrDie(\"create\", \"-f\", nimbusServiceJson, nsFlag) <del> err = framework.WaitForPodNameRunningInNamespace(c, \"nimbus\", ns) </del> <ins> err = f.WaitForPodRunningSlow(nimbusPod) </ins> Expect(err).NotTo(HaveOccurred()) err = framework.WaitForEndpoint(c, ns, \"nimbus\")", "commid": "kubernetes_pr_32135"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bfcd8c1616e8828754fd2982c8dfa9b62a9f64f48b1a3ca5310d1a2eb1f5c300", "query": "I think got confused between e.g. KUBEMASTEROSDISTRIBUTION and MASTEROS_DISTRIBUTION; it definitely doesn't match GCE. PR coming in once I've tested.\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-7feae0898f875f506bbb7d894001c3c90dbca14aa42b5df29ea0ba1452f9e2d3", "text": "# OS options for minions KUBE_OS_DISTRIBUTION=\"${KUBE_OS_DISTRIBUTION:-jessie}\" <del> KUBE_MASTER_OS_DISTRIBUTION=\"${KUBE_OS_DISTRIBUTION}\" KUBE_NODE_OS_DISTRIBUTION=\"${KUBE_OS_DISTRIBUTION}\" </del> <ins> MASTER_OS_DISTRIBUTION=\"${KUBE_OS_DISTRIBUTION}\" NODE_OS_DISTRIBUTION=\"${KUBE_OS_DISTRIBUTION}\" </ins> KUBE_NODE_IMAGE=\"${KUBE_NODE_IMAGE:-}\" COREOS_CHANNEL=\"${COREOS_CHANNEL:-alpha}\" CONTAINER_RUNTIME=\"${KUBE_CONTAINER_RUNTIME:-docker}\"", "commid": "kubernetes_pr_29427"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a540a96ec019e4374a1aed3eeb2f1a3870891c79dbab54fc2c3626988ef08e83", "query": "Description of problem Create a petset, when pod is evicted, the petset can't create a new pod on other node and make sure pod is running. Kubernetes version (use ): v1.4.0-alpha.2.1427+ How to reproduce it (as minimally and precisely as possible): kubele eviction-hard=\"memory.available<${value}\" a peset and wait all pod is running node MemoryPressure=true all pod status What happened: is evicted and petset can't create new pod and make sure pod is running. What you expected to happen: create new pod on other node and make sure pod is running.\nAlso when node come back with sufficient memory, petset can't make pod running again.\nFYI\ncc\nWas able to reproduce it. Pet set controller just loops with the following logs I0830 12:32:52. 9 ] Syncing PetSet default/cockroachdb with 3 pets I0830 12:32:52. 9 ] PetSet cockroachdb blocked from scaling on pet cockroachdb-0 I0830 12:32:52. 9 ] PetSet cockroachdb waiting on unhealthy pet cockroachdb-0 I0830 12:32:52. 9 ] PetSet cockroachdb waiting on unhealthy pet cockroachdb-1 I0830 12:32:52. 9 ] PetSet cockroachdb waiting on unhealthy pet cockroachdb-2\n-- do you have the petset YAML that we can evaluate? What is the quality of service tier for the pods produced by the petset? Can you include the of an evicted petset pod so we can see the final resource requirements spec?\nI am able to reproduce it with nginx pet set in e2e test. Here is yaml output of it Also it seems that i have working fix and almost finished debugging e2e test (patchset is linked above). Will be grateful for review.\nAh, this helps clear things up... the linked pr shows the problem in petset controller and not kubelet...\nDoes it make sense to set milestone 1.4 for this issue? I think the fix is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-50a4e1d31fc54a627222a6d12c44ae5160b4d1683babc7bc04e43fb6be5aa895", "text": "if err := p.SyncPVCs(pet); err != nil { return err } <del> if exists { </del> <ins> // if pet failed - we need to remove old one because of consistent naming if exists && realPet.pod.Status.Phase == api.PodFailed { glog.V(4).Infof(\"Delete evicted pod %v\", realPet.pod.Name) if err := p.petClient.Delete(realPet); err != nil { return err } } else if exists { </ins> if !p.isHealthy(realPet.pod) { glog.Infof(\"PetSet %v waiting on unhealthy pet %v\", pet.parent.Name, realPet.pod.Name) }", "commid": "kubernetes_pr_31777"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a540a96ec019e4374a1aed3eeb2f1a3870891c79dbab54fc2c3626988ef08e83", "query": "Description of problem Create a petset, when pod is evicted, the petset can't create a new pod on other node and make sure pod is running. Kubernetes version (use ): v1.4.0-alpha.2.1427+ How to reproduce it (as minimally and precisely as possible): kubele eviction-hard=\"memory.available<${value}\" a peset and wait all pod is running node MemoryPressure=true all pod status What happened: is evicted and petset can't create new pod and make sure pod is running. What you expected to happen: create new pod on other node and make sure pod is running.\nAlso when node come back with sufficient memory, petset can't make pod running again.\nFYI\ncc\nWas able to reproduce it. Pet set controller just loops with the following logs I0830 12:32:52. 9 ] Syncing PetSet default/cockroachdb with 3 pets I0830 12:32:52. 9 ] PetSet cockroachdb blocked from scaling on pet cockroachdb-0 I0830 12:32:52. 9 ] PetSet cockroachdb waiting on unhealthy pet cockroachdb-0 I0830 12:32:52. 9 ] PetSet cockroachdb waiting on unhealthy pet cockroachdb-1 I0830 12:32:52. 9 ] PetSet cockroachdb waiting on unhealthy pet cockroachdb-2\n-- do you have the petset YAML that we can evaluate? What is the quality of service tier for the pods produced by the petset? Can you include the of an evicted petset pod so we can see the final resource requirements spec?\nI am able to reproduce it with nginx pet set in e2e test. Here is yaml output of it Also it seems that i have working fix and almost finished debugging e2e test (patchset is linked above). Will be grateful for review.\nAh, this helps clear things up... the linked pr shows the problem in petset controller and not kubelet...\nDoes it make sense to set milestone 1.4 for this issue? I think the fix is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-41c7831f97f42c1048ac0edcaac53f5d4ca7dec7dba6b8fc7630067fc506bd02", "text": "\"k8s.io/kubernetes/pkg/controller/petset\" \"k8s.io/kubernetes/pkg/labels\" \"k8s.io/kubernetes/pkg/runtime\" <ins> \"k8s.io/kubernetes/pkg/types\" </ins> \"k8s.io/kubernetes/pkg/util/sets\" \"k8s.io/kubernetes/pkg/util/wait\" utilyaml \"k8s.io/kubernetes/pkg/util/yaml\" <ins> \"k8s.io/kubernetes/pkg/watch\" </ins> \"k8s.io/kubernetes/test/e2e/framework\" ) const ( petsetPoll = 10 * time.Second // Some pets install base packages via wget <del> petsetTimeout           = 10 * time.Minute </del> <ins> petsetTimeout = 10 * time.Minute // Timeout for pet pods to change state petPodTimeout           = 5 * time.Minute </ins> zookeeperManifestPath   = \"test/e2e/testing-manifests/petset/zookeeper\" mysqlGaleraManifestPath = \"test/e2e/testing-manifests/petset/mysql-galera\" redisManifestPath       = \"test/e2e/testing-manifests/petset/redis\"", "commid": "kubernetes_pr_31777"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a540a96ec019e4374a1aed3eeb2f1a3870891c79dbab54fc2c3626988ef08e83", "query": "Description of problem Create a petset, when pod is evicted, the petset can't create a new pod on other node and make sure pod is running. Kubernetes version (use ): v1.4.0-alpha.2.1427+ How to reproduce it (as minimally and precisely as possible): kubele eviction-hard=\"memory.available<${value}\" a peset and wait all pod is running node MemoryPressure=true all pod status What happened: is evicted and petset can't create new pod and make sure pod is running. What you expected to happen: create new pod on other node and make sure pod is running.\nAlso when node come back with sufficient memory, petset can't make pod running again.\nFYI\ncc\nWas able to reproduce it. Pet set controller just loops with the following logs I0830 12:32:52. 9 ] Syncing PetSet default/cockroachdb with 3 pets I0830 12:32:52. 9 ] PetSet cockroachdb blocked from scaling on pet cockroachdb-0 I0830 12:32:52. 9 ] PetSet cockroachdb waiting on unhealthy pet cockroachdb-0 I0830 12:32:52. 9 ] PetSet cockroachdb waiting on unhealthy pet cockroachdb-1 I0830 12:32:52. 9 ] PetSet cockroachdb waiting on unhealthy pet cockroachdb-2\n-- do you have the petset YAML that we can evaluate? What is the quality of service tier for the pods produced by the petset? Can you include the of an evicted petset pod so we can see the final resource requirements spec?\nI am able to reproduce it with nginx pet set in e2e test. Here is yaml output of it Also it seems that i have working fix and almost finished debugging e2e test (patchset is linked above). Will be grateful for review.\nAh, this helps clear things up... the linked pr shows the problem in petset controller and not kubelet...\nDoes it make sense to set milestone 1.4 for this issue? I think the fix is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-7e03950edfab3b0154b44aac0b275c03d68ad4cb0bab416f009856c0fb20bac6", "text": "}) }) <ins> var _ = framework.KubeDescribe(\"Pet set recreate [Slow] [Feature:PetSet]\", func() { f := framework.NewDefaultFramework(\"pet-set-recreate\") var c *client.Client var ns string labels := map[string]string{ \"foo\": \"bar\", \"baz\": \"blah\", } headlessSvcName := \"test\" podName := \"test-pod\" petSetName := \"web\" petPodName := \"web-0\" BeforeEach(func() { framework.SkipUnlessProviderIs(\"gce\", \"vagrant\") By(\"creating service \" + headlessSvcName + \" in namespace \" + f.Namespace.Name) headlessService := createServiceSpec(headlessSvcName, \"\", true, labels) _, err := f.Client.Services(f.Namespace.Name).Create(headlessService) framework.ExpectNoError(err) c = f.Client ns = f.Namespace.Name }) AfterEach(func() { if CurrentGinkgoTestDescription().Failed { dumpDebugInfo(c, ns) } By(\"Deleting all petset in ns \" + ns) deleteAllPetSets(c, ns) }) It(\"should recreate evicted petset\", func() { By(\"looking for a node to schedule pet set and pod\") nodes := framework.GetReadySchedulableNodesOrDie(f.Client) node := nodes.Items[0] By(\"creating pod with conflicting port in namespace \" + f.Namespace.Name) conflictingPort := api.ContainerPort{HostPort: 21017, ContainerPort: 21017, Name: \"conflict\"} pod := &api.Pod{ ObjectMeta: api.ObjectMeta{ Name: podName, }, Spec: api.PodSpec{ Containers: []api.Container{ { Name:  \"nginx\", Image: \"gcr.io/google_containers/nginx-slim:0.7\", Ports: []api.ContainerPort{conflictingPort}, }, }, NodeName: node.Name, }, } pod, err := f.Client.Pods(f.Namespace.Name).Create(pod) framework.ExpectNoError(err) By(\"creating petset with conflicting port in namespace \" + f.Namespace.Name) ps := newPetSet(petSetName, f.Namespace.Name, headlessSvcName, 1, nil, nil, labels) petContainer := &ps.Spec.Template.Spec.Containers[0] petContainer.Ports = append(petContainer.Ports, conflictingPort) ps.Spec.Template.Spec.NodeName = node.Name _, err = f.Client.Apps().PetSets(f.Namespace.Name).Create(ps) framework.ExpectNoError(err) By(\"waiting until pod \" + podName + \" will start running in namespace \" + f.Namespace.Name) if err := f.WaitForPodRunning(podName); err != nil { framework.Failf(\"Pod %v did not start running: %v\", podName, err) } var initialPetPodUID types.UID By(\"waiting until pet pod \" + petPodName + \" will be recreated and deleted at least once in namespace \" + f.Namespace.Name) w, err := f.Client.Pods(f.Namespace.Name).Watch(api.SingleObject(api.ObjectMeta{Name: petPodName})) framework.ExpectNoError(err) // we need to get UID from pod in any state and wait until pet set controller will remove pod atleast once _, err = watch.Until(petPodTimeout, w, func(event watch.Event) (bool, error) { pod := event.Object.(*api.Pod) switch event.Type { case watch.Deleted: framework.Logf(\"Observed delete event for pet pod %v in namespace %v\", pod.Name, pod.Namespace) if initialPetPodUID == \"\" { return false, nil } return true, nil } framework.Logf(\"Observed pet pod in namespace: %v, name: %v, uid: %v, status phase: %v. Waiting for petset controller to delete.\", pod.Namespace, pod.Name, pod.UID, pod.Status.Phase) initialPetPodUID = pod.UID return false, nil }) if err != nil { framework.Failf(\"Pod %v expected to be re-created atleast once\", petPodName) } By(\"removing pod with conflicting port in namespace \" + f.Namespace.Name) err = f.Client.Pods(f.Namespace.Name).Delete(pod.Name, api.NewDeleteOptions(0)) framework.ExpectNoError(err) By(\"waiting when pet pod \" + petPodName + \" will be recreated in namespace \" + f.Namespace.Name + \" and will be in running state\") // we may catch delete event, thats why we are waiting for running phase like this, and not with watch.Until Eventually(func() error { petPod, err := f.Client.Pods(f.Namespace.Name).Get(petPodName) if err != nil { return err } if petPod.Status.Phase != api.PodRunning { return fmt.Errorf(\"Pod %v is not in running phase: %v\", petPod.Name, petPod.Status.Phase) } else if petPod.UID == initialPetPodUID { return fmt.Errorf(\"Pod %v wasn't recreated: %v == %v\", petPod.Name, petPod.UID, initialPetPodUID) } return nil }, petPodTimeout, 2*time.Second).Should(BeNil()) }) }) </ins> func dumpDebugInfo(c *client.Client, ns string) { pl, _ := c.Pods(ns).List(api.ListOptions{LabelSelector: labels.Everything()}) for _, p := range pl.Items {", "commid": "kubernetes_pr_31777"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5ed5c1e20e14fe5a611a17f918cbdb7750120c4d2b83d5cbf5c92766c9f4890f", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nI'm pretty sure, those amount of failure are related to: (I don't know why yet).\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}", "positive_passages": [{"docid": "doc-en-kubernetes-372696e4ae48d7218ba6a463315c3689a491efa5d974d204606a29e2317863e9", "text": "return err } if waitForReplicas != nil { <del> watchOptions := api.ListOptions{FieldSelector: fields.OneTermEqualSelector(\"metadata.name\", name), ResourceVersion: updatedResourceVersion} watcher, err := scaler.c.ReplicationControllers(namespace).Watch(watchOptions) </del> <ins> checkRC := func(rc *api.ReplicationController) bool { if uint(rc.Spec.Replicas) != newSize { // the size is changed by other party. Don't need to wait for the new change to complete. return true } return rc.Status.ObservedGeneration >= rc.Generation && rc.Status.Replicas == rc.Spec.Replicas } // If number of replicas doesn't change, then the update may not event // be sent to underlying databse (we don't send no-op changes). // In such case, <updatedResourceVersion> will have value of the most // recent update (which may be far in the past) so we may get \"too old // RV\" error from watch or potentially no ReplicationController events // will be deliver, since it may already be in the expected state. // To protect from these two, we first issue Get() to ensure that we // are not already in the expected state. currentRC, err := scaler.c.ReplicationControllers(namespace).Get(name) </ins> if err != nil { return err } <del> _, err = watch.Until(waitForReplicas.Timeout, watcher, func(event watch.Event) (bool, error) { if event.Type != watch.Added && event.Type != watch.Modified { return false, nil </del> <ins> if !checkRC(currentRC) { watchOptions := api.ListOptions{ FieldSelector:   fields.OneTermEqualSelector(\"metadata.name\", name), ResourceVersion: updatedResourceVersion, </ins> } <del> rc := event.Object.(*api.ReplicationController) if uint(rc.Spec.Replicas) != newSize { // the size is changed by other party. Don't need to wait for the new change to complete. return true, nil </del> <ins> watcher, err := scaler.c.ReplicationControllers(namespace).Watch(watchOptions) if err != nil { return err </ins> } <del> return rc.Status.ObservedGeneration >= rc.Generation && rc.Status.Replicas == rc.Spec.Replicas, nil }) if err == wait.ErrWaitTimeout { return fmt.Errorf(\"timed out waiting for %q to be synced\", name) </del> <ins> _, err = watch.Until(waitForReplicas.Timeout, watcher, func(event watch.Event) (bool, error) { if event.Type != watch.Added && event.Type != watch.Modified { return false, nil } return checkRC(event.Object.(*api.ReplicationController)), nil }) if err == wait.ErrWaitTimeout { return fmt.Errorf(\"timed out waiting for %q to be synced\", name) } return err </ins> } <del> return err </del> } return nil }", "commid": "kubernetes_pr_31421"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5ed5c1e20e14fe5a611a17f918cbdb7750120c4d2b83d5cbf5c92766c9f4890f", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nI'm pretty sure, those amount of failure are related to: (I don't know why yet).\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}", "positive_passages": [{"docid": "doc-en-kubernetes-057311196765cb0e7f92e30190d09f1e0654a8d0171a68f24d80a16bb92963fb", "text": "}, }, StopError:       nil, <del> ExpectedActions: []string{\"get\", \"list\", \"get\", \"update\", \"watch\", \"delete\"}, </del> <ins> ExpectedActions: []string{\"get\", \"list\", \"get\", \"update\", \"get\", \"delete\"}, </ins> }, { Name: \"NoOverlapping\",", "commid": "kubernetes_pr_31421"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5ed5c1e20e14fe5a611a17f918cbdb7750120c4d2b83d5cbf5c92766c9f4890f", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nI'm pretty sure, those amount of failure are related to: (I don't know why yet).\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}", "positive_passages": [{"docid": "doc-en-kubernetes-a6858dc85a4620c11bc5ae5f281d6f3be7f0f950858388f6b0ac32cd30ad20a0", "text": "}, }, StopError:       nil, <del> ExpectedActions: []string{\"get\", \"list\", \"get\", \"update\", \"watch\", \"delete\"}, </del> <ins> ExpectedActions: []string{\"get\", \"list\", \"get\", \"update\", \"get\", \"delete\"}, </ins> }, { Name: \"OverlappingError\",", "commid": "kubernetes_pr_31421"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ccf323f57343c53a81e615f5f91e91830995a9424300c72d74f0847dc125d753", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? Currently, the 4th parameter name of updateServiceListener in kube-proxy is addOrDelete, However, from the func caller, we just pass for AddServiceListener, and for DeleteServiceListener, So, I think the name addOrDelete is unreasonable. I prefer to change the parameter name addOrDelete to add so that avoid making people confused. In addition, there is a typo, We should change addition to deletion! Also, there is a sentence breaking, we should change from No Service Endpoints Not Found =No Service Endpoints are found Thanks!\nFixed!", "positive_passages": [{"docid": "doc-en-kubernetes-1078fcfa6f04862105f5d4b723fa0a4691f40d1f604ef88f619c7cde3ff9573a", "text": "healthchecker.mutationRequestChannel <- req } <del> func updateServiceListener(serviceName types.NamespacedName, listenPort int, addOrDelete bool) bool { </del> <ins> func updateServiceListener(serviceName types.NamespacedName, listenPort int, add bool) bool { </ins> responseChannel := make(chan bool) req := &proxyListenerRequest{ serviceName:     serviceName, listenPort:      uint16(listenPort), <del> add:             addOrDelete, </del> <ins> add:             add, </ins> responseChannel: responseChannel, } healthchecker.listenerRequestChannel <- req", "commid": "kubernetes_pr_31485"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ccf323f57343c53a81e615f5f91e91830995a9424300c72d74f0847dc125d753", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? Currently, the 4th parameter name of updateServiceListener in kube-proxy is addOrDelete, However, from the func caller, we just pass for AddServiceListener, and for DeleteServiceListener, So, I think the name addOrDelete is unreasonable. I prefer to change the parameter name addOrDelete to add so that avoid making people confused. In addition, there is a typo, We should change addition to deletion! Also, there is a sentence breaking, we should change from No Service Endpoints Not Found =No Service Endpoints are found Thanks!\nFixed!", "positive_passages": [{"docid": "doc-en-kubernetes-bb51bc9254123b7761a574e47491d69dfea23818243c44d8c206f4ea80342050", "text": "return updateServiceListener(serviceName, listenPort, true) } <del> // DeleteServiceListener Request addition of a listener for a service's health check </del> <ins> // DeleteServiceListener Request deletion of a listener for a service's health check </ins> func DeleteServiceListener(serviceName types.NamespacedName, listenPort int) bool { return updateServiceListener(serviceName, listenPort, false) }", "commid": "kubernetes_pr_31485"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ccf323f57343c53a81e615f5f91e91830995a9424300c72d74f0847dc125d753", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? Currently, the 4th parameter name of updateServiceListener in kube-proxy is addOrDelete, However, from the func caller, we just pass for AddServiceListener, and for DeleteServiceListener, So, I think the name addOrDelete is unreasonable. I prefer to change the parameter name addOrDelete to add so that avoid making people confused. In addition, there is a typo, We should change addition to deletion! Also, there is a sentence breaking, we should change from No Service Endpoints Not Found =No Service Endpoints are found Thanks!\nFixed!", "positive_passages": [{"docid": "doc-en-kubernetes-31df6b808d4b9905f46e876ffbf52f475d37394499a6c75b7167b29566548cd5", "text": "s, ok := h.serviceEndpointsMap.Get(serviceName) if !ok { glog.V(4).Infof(\"Service %s not found or has no local endpoints\", serviceName) <del> sendHealthCheckResponse(rw, http.StatusServiceUnavailable, \"No Service Endpoints Not Found\") </del> <ins> sendHealthCheckResponse(rw, http.StatusServiceUnavailable, \"No Service Endpoints Found\") </ins> return } numEndpoints := len(*s.(*serviceEndpointsList).endpoints)", "commid": "kubernetes_pr_31485"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e5a484b35fec960cddb956eba6f052845dad1c368a586555990c6f6b0a2bb05", "query": "In practice this means that it doesn't get to update and thereby may refuse to admit pods which had been assigned to it by the scheduler. For example, if you update labels for that given node, and try to use affinity or on a pod, it won't get to run.\nThis looks like a sufficient fix for me, but I'm happy to add instead, if that'd help getting it accepted for 1.4.0: cc\ncc\nThat commit makes sense to me.\nThanks, I'll open a PR.", "positive_passages": [{"docid": "doc-en-kubernetes-2bc4a8495519bd2f663285c4c76327ddf902f29dc9fccc139a4ab84a1e64e466", "text": "func run(s *options.KubeletServer, kubeDeps *kubelet.KubeletDeps) (err error) { // TODO: this should be replaced by a --standalone flag <del> standaloneMode := (len(s.APIServerList) == 0) </del> <ins> standaloneMode := (len(s.APIServerList) == 0 && !s.RequireKubeConfig) </ins> if s.ExitOnLockContention && s.LockFilePath == \"\" { return errors.New(\"cannot exit on lock file contention: no lock file specified\")", "commid": "kubernetes_pr_32102"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-235c4fd5c746c299713da1f29ab9aad59c79650aa9c03654d13b0d18ce6db4b5", "query": "While following this to setup a kube-mesos integration env on my laptop, I found the default service account and default token are not created when start the cluster. As a result, I can not create a pod or deployment in this environment. Reproduce steps: the latest Mesos code, build and start 1 single master with 1 single agent. the latest Kubernetes code, use to build. the following commands to start apiserver, controller-manager and scheduler respectively: all the components are started, run command and see that there is no default token created for the default namespace. At this moment, run \"kubectl create -f \" will see the failure of creating a pod.\nThis introduced to node controller and now when we start a node controller, if is not nil, we will start this Informer controller as well. But the start of the will block main thread from starting other controllers later in the main thread. we can see that in the kube-mesos integration, we started some other controllers, including serviceaccount controller, after we started node controller. I will submit a patch later to run the in a go routine to solve the issue.", "positive_passages": [{"docid": "doc-en-kubernetes-01ef60197d8e84b4347b7181ab26fe925d485cbb60047f66e3e057eda471c6aa", "text": "go nc.podController.Run(wait.NeverStop) go nc.daemonSetController.Run(wait.NeverStop) if nc.internalPodInformer != nil { <del> nc.internalPodInformer.Run(wait.NeverStop) </del> <ins> go nc.internalPodInformer.Run(wait.NeverStop) </ins> } // Incorporate the results of node status pushed from kubelet to master.", "commid": "kubernetes_pr_32107"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a045972f2041bf03a456c81741b4b6a2d857d31a19a08ce9353cd2fe9dd6937b", "query": "https://k8s- Failed: ThirdParty resources Simple Third Party creating/deleting thirdparty objects works [Conformance] {Kubernetes e2e suite}\ncc\nSeems like the namespace creation/deletion process is flaky. IIRC there have been some recent PRs touching this area, is that right?\nWe recently code to try to expose the real underlying error for why the ns deletion fails. This is hopefully now showing it.\nThe issue is with TPR not integrated properly with the namespace controller. Creation of a new type requires a restart of the controller-manager given current state of the code. The test must be marked flaky until the state of the art is improved (which is not happening in 1.4).", "positive_passages": [{"docid": "doc-en-kubernetes-42850ff9756da0c17fa67f011430d3ea785fbe082db3bbd7494ce8f81af3da06", "text": "Items []Foo `json:\"items\"` } <del> var _ = Describe(\"ThirdParty resources\", func() { </del> <ins> // This test is marked flaky pending namespace controller observing dynamic creation of new third party types. var _ = Describe(\"ThirdParty resources [Flaky] [Disruptive]\", func() { </ins> f := framework.NewDefaultFramework(\"thirdparty\")", "commid": "kubernetes_pr_32302"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee7dcc3235d36c5ced023c560a1d39a0e56a3b4e7f45b338561a6cfa9a84c80", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nThis is pretty much the same failure, that are happening in \"gce-enormous\" suite and we currently debugging them with The main reason of those failures is that we are terminating all watchers for a particular resource type from time to time, and some of them are actually causing a snowball effect. After more looking into it, my hypothesis is that our machinery for aggregating watchers in apiserver sometimes is just to slow. In particular, I some log in my local branch and what I'm observing is that in etcd_watcher, we are: accumulating objects in incoming channel but also accumulating objects in outgoing channel, and the accumulation there is usually higher [I will send a PR to put those logs into master - they seem to be pretty useful for debugging such issues.] So my current hypothesis is that dispatching watch events to watchers is what is too slow. We will continue debugging.\nThe logs that I seem to confirm my hypothesis - outgoing channel is generally more full then the incoming channel in etcd_watcher: vs I'm working on the PR that should at least improve the situation.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nPlease apply the label to this issue if it does not need to be fixed before we launch 1.4. Otherwise please advise on how to proceed with respect to 1.4.\nThis was a regression - I fixed it by reverting an offending PR: This seems to be fixed now.\nI have 33 pods in my container (1 is substantive, the other 32 just run on log files). I get this all the time now. I'm running 1.5.4.\n- to be honest, I don't undertsand what your wrote. what is \"container\" in \"33 pods in my container\"? Also, if you believe there is a bug somewhere, please open a new issue instead of adding comment to more than half-year-old one.", "positive_passages": [{"docid": "doc-en-kubernetes-210cb30b15b726d52d6e06c7e590c95dff272da12af70f7a2b2fc3f8c3b56269", "text": "return result, len(result) > 0 } <ins> // TODO: Most probably splitting this method to a separate thread will visibily // improve throughput of our watch machinery. So what we should do is to: // - OnEvent handler simply put an element to channel // - processEvent be another goroutine processing events from that channel // Additionally, if we make this channel buffered, cacher will be more resistant // to single watchers being slow - see cacheWatcher::add method. </ins> func (c *Cacher) processEvent(event watchCacheEvent) { triggerValues, supported := c.triggerValues(&event)", "commid": "kubernetes_pr_32269"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee7dcc3235d36c5ced023c560a1d39a0e56a3b4e7f45b338561a6cfa9a84c80", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nThis is pretty much the same failure, that are happening in \"gce-enormous\" suite and we currently debugging them with The main reason of those failures is that we are terminating all watchers for a particular resource type from time to time, and some of them are actually causing a snowball effect. After more looking into it, my hypothesis is that our machinery for aggregating watchers in apiserver sometimes is just to slow. In particular, I some log in my local branch and what I'm observing is that in etcd_watcher, we are: accumulating objects in incoming channel but also accumulating objects in outgoing channel, and the accumulation there is usually higher [I will send a PR to put those logs into master - they seem to be pretty useful for debugging such issues.] So my current hypothesis is that dispatching watch events to watchers is what is too slow. We will continue debugging.\nThe logs that I seem to confirm my hypothesis - outgoing channel is generally more full then the incoming channel in etcd_watcher: vs I'm working on the PR that should at least improve the situation.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nPlease apply the label to this issue if it does not need to be fixed before we launch 1.4. Otherwise please advise on how to proceed with respect to 1.4.\nThis was a regression - I fixed it by reverting an offending PR: This seems to be fixed now.\nI have 33 pods in my container (1 is substantive, the other 32 just run on log files). I get this all the time now. I'm running 1.5.4.\n- to be honest, I don't undertsand what your wrote. what is \"container\" in \"33 pods in my container\"? Also, if you believe there is a bug somewhere, please open a new issue instead of adding comment to more than half-year-old one.", "positive_passages": [{"docid": "doc-en-kubernetes-86a694806be89e8df4cda5c663e442b7f04fc7c5364abbab95b27dea443c78f9", "text": "// OK, block sending, but only for up to 5 seconds. // cacheWatcher.add is called very often, so arrange // to reuse timers instead of constantly allocating. <ins> startTime := time.Now() </ins> const timeout = 5 * time.Second t, ok := timerPool.Get().(*time.Timer) if ok {", "commid": "kubernetes_pr_32269"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee7dcc3235d36c5ced023c560a1d39a0e56a3b4e7f45b338561a6cfa9a84c80", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nThis is pretty much the same failure, that are happening in \"gce-enormous\" suite and we currently debugging them with The main reason of those failures is that we are terminating all watchers for a particular resource type from time to time, and some of them are actually causing a snowball effect. After more looking into it, my hypothesis is that our machinery for aggregating watchers in apiserver sometimes is just to slow. In particular, I some log in my local branch and what I'm observing is that in etcd_watcher, we are: accumulating objects in incoming channel but also accumulating objects in outgoing channel, and the accumulation there is usually higher [I will send a PR to put those logs into master - they seem to be pretty useful for debugging such issues.] So my current hypothesis is that dispatching watch events to watchers is what is too slow. We will continue debugging.\nThe logs that I seem to confirm my hypothesis - outgoing channel is generally more full then the incoming channel in etcd_watcher: vs I'm working on the PR that should at least improve the situation.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nPlease apply the label to this issue if it does not need to be fixed before we launch 1.4. Otherwise please advise on how to proceed with respect to 1.4.\nThis was a regression - I fixed it by reverting an offending PR: This seems to be fixed now.\nI have 33 pods in my container (1 is substantive, the other 32 just run on log files). I get this all the time now. I'm running 1.5.4.\n- to be honest, I don't undertsand what your wrote. what is \"container\" in \"33 pods in my container\"? Also, if you believe there is a bug somewhere, please open a new issue instead of adding comment to more than half-year-old one.", "positive_passages": [{"docid": "doc-en-kubernetes-24341fa31b308bd04c31a6b67cb937fee7c74a4b0409372f0ec89eeb9c6101fe", "text": "c.forget(false) c.stop() } <ins> glog.V(2).Infof(\"cacheWatcher add function blocked processing for %v\", time.Since(startTime)) </ins> } func (c *cacheWatcher) sendWatchCacheEvent(event watchCacheEvent) {", "commid": "kubernetes_pr_32269"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee7dcc3235d36c5ced023c560a1d39a0e56a3b4e7f45b338561a6cfa9a84c80", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nThis is pretty much the same failure, that are happening in \"gce-enormous\" suite and we currently debugging them with The main reason of those failures is that we are terminating all watchers for a particular resource type from time to time, and some of them are actually causing a snowball effect. After more looking into it, my hypothesis is that our machinery for aggregating watchers in apiserver sometimes is just to slow. In particular, I some log in my local branch and what I'm observing is that in etcd_watcher, we are: accumulating objects in incoming channel but also accumulating objects in outgoing channel, and the accumulation there is usually higher [I will send a PR to put those logs into master - they seem to be pretty useful for debugging such issues.] So my current hypothesis is that dispatching watch events to watchers is what is too slow. We will continue debugging.\nThe logs that I seem to confirm my hypothesis - outgoing channel is generally more full then the incoming channel in etcd_watcher: vs I'm working on the PR that should at least improve the situation.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nPlease apply the label to this issue if it does not need to be fixed before we launch 1.4. Otherwise please advise on how to proceed with respect to 1.4.\nThis was a regression - I fixed it by reverting an offending PR: This seems to be fixed now.\nI have 33 pods in my container (1 is substantive, the other 32 just run on log files). I get this all the time now. I'm running 1.5.4.\n- to be honest, I don't undertsand what your wrote. what is \"container\" in \"33 pods in my container\"? Also, if you believe there is a bug somewhere, please open a new issue instead of adding comment to more than half-year-old one.", "positive_passages": [{"docid": "doc-en-kubernetes-5d2d33bf722f9b016cc51dd49e5cd27969538c609e9777516c02c37bf189f2f6", "text": "import ( \"fmt\" \"net/http\" <ins> \"reflect\" </ins> \"sync\" \"sync/atomic\" \"time\"", "commid": "kubernetes_pr_32269"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee7dcc3235d36c5ced023c560a1d39a0e56a3b4e7f45b338561a6cfa9a84c80", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nThis is pretty much the same failure, that are happening in \"gce-enormous\" suite and we currently debugging them with The main reason of those failures is that we are terminating all watchers for a particular resource type from time to time, and some of them are actually causing a snowball effect. After more looking into it, my hypothesis is that our machinery for aggregating watchers in apiserver sometimes is just to slow. In particular, I some log in my local branch and what I'm observing is that in etcd_watcher, we are: accumulating objects in incoming channel but also accumulating objects in outgoing channel, and the accumulation there is usually higher [I will send a PR to put those logs into master - they seem to be pretty useful for debugging such issues.] So my current hypothesis is that dispatching watch events to watchers is what is too slow. We will continue debugging.\nThe logs that I seem to confirm my hypothesis - outgoing channel is generally more full then the incoming channel in etcd_watcher: vs I'm working on the PR that should at least improve the situation.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nPlease apply the label to this issue if it does not need to be fixed before we launch 1.4. Otherwise please advise on how to proceed with respect to 1.4.\nThis was a regression - I fixed it by reverting an offending PR: This seems to be fixed now.\nI have 33 pods in my container (1 is substantive, the other 32 just run on log files). I get this all the time now. I'm running 1.5.4.\n- to be honest, I don't undertsand what your wrote. what is \"container\" in \"33 pods in my container\"? Also, if you believe there is a bug somewhere, please open a new issue instead of adding comment to more than half-year-old one.", "positive_passages": [{"docid": "doc-en-kubernetes-74e2beac7ce474c9f671ffedcb405b5c147d9190685e423dc39ffb2a72a93cd0", "text": "// Injectable for testing. Send the event down the outgoing channel. emit func(watch.Event) <ins> // HighWaterMarks for performance debugging. incomingHWM HighWaterMark outgoingHWM HighWaterMark </ins> cache etcdCache }", "commid": "kubernetes_pr_32269"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee7dcc3235d36c5ced023c560a1d39a0e56a3b4e7f45b338561a6cfa9a84c80", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nThis is pretty much the same failure, that are happening in \"gce-enormous\" suite and we currently debugging them with The main reason of those failures is that we are terminating all watchers for a particular resource type from time to time, and some of them are actually causing a snowball effect. After more looking into it, my hypothesis is that our machinery for aggregating watchers in apiserver sometimes is just to slow. In particular, I some log in my local branch and what I'm observing is that in etcd_watcher, we are: accumulating objects in incoming channel but also accumulating objects in outgoing channel, and the accumulation there is usually higher [I will send a PR to put those logs into master - they seem to be pretty useful for debugging such issues.] So my current hypothesis is that dispatching watch events to watchers is what is too slow. We will continue debugging.\nThe logs that I seem to confirm my hypothesis - outgoing channel is generally more full then the incoming channel in etcd_watcher: vs I'm working on the PR that should at least improve the situation.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nPlease apply the label to this issue if it does not need to be fixed before we launch 1.4. Otherwise please advise on how to proceed with respect to 1.4.\nThis was a regression - I fixed it by reverting an offending PR: This seems to be fixed now.\nI have 33 pods in my container (1 is substantive, the other 32 just run on log files). I get this all the time now. I'm running 1.5.4.\n- to be honest, I don't undertsand what your wrote. what is \"container\" in \"33 pods in my container\"? Also, if you believe there is a bug somewhere, please open a new issue instead of adding comment to more than half-year-old one.", "positive_passages": [{"docid": "doc-en-kubernetes-36a4bbe9bc7844d84dd648e4ba69c465bff9f20df0ce1c03d13a8aa5440c66cf", "text": "cancel:   nil, } w.emit = func(e watch.Event) { <ins> if curLen := int64(len(w.outgoing)); w.outgoingHWM.Update(curLen) { // Monitor if this gets backed up, and how much. glog.V(1).Infof(\"watch (%v): %v objects queued in outgoing channel.\", reflect.TypeOf(e.Object).String(), curLen) } </ins> // Give up on user stop, without this we leak a lot of goroutines in tests. select { case w.outgoing <- e:", "commid": "kubernetes_pr_32269"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee7dcc3235d36c5ced023c560a1d39a0e56a3b4e7f45b338561a6cfa9a84c80", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nThis is pretty much the same failure, that are happening in \"gce-enormous\" suite and we currently debugging them with The main reason of those failures is that we are terminating all watchers for a particular resource type from time to time, and some of them are actually causing a snowball effect. After more looking into it, my hypothesis is that our machinery for aggregating watchers in apiserver sometimes is just to slow. In particular, I some log in my local branch and what I'm observing is that in etcd_watcher, we are: accumulating objects in incoming channel but also accumulating objects in outgoing channel, and the accumulation there is usually higher [I will send a PR to put those logs into master - they seem to be pretty useful for debugging such issues.] So my current hypothesis is that dispatching watch events to watchers is what is too slow. We will continue debugging.\nThe logs that I seem to confirm my hypothesis - outgoing channel is generally more full then the incoming channel in etcd_watcher: vs I'm working on the PR that should at least improve the situation.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nPlease apply the label to this issue if it does not need to be fixed before we launch 1.4. Otherwise please advise on how to proceed with respect to 1.4.\nThis was a regression - I fixed it by reverting an offending PR: This seems to be fixed now.\nI have 33 pods in my container (1 is substantive, the other 32 just run on log files). I get this all the time now. I'm running 1.5.4.\n- to be honest, I don't undertsand what your wrote. what is \"container\" in \"33 pods in my container\"? Also, if you believe there is a bug somewhere, please open a new issue instead of adding comment to more than half-year-old one.", "positive_passages": [{"docid": "doc-en-kubernetes-57249fa8ab0d6c3002c064ffc44013b5601b842441a5ba5fc4decb20902746d1", "text": "incoming <- &copied } <del> var ( watchChannelHWM HighWaterMark ) </del> // translate pulls stuff from etcd, converts, and pushes out the outgoing channel. Meant to be // called as a goroutine. func (w *etcdWatcher) translate() {", "commid": "kubernetes_pr_32269"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee7dcc3235d36c5ced023c560a1d39a0e56a3b4e7f45b338561a6cfa9a84c80", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nThis is pretty much the same failure, that are happening in \"gce-enormous\" suite and we currently debugging them with The main reason of those failures is that we are terminating all watchers for a particular resource type from time to time, and some of them are actually causing a snowball effect. After more looking into it, my hypothesis is that our machinery for aggregating watchers in apiserver sometimes is just to slow. In particular, I some log in my local branch and what I'm observing is that in etcd_watcher, we are: accumulating objects in incoming channel but also accumulating objects in outgoing channel, and the accumulation there is usually higher [I will send a PR to put those logs into master - they seem to be pretty useful for debugging such issues.] So my current hypothesis is that dispatching watch events to watchers is what is too slow. We will continue debugging.\nThe logs that I seem to confirm my hypothesis - outgoing channel is generally more full then the incoming channel in etcd_watcher: vs I'm working on the PR that should at least improve the situation.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nPlease apply the label to this issue if it does not need to be fixed before we launch 1.4. Otherwise please advise on how to proceed with respect to 1.4.\nThis was a regression - I fixed it by reverting an offending PR: This seems to be fixed now.\nI have 33 pods in my container (1 is substantive, the other 32 just run on log files). I get this all the time now. I'm running 1.5.4.\n- to be honest, I don't undertsand what your wrote. what is \"container\" in \"33 pods in my container\"? Also, if you believe there is a bug somewhere, please open a new issue instead of adding comment to more than half-year-old one.", "positive_passages": [{"docid": "doc-en-kubernetes-c526fc68ea52a14e8a000d72c3d96d4be1fb045d964c47975187e146c173bef6", "text": "return case res, ok := <-w.etcdIncoming: if ok { <del> if curLen := int64(len(w.etcdIncoming)); watchChannelHWM.Update(curLen) { </del> <ins> if curLen := int64(len(w.etcdIncoming)); w.incomingHWM.Update(curLen) { </ins> // Monitor if this gets backed up, and how much. <del> glog.V(2).Infof(\"watch: %v objects queued in channel.\", curLen) </del> <ins> glog.V(1).Infof(\"watch: %v objects queued in incoming channel.\", curLen) </ins> } w.sendResult(res) }", "commid": "kubernetes_pr_32269"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee7dcc3235d36c5ced023c560a1d39a0e56a3b4e7f45b338561a6cfa9a84c80", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nThis is pretty much the same failure, that are happening in \"gce-enormous\" suite and we currently debugging them with The main reason of those failures is that we are terminating all watchers for a particular resource type from time to time, and some of them are actually causing a snowball effect. After more looking into it, my hypothesis is that our machinery for aggregating watchers in apiserver sometimes is just to slow. In particular, I some log in my local branch and what I'm observing is that in etcd_watcher, we are: accumulating objects in incoming channel but also accumulating objects in outgoing channel, and the accumulation there is usually higher [I will send a PR to put those logs into master - they seem to be pretty useful for debugging such issues.] So my current hypothesis is that dispatching watch events to watchers is what is too slow. We will continue debugging.\nThe logs that I seem to confirm my hypothesis - outgoing channel is generally more full then the incoming channel in etcd_watcher: vs I'm working on the PR that should at least improve the situation.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nPlease apply the label to this issue if it does not need to be fixed before we launch 1.4. Otherwise please advise on how to proceed with respect to 1.4.\nThis was a regression - I fixed it by reverting an offending PR: This seems to be fixed now.\nI have 33 pods in my container (1 is substantive, the other 32 just run on log files). I get this all the time now. I'm running 1.5.4.\n- to be honest, I don't undertsand what your wrote. what is \"container\" in \"33 pods in my container\"? Also, if you believe there is a bug somewhere, please open a new issue instead of adding comment to more than half-year-old one.", "positive_passages": [{"docid": "doc-en-kubernetes-8cdafe1ddcf562ec3b12e99276abdc75619a42aef3c9455ecef1a087c95698f7", "text": "if res == nil { continue } <ins> if len(wc.resultChan) == outgoingBufSize { glog.Warningf(\"Fast watcher, slow processing. Number of buffered events: %d.\"+ \"Probably caused by slow dispatching events to watchers\", outgoingBufSize) } </ins> // If user couldn't receive results fast enough, we also block incoming events from watcher. // Because storing events in local will cause more memory usage. // The worst case would be closing the fast watcher.", "commid": "kubernetes_pr_32269"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee7dcc3235d36c5ced023c560a1d39a0e56a3b4e7f45b338561a6cfa9a84c80", "query": "https://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite} Previous issues for this test:\nThis is pretty much the same failure, that are happening in \"gce-enormous\" suite and we currently debugging them with The main reason of those failures is that we are terminating all watchers for a particular resource type from time to time, and some of them are actually causing a snowball effect. After more looking into it, my hypothesis is that our machinery for aggregating watchers in apiserver sometimes is just to slow. In particular, I some log in my local branch and what I'm observing is that in etcd_watcher, we are: accumulating objects in incoming channel but also accumulating objects in outgoing channel, and the accumulation there is usually higher [I will send a PR to put those logs into master - they seem to be pretty useful for debugging such issues.] So my current hypothesis is that dispatching watch events to watchers is what is too slow. We will continue debugging.\nThe logs that I seem to confirm my hypothesis - outgoing channel is generally more full then the incoming channel in etcd_watcher: vs I'm working on the PR that should at least improve the situation.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nhttps://k8s- Failed: [] Load capacity [Feature:Performance] should be able to handle 30 pods per node {Kubernetes e2e suite}\nPlease apply the label to this issue if it does not need to be fixed before we launch 1.4. Otherwise please advise on how to proceed with respect to 1.4.\nThis was a regression - I fixed it by reverting an offending PR: This seems to be fixed now.\nI have 33 pods in my container (1 is substantive, the other 32 just run on log files). I get this all the time now. I'm running 1.5.4.\n- to be honest, I don't undertsand what your wrote. what is \"container\" in \"33 pods in my container\"? Also, if you believe there is a bug somewhere, please open a new issue instead of adding comment to more than half-year-old one.", "positive_passages": [{"docid": "doc-en-kubernetes-b6d9a5ba520878d10bc162a27089c2a79a0bcedd5e25a741744bec539639e68b", "text": "func (wc *watchChan) sendEvent(e *event) { if len(wc.incomingEventChan) == incomingBufSize { <del> glog.V(2).Infof(\"Fast watcher, slow processing. Number of buffered events: %d.\"+ </del> <ins> glog.Warningf(\"Fast watcher, slow processing. Number of buffered events: %d.\"+ </ins> \"Probably caused by slow decoding, user not receiving fast, or other processing logic\", incomingBufSize) }", "commid": "kubernetes_pr_32269"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-096053f9afbdae0d9ebcf10306786bac35334430e34aeee27d2c517b7f3c22e9", "query": "https://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite} Happened on a presubmit run in . Previous issues for this test:\nfailed in https://k8s-\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite} Happened on a presubmit run in .\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nAny updates on this issue If you could you change the milestone to 1.5 and add a label for the responsible team that would be a great help as we triage flakes for the 1.5 release. Thanks!\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nThere is a problem with fetching images on GKE. It seems that pod is unable to fetch image for more than 2 minutes. It is strange, as AFAIK the image should be pre-fetched by image-puller:\n[FLAKE-PING] This flaky-test issue would love to have more attention.\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\n, all issues must be labeled either release blocker or non release blocking by end of day 18 November 2016 PST. If you are not the correct owner please identify the correct owner and add them to this thread for assignment. Thanks for your help. cc:\nWRT https://k8s- There was a problem w/removing namespace. This is a duplicate of and is not related to HPA.\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nCould you please help triage this issue as blocking or non-blocking for 1.5 (or help find someone who can). If there is a real issue here, we need to find out ASAP, or else we risk the 1.5 release date.\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nWRT https://k8s- build: kubelet logs for pod rc-light-qyowb : Kubelet is not starting pod for 2 minutes, reason unknown. The same problem is in issue Can you take a look or assign someone from kubelet team?\nI suspect that the logging level is set to in GKE tests and so most of the useful logs are not available. Let me figure out a means to bump the logging level to further debug this issue. you might still have to triage the non v1.4 release failures to address concern .\nhow can we update the environment variables for GKE test clusters? For OSS, we up the kubelet logging for test clusters\nI still don't agree with test environmental changes, which is one of the reasons we've never made this a priority. A GKE test cluster looks the same as a GKE prod cluster. How would you debug this in production? Always ask that, and you come back to test == prod.\ncc\nIn my opinion it is release blocker: sometimes pods are not started\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nThe pod startup failure you posted in is for release 1.4 branch. Why do you think it is a release blocker? We need to triage other failures on HEAD and/or 1.5 branch which could be release blockers. If the intent is to keep prod and test in sync, then let's up the logging level in prod as well. When issues happen in prod, we might need those missing log lines anyways. I suspect that we might have to have GCI rotate logs more aggressively as a side effect.\nWhy is the argument to increase the log level rather than making sure that all logs necessary for debugging production issues are at level 2 or above? Levels 3/4 shouldn't be necessary to figure out why a key control loop isn't behaving correctly.\nWhat you suggest is a good fix for the future. We need to reexamine logging levels across kubelet. However, that might not happen in the next few days. How do we make progress now?\nWould isolating logging level changes to specific test suites be acceptable? That way, most of our tests would match production setup.\nThat's what I'd suggested on the other (internal) code review.\nDo we have consensus on how to get past this as a release-blocker?\nWe are waiting on to give a go ahead from the release perspective. The kubelet failures that and I have been discussing about have not been on v1.5 AFAIK.\nSorry, I didn't notice that this problem is on 1.4 branch. If so, the issue is not release-blocker. So, I'm removing the label.\nAck. Marking as non-release-blocker\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}\nIs it appropriate to move this to the next milestone? (and remove the non-release-blocker tag as well)\nPR should be cherry-picked to 1.5 This is not a release-blocker as it affects e2e tests only.\nhttps://k8s- Failed: [] [HPA] Horizontal pod autoscaling (scale resource: CPU) [] ReplicationController light Should scale from 1 pod to 2 pods {Kubernetes e2e suite}", "positive_passages": [{"docid": "doc-en-kubernetes-fdb9b5a89d9402a08714bc5c0e58e67e8e808cb40e473fcd93dd08c43c802034", "text": "} framework.ExpectNoError(framework.RunRC(controllerRcConfig)) <del> // Make sure endpoints are propagated. // TODO(piosz): replace sleep with endpoints watch. time.Sleep(10 * time.Second) </del> <ins> // Wait for endpoints to propagate for the controller service. framework.ExpectNoError(framework.WaitForServiceEndpointsNum( c, ns, controllerName, 1, startServiceInterval, startServiceTimeout)) </ins> }", "commid": "kubernetes_pr_38463"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2b232003ce728880c810de8f0dd50c5112cccba53e3d7b7c4149e9341a0037d", "query": "https://k8s- Failed: BeforeSuite {Kubernetes e2e suite} Previous issues for this test:", "positive_passages": [{"docid": "doc-en-kubernetes-514977c4e8486ea4f5edac451ccef2485ced7d5e64590c4ea5fe28fd4994c1e9", "text": "} // errorBadPodsStates create error message of basic info of bad pods for debugging. <del> func errorBadPodsStates(badPods []api.Pod, desiredPods int, ns string, timeout time.Duration) string { errStr := fmt.Sprintf(\"%d / %d pods in namespace %q are NOT in the desired state in %vn\", len(badPods), desiredPods, ns, timeout) </del> <ins> func errorBadPodsStates(badPods []api.Pod, desiredPods int, ns, desiredState string, timeout time.Duration) string { errStr := fmt.Sprintf(\"%d / %d pods in namespace %q are NOT in %s state in %vn\", len(badPods), desiredPods, ns, desiredState, timeout) </ins> // Pirnt bad pods info only if there are fewer than 10 bad pods if len(badPods) > 10 { return errStr + \"There are too many bad pods. Please check log for details.\"", "commid": "kubernetes_pr_33813"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2b232003ce728880c810de8f0dd50c5112cccba53e3d7b7c4149e9341a0037d", "query": "https://k8s- Failed: BeforeSuite {Kubernetes e2e suite} Previous issues for this test:", "positive_passages": [{"docid": "doc-en-kubernetes-0837eebf78e6dc66a6c73a0006dcdc31ec68269dcf3cbc6ccb8390dc4c4a5f16", "text": "// pods have been created. func WaitForPodsSuccess(c *client.Client, ns string, successPodLabels map[string]string, timeout time.Duration) error { successPodSelector := labels.SelectorFromSet(successPodLabels) <del> start, badPods := time.Now(), []api.Pod{} </del> <ins> start, badPods, desiredPods := time.Now(), []api.Pod{}, 0 </ins> if wait.PollImmediate(30*time.Second, timeout, func() (bool, error) { podList, err := c.Pods(ns).List(api.ListOptions{LabelSelector: successPodSelector})", "commid": "kubernetes_pr_33813"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2b232003ce728880c810de8f0dd50c5112cccba53e3d7b7c4149e9341a0037d", "query": "https://k8s- Failed: BeforeSuite {Kubernetes e2e suite} Previous issues for this test:", "positive_passages": [{"docid": "doc-en-kubernetes-d9b3c7a637c6a7767640c61bc93fe2966c80e59b68963ae53e2ca280ff34e6b7", "text": "return true, nil } badPods = []api.Pod{} <ins> desiredPods = len(podList.Items) </ins> for _, pod := range podList.Items { if pod.Status.Phase != api.PodSucceeded { badPods = append(badPods, pod)", "commid": "kubernetes_pr_33813"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2b232003ce728880c810de8f0dd50c5112cccba53e3d7b7c4149e9341a0037d", "query": "https://k8s- Failed: BeforeSuite {Kubernetes e2e suite} Previous issues for this test:", "positive_passages": [{"docid": "doc-en-kubernetes-8d588c5438db40949bffbe28c513a1ac0500827391efdff44af3c63df145bf0c", "text": "}) != nil { logPodStates(badPods) LogPodsWithLabels(c, ns, successPodLabels) <del> return fmt.Errorf(\"Not all pods in namespace %q are successful within %v\", ns, timeout) </del> <ins> return errors.New(errorBadPodsStates(badPods, desiredPods, ns, \"SUCCESS\", timeout)) </ins> } return nil }", "commid": "kubernetes_pr_33813"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2b232003ce728880c810de8f0dd50c5112cccba53e3d7b7c4149e9341a0037d", "query": "https://k8s- Failed: BeforeSuite {Kubernetes e2e suite} Previous issues for this test:", "positive_passages": [{"docid": "doc-en-kubernetes-66d708e834da016ea50597c47822a9006d82b327e89f45caf258e48aff3f1fae", "text": "logPodStates(badPods) return false, nil }) != nil { <del> return errors.New(errorBadPodsStates(badPods, desiredPods, ns, timeout)) </del> <ins> return errors.New(errorBadPodsStates(badPods, desiredPods, ns, \"RUNNING and READY\", timeout)) </ins> } wg.Wait() if waitForSuccessError != nil {", "commid": "kubernetes_pr_33813"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0123cb6ac201bd0f2b91e7882abfd3b318b9ffdff935b996f38e63ba0a4f0805", "query": "Another flake i found earlier yesterday, just linking to it for posterity, not blocking me right now. TestContainerStatus\nCould you post some error log here? I can't reproduce it with stress test\nHm, got one reproduce:", "positive_passages": [{"docid": "doc-en-kubernetes-95036b5248838550bd8fdef086828b184f72225af2a5e337306341be0d36cc51", "text": "} // Create the container. <del> fClock.SetTime(time.Now()) </del> <ins> fClock.SetTime(time.Now().Add(-1 * time.Hour)) </ins> *expected.CreatedAt = fClock.Now().Unix() id, err := ds.CreateContainer(\"sandboxid\", config, sConfig) // Set the id manually since we don't know the id until it's created.", "commid": "kubernetes_pr_33448"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0123cb6ac201bd0f2b91e7882abfd3b318b9ffdff935b996f38e63ba0a4f0805", "query": "Another flake i found earlier yesterday, just linking to it for posterity, not blocking me right now. TestContainerStatus\nCould you post some error log here? I can't reproduce it with stress test\nHm, got one reproduce:", "positive_passages": [{"docid": "doc-en-kubernetes-e66464d4e02cf3b6f4ea48c9b2166fc7c0c9bed79da187ff6f2f05dadcdeb1bb", "text": "assert.Equal(t, expected, status) // Advance the clock and stop the container. <del> fClock.SetTime(time.Now()) </del> <ins> fClock.SetTime(time.Now().Add(1 * time.Hour)) </ins> *expected.FinishedAt = fClock.Now().Unix() *expected.State = runtimeApi.ContainerState_EXITED *expected.Reason = \"Completed\"", "commid": "kubernetes_pr_33448"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0123cb6ac201bd0f2b91e7882abfd3b318b9ffdff935b996f38e63ba0a4f0805", "query": "Another flake i found earlier yesterday, just linking to it for posterity, not blocking me right now. TestContainerStatus\nCould you post some error log here? I can't reproduce it with stress test\nHm, got one reproduce:", "positive_passages": [{"docid": "doc-en-kubernetes-2d121d6789e8a78ee133ee52af88fcc42b73b72dafb647ddc4a8d9bfd25aa559", "text": ") func newTestDockerSevice() (*dockerService, *dockertools.FakeDockerClient, *clock.FakeClock) { <del> c := dockertools.NewFakeDockerClient() </del> fakeClock := clock.NewFakeClock(time.Time{}) <ins> c := dockertools.NewFakeDockerClientWithClock(fakeClock) </ins> return &dockerService{client: c}, c, fakeClock }", "commid": "kubernetes_pr_33448"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8635daf913727db16009000c6f67d7c9664802936521decedf5ae6216907dc0d", "query": "Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"4+\", GitVersion:\"v1.4.0-beta.11\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2016-09-23T22:53:01Z\", GoVersion:\"go1.6.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"4\", GitVersion:\"v1.4.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2016-09-26T18:10:32Z\", GoVersion:\"go1.6.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Environment: AWS - CentOS 7.2 x8664 with cloud-init (HVM) (ami-) OS (e.g. from /etc/os-release): NAME=\"CentOS Linux\" VERSION=\"7 (Core)\" ID=\"centos\" IDLIKE=\"rhel fedora\" VERSIONID=\"7\" PRETTYNAME=\"CentOS Linux 7 (Core)\" ANSICOLOR=\"0;31\" CPENAME=\"cpe:/o:centos:centos:7\" HOMEURL=\"\" BUGREPORTURL=\"\" CENTOSMANTISBTPROJECT=\"CentOS-7\" CENTOSMANTISBTPROJECTVERSION=\"7\" REDHATSUPPORTPRODUCT=\"centos\" REDHATSUPPORTPRODUCTVERSION=\"7\" Linux ip-172-31-35-103 3.10.0-327.el7.x8664 SMP Thu Nov 19 22:10:57 UTC 2015 x8664 x8664 x86_64 GNU/Linux Install tools: Others: What happened: when selinux is enabled i was getting following error on discovery container What you expected to happen: i expected node to be able to join master, but nothing was running on 9898 port of master i.e. discovery due the error mentioned above How to reproduce it (as minimally and precisely as possible): use the api which i gave you and do normal kubeadm init Anything else do we need to know: This issue got fixed with setenforce 0\nThis issue got fixed with setenforce 0 but want to track it\ncc\nBTW the issue was on latest Centos iso too downloaded from here\ncc\nthis is to do with secrets, and kubelet log is the place to look for more info, could you please grab and paste it in a gist (it's gonna be fairly large)? Also, the kernel audit log would be handy, do you know how to get this (I forgot)?\nnot sure if this will help\nthe lines are incomplete, it's best if you redirect it to a file and upload it somewhere with a link here.\ncould you also provide the output of ?", "positive_passages": [{"docid": "doc-en-kubernetes-a2c7c64765547e2371eadafa8e0b33d0785044878c6b1bac0688ad4c84d7b702", "text": "// `HostIP: s.API.AdvertiseAddrs[0]`, if there is only one address` {Name: \"http\", ContainerPort: 9898, HostPort: 9898}, }, <ins> SecurityContext: &api.SecurityContext{ SELinuxOptions: &api.SELinuxOptions{ // TODO: This implies our discovery container is not being restricted by // SELinux. This is not optimal and would be nice to adjust in future // so it can read /tmp/secret, but for now this avoids recommending // setenforce 0 system-wide. Type: \"unconfined_t\", }, }, </ins> }}, Volumes: []api.Volume{{ Name: kubeDiscoverySecretName,", "commid": "kubernetes_pr_33555"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a28579b9fb700fe4306bffad7a794ea4c9a1d5eb27439193bb009ba6338ebda5", "query": "Kubernetes version (use ): Environment: Cloud provider or hardware configuration: Any OS (e.g. from /etc/os-release): Any Kernel (e.g. ): Any Install tools: Any What happened: If I use a template with the seperator, and if the line with the separator has trailing whitespace characters, then kubectl considers that to be the EOF instead of reading further. e.g. template What you expected to happen: It should not stop reading if there are trailing whitespace characters, it should just trim the separator line and ignore the whitespaces after the . This is how it worked until v1.3.0 kubectl version. How to reproduce it (as minimally and precisely as possible): Just use the template from above and you'll notice that it won't create the Service, but it'll create the Replication controller. Anything else do we need to know: This is on kubectl version 1.4.0\nkubectl regression. cc\nThis bug is general (can be found on get, apply, delete, ...). May be somewhere in resource builder.\nMight be , Janet Kuo wrote:\nConfirmed - is the cause. would you take a look?\nWe may need to cherrypick the fix\nYaml rules are separator must be at beginning of line, three dashes, and new line. Did we change how strict we were in that PR? On Sep 27, 2016, at 7:46 PM, Janet Kuo wrote: We may need to cherrypick the fix \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nYes, and the test was changed too (originally tests allow with trailing spaces)\nAccording to spec (if my spec-alese is correct) newline + three dashes is the only requirement to terminate a document. Whitespace or prefixes are allowed afterwards, but for it to be valid YAML those must be valid at the beginning of a doc as well (as far as I can tell). So we should split and remove on any line starting with a newline and three dashes - but not consume the remaining whitespace (I believe) , Janet Kuo wrote:\nWe should probably exit non-0 and have an error message if we see something in the file that we don't expect. E.g. is neither a separator nor parseable yaml.\nWe should add a test that uses a YAML document prefix rule and verify that it correctly passes / fails when YAML goes to parse. From reading the spec it appears that anything that is invalid when n--- is present is also invalid in a single document context, and vice versa. , Phillip Wittrock wrote:\nI have rechecked the code, and I have located the root cause, since I am outing for a training these days, I will fix this right now after the training on Friday.\nI am quite sorry about the regression. :(\nshould we allow trailing whitespace characters after , if so we can trim the whitespaces when we read line by line?\nis it possible to include this fix to one of the 1.4 releases? We'd really like our users to have of k8s alpha features (Scheduled jobs is one of them) that can be configured only using 1.4 client; w/o them potentially hitting this regression.\nI will double check this regression, and open a cherry-pick PR.\nI am thinking create a cherry-pick PR for this to include it in 1.4, wdyt?\nI would like to see this in 1.4 since as you note it may break scripts. On Oct 19, 2016, at 8:19 PM, TonyAdo wrote: I am thinking create a cherry-pick PR for this to include it in 1.4, wdyt? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nDo we have a test case now? :) On Oct 19, 2016, at 8:19 PM, TonyAdo wrote: I am thinking create a cherry-pick PR for this to include it in 1.4, wdyt? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nwe already test this, you can see", "positive_passages": [{"docid": "doc-en-kubernetes-e7c1004ed4b51780834c1318cb64d19b227e5f08774395cc829a6cf080457639", "text": "} const yamlSeparator = \"n---\" <del> const separator = \"---n\" </del> <ins> const separator = \"---\" </ins> // splitYAMLDocument is a bufio.SplitFunc for splitting YAML streams into individual documents. func splitYAMLDocument(data []byte, atEOF bool) (advance int, token []byte, err error) {", "commid": "kubernetes_pr_34297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a28579b9fb700fe4306bffad7a794ea4c9a1d5eb27439193bb009ba6338ebda5", "query": "Kubernetes version (use ): Environment: Cloud provider or hardware configuration: Any OS (e.g. from /etc/os-release): Any Kernel (e.g. ): Any Install tools: Any What happened: If I use a template with the seperator, and if the line with the separator has trailing whitespace characters, then kubectl considers that to be the EOF instead of reading further. e.g. template What you expected to happen: It should not stop reading if there are trailing whitespace characters, it should just trim the separator line and ignore the whitespaces after the . This is how it worked until v1.3.0 kubectl version. How to reproduce it (as minimally and precisely as possible): Just use the template from above and you'll notice that it won't create the Service, but it'll create the Replication controller. Anything else do we need to know: This is on kubectl version 1.4.0\nkubectl regression. cc\nThis bug is general (can be found on get, apply, delete, ...). May be somewhere in resource builder.\nMight be , Janet Kuo wrote:\nConfirmed - is the cause. would you take a look?\nWe may need to cherrypick the fix\nYaml rules are separator must be at beginning of line, three dashes, and new line. Did we change how strict we were in that PR? On Sep 27, 2016, at 7:46 PM, Janet Kuo wrote: We may need to cherrypick the fix \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nYes, and the test was changed too (originally tests allow with trailing spaces)\nAccording to spec (if my spec-alese is correct) newline + three dashes is the only requirement to terminate a document. Whitespace or prefixes are allowed afterwards, but for it to be valid YAML those must be valid at the beginning of a doc as well (as far as I can tell). So we should split and remove on any line starting with a newline and three dashes - but not consume the remaining whitespace (I believe) , Janet Kuo wrote:\nWe should probably exit non-0 and have an error message if we see something in the file that we don't expect. E.g. is neither a separator nor parseable yaml.\nWe should add a test that uses a YAML document prefix rule and verify that it correctly passes / fails when YAML goes to parse. From reading the spec it appears that anything that is invalid when n--- is present is also invalid in a single document context, and vice versa. , Phillip Wittrock wrote:\nI have rechecked the code, and I have located the root cause, since I am outing for a training these days, I will fix this right now after the training on Friday.\nI am quite sorry about the regression. :(\nshould we allow trailing whitespace characters after , if so we can trim the whitespaces when we read line by line?\nis it possible to include this fix to one of the 1.4 releases? We'd really like our users to have of k8s alpha features (Scheduled jobs is one of them) that can be configured only using 1.4 client; w/o them potentially hitting this regression.\nI will double check this regression, and open a cherry-pick PR.\nI am thinking create a cherry-pick PR for this to include it in 1.4, wdyt?\nI would like to see this in 1.4 since as you note it may break scripts. On Oct 19, 2016, at 8:19 PM, TonyAdo wrote: I am thinking create a cherry-pick PR for this to include it in 1.4, wdyt? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nDo we have a test case now? :) On Oct 19, 2016, at 8:19 PM, TonyAdo wrote: I am thinking create a cherry-pick PR for this to include it in 1.4, wdyt? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nwe already test this, you can see", "positive_passages": [{"docid": "doc-en-kubernetes-f941b63bd56e132f75194e8a86bff63ce56626198217e90cbe7f0c4a350e196b", "text": "return nil, err } <del> if string(line) == separator || err == io.EOF { </del> <ins> sep := len([]byte(separator)) if i := bytes.Index(line, []byte(separator)); i == 0 { // We have a potential document terminator i += sep after := line[i:] if len(strings.TrimRightFunc(string(after), unicode.IsSpace)) == 0 { if buffer.Len() != 0 { return buffer.Bytes(), nil } if err == io.EOF { return nil, err } } } if err == io.EOF { </ins> if buffer.Len() != 0 { <ins> // If we're at EOF, we have a final, non-terminated line. Return it. </ins> return buffer.Bytes(), nil } <del> if err == io.EOF { return nil, err } } else { buffer.Write(line) </del> <ins> return nil, err </ins> } <ins> buffer.Write(line) </ins> } }", "commid": "kubernetes_pr_34297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a28579b9fb700fe4306bffad7a794ea4c9a1d5eb27439193bb009ba6338ebda5", "query": "Kubernetes version (use ): Environment: Cloud provider or hardware configuration: Any OS (e.g. from /etc/os-release): Any Kernel (e.g. ): Any Install tools: Any What happened: If I use a template with the seperator, and if the line with the separator has trailing whitespace characters, then kubectl considers that to be the EOF instead of reading further. e.g. template What you expected to happen: It should not stop reading if there are trailing whitespace characters, it should just trim the separator line and ignore the whitespaces after the . This is how it worked until v1.3.0 kubectl version. How to reproduce it (as minimally and precisely as possible): Just use the template from above and you'll notice that it won't create the Service, but it'll create the Replication controller. Anything else do we need to know: This is on kubectl version 1.4.0\nkubectl regression. cc\nThis bug is general (can be found on get, apply, delete, ...). May be somewhere in resource builder.\nMight be , Janet Kuo wrote:\nConfirmed - is the cause. would you take a look?\nWe may need to cherrypick the fix\nYaml rules are separator must be at beginning of line, three dashes, and new line. Did we change how strict we were in that PR? On Sep 27, 2016, at 7:46 PM, Janet Kuo wrote: We may need to cherrypick the fix \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nYes, and the test was changed too (originally tests allow with trailing spaces)\nAccording to spec (if my spec-alese is correct) newline + three dashes is the only requirement to terminate a document. Whitespace or prefixes are allowed afterwards, but for it to be valid YAML those must be valid at the beginning of a doc as well (as far as I can tell). So we should split and remove on any line starting with a newline and three dashes - but not consume the remaining whitespace (I believe) , Janet Kuo wrote:\nWe should probably exit non-0 and have an error message if we see something in the file that we don't expect. E.g. is neither a separator nor parseable yaml.\nWe should add a test that uses a YAML document prefix rule and verify that it correctly passes / fails when YAML goes to parse. From reading the spec it appears that anything that is invalid when n--- is present is also invalid in a single document context, and vice versa. , Phillip Wittrock wrote:\nI have rechecked the code, and I have located the root cause, since I am outing for a training these days, I will fix this right now after the training on Friday.\nI am quite sorry about the regression. :(\nshould we allow trailing whitespace characters after , if so we can trim the whitespaces when we read line by line?\nis it possible to include this fix to one of the 1.4 releases? We'd really like our users to have of k8s alpha features (Scheduled jobs is one of them) that can be configured only using 1.4 client; w/o them potentially hitting this regression.\nI will double check this regression, and open a cherry-pick PR.\nI am thinking create a cherry-pick PR for this to include it in 1.4, wdyt?\nI would like to see this in 1.4 since as you note it may break scripts. On Oct 19, 2016, at 8:19 PM, TonyAdo wrote: I am thinking create a cherry-pick PR for this to include it in 1.4, wdyt? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nDo we have a test case now? :) On Oct 19, 2016, at 8:19 PM, TonyAdo wrote: I am thinking create a cherry-pick PR for this to include it in 1.4, wdyt? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nwe already test this, you can see", "positive_passages": [{"docid": "doc-en-kubernetes-f9b2e9c57cbd98427c8fa3760507913827104b2fcd532229af2b842521581bcc", "text": "s := NewYAMLToJSONDecoder(bytes.NewReader([]byte(`--- stuff: 1 <del> --- </del> <ins> --- </ins> `))) obj := generic{} if err := s.Decode(&obj); err != nil {", "commid": "kubernetes_pr_34297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a28579b9fb700fe4306bffad7a794ea4c9a1d5eb27439193bb009ba6338ebda5", "query": "Kubernetes version (use ): Environment: Cloud provider or hardware configuration: Any OS (e.g. from /etc/os-release): Any Kernel (e.g. ): Any Install tools: Any What happened: If I use a template with the seperator, and if the line with the separator has trailing whitespace characters, then kubectl considers that to be the EOF instead of reading further. e.g. template What you expected to happen: It should not stop reading if there are trailing whitespace characters, it should just trim the separator line and ignore the whitespaces after the . This is how it worked until v1.3.0 kubectl version. How to reproduce it (as minimally and precisely as possible): Just use the template from above and you'll notice that it won't create the Service, but it'll create the Replication controller. Anything else do we need to know: This is on kubectl version 1.4.0\nkubectl regression. cc\nThis bug is general (can be found on get, apply, delete, ...). May be somewhere in resource builder.\nMight be , Janet Kuo wrote:\nConfirmed - is the cause. would you take a look?\nWe may need to cherrypick the fix\nYaml rules are separator must be at beginning of line, three dashes, and new line. Did we change how strict we were in that PR? On Sep 27, 2016, at 7:46 PM, Janet Kuo wrote: We may need to cherrypick the fix \u2014 You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nYes, and the test was changed too (originally tests allow with trailing spaces)\nAccording to spec (if my spec-alese is correct) newline + three dashes is the only requirement to terminate a document. Whitespace or prefixes are allowed afterwards, but for it to be valid YAML those must be valid at the beginning of a doc as well (as far as I can tell). So we should split and remove on any line starting with a newline and three dashes - but not consume the remaining whitespace (I believe) , Janet Kuo wrote:\nWe should probably exit non-0 and have an error message if we see something in the file that we don't expect. E.g. is neither a separator nor parseable yaml.\nWe should add a test that uses a YAML document prefix rule and verify that it correctly passes / fails when YAML goes to parse. From reading the spec it appears that anything that is invalid when n--- is present is also invalid in a single document context, and vice versa. , Phillip Wittrock wrote:\nI have rechecked the code, and I have located the root cause, since I am outing for a training these days, I will fix this right now after the training on Friday.\nI am quite sorry about the regression. :(\nshould we allow trailing whitespace characters after , if so we can trim the whitespaces when we read line by line?\nis it possible to include this fix to one of the 1.4 releases? We'd really like our users to have of k8s alpha features (Scheduled jobs is one of them) that can be configured only using 1.4 client; w/o them potentially hitting this regression.\nI will double check this regression, and open a cherry-pick PR.\nI am thinking create a cherry-pick PR for this to include it in 1.4, wdyt?\nI would like to see this in 1.4 since as you note it may break scripts. On Oct 19, 2016, at 8:19 PM, TonyAdo wrote: I am thinking create a cherry-pick PR for this to include it in 1.4, wdyt? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nDo we have a test case now? :) On Oct 19, 2016, at 8:19 PM, TonyAdo wrote: I am thinking create a cherry-pick PR for this to include it in 1.4, wdyt? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nwe already test this, you can see", "positive_passages": [{"docid": "doc-en-kubernetes-ffaf8a140cd35bed91f9d6527505813dcbbff2c8c825995a926a1cd96cd916a3", "text": "obj := generic{} err := s.Decode(&obj) if err == nil { <del> t.Fatal(\"expected error with yaml: prefix, got no error\") </del> <ins> t.Fatal(\"expected error with yaml: violate, got no error\") </ins> } fmt.Printf(\"err: %sn\", err.Error()) <del> if !strings.HasPrefix(err.Error(), \"yaml: line 1:\") { t.Fatalf(\"expected %q to have 'yaml: line 1:' prefix\", err.Error()) </del> <ins> if !strings.HasPrefix(err.Error(), \"yaml: line 2:\") { t.Fatalf(\"expected %q to have 'yaml: line 2:' found a tab character\", err.Error()) </ins> } }", "commid": "kubernetes_pr_34297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-35d3cc1f24250a067ab9790ff51c5c1866bfb8dbfe3e507bd1189b8776b497ae", "query": "Just saw this warning today: Not sure if this is only limited to kubemark, or if there are other places we need to fix, too.\nSorry if this sounds stupid, but as expected, won't show this warning - what needs to be fixed here?\nwe have a bunch of scripts and Makefiles which are omitting the currently. We need to fix these by adding the missing s.", "positive_passages": [{"docid": "doc-en-kubernetes-adbe884ea999bc3ee0e9a676bd0db2789f2f1b3dd692eba314f33a7580e46f20", "text": "docker build -t $(PREFIX)/logs-generator:$(TAG) . push: <del> gcloud docker push $(PREFIX)/logs-generator:$(TAG) </del> <ins> gcloud docker -- push $(PREFIX)/logs-generator:$(TAG) </ins> clean: rm -f logs-generator  No newline at end of file", "commid": "kubernetes_pr_35175"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3bf8a64b76529daf5ef9d30b1f8b10107f0cec27bd9639b72947be09713adaf4", "query": "See\nCI has built and uploaded unofficial prerelease darwin binaries for 1.4 using go1.7.1: cc Official binaries will ship as soon as we cut 1.4.1.\nWe have official v1.4.1 binaries available now, too.\nHooray", "positive_passages": [{"docid": "doc-en-kubernetes-9fe93ec340d941191bad7e64e1e623bc30cb214b725e2645b9d4a0ca77ab051f", "text": "RUN mkdir -p ${K8S_PATCHED_GOROOT}  && curl -sSL https://github.com/golang/go/archive/go${K8S_PATCHED_GOLANG_VERSION}.tar.gz | tar -xz -C ${K8S_PATCHED_GOROOT} --strip-components=1 <ins> # We need a patched go1.7.1 for linux/arm (https://github.com/kubernetes/kubernetes/issues/29904) # We need go1.7.1 for all darwin builds (https://github.com/kubernetes/kubernetes/issues/32999) </ins> COPY golang-patches/CL28857-go1.7.1-luxas.patch ${K8S_PATCHED_GOROOT}/ RUN cd ${K8S_PATCHED_GOROOT}  && patch -p1 < CL28857-go1.7.1-luxas.patch  && cd src  && GOROOT_FINAL=${K8S_PATCHED_GOROOT} GOROOT_BOOTSTRAP=/usr/local/go ./make.bash  <del> && for platform in linux/arm; do GOOS=${platform%/*} GOARCH=${platform##*/} GOROOT=${K8S_PATCHED_GOROOT} go install std; done </del> <ins> && for platform in linux/arm darwin/386 darwin/amd64; do GOOS=${platform%/*} GOARCH=${platform##*/} GOROOT=${K8S_PATCHED_GOROOT} go install std; done </ins>", "commid": "kubernetes_pr_33803"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3bf8a64b76529daf5ef9d30b1f8b10107f0cec27bd9639b72947be09713adaf4", "query": "See\nCI has built and uploaded unofficial prerelease darwin binaries for 1.4 using go1.7.1: cc Official binaries will ship as soon as we cut 1.4.1.\nWe have official v1.4.1 binaries available now, too.\nHooray", "positive_passages": [{"docid": "doc-en-kubernetes-f90d092e8898bb6ab708e74f476ac00fff59c5eb0d1f98823e935c618b4fd572", "text": "<del> v1.6.3-7 </del> <ins> v1.6.3-8 </ins>", "commid": "kubernetes_pr_33803"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3bf8a64b76529daf5ef9d30b1f8b10107f0cec27bd9639b72947be09713adaf4", "query": "See\nCI has built and uploaded unofficial prerelease darwin binaries for 1.4 using go1.7.1: cc Official binaries will ship as soon as we cut 1.4.1.\nWe have official v1.4.1 binaries available now, too.\nHooray", "positive_passages": [{"docid": "doc-en-kubernetes-ce9fe7343dfe52de71b0da108f81dc55cb1baa10cdfaafd5f03348b8b077a888", "text": "if [[ ${platform} == \"linux/arm\" ]]; then export CGO_ENABLED=1 export CC=arm-linux-gnueabi-gcc <ins> # See https://github.com/kubernetes/kubernetes/issues/29904 </ins> export GOROOT=${K8S_PATCHED_GOROOT} elif [[ ${platform} == \"linux/arm64\" ]]; then export CGO_ENABLED=1", "commid": "kubernetes_pr_33803"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3bf8a64b76529daf5ef9d30b1f8b10107f0cec27bd9639b72947be09713adaf4", "query": "See\nCI has built and uploaded unofficial prerelease darwin binaries for 1.4 using go1.7.1: cc Official binaries will ship as soon as we cut 1.4.1.\nWe have official v1.4.1 binaries available now, too.\nHooray", "positive_passages": [{"docid": "doc-en-kubernetes-eead7ff778238e376af51b20160a78431c2c191a6bb6e41fad32640712ed95ee", "text": "elif [[ ${platform} == \"linux/ppc64le\" ]]; then export CGO_ENABLED=1 export CC=powerpc64le-linux-gnu-gcc <ins> elif [[ ${platform} == \"darwin/\"* ]]; then # See https://github.com/kubernetes/kubernetes/issues/32999 export GOROOT=${K8S_PATCHED_GOROOT} </ins> fi fi }", "commid": "kubernetes_pr_33803"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3bf8a64b76529daf5ef9d30b1f8b10107f0cec27bd9639b72947be09713adaf4", "query": "See\nCI has built and uploaded unofficial prerelease darwin binaries for 1.4 using go1.7.1: cc Official binaries will ship as soon as we cut 1.4.1.\nWe have official v1.4.1 binaries available now, too.\nHooray", "positive_passages": [{"docid": "doc-en-kubernetes-9fe93ec340d941191bad7e64e1e623bc30cb214b725e2645b9d4a0ca77ab051f", "text": "RUN mkdir -p ${K8S_PATCHED_GOROOT}  && curl -sSL https://github.com/golang/go/archive/go${K8S_PATCHED_GOLANG_VERSION}.tar.gz | tar -xz -C ${K8S_PATCHED_GOROOT} --strip-components=1 <ins> # We need a patched go1.7.1 for linux/arm (https://github.com/kubernetes/kubernetes/issues/29904) # We need go1.7.1 for all darwin builds (https://github.com/kubernetes/kubernetes/issues/32999) </ins> COPY golang-patches/CL28857-go1.7.1-luxas.patch ${K8S_PATCHED_GOROOT}/ RUN cd ${K8S_PATCHED_GOROOT}  && patch -p1 < CL28857-go1.7.1-luxas.patch  && cd src  && GOROOT_FINAL=${K8S_PATCHED_GOROOT} GOROOT_BOOTSTRAP=/usr/local/go ./make.bash  <del> && for platform in linux/arm; do GOOS=${platform%/*} GOARCH=${platform##*/} GOROOT=${K8S_PATCHED_GOROOT} go install std; done </del> <ins> && for platform in linux/arm darwin/386 darwin/amd64; do GOOS=${platform%/*} GOARCH=${platform##*/} GOROOT=${K8S_PATCHED_GOROOT} go install std; done </ins>", "commid": "kubernetes_pr_33857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3bf8a64b76529daf5ef9d30b1f8b10107f0cec27bd9639b72947be09713adaf4", "query": "See\nCI has built and uploaded unofficial prerelease darwin binaries for 1.4 using go1.7.1: cc Official binaries will ship as soon as we cut 1.4.1.\nWe have official v1.4.1 binaries available now, too.\nHooray", "positive_passages": [{"docid": "doc-en-kubernetes-f90d092e8898bb6ab708e74f476ac00fff59c5eb0d1f98823e935c618b4fd572", "text": "<del> v1.6.3-7 </del> <ins> v1.6.3-8 </ins>", "commid": "kubernetes_pr_33857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3bf8a64b76529daf5ef9d30b1f8b10107f0cec27bd9639b72947be09713adaf4", "query": "See\nCI has built and uploaded unofficial prerelease darwin binaries for 1.4 using go1.7.1: cc Official binaries will ship as soon as we cut 1.4.1.\nWe have official v1.4.1 binaries available now, too.\nHooray", "positive_passages": [{"docid": "doc-en-kubernetes-ce9fe7343dfe52de71b0da108f81dc55cb1baa10cdfaafd5f03348b8b077a888", "text": "if [[ ${platform} == \"linux/arm\" ]]; then export CGO_ENABLED=1 export CC=arm-linux-gnueabi-gcc <ins> # See https://github.com/kubernetes/kubernetes/issues/29904 </ins> export GOROOT=${K8S_PATCHED_GOROOT} elif [[ ${platform} == \"linux/arm64\" ]]; then export CGO_ENABLED=1", "commid": "kubernetes_pr_33857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3bf8a64b76529daf5ef9d30b1f8b10107f0cec27bd9639b72947be09713adaf4", "query": "See\nCI has built and uploaded unofficial prerelease darwin binaries for 1.4 using go1.7.1: cc Official binaries will ship as soon as we cut 1.4.1.\nWe have official v1.4.1 binaries available now, too.\nHooray", "positive_passages": [{"docid": "doc-en-kubernetes-eead7ff778238e376af51b20160a78431c2c191a6bb6e41fad32640712ed95ee", "text": "elif [[ ${platform} == \"linux/ppc64le\" ]]; then export CGO_ENABLED=1 export CC=powerpc64le-linux-gnu-gcc <ins> elif [[ ${platform} == \"darwin/\"* ]]; then # See https://github.com/kubernetes/kubernetes/issues/32999 export GOROOT=${K8S_PATCHED_GOROOT} </ins> fi fi }", "commid": "kubernetes_pr_33857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0ffb29d4daaa35c38b9d541a819bedf43b16ac7b00fde22f3ce7ab4095070468", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see ): No What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): watch leak Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): 0 Environment: Cloud provider or hardware configuration: vagrant on Mac OS X OS (e.g. from /etc/os-release): CoreOS 1164.1.0 Kernel (e.g. ): Install tools: Others: What happened: We ran controller which handles our own ThirdPartyResource. When we hit \"watch of ... ended with: 401: The event in requested index is outdated and cleared (the requested history has been cleared\" error, \"forcing resync\" log is duplicated. This log message comes from . It looks like this goroutine does not exit when we hit the above mentioned error, and continued to work, and running \"resync\" more frequently. What you expected to happen: The resync goroutine must be terminated when watch is closed (i.e., ListAndWatch function returned), instead of leaking it. How to reproduce it (as minimally and precisely as possible): I just run our controller for ~15 minutes. I'm not sure why \"401: The event in requested index is outdated and cleared (the requested history has been cleared\" happens, but from the issues I read, it should be harmless. Anything else do we need to know:\nI think I see what is going on here. If exits for any reason beyond an error from the resync loop no one will tell the resync loop to exit. Furthermore, there is no \"local\" way to do this as it would be unexpected for this function to signal the Done channel as other things outside of it may be relying on it. There are some useful functions around Context () that help to create a \"local\" copy of context that can be used in this situation.\nThank you for reply. Isn't is possible to create local channel in ListAndWatch, and defer close it, and then make resync goroutine \"select\" it too?\nThis issue was labelled as component/kubectl, but actually it is not limited to kubectl. All controllers suffer from this. Only people notice this if they enable V(4) logging.\nThe really annoying thing caused by this issue is that eventually resync is done in every few seconds due to the leaked goroutine. Even if you set 30 second resync period in controller, leaked goroutines call resync too, and you end up having resync call very very frequently. If you have many resources in cache, it really performs unnecessary sync loop. This is the last thing you want.\nthis looks like a real issue. Could be related to Could you help triage? looks like a proper fix.\nI agree - this looks like a real issue. And indeed LGTM as a fix for it.", "positive_passages": [{"docid": "doc-en-kubernetes-cbb040239283ea18cf9ab32b1e75f90a0ccf38643fe4174cf3b1b2b63923c342", "text": "r.setLastSyncResourceVersion(resourceVersion) resyncerrc := make(chan error, 1) <ins> cancelCh := make(chan struct{}) defer close(cancelCh) </ins> go func() { for { select { case <-resyncCh: case <-stopCh: return <ins> case <-cancelCh: return </ins> } glog.V(4).Infof(\"%s: forcing resync\", r.name) if err := r.store.Resync(); err != nil {", "commid": "kubernetes_pr_35672"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b2b1ba02a39aa9fbaa88beb20cf1c8940383414c25aeab377ce9dd6ee22ca14", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Master Environment: Cloud provider or hardware configuration: OpenStack OS (e.g. from /etc/os-release): n/a Kernel (e.g. ): n/a Install tools: n/a Others: What happened: now can update a LB instead of deleting it and recreating it. However the security group code is still set to try and create security group rules, and if it gets an error, delete the LB and start over. What you expected to happen: Updating a service does not delete the LBaaS LB How to reproduce it (as minimally and precisely as possible): Enable in the section of Restart a Anything else do we need to know:\nyou're absolutely right, this is a critical issue (if you enable security group management). The dangerousness of aggressive cleanups has already been discussed in detail in this thread: I hope you guys can fix this.\nYup - I have a larger refactor, that ensures this, and a few other edge cases we have found in our development. It is in massive need of a rebase though, so I will need a day or 2 of uninterrupted time to get it together\nAre you still working on this? If not, I can take a look.\nping :)\n/close\nWe just ran into this where Kubernetes recreated an LB with a new Floating IP because the OpenStack API was not available for a few seconds while the LB was updated. Could this issue be re-opened? Since this is a major bug for us, we will start working on a fix for this today.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-a40452c6f08ae9945d88ea6b40869c5f5b825492a2168c1f231ebaf2e7a3dcf7", "text": "if lbaas.opts.ManageSecurityGroups { err := lbaas.ensureSecurityGroup(clusterName, apiService, nodes, loadbalancer) if err != nil { <del> // cleanup what was created so far _ = lbaas.EnsureLoadBalancerDeleted(ctx, clusterName, apiService) return status, err </del> <ins> return status, fmt.Errorf(\"Error reconciling security groups for LB service %v/%v: %v\", apiService.Namespace, apiService.Name, err) </ins> } }", "commid": "kubernetes_pr_82264"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-74852d535c90953c7828dd3da78bb675b08619f3530bd58221027eebcf627233", "query": "PetSets currently support an annotation in their PodTemplateSpec field. From the user documentation: Debugging: If one want to bring up the pets in my petset one after the other, while pausing after each step, confirming that the state is as expected, one may use this functionality. For example, a petset where each pet is a replica of a distributed database; we set the to in the petset template initially. This leads to the following progression: PetSetController creates pet-0 Manually intervene and check that it has initialized as expected. Set annotation to true (equivalent to marking that pet as healthy) PetSetController creates pet-1 Manually intervene and check that it has initialized as expected. ... Blocking the PetSet controller: We may want to ensure that the petset controller is not performing scale operations when a different user-initiated action is in progress (for example, where pets are leaving due to a kubectl drain). This may be used as a mechanism to orphan a pod from a petset controller (for a closer look), while ensuring that a replacement is not created. The use case 1 above can be realized using and is probably easier to do that way rather than use the annotation. I don't see a reason to have that case supported when we can have users scale up a PetSet gradually and manually in an identical manner. It may have been of more importance before v1.4 when the scaler & reaper were not implemented. Due to the second use-case, if it would make sense to continue to have this ability, I propose that we move it from the PodTemplateSpec to the PetSetSpec, where it will eventually reside. This seems to me, like the logical place for such a debug hook to reside. In order to run/pause the scaling operations of the PetSet controller, we could have annotations along the lines of with the annotation defaulting to when absent. /cc\nShould we just support Pause on PetSet (for part of these cases)?\nDo users have to catch the roll out at the right time in order for this to work? For example if I want to pause between nodes 2 and 3 coming up, do I need to be precise in my timing when editing the resource? How does this look from the users perspective?\nNote that Pause allows scaling in Deployments, it just blocks upgrades. That being said, I think Pause will be useful for PetSets in general. Not sure though if we can use it somehow for this specific issue.\nI like the debugging hook for PetSets. If it's optional I don't see any reason to get rid of it.\npauses petset controller if necessary and inspects the state of the system_ With the previous flow, the petset controller was paused after each pet's creation automatically, and here it would be an extra step to pause the controller it if necessary. I don't know how important it is though, but to me it seems easier to understand than a per-pod annotation.\nand I had several discussions with the lifecycle of what would be useful. There are a bunch of use cases that overlap: not a primary concern for most users but helpful (prevent changes) - very important if you are triaging failures. Technically scaling is itself a user action, so if you don't want your pet set autoscaled while triaging failures you need to take action on the HPA like deployments. Since PetSets and ReplicaSets are nothing alike w.r.t. scaling I'm not terribly concerned that pause means slightly different things if for end users it Does The Right Thing control by a third party controller - this is the babysitter controller wanting to reuse the petset controller for core stuff but still have the hook angle. Not thought through enough to design around.\nNote that Pause does not prevent scaling in Deployments, only upgrades , Clayton Coleman wrote:\nJust to summarize: The current behavior with the annotation It is set on a per-pet basis. Setting it to false on any single pod blocks all operations on the petset; scaling, creation of new pets, etc. All pets must contain the annotation, and have its value set to true in order to make progress. By default, it is set to false and makes the petset controller pause after creating one pet. The smallest change we can make for beta: Rename it to (or some better name) Make it optional (with the absence of the annotation meaning that the petset can scale) Surface the reason better when we block on scaling because of the annotation. I still think there is value in moving it to be an annotation on the PetSet resource, rather than having it be in each pod, which is confusing to users. wdyt?\nPutting it on the pod template is clever, but surprising. How many examples are dependent on it? , Anirudh Ramanathan < :\nLast I checked, all the examples had set to true. We should just get rid of it from all examples in my opinion. If we make the default (or the absence of any such annotation) to mean that the petset controller can make progress, we can safely do that. was going to do a pass over the examples after the PetSet renaming. This could be an additional step. Does that sound ok?\nIf it's not found, we assume you want to pause. You're proposing that if it's not found, we default to \"forge ahead\". SG. It should only be used in debugging/testing today. Basically if you don't know how to write your , you'd create a petset with it set, kubectl exec and write it out, scale the petset by 1, kubectl exec ..., and when you have a working cluster, put what you did in an init container and create the petset without it. This is the absolute min. You're also proposing that we move it to the petset. This makes sense overall, but I initially didn't do that because I didn't know how we would end up doing pause.\nWe could leave it there as \"alpha\" and then remove it in 1.6 once we have more time to talk about how upgrades and debugging and pause should work? , Prashanth B wrote:\nYeah the minimum work is to flip the behavior of the controller when the annotation is not found:\nAgree on flipping behavior. , Prashanth B wrote:\nFlipping SGTM. are you suggesting we leave the annotation-name as it is, and don't change it to ? If we are changing it, we should probably change the name from as well, since it doesn't make as much sense anymore. Probably ?\nor healthy rather.\nFlipping default behavior (when not present). Or did I misunderstand beeps proposal? On Oct 27, 2016, at 7:11 PM, Anirudh Ramanathan wrote: Flipping SGTM. are you suggesting we leave the annotation-name as it is, and don't change it to ? If we are changing it, we should probably change the name from initialized as well, since it doesn't make as much sense anymore. Probably unhealthy? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nRenaming it to beta is effectively moving it to beta, so I think given that we're still confused about how this ties in to the big picture, that might be premature. If it's either move to beta or drop, I'd probably vote for drop, it's a debug hook after all. Renaming it to something else but keeping in beta makes sense.\nsorry, keeping in alpha\nwhats going on with this tag? it's used in the docs here should i use it going forward?\nIt's alpha and may be removed at any time. On Nov 2, 2016, at 3:11 PM, Zachary Adam Kaplan wrote: whats going on with this tag? it's used in the docs here should i use it going forward? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .", "positive_passages": [{"docid": "doc-en-kubernetes-c2e867ad64f8ea88eaaf5bc87d2784c55deff17a8b30952afe68375105853914", "text": "// It doesn't update, probe or get the pod. type defaultPetHealthChecker struct{} <del> // isHealthy returns true if the pod is running and has the // \"pod.alpha.kubernetes.io/initialized\" set to \"true\". </del> <ins> // isHealthy returns true if the pod is ready & running. If the pod has the // \"pod.alpha.kubernetes.io/initialized\" annotation set to \"false\", pod state is ignored. </ins> func (d *defaultPetHealthChecker) isHealthy(pod *api.Pod) bool { if pod == nil || pod.Status.Phase != api.PodRunning { return false } <ins> podReady := api.IsPodReady(pod) // User may have specified a pod readiness override through a debug annotation. </ins> initialized, ok := pod.Annotations[StatefulSetInitAnnotation] <del> if !ok { glog.Infof(\"StatefulSet pod %v in %v, waiting on annotation %v\", api.PodRunning, pod.Name, StatefulSetInitAnnotation) return false } b, err := strconv.ParseBool(initialized) if err != nil { return false </del> <ins> if ok { if initAnnotation, err := strconv.ParseBool(initialized); err != nil { glog.Infof(\"Failed to parse %v annotation on pod %v: %v\", StatefulSetInitAnnotation, pod.Name, err) } else if !initAnnotation { glog.Infof(\"StatefulSet pod %v waiting on annotation %v\", pod.Name, StatefulSetInitAnnotation) podReady = initAnnotation } </ins> } <del> return b && api.IsPodReady(pod) </del> <ins> return podReady </ins> } // isDying returns true if the pod has a non-nil deletion timestamp. Since the", "commid": "kubernetes_pr_35739"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-74852d535c90953c7828dd3da78bb675b08619f3530bd58221027eebcf627233", "query": "PetSets currently support an annotation in their PodTemplateSpec field. From the user documentation: Debugging: If one want to bring up the pets in my petset one after the other, while pausing after each step, confirming that the state is as expected, one may use this functionality. For example, a petset where each pet is a replica of a distributed database; we set the to in the petset template initially. This leads to the following progression: PetSetController creates pet-0 Manually intervene and check that it has initialized as expected. Set annotation to true (equivalent to marking that pet as healthy) PetSetController creates pet-1 Manually intervene and check that it has initialized as expected. ... Blocking the PetSet controller: We may want to ensure that the petset controller is not performing scale operations when a different user-initiated action is in progress (for example, where pets are leaving due to a kubectl drain). This may be used as a mechanism to orphan a pod from a petset controller (for a closer look), while ensuring that a replacement is not created. The use case 1 above can be realized using and is probably easier to do that way rather than use the annotation. I don't see a reason to have that case supported when we can have users scale up a PetSet gradually and manually in an identical manner. It may have been of more importance before v1.4 when the scaler & reaper were not implemented. Due to the second use-case, if it would make sense to continue to have this ability, I propose that we move it from the PodTemplateSpec to the PetSetSpec, where it will eventually reside. This seems to me, like the logical place for such a debug hook to reside. In order to run/pause the scaling operations of the PetSet controller, we could have annotations along the lines of with the annotation defaulting to when absent. /cc\nShould we just support Pause on PetSet (for part of these cases)?\nDo users have to catch the roll out at the right time in order for this to work? For example if I want to pause between nodes 2 and 3 coming up, do I need to be precise in my timing when editing the resource? How does this look from the users perspective?\nNote that Pause allows scaling in Deployments, it just blocks upgrades. That being said, I think Pause will be useful for PetSets in general. Not sure though if we can use it somehow for this specific issue.\nI like the debugging hook for PetSets. If it's optional I don't see any reason to get rid of it.\npauses petset controller if necessary and inspects the state of the system_ With the previous flow, the petset controller was paused after each pet's creation automatically, and here it would be an extra step to pause the controller it if necessary. I don't know how important it is though, but to me it seems easier to understand than a per-pod annotation.\nand I had several discussions with the lifecycle of what would be useful. There are a bunch of use cases that overlap: not a primary concern for most users but helpful (prevent changes) - very important if you are triaging failures. Technically scaling is itself a user action, so if you don't want your pet set autoscaled while triaging failures you need to take action on the HPA like deployments. Since PetSets and ReplicaSets are nothing alike w.r.t. scaling I'm not terribly concerned that pause means slightly different things if for end users it Does The Right Thing control by a third party controller - this is the babysitter controller wanting to reuse the petset controller for core stuff but still have the hook angle. Not thought through enough to design around.\nNote that Pause does not prevent scaling in Deployments, only upgrades , Clayton Coleman wrote:\nJust to summarize: The current behavior with the annotation It is set on a per-pet basis. Setting it to false on any single pod blocks all operations on the petset; scaling, creation of new pets, etc. All pets must contain the annotation, and have its value set to true in order to make progress. By default, it is set to false and makes the petset controller pause after creating one pet. The smallest change we can make for beta: Rename it to (or some better name) Make it optional (with the absence of the annotation meaning that the petset can scale) Surface the reason better when we block on scaling because of the annotation. I still think there is value in moving it to be an annotation on the PetSet resource, rather than having it be in each pod, which is confusing to users. wdyt?\nPutting it on the pod template is clever, but surprising. How many examples are dependent on it? , Anirudh Ramanathan < :\nLast I checked, all the examples had set to true. We should just get rid of it from all examples in my opinion. If we make the default (or the absence of any such annotation) to mean that the petset controller can make progress, we can safely do that. was going to do a pass over the examples after the PetSet renaming. This could be an additional step. Does that sound ok?\nIf it's not found, we assume you want to pause. You're proposing that if it's not found, we default to \"forge ahead\". SG. It should only be used in debugging/testing today. Basically if you don't know how to write your , you'd create a petset with it set, kubectl exec and write it out, scale the petset by 1, kubectl exec ..., and when you have a working cluster, put what you did in an init container and create the petset without it. This is the absolute min. You're also proposing that we move it to the petset. This makes sense overall, but I initially didn't do that because I didn't know how we would end up doing pause.\nWe could leave it there as \"alpha\" and then remove it in 1.6 once we have more time to talk about how upgrades and debugging and pause should work? , Prashanth B wrote:\nYeah the minimum work is to flip the behavior of the controller when the annotation is not found:\nAgree on flipping behavior. , Prashanth B wrote:\nFlipping SGTM. are you suggesting we leave the annotation-name as it is, and don't change it to ? If we are changing it, we should probably change the name from as well, since it doesn't make as much sense anymore. Probably ?\nor healthy rather.\nFlipping default behavior (when not present). Or did I misunderstand beeps proposal? On Oct 27, 2016, at 7:11 PM, Anirudh Ramanathan wrote: Flipping SGTM. are you suggesting we leave the annotation-name as it is, and don't change it to ? If we are changing it, we should probably change the name from initialized as well, since it doesn't make as much sense anymore. Probably unhealthy? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .\nRenaming it to beta is effectively moving it to beta, so I think given that we're still confused about how this ties in to the big picture, that might be premature. If it's either move to beta or drop, I'd probably vote for drop, it's a debug hook after all. Renaming it to something else but keeping in beta makes sense.\nsorry, keeping in alpha\nwhats going on with this tag? it's used in the docs here should i use it going forward?\nIt's alpha and may be removed at any time. On Nov 2, 2016, at 3:11 PM, Zachary Adam Kaplan wrote: whats going on with this tag? it's used in the docs here should i use it going forward? \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .", "positive_passages": [{"docid": "doc-en-kubernetes-de363bcb06f8592aeac5873ab4b315bfdd46ba2c2d044e675df112fb6933d697", "text": "ObjectMeta: api.ObjectMeta{ Name:      name, Namespace: ns, <ins> Annotations: map[string]string{ \"pod.alpha.kubernetes.io/initialized\": \"false\", }, </ins> }, Spec: apps.StatefulSetSpec{ Selector: &unversioned.LabelSelector{", "commid": "kubernetes_pr_35739"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1da508198b088dbae572d4bdb1fc451b5b409cd873c7dd20d27fd3a66f833b82", "query": "Kubernetes version (use ): HEAD Environment: GCE What happened: When I set up I can see the following message: What you expected to happen: master should not be registered\ncc\nLooks like the env var isn't being respected any longer by the master scripts (but the logic for # of expected nodes did adjust correctly).\n/cc I think this may have broken in because it which unconditionally sets the field that tells a kubelet to register with the master outside of the guard that checks .\nFix in progress: . There was a problem caused by unconditional setting on the master in .", "positive_passages": [{"docid": "doc-en-kubernetes-f9c6da0c05897cef87a31e1bff94acdb9b1bbedf46bb11295a486585d1c6fbb4", "text": "create-static-ip \"${MASTER_NAME}-ip\" \"${REGION}\" MASTER_RESERVED_IP=$(gcloud compute addresses describe \"${MASTER_NAME}-ip\"  --project \"${PROJECT}\" --region \"${REGION}\" -q --format='value(address)') <del> KUBELET_APISERVER=\"${MASTER_RESERVED_IP}\" </del> <ins> if [[ \"${REGISTER_MASTER_KUBELET:-}\" == \"true\" ]]; then KUBELET_APISERVER=\"${MASTER_RESERVED_IP}\" fi </ins> KUBERNETES_MASTER_NAME=\"${MASTER_RESERVED_IP}\" create-certs \"${MASTER_RESERVED_IP}\"", "commid": "kubernetes_pr_36214"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b27fd4ba8111ba6c27ce4b735921cc2de35b4fc130a5d3c5eb23c08df1ca0eaa", "query": "From . During the firewall e2e test we need to change the service type from to to avoid leaking LB resources. But found it is not working because the field. Error I got as below: If don't delete this field, got instead another error:\nJust saw the TODO comment . Working on it.", "positive_passages": [{"docid": "doc-en-kubernetes-50b9a7c370d3eb3f366f87e457218a29328ef302afbedabe46215d34cd1d2ece", "text": "} // TODO(freehan): allow user to update loadbalancerSourceRanges <del> allErrs = append(allErrs, ValidateImmutableField(service.Spec.LoadBalancerSourceRanges, oldService.Spec.LoadBalancerSourceRanges, field.NewPath(\"spec\", \"loadBalancerSourceRanges\"))...) </del> <ins> // Only allow removing LoadBalancerSourceRanges when change service type from LoadBalancer // to non-LoadBalancer or adding LoadBalancerSourceRanges when change service type from // non-LoadBalancer to LoadBalancer. if service.Spec.Type != api.ServiceTypeLoadBalancer && oldService.Spec.Type != api.ServiceTypeLoadBalancer || service.Spec.Type == api.ServiceTypeLoadBalancer && oldService.Spec.Type == api.ServiceTypeLoadBalancer { allErrs = append(allErrs, ValidateImmutableField(service.Spec.LoadBalancerSourceRanges, oldService.Spec.LoadBalancerSourceRanges, field.NewPath(\"spec\", \"loadBalancerSourceRanges\"))...) } </ins> allErrs = append(allErrs, validateServiceFields(service)...) allErrs = append(allErrs, validateServiceAnnotations(service, oldService)...)", "commid": "kubernetes_pr_36788"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-76ed5d73de657ebb40cede01a073f7c23ca75b99af70ac9c6718b17c4fe55f7b", "query": "The logic to account for all pods being ready is incorrectly counting some pods as being controlled by a replication controller. This is causing the 1.3-1.5 upgrade tests to fail. See https://k8s- as an example. Since , the pre-flight checks fail and the rest of the tests never run. I think this was exposed by which changed some things from ReplicationControllers to Deployments. There's a pod being created by a deployment that also matches the selector of a replication controller, and is therefore being incorrectly counted by cc", "positive_passages": [{"docid": "doc-en-kubernetes-5bfe1d64d0b7c4102ab796f2658b1627731f5d5917fe593f94edf99ca37abbdf", "text": "return errStr + buf.String() } <del> // check if a Pod is controlled by a Replication Controller in the List func hasReplicationControllersForPod(rcs *api.ReplicationControllerList, pod api.Pod) bool { for _, rc := range rcs.Items { selector := labels.SelectorFromSet(rc.Spec.Selector) if selector.Matches(labels.Set(pod.ObjectMeta.Labels)) { return true } } return false } </del> // WaitForPodsSuccess waits till all labels matching the given selector enter // the Success state. The caller is expected to only invoke this method once the // pods have been created.", "commid": "kubernetes_pr_36924"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-76ed5d73de657ebb40cede01a073f7c23ca75b99af70ac9c6718b17c4fe55f7b", "query": "The logic to account for all pods being ready is incorrectly counting some pods as being controlled by a replication controller. This is causing the 1.3-1.5 upgrade tests to fail. See https://k8s- as an example. Since , the pre-flight checks fail and the rest of the tests never run. I think this was exposed by which changed some things from ReplicationControllers to Deployments. There's a pod being created by a deployment that also matches the selector of a replication controller, and is therefore being incorrectly counted by cc", "positive_passages": [{"docid": "doc-en-kubernetes-726563985792d604f7ead873d180d4375bfe5d2848ea0bb96840b774a7560980", "text": "// WaitForPodsRunningReady waits up to timeout to ensure that all pods in // namespace ns are either running and ready, or failed but controlled by a <del> // replication controller. Also, it ensures that at least minPods are running // and ready. It has separate behavior from other 'wait for' pods functions in // that it requires the list of pods on every iteration. This is useful, for </del> <ins> // controller. Also, it ensures that at least minPods are running and // ready. It has separate behavior from other 'wait for' pods functions in // that it requests the list of pods on every iteration. This is useful, for </ins> // example, in cluster startup, because the number of pods increases while // waiting. // If ignoreLabels is not empty, pods matching this selector are ignored and", "commid": "kubernetes_pr_36924"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-76ed5d73de657ebb40cede01a073f7c23ca75b99af70ac9c6718b17c4fe55f7b", "query": "The logic to account for all pods being ready is incorrectly counting some pods as being controlled by a replication controller. This is causing the 1.3-1.5 upgrade tests to fail. See https://k8s- as an example. Since , the pre-flight checks fail and the rest of the tests never run. I think this was exposed by which changed some things from ReplicationControllers to Deployments. There's a pod being created by a deployment that also matches the selector of a replication controller, and is therefore being incorrectly counted by cc", "positive_passages": [{"docid": "doc-en-kubernetes-c8d6b7fdbf4360f9b76daf9ea0ccb6840d763ce0c63c1b1c723783bcc4f1f9a1", "text": "}() if wait.PollImmediate(Poll, timeout, func() (bool, error) { <del> // We get the new list of pods and replication controllers in every // iteration because more pods come online during startup and we want to // ensure they are also checked. </del> <ins> // We get the new list of pods, replication controllers, and // replica sets in every iteration because more pods come // online during startup and we want to ensure they are also // checked. replicas, replicaOk := int32(0), int32(0) </ins> rcList, err := c.Core().ReplicationControllers(ns).List(api.ListOptions{}) if err != nil { Logf(\"Error getting replication controllers in namespace '%s': %v\", ns, err) return false, nil } <del> replicas := int32(0) </del> for _, rc := range rcList.Items { replicas += rc.Spec.Replicas <ins> replicaOk += rc.Status.ReadyReplicas } rsList, err := c.Extensions().ReplicaSets(ns).List(api.ListOptions{}) if err != nil { Logf(\"Error getting replication sets in namespace %q: %v\", ns, err) return false, nil } for _, rs := range rsList.Items { replicas += rs.Spec.Replicas replicaOk += rs.Status.ReadyReplicas </ins> } podList, err := c.Core().Pods(ns).List(api.ListOptions{})", "commid": "kubernetes_pr_36924"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-76ed5d73de657ebb40cede01a073f7c23ca75b99af70ac9c6718b17c4fe55f7b", "query": "The logic to account for all pods being ready is incorrectly counting some pods as being controlled by a replication controller. This is causing the 1.3-1.5 upgrade tests to fail. See https://k8s- as an example. Since , the pre-flight checks fail and the rest of the tests never run. I think this was exposed by which changed some things from ReplicationControllers to Deployments. There's a pod being created by a deployment that also matches the selector of a replication controller, and is therefore being incorrectly counted by cc", "positive_passages": [{"docid": "doc-en-kubernetes-0825a0dd692c079d1da03223ad7d08de5e2c932913ab63308109fdca310c3b15", "text": "Logf(\"Error getting pods in namespace '%s': %v\", ns, err) return false, nil } <del> nOk, replicaOk := int32(0), int32(0) </del> <ins> nOk := int32(0) </ins> badPods = []api.Pod{} desiredPods = len(podList.Items) for _, pod := range podList.Items {", "commid": "kubernetes_pr_36924"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-76ed5d73de657ebb40cede01a073f7c23ca75b99af70ac9c6718b17c4fe55f7b", "query": "The logic to account for all pods being ready is incorrectly counting some pods as being controlled by a replication controller. This is causing the 1.3-1.5 upgrade tests to fail. See https://k8s- as an example. Since , the pre-flight checks fail and the rest of the tests never run. I think this was exposed by which changed some things from ReplicationControllers to Deployments. There's a pod being created by a deployment that also matches the selector of a replication controller, and is therefore being incorrectly counted by cc", "positive_passages": [{"docid": "doc-en-kubernetes-d7e752deaabeb7eff68cce3162a076c64474ef9475e2effbcac8d0307bcaf698", "text": "} if res, err := testutils.PodRunningReady(&pod); res && err == nil { nOk++ <del> if hasReplicationControllersForPod(rcList, pod) { replicaOk++ } </del> } else { if pod.Status.Phase != api.PodFailed { Logf(\"The status of Pod %s is %s (Ready = false), waiting for it to be either Running (with Ready = true) or Failed\", pod.ObjectMeta.Name, pod.Status.Phase) badPods = append(badPods, pod) <del> } else if !hasReplicationControllersForPod(rcList, pod) { Logf(\"Pod %s is Failed, but it's not controlled by a ReplicationController\", pod.ObjectMeta.Name) </del> <ins> } else if _, ok := pod.Annotations[api.CreatedByAnnotation]; !ok { Logf(\"Pod %s is Failed, but it's not controlled by a controller\", pod.ObjectMeta.Name) </ins> badPods = append(badPods, pod) } <del> //ignore failed pods that are controlled by a replication controller </del> <ins> //ignore failed pods that are controlled by some controller </ins> } }", "commid": "kubernetes_pr_36924"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc8e76f63a2fff5892f2350711ca71d1b72905b8cfeeb1b70f8a6d90915c5be5", "query": "Similar to this is to test the first contributor experience fails on ubuntu 16.04, docker version 1.12.3:\nGot the same error on Linux ubuntu 4.2.0-27-generic ~14.04.1-Ubuntu SMP Fri Jan 22 15:32:26 UTC 2016 x8664 x8664 x86_64 GNU/Linux Docker Client version: 1.6.2 Client API version: 1.18 Go version (client): go1.2.1 Git commit (client): OS/Arch (client): linux/amd64 Server version: 1.6.2 Server API version: 1.18 Go version (server): go1.2.1 Git commit (server): OS/Arch (server): linux/amd64\nWhat git sha of were you building from?\nI have cloned the head. I think the reason might be missing package: gccgo-4.8-aarch64-linux-gnu I'm compiling right now and update on result.\nwere you running or ? runs inside docker, so the gcc error is confusing.\nI run: sudo make release in Ubuntu VM running in VMWare workstation if that matters. Are you in kubernetes-users slack channel?\ndoes fail in the same way?\nDo you need to run , instead of just ? Can you try running the following:\nwell, if I don't do sudo docker does not work :) I need to run as root. I'll try the commands as soon as quick-release ends.\nah, gotcha. you can probably fix the docker access issue by following in the docker manual. that's probably not why it's failing, though.\nmake release still does not work :(\ncan you please run and then paste the results? ( turns up the debugging verbosity.)\nfor me: works (using your PR to fixes the gobindata dep) -local Go build- works (docker build) works if you have Docker running. does not work: on OSX did not seem to give more verbosity.\nV=4 make release did not help :(\noops, that was not the correct environment variable, sorry. I meant .\nhere we go:\nAha, I think I figured it out. Sorry for making you rebuild so many times; the issue still isn't super obvious from the logs. Basically, the bug only occurs if you don't have enough memory to do the docker builds in parallel; if that happens, you fall into this . On the parallel side of the branch, we set the platform env vars within a subshell, so each of the cross-compilation builds won't affect each other. On the non-parallel side of the branch, we don't use a subshell. Inside , there's no overrides done for . As a result, we end up incorrectly reusing the value for , , which doesn't recognize the flag being applied for the darwin build. The fix should be easy; I'll get that sent out ASAP. we probably want this fix for 1.5, since if you fall back to non-parallel crossbuilds we're doing the wrong thing.\nAck. Will keep an eye out for the fix. Please mark it as cherrypick-candidate\nThank you guys!\nI think it is almost there. Got much further in the build (4 GB of RAM). Towards the end there is a failed test that makes the build fail: This is probably a different bug, as your PR got passed the misconfigured compilation.\nFWIW, the worked on ubuntu 16.06. It did ran some tests apparently but the build succeeded.\nI just tried with and it worked fine\nsince we have a PR ready and working, can we please switch this to non-release-blocker?", "positive_passages": [{"docid": "doc-en-kubernetes-43446979b46ffe63db5b2053eff81032fd28ef8a4139cd2c6e6409992d5d9231", "text": "--env \"KUBE_FASTBUILD=${KUBE_FASTBUILD:-false}\" --env \"KUBE_BUILDER_OS=${OSTYPE:-notdetected}\" --env \"KUBE_BUILD_PPC64LE=${KUBE_BUILD_PPC64LE}\"  # TODO(IBM): remove <ins> --env \"KUBE_VERBOSE=${KUBE_VERBOSE}\" </ins> ) # If we have stdin we can run interactive.  This allows things like 'shell.sh'", "commid": "kubernetes_pr_37665"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc8e76f63a2fff5892f2350711ca71d1b72905b8cfeeb1b70f8a6d90915c5be5", "query": "Similar to this is to test the first contributor experience fails on ubuntu 16.04, docker version 1.12.3:\nGot the same error on Linux ubuntu 4.2.0-27-generic ~14.04.1-Ubuntu SMP Fri Jan 22 15:32:26 UTC 2016 x8664 x8664 x86_64 GNU/Linux Docker Client version: 1.6.2 Client API version: 1.18 Go version (client): go1.2.1 Git commit (client): OS/Arch (client): linux/amd64 Server version: 1.6.2 Server API version: 1.18 Go version (server): go1.2.1 Git commit (server): OS/Arch (server): linux/amd64\nWhat git sha of were you building from?\nI have cloned the head. I think the reason might be missing package: gccgo-4.8-aarch64-linux-gnu I'm compiling right now and update on result.\nwere you running or ? runs inside docker, so the gcc error is confusing.\nI run: sudo make release in Ubuntu VM running in VMWare workstation if that matters. Are you in kubernetes-users slack channel?\ndoes fail in the same way?\nDo you need to run , instead of just ? Can you try running the following:\nwell, if I don't do sudo docker does not work :) I need to run as root. I'll try the commands as soon as quick-release ends.\nah, gotcha. you can probably fix the docker access issue by following in the docker manual. that's probably not why it's failing, though.\nmake release still does not work :(\ncan you please run and then paste the results? ( turns up the debugging verbosity.)\nfor me: works (using your PR to fixes the gobindata dep) -local Go build- works (docker build) works if you have Docker running. does not work: on OSX did not seem to give more verbosity.\nV=4 make release did not help :(\noops, that was not the correct environment variable, sorry. I meant .\nhere we go:\nAha, I think I figured it out. Sorry for making you rebuild so many times; the issue still isn't super obvious from the logs. Basically, the bug only occurs if you don't have enough memory to do the docker builds in parallel; if that happens, you fall into this . On the parallel side of the branch, we set the platform env vars within a subshell, so each of the cross-compilation builds won't affect each other. On the non-parallel side of the branch, we don't use a subshell. Inside , there's no overrides done for . As a result, we end up incorrectly reusing the value for , , which doesn't recognize the flag being applied for the darwin build. The fix should be easy; I'll get that sent out ASAP. we probably want this fix for 1.5, since if you fall back to non-parallel crossbuilds we're doing the wrong thing.\nAck. Will keep an eye out for the fix. Please mark it as cherrypick-candidate\nThank you guys!\nI think it is almost there. Got much further in the build (4 GB of RAM). Towards the end there is a failed test that makes the build fail: This is probably a different bug, as your PR got passed the misconfigured compilation.\nFWIW, the worked on ubuntu 16.06. It did ran some tests apparently but the build succeeded.\nI just tried with and it worked fine\nsince we have a PR ready and working, can we please switch this to non-release-blocker?", "positive_passages": [{"docid": "doc-en-kubernetes-e7771e99215c122bd960731283c2e0a1f4c2b6dc0e12358a0a7e5dca3b25558c", "text": "[[ -n ${1-} ]] || { kube::log::error_exit \"!!! Internal error. No platform set in kube::golang::set_platform_envs\" } <ins> # make sure we have a clean slate first kube::golang::unset_platform_envs </ins> export GOOS=${platform%/*} export GOARCH=${platform##*/}", "commid": "kubernetes_pr_37665"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc8e76f63a2fff5892f2350711ca71d1b72905b8cfeeb1b70f8a6d90915c5be5", "query": "Similar to this is to test the first contributor experience fails on ubuntu 16.04, docker version 1.12.3:\nGot the same error on Linux ubuntu 4.2.0-27-generic ~14.04.1-Ubuntu SMP Fri Jan 22 15:32:26 UTC 2016 x8664 x8664 x86_64 GNU/Linux Docker Client version: 1.6.2 Client API version: 1.18 Go version (client): go1.2.1 Git commit (client): OS/Arch (client): linux/amd64 Server version: 1.6.2 Server API version: 1.18 Go version (server): go1.2.1 Git commit (server): OS/Arch (server): linux/amd64\nWhat git sha of were you building from?\nI have cloned the head. I think the reason might be missing package: gccgo-4.8-aarch64-linux-gnu I'm compiling right now and update on result.\nwere you running or ? runs inside docker, so the gcc error is confusing.\nI run: sudo make release in Ubuntu VM running in VMWare workstation if that matters. Are you in kubernetes-users slack channel?\ndoes fail in the same way?\nDo you need to run , instead of just ? Can you try running the following:\nwell, if I don't do sudo docker does not work :) I need to run as root. I'll try the commands as soon as quick-release ends.\nah, gotcha. you can probably fix the docker access issue by following in the docker manual. that's probably not why it's failing, though.\nmake release still does not work :(\ncan you please run and then paste the results? ( turns up the debugging verbosity.)\nfor me: works (using your PR to fixes the gobindata dep) -local Go build- works (docker build) works if you have Docker running. does not work: on OSX did not seem to give more verbosity.\nV=4 make release did not help :(\noops, that was not the correct environment variable, sorry. I meant .\nhere we go:\nAha, I think I figured it out. Sorry for making you rebuild so many times; the issue still isn't super obvious from the logs. Basically, the bug only occurs if you don't have enough memory to do the docker builds in parallel; if that happens, you fall into this . On the parallel side of the branch, we set the platform env vars within a subshell, so each of the cross-compilation builds won't affect each other. On the non-parallel side of the branch, we don't use a subshell. Inside , there's no overrides done for . As a result, we end up incorrectly reusing the value for , , which doesn't recognize the flag being applied for the darwin build. The fix should be easy; I'll get that sent out ASAP. we probably want this fix for 1.5, since if you fall back to non-parallel crossbuilds we're doing the wrong thing.\nAck. Will keep an eye out for the fix. Please mark it as cherrypick-candidate\nThank you guys!\nI think it is almost there. Got much further in the build (4 GB of RAM). Towards the end there is a failed test that makes the build fail: This is probably a different bug, as your PR got passed the misconfigured compilation.\nFWIW, the worked on ubuntu 16.06. It did ran some tests apparently but the build succeeded.\nI just tried with and it worked fine\nsince we have a PR ready and working, can we please switch this to non-release-blocker?", "positive_passages": [{"docid": "doc-en-kubernetes-7b680628dddfd37c4c1b079e4878b61b19523c4da5d00f14f4673048fffe4a90", "text": "local -a nonstatics=() local -a tests=() <ins> V=2 kube::log::info \"Env for ${platform}: GOOS=${GOOS-} GOARCH=${GOARCH-} GOROOT=${GOROOT-} CGO_ENABLED=${CGO_ENABLED-} CC=${CC-}\" </ins> for binary in \"${binaries[@]}\"; do if [[ \"${binary}\" =~ \".test\"$ ]]; then", "commid": "kubernetes_pr_37665"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc8e76f63a2fff5892f2350711ca71d1b72905b8cfeeb1b70f8a6d90915c5be5", "query": "Similar to this is to test the first contributor experience fails on ubuntu 16.04, docker version 1.12.3:\nGot the same error on Linux ubuntu 4.2.0-27-generic ~14.04.1-Ubuntu SMP Fri Jan 22 15:32:26 UTC 2016 x8664 x8664 x86_64 GNU/Linux Docker Client version: 1.6.2 Client API version: 1.18 Go version (client): go1.2.1 Git commit (client): OS/Arch (client): linux/amd64 Server version: 1.6.2 Server API version: 1.18 Go version (server): go1.2.1 Git commit (server): OS/Arch (server): linux/amd64\nWhat git sha of were you building from?\nI have cloned the head. I think the reason might be missing package: gccgo-4.8-aarch64-linux-gnu I'm compiling right now and update on result.\nwere you running or ? runs inside docker, so the gcc error is confusing.\nI run: sudo make release in Ubuntu VM running in VMWare workstation if that matters. Are you in kubernetes-users slack channel?\ndoes fail in the same way?\nDo you need to run , instead of just ? Can you try running the following:\nwell, if I don't do sudo docker does not work :) I need to run as root. I'll try the commands as soon as quick-release ends.\nah, gotcha. you can probably fix the docker access issue by following in the docker manual. that's probably not why it's failing, though.\nmake release still does not work :(\ncan you please run and then paste the results? ( turns up the debugging verbosity.)\nfor me: works (using your PR to fixes the gobindata dep) -local Go build- works (docker build) works if you have Docker running. does not work: on OSX did not seem to give more verbosity.\nV=4 make release did not help :(\noops, that was not the correct environment variable, sorry. I meant .\nhere we go:\nAha, I think I figured it out. Sorry for making you rebuild so many times; the issue still isn't super obvious from the logs. Basically, the bug only occurs if you don't have enough memory to do the docker builds in parallel; if that happens, you fall into this . On the parallel side of the branch, we set the platform env vars within a subshell, so each of the cross-compilation builds won't affect each other. On the non-parallel side of the branch, we don't use a subshell. Inside , there's no overrides done for . As a result, we end up incorrectly reusing the value for , , which doesn't recognize the flag being applied for the darwin build. The fix should be easy; I'll get that sent out ASAP. we probably want this fix for 1.5, since if you fall back to non-parallel crossbuilds we're doing the wrong thing.\nAck. Will keep an eye out for the fix. Please mark it as cherrypick-candidate\nThank you guys!\nI think it is almost there. Got much further in the build (4 GB of RAM). Towards the end there is a failed test that makes the build fail: This is probably a different bug, as your PR got passed the misconfigured compilation.\nFWIW, the worked on ubuntu 16.06. It did ran some tests apparently but the build succeeded.\nI just tried with and it worked fine\nsince we have a PR ready and working, can we please switch this to non-release-blocker?", "positive_passages": [{"docid": "doc-en-kubernetes-b177eebe06dd86135b814e983e3909f958ee575146038d9c886d87a31405bd6f", "text": "else for platform in \"${platforms[@]}\"; do kube::log::status \"Building go targets for ${platform}:\" \"${targets[@]}\" <del> kube::golang::set_platform_envs \"${platform}\" kube::golang::build_binaries_for_platform ${platform} ${use_go_build:-} </del> <ins> ( kube::golang::set_platform_envs \"${platform}\" kube::golang::build_binaries_for_platform ${platform} ${use_go_build:-} ) </ins> done fi )", "commid": "kubernetes_pr_37665"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc8e76f63a2fff5892f2350711ca71d1b72905b8cfeeb1b70f8a6d90915c5be5", "query": "Similar to this is to test the first contributor experience fails on ubuntu 16.04, docker version 1.12.3:\nGot the same error on Linux ubuntu 4.2.0-27-generic ~14.04.1-Ubuntu SMP Fri Jan 22 15:32:26 UTC 2016 x8664 x8664 x86_64 GNU/Linux Docker Client version: 1.6.2 Client API version: 1.18 Go version (client): go1.2.1 Git commit (client): OS/Arch (client): linux/amd64 Server version: 1.6.2 Server API version: 1.18 Go version (server): go1.2.1 Git commit (server): OS/Arch (server): linux/amd64\nWhat git sha of were you building from?\nI have cloned the head. I think the reason might be missing package: gccgo-4.8-aarch64-linux-gnu I'm compiling right now and update on result.\nwere you running or ? runs inside docker, so the gcc error is confusing.\nI run: sudo make release in Ubuntu VM running in VMWare workstation if that matters. Are you in kubernetes-users slack channel?\ndoes fail in the same way?\nDo you need to run , instead of just ? Can you try running the following:\nwell, if I don't do sudo docker does not work :) I need to run as root. I'll try the commands as soon as quick-release ends.\nah, gotcha. you can probably fix the docker access issue by following in the docker manual. that's probably not why it's failing, though.\nmake release still does not work :(\ncan you please run and then paste the results? ( turns up the debugging verbosity.)\nfor me: works (using your PR to fixes the gobindata dep) -local Go build- works (docker build) works if you have Docker running. does not work: on OSX did not seem to give more verbosity.\nV=4 make release did not help :(\noops, that was not the correct environment variable, sorry. I meant .\nhere we go:\nAha, I think I figured it out. Sorry for making you rebuild so many times; the issue still isn't super obvious from the logs. Basically, the bug only occurs if you don't have enough memory to do the docker builds in parallel; if that happens, you fall into this . On the parallel side of the branch, we set the platform env vars within a subshell, so each of the cross-compilation builds won't affect each other. On the non-parallel side of the branch, we don't use a subshell. Inside , there's no overrides done for . As a result, we end up incorrectly reusing the value for , , which doesn't recognize the flag being applied for the darwin build. The fix should be easy; I'll get that sent out ASAP. we probably want this fix for 1.5, since if you fall back to non-parallel crossbuilds we're doing the wrong thing.\nAck. Will keep an eye out for the fix. Please mark it as cherrypick-candidate\nThank you guys!\nI think it is almost there. Got much further in the build (4 GB of RAM). Towards the end there is a failed test that makes the build fail: This is probably a different bug, as your PR got passed the misconfigured compilation.\nFWIW, the worked on ubuntu 16.06. It did ran some tests apparently but the build succeeded.\nI just tried with and it worked fine\nsince we have a PR ready and working, can we please switch this to non-release-blocker?", "positive_passages": [{"docid": "doc-en-kubernetes-d46313af722cf4338965e0d95d9267df3f67b5fa39178a3c58f783ee42115a1d", "text": "[[ -n ${1-} ]] || { kube::log::error_exit \"!!! Internal error. No platform set in kube::golang::set_platform_envs\" } <del> # make sure we have a clean slate first kube::golang::unset_platform_envs </del> export GOOS=${platform%/*} export GOARCH=${platform##*/}", "commid": "kubernetes_pr_37834"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6a09cd6936e4a7af660ca32687ff8d6b61828a4fd557f0736b3765ead399feaf", "query": "On kubernetes 1.4.6 taken from releases. Using CentOS 7.2 Kubernetes worked with a 1.2 version. I just uninstalled and redo installation with 1.4.6. SELinux is disabled Everyhting seems to works (controller-manager, kubelet, and so on...) excepting kube-proxy that returns an error: \"sysfs not mounted\". API is responding (internally and externally), and I can see nodes The command that is launched by systemd is (--v=8 to get a maximum of information): But sysfs is mounted on /sys: I also tried to set /sys as writable (only to be sure, with chmod +x), and also tried to use userspace proxy mode. Note: 1.2.6 version was ok I think that the problem is that sysfs mount \"none\" as label, not \"sysfs\".\nNote: I can now confirm that the problem comes from the \"label\". I did this: Then kube-proxy successfully started.\nbefore setting . This logic was introduced in v1.3 by to workaround a known docker issue That's why \"1.2.6 version was ok\". Because sysfs is mounted as , kubeproxy couldn't find it then reported error. But why sysfs is mounted as ?\nI installed kubernetes on a \"scaleway\" (a very nice cloud provider) VPS cluster. Their VPS uses a init file that mounts fs like that. I opened an issue on their github. But anyway you may mount \"none\" for tmpfs or any ramfs, sysfs, bugfs. What I think is that the mount listing function that is used in kube-proxy code tries to list the mount \"source\" but not the \"type\". For that kind of mountpoint you can use \"none\" as source.\nthe problem is here: You should check .Type and not .Device. \"Device\" is what I named \"label\" or \"source\" because I didn't remember the name ;) Sysfs can mount a \"none\" device as type \"sysfs\", so maybe you can change. See:\nI'll do a PR\nSGTM.", "positive_passages": [{"docid": "doc-en-kubernetes-3b2f06347dca38a37fd861767405a1328262cdfaf8e7007db05fda9a664552d7", "text": "for _, mountPoint := range mountPoints { const sysfsDevice = \"sysfs\" <del> if mountPoint.Device != sysfsDevice { </del> <ins> if mountPoint.Type != sysfsDevice { </ins> continue } // Check whether sysfs is 'rw'", "commid": "kubernetes_pr_37220"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bab4044edb7a0e5617350e3d6f93b7c726f673f15e5fb436597db129dafff171", "query": "The test is failing in . https://k8s- https://k8s- https://k8s- The reason is that the test expects that all pause containers () should have . However, in many tests, we are starting test containers with . Those pause containers have . Ideally, containers started in previous test should be cleaned up, so in serial suite it should not affect later test. However, it is not always true when CRI is enabled. For example, in the oom message, we could see: There are 2 problems here: Why are containers not properly cleaned up when CRI enabled? I can't even find which test leaked pause container from the log, because there are many test using pause image, and some of them start a lot of containers, such as density test, restart test. The oom score adj test should not rely on process name . However, I can't find an alternative for now, because we don't report pause container status in our api, we don't even know the container id to inspect with docker or CRI. /cc\nThis test is still flaking in cri-serial. Some examples: https://k8s- https://k8s- Need to check the logs to see if the symptoms are the same.\nIt could be that with CRI, it takes kubelet longer to clean up. Or, even worse, that kubelet is not cleaning up properly. We need more information on this on failure. Dumping pods on the node Dumping containers () on the node. Accessing docker directly is not ideal, but it's okay because the test itself only applies to docker. Alternatively, we can get the current running containers from kubelet's /runningPods endpoint. The downside is that this may lag behind the actual state a little bit (seconds). We should also make the test suite run more frequently. It runs once a day, which makes the debugging round-trip overhead too high.\nI can reproduce this process leak by running the \"Network should recover from ip leaks\" on my own node, without CRI enabled. The image used in the test was , and the docker version 1.11.2. The test creates 100 pods, then restarts the docker service by 6 times, with 20s interval in between. After the test ends, there could be multiple processes running left on the node. Those processes were reparented to pid 1, and showed no containers running. /cc\nOn the side note, the test should not be blindly checking all processes. It should, instead, take a snapshot of the system before the test and only check the new processes created by the tests.\nI filed a new issue for the docker bug since it's not unique to CRI and this test is catching it by accident: Leaving this issue to fix the test by not blindly checking all processes:\nThe docker bug is not a regression, and is tracked in . The problem of the test is not necessarily to be fixed in v1.6, at least it's not release blocker. :)", "positive_passages": [{"docid": "doc-en-kubernetes-e9158ec3181c21699dc01cf69b474d62bce23525b2e93350a8138a642759ab6e", "text": "\"//vendor:k8s.io/apimachinery/pkg/runtime/schema\", \"//vendor:k8s.io/apimachinery/pkg/types\", \"//vendor:k8s.io/apimachinery/pkg/util/intstr\", <ins> \"//vendor:k8s.io/apimachinery/pkg/util/sets\", </ins> \"//vendor:k8s.io/apimachinery/pkg/util/uuid\", \"//vendor:k8s.io/apimachinery/pkg/watch\", \"//vendor:k8s.io/client-go/pkg/api\",", "commid": "kubernetes_pr_43248"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bab4044edb7a0e5617350e3d6f93b7c726f673f15e5fb436597db129dafff171", "query": "The test is failing in . https://k8s- https://k8s- https://k8s- The reason is that the test expects that all pause containers () should have . However, in many tests, we are starting test containers with . Those pause containers have . Ideally, containers started in previous test should be cleaned up, so in serial suite it should not affect later test. However, it is not always true when CRI is enabled. For example, in the oom message, we could see: There are 2 problems here: Why are containers not properly cleaned up when CRI enabled? I can't even find which test leaked pause container from the log, because there are many test using pause image, and some of them start a lot of containers, such as density test, restart test. The oom score adj test should not rely on process name . However, I can't find an alternative for now, because we don't report pause container status in our api, we don't even know the container id to inspect with docker or CRI. /cc\nThis test is still flaking in cri-serial. Some examples: https://k8s- https://k8s- Need to check the logs to see if the symptoms are the same.\nIt could be that with CRI, it takes kubelet longer to clean up. Or, even worse, that kubelet is not cleaning up properly. We need more information on this on failure. Dumping pods on the node Dumping containers () on the node. Accessing docker directly is not ideal, but it's okay because the test itself only applies to docker. Alternatively, we can get the current running containers from kubelet's /runningPods endpoint. The downside is that this may lag behind the actual state a little bit (seconds). We should also make the test suite run more frequently. It runs once a day, which makes the debugging round-trip overhead too high.\nI can reproduce this process leak by running the \"Network should recover from ip leaks\" on my own node, without CRI enabled. The image used in the test was , and the docker version 1.11.2. The test creates 100 pods, then restarts the docker service by 6 times, with 20s interval in between. After the test ends, there could be multiple processes running left on the node. Those processes were reparented to pid 1, and showed no containers running. /cc\nOn the side note, the test should not be blindly checking all processes. It should, instead, take a snapshot of the system before the test and only check the new processes created by the tests.\nI filed a new issue for the docker bug since it's not unique to CRI and this test is catching it by accident: Leaving this issue to fix the test by not blindly checking all processes:\nThe docker bug is not a regression, and is tracked in . The problem of the test is not necessarily to be fixed in v1.6, at least it's not release blocker. :)", "positive_passages": [{"docid": "doc-en-kubernetes-bf16839ed6bf932dcf707ddf00ab1b8d9830e927ae1673da1361e6c374ee24c5", "text": "\"k8s.io/apimachinery/pkg/api/resource\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" <ins> \"k8s.io/apimachinery/pkg/util/sets\" </ins> \"k8s.io/apimachinery/pkg/util/uuid\" \"k8s.io/kubernetes/pkg/api/v1\" \"k8s.io/kubernetes/test/e2e/framework\"", "commid": "kubernetes_pr_43248"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bab4044edb7a0e5617350e3d6f93b7c726f673f15e5fb436597db129dafff171", "query": "The test is failing in . https://k8s- https://k8s- https://k8s- The reason is that the test expects that all pause containers () should have . However, in many tests, we are starting test containers with . Those pause containers have . Ideally, containers started in previous test should be cleaned up, so in serial suite it should not affect later test. However, it is not always true when CRI is enabled. For example, in the oom message, we could see: There are 2 problems here: Why are containers not properly cleaned up when CRI enabled? I can't even find which test leaked pause container from the log, because there are many test using pause image, and some of them start a lot of containers, such as density test, restart test. The oom score adj test should not rely on process name . However, I can't find an alternative for now, because we don't report pause container status in our api, we don't even know the container id to inspect with docker or CRI. /cc\nThis test is still flaking in cri-serial. Some examples: https://k8s- https://k8s- Need to check the logs to see if the symptoms are the same.\nIt could be that with CRI, it takes kubelet longer to clean up. Or, even worse, that kubelet is not cleaning up properly. We need more information on this on failure. Dumping pods on the node Dumping containers () on the node. Accessing docker directly is not ideal, but it's okay because the test itself only applies to docker. Alternatively, we can get the current running containers from kubelet's /runningPods endpoint. The downside is that this may lag behind the actual state a little bit (seconds). We should also make the test suite run more frequently. It runs once a day, which makes the debugging round-trip overhead too high.\nI can reproduce this process leak by running the \"Network should recover from ip leaks\" on my own node, without CRI enabled. The image used in the test was , and the docker version 1.11.2. The test creates 100 pods, then restarts the docker service by 6 times, with 20s interval in between. After the test ends, there could be multiple processes running left on the node. Those processes were reparented to pid 1, and showed no containers running. /cc\nOn the side note, the test should not be blindly checking all processes. It should, instead, take a snapshot of the system before the test and only check the new processes created by the tests.\nI filed a new issue for the docker bug since it's not unique to CRI and this test is catching it by accident: Leaving this issue to fix the test by not blindly checking all processes:\nThe docker bug is not a regression, and is tracked in . The problem of the test is not necessarily to be fixed in v1.6, at least it's not release blocker. :)", "positive_passages": [{"docid": "doc-en-kubernetes-18d39022ab9bee8f6592cbc21ce55316c7f182458a80d6ce8671acc092a64c73", "text": "}) Context(\"\", func() { It(\"pod infra containers oom-score-adj should be -998 and best effort container's should be 1000\", func() { <del> var err error </del> <ins> // Take a snapshot of existing pause processes. These were // created before this test, and may not be infra // containers. They should be excluded from the test. existingPausePIDs, err := getPidsForProcess(\"pause\", \"\") Expect(err).To(BeNil(), \"failed to list all pause processes on the node\") existingPausePIDSet := sets.NewInt(existingPausePIDs...) </ins> podClient := f.PodClient() podName := \"besteffort\" + string(uuid.NewUUID()) podClient.Create(&v1.Pod{", "commid": "kubernetes_pr_43248"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bab4044edb7a0e5617350e3d6f93b7c726f673f15e5fb436597db129dafff171", "query": "The test is failing in . https://k8s- https://k8s- https://k8s- The reason is that the test expects that all pause containers () should have . However, in many tests, we are starting test containers with . Those pause containers have . Ideally, containers started in previous test should be cleaned up, so in serial suite it should not affect later test. However, it is not always true when CRI is enabled. For example, in the oom message, we could see: There are 2 problems here: Why are containers not properly cleaned up when CRI enabled? I can't even find which test leaked pause container from the log, because there are many test using pause image, and some of them start a lot of containers, such as density test, restart test. The oom score adj test should not rely on process name . However, I can't find an alternative for now, because we don't report pause container status in our api, we don't even know the container id to inspect with docker or CRI. /cc\nThis test is still flaking in cri-serial. Some examples: https://k8s- https://k8s- Need to check the logs to see if the symptoms are the same.\nIt could be that with CRI, it takes kubelet longer to clean up. Or, even worse, that kubelet is not cleaning up properly. We need more information on this on failure. Dumping pods on the node Dumping containers () on the node. Accessing docker directly is not ideal, but it's okay because the test itself only applies to docker. Alternatively, we can get the current running containers from kubelet's /runningPods endpoint. The downside is that this may lag behind the actual state a little bit (seconds). We should also make the test suite run more frequently. It runs once a day, which makes the debugging round-trip overhead too high.\nI can reproduce this process leak by running the \"Network should recover from ip leaks\" on my own node, without CRI enabled. The image used in the test was , and the docker version 1.11.2. The test creates 100 pods, then restarts the docker service by 6 times, with 20s interval in between. After the test ends, there could be multiple processes running left on the node. Those processes were reparented to pid 1, and showed no containers running. /cc\nOn the side note, the test should not be blindly checking all processes. It should, instead, take a snapshot of the system before the test and only check the new processes created by the tests.\nI filed a new issue for the docker bug since it's not unique to CRI and this test is catching it by accident: Leaving this issue to fix the test by not blindly checking all processes:\nThe docker bug is not a regression, and is tracked in . The problem of the test is not necessarily to be fixed in v1.6, at least it's not release blocker. :)", "positive_passages": [{"docid": "doc-en-kubernetes-c489e291b34a833492d91b207fb262c947227008d2d2a658d53efd59acf8b34a", "text": "return fmt.Errorf(\"failed to get list of pause pids: %v\", err) } for _, pid := range pausePids { <ins> if existingPausePIDSet.Has(pid) { // Not created by this test. Ignore it. continue } </ins> if err := validateOOMScoreAdjSetting(pid, -998); err != nil { return err }", "commid": "kubernetes_pr_43248"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e710d6571fc2bb83bfa33e4a2cce734798a9edc31e924618a5805c0e3b35e1f5", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"4\", GitVersion:\"v1.4.5\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2016-10-29T01:38:40Z\", GoVersion:\"go1.6.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"4\", GitVersion:\"v1.4.5\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2016-10-29T01:32:42Z\", GoVersion:\"go1.6.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Environment: Cloud provider or hardware configuration: vSphere OS (e.g. from /etc/os-release):Kernel (e.g. ):Install tools: None Others: None What happened: When I create a deployment with vSphere cloud provider dynamic provisioning, it creates a volume spec with volume path - [datastore] kubevols/volume which contains a white space in it. In this case the cloud provider queries the getDeviceNameFromMount() to return the path of the volume mounted. Since getDeviceNameFromMount() queries the filesystem to get the mount references, it returns a volume path \"[datastore]040kubevols/volume\". Later the kubelet searches for this volume path in both the actual and desired states. Th actual and desired states contains volume with path \"[datastore] kubevols/volume\". So, it couldn't find such volume path and therefore kubernetes stalls unable to make any progress further similar to one described in . Also similar issue described in What you expected to happen: All the pods in the recreated deployment comes up. How to reproduce it (as minimally and precisely as possible): See above. Anything else do we need to know: None\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-b6905192256b8c478f5c39410c75f93e02fe1b746feac6d75db7896787306db6", "text": "\"fmt\" \"os\" \"path\" <ins> \"strings\" </ins> \"github.com/golang/glog\" \"k8s.io/kubernetes/pkg/api/resource\"", "commid": "kubernetes_pr_38338"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e710d6571fc2bb83bfa33e4a2cce734798a9edc31e924618a5805c0e3b35e1f5", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"4\", GitVersion:\"v1.4.5\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2016-10-29T01:38:40Z\", GoVersion:\"go1.6.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"4\", GitVersion:\"v1.4.5\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2016-10-29T01:32:42Z\", GoVersion:\"go1.6.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Environment: Cloud provider or hardware configuration: vSphere OS (e.g. from /etc/os-release):Kernel (e.g. ):Install tools: None Others: None What happened: When I create a deployment with vSphere cloud provider dynamic provisioning, it creates a volume spec with volume path - [datastore] kubevols/volume which contains a white space in it. In this case the cloud provider queries the getDeviceNameFromMount() to return the path of the volume mounted. Since getDeviceNameFromMount() queries the filesystem to get the mount references, it returns a volume path \"[datastore]040kubevols/volume\". Later the kubelet searches for this volume path in both the actual and desired states. Th actual and desired states contains volume with path \"[datastore] kubevols/volume\". So, it couldn't find such volume path and therefore kubernetes stalls unable to make any progress further similar to one described in . Also similar issue described in What you expected to happen: All the pods in the recreated deployment comes up. How to reproduce it (as minimally and precisely as possible): See above. Anything else do we need to know: None\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-0fb987d86186121faa0e23db0fe744567a9963c5cf0beb0f724137e8c09ac012", "text": "if err != nil { return nil, err } <ins> volumePath = strings.Replace(volumePath, \"040\", \" \", -1) </ins> glog.V(5).Infof(\"vSphere volume path is %q\", volumePath) vsphereVolume := &v1.Volume{ Name: volumeName,", "commid": "kubernetes_pr_38338"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8d2c0da68304e83135ba886da3cc34043a1f75faa72e9753c7e99fa612dae72", "query": "From etcd3: May need to retry poststarthook a few times to avoid bootstrapping failures like this.", "positive_passages": [{"docid": "doc-en-kubernetes-6e94eb507cdefe046b645f78591bee857508ff5220baaf141131aecb10b15c57", "text": "\"//pkg/registry/rbac/rolebinding/etcd:go_default_library\", \"//pkg/registry/rbac/rolebinding/policybased:go_default_library\", \"//pkg/util/runtime:go_default_library\", <ins> \"//pkg/util/wait:go_default_library\", </ins> \"//plugin/pkg/auth/authorizer/rbac/bootstrappolicy:go_default_library\", \"//vendor:github.com/golang/glog\", ],", "commid": "kubernetes_pr_39149"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8d2c0da68304e83135ba886da3cc34043a1f75faa72e9753c7e99fa612dae72", "query": "From etcd3: May need to retry poststarthook a few times to avoid bootstrapping failures like this.", "positive_passages": [{"docid": "doc-en-kubernetes-f2f6c47d546d84798950b888afe622a749a7521985a15fa404e29a7fba4bfa18", "text": "import ( \"fmt\" \"sync\" <ins> \"time\" </ins> \"github.com/golang/glog\"", "commid": "kubernetes_pr_39149"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8d2c0da68304e83135ba886da3cc34043a1f75faa72e9753c7e99fa612dae72", "query": "From etcd3: May need to retry poststarthook a few times to avoid bootstrapping failures like this.", "positive_passages": [{"docid": "doc-en-kubernetes-089634bdc5e4420857951709f9da55da61312b8541e0fb7f4926475d766f2c01", "text": "rolebindingetcd \"k8s.io/kubernetes/pkg/registry/rbac/rolebinding/etcd\" rolebindingpolicybased \"k8s.io/kubernetes/pkg/registry/rbac/rolebinding/policybased\" utilruntime \"k8s.io/kubernetes/pkg/util/runtime\" <ins> \"k8s.io/kubernetes/pkg/util/wait\" </ins> \"k8s.io/kubernetes/plugin/pkg/auth/authorizer/rbac/bootstrappolicy\" )", "commid": "kubernetes_pr_39149"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8d2c0da68304e83135ba886da3cc34043a1f75faa72e9753c7e99fa612dae72", "query": "From etcd3: May need to retry poststarthook a few times to avoid bootstrapping failures like this.", "positive_passages": [{"docid": "doc-en-kubernetes-68631a912a8da368a1a862c61c859649af4bb74cae434e7a3b46fe7fe2d9dde6", "text": "} func PostStartHook(hookContext genericapiserver.PostStartHookContext) error { <del> clientset, err := rbacclient.NewForConfig(hookContext.LoopbackClientConfig) if err != nil { utilruntime.HandleError(fmt.Errorf(\"unable to initialize clusterroles: %v\", err)) return nil } existingClusterRoles, err := clientset.ClusterRoles().List(api.ListOptions{}) if err != nil { utilruntime.HandleError(fmt.Errorf(\"unable to initialize clusterroles: %v\", err)) return nil } // if clusterroles already exist, then assume we don't have work to do because we've already // initialized or another API server has started this task if len(existingClusterRoles.Items) > 0 { return nil } for _, clusterRole := range append(bootstrappolicy.ClusterRoles(), bootstrappolicy.ControllerRoles()...) { if _, err := clientset.ClusterRoles().Create(&clusterRole); err != nil { // don't fail on failures, try to create as many as you can </del> <ins> // intializing roles is really important.  On some e2e runs, we've seen cases where etcd is down when the server // starts, the roles don't initialize, and nothing works. err := wait.Poll(1*time.Second, 30*time.Second, func() (done bool, err error) { clientset, err := rbacclient.NewForConfig(hookContext.LoopbackClientConfig) if err != nil { </ins> utilruntime.HandleError(fmt.Errorf(\"unable to initialize clusterroles: %v\", err)) <del> continue </del> <ins> return false, nil </ins> } <del> glog.Infof(\"Created clusterrole.%s/%s\", rbac.GroupName, clusterRole.Name) } existingClusterRoleBindings, err := clientset.ClusterRoleBindings().List(api.ListOptions{}) if err != nil { utilruntime.HandleError(fmt.Errorf(\"unable to initialize clusterrolebindings: %v\", err)) return nil } // if clusterrolebindings already exist, then assume we don't have work to do because we've already // initialized or another API server has started this task if len(existingClusterRoleBindings.Items) > 0 { return nil } </del> <ins> existingClusterRoles, err := clientset.ClusterRoles().List(api.ListOptions{}) if err != nil { utilruntime.HandleError(fmt.Errorf(\"unable to initialize clusterroles: %v\", err)) return false, nil } // only initialized on empty etcd if len(existingClusterRoles.Items) == 0 { for _, clusterRole := range append(bootstrappolicy.ClusterRoles(), bootstrappolicy.ControllerRoles()...) { if _, err := clientset.ClusterRoles().Create(&clusterRole); err != nil { // don't fail on failures, try to create as many as you can utilruntime.HandleError(fmt.Errorf(\"unable to initialize clusterroles: %v\", err)) continue } glog.Infof(\"Created clusterrole.%s/%s\", rbac.GroupName, clusterRole.Name) } } </ins> <del> for _, clusterRoleBinding := range append(bootstrappolicy.ClusterRoleBindings(), bootstrappolicy.ControllerRoleBindings()...) { if _, err := clientset.ClusterRoleBindings().Create(&clusterRoleBinding); err != nil { // don't fail on failures, try to create as many as you can </del> <ins> existingClusterRoleBindings, err := clientset.ClusterRoleBindings().List(api.ListOptions{}) if err != nil { </ins> utilruntime.HandleError(fmt.Errorf(\"unable to initialize clusterrolebindings: %v\", err)) <del> continue </del> <ins> return false, nil } // only initialized on empty etcd if len(existingClusterRoleBindings.Items) == 0 { for _, clusterRoleBinding := range append(bootstrappolicy.ClusterRoleBindings(), bootstrappolicy.ControllerRoleBindings()...) { if _, err := clientset.ClusterRoleBindings().Create(&clusterRoleBinding); err != nil { // don't fail on failures, try to create as many as you can utilruntime.HandleError(fmt.Errorf(\"unable to initialize clusterrolebindings: %v\", err)) continue } glog.Infof(\"Created clusterrolebinding.%s/%s\", rbac.GroupName, clusterRoleBinding.Name) } </ins> } <del> glog.Infof(\"Created clusterrolebinding.%s/%s\", rbac.GroupName, clusterRoleBinding.Name) </del> <ins> return true, nil }) // if we're never able to make it through intialization, kill the API server if err != nil { return fmt.Errorf(\"unable to initialize roles: %v\", err) </ins> } return nil", "commid": "kubernetes_pr_39149"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5941efe129f89aeac5a57a181211dbed35027d19160f63506020d4b51036a413", "query": "adler when brute-forced turns out to break really fast (). There are a couple of places we use it in the repo: We should probably replace it with fnv. I tested fnv and it seems to be slightly more expensive but also a lot more stable than adler:\nJust work out a patch to fix this, please take a look.\nassigning this to you since the only place left to use adler is in and it's a legacy helper.\n/assign\n[MILESTONENOTIFIER] Milestone Labels Incomplete Action required: This issue requires label changes. If the required changes are not made within 3 days, the issue will be moved out of the v1.8 milestone. kind: Must specify at most one of ['kind/bug', 'kind/feature', 'kind/cleanup']. priority: Must specify at most one of ['priority/critical-urgent', 'priority/important-soon', 'priority/important-longterm']. <detailsAdditional instructions available <a href=\"\"here</a</details\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nThis was removed in", "positive_passages": [{"docid": "doc-en-kubernetes-8eabfca24d654a2831fef622d55b761b83a97c4cfd13f998e34f97e37aa0a133", "text": "package controller import ( <del> \"hash/adler32\" </del> <ins> \"hash/fnv\" </ins> \"sync\" \"github.com/golang/groupcache/lru\"", "commid": "kubernetes_pr_40297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5941efe129f89aeac5a57a181211dbed35027d19160f63506020d4b51036a413", "query": "adler when brute-forced turns out to break really fast (). There are a couple of places we use it in the repo: We should probably replace it with fnv. I tested fnv and it seems to be slightly more expensive but also a lot more stable than adler:\nJust work out a patch to fix this, please take a look.\nassigning this to you since the only place left to use adler is in and it's a legacy helper.\n/assign\n[MILESTONENOTIFIER] Milestone Labels Incomplete Action required: This issue requires label changes. If the required changes are not made within 3 days, the issue will be moved out of the v1.8 milestone. kind: Must specify at most one of ['kind/bug', 'kind/feature', 'kind/cleanup']. priority: Must specify at most one of ['priority/critical-urgent', 'priority/important-soon', 'priority/important-longterm']. <detailsAdditional instructions available <a href=\"\"here</a</details\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nThis was removed in", "positive_passages": [{"docid": "doc-en-kubernetes-327215bc767ff14d50cf2cc7882931bfb5310b6f20b672bbaa07e9b127783ac4", "text": "// Since we match objects by namespace and Labels/Selector, so if two objects have the same namespace and labels, // they will have the same key. func keyFunc(obj objectWithMeta) uint64 { <del> hash := adler32.New() </del> <ins> hash := fnv.New32a() </ins> hashutil.DeepHashObject(hash, &equivalenceLabelObj{ namespace: obj.GetNamespace(), labels:    obj.GetLabels(),", "commid": "kubernetes_pr_40297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5941efe129f89aeac5a57a181211dbed35027d19160f63506020d4b51036a413", "query": "adler when brute-forced turns out to break really fast (). There are a couple of places we use it in the repo: We should probably replace it with fnv. I tested fnv and it seems to be slightly more expensive but also a lot more stable than adler:\nJust work out a patch to fix this, please take a look.\nassigning this to you since the only place left to use adler is in and it's a legacy helper.\n/assign\n[MILESTONENOTIFIER] Milestone Labels Incomplete Action required: This issue requires label changes. If the required changes are not made within 3 days, the issue will be moved out of the v1.8 milestone. kind: Must specify at most one of ['kind/bug', 'kind/feature', 'kind/cleanup']. priority: Must specify at most one of ['priority/critical-urgent', 'priority/important-soon', 'priority/important-longterm']. <detailsAdditional instructions available <a href=\"\"here</a</details\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nThis was removed in", "positive_passages": [{"docid": "doc-en-kubernetes-b2f8ccf7c423a40169bd46ad0a9ab75e6a96a596d339e4551cb4afe2ff01e023", "text": "import ( \"bufio\" \"fmt\" <del> \"hash/adler32\" </del> <ins> \"hash/fnv\" </ins> \"io\" \"os\" \"os/exec\"", "commid": "kubernetes_pr_40297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5941efe129f89aeac5a57a181211dbed35027d19160f63506020d4b51036a413", "query": "adler when brute-forced turns out to break really fast (). There are a couple of places we use it in the repo: We should probably replace it with fnv. I tested fnv and it seems to be slightly more expensive but also a lot more stable than adler:\nJust work out a patch to fix this, please take a look.\nassigning this to you since the only place left to use adler is in and it's a legacy helper.\n/assign\n[MILESTONENOTIFIER] Milestone Labels Incomplete Action required: This issue requires label changes. If the required changes are not made within 3 days, the issue will be moved out of the v1.8 milestone. kind: Must specify at most one of ['kind/bug', 'kind/feature', 'kind/cleanup']. priority: Must specify at most one of ['priority/critical-urgent', 'priority/important-soon', 'priority/important-longterm']. <detailsAdditional instructions available <a href=\"\"here</a</details\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nThis was removed in", "positive_passages": [{"docid": "doc-en-kubernetes-3b4cb1c664e9aa8a9a1be8b3e8383af7908cc7f36689008a0b74563c08216d4b", "text": "} func readProcMountsFrom(file io.Reader, out *[]MountPoint) (uint32, error) { <del> hash := adler32.New() </del> <ins> hash := fnv.New32a() </ins> scanner := bufio.NewReader(file) for { line, err := scanner.ReadString('n')", "commid": "kubernetes_pr_40297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5941efe129f89aeac5a57a181211dbed35027d19160f63506020d4b51036a413", "query": "adler when brute-forced turns out to break really fast (). There are a couple of places we use it in the repo: We should probably replace it with fnv. I tested fnv and it seems to be slightly more expensive but also a lot more stable than adler:\nJust work out a patch to fix this, please take a look.\nassigning this to you since the only place left to use adler is in and it's a legacy helper.\n/assign\n[MILESTONENOTIFIER] Milestone Labels Incomplete Action required: This issue requires label changes. If the required changes are not made within 3 days, the issue will be moved out of the v1.8 milestone. kind: Must specify at most one of ['kind/bug', 'kind/feature', 'kind/cleanup']. priority: Must specify at most one of ['priority/critical-urgent', 'priority/important-soon', 'priority/important-longterm']. <detailsAdditional instructions available <a href=\"\"here</a</details\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nThis was removed in", "positive_passages": [{"docid": "doc-en-kubernetes-90f320cc7c0981fc3dbb6edb6d3461b26ffbbf603a8a5ccdcca319e0715dcae1", "text": "/dev/1    /path/to/1   type1\tflags 1 1 /dev/2 /path/to/2 type2 flags,1,2=3 2 2 ` <ins> // NOTE: readProcMountsFrom has been updated to using fnv.New32a() </ins> hash, err := readProcMountsFrom(strings.NewReader(successCase), nil) if err != nil { t.Errorf(\"expected success\") } <del> if hash != 0xa3522051 { t.Errorf(\"expected 0xa3522051, got %#x\", hash) </del> <ins> if hash != 0xa290ff0b { t.Errorf(\"expected 0xa290ff0b, got %#x\", hash) </ins> } mounts := []MountPoint{} hash, err = readProcMountsFrom(strings.NewReader(successCase), &mounts) if err != nil { t.Errorf(\"expected success\") } <del> if hash != 0xa3522051 { t.Errorf(\"expected 0xa3522051, got %#x\", hash) </del> <ins> if hash != 0xa290ff0b { t.Errorf(\"expected 0xa290ff0b, got %#x\", hash) </ins> } if len(mounts) != 3 { t.Fatalf(\"expected 3 mounts, got %d\", len(mounts))", "commid": "kubernetes_pr_40297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5941efe129f89aeac5a57a181211dbed35027d19160f63506020d4b51036a413", "query": "adler when brute-forced turns out to break really fast (). There are a couple of places we use it in the repo: We should probably replace it with fnv. I tested fnv and it seems to be slightly more expensive but also a lot more stable than adler:\nJust work out a patch to fix this, please take a look.\nassigning this to you since the only place left to use adler is in and it's a legacy helper.\n/assign\n[MILESTONENOTIFIER] Milestone Labels Incomplete Action required: This issue requires label changes. If the required changes are not made within 3 days, the issue will be moved out of the v1.8 milestone. kind: Must specify at most one of ['kind/bug', 'kind/feature', 'kind/cleanup']. priority: Must specify at most one of ['priority/critical-urgent', 'priority/important-soon', 'priority/important-longterm']. <detailsAdditional instructions available <a href=\"\"here</a</details\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nThis was removed in", "positive_passages": [{"docid": "doc-en-kubernetes-cb73ca9feb406ec003936f4821ec49a26e1b0b16540d1811dbcbb362b33b9ed9", "text": "package core import ( <del> \"hash/adler32\" </del> <ins> \"hash/fnv\" </ins> \"github.com/golang/groupcache/lru\"", "commid": "kubernetes_pr_40297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5941efe129f89aeac5a57a181211dbed35027d19160f63506020d4b51036a413", "query": "adler when brute-forced turns out to break really fast (). There are a couple of places we use it in the repo: We should probably replace it with fnv. I tested fnv and it seems to be slightly more expensive but also a lot more stable than adler:\nJust work out a patch to fix this, please take a look.\nassigning this to you since the only place left to use adler is in and it's a legacy helper.\n/assign\n[MILESTONENOTIFIER] Milestone Labels Incomplete Action required: This issue requires label changes. If the required changes are not made within 3 days, the issue will be moved out of the v1.8 milestone. kind: Must specify at most one of ['kind/bug', 'kind/feature', 'kind/cleanup']. priority: Must specify at most one of ['priority/critical-urgent', 'priority/important-soon', 'priority/important-longterm']. <detailsAdditional instructions available <a href=\"\"here</a</details\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nThis was removed in", "positive_passages": [{"docid": "doc-en-kubernetes-5e67570a43755f33bedc5a2c414bf5b80aa4a83b82a6c2090a90c9705fd21d33", "text": "// hashEquivalencePod returns the hash of equivalence pod. func (ec *EquivalenceCache) hashEquivalencePod(pod *v1.Pod) uint64 { equivalencePod := ec.getEquivalencePod(pod) <del> hash := adler32.New() </del> <ins> hash := fnv.New32a() </ins> hashutil.DeepHashObject(hash, equivalencePod) return uint64(hash.Sum32()) }", "commid": "kubernetes_pr_40297"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-490ac367d4ab83a139fc1f320c659a499899ad8ab67ed3319f693dd98af4d529", "query": "Our scalability tests started failing on Thu last week: https://k8s- [250 run passed, 251 failed and since then everything failed] I started looking into it and it seems that something happened to how we are handling watches (i.e. I'm seeing a huge number of watches failing with \"err too old\" errors (which I didn't see before).\nAs an example in run 258 of kubemark-scale, I'm seeing this log in the test (after 5 minutes of running test); This is extremely strange and unexpected. I looked into apiserver logs, and there is expected number of POST and PUT operations on pods (and no DELETE and PATCH operations until then). Until then, there were alltogethere ~60.000 operations on pods. However, in 5000-node cluster, the size of watchcache of pods is supposed to be 250.000, which means that at that moment we should have all the history from the beginning in watch cache. And still we are observing those errors. Something must have changed around that recently...\nAs an example, logs from apiserver from a given node: This means something is really wrong: the first watch started at 45, then after it finished, we tried starting watch from rv= and it failed with \"rv too old\" the list, returned rv= from which we started the next watch. If the watch cache size for pods would be 250.000 (50*cluster size), there there is no way that with current rv=, the rv= would be outside history window...\nI had a hypothesis that it might be the problem of breaking watch to etcd. But in that case there should be a warning \"Terminating all watchers\" log in apiserver, and there is no such log. It also seems that the size of cache is being set correctly...\nSo I tried running large kubemark locally and it seems that the problem is that the size of cache is too small. I few more logs, and here is what I'm seeing: So it seems that we are correctly initializing cachesizes, but then watch cache capacity is 100 (which explains why we are seeing all those \"rv too old\" errors. I will try to debug why the capacity is so small.\nOK - I found it. contains the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-eee82a5bc100a471f31aab1ec4381533187566f7c306b0d094ee63cefb6a0acb", "text": "type cacheWatcher struct { sync.Mutex copier  runtime.ObjectCopier <del> input   chan *watchCacheEvent </del> <ins> input   chan watchCacheEvent </ins> result  chan watch.Event done    chan struct{} filter  watchFilterFunc", "commid": "kubernetes_pr_41018"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-490ac367d4ab83a139fc1f320c659a499899ad8ab67ed3319f693dd98af4d529", "query": "Our scalability tests started failing on Thu last week: https://k8s- [250 run passed, 251 failed and since then everything failed] I started looking into it and it seems that something happened to how we are handling watches (i.e. I'm seeing a huge number of watches failing with \"err too old\" errors (which I didn't see before).\nAs an example in run 258 of kubemark-scale, I'm seeing this log in the test (after 5 minutes of running test); This is extremely strange and unexpected. I looked into apiserver logs, and there is expected number of POST and PUT operations on pods (and no DELETE and PATCH operations until then). Until then, there were alltogethere ~60.000 operations on pods. However, in 5000-node cluster, the size of watchcache of pods is supposed to be 250.000, which means that at that moment we should have all the history from the beginning in watch cache. And still we are observing those errors. Something must have changed around that recently...\nAs an example, logs from apiserver from a given node: This means something is really wrong: the first watch started at 45, then after it finished, we tried starting watch from rv= and it failed with \"rv too old\" the list, returned rv= from which we started the next watch. If the watch cache size for pods would be 250.000 (50*cluster size), there there is no way that with current rv=, the rv= would be outside history window...\nI had a hypothesis that it might be the problem of breaking watch to etcd. But in that case there should be a warning \"Terminating all watchers\" log in apiserver, and there is no such log. It also seems that the size of cache is being set correctly...\nSo I tried running large kubemark locally and it seems that the problem is that the size of cache is too small. I few more logs, and here is what I'm seeing: So it seems that we are correctly initializing cachesizes, but then watch cache capacity is 100 (which explains why we are seeing all those \"rv too old\" errors. I will try to debug why the capacity is so small.\nOK - I found it. contains the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-1933b00d6182cb765df6698be539487f436e32d96324601096b33817b7d444c8", "text": "func newCacheWatcher(copier runtime.ObjectCopier, resourceVersion uint64, chanSize int, initEvents []*watchCacheEvent, filter watchFilterFunc, forget func(bool)) *cacheWatcher { watcher := &cacheWatcher{ copier:  copier, <del> input:   make(chan *watchCacheEvent, chanSize), </del> <ins> input:   make(chan watchCacheEvent, chanSize), </ins> result:  make(chan watch.Event, chanSize), done:    make(chan struct{}), filter:  filter,", "commid": "kubernetes_pr_41018"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-490ac367d4ab83a139fc1f320c659a499899ad8ab67ed3319f693dd98af4d529", "query": "Our scalability tests started failing on Thu last week: https://k8s- [250 run passed, 251 failed and since then everything failed] I started looking into it and it seems that something happened to how we are handling watches (i.e. I'm seeing a huge number of watches failing with \"err too old\" errors (which I didn't see before).\nAs an example in run 258 of kubemark-scale, I'm seeing this log in the test (after 5 minutes of running test); This is extremely strange and unexpected. I looked into apiserver logs, and there is expected number of POST and PUT operations on pods (and no DELETE and PATCH operations until then). Until then, there were alltogethere ~60.000 operations on pods. However, in 5000-node cluster, the size of watchcache of pods is supposed to be 250.000, which means that at that moment we should have all the history from the beginning in watch cache. And still we are observing those errors. Something must have changed around that recently...\nAs an example, logs from apiserver from a given node: This means something is really wrong: the first watch started at 45, then after it finished, we tried starting watch from rv= and it failed with \"rv too old\" the list, returned rv= from which we started the next watch. If the watch cache size for pods would be 250.000 (50*cluster size), there there is no way that with current rv=, the rv= would be outside history window...\nI had a hypothesis that it might be the problem of breaking watch to etcd. But in that case there should be a warning \"Terminating all watchers\" log in apiserver, and there is no such log. It also seems that the size of cache is being set correctly...\nSo I tried running large kubemark locally and it seems that the problem is that the size of cache is too small. I few more logs, and here is what I'm seeing: So it seems that we are correctly initializing cachesizes, but then watch cache capacity is 100 (which explains why we are seeing all those \"rv too old\" errors. I will try to debug why the capacity is so small.\nOK - I found it. contains the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-ce5016b48d265bd4d65752d4213b5269922efe93c61c9309eb48675e73d98912", "text": "func (c *cacheWatcher) add(event *watchCacheEvent, budget *timeBudget) { // Try to send the event immediately, without blocking. select { <del> case c.input <- event: </del> <ins> case c.input <- *event: </ins> return default: }", "commid": "kubernetes_pr_41018"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-490ac367d4ab83a139fc1f320c659a499899ad8ab67ed3319f693dd98af4d529", "query": "Our scalability tests started failing on Thu last week: https://k8s- [250 run passed, 251 failed and since then everything failed] I started looking into it and it seems that something happened to how we are handling watches (i.e. I'm seeing a huge number of watches failing with \"err too old\" errors (which I didn't see before).\nAs an example in run 258 of kubemark-scale, I'm seeing this log in the test (after 5 minutes of running test); This is extremely strange and unexpected. I looked into apiserver logs, and there is expected number of POST and PUT operations on pods (and no DELETE and PATCH operations until then). Until then, there were alltogethere ~60.000 operations on pods. However, in 5000-node cluster, the size of watchcache of pods is supposed to be 250.000, which means that at that moment we should have all the history from the beginning in watch cache. And still we are observing those errors. Something must have changed around that recently...\nAs an example, logs from apiserver from a given node: This means something is really wrong: the first watch started at 45, then after it finished, we tried starting watch from rv= and it failed with \"rv too old\" the list, returned rv= from which we started the next watch. If the watch cache size for pods would be 250.000 (50*cluster size), there there is no way that with current rv=, the rv= would be outside history window...\nI had a hypothesis that it might be the problem of breaking watch to etcd. But in that case there should be a warning \"Terminating all watchers\" log in apiserver, and there is no such log. It also seems that the size of cache is being set correctly...\nSo I tried running large kubemark locally and it seems that the problem is that the size of cache is too small. I few more logs, and here is what I'm seeing: So it seems that we are correctly initializing cachesizes, but then watch cache capacity is 100 (which explains why we are seeing all those \"rv too old\" errors. I will try to debug why the capacity is so small.\nOK - I found it. contains the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-747365d3f5f7926cd1d98818acf30d90a396bb398d6d61438e2025fdfdf08777", "text": "defer timerPool.Put(t) select { <del> case c.input <- event: </del> <ins> case c.input <- *event: </ins> stopped := t.Stop() if !stopped { // Consume triggered (but not yet received) timer event", "commid": "kubernetes_pr_41018"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-490ac367d4ab83a139fc1f320c659a499899ad8ab67ed3319f693dd98af4d529", "query": "Our scalability tests started failing on Thu last week: https://k8s- [250 run passed, 251 failed and since then everything failed] I started looking into it and it seems that something happened to how we are handling watches (i.e. I'm seeing a huge number of watches failing with \"err too old\" errors (which I didn't see before).\nAs an example in run 258 of kubemark-scale, I'm seeing this log in the test (after 5 minutes of running test); This is extremely strange and unexpected. I looked into apiserver logs, and there is expected number of POST and PUT operations on pods (and no DELETE and PATCH operations until then). Until then, there were alltogethere ~60.000 operations on pods. However, in 5000-node cluster, the size of watchcache of pods is supposed to be 250.000, which means that at that moment we should have all the history from the beginning in watch cache. And still we are observing those errors. Something must have changed around that recently...\nAs an example, logs from apiserver from a given node: This means something is really wrong: the first watch started at 45, then after it finished, we tried starting watch from rv= and it failed with \"rv too old\" the list, returned rv= from which we started the next watch. If the watch cache size for pods would be 250.000 (50*cluster size), there there is no way that with current rv=, the rv= would be outside history window...\nI had a hypothesis that it might be the problem of breaking watch to etcd. But in that case there should be a warning \"Terminating all watchers\" log in apiserver, and there is no such log. It also seems that the size of cache is being set correctly...\nSo I tried running large kubemark locally and it seems that the problem is that the size of cache is too small. I few more logs, and here is what I'm seeing: So it seems that we are correctly initializing cachesizes, but then watch cache capacity is 100 (which explains why we are seeing all those \"rv too old\" errors. I will try to debug why the capacity is so small.\nOK - I found it. contains the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-da6869b51895439ac559459c36f19a5c1b858c8b2063648939a1324dc0d2eacd", "text": "} // only send events newer than resourceVersion if event.ResourceVersion > resourceVersion { <del> c.sendWatchCacheEvent(event) </del> <ins> c.sendWatchCacheEvent(&event) </ins> } } }", "commid": "kubernetes_pr_41018"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8bc52aafefd8d4f5fd7860ac78effc748d00a617bb0944080ddb6bdd9c32be6b", "query": "The description of says: However the implementation will interpret the name as a regex. So for example \"...\" will match any three-letter string. This is not what I understand by \"exact match\".\nWill open an PR fix this comment", "positive_passages": [{"docid": "doc-en-kubernetes-2fce45bad966e626c6f47f68768f6361dd3ef22156f32d2c97931045243cb93e", "text": "return utilerrors.NewAggregate(errList) } <del> // Find process(es) with a specified name (exact match) </del> <ins> // Find process(es) with a specified name (regexp match) </ins> // and return their pid(s) func PidOf(name string) ([]int, error) { if len(name) == 0 {", "commid": "kubernetes_pr_41330"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c1af9be05ec6d7dedbb1ae7294344c5d68ab0d6ecd719d2d691350d408b871c8", "query": "If in line line is executed also for step 2.2.1 if the tool failed during first run of upgrade. I guess we should also check for the step and compare it to version.", "positive_passages": [{"docid": "doc-en-kubernetes-8c4e72cf0c37e68a37436542b0110ec91de9d933d5549d747fcd18d762387178", "text": "exit 1 fi <ins> echo \"$(date +'%Y-%m-%d %H:%M:%S') Detecting if migration is needed\" </ins> if [ \"${TARGET_STORAGE}\" != \"etcd2\" -a \"${TARGET_STORAGE}\" != \"etcd3\" ]; then echo \"Not supported version of storage: ${TARGET_STORAGE}\" exit 1", "commid": "kubernetes_pr_41325"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c1af9be05ec6d7dedbb1ae7294344c5d68ab0d6ecd719d2d691350d408b871c8", "query": "If in line line is executed also for step 2.2.1 if the tool failed during first run of upgrade. I guess we should also check for the step and compare it to version.", "positive_passages": [{"docid": "doc-en-kubernetes-4b88d472d246da849417baddee119268e3b81e17eaf33b409e3e3d9c32a18dc4", "text": "CURRENT_VERSION=${step} echo \"${CURRENT_VERSION}/${CURRENT_STORAGE}\" > \"${DATA_DIRECTORY}/${VERSION_FILE}\" fi <del> if [ \"$(echo ${CURRENT_VERSION} | cut -c1-2)\" = \"3.\" -a \"${CURRENT_STORAGE}\" = \"etcd2\" -a \"${TARGET_STORAGE}\" = \"etcd3\" ]; then </del> <ins> if [ \"$(echo ${CURRENT_VERSION} | cut -c1-2)\" = \"3.\" -a \"${CURRENT_VERSION}\" = \"${step}\" -a \"${CURRENT_STORAGE}\" = \"etcd2\" -a \"${TARGET_STORAGE}\" = \"etcd3\" ]; then </ins> # If it is the first 3.x release in the list and we are migrating # also from 'etcd2' to 'etcd3', do the migration now. echo \"Performing etcd2 -> etcd3 migration\"", "commid": "kubernetes_pr_41325"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c1af9be05ec6d7dedbb1ae7294344c5d68ab0d6ecd719d2d691350d408b871c8", "query": "If in line line is executed also for step 2.2.1 if the tool failed during first run of upgrade. I guess we should also check for the step and compare it to version.", "positive_passages": [{"docid": "doc-en-kubernetes-39ee29be4005e5459009e2c0dd89de21054fb996375b15fef0e56d08ea1740a0", "text": "CURRENT_VERSION=\"2.3.7\" echo \"${CURRENT_VERSION}/${CURRENT_STORAGE}\" > \"${DATA_DIRECTORY}/${VERSION_FILE}\" fi <ins> echo \"$(date +'%Y-%m-%d %H:%M:%S') Migration finished\" </ins>", "commid": "kubernetes_pr_41325"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b043ab61632a183920bf62a5be84e11c0702831755fb3808ab5d8790cb5d9b1", "query": "At the very least it should be clear when (timestamp) the migration started and finished.", "positive_passages": [{"docid": "doc-en-kubernetes-8c4e72cf0c37e68a37436542b0110ec91de9d933d5549d747fcd18d762387178", "text": "exit 1 fi <ins> echo \"$(date +'%Y-%m-%d %H:%M:%S') Detecting if migration is needed\" </ins> if [ \"${TARGET_STORAGE}\" != \"etcd2\" -a \"${TARGET_STORAGE}\" != \"etcd3\" ]; then echo \"Not supported version of storage: ${TARGET_STORAGE}\" exit 1", "commid": "kubernetes_pr_41325"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b043ab61632a183920bf62a5be84e11c0702831755fb3808ab5d8790cb5d9b1", "query": "At the very least it should be clear when (timestamp) the migration started and finished.", "positive_passages": [{"docid": "doc-en-kubernetes-4b88d472d246da849417baddee119268e3b81e17eaf33b409e3e3d9c32a18dc4", "text": "CURRENT_VERSION=${step} echo \"${CURRENT_VERSION}/${CURRENT_STORAGE}\" > \"${DATA_DIRECTORY}/${VERSION_FILE}\" fi <del> if [ \"$(echo ${CURRENT_VERSION} | cut -c1-2)\" = \"3.\" -a \"${CURRENT_STORAGE}\" = \"etcd2\" -a \"${TARGET_STORAGE}\" = \"etcd3\" ]; then </del> <ins> if [ \"$(echo ${CURRENT_VERSION} | cut -c1-2)\" = \"3.\" -a \"${CURRENT_VERSION}\" = \"${step}\" -a \"${CURRENT_STORAGE}\" = \"etcd2\" -a \"${TARGET_STORAGE}\" = \"etcd3\" ]; then </ins> # If it is the first 3.x release in the list and we are migrating # also from 'etcd2' to 'etcd3', do the migration now. echo \"Performing etcd2 -> etcd3 migration\"", "commid": "kubernetes_pr_41325"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b043ab61632a183920bf62a5be84e11c0702831755fb3808ab5d8790cb5d9b1", "query": "At the very least it should be clear when (timestamp) the migration started and finished.", "positive_passages": [{"docid": "doc-en-kubernetes-39ee29be4005e5459009e2c0dd89de21054fb996375b15fef0e56d08ea1740a0", "text": "CURRENT_VERSION=\"2.3.7\" echo \"${CURRENT_VERSION}/${CURRENT_STORAGE}\" > \"${DATA_DIRECTORY}/${VERSION_FILE}\" fi <ins> echo \"$(date +'%Y-%m-%d %H:%M:%S') Migration finished\" </ins>", "commid": "kubernetes_pr_41325"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f063045a15f2f641d3790e2b25e476dde91e4310f364256ec78b76d0b285e9b4", "query": "https://k8s- do you know the statefulset owners?\ncc\nI did not see this happening until recently.\nThe controller misses that the first pod transitioned to unready and proceeds to create the second pod. The test uses a client to hit the api server and will scale up the statefulset as soon as the broken pod is observed but the controller uses caches so it may observe the scaled up statefulset quicker than the updated pod.\nI will update the test to ensure that we wait until the unreadiness is observed on StatefulSet.Status.Replicas field prior to the scaling operation\nSGTM", "positive_passages": [{"docid": "doc-en-kubernetes-f7d62132b4db76685889587226bdf9877544f351fe75f65732023169f32c0783", "text": "} } <del> func (s *StatefulSetTester) waitForStatus(ss *apps.StatefulSet, expectedReplicas int32) { </del> <ins> // WaitForStatus waits for the ss.Status.Replicas to be equal to expectedReplicas func (s *StatefulSetTester) WaitForStatus(ss *apps.StatefulSet, expectedReplicas int32) { </ins> Logf(\"Waiting for statefulset status.replicas updated to %d\", expectedReplicas) ns, name := ss.Namespace, ss.Name", "commid": "kubernetes_pr_42367"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f063045a15f2f641d3790e2b25e476dde91e4310f364256ec78b76d0b285e9b4", "query": "https://k8s- do you know the statefulset owners?\ncc\nI did not see this happening until recently.\nThe controller misses that the first pod transitioned to unready and proceeds to create the second pod. The test uses a client to hit the api server and will scale up the statefulset as soon as the broken pod is observed but the controller uses caches so it may observe the scaled up statefulset quicker than the updated pod.\nI will update the test to ensure that we wait until the unreadiness is observed on StatefulSet.Status.Replicas field prior to the scaling operation\nSGTM", "positive_passages": [{"docid": "doc-en-kubernetes-e61461d917d216bf6a9da6b499ee8cb4911f13ec4698fd199601f55f6b258be4", "text": "if err != nil { return false, err } <ins> if *ssGet.Status.ObservedGeneration < ss.Generation { return false, nil } </ins> if ssGet.Status.Replicas != expectedReplicas { Logf(\"Waiting for stateful set status to become %d, currently %d\", expectedReplicas, ssGet.Status.Replicas) return false, nil", "commid": "kubernetes_pr_42367"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f063045a15f2f641d3790e2b25e476dde91e4310f364256ec78b76d0b285e9b4", "query": "https://k8s- do you know the statefulset owners?\ncc\nI did not see this happening until recently.\nThe controller misses that the first pod transitioned to unready and proceeds to create the second pod. The test uses a client to hit the api server and will scale up the statefulset as soon as the broken pod is observed but the controller uses caches so it may observe the scaled up statefulset quicker than the updated pod.\nI will update the test to ensure that we wait until the unreadiness is observed on StatefulSet.Status.Replicas field prior to the scaling operation\nSGTM", "positive_passages": [{"docid": "doc-en-kubernetes-221c65bce613f956c9b7306d452aa44016fea4ad6d9d9422aa936df685543fe4", "text": "if err := sst.Scale(&ss, 0); err != nil { errList = append(errList, fmt.Sprintf(\"%v\", err)) } <del> sst.waitForStatus(&ss, 0) </del> <ins> sst.WaitForStatus(&ss, 0) </ins> Logf(\"Deleting statefulset %v\", ss.Name) if err := c.Apps().StatefulSets(ss.Namespace).Delete(ss.Name, nil); err != nil { errList = append(errList, fmt.Sprintf(\"%v\", err))", "commid": "kubernetes_pr_42367"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f063045a15f2f641d3790e2b25e476dde91e4310f364256ec78b76d0b285e9b4", "query": "https://k8s- do you know the statefulset owners?\ncc\nI did not see this happening until recently.\nThe controller misses that the first pod transitioned to unready and proceeds to create the second pod. The test uses a client to hit the api server and will scale up the statefulset as soon as the broken pod is observed but the controller uses caches so it may observe the scaled up statefulset quicker than the updated pod.\nI will update the test to ensure that we wait until the unreadiness is observed on StatefulSet.Status.Replicas field prior to the scaling operation\nSGTM", "positive_passages": [{"docid": "doc-en-kubernetes-df9dad900fd539730bb82f8014f2c5d0b6f0a0a7cab673719982221cdf04214b", "text": "By(\"Before scale up finished setting 2nd pod to be not ready by breaking readiness probe\") sst.BreakProbe(ss, testProbe) <ins> sst.WaitForStatus(ss, 0) </ins> sst.WaitForRunningAndNotReady(2, ss) By(\"Continue scale operation after the 2nd pod, and scaling down to 1 replica\")", "commid": "kubernetes_pr_42367"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f063045a15f2f641d3790e2b25e476dde91e4310f364256ec78b76d0b285e9b4", "query": "https://k8s- do you know the statefulset owners?\ncc\nI did not see this happening until recently.\nThe controller misses that the first pod transitioned to unready and proceeds to create the second pod. The test uses a client to hit the api server and will scale up the statefulset as soon as the broken pod is observed but the controller uses caches so it may observe the scaled up statefulset quicker than the updated pod.\nI will update the test to ensure that we wait until the unreadiness is observed on StatefulSet.Status.Replicas field prior to the scaling operation\nSGTM", "positive_passages": [{"docid": "doc-en-kubernetes-e2788355e7491b0a1f10b051eb0f6a134fe6bd176d44984216d661d56c416938", "text": "By(\"Confirming that stateful set scale up will halt with unhealthy stateful pod\") sst.BreakProbe(ss, testProbe) sst.WaitForRunningAndNotReady(*ss.Spec.Replicas, ss) <ins> sst.WaitForStatus(ss, 0) </ins> sst.UpdateReplicas(ss, 3) sst.ConfirmStatefulPodCount(1, ss, 10*time.Second)", "commid": "kubernetes_pr_42367"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f063045a15f2f641d3790e2b25e476dde91e4310f364256ec78b76d0b285e9b4", "query": "https://k8s- do you know the statefulset owners?\ncc\nI did not see this happening until recently.\nThe controller misses that the first pod transitioned to unready and proceeds to create the second pod. The test uses a client to hit the api server and will scale up the statefulset as soon as the broken pod is observed but the controller uses caches so it may observe the scaled up statefulset quicker than the updated pod.\nI will update the test to ensure that we wait until the unreadiness is observed on StatefulSet.Status.Replicas field prior to the scaling operation\nSGTM", "positive_passages": [{"docid": "doc-en-kubernetes-5c5d00e36ce3969e4a100605509c39dcf4b5baec36827316ca42443274cd66dd", "text": "Expect(err).NotTo(HaveOccurred()) sst.BreakProbe(ss, testProbe) <ins> sst.WaitForStatus(ss, 0) </ins> sst.WaitForRunningAndNotReady(3, ss) sst.UpdateReplicas(ss, 0) sst.ConfirmStatefulPodCount(3, ss, 10*time.Second)", "commid": "kubernetes_pr_42367"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-01be90805f5b079723b5db36f29de388e9c7d6fb4142d8302d92a3b827f9a2b4", "query": "https://k8s- replica set controller maybe?\nThe rc seems to be updated almost a second after the failure. Maybe the test needs to retry\nAnd the real log for the failure is\n/assign flakes PRs at least once a day The can filter down to focus on a single test:\nFor when you have some time.\nReassign to you\nOutput of has been change in 1.6. That's why upgrade tests are failing. But I'm not sure why it is not failing 100% from the triage board. Do you know why? Output of 1.5 or earlier: Output in 1.6 or later:\nThe timeout is now. Is it reasonable to give it a little more time?\nThat timeout waits for the pods to run based on the API server. The rc controller is using its own cache so it may lag a bit before it actually updates the rc status. The test needs to retry for some time if the output we get back from describe does not match.\nIn other word, should also have its own retries.\nSGTM. Going to send a fix today.\nFYI, this test continues to flake PRs at least once per day:\nshould it show up in\nHm, this seems to fail in the upgrade tests. this failure seems to be related to an image name change as you already pointed out before. Mind finding what changed the test to use that image and fix the image name?\nIt is actually the key name has been changed in the key-value pair, not the value. As I pointed out in before expected key: now expected key:\nHm, this is unfortunate. These kubectl tests should really be unit tests.\nthe 24 hr test history is largely focused on failures right now, and this is highlighting flakes specifically (aka which tests are both passing and failing at the same commit the most often). Please follow the reports I'm sending to kubernetes-dev and related sigs. Also you can generate this info yourself using PS: also try out for finding failures (I'm sending out a separate email highlighting the biggest sources of failure). PPS: we are in the process of creating infrastructure to automate creating these reports, but automation never works as well as a fellow human asking for attention.\nWe still need to patch the release-1.4 and release-1.5 branch to make the upgrade tests passing. I will send PRs later this week.\nWe didn't fix\nThe change mentioned in was introduced in 1.6. The change covers describer and kubectl e2e test. After discussing with we think we are not going to backport the changes to 1.4 and 1.5, instead we are going to skip the tests in version skew cases. WDYT?\nshould fix this issue\nlooks like the PR is resolved, should we close?\nPlease wait until fix to be cherrypick into 1.4.\nSure! Which PR is this?\nIs it possible to cherrypick to 1.4 by just changing the milestone to 1.4?\nno you need to create a new PR with the target branch of 1.4\nReady to close?\nYup. /close", "positive_passages": [{"docid": "doc-en-kubernetes-331f31cb383acd049c9dc648455c530d45d3ace2ee570b6da0e26fe249719aca", "text": "}) // Rc <del> output := framework.RunKubectlOrDie(\"describe\", \"rc\", \"redis-master\", nsFlag) </del> requiredStrings := [][]string{ {\"Name:\", \"redis-master\"}, {\"Namespace:\", ns},", "commid": "kubernetes_pr_44512"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-01be90805f5b079723b5db36f29de388e9c7d6fb4142d8302d92a3b827f9a2b4", "query": "https://k8s- replica set controller maybe?\nThe rc seems to be updated almost a second after the failure. Maybe the test needs to retry\nAnd the real log for the failure is\n/assign flakes PRs at least once a day The can filter down to focus on a single test:\nFor when you have some time.\nReassign to you\nOutput of has been change in 1.6. That's why upgrade tests are failing. But I'm not sure why it is not failing 100% from the triage board. Do you know why? Output of 1.5 or earlier: Output in 1.6 or later:\nThe timeout is now. Is it reasonable to give it a little more time?\nThat timeout waits for the pods to run based on the API server. The rc controller is using its own cache so it may lag a bit before it actually updates the rc status. The test needs to retry for some time if the output we get back from describe does not match.\nIn other word, should also have its own retries.\nSGTM. Going to send a fix today.\nFYI, this test continues to flake PRs at least once per day:\nshould it show up in\nHm, this seems to fail in the upgrade tests. this failure seems to be related to an image name change as you already pointed out before. Mind finding what changed the test to use that image and fix the image name?\nIt is actually the key name has been changed in the key-value pair, not the value. As I pointed out in before expected key: now expected key:\nHm, this is unfortunate. These kubectl tests should really be unit tests.\nthe 24 hr test history is largely focused on failures right now, and this is highlighting flakes specifically (aka which tests are both passing and failing at the same commit the most often). Please follow the reports I'm sending to kubernetes-dev and related sigs. Also you can generate this info yourself using PS: also try out for finding failures (I'm sending out a separate email highlighting the biggest sources of failure). PPS: we are in the process of creating infrastructure to automate creating these reports, but automation never works as well as a fellow human asking for attention.\nWe still need to patch the release-1.4 and release-1.5 branch to make the upgrade tests passing. I will send PRs later this week.\nWe didn't fix\nThe change mentioned in was introduced in 1.6. The change covers describer and kubectl e2e test. After discussing with we think we are not going to backport the changes to 1.4 and 1.5, instead we are going to skip the tests in version skew cases. WDYT?\nshould fix this issue\nlooks like the PR is resolved, should we close?\nPlease wait until fix to be cherrypick into 1.4.\nSure! Which PR is this?\nIs it possible to cherrypick to 1.4 by just changing the milestone to 1.4?\nno you need to create a new PR with the target branch of 1.4\nReady to close?\nYup. /close", "positive_passages": [{"docid": "doc-en-kubernetes-15f1f38ffddfbd92977657ecbc5e796e1e2402f7c10072d58ff6870c4c36cdab", "text": "{\"Pod Template:\"}, {\"Image:\", redisImage}, {\"Events:\"}} <del> checkOutput(output, requiredStrings) </del> <ins> checkKubectlOutputWithRetry(requiredStrings, \"describe\", \"rc\", \"redis-master\", nsFlag) </ins> // Service <del> output = framework.RunKubectlOrDie(\"describe\", \"service\", \"redis-master\", nsFlag) </del> <ins> output := framework.RunKubectlOrDie(\"describe\", \"service\", \"redis-master\", nsFlag) </ins> requiredStrings = [][]string{ {\"Name:\", \"redis-master\"}, {\"Namespace:\", ns},", "commid": "kubernetes_pr_44512"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-01be90805f5b079723b5db36f29de388e9c7d6fb4142d8302d92a3b827f9a2b4", "query": "https://k8s- replica set controller maybe?\nThe rc seems to be updated almost a second after the failure. Maybe the test needs to retry\nAnd the real log for the failure is\n/assign flakes PRs at least once a day The can filter down to focus on a single test:\nFor when you have some time.\nReassign to you\nOutput of has been change in 1.6. That's why upgrade tests are failing. But I'm not sure why it is not failing 100% from the triage board. Do you know why? Output of 1.5 or earlier: Output in 1.6 or later:\nThe timeout is now. Is it reasonable to give it a little more time?\nThat timeout waits for the pods to run based on the API server. The rc controller is using its own cache so it may lag a bit before it actually updates the rc status. The test needs to retry for some time if the output we get back from describe does not match.\nIn other word, should also have its own retries.\nSGTM. Going to send a fix today.\nFYI, this test continues to flake PRs at least once per day:\nshould it show up in\nHm, this seems to fail in the upgrade tests. this failure seems to be related to an image name change as you already pointed out before. Mind finding what changed the test to use that image and fix the image name?\nIt is actually the key name has been changed in the key-value pair, not the value. As I pointed out in before expected key: now expected key:\nHm, this is unfortunate. These kubectl tests should really be unit tests.\nthe 24 hr test history is largely focused on failures right now, and this is highlighting flakes specifically (aka which tests are both passing and failing at the same commit the most often). Please follow the reports I'm sending to kubernetes-dev and related sigs. Also you can generate this info yourself using PS: also try out for finding failures (I'm sending out a separate email highlighting the biggest sources of failure). PPS: we are in the process of creating infrastructure to automate creating these reports, but automation never works as well as a fellow human asking for attention.\nWe still need to patch the release-1.4 and release-1.5 branch to make the upgrade tests passing. I will send PRs later this week.\nWe didn't fix\nThe change mentioned in was introduced in 1.6. The change covers describer and kubectl e2e test. After discussing with we think we are not going to backport the changes to 1.4 and 1.5, instead we are going to skip the tests in version skew cases. WDYT?\nshould fix this issue\nlooks like the PR is resolved, should we close?\nPlease wait until fix to be cherrypick into 1.4.\nSure! Which PR is this?\nIs it possible to cherrypick to 1.4 by just changing the milestone to 1.4?\nno you need to create a new PR with the target branch of 1.4\nReady to close?\nYup. /close", "positive_passages": [{"docid": "doc-en-kubernetes-27e1f3a0fb8e0d6d2b84ffcca5efff3378814bcf11ab4379acc09ac96526e066", "text": "}) // Checks whether the output split by line contains the required elements. <del> func checkOutput(output string, required [][]string) { </del> <ins> func checkOutputReturnError(output string, required [][]string) error { </ins> outputLines := strings.Split(output, \"n\") currentLine := 0 for _, requirement := range required {", "commid": "kubernetes_pr_44512"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-01be90805f5b079723b5db36f29de388e9c7d6fb4142d8302d92a3b827f9a2b4", "query": "https://k8s- replica set controller maybe?\nThe rc seems to be updated almost a second after the failure. Maybe the test needs to retry\nAnd the real log for the failure is\n/assign flakes PRs at least once a day The can filter down to focus on a single test:\nFor when you have some time.\nReassign to you\nOutput of has been change in 1.6. That's why upgrade tests are failing. But I'm not sure why it is not failing 100% from the triage board. Do you know why? Output of 1.5 or earlier: Output in 1.6 or later:\nThe timeout is now. Is it reasonable to give it a little more time?\nThat timeout waits for the pods to run based on the API server. The rc controller is using its own cache so it may lag a bit before it actually updates the rc status. The test needs to retry for some time if the output we get back from describe does not match.\nIn other word, should also have its own retries.\nSGTM. Going to send a fix today.\nFYI, this test continues to flake PRs at least once per day:\nshould it show up in\nHm, this seems to fail in the upgrade tests. this failure seems to be related to an image name change as you already pointed out before. Mind finding what changed the test to use that image and fix the image name?\nIt is actually the key name has been changed in the key-value pair, not the value. As I pointed out in before expected key: now expected key:\nHm, this is unfortunate. These kubectl tests should really be unit tests.\nthe 24 hr test history is largely focused on failures right now, and this is highlighting flakes specifically (aka which tests are both passing and failing at the same commit the most often). Please follow the reports I'm sending to kubernetes-dev and related sigs. Also you can generate this info yourself using PS: also try out for finding failures (I'm sending out a separate email highlighting the biggest sources of failure). PPS: we are in the process of creating infrastructure to automate creating these reports, but automation never works as well as a fellow human asking for attention.\nWe still need to patch the release-1.4 and release-1.5 branch to make the upgrade tests passing. I will send PRs later this week.\nWe didn't fix\nThe change mentioned in was introduced in 1.6. The change covers describer and kubectl e2e test. After discussing with we think we are not going to backport the changes to 1.4 and 1.5, instead we are going to skip the tests in version skew cases. WDYT?\nshould fix this issue\nlooks like the PR is resolved, should we close?\nPlease wait until fix to be cherrypick into 1.4.\nSure! Which PR is this?\nIs it possible to cherrypick to 1.4 by just changing the milestone to 1.4?\nno you need to create a new PR with the target branch of 1.4\nReady to close?\nYup. /close", "positive_passages": [{"docid": "doc-en-kubernetes-585e3c00c9dd583ab3b283ffaf7d98b2279bc5b9719be57c224f22efd8b45481", "text": "currentLine++ } if currentLine == len(outputLines) { <del> framework.Failf(\"Failed to find %s in %s\", requirement[0], output) </del> <ins> return fmt.Errorf(\"failed to find %s in %s\", requirement[0], output) </ins> } for _, item := range requirement[1:] { if !strings.Contains(outputLines[currentLine], item) { <del> framework.Failf(\"Failed to find %s in %s\", item, outputLines[currentLine]) </del> <ins> return fmt.Errorf(\"failed to find %s in %s\", item, outputLines[currentLine]) </ins> } } } <ins> return nil } func checkOutput(output string, required [][]string) { err := checkOutputReturnError(output, required) if err != nil { framework.Failf(\"%v\", err) } } func checkKubectlOutputWithRetry(required [][]string, args ...string) { var pollErr error wait.PollImmediate(time.Second, time.Minute, func() (bool, error) { output := framework.RunKubectlOrDie(args...) err := checkOutputReturnError(output, required) if err != nil { pollErr = err return false, nil } pollErr = nil return true, nil }) if pollErr != nil { framework.Failf(\"%v\", pollErr) } return </ins> } func getAPIVersions(apiEndpoint string) (*metav1.APIVersions, error) {", "commid": "kubernetes_pr_44512"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1629f917e5afb398a2ce58b7c68cfc8414afc810c0142575c793d4142fcdf0fe", "query": "We need to gracefully handle the case when a Deployment specifies an absolute value of MaxUnavailable larger than its spec.replicas. I don't think we want to add validation for this, simply collapsing maxUnavailable to spec.replicas would suffice.\nAre you working on this? I am glad to take this if not.\nfeel free to work on it", "positive_passages": [{"docid": "doc-en-kubernetes-adb0c010b376639250b0bcd03642d07e0135b06d38e87f27780a6077c8fef454", "text": "} // Error caught by validation _, maxUnavailable, _ := ResolveFenceposts(deployment.Spec.Strategy.RollingUpdate.MaxSurge, deployment.Spec.Strategy.RollingUpdate.MaxUnavailable, *(deployment.Spec.Replicas)) <ins> if maxUnavailable > *deployment.Spec.Replicas { return *deployment.Spec.Replicas } </ins> return maxUnavailable }", "commid": "kubernetes_pr_43732"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1629f917e5afb398a2ce58b7c68cfc8414afc810c0142575c793d4142fcdf0fe", "query": "We need to gracefully handle the case when a Deployment specifies an absolute value of MaxUnavailable larger than its spec.replicas. I don't think we want to add validation for this, simply collapsing maxUnavailable to spec.replicas would suffice.\nAre you working on this? I am glad to take this if not.\nfeel free to work on it", "positive_passages": [{"docid": "doc-en-kubernetes-d49eb9b532431c5cb40e37a8658f279cdb8ba5e83aeb3d692861b6908a66233e", "text": "} } } <ins> func TestMaxUnavailable(t *testing.T) { deployment := func(replicas int32, maxUnavailable intstr.IntOrString) extensions.Deployment { return extensions.Deployment{ Spec: extensions.DeploymentSpec{ Replicas: func(i int32) *int32 { return &i }(replicas), Strategy: extensions.DeploymentStrategy{ RollingUpdate: &extensions.RollingUpdateDeployment{ MaxSurge:       func(i int) *intstr.IntOrString { x := intstr.FromInt(i); return &x }(int(1)), MaxUnavailable: &maxUnavailable, }, Type: extensions.RollingUpdateDeploymentStrategyType, }, }, } } tests := []struct { name       string deployment extensions.Deployment expected   int32 }{ { name:       \"maxUnavailable less than replicas\", deployment: deployment(10, intstr.FromInt(5)), expected:   int32(5), }, { name:       \"maxUnavailable equal replicas\", deployment: deployment(10, intstr.FromInt(10)), expected:   int32(10), }, { name:       \"maxUnavailable greater than replicas\", deployment: deployment(5, intstr.FromInt(10)), expected:   int32(5), }, { name:       \"maxUnavailable with replicas is 0\", deployment: deployment(0, intstr.FromInt(10)), expected:   int32(0), }, { name: \"maxUnavailable with Recreate deployment strategy\", deployment: extensions.Deployment{ Spec: extensions.DeploymentSpec{ Strategy: extensions.DeploymentStrategy{ Type: extensions.RecreateDeploymentStrategyType, }, }, }, expected: int32(0), }, { name:       \"maxUnavailable less than replicas with percents\", deployment: deployment(10, intstr.FromString(\"50%\")), expected:   int32(5), }, { name:       \"maxUnavailable equal replicas with percents\", deployment: deployment(10, intstr.FromString(\"100%\")), expected:   int32(10), }, { name:       \"maxUnavailable greater than replicas with percents\", deployment: deployment(5, intstr.FromString(\"100%\")), expected:   int32(5), }, } for _, test := range tests { t.Log(test.name) maxUnavailable := MaxUnavailable(test.deployment) if test.expected != maxUnavailable { t.Fatalf(\"expected:%v, got:%v\", test.expected, maxUnavailable) } } } </ins>", "commid": "kubernetes_pr_43732"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-05a35484a6fb3e3b632cb2c2bc09c0a13c7491426c4df503e3be004f93099a07", "query": "When patching, in the type decoded from ToUnstructured mismatch with the one decoded form json.Unmarshal for numbers. Example: port: 80 in original object has type int64 port: 80 in original object has type float64 This is the root cause of", "positive_passages": [{"docid": "doc-en-kubernetes-caa27a13b30305c0ea696e07c1c4b7547a099699c8ce96d0b673aad133fcd7b4", "text": "package handlers import ( <del> \"encoding/json\" </del> \"fmt\" \"k8s.io/apimachinery/pkg/conversion/unstructured\" \"k8s.io/apimachinery/pkg/runtime\" \"k8s.io/apimachinery/pkg/types\" <ins> \"k8s.io/apimachinery/pkg/util/json\" </ins> \"k8s.io/apimachinery/pkg/util/strategicpatch\" \"github.com/evanphx/json-patch\"", "commid": "kubernetes_pr_42489"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-05a35484a6fb3e3b632cb2c2bc09c0a13c7491426c4df503e3be004f93099a07", "query": "When patching, in the type decoded from ToUnstructured mismatch with the one decoded form json.Unmarshal for numbers. Example: port: 80 in original object has type int64 port: 80 in original object has type float64 This is the root cause of", "positive_passages": [{"docid": "doc-en-kubernetes-5cd4b8ef247018b50fef5bb87f26b5c9b37fce693b6e7ff16a433a1eec5643ad", "text": "} <ins> func TestNumberConversion(t *testing.T) { codec := api.Codecs.LegacyCodec(schema.GroupVersion{Version: \"v1\"}) currentVersionedObject := &v1.Service{ TypeMeta:   metav1.TypeMeta{Kind: \"Service\", APIVersion: \"v1\"}, ObjectMeta: metav1.ObjectMeta{Name: \"test-service\"}, Spec: v1.ServiceSpec{ Ports: []v1.ServicePort{ { Port:     80, Protocol: \"TCP\", NodePort: 31678, }, }, }, } versionedObjToUpdate := &v1.Service{} versionedObj := &v1.Service{} patchJS := []byte(`{\"spec\":{\"ports\":[{\"port\":80,\"nodePort\":31789}]}}`) _, _, err := strategicPatchObject(codec, currentVersionedObject, patchJS, versionedObjToUpdate, versionedObj) if err != nil { t.Fatal(err) } ports := versionedObjToUpdate.Spec.Ports if len(ports) != 1 || ports[0].Port != 80 || ports[0].NodePort != 31789 { t.Fatal(errors.New(\"Ports failed to merge because of number conversion issue\")) } } </ins> func TestPatchResourceWithVersionConflict(t *testing.T) { namespace := \"bar\" name := \"foo\"", "commid": "kubernetes_pr_42489"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-05a35484a6fb3e3b632cb2c2bc09c0a13c7491426c4df503e3be004f93099a07", "query": "When patching, in the type decoded from ToUnstructured mismatch with the one decoded form json.Unmarshal for numbers. Example: port: 80 in original object has type int64 port: 80 in original object has type float64 This is the root cause of", "positive_passages": [{"docid": "doc-en-kubernetes-fc5e7118017922dd322a7f5d28d9f02e6c848765c74111cdfaa2e46e8b208d07", "text": "\"//vendor:k8s.io/apimachinery/pkg/runtime/serializer/streaming\", \"//vendor:k8s.io/apimachinery/pkg/types\", \"//vendor:k8s.io/apimachinery/pkg/util/httpstream\", <ins> \"//vendor:k8s.io/apimachinery/pkg/util/json\", </ins> \"//vendor:k8s.io/apimachinery/pkg/util/mergepatch\", \"//vendor:k8s.io/apimachinery/pkg/util/net\", \"//vendor:k8s.io/apimachinery/pkg/util/runtime\",", "commid": "kubernetes_pr_42489"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-092a2c271f463c8f9716c9adec149fd83ba8b319995452bb190dfdefdb7e8e39", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Kubernetes version (use ): master What happened: The functionality is hidden in a large function, and not explicit, testable. What you expected to happen: The logic of should read more clearly, with tests for individual filters.\nhas a PR for this .\nFew more things include removing limits in entries like\nyeah, im not sure why the thing is there, after all they are just appending to the slice and the limit wont have an effect , from what i can tell, will it? probably good idea to remove unless im missing something.\nIts part of part of PR too.", "positive_passages": [{"docid": "doc-en-kubernetes-c71c02347886caae4c96258af58bb7beb9c4bb61cc641b8273dcb13f328ad230", "text": "// Returns selectors of services, RCs and RSs matching the given pod. func getSelectors(pod *v1.Pod, sl algorithm.ServiceLister, cl algorithm.ControllerLister, rsl algorithm.ReplicaSetLister, ssl algorithm.StatefulSetLister) []labels.Selector { <del> selectors := make([]labels.Selector, 0, 3) </del> <ins> var selectors []labels.Selector </ins> if services, err := sl.GetPodServices(pod); err == nil { for _, service := range services { selectors = append(selectors, labels.SelectorFromSet(service.Spec.Selector))", "commid": "kubernetes_pr_42578"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-092a2c271f463c8f9716c9adec149fd83ba8b319995452bb190dfdefdb7e8e39", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Kubernetes version (use ): master What happened: The functionality is hidden in a large function, and not explicit, testable. What you expected to happen: The logic of should read more clearly, with tests for individual filters.\nhas a PR for this .\nFew more things include removing limits in entries like\nyeah, im not sure why the thing is there, after all they are just appending to the slice and the limit wont have an effect , from what i can tell, will it? probably good idea to remove unless im missing something.\nIts part of part of PR too.", "positive_passages": [{"docid": "doc-en-kubernetes-49fba98956d3de036187082d6db5f8a939e22fe65f3398d986de719585dbb70a", "text": "return antiAffinity.CalculateAntiAffinityPriority } <ins> // Classifies nodes into ones with labels and without labels. func (s *ServiceAntiAffinity) getNodeClassificationByLabels(nodes []*v1.Node) (map[string]string, []string) { labeledNodes := map[string]string{} nonLabeledNodes := []string{} for _, node := range nodes { if labels.Set(node.Labels).Has(s.label) { label := labels.Set(node.Labels).Get(s.label) labeledNodes[node.Name] = label } else { nonLabeledNodes = append(nonLabeledNodes, node.Name) } } return labeledNodes, nonLabeledNodes } </ins> // CalculateAntiAffinityPriority spreads pods by minimizing the number of pods belonging to the same service // on machines with the same value for a particular label. // The label to be considered is provided to the struct (ServiceAntiAffinity).", "commid": "kubernetes_pr_42578"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-092a2c271f463c8f9716c9adec149fd83ba8b319995452bb190dfdefdb7e8e39", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Kubernetes version (use ): master What happened: The functionality is hidden in a large function, and not explicit, testable. What you expected to happen: The logic of should read more clearly, with tests for individual filters.\nhas a PR for this .\nFew more things include removing limits in entries like\nyeah, im not sure why the thing is there, after all they are just appending to the slice and the limit wont have an effect , from what i can tell, will it? probably good idea to remove unless im missing something.\nIts part of part of PR too.", "positive_passages": [{"docid": "doc-en-kubernetes-bde1cb7287ab8c5ce4267e5b00aaf1bafc24be69601e04408930fb0339436235", "text": "} // separate out the nodes that have the label from the ones that don't <del> otherNodes := []string{} labeledNodes := map[string]string{} for _, node := range nodes { if labels.Set(node.Labels).Has(s.label) { label := labels.Set(node.Labels).Get(s.label) labeledNodes[node.Name] = label } else { otherNodes = append(otherNodes, node.Name) } } </del> <ins> labeledNodes, nonLabeledNodes := s.getNodeClassificationByLabels(nodes) </ins> podCounts := map[string]int{} for _, pod := range nsServicePods { label, exists := labeledNodes[pod.Spec.NodeName]", "commid": "kubernetes_pr_42578"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-092a2c271f463c8f9716c9adec149fd83ba8b319995452bb190dfdefdb7e8e39", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Kubernetes version (use ): master What happened: The functionality is hidden in a large function, and not explicit, testable. What you expected to happen: The logic of should read more clearly, with tests for individual filters.\nhas a PR for this .\nFew more things include removing limits in entries like\nyeah, im not sure why the thing is there, after all they are just appending to the slice and the limit wont have an effect , from what i can tell, will it? probably good idea to remove unless im missing something.\nIts part of part of PR too.", "positive_passages": [{"docid": "doc-en-kubernetes-83069e4c4d7abe023824c517d3a470d7ca4f3ff969eb9a94fcb57df8ffeb028d", "text": "} podCounts[label]++ } numServicePods := len(nsServicePods) result := []schedulerapi.HostPriority{} //score int - scale of 0-maxPriority", "commid": "kubernetes_pr_42578"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-092a2c271f463c8f9716c9adec149fd83ba8b319995452bb190dfdefdb7e8e39", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Kubernetes version (use ): master What happened: The functionality is hidden in a large function, and not explicit, testable. What you expected to happen: The logic of should read more clearly, with tests for individual filters.\nhas a PR for this .\nFew more things include removing limits in entries like\nyeah, im not sure why the thing is there, after all they are just appending to the slice and the limit wont have an effect , from what i can tell, will it? probably good idea to remove unless im missing something.\nIts part of part of PR too.", "positive_passages": [{"docid": "doc-en-kubernetes-57bf4388b9ba1f2b4271dae13ba724b0e14a4afcf7189cfb42af98cb9734f759", "text": "result = append(result, schedulerapi.HostPriority{Host: node, Score: int(fScore)}) } // add the open nodes with a score of 0 <del> for _, node := range otherNodes { </del> <ins> for _, node := range nonLabeledNodes { </ins> result = append(result, schedulerapi.HostPriority{Host: node, Score: 0}) } return result, nil }", "commid": "kubernetes_pr_42578"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-092a2c271f463c8f9716c9adec149fd83ba8b319995452bb190dfdefdb7e8e39", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Kubernetes version (use ): master What happened: The functionality is hidden in a large function, and not explicit, testable. What you expected to happen: The logic of should read more clearly, with tests for individual filters.\nhas a PR for this .\nFew more things include removing limits in entries like\nyeah, im not sure why the thing is there, after all they are just appending to the slice and the limit wont have an effect , from what i can tell, will it? probably good idea to remove unless im missing something.\nIts part of part of PR too.", "positive_passages": [{"docid": "doc-en-kubernetes-3ece106d1a7e9b44ddc82d2c9485299f1acfb5e56d7c59c34414a3ea55b22ae8", "text": "} } <ins> func TestGetNodeClassificationByLabels(t *testing.T) { const machine01 = \"machine01\" const machine02 = \"machine02\" const zoneA = \"zoneA\" zone1 := map[string]string{ \"zone\": zoneA, } labeledNodes := map[string]map[string]string{ machine01: zone1, } expectedNonLabeledNodes := []string{machine02} serviceAffinity := ServiceAntiAffinity{label: \"zone\"} newLabeledNodes, noNonLabeledNodes := serviceAffinity.getNodeClassificationByLabels(makeLabeledNodeList(labeledNodes)) noLabeledNodes, newnonLabeledNodes := serviceAffinity.getNodeClassificationByLabels(makeNodeList(expectedNonLabeledNodes)) label, _ := newLabeledNodes[machine01] if label != zoneA && len(noNonLabeledNodes) != 0 { t.Errorf(\"Expected only labeled node with label zoneA and no noNonLabeledNodes\") } if len(noLabeledNodes) != 0 && newnonLabeledNodes[0] != machine02 { t.Errorf(\"Expected only non labled nodes\") } } </ins> func makeLabeledNodeList(nodeMap map[string]map[string]string) []*v1.Node { nodes := make([]*v1.Node, 0, len(nodeMap)) for nodeName, labels := range nodeMap {", "commid": "kubernetes_pr_42578"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fe8cd1417ccecb69a119143da34e7328b16728970aada998527fd4ee6dea436e", "query": "Kubernetes version (use ): Environment: Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): container-os Kernel (e.g. ): Linux gke-wordpress-cluster-default-pool--m764 4.4.21+ SMP Fri Feb 17 15:34:45 PST 2017 x86_64 Intel(R) Xeon(R) CPU @ 2.60GHz GenuineIntel GNU/Linux Install tools: Others: What happened: ` I was able to bring up wordpress okay the first time, except GKE wasn't creating loadbalancer ips due to a quota issue, which I resolved, note at this point the mysql pod was up and had attached to it's volume. Upon deleting the wordpress deployment and creating it again I started getting the above errors. I deleted the mysql pod as well and brought it up again to see that it had the same issue. The volumes are backed by a gluster cluster on GCE. Looking at the brick logs on one of the gluster nodes I see I've tried restarting kubelet on the node. I can't find the kubelet log file on any of gke nodes. And I don't know how to get the kube-controller and apiserver logs from the master (GKE). I suspect it's a failing of the glusterfs client on the gke nodes? What you expected to happen: Deployment to mount the volumes successfully. How to reproduce it (as minimally and precisely as possible): Not sure how, but I've run into this intermittently Anything else we need to know: The volumes are backed by gluster\n/cc\nIf you delete pod and create pods soon, it is possible that you could see some errors like \"timeout expired waiting for volumes to attach/mount\" temporally. Could you wait for a few more minutes to see whether the pods could be started correctly?\nI actually tried that, deleted the pods, then waited 5 minutes and recreated them with the same error. Maybe it wasn't long enough\nCan you post output of ? It may have some other events for failure..\nI deleted the cluster this afternoon, but I checked constantly and those were the only errors, Timeout on mount and a failed to sync error\nIf you use level 4 log, it should also give the detailed messages of failed mount so that we can figure out why it failed.\nCan you email me your project name, cluster name, and zone information? I can take a look at the master logs to see if there's anything useful there.\nThis is starting to happen more frequently..\ncould you provide more details about in what situation it happened frequently? Kubelet log could give us more information. If you use GKE cluster, run \"journctlctl -u kubelet /tmp/log\" to get the log. You could also share with us the log if it is ok.\nThis seems to be the relevant part of the log I re-created that and my pods sprang back up. Weird thing is I had created that, along with the pvcs and pvs but seems it's somehow getting deleted. There's almost certainly certain I'm doing wrong but I'm not sure what. ]\nHI Jonathan, can you clarify what you had to recreate?\nThe glusterfs endpoints , Michelle Au <:\nI have a very similar problem running OpenShift 3.4 in AWS EC2 doing the same exact thing. Brand new OSE install [root master]# oc version oc v3.4.1.12 kubernetes v1.4.0+ features: Basic-Auth GSSAPI Kerberos SPNEGO Server https://172.31.40.126:8443 openshift v3.4.1.12 kubernetes v1.4.0+ POD in question is the docker-registry (kind of important for OSE to work) I've followed this to see if it would fix the issue: But no luck or change. Error syncing pod, skipping: timeout expired waiting for volumes to attach/mount for pod \"docker-registry-3-afbbt\"/\"default\". list of unattached/unmounted volumes=[registry-storage] then: Unable to mount volumes for pod \"docker-registry-3-afbbt_default(-1a45-11e7-abf8-)\": timeout expired waiting for volumes to attach/mount for pod \"docker-registry-3-afbbt\"/\"default\". list of unattached/unmounted volumes=[registry-storage] I have no idea what log(s) to look at, this was of no help when I deployed a new docker-registry: oc logs -f dc/docker-registry Any help or guidance would be greatly appreciated as this is a blocker issue for me. thanks and best wishes,\nare you using glusterfs for registry-storage volume or other type of volume? Could you share us your kubelet log if possible over slack Thanks!\nHi Jing Xu, Would you know where this log would be? Or is the name kublet<somethingso I may find it for you? I just requested to join the slack channel, as soon as I'm signed in I will share the log. Probably tomorrow as I'm on the east coast USA Thank you! Joel\nFor you are using GKE with GCI image, you can use \"journalctl -u kubelet \" to get the log. Otherwise, it should be in \" , shepp67 <:\nI also experienced this. Kubernetes version:Cloud provider or hardware configuration: OpenStack OS (e.g. from /etc/os-release): Ubuntu 16.04.1 LTS Kernel (e.g. ): Install tools: custom That kubernetes worker vm actually had volumes attached. I saw it on OpenStack dashboard. But: and actually: Besides, this is a new worker vm. I have other worker vms already running, using cinder volumes and there were no such errors. I use Helm to deploy this Pod. I have deployed it earlier and removed it. But it was 2 days ago. I found the solution here: . On that worker vm I run: Edit: or upgrade Kubernetes to = 1.6.0-beta.3 I don't know if this is the solution to issue.\nI'm seeing this same error on all my manually launched private Ubuntu based clusters (6), running 1.5.3 and 1.6.0. In my case the messages reference only stopped pods launched by CronJob Jobs. The messages indicate issues mounting every volume in the pod including PVs and node-local volumes. These pods, and future ones launched by these CronJobs, are fully successful when they run. It is only after they run to successful completion and exit that these messages show up. Glancing at the kubelet code, this appears to be coming out of some housekeeping/synch loop.\nI've identified a bug and am working on a fix for when \"Unable to mount volumes for pod...\" + \"Error syncing pod\" happen indefinitely BUT the pod is actually running just fine, as observed by . For others, if you see this message but your pod is Running, you can safely ignore it. It's caused by a small limitation of the reconstruction of state (what volumes are mounted) so there is a chance you will see this only if you restart kubelet while your pods had volumes mounted. correction: you say they even Completed, they weren't just Running fine. So yeah, it's just misleading logging and not really an indication of anything breaking\nBecause the error message is very generic, I think there might be different problems mentioned in this thread. 's issue could be fixed by 's PR are you still have any issues with mount? could you also let us know whether you still have the issue? Thanks! Jing\nHi my issue was related to which helped me sort out. I was creating the gluster endpoints without a service and turns out the kube-controller deletes all such endpoints that are not attached to a service at regular intervals. So after every so often when a pod went down and tried to come up again and mount its respective pv it failed because it couldn't connect to gluster. The fix is to create a service for the gluster endpoints.\nI also just ran into such timeout issue: After running a load test against my postgres backed web application, the database didn't respond anymore for still unknown reasons. According to kubernetes it was up and running The log showed a bunch of these messages. Not sure yet why but possibly it couldn't access the volume anymore: Short after that, the pod entered \"error\" state: The event log showed: This error disappeared after a few minutes (not sure how long exactly, but it took a while), but then I got the same error as described here: I couldn't figure out anything more on my own. Nothing in the syslog, nothing more than this in the kubelet log. Finally I rebooted the machine which fixed the issue.\ncc do you know what error of the network not ready? It might be helpful if you could share the kubelet log with us to debug. Thanks!\nAFAIK, the \"network not ready error\" is benign, kubelet will retry after this error () cc\nI hope I didn't miss some secrets in there, quite a talky log. But here it is: The database didn't respond anymore because it ran OOM and was killed, as also shown in the log. Although it appears like it was OOM killed after it became unresponsive in the log.. Either way, a bunch of other things got killed too, so granted - \"not ideal\" situation :). Yet it shouldn't drop the volume and should re-attach it.\nI think you are hitting the issue mentioned above. He has a PR to fix it. I will make sure it can merge soon. Thanks!\nGreat, thanks! Do you know roughly when this will be available in GCE?\nyou mean GKE or GCE? For GKE it will take a little bit longer. On GCE, when the PR gets merged, the fix should be available when the next release is out (I think should be soon)\nRunning on GKE. I'd rather not launch my product with this bug around. Is there a workaround for it or something I can monitor for? Or maybe it could get hot fixed on GKE? If there is no workaround, this effectively renders GKE useless for stateful stuff.\nIt's hard to say if volumes are actually being dropped/unmounted or if the FailedMount errors are wrong & misleading, so I wouldn't go so far as to say it's broken because of some volume issues. It could be something else entirely. If nothing else, the PR jing's referring to will clean up the event noise and help us debug the root cause. In the meantime, I wouldn't trust the FailedMount events to be accurate, so if your applications are unresponsive, there may be other causes worth considering\nWell, I only can say that my volumes were dropped and it didn't recover on it's own (only after reboot). Dropped a seen by kubernetes, dunno if the volumes were still attached but they weren't usable by my scheduled database. To be clear: I'm not \"complaining\" and this was just test/R&D, but it would this is the scariest kind of issue for me to happen in prod, given that it's a managed service where I can't find a workaround on my own. Rebooting fixed it in my case, but that's a big hammer..\nYou don't need to reboot the node. Delete the pod and restart it should work for this issue. Is this workaround ok for your case? , discordianfish <:\nGood to know, thanks! Will try this next time.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nHi, I'm facing the same issue with k8s 1.9, installed by kops on AWS. volume created successfully on AWS and attached to the right node, but the pod is failed to start.\n/remove-lifecycle stale\ncould you please provide more details about your issue? What are the steps to reproduce it? Thanks!\nyeah can you open a new bug for EBS and cc me with details? I was hoping we fixed most of EBS problems in 1.9 - I will be more than happy to walk through and find what is causing volume to not mount. As I understand this is different from typical EBS problems where volume fails to attach. In your case, volume is being attached to right node but it is not being seen by kubelet.\nI found the issue, and it was the fact that i used c5 instances with nvme, this is why the volume never been attached as k8s looking for /dev/xvdXX and with nvme that path is different. I did notice that in 1.9 k8s should support nvme natively but it seems that it's still not stable. thanks\noh weird. You should open a bug about NVMe support then. I was thinking it would just work.\ncc Is there an issue related to nvme support? please let us know any issues you still have with 1.9. Thanks!\nThis is nvme on AWS, not related to the work is doing on gce.\nThanks Definitely related to NVMe support. Ran into this trying to mount a gp2 EBS volume on a node which was an m5 EC2 instance.\nI think I am seeing like this with , but unsure of \"why\" at the moment. It would seem works perfectly fine.\ndid you guys had a chance to open a BUG for NVMe support on EBS? If you do - please paste output of and PersistentVolume spec. We can't fix it unless we know bit more. :(\nsorry, we worked around this by reverting back to m4 class instances. It should be simple enough to reproduce however... create a k8s cluster w/ m5 EBS backed nodes and create a simple pod w/ a persistent volume. You'll notice that the pod will never launch and you should be able to debug further. If I do run into this again I'll be sure to get some more data for you.\nI too have the error, error syncing pod. kubectl describe pod kafka1-kafka-0 .... .... .... Warning FailedSync 5m (x141 over 35m) kubelet, 10.186.. Error syncing pod Warning BackOff 57s (x164 over 35m) kubelet, 10.186.. Back-off restarting failed container kubectl logs kafka1-kafka-0 -p export KAFKABROKERID=kafka1-kafka-0 export KAFKAADVERTISEDLISTENERS=PLAINTEXT://172.30.*.:9092 /etc/confluent/docker/run sh: 3: /etc/confluent/docker/run: not found", "positive_passages": [{"docid": "doc-en-kubernetes-28a49384ed5115e52fd0ea2ccd9a71595e97ec2b4446a4fbafc5fc14b0a4bc59", "text": "openssh-client  nfs-common  socat  <ins> udev  </ins> util-linux COPY cni-bin/bin /opt/cni/bin", "commid": "kubernetes_pr_61357"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fe8cd1417ccecb69a119143da34e7328b16728970aada998527fd4ee6dea436e", "query": "Kubernetes version (use ): Environment: Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): container-os Kernel (e.g. ): Linux gke-wordpress-cluster-default-pool--m764 4.4.21+ SMP Fri Feb 17 15:34:45 PST 2017 x86_64 Intel(R) Xeon(R) CPU @ 2.60GHz GenuineIntel GNU/Linux Install tools: Others: What happened: ` I was able to bring up wordpress okay the first time, except GKE wasn't creating loadbalancer ips due to a quota issue, which I resolved, note at this point the mysql pod was up and had attached to it's volume. Upon deleting the wordpress deployment and creating it again I started getting the above errors. I deleted the mysql pod as well and brought it up again to see that it had the same issue. The volumes are backed by a gluster cluster on GCE. Looking at the brick logs on one of the gluster nodes I see I've tried restarting kubelet on the node. I can't find the kubelet log file on any of gke nodes. And I don't know how to get the kube-controller and apiserver logs from the master (GKE). I suspect it's a failing of the glusterfs client on the gke nodes? What you expected to happen: Deployment to mount the volumes successfully. How to reproduce it (as minimally and precisely as possible): Not sure how, but I've run into this intermittently Anything else we need to know: The volumes are backed by gluster\n/cc\nIf you delete pod and create pods soon, it is possible that you could see some errors like \"timeout expired waiting for volumes to attach/mount\" temporally. Could you wait for a few more minutes to see whether the pods could be started correctly?\nI actually tried that, deleted the pods, then waited 5 minutes and recreated them with the same error. Maybe it wasn't long enough\nCan you post output of ? It may have some other events for failure..\nI deleted the cluster this afternoon, but I checked constantly and those were the only errors, Timeout on mount and a failed to sync error\nIf you use level 4 log, it should also give the detailed messages of failed mount so that we can figure out why it failed.\nCan you email me your project name, cluster name, and zone information? I can take a look at the master logs to see if there's anything useful there.\nThis is starting to happen more frequently..\ncould you provide more details about in what situation it happened frequently? Kubelet log could give us more information. If you use GKE cluster, run \"journctlctl -u kubelet /tmp/log\" to get the log. You could also share with us the log if it is ok.\nThis seems to be the relevant part of the log I re-created that and my pods sprang back up. Weird thing is I had created that, along with the pvcs and pvs but seems it's somehow getting deleted. There's almost certainly certain I'm doing wrong but I'm not sure what. ]\nHI Jonathan, can you clarify what you had to recreate?\nThe glusterfs endpoints , Michelle Au <:\nI have a very similar problem running OpenShift 3.4 in AWS EC2 doing the same exact thing. Brand new OSE install [root master]# oc version oc v3.4.1.12 kubernetes v1.4.0+ features: Basic-Auth GSSAPI Kerberos SPNEGO Server https://172.31.40.126:8443 openshift v3.4.1.12 kubernetes v1.4.0+ POD in question is the docker-registry (kind of important for OSE to work) I've followed this to see if it would fix the issue: But no luck or change. Error syncing pod, skipping: timeout expired waiting for volumes to attach/mount for pod \"docker-registry-3-afbbt\"/\"default\". list of unattached/unmounted volumes=[registry-storage] then: Unable to mount volumes for pod \"docker-registry-3-afbbt_default(-1a45-11e7-abf8-)\": timeout expired waiting for volumes to attach/mount for pod \"docker-registry-3-afbbt\"/\"default\". list of unattached/unmounted volumes=[registry-storage] I have no idea what log(s) to look at, this was of no help when I deployed a new docker-registry: oc logs -f dc/docker-registry Any help or guidance would be greatly appreciated as this is a blocker issue for me. thanks and best wishes,\nare you using glusterfs for registry-storage volume or other type of volume? Could you share us your kubelet log if possible over slack Thanks!\nHi Jing Xu, Would you know where this log would be? Or is the name kublet<somethingso I may find it for you? I just requested to join the slack channel, as soon as I'm signed in I will share the log. Probably tomorrow as I'm on the east coast USA Thank you! Joel\nFor you are using GKE with GCI image, you can use \"journalctl -u kubelet \" to get the log. Otherwise, it should be in \" , shepp67 <:\nI also experienced this. Kubernetes version:Cloud provider or hardware configuration: OpenStack OS (e.g. from /etc/os-release): Ubuntu 16.04.1 LTS Kernel (e.g. ): Install tools: custom That kubernetes worker vm actually had volumes attached. I saw it on OpenStack dashboard. But: and actually: Besides, this is a new worker vm. I have other worker vms already running, using cinder volumes and there were no such errors. I use Helm to deploy this Pod. I have deployed it earlier and removed it. But it was 2 days ago. I found the solution here: . On that worker vm I run: Edit: or upgrade Kubernetes to = 1.6.0-beta.3 I don't know if this is the solution to issue.\nI'm seeing this same error on all my manually launched private Ubuntu based clusters (6), running 1.5.3 and 1.6.0. In my case the messages reference only stopped pods launched by CronJob Jobs. The messages indicate issues mounting every volume in the pod including PVs and node-local volumes. These pods, and future ones launched by these CronJobs, are fully successful when they run. It is only after they run to successful completion and exit that these messages show up. Glancing at the kubelet code, this appears to be coming out of some housekeeping/synch loop.\nI've identified a bug and am working on a fix for when \"Unable to mount volumes for pod...\" + \"Error syncing pod\" happen indefinitely BUT the pod is actually running just fine, as observed by . For others, if you see this message but your pod is Running, you can safely ignore it. It's caused by a small limitation of the reconstruction of state (what volumes are mounted) so there is a chance you will see this only if you restart kubelet while your pods had volumes mounted. correction: you say they even Completed, they weren't just Running fine. So yeah, it's just misleading logging and not really an indication of anything breaking\nBecause the error message is very generic, I think there might be different problems mentioned in this thread. 's issue could be fixed by 's PR are you still have any issues with mount? could you also let us know whether you still have the issue? Thanks! Jing\nHi my issue was related to which helped me sort out. I was creating the gluster endpoints without a service and turns out the kube-controller deletes all such endpoints that are not attached to a service at regular intervals. So after every so often when a pod went down and tried to come up again and mount its respective pv it failed because it couldn't connect to gluster. The fix is to create a service for the gluster endpoints.\nI also just ran into such timeout issue: After running a load test against my postgres backed web application, the database didn't respond anymore for still unknown reasons. According to kubernetes it was up and running The log showed a bunch of these messages. Not sure yet why but possibly it couldn't access the volume anymore: Short after that, the pod entered \"error\" state: The event log showed: This error disappeared after a few minutes (not sure how long exactly, but it took a while), but then I got the same error as described here: I couldn't figure out anything more on my own. Nothing in the syslog, nothing more than this in the kubelet log. Finally I rebooted the machine which fixed the issue.\ncc do you know what error of the network not ready? It might be helpful if you could share the kubelet log with us to debug. Thanks!\nAFAIK, the \"network not ready error\" is benign, kubelet will retry after this error () cc\nI hope I didn't miss some secrets in there, quite a talky log. But here it is: The database didn't respond anymore because it ran OOM and was killed, as also shown in the log. Although it appears like it was OOM killed after it became unresponsive in the log.. Either way, a bunch of other things got killed too, so granted - \"not ideal\" situation :). Yet it shouldn't drop the volume and should re-attach it.\nI think you are hitting the issue mentioned above. He has a PR to fix it. I will make sure it can merge soon. Thanks!\nGreat, thanks! Do you know roughly when this will be available in GCE?\nyou mean GKE or GCE? For GKE it will take a little bit longer. On GCE, when the PR gets merged, the fix should be available when the next release is out (I think should be soon)\nRunning on GKE. I'd rather not launch my product with this bug around. Is there a workaround for it or something I can monitor for? Or maybe it could get hot fixed on GKE? If there is no workaround, this effectively renders GKE useless for stateful stuff.\nIt's hard to say if volumes are actually being dropped/unmounted or if the FailedMount errors are wrong & misleading, so I wouldn't go so far as to say it's broken because of some volume issues. It could be something else entirely. If nothing else, the PR jing's referring to will clean up the event noise and help us debug the root cause. In the meantime, I wouldn't trust the FailedMount events to be accurate, so if your applications are unresponsive, there may be other causes worth considering\nWell, I only can say that my volumes were dropped and it didn't recover on it's own (only after reboot). Dropped a seen by kubernetes, dunno if the volumes were still attached but they weren't usable by my scheduled database. To be clear: I'm not \"complaining\" and this was just test/R&D, but it would this is the scariest kind of issue for me to happen in prod, given that it's a managed service where I can't find a workaround on my own. Rebooting fixed it in my case, but that's a big hammer..\nYou don't need to reboot the node. Delete the pod and restart it should work for this issue. Is this workaround ok for your case? , discordianfish <:\nGood to know, thanks! Will try this next time.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nHi, I'm facing the same issue with k8s 1.9, installed by kops on AWS. volume created successfully on AWS and attached to the right node, but the pod is failed to start.\n/remove-lifecycle stale\ncould you please provide more details about your issue? What are the steps to reproduce it? Thanks!\nyeah can you open a new bug for EBS and cc me with details? I was hoping we fixed most of EBS problems in 1.9 - I will be more than happy to walk through and find what is causing volume to not mount. As I understand this is different from typical EBS problems where volume fails to attach. In your case, volume is being attached to right node but it is not being seen by kubelet.\nI found the issue, and it was the fact that i used c5 instances with nvme, this is why the volume never been attached as k8s looking for /dev/xvdXX and with nvme that path is different. I did notice that in 1.9 k8s should support nvme natively but it seems that it's still not stable. thanks\noh weird. You should open a bug about NVMe support then. I was thinking it would just work.\ncc Is there an issue related to nvme support? please let us know any issues you still have with 1.9. Thanks!\nThis is nvme on AWS, not related to the work is doing on gce.\nThanks Definitely related to NVMe support. Ran into this trying to mount a gp2 EBS volume on a node which was an m5 EC2 instance.\nI think I am seeing like this with , but unsure of \"why\" at the moment. It would seem works perfectly fine.\ndid you guys had a chance to open a BUG for NVMe support on EBS? If you do - please paste output of and PersistentVolume spec. We can't fix it unless we know bit more. :(\nsorry, we worked around this by reverting back to m4 class instances. It should be simple enough to reproduce however... create a k8s cluster w/ m5 EBS backed nodes and create a simple pod w/ a persistent volume. You'll notice that the pod will never launch and you should be able to debug further. If I do run into this again I'll be sure to get some more data for you.\nI too have the error, error syncing pod. kubectl describe pod kafka1-kafka-0 .... .... .... Warning FailedSync 5m (x141 over 35m) kubelet, 10.186.. Error syncing pod Warning BackOff 57s (x164 over 35m) kubelet, 10.186.. Back-off restarting failed container kubectl logs kafka1-kafka-0 -p export KAFKABROKERID=kafka1-kafka-0 export KAFKAADVERTISEDLISTENERS=PLAINTEXT://172.30.*.:9092 /etc/confluent/docker/run sh: 3: /etc/confluent/docker/run: not found", "positive_passages": [{"docid": "doc-en-kubernetes-b6ab816fb56fac291aeed1968a82aef4f505127371face0f524719ea49fbb103", "text": "REGISTRY?=staging-k8s.gcr.io IMAGE?=debian-hyperkube-base <del> TAG=0.9 </del> <ins> TAG=0.10 </ins> ARCH?=amd64 CACHEBUST?=1", "commid": "kubernetes_pr_61357"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fe8cd1417ccecb69a119143da34e7328b16728970aada998527fd4ee6dea436e", "query": "Kubernetes version (use ): Environment: Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): container-os Kernel (e.g. ): Linux gke-wordpress-cluster-default-pool--m764 4.4.21+ SMP Fri Feb 17 15:34:45 PST 2017 x86_64 Intel(R) Xeon(R) CPU @ 2.60GHz GenuineIntel GNU/Linux Install tools: Others: What happened: ` I was able to bring up wordpress okay the first time, except GKE wasn't creating loadbalancer ips due to a quota issue, which I resolved, note at this point the mysql pod was up and had attached to it's volume. Upon deleting the wordpress deployment and creating it again I started getting the above errors. I deleted the mysql pod as well and brought it up again to see that it had the same issue. The volumes are backed by a gluster cluster on GCE. Looking at the brick logs on one of the gluster nodes I see I've tried restarting kubelet on the node. I can't find the kubelet log file on any of gke nodes. And I don't know how to get the kube-controller and apiserver logs from the master (GKE). I suspect it's a failing of the glusterfs client on the gke nodes? What you expected to happen: Deployment to mount the volumes successfully. How to reproduce it (as minimally and precisely as possible): Not sure how, but I've run into this intermittently Anything else we need to know: The volumes are backed by gluster\n/cc\nIf you delete pod and create pods soon, it is possible that you could see some errors like \"timeout expired waiting for volumes to attach/mount\" temporally. Could you wait for a few more minutes to see whether the pods could be started correctly?\nI actually tried that, deleted the pods, then waited 5 minutes and recreated them with the same error. Maybe it wasn't long enough\nCan you post output of ? It may have some other events for failure..\nI deleted the cluster this afternoon, but I checked constantly and those were the only errors, Timeout on mount and a failed to sync error\nIf you use level 4 log, it should also give the detailed messages of failed mount so that we can figure out why it failed.\nCan you email me your project name, cluster name, and zone information? I can take a look at the master logs to see if there's anything useful there.\nThis is starting to happen more frequently..\ncould you provide more details about in what situation it happened frequently? Kubelet log could give us more information. If you use GKE cluster, run \"journctlctl -u kubelet /tmp/log\" to get the log. You could also share with us the log if it is ok.\nThis seems to be the relevant part of the log I re-created that and my pods sprang back up. Weird thing is I had created that, along with the pvcs and pvs but seems it's somehow getting deleted. There's almost certainly certain I'm doing wrong but I'm not sure what. ]\nHI Jonathan, can you clarify what you had to recreate?\nThe glusterfs endpoints , Michelle Au <:\nI have a very similar problem running OpenShift 3.4 in AWS EC2 doing the same exact thing. Brand new OSE install [root master]# oc version oc v3.4.1.12 kubernetes v1.4.0+ features: Basic-Auth GSSAPI Kerberos SPNEGO Server https://172.31.40.126:8443 openshift v3.4.1.12 kubernetes v1.4.0+ POD in question is the docker-registry (kind of important for OSE to work) I've followed this to see if it would fix the issue: But no luck or change. Error syncing pod, skipping: timeout expired waiting for volumes to attach/mount for pod \"docker-registry-3-afbbt\"/\"default\". list of unattached/unmounted volumes=[registry-storage] then: Unable to mount volumes for pod \"docker-registry-3-afbbt_default(-1a45-11e7-abf8-)\": timeout expired waiting for volumes to attach/mount for pod \"docker-registry-3-afbbt\"/\"default\". list of unattached/unmounted volumes=[registry-storage] I have no idea what log(s) to look at, this was of no help when I deployed a new docker-registry: oc logs -f dc/docker-registry Any help or guidance would be greatly appreciated as this is a blocker issue for me. thanks and best wishes,\nare you using glusterfs for registry-storage volume or other type of volume? Could you share us your kubelet log if possible over slack Thanks!\nHi Jing Xu, Would you know where this log would be? Or is the name kublet<somethingso I may find it for you? I just requested to join the slack channel, as soon as I'm signed in I will share the log. Probably tomorrow as I'm on the east coast USA Thank you! Joel\nFor you are using GKE with GCI image, you can use \"journalctl -u kubelet \" to get the log. Otherwise, it should be in \" , shepp67 <:\nI also experienced this. Kubernetes version:Cloud provider or hardware configuration: OpenStack OS (e.g. from /etc/os-release): Ubuntu 16.04.1 LTS Kernel (e.g. ): Install tools: custom That kubernetes worker vm actually had volumes attached. I saw it on OpenStack dashboard. But: and actually: Besides, this is a new worker vm. I have other worker vms already running, using cinder volumes and there were no such errors. I use Helm to deploy this Pod. I have deployed it earlier and removed it. But it was 2 days ago. I found the solution here: . On that worker vm I run: Edit: or upgrade Kubernetes to = 1.6.0-beta.3 I don't know if this is the solution to issue.\nI'm seeing this same error on all my manually launched private Ubuntu based clusters (6), running 1.5.3 and 1.6.0. In my case the messages reference only stopped pods launched by CronJob Jobs. The messages indicate issues mounting every volume in the pod including PVs and node-local volumes. These pods, and future ones launched by these CronJobs, are fully successful when they run. It is only after they run to successful completion and exit that these messages show up. Glancing at the kubelet code, this appears to be coming out of some housekeeping/synch loop.\nI've identified a bug and am working on a fix for when \"Unable to mount volumes for pod...\" + \"Error syncing pod\" happen indefinitely BUT the pod is actually running just fine, as observed by . For others, if you see this message but your pod is Running, you can safely ignore it. It's caused by a small limitation of the reconstruction of state (what volumes are mounted) so there is a chance you will see this only if you restart kubelet while your pods had volumes mounted. correction: you say they even Completed, they weren't just Running fine. So yeah, it's just misleading logging and not really an indication of anything breaking\nBecause the error message is very generic, I think there might be different problems mentioned in this thread. 's issue could be fixed by 's PR are you still have any issues with mount? could you also let us know whether you still have the issue? Thanks! Jing\nHi my issue was related to which helped me sort out. I was creating the gluster endpoints without a service and turns out the kube-controller deletes all such endpoints that are not attached to a service at regular intervals. So after every so often when a pod went down and tried to come up again and mount its respective pv it failed because it couldn't connect to gluster. The fix is to create a service for the gluster endpoints.\nI also just ran into such timeout issue: After running a load test against my postgres backed web application, the database didn't respond anymore for still unknown reasons. According to kubernetes it was up and running The log showed a bunch of these messages. Not sure yet why but possibly it couldn't access the volume anymore: Short after that, the pod entered \"error\" state: The event log showed: This error disappeared after a few minutes (not sure how long exactly, but it took a while), but then I got the same error as described here: I couldn't figure out anything more on my own. Nothing in the syslog, nothing more than this in the kubelet log. Finally I rebooted the machine which fixed the issue.\ncc do you know what error of the network not ready? It might be helpful if you could share the kubelet log with us to debug. Thanks!\nAFAIK, the \"network not ready error\" is benign, kubelet will retry after this error () cc\nI hope I didn't miss some secrets in there, quite a talky log. But here it is: The database didn't respond anymore because it ran OOM and was killed, as also shown in the log. Although it appears like it was OOM killed after it became unresponsive in the log.. Either way, a bunch of other things got killed too, so granted - \"not ideal\" situation :). Yet it shouldn't drop the volume and should re-attach it.\nI think you are hitting the issue mentioned above. He has a PR to fix it. I will make sure it can merge soon. Thanks!\nGreat, thanks! Do you know roughly when this will be available in GCE?\nyou mean GKE or GCE? For GKE it will take a little bit longer. On GCE, when the PR gets merged, the fix should be available when the next release is out (I think should be soon)\nRunning on GKE. I'd rather not launch my product with this bug around. Is there a workaround for it or something I can monitor for? Or maybe it could get hot fixed on GKE? If there is no workaround, this effectively renders GKE useless for stateful stuff.\nIt's hard to say if volumes are actually being dropped/unmounted or if the FailedMount errors are wrong & misleading, so I wouldn't go so far as to say it's broken because of some volume issues. It could be something else entirely. If nothing else, the PR jing's referring to will clean up the event noise and help us debug the root cause. In the meantime, I wouldn't trust the FailedMount events to be accurate, so if your applications are unresponsive, there may be other causes worth considering\nWell, I only can say that my volumes were dropped and it didn't recover on it's own (only after reboot). Dropped a seen by kubernetes, dunno if the volumes were still attached but they weren't usable by my scheduled database. To be clear: I'm not \"complaining\" and this was just test/R&D, but it would this is the scariest kind of issue for me to happen in prod, given that it's a managed service where I can't find a workaround on my own. Rebooting fixed it in my case, but that's a big hammer..\nYou don't need to reboot the node. Delete the pod and restart it should work for this issue. Is this workaround ok for your case? , discordianfish <:\nGood to know, thanks! Will try this next time.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nHi, I'm facing the same issue with k8s 1.9, installed by kops on AWS. volume created successfully on AWS and attached to the right node, but the pod is failed to start.\n/remove-lifecycle stale\ncould you please provide more details about your issue? What are the steps to reproduce it? Thanks!\nyeah can you open a new bug for EBS and cc me with details? I was hoping we fixed most of EBS problems in 1.9 - I will be more than happy to walk through and find what is causing volume to not mount. As I understand this is different from typical EBS problems where volume fails to attach. In your case, volume is being attached to right node but it is not being seen by kubelet.\nI found the issue, and it was the fact that i used c5 instances with nvme, this is why the volume never been attached as k8s looking for /dev/xvdXX and with nvme that path is different. I did notice that in 1.9 k8s should support nvme natively but it seems that it's still not stable. thanks\noh weird. You should open a bug about NVMe support then. I was thinking it would just work.\ncc Is there an issue related to nvme support? please let us know any issues you still have with 1.9. Thanks!\nThis is nvme on AWS, not related to the work is doing on gce.\nThanks Definitely related to NVMe support. Ran into this trying to mount a gp2 EBS volume on a node which was an m5 EC2 instance.\nI think I am seeing like this with , but unsure of \"why\" at the moment. It would seem works perfectly fine.\ndid you guys had a chance to open a BUG for NVMe support on EBS? If you do - please paste output of and PersistentVolume spec. We can't fix it unless we know bit more. :(\nsorry, we worked around this by reverting back to m4 class instances. It should be simple enough to reproduce however... create a k8s cluster w/ m5 EBS backed nodes and create a simple pod w/ a persistent volume. You'll notice that the pod will never launch and you should be able to debug further. If I do run into this again I'll be sure to get some more data for you.\nI too have the error, error syncing pod. kubectl describe pod kafka1-kafka-0 .... .... .... Warning FailedSync 5m (x141 over 35m) kubelet, 10.186.. Error syncing pod Warning BackOff 57s (x164 over 35m) kubelet, 10.186.. Back-off restarting failed container kubectl logs kafka1-kafka-0 -p export KAFKABROKERID=kafka1-kafka-0 export KAFKAADVERTISEDLISTENERS=PLAINTEXT://172.30.*.:9092 /etc/confluent/docker/run sh: 3: /etc/confluent/docker/run: not found", "positive_passages": [{"docid": "doc-en-kubernetes-71bc8f1127d80f290e7fac12c90bf604bea92672710ee17670f9f331a1dc193a", "text": "docker_pull( name = \"debian-hyperkube-base-amd64\", <del> digest = \"sha256:d83594ecd85345144584523e7fa5388467edf5d2dfa30d0a1bcbf184cddf4a7b\", </del> <ins> digest = \"sha256:cc782ed16599000ca4c85d47ec6264753747ae1e77520894dca84b104a7621e2\", </ins> registry = \"k8s.gcr.io\", repository = \"debian-hyperkube-base-amd64\", <del> tag = \"0.9\",  # ignored, but kept here for documentation </del> <ins> tag = \"0.10\",  # ignored, but kept here for documentation </ins> ) docker_pull(", "commid": "kubernetes_pr_61357"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fe8cd1417ccecb69a119143da34e7328b16728970aada998527fd4ee6dea436e", "query": "Kubernetes version (use ): Environment: Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): container-os Kernel (e.g. ): Linux gke-wordpress-cluster-default-pool--m764 4.4.21+ SMP Fri Feb 17 15:34:45 PST 2017 x86_64 Intel(R) Xeon(R) CPU @ 2.60GHz GenuineIntel GNU/Linux Install tools: Others: What happened: ` I was able to bring up wordpress okay the first time, except GKE wasn't creating loadbalancer ips due to a quota issue, which I resolved, note at this point the mysql pod was up and had attached to it's volume. Upon deleting the wordpress deployment and creating it again I started getting the above errors. I deleted the mysql pod as well and brought it up again to see that it had the same issue. The volumes are backed by a gluster cluster on GCE. Looking at the brick logs on one of the gluster nodes I see I've tried restarting kubelet on the node. I can't find the kubelet log file on any of gke nodes. And I don't know how to get the kube-controller and apiserver logs from the master (GKE). I suspect it's a failing of the glusterfs client on the gke nodes? What you expected to happen: Deployment to mount the volumes successfully. How to reproduce it (as minimally and precisely as possible): Not sure how, but I've run into this intermittently Anything else we need to know: The volumes are backed by gluster\n/cc\nIf you delete pod and create pods soon, it is possible that you could see some errors like \"timeout expired waiting for volumes to attach/mount\" temporally. Could you wait for a few more minutes to see whether the pods could be started correctly?\nI actually tried that, deleted the pods, then waited 5 minutes and recreated them with the same error. Maybe it wasn't long enough\nCan you post output of ? It may have some other events for failure..\nI deleted the cluster this afternoon, but I checked constantly and those were the only errors, Timeout on mount and a failed to sync error\nIf you use level 4 log, it should also give the detailed messages of failed mount so that we can figure out why it failed.\nCan you email me your project name, cluster name, and zone information? I can take a look at the master logs to see if there's anything useful there.\nThis is starting to happen more frequently..\ncould you provide more details about in what situation it happened frequently? Kubelet log could give us more information. If you use GKE cluster, run \"journctlctl -u kubelet /tmp/log\" to get the log. You could also share with us the log if it is ok.\nThis seems to be the relevant part of the log I re-created that and my pods sprang back up. Weird thing is I had created that, along with the pvcs and pvs but seems it's somehow getting deleted. There's almost certainly certain I'm doing wrong but I'm not sure what. ]\nHI Jonathan, can you clarify what you had to recreate?\nThe glusterfs endpoints , Michelle Au <:\nI have a very similar problem running OpenShift 3.4 in AWS EC2 doing the same exact thing. Brand new OSE install [root master]# oc version oc v3.4.1.12 kubernetes v1.4.0+ features: Basic-Auth GSSAPI Kerberos SPNEGO Server https://172.31.40.126:8443 openshift v3.4.1.12 kubernetes v1.4.0+ POD in question is the docker-registry (kind of important for OSE to work) I've followed this to see if it would fix the issue: But no luck or change. Error syncing pod, skipping: timeout expired waiting for volumes to attach/mount for pod \"docker-registry-3-afbbt\"/\"default\". list of unattached/unmounted volumes=[registry-storage] then: Unable to mount volumes for pod \"docker-registry-3-afbbt_default(-1a45-11e7-abf8-)\": timeout expired waiting for volumes to attach/mount for pod \"docker-registry-3-afbbt\"/\"default\". list of unattached/unmounted volumes=[registry-storage] I have no idea what log(s) to look at, this was of no help when I deployed a new docker-registry: oc logs -f dc/docker-registry Any help or guidance would be greatly appreciated as this is a blocker issue for me. thanks and best wishes,\nare you using glusterfs for registry-storage volume or other type of volume? Could you share us your kubelet log if possible over slack Thanks!\nHi Jing Xu, Would you know where this log would be? Or is the name kublet<somethingso I may find it for you? I just requested to join the slack channel, as soon as I'm signed in I will share the log. Probably tomorrow as I'm on the east coast USA Thank you! Joel\nFor you are using GKE with GCI image, you can use \"journalctl -u kubelet \" to get the log. Otherwise, it should be in \" , shepp67 <:\nI also experienced this. Kubernetes version:Cloud provider or hardware configuration: OpenStack OS (e.g. from /etc/os-release): Ubuntu 16.04.1 LTS Kernel (e.g. ): Install tools: custom That kubernetes worker vm actually had volumes attached. I saw it on OpenStack dashboard. But: and actually: Besides, this is a new worker vm. I have other worker vms already running, using cinder volumes and there were no such errors. I use Helm to deploy this Pod. I have deployed it earlier and removed it. But it was 2 days ago. I found the solution here: . On that worker vm I run: Edit: or upgrade Kubernetes to = 1.6.0-beta.3 I don't know if this is the solution to issue.\nI'm seeing this same error on all my manually launched private Ubuntu based clusters (6), running 1.5.3 and 1.6.0. In my case the messages reference only stopped pods launched by CronJob Jobs. The messages indicate issues mounting every volume in the pod including PVs and node-local volumes. These pods, and future ones launched by these CronJobs, are fully successful when they run. It is only after they run to successful completion and exit that these messages show up. Glancing at the kubelet code, this appears to be coming out of some housekeeping/synch loop.\nI've identified a bug and am working on a fix for when \"Unable to mount volumes for pod...\" + \"Error syncing pod\" happen indefinitely BUT the pod is actually running just fine, as observed by . For others, if you see this message but your pod is Running, you can safely ignore it. It's caused by a small limitation of the reconstruction of state (what volumes are mounted) so there is a chance you will see this only if you restart kubelet while your pods had volumes mounted. correction: you say they even Completed, they weren't just Running fine. So yeah, it's just misleading logging and not really an indication of anything breaking\nBecause the error message is very generic, I think there might be different problems mentioned in this thread. 's issue could be fixed by 's PR are you still have any issues with mount? could you also let us know whether you still have the issue? Thanks! Jing\nHi my issue was related to which helped me sort out. I was creating the gluster endpoints without a service and turns out the kube-controller deletes all such endpoints that are not attached to a service at regular intervals. So after every so often when a pod went down and tried to come up again and mount its respective pv it failed because it couldn't connect to gluster. The fix is to create a service for the gluster endpoints.\nI also just ran into such timeout issue: After running a load test against my postgres backed web application, the database didn't respond anymore for still unknown reasons. According to kubernetes it was up and running The log showed a bunch of these messages. Not sure yet why but possibly it couldn't access the volume anymore: Short after that, the pod entered \"error\" state: The event log showed: This error disappeared after a few minutes (not sure how long exactly, but it took a while), but then I got the same error as described here: I couldn't figure out anything more on my own. Nothing in the syslog, nothing more than this in the kubelet log. Finally I rebooted the machine which fixed the issue.\ncc do you know what error of the network not ready? It might be helpful if you could share the kubelet log with us to debug. Thanks!\nAFAIK, the \"network not ready error\" is benign, kubelet will retry after this error () cc\nI hope I didn't miss some secrets in there, quite a talky log. But here it is: The database didn't respond anymore because it ran OOM and was killed, as also shown in the log. Although it appears like it was OOM killed after it became unresponsive in the log.. Either way, a bunch of other things got killed too, so granted - \"not ideal\" situation :). Yet it shouldn't drop the volume and should re-attach it.\nI think you are hitting the issue mentioned above. He has a PR to fix it. I will make sure it can merge soon. Thanks!\nGreat, thanks! Do you know roughly when this will be available in GCE?\nyou mean GKE or GCE? For GKE it will take a little bit longer. On GCE, when the PR gets merged, the fix should be available when the next release is out (I think should be soon)\nRunning on GKE. I'd rather not launch my product with this bug around. Is there a workaround for it or something I can monitor for? Or maybe it could get hot fixed on GKE? If there is no workaround, this effectively renders GKE useless for stateful stuff.\nIt's hard to say if volumes are actually being dropped/unmounted or if the FailedMount errors are wrong & misleading, so I wouldn't go so far as to say it's broken because of some volume issues. It could be something else entirely. If nothing else, the PR jing's referring to will clean up the event noise and help us debug the root cause. In the meantime, I wouldn't trust the FailedMount events to be accurate, so if your applications are unresponsive, there may be other causes worth considering\nWell, I only can say that my volumes were dropped and it didn't recover on it's own (only after reboot). Dropped a seen by kubernetes, dunno if the volumes were still attached but they weren't usable by my scheduled database. To be clear: I'm not \"complaining\" and this was just test/R&D, but it would this is the scariest kind of issue for me to happen in prod, given that it's a managed service where I can't find a workaround on my own. Rebooting fixed it in my case, but that's a big hammer..\nYou don't need to reboot the node. Delete the pod and restart it should work for this issue. Is this workaround ok for your case? , discordianfish <:\nGood to know, thanks! Will try this next time.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nHi, I'm facing the same issue with k8s 1.9, installed by kops on AWS. volume created successfully on AWS and attached to the right node, but the pod is failed to start.\n/remove-lifecycle stale\ncould you please provide more details about your issue? What are the steps to reproduce it? Thanks!\nyeah can you open a new bug for EBS and cc me with details? I was hoping we fixed most of EBS problems in 1.9 - I will be more than happy to walk through and find what is causing volume to not mount. As I understand this is different from typical EBS problems where volume fails to attach. In your case, volume is being attached to right node but it is not being seen by kubelet.\nI found the issue, and it was the fact that i used c5 instances with nvme, this is why the volume never been attached as k8s looking for /dev/xvdXX and with nvme that path is different. I did notice that in 1.9 k8s should support nvme natively but it seems that it's still not stable. thanks\noh weird. You should open a bug about NVMe support then. I was thinking it would just work.\ncc Is there an issue related to nvme support? please let us know any issues you still have with 1.9. Thanks!\nThis is nvme on AWS, not related to the work is doing on gce.\nThanks Definitely related to NVMe support. Ran into this trying to mount a gp2 EBS volume on a node which was an m5 EC2 instance.\nI think I am seeing like this with , but unsure of \"why\" at the moment. It would seem works perfectly fine.\ndid you guys had a chance to open a BUG for NVMe support on EBS? If you do - please paste output of and PersistentVolume spec. We can't fix it unless we know bit more. :(\nsorry, we worked around this by reverting back to m4 class instances. It should be simple enough to reproduce however... create a k8s cluster w/ m5 EBS backed nodes and create a simple pod w/ a persistent volume. You'll notice that the pod will never launch and you should be able to debug further. If I do run into this again I'll be sure to get some more data for you.\nI too have the error, error syncing pod. kubectl describe pod kafka1-kafka-0 .... .... .... Warning FailedSync 5m (x141 over 35m) kubelet, 10.186.. Error syncing pod Warning BackOff 57s (x164 over 35m) kubelet, 10.186.. Back-off restarting failed container kubectl logs kafka1-kafka-0 -p export KAFKABROKERID=kafka1-kafka-0 export KAFKAADVERTISEDLISTENERS=PLAINTEXT://172.30.*.:9092 /etc/confluent/docker/run sh: 3: /etc/confluent/docker/run: not found", "positive_passages": [{"docid": "doc-en-kubernetes-5e2d050c071ba81e141422f1e404c82c926fc4b70e9a4d6b9f920a289bbd9983", "text": "OUT_DIR?=_output HYPERKUBE_BIN?=$(OUT_DIR)/dockerized/bin/linux/$(ARCH)/hyperkube <del> BASEIMAGE=k8s.gcr.io/debian-hyperkube-base-$(ARCH):0.8 </del> <ins> BASEIMAGE=k8s.gcr.io/debian-hyperkube-base-$(ARCH):0.10 </ins> TEMP_DIR:=$(shell mktemp -d -t hyperkubeXXXXXX) all: build", "commid": "kubernetes_pr_61357"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f59d598d5d92681fe549c4f3adb9f9b079e6c980b7927f7c2c210b3c06d36aca", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Ubuntu 14.04 Kernel (e.g. ): Linux dev-k8s-controller-p1 4.4.0-53-generic ~14.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x8664 x8664 x86_64 GNU/Linux Install tools: chef cookbook Others: Docker 1.12.6, calico 2.1 CNI binaries: kubelet config: What happened: When trying to run pod error message is generated: So it seems that kubelet is trying to find CNI binaries in paths: /opt/loopback/bin /etc/cni/net.d /opt/calico/bin But it should look at since this is the default valur for parameter. What you expected to happen: Pod starts. How to reproduce it (as minimally and precisely as possible): Run pod: with kubelet 1.6 and CNI binaries in those path (default for calico): Anything else we need to know: After copy to and pod starts fine.\nGood, very helpful to me\nWhen set and not set , default path of CNI binaries will not take effect, the path specified by will be used instead. We should use and instead of if use CNI plugin.\nI will push a PR to deprecate the flag. It is confusing. Closing this issue.\nWas that ? It was closed without merging. I agree should be deprecated.\nI think is needed before is removed. The flag is still not deprecated, I will send a PR to deprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-b964eccb51ada510c153fe24c3d4d3fb4105dffd49dc05aa334d3d592a43d066", "text": "fi # Network plugin if [[ -n \"${NETWORK_PROVIDER:-}\" ]]; then <del> if [[ \"${NETWORK_PROVIDER:-}\" == \"cni\" ]]; then flags+=\" --cni-bin-dir=/opt/kubernetes/bin\" else flags+=\" --network-plugin-dir=/opt/kubernetes/bin\" fi </del> <ins> flags+=\" --cni-bin-dir=/opt/kubernetes/bin\" </ins> flags+=\" --network-plugin=${NETWORK_PROVIDER}\" fi if [[ -n \"${NON_MASQUERADE_CIDR:-}\" ]]; then", "commid": "kubernetes_pr_46327"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f59d598d5d92681fe549c4f3adb9f9b079e6c980b7927f7c2c210b3c06d36aca", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Ubuntu 14.04 Kernel (e.g. ): Linux dev-k8s-controller-p1 4.4.0-53-generic ~14.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x8664 x8664 x86_64 GNU/Linux Install tools: chef cookbook Others: Docker 1.12.6, calico 2.1 CNI binaries: kubelet config: What happened: When trying to run pod error message is generated: So it seems that kubelet is trying to find CNI binaries in paths: /opt/loopback/bin /etc/cni/net.d /opt/calico/bin But it should look at since this is the default valur for parameter. What you expected to happen: Pod starts. How to reproduce it (as minimally and precisely as possible): Run pod: with kubelet 1.6 and CNI binaries in those path (default for calico): Anything else we need to know: After copy to and pod starts fine.\nGood, very helpful to me\nWhen set and not set , default path of CNI binaries will not take effect, the path specified by will be used instead. We should use and instead of if use CNI plugin.\nI will push a PR to deprecate the flag. It is confusing. Closing this issue.\nWas that ? It was closed without merging. I agree should be deprecated.\nI think is needed before is removed. The flag is still not deprecated, I will send a PR to deprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-b635007556eeaacc69982ac0ab4ddf8742a493fe7f2afd5201661e7db9506d4a", "text": "fi # Network plugin if [[ -n \"${NETWORK_PROVIDER:-}\" || -n \"${NETWORK_POLICY_PROVIDER:-}\" ]]; then <del> if [[ \"${NETWORK_PROVIDER:-}\" == \"cni\" || \"${NETWORK_POLICY_PROVIDER:-}\" == \"calico\" ]]; then flags+=\" --cni-bin-dir=/home/kubernetes/bin\" else flags+=\" --network-plugin-dir=/home/kubernetes/bin\" fi </del> <ins> flags+=\" --cni-bin-dir=/home/kubernetes/bin\" </ins> if [[ \"${NETWORK_POLICY_PROVIDER:-}\" == \"calico\" ]]; then # Calico uses CNI always. flags+=\" --network-plugin=cni\"", "commid": "kubernetes_pr_46327"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f59d598d5d92681fe549c4f3adb9f9b079e6c980b7927f7c2c210b3c06d36aca", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Ubuntu 14.04 Kernel (e.g. ): Linux dev-k8s-controller-p1 4.4.0-53-generic ~14.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x8664 x8664 x86_64 GNU/Linux Install tools: chef cookbook Others: Docker 1.12.6, calico 2.1 CNI binaries: kubelet config: What happened: When trying to run pod error message is generated: So it seems that kubelet is trying to find CNI binaries in paths: /opt/loopback/bin /etc/cni/net.d /opt/calico/bin But it should look at since this is the default valur for parameter. What you expected to happen: Pod starts. How to reproduce it (as minimally and precisely as possible): Run pod: with kubelet 1.6 and CNI binaries in those path (default for calico): Anything else we need to know: After copy to and pod starts fine.\nGood, very helpful to me\nWhen set and not set , default path of CNI binaries will not take effect, the path specified by will be used instead. We should use and instead of if use CNI plugin.\nI will push a PR to deprecate the flag. It is confusing. Closing this issue.\nWas that ? It was closed without merging. I agree should be deprecated.\nI think is needed before is removed. The flag is still not deprecated, I will send a PR to deprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-50f8703c4a5f723954013e2051756d0aceb51dcd9e4be680012e9c9df6bb67c2", "text": "{% if pillar.get('network_provider', '').lower() == 'opencontrail' %} {% set network_plugin = \"--network-plugin=opencontrail\" %} {% elif pillar.get('network_provider', '').lower() == 'cni' %} <del> {% set network_plugin = \"--network-plugin=cni --network-plugin-dir=/etc/cni/net.d/\" %} </del> <ins> {% set network_plugin = \"--network-plugin=cni --cni-bin-dir=/etc/cni/net.d/\" %} </ins> {%elif pillar.get('network_policy_provider', '').lower() == 'calico' and grains['roles'][0] != 'kubernetes-master' -%} <del> {% set network_plugin = \"--network-plugin=cni --network-plugin-dir=/etc/cni/net.d/ --cni-bin-dir=/home/kubernetes/bin/\" %} </del> <ins> {% set network_plugin = \"--network-plugin=cni --cni-conf-dir=/etc/cni/net.d/ --cni-bin-dir=/home/kubernetes/bin/\" %} </ins> {% elif pillar.get('network_provider', '').lower() == 'kubenet' %} {% set network_plugin = \"--network-plugin=kubenet\" -%} {% endif -%}", "commid": "kubernetes_pr_46327"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f59d598d5d92681fe549c4f3adb9f9b079e6c980b7927f7c2c210b3c06d36aca", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Ubuntu 14.04 Kernel (e.g. ): Linux dev-k8s-controller-p1 4.4.0-53-generic ~14.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x8664 x8664 x86_64 GNU/Linux Install tools: chef cookbook Others: Docker 1.12.6, calico 2.1 CNI binaries: kubelet config: What happened: When trying to run pod error message is generated: So it seems that kubelet is trying to find CNI binaries in paths: /opt/loopback/bin /etc/cni/net.d /opt/calico/bin But it should look at since this is the default valur for parameter. What you expected to happen: Pod starts. How to reproduce it (as minimally and precisely as possible): Run pod: with kubelet 1.6 and CNI binaries in those path (default for calico): Anything else we need to know: After copy to and pod starts fine.\nGood, very helpful to me\nWhen set and not set , default path of CNI binaries will not take effect, the path specified by will be used instead. We should use and instead of if use CNI plugin.\nI will push a PR to deprecate the flag. It is confusing. Closing this issue.\nWas that ? It was closed without merging. I agree should be deprecated.\nI think is needed before is removed. The flag is still not deprecated, I will send a PR to deprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-7dd2242fc76c4a9dee9c6493f19e36ccf24a8a50da917ffb9f2a273fbf44879d", "text": "// Network plugin settings. Shared by both docker and rkt. fs.StringVar(&s.NetworkPluginName, \"network-plugin\", s.NetworkPluginName, \"<Warning: Alpha feature> The name of the network plugin to be invoked for various events in kubelet/pod lifecycle\") <ins> //TODO(#46410): Remove the network-plugin-dir flag. </ins> fs.StringVar(&s.NetworkPluginDir, \"network-plugin-dir\", s.NetworkPluginDir, \"<Warning: Alpha feature> The full path of the directory in which to search for network plugins or CNI config\") <ins> fs.MarkDeprecated(\"network-plugin-dir\", \"Use --cni-bin-dir instead. This flag will be removed in a future version.\") </ins> fs.StringVar(&s.CNIConfDir, \"cni-conf-dir\", s.CNIConfDir, \"<Warning: Alpha feature> The full path of the directory in which to search for CNI config files. Default: /etc/cni/net.d\") fs.StringVar(&s.CNIBinDir, \"cni-bin-dir\", s.CNIBinDir, \"<Warning: Alpha feature> The full path of the directory in which to search for CNI plugin binaries. Default: /opt/cni/bin\") fs.Int32Var(&s.NetworkPluginMTU, \"network-plugin-mtu\", s.NetworkPluginMTU, \"<Warning: Alpha feature> The MTU to be passed to the network plugin, to override the default. Set to 0 to use the default 1460 MTU.\")", "commid": "kubernetes_pr_46327"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f59d598d5d92681fe549c4f3adb9f9b079e6c980b7927f7c2c210b3c06d36aca", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Ubuntu 14.04 Kernel (e.g. ): Linux dev-k8s-controller-p1 4.4.0-53-generic ~14.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x8664 x8664 x86_64 GNU/Linux Install tools: chef cookbook Others: Docker 1.12.6, calico 2.1 CNI binaries: kubelet config: What happened: When trying to run pod error message is generated: So it seems that kubelet is trying to find CNI binaries in paths: /opt/loopback/bin /etc/cni/net.d /opt/calico/bin But it should look at since this is the default valur for parameter. What you expected to happen: Pod starts. How to reproduce it (as minimally and precisely as possible): Run pod: with kubelet 1.6 and CNI binaries in those path (default for calico): Anything else we need to know: After copy to and pod starts fine.\nGood, very helpful to me\nWhen set and not set , default path of CNI binaries will not take effect, the path specified by will be used instead. We should use and instead of if use CNI plugin.\nI will push a PR to deprecate the flag. It is confusing. Closing this issue.\nWas that ? It was closed without merging. I agree should be deprecated.\nI think is needed before is removed. The flag is still not deprecated, I will send a PR to deprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-02d331889051503c3595531204e80be4c8638dbbf690ec963ecca96e449dc311", "text": "KUBELET_FLAGS=${KUBELET_FLAGS:-\"\"} # Name of the network plugin, eg: \"kubenet\" NET_PLUGIN=${NET_PLUGIN:-\"\"} <del> # Place the binaries required by NET_PLUGIN in this directory, eg: \"/home/kubernetes/bin\". NET_PLUGIN_DIR=${NET_PLUGIN_DIR:-\"\"} </del> <ins> # Place the config files and binaries required by NET_PLUGIN in these directory, # eg: \"/etc/cni/net.d\" for config files, and \"/opt/cni/bin\" for binaries. CNI_CONF_DIR=${CNI_CONF_DIR:-\"\"} CNI_BIN_DIR=${CNI_BIN_DIR:-\"\"} </ins> SERVICE_CLUSTER_IP_RANGE=${SERVICE_CLUSTER_IP_RANGE:-10.0.0.0/24} FIRST_SERVICE_CLUSTER_IP=${FIRST_SERVICE_CLUSTER_IP:-10.0.0.1} # if enabled, must set CGROUP_ROOT", "commid": "kubernetes_pr_46327"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f59d598d5d92681fe549c4f3adb9f9b079e6c980b7927f7c2c210b3c06d36aca", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Ubuntu 14.04 Kernel (e.g. ): Linux dev-k8s-controller-p1 4.4.0-53-generic ~14.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x8664 x8664 x86_64 GNU/Linux Install tools: chef cookbook Others: Docker 1.12.6, calico 2.1 CNI binaries: kubelet config: What happened: When trying to run pod error message is generated: So it seems that kubelet is trying to find CNI binaries in paths: /opt/loopback/bin /etc/cni/net.d /opt/calico/bin But it should look at since this is the default valur for parameter. What you expected to happen: Pod starts. How to reproduce it (as minimally and precisely as possible): Run pod: with kubelet 1.6 and CNI binaries in those path (default for calico): Anything else we need to know: After copy to and pod starts fine.\nGood, very helpful to me\nWhen set and not set , default path of CNI binaries will not take effect, the path specified by will be used instead. We should use and instead of if use CNI plugin.\nI will push a PR to deprecate the flag. It is confusing. Closing this issue.\nWas that ? It was closed without merging. I agree should be deprecated.\nI think is needed before is removed. The flag is still not deprecated, I will send a PR to deprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-5b75f63eed85f57de464bcadf0bf5ae4f94a43e0b890e8f9dc90caefea778c40", "text": "auth_args=\"${auth_args} --client-ca-file=${CLIENT_CA_FILE}\" fi <del> net_plugin_dir_args=\"\" if [[ -n \"${NET_PLUGIN_DIR}\" ]]; then net_plugin_dir_args=\"--network-plugin-dir=${NET_PLUGIN_DIR}\" </del> <ins> cni_conf_dir_args=\"\" if [[ -n \"${CNI_CONF_DIR}\" ]]; then cni_conf_dir_args=\"--cni-conf-dir=${CNI_CONF_DIR}\" fi cni_bin_dir_args=\"\" if [[ -n \"${CNI_BIN_DIR}\" ]]; then cni_bin_dir_args=\"--cni-bin-dir=${CNI_BIN_DIR}\" </ins> fi container_runtime_endpoint_args=\"\"", "commid": "kubernetes_pr_46327"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f59d598d5d92681fe549c4f3adb9f9b079e6c980b7927f7c2c210b3c06d36aca", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Ubuntu 14.04 Kernel (e.g. ): Linux dev-k8s-controller-p1 4.4.0-53-generic ~14.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x8664 x8664 x86_64 GNU/Linux Install tools: chef cookbook Others: Docker 1.12.6, calico 2.1 CNI binaries: kubelet config: What happened: When trying to run pod error message is generated: So it seems that kubelet is trying to find CNI binaries in paths: /opt/loopback/bin /etc/cni/net.d /opt/calico/bin But it should look at since this is the default valur for parameter. What you expected to happen: Pod starts. How to reproduce it (as minimally and precisely as possible): Run pod: with kubelet 1.6 and CNI binaries in those path (default for calico): Anything else we need to know: After copy to and pod starts fine.\nGood, very helpful to me\nWhen set and not set , default path of CNI binaries will not take effect, the path specified by will be used instead. We should use and instead of if use CNI plugin.\nI will push a PR to deprecate the flag. It is confusing. Closing this issue.\nWas that ? It was closed without merging. I agree should be deprecated.\nI think is needed before is removed. The flag is still not deprecated, I will send a PR to deprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-56cfb9b1c676b6185ffc527c4af2ec2d4beb04fef46c7df1f403129bb737193f", "text": "--pod-manifest-path=\"${POD_MANIFEST_PATH}\"  ${auth_args}  ${dns_args}  <del> ${net_plugin_dir_args}  </del> <ins> ${cni_conf_dir_args}  ${cni_bin_dir_args}  </ins> ${net_plugin_args}  ${container_runtime_endpoint_args}  ${image_service_endpoint_args} ", "commid": "kubernetes_pr_46327"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f59d598d5d92681fe549c4f3adb9f9b079e6c980b7927f7c2c210b3c06d36aca", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Ubuntu 14.04 Kernel (e.g. ): Linux dev-k8s-controller-p1 4.4.0-53-generic ~14.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x8664 x8664 x86_64 GNU/Linux Install tools: chef cookbook Others: Docker 1.12.6, calico 2.1 CNI binaries: kubelet config: What happened: When trying to run pod error message is generated: So it seems that kubelet is trying to find CNI binaries in paths: /opt/loopback/bin /etc/cni/net.d /opt/calico/bin But it should look at since this is the default valur for parameter. What you expected to happen: Pod starts. How to reproduce it (as minimally and precisely as possible): Run pod: with kubelet 1.6 and CNI binaries in those path (default for calico): Anything else we need to know: After copy to and pod starts fine.\nGood, very helpful to me\nWhen set and not set , default path of CNI binaries will not take effect, the path specified by will be used instead. We should use and instead of if use CNI plugin.\nI will push a PR to deprecate the flag. It is confusing. Closing this issue.\nWas that ? It was closed without merging. I agree should be deprecated.\nI think is needed before is removed. The flag is still not deprecated, I will send a PR to deprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-6bf6c9512127d8bd2d5a896cb3c760a312be0db7632788fe3e3c5b30f231be5c", "text": "# Do not use any network plugin by default. User could override the flags with # test_args. <del> test_args='--kubelet-flags=\"--network-plugin= --network-plugin-dir=\" '$test_args </del> <ins> test_args='--kubelet-flags=\"--network-plugin= --cni-bin-dir=\" '$test_args </ins> # Runtime flags test_args='--kubelet-flags=\"--container-runtime='$runtime'\" '$test_args", "commid": "kubernetes_pr_46327"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f59d598d5d92681fe549c4f3adb9f9b079e6c980b7927f7c2c210b3c06d36aca", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Ubuntu 14.04 Kernel (e.g. ): Linux dev-k8s-controller-p1 4.4.0-53-generic ~14.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x8664 x8664 x86_64 GNU/Linux Install tools: chef cookbook Others: Docker 1.12.6, calico 2.1 CNI binaries: kubelet config: What happened: When trying to run pod error message is generated: So it seems that kubelet is trying to find CNI binaries in paths: /opt/loopback/bin /etc/cni/net.d /opt/calico/bin But it should look at since this is the default valur for parameter. What you expected to happen: Pod starts. How to reproduce it (as minimally and precisely as possible): Run pod: with kubelet 1.6 and CNI binaries in those path (default for calico): Anything else we need to know: After copy to and pod starts fine.\nGood, very helpful to me\nWhen set and not set , default path of CNI binaries will not take effect, the path specified by will be used instead. We should use and instead of if use CNI plugin.\nI will push a PR to deprecate the flag. It is confusing. Closing this issue.\nWas that ? It was closed without merging. I agree should be deprecated.\nI think is needed before is removed. The flag is still not deprecated, I will send a PR to deprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-a12931dc28d8850022123c13a0aa2063f950eebb091e4147b3c17d97afa8cbe9", "text": "# plugin by default. NETWORK_PLUGIN=${NETWORK_PLUGIN:-\"\"} <del> # NETWORK_PLUGIN_PATH is the path to network plugin binary. NETWORK_PLUGIN_PATH=${NETWORK_PLUGIN_PATH:-\"\"} </del> <ins> # CNI_CONF_DIR is the path to network plugin binaries. CNI_CONF_DIR=${CNI_CONF_DIR:-\"\"} # CNI_BIN_DIR is the path to network plugin config files. CNI_BIN_DIR=${CNI_BIN_DIR:-\"\"} </ins> # start_kubelet starts kubelet and redirect kubelet log to $LOG_DIR/kubelet.log. kubelet_log=kubelet.log", "commid": "kubernetes_pr_46327"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f59d598d5d92681fe549c4f3adb9f9b079e6c980b7927f7c2c210b3c06d36aca", "query": "Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Ubuntu 14.04 Kernel (e.g. ): Linux dev-k8s-controller-p1 4.4.0-53-generic ~14.04.1-Ubuntu SMP Fri Dec 2 03:43:31 UTC 2016 x8664 x8664 x86_64 GNU/Linux Install tools: chef cookbook Others: Docker 1.12.6, calico 2.1 CNI binaries: kubelet config: What happened: When trying to run pod error message is generated: So it seems that kubelet is trying to find CNI binaries in paths: /opt/loopback/bin /etc/cni/net.d /opt/calico/bin But it should look at since this is the default valur for parameter. What you expected to happen: Pod starts. How to reproduce it (as minimally and precisely as possible): Run pod: with kubelet 1.6 and CNI binaries in those path (default for calico): Anything else we need to know: After copy to and pod starts fine.\nGood, very helpful to me\nWhen set and not set , default path of CNI binaries will not take effect, the path specified by will be used instead. We should use and instead of if use CNI plugin.\nI will push a PR to deprecate the flag. It is confusing. Closing this issue.\nWas that ? It was closed without merging. I agree should be deprecated.\nI think is needed before is removed. The flag is still not deprecated, I will send a PR to deprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-07036046397465555e2ea9b022a09a87965cf9273466dcc8a07bc4c88805a30a", "text": "--system-cgroups=/system  --cgroup-root=/  --network-plugin=$NETWORK_PLUGIN  <del> --network-plugin-dir=$NETWORK_PLUGIN_PATH  </del> <ins> --cni-conf-dir=$CNI_CONF_DIR  --cni-bin-dir=$CNI_BIN_DIR  </ins> --v=$log_level  --logtostderr", "commid": "kubernetes_pr_46327"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0318647ed38ee346e4394847572fe3c715455e2328b33549b60619adece32e73", "query": "In order to support running tests in parallel, we randomized NodePort selection. There appears to be some evidence that this is not sufficient and is causing e2e test flakes: https://k8s-\nHi, As a need contributor, I'm interesting of solving this issue. I already check the current code, and propose to retry the service creation until success or all possible ports (between FederatedSvcNodePortFirst and FederatedSvcNodePortLast) have been tried. If this approach is fine for you, I can submit a PR soon.\nHow do you plan to check if the NodePorts are available? In our presubmit test environment, tests run across many instances of federation control planes in parallel, but share the same underlying clusters. So this approach might be viable depending on how and where you plan to check for these used NodePorts.\nmy approach for getting an available port is a \"Dummy\" approach: create a list of possible available port, get one of them randomly, then try to create the Service. If Service creation failed. try to use another possible available port, until service creation success or all possible available ports have been tested.\nSounds reasonable to me. Go for it. A couple of caveats: need to create a real list, you could just use the range boundaries. careful about service creation failure. You need to check if the service shard creation failed in the underlying clusters and rollback all those shards before retrying.\nthanks for the caveats, I will do soon a PR.\nHi, what is the state of this issue? Is working in this issues with the others issues related to e2e tests?\nhas a PR to fix this issue -", "positive_passages": [{"docid": "doc-en-kubernetes-03b94f0564070a4257037a8023fd4442a2fb04d4ca2f4e8dd8c30414e9201401", "text": "clusters = f.GetRegisteredClusters() ns = f.FederationNamespace.Name // create backend service <del> service = createLBServiceOrFail(f.FederationClientset, ns, FederatedIngressServiceName) </del> <ins> service = createLBServiceOrFail(f.FederationClientset, ns, FederatedIngressServiceName, clusters) </ins> // create the TLS secret secret = createTLSSecretOrFail(f.FederationClientset, ns, FederatedIngressTLSSecretName) // wait for services objects sync", "commid": "kubernetes_pr_45186"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0318647ed38ee346e4394847572fe3c715455e2328b33549b60619adece32e73", "query": "In order to support running tests in parallel, we randomized NodePort selection. There appears to be some evidence that this is not sufficient and is causing e2e test flakes: https://k8s-\nHi, As a need contributor, I'm interesting of solving this issue. I already check the current code, and propose to retry the service creation until success or all possible ports (between FederatedSvcNodePortFirst and FederatedSvcNodePortLast) have been tried. If this approach is fine for you, I can submit a PR soon.\nHow do you plan to check if the NodePorts are available? In our presubmit test environment, tests run across many instances of federation control planes in parallel, but share the same underlying clusters. So this approach might be viable depending on how and where you plan to check for these used NodePorts.\nmy approach for getting an available port is a \"Dummy\" approach: create a list of possible available port, get one of them randomly, then try to create the Service. If Service creation failed. try to use another possible available port, until service creation success or all possible available ports have been tested.\nSounds reasonable to me. Go for it. A couple of caveats: need to create a real list, you could just use the range boundaries. careful about service creation failure. You need to check if the service shard creation failed in the underlying clusters and rollback all those shards before retrying.\nthanks for the caveats, I will do soon a PR.\nHi, what is the state of this issue? Is working in this issues with the others issues related to e2e tests?\nhas a PR to fix this issue -", "positive_passages": [{"docid": "doc-en-kubernetes-4586dde5001f3d905589c8cfccfbcb5905f6032800e19dabb23aa78e40f84c54", "text": "backendPods = createBackendPodsOrFail(clusters, nsName, FederatedServicePodName) <del> service = createLBServiceOrFail(f.FederationClientset, nsName, FederatedServiceName) </del> <ins> service = createLBServiceOrFail(f.FederationClientset, nsName, FederatedServiceName, clusters) </ins> obj, err := scheme.Scheme.DeepCopy(service) // Cloning shouldn't fail. On the off-chance it does, we // should shallow copy service to serviceShard before", "commid": "kubernetes_pr_45186"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0318647ed38ee346e4394847572fe3c715455e2328b33549b60619adece32e73", "query": "In order to support running tests in parallel, we randomized NodePort selection. There appears to be some evidence that this is not sufficient and is causing e2e test flakes: https://k8s-\nHi, As a need contributor, I'm interesting of solving this issue. I already check the current code, and propose to retry the service creation until success or all possible ports (between FederatedSvcNodePortFirst and FederatedSvcNodePortLast) have been tried. If this approach is fine for you, I can submit a PR soon.\nHow do you plan to check if the NodePorts are available? In our presubmit test environment, tests run across many instances of federation control planes in parallel, but share the same underlying clusters. So this approach might be viable depending on how and where you plan to check for these used NodePorts.\nmy approach for getting an available port is a \"Dummy\" approach: create a list of possible available port, get one of them randomly, then try to create the Service. If Service creation failed. try to use another possible available port, until service creation success or all possible available ports have been tested.\nSounds reasonable to me. Go for it. A couple of caveats: need to create a real list, you could just use the range boundaries. careful about service creation failure. You need to check if the service shard creation failed in the underlying clusters and rollback all those shards before retrying.\nthanks for the caveats, I will do soon a PR.\nHi, what is the state of this issue? Is working in this issues with the others issues related to e2e tests?\nhas a PR to fix this issue -", "positive_passages": [{"docid": "doc-en-kubernetes-03ec4f3dd199c07d18f66dbf601205a56c5942dd4fc53c84219ec0d5fed31a47", "text": "return clientset.CoreV1().Services(namespace).Create(service) } <del> func createLBService(clientset *fedclientset.Clientset, namespace, name string) (*v1.Service, error) { </del> <ins> func createLBService(clientset *fedclientset.Clientset, namespace, name string, clusters fedframework.ClusterSlice) (*v1.Service, error) { </ins> if clientset == nil || len(namespace) == 0 { return nil, fmt.Errorf(\"Internal error: invalid parameters passed to createService: clientset: %v, namespace: %v\", clientset, namespace) }", "commid": "kubernetes_pr_45186"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0318647ed38ee346e4394847572fe3c715455e2328b33549b60619adece32e73", "query": "In order to support running tests in parallel, we randomized NodePort selection. There appears to be some evidence that this is not sufficient and is causing e2e test flakes: https://k8s-\nHi, As a need contributor, I'm interesting of solving this issue. I already check the current code, and propose to retry the service creation until success or all possible ports (between FederatedSvcNodePortFirst and FederatedSvcNodePortLast) have been tried. If this approach is fine for you, I can submit a PR soon.\nHow do you plan to check if the NodePorts are available? In our presubmit test environment, tests run across many instances of federation control planes in parallel, but share the same underlying clusters. So this approach might be viable depending on how and where you plan to check for these used NodePorts.\nmy approach for getting an available port is a \"Dummy\" approach: create a list of possible available port, get one of them randomly, then try to create the Service. If Service creation failed. try to use another possible available port, until service creation success or all possible available ports have been tested.\nSounds reasonable to me. Go for it. A couple of caveats: need to create a real list, you could just use the range boundaries. careful about service creation failure. You need to check if the service shard creation failed in the underlying clusters and rollback all those shards before retrying.\nthanks for the caveats, I will do soon a PR.\nHi, what is the state of this issue? Is working in this issues with the others issues related to e2e tests?\nhas a PR to fix this issue -", "positive_passages": [{"docid": "doc-en-kubernetes-d70d40f41d30b8b5849eb8704391fe51bc8c8d54c84f73824169419e5ee7db14", "text": "// Tests can be run in parallel, so we need a different nodePort for // each test. <del> // We add 1 to FederatedSvcNodePortLast because IntnRange's range end // is not inclusive. nodePort := int32(rand.IntnRange(FederatedSvcNodePortFirst, FederatedSvcNodePortLast+1)) </del> <ins> // we add in a array all the \"available\" ports availablePorts := make([]int32, FederatedSvcNodePortLast-FederatedSvcNodePortFirst) for i := range availablePorts { availablePorts[i] = int32(FederatedSvcNodePortFirst + i) } var err error var service *v1.Service retry := 10 // the function should retry the service creation on different port only 10 time. // until the availablePort list is not empty, lets try to create the service for len(availablePorts) > 0 && retry > 0 { // select the Id of an available port i := rand.Intn(len(availablePorts)) By(fmt.Sprintf(\"try creating federated service %q in namespace %q with nodePort %d\", name, namespace, availablePorts[i])) service, err = createServiceWithNodePort(clientset, namespace, name, availablePorts[i]) if err == nil { // check if service have been created properly in all clusters. // if the service is not present in one of the clusters, we should cleanup all services if err = checkServicesCreation(namespace, name, clusters); err == nil { // everything was created properly so returns the federated service. return service, nil } } // in case of error, cleanup everything if service != nil { if err = deleteService(clientset, namespace, name, nil); err != nil { framework.ExpectNoError(err, \"Deleting service %q after a partial createService() error\", service.Name) return nil, err } cleanupServiceShardsAndProviderResources(namespace, service, clusters) } // creation failed, lets try with another port // first remove from the availablePorts the port with which the creation failed availablePorts = append(availablePorts[:i], availablePorts[i+1:]...) retry-- } return nil, err } func createServiceWithNodePort(clientset *fedclientset.Clientset, namespace, name string, nodePort int32) (*v1.Service, error) { </ins> service := &v1.Service{ ObjectMeta: metav1.ObjectMeta{ Name:      name,", "commid": "kubernetes_pr_45186"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0318647ed38ee346e4394847572fe3c715455e2328b33549b60619adece32e73", "query": "In order to support running tests in parallel, we randomized NodePort selection. There appears to be some evidence that this is not sufficient and is causing e2e test flakes: https://k8s-\nHi, As a need contributor, I'm interesting of solving this issue. I already check the current code, and propose to retry the service creation until success or all possible ports (between FederatedSvcNodePortFirst and FederatedSvcNodePortLast) have been tried. If this approach is fine for you, I can submit a PR soon.\nHow do you plan to check if the NodePorts are available? In our presubmit test environment, tests run across many instances of federation control planes in parallel, but share the same underlying clusters. So this approach might be viable depending on how and where you plan to check for these used NodePorts.\nmy approach for getting an available port is a \"Dummy\" approach: create a list of possible available port, get one of them randomly, then try to create the Service. If Service creation failed. try to use another possible available port, until service creation success or all possible available ports have been tested.\nSounds reasonable to me. Go for it. A couple of caveats: need to create a real list, you could just use the range boundaries. careful about service creation failure. You need to check if the service shard creation failed in the underlying clusters and rollback all those shards before retrying.\nthanks for the caveats, I will do soon a PR.\nHi, what is the state of this issue? Is working in this issues with the others issues related to e2e tests?\nhas a PR to fix this issue -", "positive_passages": [{"docid": "doc-en-kubernetes-ac4d7111808cacddffea38c1c4fdca5c1de8949c74378c86218bffbbca0f0921", "text": "return clientset.CoreV1().Services(namespace).Create(service) } <ins> // checkServicesCreation checks if the service have been created successfuly in all the clusters. // if the service is not present in at least one of the clusters, this function returns an error. func checkServicesCreation(namespace, serviceName string, clusters fedframework.ClusterSlice) error { framework.Logf(\"check if service %q have been created in %d clusters\", serviceName, len(clusters)) for _, cluster := range clusters { name := cluster.Name err := wait.PollImmediate(framework.Poll, fedframework.FederatedDefaultTestTimeout, func() (bool, error) { var err error _, err = cluster.Clientset.CoreV1().Services(namespace).Get(serviceName, metav1.GetOptions{}) if err != nil && !errors.IsNotFound(err) { // Get failed with an error, try again. framework.Logf(\"Failed to find service %q in namespace %q, in cluster %q: %v. Trying again in %s\", serviceName, namespace, name, err, framework.Poll) return false, err } else if errors.IsNotFound(err) { framework.Logf(\"Service %q in namespace %q in cluster %q not found. Trying again in %s\", serviceName, namespace, name, framework.Poll) return false, nil } By(fmt.Sprintf(\"Service %q in namespace %q in cluster %q found\", serviceName, namespace, name)) return true, nil }) if err != nil { return err } } return nil } </ins> func createServiceOrFail(clientset *fedclientset.Clientset, namespace, name string) *v1.Service { service, err := createService(clientset, namespace, name) framework.ExpectNoError(err, \"Creating service %q in namespace %q\", service.Name, namespace)", "commid": "kubernetes_pr_45186"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0318647ed38ee346e4394847572fe3c715455e2328b33549b60619adece32e73", "query": "In order to support running tests in parallel, we randomized NodePort selection. There appears to be some evidence that this is not sufficient and is causing e2e test flakes: https://k8s-\nHi, As a need contributor, I'm interesting of solving this issue. I already check the current code, and propose to retry the service creation until success or all possible ports (between FederatedSvcNodePortFirst and FederatedSvcNodePortLast) have been tried. If this approach is fine for you, I can submit a PR soon.\nHow do you plan to check if the NodePorts are available? In our presubmit test environment, tests run across many instances of federation control planes in parallel, but share the same underlying clusters. So this approach might be viable depending on how and where you plan to check for these used NodePorts.\nmy approach for getting an available port is a \"Dummy\" approach: create a list of possible available port, get one of them randomly, then try to create the Service. If Service creation failed. try to use another possible available port, until service creation success or all possible available ports have been tested.\nSounds reasonable to me. Go for it. A couple of caveats: need to create a real list, you could just use the range boundaries. careful about service creation failure. You need to check if the service shard creation failed in the underlying clusters and rollback all those shards before retrying.\nthanks for the caveats, I will do soon a PR.\nHi, what is the state of this issue? Is working in this issues with the others issues related to e2e tests?\nhas a PR to fix this issue -", "positive_passages": [{"docid": "doc-en-kubernetes-5be095fb89afbcb374034497f94ee5c9183987c97747cd7615c136d0f262cf84", "text": "return service } <del> func createLBServiceOrFail(clientset *fedclientset.Clientset, namespace, name string) *v1.Service { service, err := createLBService(clientset, namespace, name) </del> <ins> func createLBServiceOrFail(clientset *fedclientset.Clientset, namespace, name string, clusters fedframework.ClusterSlice) *v1.Service { service, err := createLBService(clientset, namespace, name, clusters) </ins> framework.ExpectNoError(err, \"Creating service %q in namespace %q\", service.Name, namespace) By(fmt.Sprintf(\"Successfully created federated service (type: load balancer) %q in namespace %q\", name, namespace)) return service", "commid": "kubernetes_pr_45186"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0318647ed38ee346e4394847572fe3c715455e2328b33549b60619adece32e73", "query": "In order to support running tests in parallel, we randomized NodePort selection. There appears to be some evidence that this is not sufficient and is causing e2e test flakes: https://k8s-\nHi, As a need contributor, I'm interesting of solving this issue. I already check the current code, and propose to retry the service creation until success or all possible ports (between FederatedSvcNodePortFirst and FederatedSvcNodePortLast) have been tried. If this approach is fine for you, I can submit a PR soon.\nHow do you plan to check if the NodePorts are available? In our presubmit test environment, tests run across many instances of federation control planes in parallel, but share the same underlying clusters. So this approach might be viable depending on how and where you plan to check for these used NodePorts.\nmy approach for getting an available port is a \"Dummy\" approach: create a list of possible available port, get one of them randomly, then try to create the Service. If Service creation failed. try to use another possible available port, until service creation success or all possible available ports have been tested.\nSounds reasonable to me. Go for it. A couple of caveats: need to create a real list, you could just use the range boundaries. careful about service creation failure. You need to check if the service shard creation failed in the underlying clusters and rollback all those shards before retrying.\nthanks for the caveats, I will do soon a PR.\nHi, what is the state of this issue? Is working in this issues with the others issues related to e2e tests?\nhas a PR to fix this issue -", "positive_passages": [{"docid": "doc-en-kubernetes-665455d5e4110c8e13f3191dd979e16bf5dfecd8003a6d800d20a37b35d25873", "text": "Fail(fmt.Sprintf(\"Internal error: invalid parameters passed to deleteServiceOrFail: clientset: %v, namespace: %v, service: %v\", clientset, namespace, serviceName)) } framework.Logf(\"Deleting service %q in namespace %v\", serviceName, namespace) <ins> err := deleteService(clientset, namespace, serviceName, orphanDependents) if err != nil { framework.ExpectNoError(err, \"Error deleting service %q from namespace %q\", serviceName, namespace) } } func deleteService(clientset *fedclientset.Clientset, namespace string, serviceName string, orphanDependents *bool) error { </ins> err := clientset.CoreV1().Services(namespace).Delete(serviceName, &metav1.DeleteOptions{OrphanDependents: orphanDependents}) <del> framework.ExpectNoError(err, \"Error deleting service %q from namespace %q\", serviceName, namespace) </del> <ins> if err != nil { return err } </ins> // Wait for the service to be deleted. err = wait.Poll(5*time.Second, fedframework.FederatedDefaultTestTimeout, func() (bool, error) { _, err := clientset.Core().Services(namespace).Get(serviceName, metav1.GetOptions{})", "commid": "kubernetes_pr_45186"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0318647ed38ee346e4394847572fe3c715455e2328b33549b60619adece32e73", "query": "In order to support running tests in parallel, we randomized NodePort selection. There appears to be some evidence that this is not sufficient and is causing e2e test flakes: https://k8s-\nHi, As a need contributor, I'm interesting of solving this issue. I already check the current code, and propose to retry the service creation until success or all possible ports (between FederatedSvcNodePortFirst and FederatedSvcNodePortLast) have been tried. If this approach is fine for you, I can submit a PR soon.\nHow do you plan to check if the NodePorts are available? In our presubmit test environment, tests run across many instances of federation control planes in parallel, but share the same underlying clusters. So this approach might be viable depending on how and where you plan to check for these used NodePorts.\nmy approach for getting an available port is a \"Dummy\" approach: create a list of possible available port, get one of them randomly, then try to create the Service. If Service creation failed. try to use another possible available port, until service creation success or all possible available ports have been tested.\nSounds reasonable to me. Go for it. A couple of caveats: need to create a real list, you could just use the range boundaries. careful about service creation failure. You need to check if the service shard creation failed in the underlying clusters and rollback all those shards before retrying.\nthanks for the caveats, I will do soon a PR.\nHi, what is the state of this issue? Is working in this issues with the others issues related to e2e tests?\nhas a PR to fix this issue -", "positive_passages": [{"docid": "doc-en-kubernetes-867d0a8831a25c2e0876abc265097bb13bf402256160f935f5f2a38e05c4ed66", "text": "} return false, err }) <del> if err != nil { framework.DescribeSvc(namespace) framework.Failf(\"Error in deleting service %s: %v\", serviceName, err) } </del> <ins> return err </ins> } func cleanupServiceShardsAndProviderResources(namespace string, service *v1.Service, clusters fedframework.ClusterSlice) {", "commid": "kubernetes_pr_45186"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-372f31bbae35c3eba7fa05d29bef438fa01153dd17bab3d567afcb0b28d24b93", "query": "We copy in BUILD files from the saved directories. The BUILD files should be preserved. This was hit in", "positive_passages": [{"docid": "doc-en-kubernetes-170c0452b14d8fdce27c3b9035b11bfd062cdbc37b3f28a7d33a92fb312484a6", "text": "if [ \"${DRY_RUN}\" = false ]; then ls \"${CLIENT_REPO}\" | { grep -v '_tmp' || true; } | xargs rm -rf mv \"${CLIENT_REPO_TEMP}\"/* \"${CLIENT_REPO}\" <ins> git checkout HEAD -- $(find \"${CLIENT_REPO}\" -name BUILD) </ins> fi", "commid": "kubernetes_pr_44568"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cec61f8ec69a9d7d7e36e7d5da8c4f6dcc87324a534945b6990d0e34da434212", "query": "The web and instructions for [Installing and Setting Up kubectl] need a slight tuneup. The homebrew instructions should reflect a few different options for Bash on macOS. bash-completion is for Bash 3.2 (macOS default), and bash-completion is for Bash 4.1+ (upgraded GNU Bash) I lost an hour of my life to this; I hope this helps others. What happened: By following the homebrew install instructions on this page, then entering and tabbing, this is the output: What you expected to happen: By following the same path as above this should be the output: Anything else we need to know: Currently the instructions assume the default Bash on a vanilla macOS install; while I understand this being most-likely scenario, the default version of Bash is shamefully old. After reviewing to options in homebrew it appears there are 2: -completion is for Bash 3.2 and -completion is for Bash 4.1+ For those of us that cannot live without all the options, this is how we do: Install: Configure Then the needs to be updated to reflect this changes: TEST a new tab (the is sourced-in) and tab twice We then get the expected result. The requested details follow: Kubernetes version (use ): Environment: personal/dev Cloud provider or hardware configuration: NA OS (e.g. from /etc/os-release): macOS Sierra Kernel (e.g. ): Install tools: homebrew [Installing and Setting Up kubectl]\nSo were you running bash 3.2 or bash 4 prior to this? It looks like the instructions are for bash-completion which should be for the bash installed by default in macOS. /assign\nI always install the latest Bash, currently 4.4.12(1)-release. Apple's is too old and I'm not going live in their cave; most people won't - that's why homebrew is a huge project. Correct, the instructions are for the stock version of Bash (presently 3.2.57(1)-release). My suggestion is to include instructions for both versions. Mostly to keep others from wasting the same time. I've already done the testing so folding in the new details should be pretty straight-forward.\nI've opened to update the kubernetes documentation, and to potentially update how homebrew works to make this clearer.\nDocs have been updated: /close", "positive_passages": [{"docid": "doc-en-kubernetes-531080c7d0d49ca94cca87a27a474740fcd4e41b15e3c7a649295427c5be7119", "text": "var ( // TODO: Deprecate gitMajor and gitMinor, use only gitVersion instead. gitMajor     string = \"0\"              // major version, always numeric <del> gitMinor     string = \"8.2+\"           // minor version, numeric possibly followed by \"+\" gitVersion   string = \"v0.8.2-dev\"     // version from git, output of $(git describe) </del> <ins> gitMinor     string = \"8.3\"            // minor version, numeric possibly followed by \"+\" gitVersion   string = \"v0.8.3\"         // version from git, output of $(git describe) </ins> gitCommit    string = \"\"               // sha1 from git, output of $(git rev-parse HEAD) gitTreeState string = \"not a git tree\" // state of git tree, either \"clean\" or \"dirty\" )", "commid": "kubernetes_pr_3737"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-10a8babb28c4f6ea333338ba9c51d88b95dc0d525c3b45d618113f0ab8d21a82", "query": "seen in https://k8s-\nShould be fixed by\nI believe this is fixed?\nYes, I missed this one.", "positive_passages": [{"docid": "doc-en-kubernetes-9b32fa979a405642195e76a01a23aa117f2b38cf55f193263b26af258a975529", "text": "package spdy import ( <ins> \"bufio\" </ins> \"fmt\" <ins> \"io\" \"net\" </ins> \"net/http\" \"strings\" <ins> \"sync/atomic\" </ins> \"k8s.io/apimachinery/pkg/util/httpstream\" \"k8s.io/apimachinery/pkg/util/runtime\"", "commid": "kubernetes_pr_43922"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-10a8babb28c4f6ea333338ba9c51d88b95dc0d525c3b45d618113f0ab8d21a82", "query": "seen in https://k8s-\nShould be fixed by\nI believe this is fixed?\nYes, I missed this one.", "positive_passages": [{"docid": "doc-en-kubernetes-1bfabb8f9988be4d28b8dc2293e4f2d194e78a2d59901a4914e76687ba874bd6", "text": "type responseUpgrader struct { } <ins> // connWrapper is used to wrap a hijacked connection and its bufio.Reader. All // calls will be handled directly by the underlying net.Conn with the exception // of Read and Close calls, which will consider data in the bufio.Reader. This // ensures that data already inside the used bufio.Reader instance is also // read. type connWrapper struct { net.Conn closed    int32 bufReader *bufio.Reader } func (w *connWrapper) Read(b []byte) (n int, err error) { if atomic.LoadInt32(&w.closed) == 1 { return 0, io.EOF } return w.bufReader.Read(b) } func (w *connWrapper) Close() error { err := w.Conn.Close() atomic.StoreInt32(&w.closed, 1) return err } </ins> // NewResponseUpgrader returns a new httpstream.ResponseUpgrader that is // capable of upgrading HTTP responses using SPDY/3.1 via the // spdystream package.", "commid": "kubernetes_pr_43922"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-10a8babb28c4f6ea333338ba9c51d88b95dc0d525c3b45d618113f0ab8d21a82", "query": "seen in https://k8s-\nShould be fixed by\nI believe this is fixed?\nYes, I missed this one.", "positive_passages": [{"docid": "doc-en-kubernetes-ff7cb02b61e50fb85db39f680dc4d68e4f3bfee79799bad3fe93902c730de6a4", "text": "w.Header().Add(httpstream.HeaderUpgrade, HeaderSpdy31) w.WriteHeader(http.StatusSwitchingProtocols) <del> conn, _, err := hijacker.Hijack() </del> <ins> conn, bufrw, err := hijacker.Hijack() </ins> if err != nil { runtime.HandleError(fmt.Errorf(\"unable to upgrade: error hijacking response: %v\", err)) return nil } <del> spdyConn, err := NewServerConnection(conn, newStreamHandler) </del> <ins> connWithBuf := &connWrapper{Conn: conn, bufReader: bufrw.Reader} spdyConn, err := NewServerConnection(connWithBuf, newStreamHandler) </ins> if err != nil { runtime.HandleError(fmt.Errorf(\"unable to upgrade: error creating SPDY server connection: %v\", err)) return nil", "commid": "kubernetes_pr_43922"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d13ccc3944e3d6c7481ff49d201d25638bf4d84e13a1a49d2028bb29d8f9531f", "query": "https://k8s- Failed: TestServeExecInContainer {server}\nShould be fixed by\nhttps://k8s- Failed: TestServeExecInContainer {server}", "positive_passages": [{"docid": "doc-en-kubernetes-9b32fa979a405642195e76a01a23aa117f2b38cf55f193263b26af258a975529", "text": "package spdy import ( <ins> \"bufio\" </ins> \"fmt\" <ins> \"io\" \"net\" </ins> \"net/http\" \"strings\" <ins> \"sync/atomic\" </ins> \"k8s.io/apimachinery/pkg/util/httpstream\" \"k8s.io/apimachinery/pkg/util/runtime\"", "commid": "kubernetes_pr_43922"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d13ccc3944e3d6c7481ff49d201d25638bf4d84e13a1a49d2028bb29d8f9531f", "query": "https://k8s- Failed: TestServeExecInContainer {server}\nShould be fixed by\nhttps://k8s- Failed: TestServeExecInContainer {server}", "positive_passages": [{"docid": "doc-en-kubernetes-1bfabb8f9988be4d28b8dc2293e4f2d194e78a2d59901a4914e76687ba874bd6", "text": "type responseUpgrader struct { } <ins> // connWrapper is used to wrap a hijacked connection and its bufio.Reader. All // calls will be handled directly by the underlying net.Conn with the exception // of Read and Close calls, which will consider data in the bufio.Reader. This // ensures that data already inside the used bufio.Reader instance is also // read. type connWrapper struct { net.Conn closed    int32 bufReader *bufio.Reader } func (w *connWrapper) Read(b []byte) (n int, err error) { if atomic.LoadInt32(&w.closed) == 1 { return 0, io.EOF } return w.bufReader.Read(b) } func (w *connWrapper) Close() error { err := w.Conn.Close() atomic.StoreInt32(&w.closed, 1) return err } </ins> // NewResponseUpgrader returns a new httpstream.ResponseUpgrader that is // capable of upgrading HTTP responses using SPDY/3.1 via the // spdystream package.", "commid": "kubernetes_pr_43922"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d13ccc3944e3d6c7481ff49d201d25638bf4d84e13a1a49d2028bb29d8f9531f", "query": "https://k8s- Failed: TestServeExecInContainer {server}\nShould be fixed by\nhttps://k8s- Failed: TestServeExecInContainer {server}", "positive_passages": [{"docid": "doc-en-kubernetes-ff7cb02b61e50fb85db39f680dc4d68e4f3bfee79799bad3fe93902c730de6a4", "text": "w.Header().Add(httpstream.HeaderUpgrade, HeaderSpdy31) w.WriteHeader(http.StatusSwitchingProtocols) <del> conn, _, err := hijacker.Hijack() </del> <ins> conn, bufrw, err := hijacker.Hijack() </ins> if err != nil { runtime.HandleError(fmt.Errorf(\"unable to upgrade: error hijacking response: %v\", err)) return nil } <del> spdyConn, err := NewServerConnection(conn, newStreamHandler) </del> <ins> connWithBuf := &connWrapper{Conn: conn, bufReader: bufrw.Reader} spdyConn, err := NewServerConnection(connWithBuf, newStreamHandler) </ins> if err != nil { runtime.HandleError(fmt.Errorf(\"unable to upgrade: error creating SPDY server connection: %v\", err)) return nil", "commid": "kubernetes_pr_43922"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f719394191e6dfa6ab5d9c8d66dff792067fac38082fdfe991b0e433d63e8030", "query": "On , will fail to evaluate a filter when the member does not exist: For instance, if I were to execute Where not all in that namespace had the annotation, this would fail with the error message: This is confusing as it leads me to think more than one item was selected, so while it is not technically incorrect the error message is misleading. I would furthermore expect to more gracefully handle this case -- a missing here means that the filter should fail, not error.\nWhat do you mean by ? How is it different from ?\nAs in, don't add that item to the list of items on which the following access is made. When I do: And there is no annotation on , I just get nothing back -- no error, just nothing. Similarly, i would have expected the filtered expression to give me the for all of the pods that have an annotation with value . That, anyway is what I understand the JSONPath syntax to mean. When you write You are saying:\ncc since you authored and I'm not sure how we want to fix this.\nTaking a look now\nit looks like you need to do this (note that the annotations portion is wrapped by ): I wrote a unit test and it worked as expected. PTAL!\nI'm pretty sure that was a typo on my end but let me check -- do you have a reproducer script?\nI see an entirely different error today... weird:\nOk so you have 1 object with annotations, and 1 without. Let me look into that case.\nLet me add another annotation to\nNo difference if both have annotations:\nOk, I'll have to test using kubectl\nI'm the Origin bundled but I don't think there are any patches on JSONPath there:\nI'm able to reproduce in the unit test when 1 object has annotations and the other does not, if allowMissingKeys is true for the jsonpath parser.\nI see. Let me know if I can be of more help.\nI think I have a fix. PR coming soon.\nPossible", "positive_passages": [{"docid": "doc-en-kubernetes-3ad30ea9c1f61bfdab01798eeb9717434acff09fd7b2da6bd0b6a82ec3ef40e4", "text": "} var left, right interface{} <del> if len(lefts) != 1 { </del> <ins> switch { case len(lefts) == 0: continue case len(lefts) > 1: </ins> return input, fmt.Errorf(\"can only compare one element at a time\") } left = lefts[0].Interface()", "commid": "kubernetes_pr_47846"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f719394191e6dfa6ab5d9c8d66dff792067fac38082fdfe991b0e433d63e8030", "query": "On , will fail to evaluate a filter when the member does not exist: For instance, if I were to execute Where not all in that namespace had the annotation, this would fail with the error message: This is confusing as it leads me to think more than one item was selected, so while it is not technically incorrect the error message is misleading. I would furthermore expect to more gracefully handle this case -- a missing here means that the filter should fail, not error.\nWhat do you mean by ? How is it different from ?\nAs in, don't add that item to the list of items on which the following access is made. When I do: And there is no annotation on , I just get nothing back -- no error, just nothing. Similarly, i would have expected the filtered expression to give me the for all of the pods that have an annotation with value . That, anyway is what I understand the JSONPath syntax to mean. When you write You are saying:\ncc since you authored and I'm not sure how we want to fix this.\nTaking a look now\nit looks like you need to do this (note that the annotations portion is wrapped by ): I wrote a unit test and it worked as expected. PTAL!\nI'm pretty sure that was a typo on my end but let me check -- do you have a reproducer script?\nI see an entirely different error today... weird:\nOk so you have 1 object with annotations, and 1 without. Let me look into that case.\nLet me add another annotation to\nNo difference if both have annotations:\nOk, I'll have to test using kubectl\nI'm the Origin bundled but I don't think there are any patches on JSONPath there:\nI'm able to reproduce in the unit test when 1 object has annotations and the other does not, if allowMissingKeys is true for the jsonpath parser.\nI see. Let me know if I can be of more help.\nI think I have a fix. PR coming soon.\nPossible", "positive_passages": [{"docid": "doc-en-kubernetes-782fbd79a5f19e220622de9146ca8d8b5b9e0fbe4ed353adf0592d54ee12611a", "text": "if err != nil { return input, err } <del> if len(rights) != 1 { </del> <ins> switch { case len(rights) == 0: continue case len(rights) > 1: </ins> return input, fmt.Errorf(\"can only compare one element at a time\") } right = rights[0].Interface()", "commid": "kubernetes_pr_47846"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f719394191e6dfa6ab5d9c8d66dff792067fac38082fdfe991b0e433d63e8030", "query": "On , will fail to evaluate a filter when the member does not exist: For instance, if I were to execute Where not all in that namespace had the annotation, this would fail with the error message: This is confusing as it leads me to think more than one item was selected, so while it is not technically incorrect the error message is misleading. I would furthermore expect to more gracefully handle this case -- a missing here means that the filter should fail, not error.\nWhat do you mean by ? How is it different from ?\nAs in, don't add that item to the list of items on which the following access is made. When I do: And there is no annotation on , I just get nothing back -- no error, just nothing. Similarly, i would have expected the filtered expression to give me the for all of the pods that have an annotation with value . That, anyway is what I understand the JSONPath syntax to mean. When you write You are saying:\ncc since you authored and I'm not sure how we want to fix this.\nTaking a look now\nit looks like you need to do this (note that the annotations portion is wrapped by ): I wrote a unit test and it worked as expected. PTAL!\nI'm pretty sure that was a typo on my end but let me check -- do you have a reproducer script?\nI see an entirely different error today... weird:\nOk so you have 1 object with annotations, and 1 without. Let me look into that case.\nLet me add another annotation to\nNo difference if both have annotations:\nOk, I'll have to test using kubectl\nI'm the Origin bundled but I don't think there are any patches on JSONPath there:\nI'm able to reproduce in the unit test when 1 object has annotations and the other does not, if allowMissingKeys is true for the jsonpath parser.\nI see. Let me know if I can be of more help.\nI think I have a fix. PR coming soon.\nPossible", "positive_passages": [{"docid": "doc-en-kubernetes-e5d802c6cf888415f538289a0bc7dadb78e4459b452b7d38d3103b9c9a28ac6a", "text": ") type jsonpathTest struct { <del> name     string template string input    interface{} expect   string </del> <ins> name        string template    string input       interface{} expect      string expectError bool </ins> } func testJSONPath(tests []jsonpathTest, allowMissingKeys bool, t *testing.T) {", "commid": "kubernetes_pr_47846"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f719394191e6dfa6ab5d9c8d66dff792067fac38082fdfe991b0e433d63e8030", "query": "On , will fail to evaluate a filter when the member does not exist: For instance, if I were to execute Where not all in that namespace had the annotation, this would fail with the error message: This is confusing as it leads me to think more than one item was selected, so while it is not technically incorrect the error message is misleading. I would furthermore expect to more gracefully handle this case -- a missing here means that the filter should fail, not error.\nWhat do you mean by ? How is it different from ?\nAs in, don't add that item to the list of items on which the following access is made. When I do: And there is no annotation on , I just get nothing back -- no error, just nothing. Similarly, i would have expected the filtered expression to give me the for all of the pods that have an annotation with value . That, anyway is what I understand the JSONPath syntax to mean. When you write You are saying:\ncc since you authored and I'm not sure how we want to fix this.\nTaking a look now\nit looks like you need to do this (note that the annotations portion is wrapped by ): I wrote a unit test and it worked as expected. PTAL!\nI'm pretty sure that was a typo on my end but let me check -- do you have a reproducer script?\nI see an entirely different error today... weird:\nOk so you have 1 object with annotations, and 1 without. Let me look into that case.\nLet me add another annotation to\nNo difference if both have annotations:\nOk, I'll have to test using kubectl\nI'm the Origin bundled but I don't think there are any patches on JSONPath there:\nI'm able to reproduce in the unit test when 1 object has annotations and the other does not, if allowMissingKeys is true for the jsonpath parser.\nI see. Let me know if I can be of more help.\nI think I have a fix. PR coming soon.\nPossible", "positive_passages": [{"docid": "doc-en-kubernetes-5fac69deede58d3e9b276f8aa336df98d424d9c575616cdca25ffc21560a7dc3", "text": "} buf := new(bytes.Buffer) err = j.Execute(buf, test.input) <del> if err != nil { </del> <ins> if test.expectError { if test.expectError && err == nil { t.Errorf(\"in %s, expected execute error\", test.name) } continue } else if err != nil { </ins> t.Errorf(\"in %s, execute error %v\", test.name, err) } out := buf.String()", "commid": "kubernetes_pr_47846"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f719394191e6dfa6ab5d9c8d66dff792067fac38082fdfe991b0e433d63e8030", "query": "On , will fail to evaluate a filter when the member does not exist: For instance, if I were to execute Where not all in that namespace had the annotation, this would fail with the error message: This is confusing as it leads me to think more than one item was selected, so while it is not technically incorrect the error message is misleading. I would furthermore expect to more gracefully handle this case -- a missing here means that the filter should fail, not error.\nWhat do you mean by ? How is it different from ?\nAs in, don't add that item to the list of items on which the following access is made. When I do: And there is no annotation on , I just get nothing back -- no error, just nothing. Similarly, i would have expected the filtered expression to give me the for all of the pods that have an annotation with value . That, anyway is what I understand the JSONPath syntax to mean. When you write You are saying:\ncc since you authored and I'm not sure how we want to fix this.\nTaking a look now\nit looks like you need to do this (note that the annotations portion is wrapped by ): I wrote a unit test and it worked as expected. PTAL!\nI'm pretty sure that was a typo on my end but let me check -- do you have a reproducer script?\nI see an entirely different error today... weird:\nOk so you have 1 object with annotations, and 1 without. Let me look into that case.\nLet me add another annotation to\nNo difference if both have annotations:\nOk, I'll have to test using kubectl\nI'm the Origin bundled but I don't think there are any patches on JSONPath there:\nI'm able to reproduce in the unit test when 1 object has annotations and the other does not, if allowMissingKeys is true for the jsonpath parser.\nI see. Let me know if I can be of more help.\nI think I have a fix. PR coming soon.\nPossible", "positive_passages": [{"docid": "doc-en-kubernetes-22b1d22546bc1653e9126bd97131a92ee8b0dbab9fb68f55add708d963bcd723", "text": "} storeTests := []jsonpathTest{ <del> {\"plain\", \"hello jsonpath\", nil, \"hello jsonpath\"}, {\"recursive\", \"{..}\", []int{1, 2, 3}, \"[1 2 3]\"}, {\"filter\", \"{[?(@<5)]}\", []int{2, 6, 3, 7}, \"2 3\"}, {\"quote\", `{\"{\"}`, nil, \"{\"}, {\"union\", \"{[1,3,4]}\", []int{0, 1, 2, 3, 4}, \"1 3 4\"}, {\"array\", \"{[0:2]}\", []string{\"Monday\", \"Tudesday\"}, \"Monday Tudesday\"}, {\"variable\", \"hello {.Name}\", storeData, \"hello jsonpath\"}, {\"dict/\", \"{$.Labels.web/html}\", storeData, \"15\"}, {\"dict/\", \"{$.Employees.jason}\", storeData, \"manager\"}, {\"dict/\", \"{$.Employees.dan}\", storeData, \"clerk\"}, {\"dict-\", \"{.Labels.k8s-app}\", storeData, \"20\"}, {\"nest\", \"{.Bicycle[*].Color}\", storeData, \"red green\"}, {\"allarray\", \"{.Book[*].Author}\", storeData, \"Nigel Rees Evelyn Waugh Herman Melville\"}, {\"allfileds\", \"{.Bicycle.*}\", storeData, \"{red 19.95 true} {green 20.01 false}\"}, {\"recurfileds\", \"{..Price}\", storeData, \"8.95 12.99 8.99 19.95 20.01\"}, </del> <ins> {\"plain\", \"hello jsonpath\", nil, \"hello jsonpath\", false}, {\"recursive\", \"{..}\", []int{1, 2, 3}, \"[1 2 3]\", false}, {\"filter\", \"{[?(@<5)]}\", []int{2, 6, 3, 7}, \"2 3\", false}, {\"quote\", `{\"{\"}`, nil, \"{\", false}, {\"union\", \"{[1,3,4]}\", []int{0, 1, 2, 3, 4}, \"1 3 4\", false}, {\"array\", \"{[0:2]}\", []string{\"Monday\", \"Tudesday\"}, \"Monday Tudesday\", false}, {\"variable\", \"hello {.Name}\", storeData, \"hello jsonpath\", false}, {\"dict/\", \"{$.Labels.web/html}\", storeData, \"15\", false}, {\"dict/\", \"{$.Employees.jason}\", storeData, \"manager\", false}, {\"dict/\", \"{$.Employees.dan}\", storeData, \"clerk\", false}, {\"dict-\", \"{.Labels.k8s-app}\", storeData, \"20\", false}, {\"nest\", \"{.Bicycle[*].Color}\", storeData, \"red green\", false}, {\"allarray\", \"{.Book[*].Author}\", storeData, \"Nigel Rees Evelyn Waugh Herman Melville\", false}, {\"allfileds\", \"{.Bicycle.*}\", storeData, \"{red 19.95 true} {green 20.01 false}\", false}, {\"recurfileds\", \"{..Price}\", storeData, \"8.95 12.99 8.99 19.95 20.01\", false}, </ins> {\"lastarray\", \"{.Book[-1:]}\", storeData, <del> \"{Category: fiction, Author: Herman Melville, Title: Moby Dick, Price: 8.99}\"}, </del> <ins> \"{Category: fiction, Author: Herman Melville, Title: Moby Dick, Price: 8.99}\", false}, </ins> {\"recurarray\", \"{..Book[2]}\", storeData, <del> \"{Category: fiction, Author: Herman Melville, Title: Moby Dick, Price: 8.99}\"}, {\"bool\", \"{.Bicycle[?(@.IsNew==true)]}\", storeData, \"{red 19.95 true}\"}, </del> <ins> \"{Category: fiction, Author: Herman Melville, Title: Moby Dick, Price: 8.99}\", false}, {\"bool\", \"{.Bicycle[?(@.IsNew==true)]}\", storeData, \"{red 19.95 true}\", false}, </ins> } testJSONPath(storeTests, false, t) missingKeyTests := []jsonpathTest{ <del> {\"nonexistent field\", \"{.hello}\", storeData, \"\"}, </del> <ins> {\"nonexistent field\", \"{.hello}\", storeData, \"\", false}, </ins> } testJSONPath(missingKeyTests, true, t) failStoreTests := []jsonpathTest{ <del> {\"invalid identifier\", \"{hello}\", storeData, \"unrecognized identifier hello\"}, {\"nonexistent field\", \"{.hello}\", storeData, \"hello is not found\"}, {\"invalid array\", \"{.Labels[0]}\", storeData, \"map[string]int is not array or slice\"}, {\"invalid filter operator\", \"{.Book[?(@.Price<>10)]}\", storeData, \"unrecognized filter operator <>\"}, {\"redundent end\", \"{range .Labels.*}{@}{end}{end}\", storeData, \"not in range, nothing to end\"}, </del> <ins> {\"invalid identifier\", \"{hello}\", storeData, \"unrecognized identifier hello\", false}, {\"nonexistent field\", \"{.hello}\", storeData, \"hello is not found\", false}, {\"invalid array\", \"{.Labels[0]}\", storeData, \"map[string]int is not array or slice\", false}, {\"invalid filter operator\", \"{.Book[?(@.Price<>10)]}\", storeData, \"unrecognized filter operator <>\", false}, {\"redundent end\", \"{range .Labels.*}{@}{end}{end}\", storeData, \"not in range, nothing to end\", false}, </ins> } testFailJSONPath(failStoreTests, t) }", "commid": "kubernetes_pr_47846"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f719394191e6dfa6ab5d9c8d66dff792067fac38082fdfe991b0e433d63e8030", "query": "On , will fail to evaluate a filter when the member does not exist: For instance, if I were to execute Where not all in that namespace had the annotation, this would fail with the error message: This is confusing as it leads me to think more than one item was selected, so while it is not technically incorrect the error message is misleading. I would furthermore expect to more gracefully handle this case -- a missing here means that the filter should fail, not error.\nWhat do you mean by ? How is it different from ?\nAs in, don't add that item to the list of items on which the following access is made. When I do: And there is no annotation on , I just get nothing back -- no error, just nothing. Similarly, i would have expected the filtered expression to give me the for all of the pods that have an annotation with value . That, anyway is what I understand the JSONPath syntax to mean. When you write You are saying:\ncc since you authored and I'm not sure how we want to fix this.\nTaking a look now\nit looks like you need to do this (note that the annotations portion is wrapped by ): I wrote a unit test and it worked as expected. PTAL!\nI'm pretty sure that was a typo on my end but let me check -- do you have a reproducer script?\nI see an entirely different error today... weird:\nOk so you have 1 object with annotations, and 1 without. Let me look into that case.\nLet me add another annotation to\nNo difference if both have annotations:\nOk, I'll have to test using kubectl\nI'm the Origin bundled but I don't think there are any patches on JSONPath there:\nI'm able to reproduce in the unit test when 1 object has annotations and the other does not, if allowMissingKeys is true for the jsonpath parser.\nI see. Let me know if I can be of more help.\nI think I have a fix. PR coming soon.\nPossible", "positive_passages": [{"docid": "doc-en-kubernetes-6e0de02ba8f70ba9eba8b1d8dccd95f5aae13ba65a786ccabfdc7971442ad44a", "text": "t.Error(err) } pointsTests := []jsonpathTest{ <del> {\"exists filter\", \"{[?(@.z)].id}\", pointsData, \"i2 i5\"}, {\"bracket key\", \"{[0]['id']}\", pointsData, \"i1\"}, </del> <ins> {\"exists filter\", \"{[?(@.z)].id}\", pointsData, \"i2 i5\", false}, {\"bracket key\", \"{[0]['id']}\", pointsData, \"i1\", false}, </ins> } testJSONPath(pointsTests, false, t) }", "commid": "kubernetes_pr_47846"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f719394191e6dfa6ab5d9c8d66dff792067fac38082fdfe991b0e433d63e8030", "query": "On , will fail to evaluate a filter when the member does not exist: For instance, if I were to execute Where not all in that namespace had the annotation, this would fail with the error message: This is confusing as it leads me to think more than one item was selected, so while it is not technically incorrect the error message is misleading. I would furthermore expect to more gracefully handle this case -- a missing here means that the filter should fail, not error.\nWhat do you mean by ? How is it different from ?\nAs in, don't add that item to the list of items on which the following access is made. When I do: And there is no annotation on , I just get nothing back -- no error, just nothing. Similarly, i would have expected the filtered expression to give me the for all of the pods that have an annotation with value . That, anyway is what I understand the JSONPath syntax to mean. When you write You are saying:\ncc since you authored and I'm not sure how we want to fix this.\nTaking a look now\nit looks like you need to do this (note that the annotations portion is wrapped by ): I wrote a unit test and it worked as expected. PTAL!\nI'm pretty sure that was a typo on my end but let me check -- do you have a reproducer script?\nI see an entirely different error today... weird:\nOk so you have 1 object with annotations, and 1 without. Let me look into that case.\nLet me add another annotation to\nNo difference if both have annotations:\nOk, I'll have to test using kubectl\nI'm the Origin bundled but I don't think there are any patches on JSONPath there:\nI'm able to reproduce in the unit test when 1 object has annotations and the other does not, if allowMissingKeys is true for the jsonpath parser.\nI see. Let me know if I can be of more help.\nI think I have a fix. PR coming soon.\nPossible", "positive_passages": [{"docid": "doc-en-kubernetes-d2879fe79ff80d12ad41d8480d3708ae73b3fda3966c16febef35b7d47ae7c83", "text": "} nodesTests := []jsonpathTest{ <del> {\"range item\", `{range .items[*]}{.metadata.name}, {end}{.kind}`, nodesData, \"127.0.0.1, 127.0.0.2, List\"}, {\"range item with quote\", `{range .items[*]}{.metadata.name}{\"t\"}{end}`, nodesData, \"127.0.0.1t127.0.0.2t\"}, </del> <ins> {\"range item\", `{range .items[*]}{.metadata.name}, {end}{.kind}`, nodesData, \"127.0.0.1, 127.0.0.2, List\", false}, {\"range item with quote\", `{range .items[*]}{.metadata.name}{\"t\"}{end}`, nodesData, \"127.0.0.1t127.0.0.2t\", false}, </ins> {\"range addresss\", `{.items[*].status.addresses[*].address}`, nodesData, <del> \"127.0.0.1 127.0.0.2 127.0.0.3\"}, </del> <ins> \"127.0.0.1 127.0.0.2 127.0.0.3\", false}, </ins> {\"double range\", `{range .items[*]}{range .status.addresses[*]}{.address}, {end}{end}`, nodesData, <del> \"127.0.0.1, 127.0.0.2, 127.0.0.3, \"}, {\"item name\", `{.items[*].metadata.name}`, nodesData, \"127.0.0.1 127.0.0.2\"}, </del> <ins> \"127.0.0.1, 127.0.0.2, 127.0.0.3, \", false}, {\"item name\", `{.items[*].metadata.name}`, nodesData, \"127.0.0.1 127.0.0.2\", false}, </ins> {\"union nodes capacity\", `{.items[*]['metadata.name', 'status.capacity']}`, nodesData, <del> \"127.0.0.1 127.0.0.2 map[cpu:4] map[cpu:8]\"}, </del> <ins> \"127.0.0.1 127.0.0.2 map[cpu:4] map[cpu:8]\", false}, </ins> {\"range nodes capacity\", `{range .items[*]}[{.metadata.name}, {.status.capacity}] {end}`, nodesData, <del> \"[127.0.0.1, map[cpu:4]] [127.0.0.2, map[cpu:8]] \"}, {\"user password\", `{.users[?(@.name==\"e2e\")].user.password}`, &nodesData, \"secret\"}, {\"hostname\", `{.items[0].metadata.labels.kubernetes.io/hostname}`, &nodesData, \"127.0.0.1\"}, {\"hostname filter\", `{.items[?(@.metadata.labels.kubernetes.io/hostname==\"127.0.0.1\")].kind}`, &nodesData, \"None\"}, {\"bool item\", `{.items[?(@..ready==true)].metadata.name}`, &nodesData, \"127.0.0.1\"}, </del> <ins> \"[127.0.0.1, map[cpu:4]] [127.0.0.2, map[cpu:8]] \", false}, {\"user password\", `{.users[?(@.name==\"e2e\")].user.password}`, &nodesData, \"secret\", false}, {\"hostname\", `{.items[0].metadata.labels.kubernetes.io/hostname}`, &nodesData, \"127.0.0.1\", false}, {\"hostname filter\", `{.items[?(@.metadata.labels.kubernetes.io/hostname==\"127.0.0.1\")].kind}`, &nodesData, \"None\", false}, {\"bool item\", `{.items[?(@..ready==true)].metadata.name}`, &nodesData, \"127.0.0.1\", false}, </ins> } testJSONPath(nodesTests, false, t) randomPrintOrderTests := []jsonpathTest{ <del> {\"recursive name\", \"{..name}\", nodesData, `127.0.0.1 127.0.0.2 myself e2e`}, </del> <ins> {\"recursive name\", \"{..name}\", nodesData, `127.0.0.1 127.0.0.2 myself e2e`, false}, </ins> } testJSONPathSortOutput(randomPrintOrderTests, t) } <ins> func TestFilterPartialMatchesSometimesMissingAnnotations(t *testing.T) { // for https://issues.k8s.io/45546 var input = []byte(`{ \"kind\": \"List\", \"items\": [ { \"kind\": \"Pod\", \"metadata\": { \"name\": \"pod1\", \"annotations\": { \"color\": \"blue\" } } }, { \"kind\": \"Pod\", \"metadata\": { \"name\": \"pod2\" } }, { \"kind\": \"Pod\", \"metadata\": { \"name\": \"pod3\", \"annotations\": { \"color\": \"green\" } } }, { \"kind\": \"Pod\", \"metadata\": { \"name\": \"pod4\", \"annotations\": { \"color\": \"blue\" } } } ] }`) var data interface{} err := json.Unmarshal(input, &data) if err != nil { t.Fatal(err) } testJSONPath( []jsonpathTest{ { \"filter, should only match a subset, some items don't have annotations, tolerate missing items\", `{.items[?(@.metadata.annotations.color==\"blue\")].metadata.name}`, data, \"pod1 pod4\", false, // expect no error }, }, true, // allow missing keys t, ) testJSONPath( []jsonpathTest{ { \"filter, should only match a subset, some items don't have annotations, error on missing items\", `{.items[?(@.metadata.annotations.color==\"blue\")].metadata.name}`, data, \"\", true, // expect an error }, }, false, // don't allow missing keys t, ) } </ins>", "commid": "kubernetes_pr_47846"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-65caa9d64a4c73df5022d80330fa6a1add34a56f25ed4e6ffce49deea129d515", "query": "Kubernetes version (use ): Kubernetes HEAD Environment: Cloud provider or hardware configuration: linux OS (e.g. from /etc/os-release): Kernel (e.g. ):NAME=Fedora25 What happened: apiserver panic What you expected to happen: No panic How to reproduce it (as minimally and precisely as possible): Testcase is going to be sent as a PR\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-bfe1b19731f72a976b3e8efbc981b4dffc10e4f7577a683c0b684753b066a84a", "text": "\"integration\", ], deps = [ <ins> \"//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library\", </ins> \"//vendor/k8s.io/apimachinery/pkg/api/meta:go_default_library\", \"//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library\", \"//vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured:go_default_library\",", "commid": "kubernetes_pr_45768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-65caa9d64a4c73df5022d80330fa6a1add34a56f25ed4e6ffce49deea129d515", "query": "Kubernetes version (use ): Kubernetes HEAD Environment: Cloud provider or hardware configuration: linux OS (e.g. from /etc/os-release): Kernel (e.g. ):NAME=Fedora25 What happened: apiserver panic What you expected to happen: No panic How to reproduce it (as minimally and precisely as possible): Testcase is going to be sent as a PR\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-791b886fae8650e8dbfe2cec1193e625632765874cdfb30b967cee383d811749", "text": "\"testing\" \"time\" <ins> \"k8s.io/apimachinery/pkg/api/errors\" </ins> \"k8s.io/apimachinery/pkg/api/meta\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured\"", "commid": "kubernetes_pr_45768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-65caa9d64a4c73df5022d80330fa6a1add34a56f25ed4e6ffce49deea129d515", "query": "Kubernetes version (use ): Kubernetes HEAD Environment: Cloud provider or hardware configuration: linux OS (e.g. from /etc/os-release): Kernel (e.g. ):NAME=Fedora25 What happened: apiserver panic What you expected to happen: No panic How to reproduce it (as minimally and precisely as possible): Testcase is going to be sent as a PR\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-b5bca62adf07d8d0ae02e4c4a8e49b0c558da7e33be723500f26bb83e0060b90", "text": "if e, a := createdNoxuInstance, gottenNoxuInstance2; !reflect.DeepEqual(e, a) { t.Errorf(\"expected %v, got %v\", e, a) } <ins> } func TestDeRegistrationAndReRegistration(t *testing.T) { stopCh, apiExtensionClient, clientPool, err := testserver.StartDefaultServer() if err != nil { t.Fatal(err) } defer close(stopCh) noxuDefinition := testserver.NewNoxuCustomResourceDefinition() ns := \"not-the-default\" sameInstanceName := \"foo\" func() { noxuVersionClient, err := testserver.CreateNewCustomResourceDefinition(noxuDefinition, apiExtensionClient, clientPool) if err != nil { t.Fatal(err) } noxuNamespacedResourceClient := NewNamespacedCustomResourceClient(ns, noxuVersionClient, noxuDefinition) if _, err := instantiateCustomResource(t, testserver.NewNoxuInstance(ns, sameInstanceName), noxuNamespacedResourceClient, noxuDefinition); err != nil { t.Fatal(err) } // Remove sameInstanceName since at the moment there's no finalizers. // TODO: as soon finalizers will be implemented Delete can be removed. if err := noxuNamespacedResourceClient.Delete(sameInstanceName, nil); err != nil { t.Fatal(err) } if err := testserver.DeleteCustomResourceDefinition(noxuDefinition, apiExtensionClient); err != nil { t.Fatal(err) } if _, err := testserver.GetCustomResourceDefinition(noxuDefinition, apiExtensionClient); err == nil || !errors.IsNotFound(err) { t.Fatalf(\"expected a NotFound error, got:%v\", err) } if _, err = noxuNamespacedResourceClient.List(metav1.ListOptions{}); err == nil || !errors.IsNotFound(err) { t.Fatalf(\"expected a NotFound error, got:%v\", err) } if _, err = noxuNamespacedResourceClient.Get(\"foo\"); err == nil || !errors.IsNotFound(err) { t.Fatalf(\"expected a NotFound error, got:%v\", err) } }() func() { if _, err := testserver.GetCustomResourceDefinition(noxuDefinition, apiExtensionClient); err == nil || !errors.IsNotFound(err) { t.Fatalf(\"expected a NotFound error, got:%v\", err) } noxuVersionClient, err := testserver.CreateNewCustomResourceDefinition(noxuDefinition, apiExtensionClient, clientPool) if err != nil { t.Fatal(err) } noxuNamespacedResourceClient := NewNamespacedCustomResourceClient(ns, noxuVersionClient, noxuDefinition) initialList, err := noxuNamespacedResourceClient.List(metav1.ListOptions{}) if err != nil { t.Fatal(err) } if _, err = noxuNamespacedResourceClient.Get(sameInstanceName); err == nil || !errors.IsNotFound(err) { t.Fatalf(\"expected a NotFound error, got:%v\", err) } if e, a := 0, len(initialList.(*unstructured.UnstructuredList).Items); e != a { t.Fatalf(\"expected %v, got %v\", e, a) } createdNoxuInstance, err := instantiateCustomResource(t, testserver.NewNoxuInstance(ns, sameInstanceName), noxuNamespacedResourceClient, noxuDefinition) if err != nil { t.Fatal(err) } gottenNoxuInstance, err := noxuNamespacedResourceClient.Get(sameInstanceName) if err != nil { t.Fatal(err) } if e, a := createdNoxuInstance, gottenNoxuInstance; !reflect.DeepEqual(e, a) { t.Fatalf(\"expected %v, got %v\", e, a) } listWithItem, err := noxuNamespacedResourceClient.List(metav1.ListOptions{}) if err != nil { t.Fatal(err) } if e, a := 1, len(listWithItem.(*unstructured.UnstructuredList).Items); e != a { t.Fatalf(\"expected %v, got %v\", e, a) } if e, a := *createdNoxuInstance, listWithItem.(*unstructured.UnstructuredList).Items[0]; !reflect.DeepEqual(e, a) { t.Fatalf(\"expected %v, got %v\", e, a) } if err := noxuNamespacedResourceClient.Delete(sameInstanceName, nil); err != nil { t.Fatal(err) } if _, err = noxuNamespacedResourceClient.Get(sameInstanceName); err == nil || !errors.IsNotFound(err) { t.Fatalf(\"expected a NotFound error, got:%v\", err) } listWithoutItem, err := noxuNamespacedResourceClient.List(metav1.ListOptions{}) if err != nil { t.Fatal(err) } if e, a := 0, len(listWithoutItem.(*unstructured.UnstructuredList).Items); e != a { t.Fatalf(\"expected %v, got %v\", e, a) } }() </ins> }", "commid": "kubernetes_pr_45768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-65caa9d64a4c73df5022d80330fa6a1add34a56f25ed4e6ffce49deea129d515", "query": "Kubernetes version (use ): Kubernetes HEAD Environment: Cloud provider or hardware configuration: linux OS (e.g. from /etc/os-release): Kernel (e.g. ):NAME=Fedora25 What happened: apiserver panic What you expected to happen: No panic How to reproduce it (as minimally and precisely as possible): Testcase is going to be sent as a PR\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-aba02a0cd96568479804b673efd782382f478625d90ba7b358b5140362f4db29", "text": "tags = [\"automanaged\"], deps = [ \"//vendor/github.com/pborman/uuid:go_default_library\", <ins> \"//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library\", </ins> \"//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library\", \"//vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured:go_default_library\", \"//vendor/k8s.io/apimachinery/pkg/runtime/schema:go_default_library\",", "commid": "kubernetes_pr_45768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-65caa9d64a4c73df5022d80330fa6a1add34a56f25ed4e6ffce49deea129d515", "query": "Kubernetes version (use ): Kubernetes HEAD Environment: Cloud provider or hardware configuration: linux OS (e.g. from /etc/os-release): Kernel (e.g. ):NAME=Fedora25 What happened: apiserver panic What you expected to happen: No panic How to reproduce it (as minimally and precisely as possible): Testcase is going to be sent as a PR\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-4b9cf6a935f4b15793f73f9eb20bb3f3fee208ccacad280d58b4e1e967c2d674", "text": "import ( \"time\" <ins> \"k8s.io/apimachinery/pkg/api/errors\" </ins> metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured\" \"k8s.io/apimachinery/pkg/runtime/schema\"", "commid": "kubernetes_pr_45768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-65caa9d64a4c73df5022d80330fa6a1add34a56f25ed4e6ffce49deea129d515", "query": "Kubernetes version (use ): Kubernetes HEAD Environment: Cloud provider or hardware configuration: linux OS (e.g. from /etc/os-release): Kernel (e.g. ):NAME=Fedora25 What happened: apiserver panic What you expected to happen: No panic How to reproduce it (as minimally and precisely as possible): Testcase is going to be sent as a PR\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-22b1db6a2ccd28c172fe1a70b2068a865acfe3cd18ff76a312db9b7e6ea22c31", "text": "} return dynamicClient, nil } <ins> func DeleteCustomResourceDefinition(customResource *apiextensionsv1alpha1.CustomResourceDefinition, apiExtensionsClient clientset.Interface) error { if err := apiExtensionsClient.Apiextensions().CustomResourceDefinitions().Delete(customResource.Name, nil); err != nil { return err } err := wait.PollImmediate(30*time.Millisecond, 30*time.Second, func() (bool, error) { if _, err := apiExtensionsClient.Discovery().ServerResourcesForGroupVersion(customResource.Spec.Group + \"/\" + customResource.Spec.Version); err != nil { if errors.IsNotFound(err) { return true, nil } return false, err } return false, nil }) return err } func GetCustomResourceDefinition(customResource *apiextensionsv1alpha1.CustomResourceDefinition, apiExtensionsClient clientset.Interface) (*apiextensionsv1alpha1.CustomResourceDefinition, error) { return apiExtensionsClient.Apiextensions().CustomResourceDefinitions().Get(customResource.Name, metav1.GetOptions{}) } </ins>", "commid": "kubernetes_pr_45768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aa75d975d992a909f430b0bed93e3d2043e7547cce9241b8dcea96441c405e96", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? NO Note: Please file issues for subcomponents under the appropriate repo What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): kubernetes, azure file, chinacloudapi Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): master Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): Install tools: Others: What happened: We try to mount azure file to pod, and get the following error That is because azure china's storage DNS suffix is rather than What you expected to happen: Kubernetes should provide some method to let user specify storage dns suffix, so we can use Azure file volume How to reproduce it (as minimally and precisely as possible): Any Azure cluster in china can reproduce it. Anything else we need to know: kubernetes has hard coded in shows a relative issue\ncould you help confirm this?\nOne possible way is configuring DNS suffix via annotations of PV. If thinks this way okay, I'd like to create a PR to fix it.\nazure file was implemented without using resource group or azure cloud provider. The endpoint can be found at One fix is to use azure cloud provider and choose the file service endpoint from azure environment as I did in blob service . Let me know if you can help.\nI'm not familiar with azure cloud provider and volume codes. I'd like to try to dig into it to see if I can fix as the way you suggested.", "positive_passages": [{"docid": "doc-en-kubernetes-13d43e0b9429d374a1ecee7548696e08ff7dbef21af74952a25c54e14d90fbd8", "text": "library = \":go_default_library\", tags = [\"automanaged\"], deps = [ <ins> \"//pkg/cloudprovider/providers/azure:go_default_library\", \"//pkg/cloudprovider/providers/fake:go_default_library\", </ins> \"//pkg/util/mount:go_default_library\", \"//pkg/volume:go_default_library\", \"//pkg/volume/testing:go_default_library\",", "commid": "kubernetes_pr_48460"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aa75d975d992a909f430b0bed93e3d2043e7547cce9241b8dcea96441c405e96", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? NO Note: Please file issues for subcomponents under the appropriate repo What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): kubernetes, azure file, chinacloudapi Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): master Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): Install tools: Others: What happened: We try to mount azure file to pod, and get the following error That is because azure china's storage DNS suffix is rather than What you expected to happen: Kubernetes should provide some method to let user specify storage dns suffix, so we can use Azure file volume How to reproduce it (as minimally and precisely as possible): Any Azure cluster in china can reproduce it. Anything else we need to know: kubernetes has hard coded in shows a relative issue\ncould you help confirm this?\nOne possible way is configuring DNS suffix via annotations of PV. If thinks this way okay, I'd like to create a PR to fix it.\nazure file was implemented without using resource group or azure cloud provider. The endpoint can be found at One fix is to use azure cloud provider and choose the file service endpoint from azure environment as I did in blob service . Let me know if you can help.\nI'm not familiar with azure cloud provider and volume codes. I'd like to try to dig into it to see if I can fix as the way you suggested.", "positive_passages": [{"docid": "doc-en-kubernetes-84050a42b0d800bed44d88bc9fafce6bc54434924330b08b98af6bd39d352919", "text": "\"k8s.io/kubernetes/pkg/volume\" \"github.com/golang/glog\" <ins> \"k8s.io/kubernetes/pkg/cloudprovider\" \"k8s.io/kubernetes/pkg/cloudprovider/providers/azure\" </ins> \"k8s.io/kubernetes/pkg/volume/util\" ) <del> // This is the primary entrypoint for volume plugins. </del> <ins> // ProbeVolumePlugins is the primary endpoint for volume plugins </ins> func ProbeVolumePlugins() []volume.VolumePlugin { return []volume.VolumePlugin{&azureFilePlugin{nil}} }", "commid": "kubernetes_pr_48460"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aa75d975d992a909f430b0bed93e3d2043e7547cce9241b8dcea96441c405e96", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? NO Note: Please file issues for subcomponents under the appropriate repo What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): kubernetes, azure file, chinacloudapi Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): master Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): Install tools: Others: What happened: We try to mount azure file to pod, and get the following error That is because azure china's storage DNS suffix is rather than What you expected to happen: Kubernetes should provide some method to let user specify storage dns suffix, so we can use Azure file volume How to reproduce it (as minimally and precisely as possible): Any Azure cluster in china can reproduce it. Anything else we need to know: kubernetes has hard coded in shows a relative issue\ncould you help confirm this?\nOne possible way is configuring DNS suffix via annotations of PV. If thinks this way okay, I'd like to create a PR to fix it.\nazure file was implemented without using resource group or azure cloud provider. The endpoint can be found at One fix is to use azure cloud provider and choose the file service endpoint from azure environment as I did in blob service . Let me know if you can help.\nI'm not familiar with azure cloud provider and volume codes. I'd like to try to dig into it to see if I can fix as the way you suggested.", "positive_passages": [{"docid": "doc-en-kubernetes-07475e01541eb8fd1f84b96503756581ea4480adca9e8b3be4161c20fe5c8f04", "text": "if accountName, accountKey, err = b.util.GetAzureCredentials(b.plugin.host, b.pod.Namespace, b.secretName); err != nil { return err } <del> os.MkdirAll(dir, 0750) source := fmt.Sprintf(\"//%s.file.core.windows.net/%s\", accountName, b.shareName) </del> <ins> os.MkdirAll(dir, 0700) source := fmt.Sprintf(\"//%s.file.%s/%s\", accountName, getStorageEndpointSuffix(b.plugin.host.GetCloudProvider()), b.shareName) </ins> // parameters suggested by https://azure.microsoft.com/en-us/documentation/articles/storage-how-to-use-files-linux/ <del> options := []string{fmt.Sprintf(\"vers=3.0,username=%s,password=%s,dir_mode=0777,file_mode=0777\", accountName, accountKey)} </del> <ins> options := []string{fmt.Sprintf(\"vers=3.0,username=%s,password=%s,dir_mode=0700,file_mode=0700\", accountName, accountKey)} </ins> if b.readOnly { options = append(options, \"ro\") }", "commid": "kubernetes_pr_48460"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aa75d975d992a909f430b0bed93e3d2043e7547cce9241b8dcea96441c405e96", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? NO Note: Please file issues for subcomponents under the appropriate repo What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): kubernetes, azure file, chinacloudapi Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): master Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): Install tools: Others: What happened: We try to mount azure file to pod, and get the following error That is because azure china's storage DNS suffix is rather than What you expected to happen: Kubernetes should provide some method to let user specify storage dns suffix, so we can use Azure file volume How to reproduce it (as minimally and precisely as possible): Any Azure cluster in china can reproduce it. Anything else we need to know: kubernetes has hard coded in shows a relative issue\ncould you help confirm this?\nOne possible way is configuring DNS suffix via annotations of PV. If thinks this way okay, I'd like to create a PR to fix it.\nazure file was implemented without using resource group or azure cloud provider. The endpoint can be found at One fix is to use azure cloud provider and choose the file service endpoint from azure environment as I did in blob service . Let me know if you can help.\nI'm not familiar with azure cloud provider and volume codes. I'd like to try to dig into it to see if I can fix as the way you suggested.", "positive_passages": [{"docid": "doc-en-kubernetes-07b47a8b0a758f74bd00ba0161082ff1015deebf2c5002b203975a65eb605e65", "text": "return nil, false, fmt.Errorf(\"Spec does not reference an AzureFile volume type\") } <ins> func getAzureCloud(cloudProvider cloudprovider.Interface) (*azure.Cloud, error) { azure, ok := cloudProvider.(*azure.Cloud) if !ok || azure == nil { return nil, fmt.Errorf(\"Failed to get Azure Cloud Provider. GetCloudProvider returned %v instead\", cloudProvider) } return azure, nil } func getStorageEndpointSuffix(cloudprovider cloudprovider.Interface) string { const publicCloudStorageEndpointSuffix = \"core.windows.net\" azure, err := getAzureCloud(cloudprovider) if err != nil { glog.Warningf(\"No Azure cloud provider found. Using the Azure public cloud endpoint: %s\", publicCloudStorageEndpointSuffix) return publicCloudStorageEndpointSuffix } return azure.Environment.StorageEndpointSuffix } </ins>", "commid": "kubernetes_pr_48460"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aa75d975d992a909f430b0bed93e3d2043e7547cce9241b8dcea96441c405e96", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? NO Note: Please file issues for subcomponents under the appropriate repo What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): kubernetes, azure file, chinacloudapi Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): master Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): Install tools: Others: What happened: We try to mount azure file to pod, and get the following error That is because azure china's storage DNS suffix is rather than What you expected to happen: Kubernetes should provide some method to let user specify storage dns suffix, so we can use Azure file volume How to reproduce it (as minimally and precisely as possible): Any Azure cluster in china can reproduce it. Anything else we need to know: kubernetes has hard coded in shows a relative issue\ncould you help confirm this?\nOne possible way is configuring DNS suffix via annotations of PV. If thinks this way okay, I'd like to create a PR to fix it.\nazure file was implemented without using resource group or azure cloud provider. The endpoint can be found at One fix is to use azure cloud provider and choose the file service endpoint from azure environment as I did in blob service . Let me know if you can help.\nI'm not familiar with azure cloud provider and volume codes. I'd like to try to dig into it to see if I can fix as the way you suggested.", "positive_passages": [{"docid": "doc-en-kubernetes-b92ecebd906b685d20ba057d5a97c177b054766b6fe824d82851d03e29691d70", "text": "\"io/ioutil\" \"os\" \"path\" <ins> \"strings\" </ins> \"testing\" \"k8s.io/api/core/v1\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/types\" \"k8s.io/client-go/kubernetes/fake\" <ins> \"k8s.io/kubernetes/pkg/cloudprovider/providers/azure\" fakecloud \"k8s.io/kubernetes/pkg/cloudprovider/providers/fake\" </ins> \"k8s.io/kubernetes/pkg/util/mount\" \"k8s.io/kubernetes/pkg/volume\" volumetest \"k8s.io/kubernetes/pkg/volume/testing\"", "commid": "kubernetes_pr_48460"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aa75d975d992a909f430b0bed93e3d2043e7547cce9241b8dcea96441c405e96", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? NO Note: Please file issues for subcomponents under the appropriate repo What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): kubernetes, azure file, chinacloudapi Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): master Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): Install tools: Others: What happened: We try to mount azure file to pod, and get the following error That is because azure china's storage DNS suffix is rather than What you expected to happen: Kubernetes should provide some method to let user specify storage dns suffix, so we can use Azure file volume How to reproduce it (as minimally and precisely as possible): Any Azure cluster in china can reproduce it. Anything else we need to know: kubernetes has hard coded in shows a relative issue\ncould you help confirm this?\nOne possible way is configuring DNS suffix via annotations of PV. If thinks this way okay, I'd like to create a PR to fix it.\nazure file was implemented without using resource group or azure cloud provider. The endpoint can be found at One fix is to use azure cloud provider and choose the file service endpoint from azure environment as I did in blob service . Let me know if you can help.\nI'm not familiar with azure cloud provider and volume codes. I'd like to try to dig into it to see if I can fix as the way you suggested.", "positive_passages": [{"docid": "doc-en-kubernetes-d115fa853b6a3446076c80169fa92d2147abcc1396fe005459d188d84cb3d468", "text": "return false } <del> func TestPlugin(t *testing.T) { </del> <ins> func getAzureTestCloud(t *testing.T) *azure.Cloud { config := `{ \"aadClientId\": \"--aad-client-id--\", \"aadClientSecret\": \"--aad-client-secret--\" }` configReader := strings.NewReader(config) cloud, err := azure.NewCloud(configReader) if err != nil { t.Error(err) } azureCloud, ok := cloud.(*azure.Cloud) if !ok { t.Error(\"NewCloud returned incorrect type\") } return azureCloud } func getTestTempDir(t *testing.T) string { </ins> tmpDir, err := ioutil.TempDir(os.TempDir(), \"azurefileTest\") if err != nil { t.Fatalf(\"can't make a temp dir: %v\", err) } <ins> return tmpDir } func TestPluginAzureCloudProvider(t *testing.T) { tmpDir := getTestTempDir(t) defer os.RemoveAll(tmpDir) testPlugin(t, tmpDir, volumetest.NewFakeVolumeHostWithCloudProvider(tmpDir, nil, nil, getAzureTestCloud(t))) } func TestPluginWithoutCloudProvider(t *testing.T) { tmpDir := getTestTempDir(t) defer os.RemoveAll(tmpDir) testPlugin(t, tmpDir, volumetest.NewFakeVolumeHost(tmpDir, nil, nil)) } func TestPluginWithOtherCloudProvider(t *testing.T) { tmpDir := getTestTempDir(t) </ins> defer os.RemoveAll(tmpDir) <ins> cloud := &fakecloud.FakeCloud{} testPlugin(t, tmpDir, volumetest.NewFakeVolumeHostWithCloudProvider(tmpDir, nil, nil, cloud)) } func testPlugin(t *testing.T, tmpDir string, volumeHost volume.VolumeHost) { </ins> plugMgr := volume.VolumePluginMgr{} <del> plugMgr.InitPlugins(ProbeVolumePlugins(), volumetest.NewFakeVolumeHost(tmpDir, nil, nil)) </del> <ins> plugMgr.InitPlugins(ProbeVolumePlugins(), volumeHost) </ins> plug, err := plugMgr.FindPluginByName(\"kubernetes.io/azure-file\") if err != nil {", "commid": "kubernetes_pr_48460"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aa75d975d992a909f430b0bed93e3d2043e7547cce9241b8dcea96441c405e96", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? NO Note: Please file issues for subcomponents under the appropriate repo What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): kubernetes, azure file, chinacloudapi Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): master Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): Install tools: Others: What happened: We try to mount azure file to pod, and get the following error That is because azure china's storage DNS suffix is rather than What you expected to happen: Kubernetes should provide some method to let user specify storage dns suffix, so we can use Azure file volume How to reproduce it (as minimally and precisely as possible): Any Azure cluster in china can reproduce it. Anything else we need to know: kubernetes has hard coded in shows a relative issue\ncould you help confirm this?\nOne possible way is configuring DNS suffix via annotations of PV. If thinks this way okay, I'd like to create a PR to fix it.\nazure file was implemented without using resource group or azure cloud provider. The endpoint can be found at One fix is to use azure cloud provider and choose the file service endpoint from azure environment as I did in blob service . Let me know if you can help.\nI'm not familiar with azure cloud provider and volume codes. I'd like to try to dig into it to see if I can fix as the way you suggested.", "positive_passages": [{"docid": "doc-en-kubernetes-839719faf7240f60727f8b56965ca53afdb0c7d07adfb16e97c13731a4be27b7", "text": "} func NewFakeVolumeHost(rootDir string, kubeClient clientset.Interface, plugins []VolumePlugin) *fakeVolumeHost { <del> host := &fakeVolumeHost{rootDir: rootDir, kubeClient: kubeClient, cloud: nil} </del> <ins> return newFakeVolumeHost(rootDir, kubeClient, plugins, nil) } func NewFakeVolumeHostWithCloudProvider(rootDir string, kubeClient clientset.Interface, plugins []VolumePlugin, cloud cloudprovider.Interface) *fakeVolumeHost { return newFakeVolumeHost(rootDir, kubeClient, plugins, cloud) } func newFakeVolumeHost(rootDir string, kubeClient clientset.Interface, plugins []VolumePlugin, cloud cloudprovider.Interface) *fakeVolumeHost { host := &fakeVolumeHost{rootDir: rootDir, kubeClient: kubeClient, cloud: cloud} </ins> host.mounter = &mount.FakeMounter{} host.writer = &io.StdWriter{} host.pluginMgr.InitPlugins(plugins, host)", "commid": "kubernetes_pr_48460"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f28a055e094ad8cab6090a9353bf9b81626590240635476010468b49904b9bc1", "query": "Is this a BUG REPORT or FEATURE REQUEST? BUG REPORT Kubernetes version (use ): kubernetes/master using CRI with docker What happened: Create a pod that uses a readiness probe that does an exec to command that doesnt exist See the following in logs: What you expected to happen: No error in log, expected the event to properly be thrown. How to reproduce it (as minimally and precisely as possible): See above. Anything else we need to know: Nope.\nthis is a regression.\ndebugging, will post a fix once found.\nOther reports: ,\n-- thanks for the other reports. at least now we have a reliable reproduction.\nThe problem appears to be the following: has a that correlates containers to a . It uses the type . event recorder library we use in the prober works with . If it doesn't get one of those, it expects the passed in object to implement List. As a result, we are passing a v1.ObjectReference the recorder was not expecting.\nThe bug may have been introduced in , which was there since v1.6.0.\nOpened for a fix.\nKeep this open until 1.6 is patched.\n/remove-priority P0 /priority critical-urgent (I'm not actually sure this is the right priority, just trying to remove the old priority/PN labels)\nClosing since has been merged.", "positive_passages": [{"docid": "doc-en-kubernetes-9006ad8a1ef4066b91045f0f74c3c93e7d6b06df33a12c442b1043b7deaf0565", "text": "} // SetRef stores a reference to a pod's container, associating it with the given container ID. <ins> // TODO: move this to client-go v1.ObjectReference </ins> func (c *RefManager) SetRef(id ContainerID, ref *v1.ObjectReference) { c.Lock() defer c.Unlock()", "commid": "kubernetes_pr_46246"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f28a055e094ad8cab6090a9353bf9b81626590240635476010468b49904b9bc1", "query": "Is this a BUG REPORT or FEATURE REQUEST? BUG REPORT Kubernetes version (use ): kubernetes/master using CRI with docker What happened: Create a pod that uses a readiness probe that does an exec to command that doesnt exist See the following in logs: What you expected to happen: No error in log, expected the event to properly be thrown. How to reproduce it (as minimally and precisely as possible): See above. Anything else we need to know: Nope.\nthis is a regression.\ndebugging, will post a fix once found.\nOther reports: ,\n-- thanks for the other reports. at least now we have a reliable reproduction.\nThe problem appears to be the following: has a that correlates containers to a . It uses the type . event recorder library we use in the prober works with . If it doesn't get one of those, it expects the passed in object to implement List. As a result, we are passing a v1.ObjectReference the recorder was not expecting.\nThe bug may have been introduced in , which was there since v1.6.0.\nOpened for a fix.\nKeep this open until 1.6 is patched.\n/remove-priority P0 /priority critical-urgent (I'm not actually sure this is the right priority, just trying to remove the old priority/PN labels)\nClosing since has been merged.", "positive_passages": [{"docid": "doc-en-kubernetes-8d8c32bf201464bd35fc1b84398f2283e87ea9bb2b98cc33651f8a3e1c5938a0", "text": "} // GetRef returns the container reference of the given ID, or (nil, false) if none is stored. <ins> // TODO: move this to client-go v1.ObjectReference </ins> func (c *RefManager) GetRef(id ContainerID) (ref *v1.ObjectReference, ok bool) { c.RLock() defer c.RUnlock()", "commid": "kubernetes_pr_46246"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f28a055e094ad8cab6090a9353bf9b81626590240635476010468b49904b9bc1", "query": "Is this a BUG REPORT or FEATURE REQUEST? BUG REPORT Kubernetes version (use ): kubernetes/master using CRI with docker What happened: Create a pod that uses a readiness probe that does an exec to command that doesnt exist See the following in logs: What you expected to happen: No error in log, expected the event to properly be thrown. How to reproduce it (as minimally and precisely as possible): See above. Anything else we need to know: Nope.\nthis is a regression.\ndebugging, will post a fix once found.\nOther reports: ,\n-- thanks for the other reports. at least now we have a reliable reproduction.\nThe problem appears to be the following: has a that correlates containers to a . It uses the type . event recorder library we use in the prober works with . If it doesn't get one of those, it expects the passed in object to implement List. As a result, we are passing a v1.ObjectReference the recorder was not expecting.\nThe bug may have been introduced in , which was there since v1.6.0.\nOpened for a fix.\nKeep this open until 1.6 is patched.\n/remove-priority P0 /priority critical-urgent (I'm not actually sure this is the right priority, just trying to remove the old priority/PN labels)\nClosing since has been merged.", "positive_passages": [{"docid": "doc-en-kubernetes-5156073453ff201965d0fade08d39b3c032a58211f3ed42dbfab323186f6959d", "text": "glog.Warningf(\"No ref for container %q\", containerID) return } <del> m.recorder.Event(ref, eventType, reason, message) </del> <ins> m.recorder.Event(events.ToObjectReference(ref), eventType, reason, message) </ins> } // executePreStopHook runs the pre-stop lifecycle hooks if applicable and returns the duration it takes.", "commid": "kubernetes_pr_46246"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f28a055e094ad8cab6090a9353bf9b81626590240635476010468b49904b9bc1", "query": "Is this a BUG REPORT or FEATURE REQUEST? BUG REPORT Kubernetes version (use ): kubernetes/master using CRI with docker What happened: Create a pod that uses a readiness probe that does an exec to command that doesnt exist See the following in logs: What you expected to happen: No error in log, expected the event to properly be thrown. How to reproduce it (as minimally and precisely as possible): See above. Anything else we need to know: Nope.\nthis is a regression.\ndebugging, will post a fix once found.\nOther reports: ,\n-- thanks for the other reports. at least now we have a reliable reproduction.\nThe problem appears to be the following: has a that correlates containers to a . It uses the type . event recorder library we use in the prober works with . If it doesn't get one of those, it expects the passed in object to implement List. As a result, we are passing a v1.ObjectReference the recorder was not expecting.\nThe bug may have been introduced in , which was there since v1.6.0.\nOpened for a fix.\nKeep this open until 1.6 is patched.\n/remove-priority P0 /priority critical-urgent (I'm not actually sure this is the right priority, just trying to remove the old priority/PN labels)\nClosing since has been merged.", "positive_passages": [{"docid": "doc-en-kubernetes-0ecedff605dd11b36796cae4ae85ebdb5de3bf532adb761596b0ee74871ca1f5", "text": "if err != nil { glog.V(1).Infof(\"%s probe for %q errored: %v\", probeType, ctrName, err) if hasRef { <del> pb.recorder.Eventf(ref, v1.EventTypeWarning, events.ContainerUnhealthy, \"%s probe errored: %v\", probeType, err) </del> <ins> pb.recorder.Eventf(events.ToObjectReference(ref), v1.EventTypeWarning, events.ContainerUnhealthy, \"%s probe errored: %v\", probeType, err) </ins> } } else { // result != probe.Success glog.V(1).Infof(\"%s probe for %q failed (%v): %s\", probeType, ctrName, result, output) if hasRef { <del> pb.recorder.Eventf(ref, v1.EventTypeWarning, events.ContainerUnhealthy, \"%s probe failed: %s\", probeType, output) </del> <ins> pb.recorder.Eventf(events.ToObjectReference(ref), v1.EventTypeWarning, events.ContainerUnhealthy, \"%s probe failed: %s\", probeType, output) </ins> } } return results.Failure, err", "commid": "kubernetes_pr_46246"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f28a055e094ad8cab6090a9353bf9b81626590240635476010468b49904b9bc1", "query": "Is this a BUG REPORT or FEATURE REQUEST? BUG REPORT Kubernetes version (use ): kubernetes/master using CRI with docker What happened: Create a pod that uses a readiness probe that does an exec to command that doesnt exist See the following in logs: What you expected to happen: No error in log, expected the event to properly be thrown. How to reproduce it (as minimally and precisely as possible): See above. Anything else we need to know: Nope.\nthis is a regression.\ndebugging, will post a fix once found.\nOther reports: ,\n-- thanks for the other reports. at least now we have a reliable reproduction.\nThe problem appears to be the following: has a that correlates containers to a . It uses the type . event recorder library we use in the prober works with . If it doesn't get one of those, it expects the passed in object to implement List. As a result, we are passing a v1.ObjectReference the recorder was not expecting.\nThe bug may have been introduced in , which was there since v1.6.0.\nOpened for a fix.\nKeep this open until 1.6 is patched.\n/remove-priority P0 /priority critical-urgent (I'm not actually sure this is the right priority, just trying to remove the old priority/PN labels)\nClosing since has been merged.", "positive_passages": [{"docid": "doc-en-kubernetes-6a07357654c1ea58647a5cecc619b4ea3fd0107d714faeaf8a5ee93cb72d639e", "text": "uuid := utilstrings.ShortenString(id.uuid, 8) switch reason { case \"Created\": <del> r.recorder.Eventf(ref, v1.EventTypeNormal, events.CreatedContainer, \"Created with rkt id %v\", uuid) </del> <ins> r.recorder.Eventf(events.ToObjectReference(ref), v1.EventTypeNormal, events.CreatedContainer, \"Created with rkt id %v\", uuid) </ins> case \"Started\": <del> r.recorder.Eventf(ref, v1.EventTypeNormal, events.StartedContainer, \"Started with rkt id %v\", uuid) </del> <ins> r.recorder.Eventf(events.ToObjectReference(ref), v1.EventTypeNormal, events.StartedContainer, \"Started with rkt id %v\", uuid) </ins> case \"Failed\": <del> r.recorder.Eventf(ref, v1.EventTypeWarning, events.FailedToStartContainer, \"Failed to start with rkt id %v with error %v\", uuid, failure) </del> <ins> r.recorder.Eventf(events.ToObjectReference(ref), v1.EventTypeWarning, events.FailedToStartContainer, \"Failed to start with rkt id %v with error %v\", uuid, failure) </ins> case \"Killing\": <del> r.recorder.Eventf(ref, v1.EventTypeNormal, events.KillingContainer, \"Killing with rkt id %v\", uuid) </del> <ins> r.recorder.Eventf(events.ToObjectReference(ref), v1.EventTypeNormal, events.KillingContainer, \"Killing with rkt id %v\", uuid) </ins> default: glog.Errorf(\"rkt: Unexpected event %q\", reason) }", "commid": "kubernetes_pr_46246"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31ac89f43517e9b52bae95bbf6a3f87a02afdf8494c951688a4cda2fbf3b7019", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): selflink kubelet selflink default selflink manifest selflink Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT Kubernetes version (use ): admin kubectl version Client Version: version.Info{Major:\"1\", Minor:\"5\", GitVersion:\"v1.5.7\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-04-27T10:00:30Z\", GoVersion:\"go1.7.5\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"5\", GitVersion:\"v1.5.7\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-04-27T09:42:05Z\", GoVersion:\"go1.7.5\", Compiler:\"gc\", Platform:\"linux/amd64\"} Environment: Cloud provider or hardware configuration: AWS OS: Debian GNU/Linux 8 (jessie) Kernel: Linux ip-10-150-109-115 4.4.41-k8s SMP Mon Jan 9 15:34:39 UTC 2017 x86_64 GNU/Linux Install tools: kops 1.5.3 Others: What happened: When running the selfLink for pods started from manifests were incorrect. Example: What you expected to happen: To receive a correct selfLink: Example: How to reproduce it (as minimally and precisely as possible): I believe simply using a pod manifest to start a pod will cause this issue as kubelet seems to rely on defaults when starting pods from manifests. Anything else we need to know: I believe the below linked line needs to be corrected:\n/assign I reproduced it. Will fix. Thanks for reporting!\nGitHub didn't allow me to assign the following users: xiangpengzhao. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. I understand the commands that are listed . </details", "positive_passages": [{"docid": "doc-en-kubernetes-0e3f104991f633a9fda07684064de39e8d05d3174df8fd2e6967032326bd9303", "text": "if len(namespace) == 0 { namespace = metav1.NamespaceDefault } <del> selfLink = fmt.Sprintf(\"/api/\"+api.Registry.GroupOrDie(api.GroupName).GroupVersion.Version+\"/pods/namespaces/%s/%s\", name, namespace) </del> <ins> selfLink = fmt.Sprintf(\"/api/\"+api.Registry.GroupOrDie(api.GroupName).GroupVersion.Version+\"/namespaces/%s/pods/%s\", namespace, name) </ins> return selfLink }", "commid": "kubernetes_pr_46396"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31ac89f43517e9b52bae95bbf6a3f87a02afdf8494c951688a4cda2fbf3b7019", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): selflink kubelet selflink default selflink manifest selflink Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT Kubernetes version (use ): admin kubectl version Client Version: version.Info{Major:\"1\", Minor:\"5\", GitVersion:\"v1.5.7\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-04-27T10:00:30Z\", GoVersion:\"go1.7.5\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"5\", GitVersion:\"v1.5.7\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-04-27T09:42:05Z\", GoVersion:\"go1.7.5\", Compiler:\"gc\", Platform:\"linux/amd64\"} Environment: Cloud provider or hardware configuration: AWS OS: Debian GNU/Linux 8 (jessie) Kernel: Linux ip-10-150-109-115 4.4.41-k8s SMP Mon Jan 9 15:34:39 UTC 2017 x86_64 GNU/Linux Install tools: kops 1.5.3 Others: What happened: When running the selfLink for pods started from manifests were incorrect. Example: What you expected to happen: To receive a correct selfLink: Example: How to reproduce it (as minimally and precisely as possible): I believe simply using a pod manifest to start a pod will cause this issue as kubelet seems to rely on defaults when starting pods from manifests. Anything else we need to know: I believe the below linked line needs to be corrected:\n/assign I reproduced it. Will fix. Thanks for reporting!\nGitHub didn't allow me to assign the following users: xiangpengzhao. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. I understand the commands that are listed . </details", "positive_passages": [{"docid": "doc-en-kubernetes-acd8a1d668b355f64914113fac6806075f1045e1331905dadd9b40c90e814486", "text": "} } } <ins> func TestGetSelfLink(t *testing.T) { var testCases = []struct { desc             string name             string namespace        string expectedSelfLink string }{ { desc:             \"No namespace specified\", name:             \"foo\", namespace:        \"\", expectedSelfLink: \"/api/v1/namespaces/default/pods/foo\", }, { desc:             \"Namespace specified\", name:             \"foo\", namespace:        \"bar\", expectedSelfLink: \"/api/v1/namespaces/bar/pods/foo\", }, } for _, testCase := range testCases { selfLink := getSelfLink(testCase.name, testCase.namespace) if testCase.expectedSelfLink != selfLink { t.Errorf(\"%s: getSelfLink error, expected: %s, got: %s\", testCase.desc, testCase.expectedSelfLink, selfLink) } } } </ins>", "commid": "kubernetes_pr_46396"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-735b73e1445875f0744f7d639f99b01e93a38ecea4de40b47921bcb778960a82", "query": "When a node is deleting a pod, the NodeRestriction admission plugin ensures the pod is bound to the node. It first checks the server cache for the pod. In the case where a pod was created and immediately deleted, it may not yet exist in the server cache. Before forbidding, we should do a live lookup. https://k8s- cc", "positive_passages": [{"docid": "doc-en-kubernetes-c7840a21fb40ecf57f57663c7c74607f80f814573f8a842de0f03083ed3212a3", "text": "\"//pkg/client/clientset_generated/internalclientset:go_default_library\", \"//pkg/client/clientset_generated/internalclientset/typed/core/internalversion:go_default_library\", \"//pkg/kubeapiserver/admission:go_default_library\", <ins> \"//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library\", </ins> \"//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library\", \"//vendor/k8s.io/apiserver/pkg/admission:go_default_library\", ],", "commid": "kubernetes_pr_46972"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-735b73e1445875f0744f7d639f99b01e93a38ecea4de40b47921bcb778960a82", "query": "When a node is deleting a pod, the NodeRestriction admission plugin ensures the pod is bound to the node. It first checks the server cache for the pod. In the case where a pod was created and immediately deleted, it may not yet exist in the server cache. Before forbidding, we should do a live lookup. https://k8s- cc", "positive_passages": [{"docid": "doc-en-kubernetes-bc108532072832232937c90ce0bb40e3e66dd8a671f3dbdb86af202e9d555e29", "text": "\"fmt\" \"io\" <ins> \"k8s.io/apimachinery/pkg/api/errors\" </ins> \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apiserver/pkg/admission\" \"k8s.io/kubernetes/pkg/api\"", "commid": "kubernetes_pr_46972"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-735b73e1445875f0744f7d639f99b01e93a38ecea4de40b47921bcb778960a82", "query": "When a node is deleting a pod, the NodeRestriction admission plugin ensures the pod is bound to the node. It first checks the server cache for the pod. In the case where a pod was created and immediately deleted, it may not yet exist in the server cache. Before forbidding, we should do a live lookup. https://k8s- cc", "positive_passages": [{"docid": "doc-en-kubernetes-229b931a7c397926a3a20fbcd96879580026f2581b80ebeaa83c25a6df324db6", "text": "return nil case admission.Delete: <del> // get the existing pod </del> <ins> // get the existing pod from the server cache </ins> existingPod, err := c.podsGetter.Pods(a.GetNamespace()).Get(a.GetName(), v1.GetOptions{ResourceVersion: \"0\"}) <ins> if errors.IsNotFound(err) { // wasn't found in the server cache, do a live lookup before forbidding existingPod, err = c.podsGetter.Pods(a.GetNamespace()).Get(a.GetName(), v1.GetOptions{}) } </ins> if err != nil { return admission.NewForbidden(a, err) }", "commid": "kubernetes_pr_46972"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d96d95df77a44fb7254651819de7a7da7fdea83bed17fd40f1db55b495f9afe8", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see ): Note: Please file issues for subcomponents under the appropriate repo What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): Is this a BUG REPORT or FEATURE REQUEST? (choose one): <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): master Environment: Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: What happened: Currently, the YAML template for both npd and fluentd service do not have toleration, this may cause the daemonset cannot be started on a node if it is already selected to run , it is better to add toleration for both npd and fluentd so as to make sure those daemonset can run on the nodes even if it is for . All other daemonset in kubernetes also have such tolerations. What you expected to happen: Should add toleration for both npd and fluentd. How to reproduce it (as minimally and precisely as possible): Anything else we need to know:\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\nYou sent PRs to fix this, right? Can this be closed now?\nthe PR was not committed yet, can you help lgtm and approve it?", "positive_passages": [{"docid": "doc-en-kubernetes-a025134d6c7a30fceb3f4e3e651ee74d6e8cacaecd34dc04f5e359b6471a9355", "text": "tolerations: - operator: \"Exists\" effect: \"NoExecute\" <ins> - key: \"CriticalAddonsOnly\" operator: \"Exists\" </ins>", "commid": "kubernetes_pr_46748"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72b6f4033d47262868bfa64c947c8c44e063353890ba7dff6a2a083bcacb672d", "query": "We have moved to non-global schema in a number of places in 1.6 and 1.7. It is easy to forget registering the unversioned types like , leading to encoding errors in error cases. The registration of the unversioned types should be automatic as for the types, i.e. in .\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\ndo we need to close out this issue? (since referenced PR has merged)\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-111713cb7356cd7c453110e1466e10bc754216687fa5957606c70b9d1abfe452", "text": "if kind.Version == runtime.APIVersionInternal { continue } <del> if kind == api.Unversioned.WithKind(\"Status\") { </del> <ins> if kind == metav1.Unversioned.WithKind(\"Status\") { </ins> // this is added below as unversioned continue } metaOnlyObject := gvkToMetadataOnlyObject(kind) scheme.AddKnownTypeWithName(kind, metaOnlyObject) } <del> scheme.AddUnversionedTypes(api.Unversioned, &metav1.Status{}) </del> <ins> scheme.AddUnversionedTypes(metav1.Unversioned, &metav1.Status{}) </ins> return serializer.NewCodecFactory(scheme) }", "commid": "kubernetes_pr_46112"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72b6f4033d47262868bfa64c947c8c44e063353890ba7dff6a2a083bcacb672d", "query": "We have moved to non-global schema in a number of places in 1.6 and 1.7. It is easy to forget registering the unversioned types like , leading to encoding errors in error cases. The registration of the unversioned types should be automatic as for the types, i.e. in .\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\ndo we need to close out this issue? (since referenced PR has merged)\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-6503abb79b502b3fcd0eaacc588f5b1f8e57325350c6fb3cb6c0628ba4bc714b", "text": "// SchemeGroupVersion is group version used to register these objects var SchemeGroupVersion = schema.GroupVersion{Group: GroupName, Version: \"v1\"} <ins> // Unversioned is group version for unversioned API objects // TODO: this should be v1 probably var Unversioned = schema.GroupVersion{Group: \"\", Version: \"v1\"} </ins> // WatchEventKind is name reserved for serializing watch events. const WatchEventKind = \"WatchEvent\"", "commid": "kubernetes_pr_46112"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72b6f4033d47262868bfa64c947c8c44e063353890ba7dff6a2a083bcacb672d", "query": "We have moved to non-global schema in a number of places in 1.6 and 1.7. It is easy to forget registering the unversioned types like , leading to encoding errors in error cases. The registration of the unversioned types should be automatic as for the types, i.e. in .\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\ndo we need to close out this issue? (since referenced PR has merged)\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-a970a199e15095005ca6ed46d570ac457a40f0b6035476f48733542704d86a25", "text": "Convert_versioned_Event_to_versioned_InternalEvent, ) <ins> // Register Unversioned types under their own special group scheme.AddUnversionedTypes(Unversioned, &Status{}, &APIVersions{}, &APIGroupList{}, &APIGroup{}, &APIResourceList{}, ) </ins> // register manually. This usually goes through the SchemeBuilder, which we cannot use here. scheme.AddGeneratedDeepCopyFuncs(GetGeneratedDeepCopyFuncs()...) AddConversionFuncs(scheme)", "commid": "kubernetes_pr_46112"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72b6f4033d47262868bfa64c947c8c44e063353890ba7dff6a2a083bcacb672d", "query": "We have moved to non-global schema in a number of places in 1.6 and 1.7. It is easy to forget registering the unversioned types like , leading to encoding errors in error cases. The registration of the unversioned types should be automatic as for the types, i.e. in .\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\ndo we need to close out this issue? (since referenced PR has merged)\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-9a153b357cc35eb655f40b08cf93663fddd64e022964311f9ac7a2c0c620001d", "text": "t := reflect.TypeOf(obj).Elem() gvk := version.WithKind(t.Name()) s.unversionedTypes[t] = gvk <del> if _, ok := s.unversionedKinds[gvk.Kind]; ok { panic(fmt.Sprintf(\"%v has already been registered as unversioned kind %q - kind name must be unique\", reflect.TypeOf(t), gvk.Kind)) </del> <ins> if old, ok := s.unversionedKinds[gvk.Kind]; ok && t != old { panic(fmt.Sprintf(\"%v.%v has already been registered as unversioned kind %q - kind name must be unique\", old.PkgPath(), old.Name(), gvk)) </ins> } s.unversionedKinds[gvk.Kind] = t }", "commid": "kubernetes_pr_46112"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72b6f4033d47262868bfa64c947c8c44e063353890ba7dff6a2a083bcacb672d", "query": "We have moved to non-global schema in a number of places in 1.6 and 1.7. It is easy to forget registering the unversioned types like , leading to encoding errors in error cases. The registration of the unversioned types should be automatic as for the types, i.e. in .\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\ndo we need to close out this issue? (since referenced PR has merged)\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-2d08aa9f0188966efa13d324f24ce950aa0d1bd94a340f8bbc1bc380e8e49233", "text": "} s.AddUnversionedTypes(gv, &InternalSimple{}) <ins> s.AddUnversionedTypes(gv, &InternalSimple{}) </ins> if len(s.KnownTypes(gv)) != 1 { t.Errorf(\"expected only one %v type after double registration with custom name\", gv) }", "commid": "kubernetes_pr_46112"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72b6f4033d47262868bfa64c947c8c44e063353890ba7dff6a2a083bcacb672d", "query": "We have moved to non-global schema in a number of places in 1.6 and 1.7. It is easy to forget registering the unversioned types like , leading to encoding errors in error cases. The registration of the unversioned types should be automatic as for the types, i.e. in .\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\ndo we need to close out this issue? (since referenced PR has merged)\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-151400ee2ac8006e17a560dec7f9035ca86a68f609c580e83c1a547771403711", "text": "} } <ins> // EmbeddableTypeMeta passes GetObjectKind to the type which embeds it. type EmbeddableTypeMeta runtime.TypeMeta func (tm *EmbeddableTypeMeta) GetObjectKind() schema.ObjectKind { return (*runtime.TypeMeta)(tm) } </ins> func TestConflictingAddKnownTypes(t *testing.T) { s := runtime.NewScheme() gv := schema.GroupVersion{Group: \"foo\", Version: \"v1\"}", "commid": "kubernetes_pr_46112"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72b6f4033d47262868bfa64c947c8c44e063353890ba7dff6a2a083bcacb672d", "query": "We have moved to non-global schema in a number of places in 1.6 and 1.7. It is easy to forget registering the unversioned types like , leading to encoding errors in error cases. The registration of the unversioned types should be automatic as for the types, i.e. in .\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\ndo we need to close out this issue? (since referenced PR has merged)\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-d1b4b2809f4ef26dbfbaa1393eb684b6c970e54d1b52775d37dcfb588512f47f", "text": "panicked <- true } }() s.AddUnversionedTypes(gv, &InternalSimple{}) <ins> // redefine InternalSimple with the same name, but obviously as a different type type InternalSimple struct { EmbeddableTypeMeta `json:\",inline\"` TestString         string `json:\"testString\"` } </ins> s.AddUnversionedTypes(gv, &InternalSimple{}) panicked <- false }()", "commid": "kubernetes_pr_46112"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72b6f4033d47262868bfa64c947c8c44e063353890ba7dff6a2a083bcacb672d", "query": "We have moved to non-global schema in a number of places in 1.6 and 1.7. It is easy to forget registering the unversioned types like , leading to encoding errors in error cases. The registration of the unversioned types should be automatic as for the types, i.e. in .\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\ndo we need to close out this issue? (since referenced PR has merged)\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-009146622dd48374d238d05664955a82a0bbfd0fbef9855b3390cb30af84612d", "text": "// SchemeGroupVersion is group version used to register these objects var SchemeGroupVersion = schema.GroupVersion{Group: GroupName, Version: runtime.APIVersionInternal} <del> // Unversioned is group version for unversioned API objects // TODO: this should be v1 probably var Unversioned = schema.GroupVersion{Group: \"\", Version: \"v1\"} </del> // ParameterCodec handles versioning of objects that are converted to query parameters. var ParameterCodec = runtime.NewParameterCodec(Scheme)", "commid": "kubernetes_pr_46112"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72b6f4033d47262868bfa64c947c8c44e063353890ba7dff6a2a083bcacb672d", "query": "We have moved to non-global schema in a number of places in 1.6 and 1.7. It is easy to forget registering the unversioned types like , leading to encoding errors in error cases. The registration of the unversioned types should be automatic as for the types, i.e. in .\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\ndo we need to close out this issue? (since referenced PR has merged)\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-b5562393a85947e79f35de68ac280cfe5e22e548fcb1c7757b800a08aa13b4a0", "text": "&ConfigMapList{}, ) <del> // Register Unversioned types under their own special group scheme.AddUnversionedTypes(Unversioned, &metav1.Status{}, &metav1.APIVersions{}, &metav1.APIGroupList{}, &metav1.APIGroup{}, &metav1.APIResourceList{}, ) </del> return nil }", "commid": "kubernetes_pr_46112"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72b6f4033d47262868bfa64c947c8c44e063353890ba7dff6a2a083bcacb672d", "query": "We have moved to non-global schema in a number of places in 1.6 and 1.7. It is easy to forget registering the unversioned types like , leading to encoding errors in error cases. The registration of the unversioned types should be automatic as for the types, i.e. in .\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\ndo we need to close out this issue? (since referenced PR has merged)\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-43faa21049c32252f66fcc770fb34392eb55ced2cedfd85ad254b551b1f45dd5", "text": "} } <ins> func TestStatus(t *testing.T) { _, s, closeFn := framework.RunAMaster(nil) defer closeFn() u := s.URL + \"/apis/batch/v1/namespaces/default/jobs/foo\" resp, err := http.Get(u) if err != nil { t.Fatalf(\"unexpected error getting %s: %v\", u, err) } if resp.StatusCode != http.StatusNotFound { t.Fatalf(\"got status %v instead of 404\", resp.StatusCode) } defer resp.Body.Close() data, _ := ioutil.ReadAll(resp.Body) decodedData := map[string]interface{}{} if err := json.Unmarshal(data, &decodedData); err != nil { t.Logf(\"body: %s\", string(data)) t.Fatalf(\"got error decoding data: %v\", err) } t.Logf(\"body: %s\", string(data)) if got, expected := decodedData[\"apiVersion\"], \"v1\"; got != expected { t.Errorf(\"unexpected apiVersion %q, expected %q\", got, expected) } if got, expected := decodedData[\"kind\"], \"Status\"; got != expected { t.Errorf(\"unexpected kind %q, expected %q\", got, expected) } if got, expected := decodedData[\"status\"], \"Failure\"; got != expected { t.Errorf(\"unexpected status %q, expected %q\", got, expected) } if got, expected := decodedData[\"code\"], float64(404); got != expected { t.Errorf(\"unexpected code %v, expected %v\", got, expected) } } </ins> func TestWatchSucceedsWithoutArgs(t *testing.T) { _, s, closeFn := framework.RunAMaster(nil) defer closeFn()", "commid": "kubernetes_pr_46112"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e125aa108aaf244bcfe7ca83c7081fad24054b312c79c5cbcd86436e2bd1a1f", "query": "We should do this after 1.7. xref /sig testing cc\nIs this the task that needs completed - Add support to Ubuntu e2e test-infra\nThat is different, this is about running GPU tests as part of PR pre-submit tests. Right now we skip them because they are \"[Serial]\".\nI can work on this issue in conjunction with . Is this issue just a matter of adding GPU tests to a different suite or are there more subtasks?\nAnymore progress on this?\nThanks for the reminder. I just submitted an internal request for quota to run these tests. Once that is approved, I will add a PR in test-infra to run GPU tests on all k/k PRs. It will be non-blocking initially and then become blocking later on.\nAwesome, thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-84ef4579f6a2170e18ae397f0c6fccbc6f305673ebc923fdf4fa333ec18b046c", "text": "PodWaiting PodStatus = \"Waiting\" // PodRunning means that the pod is up and running. PodRunning PodStatus = \"Running\" <del> // PodTerminated means that the pod has stopped. </del> <ins> // PodTerminated means that the pod has stopped with error(s) </ins> PodTerminated PodStatus = \"Terminated\" // PodUnknown means that we failed to obtain info about the pod. PodUnknown PodStatus = \"Unknown\" <ins> // PodSucceeded means that the pod has stopped without error(s) PodSucceeded PodStatus = \"Succeeded\" </ins> ) type ContainerStateWaiting struct {", "commid": "kubernetes_pr_3076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e125aa108aaf244bcfe7ca83c7081fad24054b312c79c5cbcd86436e2bd1a1f", "query": "We should do this after 1.7. xref /sig testing cc\nIs this the task that needs completed - Add support to Ubuntu e2e test-infra\nThat is different, this is about running GPU tests as part of PR pre-submit tests. Right now we skip them because they are \"[Serial]\".\nI can work on this issue in conjunction with . Is this issue just a matter of adding GPU tests to a different suite or are there more subtasks?\nAnymore progress on this?\nThanks for the reminder. I just submitted an internal request for quota to run these tests. Once that is approved, I will add a PR in test-infra to run GPU tests on all k/k PRs. It will be non-blocking initially and then become blocking later on.\nAwesome, thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-d758b89a7c4df0d90f8c9800580a7dbe1bc5a6ff227e79e56827f6fa675d34da", "text": "case newer.PodRunning: *out = PodRunning case newer.PodSucceeded: <del> *out = PodTerminated </del> <ins> *out = PodSucceeded </ins> case newer.PodFailed: *out = PodTerminated case newer.PodUnknown:", "commid": "kubernetes_pr_3076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e125aa108aaf244bcfe7ca83c7081fad24054b312c79c5cbcd86436e2bd1a1f", "query": "We should do this after 1.7. xref /sig testing cc\nIs this the task that needs completed - Add support to Ubuntu e2e test-infra\nThat is different, this is about running GPU tests as part of PR pre-submit tests. Right now we skip them because they are \"[Serial]\".\nI can work on this issue in conjunction with . Is this issue just a matter of adding GPU tests to a different suite or are there more subtasks?\nAnymore progress on this?\nThanks for the reminder. I just submitted an internal request for quota to run these tests. Once that is approved, I will add a PR in test-infra to run GPU tests on all k/k PRs. It will be non-blocking initially and then become blocking later on.\nAwesome, thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-4cdf0aaab158f2550906fadc4c5762565e830f863689cb7ede6e0e869511f102", "text": "case PodTerminated: // Older API versions did not contain enough info to map to PodSucceeded *out = newer.PodFailed <ins> case PodSucceeded: *out = newer.PodSucceeded </ins> case PodUnknown: *out = newer.PodUnknown default:", "commid": "kubernetes_pr_3076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e125aa108aaf244bcfe7ca83c7081fad24054b312c79c5cbcd86436e2bd1a1f", "query": "We should do this after 1.7. xref /sig testing cc\nIs this the task that needs completed - Add support to Ubuntu e2e test-infra\nThat is different, this is about running GPU tests as part of PR pre-submit tests. Right now we skip them because they are \"[Serial]\".\nI can work on this issue in conjunction with . Is this issue just a matter of adding GPU tests to a different suite or are there more subtasks?\nAnymore progress on this?\nThanks for the reminder. I just submitted an internal request for quota to run these tests. Once that is approved, I will add a PR in test-infra to run GPU tests on all k/k PRs. It will be non-blocking initially and then become blocking later on.\nAwesome, thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-ae6ff399305e2fb905afa1c4df90e085bc2176a6012404b1b80f2a05572e66ab", "text": "PodTerminated PodStatus = \"Terminated\" // PodUnknown means that we failed to obtain info about the pod. PodUnknown PodStatus = \"Unknown\" <ins> // PodSucceeded means that the pod has stopped without error(s) PodSucceeded PodStatus = \"Succeeded\" </ins> ) type ContainerStateWaiting struct {", "commid": "kubernetes_pr_3076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0f154968bad7b3fe4febd8724083c6d4a91f4ea6f45457b43a4887b9d4012654", "query": "xref: /sig node /area test\nI am working on this.\nCan you update this with the types of tests that you are adding? Is this similar to ?\nNo, this is for running the existing GPU e2e tests on GKE which are currently running on only GCE.\nThe referenced PRs appear to have merged, closing.", "positive_passages": [{"docid": "doc-en-kubernetes-eb169a476fce4d5432553b5c0645a066d73ed0e9f0f8cb8788cebd332514e818", "text": "package e2e import ( <ins> \"io/ioutil\" \"net/http\" </ins> \"strings\" \"time\"", "commid": "kubernetes_pr_47467"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0f154968bad7b3fe4febd8724083c6d4a91f4ea6f45457b43a4887b9d4012654", "query": "xref: /sig node /area test\nI am working on this.\nCan you update this with the types of tests that you are adding? Is this similar to ?\nNo, this is for running the existing GPU e2e tests on GKE which are currently running on only GCE.\nThe referenced PRs appear to have merged, closing.", "positive_passages": [{"docid": "doc-en-kubernetes-acd5865f5e7734cabf958dda044a84bd3f5d8a47dc594641844eaace3e1ea07d", "text": "\"k8s.io/kubernetes/pkg/api/v1\" extensions \"k8s.io/kubernetes/pkg/apis/extensions/v1beta1\" \"k8s.io/kubernetes/test/e2e/framework\" <del> \"k8s.io/kubernetes/test/e2e/generated\" </del> . \"github.com/onsi/ginkgo\" . \"github.com/onsi/gomega\"", "commid": "kubernetes_pr_47467"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0f154968bad7b3fe4febd8724083c6d4a91f4ea6f45457b43a4887b9d4012654", "query": "xref: /sig node /area test\nI am working on this.\nCan you update this with the types of tests that you are adding? Is this similar to ?\nNo, this is for running the existing GPU e2e tests on GKE which are currently running on only GCE.\nThe referenced PRs appear to have merged, closing.", "positive_passages": [{"docid": "doc-en-kubernetes-60c55c17e4dd0a60d8299e116d857d77c5522ba1ce63b27f267414809192d0f7", "text": "// Nvidia driver installation can take upwards of 5 minutes. driverInstallTimeout = 10 * time.Minute // Nvidia COS driver installer daemonset. <del> cosNvidiaDriverInstallerPath = \"cluster/gce/gci/nvidia-gpus/cos-installer-daemonset.yaml\" </del> <ins> cosNvidiaDriverInstallerUrl = \"https://raw.githubusercontent.com/ContainerEngine/accelerators/stable/cos-nvidia-gpu-installer/daemonset.yaml\" </ins> ) func makeCudaAdditionTestPod() *v1.Pod {", "commid": "kubernetes_pr_47467"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0f154968bad7b3fe4febd8724083c6d4a91f4ea6f45457b43a4887b9d4012654", "query": "xref: /sig node /area test\nI am working on this.\nCan you update this with the types of tests that you are adding? Is this similar to ?\nNo, this is for running the existing GPU e2e tests on GKE which are currently running on only GCE.\nThe referenced PRs appear to have merged, closing.", "positive_passages": [{"docid": "doc-en-kubernetes-f947f5149bafc3a338a4211596482f0676eb9efda7a34520e81c86263da60550", "text": "// GPU drivers might have already been installed. if !areGPUsAvailableOnAllSchedulableNodes(f) { // Install Nvidia Drivers. <del> ds := dsFromManifest(cosNvidiaDriverInstallerPath) </del> <ins> ds := dsFromManifest(cosNvidiaDriverInstallerUrl) </ins> ds.Namespace = f.Namespace.Name _, err := f.ClientSet.Extensions().DaemonSets(f.Namespace.Name).Create(ds) framework.ExpectNoError(err, \"failed to create daemonset\")", "commid": "kubernetes_pr_47467"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0f154968bad7b3fe4febd8724083c6d4a91f4ea6f45457b43a4887b9d4012654", "query": "xref: /sig node /area test\nI am working on this.\nCan you update this with the types of tests that you are adding? Is this similar to ?\nNo, this is for running the existing GPU e2e tests on GKE which are currently running on only GCE.\nThe referenced PRs appear to have merged, closing.", "positive_passages": [{"docid": "doc-en-kubernetes-de986b276b53cdd91e5c979f42724c35b84232662d716477c20188d82a9c8cec", "text": "} // dsFromManifest reads a .json/yaml file and returns the daemonset in it. <del> func dsFromManifest(fileName string) *extensions.DaemonSet { </del> <ins> func dsFromManifest(url string) *extensions.DaemonSet { </ins> var controller extensions.DaemonSet <del> framework.Logf(\"Parsing ds from %v\", fileName) data := generated.ReadOrDie(fileName) </del> <ins> framework.Logf(\"Parsing ds from %v\", url) var response *http.Response var err error for i := 1; i <= 5; i++ { response, err = http.Get(url) if err == nil && response.StatusCode == 200 { break } time.Sleep(time.Duration(i) * time.Second) } Expect(err).NotTo(HaveOccurred()) Expect(response.StatusCode).To(Equal(200)) defer response.Body.Close() data, err := ioutil.ReadAll(response.Body) Expect(err).NotTo(HaveOccurred()) </ins> json, err := utilyaml.ToJSON(data) Expect(err).NotTo(HaveOccurred())", "commid": "kubernetes_pr_47467"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0f154968bad7b3fe4febd8724083c6d4a91f4ea6f45457b43a4887b9d4012654", "query": "xref: /sig node /area test\nI am working on this.\nCan you update this with the types of tests that you are adding? Is this similar to ?\nNo, this is for running the existing GPU e2e tests on GKE which are currently running on only GCE.\nThe referenced PRs appear to have merged, closing.", "positive_passages": [{"docid": "doc-en-kubernetes-a184669b4f8aef70c7f97a8283e42a75f89ba185e8981003aabe1b660b97789c", "text": "runcmd: - modprobe configs <del> - docker run -v /dev:/dev -v /home/kubernetes/bin/nvidia:/rootfs/nvidia -v /etc/os-release:/rootfs/etc/os-release -v /proc/sysrq-trigger:/sysrq -e LAKITU_KERNEL_SHA1=26481563cb3788ad254c2bf2126b843c161c7e48 -e BASE_DIR=/rootfs/nvidia --privileged gcr.io/google_containers/cos-nvidia-driver-install@sha256:ad83ede6e0c6d768bf7cf69a7dec972aa5e8f88778142ca46afd3286ad58cfc8 </del> <ins> - docker run -v /dev:/dev -v /home/kubernetes/bin/nvidia:/rootfs/nvidia -v /etc/os-release:/rootfs/etc/os-release -v /proc/sysrq-trigger:/sysrq -e BASE_DIR=/rootfs/nvidia --privileged gcr.io/google_containers/cos-nvidia-driver-install@sha256:cb55c7971c337fece62f2bfe858662522a01e43ac9984a2dd1dd5c71487d225c </ins> - mount /tmp /tmp -o remount,exec,suid - usermod -a -G docker jenkins - mkdir -p /var/lib/kubelet", "commid": "kubernetes_pr_47467"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0f154968bad7b3fe4febd8724083c6d4a91f4ea6f45457b43a4887b9d4012654", "query": "xref: /sig node /area test\nI am working on this.\nCan you update this with the types of tests that you are adding? Is this similar to ?\nNo, this is for running the existing GPU e2e tests on GKE which are currently running on only GCE.\nThe referenced PRs appear to have merged, closing.", "positive_passages": [{"docid": "doc-en-kubernetes-05af8398773a76624b30fb4b11bb9909f037c7d540122074af0a73af49209119", "text": "image: e2e-node-containervm-v20161208-image # docker 1.11.2 project: kubernetes-node-e2e-images gci: <del> image_regex: cos-beta-59-9460-20-0 # docker 1.11.2 </del> <ins> image_regex: cos-stable-59-9460-60-0 # docker 1.11.2 </ins> project: cos-cloud metadata: \"user-data<test/e2e_node/jenkins/gci-init-gpu.yaml,gci-update-strategy=update_disabled\" resources: accelerators: - type: nvidia-tesla-k80 count: 2", "commid": "kubernetes_pr_47467"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07d743f275589dc899f72f61b7bb720b2610d6e1babb36a1a07c597b266bdaf8", "query": "several operations to the glusterfs mount operation that nodes are not permitted to perform: looks up arbitrary secrets based on storage class parameters. this will not succeed, as the node authorizer will only allow nodes access to secrets referenced by pods or persistent volumes used by the node attempts to create a service and endpoint using the node's API client. nodes do not have permission to create arbitrary endpoints and services. For both of those reasons, that recreate operation will fail when attempted from the node. The recreate operation should probably move to one of the storage-related controllers (provisioner or attach/detach) cc\nMarking this with 1.7 milestone until we have a better idea of whether this is blocking or not for the 1.7 release.\nCC Is the endpoint originally created by the user or by the volume plugin creating/deleting Endpoint objects? In addition to the concerns raised, having a volume create new API objects seems like a bad idea (abstraction layer violation?).\nFrom on Slack: Unless there is justification otherwise, I will roll back the PR on Monday.\ncc/\nrevert button doesn't work, have to do it manually\nRevert PR is approved and awaiting merge (). Once that merges this issue can be closed.\nOpened an E2E pr to catch this kind of behavior in the future. WIP, still exploring a method to reproduce and catch the behavior.", "positive_passages": [{"docid": "doc-en-kubernetes-131478b861261a6e2d310a822fdf14138a07c51b973e77dca078bc30f37cf471", "text": "// absGidMin <= defGidMin <= defGidMax <= absGidMax absoluteGidMin          = 2000 absoluteGidMax          = math.MaxInt32 <del> heketiAnn               = \"heketi-dynamic-provisioner\" glusterTypeAnn          = \"gluster.org/type\" glusterDescAnn          = \"Gluster: Dynamically provisioned PV\" </del> linuxGlusterMountBinary = \"mount.glusterfs\" autoUnmountBinaryVer    = \"3.11\" )", "commid": "kubernetes_pr_47726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07d743f275589dc899f72f61b7bb720b2610d6e1babb36a1a07c597b266bdaf8", "query": "several operations to the glusterfs mount operation that nodes are not permitted to perform: looks up arbitrary secrets based on storage class parameters. this will not succeed, as the node authorizer will only allow nodes access to secrets referenced by pods or persistent volumes used by the node attempts to create a service and endpoint using the node's API client. nodes do not have permission to create arbitrary endpoints and services. For both of those reasons, that recreate operation will fail when attempted from the node. The recreate operation should probably move to one of the storage-related controllers (provisioner or attach/detach) cc\nMarking this with 1.7 milestone until we have a better idea of whether this is blocking or not for the 1.7 release.\nCC Is the endpoint originally created by the user or by the volume plugin creating/deleting Endpoint objects? In addition to the concerns raised, having a volume create new API objects seems like a bad idea (abstraction layer violation?).\nFrom on Slack: Unless there is justification otherwise, I will roll back the PR on Monday.\ncc/\nrevert button doesn't work, have to do it manually\nRevert PR is approved and awaiting merge (). Once that merges this issue can be closed.\nOpened an E2E pr to catch this kind of behavior in the future. WIP, still exploring a method to reproduce and catch the behavior.", "positive_passages": [{"docid": "doc-en-kubernetes-a0ee4ca6fec483693c46daaa9f60b9b9c509398f131af4632f15776bfd00f5c4", "text": "if kubeClient == nil { return nil, fmt.Errorf(\"glusterfs: failed to get kube client to initialize mounter\") } ep, err := kubeClient.Core().Endpoints(ns).Get(epName, metav1.GetOptions{}) <del> if err != nil && errors.IsNotFound(err) { claim := spec.PersistentVolume.Spec.ClaimRef.Name checkEpName := dynamicEpSvcPrefix + claim if epName != checkEpName { return nil, fmt.Errorf(\"failed to get endpoint %s, error %v\", epName, err) } glog.Errorf(\"glusterfs: failed to get endpoint %s[%v]\", epName, err) if spec != nil && spec.PersistentVolume.Annotations[volumehelper.VolumeDynamicallyCreatedByKey] == heketiAnn { class, err := volutil.GetClassForVolume(plugin.host.GetKubeClient(), spec.PersistentVolume) if err != nil { return nil, fmt.Errorf(\"glusterfs: failed to get storageclass, error: %v\", err) } cfg, err := parseClassParameters(class.Parameters, plugin.host.GetKubeClient()) if err != nil { return nil, fmt.Errorf(\"glusterfs: failed to parse parameters, error: %v\", err) } scConfig := *cfg cli := gcli.NewClient(scConfig.url, scConfig.user, scConfig.secretValue) if cli == nil { return nil, fmt.Errorf(\"glusterfs: failed to create heketi client, error: %v\", err) } volumeID := dstrings.TrimPrefix(source.Path, volPrefix) volInfo, err := cli.VolumeInfo(volumeID) if err != nil { return nil, fmt.Errorf(\"glusterfs: failed to get volume info, error: %v\", err) } endpointIPs, err := getClusterNodes(cli, volInfo.Cluster) if err != nil { return nil, fmt.Errorf(\"glusterfs: failed to get cluster nodes, error: %v\", err) } // Give an attempt to recreate endpoint/service. _, _, err = plugin.createEndpointService(ns, epName, endpointIPs, claim) if err != nil && !errors.IsAlreadyExists(err) { glog.Errorf(\"glusterfs: failed to recreate endpoint/service, error: %v\", err) return nil, fmt.Errorf(\"failed to recreate endpoint/service, error: %v\", err) } glog.V(3).Infof(\"glusterfs: endpoint/service [%v] successfully recreated \", epName) } else { return nil, err } </del> <ins> if err != nil { glog.Errorf(\"glusterfs: failed to get endpoints %s[%v]\", epName, err) return nil, err </ins> } <ins> glog.V(1).Infof(\"glusterfs: endpoints %v\", ep) </ins> return plugin.newMounterInternal(spec, ep, pod, plugin.host.GetMounter(), exec.New()) }", "commid": "kubernetes_pr_47726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07d743f275589dc899f72f61b7bb720b2610d6e1babb36a1a07c597b266bdaf8", "query": "several operations to the glusterfs mount operation that nodes are not permitted to perform: looks up arbitrary secrets based on storage class parameters. this will not succeed, as the node authorizer will only allow nodes access to secrets referenced by pods or persistent volumes used by the node attempts to create a service and endpoint using the node's API client. nodes do not have permission to create arbitrary endpoints and services. For both of those reasons, that recreate operation will fail when attempted from the node. The recreate operation should probably move to one of the storage-related controllers (provisioner or attach/detach) cc\nMarking this with 1.7 milestone until we have a better idea of whether this is blocking or not for the 1.7 release.\nCC Is the endpoint originally created by the user or by the volume plugin creating/deleting Endpoint objects? In addition to the concerns raised, having a volume create new API objects seems like a bad idea (abstraction layer violation?).\nFrom on Slack: Unless there is justification otherwise, I will roll back the PR on Monday.\ncc/\nrevert button doesn't work, have to do it manually\nRevert PR is approved and awaiting merge (). Once that merges this issue can be closed.\nOpened an E2E pr to catch this kind of behavior in the future. WIP, still exploring a method to reproduce and catch the behavior.", "positive_passages": [{"docid": "doc-en-kubernetes-25cce2fdda31093d14b2127007b67fdd036bfca4fb1bb33353b5eb910ed01666", "text": "return newGidTable, nil } <del> //createEndpointService create an endpoint and service in provided namespace. func (plugin *glusterfsPlugin) createEndpointService(namespace string, epServiceName string, hostips []string, pvcname string) (endpoint *v1.Endpoints, service *v1.Service, err error) { addrlist := make([]v1.EndpointAddress, len(hostips)) for i, v := range hostips { addrlist[i].IP = v } endpoint = &v1.Endpoints{ ObjectMeta: metav1.ObjectMeta{ Namespace: namespace, Name:      epServiceName, Labels: map[string]string{ \"gluster.kubernetes.io/provisioned-for-pvc\": pvcname, }, }, Subsets: []v1.EndpointSubset{{ Addresses: addrlist, Ports:     []v1.EndpointPort{{Port: 1, Protocol: \"TCP\"}}, }}, } kubeClient := plugin.host.GetKubeClient() if kubeClient == nil { return nil, nil, fmt.Errorf(\"glusterfs: failed to get kube client when creating endpoint service\") } _, err = kubeClient.Core().Endpoints(namespace).Create(endpoint) if err != nil && errors.IsAlreadyExists(err) { glog.V(1).Infof(\"glusterfs: endpoint [%s] already exist in namespace [%s]\", endpoint, namespace) err = nil } if err != nil { glog.Errorf(\"glusterfs: failed to create endpoint: %v\", err) return nil, nil, fmt.Errorf(\"error creating endpoint: %v\", err) } service = &v1.Service{ ObjectMeta: metav1.ObjectMeta{ Name:      epServiceName, Namespace: namespace, Labels: map[string]string{ \"gluster.kubernetes.io/provisioned-for-pvc\": pvcname, }, }, Spec: v1.ServiceSpec{ Ports: []v1.ServicePort{ {Protocol: \"TCP\", Port: 1}}}} _, err = kubeClient.Core().Services(namespace).Create(service) if err != nil && errors.IsAlreadyExists(err) { glog.V(1).Infof(\"glusterfs: service [%s] already exist in namespace [%s]\", service, namespace) err = nil } if err != nil { glog.Errorf(\"glusterfs: failed to create service: %v\", err) return nil, nil, fmt.Errorf(\"error creating service: %v\", err) } return endpoint, service, nil } // deleteEndpointService delete the endpoint and service from the provided namespace. func (plugin *glusterfsPlugin) deleteEndpointService(namespace string, epServiceName string) (err error) { kubeClient := plugin.host.GetKubeClient() if kubeClient == nil { return fmt.Errorf(\"glusterfs: failed to get kube client when deleting endpoint service\") } err = kubeClient.Core().Services(namespace).Delete(epServiceName, nil) if err != nil { glog.Errorf(\"glusterfs: error deleting service %s/%s: %v\", namespace, epServiceName, err) return fmt.Errorf(\"error deleting service %s/%s: %v\", namespace, epServiceName, err) } glog.V(1).Infof(\"glusterfs: service/endpoint %s/%s deleted successfully\", namespace, epServiceName) return nil } </del> func (d *glusterfsVolumeDeleter) getGid() (int, bool, error) { gidStr, ok := d.spec.Annotations[volumehelper.VolumeGidAnnotationKey]", "commid": "kubernetes_pr_47726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07d743f275589dc899f72f61b7bb720b2610d6e1babb36a1a07c597b266bdaf8", "query": "several operations to the glusterfs mount operation that nodes are not permitted to perform: looks up arbitrary secrets based on storage class parameters. this will not succeed, as the node authorizer will only allow nodes access to secrets referenced by pods or persistent volumes used by the node attempts to create a service and endpoint using the node's API client. nodes do not have permission to create arbitrary endpoints and services. For both of those reasons, that recreate operation will fail when attempted from the node. The recreate operation should probably move to one of the storage-related controllers (provisioner or attach/detach) cc\nMarking this with 1.7 milestone until we have a better idea of whether this is blocking or not for the 1.7 release.\nCC Is the endpoint originally created by the user or by the volume plugin creating/deleting Endpoint objects? In addition to the concerns raised, having a volume create new API objects seems like a bad idea (abstraction layer violation?).\nFrom on Slack: Unless there is justification otherwise, I will roll back the PR on Monday.\ncc/\nrevert button doesn't work, have to do it manually\nRevert PR is approved and awaiting merge (). Once that merges this issue can be closed.\nOpened an E2E pr to catch this kind of behavior in the future. WIP, still exploring a method to reproduce and catch the behavior.", "positive_passages": [{"docid": "doc-en-kubernetes-aff627441cbac6b116f7ece4effb376c66fac7b19eef52c93116cbc04654d0c8", "text": "dynamicEndpoint = pvSpec.Glusterfs.EndpointsName } glog.V(3).Infof(\"glusterfs: dynamic namespace and endpoint : [%v/%v]\", dynamicNamespace, dynamicEndpoint) <del> err = d.plugin.deleteEndpointService(dynamicNamespace, dynamicEndpoint) </del> <ins> err = d.deleteEndpointService(dynamicNamespace, dynamicEndpoint) </ins> if err != nil { glog.Errorf(\"glusterfs: error when deleting endpoint/service :%v\", err) } else {", "commid": "kubernetes_pr_47726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07d743f275589dc899f72f61b7bb720b2610d6e1babb36a1a07c597b266bdaf8", "query": "several operations to the glusterfs mount operation that nodes are not permitted to perform: looks up arbitrary secrets based on storage class parameters. this will not succeed, as the node authorizer will only allow nodes access to secrets referenced by pods or persistent volumes used by the node attempts to create a service and endpoint using the node's API client. nodes do not have permission to create arbitrary endpoints and services. For both of those reasons, that recreate operation will fail when attempted from the node. The recreate operation should probably move to one of the storage-related controllers (provisioner or attach/detach) cc\nMarking this with 1.7 milestone until we have a better idea of whether this is blocking or not for the 1.7 release.\nCC Is the endpoint originally created by the user or by the volume plugin creating/deleting Endpoint objects? In addition to the concerns raised, having a volume create new API objects seems like a bad idea (abstraction layer violation?).\nFrom on Slack: Unless there is justification otherwise, I will roll back the PR on Monday.\ncc/\nrevert button doesn't work, have to do it manually\nRevert PR is approved and awaiting merge (). Once that merges this issue can be closed.\nOpened an E2E pr to catch this kind of behavior in the future. WIP, still exploring a method to reproduce and catch the behavior.", "positive_passages": [{"docid": "doc-en-kubernetes-84507db8a1f646ae69c5cea1bad9be7ad4459ab3a81911a212fcc2570a927e68", "text": "gidStr := strconv.FormatInt(int64(gid), 10) pv.Annotations = map[string]string{ <del> volumehelper.VolumeGidAnnotationKey:        gidStr, volumehelper.VolumeDynamicallyCreatedByKey: heketiAnn, glusterTypeAnn:                             \"file\", \"Description\":                              glusterDescAnn, v1.MountOptionAnnotation:                   \"auto_unmount\", </del> <ins> volumehelper.VolumeGidAnnotationKey: gidStr, \"kubernetes.io/createdby\":           \"heketi-dynamic-provisioner\", \"gluster.org/type\":                  \"file\", \"Description\":                       \"Gluster: Dynamically provisioned PV\", v1.MountOptionAnnotation:            \"auto_unmount\", </ins> } pv.Spec.Capacity = v1.ResourceList{", "commid": "kubernetes_pr_47726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07d743f275589dc899f72f61b7bb720b2610d6e1babb36a1a07c597b266bdaf8", "query": "several operations to the glusterfs mount operation that nodes are not permitted to perform: looks up arbitrary secrets based on storage class parameters. this will not succeed, as the node authorizer will only allow nodes access to secrets referenced by pods or persistent volumes used by the node attempts to create a service and endpoint using the node's API client. nodes do not have permission to create arbitrary endpoints and services. For both of those reasons, that recreate operation will fail when attempted from the node. The recreate operation should probably move to one of the storage-related controllers (provisioner or attach/detach) cc\nMarking this with 1.7 milestone until we have a better idea of whether this is blocking or not for the 1.7 release.\nCC Is the endpoint originally created by the user or by the volume plugin creating/deleting Endpoint objects? In addition to the concerns raised, having a volume create new API objects seems like a bad idea (abstraction layer violation?).\nFrom on Slack: Unless there is justification otherwise, I will roll back the PR on Monday.\ncc/\nrevert button doesn't work, have to do it manually\nRevert PR is approved and awaiting merge (). Once that merges this issue can be closed.\nOpened an E2E pr to catch this kind of behavior in the future. WIP, still exploring a method to reproduce and catch the behavior.", "positive_passages": [{"docid": "doc-en-kubernetes-1e158d7daba06266d0d40a677afcaab057f820980e044b80ca2ad496120d82e2", "text": "return pv, nil } <ins> func (p *glusterfsVolumeProvisioner) GetClusterNodes(cli *gcli.Client, cluster string) (dynamicHostIps []string, err error) { clusterinfo, err := cli.ClusterInfo(cluster) if err != nil { glog.Errorf(\"glusterfs: failed to get cluster details: %v\", err) return nil, fmt.Errorf(\"failed to get cluster details: %v\", err) } // For the dynamically provisioned volume, we gather the list of node IPs // of the cluster on which provisioned volume belongs to, as there can be multiple // clusters. for _, node := range clusterinfo.Nodes { nodei, err := cli.NodeInfo(string(node)) if err != nil { glog.Errorf(\"glusterfs: failed to get hostip: %v\", err) return nil, fmt.Errorf(\"failed to get hostip: %v\", err) } ipaddr := dstrings.Join(nodei.NodeAddRequest.Hostnames.Storage, \"\") dynamicHostIps = append(dynamicHostIps, ipaddr) } glog.V(3).Infof(\"glusterfs: hostlist :%v\", dynamicHostIps) if len(dynamicHostIps) == 0 { glog.Errorf(\"glusterfs: no hosts found: %v\", err) return nil, fmt.Errorf(\"no hosts found: %v\", err) } return dynamicHostIps, nil } </ins> func (p *glusterfsVolumeProvisioner) CreateVolume(gid int) (r *v1.GlusterfsVolumeSource, size int, err error) { var clusterIDs []string capacity := p.options.PVC.Spec.Resources.Requests[v1.ResourceName(v1.ResourceStorage)]", "commid": "kubernetes_pr_47726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07d743f275589dc899f72f61b7bb720b2610d6e1babb36a1a07c597b266bdaf8", "query": "several operations to the glusterfs mount operation that nodes are not permitted to perform: looks up arbitrary secrets based on storage class parameters. this will not succeed, as the node authorizer will only allow nodes access to secrets referenced by pods or persistent volumes used by the node attempts to create a service and endpoint using the node's API client. nodes do not have permission to create arbitrary endpoints and services. For both of those reasons, that recreate operation will fail when attempted from the node. The recreate operation should probably move to one of the storage-related controllers (provisioner or attach/detach) cc\nMarking this with 1.7 milestone until we have a better idea of whether this is blocking or not for the 1.7 release.\nCC Is the endpoint originally created by the user or by the volume plugin creating/deleting Endpoint objects? In addition to the concerns raised, having a volume create new API objects seems like a bad idea (abstraction layer violation?).\nFrom on Slack: Unless there is justification otherwise, I will roll back the PR on Monday.\ncc/\nrevert button doesn't work, have to do it manually\nRevert PR is approved and awaiting merge (). Once that merges this issue can be closed.\nOpened an E2E pr to catch this kind of behavior in the future. WIP, still exploring a method to reproduce and catch the behavior.", "positive_passages": [{"docid": "doc-en-kubernetes-8a48704c26ac1514971a0729a2002652765ef4e88eeec62f239fb2a58b81d277", "text": "return nil, 0, fmt.Errorf(\"error creating volume %v\", err) } glog.V(1).Infof(\"glusterfs: volume with size: %d and name: %s created\", volume.Size, volume.Name) <del> dynamicHostIps, err := getClusterNodes(cli, volume.Cluster) </del> <ins> dynamicHostIps, err := p.GetClusterNodes(cli, volume.Cluster) </ins> if err != nil { glog.Errorf(\"glusterfs: error [%v] when getting cluster nodes for volume %s\", err, volume) return nil, 0, fmt.Errorf(\"error [%v] when getting cluster nodes for volume %s\", err, volume)", "commid": "kubernetes_pr_47726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07d743f275589dc899f72f61b7bb720b2610d6e1babb36a1a07c597b266bdaf8", "query": "several operations to the glusterfs mount operation that nodes are not permitted to perform: looks up arbitrary secrets based on storage class parameters. this will not succeed, as the node authorizer will only allow nodes access to secrets referenced by pods or persistent volumes used by the node attempts to create a service and endpoint using the node's API client. nodes do not have permission to create arbitrary endpoints and services. For both of those reasons, that recreate operation will fail when attempted from the node. The recreate operation should probably move to one of the storage-related controllers (provisioner or attach/detach) cc\nMarking this with 1.7 milestone until we have a better idea of whether this is blocking or not for the 1.7 release.\nCC Is the endpoint originally created by the user or by the volume plugin creating/deleting Endpoint objects? In addition to the concerns raised, having a volume create new API objects seems like a bad idea (abstraction layer violation?).\nFrom on Slack: Unless there is justification otherwise, I will roll back the PR on Monday.\ncc/\nrevert button doesn't work, have to do it manually\nRevert PR is approved and awaiting merge (). Once that merges this issue can be closed.\nOpened an E2E pr to catch this kind of behavior in the future. WIP, still exploring a method to reproduce and catch the behavior.", "positive_passages": [{"docid": "doc-en-kubernetes-476fe2e03e6f5263f64418fe88d5baac2a76935ec3a4f17fcbf756ad501f9b52", "text": "// of volume creation. epServiceName := dynamicEpSvcPrefix + p.options.PVC.Name epNamespace := p.options.PVC.Namespace <del> endpoint, service, err := p.plugin.createEndpointService(epNamespace, epServiceName, dynamicHostIps, p.options.PVC.Name) </del> <ins> endpoint, service, err := p.createEndpointService(epNamespace, epServiceName, dynamicHostIps, p.options.PVC.Name) </ins> if err != nil { glog.Errorf(\"glusterfs: failed to create endpoint/service: %v\", err) deleteErr := cli.VolumeDelete(volume.Id)", "commid": "kubernetes_pr_47726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07d743f275589dc899f72f61b7bb720b2610d6e1babb36a1a07c597b266bdaf8", "query": "several operations to the glusterfs mount operation that nodes are not permitted to perform: looks up arbitrary secrets based on storage class parameters. this will not succeed, as the node authorizer will only allow nodes access to secrets referenced by pods or persistent volumes used by the node attempts to create a service and endpoint using the node's API client. nodes do not have permission to create arbitrary endpoints and services. For both of those reasons, that recreate operation will fail when attempted from the node. The recreate operation should probably move to one of the storage-related controllers (provisioner or attach/detach) cc\nMarking this with 1.7 milestone until we have a better idea of whether this is blocking or not for the 1.7 release.\nCC Is the endpoint originally created by the user or by the volume plugin creating/deleting Endpoint objects? In addition to the concerns raised, having a volume create new API objects seems like a bad idea (abstraction layer violation?).\nFrom on Slack: Unless there is justification otherwise, I will roll back the PR on Monday.\ncc/\nrevert button doesn't work, have to do it manually\nRevert PR is approved and awaiting merge (). Once that merges this issue can be closed.\nOpened an E2E pr to catch this kind of behavior in the future. WIP, still exploring a method to reproduce and catch the behavior.", "positive_passages": [{"docid": "doc-en-kubernetes-886a22c54d0bb552d0aacc19364b639b73f6633669f646a1ac11e9f7bed58175", "text": "}, sz, nil } <ins> func (p *glusterfsVolumeProvisioner) createEndpointService(namespace string, epServiceName string, hostips []string, pvcname string) (endpoint *v1.Endpoints, service *v1.Service, err error) { addrlist := make([]v1.EndpointAddress, len(hostips)) for i, v := range hostips { addrlist[i].IP = v } endpoint = &v1.Endpoints{ ObjectMeta: metav1.ObjectMeta{ Namespace: namespace, Name:      epServiceName, Labels: map[string]string{ \"gluster.kubernetes.io/provisioned-for-pvc\": pvcname, }, }, Subsets: []v1.EndpointSubset{{ Addresses: addrlist, Ports:     []v1.EndpointPort{{Port: 1, Protocol: \"TCP\"}}, }}, } kubeClient := p.plugin.host.GetKubeClient() if kubeClient == nil { return nil, nil, fmt.Errorf(\"glusterfs: failed to get kube client when creating endpoint service\") } _, err = kubeClient.Core().Endpoints(namespace).Create(endpoint) if err != nil && errors.IsAlreadyExists(err) { glog.V(1).Infof(\"glusterfs: endpoint [%s] already exist in namespace [%s]\", endpoint, namespace) err = nil } if err != nil { glog.Errorf(\"glusterfs: failed to create endpoint: %v\", err) return nil, nil, fmt.Errorf(\"error creating endpoint: %v\", err) } service = &v1.Service{ ObjectMeta: metav1.ObjectMeta{ Name:      epServiceName, Namespace: namespace, Labels: map[string]string{ \"gluster.kubernetes.io/provisioned-for-pvc\": pvcname, }, }, Spec: v1.ServiceSpec{ Ports: []v1.ServicePort{ {Protocol: \"TCP\", Port: 1}}}} _, err = kubeClient.Core().Services(namespace).Create(service) if err != nil && errors.IsAlreadyExists(err) { glog.V(1).Infof(\"glusterfs: service [%s] already exist in namespace [%s]\", service, namespace) err = nil } if err != nil { glog.Errorf(\"glusterfs: failed to create service: %v\", err) return nil, nil, fmt.Errorf(\"error creating service: %v\", err) } return endpoint, service, nil } func (d *glusterfsVolumeDeleter) deleteEndpointService(namespace string, epServiceName string) (err error) { kubeClient := d.plugin.host.GetKubeClient() if kubeClient == nil { return fmt.Errorf(\"glusterfs: failed to get kube client when deleting endpoint service\") } err = kubeClient.Core().Services(namespace).Delete(epServiceName, nil) if err != nil { glog.Errorf(\"glusterfs: error deleting service %s/%s: %v\", namespace, epServiceName, err) return fmt.Errorf(\"error deleting service %s/%s: %v\", namespace, epServiceName, err) } glog.V(1).Infof(\"glusterfs: service/endpoint %s/%s deleted successfully\", namespace, epServiceName) return nil } </ins> // parseSecret finds a given Secret instance and reads user password from it. func parseSecret(namespace, secretName string, kubeClient clientset.Interface) (string, error) { secretMap, err := volutil.GetSecretForPV(namespace, secretName, glusterfsPluginName, kubeClient)", "commid": "kubernetes_pr_47726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07d743f275589dc899f72f61b7bb720b2610d6e1babb36a1a07c597b266bdaf8", "query": "several operations to the glusterfs mount operation that nodes are not permitted to perform: looks up arbitrary secrets based on storage class parameters. this will not succeed, as the node authorizer will only allow nodes access to secrets referenced by pods or persistent volumes used by the node attempts to create a service and endpoint using the node's API client. nodes do not have permission to create arbitrary endpoints and services. For both of those reasons, that recreate operation will fail when attempted from the node. The recreate operation should probably move to one of the storage-related controllers (provisioner or attach/detach) cc\nMarking this with 1.7 milestone until we have a better idea of whether this is blocking or not for the 1.7 release.\nCC Is the endpoint originally created by the user or by the volume plugin creating/deleting Endpoint objects? In addition to the concerns raised, having a volume create new API objects seems like a bad idea (abstraction layer violation?).\nFrom on Slack: Unless there is justification otherwise, I will roll back the PR on Monday.\ncc/\nrevert button doesn't work, have to do it manually\nRevert PR is approved and awaiting merge (). Once that merges this issue can be closed.\nOpened an E2E pr to catch this kind of behavior in the future. WIP, still exploring a method to reproduce and catch the behavior.", "positive_passages": [{"docid": "doc-en-kubernetes-228e05814cf2aad90801badf92dc3782de1c25074b273c830fdd4acd721611cf", "text": "return &cfg, nil } <del> // getClusterNodes() returns the cluster nodes of a given cluster func getClusterNodes(cli *gcli.Client, cluster string) (dynamicHostIps []string, err error) { clusterinfo, err := cli.ClusterInfo(cluster) if err != nil { glog.Errorf(\"glusterfs: failed to get cluster details: %v\", err) return nil, fmt.Errorf(\"failed to get cluster details: %v\", err) } // For the dynamically provisioned volume, we gather the list of node IPs // of the cluster on which provisioned volume belongs to, as there can be multiple // clusters. for _, node := range clusterinfo.Nodes { nodei, err := cli.NodeInfo(string(node)) if err != nil { glog.Errorf(\"glusterfs: failed to get hostip: %v\", err) return nil, fmt.Errorf(\"failed to get hostip: %v\", err) } ipaddr := dstrings.Join(nodei.NodeAddRequest.Hostnames.Storage, \"\") dynamicHostIps = append(dynamicHostIps, ipaddr) } glog.V(3).Infof(\"glusterfs: hostlist :%v\", dynamicHostIps) if len(dynamicHostIps) == 0 { glog.Errorf(\"glusterfs: no hosts found: %v\", err) return nil, fmt.Errorf(\"no hosts found: %v\", err) } return dynamicHostIps, nil } </del>", "commid": "kubernetes_pr_47726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bc5dc487097ca8e1afb5b49dfc6335c039b52302e29bce4de3d1449afeaae0f6", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see ): No What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): local-up- Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: KVM OS (e.g. from /etc/os-release): fedora 25 Kernel (e.g. ): uname -a Linux k8sbuild-master 4.11.3-200.fc25.x8664 SMP Thu May 25 19:03:07 UTC 2017 x8664 x8664 x8664 GNU/Linux Install tools: Others: What happened: local-up- fails to create kube-dns and StorageClass. What you expected to happen: local-up- is successfully executed. How to reproduce it (as minimally and precisely as possible): 1) Clone kubernetes from master branch 2) run local-up- $ export ENABLEHOSTPATHPROVISIONER=\"true\"; ./hack/local-up- If you already have kubernetes , try this 1) make cleanmeta 2) run local-up- $ export ENABLEHOSTPATHPROVISIONER=\"true\"; ./hack/local-up- Anything else we need to know: I think this problem is timing issue because sleeping 3 seconds before startkubedns can avoid this problem.\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\n/sig testing /sig storage /sig network\n/sig apps\nI met the same issue we should add a function to check if all api-versions are up", "positive_passages": [{"docid": "doc-en-kubernetes-71699812004e0e9dee6d6091470567e6c87562fe68a9c605d1b97f7f0ea88444", "text": "DNS_SERVER_IP=${KUBE_DNS_SERVER_IP:-10.0.0.10} DNS_DOMAIN=${KUBE_DNS_NAME:-\"cluster.local\"} KUBECTL=${KUBECTL:-cluster/kubectl.sh} <del> WAIT_FOR_URL_API_SERVER=${WAIT_FOR_URL_API_SERVER:-10} </del> <ins> WAIT_FOR_URL_API_SERVER=${WAIT_FOR_URL_API_SERVER:-20} </ins> ENABLE_DAEMON=${ENABLE_DAEMON:-false} HOSTNAME_OVERRIDE=${HOSTNAME_OVERRIDE:-\"127.0.0.1\"} CLOUD_PROVIDER=${CLOUD_PROVIDER:-\"\"}", "commid": "kubernetes_pr_49072"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bc5dc487097ca8e1afb5b49dfc6335c039b52302e29bce4de3d1449afeaae0f6", "query": "<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see ): No What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): local-up- Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): Environment: Cloud provider or hardware configuration: KVM OS (e.g. from /etc/os-release): fedora 25 Kernel (e.g. ): uname -a Linux k8sbuild-master 4.11.3-200.fc25.x8664 SMP Thu May 25 19:03:07 UTC 2017 x8664 x8664 x8664 GNU/Linux Install tools: Others: What happened: local-up- fails to create kube-dns and StorageClass. What you expected to happen: local-up- is successfully executed. How to reproduce it (as minimally and precisely as possible): 1) Clone kubernetes from master branch 2) run local-up- $ export ENABLEHOSTPATHPROVISIONER=\"true\"; ./hack/local-up- If you already have kubernetes , try this 1) make cleanmeta 2) run local-up- $ export ENABLEHOSTPATHPROVISIONER=\"true\"; ./hack/local-up- Anything else we need to know: I think this problem is timing issue because sleeping 3 seconds before startkubedns can avoid this problem.\nThere are no sig labels on this issue. Please by:<br(1) mentioning a sig: <br(2) specifying the label manually: <br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list\n/sig testing /sig storage /sig network\n/sig apps\nI met the same issue we should add a function to check if all api-versions are up", "positive_passages": [{"docid": "doc-en-kubernetes-4fc7ae07d00085597d24b0d1e36ebb22b4636f5f5a53029fa25a34356a909f13", "text": "# this uses the API port because if you don't have any authenticator, you can't seem to use the secure port at all. # this matches what happened with the combination in 1.4. # TODO change this conditionally based on whether API_PORT is on or off <del> kube::util::wait_for_url \"http://${API_HOST_IP}:${API_SECURE_PORT}/healthz\" \"apiserver: \" 1 ${WAIT_FOR_URL_API_SERVER}  </del> <ins> kube::util::wait_for_url \"https://${API_HOST_IP}:${API_SECURE_PORT}/healthz\" \"apiserver: \" 1 ${WAIT_FOR_URL_API_SERVER}  </ins> || { echo \"check apiserver logs: ${APISERVER_LOG}\" ; exit 1 ; } # Create kubeconfigs for all components, using client certs", "commid": "kubernetes_pr_49072"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-efc4d6f641fd1b1bcaa275636a136a6176382b556456e87b10de85fb3c9c026d", "query": "Every time watch is reset, event exporter exports an entry about it to Stackdriver. To make it less irritating, this has to be done once per container run Related image PR: /cc", "positive_passages": [{"docid": "doc-en-kubernetes-a24a1710fcb2dc466c7a3362f9bcf2083c53845ac798b6f81789583b9875d525", "text": "apiVersion: apps/v1beta1 kind: Deployment metadata: <del> name: event-exporter-v0.1.0 </del> <ins> name: event-exporter-v0.1.4 </ins> namespace: kube-system labels: k8s-app: event-exporter", "commid": "kubernetes_pr_47915"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-efc4d6f641fd1b1bcaa275636a136a6176382b556456e87b10de85fb3c9c026d", "query": "Every time watch is reset, event exporter exports an entry about it to Stackdriver. To make it less irritating, this has to be done once per container run Related image PR: /cc", "positive_passages": [{"docid": "doc-en-kubernetes-6a1b0872dab68d089605077754a375404f032cef3d97587b961f0aee741c4b5d", "text": "containers: # TODO: Add resources in 1.8 - name: event-exporter <del> image: gcr.io/google-containers/event-exporter:v0.1.0-r2 </del> <ins> image: gcr.io/google-containers/event-exporter:v0.1.4 </ins> command: - '/event-exporter' - name: prometheus-to-sd-exporter", "commid": "kubernetes_pr_48712"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-30aaf5a2ce7eb6db27689d060ddcaf85253c0ae07b0503c963889141615172e9", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: If node is unreachable, NodeController only set , , to unknown; it's better to also set NetworkUnavailable & InodePressure to unknown.\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig node\nIsn't a known condition if node is unreachable?\nis the status of container, e.g. CNI is not ready. If node is unreachable, it should be Unknown.\nThanks for explanation!\nwill not set NetworkUnavailable & InodePressure to unknown, refer to .", "positive_passages": [{"docid": "doc-en-kubernetes-ef26f3e4b06449df6ceea29cd2aa9fede26d3c2f30d0e02cd3baa58abb3061f8", "text": "} } <del> // For a given node checks its conditions and tries to update it. Returns grace period to which given node // is entitled, state of current and last observed Ready Condition, and an error if it occurred. </del> <ins> // tryUpdateNodeStatus checks a given node's conditions and tries to update it. Returns grace period to // which given node is entitled, state of current and last observed Ready Condition, and an error if it occurred. </ins> func (nc *NodeController) tryUpdateNodeStatus(node *v1.Node) (time.Duration, v1.NodeCondition, *v1.NodeCondition, error) { var err error var gracePeriod time.Duration", "commid": "kubernetes_pr_48983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-30aaf5a2ce7eb6db27689d060ddcaf85253c0ae07b0503c963889141615172e9", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: If node is unreachable, NodeController only set , , to unknown; it's better to also set NetworkUnavailable & InodePressure to unknown.\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig node\nIsn't a known condition if node is unreachable?\nis the status of container, e.g. CNI is not ready. If node is unreachable, it should be Unknown.\nThanks for explanation!\nwill not set NetworkUnavailable & InodePressure to unknown, refer to .", "positive_passages": [{"docid": "doc-en-kubernetes-75e524eaab1877659566fab24cb7633e6cad40c6dcbff1d2d8b918820124b8fe", "text": "// otherwise we leave it as it is. if savedCondition.LastTransitionTime != observedCondition.LastTransitionTime { glog.V(3).Infof(\"ReadyCondition for Node %s transitioned from %v to %v\", node.Name, savedCondition.Status, observedCondition) transitionTime = nc.now() } else { transitionTime = savedNodeStatus.readyTransitionTimestamp", "commid": "kubernetes_pr_48983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-30aaf5a2ce7eb6db27689d060ddcaf85253c0ae07b0503c963889141615172e9", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: If node is unreachable, NodeController only set , , to unknown; it's better to also set NetworkUnavailable & InodePressure to unknown.\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig node\nIsn't a known condition if node is unreachable?\nis the status of container, e.g. CNI is not ready. If node is unreachable, it should be Unknown.\nThanks for explanation!\nwill not set NetworkUnavailable & InodePressure to unknown, refer to .", "positive_passages": [{"docid": "doc-en-kubernetes-032f6f1ef48e3ec85e0a958ac5e1bc08c5bfa953a08df0b7d9b79cb327ec4efb", "text": "} // remaining node conditions should also be set to Unknown <del> remainingNodeConditionTypes := []v1.NodeConditionType{v1.NodeOutOfDisk, v1.NodeMemoryPressure, v1.NodeDiskPressure} </del> <ins> remainingNodeConditionTypes := []v1.NodeConditionType{ v1.NodeOutOfDisk, v1.NodeMemoryPressure, v1.NodeDiskPressure, // We don't change 'NodeInodePressure' condition, as it'll be removed in future. // v1.NodeInodePressure, // We don't change 'NodeNetworkUnavailable' condition, as it's managed on a control plane level. // v1.NodeNetworkUnavailable, } </ins> nowTimestamp := nc.now() for _, nodeConditionType := range remainingNodeConditionTypes { _, currentCondition := nodeutil.GetNodeCondition(&node.Status, nodeConditionType)", "commid": "kubernetes_pr_48983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-30aaf5a2ce7eb6db27689d060ddcaf85253c0ae07b0503c963889141615172e9", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: If node is unreachable, NodeController only set , , to unknown; it's better to also set NetworkUnavailable & InodePressure to unknown.\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig node\nIsn't a known condition if node is unreachable?\nis the status of container, e.g. CNI is not ready. If node is unreachable, it should be Unknown.\nThanks for explanation!\nwill not set NetworkUnavailable & InodePressure to unknown, refer to .", "positive_passages": [{"docid": "doc-en-kubernetes-017e8174cf0fd099a501457935f1fd4e47ce116d6eff109d47b2bc248a9e2a5e", "text": "return 0 } <del> // This function is expected to get a slice of NodeReadyConditions for all Nodes in a given zone. </del> <ins> // ComputeZoneState returns a slice of NodeReadyConditions for all Nodes in a given zone. </ins> // The zone is considered: // - fullyDisrupted if there're no Ready Nodes, // - partiallyDisrupted if at least than nc.unhealthyZoneThreshold percent of Nodes are not Ready,", "commid": "kubernetes_pr_48983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1dc2549ac0119567f8fdbad5a90f42a3a48bc3f10a1848651b920c883c2c8bd8", "query": "There's a problem b/c pods are created to run on all nodes, but run sequentially, effectively multiplying testing time", "positive_passages": [{"docid": "doc-en-kubernetes-a81c381b3a4d3137bc09a23c89a41d26c4c9389a9d6bc933a0dbfa71cbb51141", "text": "\"math\" \"time\" <del> meta_v1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" </del> \"k8s.io/kubernetes/test/e2e/framework\" \"k8s.io/kubernetes/test/e2e/instrumentation\"", "commid": "kubernetes_pr_49013"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1dc2549ac0119567f8fdbad5a90f42a3a48bc3f10a1848651b920c883c2c8bd8", "query": "There's a problem b/c pods are created to run on all nodes, but run sequentially, effectively multiplying testing time", "positive_passages": [{"docid": "doc-en-kubernetes-29a5b0d39e30d5c6ac636391bd0b18c93ea05fabb72f7af7dfe0774ec76c4b2b", "text": "nodes := framework.GetReadySchedulableNodesOrDie(f.ClientSet).Items maxPodCount := 10 <del> jobDuration := 1 * time.Hour </del> <ins> jobDuration := 30 * time.Minute </ins> linesPerPodPerSecond := 100 <del> testDuration := 21 * time.Hour </del> <ins> // TODO(crassirostris): Increase to 21 hrs testDuration := 3 * time.Hour </ins> ingestionTimeout := testDuration + 30*time.Minute allowedRestarts := int(math.Ceil(float64(testDuration) / float64(time.Hour) * maxAllowedRestartsPerHour))", "commid": "kubernetes_pr_49013"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1dc2549ac0119567f8fdbad5a90f42a3a48bc3f10a1848651b920c883c2c8bd8", "query": "There's a problem b/c pods are created to run on all nodes, but run sequentially, effectively multiplying testing time", "positive_passages": [{"docid": "doc-en-kubernetes-81c670719f03800a4973bde84fb889bd2326b190b8ed48e9a0f482463ec392dd", "text": "podRunCount := maxPodCount*(int(testDuration/jobDuration)-1) + 1 linesPerPod := linesPerPodPerSecond * int(jobDuration.Seconds()) <ins> // pods is a flat array of all pods to be run and to expect in Stackdriver. </ins> pods := []*loggingPod{} <ins> // podsByRun is a two-dimensional array of pods, first dimension is the run // index, the second dimension is the node index. Since we want to create // an equal load on all nodes, for the same run we have one pod per node. podsByRun := [][]*loggingPod{} </ins> for runIdx := 0; runIdx < podRunCount; runIdx++ { <ins> podsInRun := []*loggingPod{} </ins> for nodeIdx, node := range nodes { podName := fmt.Sprintf(\"job-logs-generator-%d-%d-%d-%d\", maxPodCount, linesPerPod, runIdx, nodeIdx) <del> pods = append(pods, newLoggingPod(podName, node.Name, linesPerPod, jobDuration)) </del> <ins> pod := newLoggingPod(podName, node.Name, linesPerPod, jobDuration) pods = append(pods, pod) podsInRun = append(podsInRun, pod) </ins> } <ins> podsByRun = append(podsByRun, podsInRun) </ins> } By(\"Running short-living pods\") go func() { <del> for _, pod := range pods { pod.Start(f) </del> <ins> for runIdx := 0; runIdx < podRunCount; runIdx++ { // Starting one pod on each node. for _, pod := range podsByRun[runIdx] { pod.Start(f) } </ins> time.Sleep(podRunDelay) <del> defer f.PodClient().Delete(pod.Name, &meta_v1.DeleteOptions{}) </del> } // Waiting until the last pod has completed time.Sleep(jobDuration - podRunDelay + lastPodIngestionSlack)", "commid": "kubernetes_pr_49013"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b79d32e7a321057d32fcaee893eb22ae1c074b6d42568816fe8e5690a6d0ee49", "query": "/kind bug What happened: A pod with an empty namespace field was mutated by a pod preset in a different namespace. What you expected to happen: Pod presets should only operate on pods in the same namespace. How to reproduce it (as minimally and precisely as possible): Submit a pod with an empty namespace field and observe pod preset mutation. Anything else we need to know?: This is a fix for an alpha non-default feature. Fix submitted in\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig api-machinery", "positive_passages": [{"docid": "doc-en-kubernetes-19950dcdb18bb7795f2b29a1c22669059b7e58f1de0ba90164ec95531ad2572a", "text": "return nil } <del> list, err := c.lister.PodPresets(pod.GetNamespace()).List(labels.Everything()) </del> <ins> list, err := c.lister.PodPresets(a.GetNamespace()).List(labels.Everything()) </ins> // Ignore if exclusion annotation is present if podAnnotations := pod.GetAnnotations(); podAnnotations != nil {", "commid": "kubernetes_pr_49120"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b79d32e7a321057d32fcaee893eb22ae1c074b6d42568816fe8e5690a6d0ee49", "query": "/kind bug What happened: A pod with an empty namespace field was mutated by a pod preset in a different namespace. What you expected to happen: Pod presets should only operate on pods in the same namespace. How to reproduce it (as minimally and precisely as possible): Submit a pod with an empty namespace field and observe pod preset mutation. Anything else we need to know?: This is a fix for an alpha non-default feature. Fix submitted in\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig api-machinery", "positive_passages": [{"docid": "doc-en-kubernetes-b64027a45e12b27607cb788153d3122afd9f6dba4e924b314f58ab1a6dacc3d0", "text": "} } <ins> func TestAdmitEmptyPodNamespace(t *testing.T) { containerName := \"container\" pod := &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: \"mypod\", Labels: map[string]string{ \"security\": \"S2\", }, }, Spec: api.PodSpec{ Containers: []api.Container{ { Name: containerName, Env:  []api.EnvVar{{Name: \"abc\", Value: \"value2\"}, {Name: \"ABCD\", Value: \"value3\"}}, }, }, }, } pip := &settings.PodPreset{ ObjectMeta: v1.ObjectMeta{ Name:      \"hello\", Namespace: \"different\", // (pod will be submitted to namespace 'namespace') }, Spec: settings.PodPresetSpec{ Selector: v1.LabelSelector{ MatchExpressions: []v1.LabelSelectorRequirement{ { Key:      \"security\", Operator: v1.LabelSelectorOpIn, Values:   []string{\"S2\"}, }, }, }, Volumes: []api.Volume{{Name: \"vol\", VolumeSource: api.VolumeSource{EmptyDir: &api.EmptyDirVolumeSource{}}}}, Env:     []api.EnvVar{{Name: \"abcd\", Value: \"value\"}, {Name: \"ABC\", Value: \"value\"}}, EnvFrom: []api.EnvFromSource{ { ConfigMapRef: &api.ConfigMapEnvSource{ LocalObjectReference: api.LocalObjectReference{Name: \"abc\"}, }, }, { Prefix: \"pre_\", ConfigMapRef: &api.ConfigMapEnvSource{ LocalObjectReference: api.LocalObjectReference{Name: \"abc\"}, }, }, }, }, } originalPod, err := api.Scheme.Copy(pod) if err != nil { t.Fatal(err) } err = admitPod(pod, pip) if err != nil { t.Fatal(err) } // verify PodSpec has not been mutated if !reflect.DeepEqual(pod, originalPod) { t.Fatalf(\"Expected pod spec of '%v' to be unchanged\", pod.Name) } } </ins> func admitPod(pod *api.Pod, pip *settings.PodPreset) error { informerFactory := informers.NewSharedInformerFactory(nil, controller.NoResyncPeriodFunc()) store := informerFactory.Settings().InternalVersion().PodPresets().Informer().GetStore()", "commid": "kubernetes_pr_49120"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cc9a90a08712a5d452773e568c5f455ca56f11e72f82f403f33b02eda765f73c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When trying to list object using field spec.SchedulerName, we are getting the below error message. Failed to list : field label not supported: spec.schedulerName What you expected to happen: To be able to fetch pods using the list and watch based on the field 'spec.schedulerName' How to reproduce it (as minimally and precisely as possible): Create a simple controller to with a list and watch method. Set the FieldSelector ( in the ListOptions structure ) in the ListFunc and the WatchFunc to 'spec.SchedulerName=custome-SchedulerName' Running this controller yields the above error. Anything else we need to know?: Description: Unable to fetch pods based on the field 'spec.schedulerName'. This was in 1.6 version, for multi scheduler support in kubernetes. We need to be able to fetch pods 1) Assigned to a particular custom scheduler. 2) Should be able to fetch the state transition of the pods scheduled by a custom scheduler using the fields selector. Whats the correct way to use 'schedulerName' fields for fetching objects? Or is there any other way for the custom scheduler to determine the above information from the kubernetes? This is an urgent issue, any quick help/suggestion will be of great help. Environment: Kubernetes version : Client Version: version.Info{Major:\"1\", Minor:\"7\", GitVersion:\"v1.7.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-06-29T23:15:59Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"7\", GitVersion:\"v1.7.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-07-14T01:48:01Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Install tools: kubeadm\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig api-machinery\n/cc\ncc\nSIG API Machinery doesn't own the contents of the API--we only need to be involved if the mechanism needs to be general.\nGiven the error message mentioned in the bug report at the top of this thread, do you have a suggestion of what we forgot to do when we the SchedulerName field to the PodSpec? i.e. to enable field selection on the schedulerName field?\n/cc me", "positive_passages": [{"docid": "doc-en-kubernetes-bd1cfc54022e025b37d4c7aa0c024ab27b9e75d48b9e87501a7813d3f8ef160a", "text": "\"spec.nodeName\", \"spec.restartPolicy\", \"spec.serviceAccountName\", <ins> \"spec.schedulerName\", </ins> \"status.phase\", \"status.hostIP\", \"status.podIP\":", "commid": "kubernetes_pr_50582"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cc9a90a08712a5d452773e568c5f455ca56f11e72f82f403f33b02eda765f73c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When trying to list object using field spec.SchedulerName, we are getting the below error message. Failed to list : field label not supported: spec.schedulerName What you expected to happen: To be able to fetch pods using the list and watch based on the field 'spec.schedulerName' How to reproduce it (as minimally and precisely as possible): Create a simple controller to with a list and watch method. Set the FieldSelector ( in the ListOptions structure ) in the ListFunc and the WatchFunc to 'spec.SchedulerName=custome-SchedulerName' Running this controller yields the above error. Anything else we need to know?: Description: Unable to fetch pods based on the field 'spec.schedulerName'. This was in 1.6 version, for multi scheduler support in kubernetes. We need to be able to fetch pods 1) Assigned to a particular custom scheduler. 2) Should be able to fetch the state transition of the pods scheduled by a custom scheduler using the fields selector. Whats the correct way to use 'schedulerName' fields for fetching objects? Or is there any other way for the custom scheduler to determine the above information from the kubernetes? This is an urgent issue, any quick help/suggestion will be of great help. Environment: Kubernetes version : Client Version: version.Info{Major:\"1\", Minor:\"7\", GitVersion:\"v1.7.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-06-29T23:15:59Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"7\", GitVersion:\"v1.7.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-07-14T01:48:01Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Install tools: kubeadm\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig api-machinery\n/cc\ncc\nSIG API Machinery doesn't own the contents of the API--we only need to be involved if the mechanism needs to be general.\nGiven the error message mentioned in the bug report at the top of this thread, do you have a suggestion of what we forgot to do when we the SchedulerName field to the PodSpec? i.e. to enable field selection on the schedulerName field?\n/cc me", "positive_passages": [{"docid": "doc-en-kubernetes-c22f1a23145b81cfcb81d1405cca297044a40d8f7c476063bc9497cba43505c9", "text": "// amount of allocations needed to create the fields.Set. If you add any // field here or the number of object-meta related fields changes, this should // be adjusted. <del> podSpecificFieldsSet := make(fields.Set, 6) </del> <ins> podSpecificFieldsSet := make(fields.Set, 7) </ins> podSpecificFieldsSet[\"spec.nodeName\"] = pod.Spec.NodeName podSpecificFieldsSet[\"spec.restartPolicy\"] = string(pod.Spec.RestartPolicy) <ins> podSpecificFieldsSet[\"spec.schedulerName\"] = string(pod.Spec.SchedulerName) </ins> podSpecificFieldsSet[\"status.phase\"] = string(pod.Status.Phase) podSpecificFieldsSet[\"status.podIP\"] = string(pod.Status.PodIP) return generic.AddObjectMetaFieldsSet(podSpecificFieldsSet, &pod.ObjectMeta, true)", "commid": "kubernetes_pr_50582"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cc9a90a08712a5d452773e568c5f455ca56f11e72f82f403f33b02eda765f73c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When trying to list object using field spec.SchedulerName, we are getting the below error message. Failed to list : field label not supported: spec.schedulerName What you expected to happen: To be able to fetch pods using the list and watch based on the field 'spec.schedulerName' How to reproduce it (as minimally and precisely as possible): Create a simple controller to with a list and watch method. Set the FieldSelector ( in the ListOptions structure ) in the ListFunc and the WatchFunc to 'spec.SchedulerName=custome-SchedulerName' Running this controller yields the above error. Anything else we need to know?: Description: Unable to fetch pods based on the field 'spec.schedulerName'. This was in 1.6 version, for multi scheduler support in kubernetes. We need to be able to fetch pods 1) Assigned to a particular custom scheduler. 2) Should be able to fetch the state transition of the pods scheduled by a custom scheduler using the fields selector. Whats the correct way to use 'schedulerName' fields for fetching objects? Or is there any other way for the custom scheduler to determine the above information from the kubernetes? This is an urgent issue, any quick help/suggestion will be of great help. Environment: Kubernetes version : Client Version: version.Info{Major:\"1\", Minor:\"7\", GitVersion:\"v1.7.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-06-29T23:15:59Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"7\", GitVersion:\"v1.7.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-07-14T01:48:01Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Install tools: kubeadm\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig api-machinery\n/cc\ncc\nSIG API Machinery doesn't own the contents of the API--we only need to be involved if the mechanism needs to be general.\nGiven the error message mentioned in the bug report at the top of this thread, do you have a suggestion of what we forgot to do when we the SchedulerName field to the PodSpec? i.e. to enable field selection on the schedulerName field?\n/cc me", "positive_passages": [{"docid": "doc-en-kubernetes-06164a6bdc966227b908e623a1f610425cf7d433dbbe1e4a689cdbd65ee8ee10", "text": "}, { in: &api.Pod{ <ins> Spec: api.PodSpec{SchedulerName: \"scheduler1\"}, }, fieldSelector: fields.ParseSelectorOrDie(\"spec.schedulerName=scheduler1\"), expectMatch:   true, }, { in: &api.Pod{ Spec: api.PodSpec{SchedulerName: \"scheduler1\"}, }, fieldSelector: fields.ParseSelectorOrDie(\"spec.schedulerName=scheduler2\"), expectMatch:   false, }, { in: &api.Pod{ </ins> Status: api.PodStatus{Phase: api.PodRunning}, }, fieldSelector: fields.ParseSelectorOrDie(\"status.phase=Running\"),", "commid": "kubernetes_pr_50582"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d84f225075f0f84856b63395873a83aaf5523b5813df96adeb3ab8300018cf9a", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug /sig storage What happened: Offshoot of . Let's change the tests to use the programmatic API instead of gcloud CLI.\nJust confirming that this issue is referring only to the 3 gcloud CLI calls in\nyup\nPR:", "positive_passages": [{"docid": "doc-en-kubernetes-ea6d74c31fc73e46067a575369032db99eb763ea3ee10151703df3044ea4cdee", "text": "return zones, nil } <ins> // ListInstanceNames returns a string of instance names seperated by spaces. func (gce *GCECloud) ListInstanceNames(project, zone string) (string, error) { res, err := gce.service.Instances.List(project, zone).Fields(\"items(name)\").Do() if err != nil { return \"\", err } var output string for _, item := range res.Items { output += item.Name + \" \" } return output, nil } // DeleteInstance deletes an instance specified by project, zone, and name func (gce *GCECloud) DeleteInstance(project, zone, name string) (*compute.Operation, error) { return gce.service.Instances.Delete(project, zone, name).Do() } </ins> // Implementation of Instances.CurrentNodeName func (gce *GCECloud) CurrentNodeName(hostname string) (types.NodeName, error) { return types.NodeName(hostname), nil", "commid": "kubernetes_pr_51809"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d84f225075f0f84856b63395873a83aaf5523b5813df96adeb3ab8300018cf9a", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug /sig storage What happened: Offshoot of . Let's change the tests to use the programmatic API instead of gcloud CLI.\nJust confirming that this issue is referring only to the 3 gcloud CLI calls in\nyup\nPR:", "positive_passages": [{"docid": "doc-en-kubernetes-a31ca3d92b89ecee20b6ee5d5b44ffa728c6cf5e7c0bf870fd7e590718376f1a", "text": "import ( \"fmt\" mathrand \"math/rand\" <del> \"os/exec\" </del> \"strings\" \"time\"", "commid": "kubernetes_pr_51809"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d84f225075f0f84856b63395873a83aaf5523b5813df96adeb3ab8300018cf9a", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug /sig storage What happened: Offshoot of . Let's change the tests to use the programmatic API instead of gcloud CLI.\nJust confirming that this issue is referring only to the 3 gcloud CLI calls in\nyup\nPR:", "positive_passages": [{"docid": "doc-en-kubernetes-2c0f79813cf984ea5bd75067b8de08b3a6bd1dfa096fc7550d391c4853760124", "text": "// Verify that disk shows up in node 0's volumeInUse list framework.ExpectNoError(waitForPDInVolumesInUse(nodeClient, diskName, host0Name, nodeStatusTimeout, true /* should exist*/)) <del> output, err := exec.Command(\"gcloud\", \"compute\", \"instances\", \"list\", \"--project=\"+framework.TestContext.CloudConfig.ProjectID).CombinedOutput() </del> <ins> gceCloud, err := framework.GetGCECloud() framework.ExpectNoError(err, fmt.Sprintf(\"Unable to create gcloud client err=%v\", err)) output, err := gceCloud.ListInstanceNames(framework.TestContext.CloudConfig.ProjectID, framework.TestContext.CloudConfig.Zone) </ins> framework.ExpectNoError(err, fmt.Sprintf(\"Unable to get list of node instances err=%v output=%s\", err, output)) Expect(true, strings.Contains(string(output), string(host0Name))) By(\"deleting host0\") <ins> resp, err := gceCloud.DeleteInstance(framework.TestContext.CloudConfig.ProjectID, framework.TestContext.CloudConfig.Zone, string(host0Name)) framework.ExpectNoError(err, fmt.Sprintf(\"Failed to delete host0pod: err=%v response=%#v\", err, resp)) </ins> <del> output, err = exec.Command(\"gcloud\", \"compute\", \"instances\", \"delete\", string(host0Name), \"--project=\"+framework.TestContext.CloudConfig.ProjectID, \"--zone=\"+framework.TestContext.CloudConfig.Zone).CombinedOutput() framework.ExpectNoError(err, fmt.Sprintf(\"Failed to delete host0pod: err=%v output=%s\", err, output)) output, err = exec.Command(\"gcloud\", \"compute\", \"instances\", \"list\", \"--project=\"+framework.TestContext.CloudConfig.ProjectID).CombinedOutput() </del> <ins> output, err = gceCloud.ListInstanceNames(framework.TestContext.CloudConfig.ProjectID, framework.TestContext.CloudConfig.Zone) </ins> framework.ExpectNoError(err, fmt.Sprintf(\"Unable to get list of node instances err=%v output=%s\", err, output)) Expect(false, strings.Contains(string(output), string(host0Name)))", "commid": "kubernetes_pr_51809"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7ea6a0d142494ff2b4ab87c8d729fbcd3c1faf2bb0e5c24469e589e79da71312", "query": "Seeing flakes on master: https://k8s- https://k8s- and on unrelated PRs: https://k8s-\nI was able to reproduce this locally (although it's very hard to trigger). Initial thoughts are that it's different from ; in this case, the actual sync is instant (millseconds) but the CRD created in the test fails to appear in discovery calls over the course of repeated attempts every 5 seconds for the remainder of the test. Normally, the type shows up in discovery almost immediately after creation.\nLooks like PR might be hitting a related flaky test. I get 6 failures in 60 runs from the command I'm super new around here so thought it prudent to add the information I have found before attempting to dig deeper. I followed instructions in to build from within directory If the test failure logs are of any use to anyone just message and I'll post one of them.\nThanks. I've also been able to reproduce locally and am debugging it today. I did have to hack up the integration test setup to get apiserver logs in this context. I've also opened to explore making the integration test script more configurable with regards to logging.\nI was wrong about the discovery aspect; the CRD is coming back from discovery, but the restMapper fails to map it. I also notice we're using DiscoveryInterface.ServerPreferredResources which is not actually implemented with a cache in memCacheClient.\nokay, now I'm getting somewhere. I made a which exercises discovery and REST mapping without the GC in the picture at all, and have been able to reproduce the flake 1 time out of 40 runs so far with .\nFirst problem is pretty clear in hindsight; we reset the restmapper, then get deletable resources using the discovery client directly, then sync based on the resources from discovery. The direct discovery call doesn't use the client's internal cache, and so the restmapper might be out of sync with the subsequent discovery call, causing us to sync with resources not yet represented in the restmapper's cache. That explains the isolated flake in the test I made, but doesn't yet explain why the restmapper would continue to fail on subsequent sync calls (since the nest restmapper reset would usually bring it up to date with the resources returned from the direct discovery call).\nI'm out tomorrow, so a quick update here in case somebody else looks into it... can reproduce the issue where DeferredDiscoveryRESTMapper sometimes becomes unable to map the CRD resource, even after the type is available from discovery. I've also ruled out the memCacheClient by replacing it with a non-caching implementation like: And using that in the setup like: The issue can still be reproduced that way. Looks like more debugging of DeferredDiscoveryRESTMapper itself is required.\nFinally tracked this down. Custom resource kinds are always given a plural suffix of \"s\". If the singular name ends in \"s\", the assumes the plural form is an \"es\" suffix, which will never match the generated kind. This explains the intermittent nature of the failure (the randomly generated names often happen to match the assumptions of the rest mapper).\nis the root cause\nGood effort", "positive_passages": [{"docid": "doc-en-kubernetes-10e1cbb6f4c9c7bc01dde93ca17e7bc3e9d98d89cfe242388bee7745a5f6c14b", "text": "//NewRandomNameCustomResourceDefinition generates a CRD with random name to avoid name conflict in e2e tests func NewRandomNameCustomResourceDefinition(scope apiextensionsv1beta1.ResourceScope) *apiextensionsv1beta1.CustomResourceDefinition { <del> gName := names.SimpleNameGenerator.GenerateName(\"foo\") </del> <ins> // ensure the singular doesn't end in an s for now gName := names.SimpleNameGenerator.GenerateName(\"foo\") + \"a\" </ins> return &apiextensionsv1beta1.CustomResourceDefinition{ ObjectMeta: metav1.ObjectMeta{Name: gName + \"s.mygroup.example.com\"}, Spec: apiextensionsv1beta1.CustomResourceDefinitionSpec{", "commid": "kubernetes_pr_50291"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9101ad393fb6a2a33b8bfb776eef50d2cb2916deea96a521a370ed1fc49f445a", "query": "In Cinder cloud provider openstack Inside of AttachDisk function, it issues DetachDisk if it find out the the volume is currently attached to a different instance. This is very dangerous because it is very likely the volume is still mounted to that instance. The correct behavior should be fail this AttachDisk call. K8s attachdetach controller should handle unmount and detach volume safely.\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-e984c5c53b273829c30d7f0519ad57ef22e7bfb4edf32f3f85b3069b60ab401c", "text": "glog.V(4).Infof(\"Disk %s is already attached to instance %s\", volumeID, instanceID) return volume.ID, nil } <del> glog.V(2).Infof(\"Disk %s is attached to a different instance (%s), detaching\", volumeID, volume.AttachedServerId) err = os.DetachDisk(volume.AttachedServerId, volumeID) if err != nil { return \"\", err } </del> <ins> errmsg := fmt.Sprintf(\"Disk %s is attached to a different instance (%s)\", volumeID, volume.AttachedServerId) glog.V(2).Infof(errmsg) return \"\", errors.New(errmsg) </ins> } startTime := time.Now()", "commid": "kubernetes_pr_50042"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-58d223bcda71c0cad54d5576eb06f7eca04bacec0a41ff1f7882b5e79cede5ec", "query": "Making an API request for table output and specifying the parameter causes a server error in parameter conversion, and an inaccurate error message in response: server log: E0804 09:41:14. ] apiserver received an error that is not an metav1.Status: converting (url.Values).[]string to (v1alpha1.TableOptions).v1alpha1.IncludeObjectPolicy: couldn't copy '[]string' into 'v1alpha1.IncludeObjectPolicy'; didn't understand types\nUgh, typed strings.", "positive_passages": [{"docid": "doc-en-kubernetes-bf2d4509c8ee0f642c293274515f8998d4351bd71d9de9bb5efa73cc1899117c", "text": "go_library( name = \"go_default_library\", srcs = [ <ins> \"conversion.go\", </ins> \"deepcopy.go\", \"doc.go\", \"generated.pb.go\",", "commid": "kubernetes_pr_50159"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-58d223bcda71c0cad54d5576eb06f7eca04bacec0a41ff1f7882b5e79cede5ec", "query": "Making an API request for table output and specifying the parameter causes a server error in parameter conversion, and an inaccurate error message in response: server log: E0804 09:41:14. ] apiserver received an error that is not an metav1.Status: converting (url.Values).[]string to (v1alpha1.TableOptions).v1alpha1.IncludeObjectPolicy: couldn't copy '[]string' into 'v1alpha1.IncludeObjectPolicy'; didn't understand types\nUgh, typed strings.", "positive_passages": [{"docid": "doc-en-kubernetes-5e61d83f8b4ef181404bcb262b4e26538fef242255597ca53643e6cc67e0eec1", "text": "<ins> /* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package v1alpha1 import \"k8s.io/apimachinery/pkg/conversion\" // Convert_Slice_string_To_v1alpha1_IncludeObjectPolicy allows converting a URL query parameter value func Convert_Slice_string_To_v1alpha1_IncludeObjectPolicy(input *[]string, out *IncludeObjectPolicy, s conversion.Scope) error { if len(*input) > 0 { *out = IncludeObjectPolicy((*input)[0]) } return nil } </ins>", "commid": "kubernetes_pr_50159"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-58d223bcda71c0cad54d5576eb06f7eca04bacec0a41ff1f7882b5e79cede5ec", "query": "Making an API request for table output and specifying the parameter causes a server error in parameter conversion, and an inaccurate error message in response: server log: E0804 09:41:14. ] apiserver received an error that is not an metav1.Status: converting (url.Values).[]string to (v1alpha1.TableOptions).v1alpha1.IncludeObjectPolicy: couldn't copy '[]string' into 'v1alpha1.IncludeObjectPolicy'; didn't understand types\nUgh, typed strings.", "positive_passages": [{"docid": "doc-en-kubernetes-2f6fe25458bdf8b438601742accd6a7646974e78d3612cd10a47db449a1200fc", "text": "&PartialObjectMetadataList{}, ) <ins> if err := scheme.AddConversionFuncs( Convert_Slice_string_To_v1alpha1_IncludeObjectPolicy, ); err != nil { panic(err) } </ins> // register manually. This usually goes through the SchemeBuilder, which we cannot use here. //scheme.AddGeneratedDeepCopyFuncs(GetGeneratedDeepCopyFuncs()...) }", "commid": "kubernetes_pr_50159"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-58d223bcda71c0cad54d5576eb06f7eca04bacec0a41ff1f7882b5e79cede5ec", "query": "Making an API request for table output and specifying the parameter causes a server error in parameter conversion, and an inaccurate error message in response: server log: E0804 09:41:14. ] apiserver received an error that is not an metav1.Status: converting (url.Values).[]string to (v1alpha1.TableOptions).v1alpha1.IncludeObjectPolicy: couldn't copy '[]string' into 'v1alpha1.IncludeObjectPolicy'; didn't understand types\nUgh, typed strings.", "positive_passages": [{"docid": "doc-en-kubernetes-33a22704cb55211e138ff5146992d91cf86ecdf1ed28fdf17cb97a1223f2b507", "text": "}, }, }, <ins> { accept: runtime.ContentTypeJSON + \";as=Table;v=v1alpha1;g=meta.k8s.io\", params: url.Values{\"includeObject\": []string{\"Metadata\"}}, expected: &metav1alpha1.Table{ TypeMeta: metav1.TypeMeta{Kind: \"Table\", APIVersion: \"meta.k8s.io/v1alpha1\"}, ColumnDefinitions: []metav1alpha1.TableColumnDefinition{ {Name: \"Name\", Type: \"string\", Description: metaDoc[\"name\"]}, {Name: \"Created At\", Type: \"date\", Description: metaDoc[\"creationTimestamp\"]}, }, Rows: []metav1alpha1.TableRow{ {Cells: []interface{}{\"foo1\", now.Time.UTC().Format(time.RFC3339)}, Object: runtime.RawExtension{Raw: encodedBody}}, }, }, }, </ins> } for i, test := range tests { u, err := url.Parse(server.URL + \"/\" + prefix + \"/\" + testGroupVersion.Group + \"/\" + testGroupVersion.Version + \"/namespaces/default/simple/id\")", "commid": "kubernetes_pr_50159"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-58d223bcda71c0cad54d5576eb06f7eca04bacec0a41ff1f7882b5e79cede5ec", "query": "Making an API request for table output and specifying the parameter causes a server error in parameter conversion, and an inaccurate error message in response: server log: E0804 09:41:14. ] apiserver received an error that is not an metav1.Status: converting (url.Values).[]string to (v1alpha1.TableOptions).v1alpha1.IncludeObjectPolicy: couldn't copy '[]string' into 'v1alpha1.IncludeObjectPolicy'; didn't understand types\nUgh, typed strings.", "positive_passages": [{"docid": "doc-en-kubernetes-7911c1932e04d63c0fe4a9605419a98cc51d5fc35f1198dfb1a704fdf553b58a", "text": "} if test.statusCode != 0 { if resp.StatusCode != test.statusCode { <del> t.Errorf(\"%d: unexpected response: %#v\", resp) </del> <ins> t.Errorf(\"%d: unexpected response: %#v\", i, resp) </ins> } continue } if resp.StatusCode != http.StatusOK { <del> t.Errorf(\"%d: unexpected response: %#v\", resp) </del> <ins> t.Errorf(\"%d: unexpected response: %#v\", i, resp) </ins> } var itemOut metav1alpha1.Table <del> if _, err = extractBody(resp, &itemOut); err != nil { </del> <ins> body, err := extractBody(resp, &itemOut) if err != nil { </ins> t.Fatal(err) } if !reflect.DeepEqual(test.expected, &itemOut) { <ins> t.Log(body) </ins> t.Errorf(\"%d: did not match: %s\", i, diff.ObjectReflectDiff(test.expected, &itemOut)) } }", "commid": "kubernetes_pr_50159"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d99d066ab36522f6dcfea94e20b0ee3694b05e719a1247e54f2eed3487eedcdf", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: Unit test error message match the conventional Go style: For example: if got, want := set.Status.Replicas, 3; got != want { t.Errorf(\"set.Status.Replicas = %v; want %v\", got, want) }\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig testing\n/assign\n/reopen", "positive_passages": [{"docid": "doc-en-kubernetes-2961bc0ca863d036fcd132c9142f0d6e9348dac7d6be7020aca3397fe888d9eb", "text": "t.Errorf(\"unexpected error: %v\", err) } if len(times) != 0 { <del> t.Errorf(\"expected 0 start times, got: , got: %v\", times) </del> <ins> t.Errorf(\"expected 0 start times, got: %v\", times) </ins> } } {", "commid": "kubernetes_pr_49938"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d99d066ab36522f6dcfea94e20b0ee3694b05e719a1247e54f2eed3487eedcdf", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: Unit test error message match the conventional Go style: For example: if got, want := set.Status.Replicas, 3; got != want { t.Errorf(\"set.Status.Replicas = %v; want %v\", got, want) }\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig testing\n/assign\n/reopen", "positive_passages": [{"docid": "doc-en-kubernetes-4040f51aff129e6290fbe30dca665b4a519d6c43d00c17e5f2ef24599f029591", "text": "t.Errorf(\"unexpected error: %v\", err) } if len(times) != 1 { <del> t.Errorf(\"expected 2 start times, got: , got: %v\", times) </del> <ins> t.Errorf(\"expected 1 start times, got: %v\", times) </ins> } else if !times[0].Equal(T2) { t.Errorf(\"expected: %v, got: %v\", T1, times[0]) }", "commid": "kubernetes_pr_49938"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d99d066ab36522f6dcfea94e20b0ee3694b05e719a1247e54f2eed3487eedcdf", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: Unit test error message match the conventional Go style: For example: if got, want := set.Status.Replicas, 3; got != want { t.Errorf(\"set.Status.Replicas = %v; want %v\", got, want) }\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig testing\n/assign\n/reopen", "positive_passages": [{"docid": "doc-en-kubernetes-795fc6bd0f0b6caba1c6e935766e0d53ec706798b68901677de3d5bdcd82a2cf", "text": "t.Errorf(\"unexpected error: %v\", err) } if len(times) != 2 { <del> t.Errorf(\"expected 2 start times, got: , got: %v\", times) </del> <ins> t.Errorf(\"expected 2 start times, got: %v\", times) </ins> } else { if !times[0].Equal(T1) { t.Errorf(\"expected: %v, got: %v\", T1, times[0])", "commid": "kubernetes_pr_49938"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d99d066ab36522f6dcfea94e20b0ee3694b05e719a1247e54f2eed3487eedcdf", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: Unit test error message match the conventional Go style: For example: if got, want := set.Status.Replicas, 3; got != want { t.Errorf(\"set.Status.Replicas = %v; want %v\", got, want) }\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig testing\n/assign\n/reopen", "positive_passages": [{"docid": "doc-en-kubernetes-8f615b3f814cb8d55c1fb13f3541c1f5c0c8f04c5aa3f6d62aed08846ca36cf3", "text": "set = obj.(*apps.StatefulSet) } if set.Status.Replicas != 3 { <del> t.Error(\"Falied to scale statefulset to 3 replicas\") </del> <ins> t.Errorf(\"set.Status.Replicas = %v; want 3\", set.Status.Replicas) </ins> } }", "commid": "kubernetes_pr_50219"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d99d066ab36522f6dcfea94e20b0ee3694b05e719a1247e54f2eed3487eedcdf", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: Unit test error message match the conventional Go style: For example: if got, want := set.Status.Replicas, 3; got != want { t.Errorf(\"set.Status.Replicas = %v; want %v\", got, want) }\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig testing\n/assign\n/reopen", "positive_passages": [{"docid": "doc-en-kubernetes-f7f23bb4df2d6b66d809d077c49ddf0cb037dec47901f99dd86a919d533bb396", "text": "set = obj.(*apps.StatefulSet) } if set.Status.Replicas != 3 { <del> t.Error(\"Falied to scale statefulset to 3 replicas\") </del> <ins> t.Errorf(\"set.Status.Replicas = %v; want 3\", set.Status.Replicas) </ins> } *set.Spec.Replicas = 0 if err := scaleDownStatefulSetController(set, ssc, spc); err != nil {", "commid": "kubernetes_pr_50219"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d99d066ab36522f6dcfea94e20b0ee3694b05e719a1247e54f2eed3487eedcdf", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: Unit test error message match the conventional Go style: For example: if got, want := set.Status.Replicas, 3; got != want { t.Errorf(\"set.Status.Replicas = %v; want %v\", got, want) }\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig testing\n/assign\n/reopen", "positive_passages": [{"docid": "doc-en-kubernetes-11ccd90bbc5644a2ec5a3e4c840259808df42f5d4bd065d2a36a52a5325ad90b", "text": "set = obj.(*apps.StatefulSet) } if set.Status.Replicas != 3 { <del> t.Error(\"Falied to scale statefulset to 3 replicas\") </del> <ins> t.Errorf(\"set.Status.Replicas = %v; want 3\", set.Status.Replicas) </ins> } pods, err := spc.addTerminatingPod(set, 3) if err != nil {", "commid": "kubernetes_pr_50219"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d99d066ab36522f6dcfea94e20b0ee3694b05e719a1247e54f2eed3487eedcdf", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: Unit test error message match the conventional Go style: For example: if got, want := set.Status.Replicas, 3; got != want { t.Errorf(\"set.Status.Replicas = %v; want %v\", got, want) }\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig testing\n/assign\n/reopen", "positive_passages": [{"docid": "doc-en-kubernetes-235471ec556de537890511d51fce450c1698e551e904edeb6163e49fa11540f1", "text": "set = obj.(*apps.StatefulSet) } if set.Status.Replicas != 0 { <del> t.Error(\"Falied to scale statefulset to 3 replicas\") </del> <ins> t.Errorf(\"set.Status.Replicas = %v; want 0\", set.Status.Replicas) </ins> } }", "commid": "kubernetes_pr_50219"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d99d066ab36522f6dcfea94e20b0ee3694b05e719a1247e54f2eed3487eedcdf", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: Unit test error message match the conventional Go style: For example: if got, want := set.Status.Replicas, 3; got != want { t.Errorf(\"set.Status.Replicas = %v; want %v\", got, want) }\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig testing\n/assign\n/reopen", "positive_passages": [{"docid": "doc-en-kubernetes-4e9ad890b14de49c42b0ff38413925cceeb77ee9b743d786d43f5929eb2d7776", "text": "set = obj.(*apps.StatefulSet) } if set.Status.Replicas != 3 { <del> t.Error(\"Falied to scale statefulset to 3 replicas\") </del> <ins> t.Errorf(\"set.Status.Replicas = %v; want 3\", set.Status.Replicas) </ins> } *set.Spec.Replicas = 5 fakeResourceVersion(set)", "commid": "kubernetes_pr_50219"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2a0e15966cdb248fd0acdf76a89014fcb0b5e0e863719e0a7c39422e7cec2653", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: e2e test panic in test What you expected to happen: no panic How to reproduce it (as minimally and precisely as possible): start \" [Feature:ManualPerformance] should be able to handle 3 pods per node\" e2e test on a 3-node cluster Anything else we need to know?: panic info : ! After some digging find why. Because the cluster size is 3 that d is 0 in sleepUpTo func which causes rand.Int63n panic happy to fix this. Environment: Kubernetes version (use ):1.7.3 Cloud provider or hardware configuration*: bare-metal OS (e.g. from /etc/os-release): ubuntu Kernel (e.g. ): 16.04 Install tools: kubeadm Others:\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig Testing\njust add a sanity check is fine I think\nIt seems that the count of pods is 0.\npod count is not 0, is 9(33)\nIf totalPods less than throughput, in our case, totalPods is 9, throughput is 10, the creatingTime will be 0, which makes rand.Int63n panic\nor throughput is getting from env LOADTESTTHROUGHPUT, safe to add a sanity check\nIf totalPods less than throughput, in our case, totalPods is 9, throughput is 10, the creatingTime will be 0, which makes rand.Int63n panic agree.", "positive_passages": [{"docid": "doc-en-kubernetes-1a32f5e57311e5beed7b47a3ea261fa816ac0963b95a90366fe59b3395a978ba", "text": "} func sleepUpTo(d time.Duration) { <del> time.Sleep(time.Duration(rand.Int63n(d.Nanoseconds()))) </del> <ins> if d.Nanoseconds() > 0 { time.Sleep(time.Duration(rand.Int63n(d.Nanoseconds()))) } </ins> } func createAllResources(configs []testutils.RunObjectConfig, creatingTime time.Duration) {", "commid": "kubernetes_pr_50742"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc6177451e9ae3dd109f95c34ca28c9d9a0c4aae10f2acbc42a784aa55bc42f8", "query": "seems to belong to sig node PTAL and fix ASAP\n/assign as it seems like having something to do with", "positive_passages": [{"docid": "doc-en-kubernetes-0488c1df890f349769f24b41eadc6e66660b4f690ea2e35ede119638386b533f", "text": "dockercontainer \"github.com/docker/docker/api/types/container\" dockerfilters \"github.com/docker/docker/api/types/filters\" \"github.com/golang/glog\" <del> \"k8s.io/api/core/v1\" </del> runtimeapi \"k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime\" )", "commid": "kubernetes_pr_50694"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc6177451e9ae3dd109f95c34ca28c9d9a0c4aae10f2acbc42a784aa55bc42f8", "query": "seems to belong to sig node PTAL and fix ASAP\n/assign as it seems like having something to do with", "positive_passages": [{"docid": "doc-en-kubernetes-5f17ebf387b9c5829933399653790df061306a0667483bdbc7ebb26b66102bbf", "text": "return 0 } <del> func (ds *dockerService) getSecurityOpts(containerName string, sandboxConfig *runtimeapi.PodSandboxConfig, separator rune) ([]string, error) { hasSeccompSetting := false annotations := sandboxConfig.GetAnnotations() if _, ok := annotations[v1.SeccompContainerAnnotationKeyPrefix+containerName]; !ok { _, hasSeccompSetting = annotations[v1.SeccompPodAnnotationKey] } else { hasSeccompSetting = true </del> <ins> func (ds *dockerService) getSecurityOpts(seccompProfile string, separator rune) ([]string, error) { if seccompProfile != \"\" { glog.Warningf(\"seccomp annotations are not supported on windows\") </ins> } <del> if hasSeccompSetting { glog.Warningf(\"seccomp annotations found, but it is not supported on windows\") } </del> return nil, nil }", "commid": "kubernetes_pr_50694"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ff32de2e880660eb15ff6af8978eca25943f80e4eedc7381a29e1be2e1575046", "query": "We allow users to specify in the Service object. If the user later removes this from the Service Spec, the controller will fail to sync. For example: creates an LB for Service.Spec.LoadBalancerIP = \"1.1.1.1\" with a user-owned static IP address. updates the Service to remove the requested LoadBalancerIP tries to used by the existing forwarding rule (i.e., \"1.1.1.1\"). It encounters a conflict. Controller assumes it owns the IP and by name but fails. We can fix the controller to continue syncing and using the user-owned IP for the LB, or create a new address for the LB. The former seems less disruptive to me, but the downside is that if user will not be able to let other components use this IP (i.e., 1.1.1.1) unless they explicitly delete the Service. I think it's ok but would like more opinions. thoughts?\nIf a service is updated to remove a static address, then it seems like that would be a deliberate move on the part of the user. It seems like it should probably release the address and provision a dynamic one, even if this is disruptive. How do we handle the reverse? If a user has an already existing LoadBalancer service, and they add the after the fact? Would this release the dynamic address and recreate the forwarding rule with the reserved static address?\nIt seems like the creating a new address makes sense here... General comment: given the combinations (and the bugs we have been running into), I think this is a problem that all of the potential state transitions for the load balancer have not been fully spec'd out.\nCreating a new address seems nice but the implementation is a nightmare. The service controller doesn't give you a previous Service spec, so you don't know what's changed (controller might not know either if spec was modified while offline). Given a desired service spec without a how do you decide to ditch your current IP and grab a new one? If we were to call to evaluate the situation, it's highly likely users will accidentally cause LBs to change IPs during typical usage. Imagine a user has a dynamically allocated IP for a service, but they want to promote it for safe keeping. The controller would think it needs to surrender the IP to the user's reservation. The only correct process would be to set before promoting the address; however, that will surely be a missed point in docs and result in unhappy users. I lean towards the LB continuing use of the IP. Besides the easy option of deleting & re-creating the service, they could change the to another static address then demote the address. I'm not too familiar with the ideological boundaries of controllers and spec, so let me know if this crosses the line. What if the service controller set to the created IP on first sync if the IP wasn't pre-specified? The controller could rely on loadBalancerIP to always indicate which IP to use. If the field is empty (blanked by user), then it's a signal to get a new IP.\nBy spec, I mean we should write down the careful reasoning that you just wrote in a permanent place :-)\nwould it then make sense for to be immutable on an already created service?\n+1 +1 Was thinking the same. Unlike the many annotations we support, updates to this actual field could be validated and blocked at the apiserver... Changing IP is disruptive anyway. Could we simply ask the user to re-create the Service?\nOf course, this could be an API-breaking change, and other cloud providers may actually be supporting this properly.\nI just ran across this today, but in a more likely (IMO) case. 1) create the Service, type=LoadBalancer 2) let the IP be auto-allocated 3) manually promote that IP to static and give it a meaningful name 4) observe errors from service controller trying to allocate that IP Since my Service does not spec \"loadBalancerIP\", the question is, do we: a) use the IP, but leave it as static b) use the IP, but demote it back to ephemeral c) allocate and use a new IP C is completely hostile. B is subtly hostile. A seems correct. Can it be implemented? If we find that the IP exists but the name of it is not what we expect, we should treat it as user-provided and leave it alone. This is still nasty because it logs a failure in the GCP activities log for every loop, but I don't know how to avoid that without getting a list of IPs and scanning for the IP we want.\nFiled for the looping.\n+1 as long as we can rely on the \"naming\" of the address to decide whether the controller owns the address and can promote/demote it.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale Still relevant\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale Still relevant\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nany update on this?\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/lifecycle frozen\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d", "positive_passages": [{"docid": "doc-en-kubernetes-1d4511c22236fb00e6e652fda276ce041f093582765a8e7ca5cf57d635debfc8", "text": "existed = true } <ins> // If address exists, get it by IP, because name might be different. // This can specifically happen if the IP was changed from ephemeral to static, // which results in a new name for the IP. if existingIP != \"\" { addr, err := s.GetRegionAddressByIP(region, existingIP) if err != nil { return \"\", false, fmt.Errorf(\"error getting static IP address: %v\", err) } return addr.Address, existed, nil } // Otherwise, get address by name </ins> addr, err := s.GetRegionAddress(name, region) if err != nil { return \"\", false, fmt.Errorf(\"error getting static IP address: %v\", err)", "commid": "kubernetes_pr_86452"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ff32de2e880660eb15ff6af8978eca25943f80e4eedc7381a29e1be2e1575046", "query": "We allow users to specify in the Service object. If the user later removes this from the Service Spec, the controller will fail to sync. For example: creates an LB for Service.Spec.LoadBalancerIP = \"1.1.1.1\" with a user-owned static IP address. updates the Service to remove the requested LoadBalancerIP tries to used by the existing forwarding rule (i.e., \"1.1.1.1\"). It encounters a conflict. Controller assumes it owns the IP and by name but fails. We can fix the controller to continue syncing and using the user-owned IP for the LB, or create a new address for the LB. The former seems less disruptive to me, but the downside is that if user will not be able to let other components use this IP (i.e., 1.1.1.1) unless they explicitly delete the Service. I think it's ok but would like more opinions. thoughts?\nIf a service is updated to remove a static address, then it seems like that would be a deliberate move on the part of the user. It seems like it should probably release the address and provision a dynamic one, even if this is disruptive. How do we handle the reverse? If a user has an already existing LoadBalancer service, and they add the after the fact? Would this release the dynamic address and recreate the forwarding rule with the reserved static address?\nIt seems like the creating a new address makes sense here... General comment: given the combinations (and the bugs we have been running into), I think this is a problem that all of the potential state transitions for the load balancer have not been fully spec'd out.\nCreating a new address seems nice but the implementation is a nightmare. The service controller doesn't give you a previous Service spec, so you don't know what's changed (controller might not know either if spec was modified while offline). Given a desired service spec without a how do you decide to ditch your current IP and grab a new one? If we were to call to evaluate the situation, it's highly likely users will accidentally cause LBs to change IPs during typical usage. Imagine a user has a dynamically allocated IP for a service, but they want to promote it for safe keeping. The controller would think it needs to surrender the IP to the user's reservation. The only correct process would be to set before promoting the address; however, that will surely be a missed point in docs and result in unhappy users. I lean towards the LB continuing use of the IP. Besides the easy option of deleting & re-creating the service, they could change the to another static address then demote the address. I'm not too familiar with the ideological boundaries of controllers and spec, so let me know if this crosses the line. What if the service controller set to the created IP on first sync if the IP wasn't pre-specified? The controller could rely on loadBalancerIP to always indicate which IP to use. If the field is empty (blanked by user), then it's a signal to get a new IP.\nBy spec, I mean we should write down the careful reasoning that you just wrote in a permanent place :-)\nwould it then make sense for to be immutable on an already created service?\n+1 +1 Was thinking the same. Unlike the many annotations we support, updates to this actual field could be validated and blocked at the apiserver... Changing IP is disruptive anyway. Could we simply ask the user to re-create the Service?\nOf course, this could be an API-breaking change, and other cloud providers may actually be supporting this properly.\nI just ran across this today, but in a more likely (IMO) case. 1) create the Service, type=LoadBalancer 2) let the IP be auto-allocated 3) manually promote that IP to static and give it a meaningful name 4) observe errors from service controller trying to allocate that IP Since my Service does not spec \"loadBalancerIP\", the question is, do we: a) use the IP, but leave it as static b) use the IP, but demote it back to ephemeral c) allocate and use a new IP C is completely hostile. B is subtly hostile. A seems correct. Can it be implemented? If we find that the IP exists but the name of it is not what we expect, we should treat it as user-provided and leave it alone. This is still nasty because it logs a failure in the GCP activities log for every loop, but I don't know how to avoid that without getting a list of IPs and scanning for the IP we want.\nFiled for the looping.\n+1 as long as we can rely on the \"naming\" of the address to decide whether the controller owns the address and can promote/demote it.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale Still relevant\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale Still relevant\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nany update on this?\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/lifecycle frozen\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d", "positive_passages": [{"docid": "doc-en-kubernetes-3499ae2e2f45d2cfc620ab36ef01420ea536c90358e4be69231e2e6528570536", "text": "if err != nil || !existed || ip != ipPrime { t.Fatalf(`ensureStaticIP(%v, %v, %v, %v, %v) = %v, %v, %v; want %v, true, nil`, gce, ipName, serviceName, gce.region, ip, ipPrime, existed, err, ip) } <ins> // Ensure call with different name ipName = \"another-name-for-static-ip\" ipPrime, existed, err = ensureStaticIP(gce, ipName, serviceName, gce.region, ip, cloud.NetworkTierDefault) if err != nil || !existed || ip != ipPrime { t.Fatalf(`ensureStaticIP(%v, %v, %v, %v, %v) = %v, %v, %v; want %v, true, nil`, gce, ipName, serviceName, gce.region, ip, ipPrime, existed, err, ip) } </ins> } func TestEnsureStaticIPWithTier(t *testing.T) {", "commid": "kubernetes_pr_86452"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b6c7dc7df0d7bcfd58ca95e0601a8e4b9b3c643a3067c0232de981b8b87c87ec", "query": "When using IP aliases on GCE, use a secondary range rather than subnetwork to reserve cluster IPs.\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals", "positive_passages": [{"docid": "doc-en-kubernetes-e124472ef0d00f0397005a403b7af0551029ec99067c23a16214e22592489761", "text": "--network ${NETWORK}  --region ${REGION}  --range ${NODE_IP_RANGE}  <del> --secondary-range \"pods-default=${CLUSTER_IP_RANGE}\" </del> <ins> --secondary-range \"pods-default=${CLUSTER_IP_RANGE}\"  --secondary-range \"services-default=${SERVICE_CLUSTER_IP_RANGE}\" </ins> echo \"Created subnetwork ${IP_ALIAS_SUBNETWORK}\" else if ! echo ${subnet} | grep --quiet secondaryIpRanges ${subnet}; then", "commid": "kubernetes_pr_51690"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b6c7dc7df0d7bcfd58ca95e0601a8e4b9b3c643a3067c0232de981b8b87c87ec", "query": "When using IP aliases on GCE, use a secondary range rather than subnetwork to reserve cluster IPs.\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals", "positive_passages": [{"docid": "doc-en-kubernetes-0fbf5871f5dc3ddea71b7531e19a6b4f6acc2431aea91fb9288823b5c27788c9", "text": "exit 1 fi fi <del> # Services subnetwork. local subnet=$(gcloud beta compute networks subnets describe  --project \"${PROJECT}\"  --region ${REGION}  ${SERVICE_CLUSTER_IP_SUBNETWORK} 2>/dev/null) if [[ -z ${subnet} ]]; then if [[ ${SERVICE_CLUSTER_IP_SUBNETWORK} != ${INSTANCE_PREFIX}-subnet-services ]]; then echo \"${color_red}Subnetwork ${NETWORK}:${SERVICE_CLUSTER_IP_SUBNETWORK} does not exist${color_norm}\" exit 1 fi echo \"Creating subnet for reserving service cluster IPs ${NETWORK}:${SERVICE_CLUSTER_IP_SUBNETWORK}\" gcloud beta compute networks subnets create  ${SERVICE_CLUSTER_IP_SUBNETWORK}  --description \"Automatically generated subnet for ${INSTANCE_PREFIX} cluster. This will be removed on cluster teardown.\"  --project \"${PROJECT}\"  --network ${NETWORK}  --region ${REGION}  --range ${SERVICE_CLUSTER_IP_RANGE} echo \"Created subnetwork ${SERVICE_CLUSTER_IP_SUBNETWORK}\" else echo \"Subnet ${SERVICE_CLUSTER_IP_SUBNETWORK} already exists\" fi </del> } function delete-firewall-rules() {", "commid": "kubernetes_pr_51690"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b6c7dc7df0d7bcfd58ca95e0601a8e4b9b3c643a3067c0232de981b8b87c87ec", "query": "When using IP aliases on GCE, use a secondary range rather than subnetwork to reserve cluster IPs.\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals", "positive_passages": [{"docid": "doc-en-kubernetes-32c5bb2c503839bc226f37399d6bd5b2094189a030d3661ba2c41e1d2ddd1273", "text": "${IP_ALIAS_SUBNETWORK} fi fi <del> if [[ ${SERVICE_CLUSTER_IP_SUBNETWORK} == ${INSTANCE_PREFIX}-subnet-services ]]; then echo \"Removing auto-created subnet ${NETWORK}:${SERVICE_CLUSTER_IP_SUBNETWORK}\" if [[ -n $(gcloud beta compute networks subnets describe  --project \"${PROJECT}\"  --region ${REGION}  ${SERVICE_CLUSTER_IP_SUBNETWORK} 2>/dev/null) ]]; then gcloud --quiet beta compute networks subnets delete  --project \"${PROJECT}\"  --region ${REGION}  ${SERVICE_CLUSTER_IP_SUBNETWORK} fi fi </del> } # Generates SSL certificates for etcd cluster. Uses cfssl program.", "commid": "kubernetes_pr_51690"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a79b6bc7e527e825eca09a117ef51fcb0df687226620a6bdf023846890bd6a8e", "query": "Test Cases: [ ] Egress blocking based on cidr to a set of pods [ ] Egress blocking based on namespace to a set of pods [ ] Egress blocking based on a set of pods to another set of pods\nUpdate: I'm working to try to enable these new features in a few CNI plug-ins so the tests can run locally.\nCan we please move out of 1.8 milestone?\n/label status/approved-for-milestone\n/kind cleanup\n/remove-kind bug\nThose labels are not set on the issue: <detailsIn response to : /remove-kind bug Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/kind cleanup\n/status approved-for-milestone /kind cleanup /remove-kind bug\n[MILESTONENOTIFIER] Milestone Issue Current <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. : Adding tests, refactoring, fixing old bugs. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nCan we please move out of 1.9 milestone? :)\nthis will be partially fixed with . I think it is safe to keep in the milestone.", "positive_passages": [{"docid": "doc-en-kubernetes-dee94ba3fe9e8ad838e8c2c65f2751ff9b5667c193d8735c08be32ab5c8812a8", "text": "testCannotConnect(f, f.Namespace, \"client-b\", service, 81) }) }) <ins> It(\"should allow egress access on one named port [Feature:NetworkPolicy]\", func() { clientPodName := \"client-a\" protocolUDP := v1.ProtocolUDP policy := &networkingv1.NetworkPolicy{ ObjectMeta: metav1.ObjectMeta{ Name: \"allow-client-a-via-named-port-egress-rule\", }, Spec: networkingv1.NetworkPolicySpec{ // Apply this policy to client-a PodSelector: metav1.LabelSelector{ MatchLabels: map[string]string{ \"pod-name\": clientPodName, }, }, // Allow traffic to only one named port: \"serve-80\". Egress: []networkingv1.NetworkPolicyEgressRule{{ Ports: []networkingv1.NetworkPolicyPort{ { Port: &intstr.IntOrString{Type: intstr.String, StrVal: \"serve-80\"}, }, // Allow DNS look-ups { Protocol: &protocolUDP, Port:     &intstr.IntOrString{Type: intstr.Int, IntVal: 53}, }, }, }}, }, } policy, err := f.ClientSet.NetworkingV1().NetworkPolicies(f.Namespace.Name).Create(policy) Expect(err).NotTo(HaveOccurred()) defer cleanupNetworkPolicy(f, policy) By(\"Creating client-a which should be able to contact the server.\", func() { testCanConnect(f, f.Namespace, clientPodName, service, 80) }) By(\"Creating client-a which should not be able to contact the server on port 81.\", func() { testCannotConnect(f, f.Namespace, clientPodName, service, 81) }) }) </ins> }) })", "commid": "kubernetes_pr_55186"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3136844f9d3895d8ddd69e5024a99bf146fde86d1eed084a149e842e256ed078", "query": "bumped the vendored docker library and introduced a regression where pods with images that don't contain an explicit \"\" repo path result in failures. Results in the following error: Pod gets shows that the image has been pulled, though not by that name Changing the image to in the pod spec corrects the issue. I think the new code that is changing the behavior is somewhere in here is a new function brought in by the bump. If I checkout the commit before the bump, the problem does not occur. related:\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig node\ntaking a look now\nWhat docker version are you using?\nDo you have any e2e tests that are failing? We run a lot of tests with image \"busybox\"\nDidn't think about it before, but I guess 1.12 is the supported version for 1.8 eh? Let me try it on 1.12.\nHm, weird. We also have cluster e2e test coverage for 1.13. Many test are using directly from this function\nI installed a completely fresh box with docker 1.12 and could still recreate. I have no explanation :confused: from kubelet built from upstream/release-1.8\nThis is one of our e2e test node log: You could find tons of . One thing I don't understand on your side is that, logs in our test are always: Why on your node it's ? Where does that image come from? What if you delete it?\ndoes this mean that upgrades will fail if the local image names need to change?\nSeems not. Based on the following code, it's fine to pull/inspect with new reference when we previously pulled with old reference. Could not reproduce this.\nI could not reproduce with the code above either.\nFor any image which has no tag, kubelet will add a default tag , and default repo to it. So will change to and send to dockerd to pull. But dockerd knows and are the same thing, so should return right instead of not found. (as demo) Can you make sure your dockerd is the a version compatible with k8s 1.8?\nJust ran into this. If you up the kubelet's log level to 4, you'll see a \"not found\" error from For example: If we look at the code in that helper function, we have this: Here is the result of inspecting the image on my system (only showing relevant fields): You'll notice that the RepoTag it has is for , not . I am guessing the fact that we're somewhere inserting \"library\" into the image's name is what's tripping this up.\nIf it wasn't clear, I believe dockershim is what's having the issue. Once the kubelet sends the protobuf message to the dockershim socket to pull the image, it goes from to to to and then into the helper function I listed above.\nIt appears to be this: to to to That's where the \"library\" is coming from.\nPrior to the PR that bumped docker/distribution, used to have , which does not do any normalization (i.e. including \"library\").\nOK, I see why when we bumped to the newer docker/distribution, we switch to using . It's because now requires that the input be in \"canonical\" format (in this case, has and , if applicable), which you get automatically by calling ...\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node: Issue will be escalated to these SIGs if needed. priority/critical-urgent: Never automatically move out of a release milestone; continually escalate to contributor and SIG through all available channels. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\n/assign\ncould you give steps to reproduce this? We can't reproduce this and many of the node/cluster e2e tests pull images using unqualified name such as \"buxybox\"\nWhat docker distribution are you using? I could not reproduce this myself. I don't understand how does the reference show up, we never pull image with it. Is this a problem specific to a docker distribution?\nrun the e2e tests on a centos/fedora/rhel image\nIs there any signal in test-grid for centos/fedora/rhel? Would be nice to catch issues like this sooner than later.\nrun the e2e tests on a centos/fedora/rhel image there is not, and definitely should be, given that k8s releases rpms as part of each release. will be on the short list for the release retrospective.\nI feel like this is a problem in docker distribution in centos/fedora/rhel. Docker should not return when we are using to pull image. Should we fix the corresponding docker distribution instead of blocking Kubernete release?\nSince that would mean releasing a new version would regress existing users, we generally say that we'll do our best to tolerate it instead of releasing something known broken. We've done that with various versions of Docker, systemd, and iptables for years, and I'm sure we'll do our best to do that. I do agree that this looks like a bug in that docker distribution that should be fixed. I also agree that this should have been in the test grid and that the distro owner is responsible for ensuring the project has that signal.\nThanks! I agree that we should not break existing users. I'm fine with as long as we keep in mind we made this change, and clean it up in the future. I think it would be helpful if we could have test coverage in test-grid on more distros, so that we could have caught similar problems earlier.\nAgree - I think anyone who causes a release slip is required to make sure they fix the problem so it can't happen in the future. And get better all around testing. On Sep 27, 2017, at 7:40 PM, Lantao Liu <: ! I agree that we should not break existing users. I'm fine with long as we keep in mind we made this change, and clean it up in the future. I think it would be helpful if we could have test coverage on more distros, so that we could have caught similar problems earlier. \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread\nI have opened a bug for this\nThis has broken the CRI as well. Kubernetes should not normalize image names on behalf of the CRI runtime. It's up to implementors to decide how to handle an image name and since there's not a standard around Kube and Image names, I'd prefer not to break the CRI.\nAre you saying it's currently broken, or the fix was ok? , Antonio Murdaca <:\nThe fix is ok but the original patch caused another bug\nWhich one?\ncaused a bug fixed by\nDoes this problem fixed?", "positive_passages": [{"docid": "doc-en-kubernetes-3ea8a6149105d556ae984fd1456cf9ce1d1be51a455ffcbd6f4cbd761f76c3b5", "text": "// hostname or not, we only check for the suffix match. if strings.HasSuffix(image, tag) || strings.HasSuffix(tag, image) { return true <ins> } else { // TODO: We need to remove this hack when project atomic based // docker distro(s) like centos/fedora/rhel image fix problems on // their end. // Say the tag is \"docker.io/busybox:latest\" // and the image is \"docker.io/library/busybox:latest\" t, err := dockerref.ParseNormalizedNamed(tag) if err != nil { continue } // the parsed/normalized tag will look like // reference.taggedReference { // \t namedRepository: reference.repository { // \t   domain: \"docker.io\", // \t   path: \"library/busybox\" //\t}, // \ttag: \"latest\" // } // If it does not have tags then we bail out t2, ok := t.(dockerref.Tagged) if !ok { continue } // normalized tag would look like \"docker.io/library/busybox:latest\" // note the library get added in the string normalizedTag := t2.String() if normalizedTag == \"\" { continue } if strings.HasSuffix(image, normalizedTag) || strings.HasSuffix(normalizedTag, image) { return true } </ins> } } }", "commid": "kubernetes_pr_53161"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3136844f9d3895d8ddd69e5024a99bf146fde86d1eed084a149e842e256ed078", "query": "bumped the vendored docker library and introduced a regression where pods with images that don't contain an explicit \"\" repo path result in failures. Results in the following error: Pod gets shows that the image has been pulled, though not by that name Changing the image to in the pod spec corrects the issue. I think the new code that is changing the behavior is somewhere in here is a new function brought in by the bump. If I checkout the commit before the bump, the problem does not occur. related:\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig node\ntaking a look now\nWhat docker version are you using?\nDo you have any e2e tests that are failing? We run a lot of tests with image \"busybox\"\nDidn't think about it before, but I guess 1.12 is the supported version for 1.8 eh? Let me try it on 1.12.\nHm, weird. We also have cluster e2e test coverage for 1.13. Many test are using directly from this function\nI installed a completely fresh box with docker 1.12 and could still recreate. I have no explanation :confused: from kubelet built from upstream/release-1.8\nThis is one of our e2e test node log: You could find tons of . One thing I don't understand on your side is that, logs in our test are always: Why on your node it's ? Where does that image come from? What if you delete it?\ndoes this mean that upgrades will fail if the local image names need to change?\nSeems not. Based on the following code, it's fine to pull/inspect with new reference when we previously pulled with old reference. Could not reproduce this.\nI could not reproduce with the code above either.\nFor any image which has no tag, kubelet will add a default tag , and default repo to it. So will change to and send to dockerd to pull. But dockerd knows and are the same thing, so should return right instead of not found. (as demo) Can you make sure your dockerd is the a version compatible with k8s 1.8?\nJust ran into this. If you up the kubelet's log level to 4, you'll see a \"not found\" error from For example: If we look at the code in that helper function, we have this: Here is the result of inspecting the image on my system (only showing relevant fields): You'll notice that the RepoTag it has is for , not . I am guessing the fact that we're somewhere inserting \"library\" into the image's name is what's tripping this up.\nIf it wasn't clear, I believe dockershim is what's having the issue. Once the kubelet sends the protobuf message to the dockershim socket to pull the image, it goes from to to to and then into the helper function I listed above.\nIt appears to be this: to to to That's where the \"library\" is coming from.\nPrior to the PR that bumped docker/distribution, used to have , which does not do any normalization (i.e. including \"library\").\nOK, I see why when we bumped to the newer docker/distribution, we switch to using . It's because now requires that the input be in \"canonical\" format (in this case, has and , if applicable), which you get automatically by calling ...\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node: Issue will be escalated to these SIGs if needed. priority/critical-urgent: Never automatically move out of a release milestone; continually escalate to contributor and SIG through all available channels. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\n/assign\ncould you give steps to reproduce this? We can't reproduce this and many of the node/cluster e2e tests pull images using unqualified name such as \"buxybox\"\nWhat docker distribution are you using? I could not reproduce this myself. I don't understand how does the reference show up, we never pull image with it. Is this a problem specific to a docker distribution?\nrun the e2e tests on a centos/fedora/rhel image\nIs there any signal in test-grid for centos/fedora/rhel? Would be nice to catch issues like this sooner than later.\nrun the e2e tests on a centos/fedora/rhel image there is not, and definitely should be, given that k8s releases rpms as part of each release. will be on the short list for the release retrospective.\nI feel like this is a problem in docker distribution in centos/fedora/rhel. Docker should not return when we are using to pull image. Should we fix the corresponding docker distribution instead of blocking Kubernete release?\nSince that would mean releasing a new version would regress existing users, we generally say that we'll do our best to tolerate it instead of releasing something known broken. We've done that with various versions of Docker, systemd, and iptables for years, and I'm sure we'll do our best to do that. I do agree that this looks like a bug in that docker distribution that should be fixed. I also agree that this should have been in the test grid and that the distro owner is responsible for ensuring the project has that signal.\nThanks! I agree that we should not break existing users. I'm fine with as long as we keep in mind we made this change, and clean it up in the future. I think it would be helpful if we could have test coverage in test-grid on more distros, so that we could have caught similar problems earlier.\nAgree - I think anyone who causes a release slip is required to make sure they fix the problem so it can't happen in the future. And get better all around testing. On Sep 27, 2017, at 7:40 PM, Lantao Liu <: ! I agree that we should not break existing users. I'm fine with long as we keep in mind we made this change, and clean it up in the future. I think it would be helpful if we could have test coverage on more distros, so that we could have caught similar problems earlier. \u2014 You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread\nI have opened a bug for this\nThis has broken the CRI as well. Kubernetes should not normalize image names on behalf of the CRI runtime. It's up to implementors to decide how to handle an image name and since there's not a standard around Kube and Image names, I'd prefer not to break the CRI.\nAre you saying it's currently broken, or the fix was ok? , Antonio Murdaca <:\nThe fix is ok but the original patch caused another bug\nWhich one?\ncaused a bug fixed by\nDoes this problem fixed?", "positive_passages": [{"docid": "doc-en-kubernetes-c721f3d097e7988b89459e532a6a3d11b319532a5db421d6ee75f55f038b321f", "text": "Output: true, }, { <ins> Inspected: dockertypes.ImageInspect{ ID:       \"sha256:9bbdf247c91345f0789c10f50a57e36a667af1189687ad1de88a6243d05a2227\", RepoTags: []string{\"docker.io/busybox:latest\"}, }, Image:  \"docker.io/library/busybox:latest\", Output: true, }, { </ins> // RepoDigest match is is required Inspected: dockertypes.ImageInspect{ ID:          \"\",", "commid": "kubernetes_pr_53161"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e40ebb6767d1e38ffdcbda9625fe881658b7fe225ed48accb10a587281467df9", "query": "(SEE UPDATE at ) Currently, if you're writing an initializer controller, you're most likely using it to initialize a and deploying the controller with . Therefore you're likely using the following trick to avoid the chicken and egg problem: This bypasses the initializers for the pods and lets your controller to be deployed even though your InitializerConfiguration is configured to capture all pods. Problem occurs when you apply an update to this Deployment with the same manifest containing empty pending list. You get error: I think this is a somewhat major UX issue. It requires users to deploy the initializer controller with the but later on when they need to update the controller with , they can't use the same manifest containing the empty list. /area api /area extensibility /sig api-machinery /kind bug /assign\n/cc\nWe silently ignore some metadata updates, which is one option. Potentially we shouldn't require empty initializers pending, but simply empty initializers (which means - init directly), and only ignore that. Are there any examples of use of SMP for similar? I'm not sure this meets the bar for 1.8 but if we can find an example of something consistent already in the API I'd be willing to review.\nI don't have any concrete examples, there's an example initializer at making use the trick, I use it myself, and I suspect many more initializers to come will use this, too. I'm not sure if this would work, but does setting provide a way to skip initialization (if possible at all)? If not, we might actually need a separate field to signal skipping initialization.\n/cc\nCurrently the initializer plugin to on UPDATE, but that happens after it updating already initialized objects. We can simply change their order.\nI'd like to amend the issue, it's more serious than I thought. (thanks for bringing it to my attention If you're deploying your Initializer with and if you have an initializerconfiguration for objects, it's impossible to deploy your initializer in the first place without deleting InitializerConfiguration first: is not inherited by the created on is not honored (this field is not propagated to the created Pod). I think (2) should be fixed somehow, otherwise there will be no way of writing an initializer for Pods and deploying the initializer itself using Deployment/ReplicaSet/RC without deleting the InitializerConfiguration first. Maybe what we need is an exclusion/exemption selector (or namespace(s)) as discussed in to allow deployment of Initializers themselves easier.\nFor 1, see I don't want to pursue that though, because i) we'll need to fix workload controllers one by one, and ii) we need to carefully consider permission issues. I think we should focus on adding the namespace selector.", "positive_passages": [{"docid": "doc-en-kubernetes-90a127760981a422f37973fc2ed35862b5ccf592c750a5e22d4eaa7e3121a2b5", "text": "} updated := accessor.GetInitializers() <ins> // controllers deployed with an empty initializers.pending have their initializers set to nil // but should be able to update without changing their manifest if updated != nil && len(updated.Pending) == 0 && updated.Result == nil { accessor.SetInitializers(nil) updated = nil } </ins> existingAccessor, err := meta.Accessor(a.GetOldObject()) if err != nil { // if the old object does not have an accessor, but the new one does, error out", "commid": "kubernetes_pr_52558"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e40ebb6767d1e38ffdcbda9625fe881658b7fe225ed48accb10a587281467df9", "query": "(SEE UPDATE at ) Currently, if you're writing an initializer controller, you're most likely using it to initialize a and deploying the controller with . Therefore you're likely using the following trick to avoid the chicken and egg problem: This bypasses the initializers for the pods and lets your controller to be deployed even though your InitializerConfiguration is configured to capture all pods. Problem occurs when you apply an update to this Deployment with the same manifest containing empty pending list. You get error: I think this is a somewhat major UX issue. It requires users to deploy the initializer controller with the but later on when they need to update the controller with , they can't use the same manifest containing the empty list. /area api /area extensibility /sig api-machinery /kind bug /assign\n/cc\nWe silently ignore some metadata updates, which is one option. Potentially we shouldn't require empty initializers pending, but simply empty initializers (which means - init directly), and only ignore that. Are there any examples of use of SMP for similar? I'm not sure this meets the bar for 1.8 but if we can find an example of something consistent already in the API I'd be willing to review.\nI don't have any concrete examples, there's an example initializer at making use the trick, I use it myself, and I suspect many more initializers to come will use this, too. I'm not sure if this would work, but does setting provide a way to skip initialization (if possible at all)? If not, we might actually need a separate field to signal skipping initialization.\n/cc\nCurrently the initializer plugin to on UPDATE, but that happens after it updating already initialized objects. We can simply change their order.\nI'd like to amend the issue, it's more serious than I thought. (thanks for bringing it to my attention If you're deploying your Initializer with and if you have an initializerconfiguration for objects, it's impossible to deploy your initializer in the first place without deleting InitializerConfiguration first: is not inherited by the created on is not honored (this field is not propagated to the created Pod). I think (2) should be fixed somehow, otherwise there will be no way of writing an initializer for Pods and deploying the initializer itself using Deployment/ReplicaSet/RC without deleting the InitializerConfiguration first. Maybe what we need is an exclusion/exemption selector (or namespace(s)) as discussed in to allow deployment of Initializers themselves easier.\nFor 1, see I don't want to pursue that though, because i) we'll need to fix workload controllers one by one, and ii) we need to carefully consider permission issues. I think we should focus on adding the namespace selector.", "positive_passages": [{"docid": "doc-en-kubernetes-8d77189393d6ab6e83dc75280e5ec175ef0732a278efcebe807bd35e5251704c", "text": "glog.V(5).Infof(\"Modifying uninitialized resource %s\", a.GetResource()) <del> if updated != nil && len(updated.Pending) == 0 && updated.Result == nil { accessor.SetInitializers(nil) } </del> // because we are called before validation, we need to ensure the update transition is valid. if errs := validation.ValidateInitializersUpdate(updated, existing, initializerFieldPath); len(errs) > 0 { return errors.NewInvalid(a.GetKind().GroupKind(), a.GetName(), errs)", "commid": "kubernetes_pr_52558"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e40ebb6767d1e38ffdcbda9625fe881658b7fe225ed48accb10a587281467df9", "query": "(SEE UPDATE at ) Currently, if you're writing an initializer controller, you're most likely using it to initialize a and deploying the controller with . Therefore you're likely using the following trick to avoid the chicken and egg problem: This bypasses the initializers for the pods and lets your controller to be deployed even though your InitializerConfiguration is configured to capture all pods. Problem occurs when you apply an update to this Deployment with the same manifest containing empty pending list. You get error: I think this is a somewhat major UX issue. It requires users to deploy the initializer controller with the but later on when they need to update the controller with , they can't use the same manifest containing the empty list. /area api /area extensibility /sig api-machinery /kind bug /assign\n/cc\nWe silently ignore some metadata updates, which is one option. Potentially we shouldn't require empty initializers pending, but simply empty initializers (which means - init directly), and only ignore that. Are there any examples of use of SMP for similar? I'm not sure this meets the bar for 1.8 but if we can find an example of something consistent already in the API I'd be willing to review.\nI don't have any concrete examples, there's an example initializer at making use the trick, I use it myself, and I suspect many more initializers to come will use this, too. I'm not sure if this would work, but does setting provide a way to skip initialization (if possible at all)? If not, we might actually need a separate field to signal skipping initialization.\n/cc\nCurrently the initializer plugin to on UPDATE, but that happens after it updating already initialized objects. We can simply change their order.\nI'd like to amend the issue, it's more serious than I thought. (thanks for bringing it to my attention If you're deploying your Initializer with and if you have an initializerconfiguration for objects, it's impossible to deploy your initializer in the first place without deleting InitializerConfiguration first: is not inherited by the created on is not honored (this field is not propagated to the created Pod). I think (2) should be fixed somehow, otherwise there will be no way of writing an initializer for Pods and deploying the initializer itself using Deployment/ReplicaSet/RC without deleting the InitializerConfiguration first. Maybe what we need is an exclusion/exemption selector (or namespace(s)) as discussed in to allow deployment of Initializers themselves easier.\nFor 1, see I don't want to pursue that though, because i) we'll need to fix workload controllers one by one, and ii) we need to carefully consider permission issues. I think we should focus on adding the namespace selector.", "positive_passages": [{"docid": "doc-en-kubernetes-a89a86b550173428c12324af56a445d50c9106b81ba06578dd841a1a0b9c0fd6", "text": "newInitializers: &metav1.Initializers{Pending: []metav1.Initializer{{Name: \"init.k8s.io\"}}}, err:             \"field is immutable once initialization has completed\", }, <ins> { name:            \"empty initializer list is treated as nil initializer\", oldInitializers: nil, newInitializers: &metav1.Initializers{}, verifyUpdatedObj: func(obj runtime.Object) (bool, string) { accessor, err := meta.Accessor(obj) if err != nil { return false, \"cannot get accessor\" } if accessor.GetInitializers() != nil { return false, \"expect nil initializers\" } return true, \"\" }, err: \"\", }, </ins> } plugin := initializer{", "commid": "kubernetes_pr_52558"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4b5959a3aaa5f30e123a555df8aee9d29b1dec6e0fefb212f2839a190ac1f9c", "query": "/kind bug What happened: When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in and other man pages. coming from that uses and probably sets do not have any specific order, so it would need to be sorted on output. What you expected to happen: Every build should give identical results. See https://reproducible- for why this matters. How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version: 1.7.0 OS (e.g. from /etc/os-release): openSUSE Tumbleweed\n/sig release\nsomehow this bug seems to have been forgotten - can you help getting the right people to have a look?\n- can you please confirm that PR works for you?\nI tested it and it looks good.\n/assign I enjoy reading my highlights to find the issue has already been addressed. :)\nSorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)\n/area build-release\nrelated to /reopen\nReopening this issue. <detailsIn response to : related to Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-639c781f5a0b80f81b6a39c1c3458a004518a198d0c23ffd96c50f3041f5c30a", "text": "\"flag\" \"fmt\" \"net\" <ins> \"sort\" </ins> \"strings\" \"github.com/golang/glog\"", "commid": "kubernetes_pr_57008"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4b5959a3aaa5f30e123a555df8aee9d29b1dec6e0fefb212f2839a190ac1f9c", "query": "/kind bug What happened: When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in and other man pages. coming from that uses and probably sets do not have any specific order, so it would need to be sorted on output. What you expected to happen: Every build should give identical results. See https://reproducible- for why this matters. How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version: 1.7.0 OS (e.g. from /etc/os-release): openSUSE Tumbleweed\n/sig release\nsomehow this bug seems to have been forgotten - can you help getting the right people to have a look?\n- can you please confirm that PR works for you?\nI tested it and it looks good.\n/assign I enjoy reading my highlights to find the issue has already been addressed. :)\nSorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)\n/area build-release\nrelated to /reopen\nReopening this issue. <detailsIn response to : related to Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-dd0b19685f43a185fe11d580c2d439dfa4e87fc3b3c92232b17839e9bfd83e6f", "text": "// String is the method to format the flag's value, part of the flag.Value interface. func (c *cidrs) String() string { <del> return strings.Join(c.ipn.StringSlice(), \",\") </del> <ins> s := c.ipn.StringSlice() sort.Strings(s) return strings.Join(s, \",\") </ins> } // Set supports a value of CSV or the flag repeated multiple times", "commid": "kubernetes_pr_57008"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4b5959a3aaa5f30e123a555df8aee9d29b1dec6e0fefb212f2839a190ac1f9c", "query": "/kind bug What happened: When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in and other man pages. coming from that uses and probably sets do not have any specific order, so it would need to be sorted on output. What you expected to happen: Every build should give identical results. See https://reproducible- for why this matters. How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version: 1.7.0 OS (e.g. from /etc/os-release): openSUSE Tumbleweed\n/sig release\nsomehow this bug seems to have been forgotten - can you help getting the right people to have a look?\n- can you please confirm that PR works for you?\nI tested it and it looks good.\n/assign I enjoy reading my highlights to find the issue has already been addressed. :)\nSorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)\n/area build-release\nrelated to /reopen\nReopening this issue. <detailsIn response to : related to Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-4871295a0f9f05c0f96a6b20d582d9405c338c119ad7289d8d0dab0eae458c8b", "text": "for format := range jsonFormats { formats = append(formats, format) } <ins> sort.Strings(formats) </ins> return formats }", "commid": "kubernetes_pr_68983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4b5959a3aaa5f30e123a555df8aee9d29b1dec6e0fefb212f2839a190ac1f9c", "query": "/kind bug What happened: When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in and other man pages. coming from that uses and probably sets do not have any specific order, so it would need to be sorted on output. What you expected to happen: Every build should give identical results. See https://reproducible- for why this matters. How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version: 1.7.0 OS (e.g. from /etc/os-release): openSUSE Tumbleweed\n/sig release\nsomehow this bug seems to have been forgotten - can you help getting the right people to have a look?\n- can you please confirm that PR works for you?\nI tested it and it looks good.\n/assign I enjoy reading my highlights to find the issue has already been addressed. :)\nSorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)\n/area build-release\nrelated to /reopen\nReopening this issue. <detailsIn response to : related to Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-46dd2b6ecc3315894a96f6ff76214b59aec279b6d27cbfcc3c9dc9d8bd0d2400", "text": "printFlags := JSONPathPrintFlags{ TemplateArgument: templateArg, } <ins> if !sort.StringsAreSorted(printFlags.AllowedFormats()) { t.Fatalf(\"allowed formats are not sorted\") } </ins> p, err := printFlags.ToPrinter(tc.outputFormat) if tc.expectNoMatch {", "commid": "kubernetes_pr_68983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4b5959a3aaa5f30e123a555df8aee9d29b1dec6e0fefb212f2839a190ac1f9c", "query": "/kind bug What happened: When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in and other man pages. coming from that uses and probably sets do not have any specific order, so it would need to be sorted on output. What you expected to happen: Every build should give identical results. See https://reproducible- for why this matters. How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version: 1.7.0 OS (e.g. from /etc/os-release): openSUSE Tumbleweed\n/sig release\nsomehow this bug seems to have been forgotten - can you help getting the right people to have a look?\n- can you please confirm that PR works for you?\nI tested it and it looks good.\n/assign I enjoy reading my highlights to find the issue has already been addressed. :)\nSorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)\n/area build-release\nrelated to /reopen\nReopening this issue. <detailsIn response to : related to Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-df6d2ff1a8637e12cb455fef3fe97fc629f652bd88b7e44ad3b96f234ee063b4", "text": "TemplateArgument: &tc.templateArg, AllowMissingKeys: tc.allowMissingKeys, } <ins> if !sort.StringsAreSorted(printFlags.AllowedFormats()) { t.Fatalf(\"allowed formats are not sorted\") } </ins> outputFormat := \"jsonpath\" p, err := printFlags.ToPrinter(outputFormat)", "commid": "kubernetes_pr_68983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4b5959a3aaa5f30e123a555df8aee9d29b1dec6e0fefb212f2839a190ac1f9c", "query": "/kind bug What happened: When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in and other man pages. coming from that uses and probably sets do not have any specific order, so it would need to be sorted on output. What you expected to happen: Every build should give identical results. See https://reproducible- for why this matters. How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version: 1.7.0 OS (e.g. from /etc/os-release): openSUSE Tumbleweed\n/sig release\nsomehow this bug seems to have been forgotten - can you help getting the right people to have a look?\n- can you please confirm that PR works for you?\nI tested it and it looks good.\n/assign I enjoy reading my highlights to find the issue has already been addressed. :)\nSorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)\n/area build-release\nrelated to /reopen\nReopening this issue. <detailsIn response to : related to Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-94fb390b199f3e59402151ea026768c466ec840fa8cb46bd6f052f1699e5d7c5", "text": "import ( \"fmt\" \"io/ioutil\" <ins> \"sort\" </ins> \"strings\" \"github.com/spf13/cobra\"", "commid": "kubernetes_pr_68983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4b5959a3aaa5f30e123a555df8aee9d29b1dec6e0fefb212f2839a190ac1f9c", "query": "/kind bug What happened: When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in and other man pages. coming from that uses and probably sets do not have any specific order, so it would need to be sorted on output. What you expected to happen: Every build should give identical results. See https://reproducible- for why this matters. How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version: 1.7.0 OS (e.g. from /etc/os-release): openSUSE Tumbleweed\n/sig release\nsomehow this bug seems to have been forgotten - can you help getting the right people to have a look?\n- can you please confirm that PR works for you?\nI tested it and it looks good.\n/assign I enjoy reading my highlights to find the issue has already been addressed. :)\nSorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)\n/area build-release\nrelated to /reopen\nReopening this issue. <detailsIn response to : related to Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-85b073b847bcf21d50c96fecea75f9ae52bb8859946d9db9db8db8757e300a25", "text": "for format := range templateFormats { formats = append(formats, format) } <ins> sort.Strings(formats) </ins> return formats }", "commid": "kubernetes_pr_68983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4b5959a3aaa5f30e123a555df8aee9d29b1dec6e0fefb212f2839a190ac1f9c", "query": "/kind bug What happened: When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in and other man pages. coming from that uses and probably sets do not have any specific order, so it would need to be sorted on output. What you expected to happen: Every build should give identical results. See https://reproducible- for why this matters. How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version: 1.7.0 OS (e.g. from /etc/os-release): openSUSE Tumbleweed\n/sig release\nsomehow this bug seems to have been forgotten - can you help getting the right people to have a look?\n- can you please confirm that PR works for you?\nI tested it and it looks good.\n/assign I enjoy reading my highlights to find the issue has already been addressed. :)\nSorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)\n/area build-release\nrelated to /reopen\nReopening this issue. <detailsIn response to : related to Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-f741b7cd02657c79471641d0407a12ce85c141e7271c06a4a74897d43614e3a3", "text": "\"fmt\" \"io/ioutil\" \"os\" <ins> \"sort\" </ins> \"strings\" \"testing\"", "commid": "kubernetes_pr_68983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4b5959a3aaa5f30e123a555df8aee9d29b1dec6e0fefb212f2839a190ac1f9c", "query": "/kind bug What happened: When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in and other man pages. coming from that uses and probably sets do not have any specific order, so it would need to be sorted on output. What you expected to happen: Every build should give identical results. See https://reproducible- for why this matters. How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version: 1.7.0 OS (e.g. from /etc/os-release): openSUSE Tumbleweed\n/sig release\nsomehow this bug seems to have been forgotten - can you help getting the right people to have a look?\n- can you please confirm that PR works for you?\nI tested it and it looks good.\n/assign I enjoy reading my highlights to find the issue has already been addressed. :)\nSorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)\n/area build-release\nrelated to /reopen\nReopening this issue. <detailsIn response to : related to Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-93d52b241c0339d706ab9e98cccf6722bdb565f709f4d697db5efc073e10ff18", "text": "printFlags := GoTemplatePrintFlags{ TemplateArgument: templateArg, } <ins> if !sort.StringsAreSorted(printFlags.AllowedFormats()) { t.Fatalf(\"allowed formats are not sorted\") } </ins> p, err := printFlags.ToPrinter(tc.outputFormat) if tc.expectNoMatch {", "commid": "kubernetes_pr_68983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4b5959a3aaa5f30e123a555df8aee9d29b1dec6e0fefb212f2839a190ac1f9c", "query": "/kind bug What happened: When building kubernetes-1.7.0 packages for openSUSE, results differ for each build in and other man pages. coming from that uses and probably sets do not have any specific order, so it would need to be sorted on output. What you expected to happen: Every build should give identical results. See https://reproducible- for why this matters. How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version: 1.7.0 OS (e.g. from /etc/os-release): openSUSE Tumbleweed\n/sig release\nsomehow this bug seems to have been forgotten - can you help getting the right people to have a look?\n- can you please confirm that PR works for you?\nI tested it and it looks good.\n/assign I enjoy reading my highlights to find the issue has already been addressed. :)\nSorry this wasn't addressed sooner. It does seem like it fell into a black hole, and pinging was the right way to resolve that. :)\n/area build-release\nrelated to /reopen\nReopening this issue. <detailsIn response to : related to Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-df4158af818002642a28b24a0ad4eb4e7f0ae4154c6d7f4e4398f1710208b454", "text": "TemplateArgument: &tc.templateArg, AllowMissingKeys: tc.allowMissingKeys, } <ins> if !sort.StringsAreSorted(printFlags.AllowedFormats()) { t.Fatalf(\"allowed formats are not sorted\") } </ins> outputFormat := \"template\" p, err := printFlags.ToPrinter(outputFormat)", "commid": "kubernetes_pr_68983"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3c9ed989ba950e66c60864531514691d49ac4eeb91c62c40bd6ad56d9c2c8cd9", "query": "/kind e2e-test-failure GCE serial and GCI GCE serial started failing last evening https://k8s- https://k8s-\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/testing: Issue will be escalated to these SIGs if needed. priority/critical-urgent: Never automatically move out of a release milestone; continually escalate to contributor and SIG through all available channels. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nhttps://k8s- is still green, I would suspect something ~last Friday afternoon gets merged\nHere is what I found, after a while, the node lost their authorization to connect to API server. I believe this has the same root cause as\nI am going to revert offending pr () to see if it helps. EDIT: Looks like is in the process of reverting it:", "positive_passages": [{"docid": "doc-en-kubernetes-ce440a92dbe280fdf26e3519176d77c55176ad2810c3445224ef83df34b60eee", "text": "ETCD_QUORUM_READ: $(yaml-quote ${ETCD_QUORUM_READ}) EOF fi <ins> if [ -n \"${CLUSTER_SIGNING_DURATION:-}\" ]; then cat >>$file <<EOF CLUSTER_SIGNING_DURATION: $(yaml-quote ${CLUSTER_SIGNING_DURATION}) EOF fi </ins> else # Node-only env vars.", "commid": "kubernetes_pr_52497"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3c9ed989ba950e66c60864531514691d49ac4eeb91c62c40bd6ad56d9c2c8cd9", "query": "/kind e2e-test-failure GCE serial and GCI GCE serial started failing last evening https://k8s- https://k8s-\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/testing: Issue will be escalated to these SIGs if needed. priority/critical-urgent: Never automatically move out of a release milestone; continually escalate to contributor and SIG through all available channels. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nhttps://k8s- is still green, I would suspect something ~last Friday afternoon gets merged\nHere is what I found, after a while, the node lost their authorization to connect to API server. I believe this has the same root cause as\nI am going to revert offending pr () to see if it helps. EDIT: Looks like is in the process of reverting it:", "positive_passages": [{"docid": "doc-en-kubernetes-a04b7d54f0809a543afa23664b88430d20fa4bcc3a9ec89187e8d89c03ea6a91", "text": "# Optional: [Experiment Only] Run kube-proxy as a DaemonSet if set to true, run as static pods otherwise. KUBE_PROXY_DAEMONSET=\"${KUBE_PROXY_DAEMONSET:-false}\" # true, false <ins> # Optional: duration of cluster signed certificates. CLUSTER_SIGNING_DURATION=\"${CLUSTER_SIGNING_DURATION:-}\" </ins> # Optional: enable pod priority ENABLE_POD_PRIORITY=\"${ENABLE_POD_PRIORITY:-}\" if [[ \"${ENABLE_POD_PRIORITY}\" == \"true\" ]]; then", "commid": "kubernetes_pr_52497"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3c9ed989ba950e66c60864531514691d49ac4eeb91c62c40bd6ad56d9c2c8cd9", "query": "/kind e2e-test-failure GCE serial and GCI GCE serial started failing last evening https://k8s- https://k8s-\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/testing: Issue will be escalated to these SIGs if needed. priority/critical-urgent: Never automatically move out of a release milestone; continually escalate to contributor and SIG through all available channels. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nhttps://k8s- is still green, I would suspect something ~last Friday afternoon gets merged\nHere is what I found, after a while, the node lost their authorization to connect to API server. I believe this has the same root cause as\nI am going to revert offending pr () to see if it helps. EDIT: Looks like is in the process of reverting it:", "positive_passages": [{"docid": "doc-en-kubernetes-026986dee71135ecc84c7789c61f3de18c4050e1bedf2b5d14ba7e995fa89660", "text": "if [[ -n \"${VOLUME_PLUGIN_DIR:-}\" ]]; then params+=\" --flex-volume-plugin-dir=${VOLUME_PLUGIN_DIR}\" fi <ins> if [[ -n \"${CLUSTER_SIGNING_DURATION:-}\" ]]; then params+=\" --experimental-cluster-signing-duration=$CLUSTER_SIGNING_DURATION\" fi </ins> local -r kube_rc_docker_tag=$(cat /home/kubernetes/kube-docker-files/kube-controller-manager.docker_tag) local container_env=\"\" if [[ -n \"${ENABLE_CACHE_MUTATION_DETECTOR:-}\" ]]; then", "commid": "kubernetes_pr_52497"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-785adbfc530cee5c14decf2077a251c037f7652cdfd80a2690c7ba11c85d0253", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: BUG /kind bug What happened: Attempting to run e2e test on GCE without cluster started fails with stack trace What you expected to happen: A useful error message to be printed How to reproduce it (as minimally and precisely as possible): Without a cluster started: Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig testing /assign\nThis happens because gcloud returns an error when a resource isn't found and ginkgo- sets errexit", "positive_passages": [{"docid": "doc-en-kubernetes-94832abb959d6ef89823cf4debcfe80db092467c5488f6146f6ec9f59439eded", "text": "if [[ -z \"${KUBE_MASTER_IP-}\" ]]; then local master_address_name=\"${MASTER_NAME}-ip\" echo \"Looking for address '${master_address_name}'\" >&2 <del> KUBE_MASTER_IP=$(gcloud compute addresses describe \"${master_address_name}\"  --project \"${PROJECT}\" --region \"${REGION}\" -q --format='value(address)') fi if [[ -z \"${KUBE_MASTER_IP-}\" ]]; then echo \"Could not detect Kubernetes master node.  Make sure you've launched a cluster with 'kube-up.sh'\" >&2 exit 1 </del> <ins> if ! KUBE_MASTER_IP=$(gcloud compute addresses describe \"${master_address_name}\"  --project \"${PROJECT}\" --region \"${REGION}\" -q --format='value(address)') ||  [[ -z \"${KUBE_MASTER_IP-}\" ]]; then echo \"Could not detect Kubernetes master node.  Make sure you've launched a cluster with 'kube-up.sh'\" >&2 exit 1 fi </ins> fi echo \"Using master: $KUBE_MASTER (external IP: $KUBE_MASTER_IP)\" >&2 }", "commid": "kubernetes_pr_52489"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0830e634f1865e538fd2ea94dff87a50d196b25f52c6a6ca814f2ee175c731aa", "query": "It is possible to have multiple signals that point to the same type of resource, e.g., both SignalNodeFsAvailable and SignalAllocatableNodeFsAvailable refer to the same resource NodeFs. Change the map from map[v1.ResourceName]evictionapi.Signal to map[v1.ResourceName][]evictionapi.Signal\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/kind cleanup /priority important/soon taking a guess at labels to satisfy the milestone munger\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node sig/storage: Issue will be escalated to these SIGs if needed. priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. kind/cleanup: Adding tests, refactoring, fixing old bugs. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nLooks like the PR for this is just awaiting merge", "positive_passages": [{"docid": "doc-en-kubernetes-6440c49b0a5fd9a260072773bd2b96d68ccb409c5b4c6debc6d77a8444b151d4", "text": "} // update our local observations based on the amount reported to have been reclaimed. // note: this is optimistic, other things could have been still consuming the pressured resource in the interim. <del> signal := resourceToSignal[resourceToReclaim] value, ok := observations[signal] if !ok { glog.Errorf(\"eviction manager: unable to find value associated with signal %v\", signal) continue </del> <ins> for _, signal := range resourceClaimToSignal[resourceToReclaim] { value, ok := observations[signal] if !ok { glog.Errorf(\"eviction manager: unable to find value associated with signal %v\", signal) continue } value.available.Add(*reclaimed) </ins> } <del> value.available.Add(*reclaimed) </del> // evaluate all current thresholds to see if with adjusted observations, we think we have met min reclaim goals if len(thresholdsMet(m.thresholdsMet, observations, true)) == 0 { return true", "commid": "kubernetes_pr_47080"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0830e634f1865e538fd2ea94dff87a50d196b25f52c6a6ca814f2ee175c731aa", "query": "It is possible to have multiple signals that point to the same type of resource, e.g., both SignalNodeFsAvailable and SignalAllocatableNodeFsAvailable refer to the same resource NodeFs. Change the map from map[v1.ResourceName]evictionapi.Signal to map[v1.ResourceName][]evictionapi.Signal\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/kind cleanup /priority important/soon taking a guess at labels to satisfy the milestone munger\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node sig/storage: Issue will be escalated to these SIGs if needed. priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. kind/cleanup: Adding tests, refactoring, fixing old bugs. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nLooks like the PR for this is just awaiting merge", "positive_passages": [{"docid": "doc-en-kubernetes-e14713ea05852a077d2fdfb36cf02e28599e45e9d883b35b12e6e4ad97a91d56", "text": "} } } <ins> // TestAllocatableNodeFsPressure func TestAllocatableNodeFsPressure(t *testing.T) { podMaker := makePodWithDiskStats summaryStatsMaker := makeDiskStats podsToMake := []podToMake{ {name: \"guaranteed-low\", requests: newEphemeralStorageResourceList(\"200Mi\", \"100m\", \"1Gi\"), limits: newEphemeralStorageResourceList(\"200Mi\", \"100m\", \"1Gi\"), rootFsUsed: \"200Mi\"}, {name: \"guaranteed-high\", requests: newEphemeralStorageResourceList(\"800Mi\", \"100m\", \"1Gi\"), limits: newEphemeralStorageResourceList(\"800Mi\", \"100m\", \"1Gi\"), rootFsUsed: \"800Mi\"}, {name: \"burstable-low\", requests: newEphemeralStorageResourceList(\"300Mi\", \"100m\", \"100Mi\"), limits: newEphemeralStorageResourceList(\"300Mi\", \"200m\", \"1Gi\"), logsFsUsed: \"300Mi\"}, {name: \"burstable-high\", requests: newEphemeralStorageResourceList(\"800Mi\", \"100m\", \"100Mi\"), limits: newEphemeralStorageResourceList(\"800Mi\", \"200m\", \"1Gi\"), rootFsUsed: \"800Mi\"}, {name: \"best-effort-low\", requests: newEphemeralStorageResourceList(\"300Mi\", \"\", \"\"), limits: newEphemeralStorageResourceList(\"300Mi\", \"\", \"\"), logsFsUsed: \"300Mi\"}, {name: \"best-effort-high\", requests: newEphemeralStorageResourceList(\"800Mi\", \"\", \"\"), limits: newEphemeralStorageResourceList(\"800Mi\", \"\", \"\"), rootFsUsed: \"800Mi\"}, } pods := []*v1.Pod{} podStats := map[*v1.Pod]statsapi.PodStats{} for _, podToMake := range podsToMake { pod, podStat := podMaker(podToMake.name, podToMake.requests, podToMake.limits, podToMake.rootFsUsed, podToMake.logsFsUsed, podToMake.perLocalVolumeUsed) pods = append(pods, pod) podStats[pod] = podStat } podToEvict := pods[5] activePodsFunc := func() []*v1.Pod { return pods } fakeClock := clock.NewFakeClock(time.Now()) podKiller := &mockPodKiller{} diskInfoProvider := &mockDiskInfoProvider{dedicatedImageFs: false} capacityProvider := newMockCapacityProvider(newEphemeralStorageResourceList(\"6Gi\", \"1000m\", \"10Gi\"), newEphemeralStorageResourceList(\"1Gi\", \"1000m\", \"10Gi\")) diskGC := &mockDiskGC{imageBytesFreed: int64(0), err: nil} nodeRef := &v1.ObjectReference{Kind: \"Node\", Name: \"test\", UID: types.UID(\"test\"), Namespace: \"\"} config := Config{ MaxPodGracePeriodSeconds: 5, PressureTransitionPeriod: time.Minute * 5, Thresholds: []evictionapi.Threshold{ { Signal:   evictionapi.SignalAllocatableNodeFsAvailable, Operator: evictionapi.OpLessThan, Value: evictionapi.ThresholdValue{ Quantity: quantityMustParse(\"1Ki\"), }, }, }, } summaryProvider := &fakeSummaryProvider{result: summaryStatsMaker(\"3Gi\", \"6Gi\", podStats)} manager := &managerImpl{ clock:           fakeClock, killPodFunc:     podKiller.killPodNow, imageGC:         diskGC, containerGC:     diskGC, config:          config, recorder:        &record.FakeRecorder{}, summaryProvider: summaryProvider, nodeRef:         nodeRef, nodeConditionsLastObservedAt: nodeConditionsObservedAt{}, thresholdsFirstObservedAt:    thresholdsObservedAt{}, } // create a best effort pod to test admission bestEffortPodToAdmit, _ := podMaker(\"best-admit\", newEphemeralStorageResourceList(\"\", \"\", \"\"), newEphemeralStorageResourceList(\"\", \"\", \"\"), \"0Gi\", \"\", \"\") burstablePodToAdmit, _ := podMaker(\"burst-admit\", newEphemeralStorageResourceList(\"1Gi\", \"\", \"\"), newEphemeralStorageResourceList(\"1Gi\", \"\", \"\"), \"1Gi\", \"\", \"\") // synchronize manager.synchronize(diskInfoProvider, activePodsFunc, capacityProvider) // we should not have disk pressure if manager.IsUnderDiskPressure() { t.Fatalf(\"Manager should not report disk pressure\") } // try to admit our pods (they should succeed) expected := []bool{true, true} for i, pod := range []*v1.Pod{bestEffortPodToAdmit, burstablePodToAdmit} { if result := manager.Admit(&lifecycle.PodAdmitAttributes{Pod: pod}); expected[i] != result.Admit { t.Fatalf(\"Admit pod: %v, expected: %v, actual: %v\", pod, expected[i], result.Admit) } } // induce disk pressure! fakeClock.Step(1 * time.Minute) pod, podStat := podMaker(\"guaranteed-high-2\", newEphemeralStorageResourceList(\"2000Mi\", \"100m\", \"1Gi\"), newEphemeralStorageResourceList(\"2000Mi\", \"100m\", \"1Gi\"), \"2000Mi\", \"\", \"\") podStats[pod] = podStat pods = append(pods, pod) summaryProvider.result = summaryStatsMaker(\"6Gi\", \"6Gi\", podStats) manager.synchronize(diskInfoProvider, activePodsFunc, capacityProvider) // we should have disk pressure if !manager.IsUnderDiskPressure() { t.Fatalf(\"Manager should report disk pressure\") } // check the right pod was killed if podKiller.pod != podToEvict { t.Fatalf(\"Manager chose to kill pod: %v, but should have chosen %v\", podKiller.pod, podToEvict.Name) } observedGracePeriod := *podKiller.gracePeriodOverride if observedGracePeriod != int64(0) { t.Fatalf(\"Manager chose to kill pod with incorrect grace period.  Expected: %d, actual: %d\", 0, observedGracePeriod) } // reset state podKiller.pod = nil podKiller.gracePeriodOverride = nil // try to admit our pod (should fail) expected = []bool{false, false} for i, pod := range []*v1.Pod{bestEffortPodToAdmit, burstablePodToAdmit} { if result := manager.Admit(&lifecycle.PodAdmitAttributes{Pod: pod}); expected[i] != result.Admit { t.Fatalf(\"Admit pod: %v, expected: %v, actual: %v\", pod, expected[i], result.Admit) } } // reduce disk pressure fakeClock.Step(1 * time.Minute) pods[5] = pods[len(pods)-1] pods = pods[:len(pods)-1] // we should have disk pressure (because transition period not yet met) if !manager.IsUnderDiskPressure() { t.Fatalf(\"Manager should report disk pressure\") } // try to admit our pod (should fail) expected = []bool{false, false} for i, pod := range []*v1.Pod{bestEffortPodToAdmit, burstablePodToAdmit} { if result := manager.Admit(&lifecycle.PodAdmitAttributes{Pod: pod}); expected[i] != result.Admit { t.Fatalf(\"Admit pod: %v, expected: %v, actual: %v\", pod, expected[i], result.Admit) } } // move the clock past transition period to ensure that we stop reporting pressure fakeClock.Step(5 * time.Minute) manager.synchronize(diskInfoProvider, activePodsFunc, capacityProvider) // we should not have disk pressure (because transition period met) if manager.IsUnderDiskPressure() { t.Fatalf(\"Manager should not report disk pressure\") } // no pod should have been killed if podKiller.pod != nil { t.Fatalf(\"Manager chose to kill pod: %v when no pod should have been killed\", podKiller.pod.Name) } // all pods should admit now expected = []bool{true, true} for i, pod := range []*v1.Pod{bestEffortPodToAdmit, burstablePodToAdmit} { if result := manager.Admit(&lifecycle.PodAdmitAttributes{Pod: pod}); expected[i] != result.Admit { t.Fatalf(\"Admit pod: %v, expected: %v, actual: %v\", pod, expected[i], result.Admit) } } } func TestNodeReclaimForAllocatableFuncs(t *testing.T) { podMaker := makePodWithDiskStats summaryStatsMaker := makeDiskStats podsToMake := []podToMake{ {name: \"guaranteed-low\", requests: newEphemeralStorageResourceList(\"200Mi\", \"100m\", \"1Gi\"), limits: newEphemeralStorageResourceList(\"200Mi\", \"100m\", \"1Gi\"), rootFsUsed: \"200Mi\"}, {name: \"guaranteed-high\", requests: newEphemeralStorageResourceList(\"800Mi\", \"100m\", \"1Gi\"), limits: newEphemeralStorageResourceList(\"800Mi\", \"100m\", \"1Gi\"), rootFsUsed: \"800Mi\"}, {name: \"burstable-low\", requests: newEphemeralStorageResourceList(\"300Mi\", \"100m\", \"100Mi\"), limits: newEphemeralStorageResourceList(\"300Mi\", \"200m\", \"1Gi\"), logsFsUsed: \"300Mi\"}, {name: \"burstable-high\", requests: newEphemeralStorageResourceList(\"800Mi\", \"100m\", \"100Mi\"), limits: newEphemeralStorageResourceList(\"800Mi\", \"200m\", \"1Gi\"), rootFsUsed: \"800Mi\"}, {name: \"best-effort-low\", requests: newEphemeralStorageResourceList(\"300Mi\", \"\", \"\"), limits: newEphemeralStorageResourceList(\"300Mi\", \"\", \"\"), logsFsUsed: \"300Mi\"}, {name: \"best-effort-high\", requests: newEphemeralStorageResourceList(\"800Mi\", \"\", \"\"), limits: newEphemeralStorageResourceList(\"800Mi\", \"\", \"\"), rootFsUsed: \"800Mi\"}, } pods := []*v1.Pod{} podStats := map[*v1.Pod]statsapi.PodStats{} for _, podToMake := range podsToMake { pod, podStat := podMaker(podToMake.name, podToMake.requests, podToMake.limits, podToMake.rootFsUsed, podToMake.logsFsUsed, podToMake.perLocalVolumeUsed) pods = append(pods, pod) podStats[pod] = podStat } podToEvict := pods[5] activePodsFunc := func() []*v1.Pod { return pods } fakeClock := clock.NewFakeClock(time.Now()) podKiller := &mockPodKiller{} diskInfoProvider := &mockDiskInfoProvider{dedicatedImageFs: false} capacityProvider := newMockCapacityProvider(newEphemeralStorageResourceList(\"6Gi\", \"1000m\", \"10Gi\"), newEphemeralStorageResourceList(\"1Gi\", \"1000m\", \"10Gi\")) imageGcFree := resource.MustParse(\"800Mi\") diskGC := &mockDiskGC{imageBytesFreed: imageGcFree.Value(), err: nil} nodeRef := &v1.ObjectReference{Kind: \"Node\", Name: \"test\", UID: types.UID(\"test\"), Namespace: \"\"} config := Config{ MaxPodGracePeriodSeconds: 5, PressureTransitionPeriod: time.Minute * 5, Thresholds: []evictionapi.Threshold{ { Signal:   evictionapi.SignalAllocatableNodeFsAvailable, Operator: evictionapi.OpLessThan, Value: evictionapi.ThresholdValue{ Quantity: quantityMustParse(\"10Mi\"), }, }, }, } summaryProvider := &fakeSummaryProvider{result: summaryStatsMaker(\"6Gi\", \"6Gi\", podStats)} manager := &managerImpl{ clock:           fakeClock, killPodFunc:     podKiller.killPodNow, imageGC:         diskGC, containerGC:     diskGC, config:          config, recorder:        &record.FakeRecorder{}, summaryProvider: summaryProvider, nodeRef:         nodeRef, nodeConditionsLastObservedAt: nodeConditionsObservedAt{}, thresholdsFirstObservedAt:    thresholdsObservedAt{}, } // synchronize manager.synchronize(diskInfoProvider, activePodsFunc, capacityProvider) // we should not have disk pressure if manager.IsUnderDiskPressure() { t.Errorf(\"Manager should not report disk pressure\") } // induce hard threshold fakeClock.Step(1 * time.Minute) pod, podStat := podMaker(\"guaranteed-high-2\", newEphemeralStorageResourceList(\"2000Mi\", \"100m\", \"1Gi\"), newEphemeralStorageResourceList(\"2000Mi\", \"100m\", \"1Gi\"), \"2000Mi\", \"\", \"\") podStats[pod] = podStat pods = append(pods, pod) summaryProvider.result = summaryStatsMaker(\"6Gi\", \"6Gi\", podStats) manager.synchronize(diskInfoProvider, activePodsFunc, capacityProvider) // we should have disk pressure if !manager.IsUnderDiskPressure() { t.Fatalf(\"Manager should report disk pressure since soft threshold was met\") } // verify image gc was invoked if !diskGC.imageGCInvoked || !diskGC.containerGCInvoked { t.Fatalf(\"Manager should have invoked image gc\") } // verify no pod was killed because image gc was sufficient if podKiller.pod == nil { t.Fatalf(\"Manager should have killed a pod, but not killed\") } // check the right pod was killed if podKiller.pod != podToEvict { t.Fatalf(\"Manager chose to kill pod: %v, but should have chosen %v\", podKiller.pod, podToEvict.Name) } observedGracePeriod := *podKiller.gracePeriodOverride if observedGracePeriod != int64(0) { t.Fatalf(\"Manager chose to kill pod with incorrect grace period.  Expected: %d, actual: %d\", 0, observedGracePeriod) } // reset state diskGC.imageGCInvoked = false diskGC.containerGCInvoked = false podKiller.pod = nil podKiller.gracePeriodOverride = nil // reduce disk pressure fakeClock.Step(1 * time.Minute) pods[5] = pods[len(pods)-1] pods = pods[:len(pods)-1] // we should have disk pressure (because transition period not yet met) if !manager.IsUnderDiskPressure() { t.Fatalf(\"Manager should report disk pressure\") } // move the clock past transition period to ensure that we stop reporting pressure fakeClock.Step(5 * time.Minute) manager.synchronize(diskInfoProvider, activePodsFunc, capacityProvider) // we should not have disk pressure (because transition period met) if manager.IsUnderDiskPressure() { t.Fatalf(\"Manager should not report disk pressure\") } // no pod should have been killed if podKiller.pod != nil { t.Fatalf(\"Manager chose to kill pod: %v when no pod should have been killed\", podKiller.pod.Name) } // no image gc should have occurred if diskGC.imageGCInvoked || diskGC.containerGCInvoked { t.Errorf(\"Manager chose to perform image gc when it was not neeed\") } // no pod should have been killed if podKiller.pod != nil { t.Errorf(\"Manager chose to kill pod: %v when no pod should have been killed\", podKiller.pod.Name) } } </ins>", "commid": "kubernetes_pr_47080"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0830e634f1865e538fd2ea94dff87a50d196b25f52c6a6ca814f2ee175c731aa", "query": "It is possible to have multiple signals that point to the same type of resource, e.g., both SignalNodeFsAvailable and SignalAllocatableNodeFsAvailable refer to the same resource NodeFs. Change the map from map[v1.ResourceName]evictionapi.Signal to map[v1.ResourceName][]evictionapi.Signal\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/kind cleanup /priority important/soon taking a guess at labels to satisfy the milestone munger\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node sig/storage: Issue will be escalated to these SIGs if needed. priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. kind/cleanup: Adding tests, refactoring, fixing old bugs. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nLooks like the PR for this is just awaiting merge", "positive_passages": [{"docid": "doc-en-kubernetes-fd82dd50b6bcf95cef44ad4f7e94b9e2e2914f8c49b6e666cd3c5bfbeeca5126", "text": "signalToNodeCondition map[evictionapi.Signal]v1.NodeConditionType // signalToResource maps a Signal to its associated Resource. signalToResource map[evictionapi.Signal]v1.ResourceName <del> // resourceToSignal maps a Resource to its associated Signal resourceToSignal map[v1.ResourceName]evictionapi.Signal </del> <ins> // resourceClaimToSignal maps a Resource that can be reclaimed to its associated Signal resourceClaimToSignal map[v1.ResourceName][]evictionapi.Signal </ins> ) func init() {", "commid": "kubernetes_pr_47080"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0830e634f1865e538fd2ea94dff87a50d196b25f52c6a6ca814f2ee175c731aa", "query": "It is possible to have multiple signals that point to the same type of resource, e.g., both SignalNodeFsAvailable and SignalAllocatableNodeFsAvailable refer to the same resource NodeFs. Change the map from map[v1.ResourceName]evictionapi.Signal to map[v1.ResourceName][]evictionapi.Signal\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/kind cleanup /priority important/soon taking a guess at labels to satisfy the milestone munger\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node sig/storage: Issue will be escalated to these SIGs if needed. priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. kind/cleanup: Adding tests, refactoring, fixing old bugs. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nLooks like the PR for this is just awaiting merge", "positive_passages": [{"docid": "doc-en-kubernetes-d07baa431fd1083d65aee2586889f47e96b4c02e18917206d603412412f5e325", "text": "signalToResource[evictionapi.SignalNodeFsAvailable] = resourceNodeFs signalToResource[evictionapi.SignalNodeFsInodesFree] = resourceNodeFsInodes <del> resourceToSignal = map[v1.ResourceName]evictionapi.Signal{} for key, value := range signalToResource { resourceToSignal[value] = key } // Hard-code here to make sure resourceNodeFs maps to evictionapi.SignalNodeFsAvailable // (TODO) resourceToSignal is a map from resource name to a list of signals resourceToSignal[resourceNodeFs] = evictionapi.SignalNodeFsAvailable </del> <ins> // maps resource to signals (the following resource could be reclaimed) resourceClaimToSignal = map[v1.ResourceName][]evictionapi.Signal{} resourceClaimToSignal[resourceNodeFs] = []evictionapi.Signal{evictionapi.SignalNodeFsAvailable} resourceClaimToSignal[resourceImageFs] = []evictionapi.Signal{evictionapi.SignalImageFsAvailable} resourceClaimToSignal[resourceNodeFsInodes] = []evictionapi.Signal{evictionapi.SignalNodeFsInodesFree} resourceClaimToSignal[resourceImageFsInodes] = []evictionapi.Signal{evictionapi.SignalImageFsInodesFree} </ins> } // validSignal returns true if the signal is supported.", "commid": "kubernetes_pr_47080"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0830e634f1865e538fd2ea94dff87a50d196b25f52c6a6ca814f2ee175c731aa", "query": "It is possible to have multiple signals that point to the same type of resource, e.g., both SignalNodeFsAvailable and SignalAllocatableNodeFsAvailable refer to the same resource NodeFs. Change the map from map[v1.ResourceName]evictionapi.Signal to map[v1.ResourceName][]evictionapi.Signal\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/kind cleanup /priority important/soon taking a guess at labels to satisfy the milestone munger\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node sig/storage: Issue will be escalated to these SIGs if needed. priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. kind/cleanup: Adding tests, refactoring, fixing old bugs. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nLooks like the PR for this is just awaiting merge", "positive_passages": [{"docid": "doc-en-kubernetes-bf1e669406473df5d1140f1a553db16dca03942432fee2c9d85b86bcacbf72d6", "text": "return res } <ins> func newEphemeralStorageResourceList(ephemeral, cpu, memory string) v1.ResourceList { res := v1.ResourceList{} if ephemeral != \"\" { res[v1.ResourceEphemeralStorage] = resource.MustParse(ephemeral) } if cpu != \"\" { res[v1.ResourceCPU] = resource.MustParse(cpu) } if memory != \"\" { res[v1.ResourceMemory] = resource.MustParse(\"1Mi\") } return res } </ins> func newResourceRequirements(requests, limits v1.ResourceList) v1.ResourceRequirements { res := v1.ResourceRequirements{} res.Requests = requests", "commid": "kubernetes_pr_47080"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc43a974ea2ea04c522d44e3808a2250bd460e5bc91555a60b00d399968fd9cf", "query": "Currently, always returns with 0 exit code no matter the test fails or not. We should fix it to return non-zero exit code for test failure.", "positive_passages": [{"docid": "doc-en-kubernetes-b7aa6d9434c50c7f1a7e78a1cdb22be3995f9e47b2f8c4e7afba250ea5fda447", "text": "ginkgo := filepath.Join(outputDir, \"ginkgo\") test := filepath.Join(outputDir, \"e2e_node.test\") <del> if *systemSpecName == \"\" { runCommand(ginkgo, *ginkgoFlags, test, \"--\", *testFlags) return </del> <ins> args := []string{*ginkgoFlags, test, \"--\", *testFlags} if *systemSpecName != \"\" { rootDir, err := builder.GetK8sRootDir() if err != nil { glog.Fatalf(\"Failed to get k8s root directory: %v\", err) } systemSpecFile := filepath.Join(rootDir, systemSpecPath, *systemSpecName+\".yaml\") args = append(args, fmt.Sprintf(\"--system-spec-name=%s --system-spec-file=%s\", *systemSpecName, systemSpecFile)) </ins> } <del> rootDir, err := builder.GetK8sRootDir() if err != nil { glog.Fatalf(\"Failed to get k8s root directory: %v\", err) </del> <ins> if err := runCommand(ginkgo, args...); err != nil { glog.Exitf(\"Test failed: %v\", err) </ins> } <del> systemSpecFile := filepath.Join(rootDir, systemSpecPath, *systemSpecName+\".yaml\") runCommand(ginkgo, *ginkgoFlags, test, \"--\", fmt.Sprintf(\"--system-spec-name=%s --system-spec-file=%s\", *systemSpecName, systemSpecFile), *testFlags) </del> return }", "commid": "kubernetes_pr_52606"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9d96fadb6189b5bf3a00e3a1630f8f9a54b4f5aca0ead084364dd1f5a8e0cb0d", "query": "When pod is evicted, pod is terminated. After this change , attach/detach controller should be able to detach the pod correctly so that new pod which uses the same volume will start up. We need to have an e2e test for this scenario.\nwhat environment is good for this e2e test? GCE or GKE or AWS? I see we have which has func, Can you comment on why is insufficient to cover this issue?\ndoes the pod need to be evicted? Or would be ok to delete the pod and then check that the PD is detached. Then create a new pod using the same PD and test that it attaches?\n[MILESTONENOTIFIER] Milestone Removed Important: This issue was missing labels required for the v1.9 milestone for more than 3 days: kind: Must specify exactly one of , or . <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nping ^^\nsorry for the delay. Here we want to test the detach behavior of evicted pods. So delete a pod directly is different from it. When Pod is evicted, the containers will be killed and the pod status is terminated. But the pod api object is not deleted from API server. Before PR , such evicted pods will not trigger detach operation because the pod api object is not deleted from api server. So the purpose of the test is to make sure detach operation is triggered for such evicted pods.\nThanks Do you have a suggestion for how to force a pod to be evicted?\nYou could have the pod do some memory intensive application\nah, like my use of in the io-streaming pr :-)\n- Here's another option to cause eviction: .", "positive_passages": [{"docid": "doc-en-kubernetes-efecb8bc24c66fbea89a9b7b2c04a9e048dbf063988fec5a45155c37cf02855b", "text": "\"//vendor/google.golang.org/api/googleapi:go_default_library\", \"//vendor/k8s.io/api/batch/v1:go_default_library\", \"//vendor/k8s.io/api/core/v1:go_default_library\", <ins> \"//vendor/k8s.io/api/policy/v1beta1:go_default_library\", </ins> \"//vendor/k8s.io/api/rbac/v1beta1:go_default_library\", \"//vendor/k8s.io/api/storage/v1:go_default_library\", \"//vendor/k8s.io/api/storage/v1beta1:go_default_library\",", "commid": "kubernetes_pr_54207"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9d96fadb6189b5bf3a00e3a1630f8f9a54b4f5aca0ead084364dd1f5a8e0cb0d", "query": "When pod is evicted, pod is terminated. After this change , attach/detach controller should be able to detach the pod correctly so that new pod which uses the same volume will start up. We need to have an e2e test for this scenario.\nwhat environment is good for this e2e test? GCE or GKE or AWS? I see we have which has func, Can you comment on why is insufficient to cover this issue?\ndoes the pod need to be evicted? Or would be ok to delete the pod and then check that the PD is detached. Then create a new pod using the same PD and test that it attaches?\n[MILESTONENOTIFIER] Milestone Removed Important: This issue was missing labels required for the v1.9 milestone for more than 3 days: kind: Must specify exactly one of , or . <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nping ^^\nsorry for the delay. Here we want to test the detach behavior of evicted pods. So delete a pod directly is different from it. When Pod is evicted, the containers will be killed and the pod status is terminated. But the pod api object is not deleted from API server. Before PR , such evicted pods will not trigger detach operation because the pod api object is not deleted from api server. So the purpose of the test is to make sure detach operation is triggered for such evicted pods.\nThanks Do you have a suggestion for how to force a pod to be evicted?\nYou could have the pod do some memory intensive application\nah, like my use of in the io-streaming pr :-)\n- Here's another option to cause eviction: .", "positive_passages": [{"docid": "doc-en-kubernetes-5c5fccf8838252cc231e69e116dd177b928351a14bb6da2170f37413c6b4524f", "text": ". \"github.com/onsi/ginkgo\" . \"github.com/onsi/gomega\" \"k8s.io/api/core/v1\" <ins> policy \"k8s.io/api/policy/v1beta1\" </ins> \"k8s.io/apimachinery/pkg/api/resource\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/types\" \"k8s.io/apimachinery/pkg/util/uuid\" <ins> \"k8s.io/apimachinery/pkg/util/wait\" </ins> clientset \"k8s.io/client-go/kubernetes\" v1core \"k8s.io/client-go/kubernetes/typed/core/v1\" \"k8s.io/kubernetes/pkg/api/testapi\"", "commid": "kubernetes_pr_54207"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9d96fadb6189b5bf3a00e3a1630f8f9a54b4f5aca0ead084364dd1f5a8e0cb0d", "query": "When pod is evicted, pod is terminated. After this change , attach/detach controller should be able to detach the pod correctly so that new pod which uses the same volume will start up. We need to have an e2e test for this scenario.\nwhat environment is good for this e2e test? GCE or GKE or AWS? I see we have which has func, Can you comment on why is insufficient to cover this issue?\ndoes the pod need to be evicted? Or would be ok to delete the pod and then check that the PD is detached. Then create a new pod using the same PD and test that it attaches?\n[MILESTONENOTIFIER] Milestone Removed Important: This issue was missing labels required for the v1.9 milestone for more than 3 days: kind: Must specify exactly one of , or . <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nping ^^\nsorry for the delay. Here we want to test the detach behavior of evicted pods. So delete a pod directly is different from it. When Pod is evicted, the containers will be killed and the pod status is terminated. But the pod api object is not deleted from API server. Before PR , such evicted pods will not trigger detach operation because the pod api object is not deleted from api server. So the purpose of the test is to make sure detach operation is triggered for such evicted pods.\nThanks Do you have a suggestion for how to force a pod to be evicted?\nYou could have the pod do some memory intensive application\nah, like my use of in the io-streaming pr :-)\n- Here's another option to cause eviction: .", "positive_passages": [{"docid": "doc-en-kubernetes-00e9a79930da90ae9ce7d60ffa247b9924b2abf6d81e3e15d0cb81678629db4b", "text": "gcePDDetachPollTime = 10 * time.Second nodeStatusTimeout   = 10 * time.Minute nodeStatusPollTime  = 1 * time.Second <ins> podEvictTimeout     = 2 * time.Minute </ins> maxReadRetry        = 3 minNodes            = 2 ) var _ = SIGDescribe(\"Pod Disks\", func() { var ( <ins> ns         string cs         clientset.Interface </ins> podClient  v1core.PodInterface nodeClient v1core.NodeInterface host0Name  types.NodeName", "commid": "kubernetes_pr_54207"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9d96fadb6189b5bf3a00e3a1630f8f9a54b4f5aca0ead084364dd1f5a8e0cb0d", "query": "When pod is evicted, pod is terminated. After this change , attach/detach controller should be able to detach the pod correctly so that new pod which uses the same volume will start up. We need to have an e2e test for this scenario.\nwhat environment is good for this e2e test? GCE or GKE or AWS? I see we have which has func, Can you comment on why is insufficient to cover this issue?\ndoes the pod need to be evicted? Or would be ok to delete the pod and then check that the PD is detached. Then create a new pod using the same PD and test that it attaches?\n[MILESTONENOTIFIER] Milestone Removed Important: This issue was missing labels required for the v1.9 milestone for more than 3 days: kind: Must specify exactly one of , or . <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nping ^^\nsorry for the delay. Here we want to test the detach behavior of evicted pods. So delete a pod directly is different from it. When Pod is evicted, the containers will be killed and the pod status is terminated. But the pod api object is not deleted from API server. Before PR , such evicted pods will not trigger detach operation because the pod api object is not deleted from api server. So the purpose of the test is to make sure detach operation is triggered for such evicted pods.\nThanks Do you have a suggestion for how to force a pod to be evicted?\nYou could have the pod do some memory intensive application\nah, like my use of in the io-streaming pr :-)\n- Here's another option to cause eviction: .", "positive_passages": [{"docid": "doc-en-kubernetes-4402d491801f62d390f12c43ba4861a74ca1ec3d60bd270668a6292a0e9b8ff0", "text": "BeforeEach(func() { framework.SkipUnlessNodeCountIsAtLeast(minNodes) <ins> cs = f.ClientSet ns = f.Namespace.Name </ins> <del> podClient = f.ClientSet.Core().Pods(f.Namespace.Name) nodeClient = f.ClientSet.Core().Nodes() nodes = framework.GetReadySchedulableNodesOrDie(f.ClientSet) </del> <ins> podClient = cs.Core().Pods(ns) nodeClient = cs.Core().Nodes() nodes = framework.GetReadySchedulableNodesOrDie(cs) </ins> Expect(len(nodes.Items)).To(BeNumerically(\">=\", minNodes), fmt.Sprintf(\"Requires at least %d nodes\", minNodes)) host0Name = types.NodeName(nodes.Items[0].ObjectMeta.Name) host1Name = types.NodeName(nodes.Items[1].ObjectMeta.Name)", "commid": "kubernetes_pr_54207"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9d96fadb6189b5bf3a00e3a1630f8f9a54b4f5aca0ead084364dd1f5a8e0cb0d", "query": "When pod is evicted, pod is terminated. After this change , attach/detach controller should be able to detach the pod correctly so that new pod which uses the same volume will start up. We need to have an e2e test for this scenario.\nwhat environment is good for this e2e test? GCE or GKE or AWS? I see we have which has func, Can you comment on why is insufficient to cover this issue?\ndoes the pod need to be evicted? Or would be ok to delete the pod and then check that the PD is detached. Then create a new pod using the same PD and test that it attaches?\n[MILESTONENOTIFIER] Milestone Removed Important: This issue was missing labels required for the v1.9 milestone for more than 3 days: kind: Must specify exactly one of , or . <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nping ^^\nsorry for the delay. Here we want to test the detach behavior of evicted pods. So delete a pod directly is different from it. When Pod is evicted, the containers will be killed and the pod status is terminated. But the pod api object is not deleted from API server. Before PR , such evicted pods will not trigger detach operation because the pod api object is not deleted from api server. So the purpose of the test is to make sure detach operation is triggered for such evicted pods.\nThanks Do you have a suggestion for how to force a pod to be evicted?\nYou could have the pod do some memory intensive application\nah, like my use of in the io-streaming pr :-)\n- Here's another option to cause eviction: .", "positive_passages": [{"docid": "doc-en-kubernetes-8a8702c8bf76bf3595cbdb5e90050141f2ee4221ab28bbe7178615b23713fe6c", "text": "} }) <del> Context(\"detach from a disrupted node [Slow] [Disruptive]\", func() { </del> <ins> Context(\"detach in a disrupted environment [Slow] [Disruptive]\", func() { </ins> const ( deleteNode    = 1 // delete physical node deleteNodeObj = 2 // delete node's api object only <ins> evictPod      = 3 // evict host0Pod on node0 </ins> ) type testT struct { <del> descr  string // It description nodeOp int    // disruptive operation performed on target node </del> <ins> descr     string // It description disruptOp int    // disruptive operation performed on target node </ins> } tests := []testT{ { <del> descr:  \"node is deleted\", nodeOp: deleteNode, </del> <ins> descr:     \"node is deleted\", disruptOp: deleteNode, </ins> }, { <del> descr:  \"node's API object is deleted\", nodeOp: deleteNodeObj, </del> <ins> descr:     \"node's API object is deleted\", disruptOp: deleteNodeObj, }, { descr:     \"pod is evicted\", disruptOp: evictPod, </ins> }, } for _, t := range tests { <del> nodeOp := t.nodeOp </del> <ins> disruptOp := t.disruptOp </ins> It(fmt.Sprintf(\"when %s\", t.descr), func() { framework.SkipUnlessProviderIs(\"gce\") origNodeCnt := len(nodes.Items) // healhy nodes running kublet", "commid": "kubernetes_pr_54207"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9d96fadb6189b5bf3a00e3a1630f8f9a54b4f5aca0ead084364dd1f5a8e0cb0d", "query": "When pod is evicted, pod is terminated. After this change , attach/detach controller should be able to detach the pod correctly so that new pod which uses the same volume will start up. We need to have an e2e test for this scenario.\nwhat environment is good for this e2e test? GCE or GKE or AWS? I see we have which has func, Can you comment on why is insufficient to cover this issue?\ndoes the pod need to be evicted? Or would be ok to delete the pod and then check that the PD is detached. Then create a new pod using the same PD and test that it attaches?\n[MILESTONENOTIFIER] Milestone Removed Important: This issue was missing labels required for the v1.9 milestone for more than 3 days: kind: Must specify exactly one of , or . <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nping ^^\nsorry for the delay. Here we want to test the detach behavior of evicted pods. So delete a pod directly is different from it. When Pod is evicted, the containers will be killed and the pod status is terminated. But the pod api object is not deleted from API server. Before PR , such evicted pods will not trigger detach operation because the pod api object is not deleted from api server. So the purpose of the test is to make sure detach operation is triggered for such evicted pods.\nThanks Do you have a suggestion for how to force a pod to be evicted?\nYou could have the pod do some memory intensive application\nah, like my use of in the io-streaming pr :-)\n- Here's another option to cause eviction: .", "positive_passages": [{"docid": "doc-en-kubernetes-ccde8a5160dee571884a22dc34a09569874621e3623858178de8d50fcba79194", "text": "diskName, err := framework.CreatePDWithRetry() framework.ExpectNoError(err, \"Error creating a pd\") <del> targetNode := &nodes.Items[0] </del> <ins> targetNode := &nodes.Items[0] // for node delete ops </ins> host0Pod := testPDPod([]string{diskName}, host0Name, false, 1) containerName := \"mycontainer\" defer func() { By(\"defer: cleaning up PD-RW test env\") framework.Logf(\"defer cleanup errors can usually be ignored\") <del> if nodeOp == deleteNode { podClient.Delete(host0Pod.Name, metav1.NewDeleteOptions(0)) } </del> <ins> By(\"defer: delete host0Pod\") podClient.Delete(host0Pod.Name, metav1.NewDeleteOptions(0)) By(\"defer: detach and delete PDs\") </ins> detachAndDeletePDs(diskName, []types.NodeName{host0Name}) <del> if nodeOp == deleteNodeObj { targetNode.ObjectMeta.SetResourceVersion(\"0\") // need to set the resource version or else the Create() fails _, err := nodeClient.Create(targetNode) framework.ExpectNoError(err, \"defer: Unable to re-create the deleted node\") </del> <ins> if disruptOp == deleteNode || disruptOp == deleteNodeObj { if disruptOp == deleteNodeObj { targetNode.ObjectMeta.SetResourceVersion(\"0\") // need to set the resource version or else the Create() fails By(\"defer: re-create host0 node object\") _, err := nodeClient.Create(targetNode) framework.ExpectNoError(err, fmt.Sprintf(\"defer: Unable to re-create the deleted node object %q\", targetNode.Name)) } By(\"defer: verify the number of ready nodes\") numNodes := countReadyNodes(cs, host0Name) // if this defer is reached due to an Expect then nested // Expects are lost, so use Failf here if numNodes != origNodeCnt { framework.Failf(\"defer: Requires current node count (%d) to return to original node count (%d)\", numNodes, origNodeCnt) } </ins> } <del> numNodes := countReadyNodes(f.ClientSet, host0Name) Expect(numNodes).To(Equal(origNodeCnt), fmt.Sprintf(\"defer: Requires current node count (%d) to return to original node count (%d)\", numNodes, origNodeCnt)) </del> }() By(\"creating host0Pod on node0\") _, err = podClient.Create(host0Pod) framework.ExpectNoError(err, fmt.Sprintf(\"Failed to create host0Pod: %v\", err)) <ins> By(\"waiting for host0Pod to be running\") </ins> framework.ExpectNoError(f.WaitForPodRunningSlow(host0Pod.Name)) By(\"writing content to host0Pod\")", "commid": "kubernetes_pr_54207"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9d96fadb6189b5bf3a00e3a1630f8f9a54b4f5aca0ead084364dd1f5a8e0cb0d", "query": "When pod is evicted, pod is terminated. After this change , attach/detach controller should be able to detach the pod correctly so that new pod which uses the same volume will start up. We need to have an e2e test for this scenario.\nwhat environment is good for this e2e test? GCE or GKE or AWS? I see we have which has func, Can you comment on why is insufficient to cover this issue?\ndoes the pod need to be evicted? Or would be ok to delete the pod and then check that the PD is detached. Then create a new pod using the same PD and test that it attaches?\n[MILESTONENOTIFIER] Milestone Removed Important: This issue was missing labels required for the v1.9 milestone for more than 3 days: kind: Must specify exactly one of , or . <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nping ^^\nsorry for the delay. Here we want to test the detach behavior of evicted pods. So delete a pod directly is different from it. When Pod is evicted, the containers will be killed and the pod status is terminated. But the pod api object is not deleted from API server. Before PR , such evicted pods will not trigger detach operation because the pod api object is not deleted from api server. So the purpose of the test is to make sure detach operation is triggered for such evicted pods.\nThanks Do you have a suggestion for how to force a pod to be evicted?\nYou could have the pod do some memory intensive application\nah, like my use of in the io-streaming pr :-)\n- Here's another option to cause eviction: .", "positive_passages": [{"docid": "doc-en-kubernetes-3a6b1f48929585865eae903b5c108daaf849474c8b2cba29b9f56637ac0bb610", "text": "By(\"verifying PD is present in node0's VolumeInUse list\") framework.ExpectNoError(waitForPDInVolumesInUse(nodeClient, diskName, host0Name, nodeStatusTimeout, true /* should exist*/)) <del> if nodeOp == deleteNode { </del> <ins> if disruptOp == deleteNode { </ins> By(\"getting gce instances\") gceCloud, err := framework.GetGCECloud() framework.ExpectNoError(err, fmt.Sprintf(\"Unable to create gcloud client err=%v\", err))", "commid": "kubernetes_pr_54207"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9d96fadb6189b5bf3a00e3a1630f8f9a54b4f5aca0ead084364dd1f5a8e0cb0d", "query": "When pod is evicted, pod is terminated. After this change , attach/detach controller should be able to detach the pod correctly so that new pod which uses the same volume will start up. We need to have an e2e test for this scenario.\nwhat environment is good for this e2e test? GCE or GKE or AWS? I see we have which has func, Can you comment on why is insufficient to cover this issue?\ndoes the pod need to be evicted? Or would be ok to delete the pod and then check that the PD is detached. Then create a new pod using the same PD and test that it attaches?\n[MILESTONENOTIFIER] Milestone Removed Important: This issue was missing labels required for the v1.9 milestone for more than 3 days: kind: Must specify exactly one of , or . <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nping ^^\nsorry for the delay. Here we want to test the detach behavior of evicted pods. So delete a pod directly is different from it. When Pod is evicted, the containers will be killed and the pod status is terminated. But the pod api object is not deleted from API server. Before PR , such evicted pods will not trigger detach operation because the pod api object is not deleted from api server. So the purpose of the test is to make sure detach operation is triggered for such evicted pods.\nThanks Do you have a suggestion for how to force a pod to be evicted?\nYou could have the pod do some memory intensive application\nah, like my use of in the io-streaming pr :-)\n- Here's another option to cause eviction: .", "positive_passages": [{"docid": "doc-en-kubernetes-0350eeecc160d452781d8d58cf9c30ee0996fd7eb196440e1a23aa8a31fc7a03", "text": "By(\"deleting host0\") resp, err := gceCloud.DeleteInstance(framework.TestContext.CloudConfig.ProjectID, framework.TestContext.CloudConfig.Zone, string(host0Name)) framework.ExpectNoError(err, fmt.Sprintf(\"Failed to delete host0Pod: err=%v response=%#v\", err, resp)) <del> By(\"expecting host0 node to be recreated\") numNodes := countReadyNodes(f.ClientSet, host0Name) </del> <ins> By(\"expecting host0 node to be re-created\") numNodes := countReadyNodes(cs, host0Name) </ins> Expect(numNodes).To(Equal(origNodeCnt), fmt.Sprintf(\"Requires current node count (%d) to return to original node count (%d)\", numNodes, origNodeCnt)) output, err = gceCloud.ListInstanceNames(framework.TestContext.CloudConfig.ProjectID, framework.TestContext.CloudConfig.Zone) framework.ExpectNoError(err, fmt.Sprintf(\"Unable to get list of node instances err=%v output=%s\", err, output)) Expect(false, strings.Contains(string(output), string(host0Name))) <del> } else if nodeOp == deleteNodeObj { </del> <ins> } else if disruptOp == deleteNodeObj { </ins> By(\"deleting host0's node api object\") framework.ExpectNoError(nodeClient.Delete(string(host0Name), metav1.NewDeleteOptions(0)), \"Unable to delete host0's node object\") By(\"deleting host0Pod\") framework.ExpectNoError(podClient.Delete(host0Pod.Name, metav1.NewDeleteOptions(0)), \"Unable to delete host0Pod\") <ins> } else if disruptOp == evictPod { evictTarget := &policy.Eviction{ ObjectMeta: metav1.ObjectMeta{ Name:      host0Pod.Name, Namespace: ns, }, } By(\"evicting host0Pod\") err = wait.PollImmediate(framework.Poll, podEvictTimeout, func() (bool, error) { err = cs.CoreV1().Pods(ns).Evict(evictTarget) if err != nil { return false, nil } else { return true, nil } }) Expect(err).NotTo(HaveOccurred(), fmt.Sprintf(\"failed to evict host0Pod after %v\", podEvictTimeout)) </ins> } By(\"waiting for pd to detach from host0\")", "commid": "kubernetes_pr_54207"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-878b3413520069a3d3965eb764a7edb4e0bab274ced2a3e5ddfa2f3f07c0e15b", "query": "/kind bug What happened: When a cluster is provisioned using a containerised kubelet using the following images: Pods with PVCs are not created because kubelet cannot mount the disks. If you look at events, you can see that it's missing some binaries: This executable is . This problem can be resolved by mounting paths from the host into the rkt container, specifically and . Is this expected? mentioned in , that mounting operations are moving out from the main process into containers. Is this part of that effort? This caught me quite unexpected, and I didn't find any docs or changelog entries which indicated additional host mounts were necessary. If it's deliberate, I can close this until we perhaps document the breaking change. Is there a good place where we can document this? If it's not, I'll leave this open as a tracking issue. What you expected to happen: The hyperkube image to work without lots of host mounts. How to reproduce it (as minimally and precisely as possible): Run kubelet with rkt in one of the above listed images (see CoreOS' ). Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OpenStack OS (e.g. from /etc/os-release):Kernel (e.g. ):Install tools: tectonic-installer\n/sig storage /sig node\nSeems the base hyperkube image was changed: done in /cc\nThe pkg/util/mount/mount_linux source defaults to ext4 if a fstype is not selected. It makes sense to restore the e2fsprogs package within the hyperkube image.\ncc cc cc This seems like something that should be in the 1.8 milestone. Can someone who owns the hyperkube image comment on that?\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node sig/storage: Issue will be escalated to these SIGs if needed. priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nContainerization of mount is not going to happen until 1.9 at the earliest. So if hyperkube is broken, it should be fixed before ship.\n\"modprobe\" also went missing in 1.8 hyperkube images... Both kubelet and kube-proxy need it.\nAre you noticing any buggy behaviour on those components without it? Would you mind creating an issue and/or PR to restore that dep\nDone: And done: :)", "positive_passages": [{"docid": "doc-en-kubernetes-ce5b1f06889176d6d93326c844d38ab479efd5b503ec9251ca81e8c5cac45bae", "text": "RUN echo CACHEBUST>/dev/null && clean-install  iptables  <ins> e2fsprogs  </ins> ebtables  ethtool  ca-certificates ", "commid": "kubernetes_pr_52798"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-878b3413520069a3d3965eb764a7edb4e0bab274ced2a3e5ddfa2f3f07c0e15b", "query": "/kind bug What happened: When a cluster is provisioned using a containerised kubelet using the following images: Pods with PVCs are not created because kubelet cannot mount the disks. If you look at events, you can see that it's missing some binaries: This executable is . This problem can be resolved by mounting paths from the host into the rkt container, specifically and . Is this expected? mentioned in , that mounting operations are moving out from the main process into containers. Is this part of that effort? This caught me quite unexpected, and I didn't find any docs or changelog entries which indicated additional host mounts were necessary. If it's deliberate, I can close this until we perhaps document the breaking change. Is there a good place where we can document this? If it's not, I'll leave this open as a tracking issue. What you expected to happen: The hyperkube image to work without lots of host mounts. How to reproduce it (as minimally and precisely as possible): Run kubelet with rkt in one of the above listed images (see CoreOS' ). Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OpenStack OS (e.g. from /etc/os-release):Kernel (e.g. ):Install tools: tectonic-installer\n/sig storage /sig node\nSeems the base hyperkube image was changed: done in /cc\nThe pkg/util/mount/mount_linux source defaults to ext4 if a fstype is not selected. It makes sense to restore the e2fsprogs package within the hyperkube image.\ncc cc cc This seems like something that should be in the 1.8 milestone. Can someone who owns the hyperkube image comment on that?\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node sig/storage: Issue will be escalated to these SIGs if needed. priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nContainerization of mount is not going to happen until 1.9 at the earliest. So if hyperkube is broken, it should be fixed before ship.\n\"modprobe\" also went missing in 1.8 hyperkube images... Both kubelet and kube-proxy need it.\nAre you noticing any buggy behaviour on those components without it? Would you mind creating an issue and/or PR to restore that dep\nDone: And done: :)", "positive_passages": [{"docid": "doc-en-kubernetes-3a904304d6af11bd7ebd679be08d5dc3d915f3a62076b6a108f26ad56c84c648", "text": "REGISTRY?=gcr.io/google-containers IMAGE?=debian-hyperkube-base <del> TAG=0.2 </del> <ins> TAG=0.3 </ins> ARCH?=amd64 CACHEBUST?=1", "commid": "kubernetes_pr_52798"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-878b3413520069a3d3965eb764a7edb4e0bab274ced2a3e5ddfa2f3f07c0e15b", "query": "/kind bug What happened: When a cluster is provisioned using a containerised kubelet using the following images: Pods with PVCs are not created because kubelet cannot mount the disks. If you look at events, you can see that it's missing some binaries: This executable is . This problem can be resolved by mounting paths from the host into the rkt container, specifically and . Is this expected? mentioned in , that mounting operations are moving out from the main process into containers. Is this part of that effort? This caught me quite unexpected, and I didn't find any docs or changelog entries which indicated additional host mounts were necessary. If it's deliberate, I can close this until we perhaps document the breaking change. Is there a good place where we can document this? If it's not, I'll leave this open as a tracking issue. What you expected to happen: The hyperkube image to work without lots of host mounts. How to reproduce it (as minimally and precisely as possible): Run kubelet with rkt in one of the above listed images (see CoreOS' ). Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OpenStack OS (e.g. from /etc/os-release):Kernel (e.g. ):Install tools: tectonic-installer\n/sig storage /sig node\nSeems the base hyperkube image was changed: done in /cc\nThe pkg/util/mount/mount_linux source defaults to ext4 if a fstype is not selected. It makes sense to restore the e2fsprogs package within the hyperkube image.\ncc cc cc This seems like something that should be in the 1.8 milestone. Can someone who owns the hyperkube image comment on that?\n[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node sig/storage: Issue will be escalated to these SIGs if needed. priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=\"\"here</aThe commands available for adding these labels are documented <a href=\"\"here</a</details\nContainerization of mount is not going to happen until 1.9 at the earliest. So if hyperkube is broken, it should be fixed before ship.\n\"modprobe\" also went missing in 1.8 hyperkube images... Both kubelet and kube-proxy need it.\nAre you noticing any buggy behaviour on those components without it? Would you mind creating an issue and/or PR to restore that dep\nDone: And done: :)", "positive_passages": [{"docid": "doc-en-kubernetes-7eb759d928b619ad8d24f58a91aa5a1a1c84845c963070732a9e6f8c605fb3ac", "text": "ARCH?=amd64 HYPERKUBE_BIN?=_output/dockerized/bin/linux/$(ARCH)/hyperkube <del> BASEIMAGE=gcr.io/google-containers/debian-hyperkube-base-$(ARCH):0.2 </del> <ins> BASEIMAGE=gcr.io/google-containers/debian-hyperkube-base-$(ARCH):0.3 </ins> TEMP_DIR:=$(shell mktemp -d -t hyperkubeXXXXXX) all: build", "commid": "kubernetes_pr_52798"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-141ad298529fc52bdd1d978ad80ddba1c5d4febe5b6ef954b2a124b684d72c89", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: my yaml: exec kubectl set resources command,just update first object: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig cli\n/kind bug\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-2fafe9b6116bda8684ea5d3336b34c8c9e183a44ad04a16725e1cd577382a691", "text": "} if len(o.Output) > 0 { <del> return o.PrintObject(o.Cmd, o.Local, o.Mapper, obj, o.Out) </del> <ins> if err := o.PrintObject(o.Cmd, o.Local, o.Mapper, obj, o.Out); err != nil { return err } continue </ins> } cmdutil.PrintSuccess(o.Mapper, o.ShortOutput, o.Out, info.Mapping.Resource, info.Name, false, \"env updated\")", "commid": "kubernetes_pr_53000"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-141ad298529fc52bdd1d978ad80ddba1c5d4febe5b6ef954b2a124b684d72c89", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: my yaml: exec kubectl set resources command,just update first object: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig cli\n/kind bug\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-e568b65ab794edf6f546d443987159c53c9cbace483065b5d60214711781c982", "text": "t.Errorf(\"did not set env: %s\", buf.String()) } } <ins> func TestSetMultiResourcesEnvLocal(t *testing.T) { f, tf, codec, ns := cmdtesting.NewAPIFactory() tf.Client = &fake.RESTClient{ GroupVersion:         legacyscheme.Registry.GroupOrDie(api.GroupName).GroupVersion, NegotiatedSerializer: ns, Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) { t.Fatalf(\"unexpected request: %s %#vn%#v\", req.Method, req.URL, req) return nil, nil }), } tf.Namespace = \"test\" tf.ClientConfig = &restclient.Config{ContentConfig: restclient.ContentConfig{GroupVersion: &legacyscheme.Registry.GroupOrDie(api.GroupName).GroupVersion}} buf := bytes.NewBuffer([]byte{}) cmd := NewCmdEnv(f, os.Stdin, buf, buf) cmd.SetOutput(buf) cmd.Flags().Set(\"output\", \"name\") cmd.Flags().Set(\"local\", \"true\") mapper, typer := f.Object() tf.Printer = &printers.NamePrinter{Decoders: []runtime.Decoder{codec}, Typer: typer, Mapper: mapper} opts := EnvOptions{FilenameOptions: resource.FilenameOptions{ Filenames: []string{\"../../../../test/fixtures/pkg/kubectl/cmd/set/multi-resource-yaml.yaml\"}}, Out:   buf, Local: true} err := opts.Complete(f, cmd, []string{\"env=prod\"}) if err == nil { err = opts.RunEnv(f) } if err != nil { t.Fatalf(\"unexpected error: %v\", err) } expectedOut := \"replicationcontrollers/first-rcnreplicationcontrollers/second-rcn\" if buf.String() != expectedOut { t.Errorf(\"expected out:n%snbut got:n%s\", expectedOut, buf.String()) } } </ins>", "commid": "kubernetes_pr_53000"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-141ad298529fc52bdd1d978ad80ddba1c5d4febe5b6ef954b2a124b684d72c89", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: my yaml: exec kubectl set resources command,just update first object: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig cli\n/kind bug\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-7ee1da84ef5ae7e8426967b2f790dcd1a47933df4fce5a8a708665607c9065ca", "text": "} } } <ins> func TestSetMultiResourcesImageLocal(t *testing.T) { f, tf, codec, ns := cmdtesting.NewAPIFactory() tf.Client = &fake.RESTClient{ GroupVersion:         legacyscheme.Registry.GroupOrDie(api.GroupName).GroupVersion, NegotiatedSerializer: ns, Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) { t.Fatalf(\"unexpected request: %s %#vn%#v\", req.Method, req.URL, req) return nil, nil }), } tf.Namespace = \"test\" tf.ClientConfig = &restclient.Config{ContentConfig: restclient.ContentConfig{GroupVersion: &legacyscheme.Registry.GroupOrDie(api.GroupName).GroupVersion}} buf := bytes.NewBuffer([]byte{}) cmd := NewCmdImage(f, buf, buf) cmd.SetOutput(buf) cmd.Flags().Set(\"output\", \"name\") cmd.Flags().Set(\"local\", \"true\") mapper, typer := f.Object() tf.Printer = &printers.NamePrinter{Decoders: []runtime.Decoder{codec}, Typer: typer, Mapper: mapper} opts := ImageOptions{FilenameOptions: resource.FilenameOptions{ Filenames: []string{\"../../../../test/fixtures/pkg/kubectl/cmd/set/multi-resource-yaml.yaml\"}}, Out:   buf, Local: true} err := opts.Complete(f, cmd, []string{\"*=thingy\"}) if err == nil { err = opts.Validate() } if err == nil { err = opts.Run() } if err != nil { t.Fatalf(\"unexpected error: %v\", err) } expectedOut := \"replicationcontrollers/first-rcnreplicationcontrollers/second-rcn\" if buf.String() != expectedOut { t.Errorf(\"expected out:n%snbut got:n%s\", expectedOut, buf.String()) } } </ins>", "commid": "kubernetes_pr_53000"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-141ad298529fc52bdd1d978ad80ddba1c5d4febe5b6ef954b2a124b684d72c89", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: my yaml: exec kubectl set resources command,just update first object: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig cli\n/kind bug\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-fc04115ed3fd992ea148d1a324c6962a777ff384053c1cd295b70dde19aaf93c", "text": "} if o.Local || cmdutil.GetDryRunFlag(o.Cmd) { <del> return o.PrintObject(o.Cmd, o.Local, o.Mapper, info.Object, o.Out) </del> <ins> if err := o.PrintObject(o.Cmd, o.Local, o.Mapper, info.Object, o.Out); err != nil { return err } continue </ins> } obj, err := resource.NewHelper(info.Client, info.Mapping).Patch(info.Namespace, info.Name, types.StrategicMergePatchType, patch.Patch)", "commid": "kubernetes_pr_53000"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-141ad298529fc52bdd1d978ad80ddba1c5d4febe5b6ef954b2a124b684d72c89", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: my yaml: exec kubectl set resources command,just update first object: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig cli\n/kind bug\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-8869fa672e0000e1be855aff272c509593970cedcff32eb2e1ccb94dab61451d", "text": "t.Errorf(\"did not set resources: %s\", buf.String()) } } <ins> func TestSetMultiResourcesLimitsLocal(t *testing.T) { f, tf, codec, ns := cmdtesting.NewAPIFactory() tf.Client = &fake.RESTClient{ GroupVersion:         legacyscheme.Registry.GroupOrDie(api.GroupName).GroupVersion, NegotiatedSerializer: ns, Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) { t.Fatalf(\"unexpected request: %s %#vn%#v\", req.Method, req.URL, req) return nil, nil }), } tf.Namespace = \"test\" tf.ClientConfig = &restclient.Config{ContentConfig: restclient.ContentConfig{GroupVersion: &legacyscheme.Registry.GroupOrDie(api.GroupName).GroupVersion}} buf := bytes.NewBuffer([]byte{}) cmd := NewCmdResources(f, buf, buf) cmd.SetOutput(buf) cmd.Flags().Set(\"output\", \"name\") cmd.Flags().Set(\"local\", \"true\") mapper, typer := f.Object() tf.Printer = &printers.NamePrinter{Decoders: []runtime.Decoder{codec}, Typer: typer, Mapper: mapper} opts := ResourcesOptions{FilenameOptions: resource.FilenameOptions{ Filenames: []string{\"../../../../test/fixtures/pkg/kubectl/cmd/set/multi-resource-yaml.yaml\"}}, Out:               buf, Local:             true, Limits:            \"cpu=200m,memory=512Mi\", Requests:          \"cpu=200m,memory=512Mi\", ContainerSelector: \"*\"} err := opts.Complete(f, cmd, []string{}) if err == nil { err = opts.Validate() } if err == nil { err = opts.Run() } if err != nil { t.Fatalf(\"unexpected error: %v\", err) } expectedOut := \"replicationcontrollers/first-rcnreplicationcontrollers/second-rcn\" if buf.String() != expectedOut { t.Errorf(\"expected out:n%snbut got:n%s\", expectedOut, buf.String()) } } </ins>", "commid": "kubernetes_pr_53000"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-141ad298529fc52bdd1d978ad80ddba1c5d4febe5b6ef954b2a124b684d72c89", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: my yaml: exec kubectl set resources command,just update first object: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig cli\n/kind bug\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-cd4f240d3200b15d44b875690374da13b099afb464f7ef1074c850342422741e", "text": "} if o.Local || o.DryRun { <del> return o.PrintObject(o.Mapper, info.Object, o.Out) </del> <ins> if err := o.PrintObject(o.Mapper, info.Object, o.Out); err != nil { return err } continue </ins> } obj, err := resource.NewHelper(info.Client, info.Mapping).Patch(info.Namespace, info.Name, types.StrategicMergePatchType, patch.Patch)", "commid": "kubernetes_pr_53000"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-141ad298529fc52bdd1d978ad80ddba1c5d4febe5b6ef954b2a124b684d72c89", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: my yaml: exec kubectl set resources command,just update first object: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig cli\n/kind bug\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-743f201778f12c7ba2bb19be0ac35a77bc184d36d466adccf87bca7f3e6e92b6", "text": "<ins> apiVersion: v1 kind: ReplicationController metadata: name: first-rc spec: replicas: 1 selector: app: mock template: metadata: labels: app: mock spec: containers: - name: mock-container image: gcr.io/google-containers/pause:2.0 --- apiVersion: v1 kind: ReplicationController metadata: name: second-rc spec: replicas: 1 selector: app: mock template: metadata: labels: app: mock spec: containers: - name: mock-container image: gcr.io/google-containers/pause:2.0 </ins>  No newline at end of file", "commid": "kubernetes_pr_53000"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e4af3c33d68e650a678730ef7b2281c281dc93d7d3e260c24d3b6a0d9cd86129", "query": "We should introduce a buffer (similar to what we have in the webhook output backend) to the log file output backend. Audit events should be queued on a relatively large buffer chanel, and an output go routine should grab events off the queue and write them to disk. If an audit event is output when the channel is full, it should be dropped (this should be counted by a prometheus metric, and an e2e test should ensure that the count is below some threshold). This behavior should be optional (configurable) /cc is tracking the regression\nNaturally os will cache , these cached data will be written to disk either by fsync or pdflush periodically. What do you think is the most time-costing procedure in audit?\nThe problem is not with the time consumed. The problem is that currently write is performed synchronously with processing the request, which slows the request down, no matter how well caching works\nThe problem is that currently write is performed synchronously with processing the request Sure synchronously write does cost time serializing. Introduce buffer mechanism can really reduce api request latency time.\nIt doesn't matter that much if it happens asynchronously Indeed\nYes, this is a good point to improve performance.\nNow I totally comprehend this. I am pleased to implement this buffer.\nI'll be happy to review that\naudit log is important sensitive information which we should try to make sure it reaches disk at all cost. Does this effort compromises that in favor of optimizing for latency ?\nI'll make sure it's configurable and if the security is critical, you can setup synchronous write in your deployment. Having said that, it's critical to be able to accommodate the case where having 100% calls written does not compensate for increased latencies. Does it make sense?\nthanks my preference would be to keep the default as no buffering when making it configurable. I didnt understand how does one setup \"synchronous write in your deployment\" and how that will affect audit logs reaching disk. My worry is mainly around a crash where the buffered audit logs dont reach the disk and are lost\nif use buffer, audit events lost is inevitable when crash. As like webhook backend, still exist this risk. But to improve apiserver qps, something should comprise. By the way, we still reserve the synchronous write mode, which is configurable.\nTo make it simple, when offered trade-off, people are more likely to give up audit logs reliability than performance. Makes sense?\ni am not against this change. i think what would be best is to make the default as no buffering and enable buffering through a parameter. Also for Enterprises, the trade off is not correct, they would prefer to NOT give up audit logs\nI understand what you're suggesting and I don't agree :) Switching to buffering will for sure increase the latency, but will only increase the probability of losing logs, which will never be zero. I'm pretty sure we need to have buffered mode by default. However, since this argument is about making a trade-off and since neither of us represents quorum, let's ask more people for their opinion What do you think?\nThe default is slightly less important here since audit logging as a whole is not enabled by default. If we do turn it on by default, it becomes more important. That said, my hunch is that we should default to the mode with lower performance impact, but I don't have strong feelings either way.\nAs long as there are options to turn it on of off (the synchronous write) I'm fine with either default. Still, I'd like to see due diligence towards ensuring low lost rate when using buffered write, and sufficient documentation around caveats of using one or the other. Audit, from my personal experience, is crucial for majority of enterprises and they won't tolerate not even single lost event.\nThat is not possible, there will always be a situation when an audit event can be lost: sudden power loss, disk/network failure, random bit flip, etc. The questions is whether 10^(-6) is low enough loss probability, or we need to get 10^(-14) by sacrificing performance (arbitrary numbers, just to illustrate my point). Note, that reduced performance can increase the number of timeouts and retries, increasing load and leading to failures and even more lost events.\nI think this is an important bug that we're not testing audit logging at scale\nMarking it as urgent, since it's blocking\nIf split into 3 prs, I must do it one by one . Now first one is up .\nSGTM Status of this issue: ETA: 1/12/2017 Risks: Complicated fix required\nhas been reviewed for almost 2 months and has not done. If I raise 3 prs to replace it, I am still worried whether all of them can be merged. They act as a whole.\nNow I'm going to devote my time to it, we'll do it\nOK.\nIn progress, reviewed first PR, waiting for applying changes ETA: Dec 01\nPer Exception discussion, this portion of the feature is being removed from the milestone. As such, changing the priority. /priority important-soon /remove-priority critical-urgent\n[MILESTONENOTIFIER] Milestone Removed From Issue Important: Code freeze is in effect and only issues with may remain in the v1.9 milestone. <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-c704a67ad002abcf1406f63f6b67f7d37e3113960b328ddc381855a5eef5d385", "text": "name = \"all-srcs\", srcs = [ \":package-srcs\", <ins> \"//staging/src/k8s.io/apiserver/plugin/pkg/audit/buffered:all-srcs\", </ins> \"//staging/src/k8s.io/apiserver/plugin/pkg/audit/log:all-srcs\", \"//staging/src/k8s.io/apiserver/plugin/pkg/audit/webhook:all-srcs\", ],", "commid": "kubernetes_pr_60076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e4af3c33d68e650a678730ef7b2281c281dc93d7d3e260c24d3b6a0d9cd86129", "query": "We should introduce a buffer (similar to what we have in the webhook output backend) to the log file output backend. Audit events should be queued on a relatively large buffer chanel, and an output go routine should grab events off the queue and write them to disk. If an audit event is output when the channel is full, it should be dropped (this should be counted by a prometheus metric, and an e2e test should ensure that the count is below some threshold). This behavior should be optional (configurable) /cc is tracking the regression\nNaturally os will cache , these cached data will be written to disk either by fsync or pdflush periodically. What do you think is the most time-costing procedure in audit?\nThe problem is not with the time consumed. The problem is that currently write is performed synchronously with processing the request, which slows the request down, no matter how well caching works\nThe problem is that currently write is performed synchronously with processing the request Sure synchronously write does cost time serializing. Introduce buffer mechanism can really reduce api request latency time.\nIt doesn't matter that much if it happens asynchronously Indeed\nYes, this is a good point to improve performance.\nNow I totally comprehend this. I am pleased to implement this buffer.\nI'll be happy to review that\naudit log is important sensitive information which we should try to make sure it reaches disk at all cost. Does this effort compromises that in favor of optimizing for latency ?\nI'll make sure it's configurable and if the security is critical, you can setup synchronous write in your deployment. Having said that, it's critical to be able to accommodate the case where having 100% calls written does not compensate for increased latencies. Does it make sense?\nthanks my preference would be to keep the default as no buffering when making it configurable. I didnt understand how does one setup \"synchronous write in your deployment\" and how that will affect audit logs reaching disk. My worry is mainly around a crash where the buffered audit logs dont reach the disk and are lost\nif use buffer, audit events lost is inevitable when crash. As like webhook backend, still exist this risk. But to improve apiserver qps, something should comprise. By the way, we still reserve the synchronous write mode, which is configurable.\nTo make it simple, when offered trade-off, people are more likely to give up audit logs reliability than performance. Makes sense?\ni am not against this change. i think what would be best is to make the default as no buffering and enable buffering through a parameter. Also for Enterprises, the trade off is not correct, they would prefer to NOT give up audit logs\nI understand what you're suggesting and I don't agree :) Switching to buffering will for sure increase the latency, but will only increase the probability of losing logs, which will never be zero. I'm pretty sure we need to have buffered mode by default. However, since this argument is about making a trade-off and since neither of us represents quorum, let's ask more people for their opinion What do you think?\nThe default is slightly less important here since audit logging as a whole is not enabled by default. If we do turn it on by default, it becomes more important. That said, my hunch is that we should default to the mode with lower performance impact, but I don't have strong feelings either way.\nAs long as there are options to turn it on of off (the synchronous write) I'm fine with either default. Still, I'd like to see due diligence towards ensuring low lost rate when using buffered write, and sufficient documentation around caveats of using one or the other. Audit, from my personal experience, is crucial for majority of enterprises and they won't tolerate not even single lost event.\nThat is not possible, there will always be a situation when an audit event can be lost: sudden power loss, disk/network failure, random bit flip, etc. The questions is whether 10^(-6) is low enough loss probability, or we need to get 10^(-14) by sacrificing performance (arbitrary numbers, just to illustrate my point). Note, that reduced performance can increase the number of timeouts and retries, increasing load and leading to failures and even more lost events.\nI think this is an important bug that we're not testing audit logging at scale\nMarking it as urgent, since it's blocking\nIf split into 3 prs, I must do it one by one . Now first one is up .\nSGTM Status of this issue: ETA: 1/12/2017 Risks: Complicated fix required\nhas been reviewed for almost 2 months and has not done. If I raise 3 prs to replace it, I am still worried whether all of them can be merged. They act as a whole.\nNow I'm going to devote my time to it, we'll do it\nOK.\nIn progress, reviewed first PR, waiting for applying changes ETA: Dec 01\nPer Exception discussion, this portion of the feature is being removed from the milestone. As such, changing the priority. /priority important-soon /remove-priority critical-urgent\n[MILESTONENOTIFIER] Milestone Removed From Issue Important: Code freeze is in effect and only issues with may remain in the v1.9 milestone. <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-513c48ed330d9ae0d9ef08a07e8dad77b099360a97d138df348c2a52bbbe4606", "text": "<ins> load(\"@io_bazel_rules_go//go:def.bzl\", \"go_library\", \"go_test\") go_library( name = \"go_default_library\", srcs = [ \"buffered.go\", \"doc.go\", ], importpath = \"k8s.io/apiserver/plugin/pkg/audit/buffered\", visibility = [\"//visibility:public\"], deps = [ \"//vendor/k8s.io/apimachinery/pkg/util/runtime:go_default_library\", \"//vendor/k8s.io/apimachinery/pkg/util/wait:go_default_library\", \"//vendor/k8s.io/apiserver/pkg/apis/audit:go_default_library\", \"//vendor/k8s.io/apiserver/pkg/audit:go_default_library\", \"//vendor/k8s.io/client-go/util/flowcontrol:go_default_library\", ], ) go_test( name = \"go_default_test\", srcs = [\"buffered_test.go\"], embed = [\":go_default_library\"], deps = [ \"//vendor/github.com/stretchr/testify/require:go_default_library\", \"//vendor/k8s.io/apimachinery/pkg/util/wait:go_default_library\", \"//vendor/k8s.io/apiserver/pkg/apis/audit:go_default_library\", \"//vendor/k8s.io/apiserver/pkg/audit:go_default_library\", ], ) filegroup( name = \"package-srcs\", srcs = glob([\"**\"]), tags = [\"automanaged\"], visibility = [\"//visibility:private\"], ) filegroup( name = \"all-srcs\", srcs = [\":package-srcs\"], tags = [\"automanaged\"], visibility = [\"//visibility:public\"], ) </ins>", "commid": "kubernetes_pr_60076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e4af3c33d68e650a678730ef7b2281c281dc93d7d3e260c24d3b6a0d9cd86129", "query": "We should introduce a buffer (similar to what we have in the webhook output backend) to the log file output backend. Audit events should be queued on a relatively large buffer chanel, and an output go routine should grab events off the queue and write them to disk. If an audit event is output when the channel is full, it should be dropped (this should be counted by a prometheus metric, and an e2e test should ensure that the count is below some threshold). This behavior should be optional (configurable) /cc is tracking the regression\nNaturally os will cache , these cached data will be written to disk either by fsync or pdflush periodically. What do you think is the most time-costing procedure in audit?\nThe problem is not with the time consumed. The problem is that currently write is performed synchronously with processing the request, which slows the request down, no matter how well caching works\nThe problem is that currently write is performed synchronously with processing the request Sure synchronously write does cost time serializing. Introduce buffer mechanism can really reduce api request latency time.\nIt doesn't matter that much if it happens asynchronously Indeed\nYes, this is a good point to improve performance.\nNow I totally comprehend this. I am pleased to implement this buffer.\nI'll be happy to review that\naudit log is important sensitive information which we should try to make sure it reaches disk at all cost. Does this effort compromises that in favor of optimizing for latency ?\nI'll make sure it's configurable and if the security is critical, you can setup synchronous write in your deployment. Having said that, it's critical to be able to accommodate the case where having 100% calls written does not compensate for increased latencies. Does it make sense?\nthanks my preference would be to keep the default as no buffering when making it configurable. I didnt understand how does one setup \"synchronous write in your deployment\" and how that will affect audit logs reaching disk. My worry is mainly around a crash where the buffered audit logs dont reach the disk and are lost\nif use buffer, audit events lost is inevitable when crash. As like webhook backend, still exist this risk. But to improve apiserver qps, something should comprise. By the way, we still reserve the synchronous write mode, which is configurable.\nTo make it simple, when offered trade-off, people are more likely to give up audit logs reliability than performance. Makes sense?\ni am not against this change. i think what would be best is to make the default as no buffering and enable buffering through a parameter. Also for Enterprises, the trade off is not correct, they would prefer to NOT give up audit logs\nI understand what you're suggesting and I don't agree :) Switching to buffering will for sure increase the latency, but will only increase the probability of losing logs, which will never be zero. I'm pretty sure we need to have buffered mode by default. However, since this argument is about making a trade-off and since neither of us represents quorum, let's ask more people for their opinion What do you think?\nThe default is slightly less important here since audit logging as a whole is not enabled by default. If we do turn it on by default, it becomes more important. That said, my hunch is that we should default to the mode with lower performance impact, but I don't have strong feelings either way.\nAs long as there are options to turn it on of off (the synchronous write) I'm fine with either default. Still, I'd like to see due diligence towards ensuring low lost rate when using buffered write, and sufficient documentation around caveats of using one or the other. Audit, from my personal experience, is crucial for majority of enterprises and they won't tolerate not even single lost event.\nThat is not possible, there will always be a situation when an audit event can be lost: sudden power loss, disk/network failure, random bit flip, etc. The questions is whether 10^(-6) is low enough loss probability, or we need to get 10^(-14) by sacrificing performance (arbitrary numbers, just to illustrate my point). Note, that reduced performance can increase the number of timeouts and retries, increasing load and leading to failures and even more lost events.\nI think this is an important bug that we're not testing audit logging at scale\nMarking it as urgent, since it's blocking\nIf split into 3 prs, I must do it one by one . Now first one is up .\nSGTM Status of this issue: ETA: 1/12/2017 Risks: Complicated fix required\nhas been reviewed for almost 2 months and has not done. If I raise 3 prs to replace it, I am still worried whether all of them can be merged. They act as a whole.\nNow I'm going to devote my time to it, we'll do it\nOK.\nIn progress, reviewed first PR, waiting for applying changes ETA: Dec 01\nPer Exception discussion, this portion of the feature is being removed from the milestone. As such, changing the priority. /priority important-soon /remove-priority critical-urgent\n[MILESTONENOTIFIER] Milestone Removed From Issue Important: Code freeze is in effect and only issues with may remain in the v1.9 milestone. <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-1b0dd6ec2b11c0fc3df8399d8720bd1ebebad2dcc84d63d27365374633578ab7", "text": "<ins> /* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package buffered import ( \"fmt\" \"sync\" \"time\" \"k8s.io/apimachinery/pkg/util/runtime\" \"k8s.io/apimachinery/pkg/util/wait\" auditinternal \"k8s.io/apiserver/pkg/apis/audit\" \"k8s.io/apiserver/pkg/audit\" \"k8s.io/client-go/util/flowcontrol\" ) // The plugin name reported in error metrics. const pluginName = \"buffered\" const ( // Default configuration values for ModeBatch. defaultBatchBufferSize = 10000            // Buffer up to 10000 events before starting discarding. defaultBatchMaxSize    = 400              // Only send up to 400 events at a time. defaultBatchMaxWait    = 30 * time.Second // Send events at least twice a minute. defaultBatchThrottleQPS   = 10 // Limit the send rate by 10 QPS. defaultBatchThrottleBurst = 15 // Allow up to 15 QPS burst. ) // BatchConfig represents batching delegate audit backend configuration. type BatchConfig struct { // BufferSize defines a size of the buffering queue. BufferSize int // MaxBatchSize defines maximum size of a batch. MaxBatchSize int // MaxBatchWait indicates the maximum interval between two batches. MaxBatchWait time.Duration // ThrottleEnable defines whether throttling will be applied to the batching process. ThrottleEnable bool // ThrottleQPS defines the allowed rate of batches per second sent to the delegate backend. ThrottleQPS float32 // ThrottleBurst defines the maximum rate of batches per second sent to the delegate backend in case // the capacity defined by ThrottleQPS was not utilized. ThrottleBurst int } // NewDefaultBatchConfig returns new Config objects populated by default values. func NewDefaultBatchConfig() BatchConfig { return BatchConfig{ BufferSize:   defaultBatchBufferSize, MaxBatchSize: defaultBatchMaxSize, MaxBatchWait: defaultBatchMaxWait, ThrottleEnable: true, ThrottleQPS:    defaultBatchThrottleQPS, ThrottleBurst:  defaultBatchThrottleBurst, } } type bufferedBackend struct { // The delegate backend that actually exports events. delegateBackend audit.Backend // Channel to buffer events before sending to the delegate backend. buffer chan *auditinternal.Event // Maximum number of events in a batch sent to the delegate backend. maxBatchSize int // Amount of time to wait after sending a batch to the delegate backend before sending another one. // // Receiving maxBatchSize events will always trigger sending a batch, regardless of the amount of time passed. maxBatchWait time.Duration // Channel to signal that the batching routine has processed all remaining events and exited. // Once `shutdownCh` is closed no new events will be sent to the delegate backend. shutdownCh chan struct{} // WaitGroup to control the concurrency of sending batches to the delegate backend. // Worker routine calls Add before sending a batch and // then spawns a routine that calls Done after batch was processed by the delegate backend. // This WaitGroup is used to wait for all sending routines to finish before shutting down audit backend. wg sync.WaitGroup // Limits the number of batches sent to the delegate backend per second. throttle flowcontrol.RateLimiter } var _ audit.Backend = &bufferedBackend{} // NewBackend returns a buffered audit backend that wraps delegate backend. func NewBackend(delegate audit.Backend, config BatchConfig) audit.Backend { var throttle flowcontrol.RateLimiter if config.ThrottleEnable { throttle = flowcontrol.NewTokenBucketRateLimiter(config.ThrottleQPS, config.ThrottleBurst) } return &bufferedBackend{ delegateBackend: delegate, buffer:          make(chan *auditinternal.Event, config.BufferSize), maxBatchSize:    config.MaxBatchSize, maxBatchWait:    config.MaxBatchWait, shutdownCh:      make(chan struct{}), wg:              sync.WaitGroup{}, throttle:        throttle, } } func (b *bufferedBackend) Run(stopCh <-chan struct{}) error { go func() { // Signal that the working routine has exited. defer close(b.shutdownCh) b.processIncomingEvents(stopCh) // Handle the events that were received after the last buffer // scraping and before this line. Since the buffer is closed, no new // events will come through. allEventsProcessed := false timer := make(chan time.Time) for !allEventsProcessed { allEventsProcessed = func() bool { // Recover from any panic in order to try to process all remaining events. // Note, that in case of a panic, the return value will be false and // the loop execution will continue. defer runtime.HandleCrash() events := b.collectEvents(timer, wait.NeverStop) b.processEvents(events) return len(events) == 0 }() } }() return b.delegateBackend.Run(stopCh) } // Shutdown blocks until stopCh passed to the Run method is closed and all // events added prior to that moment are batched and sent to the delegate backend. func (b *bufferedBackend) Shutdown() { // Wait until the routine spawned in Run method exits. <-b.shutdownCh // Wait until all sending routines exit. b.wg.Wait() b.delegateBackend.Shutdown() } // processIncomingEvents runs a loop that collects events from the buffer. When // b.stopCh is closed, processIncomingEvents stops and closes the buffer. func (b *bufferedBackend) processIncomingEvents(stopCh <-chan struct{}) { defer close(b.buffer) t := time.NewTimer(b.maxBatchWait) defer t.Stop() for { func() { // Recover from any panics caused by this function so a panic in the // goroutine can't bring down the main routine. defer runtime.HandleCrash() t.Reset(b.maxBatchWait) b.processEvents(b.collectEvents(t.C, stopCh)) }() select { case <-stopCh: return default: } } } // collectEvents attempts to collect some number of events in a batch. // // The following things can cause collectEvents to stop and return the list // of events: // //   * Maximum number of events for a batch. //   * Timer has passed. //   * Buffer channel is closed and empty. //   * stopCh is closed. func (b *bufferedBackend) collectEvents(timer <-chan time.Time, stopCh <-chan struct{}) []*auditinternal.Event { var events []*auditinternal.Event L: for i := 0; i < b.maxBatchSize; i++ { select { case ev, ok := <-b.buffer: // Buffer channel was closed and no new events will follow. if !ok { break L } events = append(events, ev) case <-timer: // Timer has expired. Send currently accumulated batch. break L case <-stopCh: // Backend has been stopped. Send currently accumulated batch. break L } } return events } // processEvents process the batch events in a goroutine using delegateBackend's ProcessEvents. func (b *bufferedBackend) processEvents(events []*auditinternal.Event) { if len(events) == 0 { return } // TODO(audit): Should control the number of active goroutines // if one goroutine takes 5 seconds to finish, the number of goroutines can be 5 * defaultBatchThrottleQPS if b.throttle != nil { b.throttle.Accept() } b.wg.Add(1) go func() { defer b.wg.Done() defer runtime.HandleCrash() // Execute the real processing in a goroutine to keep it from blocking. // This lets the batching routine continue draining the queue immediately. b.delegateBackend.ProcessEvents(events...) }() } func (b *bufferedBackend) ProcessEvents(ev ...*auditinternal.Event) { // The following mechanism is in place to support the situation when audit // events are still coming after the backend was stopped. var sendErr error var evIndex int // If the delegateBackend was shutdown and the buffer channel was closed, an // attempt to add an event to it will result in panic that we should // recover from. defer func() { if err := recover(); err != nil { sendErr = fmt.Errorf(\"panic when processing events: %v\", err) } if sendErr != nil { audit.HandlePluginError(pluginName, sendErr, ev[evIndex:]...) } }() for i, e := range ev { evIndex = i // Per the audit.Backend interface these events are reused after being // sent to the Sink. Deep copy and send the copy to the queue. event := e.DeepCopy() select { case b.buffer <- event: default: sendErr = fmt.Errorf(\"audit buffer queue blocked\") return } } } </ins>", "commid": "kubernetes_pr_60076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e4af3c33d68e650a678730ef7b2281c281dc93d7d3e260c24d3b6a0d9cd86129", "query": "We should introduce a buffer (similar to what we have in the webhook output backend) to the log file output backend. Audit events should be queued on a relatively large buffer chanel, and an output go routine should grab events off the queue and write them to disk. If an audit event is output when the channel is full, it should be dropped (this should be counted by a prometheus metric, and an e2e test should ensure that the count is below some threshold). This behavior should be optional (configurable) /cc is tracking the regression\nNaturally os will cache , these cached data will be written to disk either by fsync or pdflush periodically. What do you think is the most time-costing procedure in audit?\nThe problem is not with the time consumed. The problem is that currently write is performed synchronously with processing the request, which slows the request down, no matter how well caching works\nThe problem is that currently write is performed synchronously with processing the request Sure synchronously write does cost time serializing. Introduce buffer mechanism can really reduce api request latency time.\nIt doesn't matter that much if it happens asynchronously Indeed\nYes, this is a good point to improve performance.\nNow I totally comprehend this. I am pleased to implement this buffer.\nI'll be happy to review that\naudit log is important sensitive information which we should try to make sure it reaches disk at all cost. Does this effort compromises that in favor of optimizing for latency ?\nI'll make sure it's configurable and if the security is critical, you can setup synchronous write in your deployment. Having said that, it's critical to be able to accommodate the case where having 100% calls written does not compensate for increased latencies. Does it make sense?\nthanks my preference would be to keep the default as no buffering when making it configurable. I didnt understand how does one setup \"synchronous write in your deployment\" and how that will affect audit logs reaching disk. My worry is mainly around a crash where the buffered audit logs dont reach the disk and are lost\nif use buffer, audit events lost is inevitable when crash. As like webhook backend, still exist this risk. But to improve apiserver qps, something should comprise. By the way, we still reserve the synchronous write mode, which is configurable.\nTo make it simple, when offered trade-off, people are more likely to give up audit logs reliability than performance. Makes sense?\ni am not against this change. i think what would be best is to make the default as no buffering and enable buffering through a parameter. Also for Enterprises, the trade off is not correct, they would prefer to NOT give up audit logs\nI understand what you're suggesting and I don't agree :) Switching to buffering will for sure increase the latency, but will only increase the probability of losing logs, which will never be zero. I'm pretty sure we need to have buffered mode by default. However, since this argument is about making a trade-off and since neither of us represents quorum, let's ask more people for their opinion What do you think?\nThe default is slightly less important here since audit logging as a whole is not enabled by default. If we do turn it on by default, it becomes more important. That said, my hunch is that we should default to the mode with lower performance impact, but I don't have strong feelings either way.\nAs long as there are options to turn it on of off (the synchronous write) I'm fine with either default. Still, I'd like to see due diligence towards ensuring low lost rate when using buffered write, and sufficient documentation around caveats of using one or the other. Audit, from my personal experience, is crucial for majority of enterprises and they won't tolerate not even single lost event.\nThat is not possible, there will always be a situation when an audit event can be lost: sudden power loss, disk/network failure, random bit flip, etc. The questions is whether 10^(-6) is low enough loss probability, or we need to get 10^(-14) by sacrificing performance (arbitrary numbers, just to illustrate my point). Note, that reduced performance can increase the number of timeouts and retries, increasing load and leading to failures and even more lost events.\nI think this is an important bug that we're not testing audit logging at scale\nMarking it as urgent, since it's blocking\nIf split into 3 prs, I must do it one by one . Now first one is up .\nSGTM Status of this issue: ETA: 1/12/2017 Risks: Complicated fix required\nhas been reviewed for almost 2 months and has not done. If I raise 3 prs to replace it, I am still worried whether all of them can be merged. They act as a whole.\nNow I'm going to devote my time to it, we'll do it\nOK.\nIn progress, reviewed first PR, waiting for applying changes ETA: Dec 01\nPer Exception discussion, this portion of the feature is being removed from the milestone. As such, changing the priority. /priority important-soon /remove-priority critical-urgent\n[MILESTONENOTIFIER] Milestone Removed From Issue Important: Code freeze is in effect and only issues with may remain in the v1.9 milestone. <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-01b93570357cc47f8ff567766f0d2185b27962dc0fc61ff6b644c51f38993870", "text": "<ins> /* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package buffered import ( \"testing\" \"time\" \"github.com/stretchr/testify/require\" \"k8s.io/apimachinery/pkg/util/wait\" auditinternal \"k8s.io/apiserver/pkg/apis/audit\" \"k8s.io/apiserver/pkg/audit\" ) var ( closedStopCh = func() <-chan struct{} { ch := make(chan struct{}) close(ch) return ch }() infiniteTimeCh <-chan time.Time = make(chan time.Time) closedTimeCh                    = func() <-chan time.Time { ch := make(chan time.Time) close(ch) return ch }() ) func newEvents(number int) []*auditinternal.Event { events := make([]*auditinternal.Event, number) for i := range events { events[i] = &auditinternal.Event{} } return events } func TestBufferedBackendCollectEvents(t *testing.T) { config := NewDefaultBatchConfig() testCases := []struct { desc          string timer         <-chan time.Time stopCh        <-chan struct{} numEvents     int wantBatchSize int }{ { desc:          \"max batch size encountered\", timer:         infiniteTimeCh, stopCh:        wait.NeverStop, numEvents:     config.MaxBatchSize + 1, wantBatchSize: config.MaxBatchSize, }, { desc:   \"timer expired\", timer:  closedTimeCh, stopCh: wait.NeverStop, }, { desc:   \"chanel closed\", timer:  infiniteTimeCh, stopCh: closedStopCh, }, } for _, tc := range testCases { tc := tc t.Run(tc.desc, func(t *testing.T) { t.Parallel() backend := NewBackend(&fakeBackend{}, config).(*bufferedBackend) backend.ProcessEvents(newEvents(tc.numEvents)...) batch := backend.collectEvents(tc.timer, tc.stopCh) require.Equal(t, tc.wantBatchSize, len(batch), \"unexpected batch size\") }) } } func TestBufferedBackendProcessEventsAfterStop(t *testing.T) { t.Parallel() backend := NewBackend(&fakeBackend{}, NewDefaultBatchConfig()).(*bufferedBackend) backend.Run(closedStopCh) backend.Shutdown() backend.ProcessEvents(newEvents(1)...) batch := backend.collectEvents(infiniteTimeCh, wait.NeverStop) require.Equal(t, 0, len(batch), \"processed events after the backed has been stopped\") } func TestBufferedBackendProcessEventsBufferFull(t *testing.T) { t.Parallel() config := NewDefaultBatchConfig() config.BufferSize = 1 backend := NewBackend(&fakeBackend{}, config).(*bufferedBackend) backend.ProcessEvents(newEvents(2)...) require.Equal(t, 1, len(backend.buffer), \"buffed contains more elements than it should\") } func TestBufferedBackendShutdownWaitsForDelegatedCalls(t *testing.T) { t.Parallel() delegatedCallStartCh := make(chan struct{}) delegatedCallEndCh := make(chan struct{}) delegateBackend := &fakeBackend{ onRequest: func(_ []*auditinternal.Event) { close(delegatedCallStartCh) <-delegatedCallEndCh }, } config := NewDefaultBatchConfig() backend := NewBackend(delegateBackend, config) // Run backend, process events, wait for them to be batched and for delegated call to start. stopCh := make(chan struct{}) backend.Run(stopCh) backend.ProcessEvents(newEvents(config.MaxBatchSize)...) <-delegatedCallStartCh // Start shutdown procedure. shutdownEndCh := make(chan struct{}) go func() { close(stopCh) backend.Shutdown() close(shutdownEndCh) }() // Wait for some time and then check whether Shutdown has exited. Can give false positive, // but never false negative. time.Sleep(100 * time.Millisecond) select { case <-shutdownEndCh: t.Fatalf(\"Shutdown exited before delegated call ended\") default: } // Wait for Shutdown to exit after delegated call has exited. close(delegatedCallEndCh) <-shutdownEndCh } type fakeBackend struct { onRequest func(events []*auditinternal.Event) } var _ audit.Backend = &fakeBackend{} func (b *fakeBackend) Run(stopCh <-chan struct{}) error { return nil } func (b *fakeBackend) Shutdown() { return } func (b *fakeBackend) ProcessEvents(ev ...*auditinternal.Event) { if b.onRequest != nil { b.onRequest(ev) } } </ins>", "commid": "kubernetes_pr_60076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e4af3c33d68e650a678730ef7b2281c281dc93d7d3e260c24d3b6a0d9cd86129", "query": "We should introduce a buffer (similar to what we have in the webhook output backend) to the log file output backend. Audit events should be queued on a relatively large buffer chanel, and an output go routine should grab events off the queue and write them to disk. If an audit event is output when the channel is full, it should be dropped (this should be counted by a prometheus metric, and an e2e test should ensure that the count is below some threshold). This behavior should be optional (configurable) /cc is tracking the regression\nNaturally os will cache , these cached data will be written to disk either by fsync or pdflush periodically. What do you think is the most time-costing procedure in audit?\nThe problem is not with the time consumed. The problem is that currently write is performed synchronously with processing the request, which slows the request down, no matter how well caching works\nThe problem is that currently write is performed synchronously with processing the request Sure synchronously write does cost time serializing. Introduce buffer mechanism can really reduce api request latency time.\nIt doesn't matter that much if it happens asynchronously Indeed\nYes, this is a good point to improve performance.\nNow I totally comprehend this. I am pleased to implement this buffer.\nI'll be happy to review that\naudit log is important sensitive information which we should try to make sure it reaches disk at all cost. Does this effort compromises that in favor of optimizing for latency ?\nI'll make sure it's configurable and if the security is critical, you can setup synchronous write in your deployment. Having said that, it's critical to be able to accommodate the case where having 100% calls written does not compensate for increased latencies. Does it make sense?\nthanks my preference would be to keep the default as no buffering when making it configurable. I didnt understand how does one setup \"synchronous write in your deployment\" and how that will affect audit logs reaching disk. My worry is mainly around a crash where the buffered audit logs dont reach the disk and are lost\nif use buffer, audit events lost is inevitable when crash. As like webhook backend, still exist this risk. But to improve apiserver qps, something should comprise. By the way, we still reserve the synchronous write mode, which is configurable.\nTo make it simple, when offered trade-off, people are more likely to give up audit logs reliability than performance. Makes sense?\ni am not against this change. i think what would be best is to make the default as no buffering and enable buffering through a parameter. Also for Enterprises, the trade off is not correct, they would prefer to NOT give up audit logs\nI understand what you're suggesting and I don't agree :) Switching to buffering will for sure increase the latency, but will only increase the probability of losing logs, which will never be zero. I'm pretty sure we need to have buffered mode by default. However, since this argument is about making a trade-off and since neither of us represents quorum, let's ask more people for their opinion What do you think?\nThe default is slightly less important here since audit logging as a whole is not enabled by default. If we do turn it on by default, it becomes more important. That said, my hunch is that we should default to the mode with lower performance impact, but I don't have strong feelings either way.\nAs long as there are options to turn it on of off (the synchronous write) I'm fine with either default. Still, I'd like to see due diligence towards ensuring low lost rate when using buffered write, and sufficient documentation around caveats of using one or the other. Audit, from my personal experience, is crucial for majority of enterprises and they won't tolerate not even single lost event.\nThat is not possible, there will always be a situation when an audit event can be lost: sudden power loss, disk/network failure, random bit flip, etc. The questions is whether 10^(-6) is low enough loss probability, or we need to get 10^(-14) by sacrificing performance (arbitrary numbers, just to illustrate my point). Note, that reduced performance can increase the number of timeouts and retries, increasing load and leading to failures and even more lost events.\nI think this is an important bug that we're not testing audit logging at scale\nMarking it as urgent, since it's blocking\nIf split into 3 prs, I must do it one by one . Now first one is up .\nSGTM Status of this issue: ETA: 1/12/2017 Risks: Complicated fix required\nhas been reviewed for almost 2 months and has not done. If I raise 3 prs to replace it, I am still worried whether all of them can be merged. They act as a whole.\nNow I'm going to devote my time to it, we'll do it\nOK.\nIn progress, reviewed first PR, waiting for applying changes ETA: Dec 01\nPer Exception discussion, this portion of the feature is being removed from the milestone. As such, changing the priority. /priority important-soon /remove-priority critical-urgent\n[MILESTONENOTIFIER] Milestone Removed From Issue Important: Code freeze is in effect and only issues with may remain in the v1.9 milestone. <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-f388952a25d80a9a0d787867a377daee33952ae719b6804db8385bfe612f47ff", "text": "<ins> /* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ // Package buffered provides an implementation for the audit.Backend interface // that batches incoming audit events and sends batches to the delegate audit.Backend. package buffered // import \"k8s.io/apiserver/plugin/pkg/audit/buffered\" </ins>", "commid": "kubernetes_pr_60076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-284fb555a913f6894b005ac842118dc412cfd892c771454a17e2e489b164471e", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Creating a service with created a load balancer without a floating IP. What you expected to happen: Load balancer should have a floating IP assigned by default. How to reproduce it (as minimally and precisely as possible): Deploy this manifest on a cluster and check the resulting load balancer. No floating IP will be assigned. Anything else we need to know?: The default behavior changed from k8s 1.7.x. It appears that an annotation that will add a floating IP, but the default should not have changed without warning. This also breaks the workflow. For example: Environment: Kubernetes version (use ): v1.8.0-rc.1+coreos.0 Cloud provider or hardware configuration**: openstack OS (e.g. from /etc/os-release): Container Linux by CoreOS 1520.4.0 (Ladybug) Kernel (e.g. ): 4.13.3-coreos Install tools: Others:\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig openstack\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nOops, default should be external. /assign", "positive_passages": [{"docid": "doc-en-kubernetes-1fec9abbd042a0ed6cc7b456b18d1a9664f3fed1b65947524e02a649a6acac5b", "text": "// ServiceAnnotationLoadBalancerInternal is the annotation used on the service // to indicate that we want an internal loadbalancer service. <del> // If the value of ServiceAnnotationLoadBalancerInternal is false, it indicates that we want an external loadbalancer service. Default to true. </del> <ins> // If the value of ServiceAnnotationLoadBalancerInternal is false, it indicates that we want an external loadbalancer service. Default to false. </ins> ServiceAnnotationLoadBalancerInternal = \"service.beta.kubernetes.io/openstack-internal-load-balancer\" )", "commid": "kubernetes_pr_53101"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-284fb555a913f6894b005ac842118dc412cfd892c771454a17e2e489b164471e", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Creating a service with created a load balancer without a floating IP. What you expected to happen: Load balancer should have a floating IP assigned by default. How to reproduce it (as minimally and precisely as possible): Deploy this manifest on a cluster and check the resulting load balancer. No floating IP will be assigned. Anything else we need to know?: The default behavior changed from k8s 1.7.x. It appears that an annotation that will add a floating IP, but the default should not have changed without warning. This also breaks the workflow. For example: Environment: Kubernetes version (use ): v1.8.0-rc.1+coreos.0 Cloud provider or hardware configuration**: openstack OS (e.g. from /etc/os-release): Container Linux by CoreOS 1520.4.0 (Ladybug) Kernel (e.g. ): 4.13.3-coreos Install tools: Others:\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig openstack\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nOops, default should be external. /assign", "positive_passages": [{"docid": "doc-en-kubernetes-0beb699cc4a304e0afe65bd6163d5dd6810447dbdee22c1e95b9fe1ec26a8039", "text": "glog.V(4).Infof(\"EnsureLoadBalancer using floatingPool: %v\", floatingPool) var internalAnnotation bool <del> internal := getStringFromServiceAnnotation(apiService, ServiceAnnotationLoadBalancerInternal, \"true\") </del> <ins> internal := getStringFromServiceAnnotation(apiService, ServiceAnnotationLoadBalancerInternal, \"false\") </ins> switch internal { case \"true\": glog.V(4).Infof(\"Ensure an internal loadbalancer service.\")", "commid": "kubernetes_pr_53101"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-284fb555a913f6894b005ac842118dc412cfd892c771454a17e2e489b164471e", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Creating a service with created a load balancer without a floating IP. What you expected to happen: Load balancer should have a floating IP assigned by default. How to reproduce it (as minimally and precisely as possible): Deploy this manifest on a cluster and check the resulting load balancer. No floating IP will be assigned. Anything else we need to know?: The default behavior changed from k8s 1.7.x. It appears that an annotation that will add a floating IP, but the default should not have changed without warning. This also breaks the workflow. For example: Environment: Kubernetes version (use ): v1.8.0-rc.1+coreos.0 Cloud provider or hardware configuration**: openstack OS (e.g. from /etc/os-release): Container Linux by CoreOS 1520.4.0 (Ladybug) Kernel (e.g. ): 4.13.3-coreos Install tools: Others:\nThere are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals\n/sig openstack\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nOops, default should be external. /assign", "positive_passages": [{"docid": "doc-en-kubernetes-853fd4d7cced2fe78c50020cf6d5261e6ae6e5162748d8bfd6fd31e5cd86ae50", "text": "glog.V(4).Infof(\"Ensure an external loadbalancer service.\") internalAnnotation = false } else { <del> return nil, fmt.Errorf(\"floating-network-id or loadbalancer.openstack.org/floating-network-id should be specified when service.beta.kubernetes.io/openstack-internal-load-balancer is false\") </del> <ins> return nil, fmt.Errorf(\"floating-network-id or loadbalancer.openstack.org/floating-network-id should be specified when ensuring an external loadbalancer service.\") </ins> } default: return nil, fmt.Errorf(\"unknow service.beta.kubernetes.io/openstack-internal-load-balancer annotation: %v, specify \"true\" or \"false\".\",", "commid": "kubernetes_pr_53101"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-13002b8f7a203d65a315278f67f4fc6e847d33f04aed6426007d63ed6ca2eded", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: What you expected to happen: Test should not flake /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: vkamra. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nGitHub didn't allow me to assign the following users: vkamra. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n- You won't be able to assign this to me (not a kubernetes member). Am taking a look.\nvolumemetrics.go_ could/should have more logging, either calling or more calls to .\nThe test appears to fail on this metric: \"kubeletvolumestatsused_bytes\". So samplePVC != pvcName and/or sampleNS != namespace. It would be nice if the sample name and ns were also logged. Also something is weird here: the framework's is called before the local . Note in the log:\n- will add a couple of Logf() statements to log the samples - you're right that will help. Once the volume is attached, volume stats are grabbed every interval. The thing I noticed in the logs is that we issue a delete for the pod at but the volume only got attached/bound successfully at The test assumes blocks till the pod is running and PVC is attached but maybe that's not a valid assumption?\nNevermind - That log message has 2 timestamps in it - the volume was provisioned at .\nPushed The working theory being that volume stats were not collected within the wait earlier being used.\ndid you figure out if I was correct in thinking that the framework was invoked before the local ? That seems very, very unlikely but that is how it looked in the log.\n- I believe you're right that the framework is being invoked before the local one. I observe the same in a test as well, so I don't think it's specific to this call. Based on the , nested blocks should be invoked inner-outer. It's not clear, however - whether the local is nested - or at the same level as the framework block when I look at", "positive_passages": [{"docid": "doc-en-kubernetes-d85accc32c8664e5fd7d93a734b39718ee6681ce884a7faa0fd367f6f02837e8", "text": "pod, err = c.CoreV1().Pods(ns).Get(pod.Name, metav1.GetOptions{}) Expect(err).NotTo(HaveOccurred()) <del> // Wait for `VolumeStatsAggPeriod' to grab metrics time.Sleep(1 * time.Minute) // Grab kubelet metrics from the node the pod was scheduled on kubeMetrics, err := metricsGrabber.GrabFromKubelet(pod.Spec.NodeName) Expect(err).NotTo(HaveOccurred(), \"Error getting kubelet metrics : %v\", err) framework.Logf(\"Deleting pod %q/%q\", pod.Namespace, pod.Name) framework.ExpectNoError(framework.DeletePodWithWait(f, c, pod)) </del> // Verify volume stat metrics were collected for the referenced PVC volumeStatKeys := []string{ kubeletmetrics.VolumeStatsUsedBytesKey,", "commid": "kubernetes_pr_53168"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-13002b8f7a203d65a315278f67f4fc6e847d33f04aed6426007d63ed6ca2eded", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: What you expected to happen: Test should not flake /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: vkamra. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nGitHub didn't allow me to assign the following users: vkamra. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n- You won't be able to assign this to me (not a kubernetes member). Am taking a look.\nvolumemetrics.go_ could/should have more logging, either calling or more calls to .\nThe test appears to fail on this metric: \"kubeletvolumestatsused_bytes\". So samplePVC != pvcName and/or sampleNS != namespace. It would be nice if the sample name and ns were also logged. Also something is weird here: the framework's is called before the local . Note in the log:\n- will add a couple of Logf() statements to log the samples - you're right that will help. Once the volume is attached, volume stats are grabbed every interval. The thing I noticed in the logs is that we issue a delete for the pod at but the volume only got attached/bound successfully at The test assumes blocks till the pod is running and PVC is attached but maybe that's not a valid assumption?\nNevermind - That log message has 2 timestamps in it - the volume was provisioned at .\nPushed The working theory being that volume stats were not collected within the wait earlier being used.\ndid you figure out if I was correct in thinking that the framework was invoked before the local ? That seems very, very unlikely but that is how it looked in the log.\n- I believe you're right that the framework is being invoked before the local one. I observe the same in a test as well, so I don't think it's specific to this call. Based on the , nested blocks should be invoked inner-outer. It's not clear, however - whether the local is nested - or at the same level as the framework block when I look at", "positive_passages": [{"docid": "doc-en-kubernetes-fb8cda6b4773a819bbd47122213084f5b4efe1e52a0d5f7825c9e22ae3a6bad9", "text": "kubeletmetrics.VolumeStatsInodesFreeKey, kubeletmetrics.VolumeStatsInodesUsedKey, } <ins> // Poll kubelet metrics waiting for the volume to be picked up // by the volume stats collector var kubeMetrics metrics.KubeletMetrics waitErr := wait.Poll(30*time.Second, 5*time.Minute, func() (bool, error) { framework.Logf(\"Grabbing Kubelet metrics\") // Grab kubelet metrics from the node the pod was scheduled on var err error kubeMetrics, err = metricsGrabber.GrabFromKubelet(pod.Spec.NodeName) if err != nil { framework.Logf(\"Error fetching kubelet metrics\") return false, err } key := volumeStatKeys[0] kubeletKeyName := fmt.Sprintf(\"%s_%s\", kubeletmetrics.KubeletSubsystem, key) if !findVolumeStatMetric(kubeletKeyName, pvc.Namespace, pvc.Name, kubeMetrics) { return false, nil } return true, nil }) Expect(waitErr).NotTo(HaveOccurred(), \"Error finding volume metrics : %v\", waitErr) </ins> for _, key := range volumeStatKeys { kubeletKeyName := fmt.Sprintf(\"%s_%s\", kubeletmetrics.KubeletSubsystem, key) <del> verifyVolumeStatMetric(kubeletKeyName, pvc.Namespace, pvc.Name, kubeMetrics) </del> <ins> found := findVolumeStatMetric(kubeletKeyName, pvc.Namespace, pvc.Name, kubeMetrics) Expect(found).To(BeTrue(), \"PVC %s, Namespace %s not found for %s\", pvc.Name, pvc.Namespace, kubeletKeyName) </ins> } <ins> framework.Logf(\"Deleting pod %q/%q\", pod.Namespace, pod.Name) framework.ExpectNoError(framework.DeletePodWithWait(f, c, pod)) </ins> }) })", "commid": "kubernetes_pr_53168"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-13002b8f7a203d65a315278f67f4fc6e847d33f04aed6426007d63ed6ca2eded", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: What you expected to happen: Test should not flake /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: vkamra. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nGitHub didn't allow me to assign the following users: vkamra. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n- You won't be able to assign this to me (not a kubernetes member). Am taking a look.\nvolumemetrics.go_ could/should have more logging, either calling or more calls to .\nThe test appears to fail on this metric: \"kubeletvolumestatsused_bytes\". So samplePVC != pvcName and/or sampleNS != namespace. It would be nice if the sample name and ns were also logged. Also something is weird here: the framework's is called before the local . Note in the log:\n- will add a couple of Logf() statements to log the samples - you're right that will help. Once the volume is attached, volume stats are grabbed every interval. The thing I noticed in the logs is that we issue a delete for the pod at but the volume only got attached/bound successfully at The test assumes blocks till the pod is running and PVC is attached but maybe that's not a valid assumption?\nNevermind - That log message has 2 timestamps in it - the volume was provisioned at .\nPushed The working theory being that volume stats were not collected within the wait earlier being used.\ndid you figure out if I was correct in thinking that the framework was invoked before the local ? That seems very, very unlikely but that is how it looked in the log.\n- I believe you're right that the framework is being invoked before the local one. I observe the same in a test as well, so I don't think it's specific to this call. Based on the , nested blocks should be invoked inner-outer. It's not clear, however - whether the local is nested - or at the same level as the framework block when I look at", "positive_passages": [{"docid": "doc-en-kubernetes-9ad1c603d451b66a69d187a6d8c509cbf3d1a5daa22323cd47950d1db2d9ba7a", "text": "return result } <del> // Verifies the specified metrics are in `kubeletMetrics` func verifyVolumeStatMetric(metricKeyName string, namespace string, pvcName string, kubeletMetrics metrics.KubeletMetrics) { </del> <ins> // Finds the sample in the specified metric from `KubeletMetrics` tagged with // the specified namespace and pvc name func findVolumeStatMetric(metricKeyName string, namespace string, pvcName string, kubeletMetrics metrics.KubeletMetrics) bool { </ins> found := false errCount := 0 <ins> framework.Logf(\"Looking for sample in metric `%s` tagged with namespace `%s`, PVC `%s`\", metricKeyName, namespace, pvcName) </ins> if samples, ok := kubeletMetrics[metricKeyName]; ok { for _, sample := range samples { <ins> framework.Logf(\"Found sample %s\", sample.String()) </ins> samplePVC, ok := sample.Metric[\"persistentvolumeclaim\"] if !ok { framework.Logf(\"Error getting pvc for metric %s, sample %s\", metricKeyName, sample.String())", "commid": "kubernetes_pr_53168"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-13002b8f7a203d65a315278f67f4fc6e847d33f04aed6426007d63ed6ca2eded", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: What you expected to happen: Test should not flake /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: vkamra. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nGitHub didn't allow me to assign the following users: vkamra. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n- You won't be able to assign this to me (not a kubernetes member). Am taking a look.\nvolumemetrics.go_ could/should have more logging, either calling or more calls to .\nThe test appears to fail on this metric: \"kubeletvolumestatsused_bytes\". So samplePVC != pvcName and/or sampleNS != namespace. It would be nice if the sample name and ns were also logged. Also something is weird here: the framework's is called before the local . Note in the log:\n- will add a couple of Logf() statements to log the samples - you're right that will help. Once the volume is attached, volume stats are grabbed every interval. The thing I noticed in the logs is that we issue a delete for the pod at but the volume only got attached/bound successfully at The test assumes blocks till the pod is running and PVC is attached but maybe that's not a valid assumption?\nNevermind - That log message has 2 timestamps in it - the volume was provisioned at .\nPushed The working theory being that volume stats were not collected within the wait earlier being used.\ndid you figure out if I was correct in thinking that the framework was invoked before the local ? That seems very, very unlikely but that is how it looked in the log.\n- I believe you're right that the framework is being invoked before the local one. I observe the same in a test as well, so I don't think it's specific to this call. Based on the , nested blocks should be invoked inner-outer. It's not clear, however - whether the local is nested - or at the same level as the framework block when I look at", "positive_passages": [{"docid": "doc-en-kubernetes-079ac775f1c75fe9f8dbb63497758fb4f5a9d2a114fec7a4eb47806473f5167f", "text": "} } Expect(errCount).To(Equal(0), \"Found invalid samples\") <del> Expect(found).To(BeTrue(), \"PVC %s, Namespace %s not found for %s\", pvcName, namespace, metricKeyName) </del> <ins> return found </ins> }", "commid": "kubernetes_pr_53168"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-565c435e3a6e8af170a56a1cf4d531f90a9eb53fea1c780715e76a7ee1908f76", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: On a fresh Ubuntu 16.04.3 system booted from the official cloud image, fails because exists. What you expected to happen: kubeadm successfully initializes the cluster How to reproduce it (as minimally and precisely as possible): a new VM from the latest the Anything else we need to know?: Contents of : Environment: Kubernetes version (use ): Cloud provider or hardware configuration: Hyper-V generation 1 virtual machine OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: none Others: none\nThis is related to the location where the kubelet persists its certificates while running in the background, waiting for config: the kubeadm 1.8.0-0 package accidentally used a location that is the kubeadm 1.8.0-1 package corrected that to use , but starting the kubelet before running causes files to be generated into the folder since expects there to be a running kubelet prior to being called, it shouldn't expect the kubelet's folder to be empty if you are scripting bootstrapping a known clean machine, there are a few possible workarounds until is released in 1.8.1 (any of the following work around this issue): verify this is the only preflight check failure, then run the init or join command with stop the kubelet service and remove prior to running the init or join command run prior to running init or join addressed as part of\ncc\nI did it worked for me!\nOn a known clean environment, that's an ok workaround for the moment, but the reason checks for existing files/folders is to avoid stomping an existing installation, and running would negate those checks.\n(If you wonder why the deployment scripts that you wrote yesterday stopped working this morning \u2013 this is why! :-)) For the time being, before running or , I'll: check if or exists if they don't exist, stop kubelet, and wipe out I'd love to know if there are foreseeable pitfalls in this approach. Thanks! <3\napologies for the churn. we traded a for this false-positive fail safe issue. working with to determine the best way to resolve this.\nNo worries, and thanks for the super-quick turnaround time. Much appreciated! (I didn't mean to sound snarky or anything; sorry if that how it came out!)\nThis guys are posting new versions without properly testing it. Can you imagine brand new centos 7 installation and then getting: \"kubeadm 1.8.0 init fails with \"/var/lib/kubelet is not empty\" how disgusting that was and what I was thinking about responsibility and professionalism here?\nEverything was done by: but now it is even getting better: The HTTP call equal to 'curl -sSL http://localhost:/healthz' failed with error: Get http://localhost:/healthz: dial tcp [::1]:: getsockopt: connection refused you should remove 1.8 and put it do \"back to the drawing board\" stadium. It is useless even to test this 1.8\nI apologize for the issue. Our top priority was to prevent data loss and issues upgrading existing installations that would disrupt already-running workloads. We are working now to resolve this issue with fresh installations.\nWish you luck.\nETA for a fix for this? should i hard code this deletion of contents of /var/lib/kubelet prior to running kubeadm init in my automation scripts? or simply add the ignore pre flight checks arguement will do the trick?\nthere are plenty of other pre-flight checks that are valuable and you don't want to skip, it's just the check for an empty that is incorrect. if you are scripting bootstrapping a known clean machine, there are a couple possible workarounds until is released in 1.8.1: run / skipping preflight checks stop the kubelet service, remove , then run /\nok just to confirm, moving forward, ideally should not be checking for contents in (i.e. having contents is totally fine), or should installing kubelet not populate contenst of ?\nCorrect. The instructions start the kubelet and let it run in a crash loop in the background, waiting for config. In that state, the kubelet is free to write to its directory containing state (), so should not require that directory to be empty in order to run\n(Reposting my earlier tip since it worked like a charm for my automated deployment scripts.) For the time being, before running or , I'll: check if or exists if they don't exist, stop kubelet (), and wipe out () This might or might not be appropriate for your use-cases, but for mine it works great (I'm automatically deploying hundreds of k8s clusters of training purposes). Stopping kubelet is necessary to avoid race conditions where it would recreate the directory before you run .\nIf i wipe out the /var/lib/kubelet/pki directory and do not restart kubelet, the kubeadm init process hangs with kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz/syncloop' failed with error: Get http://localhost:/healthz/syncloop: dial tcp [::1]:: getsockopt: connection refused. [kubelet-check] It seems like the kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz' failed with error: Get http://localhost:/healthz: dial tcp [::1]:: getsockopt: connection refused. [kubelet-check] It seems like the kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz/syncloop' failed with error: Get http://localhost:/healthz/syncloop: dial tcp [::1]:: getsockopt: connection refused. [kubelet-check] It seems like the kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz' failed with error: Get http://localhost:/healthz: dial tcp [::1]:: getsockopt: connection refused. Unfortunately, an error has occurred: timed out waiting for the condition This error is likely caused by that: The kubelet is not running The kubelet is unhealthy due to a misconfiguration of the node in some way (required cgroups disabled) There is no internet connection; so the kubelet can't pull the following control plane images: You can troubleshoot this for example with the following commands if you're on a systemd-powered system: 'systemctl status kubelet' 'journalctl -xeu kubelet' When i check the status of kubelet, it's restarting and never starts because So, i am guessing my only option is to skip preflight checks, let me try that out..\nWish you luck. This is not the only problem: kubectl cluster-info Kubernetes master is running at http://localhost:8080 [root ~]# kubectl apply -f W1004 06:49:56. 2422 ] Failed to download OpenAPI (Get http://localhost:8080/swagger- dial tcp [::1]:8080: getsockopt: connection refused), falling back to swagger The connection to the server localhost:8080 was refused - did you specify the right host or port? Why did you put this 1.8 version when it is obviously not properly tested. Or tested at all?\nNot to forget: systemctl status firewalld firewalld.service - firewalld - dynamic firewall daemon Loaded: loaded (/usr/lib/systemd/system/firewalld.service; disabled; vendor preset: enabled) Active: inactive (dead) Docs: man:firewalld(1)\nkubeadm does not run kubernetes unsecured. following the setup instructions in the output of configures to speak to the initialized server:\nOk. This worked. Thank you. Node also by running kubeadm join.... Now the problem is dashboard. I have followed: but still don't understand where to start kubectl proxy and max.I god when I try to access dashboard is (https://192.168.4.10:6443/): { \"kind\": \"Status\", \"apiVersion\": \"v1\", \"metadata\": { }, \"status\": \"Failure\", \"message\": \"forbidden: User \"system:anonymous\" cannot get path \"/\"\", \"reason\": \"Forbidden\", \"details\": { }, \"code\": 403 } I am total newbee and anything which is not clear into documentation I can't resolve. I am using this for testing purposes and stil after 10days can't get dashboard nice and clean and then explore full power of kubernetes. Right now it is unusable even for testing.\nHi All, Need help here current i'm installing Kubernetes version: v1.8.0 using the command \"kubeadm reset && kubeadm init\" it went hanged state. systemctl status kubelet log showing that Oct 04 20:15:02 cluster-1 kubelet[]: W1004 20:15:02. ] Unable to update cni config: No networks found in /etc/cni/net.d Oct 04 20:15:02 cluster-1 kubelet[]: E1004 20:15:02. ] Container runtime network not ready: NetworkReady=false reason:Net...nitialized Oct 04 20:15:02 cluster-1 kubelet[]: E1004 20:15:02. ] Failed to get system container stats for \"\" Oct 04 20:15:02 cluster-1 kubelet[]: E1004 20:15:02. ] Failed to get system container stats for \"\" Oct 04 20:15:07 cluster-1 kubelet[]: W1004 20:15:07. ] Unable to update cni config: No networks found in /etc/cni/net.d Oct 04 20:15:07 cluster-1 kubelet[]: E1004 20:15:07. ] Container runtime network not ready: NetworkReady=false reason:Net...nitialized Oct 04 20:15:12 cluster-1 kubelet[]: W1004 20:15:12. ] Unable to update cni config: No networks found in /etc/cni/net.d Oct 04 20:15:12 cluster-1 kubelet[]: E1004 20:15:12. ] Container runtime network not ready: NetworkReady=false reason:Net...nitialized Oct 04 20:15:12 cluster-1 kubelet[]: E1004 20:15:12. ] Failed to get system container stats for \"\" Oct 04 20:15:12 cluster-1 kubelet[]: E1004 20:15:12. ] Failed to get system container stats for \"\" Warning: kubelet.service changed on disk. Run 'systemctl daemon-reload' to reload units. After that i'm tried to weave it failed with error kubectl apply -f \"$(kubectl version tr -d 'n')\" The connection to the server localhost:8080 was refused - did you specify the right host or port? W1004 18:53:33. ] Failed to download OpenAPI (Get http://localhost:8080/swagger- dial tcp [::1]:8080: getsockopt: connection refused), falling back to swagger The connection to the server localhost:8080 was refused - did you specify the right host or port? Please anyone can help me on this\nbe sure to follow the instructions to add the admin kubeconfig file so kubectl can communicate with the initialized API server:\nFor anyone following this thread, if you encounter issues other than the message, please report them in a separate issue (after searching for existing reports), to ensure they are triaged and routed appropriately and resolved as quickly as possible. Thanks.\nthank you for your quick response now i'm getting kubectl apply -f \"$(kubectl version tr -d 'n')\" Unable to connect to the server: Forbidden W1004 20:34:18. ] Failed to download OpenAPI (Get https://192.168.1.3:6443/swagger- Forbidden), falling back to swagger Unable to connect to the server: Forbidden\nyou seem to be hitting a totally different problem than the one related to ; can you please open a different issue? Thank you so much!\nI also the same issue'var/lib/kubelet is not empty' after I used the command \"kubeadm reset && kubeadm init\" it want to hanged state.(if want u can see my above threads).to move to another step I'm trying to install the weave it was failed saying that kubectl apply -f \"$(kubectl version tr -d 'n')\" The connection to the server localhost:8080 was refused - did you specify the right host or port? W1004 18:53:33. ] Failed to download OpenAPI (Get http://localhost:8080/swagger- dial tcp [::1]:8080: getsockopt: connection refused), falling back to swagger The connection to the server localhost:8080 was refused - did you specify the right host or port? Can you please help me to solve the issue Thank in advance\npick to 1.8 branch is reopening to track issue until resolved in 1.8.x\nif you get it means that your kube config file is missing. By default, tries to connect to . But when you deploy a cluster with , the API will be listening on port 6443. So you should see an error relative to port 6443, nor port 8080. If you see an error related to port 8080, it means that you haven't copied the configuration file () generated by . I hope that makes sense. My piece of advice would be to destroy the machines that you are currently using and restart from scratch (assuming you are using VMs), making sure that you follow each step carefully. Very often it solved the problem for me, because I had forgotten a step, or deviated from the instructions. Especially if something fails, it is often easier to restart from scratch, until you understand fully the technology and each underlying command. Good luck!\nHello hemaprasad, The problem is that when people know it is hard for them to set their mind to explain things to people who are new in a same area. Explanations given by jpetazzo and liggitt are ok but they are stepping over some steps which they assume but we as newbee don't. Now, to have kubernetes operational we all should: -stop the kubelet service, remove /var/lib/kubelet/pki, then run kubeadm init (without starting kubelet service first) Same goes for nodes: -stop the kubelet service, remove /var/lib/kubelet/pki, then run kubeadm join (with a token saved from kubeadm init) Now... how to make dashboard accessible from my workstation which is out of kubernetes cluster? Suppose for this I should go to some other thread?\nyour explanations are correct! As for your dashboard question, I have no idea, but I would recommend to open another github issue for that (since the title of this issue is \"kubeadm 1.8.0 init fails with \"/var/lib/kubelet is not empty\"\"). Thank you!\nThank you for fast reply. Also I am trying these innocent commands from documentations: scp root . ./kubectl --kubeconfig get nodes but I am getting: Unable to connect to the server: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"kubernetes\") My guess is that is also the same reason why dashboard over proxy is not working. Some help?\nIt looks like you are copying from a remote host. If it is the case, you also need to edit to point to that remote host (instead of ). The tutorials and documentations imply that people will run directly from the master.\nNice this is... so why into same documentation exist this: Controlling your cluster from machines other than the master In order to get a kubectl on some other computer (e.g. laptop) to talk to your cluster, you need to copy the administrator kubeconfig file from your master to your workstation like this... Never mind, it is obviously long way to go till this function even in test environment :(\nHello all. Finally dashboard starts working from master node. Please, do NOT use 1GB-2GB on master node, it would behave erratically and services which you expect to start normally... won't. Use at least 4GB and then also be patient. http://localhost:8001/ui/ will respond with strange formed URL so please use copy-paste: http://localhost:8001/api/v1/namespaces/kube-system/services/https:kubernetes-dashboard:/proxy/ That's for today. Hope this will help somebody.\n[MILESTONENOTIFIER] Milestone Issue Needs Approval Action required: This issue must have the label applied by a SIG maintainer. <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nI've tried you're workaround But I'm then on kubeadm init I'm hitting this:\nthis is fixed in v1.8.1\nAfter installing 1.8.1 kubelet won't start:\nNot only what you mentioned dkirrane, there is a problem with: They never wrote ANY detail how to add a new Node in a Cluster when your initial Token (which is valid for ... unknown) expired! Not a word. Only if you want to test-and-try yourself. Lovely beta troubleshooting job this is. Documentation should be much, much better. Especially for somebody not working on Kubernetes dev. team.\nIf you try with this you will see that there is no way to use IP address mentioned: (Text is from: ) \"To implement this automation, you must know the IP address that the master will have after it is started..... kubeadm can generate a token for you: kubeadm token generate Start both the master node and the worker nodes concurrently with this token.\" Where to use mentioned IP address? How to make any useful Node cluster joining after Token has expired?\nHello, solved a Token problem. Documentation really needs to be updated considering newbee mind. Otherwise it is source of frustration. Currently nodes are ok and operational. If this above helps you... ok.\nThis issue is fixed in the latest version of kubernetes. Just reset the kubeadm and remove the /var/lib/etcd as kubeadm is expecting it to be empty. Then start the kubeadm init. It should work fine.", "positive_passages": [{"docid": "doc-en-kubernetes-c66c0a96b5b60318ae93c6874a704e1df64e07e9d1a5368461eaf6a9cbcfbf42", "text": "PortOpenCheck{port: 10252}, HTTPProxyCheck{Proto: \"https\", Host: cfg.API.AdvertiseAddress, Port: int(cfg.API.BindPort)}, DirAvailableCheck{Path: filepath.Join(kubeadmconstants.KubernetesDir, kubeadmconstants.ManifestsSubDirName)}, <del> DirAvailableCheck{Path: \"/var/lib/kubelet\"}, </del> FileContentCheck{Path: bridgenf, Content: []byte{'1'}}, SwapCheck{}, InPathCheck{executable: \"ip\", mandatory: true},", "commid": "kubernetes_pr_53317"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-565c435e3a6e8af170a56a1cf4d531f90a9eb53fea1c780715e76a7ee1908f76", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: On a fresh Ubuntu 16.04.3 system booted from the official cloud image, fails because exists. What you expected to happen: kubeadm successfully initializes the cluster How to reproduce it (as minimally and precisely as possible): a new VM from the latest the Anything else we need to know?: Contents of : Environment: Kubernetes version (use ): Cloud provider or hardware configuration: Hyper-V generation 1 virtual machine OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: none Others: none\nThis is related to the location where the kubelet persists its certificates while running in the background, waiting for config: the kubeadm 1.8.0-0 package accidentally used a location that is the kubeadm 1.8.0-1 package corrected that to use , but starting the kubelet before running causes files to be generated into the folder since expects there to be a running kubelet prior to being called, it shouldn't expect the kubelet's folder to be empty if you are scripting bootstrapping a known clean machine, there are a few possible workarounds until is released in 1.8.1 (any of the following work around this issue): verify this is the only preflight check failure, then run the init or join command with stop the kubelet service and remove prior to running the init or join command run prior to running init or join addressed as part of\ncc\nI did it worked for me!\nOn a known clean environment, that's an ok workaround for the moment, but the reason checks for existing files/folders is to avoid stomping an existing installation, and running would negate those checks.\n(If you wonder why the deployment scripts that you wrote yesterday stopped working this morning \u2013 this is why! :-)) For the time being, before running or , I'll: check if or exists if they don't exist, stop kubelet, and wipe out I'd love to know if there are foreseeable pitfalls in this approach. Thanks! <3\napologies for the churn. we traded a for this false-positive fail safe issue. working with to determine the best way to resolve this.\nNo worries, and thanks for the super-quick turnaround time. Much appreciated! (I didn't mean to sound snarky or anything; sorry if that how it came out!)\nThis guys are posting new versions without properly testing it. Can you imagine brand new centos 7 installation and then getting: \"kubeadm 1.8.0 init fails with \"/var/lib/kubelet is not empty\" how disgusting that was and what I was thinking about responsibility and professionalism here?\nEverything was done by: but now it is even getting better: The HTTP call equal to 'curl -sSL http://localhost:/healthz' failed with error: Get http://localhost:/healthz: dial tcp [::1]:: getsockopt: connection refused you should remove 1.8 and put it do \"back to the drawing board\" stadium. It is useless even to test this 1.8\nI apologize for the issue. Our top priority was to prevent data loss and issues upgrading existing installations that would disrupt already-running workloads. We are working now to resolve this issue with fresh installations.\nWish you luck.\nETA for a fix for this? should i hard code this deletion of contents of /var/lib/kubelet prior to running kubeadm init in my automation scripts? or simply add the ignore pre flight checks arguement will do the trick?\nthere are plenty of other pre-flight checks that are valuable and you don't want to skip, it's just the check for an empty that is incorrect. if you are scripting bootstrapping a known clean machine, there are a couple possible workarounds until is released in 1.8.1: run / skipping preflight checks stop the kubelet service, remove , then run /\nok just to confirm, moving forward, ideally should not be checking for contents in (i.e. having contents is totally fine), or should installing kubelet not populate contenst of ?\nCorrect. The instructions start the kubelet and let it run in a crash loop in the background, waiting for config. In that state, the kubelet is free to write to its directory containing state (), so should not require that directory to be empty in order to run\n(Reposting my earlier tip since it worked like a charm for my automated deployment scripts.) For the time being, before running or , I'll: check if or exists if they don't exist, stop kubelet (), and wipe out () This might or might not be appropriate for your use-cases, but for mine it works great (I'm automatically deploying hundreds of k8s clusters of training purposes). Stopping kubelet is necessary to avoid race conditions where it would recreate the directory before you run .\nIf i wipe out the /var/lib/kubelet/pki directory and do not restart kubelet, the kubeadm init process hangs with kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz/syncloop' failed with error: Get http://localhost:/healthz/syncloop: dial tcp [::1]:: getsockopt: connection refused. [kubelet-check] It seems like the kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz' failed with error: Get http://localhost:/healthz: dial tcp [::1]:: getsockopt: connection refused. [kubelet-check] It seems like the kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz/syncloop' failed with error: Get http://localhost:/healthz/syncloop: dial tcp [::1]:: getsockopt: connection refused. [kubelet-check] It seems like the kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz' failed with error: Get http://localhost:/healthz: dial tcp [::1]:: getsockopt: connection refused. Unfortunately, an error has occurred: timed out waiting for the condition This error is likely caused by that: The kubelet is not running The kubelet is unhealthy due to a misconfiguration of the node in some way (required cgroups disabled) There is no internet connection; so the kubelet can't pull the following control plane images: You can troubleshoot this for example with the following commands if you're on a systemd-powered system: 'systemctl status kubelet' 'journalctl -xeu kubelet' When i check the status of kubelet, it's restarting and never starts because So, i am guessing my only option is to skip preflight checks, let me try that out..\nWish you luck. This is not the only problem: kubectl cluster-info Kubernetes master is running at http://localhost:8080 [root ~]# kubectl apply -f W1004 06:49:56. 2422 ] Failed to download OpenAPI (Get http://localhost:8080/swagger- dial tcp [::1]:8080: getsockopt: connection refused), falling back to swagger The connection to the server localhost:8080 was refused - did you specify the right host or port? Why did you put this 1.8 version when it is obviously not properly tested. Or tested at all?\nNot to forget: systemctl status firewalld firewalld.service - firewalld - dynamic firewall daemon Loaded: loaded (/usr/lib/systemd/system/firewalld.service; disabled; vendor preset: enabled) Active: inactive (dead) Docs: man:firewalld(1)\nkubeadm does not run kubernetes unsecured. following the setup instructions in the output of configures to speak to the initialized server:\nOk. This worked. Thank you. Node also by running kubeadm join.... Now the problem is dashboard. I have followed: but still don't understand where to start kubectl proxy and max.I god when I try to access dashboard is (https://192.168.4.10:6443/): { \"kind\": \"Status\", \"apiVersion\": \"v1\", \"metadata\": { }, \"status\": \"Failure\", \"message\": \"forbidden: User \"system:anonymous\" cannot get path \"/\"\", \"reason\": \"Forbidden\", \"details\": { }, \"code\": 403 } I am total newbee and anything which is not clear into documentation I can't resolve. I am using this for testing purposes and stil after 10days can't get dashboard nice and clean and then explore full power of kubernetes. Right now it is unusable even for testing.\nHi All, Need help here current i'm installing Kubernetes version: v1.8.0 using the command \"kubeadm reset && kubeadm init\" it went hanged state. systemctl status kubelet log showing that Oct 04 20:15:02 cluster-1 kubelet[]: W1004 20:15:02. ] Unable to update cni config: No networks found in /etc/cni/net.d Oct 04 20:15:02 cluster-1 kubelet[]: E1004 20:15:02. ] Container runtime network not ready: NetworkReady=false reason:Net...nitialized Oct 04 20:15:02 cluster-1 kubelet[]: E1004 20:15:02. ] Failed to get system container stats for \"\" Oct 04 20:15:02 cluster-1 kubelet[]: E1004 20:15:02. ] Failed to get system container stats for \"\" Oct 04 20:15:07 cluster-1 kubelet[]: W1004 20:15:07. ] Unable to update cni config: No networks found in /etc/cni/net.d Oct 04 20:15:07 cluster-1 kubelet[]: E1004 20:15:07. ] Container runtime network not ready: NetworkReady=false reason:Net...nitialized Oct 04 20:15:12 cluster-1 kubelet[]: W1004 20:15:12. ] Unable to update cni config: No networks found in /etc/cni/net.d Oct 04 20:15:12 cluster-1 kubelet[]: E1004 20:15:12. ] Container runtime network not ready: NetworkReady=false reason:Net...nitialized Oct 04 20:15:12 cluster-1 kubelet[]: E1004 20:15:12. ] Failed to get system container stats for \"\" Oct 04 20:15:12 cluster-1 kubelet[]: E1004 20:15:12. ] Failed to get system container stats for \"\" Warning: kubelet.service changed on disk. Run 'systemctl daemon-reload' to reload units. After that i'm tried to weave it failed with error kubectl apply -f \"$(kubectl version tr -d 'n')\" The connection to the server localhost:8080 was refused - did you specify the right host or port? W1004 18:53:33. ] Failed to download OpenAPI (Get http://localhost:8080/swagger- dial tcp [::1]:8080: getsockopt: connection refused), falling back to swagger The connection to the server localhost:8080 was refused - did you specify the right host or port? Please anyone can help me on this\nbe sure to follow the instructions to add the admin kubeconfig file so kubectl can communicate with the initialized API server:\nFor anyone following this thread, if you encounter issues other than the message, please report them in a separate issue (after searching for existing reports), to ensure they are triaged and routed appropriately and resolved as quickly as possible. Thanks.\nthank you for your quick response now i'm getting kubectl apply -f \"$(kubectl version tr -d 'n')\" Unable to connect to the server: Forbidden W1004 20:34:18. ] Failed to download OpenAPI (Get https://192.168.1.3:6443/swagger- Forbidden), falling back to swagger Unable to connect to the server: Forbidden\nyou seem to be hitting a totally different problem than the one related to ; can you please open a different issue? Thank you so much!\nI also the same issue'var/lib/kubelet is not empty' after I used the command \"kubeadm reset && kubeadm init\" it want to hanged state.(if want u can see my above threads).to move to another step I'm trying to install the weave it was failed saying that kubectl apply -f \"$(kubectl version tr -d 'n')\" The connection to the server localhost:8080 was refused - did you specify the right host or port? W1004 18:53:33. ] Failed to download OpenAPI (Get http://localhost:8080/swagger- dial tcp [::1]:8080: getsockopt: connection refused), falling back to swagger The connection to the server localhost:8080 was refused - did you specify the right host or port? Can you please help me to solve the issue Thank in advance\npick to 1.8 branch is reopening to track issue until resolved in 1.8.x\nif you get it means that your kube config file is missing. By default, tries to connect to . But when you deploy a cluster with , the API will be listening on port 6443. So you should see an error relative to port 6443, nor port 8080. If you see an error related to port 8080, it means that you haven't copied the configuration file () generated by . I hope that makes sense. My piece of advice would be to destroy the machines that you are currently using and restart from scratch (assuming you are using VMs), making sure that you follow each step carefully. Very often it solved the problem for me, because I had forgotten a step, or deviated from the instructions. Especially if something fails, it is often easier to restart from scratch, until you understand fully the technology and each underlying command. Good luck!\nHello hemaprasad, The problem is that when people know it is hard for them to set their mind to explain things to people who are new in a same area. Explanations given by jpetazzo and liggitt are ok but they are stepping over some steps which they assume but we as newbee don't. Now, to have kubernetes operational we all should: -stop the kubelet service, remove /var/lib/kubelet/pki, then run kubeadm init (without starting kubelet service first) Same goes for nodes: -stop the kubelet service, remove /var/lib/kubelet/pki, then run kubeadm join (with a token saved from kubeadm init) Now... how to make dashboard accessible from my workstation which is out of kubernetes cluster? Suppose for this I should go to some other thread?\nyour explanations are correct! As for your dashboard question, I have no idea, but I would recommend to open another github issue for that (since the title of this issue is \"kubeadm 1.8.0 init fails with \"/var/lib/kubelet is not empty\"\"). Thank you!\nThank you for fast reply. Also I am trying these innocent commands from documentations: scp root . ./kubectl --kubeconfig get nodes but I am getting: Unable to connect to the server: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"kubernetes\") My guess is that is also the same reason why dashboard over proxy is not working. Some help?\nIt looks like you are copying from a remote host. If it is the case, you also need to edit to point to that remote host (instead of ). The tutorials and documentations imply that people will run directly from the master.\nNice this is... so why into same documentation exist this: Controlling your cluster from machines other than the master In order to get a kubectl on some other computer (e.g. laptop) to talk to your cluster, you need to copy the administrator kubeconfig file from your master to your workstation like this... Never mind, it is obviously long way to go till this function even in test environment :(\nHello all. Finally dashboard starts working from master node. Please, do NOT use 1GB-2GB on master node, it would behave erratically and services which you expect to start normally... won't. Use at least 4GB and then also be patient. http://localhost:8001/ui/ will respond with strange formed URL so please use copy-paste: http://localhost:8001/api/v1/namespaces/kube-system/services/https:kubernetes-dashboard:/proxy/ That's for today. Hope this will help somebody.\n[MILESTONENOTIFIER] Milestone Issue Needs Approval Action required: This issue must have the label applied by a SIG maintainer. <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nI've tried you're workaround But I'm then on kubeadm init I'm hitting this:\nthis is fixed in v1.8.1\nAfter installing 1.8.1 kubelet won't start:\nNot only what you mentioned dkirrane, there is a problem with: They never wrote ANY detail how to add a new Node in a Cluster when your initial Token (which is valid for ... unknown) expired! Not a word. Only if you want to test-and-try yourself. Lovely beta troubleshooting job this is. Documentation should be much, much better. Especially for somebody not working on Kubernetes dev. team.\nIf you try with this you will see that there is no way to use IP address mentioned: (Text is from: ) \"To implement this automation, you must know the IP address that the master will have after it is started..... kubeadm can generate a token for you: kubeadm token generate Start both the master node and the worker nodes concurrently with this token.\" Where to use mentioned IP address? How to make any useful Node cluster joining after Token has expired?\nHello, solved a Token problem. Documentation really needs to be updated considering newbee mind. Otherwise it is source of frustration. Currently nodes are ok and operational. If this above helps you... ok.\nThis issue is fixed in the latest version of kubernetes. Just reset the kubeadm and remove the /var/lib/etcd as kubeadm is expecting it to be empty. Then start the kubeadm init. It should work fine.", "positive_passages": [{"docid": "doc-en-kubernetes-12ec821089bd0d7b353e75c1f213250ccccfe5b66da3488e43f39ef14a984d92", "text": "ServiceCheck{Service: \"docker\", CheckIfActive: true}, PortOpenCheck{port: 10250}, DirAvailableCheck{Path: filepath.Join(kubeadmconstants.KubernetesDir, kubeadmconstants.ManifestsSubDirName)}, <del> DirAvailableCheck{Path: \"/var/lib/kubelet\"}, </del> FileAvailableCheck{Path: cfg.CACertPath}, FileAvailableCheck{Path: filepath.Join(kubeadmconstants.KubernetesDir, kubeadmconstants.KubeletKubeConfigFileName)}, FileContentCheck{Path: bridgenf, Content: []byte{'1'}},", "commid": "kubernetes_pr_53317"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-565c435e3a6e8af170a56a1cf4d531f90a9eb53fea1c780715e76a7ee1908f76", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: On a fresh Ubuntu 16.04.3 system booted from the official cloud image, fails because exists. What you expected to happen: kubeadm successfully initializes the cluster How to reproduce it (as minimally and precisely as possible): a new VM from the latest the Anything else we need to know?: Contents of : Environment: Kubernetes version (use ): Cloud provider or hardware configuration: Hyper-V generation 1 virtual machine OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: none Others: none\nThis is related to the location where the kubelet persists its certificates while running in the background, waiting for config: the kubeadm 1.8.0-0 package accidentally used a location that is the kubeadm 1.8.0-1 package corrected that to use , but starting the kubelet before running causes files to be generated into the folder since expects there to be a running kubelet prior to being called, it shouldn't expect the kubelet's folder to be empty if you are scripting bootstrapping a known clean machine, there are a few possible workarounds until is released in 1.8.1 (any of the following work around this issue): verify this is the only preflight check failure, then run the init or join command with stop the kubelet service and remove prior to running the init or join command run prior to running init or join addressed as part of\ncc\nI did it worked for me!\nOn a known clean environment, that's an ok workaround for the moment, but the reason checks for existing files/folders is to avoid stomping an existing installation, and running would negate those checks.\n(If you wonder why the deployment scripts that you wrote yesterday stopped working this morning \u2013 this is why! :-)) For the time being, before running or , I'll: check if or exists if they don't exist, stop kubelet, and wipe out I'd love to know if there are foreseeable pitfalls in this approach. Thanks! <3\napologies for the churn. we traded a for this false-positive fail safe issue. working with to determine the best way to resolve this.\nNo worries, and thanks for the super-quick turnaround time. Much appreciated! (I didn't mean to sound snarky or anything; sorry if that how it came out!)\nThis guys are posting new versions without properly testing it. Can you imagine brand new centos 7 installation and then getting: \"kubeadm 1.8.0 init fails with \"/var/lib/kubelet is not empty\" how disgusting that was and what I was thinking about responsibility and professionalism here?\nEverything was done by: but now it is even getting better: The HTTP call equal to 'curl -sSL http://localhost:/healthz' failed with error: Get http://localhost:/healthz: dial tcp [::1]:: getsockopt: connection refused you should remove 1.8 and put it do \"back to the drawing board\" stadium. It is useless even to test this 1.8\nI apologize for the issue. Our top priority was to prevent data loss and issues upgrading existing installations that would disrupt already-running workloads. We are working now to resolve this issue with fresh installations.\nWish you luck.\nETA for a fix for this? should i hard code this deletion of contents of /var/lib/kubelet prior to running kubeadm init in my automation scripts? or simply add the ignore pre flight checks arguement will do the trick?\nthere are plenty of other pre-flight checks that are valuable and you don't want to skip, it's just the check for an empty that is incorrect. if you are scripting bootstrapping a known clean machine, there are a couple possible workarounds until is released in 1.8.1: run / skipping preflight checks stop the kubelet service, remove , then run /\nok just to confirm, moving forward, ideally should not be checking for contents in (i.e. having contents is totally fine), or should installing kubelet not populate contenst of ?\nCorrect. The instructions start the kubelet and let it run in a crash loop in the background, waiting for config. In that state, the kubelet is free to write to its directory containing state (), so should not require that directory to be empty in order to run\n(Reposting my earlier tip since it worked like a charm for my automated deployment scripts.) For the time being, before running or , I'll: check if or exists if they don't exist, stop kubelet (), and wipe out () This might or might not be appropriate for your use-cases, but for mine it works great (I'm automatically deploying hundreds of k8s clusters of training purposes). Stopping kubelet is necessary to avoid race conditions where it would recreate the directory before you run .\nIf i wipe out the /var/lib/kubelet/pki directory and do not restart kubelet, the kubeadm init process hangs with kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz/syncloop' failed with error: Get http://localhost:/healthz/syncloop: dial tcp [::1]:: getsockopt: connection refused. [kubelet-check] It seems like the kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz' failed with error: Get http://localhost:/healthz: dial tcp [::1]:: getsockopt: connection refused. [kubelet-check] It seems like the kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz/syncloop' failed with error: Get http://localhost:/healthz/syncloop: dial tcp [::1]:: getsockopt: connection refused. [kubelet-check] It seems like the kubelet isn't running or healthy. [kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:/healthz' failed with error: Get http://localhost:/healthz: dial tcp [::1]:: getsockopt: connection refused. Unfortunately, an error has occurred: timed out waiting for the condition This error is likely caused by that: The kubelet is not running The kubelet is unhealthy due to a misconfiguration of the node in some way (required cgroups disabled) There is no internet connection; so the kubelet can't pull the following control plane images: You can troubleshoot this for example with the following commands if you're on a systemd-powered system: 'systemctl status kubelet' 'journalctl -xeu kubelet' When i check the status of kubelet, it's restarting and never starts because So, i am guessing my only option is to skip preflight checks, let me try that out..\nWish you luck. This is not the only problem: kubectl cluster-info Kubernetes master is running at http://localhost:8080 [root ~]# kubectl apply -f W1004 06:49:56. 2422 ] Failed to download OpenAPI (Get http://localhost:8080/swagger- dial tcp [::1]:8080: getsockopt: connection refused), falling back to swagger The connection to the server localhost:8080 was refused - did you specify the right host or port? Why did you put this 1.8 version when it is obviously not properly tested. Or tested at all?\nNot to forget: systemctl status firewalld firewalld.service - firewalld - dynamic firewall daemon Loaded: loaded (/usr/lib/systemd/system/firewalld.service; disabled; vendor preset: enabled) Active: inactive (dead) Docs: man:firewalld(1)\nkubeadm does not run kubernetes unsecured. following the setup instructions in the output of configures to speak to the initialized server:\nOk. This worked. Thank you. Node also by running kubeadm join.... Now the problem is dashboard. I have followed: but still don't understand where to start kubectl proxy and max.I god when I try to access dashboard is (https://192.168.4.10:6443/): { \"kind\": \"Status\", \"apiVersion\": \"v1\", \"metadata\": { }, \"status\": \"Failure\", \"message\": \"forbidden: User \"system:anonymous\" cannot get path \"/\"\", \"reason\": \"Forbidden\", \"details\": { }, \"code\": 403 } I am total newbee and anything which is not clear into documentation I can't resolve. I am using this for testing purposes and stil after 10days can't get dashboard nice and clean and then explore full power of kubernetes. Right now it is unusable even for testing.\nHi All, Need help here current i'm installing Kubernetes version: v1.8.0 using the command \"kubeadm reset && kubeadm init\" it went hanged state. systemctl status kubelet log showing that Oct 04 20:15:02 cluster-1 kubelet[]: W1004 20:15:02. ] Unable to update cni config: No networks found in /etc/cni/net.d Oct 04 20:15:02 cluster-1 kubelet[]: E1004 20:15:02. ] Container runtime network not ready: NetworkReady=false reason:Net...nitialized Oct 04 20:15:02 cluster-1 kubelet[]: E1004 20:15:02. ] Failed to get system container stats for \"\" Oct 04 20:15:02 cluster-1 kubelet[]: E1004 20:15:02. ] Failed to get system container stats for \"\" Oct 04 20:15:07 cluster-1 kubelet[]: W1004 20:15:07. ] Unable to update cni config: No networks found in /etc/cni/net.d Oct 04 20:15:07 cluster-1 kubelet[]: E1004 20:15:07. ] Container runtime network not ready: NetworkReady=false reason:Net...nitialized Oct 04 20:15:12 cluster-1 kubelet[]: W1004 20:15:12. ] Unable to update cni config: No networks found in /etc/cni/net.d Oct 04 20:15:12 cluster-1 kubelet[]: E1004 20:15:12. ] Container runtime network not ready: NetworkReady=false reason:Net...nitialized Oct 04 20:15:12 cluster-1 kubelet[]: E1004 20:15:12. ] Failed to get system container stats for \"\" Oct 04 20:15:12 cluster-1 kubelet[]: E1004 20:15:12. ] Failed to get system container stats for \"\" Warning: kubelet.service changed on disk. Run 'systemctl daemon-reload' to reload units. After that i'm tried to weave it failed with error kubectl apply -f \"$(kubectl version tr -d 'n')\" The connection to the server localhost:8080 was refused - did you specify the right host or port? W1004 18:53:33. ] Failed to download OpenAPI (Get http://localhost:8080/swagger- dial tcp [::1]:8080: getsockopt: connection refused), falling back to swagger The connection to the server localhost:8080 was refused - did you specify the right host or port? Please anyone can help me on this\nbe sure to follow the instructions to add the admin kubeconfig file so kubectl can communicate with the initialized API server:\nFor anyone following this thread, if you encounter issues other than the message, please report them in a separate issue (after searching for existing reports), to ensure they are triaged and routed appropriately and resolved as quickly as possible. Thanks.\nthank you for your quick response now i'm getting kubectl apply -f \"$(kubectl version tr -d 'n')\" Unable to connect to the server: Forbidden W1004 20:34:18. ] Failed to download OpenAPI (Get https://192.168.1.3:6443/swagger- Forbidden), falling back to swagger Unable to connect to the server: Forbidden\nyou seem to be hitting a totally different problem than the one related to ; can you please open a different issue? Thank you so much!\nI also the same issue'var/lib/kubelet is not empty' after I used the command \"kubeadm reset && kubeadm init\" it want to hanged state.(if want u can see my above threads).to move to another step I'm trying to install the weave it was failed saying that kubectl apply -f \"$(kubectl version tr -d 'n')\" The connection to the server localhost:8080 was refused - did you specify the right host or port? W1004 18:53:33. ] Failed to download OpenAPI (Get http://localhost:8080/swagger- dial tcp [::1]:8080: getsockopt: connection refused), falling back to swagger The connection to the server localhost:8080 was refused - did you specify the right host or port? Can you please help me to solve the issue Thank in advance\npick to 1.8 branch is reopening to track issue until resolved in 1.8.x\nif you get it means that your kube config file is missing. By default, tries to connect to . But when you deploy a cluster with , the API will be listening on port 6443. So you should see an error relative to port 6443, nor port 8080. If you see an error related to port 8080, it means that you haven't copied the configuration file () generated by . I hope that makes sense. My piece of advice would be to destroy the machines that you are currently using and restart from scratch (assuming you are using VMs), making sure that you follow each step carefully. Very often it solved the problem for me, because I had forgotten a step, or deviated from the instructions. Especially if something fails, it is often easier to restart from scratch, until you understand fully the technology and each underlying command. Good luck!\nHello hemaprasad, The problem is that when people know it is hard for them to set their mind to explain things to people who are new in a same area. Explanations given by jpetazzo and liggitt are ok but they are stepping over some steps which they assume but we as newbee don't. Now, to have kubernetes operational we all should: -stop the kubelet service, remove /var/lib/kubelet/pki, then run kubeadm init (without starting kubelet service first) Same goes for nodes: -stop the kubelet service, remove /var/lib/kubelet/pki, then run kubeadm join (with a token saved from kubeadm init) Now... how to make dashboard accessible from my workstation which is out of kubernetes cluster? Suppose for this I should go to some other thread?\nyour explanations are correct! As for your dashboard question, I have no idea, but I would recommend to open another github issue for that (since the title of this issue is \"kubeadm 1.8.0 init fails with \"/var/lib/kubelet is not empty\"\"). Thank you!\nThank you for fast reply. Also I am trying these innocent commands from documentations: scp root . ./kubectl --kubeconfig get nodes but I am getting: Unable to connect to the server: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"kubernetes\") My guess is that is also the same reason why dashboard over proxy is not working. Some help?\nIt looks like you are copying from a remote host. If it is the case, you also need to edit to point to that remote host (instead of ). The tutorials and documentations imply that people will run directly from the master.\nNice this is... so why into same documentation exist this: Controlling your cluster from machines other than the master In order to get a kubectl on some other computer (e.g. laptop) to talk to your cluster, you need to copy the administrator kubeconfig file from your master to your workstation like this... Never mind, it is obviously long way to go till this function even in test environment :(\nHello all. Finally dashboard starts working from master node. Please, do NOT use 1GB-2GB on master node, it would behave erratically and services which you expect to start normally... won't. Use at least 4GB and then also be patient. http://localhost:8001/ui/ will respond with strange formed URL so please use copy-paste: http://localhost:8001/api/v1/namespaces/kube-system/services/https:kubernetes-dashboard:/proxy/ That's for today. Hope this will help somebody.\n[MILESTONENOTIFIER] Milestone Issue Needs Approval Action required: This issue must have the label applied by a SIG maintainer. <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nI've tried you're workaround But I'm then on kubeadm init I'm hitting this:\nthis is fixed in v1.8.1\nAfter installing 1.8.1 kubelet won't start:\nNot only what you mentioned dkirrane, there is a problem with: They never wrote ANY detail how to add a new Node in a Cluster when your initial Token (which is valid for ... unknown) expired! Not a word. Only if you want to test-and-try yourself. Lovely beta troubleshooting job this is. Documentation should be much, much better. Especially for somebody not working on Kubernetes dev. team.\nIf you try with this you will see that there is no way to use IP address mentioned: (Text is from: ) \"To implement this automation, you must know the IP address that the master will have after it is started..... kubeadm can generate a token for you: kubeadm token generate Start both the master node and the worker nodes concurrently with this token.\" Where to use mentioned IP address? How to make any useful Node cluster joining after Token has expired?\nHello, solved a Token problem. Documentation really needs to be updated considering newbee mind. Otherwise it is source of frustration. Currently nodes are ok and operational. If this above helps you... ok.\nThis issue is fixed in the latest version of kubernetes. Just reset the kubeadm and remove the /var/lib/etcd as kubeadm is expecting it to be empty. Then start the kubeadm init. It should work fine.", "positive_passages": [{"docid": "doc-en-kubernetes-402589e4bafdcf8a3d902eb342bc69c0d1941a6427c7b777aaee009f4a987beb", "text": "RequireKubeConfig:       false, KubeConfig:              flag.NewStringFlag(\"/var/lib/kubelet/kubeconfig\"), ContainerRuntimeOptions: *NewContainerRuntimeOptions(), <del> CertDirectory:           \"/var/run/kubernetes\", </del> <ins> CertDirectory:           \"/var/lib/kubelet/pki\", </ins> RootDirectory:           v1alpha1.DefaultRootDir, // DEPRECATED: auto detecting cloud providers goes against the initiative // for out-of-tree cloud providers as we'll now depend on cAdvisor integrations", "commid": "kubernetes_pr_53317"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcd38f96bb0b0d9330540253d08f14b2aaabd10f649fad7a7075c60a5f24ba31", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: CRD: Existing object: New object: says: If this is a problem with the new object definition rather than a bug with , I'd expect a better error message. (The new object looks fine to me, though; it should be identical to the old object.) What you expected to happen: I expected the object to be updated without an error. How to reproduce it (as minimally and precisely as possible): See description. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration**: GCE OS (e.g. from /etc/os-release): CentOS Linux 7.4 (1708) Kernel (e.g. ): Linux master-head-1 4.13.4- SMP Wed Sep 27 13:32:23 EDT 2017 x8664 x8664 x8664 GNU/Linux Install tools: Custom scripts Others:\n/sig api-machinery\nAre you able to reproduce this everytime? I am able to use apply normally with your example.\nI can reliably reproduce it if the annotation exists: If I use to remove the annotation, then it works the first time but fails thereafter:\nThis is happening for other CRDs as well (Prometheus Operator ServiceMonitors). If I apply a ServiceMonitor CRD 3 times: If I remove the annotation or replace the object () then I can work around the issue.\nSeems any CRD is affected; the CRD used by our are also not working: This has completely broken our CI/CD workflow... unfortunately we'd already completed the TPR-CRD migration for the 1.8 upgrade before noticing this problem, so we can't really downgrade. How safe is as an alternative to ? It still generates an update event for watchers, not a delete/recreate, right?\nIt looks like something going wrong during the patching. After using changes from , I get this: /cc /area third-party-resource\nBut uses json merge patch and not strategic merge patch for custom resources:\nI was able to reproduce this in v1.8.0 with the original manifests at the top. As found, it only happens on the 3rd execution: It also seems to only happen when the ought to be a no-op. If I change something in the IPPool spec, works once more, then starts failing again. When the is a no-op, the PATCH request body generated by looks like this: When the is NOT a no-op, the PATCH request body looks like this:\nThere's a typo in the code generating the error messages for both and : They should be calling instead of . When I fix that, the error message becomes:\nI can reproduce this without , just by doing a no-op twice:\nThe same issue affects v1.7.8 (tested on GKE)\nSame issue with v1.8.1\nThis just fix the error message: But it doesn't fix the issue\nStill investigating the issue but I noticed that when we do a no-op patch for native resources, we get a \"not patched\" response. However, for non-native resources, it still tries to patch it (and bumps the resourceVersion too).\nI don't konwn whether this is a issue, I can't do strategic merge patch to CRD. When I run , --type=merge must be passed.\nWe should be able to apply strategic merge patch to CRDs. However, we can't apply strategic merge to CRs because we're missing the metadata about how to handle each field for the strategic merge patch. Unfortunately, this error is occuring even with . :(\n/assign\ndo you know if the fix fir this will make it to 1.8.3\nhopefully yes, this should be merged soon.\nthanks! this has been a blocker for us to upgrade to 1.8\ncan you confirm this is completely fixed? The PR writes \"partial fix\".\nNow we can't reproduce this issue with the method descripted above. I still need some I extra time to research it. Maybe we can close this one. If I can reproduce the issue in another way, I can open another issue with new situation.\nIf it's not fixed, let's keep it open.\nFun, a fork closing issues.\nFrom Then I think we can officially close this.\n(the fix is merged into release-1.8, but after v1.8.4-beta.0)\nwhat stable release of k8s will this be in? 1.8.4 or 1.8.5?\nIs there an update for this?\nlooks like it was merged here: but did not make it into 1.8.4, might make it into 1.8.5", "positive_passages": [{"docid": "doc-en-kubernetes-09ba942f4100f76508438efa1282a69e54cdcf21172437fdce6cedf3ab005788", "text": "\"//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library\", \"//vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured:go_default_library\", \"//vendor/k8s.io/apimachinery/pkg/runtime:go_default_library\", <ins> \"//vendor/k8s.io/apimachinery/pkg/types:go_default_library\", </ins> \"//vendor/k8s.io/apimachinery/pkg/util/wait:go_default_library\", \"//vendor/k8s.io/apimachinery/pkg/watch:go_default_library\", \"//vendor/k8s.io/apiserver/pkg/util/feature:go_default_library\",", "commid": "kubernetes_pr_54780"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcd38f96bb0b0d9330540253d08f14b2aaabd10f649fad7a7075c60a5f24ba31", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: CRD: Existing object: New object: says: If this is a problem with the new object definition rather than a bug with , I'd expect a better error message. (The new object looks fine to me, though; it should be identical to the old object.) What you expected to happen: I expected the object to be updated without an error. How to reproduce it (as minimally and precisely as possible): See description. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration**: GCE OS (e.g. from /etc/os-release): CentOS Linux 7.4 (1708) Kernel (e.g. ): Linux master-head-1 4.13.4- SMP Wed Sep 27 13:32:23 EDT 2017 x8664 x8664 x8664 GNU/Linux Install tools: Custom scripts Others:\n/sig api-machinery\nAre you able to reproduce this everytime? I am able to use apply normally with your example.\nI can reliably reproduce it if the annotation exists: If I use to remove the annotation, then it works the first time but fails thereafter:\nThis is happening for other CRDs as well (Prometheus Operator ServiceMonitors). If I apply a ServiceMonitor CRD 3 times: If I remove the annotation or replace the object () then I can work around the issue.\nSeems any CRD is affected; the CRD used by our are also not working: This has completely broken our CI/CD workflow... unfortunately we'd already completed the TPR-CRD migration for the 1.8 upgrade before noticing this problem, so we can't really downgrade. How safe is as an alternative to ? It still generates an update event for watchers, not a delete/recreate, right?\nIt looks like something going wrong during the patching. After using changes from , I get this: /cc /area third-party-resource\nBut uses json merge patch and not strategic merge patch for custom resources:\nI was able to reproduce this in v1.8.0 with the original manifests at the top. As found, it only happens on the 3rd execution: It also seems to only happen when the ought to be a no-op. If I change something in the IPPool spec, works once more, then starts failing again. When the is a no-op, the PATCH request body generated by looks like this: When the is NOT a no-op, the PATCH request body looks like this:\nThere's a typo in the code generating the error messages for both and : They should be calling instead of . When I fix that, the error message becomes:\nI can reproduce this without , just by doing a no-op twice:\nThe same issue affects v1.7.8 (tested on GKE)\nSame issue with v1.8.1\nThis just fix the error message: But it doesn't fix the issue\nStill investigating the issue but I noticed that when we do a no-op patch for native resources, we get a \"not patched\" response. However, for non-native resources, it still tries to patch it (and bumps the resourceVersion too).\nI don't konwn whether this is a issue, I can't do strategic merge patch to CRD. When I run , --type=merge must be passed.\nWe should be able to apply strategic merge patch to CRDs. However, we can't apply strategic merge to CRs because we're missing the metadata about how to handle each field for the strategic merge patch. Unfortunately, this error is occuring even with . :(\n/assign\ndo you know if the fix fir this will make it to 1.8.3\nhopefully yes, this should be merged soon.\nthanks! this has been a blocker for us to upgrade to 1.8\ncan you confirm this is completely fixed? The PR writes \"partial fix\".\nNow we can't reproduce this issue with the method descripted above. I still need some I extra time to research it. Maybe we can close this one. If I can reproduce the issue in another way, I can open another issue with new situation.\nIf it's not fixed, let's keep it open.\nFun, a fork closing issues.\nFrom Then I think we can officially close this.\n(the fix is merged into release-1.8, but after v1.8.4-beta.0)\nwhat stable release of k8s will this be in? 1.8.4 or 1.8.5?\nIs there an update for this?\nlooks like it was merged here: but did not make it into 1.8.4, might make it into 1.8.5", "positive_passages": [{"docid": "doc-en-kubernetes-f83e3d708392a283ebba98a2de2bfc65a8d14a1574be05b79b70b9c814dbf6fc", "text": "metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured\" \"k8s.io/apimachinery/pkg/runtime\" <ins> \"k8s.io/apimachinery/pkg/types\" </ins> \"k8s.io/apimachinery/pkg/util/wait\" \"k8s.io/apimachinery/pkg/watch\" \"k8s.io/client-go/dynamic\"", "commid": "kubernetes_pr_54780"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcd38f96bb0b0d9330540253d08f14b2aaabd10f649fad7a7075c60a5f24ba31", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: CRD: Existing object: New object: says: If this is a problem with the new object definition rather than a bug with , I'd expect a better error message. (The new object looks fine to me, though; it should be identical to the old object.) What you expected to happen: I expected the object to be updated without an error. How to reproduce it (as minimally and precisely as possible): See description. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration**: GCE OS (e.g. from /etc/os-release): CentOS Linux 7.4 (1708) Kernel (e.g. ): Linux master-head-1 4.13.4- SMP Wed Sep 27 13:32:23 EDT 2017 x8664 x8664 x8664 GNU/Linux Install tools: Custom scripts Others:\n/sig api-machinery\nAre you able to reproduce this everytime? I am able to use apply normally with your example.\nI can reliably reproduce it if the annotation exists: If I use to remove the annotation, then it works the first time but fails thereafter:\nThis is happening for other CRDs as well (Prometheus Operator ServiceMonitors). If I apply a ServiceMonitor CRD 3 times: If I remove the annotation or replace the object () then I can work around the issue.\nSeems any CRD is affected; the CRD used by our are also not working: This has completely broken our CI/CD workflow... unfortunately we'd already completed the TPR-CRD migration for the 1.8 upgrade before noticing this problem, so we can't really downgrade. How safe is as an alternative to ? It still generates an update event for watchers, not a delete/recreate, right?\nIt looks like something going wrong during the patching. After using changes from , I get this: /cc /area third-party-resource\nBut uses json merge patch and not strategic merge patch for custom resources:\nI was able to reproduce this in v1.8.0 with the original manifests at the top. As found, it only happens on the 3rd execution: It also seems to only happen when the ought to be a no-op. If I change something in the IPPool spec, works once more, then starts failing again. When the is a no-op, the PATCH request body generated by looks like this: When the is NOT a no-op, the PATCH request body looks like this:\nThere's a typo in the code generating the error messages for both and : They should be calling instead of . When I fix that, the error message becomes:\nI can reproduce this without , just by doing a no-op twice:\nThe same issue affects v1.7.8 (tested on GKE)\nSame issue with v1.8.1\nThis just fix the error message: But it doesn't fix the issue\nStill investigating the issue but I noticed that when we do a no-op patch for native resources, we get a \"not patched\" response. However, for non-native resources, it still tries to patch it (and bumps the resourceVersion too).\nI don't konwn whether this is a issue, I can't do strategic merge patch to CRD. When I run , --type=merge must be passed.\nWe should be able to apply strategic merge patch to CRDs. However, we can't apply strategic merge to CRs because we're missing the metadata about how to handle each field for the strategic merge patch. Unfortunately, this error is occuring even with . :(\n/assign\ndo you know if the fix fir this will make it to 1.8.3\nhopefully yes, this should be merged soon.\nthanks! this has been a blocker for us to upgrade to 1.8\ncan you confirm this is completely fixed? The PR writes \"partial fix\".\nNow we can't reproduce this issue with the method descripted above. I still need some I extra time to research it. Maybe we can close this one. If I can reproduce the issue in another way, I can open another issue with new situation.\nIf it's not fixed, let's keep it open.\nFun, a fork closing issues.\nFrom Then I think we can officially close this.\n(the fix is merged into release-1.8, but after v1.8.4-beta.0)\nwhat stable release of k8s will this be in? 1.8.4 or 1.8.5?\nIs there an update for this?\nlooks like it was merged here: but did not make it into 1.8.4, might make it into 1.8.5", "positive_passages": [{"docid": "doc-en-kubernetes-3a1fd1ecf5986d6e0ae6fce4fea3c3fd4ef399e9f999b0a3d9caec7910b524ba", "text": "} } <ins> func TestPatch(t *testing.T) { stopCh, apiExtensionClient, clientPool, err := testserver.StartDefaultServer() if err != nil { t.Fatal(err) } defer close(stopCh) noxuDefinition := testserver.NewNoxuCustomResourceDefinition(apiextensionsv1beta1.ClusterScoped) noxuVersionClient, err := testserver.CreateNewCustomResourceDefinition(noxuDefinition, apiExtensionClient, clientPool) if err != nil { t.Fatal(err) } ns := \"not-the-default\" noxuNamespacedResourceClient := noxuVersionClient.Resource(&metav1.APIResource{ Name:       noxuDefinition.Spec.Names.Plural, Namespaced: true, }, ns) noxuInstanceToCreate := testserver.NewNoxuInstance(ns, \"foo\") createdNoxuInstance, err := noxuNamespacedResourceClient.Create(noxuInstanceToCreate) if err != nil { t.Fatal(err) } patch := []byte(`{\"num\": {\"num2\":999}}`) createdNoxuInstance, err = noxuNamespacedResourceClient.Patch(\"foo\", types.MergePatchType, patch) if err != nil { t.Fatalf(\"unexpected error: %v\", err) } // a patch with no change createdNoxuInstance, err = noxuNamespacedResourceClient.Patch(\"foo\", types.MergePatchType, patch) if err != nil { t.Fatalf(\"unexpected error: %v\", err) } // an empty patch createdNoxuInstance, err = noxuNamespacedResourceClient.Patch(\"foo\", types.MergePatchType, []byte(`{}`)) if err != nil { t.Fatalf(\"unexpected error: %v\", err) } originalJSON, err := runtime.Encode(unstructured.UnstructuredJSONScheme, createdNoxuInstance) if err != nil { t.Fatalf(\"unexpected error: %v\", err) } gottenNoxuInstance, err := runtime.Decode(unstructured.UnstructuredJSONScheme, originalJSON) if err != nil { t.Fatalf(\"unexpected error: %v\", err) } // Check if int is preserved. unstructuredObj := gottenNoxuInstance.(*unstructured.Unstructured).Object num := unstructuredObj[\"num\"].(map[string]interface{}) num1 := num[\"num1\"].(int64) num2 := num[\"num2\"].(int64) if num1 != 9223372036854775807 || num2 != 999 { t.Errorf(\"Expected %v, got %v, %v\", `9223372036854775807, 999`, num1, num2) } } </ins> func TestCrossNamespaceListWatch(t *testing.T) { stopCh, apiExtensionClient, clientPool, err := testserver.StartDefaultServer() if err != nil {", "commid": "kubernetes_pr_54780"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcd38f96bb0b0d9330540253d08f14b2aaabd10f649fad7a7075c60a5f24ba31", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: CRD: Existing object: New object: says: If this is a problem with the new object definition rather than a bug with , I'd expect a better error message. (The new object looks fine to me, though; it should be identical to the old object.) What you expected to happen: I expected the object to be updated without an error. How to reproduce it (as minimally and precisely as possible): See description. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration**: GCE OS (e.g. from /etc/os-release): CentOS Linux 7.4 (1708) Kernel (e.g. ): Linux master-head-1 4.13.4- SMP Wed Sep 27 13:32:23 EDT 2017 x8664 x8664 x8664 GNU/Linux Install tools: Custom scripts Others:\n/sig api-machinery\nAre you able to reproduce this everytime? I am able to use apply normally with your example.\nI can reliably reproduce it if the annotation exists: If I use to remove the annotation, then it works the first time but fails thereafter:\nThis is happening for other CRDs as well (Prometheus Operator ServiceMonitors). If I apply a ServiceMonitor CRD 3 times: If I remove the annotation or replace the object () then I can work around the issue.\nSeems any CRD is affected; the CRD used by our are also not working: This has completely broken our CI/CD workflow... unfortunately we'd already completed the TPR-CRD migration for the 1.8 upgrade before noticing this problem, so we can't really downgrade. How safe is as an alternative to ? It still generates an update event for watchers, not a delete/recreate, right?\nIt looks like something going wrong during the patching. After using changes from , I get this: /cc /area third-party-resource\nBut uses json merge patch and not strategic merge patch for custom resources:\nI was able to reproduce this in v1.8.0 with the original manifests at the top. As found, it only happens on the 3rd execution: It also seems to only happen when the ought to be a no-op. If I change something in the IPPool spec, works once more, then starts failing again. When the is a no-op, the PATCH request body generated by looks like this: When the is NOT a no-op, the PATCH request body looks like this:\nThere's a typo in the code generating the error messages for both and : They should be calling instead of . When I fix that, the error message becomes:\nI can reproduce this without , just by doing a no-op twice:\nThe same issue affects v1.7.8 (tested on GKE)\nSame issue with v1.8.1\nThis just fix the error message: But it doesn't fix the issue\nStill investigating the issue but I noticed that when we do a no-op patch for native resources, we get a \"not patched\" response. However, for non-native resources, it still tries to patch it (and bumps the resourceVersion too).\nI don't konwn whether this is a issue, I can't do strategic merge patch to CRD. When I run , --type=merge must be passed.\nWe should be able to apply strategic merge patch to CRDs. However, we can't apply strategic merge to CRs because we're missing the metadata about how to handle each field for the strategic merge patch. Unfortunately, this error is occuring even with . :(\n/assign\ndo you know if the fix fir this will make it to 1.8.3\nhopefully yes, this should be merged soon.\nthanks! this has been a blocker for us to upgrade to 1.8\ncan you confirm this is completely fixed? The PR writes \"partial fix\".\nNow we can't reproduce this issue with the method descripted above. I still need some I extra time to research it. Maybe we can close this one. If I can reproduce the issue in another way, I can open another issue with new situation.\nIf it's not fixed, let's keep it open.\nFun, a fork closing issues.\nFrom Then I think we can officially close this.\n(the fix is merged into release-1.8, but after v1.8.4-beta.0)\nwhat stable release of k8s will this be in? 1.8.4 or 1.8.5?\nIs there an update for this?\nlooks like it was merged here: but did not make it into 1.8.4, might make it into 1.8.5", "positive_passages": [{"docid": "doc-en-kubernetes-d31cf03a946e8f5368d7bd0d2de9546c6a35ea19f752affb73016800d3a6e4c7", "text": "if err != nil { return err } <del> mustCheckData = false continue </del> <ins> if !bytes.Equal(data, origState.data) { // original data changed, restart loop mustCheckData = false continue } </ins> } return decode(s.codec, s.versioner, origState.data, out, origState.rev) }", "commid": "kubernetes_pr_54780"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-34d17b13918e1176128a125a4446a9ee51e6076dbf365b28187a9878bb1d98f0", "query": "This issue is meant to track planned work items for pre-allocated hugepages across releases. This issue captures the plan of record discussed in the wg-resource-mgmt meetings. [x] HugePages should be restricted via ResourceQuota [Owner: , fixed ] Assess ability to graduate feature to beta. [x] HugePages should require the user to request cpu or memory [Owner: fixed ] [x] HugePages should not be tied to QoS [Owner: fixed ] [ ] HugePages promoted to beta [Owner: ][ ] HugePages isolated at container and not just pod boundary [Owner: TBD] [ ] HugePages should be restricted via LimitRange [Owner: TBD] cc\n/cc\nIf no one is doing it, I'd like to work on the ResourceQuota part.\nwould this be discussed in the meeting recently? i would like to try on the \"via LimitRange\" but seems more details need to be settled.\n/cc\nRegarding to the ResourceQuota issue, all I could think is to add support for resource HugePages in podEvaluator of quota, so that it could be aware of the hugepage declared in resourceQuota, and that requested in podSpec. It is thought to be a small change, The only thing that needs attention is the way to address resource HugePages, as it's name is not fixed, like CPU or memory, but in a specific format. Correct me if I miss something :)\n-- the quota change is relatively small, if you want to pick up the work, i would be happy to shephard it.\n-- you as owner, thanks for volunteering! let me know when you have the pr up\nare you ready for the LimitRange part? :)\nyes, I've worked on this for some time and will commit the pr ASAP.\n/cc\nhi, I am confused by the tests I've made, which seems the \"HugePages should be restricted via LimitRange\" has already been done. I created the LimitRange as below: apiVersion: v1 kind: LimitRange metadata: name: mytest spec: limits: default: hugepages-2Mi: 40Mi defaultRequest: hugepages-2Mi: 40Mi type: Container and the pods created by the following yaml: apiVersion: v1 kind: Pod metadata: generateName: hugepages-volume- spec: containers: image: tomcatjava:v6.0 command: name: example and the output of the pod in yaml is like: spec: containers: command: image: tomcatjava:v6.0 imagePullPolicy: IfNotPresent name: example resources: limits: hugepages-2Mi: 40Mi memory: 250Mi requests: hugepages-2Mi: 40Mi memory: 125Mi Is this the LimitRange part already been done? Otherwise anything wrong with my understanding? Also, I found an subtle error in the error info when creating pods restricted by the hugepage , would you please take a look?\n-- thanks for the feedback, i have been distracted looking at other topics, but hope to return to this later this week.\nI have filed an issue related to hugepages, would you please check when you are free? link:\nyou can't re-open an issue/PR unless you authored it or you are assigned to it. <detailsIn response to : /reopen </details\nhi, I've worked on the HugePages isolated at container and not just pod boundary issue and would like to confirm some details. My first though was to implement this issue via docker, just like what cpu and memory did. But docker seems not support hugepage limit in present. Which means we have to get it done by coding in kubernetes or libcontainer, is that right? Please let me know if there are any other instructions that may help :)\n-- to support isolation at container boundary, we would need support from the container runtime. that would require support in the CRI to expose the resource, and support in individual container runtimes (contianerd, cri-o, docker, rkt, etc.) to actually make use of it. in practice though, i have not seen a major requirement to support container boundary isolation. do you have use cases in mind that would require it?\nI have no any other use cases as well, for now all the achievements fit well for our requirements. BTW, does the still need to move on? I found it seems already being supported by default.\nI don't think the intent was for to close this /reopen\nyou can't re-open an issue/PR unless you authored it or you are assigned to it. <detailsIn response to : I don't think the intent was for to close this /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-16de65748754c10be5aea03f696ceae821440f39b46be88dfb88e7f5f3bfd141", "text": "CPUManager utilfeature.Feature = \"CPUManager\" // owner: @derekwaynecarr <del> // alpha: v1.8 </del> <ins> // beta: v1.10 </ins> // // Enable pods to consume pre-allocated huge pages of varying page sizes HugePages utilfeature.Feature = \"HugePages\"", "commid": "kubernetes_pr_56939"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-34d17b13918e1176128a125a4446a9ee51e6076dbf365b28187a9878bb1d98f0", "query": "This issue is meant to track planned work items for pre-allocated hugepages across releases. This issue captures the plan of record discussed in the wg-resource-mgmt meetings. [x] HugePages should be restricted via ResourceQuota [Owner: , fixed ] Assess ability to graduate feature to beta. [x] HugePages should require the user to request cpu or memory [Owner: fixed ] [x] HugePages should not be tied to QoS [Owner: fixed ] [ ] HugePages promoted to beta [Owner: ][ ] HugePages isolated at container and not just pod boundary [Owner: TBD] [ ] HugePages should be restricted via LimitRange [Owner: TBD] cc\n/cc\nIf no one is doing it, I'd like to work on the ResourceQuota part.\nwould this be discussed in the meeting recently? i would like to try on the \"via LimitRange\" but seems more details need to be settled.\n/cc\nRegarding to the ResourceQuota issue, all I could think is to add support for resource HugePages in podEvaluator of quota, so that it could be aware of the hugepage declared in resourceQuota, and that requested in podSpec. It is thought to be a small change, The only thing that needs attention is the way to address resource HugePages, as it's name is not fixed, like CPU or memory, but in a specific format. Correct me if I miss something :)\n-- the quota change is relatively small, if you want to pick up the work, i would be happy to shephard it.\n-- you as owner, thanks for volunteering! let me know when you have the pr up\nare you ready for the LimitRange part? :)\nyes, I've worked on this for some time and will commit the pr ASAP.\n/cc\nhi, I am confused by the tests I've made, which seems the \"HugePages should be restricted via LimitRange\" has already been done. I created the LimitRange as below: apiVersion: v1 kind: LimitRange metadata: name: mytest spec: limits: default: hugepages-2Mi: 40Mi defaultRequest: hugepages-2Mi: 40Mi type: Container and the pods created by the following yaml: apiVersion: v1 kind: Pod metadata: generateName: hugepages-volume- spec: containers: image: tomcatjava:v6.0 command: name: example and the output of the pod in yaml is like: spec: containers: command: image: tomcatjava:v6.0 imagePullPolicy: IfNotPresent name: example resources: limits: hugepages-2Mi: 40Mi memory: 250Mi requests: hugepages-2Mi: 40Mi memory: 125Mi Is this the LimitRange part already been done? Otherwise anything wrong with my understanding? Also, I found an subtle error in the error info when creating pods restricted by the hugepage , would you please take a look?\n-- thanks for the feedback, i have been distracted looking at other topics, but hope to return to this later this week.\nI have filed an issue related to hugepages, would you please check when you are free? link:\nyou can't re-open an issue/PR unless you authored it or you are assigned to it. <detailsIn response to : /reopen </details\nhi, I've worked on the HugePages isolated at container and not just pod boundary issue and would like to confirm some details. My first though was to implement this issue via docker, just like what cpu and memory did. But docker seems not support hugepage limit in present. Which means we have to get it done by coding in kubernetes or libcontainer, is that right? Please let me know if there are any other instructions that may help :)\n-- to support isolation at container boundary, we would need support from the container runtime. that would require support in the CRI to expose the resource, and support in individual container runtimes (contianerd, cri-o, docker, rkt, etc.) to actually make use of it. in practice though, i have not seen a major requirement to support container boundary isolation. do you have use cases in mind that would require it?\nI have no any other use cases as well, for now all the achievements fit well for our requirements. BTW, does the still need to move on? I found it seems already being supported by default.\nI don't think the intent was for to close this /reopen\nyou can't re-open an issue/PR unless you authored it or you are assigned to it. <detailsIn response to : I don't think the intent was for to close this /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-cb26900187cb2692ae0cd452a8da882793d8852d9a6a194253280397133632e4", "text": "RotateKubeletClientCertificate:              {Default: true, PreRelease: utilfeature.Beta}, PersistentLocalVolumes:                      {Default: false, PreRelease: utilfeature.Alpha}, LocalStorageCapacityIsolation:               {Default: false, PreRelease: utilfeature.Alpha}, <del> HugePages:                                   {Default: false, PreRelease: utilfeature.Alpha}, </del> <ins> HugePages:                                   {Default: true, PreRelease: utilfeature.Beta}, </ins> DebugContainers:                             {Default: false, PreRelease: utilfeature.Alpha}, PodPriority:                                 {Default: false, PreRelease: utilfeature.Alpha}, EnableEquivalenceClassCache:                 {Default: false, PreRelease: utilfeature.Alpha},", "commid": "kubernetes_pr_56939"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-73a311e0fb78fe06f854f9b67bb3be0d69fae466b5afe5af981f39439c3cf6d4", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Pods with volumeMount gitRepo volumes in 1.8.0 see the following error in kubelet logs (also in ) It is important to not that the git repo clone is done via ssh. I think what is happening is that hyperkube image now used to have command in it and now it does not have it. So the git clone command that kubelet runs fails with the above stacktrace since it cannot find . What you expected to happen: gitRepo is volume mounted. How to reproduce it (as minimally and precisely as possible): Reproducible in kubernetes 1.8.0+ hyperkube images. Anything else we need to know?: This probably is due to missing ssh binary in the new 1.8.0 hyperkube images. The commit might be an issue. Will comment further if I find otherwise. Environment: Kubernetes version (use ): =1.8.0 Cloud provider or hardware configuration**: Not Application. OS (e.g. from /etc/os-release): hyperkube base image Kernel (e.g. ): Install tools: Others:\nHow did you installed Kubernetes may I ask?\nhow does this help?\nNormally, it is suggest to install kubelet as a daemon on host instead of using hyperkube container. cc you may be interested in this issue.\nNeed your help in identifying the fix here. I can send something for review. Suggestions are welcome.\nThe problem is that ssh isn't installed inside of the container. I don't know if it should be either, as the hyperkube image grows so large. If you install the openssh-client, it should work\nYes I did identify that as the problem if you see the description I mentioned. I pointed to a git commit that might have caused this. I am not sure what package installation has changed in the hyperkube container. \"ssh\" used to be available and now it is not. For the gitrepo feature to work it should be available.\nAh okay. If it was there before, we might want to add it back. SGTM.\nYeah, I switched the hyperkube image base from to our with some additional dependencies back. Apparently due to lack of volume + hyperkube test coverage, I've missed a number of dependencies needed. cc\nwe could use dropbear as a replacement for just the ssh client?\nI would prefer to use the openssh client over the dropbear client. It has wider usage and a stronger security track record IMO. The dropbear client also has somewhat different usage and configuration, so arguably using it is still a regression over the previous state. Saving a couple MB isn't worth using worse utilities, however much fun \"dockerfile-golfing\" is.\nto fix\ncherrypick to release-1.8:\nThis should be fixed in v1.8.3.", "positive_passages": [{"docid": "doc-en-kubernetes-fb60e4b400c73f7472d474b8b92ebfd9ef489c04eea1534dd2f8e23c40208d6c", "text": "RUN ln -s /bin/sh /bin/bash RUN echo CACHEBUST>/dev/null && clean-install  <del> iptables  </del> <ins> ca-certificates  ceph-common  cifs-utils  conntrack  </ins> e2fsprogs  ebtables  ethtool  <del> kmod  ca-certificates  conntrack  util-linux  socat  </del> git  <ins> glusterfs-client  iptables  </ins> jq  <ins> kmod  openssh-client  </ins> nfs-common  <del> glusterfs-client  cifs-utils  ceph-common </del> <ins> socat  util-linux </ins> COPY cni-bin/bin /opt/cni/bin", "commid": "kubernetes_pr_54250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-73a311e0fb78fe06f854f9b67bb3be0d69fae466b5afe5af981f39439c3cf6d4", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Pods with volumeMount gitRepo volumes in 1.8.0 see the following error in kubelet logs (also in ) It is important to not that the git repo clone is done via ssh. I think what is happening is that hyperkube image now used to have command in it and now it does not have it. So the git clone command that kubelet runs fails with the above stacktrace since it cannot find . What you expected to happen: gitRepo is volume mounted. How to reproduce it (as minimally and precisely as possible): Reproducible in kubernetes 1.8.0+ hyperkube images. Anything else we need to know?: This probably is due to missing ssh binary in the new 1.8.0 hyperkube images. The commit might be an issue. Will comment further if I find otherwise. Environment: Kubernetes version (use ): =1.8.0 Cloud provider or hardware configuration**: Not Application. OS (e.g. from /etc/os-release): hyperkube base image Kernel (e.g. ): Install tools: Others:\nHow did you installed Kubernetes may I ask?\nhow does this help?\nNormally, it is suggest to install kubelet as a daemon on host instead of using hyperkube container. cc you may be interested in this issue.\nNeed your help in identifying the fix here. I can send something for review. Suggestions are welcome.\nThe problem is that ssh isn't installed inside of the container. I don't know if it should be either, as the hyperkube image grows so large. If you install the openssh-client, it should work\nYes I did identify that as the problem if you see the description I mentioned. I pointed to a git commit that might have caused this. I am not sure what package installation has changed in the hyperkube container. \"ssh\" used to be available and now it is not. For the gitrepo feature to work it should be available.\nAh okay. If it was there before, we might want to add it back. SGTM.\nYeah, I switched the hyperkube image base from to our with some additional dependencies back. Apparently due to lack of volume + hyperkube test coverage, I've missed a number of dependencies needed. cc\nwe could use dropbear as a replacement for just the ssh client?\nI would prefer to use the openssh client over the dropbear client. It has wider usage and a stronger security track record IMO. The dropbear client also has somewhat different usage and configuration, so arguably using it is still a regression over the previous state. Saving a couple MB isn't worth using worse utilities, however much fun \"dockerfile-golfing\" is.\nto fix\ncherrypick to release-1.8:\nThis should be fixed in v1.8.3.", "positive_passages": [{"docid": "doc-en-kubernetes-09b8c32084a23050b6fe994daba65b193098c7df396e022a20f70a59219c6411", "text": "REGISTRY?=gcr.io/google-containers IMAGE?=debian-hyperkube-base <del> TAG=0.5 </del> <ins> TAG=0.6 </ins> ARCH?=amd64 CACHEBUST?=1", "commid": "kubernetes_pr_54250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-73a311e0fb78fe06f854f9b67bb3be0d69fae466b5afe5af981f39439c3cf6d4", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Pods with volumeMount gitRepo volumes in 1.8.0 see the following error in kubelet logs (also in ) It is important to not that the git repo clone is done via ssh. I think what is happening is that hyperkube image now used to have command in it and now it does not have it. So the git clone command that kubelet runs fails with the above stacktrace since it cannot find . What you expected to happen: gitRepo is volume mounted. How to reproduce it (as minimally and precisely as possible): Reproducible in kubernetes 1.8.0+ hyperkube images. Anything else we need to know?: This probably is due to missing ssh binary in the new 1.8.0 hyperkube images. The commit might be an issue. Will comment further if I find otherwise. Environment: Kubernetes version (use ): =1.8.0 Cloud provider or hardware configuration**: Not Application. OS (e.g. from /etc/os-release): hyperkube base image Kernel (e.g. ): Install tools: Others:\nHow did you installed Kubernetes may I ask?\nhow does this help?\nNormally, it is suggest to install kubelet as a daemon on host instead of using hyperkube container. cc you may be interested in this issue.\nNeed your help in identifying the fix here. I can send something for review. Suggestions are welcome.\nThe problem is that ssh isn't installed inside of the container. I don't know if it should be either, as the hyperkube image grows so large. If you install the openssh-client, it should work\nYes I did identify that as the problem if you see the description I mentioned. I pointed to a git commit that might have caused this. I am not sure what package installation has changed in the hyperkube container. \"ssh\" used to be available and now it is not. For the gitrepo feature to work it should be available.\nAh okay. If it was there before, we might want to add it back. SGTM.\nYeah, I switched the hyperkube image base from to our with some additional dependencies back. Apparently due to lack of volume + hyperkube test coverage, I've missed a number of dependencies needed. cc\nwe could use dropbear as a replacement for just the ssh client?\nI would prefer to use the openssh client over the dropbear client. It has wider usage and a stronger security track record IMO. The dropbear client also has somewhat different usage and configuration, so arguably using it is still a regression over the previous state. Saving a couple MB isn't worth using worse utilities, however much fun \"dockerfile-golfing\" is.\nto fix\ncherrypick to release-1.8:\nThis should be fixed in v1.8.3.", "positive_passages": [{"docid": "doc-en-kubernetes-5d574613f7b06edd538737cf928a8da24c5eb576603a49d7434b9dae456d940b", "text": "docker_pull( name = \"debian-hyperkube-base-amd64\", <del> digest = \"sha256:d216b425004fcb6d8047f74e81b30e7ead55f73e73511ca53a329c358786b6c9\", </del> <ins> digest = \"sha256:10546d592e58d5fdb2e25d79f291b8ac62c8d3a3d83337ad7309cca766dbebce\", </ins> registry = \"gcr.io\", repository = \"google-containers/debian-hyperkube-base-amd64\", <del> tag = \"0.5\",  # ignored, but kept here for documentation </del> <ins> tag = \"0.6\",  # ignored, but kept here for documentation </ins> ) docker_pull(", "commid": "kubernetes_pr_54250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-73a311e0fb78fe06f854f9b67bb3be0d69fae466b5afe5af981f39439c3cf6d4", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Pods with volumeMount gitRepo volumes in 1.8.0 see the following error in kubelet logs (also in ) It is important to not that the git repo clone is done via ssh. I think what is happening is that hyperkube image now used to have command in it and now it does not have it. So the git clone command that kubelet runs fails with the above stacktrace since it cannot find . What you expected to happen: gitRepo is volume mounted. How to reproduce it (as minimally and precisely as possible): Reproducible in kubernetes 1.8.0+ hyperkube images. Anything else we need to know?: This probably is due to missing ssh binary in the new 1.8.0 hyperkube images. The commit might be an issue. Will comment further if I find otherwise. Environment: Kubernetes version (use ): =1.8.0 Cloud provider or hardware configuration**: Not Application. OS (e.g. from /etc/os-release): hyperkube base image Kernel (e.g. ): Install tools: Others:\nHow did you installed Kubernetes may I ask?\nhow does this help?\nNormally, it is suggest to install kubelet as a daemon on host instead of using hyperkube container. cc you may be interested in this issue.\nNeed your help in identifying the fix here. I can send something for review. Suggestions are welcome.\nThe problem is that ssh isn't installed inside of the container. I don't know if it should be either, as the hyperkube image grows so large. If you install the openssh-client, it should work\nYes I did identify that as the problem if you see the description I mentioned. I pointed to a git commit that might have caused this. I am not sure what package installation has changed in the hyperkube container. \"ssh\" used to be available and now it is not. For the gitrepo feature to work it should be available.\nAh okay. If it was there before, we might want to add it back. SGTM.\nYeah, I switched the hyperkube image base from to our with some additional dependencies back. Apparently due to lack of volume + hyperkube test coverage, I've missed a number of dependencies needed. cc\nwe could use dropbear as a replacement for just the ssh client?\nI would prefer to use the openssh client over the dropbear client. It has wider usage and a stronger security track record IMO. The dropbear client also has somewhat different usage and configuration, so arguably using it is still a regression over the previous state. Saving a couple MB isn't worth using worse utilities, however much fun \"dockerfile-golfing\" is.\nto fix\ncherrypick to release-1.8:\nThis should be fixed in v1.8.3.", "positive_passages": [{"docid": "doc-en-kubernetes-913e01543bce7403108d4ba05afe6cbf509d89e951861a78cca54c32db274f05", "text": "ARCH?=amd64 HYPERKUBE_BIN?=_output/dockerized/bin/linux/$(ARCH)/hyperkube <del> BASEIMAGE=gcr.io/google-containers/debian-hyperkube-base-$(ARCH):0.5 </del> <ins> BASEIMAGE=gcr.io/google-containers/debian-hyperkube-base-$(ARCH):0.6 </ins> TEMP_DIR:=$(shell mktemp -d -t hyperkubeXXXXXX) all: build", "commid": "kubernetes_pr_54250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b42bb21fa6ea11da2e50c80e3ebc579d3657ae0bbb3b36ccf0c72a7b30fe8c11", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: I'm running a Redis pod with a PV provisioned as an Azure Managed Disk. It's got an exec readiness probe that calls in the container. At some point it receives a SIGTERM. The kubelet then tries to sync the pod and restart the container, but it panics in (looking over the code, that's the only place where the error from is ignored) As a result, the pod hangs in a state, since the readiness probe cannot be ran in a non existing container. What you expected to happen: The container would successfully restart. How to reproduce it (as minimally and precisely as possible): It's the 2nd time it happens but I haven't yet figured out the conditions to reproduce. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration**: Azure w/ Managed Disks OS (e.g. from /etc/os-release):Kernel (e.g. ):Install tools:Others:\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHi could you also share the storageclass, pvc & pod yaml files? I would like to repro, thx\nI may insert a nil check statment in this func: But I need to reproduce this bug anyway, so that I could find the root cause of this issue, thx.\nYes, an error check is what I'm hoping for :) I've used the chart. The PV/PVC were created manually, they're set to an empty storage class. I should mention that I've also noticed other pods being terminated/recreated at the time this one failed, however I didn't trace the cause of this yet.\nthanks for the reporting, I may have found the root cause, just need a few more debuging time, thx.\nGitHub didn't allow me to assign the following users: xiazhang. Note that only can be assigned. <detailsIn response to : /assign xiazhang Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign andyzhangx\n- Thanks for the fix!", "positive_passages": [{"docid": "doc-en-kubernetes-4de2367d6c65b3e06a6fe128ae52c399590d1dabc06ddc20ae10bc229b92d6f8", "text": "var _ volume.Mounter = &azureDiskMounter{} func (m *azureDiskMounter) GetAttributes() volume.Attributes { <del> volumeSource, _ := getVolumeSource(m.spec) </del> <ins> readOnly := false volumeSource, err := getVolumeSource(m.spec) if err != nil && volumeSource.ReadOnly != nil { readOnly = *volumeSource.ReadOnly } </ins> return volume.Attributes{ <del> ReadOnly:        *volumeSource.ReadOnly, Managed:         !*volumeSource.ReadOnly, </del> <ins> ReadOnly:        readOnly, Managed:         !readOnly, </ins> SupportsSELinux: true, } }", "commid": "kubernetes_pr_54607"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b42bb21fa6ea11da2e50c80e3ebc579d3657ae0bbb3b36ccf0c72a7b30fe8c11", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: I'm running a Redis pod with a PV provisioned as an Azure Managed Disk. It's got an exec readiness probe that calls in the container. At some point it receives a SIGTERM. The kubelet then tries to sync the pod and restart the container, but it panics in (looking over the code, that's the only place where the error from is ignored) As a result, the pod hangs in a state, since the readiness probe cannot be ran in a non existing container. What you expected to happen: The container would successfully restart. How to reproduce it (as minimally and precisely as possible): It's the 2nd time it happens but I haven't yet figured out the conditions to reproduce. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration**: Azure w/ Managed Disks OS (e.g. from /etc/os-release):Kernel (e.g. ):Install tools:Others:\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHi could you also share the storageclass, pvc & pod yaml files? I would like to repro, thx\nI may insert a nil check statment in this func: But I need to reproduce this bug anyway, so that I could find the root cause of this issue, thx.\nYes, an error check is what I'm hoping for :) I've used the chart. The PV/PVC were created manually, they're set to an empty storage class. I should mention that I've also noticed other pods being terminated/recreated at the time this one failed, however I didn't trace the cause of this yet.\nthanks for the reporting, I may have found the root cause, just need a few more debuging time, thx.\nGitHub didn't allow me to assign the following users: xiazhang. Note that only can be assigned. <detailsIn response to : /assign xiazhang Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign andyzhangx\n- Thanks for the fix!", "positive_passages": [{"docid": "doc-en-kubernetes-7b0a3428ffc4ef2466ba31fe67dfb8fb342a52b585493cbee6dc39d36af122ad", "text": "options := []string{\"bind\"} <del> if *volumeSource.ReadOnly { </del> <ins> if volumeSource.ReadOnly != nil && *volumeSource.ReadOnly { </ins> options = append(options, \"ro\") }", "commid": "kubernetes_pr_54607"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b42bb21fa6ea11da2e50c80e3ebc579d3657ae0bbb3b36ccf0c72a7b30fe8c11", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: I'm running a Redis pod with a PV provisioned as an Azure Managed Disk. It's got an exec readiness probe that calls in the container. At some point it receives a SIGTERM. The kubelet then tries to sync the pod and restart the container, but it panics in (looking over the code, that's the only place where the error from is ignored) As a result, the pod hangs in a state, since the readiness probe cannot be ran in a non existing container. What you expected to happen: The container would successfully restart. How to reproduce it (as minimally and precisely as possible): It's the 2nd time it happens but I haven't yet figured out the conditions to reproduce. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration**: Azure w/ Managed Disks OS (e.g. from /etc/os-release):Kernel (e.g. ):Install tools:Others:\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHi could you also share the storageclass, pvc & pod yaml files? I would like to repro, thx\nI may insert a nil check statment in this func: But I need to reproduce this bug anyway, so that I could find the root cause of this issue, thx.\nYes, an error check is what I'm hoping for :) I've used the chart. The PV/PVC were created manually, they're set to an empty storage class. I should mention that I've also noticed other pods being terminated/recreated at the time this one failed, however I didn't trace the cause of this yet.\nthanks for the reporting, I may have found the root cause, just need a few more debuging time, thx.\nGitHub didn't allow me to assign the following users: xiazhang. Note that only can be assigned. <detailsIn response to : /assign xiazhang Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign andyzhangx\n- Thanks for the fix!", "positive_passages": [{"docid": "doc-en-kubernetes-8ee820d48e4a1aa63eaa618ba2c7b2aff2b0af599bd6c86c696b53cf5d35f2ad", "text": "return mountErr } <del> if !*volumeSource.ReadOnly { </del> <ins> if volumeSource.ReadOnly == nil || !*volumeSource.ReadOnly { </ins> volume.SetVolumeOwnership(m, fsGroup) }", "commid": "kubernetes_pr_54607"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0d5fbe44a2b03c6b67116f7bffb16750ef5c7051d39d0ca104216a0475b3df8d", "query": "Our 5k-node cluster jobs recently started failing even before the e2e tests start. The reason is the step which checks that all kube-system pods are running is timing out: cc\nFrom the scheduler logs I'm seeing that the pods are being scheduled quite slowly, getting worse with time: 2-3 pods/min looks quite bad. cc\nAlso finding such traces: Seems like most of the time is being spent in priority calculation.\nFrom the pod spec, I'm seeing soft inter-pod anti-affinity at node-level topology: I'm almost sure this is the one causing the mischief. We've been having performance issues with anti-affinity traditionally :p\nOk... PR is the cause. It introduced anti-affinity to kube-dns. I think we should revert this change given known issues with anti-affinity. - Opinions?\nFYI - it is taking 80m until the last pod is scheduled when I'm running 5k-node cluster locally.\nThat's quite unfortunate. It looks like we should revert the change until the anti-affinity change is scalable enough to be used more broadly, unless the scheduler folks have a target fix for this use case.\ncc\nWe are very well aware of the performance issues in our affinity/anti-affinity functions, but I am not aware of a concrete solution at this point. This is partly due to the flexible design of affinity/anti-affinity concept. My humble opinion at this point is to drop some of the flexibility as they are rarely used, in order to streamline the algorithm and improve performance. Anyway, I think the proper solution to this problem needs more time than your requirements to address the issue in hand. So, you may want to change your configuration and drop the anti-affinity rule.\nwould it make sense to add a note to the anti-affinity user documentation to hint at performance problems at large scale, until this is fixed?\nRe-opening this issue as this problem has struck again. The following runs of our 5k-node scalability jobs failed to bring up the cluster on time: https://k8s- https://k8s- https://k8s- https://k8s- And the reason is kube-dns pods pending to be scheduled for a long time:\nThese failures started happening about 4 days ago and I'm pretty sure it's this one: Add self anti-affinity to kube-dns pods Sadly, we'll have to revert it again for now :( cc - Seems like the improvements to anti-affinity performance made under weren't enough?\nWe need to find other improvements for the predicate. If we cannot find major improvement opportunities, we may have to change its design to be more scalable at the cost of the reducing its flexibility.\n- my personal opinion is that we need to change the design anyway. Having it work both ways (i.e. existing pods everywhere impacting placing of our pod) will always be painful (especially for things like cluster autoscaler)\nI agree. The symetrical application of anti-affinity is problematic. I also think we need to change it.\nGreat. - do you agree with that too?\n, I'm wondering after some affinity/anti-affinity optimization in scheduler, do you think if it's fine to test coreDNS with anti-affinity policy in large cluster with 5000 nodes?\nWe probably should try to see where we are - but this requires testing before enabling that.\nI agree with - Could we first try checking with a benchmark integration test () as a proxy for real cluster test?\nI'm wondering how many real nodes are required for testing?\nSince the integration tests fake out the nodes, I think it's safe to crank it up to 5000 (that's the current largest integration test benchmark size) I'm also hoping to refactor our benchmarks soon, so let me know if you have any thoughts about them.", "positive_passages": [{"docid": "doc-en-kubernetes-b27bc9bb4470d84252cbd63b1b8133f462885f9732d3b581e6ee6438f5d428c1", "text": "annotations: scheduler.alpha.kubernetes.io/critical-pod: '' spec: <del> affinity: podAntiAffinity: preferredDuringSchedulingIgnoredDuringExecution: - weight: 100 podAffinityTerm: labelSelector: matchExpressions: - key: k8s-app operator: In values: [\"kube-dns\"] topologyKey: kubernetes.io/hostname </del> tolerations: - key: \"CriticalAddonsOnly\" operator: \"Exists\"", "commid": "kubernetes_pr_54166"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0d5fbe44a2b03c6b67116f7bffb16750ef5c7051d39d0ca104216a0475b3df8d", "query": "Our 5k-node cluster jobs recently started failing even before the e2e tests start. The reason is the step which checks that all kube-system pods are running is timing out: cc\nFrom the scheduler logs I'm seeing that the pods are being scheduled quite slowly, getting worse with time: 2-3 pods/min looks quite bad. cc\nAlso finding such traces: Seems like most of the time is being spent in priority calculation.\nFrom the pod spec, I'm seeing soft inter-pod anti-affinity at node-level topology: I'm almost sure this is the one causing the mischief. We've been having performance issues with anti-affinity traditionally :p\nOk... PR is the cause. It introduced anti-affinity to kube-dns. I think we should revert this change given known issues with anti-affinity. - Opinions?\nFYI - it is taking 80m until the last pod is scheduled when I'm running 5k-node cluster locally.\nThat's quite unfortunate. It looks like we should revert the change until the anti-affinity change is scalable enough to be used more broadly, unless the scheduler folks have a target fix for this use case.\ncc\nWe are very well aware of the performance issues in our affinity/anti-affinity functions, but I am not aware of a concrete solution at this point. This is partly due to the flexible design of affinity/anti-affinity concept. My humble opinion at this point is to drop some of the flexibility as they are rarely used, in order to streamline the algorithm and improve performance. Anyway, I think the proper solution to this problem needs more time than your requirements to address the issue in hand. So, you may want to change your configuration and drop the anti-affinity rule.\nwould it make sense to add a note to the anti-affinity user documentation to hint at performance problems at large scale, until this is fixed?\nRe-opening this issue as this problem has struck again. The following runs of our 5k-node scalability jobs failed to bring up the cluster on time: https://k8s- https://k8s- https://k8s- https://k8s- And the reason is kube-dns pods pending to be scheduled for a long time:\nThese failures started happening about 4 days ago and I'm pretty sure it's this one: Add self anti-affinity to kube-dns pods Sadly, we'll have to revert it again for now :( cc - Seems like the improvements to anti-affinity performance made under weren't enough?\nWe need to find other improvements for the predicate. If we cannot find major improvement opportunities, we may have to change its design to be more scalable at the cost of the reducing its flexibility.\n- my personal opinion is that we need to change the design anyway. Having it work both ways (i.e. existing pods everywhere impacting placing of our pod) will always be painful (especially for things like cluster autoscaler)\nI agree. The symetrical application of anti-affinity is problematic. I also think we need to change it.\nGreat. - do you agree with that too?\n, I'm wondering after some affinity/anti-affinity optimization in scheduler, do you think if it's fine to test coreDNS with anti-affinity policy in large cluster with 5000 nodes?\nWe probably should try to see where we are - but this requires testing before enabling that.\nI agree with - Could we first try checking with a benchmark integration test () as a proxy for real cluster test?\nI'm wondering how many real nodes are required for testing?\nSince the integration tests fake out the nodes, I think it's safe to crank it up to 5000 (that's the current largest integration test benchmark size) I'm also hoping to refactor our benchmarks soon, so let me know if you have any thoughts about them.", "positive_passages": [{"docid": "doc-en-kubernetes-b27bc9bb4470d84252cbd63b1b8133f462885f9732d3b581e6ee6438f5d428c1", "text": "annotations: scheduler.alpha.kubernetes.io/critical-pod: '' spec: <del> affinity: podAntiAffinity: preferredDuringSchedulingIgnoredDuringExecution: - weight: 100 podAffinityTerm: labelSelector: matchExpressions: - key: k8s-app operator: In values: [\"kube-dns\"] topologyKey: kubernetes.io/hostname </del> tolerations: - key: \"CriticalAddonsOnly\" operator: \"Exists\"", "commid": "kubernetes_pr_59357"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-410ef366e2b72f2d21696681942578239c8f98dffebaca626b2dfe032753546e", "query": "BUG REPORT: /kind bug /sig aws What happened: Adding this annotation to an existing service: did not trigger an update on AWS ELB (no new tags). What you expected to happen: Expected to see those 2 new tags under the existing ELB: How to reproduce it (as minimally and precisely as possible): a service without annotation the annotation tags on AWS Anything else we need to know?: Creating a new service WITH the annotation will create the expected tags on AWS. Environment: Kubernetes version (use ): 1.7.9 Cloud provider or hardware configuration**: AWS OS (e.g. from /etc/os-release): Debian GNU/Linux 8 (jessie) Kernel (e.g. ): Linux ip-xxxxx 4.4.78-k8s SMP Fri Jul 28 01:28:39 UTC 2017 x86_64 GNU/Linux Install tools: Others: Using Kops\n+1\n+1\n+1\n+1\n+1\nI've done some work on a fix for this, will try and get a PR submitted later today.", "positive_passages": [{"docid": "doc-en-kubernetes-17a4ba8b747bfbbe90fce83ed979c1f6b5a2f91e095ca264fe6e42e7dfef59ce", "text": "CreateLoadBalancer(*elb.CreateLoadBalancerInput) (*elb.CreateLoadBalancerOutput, error) DeleteLoadBalancer(*elb.DeleteLoadBalancerInput) (*elb.DeleteLoadBalancerOutput, error) DescribeLoadBalancers(*elb.DescribeLoadBalancersInput) (*elb.DescribeLoadBalancersOutput, error) <ins> AddTags(*elb.AddTagsInput) (*elb.AddTagsOutput, error) </ins> RegisterInstancesWithLoadBalancer(*elb.RegisterInstancesWithLoadBalancerInput) (*elb.RegisterInstancesWithLoadBalancerOutput, error) DeregisterInstancesFromLoadBalancer(*elb.DeregisterInstancesFromLoadBalancerInput) (*elb.DeregisterInstancesFromLoadBalancerOutput, error) CreateLoadBalancerPolicy(*elb.CreateLoadBalancerPolicyInput) (*elb.CreateLoadBalancerPolicyOutput, error)", "commid": "kubernetes_pr_55731"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-410ef366e2b72f2d21696681942578239c8f98dffebaca626b2dfe032753546e", "query": "BUG REPORT: /kind bug /sig aws What happened: Adding this annotation to an existing service: did not trigger an update on AWS ELB (no new tags). What you expected to happen: Expected to see those 2 new tags under the existing ELB: How to reproduce it (as minimally and precisely as possible): a service without annotation the annotation tags on AWS Anything else we need to know?: Creating a new service WITH the annotation will create the expected tags on AWS. Environment: Kubernetes version (use ): 1.7.9 Cloud provider or hardware configuration**: AWS OS (e.g. from /etc/os-release): Debian GNU/Linux 8 (jessie) Kernel (e.g. ): Linux ip-xxxxx 4.4.78-k8s SMP Fri Jul 28 01:28:39 UTC 2017 x86_64 GNU/Linux Install tools: Others: Using Kops\n+1\n+1\n+1\n+1\n+1\nI've done some work on a fix for this, will try and get a PR submitted later today.", "positive_passages": [{"docid": "doc-en-kubernetes-6508560b46659764bc43854af999e2b91b33d2879238abfbd3a1971bb15cf121", "text": "return ret, nil } <ins> func (c *Cloud) addLoadBalancerTags(loadBalancerName string, requested map[string]string) error { var tags []*elb.Tag for k, v := range requested { tag := &elb.Tag{ Key:   aws.String(k), Value: aws.String(v), } tags = append(tags, tag) } request := &elb.AddTagsInput{} request.LoadBalancerNames = []*string{&loadBalancerName} request.Tags = tags _, err := c.elb.AddTags(request) if err != nil { return fmt.Errorf(\"error adding tags to load balancer: %v\", err) } return nil } </ins> // Retrieves instance's vpc id from metadata func (c *Cloud) findVPCID() (string, error) { macs, err := c.metadata.GetMetadata(\"network/interfaces/macs/\")", "commid": "kubernetes_pr_55731"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-410ef366e2b72f2d21696681942578239c8f98dffebaca626b2dfe032753546e", "query": "BUG REPORT: /kind bug /sig aws What happened: Adding this annotation to an existing service: did not trigger an update on AWS ELB (no new tags). What you expected to happen: Expected to see those 2 new tags under the existing ELB: How to reproduce it (as minimally and precisely as possible): a service without annotation the annotation tags on AWS Anything else we need to know?: Creating a new service WITH the annotation will create the expected tags on AWS. Environment: Kubernetes version (use ): 1.7.9 Cloud provider or hardware configuration**: AWS OS (e.g. from /etc/os-release): Debian GNU/Linux 8 (jessie) Kernel (e.g. ): Linux ip-xxxxx 4.4.78-k8s SMP Fri Jul 28 01:28:39 UTC 2017 x86_64 GNU/Linux Install tools: Others: Using Kops\n+1\n+1\n+1\n+1\n+1\nI've done some work on a fix for this, will try and get a PR submitted later today.", "positive_passages": [{"docid": "doc-en-kubernetes-3b3baafeb630d41d9656b0c60db0ef0a76269859ba08f72f3e7679e89847564a", "text": "panic(\"Not implemented\") } <ins> func (elb *FakeELB) AddTags(input *elb.AddTagsInput) (*elb.AddTagsOutput, error) { panic(\"Not implemented\") } </ins> func (elb *FakeELB) RegisterInstancesWithLoadBalancer(*elb.RegisterInstancesWithLoadBalancerInput) (*elb.RegisterInstancesWithLoadBalancerOutput, error) { panic(\"Not implemented\") }", "commid": "kubernetes_pr_55731"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-410ef366e2b72f2d21696681942578239c8f98dffebaca626b2dfe032753546e", "query": "BUG REPORT: /kind bug /sig aws What happened: Adding this annotation to an existing service: did not trigger an update on AWS ELB (no new tags). What you expected to happen: Expected to see those 2 new tags under the existing ELB: How to reproduce it (as minimally and precisely as possible): a service without annotation the annotation tags on AWS Anything else we need to know?: Creating a new service WITH the annotation will create the expected tags on AWS. Environment: Kubernetes version (use ): 1.7.9 Cloud provider or hardware configuration**: AWS OS (e.g. from /etc/os-release): Debian GNU/Linux 8 (jessie) Kernel (e.g. ): Linux ip-xxxxx 4.4.78-k8s SMP Fri Jul 28 01:28:39 UTC 2017 x86_64 GNU/Linux Install tools: Others: Using Kops\n+1\n+1\n+1\n+1\n+1\nI've done some work on a fix for this, will try and get a PR submitted later today.", "positive_passages": [{"docid": "doc-en-kubernetes-e48a1a826a87fb3705c41edb502cd79a1ba3abe07174afddd8062e482da08e64", "text": "} } } <ins> { // Add additional tags glog.V(2).Infof(\"Creating additional load balancer tags for %s\", loadBalancerName) tags := getLoadBalancerAdditionalTags(annotations) if len(tags) > 0 { err := c.addLoadBalancerTags(loadBalancerName, tags) if err != nil { return nil, fmt.Errorf(\"unable to create additional load balancer tags: %v\", err) } } } </ins> } // Whether the ELB was new or existing, sync attributes regardless. This accounts for things", "commid": "kubernetes_pr_55731"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-410ef366e2b72f2d21696681942578239c8f98dffebaca626b2dfe032753546e", "query": "BUG REPORT: /kind bug /sig aws What happened: Adding this annotation to an existing service: did not trigger an update on AWS ELB (no new tags). What you expected to happen: Expected to see those 2 new tags under the existing ELB: How to reproduce it (as minimally and precisely as possible): a service without annotation the annotation tags on AWS Anything else we need to know?: Creating a new service WITH the annotation will create the expected tags on AWS. Environment: Kubernetes version (use ): 1.7.9 Cloud provider or hardware configuration**: AWS OS (e.g. from /etc/os-release): Debian GNU/Linux 8 (jessie) Kernel (e.g. ): Linux ip-xxxxx 4.4.78-k8s SMP Fri Jul 28 01:28:39 UTC 2017 x86_64 GNU/Linux Install tools: Others: Using Kops\n+1\n+1\n+1\n+1\n+1\nI've done some work on a fix for this, will try and get a PR submitted later today.", "positive_passages": [{"docid": "doc-en-kubernetes-4c7e06690a0a0849e382705b8690304780c0edebfe98ebfcdec5c0f0cedee04e", "text": "}) } <ins> func (m *MockedFakeELB) AddTags(input *elb.AddTagsInput) (*elb.AddTagsOutput, error) { args := m.Called(input) return args.Get(0).(*elb.AddTagsOutput), nil } </ins> func TestReadAWSCloudConfig(t *testing.T) { tests := []struct { name string", "commid": "kubernetes_pr_55731"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-410ef366e2b72f2d21696681942578239c8f98dffebaca626b2dfe032753546e", "query": "BUG REPORT: /kind bug /sig aws What happened: Adding this annotation to an existing service: did not trigger an update on AWS ELB (no new tags). What you expected to happen: Expected to see those 2 new tags under the existing ELB: How to reproduce it (as minimally and precisely as possible): a service without annotation the annotation tags on AWS Anything else we need to know?: Creating a new service WITH the annotation will create the expected tags on AWS. Environment: Kubernetes version (use ): 1.7.9 Cloud provider or hardware configuration**: AWS OS (e.g. from /etc/os-release): Debian GNU/Linux 8 (jessie) Kernel (e.g. ): Linux ip-xxxxx 4.4.78-k8s SMP Fri Jul 28 01:28:39 UTC 2017 x86_64 GNU/Linux Install tools: Others: Using Kops\n+1\n+1\n+1\n+1\n+1\nI've done some work on a fix for this, will try and get a PR submitted later today.", "positive_passages": [{"docid": "doc-en-kubernetes-6b67bc51a5a0a2a8a6ebc23e170b1b2db7760f66c7c6df251822447fa34205f4", "text": "} } <ins> // Test that we can add a load balancer tag func TestAddLoadBalancerTags(t *testing.T) { loadBalancerName := \"test-elb\" awsServices := newMockedFakeAWSServices(TestClusterId) c, _ := newAWSCloud(strings.NewReader(\"[global]\"), awsServices) want := make(map[string]string) want[\"tag1\"] = \"val1\" expectedAddTagsRequest := &elb.AddTagsInput{ LoadBalancerNames: []*string{&loadBalancerName}, Tags: []*elb.Tag{ { Key:   aws.String(\"tag1\"), Value: aws.String(\"val1\"), }, }, } awsServices.elb.(*MockedFakeELB).On(\"AddTags\", expectedAddTagsRequest).Return(&elb.AddTagsOutput{}) err := c.addLoadBalancerTags(loadBalancerName, want) assert.Nil(t, err, \"Error adding load balancer tags: %v\", err) awsServices.elb.(*MockedFakeELB).AssertExpectations(t) } </ins> func newMockedFakeAWSServices(id string) *FakeAWSServices { s := NewFakeAWSServices(id) s.ec2 = &MockedFakeEC2{FakeEC2Impl: s.ec2.(*FakeEC2Impl)}", "commid": "kubernetes_pr_55731"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cf260a4414bee12fed0df1f9bbd824860b6046cff0bea685f4f14bd09d4b29cd", "query": "On AWS, mutable API calls such as AttachVolume or DeleteVolume have separate API quota from API calls that do not modify the resource. Currently k8s makes a high number of AttachVolume and DeleteVolume API calls even though k8s can check if the operation is going to succeed.\n/sig aws", "positive_passages": [{"docid": "doc-en-kubernetes-e109a2fbfce288406a296774d7b3a4f5ecd070fb0d7e7d4a1acda38f2aaa252b", "text": "ec2Device := \"/dev/xvd\" + string(mountDevice) if !alreadyAttached { <ins> available, err := c.checkIfAvailable(disk, \"attaching\", awsInstance.awsID) if !available { attachEnded = true return \"\", err } </ins> request := &ec2.AttachVolumeInput{ Device:     aws.String(ec2Device), InstanceId: aws.String(awsInstance.awsID),", "commid": "kubernetes_pr_55008"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cf260a4414bee12fed0df1f9bbd824860b6046cff0bea685f4f14bd09d4b29cd", "query": "On AWS, mutable API calls such as AttachVolume or DeleteVolume have separate API quota from API calls that do not modify the resource. Currently k8s makes a high number of AttachVolume and DeleteVolume API calls even though k8s can check if the operation is going to succeed.\n/sig aws", "positive_passages": [{"docid": "doc-en-kubernetes-04be82110cbf88dd459082f0928194ed446e38de1924990dd3c12e017e2b7c5b", "text": "if err != nil { return false, err } <ins> available, err := c.checkIfAvailable(awsDisk, \"deleting\", \"\") if !available { return false, err } </ins> return awsDisk.deleteVolume() } <ins> func (c *Cloud) checkIfAvailable(disk *awsDisk, opName string, instance string) (bool, error) { info, err := disk.describeVolume() if err != nil { glog.Errorf(\"Error describing volume %q: %q\", disk.awsID, err) // if for some reason we can not describe volume we will return error return false, err } volumeState := aws.StringValue(info.State) opError := fmt.Sprintf(\"Error %s EBS volume %q\", opName, disk.awsID) if len(instance) != 0 { opError = fmt.Sprintf(\"%q to instance %q\", opError, instance) } // Only available volumes can be attached or deleted if volumeState != \"available\" { // Volume is attached somewhere else and we can not attach it here if len(info.Attachments) > 0 { attachment := info.Attachments[0] attachErr := fmt.Errorf(\"%s since volume is currently attached to %q\", opError, aws.StringValue(attachment.InstanceId)) glog.Error(attachErr) return false, attachErr } attachErr := fmt.Errorf(\"%s since volume is in %q state\", opError, volumeState) glog.Error(attachErr) return false, attachErr } return true, nil } </ins> func (c *Cloud) GetLabelsForVolume(pv *v1.PersistentVolume) (map[string]string, error) { // Ignore any volumes that are being provisioned if pv.Spec.AWSElasticBlockStore.VolumeID == volume.ProvisionedVolumeName {", "commid": "kubernetes_pr_55008"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c27b3b02c304571a16f876186f2122703d7dbcacd59c19977a1f2e30cde3b19", "query": "We should make the CRI log parsing code in kubelet to be a library. So that container runtimes and external tools don't need to copy the whole code ( vendor it instead ). Referring\n/assign\n/sig node\nI can help on it.\n/assign\nGitHub didn't allow me to assign the following users: yanxuean. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThanks. I have a branch ready for this. Will open a PR later and ping you when it is out.\nok", "positive_passages": [{"docid": "doc-en-kubernetes-8651d4b721c6bafa4306e2b3718dfa90c347fad4bec4755e7efb22e42698133e", "text": "\"//pkg/kubelet/container:go_default_library\", \"//pkg/kubelet/events:go_default_library\", \"//pkg/kubelet/images:go_default_library\", <ins> \"//pkg/kubelet/kuberuntime/logs:go_default_library\", </ins> \"//pkg/kubelet/lifecycle:go_default_library\", \"//pkg/kubelet/metrics:go_default_library\", \"//pkg/kubelet/prober/results:go_default_library\",", "commid": "kubernetes_pr_55140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c27b3b02c304571a16f876186f2122703d7dbcacd59c19977a1f2e30cde3b19", "query": "We should make the CRI log parsing code in kubelet to be a library. So that container runtimes and external tools don't need to copy the whole code ( vendor it instead ). Referring\n/assign\n/sig node\nI can help on it.\n/assign\nGitHub didn't allow me to assign the following users: yanxuean. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThanks. I have a branch ready for this. Will open a PR later and ping you when it is out.\nok", "positive_passages": [{"docid": "doc-en-kubernetes-cf711d69c90b9e2152d313d48274011a019522ee3fb8444e12fda381497fa316", "text": "\"//pkg/util/tail:go_default_library\", \"//pkg/util/version:go_default_library\", \"//vendor/github.com/armon/circbuf:go_default_library\", <del> \"//vendor/github.com/docker/docker/pkg/jsonlog:go_default_library\", \"//vendor/github.com/fsnotify/fsnotify:go_default_library\", </del> \"//vendor/github.com/golang/glog:go_default_library\", \"//vendor/github.com/google/cadvisor/info/v1:go_default_library\", \"//vendor/google.golang.org/grpc:go_default_library\",", "commid": "kubernetes_pr_55140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c27b3b02c304571a16f876186f2122703d7dbcacd59c19977a1f2e30cde3b19", "query": "We should make the CRI log parsing code in kubelet to be a library. So that container runtimes and external tools don't need to copy the whole code ( vendor it instead ). Referring\n/assign\n/sig node\nI can help on it.\n/assign\nGitHub didn't allow me to assign the following users: yanxuean. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThanks. I have a branch ready for this. Will open a PR later and ping you when it is out.\nok", "positive_passages": [{"docid": "doc-en-kubernetes-ac5f3e5e69be3a1788922d687979c10af22297611c02563cfd2145ea83a79760", "text": "\"kuberuntime_container_test.go\", \"kuberuntime_gc_test.go\", \"kuberuntime_image_test.go\", <del> \"kuberuntime_logs_test.go\", </del> \"kuberuntime_manager_test.go\", \"kuberuntime_sandbox_test.go\", \"labels_test.go\",", "commid": "kubernetes_pr_55140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c27b3b02c304571a16f876186f2122703d7dbcacd59c19977a1f2e30cde3b19", "query": "We should make the CRI log parsing code in kubelet to be a library. So that container runtimes and external tools don't need to copy the whole code ( vendor it instead ). Referring\n/assign\n/sig node\nI can help on it.\n/assign\nGitHub didn't allow me to assign the following users: yanxuean. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThanks. I have a branch ready for this. Will open a PR later and ping you when it is out.\nok", "positive_passages": [{"docid": "doc-en-kubernetes-caf43fc0ef890d26f9f8f5dfaadcbf8ed1a45f0d32ef3913adc4f3a860fafd65", "text": "filegroup( name = \"all-srcs\", <del> srcs = [\":package-srcs\"], </del> <ins> srcs = [ \":package-srcs\", \"//pkg/kubelet/kuberuntime/logs:all-srcs\", ], </ins> tags = [\"automanaged\"], )", "commid": "kubernetes_pr_55140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c27b3b02c304571a16f876186f2122703d7dbcacd59c19977a1f2e30cde3b19", "query": "We should make the CRI log parsing code in kubelet to be a library. So that container runtimes and external tools don't need to copy the whole code ( vendor it instead ). Referring\n/assign\n/sig node\nI can help on it.\n/assign\nGitHub didn't allow me to assign the following users: yanxuean. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThanks. I have a branch ready for this. Will open a PR later and ping you when it is out.\nok", "positive_passages": [{"docid": "doc-en-kubernetes-890ca39b270da9db92004019ce8e1dd82ff716e684aea7217dcc5bfc4c5d8be3", "text": "package kuberuntime import ( <del> \"bufio\" \"bytes\" \"encoding/json\" \"errors\" \"fmt\" </del> \"io\" <del> \"math\" \"os\" </del> \"time\" <del> \"github.com/docker/docker/pkg/jsonlog\" \"github.com/fsnotify/fsnotify\" \"github.com/golang/glog\" </del> \"k8s.io/api/core/v1\" <del> runtimeapi \"k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime\" \"k8s.io/kubernetes/pkg/util/tail\" </del> <ins> \"k8s.io/kubernetes/pkg/kubelet/kuberuntime/logs\" </ins> ) <del> // Notice that the current kuberuntime logs implementation doesn't handle // log rotation. // * It will not retrieve logs in rotated log file. // * If log rotation happens when following the log: //   * If the rotation is using create mode, we'll still follow the old file. //   * If the rotation is using copytruncate, we'll be reading at the original position and get nothing. // TODO(random-liu): Support log rotation. // streamType is the type of the stream. type streamType string const ( stderrType streamType = \"stderr\" stdoutType streamType = \"stdout\" // timeFormat is the time format used in the log. timeFormat = time.RFC3339Nano // blockSize is the block size used in tail. blockSize = 1024 // stateCheckPeriod is the period to check container state while following // the container log. Kubelet should not keep following the log when the // container is not running. stateCheckPeriod = 5 * time.Second ) var ( // eol is the end-of-line sign in the log. eol = []byte{'n'} // delimiter is the delimiter for timestamp and streamtype in log line. delimiter = []byte{' '} ) // logMessage is the internal log type. type logMessage struct { timestamp time.Time stream    streamType log       []byte } // reset resets the log to nil. func (l *logMessage) reset() { l.timestamp = time.Time{} l.stream = \"\" l.log = nil } // logOptions is the internal type of all log options. type logOptions struct { tail      int64 bytes     int64 since     time.Time follow    bool timestamp bool } // newLogOptions convert the v1.PodLogOptions to internal logOptions. func newLogOptions(apiOpts *v1.PodLogOptions, now time.Time) *logOptions { opts := &logOptions{ tail:      -1, // -1 by default which means read all logs. bytes:     -1, // -1 by default which means read all logs. follow:    apiOpts.Follow, timestamp: apiOpts.Timestamps, } if apiOpts.TailLines != nil { opts.tail = *apiOpts.TailLines } if apiOpts.LimitBytes != nil { opts.bytes = *apiOpts.LimitBytes } if apiOpts.SinceSeconds != nil { opts.since = now.Add(-time.Duration(*apiOpts.SinceSeconds) * time.Second) } if apiOpts.SinceTime != nil && apiOpts.SinceTime.After(opts.since) { opts.since = apiOpts.SinceTime.Time } return opts } </del> // ReadLogs read the container log and redirect into stdout and stderr. // Note that containerID is only needed when following the log, or else // just pass in empty string \"\". func (m *kubeGenericRuntimeManager) ReadLogs(path, containerID string, apiOpts *v1.PodLogOptions, stdout, stderr io.Writer) error { <del> f, err := os.Open(path) if err != nil { return fmt.Errorf(\"failed to open log file %q: %v\", path, err) } defer f.Close() </del> // Convert v1.PodLogOptions into internal log options. <del> opts := newLogOptions(apiOpts, time.Now()) // Search start point based on tail line. start, err := tail.FindTailLineStartIndex(f, opts.tail) if err != nil { return fmt.Errorf(\"failed to tail %d lines of log file %q: %v\", opts.tail, path, err) } if _, err := f.Seek(start, os.SEEK_SET); err != nil { return fmt.Errorf(\"failed to seek %d in log file %q: %v\", start, path, err) } // Start parsing the logs. r := bufio.NewReader(f) // Do not create watcher here because it is not needed if `Follow` is false. var watcher *fsnotify.Watcher var parse parseFunc writer := newLogWriter(stdout, stderr, opts) msg := &logMessage{} for { l, err := r.ReadBytes(eol[0]) if err != nil { if err != io.EOF { // This is an real error return fmt.Errorf(\"failed to read log file %q: %v\", path, err) } if !opts.follow { // Return directly when reading to the end if not follow. if len(l) > 0 { glog.Warningf(\"Incomplete line in log file %q: %q\", path, l) } glog.V(2).Infof(\"Finish parsing log file %q\", path) return nil } // Reset seek so that if this is an incomplete line, // it will be read again. if _, err := f.Seek(-int64(len(l)), os.SEEK_CUR); err != nil { return fmt.Errorf(\"failed to reset seek in log file %q: %v\", path, err) } if watcher == nil { // Intialize the watcher if it has not been initialized yet. if watcher, err = fsnotify.NewWatcher(); err != nil { return fmt.Errorf(\"failed to create fsnotify watcher: %v\", err) } defer watcher.Close() if err := watcher.Add(f.Name()); err != nil { return fmt.Errorf(\"failed to watch file %q: %v\", f.Name(), err) } } // Wait until the next log change. if found, err := m.waitLogs(containerID, watcher); !found { return err } continue } if parse == nil { // Intialize the log parsing function. parse, err = getParseFunc(l) if err != nil { return fmt.Errorf(\"failed to get parse function: %v\", err) } } // Parse the log line. msg.reset() if err := parse(l, msg); err != nil { glog.Errorf(\"Failed with err %v when parsing log for log file %q: %q\", err, path, l) continue } // Write the log line into the stream. if err := writer.write(msg); err != nil { if err == errMaximumWrite { glog.V(2).Infof(\"Finish parsing log file %q, hit bytes limit %d(bytes)\", path, opts.bytes) return nil } glog.Errorf(\"Failed with err %v when writing log for log file %q: %+v\", err, path, msg) return err } } } // waitLogs wait for the next log write. It returns a boolean and an error. The boolean // indicates whether a new log is found; the error is error happens during waiting new logs. func (m *kubeGenericRuntimeManager) waitLogs(id string, w *fsnotify.Watcher) (bool, error) { errRetry := 5 for { select { case e := <-w.Events: switch e.Op { case fsnotify.Write: return true, nil default: glog.Errorf(\"Unexpected fsnotify event: %v, retrying...\", e) } case err := <-w.Errors: glog.Errorf(\"Fsnotify watch error: %v, %d error retries remaining\", err, errRetry) if errRetry == 0 { return false, err } errRetry-- case <-time.After(stateCheckPeriod): s, err := m.runtimeService.ContainerStatus(id) if err != nil { return false, err } // Only keep following container log when it is running. if s.State != runtimeapi.ContainerState_CONTAINER_RUNNING { glog.Errorf(\"Container %q is not running (state=%q)\", id, s.State) // Do not return error because it's normal that the container stops // during waiting. return false, nil } } } } // parseFunc is a function parsing one log line to the internal log type. // Notice that the caller must make sure logMessage is not nil. type parseFunc func([]byte, *logMessage) error var parseFuncs []parseFunc = []parseFunc{ parseCRILog,        // CRI log format parse function parseDockerJSONLog, // Docker JSON log format parse function } // parseCRILog parses logs in CRI log format. CRI Log format example: //   2016-10-06T00:17:09.669794202Z stdout log content 1 //   2016-10-06T00:17:09.669794203Z stderr log content 2 func parseCRILog(log []byte, msg *logMessage) error { var err error // Parse timestamp idx := bytes.Index(log, delimiter) if idx < 0 { return fmt.Errorf(\"timestamp is not found\") } msg.timestamp, err = time.Parse(timeFormat, string(log[:idx])) if err != nil { return fmt.Errorf(\"unexpected timestamp format %q: %v\", timeFormat, err) } // Parse stream type log = log[idx+1:] idx = bytes.Index(log, delimiter) if idx < 0 { return fmt.Errorf(\"stream type is not found\") } msg.stream = streamType(log[:idx]) if msg.stream != stdoutType && msg.stream != stderrType { return fmt.Errorf(\"unexpected stream type %q\", msg.stream) } // Get log content msg.log = log[idx+1:] return nil } // parseDockerJSONLog parses logs in Docker JSON log format. Docker JSON log format // example: //   {\"log\":\"content 1\",\"stream\":\"stdout\",\"time\":\"2016-10-20T18:39:20.57606443Z\"} //   {\"log\":\"content 2\",\"stream\":\"stderr\",\"time\":\"2016-10-20T18:39:20.57606444Z\"} func parseDockerJSONLog(log []byte, msg *logMessage) error { var l = &jsonlog.JSONLog{} l.Reset() // TODO: JSON decoding is fairly expensive, we should evaluate this. if err := json.Unmarshal(log, l); err != nil { return fmt.Errorf(\"failed with %v to unmarshal log %q\", err, l) } msg.timestamp = l.Created msg.stream = streamType(l.Stream) msg.log = []byte(l.Log) return nil } // getParseFunc returns proper parse function based on the sample log line passed in. func getParseFunc(log []byte) (parseFunc, error) { for _, p := range parseFuncs { if err := p(log, &logMessage{}); err == nil { return p, nil } } return nil, fmt.Errorf(\"unsupported log format: %q\", log) } // logWriter controls the writing into the stream based on the log options. type logWriter struct { stdout io.Writer stderr io.Writer opts   *logOptions remain int64 } // errMaximumWrite is returned when all bytes have been written. var errMaximumWrite = errors.New(\"maximum write\") // errShortWrite is returned when the message is not fully written. var errShortWrite = errors.New(\"short write\") func newLogWriter(stdout io.Writer, stderr io.Writer, opts *logOptions) *logWriter { w := &logWriter{ stdout: stdout, stderr: stderr, opts:   opts, remain: math.MaxInt64, // initialize it as infinity } if opts.bytes >= 0 { w.remain = opts.bytes } return w } </del> <ins> opts := logs.NewLogOptions(apiOpts, time.Now()) </ins> <del> // writeLogs writes logs into stdout, stderr. func (w *logWriter) write(msg *logMessage) error { if msg.timestamp.Before(w.opts.since) { // Skip the line because it's older than since return nil } line := msg.log if w.opts.timestamp { prefix := append([]byte(msg.timestamp.Format(timeFormat)), delimiter[0]) line = append(prefix, line...) } // If the line is longer than the remaining bytes, cut it. if int64(len(line)) > w.remain { line = line[:w.remain] } // Get the proper stream to write to. var stream io.Writer switch msg.stream { case stdoutType: stream = w.stdout case stderrType: stream = w.stderr default: return fmt.Errorf(\"unexpected stream type %q\", msg.stream) } n, err := stream.Write(line) w.remain -= int64(n) if err != nil { return err } // If the line has not been fully written, return errShortWrite if n < len(line) { return errShortWrite } // If there are no more bytes left, return errMaximumWrite if w.remain <= 0 { return errMaximumWrite } return nil </del> <ins> return logs.ReadLogs(path, containerID, opts, m.runtimeService, stdout, stderr) </ins> }", "commid": "kubernetes_pr_55140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c27b3b02c304571a16f876186f2122703d7dbcacd59c19977a1f2e30cde3b19", "query": "We should make the CRI log parsing code in kubelet to be a library. So that container runtimes and external tools don't need to copy the whole code ( vendor it instead ). Referring\n/assign\n/sig node\nI can help on it.\n/assign\nGitHub didn't allow me to assign the following users: yanxuean. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThanks. I have a branch ready for this. Will open a PR later and ping you when it is out.\nok", "positive_passages": [{"docid": "doc-en-kubernetes-ed93fbd6c9c69e8102eda01d0710f659118fe4ed61c6707f567c8bd7fbc324d6", "text": "<del> /* Copyright 2016 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package kuberuntime import ( \"bytes\" \"testing\" \"time\" \"github.com/stretchr/testify/assert\" \"k8s.io/api/core/v1\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" ) func TestLogOptions(t *testing.T) { var ( line         = int64(8) bytes        = int64(64) timestamp    = metav1.Now() sinceseconds = int64(10) ) for c, test := range []struct { apiOpts *v1.PodLogOptions expect  *logOptions }{ { // empty options apiOpts: &v1.PodLogOptions{}, expect:  &logOptions{tail: -1, bytes: -1}, }, { // test tail lines apiOpts: &v1.PodLogOptions{TailLines: &line}, expect:  &logOptions{tail: line, bytes: -1}, }, { // test limit bytes apiOpts: &v1.PodLogOptions{LimitBytes: &bytes}, expect:  &logOptions{tail: -1, bytes: bytes}, }, { // test since timestamp apiOpts: &v1.PodLogOptions{SinceTime: &timestamp}, expect:  &logOptions{tail: -1, bytes: -1, since: timestamp.Time}, }, { // test since seconds apiOpts: &v1.PodLogOptions{SinceSeconds: &sinceseconds}, expect:  &logOptions{tail: -1, bytes: -1, since: timestamp.Add(-10 * time.Second)}, }, } { t.Logf(\"TestCase #%d: %+v\", c, test) opts := newLogOptions(test.apiOpts, timestamp.Time) assert.Equal(t, test.expect, opts) } } func TestParseLog(t *testing.T) { timestamp, err := time.Parse(timeFormat, \"2016-10-20T18:39:20.57606443Z\") assert.NoError(t, err) msg := &logMessage{} for c, test := range []struct { line string msg  *logMessage err  bool }{ { // Docker log format stdout line: `{\"log\":\"docker stdout test log\",\"stream\":\"stdout\",\"time\":\"2016-10-20T18:39:20.57606443Z\"}` + \"n\", msg: &logMessage{ timestamp: timestamp, stream:    stdoutType, log:       []byte(\"docker stdout test log\"), }, }, { // Docker log format stderr line: `{\"log\":\"docker stderr test log\",\"stream\":\"stderr\",\"time\":\"2016-10-20T18:39:20.57606443Z\"}` + \"n\", msg: &logMessage{ timestamp: timestamp, stream:    stderrType, log:       []byte(\"docker stderr test log\"), }, }, { // CRI log format stdout line: \"2016-10-20T18:39:20.57606443Z stdout cri stdout test logn\", msg: &logMessage{ timestamp: timestamp, stream:    stdoutType, log:       []byte(\"cri stdout test logn\"), }, }, { // CRI log format stderr line: \"2016-10-20T18:39:20.57606443Z stderr cri stderr test logn\", msg: &logMessage{ timestamp: timestamp, stream:    stderrType, log:       []byte(\"cri stderr test logn\"), }, }, { // Unsupported Log format line: \"unsupported log format test logn\", msg:  &logMessage{}, err:  true, }, } { t.Logf(\"TestCase #%d: %+v\", c, test) parse, err := getParseFunc([]byte(test.line)) if test.err { assert.Error(t, err) continue } assert.NoError(t, err) err = parse([]byte(test.line), msg) assert.NoError(t, err) assert.Equal(t, test.msg, msg) } } func TestWriteLogs(t *testing.T) { timestamp := time.Unix(1234, 4321) log := \"abcdefgn\" for c, test := range []struct { stream       streamType since        time.Time timestamp    bool expectStdout string expectStderr string }{ { // stderr log stream:       stderrType, expectStderr: log, }, { // stdout log stream:       stdoutType, expectStdout: log, }, { // since is after timestamp stream: stdoutType, since:  timestamp.Add(1 * time.Second), }, { // timestamp enabled stream:       stderrType, timestamp:    true, expectStderr: timestamp.Format(timeFormat) + \" \" + log, }, } { t.Logf(\"TestCase #%d: %+v\", c, test) msg := &logMessage{ timestamp: timestamp, stream:    test.stream, log:       []byte(log), } stdoutBuf := bytes.NewBuffer(nil) stderrBuf := bytes.NewBuffer(nil) w := newLogWriter(stdoutBuf, stderrBuf, &logOptions{since: test.since, timestamp: test.timestamp, bytes: -1}) err := w.write(msg) assert.NoError(t, err) assert.Equal(t, test.expectStdout, stdoutBuf.String()) assert.Equal(t, test.expectStderr, stderrBuf.String()) } } func TestWriteLogsWithBytesLimit(t *testing.T) { timestamp := time.Unix(1234, 4321) timestampStr := timestamp.Format(timeFormat) log := \"abcdefgn\" for c, test := range []struct { stdoutLines  int stderrLines  int bytes        int timestamp    bool expectStdout string expectStderr string }{ { // limit bytes less than one line stdoutLines:  3, bytes:        3, expectStdout: \"abc\", }, { // limit bytes across lines stdoutLines:  3, bytes:        len(log) + 3, expectStdout: \"abcdefgnabc\", }, { // limit bytes more than all lines stdoutLines:  3, bytes:        3 * len(log), expectStdout: \"abcdefgnabcdefgnabcdefgn\", }, { // limit bytes for stderr stderrLines:  3, bytes:        len(log) + 3, expectStderr: \"abcdefgnabc\", }, { // limit bytes for both stdout and stderr, stdout first. stdoutLines:  1, stderrLines:  2, bytes:        len(log) + 3, expectStdout: \"abcdefgn\", expectStderr: \"abc\", }, { // limit bytes with timestamp stdoutLines:  3, timestamp:    true, bytes:        len(timestampStr) + 1 + len(log) + 2, expectStdout: timestampStr + \" \" + log + timestampStr[:2], }, } { t.Logf(\"TestCase #%d: %+v\", c, test) msg := &logMessage{ timestamp: timestamp, log:       []byte(log), } stdoutBuf := bytes.NewBuffer(nil) stderrBuf := bytes.NewBuffer(nil) w := newLogWriter(stdoutBuf, stderrBuf, &logOptions{timestamp: test.timestamp, bytes: int64(test.bytes)}) for i := 0; i < test.stdoutLines; i++ { msg.stream = stdoutType if err := w.write(msg); err != nil { assert.EqualError(t, err, errMaximumWrite.Error()) } } for i := 0; i < test.stderrLines; i++ { msg.stream = stderrType if err := w.write(msg); err != nil { assert.EqualError(t, err, errMaximumWrite.Error()) } } assert.Equal(t, test.expectStdout, stdoutBuf.String()) assert.Equal(t, test.expectStderr, stderrBuf.String()) } } </del>", "commid": "kubernetes_pr_55140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c27b3b02c304571a16f876186f2122703d7dbcacd59c19977a1f2e30cde3b19", "query": "We should make the CRI log parsing code in kubelet to be a library. So that container runtimes and external tools don't need to copy the whole code ( vendor it instead ). Referring\n/assign\n/sig node\nI can help on it.\n/assign\nGitHub didn't allow me to assign the following users: yanxuean. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThanks. I have a branch ready for this. Will open a PR later and ping you when it is out.\nok", "positive_passages": [{"docid": "doc-en-kubernetes-cdf965b3e8cb847e6dbf0e8ccc2a11c3314d29ace67a110009c797cb239f4afc", "text": "<ins> load(\"@io_bazel_rules_go//go:def.bzl\", \"go_library\", \"go_test\") go_library( name = \"go_default_library\", srcs = [\"logs.go\"], importpath = \"k8s.io/kubernetes/pkg/kubelet/kuberuntime/logs\", visibility = [\"//visibility:public\"], deps = [ \"//pkg/kubelet/apis/cri:go_default_library\", \"//pkg/kubelet/apis/cri/v1alpha1/runtime:go_default_library\", \"//pkg/util/tail:go_default_library\", \"//vendor/github.com/docker/docker/pkg/jsonlog:go_default_library\", \"//vendor/github.com/fsnotify/fsnotify:go_default_library\", \"//vendor/github.com/golang/glog:go_default_library\", \"//vendor/k8s.io/api/core/v1:go_default_library\", ], ) go_test( name = \"go_default_test\", srcs = [\"logs_test.go\"], importpath = \"k8s.io/kubernetes/pkg/kubelet/kuberuntime/logs\", library = \":go_default_library\", deps = [ \"//vendor/github.com/stretchr/testify/assert:go_default_library\", \"//vendor/k8s.io/api/core/v1:go_default_library\", \"//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library\", ], ) filegroup( name = \"package-srcs\", srcs = glob([\"**\"]), tags = [\"automanaged\"], visibility = [\"//visibility:private\"], ) filegroup( name = \"all-srcs\", srcs = [\":package-srcs\"], tags = [\"automanaged\"], visibility = [\"//visibility:public\"], ) </ins>", "commid": "kubernetes_pr_55140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c27b3b02c304571a16f876186f2122703d7dbcacd59c19977a1f2e30cde3b19", "query": "We should make the CRI log parsing code in kubelet to be a library. So that container runtimes and external tools don't need to copy the whole code ( vendor it instead ). Referring\n/assign\n/sig node\nI can help on it.\n/assign\nGitHub didn't allow me to assign the following users: yanxuean. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThanks. I have a branch ready for this. Will open a PR later and ping you when it is out.\nok", "positive_passages": [{"docid": "doc-en-kubernetes-dc26b117d9268f2359423549c1164b3dc76060c6bfe562a34ecde3a1b2a147a5", "text": "<ins> /* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package logs import ( \"bufio\" \"bytes\" \"encoding/json\" \"errors\" \"fmt\" \"io\" \"math\" \"os\" \"time\" \"github.com/docker/docker/pkg/jsonlog\" \"github.com/fsnotify/fsnotify\" \"github.com/golang/glog\" \"k8s.io/api/core/v1\" internalapi \"k8s.io/kubernetes/pkg/kubelet/apis/cri\" runtimeapi \"k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime\" \"k8s.io/kubernetes/pkg/util/tail\" ) // Notice that the current CRI logs implementation doesn't handle // log rotation. // * It will not retrieve logs in rotated log file. // * If log rotation happens when following the log: //   * If the rotation is using create mode, we'll still follow the old file. //   * If the rotation is using copytruncate, we'll be reading at the original position and get nothing. // TODO(random-liu): Support log rotation. // streamType is the type of the stream. type streamType string const ( stderrType streamType = \"stderr\" stdoutType streamType = \"stdout\" // timeFormat is the time format used in the log. timeFormat = time.RFC3339Nano // blockSize is the block size used in tail. blockSize = 1024 // stateCheckPeriod is the period to check container state while following // the container log. Kubelet should not keep following the log when the // container is not running. stateCheckPeriod = 5 * time.Second ) var ( // eol is the end-of-line sign in the log. eol = []byte{'n'} // delimiter is the delimiter for timestamp and streamtype in log line. delimiter = []byte{' '} ) // logMessage is the CRI internal log type. type logMessage struct { timestamp time.Time stream    streamType log       []byte } // reset resets the log to nil. func (l *logMessage) reset() { l.timestamp = time.Time{} l.stream = \"\" l.log = nil } // LogOptions is the CRI internal type of all log options. type LogOptions struct { tail      int64 bytes     int64 since     time.Time follow    bool timestamp bool } // NewLogOptions convert the v1.PodLogOptions to CRI internal LogOptions. func NewLogOptions(apiOpts *v1.PodLogOptions, now time.Time) *LogOptions { opts := &LogOptions{ tail:      -1, // -1 by default which means read all logs. bytes:     -1, // -1 by default which means read all logs. follow:    apiOpts.Follow, timestamp: apiOpts.Timestamps, } if apiOpts.TailLines != nil { opts.tail = *apiOpts.TailLines } if apiOpts.LimitBytes != nil { opts.bytes = *apiOpts.LimitBytes } if apiOpts.SinceSeconds != nil { opts.since = now.Add(-time.Duration(*apiOpts.SinceSeconds) * time.Second) } if apiOpts.SinceTime != nil && apiOpts.SinceTime.After(opts.since) { opts.since = apiOpts.SinceTime.Time } return opts } // parseFunc is a function parsing one log line to the internal log type. // Notice that the caller must make sure logMessage is not nil. type parseFunc func([]byte, *logMessage) error var parseFuncs = []parseFunc{ parseCRILog,        // CRI log format parse function parseDockerJSONLog, // Docker JSON log format parse function } // parseCRILog parses logs in CRI log format. CRI Log format example: //   2016-10-06T00:17:09.669794202Z stdout log content 1 //   2016-10-06T00:17:09.669794203Z stderr log content 2 func parseCRILog(log []byte, msg *logMessage) error { var err error // Parse timestamp idx := bytes.Index(log, delimiter) if idx < 0 { return fmt.Errorf(\"timestamp is not found\") } msg.timestamp, err = time.Parse(timeFormat, string(log[:idx])) if err != nil { return fmt.Errorf(\"unexpected timestamp format %q: %v\", timeFormat, err) } // Parse stream type log = log[idx+1:] idx = bytes.Index(log, delimiter) if idx < 0 { return fmt.Errorf(\"stream type is not found\") } msg.stream = streamType(log[:idx]) if msg.stream != stdoutType && msg.stream != stderrType { return fmt.Errorf(\"unexpected stream type %q\", msg.stream) } // Get log content msg.log = log[idx+1:] return nil } // parseDockerJSONLog parses logs in Docker JSON log format. Docker JSON log format // example: //   {\"log\":\"content 1\",\"stream\":\"stdout\",\"time\":\"2016-10-20T18:39:20.57606443Z\"} //   {\"log\":\"content 2\",\"stream\":\"stderr\",\"time\":\"2016-10-20T18:39:20.57606444Z\"} func parseDockerJSONLog(log []byte, msg *logMessage) error { var l = &jsonlog.JSONLog{} l.Reset() // TODO: JSON decoding is fairly expensive, we should evaluate this. if err := json.Unmarshal(log, l); err != nil { return fmt.Errorf(\"failed with %v to unmarshal log %q\", err, l) } msg.timestamp = l.Created msg.stream = streamType(l.Stream) msg.log = []byte(l.Log) return nil } // getParseFunc returns proper parse function based on the sample log line passed in. func getParseFunc(log []byte) (parseFunc, error) { for _, p := range parseFuncs { if err := p(log, &logMessage{}); err == nil { return p, nil } } return nil, fmt.Errorf(\"unsupported log format: %q\", log) } // logWriter controls the writing into the stream based on the log options. type logWriter struct { stdout io.Writer stderr io.Writer opts   *LogOptions remain int64 } // errMaximumWrite is returned when all bytes have been written. var errMaximumWrite = errors.New(\"maximum write\") // errShortWrite is returned when the message is not fully written. var errShortWrite = errors.New(\"short write\") func newLogWriter(stdout io.Writer, stderr io.Writer, opts *LogOptions) *logWriter { w := &logWriter{ stdout: stdout, stderr: stderr, opts:   opts, remain: math.MaxInt64, // initialize it as infinity } if opts.bytes >= 0 { w.remain = opts.bytes } return w } // writeLogs writes logs into stdout, stderr. func (w *logWriter) write(msg *logMessage) error { if msg.timestamp.Before(w.opts.since) { // Skip the line because it's older than since return nil } line := msg.log if w.opts.timestamp { prefix := append([]byte(msg.timestamp.Format(timeFormat)), delimiter[0]) line = append(prefix, line...) } // If the line is longer than the remaining bytes, cut it. if int64(len(line)) > w.remain { line = line[:w.remain] } // Get the proper stream to write to. var stream io.Writer switch msg.stream { case stdoutType: stream = w.stdout case stderrType: stream = w.stderr default: return fmt.Errorf(\"unexpected stream type %q\", msg.stream) } n, err := stream.Write(line) w.remain -= int64(n) if err != nil { return err } // If the line has not been fully written, return errShortWrite if n < len(line) { return errShortWrite } // If there are no more bytes left, return errMaximumWrite if w.remain <= 0 { return errMaximumWrite } return nil } // ReadLogs read the container log and redirect into stdout and stderr. // Note that containerID is only needed when following the log, or else // just pass in empty string \"\". func ReadLogs(path, containerID string, opts *LogOptions, runtimeService internalapi.RuntimeService, stdout, stderr io.Writer) error { f, err := os.Open(path) if err != nil { return fmt.Errorf(\"failed to open log file %q: %v\", path, err) } defer f.Close() // Search start point based on tail line. start, err := tail.FindTailLineStartIndex(f, opts.tail) if err != nil { return fmt.Errorf(\"failed to tail %d lines of log file %q: %v\", opts.tail, path, err) } if _, err := f.Seek(start, os.SEEK_SET); err != nil { return fmt.Errorf(\"failed to seek %d in log file %q: %v\", start, path, err) } // Start parsing the logs. r := bufio.NewReader(f) // Do not create watcher here because it is not needed if `Follow` is false. var watcher *fsnotify.Watcher var parse parseFunc writer := newLogWriter(stdout, stderr, opts) msg := &logMessage{} for { l, err := r.ReadBytes(eol[0]) if err != nil { if err != io.EOF { // This is an real error return fmt.Errorf(\"failed to read log file %q: %v\", path, err) } if !opts.follow { // Return directly when reading to the end if not follow. if len(l) > 0 { glog.Warningf(\"Incomplete line in log file %q: %q\", path, l) } glog.V(2).Infof(\"Finish parsing log file %q\", path) return nil } // Reset seek so that if this is an incomplete line, // it will be read again. if _, err := f.Seek(-int64(len(l)), os.SEEK_CUR); err != nil { return fmt.Errorf(\"failed to reset seek in log file %q: %v\", path, err) } if watcher == nil { // Intialize the watcher if it has not been initialized yet. if watcher, err = fsnotify.NewWatcher(); err != nil { return fmt.Errorf(\"failed to create fsnotify watcher: %v\", err) } defer watcher.Close() if err := watcher.Add(f.Name()); err != nil { return fmt.Errorf(\"failed to watch file %q: %v\", f.Name(), err) } } // Wait until the next log change. if found, err := waitLogs(containerID, watcher, runtimeService); !found { return err } continue } if parse == nil { // Intialize the log parsing function. parse, err = getParseFunc(l) if err != nil { return fmt.Errorf(\"failed to get parse function: %v\", err) } } // Parse the log line. msg.reset() if err := parse(l, msg); err != nil { glog.Errorf(\"Failed with err %v when parsing log for log file %q: %q\", err, path, l) continue } // Write the log line into the stream. if err := writer.write(msg); err != nil { if err == errMaximumWrite { glog.V(2).Infof(\"Finish parsing log file %q, hit bytes limit %d(bytes)\", path, opts.bytes) return nil } glog.Errorf(\"Failed with err %v when writing log for log file %q: %+v\", err, path, msg) return err } } } // waitLogs wait for the next log write. It returns a boolean and an error. The boolean // indicates whether a new log is found; the error is error happens during waiting new logs. func waitLogs(id string, w *fsnotify.Watcher, runtimeService internalapi.RuntimeService) (bool, error) { errRetry := 5 for { select { case e := <-w.Events: switch e.Op { case fsnotify.Write: return true, nil default: glog.Errorf(\"Unexpected fsnotify event: %v, retrying...\", e) } case err := <-w.Errors: glog.Errorf(\"Fsnotify watch error: %v, %d error retries remaining\", err, errRetry) if errRetry == 0 { return false, err } errRetry-- case <-time.After(stateCheckPeriod): s, err := runtimeService.ContainerStatus(id) if err != nil { return false, err } // Only keep following container log when it is running. if s.State != runtimeapi.ContainerState_CONTAINER_RUNNING { glog.Errorf(\"Container %q is not running (state=%q)\", id, s.State) // Do not return error because it's normal that the container stops // during waiting. return false, nil } } } } </ins>", "commid": "kubernetes_pr_55140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c27b3b02c304571a16f876186f2122703d7dbcacd59c19977a1f2e30cde3b19", "query": "We should make the CRI log parsing code in kubelet to be a library. So that container runtimes and external tools don't need to copy the whole code ( vendor it instead ). Referring\n/assign\n/sig node\nI can help on it.\n/assign\nGitHub didn't allow me to assign the following users: yanxuean. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThanks. I have a branch ready for this. Will open a PR later and ping you when it is out.\nok", "positive_passages": [{"docid": "doc-en-kubernetes-496b691a7c58ceb0420d0221c4ad88e1ffe59683ff00954872a4c206662f02f9", "text": "<ins> /* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package logs import ( \"bytes\" \"testing\" \"time\" \"github.com/stretchr/testify/assert\" \"k8s.io/api/core/v1\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" ) func TestLogOptions(t *testing.T) { var ( line         = int64(8) bytes        = int64(64) timestamp    = metav1.Now() sinceseconds = int64(10) ) for c, test := range []struct { apiOpts *v1.PodLogOptions expect  *LogOptions }{ { // empty options apiOpts: &v1.PodLogOptions{}, expect:  &LogOptions{tail: -1, bytes: -1}, }, { // test tail lines apiOpts: &v1.PodLogOptions{TailLines: &line}, expect:  &LogOptions{tail: line, bytes: -1}, }, { // test limit bytes apiOpts: &v1.PodLogOptions{LimitBytes: &bytes}, expect:  &LogOptions{tail: -1, bytes: bytes}, }, { // test since timestamp apiOpts: &v1.PodLogOptions{SinceTime: &timestamp}, expect:  &LogOptions{tail: -1, bytes: -1, since: timestamp.Time}, }, { // test since seconds apiOpts: &v1.PodLogOptions{SinceSeconds: &sinceseconds}, expect:  &LogOptions{tail: -1, bytes: -1, since: timestamp.Add(-10 * time.Second)}, }, } { t.Logf(\"TestCase #%d: %+v\", c, test) opts := NewLogOptions(test.apiOpts, timestamp.Time) assert.Equal(t, test.expect, opts) } } func TestParseLog(t *testing.T) { timestamp, err := time.Parse(timeFormat, \"2016-10-20T18:39:20.57606443Z\") assert.NoError(t, err) msg := &logMessage{} for c, test := range []struct { line string msg  *logMessage err  bool }{ { // Docker log format stdout line: `{\"log\":\"docker stdout test log\",\"stream\":\"stdout\",\"time\":\"2016-10-20T18:39:20.57606443Z\"}` + \"n\", msg: &logMessage{ timestamp: timestamp, stream:    stdoutType, log:       []byte(\"docker stdout test log\"), }, }, { // Docker log format stderr line: `{\"log\":\"docker stderr test log\",\"stream\":\"stderr\",\"time\":\"2016-10-20T18:39:20.57606443Z\"}` + \"n\", msg: &logMessage{ timestamp: timestamp, stream:    stderrType, log:       []byte(\"docker stderr test log\"), }, }, { // CRI log format stdout line: \"2016-10-20T18:39:20.57606443Z stdout cri stdout test logn\", msg: &logMessage{ timestamp: timestamp, stream:    stdoutType, log:       []byte(\"cri stdout test logn\"), }, }, { // CRI log format stderr line: \"2016-10-20T18:39:20.57606443Z stderr cri stderr test logn\", msg: &logMessage{ timestamp: timestamp, stream:    stderrType, log:       []byte(\"cri stderr test logn\"), }, }, { // Unsupported Log format line: \"unsupported log format test logn\", msg:  &logMessage{}, err:  true, }, } { t.Logf(\"TestCase #%d: %+v\", c, test) parse, err := getParseFunc([]byte(test.line)) if test.err { assert.Error(t, err) continue } assert.NoError(t, err) err = parse([]byte(test.line), msg) assert.NoError(t, err) assert.Equal(t, test.msg, msg) } } func TestWriteLogs(t *testing.T) { timestamp := time.Unix(1234, 4321) log := \"abcdefgn\" for c, test := range []struct { stream       streamType since        time.Time timestamp    bool expectStdout string expectStderr string }{ { // stderr log stream:       stderrType, expectStderr: log, }, { // stdout log stream:       stdoutType, expectStdout: log, }, { // since is after timestamp stream: stdoutType, since:  timestamp.Add(1 * time.Second), }, { // timestamp enabled stream:       stderrType, timestamp:    true, expectStderr: timestamp.Format(timeFormat) + \" \" + log, }, } { t.Logf(\"TestCase #%d: %+v\", c, test) msg := &logMessage{ timestamp: timestamp, stream:    test.stream, log:       []byte(log), } stdoutBuf := bytes.NewBuffer(nil) stderrBuf := bytes.NewBuffer(nil) w := newLogWriter(stdoutBuf, stderrBuf, &LogOptions{since: test.since, timestamp: test.timestamp, bytes: -1}) err := w.write(msg) assert.NoError(t, err) assert.Equal(t, test.expectStdout, stdoutBuf.String()) assert.Equal(t, test.expectStderr, stderrBuf.String()) } } func TestWriteLogsWithBytesLimit(t *testing.T) { timestamp := time.Unix(1234, 4321) timestampStr := timestamp.Format(timeFormat) log := \"abcdefgn\" for c, test := range []struct { stdoutLines  int stderrLines  int bytes        int timestamp    bool expectStdout string expectStderr string }{ { // limit bytes less than one line stdoutLines:  3, bytes:        3, expectStdout: \"abc\", }, { // limit bytes across lines stdoutLines:  3, bytes:        len(log) + 3, expectStdout: \"abcdefgnabc\", }, { // limit bytes more than all lines stdoutLines:  3, bytes:        3 * len(log), expectStdout: \"abcdefgnabcdefgnabcdefgn\", }, { // limit bytes for stderr stderrLines:  3, bytes:        len(log) + 3, expectStderr: \"abcdefgnabc\", }, { // limit bytes for both stdout and stderr, stdout first. stdoutLines:  1, stderrLines:  2, bytes:        len(log) + 3, expectStdout: \"abcdefgn\", expectStderr: \"abc\", }, { // limit bytes with timestamp stdoutLines:  3, timestamp:    true, bytes:        len(timestampStr) + 1 + len(log) + 2, expectStdout: timestampStr + \" \" + log + timestampStr[:2], }, } { t.Logf(\"TestCase #%d: %+v\", c, test) msg := &logMessage{ timestamp: timestamp, log:       []byte(log), } stdoutBuf := bytes.NewBuffer(nil) stderrBuf := bytes.NewBuffer(nil) w := newLogWriter(stdoutBuf, stderrBuf, &LogOptions{timestamp: test.timestamp, bytes: int64(test.bytes)}) for i := 0; i < test.stdoutLines; i++ { msg.stream = stdoutType if err := w.write(msg); err != nil { assert.EqualError(t, err, errMaximumWrite.Error()) } } for i := 0; i < test.stderrLines; i++ { msg.stream = stderrType if err := w.write(msg); err != nil { assert.EqualError(t, err, errMaximumWrite.Error()) } } assert.Equal(t, test.expectStdout, stdoutBuf.String()) assert.Equal(t, test.expectStderr, stderrBuf.String()) } } </ins>", "commid": "kubernetes_pr_55140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2354d38d89f6dd8b381ae31424a08aa7093eac46e22478abd675b16478095578", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT: What happened: When a statefulset object is created, a lot of controllerrevisions are created at the same time. the controllerrevisions have differenct hash value but the same Data.Raw. How to fix it: two controllerrevisions are seen as the same , when [ControllerRevisionHashLabel] , Controllerrevision.Data.Raw , Controllerrevision.Data.Object are strictly the same // this line shoud be to fix the bug like below: Anything else we need to know?: Environment: Kubernetes version (use ): 1.7.8 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\nI would help fix it\n/kind bug /sig apps\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten /remove-lifecycle stale\nStatefulSet uses the following code to construct its history object (controllerrevision): However, collisionCount shouldn't be blindly increased when there's name collision. Because controller uses a cache store, the name collision could be due to a controllerrevision created but not yet observed by the controller. The right way to handle it is to first check if the controllerrevision with the same name has the same content as the one we're going to create, like how DaemonSet controller handles it:", "positive_passages": [{"docid": "doc-en-kubernetes-0b2e617d9dc2d0e8e9cae5a24f2b7cdf9af079961d2003f4ad79e5df0fd255c9", "text": "hash := HashControllerRevision(revision, collisionCount) // Update the revisions name and labels clone.Name = ControllerRevisionName(parent.GetName(), hash) <del> created, err := rh.client.AppsV1().ControllerRevisions(parent.GetNamespace()).Create(clone) </del> <ins> ns := parent.GetNamespace() created, err := rh.client.AppsV1().ControllerRevisions(ns).Create(clone) </ins> if errors.IsAlreadyExists(err) { <ins> exists, err := rh.client.AppsV1().ControllerRevisions(ns).Get(clone.Name, metav1.GetOptions{}) if err != nil { return nil, err } if bytes.Equal(exists.Data.Raw, clone.Data.Raw) { return exists, nil } </ins> *collisionCount++ continue }", "commid": "kubernetes_pr_67039"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2354d38d89f6dd8b381ae31424a08aa7093eac46e22478abd675b16478095578", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT: What happened: When a statefulset object is created, a lot of controllerrevisions are created at the same time. the controllerrevisions have differenct hash value but the same Data.Raw. How to fix it: two controllerrevisions are seen as the same , when [ControllerRevisionHashLabel] , Controllerrevision.Data.Raw , Controllerrevision.Data.Object are strictly the same // this line shoud be to fix the bug like below: Anything else we need to know?: Environment: Kubernetes version (use ): 1.7.8 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\nI would help fix it\n/kind bug /sig apps\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten /remove-lifecycle stale\nStatefulSet uses the following code to construct its history object (controllerrevision): However, collisionCount shouldn't be blindly increased when there's name collision. Because controller uses a cache store, the name collision could be due to a controllerrevision created but not yet observed by the controller. The right way to handle it is to first check if the controllerrevision with the same name has the same content as the one we're going to create, like how DaemonSet controller handles it:", "positive_passages": [{"docid": "doc-en-kubernetes-b7e23e4f16f7fd7b2f7aab14b0379d04a92ba69558d8ad6d54bcd9760d85452b", "text": "history := NewHistory(client, informer.Lister()) var collisionCount int32 <del> for i := range test.existing { _, err := history.CreateControllerRevision(test.existing[i].parent, test.existing[i].revision, &collisionCount) </del> <ins> for _, item := range test.existing { _, err := client.AppsV1().ControllerRevisions(item.parent.GetNamespace()).Create(item.revision) </ins> if err != nil { t.Fatal(err) }", "commid": "kubernetes_pr_67039"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2354d38d89f6dd8b381ae31424a08aa7093eac46e22478abd675b16478095578", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT: What happened: When a statefulset object is created, a lot of controllerrevisions are created at the same time. the controllerrevisions have differenct hash value but the same Data.Raw. How to fix it: two controllerrevisions are seen as the same , when [ControllerRevisionHashLabel] , Controllerrevision.Data.Raw , Controllerrevision.Data.Object are strictly the same // this line shoud be to fix the bug like below: Anything else we need to know?: Environment: Kubernetes version (use ): 1.7.8 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\nI would help fix it\n/kind bug /sig apps\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten /remove-lifecycle stale\nStatefulSet uses the following code to construct its history object (controllerrevision): However, collisionCount shouldn't be blindly increased when there's name collision. Because controller uses a cache store, the name collision could be due to a controllerrevision created but not yet observed by the controller. The right way to handle it is to first check if the controllerrevision with the same name has the same content as the one we're going to create, like how DaemonSet controller handles it:", "positive_passages": [{"docid": "doc-en-kubernetes-9e507651e005f6fb71cf5052bf2002e4cd637d7ce5d0275f6ba0d2b7bab9aba4", "text": "t.Errorf(\"%s: on name collision wanted new name %s got %s\", test.name, expectedName, created.Name) } <del> // Second name collision should have incremented collisionCount to 2 </del> <ins> // Second name collision will be caused by an identical revision, so no need to do anything </ins> _, err = history.CreateControllerRevision(test.parent, test.revision, &collisionCount) if err != nil { t.Errorf(\"%s: %s\", test.name, err) } <del> if collisionCount != 2 { </del> <ins> if collisionCount != 1 { </ins> t.Errorf(\"%s: on second name collision wanted collisionCount 1 got %d\", test.name, collisionCount) } }", "commid": "kubernetes_pr_67039"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2354d38d89f6dd8b381ae31424a08aa7093eac46e22478abd675b16478095578", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT: What happened: When a statefulset object is created, a lot of controllerrevisions are created at the same time. the controllerrevisions have differenct hash value but the same Data.Raw. How to fix it: two controllerrevisions are seen as the same , when [ControllerRevisionHashLabel] , Controllerrevision.Data.Raw , Controllerrevision.Data.Object are strictly the same // this line shoud be to fix the bug like below: Anything else we need to know?: Environment: Kubernetes version (use ): 1.7.8 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\nI would help fix it\n/kind bug /sig apps\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten /remove-lifecycle stale\nStatefulSet uses the following code to construct its history object (controllerrevision): However, collisionCount shouldn't be blindly increased when there's name collision. Because controller uses a cache store, the name collision could be due to a controllerrevision created but not yet observed by the controller. The right way to handle it is to first check if the controllerrevision with the same name has the same content as the one we're going to create, like how DaemonSet controller handles it:", "positive_passages": [{"docid": "doc-en-kubernetes-0e1540588338c060ccdc433b9906355784ccd323753a20fe58f9db14e9292d88", "text": "t.Fatal(err) } ss1Rev1.Namespace = ss1.Namespace <del> ss1Rev2, err := NewControllerRevision(ss1, parentKind, ss1.Spec.Template.Labels, rawTemplate(&ss1.Spec.Template), 2, ss1.Status.CollisionCount) </del> <ins> // Create a new revision with the same name and hash label as an existing revision, but with // a different template. This could happen as a result of a hash collision, but in this test // this situation is created by setting name and hash label to values known to be in use by // an existing revision. modTemplate := ss1.Spec.Template.DeepCopy() modTemplate.Labels[\"foo\"] = \"not_bar\" ss1Rev2, err := NewControllerRevision(ss1, parentKind, ss1.Spec.Template.Labels, rawTemplate(modTemplate), 2, ss1.Status.CollisionCount) ss1Rev2.Name = ss1Rev1.Name ss1Rev2.Labels[ControllerRevisionHashLabel] = ss1Rev1.Labels[ControllerRevisionHashLabel] </ins> if err != nil { t.Fatal(err) }", "commid": "kubernetes_pr_67039"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2354d38d89f6dd8b381ae31424a08aa7093eac46e22478abd675b16478095578", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT: What happened: When a statefulset object is created, a lot of controllerrevisions are created at the same time. the controllerrevisions have differenct hash value but the same Data.Raw. How to fix it: two controllerrevisions are seen as the same , when [ControllerRevisionHashLabel] , Controllerrevision.Data.Raw , Controllerrevision.Data.Object are strictly the same // this line shoud be to fix the bug like below: Anything else we need to know?: Environment: Kubernetes version (use ): 1.7.8 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\nI would help fix it\n/kind bug /sig apps\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten /remove-lifecycle stale\nStatefulSet uses the following code to construct its history object (controllerrevision): However, collisionCount shouldn't be blindly increased when there's name collision. Because controller uses a cache store, the name collision could be due to a controllerrevision created but not yet observed by the controller. The right way to handle it is to first check if the controllerrevision with the same name has the same content as the one we're going to create, like how DaemonSet controller handles it:", "positive_passages": [{"docid": "doc-en-kubernetes-91a097ec01c8c1a0396ac5d5b7506136ed36af892c39024039b19e15f6e12947", "text": "}{ { parent:   ss1, <del> revision: ss1Rev1, </del> <ins> revision: ss1Rev2, </ins> }, }, rename: true,", "commid": "kubernetes_pr_67039"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4435f48cba5c6b9ba6240af42e1efb7e38ee023f272e6d6f2f2182e6ebddb41", "query": "/kind bug /sig cli What happened: Tried to list the age of pods in the namespace in an otherwise empty cluster $ kubectl --namespace kube-system plugin aging The Magnificent Aging Plugin. No pods What you expected to happen: That the pods in the namespace would have been listed How to reproduce it (as minimally and precisely as possible): the and from into . the command: Anything else we need to know?: No Environment: Kubernetes version (use ): v1.8.2 Cloud provider or hardware configuration: minikube & GKE OS (e.g. from /etc/os-release): Mac OSX El Capitan Kernel (e.g. ): Darwin Kernel Version 15.6.0 Install tools: Google Cloud SDK\nhi for cli issue, could you please file it in this repo next time ? thanks !!\nWill the k8s github bots be able to resolve references in commit messages made in kubernetes/kubernetes PRs be able to find the corresponding issue ticket in that other project? Semi-OT but related: I know there's an overall intention to refactoring k8s proper into many distinct projects, so it would be helpful if either the contributor guide contained a mapping of each and every module making up a k8s release with its corresponding github project and protocol governing the component. Or if each directory (module) in kubernetes/kubernetes contains its own explaining the contribution protocol. Right now documentation and information about ownership, contribution and protocols of various project modules are a sprawl and a bit of a mess, creating a significant barrier to entry (contribution). What's the proper place and form to discuss these sort of things?\nthanks, I think those are some good suggestions, as far as I know you could send an email to our mailling-list(google-groups) or create an new issue then cc", "positive_passages": [{"docid": "doc-en-kubernetes-29ec6bab57948ea7cea1c13d9cbad02f44d730db039e14132773c87c4eddb092", "text": "end end <del> pods_json = `kubectl get pods -o json` </del> <ins> namespace = ENV['KUBECTL_PLUGINS_CURRENT_NAMESPACE'] || 'default' pods_json = `kubectl --namespace #{namespace} get pods -o json` </ins> pods_parsed = JSON.parse(pods_json) puts \"The Magnificent Aging Plugin.\"", "commid": "kubernetes_pr_55258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4435f48cba5c6b9ba6240af42e1efb7e38ee023f272e6d6f2f2182e6ebddb41", "query": "/kind bug /sig cli What happened: Tried to list the age of pods in the namespace in an otherwise empty cluster $ kubectl --namespace kube-system plugin aging The Magnificent Aging Plugin. No pods What you expected to happen: That the pods in the namespace would have been listed How to reproduce it (as minimally and precisely as possible): the and from into . the command: Anything else we need to know?: No Environment: Kubernetes version (use ): v1.8.2 Cloud provider or hardware configuration: minikube & GKE OS (e.g. from /etc/os-release): Mac OSX El Capitan Kernel (e.g. ): Darwin Kernel Version 15.6.0 Install tools: Google Cloud SDK\nhi for cli issue, could you please file it in this repo next time ? thanks !!\nWill the k8s github bots be able to resolve references in commit messages made in kubernetes/kubernetes PRs be able to find the corresponding issue ticket in that other project? Semi-OT but related: I know there's an overall intention to refactoring k8s proper into many distinct projects, so it would be helpful if either the contributor guide contained a mapping of each and every module making up a k8s release with its corresponding github project and protocol governing the component. Or if each directory (module) in kubernetes/kubernetes contains its own explaining the contribution protocol. Right now documentation and information about ownership, contribution and protocols of various project modules are a sprawl and a bit of a mess, creating a significant barrier to entry (contribution). What's the proper place and form to discuss these sort of things?\nthanks, I think those are some good suggestions, as far as I know you could send an email to our mailling-list(google-groups) or create an new issue then cc", "positive_passages": [{"docid": "doc-en-kubernetes-ff260104d88412aae1bc707ebdbf760d001fac4612544a4a01a01685043c7f7d", "text": "shortDesc: \"Aging shows pods by age\" longDesc: > Aging shows pods from the current namespace by age. <del> Once we have plugin support for global flags through env vars (planned for V1) we'll be able to switch between namespaces using the --namespace flag. </del> command: ./aging.rb", "commid": "kubernetes_pr_55258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-03c92a40809bb9bebafe7d5451e4686cb2d18a7692b03032be3fd36ff7b15566", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: See in : https://k8s- /cc Fixed in\n/sig aws\nAdd /priority critical-urgent since marked it as a release blocker.\nPing! Release team here. This issue doesn't have any associated PRs which are passing tests. As a reminder, 1.9 Code Slush is on the 20th, and Code Freeze is on the 22nd. Do you think you'll have a working fix by then? If you plan for this fix to go into 1.9, the issue needs to be approved, and approved for the milestone.\nthe associated PR is . It needs another look from .\nPeter, i just nudged that along.\nyeah I see your and . Thanks Davanum!\n[MILESTONENOTIFIER] Milestone Issue Needs Approval Action required: This issue must have the label applied by a SIG maintainer. <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-daf9073b07cdb93fca17f55666b5048e42b6ff33f403daddb9217b7155bb2e01", "text": "\"sync\" \"time\" <ins> \"github.com/aws/aws-sdk-go/aws\" </ins> \"github.com/aws/aws-sdk-go/aws/awserr\" \"github.com/aws/aws-sdk-go/aws/request\" \"github.com/golang/glog\"", "commid": "kubernetes_pr_55307"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-03c92a40809bb9bebafe7d5451e4686cb2d18a7692b03032be3fd36ff7b15566", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: See in : https://k8s- /cc Fixed in\n/sig aws\nAdd /priority critical-urgent since marked it as a release blocker.\nPing! Release team here. This issue doesn't have any associated PRs which are passing tests. As a reminder, 1.9 Code Slush is on the 20th, and Code Freeze is on the 22nd. Do you think you'll have a working fix by then? If you plan for this fix to go into 1.9, the issue needs to be approved, and approved for the milestone.\nthe associated PR is . It needs another look from .\nPeter, i just nudged that along.\nyeah I see your and . Thanks Davanum!\n[MILESTONENOTIFIER] Milestone Issue Needs Approval Action required: This issue must have the label applied by a SIG maintainer. <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-d4a5c1b4fb84ccf12c880dda856944d18db2dca26c3aea998789412ee3d4ff90", "text": "if delay > 0 { glog.Warningf(\"Inserting delay before AWS request (%s) to avoid RequestLimitExceeded: %s\", describeRequest(r), delay.String()) <del> r.Config.SleepDelay(delay) </del> <ins> if sleepFn := r.Config.SleepDelay; sleepFn != nil { // Support SleepDelay for backwards compatibility sleepFn(delay) } else if err := aws.SleepWithContext(r.Context(), delay); err != nil { r.Error = awserr.New(request.CanceledErrorCode, \"request context canceled\", err) r.Retryable = aws.Bool(false) return } </ins> // Avoid clock skew problems r.Time = now", "commid": "kubernetes_pr_55307"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9088f0ead78b2fff04dd418b6ce000d4b309048b0554dcd7a11b323e0a89de4d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --BUG REPORT /kind bug What happened: I tried to submit a Service Replace () to the kube-apiserver and this results the kube-apiserver container crashing and restarting. PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenameWhat you expected to happen: I expected the server not to crash and to get validation errors if the request was invalid. How to reproduce it (as minimally and precisely as possible): Create a service, get the resourceVersion and clusterIP from the created resource GET localhost:8001/api/v1/namespaces/<namespace/services/<servicenameSubmit a replace command to PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenamewith body like If the same request is submitted with the nodePort fields in the ports array then the request succeeds. I get that I may be sending an invalid request without a node port (though shouldn't the merge deal with that?) but it shouldn't take down the API server. Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"6\", GitVersion:\"v1.6.3\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-05-10T23:29:08Z\", GoVersion:\"go1.8.1\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"8\", GitVersion:\"v1.8.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-10-11T23:16:41Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Bare metal cluster OS (e.g. from /etc/os-release): Ubuntu 16.04.3 LTS (Xenial Xerus) Kernel (e.g. ): 4.4.0-98-generic Install tools: Others:\nthanks for reporting this! Seems like this is similar to and should be fixed by . can you PTAL that PR to see if it's good to merge?\n/sig api-machinery\nDuplicate of", "positive_passages": [{"docid": "doc-en-kubernetes-ff481b2b814e08a2bc8fafd76c578a67f2190f9a3e29eb6ff11384ac46802789", "text": "proxyTransport   http.RoundTripper } <ins> // ServiceNodePort includes protocol and port number of a service NodePort. type ServiceNodePort struct { // The IP protocol for this port. Supports \"TCP\" and \"UDP\". Protocol api.Protocol // The port on each node on which this service is exposed. // Default is to auto-allocate a port if the ServiceType of this Service requires one. NodePort int32 } </ins> // NewStorage returns a new REST. func NewStorage(registry Registry, endpoints endpoint.Registry, serviceIPs ipallocator.Interface, serviceNodePorts portallocator.Interface, proxyTransport http.RoundTripper) *ServiceRest {", "commid": "kubernetes_pr_49258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9088f0ead78b2fff04dd418b6ce000d4b309048b0554dcd7a11b323e0a89de4d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --BUG REPORT /kind bug What happened: I tried to submit a Service Replace () to the kube-apiserver and this results the kube-apiserver container crashing and restarting. PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenameWhat you expected to happen: I expected the server not to crash and to get validation errors if the request was invalid. How to reproduce it (as minimally and precisely as possible): Create a service, get the resourceVersion and clusterIP from the created resource GET localhost:8001/api/v1/namespaces/<namespace/services/<servicenameSubmit a replace command to PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenamewith body like If the same request is submitted with the nodePort fields in the ports array then the request succeeds. I get that I may be sending an invalid request without a node port (though shouldn't the merge deal with that?) but it shouldn't take down the API server. Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"6\", GitVersion:\"v1.6.3\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-05-10T23:29:08Z\", GoVersion:\"go1.8.1\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"8\", GitVersion:\"v1.8.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-10-11T23:16:41Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Bare metal cluster OS (e.g. from /etc/os-release): Ubuntu 16.04.3 LTS (Xenial Xerus) Kernel (e.g. ): 4.4.0-98-generic Install tools: Others:\nthanks for reporting this! Seems like this is similar to and should be fixed by . can you PTAL that PR to see if it's good to merge?\n/sig api-machinery\nDuplicate of", "positive_passages": [{"docid": "doc-en-kubernetes-252c9563e9778d7c54d3889188ae004c5a0ba37b398c1c860ef823c86448a852", "text": "// This is O(N), but we expect haystack to be small; // so small that we expect a linear search to be faster <del> func contains(haystack []int, needle int) bool { </del> <ins> func containsNumber(haystack []int, needle int) bool { </ins> for _, v := range haystack { if v == needle { return true", "commid": "kubernetes_pr_49258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9088f0ead78b2fff04dd418b6ce000d4b309048b0554dcd7a11b323e0a89de4d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --BUG REPORT /kind bug What happened: I tried to submit a Service Replace () to the kube-apiserver and this results the kube-apiserver container crashing and restarting. PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenameWhat you expected to happen: I expected the server not to crash and to get validation errors if the request was invalid. How to reproduce it (as minimally and precisely as possible): Create a service, get the resourceVersion and clusterIP from the created resource GET localhost:8001/api/v1/namespaces/<namespace/services/<servicenameSubmit a replace command to PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenamewith body like If the same request is submitted with the nodePort fields in the ports array then the request succeeds. I get that I may be sending an invalid request without a node port (though shouldn't the merge deal with that?) but it shouldn't take down the API server. Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"6\", GitVersion:\"v1.6.3\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-05-10T23:29:08Z\", GoVersion:\"go1.8.1\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"8\", GitVersion:\"v1.8.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-10-11T23:16:41Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Bare metal cluster OS (e.g. from /etc/os-release): Ubuntu 16.04.3 LTS (Xenial Xerus) Kernel (e.g. ): 4.4.0-98-generic Install tools: Others:\nthanks for reporting this! Seems like this is similar to and should be fixed by . can you PTAL that PR to see if it's good to merge?\n/sig api-machinery\nDuplicate of", "positive_passages": [{"docid": "doc-en-kubernetes-ce3a0c00c5baa977594479108afda15204d629d85175235c8e7cdf85f6f9eb21", "text": "return false } <ins> // This is O(N), but we expect serviceNodePorts to be small; // so small that we expect a linear search to be faster func containsNodePort(serviceNodePorts []ServiceNodePort, serviceNodePort ServiceNodePort) bool { for _, snp := range serviceNodePorts { if snp == serviceNodePort { return true } } return false } </ins> func CollectServiceNodePorts(service *api.Service) []int { servicePorts := []int{} for i := range service.Spec.Ports {", "commid": "kubernetes_pr_49258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9088f0ead78b2fff04dd418b6ce000d4b309048b0554dcd7a11b323e0a89de4d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --BUG REPORT /kind bug What happened: I tried to submit a Service Replace () to the kube-apiserver and this results the kube-apiserver container crashing and restarting. PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenameWhat you expected to happen: I expected the server not to crash and to get validation errors if the request was invalid. How to reproduce it (as minimally and precisely as possible): Create a service, get the resourceVersion and clusterIP from the created resource GET localhost:8001/api/v1/namespaces/<namespace/services/<servicenameSubmit a replace command to PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenamewith body like If the same request is submitted with the nodePort fields in the ports array then the request succeeds. I get that I may be sending an invalid request without a node port (though shouldn't the merge deal with that?) but it shouldn't take down the API server. Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"6\", GitVersion:\"v1.6.3\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-05-10T23:29:08Z\", GoVersion:\"go1.8.1\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"8\", GitVersion:\"v1.8.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-10-11T23:16:41Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Bare metal cluster OS (e.g. from /etc/os-release): Ubuntu 16.04.3 LTS (Xenial Xerus) Kernel (e.g. ): 4.4.0-98-generic Install tools: Others:\nthanks for reporting this! Seems like this is similar to and should be fixed by . can you PTAL that PR to see if it's good to merge?\n/sig api-machinery\nDuplicate of", "positive_passages": [{"docid": "doc-en-kubernetes-68b0636f7a84ff65de0aee522f3b0711f856d9700bbfa3586c4cf65afd6c0681", "text": "} func (rs *REST) updateNodePorts(oldService, newService *api.Service, nodePortOp *portallocator.PortAllocationOperation) error { <del> oldNodePorts := CollectServiceNodePorts(oldService) </del> <ins> oldNodePortsNumbers := CollectServiceNodePorts(oldService) newNodePorts := []ServiceNodePort{} portAllocated := map[int]bool{} </ins> <del> newNodePorts := []int{} </del> for i := range newService.Spec.Ports { servicePort := &newService.Spec.Ports[i] <del> nodePort := int(servicePort.NodePort) if nodePort != 0 { if !contains(oldNodePorts, nodePort) { err := nodePortOp.Allocate(nodePort) </del> <ins> nodePort := ServiceNodePort{Protocol: servicePort.Protocol, NodePort: servicePort.NodePort} if nodePort.NodePort != 0 { if !containsNumber(oldNodePortsNumbers, int(nodePort.NodePort)) && !portAllocated[int(nodePort.NodePort)] { err := nodePortOp.Allocate(int(nodePort.NodePort)) </ins> if err != nil { <del> el := field.ErrorList{field.Invalid(field.NewPath(\"spec\", \"ports\").Index(i).Child(\"nodePort\"), nodePort, err.Error())} </del> <ins> el := field.ErrorList{field.Invalid(field.NewPath(\"spec\", \"ports\").Index(i).Child(\"nodePort\"), nodePort.NodePort, err.Error())} </ins> return errors.NewInvalid(api.Kind(\"Service\"), newService.Name, el) } <ins> portAllocated[int(nodePort.NodePort)] = true </ins> } } else { <del> nodePort, err := nodePortOp.AllocateNext() </del> <ins> nodePortNumber, err := nodePortOp.AllocateNext() </ins> if err != nil { // TODO: what error should be returned here?  It's not a // field-level validation failure (the field is valid), and it's // not really an internal error. return errors.NewInternalError(fmt.Errorf(\"failed to allocate a nodePort: %v\", err)) } <del> servicePort.NodePort = int32(nodePort) </del> <ins> servicePort.NodePort = int32(nodePortNumber) nodePort.NodePort = servicePort.NodePort </ins> } <del> // Detect duplicate node ports; this should have been caught by validation, so we panic if contains(newNodePorts, nodePort) { panic(\"duplicate node port\") </del> <ins> if containsNodePort(newNodePorts, nodePort) { return fmt.Errorf(\"duplicate nodePort: %v\", nodePort) </ins> } newNodePorts = append(newNodePorts, nodePort) } <ins> newNodePortsNumbers := CollectServiceNodePorts(newService) </ins> // The comparison loops are O(N^2), but we don't expect N to be huge // (there's a hard-limit at 2^16, because they're ports; and even 4 ports would be a lot) <del> for _, oldNodePort := range oldNodePorts { if contains(newNodePorts, oldNodePort) { </del> <ins> for _, oldNodePortNumber := range oldNodePortsNumbers { if containsNumber(newNodePortsNumbers, oldNodePortNumber) { </ins> continue } <del> nodePortOp.ReleaseDeferred(oldNodePort) </del> <ins> nodePortOp.ReleaseDeferred(int(oldNodePortNumber)) </ins> } return nil", "commid": "kubernetes_pr_49258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9088f0ead78b2fff04dd418b6ce000d4b309048b0554dcd7a11b323e0a89de4d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --BUG REPORT /kind bug What happened: I tried to submit a Service Replace () to the kube-apiserver and this results the kube-apiserver container crashing and restarting. PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenameWhat you expected to happen: I expected the server not to crash and to get validation errors if the request was invalid. How to reproduce it (as minimally and precisely as possible): Create a service, get the resourceVersion and clusterIP from the created resource GET localhost:8001/api/v1/namespaces/<namespace/services/<servicenameSubmit a replace command to PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenamewith body like If the same request is submitted with the nodePort fields in the ports array then the request succeeds. I get that I may be sending an invalid request without a node port (though shouldn't the merge deal with that?) but it shouldn't take down the API server. Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"6\", GitVersion:\"v1.6.3\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-05-10T23:29:08Z\", GoVersion:\"go1.8.1\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"8\", GitVersion:\"v1.8.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-10-11T23:16:41Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Bare metal cluster OS (e.g. from /etc/os-release): Ubuntu 16.04.3 LTS (Xenial Xerus) Kernel (e.g. ): 4.4.0-98-generic Install tools: Others:\nthanks for reporting this! Seems like this is similar to and should be fixed by . can you PTAL that PR to see if it's good to merge?\n/sig api-machinery\nDuplicate of", "positive_passages": [{"docid": "doc-en-kubernetes-b080d6c8f7b40cd77c4fd9ab1c835834f143899a755485c4b51a81d2e86e75b1", "text": "}, expectSpecifiedNodePorts: []int{}, }, <ins> { name: \"Add new ServicePort with a different protocol without changing port numbers\", oldService: &api.Service{ ObjectMeta: metav1.ObjectMeta{Name: \"foo\"}, Spec: api.ServiceSpec{ Selector:        map[string]string{\"bar\": \"baz\"}, SessionAffinity: api.ServiceAffinityNone, Type:            api.ServiceTypeNodePort, Ports: []api.ServicePort{ { Name:       \"port-tcp\", Port:       53, TargetPort: intstr.FromInt(6502), Protocol:   api.ProtocolTCP, NodePort:   30053, }, }, }, }, newService: &api.Service{ ObjectMeta: metav1.ObjectMeta{Name: \"foo\"}, Spec: api.ServiceSpec{ Selector:        map[string]string{\"bar\": \"baz\"}, SessionAffinity: api.ServiceAffinityNone, Type:            api.ServiceTypeNodePort, Ports: []api.ServicePort{ { Name:       \"port-tcp\", Port:       53, TargetPort: intstr.FromInt(6502), Protocol:   api.ProtocolTCP, NodePort:   30053, }, { Name:       \"port-udp\", Port:       53, TargetPort: intstr.FromInt(6502), Protocol:   api.ProtocolUDP, NodePort:   30053, }, }, }, }, expectSpecifiedNodePorts: []int{30053, 30053}, }, { name: \"Change service type from ClusterIP to NodePort with same NodePort number but different protocols\", oldService: &api.Service{ ObjectMeta: metav1.ObjectMeta{Name: \"foo\"}, Spec: api.ServiceSpec{ Selector:        map[string]string{\"bar\": \"baz\"}, SessionAffinity: api.ServiceAffinityNone, Type:            api.ServiceTypeClusterIP, Ports: []api.ServicePort{{ Port:       53, Protocol:   api.ProtocolTCP, TargetPort: intstr.FromInt(6502), }}, }, }, newService: &api.Service{ ObjectMeta: metav1.ObjectMeta{Name: \"foo\"}, Spec: api.ServiceSpec{ Selector:        map[string]string{\"bar\": \"baz\"}, SessionAffinity: api.ServiceAffinityNone, Type:            api.ServiceTypeNodePort, Ports: []api.ServicePort{ { Name:       \"port-tcp\", Port:       53, TargetPort: intstr.FromInt(6502), Protocol:   api.ProtocolTCP, NodePort:   30053, }, { Name:       \"port-udp\", Port:       53, TargetPort: intstr.FromInt(6502), Protocol:   api.ProtocolUDP, NodePort:   30053, }, }, }, }, expectSpecifiedNodePorts: []int{30053, 30053}, }, </ins> } for _, test := range testCases {", "commid": "kubernetes_pr_49258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9088f0ead78b2fff04dd418b6ce000d4b309048b0554dcd7a11b323e0a89de4d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --BUG REPORT /kind bug What happened: I tried to submit a Service Replace () to the kube-apiserver and this results the kube-apiserver container crashing and restarting. PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenameWhat you expected to happen: I expected the server not to crash and to get validation errors if the request was invalid. How to reproduce it (as minimally and precisely as possible): Create a service, get the resourceVersion and clusterIP from the created resource GET localhost:8001/api/v1/namespaces/<namespace/services/<servicenameSubmit a replace command to PUT localhost:8001/api/v1/namespaces/<namespace/services/<servicenamewith body like If the same request is submitted with the nodePort fields in the ports array then the request succeeds. I get that I may be sending an invalid request without a node port (though shouldn't the merge deal with that?) but it shouldn't take down the API server. Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"6\", GitVersion:\"v1.6.3\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-05-10T23:29:08Z\", GoVersion:\"go1.8.1\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"8\", GitVersion:\"v1.8.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-10-11T23:16:41Z\", GoVersion:\"go1.8.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Bare metal cluster OS (e.g. from /etc/os-release): Ubuntu 16.04.3 LTS (Xenial Xerus) Kernel (e.g. ): 4.4.0-98-generic Install tools: Others:\nthanks for reporting this! Seems like this is similar to and should be fixed by . can you PTAL that PR to see if it's good to merge?\n/sig api-machinery\nDuplicate of", "positive_passages": [{"docid": "doc-en-kubernetes-68258f10780a7f043c59edbd5a28e35ae37bf7063cee987a6ebd3f6f25e5914e", "text": "} }) <ins> It(\"should be able to update NodePorts with two same port numbers but different protocols\", func() { serviceName := \"nodeport-update-service\" ns := f.Namespace.Name jig := framework.NewServiceTestJig(cs, serviceName) By(\"creating a TCP service \" + serviceName + \" with type=ClusterIP in namespace \" + ns) tcpService := jig.CreateTCPServiceOrFail(ns, nil) defer func() { framework.Logf(\"Cleaning up the updating NodePorts test service\") err := cs.Core().Services(ns).Delete(serviceName, nil) Expect(err).NotTo(HaveOccurred()) }() jig.SanityCheckService(tcpService, v1.ServiceTypeClusterIP) svcPort := int(tcpService.Spec.Ports[0].Port) framework.Logf(\"service port TCP: %d\", svcPort) // Change the services to NodePort and add a UDP port. By(\"changing the TCP service to type=NodePort and add a UDP port\") newService := jig.UpdateServiceOrFail(ns, tcpService.Name, func(s *v1.Service) { s.Spec.Type = v1.ServiceTypeNodePort s.Spec.Ports = []v1.ServicePort{ { Name:     \"tcp-port\", Port:     80, Protocol: v1.ProtocolTCP, }, { Name:     \"udp-port\", Port:     80, Protocol: v1.ProtocolUDP, }, } }) jig.SanityCheckService(newService, v1.ServiceTypeNodePort) if len(newService.Spec.Ports) != 2 { framework.Failf(\"new service should have two Ports\") } for _, port := range newService.Spec.Ports { if port.NodePort == 0 { framework.Failf(\"new service failed to allocate NodePort for Port %s\", port.Name) } framework.Logf(\"new service allocates NodePort %d for Port %s\", port.NodePort, port.Name) } }) </ins> It(\"should be able to change the type from ExternalName to ClusterIP\", func() { serviceName := \"externalname-service\" ns := f.Namespace.Name", "commid": "kubernetes_pr_49258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c6165eb60d2fa6134ed892e253816858f4aa3ad29aca9e33f3237a292c078a05", "query": "When one of the aggregated API servers returns a different definition of an object than what the other servers return, the merged openapi schema may contain multiple identical copies of the object definition (they differ only in the name). Is this a BUG REPORT or FEATURE REQUEST?:BUG /kind bug What happened: After changing the definition of the RawExtension type in one of the aggregated API servers, the aggregator returned the following openapi schema (note that v2, v3 and _v4 are identical; don't mind the actual new definition of RawExtension - it's incorrect): What you expected to happen: The merged schema should only contain two different RawExtension object definitions instead of 4. Environment: Kubernetes version (use ):\n/sig api-machinery\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-0b36a9029f3b31cf1efb96380ec2757059ab5767488a7a2f6abd00e9303137a1", "text": "<ins> # How to become a contributor and submit your own code ## Contributor License Agreements We'd love to accept your patches! Before we can take them, we have to jump a couple of legal hurdles. Please fill out either the individual or corporate Contributor License Agreement (CLA). * If you are an individual writing original source code and you're sure you own the intellectual property, then you'll need to sign an [individual CLA](http://code.google.com/legal/individual-cla-v1.0.html). * If you work for a company that wants to allow you to contribute your work, then you'll need to sign a [corporate CLA](http://code.google.com/legal/corporate-cla-v1.0.html). Follow either of the two links above to access the appropriate CLA and instructions for how to sign and return it. Once we receive it, we'll be able to accept your pull requests. ## Contributing A Patch 1. Submit an issue describing your proposed change to the repo in question. 1. The repo owner will respond to your issue promptly. 1. If your proposed change is accepted, and you haven't already done so, sign a Contributor License Agreement (see details above). 1. Fork the desired repo, develop and test your code changes. 1. Submit a pull request. </ins>", "commid": "kubernetes_pr_22"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9a1238de1c4b0813e72eceedd9b4cbeef1b3d12bf0b7bc6fd41e77d11828f5e0", "query": "https://k8s- https://k8s- cc: /kind bug /priority failing-test\nThis is at least twice in a week we've had cross break due to a public method signature change not being brought to all platforms () We should do:\nI'm lost - the PR in question adds an argument and fixes the call-site - what is broken?\nAhh, I see.\nHow did that PR get through, if it is so obviously broken on Cross?\nCross build doesn't run 100% of the time as a pre-submit (because it takes so long), and it can't block. It's something sig-testing is tracking, but there isn't a quick fix yet.\nLooks like was skipped for that PR: \"pull-kubernetes-cross Skipped\" not sure why yet.\nCross runs when a file matching: changes, (which needs to be fixed, opening a test-infra issue to expand the regex), but also some files could have build tags without the file name matching () Additionally cross is not blocking (), the underlying bug should be fixed now though so once we get the fix in to k/k we can make it blocking when it does run.\nI find has already sent a PR. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-8cc9689b5dc657e0097753fb920670e6efd9c37715ee358d92867c1404cfe80f", "text": "return o.writeConfigFile() } <del> proxyServer, err := NewProxyServer(o.config, o.CleanupAndExit, o.CleanupIPVS, o.scheme, o.master) </del> <ins> proxyServer, err := NewProxyServer(o) </ins> if err != nil { return err }", "commid": "kubernetes_pr_56256"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9a1238de1c4b0813e72eceedd9b4cbeef1b3d12bf0b7bc6fd41e77d11828f5e0", "query": "https://k8s- https://k8s- cc: /kind bug /priority failing-test\nThis is at least twice in a week we've had cross break due to a public method signature change not being brought to all platforms () We should do:\nI'm lost - the PR in question adds an argument and fixes the call-site - what is broken?\nAhh, I see.\nHow did that PR get through, if it is so obviously broken on Cross?\nCross build doesn't run 100% of the time as a pre-submit (because it takes so long), and it can't block. It's something sig-testing is tracking, but there isn't a quick fix yet.\nLooks like was skipped for that PR: \"pull-kubernetes-cross Skipped\" not sure why yet.\nCross runs when a file matching: changes, (which needs to be fixed, opening a test-infra issue to expand the regex), but also some files could have build tags without the file name matching () Additionally cross is not blocking (), the underlying bug should be fixed now though so once we get the fix in to k/k we can make it blocking when it does run.\nI find has already sent a PR. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-56b980af3277d0c9d927e736c28859c9e3c0b5ac7f7164299deccf525dd35972", "text": ") // NewProxyServer returns a new ProxyServer. <del> func NewProxyServer(config *proxyconfigapi.KubeProxyConfiguration, cleanupAndExit bool, cleanupIPVS bool, scheme *runtime.Scheme, master string) (*ProxyServer, error) { </del> <ins> func NewProxyServer(o *Options) (*ProxyServer, error) { return newProxyServer(o.config, o.CleanupAndExit, o.CleanupIPVS, o.scheme, o.master) } func newProxyServer( config *proxyconfigapi.KubeProxyConfiguration, cleanupAndExit bool, cleanupIPVS bool, scheme *runtime.Scheme, master string) (*ProxyServer, error) { </ins> if config == nil { return nil, errors.New(\"config is required\") }", "commid": "kubernetes_pr_56256"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9a1238de1c4b0813e72eceedd9b4cbeef1b3d12bf0b7bc6fd41e77d11828f5e0", "query": "https://k8s- https://k8s- cc: /kind bug /priority failing-test\nThis is at least twice in a week we've had cross break due to a public method signature change not being brought to all platforms () We should do:\nI'm lost - the PR in question adds an argument and fixes the call-site - what is broken?\nAhh, I see.\nHow did that PR get through, if it is so obviously broken on Cross?\nCross build doesn't run 100% of the time as a pre-submit (because it takes so long), and it can't block. It's something sig-testing is tracking, but there isn't a quick fix yet.\nLooks like was skipped for that PR: \"pull-kubernetes-cross Skipped\" not sure why yet.\nCross runs when a file matching: changes, (which needs to be fixed, opening a test-infra issue to expand the regex), but also some files could have build tags without the file name matching () Additionally cross is not blocking (), the underlying bug should be fixed now though so once we get the fix in to k/k we can make it blocking when it does run.\nI find has already sent a PR. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-fd8bf1916df498e1b4b1cd970c1a65c816709d6c7a2417efd99c94f3262aab9d", "text": "} options.CleanupAndExit = true <del> proxyserver, err := NewProxyServer(options.config, options.CleanupAndExit, options.CleanupIPVS, options.scheme, options.master) </del> <ins> proxyserver, err := NewProxyServer(options) </ins> assert.Nil(t, err, \"unexpected error in NewProxyServer, addr: %s\", addr) assert.NotNil(t, proxyserver, \"nil proxy server obj, addr: %s\", addr)", "commid": "kubernetes_pr_56256"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9a1238de1c4b0813e72eceedd9b4cbeef1b3d12bf0b7bc6fd41e77d11828f5e0", "query": "https://k8s- https://k8s- cc: /kind bug /priority failing-test\nThis is at least twice in a week we've had cross break due to a public method signature change not being brought to all platforms () We should do:\nI'm lost - the PR in question adds an argument and fixes the call-site - what is broken?\nAhh, I see.\nHow did that PR get through, if it is so obviously broken on Cross?\nCross build doesn't run 100% of the time as a pre-submit (because it takes so long), and it can't block. It's something sig-testing is tracking, but there isn't a quick fix yet.\nLooks like was skipped for that PR: \"pull-kubernetes-cross Skipped\" not sure why yet.\nCross runs when a file matching: changes, (which needs to be fixed, opening a test-infra issue to expand the regex), but also some files could have build tags without the file name matching () Additionally cross is not blocking (), the underlying bug should be fixed now though so once we get the fix in to k/k we can make it blocking when it does run.\nI find has already sent a PR. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-3cbe17ac3c5a011f23555eb207e21a45d87f97885911bfdaebb3b32c0858347c", "text": ") // NewProxyServer returns a new ProxyServer. <del> func NewProxyServer(config *proxyconfigapi.KubeProxyConfiguration, cleanupAndExit bool, scheme *runtime.Scheme, master string) (*ProxyServer, error) { </del> <ins> func NewProxyServer(o *Options) (*ProxyServer, error) { return newProxyServer(o.config, o.CleanupAndExit, o.scheme, o.master) } func newProxyServer(config *proxyconfigapi.KubeProxyConfiguration, cleanupAndExit bool, scheme *runtime.Scheme, master string) (*ProxyServer, error) { </ins> if config == nil { return nil, errors.New(\"config is required\") }", "commid": "kubernetes_pr_56256"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-346125e2da6893c97c11617d4b86f3d67d99d614b263d3a1dde1fc0bab91d262", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When kube-apiserver's livenessProbe suggests that pod is unhealthy, kubelet tries to kill its container with 30 seconds grace period. The container is killed ungracefully with SIGKILL when grace period passes. This happens each time. What you expected to happen: I expected that SIGTERM will be passed to kube-apiserver which will try to gracefully stop before 30 seconds pass (at least in some cases). How to reproduce it (as minimally and precisely as possible): Inject kube-apiserver failure (e.g. ) Watch kubelet logs for container's death You will see that container is killed after 30 seconds each time Anything else we need to know?: I believe the problem is that in kube-apiserver.manifest uses '/bin/sh -c CMD' as a PID1 process which doesn't pass SIGTERM signals to child process. See Environment: Kubernetes version (use ): v1.7.11\n/sig node\nLooks like without the pipe command will have to be removed which will make the logs hard to track. There is indeed some which makes kube-apiserver run in background and trapping SIGTERM then send a SIGTERM to apiserver's PID.\nI think this is the case for all our components, not just kube-apiserver. - FYI\nHow about using 'exec'-based solution suggested here: In our case it means prepending 'exec': I did changed this in my cluster and the process seems to meet requirements: fd/1 and fd/2 are redirected to /var/log/kube- container is killed instantaneously If everyone is fine with such a solution, I can prepare PR adding 'exec ' in front of all kubernetes/cluster/saltbase/salt/kube-apiserver/*.manifest using '/bin/sh -c CMD' pattern.\nNot sure if understand what you mean. Before there was no logs, so /bin/sh -c wasn't needed. -based solution seems to have all required properties. What is your concern about using it?\nUmm. just ignore my previous comment. I just tried prepending and it works fine for me.", "positive_passages": [{"docid": "doc-en-kubernetes-744f0fded90d2ca194f6de479e3b39eb5bb79a95bc5038a665e626bd23cdad4d", "text": "\"command\": [ \"/bin/sh\", \"-c\", <del> \"if [ -e /usr/local/bin/migrate-if-needed.sh ]; then /usr/local/bin/migrate-if-needed.sh 1>>/var/log/etcd{{ suffix }}.log 2>&1; fi; /usr/local/bin/etcd --name etcd-{{ hostname }} --listen-peer-urls {{ etcd_protocol }}://{{ hostname }}:{{ server_port }} --initial-advertise-peer-urls {{ etcd_protocol }}://{{ hostname }}:{{ server_port }} --advertise-client-urls http://127.0.0.1:{{ port }} --listen-client-urls http://127.0.0.1:{{ port }} {{ quota_bytes }} --data-dir /var/etcd/data{{ suffix }} --initial-cluster-state {{ cluster_state }} --initial-cluster {{ etcd_cluster }} {{ etcd_creds }} 1>>/var/log/etcd{{ suffix }}.log 2>&1\" </del> <ins> \"if [ -e /usr/local/bin/migrate-if-needed.sh ]; then /usr/local/bin/migrate-if-needed.sh 1>>/var/log/etcd{{ suffix }}.log 2>&1; fi; exec /usr/local/bin/etcd --name etcd-{{ hostname }} --listen-peer-urls {{ etcd_protocol }}://{{ hostname }}:{{ server_port }} --initial-advertise-peer-urls {{ etcd_protocol }}://{{ hostname }}:{{ server_port }} --advertise-client-urls http://127.0.0.1:{{ port }} --listen-client-urls http://127.0.0.1:{{ port }} {{ quota_bytes }} --data-dir /var/etcd/data{{ suffix }} --initial-cluster-state {{ cluster_state }} --initial-cluster {{ etcd_cluster }} {{ etcd_creds }} 1>>/var/log/etcd{{ suffix }}.log 2>&1\" </ins> ], \"env\": [ { \"name\": \"TARGET_STORAGE\",", "commid": "kubernetes_pr_57756"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-346125e2da6893c97c11617d4b86f3d67d99d614b263d3a1dde1fc0bab91d262", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When kube-apiserver's livenessProbe suggests that pod is unhealthy, kubelet tries to kill its container with 30 seconds grace period. The container is killed ungracefully with SIGKILL when grace period passes. This happens each time. What you expected to happen: I expected that SIGTERM will be passed to kube-apiserver which will try to gracefully stop before 30 seconds pass (at least in some cases). How to reproduce it (as minimally and precisely as possible): Inject kube-apiserver failure (e.g. ) Watch kubelet logs for container's death You will see that container is killed after 30 seconds each time Anything else we need to know?: I believe the problem is that in kube-apiserver.manifest uses '/bin/sh -c CMD' as a PID1 process which doesn't pass SIGTERM signals to child process. See Environment: Kubernetes version (use ): v1.7.11\n/sig node\nLooks like without the pipe command will have to be removed which will make the logs hard to track. There is indeed some which makes kube-apiserver run in background and trapping SIGTERM then send a SIGTERM to apiserver's PID.\nI think this is the case for all our components, not just kube-apiserver. - FYI\nHow about using 'exec'-based solution suggested here: In our case it means prepending 'exec': I did changed this in my cluster and the process seems to meet requirements: fd/1 and fd/2 are redirected to /var/log/kube- container is killed instantaneously If everyone is fine with such a solution, I can prepare PR adding 'exec ' in front of all kubernetes/cluster/saltbase/salt/kube-apiserver/*.manifest using '/bin/sh -c CMD' pattern.\nNot sure if understand what you mean. Before there was no logs, so /bin/sh -c wasn't needed. -based solution seems to have all required properties. What is your concern about using it?\nUmm. just ignore my previous comment. I just tried prepending and it works fine for me.", "positive_passages": [{"docid": "doc-en-kubernetes-cf71883e258a2412e331a02bbe251905d2270f7f56b2e0a0e770b1f85130e04f", "text": "command: - /bin/bash - -c <del> - /opt/kube-addons.sh 1>>/var/log/kube-addon-manager.log 2>&1 </del> <ins> - exec /opt/kube-addons.sh 1>>/var/log/kube-addon-manager.log 2>&1 </ins> resources: requests: cpu: 5m", "commid": "kubernetes_pr_57756"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-346125e2da6893c97c11617d4b86f3d67d99d614b263d3a1dde1fc0bab91d262", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When kube-apiserver's livenessProbe suggests that pod is unhealthy, kubelet tries to kill its container with 30 seconds grace period. The container is killed ungracefully with SIGKILL when grace period passes. This happens each time. What you expected to happen: I expected that SIGTERM will be passed to kube-apiserver which will try to gracefully stop before 30 seconds pass (at least in some cases). How to reproduce it (as minimally and precisely as possible): Inject kube-apiserver failure (e.g. ) Watch kubelet logs for container's death You will see that container is killed after 30 seconds each time Anything else we need to know?: I believe the problem is that in kube-apiserver.manifest uses '/bin/sh -c CMD' as a PID1 process which doesn't pass SIGTERM signals to child process. See Environment: Kubernetes version (use ): v1.7.11\n/sig node\nLooks like without the pipe command will have to be removed which will make the logs hard to track. There is indeed some which makes kube-apiserver run in background and trapping SIGTERM then send a SIGTERM to apiserver's PID.\nI think this is the case for all our components, not just kube-apiserver. - FYI\nHow about using 'exec'-based solution suggested here: In our case it means prepending 'exec': I did changed this in my cluster and the process seems to meet requirements: fd/1 and fd/2 are redirected to /var/log/kube- container is killed instantaneously If everyone is fine with such a solution, I can prepare PR adding 'exec ' in front of all kubernetes/cluster/saltbase/salt/kube-apiserver/*.manifest using '/bin/sh -c CMD' pattern.\nNot sure if understand what you mean. Before there was no logs, so /bin/sh -c wasn't needed. -based solution seems to have all required properties. What is your concern about using it?\nUmm. just ignore my previous comment. I just tried prepending and it works fine for me.", "positive_passages": [{"docid": "doc-en-kubernetes-fc3af2581bb964259abdf4ed52f7d84dbcadf70129d54f5a1bca300dce9ccb11", "text": "\"command\": [ \"/bin/sh\", \"-c\", <del> \"/usr/local/bin/kube-apiserver {{params}} --allow-privileged={{pillar['allow_privileged']}} 1>>/var/log/kube-apiserver.log 2>&1\" </del> <ins> \"exec /usr/local/bin/kube-apiserver {{params}} --allow-privileged={{pillar['allow_privileged']}} 1>>/var/log/kube-apiserver.log 2>&1\" </ins> ], {{container_env}} \"livenessProbe\": {", "commid": "kubernetes_pr_57756"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-346125e2da6893c97c11617d4b86f3d67d99d614b263d3a1dde1fc0bab91d262", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When kube-apiserver's livenessProbe suggests that pod is unhealthy, kubelet tries to kill its container with 30 seconds grace period. The container is killed ungracefully with SIGKILL when grace period passes. This happens each time. What you expected to happen: I expected that SIGTERM will be passed to kube-apiserver which will try to gracefully stop before 30 seconds pass (at least in some cases). How to reproduce it (as minimally and precisely as possible): Inject kube-apiserver failure (e.g. ) Watch kubelet logs for container's death You will see that container is killed after 30 seconds each time Anything else we need to know?: I believe the problem is that in kube-apiserver.manifest uses '/bin/sh -c CMD' as a PID1 process which doesn't pass SIGTERM signals to child process. See Environment: Kubernetes version (use ): v1.7.11\n/sig node\nLooks like without the pipe command will have to be removed which will make the logs hard to track. There is indeed some which makes kube-apiserver run in background and trapping SIGTERM then send a SIGTERM to apiserver's PID.\nI think this is the case for all our components, not just kube-apiserver. - FYI\nHow about using 'exec'-based solution suggested here: In our case it means prepending 'exec': I did changed this in my cluster and the process seems to meet requirements: fd/1 and fd/2 are redirected to /var/log/kube- container is killed instantaneously If everyone is fine with such a solution, I can prepare PR adding 'exec ' in front of all kubernetes/cluster/saltbase/salt/kube-apiserver/*.manifest using '/bin/sh -c CMD' pattern.\nNot sure if understand what you mean. Before there was no logs, so /bin/sh -c wasn't needed. -based solution seems to have all required properties. What is your concern about using it?\nUmm. just ignore my previous comment. I just tried prepending and it works fine for me.", "positive_passages": [{"docid": "doc-en-kubernetes-ecfb08c588e1e4f605e8af7a4b7e09e84b90b41490bcea5f75f61b8991f6e453", "text": "\"command\": [ \"/bin/sh\", \"-c\", <del> \"/usr/local/bin/kube-controller-manager {{params}} 1>>/var/log/kube-controller-manager.log 2>&1\" </del> <ins> \"exec /usr/local/bin/kube-controller-manager {{params}} 1>>/var/log/kube-controller-manager.log 2>&1\" </ins> ], {{container_env}} \"livenessProbe\": {", "commid": "kubernetes_pr_57756"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-346125e2da6893c97c11617d4b86f3d67d99d614b263d3a1dde1fc0bab91d262", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When kube-apiserver's livenessProbe suggests that pod is unhealthy, kubelet tries to kill its container with 30 seconds grace period. The container is killed ungracefully with SIGKILL when grace period passes. This happens each time. What you expected to happen: I expected that SIGTERM will be passed to kube-apiserver which will try to gracefully stop before 30 seconds pass (at least in some cases). How to reproduce it (as minimally and precisely as possible): Inject kube-apiserver failure (e.g. ) Watch kubelet logs for container's death You will see that container is killed after 30 seconds each time Anything else we need to know?: I believe the problem is that in kube-apiserver.manifest uses '/bin/sh -c CMD' as a PID1 process which doesn't pass SIGTERM signals to child process. See Environment: Kubernetes version (use ): v1.7.11\n/sig node\nLooks like without the pipe command will have to be removed which will make the logs hard to track. There is indeed some which makes kube-apiserver run in background and trapping SIGTERM then send a SIGTERM to apiserver's PID.\nI think this is the case for all our components, not just kube-apiserver. - FYI\nHow about using 'exec'-based solution suggested here: In our case it means prepending 'exec': I did changed this in my cluster and the process seems to meet requirements: fd/1 and fd/2 are redirected to /var/log/kube- container is killed instantaneously If everyone is fine with such a solution, I can prepare PR adding 'exec ' in front of all kubernetes/cluster/saltbase/salt/kube-apiserver/*.manifest using '/bin/sh -c CMD' pattern.\nNot sure if understand what you mean. Before there was no logs, so /bin/sh -c wasn't needed. -based solution seems to have all required properties. What is your concern about using it?\nUmm. just ignore my previous comment. I just tried prepending and it works fine for me.", "positive_passages": [{"docid": "doc-en-kubernetes-bf68959bee023a7a2bbdfb8c2337dd302625ba3dd90aae157da14ea9e36ec4f6", "text": "command: - /bin/sh - -c <del> - kube-proxy {{api_servers_with_port}} {{kubeconfig}} {{cluster_cidr}} --resource-container=\"\" --oom-score-adj=-998 {{params}} 1>>/var/log/kube-proxy.log 2>&1 </del> <ins> - exec kube-proxy {{api_servers_with_port}} {{kubeconfig}} {{cluster_cidr}} --resource-container=\"\" --oom-score-adj=-998 {{params}} 1>>/var/log/kube-proxy.log 2>&1 </ins> {{container_env}} {{kube_cache_mutation_detector_env_name}} {{kube_cache_mutation_detector_env_value}}", "commid": "kubernetes_pr_57756"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-346125e2da6893c97c11617d4b86f3d67d99d614b263d3a1dde1fc0bab91d262", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When kube-apiserver's livenessProbe suggests that pod is unhealthy, kubelet tries to kill its container with 30 seconds grace period. The container is killed ungracefully with SIGKILL when grace period passes. This happens each time. What you expected to happen: I expected that SIGTERM will be passed to kube-apiserver which will try to gracefully stop before 30 seconds pass (at least in some cases). How to reproduce it (as minimally and precisely as possible): Inject kube-apiserver failure (e.g. ) Watch kubelet logs for container's death You will see that container is killed after 30 seconds each time Anything else we need to know?: I believe the problem is that in kube-apiserver.manifest uses '/bin/sh -c CMD' as a PID1 process which doesn't pass SIGTERM signals to child process. See Environment: Kubernetes version (use ): v1.7.11\n/sig node\nLooks like without the pipe command will have to be removed which will make the logs hard to track. There is indeed some which makes kube-apiserver run in background and trapping SIGTERM then send a SIGTERM to apiserver's PID.\nI think this is the case for all our components, not just kube-apiserver. - FYI\nHow about using 'exec'-based solution suggested here: In our case it means prepending 'exec': I did changed this in my cluster and the process seems to meet requirements: fd/1 and fd/2 are redirected to /var/log/kube- container is killed instantaneously If everyone is fine with such a solution, I can prepare PR adding 'exec ' in front of all kubernetes/cluster/saltbase/salt/kube-apiserver/*.manifest using '/bin/sh -c CMD' pattern.\nNot sure if understand what you mean. Before there was no logs, so /bin/sh -c wasn't needed. -based solution seems to have all required properties. What is your concern about using it?\nUmm. just ignore my previous comment. I just tried prepending and it works fine for me.", "positive_passages": [{"docid": "doc-en-kubernetes-3c9546a4f9e2e4801d7dcd42743f861fbca7866fd50fbe5b68ca32c5ae530cce", "text": "\"command\": [ \"/bin/sh\", \"-c\", <del> \"/usr/local/bin/kube-scheduler {{params}} 1>>/var/log/kube-scheduler.log 2>&1\" </del> <ins> \"exec /usr/local/bin/kube-scheduler {{params}} 1>>/var/log/kube-scheduler.log 2>&1\" </ins> ], \"livenessProbe\": { \"httpGet\": {", "commid": "kubernetes_pr_57756"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-346125e2da6893c97c11617d4b86f3d67d99d614b263d3a1dde1fc0bab91d262", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When kube-apiserver's livenessProbe suggests that pod is unhealthy, kubelet tries to kill its container with 30 seconds grace period. The container is killed ungracefully with SIGKILL when grace period passes. This happens each time. What you expected to happen: I expected that SIGTERM will be passed to kube-apiserver which will try to gracefully stop before 30 seconds pass (at least in some cases). How to reproduce it (as minimally and precisely as possible): Inject kube-apiserver failure (e.g. ) Watch kubelet logs for container's death You will see that container is killed after 30 seconds each time Anything else we need to know?: I believe the problem is that in kube-apiserver.manifest uses '/bin/sh -c CMD' as a PID1 process which doesn't pass SIGTERM signals to child process. See Environment: Kubernetes version (use ): v1.7.11\n/sig node\nLooks like without the pipe command will have to be removed which will make the logs hard to track. There is indeed some which makes kube-apiserver run in background and trapping SIGTERM then send a SIGTERM to apiserver's PID.\nI think this is the case for all our components, not just kube-apiserver. - FYI\nHow about using 'exec'-based solution suggested here: In our case it means prepending 'exec': I did changed this in my cluster and the process seems to meet requirements: fd/1 and fd/2 are redirected to /var/log/kube- container is killed instantaneously If everyone is fine with such a solution, I can prepare PR adding 'exec ' in front of all kubernetes/cluster/saltbase/salt/kube-apiserver/*.manifest using '/bin/sh -c CMD' pattern.\nNot sure if understand what you mean. Before there was no logs, so /bin/sh -c wasn't needed. -based solution seems to have all required properties. What is your concern about using it?\nUmm. just ignore my previous comment. I just tried prepending and it works fine for me.", "positive_passages": [{"docid": "doc-en-kubernetes-f7926838194f200df8d09d5e46a343b2d4318082d0103429f99b5f2828d5571c", "text": "# TODO: split this out into args when we no longer need to pipe stdout to a file #6428 - sh - -c <del> - '/glbc --verbose=true --apiserver-host=http://localhost:8080 --default-backend-service=kube-system/default-http-backend --sync-period=600s --running-in-cluster=false --use-real-cloud=true --config-file-path=/etc/gce.conf --healthz-port=8086 1>>/var/log/glbc.log 2>&1' </del> <ins> - 'exec /glbc --verbose=true --apiserver-host=http://localhost:8080 --default-backend-service=kube-system/default-http-backend --sync-period=600s --running-in-cluster=false --use-real-cloud=true --config-file-path=/etc/gce.conf --healthz-port=8086 1>>/var/log/glbc.log 2>&1' </ins> volumes: - hostPath: path: /etc/gce.conf", "commid": "kubernetes_pr_57756"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-346125e2da6893c97c11617d4b86f3d67d99d614b263d3a1dde1fc0bab91d262", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When kube-apiserver's livenessProbe suggests that pod is unhealthy, kubelet tries to kill its container with 30 seconds grace period. The container is killed ungracefully with SIGKILL when grace period passes. This happens each time. What you expected to happen: I expected that SIGTERM will be passed to kube-apiserver which will try to gracefully stop before 30 seconds pass (at least in some cases). How to reproduce it (as minimally and precisely as possible): Inject kube-apiserver failure (e.g. ) Watch kubelet logs for container's death You will see that container is killed after 30 seconds each time Anything else we need to know?: I believe the problem is that in kube-apiserver.manifest uses '/bin/sh -c CMD' as a PID1 process which doesn't pass SIGTERM signals to child process. See Environment: Kubernetes version (use ): v1.7.11\n/sig node\nLooks like without the pipe command will have to be removed which will make the logs hard to track. There is indeed some which makes kube-apiserver run in background and trapping SIGTERM then send a SIGTERM to apiserver's PID.\nI think this is the case for all our components, not just kube-apiserver. - FYI\nHow about using 'exec'-based solution suggested here: In our case it means prepending 'exec': I did changed this in my cluster and the process seems to meet requirements: fd/1 and fd/2 are redirected to /var/log/kube- container is killed instantaneously If everyone is fine with such a solution, I can prepare PR adding 'exec ' in front of all kubernetes/cluster/saltbase/salt/kube-apiserver/*.manifest using '/bin/sh -c CMD' pattern.\nNot sure if understand what you mean. Before there was no logs, so /bin/sh -c wasn't needed. -based solution seems to have all required properties. What is your concern about using it?\nUmm. just ignore my previous comment. I just tried prepending and it works fine for me.", "positive_passages": [{"docid": "doc-en-kubernetes-705fadbaa28812ad1789cbe6e02b7e123a08ced848d30799064babe17ba8aa4b", "text": "# TODO: split this out into args when we no longer need to pipe stdout to a file #6428 - sh - -c <del> - '/rescheduler --running-in-cluster=false 1>>/var/log/rescheduler.log 2>&1' </del> <ins> - 'exec /rescheduler --running-in-cluster=false 1>>/var/log/rescheduler.log 2>&1' </ins> volumes: - hostPath: path: /var/log/rescheduler.log", "commid": "kubernetes_pr_57756"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4acb7ecd05e9c199186dfb06debf6d91c0b60ed3707740e0351c00fb351b6646", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Now, benchmark test make docker as the only runtime. What you expected to happen: benchmark test should be generic to all CRI container runtimes Related to How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/area test /area node-e2e\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-4e5230f8b0f2f7aa213d913275ff1d851a84d56b1257fdc49e91745f7a709803", "text": "// Start starts resource collector and connects to the standalone Cadvisor pod // then repeatedly runs collectStats. func (r *ResourceCollector) Start() { <del> // Get the cgroup container names for kubelet and docker </del> <ins> // Get the cgroup container names for kubelet and runtime </ins> kubeletContainer, err := getContainerNameForProcess(kubeletProcessName, \"\") <del> dockerContainer, err := getContainerNameForProcess(dockerProcessName, dockerPidFile) </del> <ins> runtimeContainer, err := getContainerNameForProcess(framework.TestContext.ContainerRuntimeProcessName, framework.TestContext.ContainerRuntimePidFile) </ins> if err == nil { systemContainers = map[string]string{ stats.SystemContainerKubelet: kubeletContainer, <del> stats.SystemContainerRuntime: dockerContainer, </del> <ins> stats.SystemContainerRuntime: runtimeContainer, </ins> } } else { <del> framework.Failf(\"Failed to get docker container name in test-e2e-node resource collector.\") </del> <ins> framework.Failf(\"Failed to get runtime container name in test-e2e-node resource collector.\") </ins> } wait.Poll(1*time.Second, 1*time.Minute, func() (bool, error) {", "commid": "kubernetes_pr_58323"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4acb7ecd05e9c199186dfb06debf6d91c0b60ed3707740e0351c00fb351b6646", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Now, benchmark test make docker as the only runtime. What you expected to happen: benchmark test should be generic to all CRI container runtimes Related to How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/area test /area node-e2e\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-ed2336ec4fc2332a11321d29fbdf8e46c6020e276458a63130bbc783a2b60e6e", "text": "func formatResourceUsageStats(containerStats framework.ResourceUsagePerContainer) string { // Example output: // <del> // Resource usage for node \"e2e-test-foo-node-abcde\": // container        cpu(cores)  memory(MB) // \"/\"              0.363       2942.09 // \"/docker-daemon\" 0.088       521.80 // \"/kubelet\"       0.086       424.37 // \"/system\"        0.007       119.88 </del> <ins> // Resource usage: //container cpu(cores) memory_working_set(MB) memory_rss(MB) //\"kubelet\" 0.068      27.92                  15.43 //\"runtime\" 0.664      89.88                  68.13 </ins> buf := &bytes.Buffer{} w := tabwriter.NewWriter(buf, 1, 0, 1, ' ', 0) fmt.Fprintf(w, \"containertcpu(cores)tmemory_working_set(MB)tmemory_rss(MB)n\")", "commid": "kubernetes_pr_58323"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4acb7ecd05e9c199186dfb06debf6d91c0b60ed3707740e0351c00fb351b6646", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Now, benchmark test make docker as the only runtime. What you expected to happen: benchmark test should be generic to all CRI container runtimes Related to How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/area test /area node-e2e\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-d43a6e372ac61fe3b830521af8cbc0bd6cbfc9f28183de9fe0eca77c012d82a6", "text": "func formatCPUSummary(summary framework.ContainersCPUSummary) string { // Example output for a node (the percentiles may differ): <del> // CPU usage of containers on node \"e2e-test-foo-node-0vj7\": </del> <ins> // CPU usage of containers: </ins> // container        5th%  50th% 90th% 95th% // \"/\"              0.051 0.159 0.387 0.455 // \"/runtime        0.000 0.000 0.146 0.166", "commid": "kubernetes_pr_58323"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4acb7ecd05e9c199186dfb06debf6d91c0b60ed3707740e0351c00fb351b6646", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Now, benchmark test make docker as the only runtime. What you expected to happen: benchmark test should be generic to all CRI container runtimes Related to How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/area test /area node-e2e\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-621052aa95c06830c11c54b153ecae405d0997eaf5efead46f9d72d95b7a3711", "text": "return resourceSeries } <del> // Code for getting container name of docker, copied from pkg/kubelet/cm/container_manager_linux.go // since they are not exposed const ( kubeletProcessName    = \"kubelet\" dockerProcessName     = \"docker\" dockerPidFile         = \"/var/run/docker.pid\" containerdProcessName = \"docker-containerd\" containerdPidFile     = \"/run/docker/libcontainerd/docker-containerd.pid\" ) </del> <ins> const kubeletProcessName = \"kubelet\" </ins> func getPidsForProcess(name, pidFile string) ([]int, error) { if len(pidFile) > 0 {", "commid": "kubernetes_pr_58323"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1d61960bcc4b874029c504d8fec26e7edd4b95c6ded5d0f98e72ee2715d02acd", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Priority admission controller of mirror pods. This is an error and should be removed. What you expected to happen: Integer value of Priority should be populated by the admission controller. How to reproduce it (as minimally and precisely as possible): Create a static pod with PriorityClassName set. The created mirror pod will not get the integer value of priority. /sig scheduling xref\nwhat is the kubelet expected to do with a low priority static pod if it gets evicted?\nalso doesn't this mean a user can claim their pod is a mirror pod via an annotation and get it admitted with any priority they want?\nknows better about kubelet evictions, but in my opinion a static low priority pod should be evicted similar to other pods. Whether it makes sense for static pods to be low priority or not is a relevant question. I would say it doesn't make sense, but one might find a reason to have static low priority pod. Not really. This check effectively bypasses integer resolution of priority causing the priority of all those mirror pods to be considered zero. This if statement is wrong and should be removed.\nIt also bypasses the check that prevents the pod creator from setting an integer priority themselves. In any case, agree removing the bypass is good\nStatic pods that fail for any reason (eviction is just one) are not re-run. To avoid evictions entirely as a static pod, users can use the critical pod annotation.\n, it seems we just log error if creating mirror pod failed; refer to . Does it make sense?\nI am not sure I understand the question entirely. The mirror pod exists only to show the status of the static pod. If the mirror pod doesn't exist, the static pod should still function correctly. Since that is in , it will be retried periodically.\nThe scheduler dependent on mirror pods for resource usage :). If creating mirror pod failed (e.g. wrong priority class name), there'll be ping-pong between scheduler and kubelet: scheduler send pod to node, kubelet reject it. But we can-t just return error, kubelet can start in standalone mode.\nHowever critical pod annotation is ignored if pod priorities are in use.\nThis is not the case. See in your issue.\nHowever critical pod annotation is ignored if pod priorities are in use. the intent of pod priorities was to replace the critical pod annotation with something more principled. is that not how it was implemented?\nPriority replaces most of the functionality that the critical pod annotation provides. However, the critical pod annotation is still useful for static pods, as it can prevent kubelet evictions. But for all other use-cases, I agree that priority is a much better way to manage which workloads are run, and which remain pending. I am not sure if the scheduler translates a \"critical\" pod to a \"system-priority\" pod for scheduling purposes, but the kubelet still prevents the eviction of static critical pods as an escape hatch for important static pods which cannot tolerate kubelet evictions.\nWhy would that not be modeled as a system priority? I expected critical pod annotations to not be present once the priority feature was completed.\nI agree with this. do you think we should not evict static pods which are system priority, so that even users of static pods can move from using the critical pod annotation to use pod priority?\nI think Kubelet should not evict static system pods, but even with the current logic of eviction, if these Pods do not use more resources than requested, kubelet never evicts them as their priority is higher than other pods.\nI think as a best practice users that write static pod manifests should apply a system priority to prevent eviction, but I do not think the kubelet should do anything magical about that source.", "positive_passages": [{"docid": "doc-en-kubernetes-fa3c1bd5b33fc71e70d6415bc9d4a05d6f43a1ca79140319f04fb3def0f5fe6d", "text": "if !ok { return errors.NewBadRequest(\"resource was marked with kind Pod but was unable to be converted\") } <del> if _, isMirrorPod := pod.Annotations[api.MirrorPodAnnotationKey]; isMirrorPod { return nil } </del> // Make sure that the client has not set `priority` at the time of pod creation. if operation == admission.Create && pod.Spec.Priority != nil { return admission.NewForbidden(a, fmt.Errorf(\"the integer value of priority must not be provided in pod spec. Priority admission controller populates the value from the given PriorityClass name\"))", "commid": "kubernetes_pr_58485"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1d61960bcc4b874029c504d8fec26e7edd4b95c6ded5d0f98e72ee2715d02acd", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Priority admission controller of mirror pods. This is an error and should be removed. What you expected to happen: Integer value of Priority should be populated by the admission controller. How to reproduce it (as minimally and precisely as possible): Create a static pod with PriorityClassName set. The created mirror pod will not get the integer value of priority. /sig scheduling xref\nwhat is the kubelet expected to do with a low priority static pod if it gets evicted?\nalso doesn't this mean a user can claim their pod is a mirror pod via an annotation and get it admitted with any priority they want?\nknows better about kubelet evictions, but in my opinion a static low priority pod should be evicted similar to other pods. Whether it makes sense for static pods to be low priority or not is a relevant question. I would say it doesn't make sense, but one might find a reason to have static low priority pod. Not really. This check effectively bypasses integer resolution of priority causing the priority of all those mirror pods to be considered zero. This if statement is wrong and should be removed.\nIt also bypasses the check that prevents the pod creator from setting an integer priority themselves. In any case, agree removing the bypass is good\nStatic pods that fail for any reason (eviction is just one) are not re-run. To avoid evictions entirely as a static pod, users can use the critical pod annotation.\n, it seems we just log error if creating mirror pod failed; refer to . Does it make sense?\nI am not sure I understand the question entirely. The mirror pod exists only to show the status of the static pod. If the mirror pod doesn't exist, the static pod should still function correctly. Since that is in , it will be retried periodically.\nThe scheduler dependent on mirror pods for resource usage :). If creating mirror pod failed (e.g. wrong priority class name), there'll be ping-pong between scheduler and kubelet: scheduler send pod to node, kubelet reject it. But we can-t just return error, kubelet can start in standalone mode.\nHowever critical pod annotation is ignored if pod priorities are in use.\nThis is not the case. See in your issue.\nHowever critical pod annotation is ignored if pod priorities are in use. the intent of pod priorities was to replace the critical pod annotation with something more principled. is that not how it was implemented?\nPriority replaces most of the functionality that the critical pod annotation provides. However, the critical pod annotation is still useful for static pods, as it can prevent kubelet evictions. But for all other use-cases, I agree that priority is a much better way to manage which workloads are run, and which remain pending. I am not sure if the scheduler translates a \"critical\" pod to a \"system-priority\" pod for scheduling purposes, but the kubelet still prevents the eviction of static critical pods as an escape hatch for important static pods which cannot tolerate kubelet evictions.\nWhy would that not be modeled as a system priority? I expected critical pod annotations to not be present once the priority feature was completed.\nI agree with this. do you think we should not evict static pods which are system priority, so that even users of static pods can move from using the critical pod annotation to use pod priority?\nI think Kubelet should not evict static system pods, but even with the current logic of eviction, if these Pods do not use more resources than requested, kubelet never evicts them as their priority is higher than other pods.\nI think as a best practice users that write static pod manifests should apply a system priority to prevent eviction, but I do not think the kubelet should do anything magical about that source.", "positive_passages": [{"docid": "doc-en-kubernetes-f3aaec3f3d869fea32fc11dd5ec048cd031d43f7801679d580bd4f02efc9fd66", "text": "PriorityClassName: \"system-cluster-critical\", }, }, <ins> // pod[5]: mirror Pod with a system priority class name { ObjectMeta: metav1.ObjectMeta{ Name:        \"mirror-pod-w-system-priority\", Namespace:   \"namespace\", Annotations: map[string]string{api.MirrorPodAnnotationKey: \"\"}, }, Spec: api.PodSpec{ Containers: []api.Container{ { Name: containerName, }, }, PriorityClassName: \"system-cluster-critical\", }, }, // pod[6]: mirror Pod with integer value of priority { ObjectMeta: metav1.ObjectMeta{ Name:        \"mirror-pod-w-integer-priority\", Namespace:   \"namespace\", Annotations: map[string]string{api.MirrorPodAnnotationKey: \"\"}, }, Spec: api.PodSpec{ Containers: []api.Container{ { Name: containerName, }, }, PriorityClassName: \"default1\", Priority:          &intPriority, }, }, </ins> } // Enable PodPriority feature gate. utilfeature.DefaultFeatureGate.Set(fmt.Sprintf(\"%s=true\", features.PodPriority))", "commid": "kubernetes_pr_58485"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1d61960bcc4b874029c504d8fec26e7edd4b95c6ded5d0f98e72ee2715d02acd", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Priority admission controller of mirror pods. This is an error and should be removed. What you expected to happen: Integer value of Priority should be populated by the admission controller. How to reproduce it (as minimally and precisely as possible): Create a static pod with PriorityClassName set. The created mirror pod will not get the integer value of priority. /sig scheduling xref\nwhat is the kubelet expected to do with a low priority static pod if it gets evicted?\nalso doesn't this mean a user can claim their pod is a mirror pod via an annotation and get it admitted with any priority they want?\nknows better about kubelet evictions, but in my opinion a static low priority pod should be evicted similar to other pods. Whether it makes sense for static pods to be low priority or not is a relevant question. I would say it doesn't make sense, but one might find a reason to have static low priority pod. Not really. This check effectively bypasses integer resolution of priority causing the priority of all those mirror pods to be considered zero. This if statement is wrong and should be removed.\nIt also bypasses the check that prevents the pod creator from setting an integer priority themselves. In any case, agree removing the bypass is good\nStatic pods that fail for any reason (eviction is just one) are not re-run. To avoid evictions entirely as a static pod, users can use the critical pod annotation.\n, it seems we just log error if creating mirror pod failed; refer to . Does it make sense?\nI am not sure I understand the question entirely. The mirror pod exists only to show the status of the static pod. If the mirror pod doesn't exist, the static pod should still function correctly. Since that is in , it will be retried periodically.\nThe scheduler dependent on mirror pods for resource usage :). If creating mirror pod failed (e.g. wrong priority class name), there'll be ping-pong between scheduler and kubelet: scheduler send pod to node, kubelet reject it. But we can-t just return error, kubelet can start in standalone mode.\nHowever critical pod annotation is ignored if pod priorities are in use.\nThis is not the case. See in your issue.\nHowever critical pod annotation is ignored if pod priorities are in use. the intent of pod priorities was to replace the critical pod annotation with something more principled. is that not how it was implemented?\nPriority replaces most of the functionality that the critical pod annotation provides. However, the critical pod annotation is still useful for static pods, as it can prevent kubelet evictions. But for all other use-cases, I agree that priority is a much better way to manage which workloads are run, and which remain pending. I am not sure if the scheduler translates a \"critical\" pod to a \"system-priority\" pod for scheduling purposes, but the kubelet still prevents the eviction of static critical pods as an escape hatch for important static pods which cannot tolerate kubelet evictions.\nWhy would that not be modeled as a system priority? I expected critical pod annotations to not be present once the priority feature was completed.\nI agree with this. do you think we should not evict static pods which are system priority, so that even users of static pods can move from using the critical pod annotation to use pod priority?\nI think Kubelet should not evict static system pods, but even with the current logic of eviction, if these Pods do not use more resources than requested, kubelet never evicts them as their priority is higher than other pods.\nI think as a best practice users that write static pod manifests should apply a system priority to prevent eviction, but I do not think the kubelet should do anything magical about that source.", "positive_passages": [{"docid": "doc-en-kubernetes-980ea58bccd4952f09d3af4c4dce58a4713ecd3e14c219e73f0167c66b106b79", "text": "0, true, }, <ins> { \"mirror pod with system priority class\", []*scheduling.PriorityClass{}, *pods[5], SystemCriticalPriority, false, }, { \"mirror pod with integer priority\", []*scheduling.PriorityClass{}, *pods[6], 0, true, }, </ins> } for _, test := range tests {", "commid": "kubernetes_pr_58485"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9df8e5ba2e9f919d9bec92d550979c4e420a21d16e91da208714cd0aae742f47", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /assign What happened: The tests are failing again because the scheduler messages have changed yet again. I'm going to remove the check for the exact messages because this is at least the 3rd time this has happened. Instead depend on unit/integration tests to check for specific failures. Also there's no need for these tests to run across all types of local volumes because it's just testing the scheduler part.", "positive_passages": [{"docid": "doc-en-kubernetes-0c9ca3587e96b1c07d244c5c3cb19c0f04bc880c3d17e99c64514eb40c496eb2", "text": "} }) <ins> // TODO: move this under volumeType loop </ins> Context(\"when one pod requests one prebound PVC\", func() { var testVol *localTestVolume", "commid": "kubernetes_pr_59377"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9df8e5ba2e9f919d9bec92d550979c4e420a21d16e91da208714cd0aae742f47", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /assign What happened: The tests are failing again because the scheduler messages have changed yet again. I'm going to remove the check for the exact messages because this is at least the 3rd time this has happened. Instead depend on unit/integration tests to check for specific failures. Also there's no need for these tests to run across all types of local volumes because it's just testing the scheduler part.", "positive_passages": [{"docid": "doc-en-kubernetes-2da9c5047ff5958a2b240aa981775e40454a467efe67e42c43d9035ad7a47260", "text": "}) }) <del> Context(\"when pod using local volume with non-existant path\", func() { ep := &eventPatterns{ reason:  \"FailedMount\", pattern: make([]string, 2)} ep.pattern = append(ep.pattern, \"MountVolume.SetUp failed\") ep.pattern = append(ep.pattern, \"does not exist\") It(\"should not be able to mount\", func() { testVol := &localTestVolume{ node:            config.node0, hostDir:         \"/non-existent/location/nowhere\", localVolumeType: testVolType, } By(\"Creating local PVC and PV\") createLocalPVCsPVs(config, []*localTestVolume{testVol}, testMode) pod, err := createLocalPod(config, testVol) Expect(err).To(HaveOccurred()) checkPodEvents(config, pod.Name, ep) verifyLocalVolume(config, testVol) cleanupLocalPVCsPVs(config, []*localTestVolume{testVol}) }) }) </del> <ins> }) } </ins> <del> Context(\"when pod's node is different from PV's NodeAffinity\", func() { </del> <ins> Context(\"when local volume cannot be mounted [Slow]\", func() { // TODO: // - make the pod create timeout shorter // - check for these errors in unit tests intead It(\"should fail mount due to non-existant path\", func() { ep := &eventPatterns{ reason:  \"FailedMount\", pattern: make([]string, 2)} ep.pattern = append(ep.pattern, \"MountVolume.SetUp failed\") ep.pattern = append(ep.pattern, \"does not exist\") testVol := &localTestVolume{ node:            config.node0, hostDir:         \"/non-existent/location/nowhere\", localVolumeType: DirectoryLocalVolumeType, } By(\"Creating local PVC and PV\") createLocalPVCsPVs(config, []*localTestVolume{testVol}, immediateMode) pod, err := createLocalPod(config, testVol) Expect(err).To(HaveOccurred()) checkPodEvents(config, pod.Name, ep) verifyLocalVolume(config, testVol) cleanupLocalPVCsPVs(config, []*localTestVolume{testVol}) }) </ins> <del> BeforeEach(func() { if len(config.nodes) < 2 { framework.Skipf(\"Runs only when number of nodes >= 2\") } }) </del> <ins> It(\"should fail mount due to wrong node\", func() { if len(config.nodes) < 2 { framework.Skipf(\"Runs only when number of nodes >= 2\") } </ins> <del> ep := &eventPatterns{ reason:  \"FailedScheduling\", pattern: make([]string, 2)} ep.pattern = append(ep.pattern, \"MatchNodeSelector\") ep.pattern = append(ep.pattern, \"VolumeNodeAffinityConflict\") </del> <ins> ep := &eventPatterns{ reason:  \"FailedMount\", pattern: make([]string, 2)} ep.pattern = append(ep.pattern, \"NodeSelectorTerm\") ep.pattern = append(ep.pattern, \"MountVolume.NodeAffinity check failed\") </ins> <del> It(\"should not be able to mount due to different NodeAffinity\", func() { testPodWithNodeName(config, testVolType, ep, config.nodes[1].Name, makeLocalPodWithNodeAffinity, testMode) }) </del> <ins> testVols := setupLocalVolumesPVCsPVs(config, DirectoryLocalVolumeType, config.node0, 1, immediateMode) testVol := testVols[0] </ins> <del> It(\"should not be able to mount due to different NodeSelector\", func() { testPodWithNodeName(config, testVolType, ep, config.nodes[1].Name, makeLocalPodWithNodeSelector, testMode) }) </del> <ins> pod := makeLocalPodWithNodeName(config, testVol, config.nodes[1].Name) pod, err := config.client.CoreV1().Pods(config.ns).Create(pod) Expect(err).NotTo(HaveOccurred()) </ins> <del> }) </del> <ins> err = framework.WaitForPodNameRunningInNamespace(config.client, pod.Name, pod.Namespace) Expect(err).To(HaveOccurred()) checkPodEvents(config, pod.Name, ep) </ins> <del> Context(\"when pod's node is different from PV's NodeName\", func() { </del> <ins> cleanupLocalVolumes(config, []*localTestVolume{testVol}) }) }) </ins> <del> BeforeEach(func() { if len(config.nodes) < 2 { framework.Skipf(\"Runs only when number of nodes >= 2\") } }) </del> <ins> Context(\"when pod's node is different from PV's NodeAffinity\", func() { var ( testVol    *localTestVolume volumeType localVolumeType ) BeforeEach(func() { if len(config.nodes) < 2 { framework.Skipf(\"Runs only when number of nodes >= 2\") } </ins> <del> ep := &eventPatterns{ reason:  \"FailedMount\", pattern: make([]string, 2)} ep.pattern = append(ep.pattern, \"NodeSelectorTerm\") ep.pattern = append(ep.pattern, \"MountVolume.NodeAffinity check failed\") </del> <ins> volumeType = DirectoryLocalVolumeType setupStorageClass(config, &immediateMode) testVols := setupLocalVolumesPVCsPVs(config, volumeType, config.node0, 1, immediateMode) testVol = testVols[0] }) </ins> <del> It(\"should not be able to mount due to different NodeName\", func() { testPodWithNodeName(config, testVolType, ep, config.nodes[1].Name, makeLocalPodWithNodeName, testMode) }) }) </del> <ins> AfterEach(func() { cleanupLocalVolumes(config, []*localTestVolume{testVol}) cleanupStorageClass(config) </ins> }) <del> } </del> <ins> It(\"should not be able to mount due to different NodeAffinity\", func() { testPodWithNodeConflict(config, volumeType, config.nodes[1].Name, makeLocalPodWithNodeAffinity, immediateMode) }) It(\"should not be able to mount due to different NodeSelector\", func() { testPodWithNodeConflict(config, volumeType, config.nodes[1].Name, makeLocalPodWithNodeSelector, immediateMode) }) }) </ins> Context(\"when using local volume provisioner\", func() { var volumePath string", "commid": "kubernetes_pr_59377"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9df8e5ba2e9f919d9bec92d550979c4e420a21d16e91da208714cd0aae742f47", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /assign What happened: The tests are failing again because the scheduler messages have changed yet again. I'm going to remove the check for the exact messages because this is at least the 3rd time this has happened. Instead depend on unit/integration tests to check for specific failures. Also there's no need for these tests to run across all types of local volumes because it's just testing the scheduler part.", "positive_passages": [{"docid": "doc-en-kubernetes-b07e5ca3940ab5bb2ddab3cc773f24bc154e7bcd3673df915d8e6214a2d41179", "text": "type makeLocalPodWith func(config *localTestConfig, volume *localTestVolume, nodeName string) *v1.Pod <del> func testPodWithNodeName(config *localTestConfig, testVolType localVolumeType, ep *eventPatterns, nodeName string, makeLocalPodFunc makeLocalPodWith, bindingMode storagev1.VolumeBindingMode) { </del> <ins> func testPodWithNodeConflict(config *localTestConfig, testVolType localVolumeType, nodeName string, makeLocalPodFunc makeLocalPodWith, bindingMode storagev1.VolumeBindingMode) { </ins> By(fmt.Sprintf(\"local-volume-type: %s\", testVolType)) testVols := setupLocalVolumesPVCsPVs(config, testVolType, config.node0, 1, bindingMode) testVol := testVols[0]", "commid": "kubernetes_pr_59377"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9df8e5ba2e9f919d9bec92d550979c4e420a21d16e91da208714cd0aae742f47", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /assign What happened: The tests are failing again because the scheduler messages have changed yet again. I'm going to remove the check for the exact messages because this is at least the 3rd time this has happened. Instead depend on unit/integration tests to check for specific failures. Also there's no need for these tests to run across all types of local volumes because it's just testing the scheduler part.", "positive_passages": [{"docid": "doc-en-kubernetes-2001ed9cebd868a45b35804b626f643da85b11a5a8a1c9ebfaa9bd104d7937b7", "text": "pod := makeLocalPodFunc(config, testVol, nodeName) pod, err := config.client.CoreV1().Pods(config.ns).Create(pod) Expect(err).NotTo(HaveOccurred()) <del> err = framework.WaitForPodRunningInNamespace(config.client, pod) Expect(err).To(HaveOccurred()) checkPodEvents(config, pod.Name, ep) </del> <ins> err = framework.WaitForPodNameUnschedulableInNamespace(config.client, pod.Name, pod.Namespace) Expect(err).NotTo(HaveOccurred()) </ins> cleanupLocalVolumes(config, []*localTestVolume{testVol}) }", "commid": "kubernetes_pr_59377"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a3d500050110fa46acb05ec5be5def924145d5dad82bb32c3fe8d00d1dd85a4d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: I tried to use pvs provisioned by the cephfs storageclass build from PV and pvc are OK but it failed when mounting. here is the output of the ceph-fuse mount command: I try the ceph-fuse mounting outside kubernetes environment, and found that I have to pass the --id argument to make ceph-fuse work correctly: so I add the --id option in file on line 401: and cephfs volumes can mount corretly with ceph-fuse then. Anything else we need to know?: My kubernetes cluster version is v1.6.7, running on arm64 servers, with ceph version 10.1.2, the kernel version is 4.4.58 . I backported the latest version to mount cephfs volumes with ceph-fuse.\n/sig storage\nDoes this problem still exist in the latest k8s version?\nyes, I've tested on kubernetes v1.10.0-alpha.3 with ceph version 10.2.10 and the problem still exists\nOK, let me see it ,and feedback soon. =)\nHi, one question is that do you use 'admin' as user or other user to mount cephfs by fuse ?\nwhen no \"--id\" specified, the default user is admin, which will result in bug when user is not admin.\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-dafe23ea2f65b107cb022770a1c171fa1f8b017fd10f7527e0a09cd1ae1941e2", "text": "mountArgs = append(mountArgs, mountpoint) mountArgs = append(mountArgs, \"-r\") mountArgs = append(mountArgs, cephfsVolume.path) <ins> mountArgs = append(mountArgs, \"--id\") mountArgs = append(mountArgs, cephfsVolume.id) </ins> glog.V(4).Infof(\"Mounting cmd ceph-fuse with arguments (%s)\", mountArgs) command := exec.Command(\"ceph-fuse\", mountArgs...)", "commid": "kubernetes_pr_61804"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b9858e0baaee4f0ad9651e6053a4173caa66ca467e51b54e6d1c9d78936f9530", "query": "/kind test-flake https://k8s-\n/kind flake\ncc\nSaw this on\nSorry, I haven't had time to look into this. Let's see if can get to this earlier than I do.\nI'm seeing this a lot in the rush to code freeze.\nif this is actually a 1.10 bug, can you add status/approved-for-milestone to it? Thanks.\nSomething suspicious from the , but probably it's not related to the failure:\nThe garbage collector's behavior looks right, it does delete the dependent configmap: The tested start at 16:44:27., and failed with \"test timed out after 5m0s\" at 16:44:50.. I'll check if other failed cases have the same causes.\nThe \"Kubernetes Aggregated Failures\" shows there is no \"TestCRDDeletionCascading\" failure in the last tests (). Maybe I used the wrong tool? cc\ncc because triage does not support pull-kubernetes-unit? I cannot find in as well\ngave a new failure sample: https://k8s- (And the triage dashboard can't find it). Anyway, the test showed similar behavior. The tested started at I0226 20:57:02.. The gc behaved correctly: And the 5min timeout occurred 23s after the test began. I'll check what's the 5min timeout for.\nThe 5 min timeout is for all the tests in the test/integration/garbagecollector package. The tests are run sequentially, so is the last one to run, and unfortunately uses up the 5 min quota. The two logs I looked into showed the test itself was healthy. We just need to increase the timeout limit for this package.\nfound a lot of failure samples here: https://k8s- The first 11 of them failed because the 5m timeout.\nIndicates this is still present and severe.\nI was trying to get recent failures, it seems we recently moved intergration tests out of the unit test suites, https://k8s-, where there is no failure yet. I'll try again tomorrow.\n(we rename the job this afternoon, it was named kubernetes-unit but only runs integration test)\nhttps://k8s- that looks all green so far\nCan we also check run time of the tests in that package over the past couple weeks? It seems like this just spiked. Did our tests slow down, or did we add tests to that package?\nas far as I can tell the runtime of the test didn't spike ( shows the test running in just over 300s and also included the original bump of the timeout from 300s to 600s), but the timeout was accidentally decreased from 600s back to 300s as an unintended side effect of\nah, ok\nSince it has passed the last 26 times, is this safe to reclose?\n/close", "positive_passages": [{"docid": "doc-en-kubernetes-9c8754dcd56b90b115cc0f8238fe8c038f38d7d71e898258e37de7a3c607e6d5", "text": "export ARTIFACTS_DIR=${WORKSPACE}/artifacts # Save the verbose stdout as well. export KUBE_KEEP_VERBOSE_TEST_OUTPUT=y <del> export KUBE_TIMEOUT='-timeout 300s' </del> export KUBE_INTEGRATION_TEST_MAX_CONCURRENCY=4 export LOG_LEVEL=4", "commid": "kubernetes_pr_60458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fba186c8bcf8192fecd39603df79086034a841b1628e75fdd3294455f8cd9fd2", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: Bug Report /kind bug What happened: This is related to I am trying to integrate Cloud Foundry UAA () with kubernetes using the OIDC flow and the JWT validation is failing on the kubernetes side with an error of emailverified is required. emailverified is not a required claim in the OIDC core spec From a security point of view emailverified is useful when Self Service is enabled which is true of internet identity providers User Provisioning workflow in almost all cases is admin driven and not self service and emailverified becomes an obsolete claim. With things as they stand today, this flow is not conducive to Enterprise Identity Providers. What you expected to happen: Authentication should succeeed How to reproduce it (as minimally and precisely as possible): Pass a JWT which is missing email_verified claim using the OIDC flow into kubernetes Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"9\", GitVersion:\"v1.9.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-12-16T03:15:38Z\", GoVersion:\"go1.9.2\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's not marked optional either, which was the original motivation for taking the safe route and assuming false if it wasn't provided. This would be a feature for us to detect the presence of the claim and act differently if it isn't there. Do any other providers do this? Almost all that I've worked with do support this claim.\nHi , Enterprise providers like ADFS , Okta don't support this as part of the user schema. There is the concept of whether a use is active/enabled which is not the same as email verified always. If a user is not active, a token should not be minted in the first place. I am trying to understand what additional security does email_verified provided in the context of entire identity providers where there is no self self service use creation. Thanks, Sree\nOkta supports , but it looks like ADFS doesn't: We don't know when the provider is self-service or not. Not assuming makes the client logic uniform and less error prone instead of trying to reason about the intent of the provider. There's some discussion when we enabled this validation, including some UAA notes. , specifically\nMore than 80% of the enterprise customers of Cloud Foundry are using either AD/ADFS . This becomes a breaking change. UAA can add a email_verified claim. However its going to be of little value if the underlying AD doesn't propagate that. My two cents is this check doesn't make sense in an enterprise set up\nhas agreed to take this (can't assign her because she's not part of the org) /sig auth /kind feature /milestone v1.11 /priority important-longterm /status approved-for-milestone\n[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Escalate to the issue owners; move out of the milestone after 1 attempt. : New functionality. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-4494f7379ee41113840627169a8110fe566c020fd93e9e9ddfdcd6f0e45c53d0", "text": "} if a.usernameClaim == \"email\" { <del> // Check the email_verified claim to ensure the email is valid. </del> <ins> // If the email_verified claim is present, ensure the email is valid. </ins> // https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims <del> var emailVerified bool if err := c.unmarshalClaim(\"email_verified\", &emailVerified); err != nil { return nil, false, fmt.Errorf(\"oidc: parse 'email_verified' claim: %v\", err) } if !emailVerified { return nil, false, fmt.Errorf(\"oidc: email not verified\") </del> <ins> if hasEmailVerified := c.hasClaim(\"email_verified\"); hasEmailVerified { var emailVerified bool if err := c.unmarshalClaim(\"email_verified\", &emailVerified); err != nil { return nil, false, fmt.Errorf(\"oidc: parse 'email_verified' claim: %v\", err) } // If the email_verified claim is present we have to verify it is set to `true`. if !emailVerified { return nil, false, fmt.Errorf(\"oidc: email not verified\") } </ins> } }", "commid": "kubernetes_pr_61508"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fba186c8bcf8192fecd39603df79086034a841b1628e75fdd3294455f8cd9fd2", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: Bug Report /kind bug What happened: This is related to I am trying to integrate Cloud Foundry UAA () with kubernetes using the OIDC flow and the JWT validation is failing on the kubernetes side with an error of emailverified is required. emailverified is not a required claim in the OIDC core spec From a security point of view emailverified is useful when Self Service is enabled which is true of internet identity providers User Provisioning workflow in almost all cases is admin driven and not self service and emailverified becomes an obsolete claim. With things as they stand today, this flow is not conducive to Enterprise Identity Providers. What you expected to happen: Authentication should succeeed How to reproduce it (as minimally and precisely as possible): Pass a JWT which is missing email_verified claim using the OIDC flow into kubernetes Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"9\", GitVersion:\"v1.9.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-12-16T03:15:38Z\", GoVersion:\"go1.9.2\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's not marked optional either, which was the original motivation for taking the safe route and assuming false if it wasn't provided. This would be a feature for us to detect the presence of the claim and act differently if it isn't there. Do any other providers do this? Almost all that I've worked with do support this claim.\nHi , Enterprise providers like ADFS , Okta don't support this as part of the user schema. There is the concept of whether a use is active/enabled which is not the same as email verified always. If a user is not active, a token should not be minted in the first place. I am trying to understand what additional security does email_verified provided in the context of entire identity providers where there is no self self service use creation. Thanks, Sree\nOkta supports , but it looks like ADFS doesn't: We don't know when the provider is self-service or not. Not assuming makes the client logic uniform and less error prone instead of trying to reason about the intent of the provider. There's some discussion when we enabled this validation, including some UAA notes. , specifically\nMore than 80% of the enterprise customers of Cloud Foundry are using either AD/ADFS . This becomes a breaking change. UAA can add a email_verified claim. However its going to be of little value if the underlying AD doesn't propagate that. My two cents is this check doesn't make sense in an enterprise set up\nhas agreed to take this (can't assign her because she's not part of the org) /sig auth /kind feature /milestone v1.11 /priority important-longterm /status approved-for-milestone\n[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Escalate to the issue owners; move out of the milestone after 1 attempt. : New functionality. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-c9c5ae89ad1ba4f378086a2862693ffddae5e1eec062fab705a9e8d50a247895", "text": "} return json.Unmarshal([]byte(val), v) } <ins> func (c claims) hasClaim(name string) bool { if _, ok := c[name]; !ok { return false } return true } </ins>", "commid": "kubernetes_pr_61508"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fba186c8bcf8192fecd39603df79086034a841b1628e75fdd3294455f8cd9fd2", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: Bug Report /kind bug What happened: This is related to I am trying to integrate Cloud Foundry UAA () with kubernetes using the OIDC flow and the JWT validation is failing on the kubernetes side with an error of emailverified is required. emailverified is not a required claim in the OIDC core spec From a security point of view emailverified is useful when Self Service is enabled which is true of internet identity providers User Provisioning workflow in almost all cases is admin driven and not self service and emailverified becomes an obsolete claim. With things as they stand today, this flow is not conducive to Enterprise Identity Providers. What you expected to happen: Authentication should succeeed How to reproduce it (as minimally and precisely as possible): Pass a JWT which is missing email_verified claim using the OIDC flow into kubernetes Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"9\", GitVersion:\"v1.9.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-12-16T03:15:38Z\", GoVersion:\"go1.9.2\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's not marked optional either, which was the original motivation for taking the safe route and assuming false if it wasn't provided. This would be a feature for us to detect the presence of the claim and act differently if it isn't there. Do any other providers do this? Almost all that I've worked with do support this claim.\nHi , Enterprise providers like ADFS , Okta don't support this as part of the user schema. There is the concept of whether a use is active/enabled which is not the same as email verified always. If a user is not active, a token should not be minted in the first place. I am trying to understand what additional security does email_verified provided in the context of entire identity providers where there is no self self service use creation. Thanks, Sree\nOkta supports , but it looks like ADFS doesn't: We don't know when the provider is self-service or not. Not assuming makes the client logic uniform and less error prone instead of trying to reason about the intent of the provider. There's some discussion when we enabled this validation, including some UAA notes. , specifically\nMore than 80% of the enterprise customers of Cloud Foundry are using either AD/ADFS . This becomes a breaking change. UAA can add a email_verified claim. However its going to be of little value if the underlying AD doesn't propagate that. My two cents is this check doesn't make sense in an enterprise set up\nhas agreed to take this (can't assign her because she's not part of the org) /sig auth /kind feature /milestone v1.11 /priority important-longterm /status approved-for-milestone\n[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Escalate to the issue owners; move out of the milestone after 1 attempt. : New functionality. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-e51e1989d6bd054eafa95d209e56244f06a870bfdd41bc115c9b99088f4a20c3", "text": "wantErr: true, }, { <del> // If \"email_verified\" isn't present, assume false </del> <ins> // If \"email_verified\" isn't present, assume true </ins> name: \"no-email-verified-claim\", options: Options{ IssuerURL:     \"https://auth.example.com\",", "commid": "kubernetes_pr_61508"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fba186c8bcf8192fecd39603df79086034a841b1628e75fdd3294455f8cd9fd2", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: Bug Report /kind bug What happened: This is related to I am trying to integrate Cloud Foundry UAA () with kubernetes using the OIDC flow and the JWT validation is failing on the kubernetes side with an error of emailverified is required. emailverified is not a required claim in the OIDC core spec From a security point of view emailverified is useful when Self Service is enabled which is true of internet identity providers User Provisioning workflow in almost all cases is admin driven and not self service and emailverified becomes an obsolete claim. With things as they stand today, this flow is not conducive to Enterprise Identity Providers. What you expected to happen: Authentication should succeeed How to reproduce it (as minimally and precisely as possible): Pass a JWT which is missing email_verified claim using the OIDC flow into kubernetes Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"9\", GitVersion:\"v1.9.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2017-12-16T03:15:38Z\", GoVersion:\"go1.9.2\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's not marked optional either, which was the original motivation for taking the safe route and assuming false if it wasn't provided. This would be a feature for us to detect the presence of the claim and act differently if it isn't there. Do any other providers do this? Almost all that I've worked with do support this claim.\nHi , Enterprise providers like ADFS , Okta don't support this as part of the user schema. There is the concept of whether a use is active/enabled which is not the same as email verified always. If a user is not active, a token should not be minted in the first place. I am trying to understand what additional security does email_verified provided in the context of entire identity providers where there is no self self service use creation. Thanks, Sree\nOkta supports , but it looks like ADFS doesn't: We don't know when the provider is self-service or not. Not assuming makes the client logic uniform and less error prone instead of trying to reason about the intent of the provider. There's some discussion when we enabled this validation, including some UAA notes. , specifically\nMore than 80% of the enterprise customers of Cloud Foundry are using either AD/ADFS . This becomes a breaking change. UAA can add a email_verified claim. However its going to be of little value if the underlying AD doesn't propagate that. My two cents is this check doesn't make sense in an enterprise set up\nhas agreed to take this (can't assign her because she's not part of the org) /sig auth /kind feature /milestone v1.11 /priority important-longterm /status approved-for-milestone\n[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Escalate to the issue owners; move out of the milestone after 1 attempt. : New functionality. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-b8cf9787e6d2de45ad3f73e95f2e9eaab836a15db7d982201c9c9d079a887fe7", "text": "\"email\": \"jane@example.com\", \"exp\": %d }`, valid.Unix()), <ins> want: &user.DefaultInfo{ Name: \"jane@example.com\", }, }, { name: \"invalid-email-verified-claim\", options: Options{ IssuerURL:     \"https://auth.example.com\", ClientID:      \"my-client\", UsernameClaim: \"email\", now:           func() time.Time { return now }, }, signingKey: loadRSAPrivKey(t, \"testdata/rsa_1.pem\", jose.RS256), pubKeys: []*jose.JSONWebKey{ loadRSAKey(t, \"testdata/rsa_1.pem\", jose.RS256), }, // string value for \"email_verified\" claims: fmt.Sprintf(`{ \"iss\": \"https://auth.example.com\", \"aud\": \"my-client\", \"email\": \"jane@example.com\", \"email_verified\": \"false\", \"exp\": %d }`, valid.Unix()), </ins> wantErr: true, }, {", "commid": "kubernetes_pr_61508"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f2af98395fc32c90692404f5842866454ad062b03995abe94159620d2df7dd0a", "query": "Is this a BUG REPORT or FEATURE REQUEST?: What happened: docs recommend using '--leader-elect' to have HA setup for kube-scheduler and kube-controller-manager. However, these two components approach differently what is default value for the flag. . . Seems that setting the value to true in kube-scheduler code was lost in refactoring scheduler API config in . The code before refactoring had the value . What you expected to happen: kube-scheduler set true as a default value for '--leader-elect' Environment:\nnot sure I picked right SIG\n/sig api-machinery\n/assign\n/sig scheduling", "positive_passages": [{"docid": "doc-en-kubernetes-b7c2218e62967fe1c4513ccb70443824d9e391160e1b20020cf1ab0f61556891", "text": "return nil, err } <ins> // TODO: we should fix this up better (PR 59732) o.config.LeaderElection.LeaderElect = true </ins> return o, nil }", "commid": "kubernetes_pr_60524"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2f1261686a24e9a9b8cb41f2d352702bfa4eaf05fdd39b4b9e9d7a090314c871", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig azure\nadding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-c8f3d297b5605611c738f7c8279d5f63fa7aa948f6cd50931afc9f571a2c173e", "text": "import ( \"context\" \"fmt\" <ins> \"os\" \"strings\" </ins> \"k8s.io/api/core/v1\" \"k8s.io/kubernetes/pkg/cloudprovider\"", "commid": "kubernetes_pr_59857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2f1261686a24e9a9b8cb41f2d352702bfa4eaf05fdd39b4b9e9d7a090314c871", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig azure\nadding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-80d3a35b5338dff690a5df11f51dde0e1b57419a3860775deb5e64ee8cea5082", "text": "func (az *Cloud) isCurrentInstance(name types.NodeName) (bool, error) { nodeName := mapNodeNameToVMName(name) metadataName, err := az.metadata.Text(\"instance/compute/name\") <ins> if err != nil { return false, err } if az.VMType == vmTypeVMSS { // VMSS vmName is not same with hostname, use hostname instead. metadataName, err = os.Hostname() if err != nil { return false, err } } metadataName = strings.ToLower(metadataName) </ins> return (metadataName == nodeName), err } // InstanceID returns the cloud provider ID of the specified instance. // Note that if the instance does not exist or is no longer running, we must return (\"\", cloudprovider.InstanceNotFound) func (az *Cloud) InstanceID(ctx context.Context, name types.NodeName) (string, error) { <ins> nodeName := mapNodeNameToVMName(name) </ins> if az.UseInstanceMetadata { isLocalInstance, err := az.isCurrentInstance(name) if err != nil { return \"\", err } <del> if isLocalInstance { nodeName := mapNodeNameToVMName(name) return az.getMachineID(nodeName), nil </del> <ins> // Not local instance, get instanceID from Azure ARM API. if !isLocalInstance { return az.vmSet.GetInstanceIDByNodeName(nodeName) } // Compose instanceID based on nodeName for standard instance. if az.VMType == vmTypeStandard { return az.getStandardMachineID(nodeName), nil } // Get scale set name and instanceID from vmName for vmss. metadataName, err := az.metadata.Text(\"instance/compute/name\") if err != nil { return \"\", err } ssName, instanceID, err := extractVmssVMName(metadataName) if err != nil { return \"\", err </ins> } <ins> // Compose instanceID based on ssName and instanceID for vmss instance. return az.getVmssMachineID(ssName, instanceID), nil </ins> } <del> return az.vmSet.GetInstanceIDByNodeName(string(name)) </del> <ins> return az.vmSet.GetInstanceIDByNodeName(nodeName) </ins> } // InstanceTypeByProviderID returns the cloudprovider instance type of the node with the specified unique providerID", "commid": "kubernetes_pr_59857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2f1261686a24e9a9b8cb41f2d352702bfa4eaf05fdd39b4b9e9d7a090314c871", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig azure\nadding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-8ef28ee99b2d212e20b36b805de7afa150350e23c428ae1b2f358314f0c322bb", "text": "var errNotInVMSet = errors.New(\"vm is not in the vmset\") var providerIDRE = regexp.MustCompile(`^` + CloudProviderName + `://(?:.*)/Microsoft.Compute/virtualMachines/(.+)$`) <del> // returns the full identifier of a machine func (az *Cloud) getMachineID(machineName string) string { </del> <ins> // getStandardMachineID returns the full identifier of a virtual machine. func (az *Cloud) getStandardMachineID(machineName string) string { </ins> return fmt.Sprintf( machineIDTemplate, az.SubscriptionID,", "commid": "kubernetes_pr_59857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2f1261686a24e9a9b8cb41f2d352702bfa4eaf05fdd39b4b9e9d7a090314c871", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig azure\nadding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-f246c2f079a8cc6c97ac08056aa38c614e8ccd60ce71bc41ed23638986162727", "text": "// ErrorNotVmssInstance indicates an instance is not belongint to any vmss. ErrorNotVmssInstance = errors.New(\"not a vmss instance\") <del> scaleSetNameRE = regexp.MustCompile(`.*/subscriptions/(?:.*)/Microsoft.Compute/virtualMachineScaleSets/(.+)/virtualMachines(?:.*)`) </del> <ins> scaleSetNameRE        = regexp.MustCompile(`.*/subscriptions/(?:.*)/Microsoft.Compute/virtualMachineScaleSets/(.+)/virtualMachines(?:.*)`) vmssMachineIDTemplate = \"/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/virtualMachineScaleSets/%s/virtualMachines/%s\" </ins> ) // scaleSet implements VMSet interface for Azure scale set.", "commid": "kubernetes_pr_59857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2f1261686a24e9a9b8cb41f2d352702bfa4eaf05fdd39b4b9e9d7a090314c871", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig azure\nadding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-9bc0e55e4876dca67419e8e4ff8ee4d7bfa5d23aee16b5c7e4ef67b7149d0022", "text": "return nil } <ins> // getVmssMachineID returns the full identifier of a vmss virtual machine. func (az *Cloud) getVmssMachineID(scaleSetName, instanceID string) string { return fmt.Sprintf( vmssMachineIDTemplate, az.SubscriptionID, az.ResourceGroup, scaleSetName, instanceID) } </ins>", "commid": "kubernetes_pr_59857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2f1261686a24e9a9b8cb41f2d352702bfa4eaf05fdd39b4b9e9d7a090314c871", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig azure\nadding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-46535b59b10862ad35cfa48d50d27ae18446e7d9f450af0f81581554c6583695", "text": "return fmt.Sprintf(\"%s%s%s\", scaleSetName, vmssNameSeparator, instanceID) } <del> func (ss *scaleSet) extractVmssVMName(name string) (string, string, error) { </del> <ins> func extractVmssVMName(name string) (string, string, error) { </ins> ret := strings.Split(name, vmssNameSeparator) if len(ret) != 2 { glog.Errorf(\"Failed to extract vmssVMName %q\", name)", "commid": "kubernetes_pr_59857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2f1261686a24e9a9b8cb41f2d352702bfa4eaf05fdd39b4b9e9d7a090314c871", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig azure\nadding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-1aed93bd869dd85f95d7e183688944d97b5042474525154090b0877c55781d78", "text": "func (ss *scaleSet) newVmssVMCache() (*timedCache, error) { getter := func(key string) (interface{}, error) { // vmssVM name's format is 'scaleSetName_instanceID' <del> ssName, instanceID, err := ss.extractVmssVMName(key) </del> <ins> ssName, instanceID, err := extractVmssVMName(key) </ins> if err != nil { return nil, err }", "commid": "kubernetes_pr_59857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2f1261686a24e9a9b8cb41f2d352702bfa4eaf05fdd39b4b9e9d7a090314c871", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig azure\nadding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-66dab6c4f67a0c7e3199d409fc0ff5f5ce3e8aa0ed8fa6ab455364c3f599504b", "text": ") func TestExtractVmssVMName(t *testing.T) { <del> ss := &scaleSet{} </del> cases := []struct { description        string vmName             string", "commid": "kubernetes_pr_59857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2f1261686a24e9a9b8cb41f2d352702bfa4eaf05fdd39b4b9e9d7a090314c871", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When useInstanceMetadata is set to true for vmss nodes, their providerID is wrong. What you expected to happen: Their providerID should be in format azure:///subscriptions/&lt;subscription-id/resourceGroups/&lt;rg-name/providers/Microsoft.Compute/virtualMachineScaleSets/&lt;scaleset-name/virtualMachines/&lt;instance-id How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig azure\nadding priority important-soon so that this issue can stay in 1.10. Please update if incorrect. /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-a531bedda1e711f2d684c3f28eb9a6858108c351962eadd1099091e2042d97ca", "text": "} for _, c := range cases { <del> ssName, instanceID, err := ss.extractVmssVMName(c.vmName) </del> <ins> ssName, instanceID, err := extractVmssVMName(c.vmName) </ins> if c.expectError { assert.Error(t, err, c.description) continue", "commid": "kubernetes_pr_59857"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5db6b38c9e0a6f738b58da969e759df11708e8928302c7f7de882de90bc62043", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When creating an IPv6 cluster, the --pod-network-cidr needs to be a /66, it cannot be for a larger network (smaller value) What you expected to happen: Should be able to use values smaller then /66, /64 or a /48 How to reproduce it (as minimally and precisely as possible): Create a cluster with Kubeadm, and set the podSubnet as below networking: podSubnet: \"fd00:1:2:3::/64\" Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /area ipv6 /sig network\n/assign rpothier", "positive_passages": [{"docid": "doc-en-kubernetes-a7fac5612b82bbef51d74194c04de305ed598c3abc899d264c264c3363d9a108", "text": "// RangeSize returns the size of a range in valid addresses. func RangeSize(subnet *net.IPNet) int64 { ones, bits := subnet.Mask.Size() <del> if bits == 32 && (bits-ones) >= 31 || bits == 128 && (bits-ones) >= 63 { </del> <ins> if bits == 32 && (bits-ones) >= 31 || bits == 128 && (bits-ones) >= 127 { </ins> return 0 } <del> max := int64(1) << uint(bits-ones) return max </del> <ins> // For IPv6, the max size will be limited to 65536 // This is due to the allocator keeping track of all the // allocated IP's in a bitmap. This will keep the size of // the bitmap to 64k. if bits == 128 && (bits-ones) >= 16 { return int64(1) << uint(16) } else { return int64(1) << uint(bits-ones) } </ins> } // GetIndexedIP returns a net.IP that is subnet.IP + index in the contiguous IP space.", "commid": "kubernetes_pr_60089"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5db6b38c9e0a6f738b58da969e759df11708e8928302c7f7de882de90bc62043", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When creating an IPv6 cluster, the --pod-network-cidr needs to be a /66, it cannot be for a larger network (smaller value) What you expected to happen: Should be able to use values smaller then /66, /64 or a /48 How to reproduce it (as minimally and precisely as possible): Create a cluster with Kubeadm, and set the podSubnet as below networking: podSubnet: \"fd00:1:2:3::/64\" Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /area ipv6 /sig network\n/assign rpothier", "positive_passages": [{"docid": "doc-en-kubernetes-4e576db01c795b1853e02fe900c1dcfacde28f11ced5a799f07e114a2f1dbc70", "text": ") func TestAllocate(t *testing.T) { <del> _, cidr, err := net.ParseCIDR(\"192.168.1.0/24\") if err != nil { t.Fatal(err) } r := NewCIDRRange(cidr) t.Logf(\"base: %v\", r.base.Bytes()) if f := r.Free(); f != 254 { t.Errorf(\"unexpected free %d\", f) } if f := r.Used(); f != 0 { t.Errorf(\"unexpected used %d\", f) </del> <ins> testCases := []struct { name             string cidr             string free             int released         string outOfRange1      string outOfRange2      string outOfRange3      string alreadyAllocated string }{ { name:             \"IPv4\", cidr:             \"192.168.1.0/24\", free:             254, released:         \"192.168.1.5\", outOfRange1:      \"192.168.0.1\", outOfRange2:      \"192.168.1.0\", outOfRange3:      \"192.168.1.255\", alreadyAllocated: \"192.168.1.1\", }, { name:             \"IPv6\", cidr:             \"2001:db8:1::/48\", free:             65534, released:         \"2001:db8:1::5\", outOfRange1:      \"2001:db8::1\", outOfRange2:      \"2001:db8:1::\", outOfRange3:      \"2001:db8:1::ffff\", alreadyAllocated: \"2001:db8:1::1\", }, </ins> } <del> found := sets.NewString() count := 0 for r.Free() > 0 { ip, err := r.AllocateNext() </del> <ins> for _, tc := range testCases { _, cidr, err := net.ParseCIDR(tc.cidr) </ins> if err != nil { <del> t.Fatalf(\"error @ %d: %v\", count, err) </del> <ins> t.Fatal(err) </ins> } <del> count++ if !cidr.Contains(ip) { t.Fatalf(\"allocated %s which is outside of %s\", ip, cidr) </del> <ins> r := NewCIDRRange(cidr) t.Logf(\"base: %v\", r.base.Bytes()) if f := r.Free(); f != tc.free { t.Errorf(\"Test %s unexpected free %d\", tc.name, f) </ins> } <del> if found.Has(ip.String()) { t.Fatalf(\"allocated %s twice @ %d\", ip, count) </del> <ins> if f := r.Used(); f != 0 { t.Errorf(\"Test %s unexpected used %d\", tc.name, f) } found := sets.NewString() count := 0 for r.Free() > 0 { ip, err := r.AllocateNext() if err != nil { t.Fatalf(\"Test %s error @ %d: %v\", tc.name, count, err) } count++ if !cidr.Contains(ip) { t.Fatalf(\"Test %s allocated %s which is outside of %s\", tc.name, ip, cidr) } if found.Has(ip.String()) { t.Fatalf(\"Test %s allocated %s twice @ %d\", tc.name, ip, count) } found.Insert(ip.String()) } if _, err := r.AllocateNext(); err != ErrFull { t.Fatal(err) </ins> } <del> found.Insert(ip.String()) } if _, err := r.AllocateNext(); err != ErrFull { t.Fatal(err) } released := net.ParseIP(\"192.168.1.5\") if err := r.Release(released); err != nil { t.Fatal(err) } if f := r.Free(); f != 1 { t.Errorf(\"unexpected free %d\", f) } if f := r.Used(); f != 253 { t.Errorf(\"unexpected free %d\", f) } ip, err := r.AllocateNext() if err != nil { t.Fatal(err) } if !released.Equal(ip) { t.Errorf(\"unexpected %s : %s\", ip, released) } </del> <ins> released := net.ParseIP(tc.released) if err := r.Release(released); err != nil { t.Fatal(err) } if f := r.Free(); f != 1 { t.Errorf(\"Test %s unexpected free %d\", tc.name, f) } if f := r.Used(); f != (tc.free - 1) { t.Errorf(\"Test %s unexpected free %d\", tc.name, f) } ip, err := r.AllocateNext() if err != nil { t.Fatal(err) } if !released.Equal(ip) { t.Errorf(\"Test %s unexpected %s : %s\", tc.name, ip, released) } </ins> <del> if err := r.Release(released); err != nil { t.Fatal(err) } err = r.Allocate(net.ParseIP(\"192.168.0.1\")) if _, ok := err.(*ErrNotInRange); !ok { t.Fatal(err) } if err := r.Allocate(net.ParseIP(\"192.168.1.1\")); err != ErrAllocated { t.Fatal(err) } err = r.Allocate(net.ParseIP(\"192.168.1.0\")) if _, ok := err.(*ErrNotInRange); !ok { t.Fatal(err) } err = r.Allocate(net.ParseIP(\"192.168.1.255\")) if _, ok := err.(*ErrNotInRange); !ok { t.Fatal(err) } if f := r.Free(); f != 1 { t.Errorf(\"unexpected free %d\", f) } if f := r.Used(); f != 253 { t.Errorf(\"unexpected free %d\", f) } if err := r.Allocate(released); err != nil { t.Fatal(err) } if f := r.Free(); f != 0 { t.Errorf(\"unexpected free %d\", f) } if f := r.Used(); f != 254 { t.Errorf(\"unexpected free %d\", f) </del> <ins> if err := r.Release(released); err != nil { t.Fatal(err) } err = r.Allocate(net.ParseIP(tc.outOfRange1)) if _, ok := err.(*ErrNotInRange); !ok { t.Fatal(err) } if err := r.Allocate(net.ParseIP(tc.alreadyAllocated)); err != ErrAllocated { t.Fatal(err) } err = r.Allocate(net.ParseIP(tc.outOfRange2)) if _, ok := err.(*ErrNotInRange); !ok { t.Fatal(err) } err = r.Allocate(net.ParseIP(tc.outOfRange3)) if _, ok := err.(*ErrNotInRange); !ok { t.Fatal(err) } if f := r.Free(); f != 1 { t.Errorf(\"Test %s unexpected free %d\", tc.name, f) } if f := r.Used(); f != (tc.free - 1) { t.Errorf(\"Test %s unexpected free %d\", tc.name, f) } if err := r.Allocate(released); err != nil { t.Fatal(err) } if f := r.Free(); f != 0 { t.Errorf(\"Test %s unexpected free %d\", tc.name, f) } if f := r.Used(); f != tc.free { t.Errorf(\"Test %s unexpected free %d\", tc.name, f) } </ins> } }", "commid": "kubernetes_pr_60089"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5db6b38c9e0a6f738b58da969e759df11708e8928302c7f7de882de90bc62043", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When creating an IPv6 cluster, the --pod-network-cidr needs to be a /66, it cannot be for a larger network (smaller value) What you expected to happen: Should be able to use values smaller then /66, /64 or a /48 How to reproduce it (as minimally and precisely as possible): Create a cluster with Kubeadm, and set the podSubnet as below networking: podSubnet: \"fd00:1:2:3::/64\" Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /area ipv6 /sig network\n/assign rpothier", "positive_passages": [{"docid": "doc-en-kubernetes-d39fc4ffcc6084f194dec70694370e77adc9ebdd6cd4b802eaa0b92ad0f0dc6f", "text": "}, { name:  \"supported IPv6 cidr\", <del> cidr:  \"2001:db8::/98\", addrs: 1073741824, </del> <ins> cidr:  \"2001:db8::/48\", addrs: 65536, </ins> }, { name:  \"unsupported IPv6 mask\", <del> cidr:  \"2001:db8::/65\", </del> <ins> cidr:  \"2001:db8::/1\", </ins> addrs: 0, }, }", "commid": "kubernetes_pr_60089"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d4bfe54ff37fb83a884623cd544dfe42ec65baa73bf3910601f0a26632482c49", "query": "In following with history we will be curating action items here, but it's still a WIP, atm: All non-bug-fixes for this release cycle should be merged, but there is still an ongoing list of bugs that folks may execute against for the remainder of the freeze and we will evaluating on a case-by-case basis. /cc\nThank you for creating this issue!\n/cc\nAdding required tags. Please use this issue to supply a frequent summary update of the issues you are tracking in the kubeadm repo and their status. Especially, please call out and link to any bugs that are blockers for 1.10. /kind feature /priority critical-urgent\ncan we have a general status update on the kubeadm issues? The issues themselves don't generally have status updates. This is the last week before release, where are you with the kubeadm changes?\nWe're all green except for the 1.9-1.10 upgrade tests which appear to have other issues that are not kubeadm specific. Final default update PR is which will auto-close this issue.\n^ I don't know why we have this policy but it's ridiculous...\nare there any 1.9-1.10 upgrade issues which aren't already represented by issues against kubernetes/kubernetes? that is, are there any in the kubadm repo only?\nNot that I see atm, I still need to triage the inbound issues.\n/status in-progress\n/status in-progress\n[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : New functionality. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-1d24a659c889b986ef2a13a349ccc97fcb9fe5ddf64189e908b9c728598c40ee", "text": "// DefaultClusterDNSIP defines default DNS IP DefaultClusterDNSIP = \"10.96.0.10\" // DefaultKubernetesVersion defines default kubernetes version <del> DefaultKubernetesVersion = \"stable-1.9\" </del> <ins> DefaultKubernetesVersion = \"stable-1.10\" </ins> // DefaultAPIBindPort defines default API port DefaultAPIBindPort = 6443 // DefaultAuthorizationModes defines default authorization modes", "commid": "kubernetes_pr_61127"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9a2b07cf0c73dadc896291ace41839fae52c7d65b3c953ac91d92e03ffc8bbe1", "query": "This test is failing in both gce serial suite: http://k8s- /sig network /priority failing-test /priority critical-urgent /kind bug /status approved-for-milestone cc /assign PTAL\nxref\n/milestone v1.10\nthis also fails in http://k8s-\nFailing to connect to Services at all. I can't even ping pod IPs:\nSo I can ping pods same-node and cross-node right up until it kills the apiserver. Rebooting fixes a given node. The apiserver demonstrably comes back - I can query it for info...\n- I could use help - have to shift attention soon.\nFWIW, I am testing on a Calico-enabled node\nI'll take a look at this as well.\nWeird, now even after a reboot, this condition is sticky. I have a cluster in this state, if you want to poke.\nugh, now it is resolved.\nI just repro'ed without the e2e - have a cluster, proved ping works, killed apiserver ping fails.\nInteresting - docker shows the pods not running, but apiserver says they are alive.\nUpdate: docker sees no running pods. API server thinks kubelet is running them. kubelet is getting \"\" from apiserver, even after kubelet restart.\nUpdate and recap: Bring up a cluster Run some pods Prove that pods are running and services work pkill -9 apiserver Wait. Watch kubelets \"lose\" pods that were assigned to them Observe that pods are not running and services do not work Observe that apiserver says the pods are running pkill -9 kubelet Observe that it is still broken kubectl delete one pod Observe that kubelet is fixed for that one pod, but not others Q: Why is kubelet not getting a full listing when it restarts?\nWhat exactly does it mean for it to be fixed for a deleted pod?\nKubelet started running the pod that was deleted - it got the update for that one.\nThe cluster I was testing was a week or 2 old. I built a cluster from HEAD and I can not repro - said the same. Is this test running against head of master?\nI also ran the test manually against my new cluster and it passed\nFWIW I was also unable to reproduce this yesterday on a cluster from HEAD.\nDid some investigations and had some findings for this specific failure: Traced down a bit on the history, the first occurrence was https://k8s- From the , seems suspicious because it modified . Also found reported a relevant symptom: The fix () for that was merged a day ago and may explained why we can't repro from HEAD anymore.\nnice, is this issue reproducible without the fix ()?\nSorry should have had confirmed this, bringing up a cluster now.\nQuick update: I was able to repro the same failure () from HEAD with reverted. Though this test is now flaky on some other errors: https://k8s- https://k8s- They all seem to failed while communicating with apiserver.\nThanks ! So fixed the issue and I am curious about what introduced the issue. Do you happen to know when did this test start to fail? Just trying to find out what went wrong in between. We have some other possibly related issues so finding out the root cause of this one would be super helpful.\n/assign\nThe first occurrence (for that exact failure) I noticed was https://k8s-, which happened on 2018-02-15 09:49 PST.\nYou all rock! I see a couple greens on it now, but still mostly red?\nThe test is now flaky mostly on creating an exec pod after restarting apiserver. Some sample failures: To elaborate a bit more, a snippet of the test procedure is: ssh to master and (sending a SIGTERM) Keep polling on /healthz on apiserver until 200 is returned. Create an exec pod for later steps (and failed on various erros --- EOF, connection refused, apiserver terminating). According to above test failures, my suspicion is that the test is assuming the apiserver is restarted too soon. It is possible that apiserver captured SIGTERM and did a graceful termination, so that polling on /healthz may succeed even in the termination phase. I'm not surprised trying to create a pod via a terminating apiserver will hit those errors. Could anyone confirme the SIGTERM theory?\nSpoke with folks, sounds like after SIGTERM apiserver does wait a bit for remaining requests to finish. I will take a stab to refine the test. cc\nSent .\nTest is now passing on gce but failing on gke. Apparently we don't have a way to trigger apiserver restart on gke at this moment. Sending a PR to skip this test on gke.\n[MILESTONENOTIFIER] Milestone Issue Needs Attention Action required: During code freeze, issues in the milestone should be in progress. If this issue is not being actively worked on, please remove it from the milestone. If it is being worked on, please add the label so it can be tracked with other in-flight issues. Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nCommented too quick. On gke we do a same-version master upgrade. Will send another fix :/", "positive_passages": [{"docid": "doc-en-kubernetes-3d36433b0a004468937813ba8af69af1e1388989dfb07a6b285f33a605bf1645", "text": "return fmt.Errorf(\"waiting for kubelet timed out\") } <del> func RestartApiserver(c discovery.ServerVersionInterface) error { </del> <ins> func RestartApiserver(cs clientset.Interface) error { </ins> // TODO: Make it work for all providers. if !ProviderIs(\"gce\", \"gke\", \"aws\") { return fmt.Errorf(\"unsupported provider: %s\", TestContext.Provider) } if ProviderIs(\"gce\", \"aws\") { <del> return sshRestartMaster() </del> <ins> initialRestartCount, err := getApiserverRestartCount(cs) if err != nil { return fmt.Errorf(\"failed to get apiserver's restart count: %v\", err) } if err := sshRestartMaster(); err != nil { return fmt.Errorf(\"failed to restart apiserver: %v\", err) } return waitForApiserverRestarted(cs, initialRestartCount) </ins> } // GKE doesn't allow ssh access, so use a same-version master // upgrade to teardown/recreate master. <del> v, err := c.ServerVersion() </del> <ins> v, err := cs.Discovery().ServerVersion() </ins> if err != nil { return err }", "commid": "kubernetes_pr_60993"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9a2b07cf0c73dadc896291ace41839fae52c7d65b3c953ac91d92e03ffc8bbe1", "query": "This test is failing in both gce serial suite: http://k8s- /sig network /priority failing-test /priority critical-urgent /kind bug /status approved-for-milestone cc /assign PTAL\nxref\n/milestone v1.10\nthis also fails in http://k8s-\nFailing to connect to Services at all. I can't even ping pod IPs:\nSo I can ping pods same-node and cross-node right up until it kills the apiserver. Rebooting fixes a given node. The apiserver demonstrably comes back - I can query it for info...\n- I could use help - have to shift attention soon.\nFWIW, I am testing on a Calico-enabled node\nI'll take a look at this as well.\nWeird, now even after a reboot, this condition is sticky. I have a cluster in this state, if you want to poke.\nugh, now it is resolved.\nI just repro'ed without the e2e - have a cluster, proved ping works, killed apiserver ping fails.\nInteresting - docker shows the pods not running, but apiserver says they are alive.\nUpdate: docker sees no running pods. API server thinks kubelet is running them. kubelet is getting \"\" from apiserver, even after kubelet restart.\nUpdate and recap: Bring up a cluster Run some pods Prove that pods are running and services work pkill -9 apiserver Wait. Watch kubelets \"lose\" pods that were assigned to them Observe that pods are not running and services do not work Observe that apiserver says the pods are running pkill -9 kubelet Observe that it is still broken kubectl delete one pod Observe that kubelet is fixed for that one pod, but not others Q: Why is kubelet not getting a full listing when it restarts?\nWhat exactly does it mean for it to be fixed for a deleted pod?\nKubelet started running the pod that was deleted - it got the update for that one.\nThe cluster I was testing was a week or 2 old. I built a cluster from HEAD and I can not repro - said the same. Is this test running against head of master?\nI also ran the test manually against my new cluster and it passed\nFWIW I was also unable to reproduce this yesterday on a cluster from HEAD.\nDid some investigations and had some findings for this specific failure: Traced down a bit on the history, the first occurrence was https://k8s- From the , seems suspicious because it modified . Also found reported a relevant symptom: The fix () for that was merged a day ago and may explained why we can't repro from HEAD anymore.\nnice, is this issue reproducible without the fix ()?\nSorry should have had confirmed this, bringing up a cluster now.\nQuick update: I was able to repro the same failure () from HEAD with reverted. Though this test is now flaky on some other errors: https://k8s- https://k8s- They all seem to failed while communicating with apiserver.\nThanks ! So fixed the issue and I am curious about what introduced the issue. Do you happen to know when did this test start to fail? Just trying to find out what went wrong in between. We have some other possibly related issues so finding out the root cause of this one would be super helpful.\n/assign\nThe first occurrence (for that exact failure) I noticed was https://k8s-, which happened on 2018-02-15 09:49 PST.\nYou all rock! I see a couple greens on it now, but still mostly red?\nThe test is now flaky mostly on creating an exec pod after restarting apiserver. Some sample failures: To elaborate a bit more, a snippet of the test procedure is: ssh to master and (sending a SIGTERM) Keep polling on /healthz on apiserver until 200 is returned. Create an exec pod for later steps (and failed on various erros --- EOF, connection refused, apiserver terminating). According to above test failures, my suspicion is that the test is assuming the apiserver is restarted too soon. It is possible that apiserver captured SIGTERM and did a graceful termination, so that polling on /healthz may succeed even in the termination phase. I'm not surprised trying to create a pod via a terminating apiserver will hit those errors. Could anyone confirme the SIGTERM theory?\nSpoke with folks, sounds like after SIGTERM apiserver does wait a bit for remaining requests to finish. I will take a stab to refine the test. cc\nSent .\nTest is now passing on gce but failing on gke. Apparently we don't have a way to trigger apiserver restart on gke at this moment. Sending a PR to skip this test on gke.\n[MILESTONENOTIFIER] Milestone Issue Needs Attention Action required: During code freeze, issues in the milestone should be in progress. If this issue is not being actively worked on, please remove it from the milestone. If it is being worked on, please add the label so it can be tracked with other in-flight issues. Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nCommented too quick. On gke we do a same-version master upgrade. Will send another fix :/", "positive_passages": [{"docid": "doc-en-kubernetes-b7c500c8f86990f336d9d472bf27d7ebdbf87af5f9c0794497578b9683924604", "text": "return fmt.Errorf(\"waiting for apiserver timed out\") } <del> // WaitForApiserverRestarted waits until apiserver's restart count increased. func WaitForApiserverRestarted(c clientset.Interface, initialRestartCount int32) error { </del> <ins> // waitForApiserverRestarted waits until apiserver's restart count increased. func waitForApiserverRestarted(c clientset.Interface, initialRestartCount int32) error { </ins> for start := time.Now(); time.Since(start) < time.Minute; time.Sleep(5 * time.Second) { <del> restartCount, err := GetApiserverRestartCount(c) </del> <ins> restartCount, err := getApiserverRestartCount(c) </ins> if err != nil { Logf(\"Failed to get apiserver's restart count: %v\", err) continue", "commid": "kubernetes_pr_60993"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9a2b07cf0c73dadc896291ace41839fae52c7d65b3c953ac91d92e03ffc8bbe1", "query": "This test is failing in both gce serial suite: http://k8s- /sig network /priority failing-test /priority critical-urgent /kind bug /status approved-for-milestone cc /assign PTAL\nxref\n/milestone v1.10\nthis also fails in http://k8s-\nFailing to connect to Services at all. I can't even ping pod IPs:\nSo I can ping pods same-node and cross-node right up until it kills the apiserver. Rebooting fixes a given node. The apiserver demonstrably comes back - I can query it for info...\n- I could use help - have to shift attention soon.\nFWIW, I am testing on a Calico-enabled node\nI'll take a look at this as well.\nWeird, now even after a reboot, this condition is sticky. I have a cluster in this state, if you want to poke.\nugh, now it is resolved.\nI just repro'ed without the e2e - have a cluster, proved ping works, killed apiserver ping fails.\nInteresting - docker shows the pods not running, but apiserver says they are alive.\nUpdate: docker sees no running pods. API server thinks kubelet is running them. kubelet is getting \"\" from apiserver, even after kubelet restart.\nUpdate and recap: Bring up a cluster Run some pods Prove that pods are running and services work pkill -9 apiserver Wait. Watch kubelets \"lose\" pods that were assigned to them Observe that pods are not running and services do not work Observe that apiserver says the pods are running pkill -9 kubelet Observe that it is still broken kubectl delete one pod Observe that kubelet is fixed for that one pod, but not others Q: Why is kubelet not getting a full listing when it restarts?\nWhat exactly does it mean for it to be fixed for a deleted pod?\nKubelet started running the pod that was deleted - it got the update for that one.\nThe cluster I was testing was a week or 2 old. I built a cluster from HEAD and I can not repro - said the same. Is this test running against head of master?\nI also ran the test manually against my new cluster and it passed\nFWIW I was also unable to reproduce this yesterday on a cluster from HEAD.\nDid some investigations and had some findings for this specific failure: Traced down a bit on the history, the first occurrence was https://k8s- From the , seems suspicious because it modified . Also found reported a relevant symptom: The fix () for that was merged a day ago and may explained why we can't repro from HEAD anymore.\nnice, is this issue reproducible without the fix ()?\nSorry should have had confirmed this, bringing up a cluster now.\nQuick update: I was able to repro the same failure () from HEAD with reverted. Though this test is now flaky on some other errors: https://k8s- https://k8s- They all seem to failed while communicating with apiserver.\nThanks ! So fixed the issue and I am curious about what introduced the issue. Do you happen to know when did this test start to fail? Just trying to find out what went wrong in between. We have some other possibly related issues so finding out the root cause of this one would be super helpful.\n/assign\nThe first occurrence (for that exact failure) I noticed was https://k8s-, which happened on 2018-02-15 09:49 PST.\nYou all rock! I see a couple greens on it now, but still mostly red?\nThe test is now flaky mostly on creating an exec pod after restarting apiserver. Some sample failures: To elaborate a bit more, a snippet of the test procedure is: ssh to master and (sending a SIGTERM) Keep polling on /healthz on apiserver until 200 is returned. Create an exec pod for later steps (and failed on various erros --- EOF, connection refused, apiserver terminating). According to above test failures, my suspicion is that the test is assuming the apiserver is restarted too soon. It is possible that apiserver captured SIGTERM and did a graceful termination, so that polling on /healthz may succeed even in the termination phase. I'm not surprised trying to create a pod via a terminating apiserver will hit those errors. Could anyone confirme the SIGTERM theory?\nSpoke with folks, sounds like after SIGTERM apiserver does wait a bit for remaining requests to finish. I will take a stab to refine the test. cc\nSent .\nTest is now passing on gce but failing on gke. Apparently we don't have a way to trigger apiserver restart on gke at this moment. Sending a PR to skip this test on gke.\n[MILESTONENOTIFIER] Milestone Issue Needs Attention Action required: During code freeze, issues in the milestone should be in progress. If this issue is not being actively worked on, please remove it from the milestone. If it is being worked on, please add the label so it can be tracked with other in-flight issues. Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nCommented too quick. On gke we do a same-version master upgrade. Will send another fix :/", "positive_passages": [{"docid": "doc-en-kubernetes-06472af30c5c1fe6cbe371bcaf6f07ceb18fd8e2ee5de8002e8a453e7313b8a7", "text": "return fmt.Errorf(\"timed out waiting for apiserver to be restarted\") } <del> func GetApiserverRestartCount(c clientset.Interface) (int32, error) { </del> <ins> func getApiserverRestartCount(c clientset.Interface) (int32, error) { </ins> label := labels.SelectorFromSet(labels.Set(map[string]string{\"component\": \"kube-apiserver\"})) listOpts := metav1.ListOptions{LabelSelector: label.String()} pods, err := c.CoreV1().Pods(metav1.NamespaceSystem).List(listOpts)", "commid": "kubernetes_pr_60993"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9a2b07cf0c73dadc896291ace41839fae52c7d65b3c953ac91d92e03ffc8bbe1", "query": "This test is failing in both gce serial suite: http://k8s- /sig network /priority failing-test /priority critical-urgent /kind bug /status approved-for-milestone cc /assign PTAL\nxref\n/milestone v1.10\nthis also fails in http://k8s-\nFailing to connect to Services at all. I can't even ping pod IPs:\nSo I can ping pods same-node and cross-node right up until it kills the apiserver. Rebooting fixes a given node. The apiserver demonstrably comes back - I can query it for info...\n- I could use help - have to shift attention soon.\nFWIW, I am testing on a Calico-enabled node\nI'll take a look at this as well.\nWeird, now even after a reboot, this condition is sticky. I have a cluster in this state, if you want to poke.\nugh, now it is resolved.\nI just repro'ed without the e2e - have a cluster, proved ping works, killed apiserver ping fails.\nInteresting - docker shows the pods not running, but apiserver says they are alive.\nUpdate: docker sees no running pods. API server thinks kubelet is running them. kubelet is getting \"\" from apiserver, even after kubelet restart.\nUpdate and recap: Bring up a cluster Run some pods Prove that pods are running and services work pkill -9 apiserver Wait. Watch kubelets \"lose\" pods that were assigned to them Observe that pods are not running and services do not work Observe that apiserver says the pods are running pkill -9 kubelet Observe that it is still broken kubectl delete one pod Observe that kubelet is fixed for that one pod, but not others Q: Why is kubelet not getting a full listing when it restarts?\nWhat exactly does it mean for it to be fixed for a deleted pod?\nKubelet started running the pod that was deleted - it got the update for that one.\nThe cluster I was testing was a week or 2 old. I built a cluster from HEAD and I can not repro - said the same. Is this test running against head of master?\nI also ran the test manually against my new cluster and it passed\nFWIW I was also unable to reproduce this yesterday on a cluster from HEAD.\nDid some investigations and had some findings for this specific failure: Traced down a bit on the history, the first occurrence was https://k8s- From the , seems suspicious because it modified . Also found reported a relevant symptom: The fix () for that was merged a day ago and may explained why we can't repro from HEAD anymore.\nnice, is this issue reproducible without the fix ()?\nSorry should have had confirmed this, bringing up a cluster now.\nQuick update: I was able to repro the same failure () from HEAD with reverted. Though this test is now flaky on some other errors: https://k8s- https://k8s- They all seem to failed while communicating with apiserver.\nThanks ! So fixed the issue and I am curious about what introduced the issue. Do you happen to know when did this test start to fail? Just trying to find out what went wrong in between. We have some other possibly related issues so finding out the root cause of this one would be super helpful.\n/assign\nThe first occurrence (for that exact failure) I noticed was https://k8s-, which happened on 2018-02-15 09:49 PST.\nYou all rock! I see a couple greens on it now, but still mostly red?\nThe test is now flaky mostly on creating an exec pod after restarting apiserver. Some sample failures: To elaborate a bit more, a snippet of the test procedure is: ssh to master and (sending a SIGTERM) Keep polling on /healthz on apiserver until 200 is returned. Create an exec pod for later steps (and failed on various erros --- EOF, connection refused, apiserver terminating). According to above test failures, my suspicion is that the test is assuming the apiserver is restarted too soon. It is possible that apiserver captured SIGTERM and did a graceful termination, so that polling on /healthz may succeed even in the termination phase. I'm not surprised trying to create a pod via a terminating apiserver will hit those errors. Could anyone confirme the SIGTERM theory?\nSpoke with folks, sounds like after SIGTERM apiserver does wait a bit for remaining requests to finish. I will take a stab to refine the test. cc\nSent .\nTest is now passing on gce but failing on gke. Apparently we don't have a way to trigger apiserver restart on gke at this moment. Sending a PR to skip this test on gke.\n[MILESTONENOTIFIER] Milestone Issue Needs Attention Action required: During code freeze, issues in the milestone should be in progress. If this issue is not being actively worked on, please remove it from the milestone. If it is being worked on, please add the label so it can be tracked with other in-flight issues. Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nCommented too quick. On gke we do a same-version master upgrade. Will send another fix :/", "positive_passages": [{"docid": "doc-en-kubernetes-919fd37fcf804ff8c704ca14d4a4ab403bab771779c38d5cc67e21eb1f9a483c", "text": "framework.ExpectNoError(framework.VerifyServeHostnameServiceUp(cs, ns, host, podNames1, svc1IP, servicePort)) // Restart apiserver <del> initialRestartCount, err := framework.GetApiserverRestartCount(cs) Expect(err).NotTo(HaveOccurred(), \"failed to get apiserver's restart count\") </del> By(\"Restarting apiserver\") <del> if err := framework.RestartApiserver(cs.Discovery()); err != nil { </del> <ins> if err := framework.RestartApiserver(cs); err != nil { </ins> framework.Failf(\"error restarting apiserver: %v\", err) } <del> By(\"Waiting for apiserver to be restarted\") if err := framework.WaitForApiserverRestarted(cs, initialRestartCount); err != nil { framework.Failf(\"error while waiting for apiserver to be restarted: %v\", err) } </del> By(\"Waiting for apiserver to come up by polling /healthz\") if err := framework.WaitForApiserverUp(cs); err != nil { framework.Failf(\"error while waiting for apiserver up: %v\", err)", "commid": "kubernetes_pr_60993"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f3c67bfc2950087449c2463907f069dc46972ea9be99ce2576cbe8e050232c18", "query": "/kind bug /sig storage What happened: When mounting iSCSI PV kubelet doesn't give multipathd enough time to create multipath device and fallbacks to mounting single SCSI device What you expected to happen: it uses multipath device to mount How to reproduce it (as minimally and precisely as possible): create ~5 pods on a single node, each with dynamically provisioned PV (we use Trident for that), observe how some mounts are /dev/sd and not /dev/mapper/ Environment: Kubelet 1.9.3 Baremetal + NetApp ONTAP ove iSCSI + Trident dynamic volume provisioner CoreOS (kernel 4.14.24, multipath-tools 0.6.4)\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nI can reproduce this issue fairly often (although not reliably). The problem is in in the AttachDisk() function. The basic problem is that the method that finds the multipath device looks at each device path one time, and if none of them have an associated multipath device, it just falls back to formatting and mounting the first device path. There is no wait loop for the multipath device to appear. It would be easy to add a wait loop, but that would slow down the non-multipath use case. A possible optimization would be to only wait when 2 or more paths are known, but that still opens up the possibility of incorrect behavior when attaching while all but one paths are down, or when only one path is discovered (for whatever reason).\nAfter thinking about this over lunch, I think a possible fix would be: add a 10 second wait loop for the multipath device if and only if the PV are 2 or more target portals specified. This puts control in the hands of the provisioner without modifying the API at all, and not breaking backwards compatibility. The one corner case I can see is what would happen the PV has 2 portals, but the system is only able to log in to one. This would occur when multipath was correctly configured on the storage controller and in the provisioner, but one of the paths was down (for whatever reason) at attach time. I'm inclined to make the attachment FAIL if the multipath device can't be found within 10 seconds, which would be a change to current behavior, but this can easily be worked around by the cluster administrator setting up multipathd to create devices for single path disks. Provisioners would want to document the recommended way to do that (i.e. set find_multipaths = no, and configure the blacklist appropriately).\nis vaguely described as \"target portal ips for high availability\", without describing what the \"high availability\" means. Should we assume that it means multipath? Then Kubernetes can always wait for multipath device to appear when more that one is specified. Would it break anything? Does anyone run multiple portals for the same volume without multipath? Is it something we should support? any opinion?\nyes, the iscsi portals were made possible by for HA/mpio use case (see ). The lack of concrete description makes it less obvious though.\nwas it working perfectly with older kube versions and the issue started to pop up recently or from ? Why I am asking is, multipath support was in kube () and atleast I havent seen this issue reported till this report or very recently. Gluster team were also using multipathing feature for quite some time where we always got mpath device mounted reliably, but noticed this issue very recently or with latest OCP builds. iic, There are good number of changes happened in between especially on device discovery/attach ( ex: ) disk paths. I am not concretely saying its a regression or a behavioral change or side effect of some other patch, but trying to figure out if thats the case. any thoughts here ? my understanding was/is that with more target portal IPs means ( atleast) in ISCSI context, but we could have mention as well in the description. Suppose the backup portal IPs are filled by provisioner/admin but initiator havent enabled ( dm_mulitpath is not loaded or deamon service is not running) software in the kubelet/node, what will happen ? Is it going to be infinite wait for failure ? my understanding is that, if multipath is enabled, even if it failed ( for some reason) for backup paths, a mpath device will be created for single path in the system. If thats the case above shouldnt be a concern and device mapper layer will take care of the path discovery later when path becomes stable/available. I dont think so.\nwe started with 1.9.x on kubelets, so can't tell much about mounting behaviour of previous versions. it is going to fail, but it is fine, nodes should be correctly configured. Lets say you specify fsType, but given FS module is not loaded by kernel, or now mkfs.<FSbinary is available to the kubelet, mount is going to fail and thats OK IMHO. Kubelet shouldn't try to fallback to anything less than was asked, mounting via single portal when multiple portals are specified is similar to trying \"default FS\" if required fsType can't be used. Yes, default configuration for multipathd is option (note, that default in Linux distributions might be different), which creates multipath device for every non-blacklisted block device.\nI'm fairly confident that adding a wait loop for the multipath device in the case when there are 2 or more portals in the PV spec won't cause any regressions. The thing that gives me pause is that there are cases when there's a single portal in the PV spec, but the device still supports multipath and the existing sendtargets command is the mechanism for finding those other paths. I'm wondering if it's possible to detect that case (reliably) and use a wait loop for the multipath device in those cases too.\nis the default on RHEL 7, see\nDid you mean Multiple Connection Per Session (MC/S)? I don't think this is supported in open-iscsi. Open-iSCSI only supports MPIO (multiple portals)\nI don't understand the move by RedHat to default to findmultipaths = no. It basically guarantees bad behavior in cloud-oriented use cases when there's a temporary path failure. My reading of the linked document is that the main motivation for changing the default is to avoid the need to setup a correct blacklist. It seems to me that correct behavior is more important that avoiding some work up front when configuring multipath. No, I'm referring to the . If a storage backend has multiple target portals, but the dynamic provisioner only puts one portal in the PV spec, then as long as that one portal is accessible at attach time, open-iscsi will discover the other portals and log into them. The only weakness to this approach is what happens when that one path is inaccessible at attach time due to a network switch/network port/NIC failure, while the other ports are still available.\n, AFAIK multipathd (binary) in RHEL 7 defaults to , but configuration utility they ship writes config with , that utility needs to be called explicitly , IMHO that should be direct scsi mount unconditionally, without multipath involved\nThe thing that gives me pause is that there are cases when there's a single portal in the PV spec I would be inclined to agree, except that someone the sendtargets logic to the iscsi code. This code exists for no reason other than to allow finding multiple path given a single path. In fact the existing NetApp dynamic provisioner (Trident) relies on that behavior currently to get multipath support (this is something I've fixed and will upstream shortly). If we decide that PVs with exactly one portal should not support multipath, then we should remove that sendtargets logic from the iscsi module in kubelet.", "positive_passages": [{"docid": "doc-en-kubernetes-a8b43b656d38c3de0bf5645bfbb9c2d359e773bc0798df7b2df577bbf6301557", "text": "return nil } <ins> func waitForMultiPathToExist(devicePaths []string, maxRetries int, deviceUtil volumeutil.DeviceUtil) string { if 0 == len(devicePaths) { return \"\" } for i := 0; i < maxRetries; i++ { for _, path := range devicePaths { // There shouldnt be any empty device paths. However adding this check // for safer side to avoid the possibility of an empty entry. if path == \"\" { continue } // check if the dev is using mpio and if so mount it via the dm-XX device if mappedDevicePath := deviceUtil.FindMultipathDeviceForDevice(path); mappedDevicePath != \"\" { return mappedDevicePath } } if i == maxRetries-1 { break } time.Sleep(time.Second) } return \"\" } </ins> // AttachDisk returns devicePath of volume if attach succeeded otherwise returns error func (util *ISCSIUtil) AttachDisk(b iscsiDiskMounter) (string, error) { var devicePath string", "commid": "kubernetes_pr_67140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f3c67bfc2950087449c2463907f069dc46972ea9be99ce2576cbe8e050232c18", "query": "/kind bug /sig storage What happened: When mounting iSCSI PV kubelet doesn't give multipathd enough time to create multipath device and fallbacks to mounting single SCSI device What you expected to happen: it uses multipath device to mount How to reproduce it (as minimally and precisely as possible): create ~5 pods on a single node, each with dynamically provisioned PV (we use Trident for that), observe how some mounts are /dev/sd and not /dev/mapper/ Environment: Kubelet 1.9.3 Baremetal + NetApp ONTAP ove iSCSI + Trident dynamic volume provisioner CoreOS (kernel 4.14.24, multipath-tools 0.6.4)\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nI can reproduce this issue fairly often (although not reliably). The problem is in in the AttachDisk() function. The basic problem is that the method that finds the multipath device looks at each device path one time, and if none of them have an associated multipath device, it just falls back to formatting and mounting the first device path. There is no wait loop for the multipath device to appear. It would be easy to add a wait loop, but that would slow down the non-multipath use case. A possible optimization would be to only wait when 2 or more paths are known, but that still opens up the possibility of incorrect behavior when attaching while all but one paths are down, or when only one path is discovered (for whatever reason).\nAfter thinking about this over lunch, I think a possible fix would be: add a 10 second wait loop for the multipath device if and only if the PV are 2 or more target portals specified. This puts control in the hands of the provisioner without modifying the API at all, and not breaking backwards compatibility. The one corner case I can see is what would happen the PV has 2 portals, but the system is only able to log in to one. This would occur when multipath was correctly configured on the storage controller and in the provisioner, but one of the paths was down (for whatever reason) at attach time. I'm inclined to make the attachment FAIL if the multipath device can't be found within 10 seconds, which would be a change to current behavior, but this can easily be worked around by the cluster administrator setting up multipathd to create devices for single path disks. Provisioners would want to document the recommended way to do that (i.e. set find_multipaths = no, and configure the blacklist appropriately).\nis vaguely described as \"target portal ips for high availability\", without describing what the \"high availability\" means. Should we assume that it means multipath? Then Kubernetes can always wait for multipath device to appear when more that one is specified. Would it break anything? Does anyone run multiple portals for the same volume without multipath? Is it something we should support? any opinion?\nyes, the iscsi portals were made possible by for HA/mpio use case (see ). The lack of concrete description makes it less obvious though.\nwas it working perfectly with older kube versions and the issue started to pop up recently or from ? Why I am asking is, multipath support was in kube () and atleast I havent seen this issue reported till this report or very recently. Gluster team were also using multipathing feature for quite some time where we always got mpath device mounted reliably, but noticed this issue very recently or with latest OCP builds. iic, There are good number of changes happened in between especially on device discovery/attach ( ex: ) disk paths. I am not concretely saying its a regression or a behavioral change or side effect of some other patch, but trying to figure out if thats the case. any thoughts here ? my understanding was/is that with more target portal IPs means ( atleast) in ISCSI context, but we could have mention as well in the description. Suppose the backup portal IPs are filled by provisioner/admin but initiator havent enabled ( dm_mulitpath is not loaded or deamon service is not running) software in the kubelet/node, what will happen ? Is it going to be infinite wait for failure ? my understanding is that, if multipath is enabled, even if it failed ( for some reason) for backup paths, a mpath device will be created for single path in the system. If thats the case above shouldnt be a concern and device mapper layer will take care of the path discovery later when path becomes stable/available. I dont think so.\nwe started with 1.9.x on kubelets, so can't tell much about mounting behaviour of previous versions. it is going to fail, but it is fine, nodes should be correctly configured. Lets say you specify fsType, but given FS module is not loaded by kernel, or now mkfs.<FSbinary is available to the kubelet, mount is going to fail and thats OK IMHO. Kubelet shouldn't try to fallback to anything less than was asked, mounting via single portal when multiple portals are specified is similar to trying \"default FS\" if required fsType can't be used. Yes, default configuration for multipathd is option (note, that default in Linux distributions might be different), which creates multipath device for every non-blacklisted block device.\nI'm fairly confident that adding a wait loop for the multipath device in the case when there are 2 or more portals in the PV spec won't cause any regressions. The thing that gives me pause is that there are cases when there's a single portal in the PV spec, but the device still supports multipath and the existing sendtargets command is the mechanism for finding those other paths. I'm wondering if it's possible to detect that case (reliably) and use a wait loop for the multipath device in those cases too.\nis the default on RHEL 7, see\nDid you mean Multiple Connection Per Session (MC/S)? I don't think this is supported in open-iscsi. Open-iSCSI only supports MPIO (multiple portals)\nI don't understand the move by RedHat to default to findmultipaths = no. It basically guarantees bad behavior in cloud-oriented use cases when there's a temporary path failure. My reading of the linked document is that the main motivation for changing the default is to avoid the need to setup a correct blacklist. It seems to me that correct behavior is more important that avoiding some work up front when configuring multipath. No, I'm referring to the . If a storage backend has multiple target portals, but the dynamic provisioner only puts one portal in the PV spec, then as long as that one portal is accessible at attach time, open-iscsi will discover the other portals and log into them. The only weakness to this approach is what happens when that one path is inaccessible at attach time due to a network switch/network port/NIC failure, while the other ports are still available.\n, AFAIK multipathd (binary) in RHEL 7 defaults to , but configuration utility they ship writes config with , that utility needs to be called explicitly , IMHO that should be direct scsi mount unconditionally, without multipath involved\nThe thing that gives me pause is that there are cases when there's a single portal in the PV spec I would be inclined to agree, except that someone the sendtargets logic to the iscsi code. This code exists for no reason other than to allow finding multiple path given a single path. In fact the existing NetApp dynamic provisioner (Trident) relies on that behavior currently to get multipath support (this is something I've fixed and will upstream shortly). If we decide that PVs with exactly one portal should not support multipath, then we should remove that sendtargets logic from the iscsi module in kubelet.", "positive_passages": [{"docid": "doc-en-kubernetes-6188f5739f5024a85ada1fc3f706e7b50690772597d0292fd092153239018a40", "text": "glog.Errorf(\"iscsi: last error occurred during iscsi init:n%v\", lastErr) } <del> //Make sure we use a valid devicepath to find mpio device. devicePath = devicePaths[0] for _, path := range devicePaths { // There shouldnt be any empty device paths. However adding this check // for safer side to avoid the possibility of an empty entry. if path == \"\" { continue } // check if the dev is using mpio and if so mount it via the dm-XX device if mappedDevicePath := b.deviceUtil.FindMultipathDeviceForDevice(path); mappedDevicePath != \"\" { devicePath = mappedDevicePath break } </del> <ins> // Try to find a multipath device for the volume if 1 < len(bkpPortal) { // If the PV has 2 or more portals, wait up to 10 seconds for the multipath // device to appear devicePath = waitForMultiPathToExist(devicePaths, 10, b.deviceUtil) } else { // For PVs with 1 portal, just try one time to find the multipath device. This // avoids a long pause when the multipath device will never get created, and // matches legacy behavior. devicePath = waitForMultiPathToExist(devicePaths, 1, b.deviceUtil) } // When no multipath device is found, just use the first (and presumably only) device if devicePath == \"\" { devicePath = devicePaths[0] </ins> } glog.V(5).Infof(\"iscsi: AttachDisk devicePath: %s\", devicePath)", "commid": "kubernetes_pr_67140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1957c684b46f7dba3b59a7efc638192de1585f81f68da93f440c101bf5bc4bbc", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Download the kube release source artifact from and do a build. All the kube binaries have a extraneous comma in the version: $ /usr/bin/kube-proxy --version Kubernetes v1.9.3, What you expected to happen: kube binaries built from git archive source tgz to show the correct version without extra comma. this was introduced in git attribute export-subst on creates a string format like ''HEAD -release-1.9, tag: v1.9.3, origin/release-1.9' . so, the regex capture should ignore ','\n/sig release\nThe issue is that our regex didn't handle the case where the tag isn't the last part of the string filled in by : One the 1.9.3 source tarball linked, this looks like This should be a pretty easy fix - I don't think commas are allowed in semantic version strings. /assign\n/kind bug /priority important-soon\nThis PR likely affects v1.10 as well. I have a fix out:\nConfirmed: this affects v1.10.0-beta.0 (trying ): Though applying my fix from reveals a different bug: The issue then is that there are multiple tags matching that commit when it was built: who could guess that hacks would break?\ndisregard the second part of my comment above (at least for now); v1.10.0-beta.1 has a more reasonable string: (but it still demonstrates the original bug this issue mentions)\nwe need a sig lead to status/approved-for-milestone here\n/status approved-for-milestone sure, good to be fixed :-)\naaaaaand priority increased and re- to milestone....\n/priority critical-urgent\nMaster branch is fixed. Creating cherry-pick PRs now: 1.9: 1.8: 1.7:\n[MILESTONENOTIFIER] Milestone Issue Labels Incomplete Action required: This issue requires label changes. priority: Must specify exactly one of , or . <details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nCherry pick PRs are in. Next patch release of each branch should be fixed. /close", "positive_passages": [{"docid": "doc-en-kubernetes-f23c1599f9137b27ac8b315291e238f37a1bc19f23f3335ea45766768b81dbbd", "text": "# When a 'git archive' is exported, the '$Format:%D$' below will look # something like 'HEAD -> release-1.8, tag: v1.8.3' where then 'tag: ' # can be extracted from it. <del> if [[ '$Format:%D$' =~ tag: (v[^ ]+) ]]; then </del> <ins> if [[ '$Format:%D$' =~ tag: (v[^ ,]+) ]]; then </ins> KUBE_GIT_VERSION=\"${BASH_REMATCH[1]}\" fi fi", "commid": "kubernetes_pr_61068"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b95e73f98faca5940a16ee2fccddf37ae93437213e073578ff34d76b732271f", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Service loadbalancer source range don't work in ipvs proxy mode. Which result in gci-gce-ipvs CI failed. http://k8s- How to reproduce it (as minimally and precisely as possible): In gce environment. a service with backend. service type to service util service external IP is specified. the service from pod inside and pod out of the . Environment: Kubernetes version (use ): master Cloud provider or hardware configuration: gce OS (e.g. from /etc/os-release): ubuntu Kernel (e.g. ): Install tools: cluster/kube- Others:\n/kind bug /sig network /label ipvs\n/area ipvs\nThe test seems to be flaky now. Can you take a look please?\nI don't know why, but I think this flaky have the similiar reason with other normal service-test cases, like Those flaky are pretty annoying, problem is, I have run those cases in my own environment many times, never fail... : ( But still, I'll do my best to find the reason.", "positive_passages": [{"docid": "doc-en-kubernetes-d8b5b7b988afec59cb144f82f6ded70ab20fcd0503af6cd9b83fc8c6e56348dc", "text": "} if !proxier.lbWhiteListCIDRSet.isEmpty() || !proxier.lbWhiteListIPSet.isEmpty() { // link kube-services chain -> kube-fire-wall chain <del> args := []string{\"-m\", \"set\", \"--match-set\", proxier.lbIngressSet.Name, \"dst,dst\", \"-j\", string(KubeFireWallChain)} if _, err := proxier.iptables.EnsureRule(utiliptables.Append, utiliptables.TableNAT, kubeServicesChain, args...); err != nil { glog.Errorf(\"Failed to ensure that ipset %s chain %s jumps to %s: %v\", proxier.lbIngressSet.Name, kubeServicesChain, KubeFireWallChain, err) </del> <ins> args := []string{ \"-A\", string(kubeServicesChain), \"-m\", \"set\", \"--match-set\", proxier.lbIngressSet.Name, \"dst,dst\", \"-j\", string(KubeFireWallChain), </ins> } <ins> writeLine(proxier.natRules, args...) </ins> if !proxier.lbWhiteListCIDRSet.isEmpty() { args = append(args[:0], \"-A\", string(KubeFireWallChain),", "commid": "kubernetes_pr_61091"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b95e73f98faca5940a16ee2fccddf37ae93437213e073578ff34d76b732271f", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Service loadbalancer source range don't work in ipvs proxy mode. Which result in gci-gce-ipvs CI failed. http://k8s- How to reproduce it (as minimally and precisely as possible): In gce environment. a service with backend. service type to service util service external IP is specified. the service from pod inside and pod out of the . Environment: Kubernetes version (use ): master Cloud provider or hardware configuration: gce OS (e.g. from /etc/os-release): ubuntu Kernel (e.g. ): Install tools: cluster/kube- Others:\n/kind bug /sig network /label ipvs\n/area ipvs\nThe test seems to be flaky now. Can you take a look please?\nI don't know why, but I think this flaky have the similiar reason with other normal service-test cases, like Those flaky are pretty annoying, problem is, I have run those cases in my own environment many times, never fail... : ( But still, I'll do my best to find the reason.", "positive_passages": [{"docid": "doc-en-kubernetes-cb587eb71b08fdf3c04dd1339074e019337bb8d9c2ff042cb4631abcddb39e70", "text": "\"fmt\" \"net\" \"reflect\" <ins> \"strings\" </ins> \"testing\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"", "commid": "kubernetes_pr_61091"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b95e73f98faca5940a16ee2fccddf37ae93437213e073578ff34d76b732271f", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Service loadbalancer source range don't work in ipvs proxy mode. Which result in gci-gce-ipvs CI failed. http://k8s- How to reproduce it (as minimally and precisely as possible): In gce environment. a service with backend. service type to service util service external IP is specified. the service from pod inside and pod out of the . Environment: Kubernetes version (use ): master Cloud provider or hardware configuration: gce OS (e.g. from /etc/os-release): ubuntu Kernel (e.g. ): Install tools: cluster/kube- Others:\n/kind bug /sig network /label ipvs\n/area ipvs\nThe test seems to be flaky now. Can you take a look please?\nI don't know why, but I think this flaky have the similiar reason with other normal service-test cases, like Those flaky are pretty annoying, problem is, I have run those cases in my own environment many times, never fail... : ( But still, I'll do my best to find the reason.", "positive_passages": [{"docid": "doc-en-kubernetes-c3be7299c05eef6b667287d1018676222ff29060d0795250627a26330de752bd", "text": "t.Errorf(\"Expect node port type service, got none\") } } <ins> func TestLoadBalanceSourceRanges(t *testing.T) { ipt := iptablestest.NewFake() ipvs := ipvstest.NewFake() ipset := ipsettest.NewFake(testIPSetVersion) fp := NewFakeProxier(ipt, ipvs, ipset, nil) svcIP := \"10.20.30.41\" svcPort := 80 svcLBIP := \"1.2.3.4\" svcLBSource := \"10.0.0.0/8\" svcPortName := proxy.ServicePortName{ NamespacedName: makeNSN(\"ns1\", \"svc1\"), Port:           \"p80\", } epIP := \"10.180.0.1\" makeServiceMap(fp, makeTestService(svcPortName.Namespace, svcPortName.Name, func(svc *api.Service) { svc.Spec.Type = \"LoadBalancer\" svc.Spec.ClusterIP = svcIP svc.Spec.Ports = []api.ServicePort{{ Name:     svcPortName.Port, Port:     int32(svcPort), Protocol: api.ProtocolTCP, }} svc.Status.LoadBalancer.Ingress = []api.LoadBalancerIngress{{ IP: svcLBIP, }} svc.Spec.LoadBalancerSourceRanges = []string{ svcLBSource, } }), ) makeEndpointsMap(fp, makeTestEndpoints(svcPortName.Namespace, svcPortName.Name, func(ept *api.Endpoints) { ept.Subsets = []api.EndpointSubset{{ Addresses: []api.EndpointAddress{{ IP:       epIP, NodeName: strPtr(testHostname), }}, Ports: []api.EndpointPort{{ Name: svcPortName.Port, Port: int32(svcPort), }}, }} }), ) fp.syncProxyRules() // Check ipvs service and destinations services, err := ipvs.GetVirtualServers() if err != nil { t.Errorf(\"Failed to get ipvs services, err: %v\", err) } found := false for _, svc := range services { fmt.Printf(\"address: %s:%d, %s\", svc.Address.String(), svc.Port, svc.Protocol) if svc.Address.Equal(net.ParseIP(svcLBIP)) && svc.Port == uint16(svcPort) && svc.Protocol == string(api.ProtocolTCP) { destinations, _ := ipvs.GetRealServers(svc) if len(destinations) != 1 { t.Errorf(\"Unexpected %d destinations, expect 0 destinations\", len(destinations)) } for _, ep := range destinations { if ep.Address.String() == epIP && ep.Port == uint16(svcPort) { found = true } } } } if !found { t.Errorf(\"Did not got expected loadbalance service\") } // Check ipset entry expectIPSet := map[string]*utilipset.Entry{ KubeLoadBalancerSet: { IP:       svcLBIP, Port:     svcPort, Protocol: strings.ToLower(string(api.ProtocolTCP)), SetType:  utilipset.HashIPPort, }, KubeLoadBalancerMasqSet: { IP:       svcLBIP, Port:     svcPort, Protocol: strings.ToLower(string(api.ProtocolTCP)), SetType:  utilipset.HashIPPort, }, KubeLoadBalancerSourceCIDRSet: { IP:       svcLBIP, Port:     svcPort, Protocol: strings.ToLower(string(api.ProtocolTCP)), Net:      svcLBSource, SetType:  utilipset.HashIPPortNet, }, } for set, entry := range expectIPSet { ents, err := ipset.ListEntries(set) if err != nil || len(ents) != 1 { t.Errorf(\"Check ipset entries failed for ipset: %q\", set) continue } if ents[0] != entry.String() { t.Errorf(\"Check ipset entries failed for ipset: %q\", set) } } // Check iptables chain and rules kubeSvcRules := ipt.GetRules(string(kubeServicesChain)) kubeFWRules := ipt.GetRules(string(KubeFireWallChain)) if !hasJump(kubeSvcRules, string(KubeMarkMasqChain), KubeLoadBalancerMasqSet) { t.Errorf(\"Didn't find jump from chain %v match set %v to MASQUERADE\", kubeServicesChain, KubeLoadBalancerMasqSet) } if !hasJump(kubeSvcRules, string(KubeFireWallChain), KubeLoadBalancerSet) { t.Errorf(\"Didn't find jump from chain %v match set %v to %v\", kubeServicesChain, KubeLoadBalancerSet, KubeFireWallChain) } if !hasJump(kubeFWRules, \"ACCEPT\", KubeLoadBalancerSourceCIDRSet) { t.Errorf(\"Didn't find jump from chain %v match set %v to ACCEPT\", kubeServicesChain, KubeLoadBalancerSourceCIDRSet) } } </ins> func TestOnlyLocalLoadBalancing(t *testing.T) { ipt := iptablestest.NewFake()", "commid": "kubernetes_pr_61091"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b95e73f98faca5940a16ee2fccddf37ae93437213e073578ff34d76b732271f", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Service loadbalancer source range don't work in ipvs proxy mode. Which result in gci-gce-ipvs CI failed. http://k8s- How to reproduce it (as minimally and precisely as possible): In gce environment. a service with backend. service type to service util service external IP is specified. the service from pod inside and pod out of the . Environment: Kubernetes version (use ): master Cloud provider or hardware configuration: gce OS (e.g. from /etc/os-release): ubuntu Kernel (e.g. ): Install tools: cluster/kube- Others:\n/kind bug /sig network /label ipvs\n/area ipvs\nThe test seems to be flaky now. Can you take a look please?\nI don't know why, but I think this flaky have the similiar reason with other normal service-test cases, like Those flaky are pretty annoying, problem is, I have run those cases in my own environment many times, never fail... : ( But still, I'll do my best to find the reason.", "positive_passages": [{"docid": "doc-en-kubernetes-7370a595c266f58e16dfadcc43e67e51e6781c1ebbd5ad0b3f2237523c96ac67", "text": "} } } <ins> func hasJump(rules []iptablestest.Rule, destChain, ipSet string) bool { match := false for _, r := range rules { if r[iptablestest.Jump] == destChain { match = true if ipSet != \"\" { if strings.Contains(r[iptablestest.MatchSet], ipSet) { return true } match = false } } } return match } </ins>", "commid": "kubernetes_pr_61091"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b95e73f98faca5940a16ee2fccddf37ae93437213e073578ff34d76b732271f", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Service loadbalancer source range don't work in ipvs proxy mode. Which result in gci-gce-ipvs CI failed. http://k8s- How to reproduce it (as minimally and precisely as possible): In gce environment. a service with backend. service type to service util service external IP is specified. the service from pod inside and pod out of the . Environment: Kubernetes version (use ): master Cloud provider or hardware configuration: gce OS (e.g. from /etc/os-release): ubuntu Kernel (e.g. ): Install tools: cluster/kube- Others:\n/kind bug /sig network /label ipvs\n/area ipvs\nThe test seems to be flaky now. Can you take a look please?\nI don't know why, but I think this flaky have the similiar reason with other normal service-test cases, like Those flaky are pretty annoying, problem is, I have run those cases in my own environment many times, never fail... : ( But still, I'll do my best to find the reason.", "positive_passages": [{"docid": "doc-en-kubernetes-469d90a0027521be7f34c93b119d7a460cfc9ca845b80a3804fd3868551580ae", "text": "Reject      = \"REJECT\" ToDest      = \"--to-destination \" Recent      = \"recent \" <ins> MatchSet    = \"--match-set \" </ins> ) type Rule map[string]string", "commid": "kubernetes_pr_61091"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b95e73f98faca5940a16ee2fccddf37ae93437213e073578ff34d76b732271f", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Service loadbalancer source range don't work in ipvs proxy mode. Which result in gci-gce-ipvs CI failed. http://k8s- How to reproduce it (as minimally and precisely as possible): In gce environment. a service with backend. service type to service util service external IP is specified. the service from pod inside and pod out of the . Environment: Kubernetes version (use ): master Cloud provider or hardware configuration: gce OS (e.g. from /etc/os-release): ubuntu Kernel (e.g. ): Install tools: cluster/kube- Others:\n/kind bug /sig network /label ipvs\n/area ipvs\nThe test seems to be flaky now. Can you take a look please?\nI don't know why, but I think this flaky have the similiar reason with other normal service-test cases, like Those flaky are pretty annoying, problem is, I have run those cases in my own environment many times, never fail... : ( But still, I'll do my best to find the reason.", "positive_passages": [{"docid": "doc-en-kubernetes-fbfbad523648010f75f75eda52015a203819bfd213b9fdbf65c0683bfbc1e410", "text": "for _, l := range strings.Split(string(f.Lines), \"n\") { if strings.Contains(l, fmt.Sprintf(\"-A %v\", chainName)) { newRule := Rule(map[string]string{}) <del> for _, arg := range []string{Destination, Source, DPort, Protocol, Jump, ToDest, Recent} { </del> <ins> for _, arg := range []string{Destination, Source, DPort, Protocol, Jump, ToDest, Recent, MatchSet} { </ins> tok := getToken(l, arg) if tok != \"\" { newRule[arg] = tok", "commid": "kubernetes_pr_61091"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1e6e7a922459aa1ae762d90ee2c0c561e09f7928de6f5ad4ad5cc72934b7dcd1", "query": "New tests for subpath consistently fail in ci-kubernetes-e2e-gce-multizone: https://k8s- /kind bug /sig storage\nIs this a blocker for 1.10?\nI would expect so, yes. /milestone v1.10\nI'm on it /assign\nThe problem is likely due to inline GCE PD volumes not having enough zone information. Considering changing volumes to PVs instead.\nfix was in progress in to change to a PV\n/unassign\n[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-086eef9604a2614cb1940562ab07df053b6265e68437ee83fa88c287bd8f437c", "text": "} type gcepdSource struct { <del> diskName string </del> <ins> pvc *v1.PersistentVolumeClaim </ins> } func initGCEPD() volSource {", "commid": "kubernetes_pr_61111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1e6e7a922459aa1ae762d90ee2c0c561e09f7928de6f5ad4ad5cc72934b7dcd1", "query": "New tests for subpath consistently fail in ci-kubernetes-e2e-gce-multizone: https://k8s- /kind bug /sig storage\nIs this a blocker for 1.10?\nI would expect so, yes. /milestone v1.10\nI'm on it /assign\nThe problem is likely due to inline GCE PD volumes not having enough zone information. Considering changing volumes to PVs instead.\nfix was in progress in to change to a PV\n/unassign\n[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details", "positive_passages": [{"docid": "doc-en-kubernetes-afb8259b72328e33b04ceb5df41ec289c627dc4f135cbc191e848845e9f32bfd", "text": "func (s *gcepdSource) createVolume(f *framework.Framework) volInfo { var err error <del> framework.Logf(\"Creating GCE PD volume\") s.diskName, err = framework.CreatePDWithRetry() framework.ExpectNoError(err, \"Error creating PD\") </del> <ins> framework.Logf(\"Creating GCE PD volume via dynamic provisioning\") testCase := storageClassTest{ name:      \"subpath\", claimSize: \"2G\", } pvc := newClaim(testCase, f.Namespace.Name, \"subpath\") s.pvc, err = framework.CreatePVC(f.ClientSet, f.Namespace.Name, pvc) framework.ExpectNoError(err, \"Error creating PVC\") </ins> return volInfo{ source: &v1.VolumeSource{ <del> GCEPersistentDisk: &v1.GCEPersistentDiskVolumeSource{PDName: s.diskName}, </del> <ins> PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{ ClaimName: s.pvc.Name, }, </ins> }, } } func (s *gcepdSource) cleanupVolume(f *framework.Framework) { <del> if s.diskName != \"\" { err := framework.DeletePDWithRetry(s.diskName) framework.ExpectNoError(err, \"Error deleting PD\") </del> <ins> if s.pvc != nil { err := f.ClientSet.CoreV1().PersistentVolumeClaims(f.Namespace.Name).Delete(s.pvc.Name, nil) framework.ExpectNoError(err, \"Error deleting PVC\") </ins> } }", "commid": "kubernetes_pr_61111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-897c473b11be2622aeec9f7a71c36a9c53396d522c6fb073dc9f488488c3739c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: e2e test \"gci-gce\" is running in 2 versions: with kube-dns as DNS Service : https://k8s- with CoreDNS as DNS Service : https://k8s- In CoreDNS use case the test is failing What you expected to happen: This e2e tests should not depend on what DNS service is running as default in K8s. CoreDNS is currently BETA, will move to GA soon (after v1.10 though) See : How to reproduce it (as minimally and precisely as possible): look at logs of dashboard : https://k8s- go run -v --test --test_args='--[sig-autoscaling]sDNSshorizontalsautoscalings[DisabledForLargeClusters]skube-dns-autoscalersshouldsscaleskube-dnsspodssinsbothsnonfaultysandsfaultysscenarios$' Anything else we need to know?: Environment: Kubernetes version (use ): branch master Cloud provider or hardware configuration: GCE Install tools: deployment intra-test Others: see https://k8s-\n/sig autoscaling\n/unsig cli\nLooks like the test is searching specifically for a deployment labeled \"kube-dns\". There are several references to \"kube-dns\" scattered around it, actually.\nRight now the tool \"dns-horizontal-autoscaller\" seems dedicated for kube-dns. This tools is deployed as \"add-on\" when enabled by this ENV variable : I guess we should have the definition of another dns-horizontal-autoscaller, dedicated to coredns (unless we generate the yaml file). and the choice of deployment is based on the ENV variable . see\nCurrently, the translation of the deployment of \"dns-horizontal-autoscaller\" for CoreDNS is in progress by It is expected that the corresponding e2e test will work as is (as the artifacts are selected by labels, which are the same for CroeDNS and kube-dns).", "positive_passages": [{"docid": "doc-en-kubernetes-dda332f7e4ffb2a04ba19eb7acbd49cca29605c4f8dc2f351aabc94ff9c1cc21", "text": "- --namespace=kube-system - --configmap=kube-dns-autoscaler # Should keep target in sync with cluster/addons/dns/kube-dns.yaml.base <del> - --target=Deployment/kube-dns </del> <ins> - --target={{.Target}} </ins> # When cluster is using large nodes(with more cores), \"coresPerReplica\" should dominate. # If using small nodes, \"nodesPerReplica\" should dominate. - --default-params={\"linear\":{\"coresPerReplica\":256,\"nodesPerReplica\":16,\"preventSinglePointFailure\":true}}", "commid": "kubernetes_pr_62409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-897c473b11be2622aeec9f7a71c36a9c53396d522c6fb073dc9f488488c3739c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: e2e test \"gci-gce\" is running in 2 versions: with kube-dns as DNS Service : https://k8s- with CoreDNS as DNS Service : https://k8s- In CoreDNS use case the test is failing What you expected to happen: This e2e tests should not depend on what DNS service is running as default in K8s. CoreDNS is currently BETA, will move to GA soon (after v1.10 though) See : How to reproduce it (as minimally and precisely as possible): look at logs of dashboard : https://k8s- go run -v --test --test_args='--[sig-autoscaling]sDNSshorizontalsautoscalings[DisabledForLargeClusters]skube-dns-autoscalersshouldsscaleskube-dnsspodssinsbothsnonfaultysandsfaultysscenarios$' Anything else we need to know?: Environment: Kubernetes version (use ): branch master Cloud provider or hardware configuration: GCE Install tools: deployment intra-test Others: see https://k8s-\n/sig autoscaling\n/unsig cli\nLooks like the test is searching specifically for a deployment labeled \"kube-dns\". There are several references to \"kube-dns\" scattered around it, actually.\nRight now the tool \"dns-horizontal-autoscaller\" seems dedicated for kube-dns. This tools is deployed as \"add-on\" when enabled by this ENV variable : I guess we should have the definition of another dns-horizontal-autoscaller, dedicated to coredns (unless we generate the yaml file). and the choice of deployment is based on the ENV variable . see\nCurrently, the translation of the deployment of \"dns-horizontal-autoscaller\" for CoreDNS is in progress by It is expected that the corresponding e2e test will work as is (as the artifacts are selected by labels, which are the same for CroeDNS and kube-dns).", "positive_passages": [{"docid": "doc-en-kubernetes-5f3008db0eff7e075d131cc6b0c9322c67d6ffc88d207fc590b6a6dc6265991b", "text": "apiVersion: v1 kind: Service metadata: <del> name: coredns </del> <ins> name: kube-dns </ins> namespace: kube-system labels: <del> k8s-app: coredns </del> <ins> k8s-app: kube-dns </ins> kubernetes.io/cluster-service: \"true\" addonmanager.kubernetes.io/mode: Reconcile kubernetes.io/name: \"CoreDNS\" spec: selector: <del> k8s-app: coredns </del> <ins> k8s-app: kube-dns </ins> clusterIP: __PILLAR__DNS__SERVER__ ports: - name: dns", "commid": "kubernetes_pr_62409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-897c473b11be2622aeec9f7a71c36a9c53396d522c6fb073dc9f488488c3739c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: e2e test \"gci-gce\" is running in 2 versions: with kube-dns as DNS Service : https://k8s- with CoreDNS as DNS Service : https://k8s- In CoreDNS use case the test is failing What you expected to happen: This e2e tests should not depend on what DNS service is running as default in K8s. CoreDNS is currently BETA, will move to GA soon (after v1.10 though) See : How to reproduce it (as minimally and precisely as possible): look at logs of dashboard : https://k8s- go run -v --test --test_args='--[sig-autoscaling]sDNSshorizontalsautoscalings[DisabledForLargeClusters]skube-dns-autoscalersshouldsscaleskube-dnsspodssinsbothsnonfaultysandsfaultysscenarios$' Anything else we need to know?: Environment: Kubernetes version (use ): branch master Cloud provider or hardware configuration: GCE Install tools: deployment intra-test Others: see https://k8s-\n/sig autoscaling\n/unsig cli\nLooks like the test is searching specifically for a deployment labeled \"kube-dns\". There are several references to \"kube-dns\" scattered around it, actually.\nRight now the tool \"dns-horizontal-autoscaller\" seems dedicated for kube-dns. This tools is deployed as \"add-on\" when enabled by this ENV variable : I guess we should have the definition of another dns-horizontal-autoscaller, dedicated to coredns (unless we generate the yaml file). and the choice of deployment is based on the ENV variable . see\nCurrently, the translation of the deployment of \"dns-horizontal-autoscaller\" for CoreDNS is in progress by It is expected that the corresponding e2e test will work as is (as the artifacts are selected by labels, which are the same for CroeDNS and kube-dns).", "positive_passages": [{"docid": "doc-en-kubernetes-cabf65f86133816f68e4373bd44d1565de74e5133727e5e758aa26b43a50c30b", "text": "apiVersion: v1 kind: Service metadata: <del> name: coredns </del> <ins> name: kube-dns </ins> namespace: kube-system labels: <del> k8s-app: coredns </del> <ins> k8s-app: kube-dns </ins> kubernetes.io/cluster-service: \"true\" addonmanager.kubernetes.io/mode: Reconcile kubernetes.io/name: \"CoreDNS\" spec: selector: <del> k8s-app: coredns </del> <ins> k8s-app: kube-dns </ins> clusterIP: {{ pillar['dns_server'] }} ports: - name: dns", "commid": "kubernetes_pr_62409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-897c473b11be2622aeec9f7a71c36a9c53396d522c6fb073dc9f488488c3739c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: e2e test \"gci-gce\" is running in 2 versions: with kube-dns as DNS Service : https://k8s- with CoreDNS as DNS Service : https://k8s- In CoreDNS use case the test is failing What you expected to happen: This e2e tests should not depend on what DNS service is running as default in K8s. CoreDNS is currently BETA, will move to GA soon (after v1.10 though) See : How to reproduce it (as minimally and precisely as possible): look at logs of dashboard : https://k8s- go run -v --test --test_args='--[sig-autoscaling]sDNSshorizontalsautoscalings[DisabledForLargeClusters]skube-dns-autoscalersshouldsscaleskube-dnsspodssinsbothsnonfaultysandsfaultysscenarios$' Anything else we need to know?: Environment: Kubernetes version (use ): branch master Cloud provider or hardware configuration: GCE Install tools: deployment intra-test Others: see https://k8s-\n/sig autoscaling\n/unsig cli\nLooks like the test is searching specifically for a deployment labeled \"kube-dns\". There are several references to \"kube-dns\" scattered around it, actually.\nRight now the tool \"dns-horizontal-autoscaller\" seems dedicated for kube-dns. This tools is deployed as \"add-on\" when enabled by this ENV variable : I guess we should have the definition of another dns-horizontal-autoscaller, dedicated to coredns (unless we generate the yaml file). and the choice of deployment is based on the ENV variable . see\nCurrently, the translation of the deployment of \"dns-horizontal-autoscaller\" for CoreDNS is in progress by It is expected that the corresponding e2e test will work as is (as the artifacts are selected by labels, which are the same for CroeDNS and kube-dns).", "positive_passages": [{"docid": "doc-en-kubernetes-268596d9580dbed0c12fb681ab4717168615bf8a3526ed0048473dfb50c8afcb", "text": "name: coredns namespace: kube-system labels: <del> k8s-app: coredns </del> <ins> k8s-app: kube-dns </ins> kubernetes.io/cluster-service: \"true\" addonmanager.kubernetes.io/mode: Reconcile kubernetes.io/name: \"CoreDNS\" spec: <del> replicas: 2 </del> <ins> # replicas: not specified here: # 1. In order to make Addon Manager do not reconcile this replicas parameter. # 2. Default is 1. # 3. Will be tuned in real time if DNS horizontal auto-scaling is turned on. </ins> strategy: type: RollingUpdate rollingUpdate: maxUnavailable: 1 selector: matchLabels: <del> k8s-app: coredns </del> <ins> k8s-app: kube-dns </ins> template: metadata: labels: <del> k8s-app: coredns </del> <ins> k8s-app: kube-dns </ins> spec: serviceAccountName: coredns tolerations:", "commid": "kubernetes_pr_62409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-897c473b11be2622aeec9f7a71c36a9c53396d522c6fb073dc9f488488c3739c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: e2e test \"gci-gce\" is running in 2 versions: with kube-dns as DNS Service : https://k8s- with CoreDNS as DNS Service : https://k8s- In CoreDNS use case the test is failing What you expected to happen: This e2e tests should not depend on what DNS service is running as default in K8s. CoreDNS is currently BETA, will move to GA soon (after v1.10 though) See : How to reproduce it (as minimally and precisely as possible): look at logs of dashboard : https://k8s- go run -v --test --test_args='--[sig-autoscaling]sDNSshorizontalsautoscalings[DisabledForLargeClusters]skube-dns-autoscalersshouldsscaleskube-dnsspodssinsbothsnonfaultysandsfaultysscenarios$' Anything else we need to know?: Environment: Kubernetes version (use ): branch master Cloud provider or hardware configuration: GCE Install tools: deployment intra-test Others: see https://k8s-\n/sig autoscaling\n/unsig cli\nLooks like the test is searching specifically for a deployment labeled \"kube-dns\". There are several references to \"kube-dns\" scattered around it, actually.\nRight now the tool \"dns-horizontal-autoscaller\" seems dedicated for kube-dns. This tools is deployed as \"add-on\" when enabled by this ENV variable : I guess we should have the definition of another dns-horizontal-autoscaller, dedicated to coredns (unless we generate the yaml file). and the choice of deployment is based on the ENV variable . see\nCurrently, the translation of the deployment of \"dns-horizontal-autoscaller\" for CoreDNS is in progress by It is expected that the corresponding e2e test will work as is (as the artifacts are selected by labels, which are the same for CroeDNS and kube-dns).", "positive_passages": [{"docid": "doc-en-kubernetes-ac9cb48b0587730256f82a94efd5587742ce13747c2e20a4af539d1bc54af396", "text": "apiVersion: v1 kind: Service metadata: <del> name: coredns </del> <ins> name: kube-dns </ins> namespace: kube-system labels: <del> k8s-app: coredns </del> <ins> k8s-app: kube-dns </ins> kubernetes.io/cluster-service: \"true\" addonmanager.kubernetes.io/mode: Reconcile kubernetes.io/name: \"CoreDNS\" spec: selector: <del> k8s-app: coredns </del> <ins> k8s-app: kube-dns </ins> clusterIP: $DNS_SERVER_IP ports: - name: dns", "commid": "kubernetes_pr_62409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-897c473b11be2622aeec9f7a71c36a9c53396d522c6fb073dc9f488488c3739c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: e2e test \"gci-gce\" is running in 2 versions: with kube-dns as DNS Service : https://k8s- with CoreDNS as DNS Service : https://k8s- In CoreDNS use case the test is failing What you expected to happen: This e2e tests should not depend on what DNS service is running as default in K8s. CoreDNS is currently BETA, will move to GA soon (after v1.10 though) See : How to reproduce it (as minimally and precisely as possible): look at logs of dashboard : https://k8s- go run -v --test --test_args='--[sig-autoscaling]sDNSshorizontalsautoscalings[DisabledForLargeClusters]skube-dns-autoscalersshouldsscaleskube-dnsspodssinsbothsnonfaultysandsfaultysscenarios$' Anything else we need to know?: Environment: Kubernetes version (use ): branch master Cloud provider or hardware configuration: GCE Install tools: deployment intra-test Others: see https://k8s-\n/sig autoscaling\n/unsig cli\nLooks like the test is searching specifically for a deployment labeled \"kube-dns\". There are several references to \"kube-dns\" scattered around it, actually.\nRight now the tool \"dns-horizontal-autoscaller\" seems dedicated for kube-dns. This tools is deployed as \"add-on\" when enabled by this ENV variable : I guess we should have the definition of another dns-horizontal-autoscaller, dedicated to coredns (unless we generate the yaml file). and the choice of deployment is based on the ENV variable . see\nCurrently, the translation of the deployment of \"dns-horizontal-autoscaller\" for CoreDNS is in progress by It is expected that the corresponding e2e test will work as is (as the artifacts are selected by labels, which are the same for CroeDNS and kube-dns).", "positive_passages": [{"docid": "doc-en-kubernetes-52f1e74a604d1e606f381316298f2e75501bb8ae9e37b3268eec658f50eb6826", "text": "readonly UUID_MNT_PREFIX=\"/mnt/disks/by-uuid/google-local-ssds\" readonly UUID_BLOCK_PREFIX=\"/dev/disk/by-uuid/google-local-ssds\" <ins> readonly COREDNS_AUTOSCALER=\"Deployment/coredns\" readonly KUBEDNS_AUTOSCALER=\"Deployment/kube-dns\" </ins> # Use --retry-connrefused opt only if it's supported by curl. CURL_RETRY_CONNREFUSED=\"\"", "commid": "kubernetes_pr_62409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-897c473b11be2622aeec9f7a71c36a9c53396d522c6fb073dc9f488488c3739c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: e2e test \"gci-gce\" is running in 2 versions: with kube-dns as DNS Service : https://k8s- with CoreDNS as DNS Service : https://k8s- In CoreDNS use case the test is failing What you expected to happen: This e2e tests should not depend on what DNS service is running as default in K8s. CoreDNS is currently BETA, will move to GA soon (after v1.10 though) See : How to reproduce it (as minimally and precisely as possible): look at logs of dashboard : https://k8s- go run -v --test --test_args='--[sig-autoscaling]sDNSshorizontalsautoscalings[DisabledForLargeClusters]skube-dns-autoscalersshouldsscaleskube-dnsspodssinsbothsnonfaultysandsfaultysscenarios$' Anything else we need to know?: Environment: Kubernetes version (use ): branch master Cloud provider or hardware configuration: GCE Install tools: deployment intra-test Others: see https://k8s-\n/sig autoscaling\n/unsig cli\nLooks like the test is searching specifically for a deployment labeled \"kube-dns\". There are several references to \"kube-dns\" scattered around it, actually.\nRight now the tool \"dns-horizontal-autoscaller\" seems dedicated for kube-dns. This tools is deployed as \"add-on\" when enabled by this ENV variable : I guess we should have the definition of another dns-horizontal-autoscaller, dedicated to coredns (unless we generate the yaml file). and the choice of deployment is based on the ENV variable . see\nCurrently, the translation of the deployment of \"dns-horizontal-autoscaller\" for CoreDNS is in progress by It is expected that the corresponding e2e test will work as is (as the artifacts are selected by labels, which are the same for CroeDNS and kube-dns).", "positive_passages": [{"docid": "doc-en-kubernetes-bfdd3c6789bfeed3a7497af3d7939ca27c4c971ea8984c1550e9af74823ad8b0", "text": "sed -i -e \"s@{{ *pillar['dns_domain'] *}}@${DNS_DOMAIN}@g\" \"${coredns_file}\" sed -i -e \"s@{{ *pillar['dns_server'] *}}@${DNS_SERVER_IP}@g\" \"${coredns_file}\" sed -i -e \"s@{{ *pillar['service_cluster_ip_range'] *}}@${SERVICE_CLUSTER_IP_RANGE}@g\" \"${coredns_file}\" <ins> if [[ \"${ENABLE_DNS_HORIZONTAL_AUTOSCALER:-}\" == \"true\" ]]; then setup-addon-manifests \"addons\" \"dns-horizontal-autoscaler\" \"gce\" local -r dns_autoscaler_file=\"${dst_dir}/dns-horizontal-autoscaler/dns-horizontal-autoscaler.yaml\" sed -i'' -e \"s@{{.Target}}@${COREDNS_AUTOSCALER}@g\" \"${dns_autoscaler_file}\" fi </ins> } # Sets up the manifests of Fluentd configmap and yamls for k8s addons.", "commid": "kubernetes_pr_62409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-897c473b11be2622aeec9f7a71c36a9c53396d522c6fb073dc9f488488c3739c", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: e2e test \"gci-gce\" is running in 2 versions: with kube-dns as DNS Service : https://k8s- with CoreDNS as DNS Service : https://k8s- In CoreDNS use case the test is failing What you expected to happen: This e2e tests should not depend on what DNS service is running as default in K8s. CoreDNS is currently BETA, will move to GA soon (after v1.10 though) See : How to reproduce it (as minimally and precisely as possible): look at logs of dashboard : https://k8s- go run -v --test --test_args='--[sig-autoscaling]sDNSshorizontalsautoscalings[DisabledForLargeClusters]skube-dns-autoscalersshouldsscaleskube-dnsspodssinsbothsnonfaultysandsfaultysscenarios$' Anything else we need to know?: Environment: Kubernetes version (use ): branch master Cloud provider or hardware configuration: GCE Install tools: deployment intra-test Others: see https://k8s-\n/sig autoscaling\n/unsig cli\nLooks like the test is searching specifically for a deployment labeled \"kube-dns\". There are several references to \"kube-dns\" scattered around it, actually.\nRight now the tool \"dns-horizontal-autoscaller\" seems dedicated for kube-dns. This tools is deployed as \"add-on\" when enabled by this ENV variable : I guess we should have the definition of another dns-horizontal-autoscaller, dedicated to coredns (unless we generate the yaml file). and the choice of deployment is based on the ENV variable . see\nCurrently, the translation of the deployment of \"dns-horizontal-autoscaller\" for CoreDNS is in progress by It is expected that the corresponding e2e test will work as is (as the artifacts are selected by labels, which are the same for CroeDNS and kube-dns).", "positive_passages": [{"docid": "doc-en-kubernetes-163a93ecb7527f21403a0296333c036a253355453b0d056f6e05cda3fecf3dc3", "text": "if [[ \"${ENABLE_DNS_HORIZONTAL_AUTOSCALER:-}\" == \"true\" ]]; then setup-addon-manifests \"addons\" \"dns-horizontal-autoscaler\" \"gce\" <ins> local -r dns_autoscaler_file=\"${dst_dir}/dns-horizontal-autoscaler/dns-horizontal-autoscaler.yaml\" sed -i'' -e \"s@{{.Target}}@${KUBEDNS_AUTOSCALER}@g\" \"${dns_autoscaler_file}\" </ins> fi }", "commid": "kubernetes_pr_62409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c3f9dbcfbf0abfa183188a971933f09b1bd1d9b55d8d4f63807c7685fadf987b", "query": "/sig gcp /sig cluster-life-cycle /kind flake /milestone v1.10 cc https://k8s- starting last night /assign can one of you verify?\n/kind bug /priority important-soon\n/priority critical-urgent /priority failing-test /status approved-for-milestone\n[MILESTONENOTIFIER] Milestone Issue Needs Attention Action required: During code freeze, issues in the milestone should be in progress. If this issue is not being actively worked on, please remove it from the milestone. If it is being worked on, please add the label so it can be tracked with other in-flight issues. Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\n/assign according to , gonna move those jobs to us-central1-c instead", "positive_passages": [{"docid": "doc-en-kubernetes-81e55ee5b1e7db05e2fd9deb724f64eba763bcf1fbf76f8f3b15f3ac0af9a4eb", "text": "containers: - name: influxdb image: gcr.io/google_containers/heapster_influxdb:v0.3 <ins> ports: - containerPort: 8083 hostPort: 8083 - containerPort: 8086 hostPort: 8086 </ins> - name: grafana image: gcr.io/google_containers/heapster_grafana:v0.6 env:", "commid": "kubernetes_pr_7320"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c3f9dbcfbf0abfa183188a971933f09b1bd1d9b55d8d4f63807c7685fadf987b", "query": "/sig gcp /sig cluster-life-cycle /kind flake /milestone v1.10 cc https://k8s- starting last night /assign can one of you verify?\n/kind bug /priority important-soon\n/priority critical-urgent /priority failing-test /status approved-for-milestone\n[MILESTONENOTIFIER] Milestone Issue Needs Attention Action required: During code freeze, issues in the milestone should be in progress. If this issue is not being actively worked on, please remove it from the milestone. If it is being worked on, please add the label so it can be tracked with other in-flight issues. Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\n/assign according to , gonna move those jobs to us-central1-c instead", "positive_passages": [{"docid": "doc-en-kubernetes-3b53ce3da93f066e552282c318b411f91b88e3e485ac4274fe7fe9ca69035a2b", "text": "containers: - image: gcr.io/google_containers/heapster_influxdb:v0.3 name: influxdb <ins> ports: - containerPort: 8083 hostPort: 8083 - containerPort: 8086 hostPort: 8086 </ins> - name: grafana image: gcr.io/google_containers/heapster_grafana:v0.6 env:", "commid": "kubernetes_pr_7320"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8e791342a72fb228aa97c5b91a2cfb5922e30c40e783a5d69356e7bc9daaf03d", "query": "/kind bug What happened: We had a pod with persistent storage. We drained the node. The node VM was deleted. The PV was not attached to the node that the Pod migrated too. The kube-controller-manager logs contained the following. What you expected to happen: The PV can be attached to the node it was migrated to. How to reproduce it (as minimally and precisely as possible): Create a 2 node cluster on vSphere Deploy a pod with persistent storage attached Drain the node Delete the node VM immediately after draining Anything else we need to know?: The issue seems to be in the call to getVSphereInstance. This will return an error if the Node doesn't exist. Precluding the logic on line 804-813 from being executed. A restart of the kube-controller-manager resolved the issue. The following e2e test is not triggered in vSphere environments - Which might expose the issue. Environment: Kubernetes version (use ): 1.9.5 Cloud provider or hardware configuration: vSphere OS (e.g. from /etc/os-release): ubuntu Kernel (e.g. ): Install tools: CFCR Others: /sig storage /sig vmware\nMore logs:\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-479247e3e0c0729ebc42ba7abbb564f173e1a9ecca0504777e00c44f17e1f6a9", "text": "defer cancel() vsi, err := vs.getVSphereInstance(nodeName) if err != nil { <ins> // If node doesn't exist, disk is already detached from node. if err == vclib.ErrNoVMFound { glog.Infof(\"Node %q does not exist, disk %s is already detached from node.\", convertToString(nodeName), volPath) return nil } </ins> return err } // Ensure client is logged in and session is valid", "commid": "kubernetes_pr_62220"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e77b8825eecef15f3da8f836140d3907ef15c25fa9ca3794d81a4d982094993", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Pods stuck in terminating state on Windows node after deleting it What you expected to happen: Pods get terminated and should disappear from kubectl How to reproduce it (as minimally and precisely as possible): Run a pod with windows container Delete it Pods are still terminating Anything else we need to know?: Could you pls help to resolve this issue. K8s pods stuck as Terminating after getting deleted on windows node with windows container(IIS). Docker ps -a not showing this container, so it is completely deleted, but in kubectl it is marked as Terminating. For networking we using OVN. kubectl logs: kubelet logs: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: Hyper-V VMs OS (e.g. from /etc/os-release): Windows Node: Master Node: NAME=\"Ubuntu\" VERSION=\"16.04.4 LTS (Xenial Xerus)\" ID=ubuntu IDLIKE=debian PRETTYNAME=\"Ubuntu 16.04.4 LTS\" VERSIONID=\"16.04\" HOMEURL=\"\" SUPPORTURL=\"\" BUGREPORTURL=\"\" VERSIONCODENAME=xenial UBUNTUCODENAME=xenial Kernel (e.g. ): Linux esd-kbrnts-lnx-1 4.13.0-37-generic ~16.04.1-Ubuntu SMP Wed Mar 7 16:03:28 UTC 2018 x8664 x8664 x8664 GNU/Linux Install tools: OVN 2.7 on windows OVN 2.7.2 on linux Others: Docker Version on Windows node: Server Version: 17.06.2-ee-6\n/sig windows\nIt needs sometime for kubelet to remove the pod. Could you wait a while and check whether the Pod removed?\nHi actually I have waited for 1 day, and it is not deleting. Can delete it only using --grace-period=0 --force. But I don't want to use this manual approach). Could you pls give some advice on this? Thanks in advance!\nis a reference to this issue. Checking kubelet logs will always help to troubleshoot such problem.\nActually, I have attached kubelet log in the ticket and think the main reason is Also as there any option for kubelet to automatically force delete Terminating pods after some period? And --containerized is also not solving my issue. Thanks!\nKubelet won't delete the pod from apiserver. Since it is already not exist on the node, you could force delete it by kubectl.\nIt is clear, so how we can resolve this error: ? I think this is the core item of our issue. Thanks.\nI'm not using OVN. Have you met this problem when using OVN?\nadding Bob to comment on this. i have seen this issue before, but it has been quite a while.\nHi, Guys will be very grateful if you will provide some solution for it. We have tried to add to deployment spec but it doesn't help. Thanks.\nThe error message of is actually a warning message. It shouldn't block the removal of pods. Could you recheck the following things: the node, check whether the pod is still existing, e.g. by the pod exists, check if there are other error or warning message in kubelet logs; or else, the pod could be force removed safely from apiserver\nHi, I had posted this info in the ticket description. not showing this container, so it is completely deleted, but in kubectl it is displayed as Terminating.\ni think you may get more support and faster responses in our slack channel for sig-windows.\nSo it could be safely force removed from API. And agreed with slack is a more faster way to such troubleshooting issues.\nThe issue seems to be related to . The only platform specific implementation for PodContainerManager is the one for . There is a default implementation (), that always returns true in the Exists call. Disabling the CgroupsPerQOS option on the Windows nodes resolves the issue.\nWindows doesn't support cgroups. You should always disable it.\nit is clear enough that Windows does not support cgroups). Unfortunately, it's not specified in the documentation. So to disable CgroupsPerQOS you should need to add this flags to kubelet: Maybe it will help someone... Thank you all for discussion!", "positive_passages": [{"docid": "doc-en-kubernetes-635384596e3e374881368b5fa8bb7f7cb15015dcf05883ee7e49d616f342dfa9", "text": "go_library( name = \"go_default_library\", <del> srcs = [\"validation.go\"], </del> <ins> srcs = [ \"validation.go\", ] + select({ \"@io_bazel_rules_go//go/platform:android\": [ \"validation_others.go\", ], \"@io_bazel_rules_go//go/platform:darwin\": [ \"validation_others.go\", ], \"@io_bazel_rules_go//go/platform:dragonfly\": [ \"validation_others.go\", ], \"@io_bazel_rules_go//go/platform:freebsd\": [ \"validation_others.go\", ], \"@io_bazel_rules_go//go/platform:linux\": [ \"validation_others.go\", ], \"@io_bazel_rules_go//go/platform:nacl\": [ \"validation_others.go\", ], \"@io_bazel_rules_go//go/platform:netbsd\": [ \"validation_others.go\", ], \"@io_bazel_rules_go//go/platform:openbsd\": [ \"validation_others.go\", ], \"@io_bazel_rules_go//go/platform:plan9\": [ \"validation_others.go\", ], \"@io_bazel_rules_go//go/platform:solaris\": [ \"validation_others.go\", ], \"@io_bazel_rules_go//go/platform:windows\": [ \"validation_windows.go\", ], \"//conditions:default\": [], }), </ins> importpath = \"k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig/validation\", deps = [ \"//pkg/features:go_default_library\",", "commid": "kubernetes_pr_62984"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e77b8825eecef15f3da8f836140d3907ef15c25fa9ca3794d81a4d982094993", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Pods stuck in terminating state on Windows node after deleting it What you expected to happen: Pods get terminated and should disappear from kubectl How to reproduce it (as minimally and precisely as possible): Run a pod with windows container Delete it Pods are still terminating Anything else we need to know?: Could you pls help to resolve this issue. K8s pods stuck as Terminating after getting deleted on windows node with windows container(IIS). Docker ps -a not showing this container, so it is completely deleted, but in kubectl it is marked as Terminating. For networking we using OVN. kubectl logs: kubelet logs: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: Hyper-V VMs OS (e.g. from /etc/os-release): Windows Node: Master Node: NAME=\"Ubuntu\" VERSION=\"16.04.4 LTS (Xenial Xerus)\" ID=ubuntu IDLIKE=debian PRETTYNAME=\"Ubuntu 16.04.4 LTS\" VERSIONID=\"16.04\" HOMEURL=\"\" SUPPORTURL=\"\" BUGREPORTURL=\"\" VERSIONCODENAME=xenial UBUNTUCODENAME=xenial Kernel (e.g. ): Linux esd-kbrnts-lnx-1 4.13.0-37-generic ~16.04.1-Ubuntu SMP Wed Mar 7 16:03:28 UTC 2018 x8664 x8664 x8664 GNU/Linux Install tools: OVN 2.7 on windows OVN 2.7.2 on linux Others: Docker Version on Windows node: Server Version: 17.06.2-ee-6\n/sig windows\nIt needs sometime for kubelet to remove the pod. Could you wait a while and check whether the Pod removed?\nHi actually I have waited for 1 day, and it is not deleting. Can delete it only using --grace-period=0 --force. But I don't want to use this manual approach). Could you pls give some advice on this? Thanks in advance!\nis a reference to this issue. Checking kubelet logs will always help to troubleshoot such problem.\nActually, I have attached kubelet log in the ticket and think the main reason is Also as there any option for kubelet to automatically force delete Terminating pods after some period? And --containerized is also not solving my issue. Thanks!\nKubelet won't delete the pod from apiserver. Since it is already not exist on the node, you could force delete it by kubectl.\nIt is clear, so how we can resolve this error: ? I think this is the core item of our issue. Thanks.\nI'm not using OVN. Have you met this problem when using OVN?\nadding Bob to comment on this. i have seen this issue before, but it has been quite a while.\nHi, Guys will be very grateful if you will provide some solution for it. We have tried to add to deployment spec but it doesn't help. Thanks.\nThe error message of is actually a warning message. It shouldn't block the removal of pods. Could you recheck the following things: the node, check whether the pod is still existing, e.g. by the pod exists, check if there are other error or warning message in kubelet logs; or else, the pod could be force removed safely from apiserver\nHi, I had posted this info in the ticket description. not showing this container, so it is completely deleted, but in kubectl it is displayed as Terminating.\ni think you may get more support and faster responses in our slack channel for sig-windows.\nSo it could be safely force removed from API. And agreed with slack is a more faster way to such troubleshooting issues.\nThe issue seems to be related to . The only platform specific implementation for PodContainerManager is the one for . There is a default implementation (), that always returns true in the Exists call. Disabling the CgroupsPerQOS option on the Windows nodes resolves the issue.\nWindows doesn't support cgroups. You should always disable it.\nit is clear enough that Windows does not support cgroups). Unfortunately, it's not specified in the documentation. So to disable CgroupsPerQOS you should need to add this flags to kubelet: Maybe it will help someone... Thank you all for discussion!", "positive_passages": [{"docid": "doc-en-kubernetes-cd81f29e7d619c2fa42bbd8ff9344e773b02ae1866ea53f385c08e95deeb4315", "text": "allErrors = append(allErrors, fmt.Errorf(\"invalid configuration: option %q specified for HairpinMode (--hairpin-mode). Valid options are %q, %q or %q\", kc.HairpinMode, kubeletconfig.HairpinNone, kubeletconfig.HairpinVeth, kubeletconfig.PromiscuousBridge)) } <ins> if err := validateKubeletOSConfiguration(kc); err != nil { allErrors = append(allErrors, err) } </ins> return utilerrors.NewAggregate(allErrors) }", "commid": "kubernetes_pr_62984"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e77b8825eecef15f3da8f836140d3907ef15c25fa9ca3794d81a4d982094993", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Pods stuck in terminating state on Windows node after deleting it What you expected to happen: Pods get terminated and should disappear from kubectl How to reproduce it (as minimally and precisely as possible): Run a pod with windows container Delete it Pods are still terminating Anything else we need to know?: Could you pls help to resolve this issue. K8s pods stuck as Terminating after getting deleted on windows node with windows container(IIS). Docker ps -a not showing this container, so it is completely deleted, but in kubectl it is marked as Terminating. For networking we using OVN. kubectl logs: kubelet logs: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: Hyper-V VMs OS (e.g. from /etc/os-release): Windows Node: Master Node: NAME=\"Ubuntu\" VERSION=\"16.04.4 LTS (Xenial Xerus)\" ID=ubuntu IDLIKE=debian PRETTYNAME=\"Ubuntu 16.04.4 LTS\" VERSIONID=\"16.04\" HOMEURL=\"\" SUPPORTURL=\"\" BUGREPORTURL=\"\" VERSIONCODENAME=xenial UBUNTUCODENAME=xenial Kernel (e.g. ): Linux esd-kbrnts-lnx-1 4.13.0-37-generic ~16.04.1-Ubuntu SMP Wed Mar 7 16:03:28 UTC 2018 x8664 x8664 x8664 GNU/Linux Install tools: OVN 2.7 on windows OVN 2.7.2 on linux Others: Docker Version on Windows node: Server Version: 17.06.2-ee-6\n/sig windows\nIt needs sometime for kubelet to remove the pod. Could you wait a while and check whether the Pod removed?\nHi actually I have waited for 1 day, and it is not deleting. Can delete it only using --grace-period=0 --force. But I don't want to use this manual approach). Could you pls give some advice on this? Thanks in advance!\nis a reference to this issue. Checking kubelet logs will always help to troubleshoot such problem.\nActually, I have attached kubelet log in the ticket and think the main reason is Also as there any option for kubelet to automatically force delete Terminating pods after some period? And --containerized is also not solving my issue. Thanks!\nKubelet won't delete the pod from apiserver. Since it is already not exist on the node, you could force delete it by kubectl.\nIt is clear, so how we can resolve this error: ? I think this is the core item of our issue. Thanks.\nI'm not using OVN. Have you met this problem when using OVN?\nadding Bob to comment on this. i have seen this issue before, but it has been quite a while.\nHi, Guys will be very grateful if you will provide some solution for it. We have tried to add to deployment spec but it doesn't help. Thanks.\nThe error message of is actually a warning message. It shouldn't block the removal of pods. Could you recheck the following things: the node, check whether the pod is still existing, e.g. by the pod exists, check if there are other error or warning message in kubelet logs; or else, the pod could be force removed safely from apiserver\nHi, I had posted this info in the ticket description. not showing this container, so it is completely deleted, but in kubectl it is displayed as Terminating.\ni think you may get more support and faster responses in our slack channel for sig-windows.\nSo it could be safely force removed from API. And agreed with slack is a more faster way to such troubleshooting issues.\nThe issue seems to be related to . The only platform specific implementation for PodContainerManager is the one for . There is a default implementation (), that always returns true in the Exists call. Disabling the CgroupsPerQOS option on the Windows nodes resolves the issue.\nWindows doesn't support cgroups. You should always disable it.\nit is clear enough that Windows does not support cgroups). Unfortunately, it's not specified in the documentation. So to disable CgroupsPerQOS you should need to add this flags to kubelet: Maybe it will help someone... Thank you all for discussion!", "positive_passages": [{"docid": "doc-en-kubernetes-b6b1b11013b50fadb2aa4334f8f1dae5ba41c8f71d81736483df057edb4bb49c", "text": "<ins> // +build !windows /* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package validation import ( \"k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig\" ) // validateKubeletOSConfiguration validates os specific kubelet configuration and returns an error if it is invalid. func validateKubeletOSConfiguration(kc *kubeletconfig.KubeletConfiguration) error { return nil } </ins>", "commid": "kubernetes_pr_62984"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e77b8825eecef15f3da8f836140d3907ef15c25fa9ca3794d81a4d982094993", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Pods stuck in terminating state on Windows node after deleting it What you expected to happen: Pods get terminated and should disappear from kubectl How to reproduce it (as minimally and precisely as possible): Run a pod with windows container Delete it Pods are still terminating Anything else we need to know?: Could you pls help to resolve this issue. K8s pods stuck as Terminating after getting deleted on windows node with windows container(IIS). Docker ps -a not showing this container, so it is completely deleted, but in kubectl it is marked as Terminating. For networking we using OVN. kubectl logs: kubelet logs: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: Hyper-V VMs OS (e.g. from /etc/os-release): Windows Node: Master Node: NAME=\"Ubuntu\" VERSION=\"16.04.4 LTS (Xenial Xerus)\" ID=ubuntu IDLIKE=debian PRETTYNAME=\"Ubuntu 16.04.4 LTS\" VERSIONID=\"16.04\" HOMEURL=\"\" SUPPORTURL=\"\" BUGREPORTURL=\"\" VERSIONCODENAME=xenial UBUNTUCODENAME=xenial Kernel (e.g. ): Linux esd-kbrnts-lnx-1 4.13.0-37-generic ~16.04.1-Ubuntu SMP Wed Mar 7 16:03:28 UTC 2018 x8664 x8664 x8664 GNU/Linux Install tools: OVN 2.7 on windows OVN 2.7.2 on linux Others: Docker Version on Windows node: Server Version: 17.06.2-ee-6\n/sig windows\nIt needs sometime for kubelet to remove the pod. Could you wait a while and check whether the Pod removed?\nHi actually I have waited for 1 day, and it is not deleting. Can delete it only using --grace-period=0 --force. But I don't want to use this manual approach). Could you pls give some advice on this? Thanks in advance!\nis a reference to this issue. Checking kubelet logs will always help to troubleshoot such problem.\nActually, I have attached kubelet log in the ticket and think the main reason is Also as there any option for kubelet to automatically force delete Terminating pods after some period? And --containerized is also not solving my issue. Thanks!\nKubelet won't delete the pod from apiserver. Since it is already not exist on the node, you could force delete it by kubectl.\nIt is clear, so how we can resolve this error: ? I think this is the core item of our issue. Thanks.\nI'm not using OVN. Have you met this problem when using OVN?\nadding Bob to comment on this. i have seen this issue before, but it has been quite a while.\nHi, Guys will be very grateful if you will provide some solution for it. We have tried to add to deployment spec but it doesn't help. Thanks.\nThe error message of is actually a warning message. It shouldn't block the removal of pods. Could you recheck the following things: the node, check whether the pod is still existing, e.g. by the pod exists, check if there are other error or warning message in kubelet logs; or else, the pod could be force removed safely from apiserver\nHi, I had posted this info in the ticket description. not showing this container, so it is completely deleted, but in kubectl it is displayed as Terminating.\ni think you may get more support and faster responses in our slack channel for sig-windows.\nSo it could be safely force removed from API. And agreed with slack is a more faster way to such troubleshooting issues.\nThe issue seems to be related to . The only platform specific implementation for PodContainerManager is the one for . There is a default implementation (), that always returns true in the Exists call. Disabling the CgroupsPerQOS option on the Windows nodes resolves the issue.\nWindows doesn't support cgroups. You should always disable it.\nit is clear enough that Windows does not support cgroups). Unfortunately, it's not specified in the documentation. So to disable CgroupsPerQOS you should need to add this flags to kubelet: Maybe it will help someone... Thank you all for discussion!", "positive_passages": [{"docid": "doc-en-kubernetes-84e3d23cd960dfa081cdb96e180ea853820ad2202f2117dd2f266d9e1c4b3c23", "text": "<ins> // +build windows /* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package validation import ( \"fmt\" utilerrors \"k8s.io/apimachinery/pkg/util/errors\" \"k8s.io/kubernetes/pkg/kubelet/apis/kubeletconfig\" ) // validateKubeletOSConfiguration validates os specific kubelet configuration and returns an error if it is invalid. func validateKubeletOSConfiguration(kc *kubeletconfig.KubeletConfiguration) error { message := \"invalid configuration: %v (%v) %v is not supported on Windows\" allErrors := []error{} if kc.CgroupsPerQOS { allErrors = append(allErrors, fmt.Errorf(message, \"CgroupsPerQOS\", \"--cgroups-per-qos\", kc.CgroupsPerQOS)) } if len(kc.EnforceNodeAllocatable) > 0 { allErrors = append(allErrors, fmt.Errorf(message, \"EnforceNodeAllocatable\", \"--enforce-node-allocatable\", kc.EnforceNodeAllocatable)) } return utilerrors.NewAggregate(allErrors) } </ins>", "commid": "kubernetes_pr_62984"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-336255f6e649bc5e9a36c586d29d9f11ed1db30d4ded4439288854d114501c77", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: In the kubelet, when using the kubelet creates static pods but doesn't update the status accordingly in the PodList (kubelet ). You can find that kind of Pods with the following annotation: The status will stay like that: What you expected to happen: The status is updated. How to reproduce it (as minimally and precisely as possible): Use a static pod. Anything else we need to know?: I tried to fix it in but the test-grid continuously failed at the reboot phase (see ). I had to revert it (, ). I'm creating this issue to track this bug. The problem in the e2e tests are probably from . This is an old output of the failure: https://k8s-\nI don't think this is a bug. only exposes what kubelet sees from the sources, and doesn't include statuses known only to kubelet. Since for static pods, their statuses are not written back to the source, they do not show up in . The fact that it has the condition is unintentional and a bug. It has just been fixed recently.\nI confirm that this behaviour is still happening. Having pods with status where they are actually . The kubernetes API shows them as when Kubelet endpoint as .\n/sig node\nI agree with that this is working as intended.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nI understand that the source of truth is currently the API server and that details can be retrieved there. We have however found this to be a scaling challenge. In our use case, we are a monitoring application that runs as a DaemonSet. Monitoring systems such as ours need to continuously refresh the PodList because Kubernetes operators want a real time feedback on application health via metrics, logs and traces. Having each node that is monitoring query the Kubernetes apiserver to get each of the Pod statuses results in high load on the API server. This is exacerbated and becomes difficult to scale as clusters grow to a large number of nodes. We have however found that having each node query its own Kubelet API locally is quite scaleable and allows this work to be distributed across the cluster. Ideally we would be able to use this API for static pods as well since the state of the static Pods is stored inside the kubelet. Other benefits of using the kublet API are that: It provides the link to the container runtime in the section, which is helpful for metadata collection and association. Is easily managed the RBAC system through webhooks If there is another approach or API that you\u2019d suggest we\u2019re happy to rethink how we collect this data.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nI also meet this issue.\nReporting the status as \"Pending\" might be consistent, but it's incorrect. If the pod is created statically and is health checking OK, it's not \"Pending\". The Kubelet API is almost very useful but the status flag seems to make it much less so since it's not possible to tell from the API endpoint if a static Pod is actually up successfully or not.\nHi team, I'm reaching out to see if we can revisit this issue. We need this to be able to monitor pods locally without having agents reach out to the apiserver. Currently the pod is in a wrong state (Pending when it's actually Running), and we're missing all status information (pod IP, container statuses, etc.). We would be happy and willing to update to solve the issue if we get the green light that this will be accepted. cc\nI think as long as we fix the test failures the change caused, we can re-introduce it. Feel free to assign me on a PR which accomplishes this, and make sure the reboot test passes.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-5ac242b047183fcf8ccd303a20bfe3606bb1879b3b084dac4d551dcca98f921f", "text": "// GetPods returns all pods bound to the kubelet and their spec, and the mirror // pods. func (kl *Kubelet) GetPods() []*v1.Pod { <del> return kl.podManager.GetPods() </del> <ins> pods := kl.podManager.GetPods() // a kubelet running without apiserver requires an additional // update of the static pod status. See #57106 for _, p := range pods { if status, ok := kl.statusManager.GetPodStatus(p.UID); ok { p.Status = status } } return pods </ins> } // GetRunningPods returns all pods running on kubelet from looking at the", "commid": "kubernetes_pr_77661"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-47f4fe1153b9c8db2f96f1dbd3b510d20b25e68b2d642a04fba8f7548b259f44", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: says: What you expected to happen: Don't suggest that -- as it doesn't actually do that when used. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: (This was reported in but that issue was closed) Environment: Kubernetes version (use ): (This is indeed head from today) Cloud provider or hardware configuration: macOS OS (e.g. from /etc/os-release): Kernel (e.g. ):Install tools:Others:\n/sig cli\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-093a23cc2cee09cb7ffa4b07b49a974b05be1545dbf2d85725b77b0c41e21719", "text": "// whether or not a container name was given via --container ContainerNameSpecified bool <del> Interactive            bool </del> Selector               string Object           runtime.Object", "commid": "kubernetes_pr_65420"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-47f4fe1153b9c8db2f96f1dbd3b510d20b25e68b2d642a04fba8f7548b259f44", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: says: What you expected to happen: Don't suggest that -- as it doesn't actually do that when used. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: (This was reported in but that issue was closed) Environment: Kubernetes version (use ): (This is indeed head from today) Cloud provider or hardware configuration: macOS OS (e.g. from /etc/os-release): Kernel (e.g. ):Install tools:Others:\n/sig cli\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-a1d92eec177738f780125d4e5b4f7b1a770d1118cf29c3ba380bad33df643b58", "text": "cmd.Flags().StringVar(&o.SinceTime, \"since-time\", o.SinceTime, i18n.T(\"Only return logs after a specific date (RFC3339). Defaults to all logs. Only one of since-time / since may be used.\")) cmd.Flags().DurationVar(&o.SinceSeconds, \"since\", o.SinceSeconds, \"Only return logs newer than a relative duration like 5s, 2m, or 3h. Defaults to all logs. Only one of since-time / since may be used.\") cmd.Flags().StringVarP(&o.Container, \"container\", \"c\", o.Container, \"Print the logs of this container\") <del> cmd.Flags().BoolVar(&o.Interactive, \"interactive\", o.Interactive, \"If true, prompt the user for input when required.\") cmd.Flags().MarkDeprecated(\"interactive\", \"This flag is no longer respected and there is no replacement.\") </del> cmdutil.AddPodRunningTimeoutFlag(cmd, defaultPodLogsTimeout) cmd.Flags().StringVarP(&o.Selector, \"selector\", \"l\", o.Selector, \"Selector (label query) to filter on.\") return cmd", "commid": "kubernetes_pr_65420"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ae2354e5f90f5ada93795ba7ce49d7414be41b906f7bd0cd4821d722fa0df6ba", "query": "https://k8s- Please work on finding a fix for the flake. /priority failing-test /priority important-soon /sig api-machinery /kind flake\n/assign\nI think this was fixed by\nwe had a failure on 3/28 (after the above fix merged). https://k8s- Looking at the logs this seems to be a different error than the one fixed by . Can you confirm plz?\nHmm that is different, and I will look into the reason.\nThere hasn't been a failure since 3/28, So while the test might have flakes it is definitely less flaky than 12 failures per week now\nYes the latest runs look good. Please close the issue\n/close", "positive_passages": [{"docid": "doc-en-kubernetes-105f079e07f33ef8c54ef791a07becfb7f6c257ccb05fb3f76703e6d6a904438", "text": "}, }, Spec: v1.PodSpec{ <del> ActiveDeadlineSeconds: int64ptr(20), </del> Containers: []v1.Container{ { Name:  \"example\",", "commid": "kubernetes_pr_61913"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ae2354e5f90f5ada93795ba7ce49d7414be41b906f7bd0cd4821d722fa0df6ba", "query": "https://k8s- Please work on finding a fix for the flake. /priority failing-test /priority important-soon /sig api-machinery /kind flake\n/assign\nI think this was fixed by\nwe had a failure on 3/28 (after the above fix merged). https://k8s- Looking at the logs this seems to be a different error than the one fixed by . Can you confirm plz?\nHmm that is different, and I will look into the reason.\nThere hasn't been a failure since 3/28, So while the test might have flakes it is definitely less flaky than 12 failures per week now\nYes the latest runs look good. Please close the issue\n/close", "positive_passages": [{"docid": "doc-en-kubernetes-05b61285bd80aaf29723e7c40a322d4748a96f787e2582ee060d96d051d757e8", "text": "expectNoEvent(watchB, watch.Added, testPodA) testPodA, err = updatePod(f, testPodA.GetName(), func(p *v1.Pod) { <del> p.Spec.ActiveDeadlineSeconds = int64ptr(10) </del> <ins> p.ObjectMeta.Labels[\"mutation\"] = \"1\" </ins> }) Expect(err).NotTo(HaveOccurred()) expectEvent(watchA, watch.Modified, testPodA)", "commid": "kubernetes_pr_61913"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ae2354e5f90f5ada93795ba7ce49d7414be41b906f7bd0cd4821d722fa0df6ba", "query": "https://k8s- Please work on finding a fix for the flake. /priority failing-test /priority important-soon /sig api-machinery /kind flake\n/assign\nI think this was fixed by\nwe had a failure on 3/28 (after the above fix merged). https://k8s- Looking at the logs this seems to be a different error than the one fixed by . Can you confirm plz?\nHmm that is different, and I will look into the reason.\nThere hasn't been a failure since 3/28, So while the test might have flakes it is definitely less flaky than 12 failures per week now\nYes the latest runs look good. Please close the issue\n/close", "positive_passages": [{"docid": "doc-en-kubernetes-c721002779de53e02017bb35a601713ba36c08e38cd6042431d78fe73086fe6d", "text": "expectNoEvent(watchB, watch.Modified, testPodA) testPodA, err = updatePod(f, testPodA.GetName(), func(p *v1.Pod) { <del> p.Spec.ActiveDeadlineSeconds = int64ptr(5) </del> <ins> p.ObjectMeta.Labels[\"mutation\"] = \"2\" </ins> }) Expect(err).NotTo(HaveOccurred()) expectEvent(watchA, watch.Modified, testPodA)", "commid": "kubernetes_pr_61913"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9b1fa47804b1f7e830fa325e71a35010f3c16e79f3c6e5b6bb423d5ac4aea52d", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Many service related test cases in test case are flaky. Especially related cases. CI Link: http://k8s- What you expected to happen: IPVS should sync rules within . How to reproduce it (as minimally and precisely as possible): a cluster with ipvs proxy mode, and specify . a service with backends. check the delay from create service to sync ipvs rules. (This issue is probabilistic, about 50% possibility to happened.)\n/sig network /area ipvs\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-6fc83c52daa325960098c2e84387459716c3fea3ed3fe6d65b8d1be7363fb3ba", "text": "func (proxier *Proxier) OnEndpointsSynced() { proxier.mu.Lock() proxier.endpointsSynced = true <ins> proxier.setInitialized(proxier.servicesSynced && proxier.endpointsSynced) </ins> proxier.mu.Unlock() <ins> // Sync unconditionally - this is called once per lifetime. </ins> proxier.syncProxyRules() }", "commid": "kubernetes_pr_62842"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-178631faa4b3e89ae90e213ef25c42d7a4deb3801f14f70b17d85af2c5cd7474", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Deploying kube-proxy with mode ipvs on a system with the required ipvs support compiled into the kernel rather than as modules causes the kube-proxy deployment to fall back to using iptables. tryIPVSProxy is only checking for the presence of kernel modules and not if the running kernel has the required support compiled in. What you expected to happen: tryIPVSProxy should succeed if either the required modules are found or support is compiled into the running kernel. How to reproduce it (as minimally and precisely as possible): Boot a system using a kernel with ipvs support compiled in rather than as a module (such as the kernel used by and a host without iptables installed Add --config=/etc/kubernetes/kubelet- to the kubelet arguments using the following kubelet- contents: Install using kubeadm with the following config: Check the output of the kube-proxy pod: Anything else we need to know?: From , it should be possible to check for the existence of modules.builtin and if present use that in addition to using modprobe and the contents of /proc/modules. Environment: Kubernetes version (use ): v1.10.2 Cloud provider or hardware configuration: local kvm host OS (e.g. from /etc/os-release): custom linuxkit build Kernel (e.g. ): Linux linuxkit- 4.14.40-linuxkit SMP Thu May 10 10:06:57 UTC 2018 x86_64 Linux Install tools: kubeadm\n/sig network\n/cc\ncc\ncc please take a look.", "positive_passages": [{"docid": "doc-en-kubernetes-9353cf5cd7b9363ff14676d53900dd14c2fae47f1511c72cf600edcd98ed8543", "text": "import ( \"bytes\" \"fmt\" <ins> \"io/ioutil\" </ins> \"net\" <ins> \"regexp\" </ins> \"strconv\" \"strings\" \"sync\"", "commid": "kubernetes_pr_63850"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-178631faa4b3e89ae90e213ef25c42d7a4deb3801f14f70b17d85af2c5cd7474", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Deploying kube-proxy with mode ipvs on a system with the required ipvs support compiled into the kernel rather than as modules causes the kube-proxy deployment to fall back to using iptables. tryIPVSProxy is only checking for the presence of kernel modules and not if the running kernel has the required support compiled in. What you expected to happen: tryIPVSProxy should succeed if either the required modules are found or support is compiled into the running kernel. How to reproduce it (as minimally and precisely as possible): Boot a system using a kernel with ipvs support compiled in rather than as a module (such as the kernel used by and a host without iptables installed Add --config=/etc/kubernetes/kubelet- to the kubelet arguments using the following kubelet- contents: Install using kubeadm with the following config: Check the output of the kube-proxy pod: Anything else we need to know?: From , it should be possible to check for the existence of modules.builtin and if present use that in addition to using modprobe and the contents of /proc/modules. Environment: Kubernetes version (use ): v1.10.2 Cloud provider or hardware configuration: local kvm host OS (e.g. from /etc/os-release): custom linuxkit build Kernel (e.g. ): Linux linuxkit- 4.14.40-linuxkit SMP Thu May 10 10:06:57 UTC 2018 x86_64 Linux Install tools: kubeadm\n/sig network\n/cc\ncc\ncc please take a look.", "positive_passages": [{"docid": "doc-en-kubernetes-56644ec6684b6484278d9170dc963ecd0f6bfe6dc6f08c9df9fca2906bc50123", "text": "// GetModules returns all installed kernel modules. func (handle *LinuxKernelHandler) GetModules() ([]string, error) { <ins> // Check whether IPVS required kernel modules are built-in kernelVersionFile := \"/proc/sys/kernel/osrelease\" b, err := ioutil.ReadFile(kernelVersionFile) if err != nil { glog.Errorf(\"Failed to read file %s with error %v\", kernelVersionFile, err) } kernelVersion := strings.TrimSpace(string(b)) builtinModsFilePath := fmt.Sprintf(\"/lib/modules/%s/modules.builtin\", kernelVersion) b, err = ioutil.ReadFile(builtinModsFilePath) if err != nil { glog.Errorf(\"Failed to read file %s with error %v\", builtinModsFilePath, err) } var bmods []string for _, module := range ipvsModules { if match, _ := regexp.Match(module+\".ko\", b); match { bmods = append(bmods, module) } } </ins> // Try to load IPVS required kernel modules using modprobe first for _, kmod := range ipvsModules { err := handle.executor.Command(\"modprobe\", \"--\", kmod).Run()", "commid": "kubernetes_pr_63850"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-178631faa4b3e89ae90e213ef25c42d7a4deb3801f14f70b17d85af2c5cd7474", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Deploying kube-proxy with mode ipvs on a system with the required ipvs support compiled into the kernel rather than as modules causes the kube-proxy deployment to fall back to using iptables. tryIPVSProxy is only checking for the presence of kernel modules and not if the running kernel has the required support compiled in. What you expected to happen: tryIPVSProxy should succeed if either the required modules are found or support is compiled into the running kernel. How to reproduce it (as minimally and precisely as possible): Boot a system using a kernel with ipvs support compiled in rather than as a module (such as the kernel used by and a host without iptables installed Add --config=/etc/kubernetes/kubelet- to the kubelet arguments using the following kubelet- contents: Install using kubeadm with the following config: Check the output of the kube-proxy pod: Anything else we need to know?: From , it should be possible to check for the existence of modules.builtin and if present use that in addition to using modprobe and the contents of /proc/modules. Environment: Kubernetes version (use ): v1.10.2 Cloud provider or hardware configuration: local kvm host OS (e.g. from /etc/os-release): custom linuxkit build Kernel (e.g. ): Linux linuxkit- 4.14.40-linuxkit SMP Thu May 10 10:06:57 UTC 2018 x86_64 Linux Install tools: kubeadm\n/sig network\n/cc\ncc\ncc please take a look.", "positive_passages": [{"docid": "doc-en-kubernetes-e33957593ebecae0848194042e709667188897abaa5a218d3da04db476f4c76b", "text": "} mods := strings.Split(string(out), \"n\") <del> return mods, nil </del> <ins> return append(mods, bmods...), nil </ins> } // CanUseIPVSProxier returns true if we can use the ipvs Proxier.", "commid": "kubernetes_pr_63850"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d943f6711cd68b765c622b0185eababba15b96010c64af1a6f9d1d7374169a9c", "query": "both in PR and CI runs see /assign\n/assign\nInteresting fact: is not flaky, only . The test codepath for these two are almost identical. I wonder if this is a real bug not a flaky test. still investigating.\nstill seeing flakes like https://k8s- the loop that ensures the watch cache is primed goes version-by-version, and creates and observes the delete event for that version. it does not ensure the delete event is drained from the watch caches for the other versions.\na better approach would be probably be to:\nwhy the poll? Because the watch is not reliable? Otherwise, we have that structure now.\nMoves the version loop inside the poll Today we loop over versions and poll per version, which can leave unconsumed delete events in prior versions\nCannot follow. Now we have the following without a poll:\nAt minimum, I would move the version loop inside the poll so that when we exit we know the deletion events from isWatchCachePrimed are consumed by the watch caches for all versions. If we wanted, we could move the create/delete up out of the isWatchCachePrimed function or pass versions into it to avoid creating/deleting an object per version\nOk, so we were talking about different code. good. To understand: we do a call per version, each creating and deleting an object, and waiting for the delete event with a watch call. a following watch will not see the events of the calls of itself (because they use the same versioned watch cache) and of any version in front of it in the version slice (is this true?), but it might see events of calls of versions later in the version slice. So with your outer poll and inner version loop we would make sure that we drain every version's cache for following rv=0 watch requests. Sounds plausible.\nWhere do we have the official watch axioms?\nI think I know what is the problem here. We make sure the watch is primed for . then we move on to and make sure the watch is primed by creating another object in . The watch cache is drained for but the watch cache for is not and that is the problem here. will send a fix.\nyep, same thing I described above. The solution looks good.\nI didn't see your comment when I commented. Your description is accurate.", "positive_passages": [{"docid": "doc-en-kubernetes-484555d92fbd8af0225147cd935634933b44c9a87b2e8d82bed4a51b086351ba", "text": "// For this test, we'll actually cycle, \"list/watch/create/delete\" until we get an RV from list that observes the create and not an error. // This way all the tests that are checking for watches don't have to worry about RV too old problems because crazy things *could* happen // before like the created RV could be too old to watch. <del> for _, version := range servedVersions(crd) { err := wait.PollImmediate(500*time.Millisecond, 30*time.Second, func() (bool, error) { return isWatchCachePrimed(crd, dynamicClientSet, version) }) if err != nil { return nil, err } </del> <ins> err = wait.PollImmediate(500*time.Millisecond, 30*time.Second, func() (bool, error) { return isWatchCachePrimed(crd, dynamicClientSet) }) if err != nil { return nil, err </ins> } return crd, nil } <ins> func resourceClientForVersion(crd *apiextensionsv1beta1.CustomResourceDefinition, dynamicClientSet dynamic.Interface, namespace, version string) dynamic.ResourceInterface { gvr := schema.GroupVersionResource{Group: crd.Spec.Group, Version: version, Resource: crd.Spec.Names.Plural} if crd.Spec.Scope != apiextensionsv1beta1.ClusterScoped { return dynamicClientSet.Resource(gvr).Namespace(namespace) } else { return dynamicClientSet.Resource(gvr) } } </ins> // isWatchCachePrimed returns true if the watch is primed for an specified version of CRD watch <del> func isWatchCachePrimed(crd *apiextensionsv1beta1.CustomResourceDefinition, dynamicClientSet dynamic.Interface, version string) (bool, error) { </del> <ins> func isWatchCachePrimed(crd *apiextensionsv1beta1.CustomResourceDefinition, dynamicClientSet dynamic.Interface) (bool, error) { </ins> ns := \"\" if crd.Spec.Scope != apiextensionsv1beta1.ClusterScoped { ns = \"aval\" } <del> gvr := schema.GroupVersionResource{Group: crd.Spec.Group, Version: version, Resource: crd.Spec.Names.Plural} var resourceClient dynamic.ResourceInterface if crd.Spec.Scope != apiextensionsv1beta1.ClusterScoped { resourceClient = dynamicClientSet.Resource(gvr).Namespace(ns) } else { resourceClient = dynamicClientSet.Resource(gvr) </del> <ins> versions := servedVersions(crd) if len(versions) == 0 { return true, nil </ins> } <ins> resourceClient := resourceClientForVersion(crd, dynamicClientSet, ns, versions[0]) </ins> instanceName := \"setup-instance\" instance := &unstructured.Unstructured{ Object: map[string]interface{}{ <del> \"apiVersion\": crd.Spec.Group + \"/\" + version, </del> <ins> \"apiVersion\": crd.Spec.Group + \"/\" + versions[0], </ins> \"kind\":       crd.Spec.Names.Kind, \"metadata\": map[string]interface{}{ \"namespace\": ns,", "commid": "kubernetes_pr_65288"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d943f6711cd68b765c622b0185eababba15b96010c64af1a6f9d1d7374169a9c", "query": "both in PR and CI runs see /assign\n/assign\nInteresting fact: is not flaky, only . The test codepath for these two are almost identical. I wonder if this is a real bug not a flaky test. still investigating.\nstill seeing flakes like https://k8s- the loop that ensures the watch cache is primed goes version-by-version, and creates and observes the delete event for that version. it does not ensure the delete event is drained from the watch caches for the other versions.\na better approach would be probably be to:\nwhy the poll? Because the watch is not reliable? Otherwise, we have that structure now.\nMoves the version loop inside the poll Today we loop over versions and poll per version, which can leave unconsumed delete events in prior versions\nCannot follow. Now we have the following without a poll:\nAt minimum, I would move the version loop inside the poll so that when we exit we know the deletion events from isWatchCachePrimed are consumed by the watch caches for all versions. If we wanted, we could move the create/delete up out of the isWatchCachePrimed function or pass versions into it to avoid creating/deleting an object per version\nOk, so we were talking about different code. good. To understand: we do a call per version, each creating and deleting an object, and waiting for the delete event with a watch call. a following watch will not see the events of the calls of itself (because they use the same versioned watch cache) and of any version in front of it in the version slice (is this true?), but it might see events of calls of versions later in the version slice. So with your outer poll and inner version loop we would make sure that we drain every version's cache for following rv=0 watch requests. Sounds plausible.\nWhere do we have the official watch axioms?\nI think I know what is the problem here. We make sure the watch is primed for . then we move on to and make sure the watch is primed by creating another object in . The watch cache is drained for but the watch cache for is not and that is the problem here. will send a fix.\nyep, same thing I described above. The solution looks good.\nI didn't see your comment when I commented. Your description is accurate.", "positive_passages": [{"docid": "doc-en-kubernetes-23c8278256d7086e94da850959c553ef0bd42739123f4f224e0756b5c348a30f", "text": "return false, err } <del> noxuWatch, err := resourceClient.Watch(metav1.ListOptions{ResourceVersion: createdInstance.GetResourceVersion()}) if err != nil { return false, err } defer noxuWatch.Stop() select { case watchEvent := <-noxuWatch.ResultChan(): if watch.Error == watchEvent.Type { return false, nil </del> <ins> // Wait for all versions of watch cache to be primed and also make sure we consumed the DELETE event for all // versions so that any new watch with ResourceVersion=0 does not get those events. This is source of some flaky tests. // When a client creates a watch with resourceVersion=0, it will get an ADD event for any existing objects // but because they specified resourceVersion=0, there is no starting point in the cache buffer to return existing events // from, thus the server will return anything from current head of the cache to the end. By accessing the delete // events for all versions here, we make sure that the head of the cache is passed those events and they will not being // delivered to any future watch with resourceVersion=0. for _, v := range versions { noxuWatch, err := resourceClientForVersion(crd, dynamicClientSet, ns, v).Watch( metav1.ListOptions{ResourceVersion: createdInstance.GetResourceVersion()}) if err != nil { return false, err </ins> } <del> if watch.Deleted != watchEvent.Type { return false, fmt.Errorf(\"expected DELETE, but got %#v\", watchEvent) </del> <ins> defer noxuWatch.Stop() select { case watchEvent := <-noxuWatch.ResultChan(): if watch.Error == watchEvent.Type { return false, nil } if watch.Deleted != watchEvent.Type { return false, fmt.Errorf(\"expected DELETE, but got %#v\", watchEvent) } case <-time.After(5 * time.Second): return false, fmt.Errorf(\"gave up waiting for watch event\") </ins> } <del> return true, nil case <-time.After(5 * time.Second): return false, fmt.Errorf(\"gave up waiting for watch event\") </del> } <ins> return true, nil </ins> } func DeleteCustomResourceDefinition(crd *apiextensionsv1beta1.CustomResourceDefinition, apiExtensionsClient clientset.Interface) error {", "commid": "kubernetes_pr_65288"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-093df870a7b5c49df22f3deeaa7adc10504bc34c455e3bb09727f921a17ea670", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If this may be security issue, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: During k8s cluster launch, is checked and if any etcd binary is found regardless of current OS Distribution, expected etcd binary is not downloaded and etcd soft link is not updated to point desired etcd binary, so cluster creation fails. What you expected to happen: Along with expected etcd version, OS Distribution should also be checked for successfully and efficiently installing etcd during setting up local cluster. How to reproduce it (as minimally and precisely as possible): Checkout k8s codbase on MacOS and launch cluster. working k8s codebase under virtual machine to launch cluster in VM. (Cluster creation would fail, prompting error that etcd needs to be installed and update in {KUBEROOT}/thirdparty/etcd-v{ETCDVERSION}-linux-* Anything else we need to know?: It's an optimization on managing thirdparty etcd binary for local cluster setup. Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\ndo you have a patch that you are working on? we don't really support local-up-cluster on macos yet. /sig testing\nis fixing this issue. Though I use Mac as my workstation but sometimes need local-cluster to test codebase so I mapped (softlinked) my GOPATH in virtual machine keeping separate bin directory. Everything is running perfectly fine after making changes mentioned in this PR. So thought to submit small optimization on etcd installation logic.\n/close", "positive_passages": [{"docid": "doc-en-kubernetes-e8b2cbf35a780954a45b141d3ee2ceb19c5276a9ffb19b840bb69c36560b379a", "text": "kube::etcd::install() { ( <ins> local os </ins> cd \"${KUBE_ROOT}/third_party\" <del> if [[ $(readlink etcd) == etcd-v${ETCD_VERSION}-* ]]; then </del> <ins> os=$(uname | tr \"[:upper:]\" \"[:lower:]\") if [[ $(readlink etcd) == etcd-v${ETCD_VERSION}-${os}-* ]]; then </ins> return  # already installed fi <del> if [[ $(uname) == \"Darwin\" ]]; then </del> <ins> if [[ ${os} == \"darwin\" ]]; then </ins> download_file=\"etcd-v${ETCD_VERSION}-darwin-amd64.zip\" url=\"https://github.com/coreos/etcd/releases/download/v${ETCD_VERSION}/${download_file}\" kube::util::download_file \"${url}\" \"${download_file}\"", "commid": "kubernetes_pr_64782"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-093df870a7b5c49df22f3deeaa7adc10504bc34c455e3bb09727f921a17ea670", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If this may be security issue, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: During k8s cluster launch, is checked and if any etcd binary is found regardless of current OS Distribution, expected etcd binary is not downloaded and etcd soft link is not updated to point desired etcd binary, so cluster creation fails. What you expected to happen: Along with expected etcd version, OS Distribution should also be checked for successfully and efficiently installing etcd during setting up local cluster. How to reproduce it (as minimally and precisely as possible): Checkout k8s codbase on MacOS and launch cluster. working k8s codebase under virtual machine to launch cluster in VM. (Cluster creation would fail, prompting error that etcd needs to be installed and update in {KUBEROOT}/thirdparty/etcd-v{ETCDVERSION}-linux-* Anything else we need to know?: It's an optimization on managing thirdparty etcd binary for local cluster setup. Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\ndo you have a patch that you are working on? we don't really support local-up-cluster on macos yet. /sig testing\nis fixing this issue. Though I use Mac as my workstation but sometimes need local-cluster to test codebase so I mapped (softlinked) my GOPATH in virtual machine keeping separate bin directory. Everything is running perfectly fine after making changes mentioned in this PR. So thought to submit small optimization on etcd installation logic.\n/close", "positive_passages": [{"docid": "doc-en-kubernetes-d834ff6f3db9a137d30d7446b71254aef8dcaaeb1182ff2185a3a4e4ef9c4591", "text": "kube::util::download_file \"${url}\" \"${download_file}\" tar xzf \"${download_file}\" ln -fns \"etcd-v${ETCD_VERSION}-linux-amd64\" etcd <ins> rm \"${download_file}\" </ins> fi kube::log::info \"etcd v${ETCD_VERSION} installed. To use:\" kube::log::info \"export PATH=$(pwd)/etcd:${PATH}\"", "commid": "kubernetes_pr_64782"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cab42aeb58a419434b628a8ba1af6fcf4b705a5482ca0d7362b0ced98b6e521a", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: In order to migrate to a new version of kubernetes on GKE. I cordoned(Kubectl cordon <node) all nodes in the old node pool(1.8.9) in order to drain the node pool(pods on the node) with an intention to cause the pods to run on a new version of the node pool(1.10.2). As soon as I cordoned all the nodes in the old node pool, it caused the downtime of ingress(nginx). The nginx controller pods where running fine on the cordoned node pool. But the cordon caused the nodes to be removed from the target pool of ingress load balancer. Below are the documents that suggest the above same method that I followed as best practice for zero downtime upgrade. 1). 2). What you expected to happen: I expected \"kubectl cordon <node\" not to have the node/s removed from the target pool of the loadbalancer because the nginx controller pods where running absolutely fine on these nodes. How to reproduce it (as minimally and precisely as possible): 1).Cordon all the nodes in an old node pool that runs nginx controller. Anything else we need to know?: Environment: Kubernetes version (use ): 1.10.2 Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): Container OS Kernel (e.g. ): 4.14.22+ Install tools: Others: Cordon causes to remove the nodes from the target pool of the ingress load balancer. The health checks fail on the nodes of the target pool, which should not be the case. Because the nginx controller pods run fine on these nodes.\nTechnically, this isn't a Kubernetes bug as this is working as intended; however, it does beg the question why we remove unschedulable nodes if they're marked as ready since we perform the to determine LB backend nodes. is it scheduable? is it not a master? is it not marked for exclusion? is it marked as ready? If any of those are a no, then it'll be removed from the pool on the next sync. Perhaps someone from can shed some light. /sig network\ncc This problem extends beyond GCP/ingress controller and to anyone using pools to upgrade nodes. A typical workflow I see is you'd cordon a node pool so as you drain each node the pods don't go to another node in the pool that'll shortly be drained as well. The current logic does not support that and complicates cluster administration because cordoning does not respect PDB's.\n/remove-sig apps /remove-sig gcp (since the service controller falls under sig networking)\nThose labels are not set on the issue: <detailsIn response to : /remove-sig apps /remove-sig gcp Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nRef I thought a general practice for draining the old pool is to move over one node at a time in a rolling fashion. Shouldn't there always be certain backend pods being able to receive & serve traffic? cc\nWRT draining, it is recommended to do it one node at a time ; however, in real world scenarios doing it one node at a time can cause a lot of avoidable container churn if you don't cordon off the nodes you at least plan to drain so that pods aren't being scheduled on a node you'll be draining after the next one. According to the comments in the service controller it seems the unschedulable part exists because it was how we differentiated masters in the past; however, we have labels for that now. We also have the service exclusion label (can't find when/if that'll be promoted though as i don't think there's a ticket on it).\nI'm having problems with this issue as well. The fact that nodes are removed from target pools when cordoned means that I sometimes get brief interruptions of the traffic to a service when I cordon a node. I'm guessing the node isn't gracefully removed from the load balancer which results in some traffic being cut off trying to route through the recently cordoned node. The same problem occasionally happens when deleting nodes / node pools or when the cluster autoscaler deletes a node. We are running GKE ver. 1.10.2-gke.1. Our best defence against these issue have so far been to limit node changes as much as possible and not use any auto scaling.\nI've posted a question regarding this issue in SO some weeks before it was created. The suggested action was to use node taints () instead of cordon, that way nodes will still be marked as .\nThank you for the link, it Certainly helped. Perhaps, if thats the case(as mentioned in the accepted answer of the above link), then to cordon all the nodes of old node pools should not be a recommended action, at least in the GKE upgrade docs.\nonly says: And I can't find what more it does in the documentation. So I would expect that it has exactly the same behaviour as a taint. Why is removing running pods from the balancer working as intended? If it isn't a bug then the documentation is certainly unclear in this regard.\nThis just caused a major outage for us too. I agree with the previous posts, while this may be working as the code intended, it does not follow the patterns and documentation k8s provides. When I cordon a node it should not impact the traffic going to the node or any pods on it. I should be able to gradually remove traffic by draining nodes/pods and respecting PDBs.\nthis issue touches on the fact we are removing masters as well and inadvertently removing cordoned nodes. The logic in the service controller mentions we only filter out unschedulable nodes since that's how masters were setup.\nWe wanted to replace all of the kubernetes cluster nodes to different node instance types, so we started off by cordoning all of the nodes, but it surprisingly caused an outage for us. As pointed out, the only documentation around cordoning is , which I took to mean that new pods can not be scheduled on those nodes. It was surprising behavior to find out that, not only does it not allow new pods to be scheduled on those nodes, but that it also causes the service controller to remove unschedulable nodes from load balancing pools. I understand that it's working as intended, but if that was also documented as part of the cordon operation, I would have been able to avoid an outage.\nI finally caught up to this bug. Fun one. I agree that this is working-as-intended and that it stinks. We can do better. As a short-term workaround, you can taint the nodes before cordoning one-by-one. That will stop new work from arriving, but will leave old work there. If we agree on an appropriately named taint, we can have nginx tolerate it by default. Am I missing any reason why this would not work? If that flies, we should fix docs ( those are GCP docs). I am happy to help with that. Longer term maybe we can do something smarter. I am not sure what that would be, just now. Ideas?\nIs there any reason we can't just leave the nodes in the load balancer pool when the node is cordoned? And when the pods are terminated the nodes can be removed? I may be missing some context here?\nThe presumption is that a node that is unschedulable is going away, or needs some other repair. Using it as a target for load-balancers means there could be sessions routed THROUGH that node. Even as the pods are drained. Right up until the node suddenly dies, causing an outage of a different flavor. What should really happen is that a node which becomes unschedulable starts draining connections. Once all the pods are moved off, the node can be removed from the pool entirely. I don't think any cloud providers, even GCP, handle this just right today. David Radcliffe <:\nWait, if you brought up a new nodepool, all those new nodes should be in the TargetPool. Cordoning the old nodepool should only terminate the existing connections, new connections should be fine. Something doesn't add up...\nWas this using\nYes\nRight, well, that explains it. So even draining won't do what you want - you need new connections to be allowed until you have capacity in the new pool. The good news is that you can do this entirely yourself, with taints. We just need nginx to tolerate the taint, which you can also specify yourself. The only real alternative I see would be, as you said, to leave nodes in the LB pool until the node dies. Given that we never specified this, it is probably different on every provider, which would make it hard to change (especially if the provider already provides clean drains while unschedulable).\nIIUC, we don't want new pods to land on the tainted/cordoned nodes. In that case, we can place \"NoSchedule\" taint on the nodes. We don't need any tolerations on nginx. This will prevent new instances of nginx from landing on the tainted nodes, but the existing ones will keep running there.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nThis just surprised us also. I understand the technical reasons behind it but the command name and associated documentation is misleading. To me it isn't intuitive that the command does not remove compute (pods) but does remove some networking. I would expect cordon to keep new pods from getting scheduled to it and keep it from getting to new services/ELBs/etc. The command would then cause pods to be removed and also take the node out of networking paths. Almost need a new state for a node of that is clearly defined.\nMy main issue is with the docs, and also GKE docs. They should explain this pitfall. After I got aware of the issue I understand why it works as it does. A simple workaround is to taint the nodes you are going to rotate first.\nJust chiming in; We as a GKE customer have today been bitten by this issue in production. The documentation of (in the context of GKE) is not extensive enough so we could be aware of this issue. This should be addressed. Luckily the outage was not severe because we were using the node-by-node approach (and accepted the container churn this would cause). We explicitly took this approach because our previous nodepool upgrade was a total outage also caused by in a different way. (for those interested in our total outage, not related to this issue): Due to the fact that also results in the re-calculating the amount of schedulable nodes and thus scaled the amount of pods in our cluster (in our case: from 110 back to 2) resulting for us in major DNS outage internally. Be warned that for a nodepool upgrade can have a lot of unwanted & unexpected side effects.\nIt looks like this happens only to AWS and GCP but not on Azure? Can anyone confirm this? I just tested in both AWS and Azure, and while I see logs like in AWS Kubernetes, I do not see any logs like that in Azure. Is it intended? If so isn't behavior different for each cloud provider? i.e.) cordoning a node in AWS Kubernetes prevents loadbalancer from routing traffic to the affected node but cordoning a node in Azure Kubernetes will still let the loadbalancer route traffic to the affected node. Is it intentional?\nBesides running a test like the above, how would I determine what the behavior is on AWS? I haven't found anything in the node administration docs or the Service that would imply that would shift traffic away from a Pod. In fact, the doc for explicitly states, emphasis mine: If I hadn't come across this Issue due to reports from GKE, I suppose it would only have been a matter of time until we had a high-impact production outage. There's a disconnect between Kubernetes API and the LoadBalancer as to whether Pods running on a 'd node are Ready. From all the docs I've seen, I would expect that either a) would evict Pods over to a Node before setting the instance as , or b) LoadBalancer would not equate with\nHi All, What approaches people using too workaround this? From reading the comments I was hoping to follow the custom taint approach. However, I've noticed executes a cordon making it difficult to drain the node safely with this approach.\nI was lucky in that I experienced this issue while cordoning our testing environment, so we didn't experience a production outage. I think what I'm going to try is the following... it's going to be time-consuming but I think it's the safest bet. Double the number of nodes in the server group to bring online the new nodes first Place a custom taint on each \"legacy\" node As you said, executes a first, so that's a no-go. This is the time-consuming part... for each \"legacy\" node I am going to each pod, and let my PDBs take care of maintaining minimum number of pods. I'm hopeful to try this approach this afternoon, I'll comment back here if I do!\nSame as myself! Pity neither of us have a story for Since my comment this morning I've been trying a few approaches, I've ended up with the following: Create a new node pool of equal size in GKE with the upgraded kube version Set the current node pool to not be able to grow beyond its current size - if your using regional nodes this can be annoying, let it bring up new nodes anyways and just have them taint as NoSchedule straight away Taint all old node pool nodes with NoSchedule Go through each old node pool node executing a taint of NoExecute which will cause the node to drain and go onto available nodes i.e. your newly provisioned node pool Ensure your nginx ingress is deployed with tolerances:\nHi All, I'm at a bit of a loss on this one. I've started using custom taints to drain the nodes without getting them removed from the load balancer. My application can hold a HTTP connection open for up to 600 seconds. I'm using nginx as a daemonset, have it configured with a keepalive timeout of 620s, and have . I drain the application first using a taint on each node. I have nginx on each node tolerate this taint and remove it separately at a later point using a different taint. I'm waiting 660s between drains of each node for each taint to ensure nothing is dropped - this all works fine as expected. However, once I kill the node pool or do a kubectl drain after the node is empty of all my stuff plus nginx ingress I start seeing connection issues. I'm a bit lost where to go at debugging them, best guess is something to do with kube-proxy. Can anyone shed some light on this? is there anything on the Google Layer 4 load balancer I'm missing here? Is there some way to correctly drain kube-proxy (or does that even make sense?)\nThis doesn't address the network issues you're seeing, but for those trying to \"roll their own cordon\" using taints: Using a NoExecute taint to \"drain\" the node won't be orderly and won't respect any PDBs. You want to replicate the logic from which tries to do evictions of every pod in a loop. (I realize this is a burdensome idea, but it is also the safest idea.)\nTo add on to ,: One approach that does not use node taints to force migrate, is to change for the requirements of your app. A change in node selector (e.g. based on instance type), along with a PDB (e.g. 66% / out of 3 replicas availability) should migrate you over fine. This worked out better for me than to drain or add taints to nodes to force push apps out. After the migration completes, you should be able to the nodes, and delete the node pool. FWIW, I too saw connection issues during load testing of a migration, and at least on my setup it was due to using an AWS NLB for the NGINX Ingress Controller. Switching to a classic ELB instead worked, as the NGINX LB Service seems to hit some sort of by my accounts when using NLBs. self-plug: I happened to recently cover a similar topic in a that you may find relevant. Hope it helps\nFor better or worse, for in my case pods that are behind an ingress resource are using node affinity to preferably not schedule them onto the same node. Originally this was done to ensure traffic is balanced across the different nginx ingresses. It has had a positive affect in this case too. Very interesting! Thank you for sharing, I'm not sure that swapping out the Layer4 GCE load balancer is an option here, but you have me thinking. I'm wondering if the TCP keepalive between the LB and nginx is potentially keeping connections open. , and suggest that there may be a 600 second TCP keepalive going on. Will retest doing a sleep of 620s after nginx removal and before node drain.\nHas anyone come up with a strategy to safely move workloads between two pools? Reading this bug, it seems there's no way to reliably do this without causing an outage if you follow the recommendation of + . In my case I'm not using an nginx ingress but services with type . From what I can see, adding to a node causes the Service Controller to consider the node not ready and thus removes it from a target group. This would mean that between and there is no way to add a taint to the node that will leave it in the LB until it's drained. Using doesn't work in this case since the thing I'm draining might just come back and I'm not sure if the service controller will still consider the node ready in that case, but I believe it does. The one strategy I can think of is using labels on the node and an anti-affinity on the pod. You'd then add the label to a node that would push the pod away and then delete the pod. As long as the anti affinity uses this should be safe to do in preparation of a migration. Once the pods have been deleted you could then the nodes.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/lifecycle frozen /remove-lifecycle stale /remove-lifecycle rotten\n- As I mentioned in I set up a script that first taints all nodes in the old node pool and then cordon+taint one by one node. If your ingress services are redundant this should work well.\nIs there a plan for cordon behavior to improve on GCP? We have relied on this behavior for years on our AWS clusters and it was very surprising to find out.\nThis is a bug with service load balancers - not something we should document. We defined a label in that cluster admins can use - Unschedulable has nothing to do with SLB inclusion. which is beta and on by default in 1.19.\nDisagree. Unschedulable means \"no new workloads\". It has nothing to do with existing workloads, that is why we have drain (but we should have something in kube that communicates nodes are draining). I have opened to remove this check - we have an alternate approach now and the old logic is wrong (the comment in the code even says \"this is for masters!\" and that's wrong now too as part of the kep).\nA node status condition?\nPossibly, or a taint, or a label. Something concrete.\n/milestone v1.19", "positive_passages": [{"docid": "doc-en-kubernetes-64f77bddadf74fb2432fbaf2bc1c467e47d7cf828e5ca436425ac45968697464", "text": "func (s *Controller) getNodeConditionPredicate() NodeConditionPredicate { return func(node *v1.Node) bool { <del> // We add the master to the node list, but its unschedulable.  So we use this to filter // the master. if node.Spec.Unschedulable { return false } </del> if s.legacyNodeRoleFeatureEnabled { // As of 1.6, we will taint the master, but not necessarily mark it unschedulable. // Recognize nodes labeled as master, and filter them also, as we were doing previously.", "commid": "kubernetes_pr_90823"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cab42aeb58a419434b628a8ba1af6fcf4b705a5482ca0d7362b0ced98b6e521a", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: In order to migrate to a new version of kubernetes on GKE. I cordoned(Kubectl cordon <node) all nodes in the old node pool(1.8.9) in order to drain the node pool(pods on the node) with an intention to cause the pods to run on a new version of the node pool(1.10.2). As soon as I cordoned all the nodes in the old node pool, it caused the downtime of ingress(nginx). The nginx controller pods where running fine on the cordoned node pool. But the cordon caused the nodes to be removed from the target pool of ingress load balancer. Below are the documents that suggest the above same method that I followed as best practice for zero downtime upgrade. 1). 2). What you expected to happen: I expected \"kubectl cordon <node\" not to have the node/s removed from the target pool of the loadbalancer because the nginx controller pods where running absolutely fine on these nodes. How to reproduce it (as minimally and precisely as possible): 1).Cordon all the nodes in an old node pool that runs nginx controller. Anything else we need to know?: Environment: Kubernetes version (use ): 1.10.2 Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): Container OS Kernel (e.g. ): 4.14.22+ Install tools: Others: Cordon causes to remove the nodes from the target pool of the ingress load balancer. The health checks fail on the nodes of the target pool, which should not be the case. Because the nginx controller pods run fine on these nodes.\nTechnically, this isn't a Kubernetes bug as this is working as intended; however, it does beg the question why we remove unschedulable nodes if they're marked as ready since we perform the to determine LB backend nodes. is it scheduable? is it not a master? is it not marked for exclusion? is it marked as ready? If any of those are a no, then it'll be removed from the pool on the next sync. Perhaps someone from can shed some light. /sig network\ncc This problem extends beyond GCP/ingress controller and to anyone using pools to upgrade nodes. A typical workflow I see is you'd cordon a node pool so as you drain each node the pods don't go to another node in the pool that'll shortly be drained as well. The current logic does not support that and complicates cluster administration because cordoning does not respect PDB's.\n/remove-sig apps /remove-sig gcp (since the service controller falls under sig networking)\nThose labels are not set on the issue: <detailsIn response to : /remove-sig apps /remove-sig gcp Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nRef I thought a general practice for draining the old pool is to move over one node at a time in a rolling fashion. Shouldn't there always be certain backend pods being able to receive & serve traffic? cc\nWRT draining, it is recommended to do it one node at a time ; however, in real world scenarios doing it one node at a time can cause a lot of avoidable container churn if you don't cordon off the nodes you at least plan to drain so that pods aren't being scheduled on a node you'll be draining after the next one. According to the comments in the service controller it seems the unschedulable part exists because it was how we differentiated masters in the past; however, we have labels for that now. We also have the service exclusion label (can't find when/if that'll be promoted though as i don't think there's a ticket on it).\nI'm having problems with this issue as well. The fact that nodes are removed from target pools when cordoned means that I sometimes get brief interruptions of the traffic to a service when I cordon a node. I'm guessing the node isn't gracefully removed from the load balancer which results in some traffic being cut off trying to route through the recently cordoned node. The same problem occasionally happens when deleting nodes / node pools or when the cluster autoscaler deletes a node. We are running GKE ver. 1.10.2-gke.1. Our best defence against these issue have so far been to limit node changes as much as possible and not use any auto scaling.\nI've posted a question regarding this issue in SO some weeks before it was created. The suggested action was to use node taints () instead of cordon, that way nodes will still be marked as .\nThank you for the link, it Certainly helped. Perhaps, if thats the case(as mentioned in the accepted answer of the above link), then to cordon all the nodes of old node pools should not be a recommended action, at least in the GKE upgrade docs.\nonly says: And I can't find what more it does in the documentation. So I would expect that it has exactly the same behaviour as a taint. Why is removing running pods from the balancer working as intended? If it isn't a bug then the documentation is certainly unclear in this regard.\nThis just caused a major outage for us too. I agree with the previous posts, while this may be working as the code intended, it does not follow the patterns and documentation k8s provides. When I cordon a node it should not impact the traffic going to the node or any pods on it. I should be able to gradually remove traffic by draining nodes/pods and respecting PDBs.\nthis issue touches on the fact we are removing masters as well and inadvertently removing cordoned nodes. The logic in the service controller mentions we only filter out unschedulable nodes since that's how masters were setup.\nWe wanted to replace all of the kubernetes cluster nodes to different node instance types, so we started off by cordoning all of the nodes, but it surprisingly caused an outage for us. As pointed out, the only documentation around cordoning is , which I took to mean that new pods can not be scheduled on those nodes. It was surprising behavior to find out that, not only does it not allow new pods to be scheduled on those nodes, but that it also causes the service controller to remove unschedulable nodes from load balancing pools. I understand that it's working as intended, but if that was also documented as part of the cordon operation, I would have been able to avoid an outage.\nI finally caught up to this bug. Fun one. I agree that this is working-as-intended and that it stinks. We can do better. As a short-term workaround, you can taint the nodes before cordoning one-by-one. That will stop new work from arriving, but will leave old work there. If we agree on an appropriately named taint, we can have nginx tolerate it by default. Am I missing any reason why this would not work? If that flies, we should fix docs ( those are GCP docs). I am happy to help with that. Longer term maybe we can do something smarter. I am not sure what that would be, just now. Ideas?\nIs there any reason we can't just leave the nodes in the load balancer pool when the node is cordoned? And when the pods are terminated the nodes can be removed? I may be missing some context here?\nThe presumption is that a node that is unschedulable is going away, or needs some other repair. Using it as a target for load-balancers means there could be sessions routed THROUGH that node. Even as the pods are drained. Right up until the node suddenly dies, causing an outage of a different flavor. What should really happen is that a node which becomes unschedulable starts draining connections. Once all the pods are moved off, the node can be removed from the pool entirely. I don't think any cloud providers, even GCP, handle this just right today. David Radcliffe <:\nWait, if you brought up a new nodepool, all those new nodes should be in the TargetPool. Cordoning the old nodepool should only terminate the existing connections, new connections should be fine. Something doesn't add up...\nWas this using\nYes\nRight, well, that explains it. So even draining won't do what you want - you need new connections to be allowed until you have capacity in the new pool. The good news is that you can do this entirely yourself, with taints. We just need nginx to tolerate the taint, which you can also specify yourself. The only real alternative I see would be, as you said, to leave nodes in the LB pool until the node dies. Given that we never specified this, it is probably different on every provider, which would make it hard to change (especially if the provider already provides clean drains while unschedulable).\nIIUC, we don't want new pods to land on the tainted/cordoned nodes. In that case, we can place \"NoSchedule\" taint on the nodes. We don't need any tolerations on nginx. This will prevent new instances of nginx from landing on the tainted nodes, but the existing ones will keep running there.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nThis just surprised us also. I understand the technical reasons behind it but the command name and associated documentation is misleading. To me it isn't intuitive that the command does not remove compute (pods) but does remove some networking. I would expect cordon to keep new pods from getting scheduled to it and keep it from getting to new services/ELBs/etc. The command would then cause pods to be removed and also take the node out of networking paths. Almost need a new state for a node of that is clearly defined.\nMy main issue is with the docs, and also GKE docs. They should explain this pitfall. After I got aware of the issue I understand why it works as it does. A simple workaround is to taint the nodes you are going to rotate first.\nJust chiming in; We as a GKE customer have today been bitten by this issue in production. The documentation of (in the context of GKE) is not extensive enough so we could be aware of this issue. This should be addressed. Luckily the outage was not severe because we were using the node-by-node approach (and accepted the container churn this would cause). We explicitly took this approach because our previous nodepool upgrade was a total outage also caused by in a different way. (for those interested in our total outage, not related to this issue): Due to the fact that also results in the re-calculating the amount of schedulable nodes and thus scaled the amount of pods in our cluster (in our case: from 110 back to 2) resulting for us in major DNS outage internally. Be warned that for a nodepool upgrade can have a lot of unwanted & unexpected side effects.\nIt looks like this happens only to AWS and GCP but not on Azure? Can anyone confirm this? I just tested in both AWS and Azure, and while I see logs like in AWS Kubernetes, I do not see any logs like that in Azure. Is it intended? If so isn't behavior different for each cloud provider? i.e.) cordoning a node in AWS Kubernetes prevents loadbalancer from routing traffic to the affected node but cordoning a node in Azure Kubernetes will still let the loadbalancer route traffic to the affected node. Is it intentional?\nBesides running a test like the above, how would I determine what the behavior is on AWS? I haven't found anything in the node administration docs or the Service that would imply that would shift traffic away from a Pod. In fact, the doc for explicitly states, emphasis mine: If I hadn't come across this Issue due to reports from GKE, I suppose it would only have been a matter of time until we had a high-impact production outage. There's a disconnect between Kubernetes API and the LoadBalancer as to whether Pods running on a 'd node are Ready. From all the docs I've seen, I would expect that either a) would evict Pods over to a Node before setting the instance as , or b) LoadBalancer would not equate with\nHi All, What approaches people using too workaround this? From reading the comments I was hoping to follow the custom taint approach. However, I've noticed executes a cordon making it difficult to drain the node safely with this approach.\nI was lucky in that I experienced this issue while cordoning our testing environment, so we didn't experience a production outage. I think what I'm going to try is the following... it's going to be time-consuming but I think it's the safest bet. Double the number of nodes in the server group to bring online the new nodes first Place a custom taint on each \"legacy\" node As you said, executes a first, so that's a no-go. This is the time-consuming part... for each \"legacy\" node I am going to each pod, and let my PDBs take care of maintaining minimum number of pods. I'm hopeful to try this approach this afternoon, I'll comment back here if I do!\nSame as myself! Pity neither of us have a story for Since my comment this morning I've been trying a few approaches, I've ended up with the following: Create a new node pool of equal size in GKE with the upgraded kube version Set the current node pool to not be able to grow beyond its current size - if your using regional nodes this can be annoying, let it bring up new nodes anyways and just have them taint as NoSchedule straight away Taint all old node pool nodes with NoSchedule Go through each old node pool node executing a taint of NoExecute which will cause the node to drain and go onto available nodes i.e. your newly provisioned node pool Ensure your nginx ingress is deployed with tolerances:\nHi All, I'm at a bit of a loss on this one. I've started using custom taints to drain the nodes without getting them removed from the load balancer. My application can hold a HTTP connection open for up to 600 seconds. I'm using nginx as a daemonset, have it configured with a keepalive timeout of 620s, and have . I drain the application first using a taint on each node. I have nginx on each node tolerate this taint and remove it separately at a later point using a different taint. I'm waiting 660s between drains of each node for each taint to ensure nothing is dropped - this all works fine as expected. However, once I kill the node pool or do a kubectl drain after the node is empty of all my stuff plus nginx ingress I start seeing connection issues. I'm a bit lost where to go at debugging them, best guess is something to do with kube-proxy. Can anyone shed some light on this? is there anything on the Google Layer 4 load balancer I'm missing here? Is there some way to correctly drain kube-proxy (or does that even make sense?)\nThis doesn't address the network issues you're seeing, but for those trying to \"roll their own cordon\" using taints: Using a NoExecute taint to \"drain\" the node won't be orderly and won't respect any PDBs. You want to replicate the logic from which tries to do evictions of every pod in a loop. (I realize this is a burdensome idea, but it is also the safest idea.)\nTo add on to ,: One approach that does not use node taints to force migrate, is to change for the requirements of your app. A change in node selector (e.g. based on instance type), along with a PDB (e.g. 66% / out of 3 replicas availability) should migrate you over fine. This worked out better for me than to drain or add taints to nodes to force push apps out. After the migration completes, you should be able to the nodes, and delete the node pool. FWIW, I too saw connection issues during load testing of a migration, and at least on my setup it was due to using an AWS NLB for the NGINX Ingress Controller. Switching to a classic ELB instead worked, as the NGINX LB Service seems to hit some sort of by my accounts when using NLBs. self-plug: I happened to recently cover a similar topic in a that you may find relevant. Hope it helps\nFor better or worse, for in my case pods that are behind an ingress resource are using node affinity to preferably not schedule them onto the same node. Originally this was done to ensure traffic is balanced across the different nginx ingresses. It has had a positive affect in this case too. Very interesting! Thank you for sharing, I'm not sure that swapping out the Layer4 GCE load balancer is an option here, but you have me thinking. I'm wondering if the TCP keepalive between the LB and nginx is potentially keeping connections open. , and suggest that there may be a 600 second TCP keepalive going on. Will retest doing a sleep of 620s after nginx removal and before node drain.\nHas anyone come up with a strategy to safely move workloads between two pools? Reading this bug, it seems there's no way to reliably do this without causing an outage if you follow the recommendation of + . In my case I'm not using an nginx ingress but services with type . From what I can see, adding to a node causes the Service Controller to consider the node not ready and thus removes it from a target group. This would mean that between and there is no way to add a taint to the node that will leave it in the LB until it's drained. Using doesn't work in this case since the thing I'm draining might just come back and I'm not sure if the service controller will still consider the node ready in that case, but I believe it does. The one strategy I can think of is using labels on the node and an anti-affinity on the pod. You'd then add the label to a node that would push the pod away and then delete the pod. As long as the anti affinity uses this should be safe to do in preparation of a migration. Once the pods have been deleted you could then the nodes.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/lifecycle frozen /remove-lifecycle stale /remove-lifecycle rotten\n- As I mentioned in I set up a script that first taints all nodes in the old node pool and then cordon+taint one by one node. If your ingress services are redundant this should work well.\nIs there a plan for cordon behavior to improve on GCP? We have relied on this behavior for years on our AWS clusters and it was very surprising to find out.\nThis is a bug with service load balancers - not something we should document. We defined a label in that cluster admins can use - Unschedulable has nothing to do with SLB inclusion. which is beta and on by default in 1.19.\nDisagree. Unschedulable means \"no new workloads\". It has nothing to do with existing workloads, that is why we have drain (but we should have something in kube that communicates nodes are draining). I have opened to remove this check - we have an alternate approach now and the old logic is wrong (the comment in the code even says \"this is for masters!\" and that's wrong now too as part of the kep).\nA node status condition?\nPossibly, or a taint, or a label. Something concrete.\n/milestone v1.19", "positive_passages": [{"docid": "doc-en-kubernetes-15d36c83b20b960cab6624bab196ab42b7da2fb7c638168f08ad95a8e476b005", "text": "input           *v1.Node want            bool }{ <ins> {want: false, input: &v1.Node{}}, {want: true, input: &v1.Node{Status: v1.NodeStatus{Conditions: []v1.NodeCondition{{Type: v1.NodeReady, Status: v1.ConditionTrue}}}}}, {want: false, input: &v1.Node{Status: v1.NodeStatus{Conditions: []v1.NodeCondition{{Type: v1.NodeReady, Status: v1.ConditionFalse}}}}}, {want: true, input: &v1.Node{Spec: v1.NodeSpec{Unschedulable: true}, Status: v1.NodeStatus{Conditions: []v1.NodeCondition{{Type: v1.NodeReady, Status: v1.ConditionTrue}}}}}, </ins> {want: true, input: &v1.Node{Status: validNodeStatus, ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{}}}}, {want: true, input: &v1.Node{Status: validNodeStatus, ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{labelNodeRoleMaster: \"\"}}}}, {want: true, input: &v1.Node{Status: validNodeStatus, ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{labelNodeRoleExcludeBalancer: \"\"}}}},", "commid": "kubernetes_pr_90823"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-757ffe38af6bfdd71e6f1e75d3560a3f5382542c1abe2fb0fcd35a36bf5c5dd1", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: after granting sp access to azure ACR , pull image from ACR would fail, and after wait about 15-30min, pull image would success. Root cause is that needs to be refreshed when doing , otherwise it will always return empty registry list. Related issue: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.7 - v1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig azure /assign I will implement that function.\nThanks -- can we add a milestone label?\n+1. We should fix this within v1.12 release and cherry pick to old releases. /priority critical-urgent /milestone v1.12\n/status approved-for-milestone\n[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nI'm not sure if this is related, but I'm seeing nodes (after they've been working fine for a few days) randomly start to fail pulling images with the error . Edit: I see this as the culprit: , after which all image pulls start to fail.\nthis is not related, original issue is that after granting sp access to azure acr, pull image still fails with . After my repro and investigation(really spent a lot of time...), I found the issue lies here, would return empty even after granting sp access to azure acr, and after around 15min, it returns correct loginServer list: Looks like it's a SDK or acr list with specific sp issue, workaround is wait around 15min or more time, it could recover by itself. Paste my investigation logs here, I grant sp access to acr in around , you could see it returns empty registry list first and then after a few more minutes, it returns the correct list with loginServer:\nBTW, in v1.12, acr list() uses new API, I will check whether in v1.12 would have same issue. Acutally I have already implemented LazyProvide func(check here: ), while it won't fix the original issue.\nUpdate: After a few more tries, I found it's related to this code snippet, before , we need to generate a new ServicePrincipalToken every time: I will move this code snippet into Provide() func, and send out a PR! The failure recover time is within 2min now.", "positive_passages": [{"docid": "doc-en-kubernetes-28060553700264661bbbaa635a6a8c8572d672e7b2819a0a7e3e84ac87009638", "text": "const dummyRegistryEmail = \"name@contoso.com\" <ins> var containerRegistryUrls = []string{\"*.azurecr.io\", \"*.azurecr.cn\", \"*.azurecr.de\", \"*.azurecr.us\"} </ins> // init registers the various means by which credentials may // be resolved on Azure. func init() {", "commid": "kubernetes_pr_66429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-757ffe38af6bfdd71e6f1e75d3560a3f5382542c1abe2fb0fcd35a36bf5c5dd1", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: after granting sp access to azure ACR , pull image from ACR would fail, and after wait about 15-30min, pull image would success. Root cause is that needs to be refreshed when doing , otherwise it will always return empty registry list. Related issue: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.7 - v1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig azure /assign I will implement that function.\nThanks -- can we add a milestone label?\n+1. We should fix this within v1.12 release and cherry pick to old releases. /priority critical-urgent /milestone v1.12\n/status approved-for-milestone\n[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nI'm not sure if this is related, but I'm seeing nodes (after they've been working fine for a few days) randomly start to fail pulling images with the error . Edit: I see this as the culprit: , after which all image pulls start to fail.\nthis is not related, original issue is that after granting sp access to azure acr, pull image still fails with . After my repro and investigation(really spent a lot of time...), I found the issue lies here, would return empty even after granting sp access to azure acr, and after around 15min, it returns correct loginServer list: Looks like it's a SDK or acr list with specific sp issue, workaround is wait around 15min or more time, it could recover by itself. Paste my investigation logs here, I grant sp access to acr in around , you could see it returns empty registry list first and then after a few more minutes, it returns the correct list with loginServer:\nBTW, in v1.12, acr list() uses new API, I will check whether in v1.12 would have same issue. Acutally I have already implemented LazyProvide func(check here: ), while it won't fix the original issue.\nUpdate: After a few more tries, I found it's related to this code snippet, before , we need to generate a new ServicePrincipalToken every time: I will move this code snippet into Provide() func, and send out a PR! The failure recover time is within 2min now.", "positive_passages": [{"docid": "doc-en-kubernetes-8c84f2cf40ce63d41e419b322ae76d9f68e533a05816178c00f8eb73df6f5176", "text": "ctx, cancel := getContextWithCancel() defer cancel() <del> glog.V(4).Infof(\"listing registries\") result, err := a.registryClient.List(ctx) if err != nil { glog.Errorf(\"Failed to list registries: %v\", err) return cfg } for ix := range result { loginServer := getLoginServer(result[ix]) var cred *credentialprovider.DockerConfigEntry </del> <ins> if a.config.UseManagedIdentityExtension { glog.V(4).Infof(\"listing registries\") result, err := a.registryClient.List(ctx) if err != nil { glog.Errorf(\"Failed to list registries: %v\", err) return cfg } </ins> <del> if a.config.UseManagedIdentityExtension { cred, err = getACRDockerEntryFromARMToken(a, loginServer) </del> <ins> for ix := range result { loginServer := getLoginServer(result[ix]) glog.V(2).Infof(\"loginServer: %s\", loginServer) cred, err := getACRDockerEntryFromARMToken(a, loginServer) </ins> if err != nil { continue } <del> } else { cred = &credentialprovider.DockerConfigEntry{ </del> <ins> cfg[loginServer] = *cred } } else { // Add our entry for each of the supported container registry URLs for _, url := range containerRegistryUrls { cred := &credentialprovider.DockerConfigEntry{ </ins> Username: a.config.AADClientID, Password: a.config.AADClientSecret, Email:    dummyRegistryEmail, } <ins> cfg[url] = *cred </ins> } <del> cfg[loginServer] = *cred </del> } return cfg }", "commid": "kubernetes_pr_66429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-757ffe38af6bfdd71e6f1e75d3560a3f5382542c1abe2fb0fcd35a36bf5c5dd1", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: after granting sp access to azure ACR , pull image from ACR would fail, and after wait about 15-30min, pull image would success. Root cause is that needs to be refreshed when doing , otherwise it will always return empty registry list. Related issue: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.7 - v1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig azure /assign I will implement that function.\nThanks -- can we add a milestone label?\n+1. We should fix this within v1.12 release and cherry pick to old releases. /priority critical-urgent /milestone v1.12\n/status approved-for-milestone\n[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=\"\"Additional instructions</a</li<li<a href=\"\"Commands for setting labels</a</li</ul</details\nI'm not sure if this is related, but I'm seeing nodes (after they've been working fine for a few days) randomly start to fail pulling images with the error . Edit: I see this as the culprit: , after which all image pulls start to fail.\nthis is not related, original issue is that after granting sp access to azure acr, pull image still fails with . After my repro and investigation(really spent a lot of time...), I found the issue lies here, would return empty even after granting sp access to azure acr, and after around 15min, it returns correct loginServer list: Looks like it's a SDK or acr list with specific sp issue, workaround is wait around 15min or more time, it could recover by itself. Paste my investigation logs here, I grant sp access to acr in around , you could see it returns empty registry list first and then after a few more minutes, it returns the correct list with loginServer:\nBTW, in v1.12, acr list() uses new API, I will check whether in v1.12 would have same issue. Acutally I have already implemented LazyProvide func(check here: ), while it won't fix the original issue.\nUpdate: After a few more tries, I found it's related to this code snippet, before , we need to generate a new ServicePrincipalToken every time: I will move this code snippet into Provide() func, and send out a PR! The failure recover time is within 2min now.", "positive_passages": [{"docid": "doc-en-kubernetes-20f06e957ebd253b2f9a3c0baaa653051235d42395bb311ded9636a3dafe6453", "text": "{ Name: to.StringPtr(\"foo\"), RegistryProperties: &containerregistry.RegistryProperties{ <del> LoginServer: to.StringPtr(\"foo-microsoft.azurecr.io\"), </del> <ins> LoginServer: to.StringPtr(\"*.azurecr.io\"), </ins> }, }, { Name: to.StringPtr(\"bar\"), RegistryProperties: &containerregistry.RegistryProperties{ <del> LoginServer: to.StringPtr(\"bar-microsoft.azurecr.io\"), </del> <ins> LoginServer: to.StringPtr(\"*.azurecr.cn\"), </ins> }, }, { Name: to.StringPtr(\"baz\"), RegistryProperties: &containerregistry.RegistryProperties{ <del> LoginServer: to.StringPtr(\"baz-microsoft.azurecr.io\"), </del> <ins> LoginServer: to.StringPtr(\"*.azurecr.de\"), }, }, { Name: to.StringPtr(\"bus\"), RegistryProperties: &containerregistry.RegistryProperties{ LoginServer: to.StringPtr(\"*.azurecr.us\"), </ins> }, }, }", "commid": "kubernetes_pr_66429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc7c8e4dca431b05eb10616ff2a250bffbca5716787380e263be4e54f6be7096", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: I need to know to which Pod(s) a PVC is being mounted to, without having to go through each Pod one by one checking the Volume mounts and the PersistentVolumeClaim. The kubectl describe pvc and get pvc, only tell you to which Persistent Volume the PVC is bound to, but not if is being used by a Pod(s) What you expected to happen: Add a new field in the describe or get that lists the pods that are using the PVC as a volume mount How to reproduce it (as minimally and precisely as possible): Have a PV/PVC bound and create a pod using a volume mount Anything else we need to know?: Not sure if this is only for Azure Disk, which is the Storage Class I am using. Environment: Kubernetes version (use ): 7 Cloud provider or hardware configuration: Azure OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): 4 Install tools: Azure Kubernetes Services Others: -n/a\n/sig storage\n/sig cli\nI think the kubectl describe can just construct this on the fly. Another angle is should we add this information to PVC object itself\nThat will be great, as right now the only way to correlate a PVC to a Pod is via a \"describe\" on the Pod.\nI can work on a PR for this!\nGitHub didn't allow me to assign the following users: clandry94. Note that only and repo collaborators can be assigned. <detailsIn response to : I can work on this! Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n+1 for the feature. cc\nHow to find \"what pods are using particular PVC through command line\"\n+1 for the feature.\nthis feature will be in Kubernetes 1.12\nok kubernetes 1.12 released, how to? which command?\nCan someone point to the documentation or paste command to get the pods which have the PVC in use\nsee the associated PR to see an example usage of this The line in should show it.\nWorkaround for the meantime:\nThanks , this workaround is great for those people who still use old kubernetes version. However it will meet an error if the pod have no volumes, so I improves it by adding a to check whether the volumes exists or not.\npython script to list pods with pvc in namespace(s): Is a part of a cli to set pods with velero/restic annotations. Hope it helps someone :)\nFor posterity... There is a Used By: field in the output of describe.\nclient-go didn't give this api... ,PodPVCIndex can solve the problem\nHi thanks worked for me ;) but I want to make it reverse my workarounds with adding after didn't worked do you have any ideas\n$ kubectl describe pvc -A Used\" Name: ocs-deviceset-lso-volumeset-0-data-1b45dn Namespace: openshift-storage StorageClass: lso-volumeset Used By: rook-ceph-osd-1--8fwpd Also useful ^\nthe reason it didn't work is because each return does, in point of fact, have a key defined for claimName. That key is just set to null value. So, what you'd actually want to do is test for nulls. As nice as answer is, it's a PITA to parse unstructured human-readable command output, as opposed to command output in a markup language that well known shell parsers like jq and yq can work with. Towards that end, because I had use of this, I came up with the following: That simple not null test at the end plucks out all your nulls. Obviously invert the last conditional if you want all the nulls, but you'll get all sorts of temp things that way that you probably won't care about.", "positive_passages": [{"docid": "doc-en-kubernetes-b4e3512cb79b947656cba5e5237a5e90c520421e044aad820ba60ef6d5b80799", "text": "return \"\", err } <ins> pc := d.Core().Pods(namespace) mountPods, err := getMountPods(pc, pvc.Name) if err != nil { return \"\", err } </ins> events, _ := d.Core().Events(namespace).Search(legacyscheme.Scheme, pvc) <del> return describePersistentVolumeClaim(pvc, events) </del> <ins> return describePersistentVolumeClaim(pvc, events, mountPods) } func getMountPods(c coreclient.PodInterface, pvcName string) ([]api.Pod, error) { nsPods, err := c.List(metav1.ListOptions{}) if err != nil { return []api.Pod{}, err } var pods []api.Pod for _, pod := range nsPods.Items { pvcs := getPvcs(pod.Spec.Volumes) for _, pvc := range pvcs { if pvc.PersistentVolumeClaim.ClaimName == pvcName { pods = append(pods, pod) } } } return pods, nil </ins> } <del> func describePersistentVolumeClaim(pvc *api.PersistentVolumeClaim, events *api.EventList) (string, error) { </del> <ins> func getPvcs(volumes []api.Volume) []api.Volume { var pvcs []api.Volume for _, volume := range volumes { if volume.VolumeSource.PersistentVolumeClaim != nil { pvcs = append(pvcs, volume) } } return pvcs } func describePersistentVolumeClaim(pvc *api.PersistentVolumeClaim, events *api.EventList, mountPods []api.Pod) (string, error) { </ins> return tabbedString(func(out io.Writer) error { w := NewPrefixWriter(out) w.Write(LEVEL_0, \"Name:t%sn\", pvc.Name)", "commid": "kubernetes_pr_65837"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc7c8e4dca431b05eb10616ff2a250bffbca5716787380e263be4e54f6be7096", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: I need to know to which Pod(s) a PVC is being mounted to, without having to go through each Pod one by one checking the Volume mounts and the PersistentVolumeClaim. The kubectl describe pvc and get pvc, only tell you to which Persistent Volume the PVC is bound to, but not if is being used by a Pod(s) What you expected to happen: Add a new field in the describe or get that lists the pods that are using the PVC as a volume mount How to reproduce it (as minimally and precisely as possible): Have a PV/PVC bound and create a pod using a volume mount Anything else we need to know?: Not sure if this is only for Azure Disk, which is the Storage Class I am using. Environment: Kubernetes version (use ): 7 Cloud provider or hardware configuration: Azure OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): 4 Install tools: Azure Kubernetes Services Others: -n/a\n/sig storage\n/sig cli\nI think the kubectl describe can just construct this on the fly. Another angle is should we add this information to PVC object itself\nThat will be great, as right now the only way to correlate a PVC to a Pod is via a \"describe\" on the Pod.\nI can work on a PR for this!\nGitHub didn't allow me to assign the following users: clandry94. Note that only and repo collaborators can be assigned. <detailsIn response to : I can work on this! Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n+1 for the feature. cc\nHow to find \"what pods are using particular PVC through command line\"\n+1 for the feature.\nthis feature will be in Kubernetes 1.12\nok kubernetes 1.12 released, how to? which command?\nCan someone point to the documentation or paste command to get the pods which have the PVC in use\nsee the associated PR to see an example usage of this The line in should show it.\nWorkaround for the meantime:\nThanks , this workaround is great for those people who still use old kubernetes version. However it will meet an error if the pod have no volumes, so I improves it by adding a to check whether the volumes exists or not.\npython script to list pods with pvc in namespace(s): Is a part of a cli to set pods with velero/restic annotations. Hope it helps someone :)\nFor posterity... There is a Used By: field in the output of describe.\nclient-go didn't give this api... ,PodPVCIndex can solve the problem\nHi thanks worked for me ;) but I want to make it reverse my workarounds with adding after didn't worked do you have any ideas\n$ kubectl describe pvc -A Used\" Name: ocs-deviceset-lso-volumeset-0-data-1b45dn Namespace: openshift-storage StorageClass: lso-volumeset Used By: rook-ceph-osd-1--8fwpd Also useful ^\nthe reason it didn't work is because each return does, in point of fact, have a key defined for claimName. That key is just set to null value. So, what you'd actually want to do is test for nulls. As nice as answer is, it's a PITA to parse unstructured human-readable command output, as opposed to command output in a markup language that well known shell parsers like jq and yq can work with. Towards that end, because I had use of this, I came up with the following: That simple not null test at the end plucks out all your nulls. Obviously invert the last conditional if you want all the nulls, but you'll get all sorts of temp things that way that you probably won't care about.", "positive_passages": [{"docid": "doc-en-kubernetes-03893711550b910023fb896859b81e1ea918738eec7af48edb2e99e3a32f4294", "text": "DescribeEvents(events, w) } <ins> printPodsMultiline(w, \"Mounted By\", mountPods) </ins> return nil }) }", "commid": "kubernetes_pr_65837"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc7c8e4dca431b05eb10616ff2a250bffbca5716787380e263be4e54f6be7096", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: I need to know to which Pod(s) a PVC is being mounted to, without having to go through each Pod one by one checking the Volume mounts and the PersistentVolumeClaim. The kubectl describe pvc and get pvc, only tell you to which Persistent Volume the PVC is bound to, but not if is being used by a Pod(s) What you expected to happen: Add a new field in the describe or get that lists the pods that are using the PVC as a volume mount How to reproduce it (as minimally and precisely as possible): Have a PV/PVC bound and create a pod using a volume mount Anything else we need to know?: Not sure if this is only for Azure Disk, which is the Storage Class I am using. Environment: Kubernetes version (use ): 7 Cloud provider or hardware configuration: Azure OS (e.g. from /etc/os-release): Ubuntu 16.04 Kernel (e.g. ): 4 Install tools: Azure Kubernetes Services Others: -n/a\n/sig storage\n/sig cli\nI think the kubectl describe can just construct this on the fly. Another angle is should we add this information to PVC object itself\nThat will be great, as right now the only way to correlate a PVC to a Pod is via a \"describe\" on the Pod.\nI can work on a PR for this!\nGitHub didn't allow me to assign the following users: clandry94. Note that only and repo collaborators can be assigned. <detailsIn response to : I can work on this! Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n+1 for the feature. cc\nHow to find \"what pods are using particular PVC through command line\"\n+1 for the feature.\nthis feature will be in Kubernetes 1.12\nok kubernetes 1.12 released, how to? which command?\nCan someone point to the documentation or paste command to get the pods which have the PVC in use\nsee the associated PR to see an example usage of this The line in should show it.\nWorkaround for the meantime:\nThanks , this workaround is great for those people who still use old kubernetes version. However it will meet an error if the pod have no volumes, so I improves it by adding a to check whether the volumes exists or not.\npython script to list pods with pvc in namespace(s): Is a part of a cli to set pods with velero/restic annotations. Hope it helps someone :)\nFor posterity... There is a Used By: field in the output of describe.\nclient-go didn't give this api... ,PodPVCIndex can solve the problem\nHi thanks worked for me ;) but I want to make it reverse my workarounds with adding after didn't worked do you have any ideas\n$ kubectl describe pvc -A Used\" Name: ocs-deviceset-lso-volumeset-0-data-1b45dn Namespace: openshift-storage StorageClass: lso-volumeset Used By: rook-ceph-osd-1--8fwpd Also useful ^\nthe reason it didn't work is because each return does, in point of fact, have a key defined for claimName. That key is just set to null value. So, what you'd actually want to do is test for nulls. As nice as answer is, it's a PITA to parse unstructured human-readable command output, as opposed to command output in a markup language that well known shell parsers like jq and yq can work with. Towards that end, because I had use of this, I came up with the following: That simple not null test at the end plucks out all your nulls. Obviously invert the last conditional if you want all the nulls, but you'll get all sorts of temp things that way that you probably won't care about.", "positive_passages": [{"docid": "doc-en-kubernetes-38f2c460b7a46178a2142071559a72fb71787feabe6626bc6205bfeb0a6cb934", "text": "} } <ins> // printPodsMultiline prints multiple pods with a proper alignment. func printPodsMultiline(w PrefixWriter, title string, pods []api.Pod) { printPodsMultilineWithIndent(w, \"\", title, \"t\", pods) } // printPodsMultilineWithIndent prints multiple pods with a user-defined alignment. func printPodsMultilineWithIndent(w PrefixWriter, initialIndent, title, innerIndent string, pods []api.Pod) { w.Write(LEVEL_0, \"%s%s:%s\", initialIndent, title, innerIndent) if pods == nil || len(pods) == 0 { w.WriteLine(\"<none>\") return } // to print pods in the sorted order sort.Slice(pods, func(i, j int) bool { cmpKey := func(pod api.Pod) string { return pod.Name } return cmpKey(pods[i]) < cmpKey(pods[j]) }) for i, pod := range pods { if i != 0 { w.Write(LEVEL_0, \"%s\", initialIndent) w.Write(LEVEL_0, \"%s\", innerIndent) } w.Write(LEVEL_0, \"%sn\", pod.Name) } } </ins> // printPodTolerationsMultiline prints multiple tolerations with a proper alignment. func printPodTolerationsMultiline(w PrefixWriter, title string, tolerations []api.Toleration) { printTolerationsMultilineWithIndent(w, \"\", title, \"t\", tolerations)", "commid": "kubernetes_pr_65837"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-392a747797b3e1c2752bc049b84086988d167ceb650865e5c35034d88d820b6c", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug /sig network /area kube-proxy /area ipvs /assign I'll send a fixing pull request tomorrow. What happened: On centos 7.2 with ipset 6.29, kube-proxy in ipvs mode failed to create ipset sets. After some dig, it turns out to be problem of ipset on centos/rh. See I tried ipset 6.29 on ubuntu, it's OK. But when I tried ipset 6.29 on centos, I got errors: What you expected to happen: Since the problematic ipset versions have very large installation base, we could remove ipset commet, or remove ipset commet with problematic ipset version. The problematic ipset also says it support comment by --help. The problem could be detected by a test run of \"ipset create foo hash:ip comment\". How to reproduce it (as minimally and precisely as possible): Create some service in kubernetes, run kube-proxy with ipvs mode on Centos 7.x node. Anything else we need to know?: Environment: Kubernetes version (use ): commit (actually all commits after ) Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): CentOS Linux release 7.2.1511 (Core) Kernel (e.g. ): Linux VM34centos 3.10.0-514.26.2.el7.x8664 SMP Tue Jul 4 15:04:05 UTC 2017 x8664 x8664 x8664 GNU/Linux Install tools: Others: ipset v6.29, protocol version: 6\ncould you test it before commit , that's ok?\n, yes, I did. It's OK. But I think the we don't need to revert the iptables comments.\nif ipset package not installed, will set module or match-set option in rule be weird and now seems not.", "positive_passages": [{"docid": "doc-en-kubernetes-f3b57084afd47c355dac2ad186ed47e64a3924af3734cdc12cff2cd2081d0af5", "text": "// If ignoreExistErr is set to true, then the -exist option of ipset will be specified, ipset ignores the error // otherwise raised when the same set (setname and create parameters are identical) already exists. func (runner *runner) createSet(set *IPSet, ignoreExistErr bool) error { <del> args := []string{\"create\", set.Name, string(set.SetType), \"comment\"} </del> <ins> args := []string{\"create\", set.Name, string(set.SetType)} </ins> if set.SetType == HashIPPortIP || set.SetType == HashIPPort { args = append(args, \"family\", set.HashFamily,", "commid": "kubernetes_pr_65533"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-392a747797b3e1c2752bc049b84086988d167ceb650865e5c35034d88d820b6c", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug /sig network /area kube-proxy /area ipvs /assign I'll send a fixing pull request tomorrow. What happened: On centos 7.2 with ipset 6.29, kube-proxy in ipvs mode failed to create ipset sets. After some dig, it turns out to be problem of ipset on centos/rh. See I tried ipset 6.29 on ubuntu, it's OK. But when I tried ipset 6.29 on centos, I got errors: What you expected to happen: Since the problematic ipset versions have very large installation base, we could remove ipset commet, or remove ipset commet with problematic ipset version. The problematic ipset also says it support comment by --help. The problem could be detected by a test run of \"ipset create foo hash:ip comment\". How to reproduce it (as minimally and precisely as possible): Create some service in kubernetes, run kube-proxy with ipvs mode on Centos 7.x node. Anything else we need to know?: Environment: Kubernetes version (use ): commit (actually all commits after ) Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): CentOS Linux release 7.2.1511 (Core) Kernel (e.g. ): Linux VM34centos 3.10.0-514.26.2.el7.x8664 SMP Tue Jul 4 15:04:05 UTC 2017 x8664 x8664 x8664 GNU/Linux Install tools: Others: ipset v6.29, protocol version: 6\ncould you test it before commit , that's ok?\n, yes, I did. It's OK. But I think the we don't need to revert the iptables comments.\nif ipset package not installed, will set module or match-set option in rule be weird and now seems not.", "positive_passages": [{"docid": "doc-en-kubernetes-834c6ebc51ab7503c46edb5ce4b11eea4ddaab2defcf1742d128f64ac5fb51c5", "text": "// If the -exist option is specified, ipset ignores the error otherwise raised when // the same set (setname and create parameters are identical) already exists. func (runner *runner) AddEntry(entry string, set *IPSet, ignoreExistErr bool) error { <del> args := []string{\"add\", set.Name, entry, \"comment\", set.Comment} </del> <ins> args := []string{\"add\", set.Name, entry} </ins> if ignoreExistErr { args = append(args, \"-exist\") }", "commid": "kubernetes_pr_65533"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-392a747797b3e1c2752bc049b84086988d167ceb650865e5c35034d88d820b6c", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug /sig network /area kube-proxy /area ipvs /assign I'll send a fixing pull request tomorrow. What happened: On centos 7.2 with ipset 6.29, kube-proxy in ipvs mode failed to create ipset sets. After some dig, it turns out to be problem of ipset on centos/rh. See I tried ipset 6.29 on ubuntu, it's OK. But when I tried ipset 6.29 on centos, I got errors: What you expected to happen: Since the problematic ipset versions have very large installation base, we could remove ipset commet, or remove ipset commet with problematic ipset version. The problematic ipset also says it support comment by --help. The problem could be detected by a test run of \"ipset create foo hash:ip comment\". How to reproduce it (as minimally and precisely as possible): Create some service in kubernetes, run kube-proxy with ipvs mode on Centos 7.x node. Anything else we need to know?: Environment: Kubernetes version (use ): commit (actually all commits after ) Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): CentOS Linux release 7.2.1511 (Core) Kernel (e.g. ): Linux VM34centos 3.10.0-514.26.2.el7.x8664 SMP Tue Jul 4 15:04:05 UTC 2017 x8664 x8664 x8664 GNU/Linux Install tools: Others: ipset v6.29, protocol version: 6\ncould you test it before commit , that's ok?\n, yes, I did. It's OK. But I think the we don't need to revert the iptables comments.\nif ipset package not installed, will set module or match-set option in rule be weird and now seems not.", "positive_passages": [{"docid": "doc-en-kubernetes-ad330240bd74565a455e26f2ddfe1c704e33e4883cea45fdc4a811ca8e0b8985", "text": "// DelEntry is used to delete the specified entry from the set. func (runner *runner) DelEntry(entry string, set string) error { <del> entry = strings.Split(entry, \" comment\")[0] </del> if _, err := runner.exec.Command(IPSetCmd, \"del\", set, entry).CombinedOutput(); err != nil { return fmt.Errorf(\"error deleting entry %s: from set: %s, error: %v\", entry, set, err) }", "commid": "kubernetes_pr_65533"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1d1abdd74cdb3621d2817b67140cd372d542d8b5422c1bfbe8473adbaa86f3f5", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: After merged, the leader election is calling too many api calls. Previously it calls with a 2s interval by default. Now it calls with 0 interval. Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\n/sig api-machinery\n/assign\n/kind bug", "positive_passages": [{"docid": "doc-en-kubernetes-58ec4257316fa4d9e593fe2b528d24c7b0575e0f5bb6fba721fd5609c76a8759", "text": "le.config.Lock.RecordEvent(\"stopped leading\") glog.Infof(\"failed to renew lease %v: %v\", desc, err) cancel() <del> }, 0, ctx.Done()) </del> <ins> }, le.config.RetryPeriod, ctx.Done()) </ins> } // tryAcquireOrRenew tries to acquire a leader lease if it is not already acquired,", "commid": "kubernetes_pr_65667"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b1b5aac033196141508f40a7a5ea6449e76d4ca03418f562f45bd84bbb3caae", "query": "What happened: Data race in tests in an unrelated PR Logs https://k8s- /kind bug /area platform/vsphere /area cloudprovider /sig cloud-provider\n/kind flake\nAnother time it flaked in an unrelated PR https://k8s-\nbringing this to your attention as a vsphere dev.\n/assign\nLooks like the race was in Feb 2017 here: But that code path wasn't covered by go test until vcsim support was here: I'll work on a fix.", "positive_passages": [{"docid": "doc-en-kubernetes-acee50c05f03a4393f6a404c5e26bc6467581cc19a9e2f738383c48f277573dc", "text": "// Logout calls SessionManager.Logout for the given connection. func (connection *VSphereConnection) Logout(ctx context.Context) { <del> m := session.NewManager(connection.Client) </del> <ins> clientLock.Lock() c := connection.Client clientLock.Unlock() if c == nil { return } m := session.NewManager(c) </ins> hasActiveSession, err := m.SessionIsActive(ctx) if err != nil {", "commid": "kubernetes_pr_65913"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b1b5aac033196141508f40a7a5ea6449e76d4ca03418f562f45bd84bbb3caae", "query": "What happened: Data race in tests in an unrelated PR Logs https://k8s- /kind bug /area platform/vsphere /area cloudprovider /sig cloud-provider\n/kind flake\nAnother time it flaked in an unrelated PR https://k8s-\nbringing this to your attention as a vsphere dev.\n/assign\nLooks like the race was in Feb 2017 here: But that code path wasn't covered by go test until vcsim support was here: I'll work on a fix.", "positive_passages": [{"docid": "doc-en-kubernetes-000dd86bdcecaee7b0ae8413dbb33fd19c857f05d80586112e54ecfb6f1b6741", "text": "func logout(vs *VSphere) { for _, vsphereIns := range vs.vsphereInstanceMap { <del> if vsphereIns.conn.Client != nil { vsphereIns.conn.Logout(context.TODO()) } </del> <ins> vsphereIns.conn.Logout(context.TODO()) </ins> } } // Instances returns an implementation of Instances for vSphere.", "commid": "kubernetes_pr_65913"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6d88c3f57c9a7fe083bc7fa6547d93018ed161eee205c0f2188edca1d2af8f07", "query": "Is this a BUG REPORT or FEATURE REQUEST?: What happened: The output of my kubeadm: When I pull the image with docker pull, I get such output: But other images are successfully pulled as we can see from previous log. Why?\n/sig cluster-lifecycle cc\nUgh can you fix this please? I missed this in the PR that just got merged, should be without the arch suffix as this is a manifest list\nGetting on with this ASAP.\nfyi ,", "positive_passages": [{"docid": "doc-en-kubernetes-fcfe7ba3d79af145897111a88eabb172a8c6b1c561cbbbf52c3d54c8d9d544d0", "text": "dnsImage := GetGenericArchImage(cfg.ImageRepository, \"k8s-dns-kube-dns\", constants.KubeDNSVersion) if features.Enabled(cfg.FeatureGates, features.CoreDNS) { <del> dnsImage = GetGenericArchImage(cfg.ImageRepository, \"coredns\", constants.CoreDNSVersion) </del> <ins> dnsImage = fmt.Sprintf(\"%s/%s:%s\", cfg.ImageRepository, constants.CoreDNS, constants.CoreDNSVersion) </ins> } imgs = append(imgs, dnsImage) return imgs", "commid": "kubernetes_pr_65764"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1c2f27cc7995dc0195a6d562a190312b043b529fecef2bd3bd3317c48a4bd434", "query": "Implement proposal for Azure We should implement interface in Azure cloud provider. returns true if the instance is in stopped state to detach volumes. But if instance is deleted we should not return error. Related features: Related proposal: Related PRs: /kind feature /sig azure /cc\n- can you assign me on this one ? I already have a PR in flight.\nThat's great! /assign just loop in for this RP review, thanks.\nGitHub didn't allow me to assign the following users: yastij. Note that only and repo collaborators can be assigned. <detailsIn response to : That's great! /assign just loop in for this RP review, thanks. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\no, you are not a k8s member yet, anyway, you could send out the PR for this feature, related to this issue, thanks.\nThanks, looking forward to your PR.", "positive_passages": [{"docid": "doc-en-kubernetes-deb39527973221cd7518e35e8c3f193530e4b836694e43d6f5cb8b71033f00a4", "text": "func (f *fakeVMSet) GetDataDisks(nodeName types.NodeName) ([]compute.DataDisk, error) { return nil, fmt.Errorf(\"unimplemented\") } <ins> func (f *fakeVMSet) GetProvisioningStateByNodeName(name string) (string, error) { return \"\", fmt.Errorf(\"unimplemented\") } </ins>", "commid": "kubernetes_pr_68033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1c2f27cc7995dc0195a6d562a190312b043b529fecef2bd3bd3317c48a4bd434", "query": "Implement proposal for Azure We should implement interface in Azure cloud provider. returns true if the instance is in stopped state to detach volumes. But if instance is deleted we should not return error. Related features: Related proposal: Related PRs: /kind feature /sig azure /cc\n- can you assign me on this one ? I already have a PR in flight.\nThat's great! /assign just loop in for this RP review, thanks.\nGitHub didn't allow me to assign the following users: yastij. Note that only and repo collaborators can be assigned. <detailsIn response to : That's great! /assign just loop in for this RP review, thanks. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\no, you are not a k8s member yet, anyway, you could send out the PR for this feature, related to this issue, thanks.\nThanks, looking forward to your PR.", "positive_passages": [{"docid": "doc-en-kubernetes-72b449c3ea1a23fb85af5876b917df56148e4cac38203e465ca65db9b36ecaf5", "text": "// InstanceShutdownByProviderID returns true if the instance is in safe state to detach volumes func (az *Cloud) InstanceShutdownByProviderID(ctx context.Context, providerID string) (bool, error) { <del> return false, cloudprovider.NotImplemented </del> <ins> nodeName, err := az.vmSet.GetNodeNameByProviderID(providerID) if err != nil { return false, err } provisioningState, err := az.vmSet.GetProvisioningStateByNodeName(string(nodeName)) if err != nil { return false, err } return strings.ToLower(provisioningState) == \"stopped\" || strings.ToLower(provisioningState) == \"deallocated\", nil </ins> } // getComputeMetadata gets compute information from instance metadata.", "commid": "kubernetes_pr_68033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1c2f27cc7995dc0195a6d562a190312b043b529fecef2bd3bd3317c48a4bd434", "query": "Implement proposal for Azure We should implement interface in Azure cloud provider. returns true if the instance is in stopped state to detach volumes. But if instance is deleted we should not return error. Related features: Related proposal: Related PRs: /kind feature /sig azure /cc\n- can you assign me on this one ? I already have a PR in flight.\nThat's great! /assign just loop in for this RP review, thanks.\nGitHub didn't allow me to assign the following users: yastij. Note that only and repo collaborators can be assigned. <detailsIn response to : That's great! /assign just loop in for this RP review, thanks. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\no, you are not a k8s member yet, anyway, you could send out the PR for this feature, related to this issue, thanks.\nThanks, looking forward to your PR.", "positive_passages": [{"docid": "doc-en-kubernetes-855362c04ac678a1bdd60796b9c1c584779e5c3f556d3ac5eb846f8670708975", "text": "return *machine.ID, nil } <ins> func (as *availabilitySet) GetProvisioningStateByNodeName(name string) (provisioningState string, err error) { vm, err := as.getVirtualMachine(types.NodeName(name)) if err != nil { return provisioningState, err } return *vm.ProvisioningState, nil } </ins> // GetNodeNameByProviderID gets the node name by provider ID. func (as *availabilitySet) GetNodeNameByProviderID(providerID string) (types.NodeName, error) { // NodeName is part of providerID for standard instances.", "commid": "kubernetes_pr_68033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1c2f27cc7995dc0195a6d562a190312b043b529fecef2bd3bd3317c48a4bd434", "query": "Implement proposal for Azure We should implement interface in Azure cloud provider. returns true if the instance is in stopped state to detach volumes. But if instance is deleted we should not return error. Related features: Related proposal: Related PRs: /kind feature /sig azure /cc\n- can you assign me on this one ? I already have a PR in flight.\nThat's great! /assign just loop in for this RP review, thanks.\nGitHub didn't allow me to assign the following users: yastij. Note that only and repo collaborators can be assigned. <detailsIn response to : That's great! /assign just loop in for this RP review, thanks. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\no, you are not a k8s member yet, anyway, you could send out the PR for this feature, related to this issue, thanks.\nThanks, looking forward to your PR.", "positive_passages": [{"docid": "doc-en-kubernetes-9df1c1b341bf75b539d9b041f0b754008ad5d482652ffa2149407a8011e8890e", "text": "DetachDiskByName(diskName, diskURI string, nodeName types.NodeName) error // GetDataDisks gets a list of data disks attached to the node. GetDataDisks(nodeName types.NodeName) ([]compute.DataDisk, error) <ins> // GetProvisioningStateByNodeName gets the provisioning state by node name. GetProvisioningStateByNodeName(name string) (string, error) </ins> }", "commid": "kubernetes_pr_68033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1c2f27cc7995dc0195a6d562a190312b043b529fecef2bd3bd3317c48a4bd434", "query": "Implement proposal for Azure We should implement interface in Azure cloud provider. returns true if the instance is in stopped state to detach volumes. But if instance is deleted we should not return error. Related features: Related proposal: Related PRs: /kind feature /sig azure /cc\n- can you assign me on this one ? I already have a PR in flight.\nThat's great! /assign just loop in for this RP review, thanks.\nGitHub didn't allow me to assign the following users: yastij. Note that only and repo collaborators can be assigned. <detailsIn response to : That's great! /assign just loop in for this RP review, thanks. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\no, you are not a k8s member yet, anyway, you could send out the PR for this feature, related to this issue, thanks.\nThanks, looking forward to your PR.", "positive_passages": [{"docid": "doc-en-kubernetes-20fa639dffd6a6161128886a7a4659025b2d830e9dec2d7f1a3bd7da9fb7af1b", "text": "return ssName, instanceID, *(cachedVM.(*compute.VirtualMachineScaleSetVM)), nil } <ins> func (ss *scaleSet) GetProvisioningStateByNodeName(name string) (provisioningState string, err error) { _, _, vm, err := ss.getVmssVM(name) if err != nil { return provisioningState, err } return *vm.ProvisioningState, nil } </ins> // getCachedVirtualMachineByInstanceID gets scaleSetVMInfo from cache. // The node must belong to one of scale sets. func (ss *scaleSet) getVmssVMByInstanceID(resourceGroup, scaleSetName, instanceID string) (vm compute.VirtualMachineScaleSetVM, err error) {", "commid": "kubernetes_pr_68033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21d79d4b86405dc56238b9a9ac0bd543c859fd67cfeabcc17cfe386742e18a8d", "query": "/kind bug What happened: When creating a node port application (in this case the example guestbook) on a host server that is dual stacked and has AAAA and A DNS entries, the node port on the v6 address is open to kube-proxy and hangs. What you expected to happen: The v6 address would refuse the connection and the client would fall back onto the v4 address which would connect correctly. How to reproduce it (as minimally and precisely as possible): kubeadm init with the above, and join in some workers. Then install the guestbook application Obtain the node port with and telnet to one of the servers on that port from a dual stacked client. The client will connect and refuse to respond to 'GET /' telnet directly to the IPv4 address of the server on the port and all works as expected. Anything else we need to know?: kube-proxy is noted as listening on the port. Environment: Kubernetes version (use ): ubuntu kubectl version Client Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:53:20Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:43:26Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Brightbox OS (e.g. from /etc/os-release): Ubuntu 18.04.1 LTS Kernel (e.g. ): Linux srv-jidtj 4.15.0-29-generic -Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm 1.11 Others:\n/sig network\nLooks like kube-proxy in ipvs mode listens on the nodeport ports to ensure they're not in use by something else. It just binds and listens, it doesn't serve requests. It binds on both ipv4 and ipv6 but never expects to receive connections because the iptables/ipvs rules intercept them, but on ipv4 clusters there is nothing stopping ipv6 connections coming in. The comment there does admit that only a bind is necessary to do this, but doing a full listen just made e2e tests easier. /cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen This now causes conformance failure on e2e tests due to the promotion of the Nodeport test in\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill an issue on 1.16 when running in standard IPv4 mode\nAs I understand this thread, I have the same problem. I thought that it is a node configuration or some kubernetes flag that I didn't set but it seems it ain't. I ask already on SO: Environment Kubernetes version (use kubectl version): Client Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:36:53Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-10-02T16:51:36Z\", GoVersion:\"go1.12.10\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: On premise, on virtual machines using hyper-v OS (e.g. from /etc/os-release): NAME=\"Ubuntu\" VERSION=\"18.04.3 LTS (Bionic Beaver)\" Kernel (e.g. uname -a): Linux kubernetes 5.0.0-29-generic # 31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm version: &version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:34:01Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n/lifecycle frozen\n/assign bowei\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nLooking through the comments, this looks like a bug that could have a targeted fix. /remove-triage unresolved /good-first-issue /help-wanted\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : Looking through the comments, this looks like a bug that could have a targeted fix. /good-first-issue /help-wanted </details\nI will attempt to solve this issue.\nany success or progress? If you left this issue I would like to give it a go as a first time contributor. Thanks, Yuval\nI'm still working on this as my first issue, and planning to produce a solution by 20th.\nI wasn't able to tackle the issue and will not continue trying, feel free to take it.\n/assign yuvalsteuer\nStill, open -- anyone actively working on this? I would like to attempt if not. :) /assign rkc007\nOK, again still open, doesn't look like anyone is working on this. I'd like to try it. The fix that occurs to me is simply to only listen to IPv6 addresses if the cluster is IPv6. If the e2e tests fail in this case (from looking at I don't think they will) then maybe they need to be updated. Does that make sense? What I'm not sure about is if we should do nothing with IPv6 ports or bind (to claim the port) but not listen.\n/assign michaelbeaumont", "positive_passages": [{"docid": "doc-en-kubernetes-0ef91e9080dea5daea24112145ccbc47f79741356cdf77654e67d1bd0ae7192e", "text": "type listenPortOpener struct{} // OpenLocalPort holds the given local port open. <del> func (l *listenPortOpener) OpenLocalPort(lp *utilproxy.LocalPort) (utilproxy.Closeable, error) { return openLocalPort(lp) </del> <ins> func (l *listenPortOpener) OpenLocalPort(lp *utilproxy.LocalPort, isIPv6 bool) (utilproxy.Closeable, error) { return openLocalPort(lp, isIPv6) </ins> } // Proxier implements proxy.Provider", "commid": "kubernetes_pr_87699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21d79d4b86405dc56238b9a9ac0bd543c859fd67cfeabcc17cfe386742e18a8d", "query": "/kind bug What happened: When creating a node port application (in this case the example guestbook) on a host server that is dual stacked and has AAAA and A DNS entries, the node port on the v6 address is open to kube-proxy and hangs. What you expected to happen: The v6 address would refuse the connection and the client would fall back onto the v4 address which would connect correctly. How to reproduce it (as minimally and precisely as possible): kubeadm init with the above, and join in some workers. Then install the guestbook application Obtain the node port with and telnet to one of the servers on that port from a dual stacked client. The client will connect and refuse to respond to 'GET /' telnet directly to the IPv4 address of the server on the port and all works as expected. Anything else we need to know?: kube-proxy is noted as listening on the port. Environment: Kubernetes version (use ): ubuntu kubectl version Client Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:53:20Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:43:26Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Brightbox OS (e.g. from /etc/os-release): Ubuntu 18.04.1 LTS Kernel (e.g. ): Linux srv-jidtj 4.15.0-29-generic -Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm 1.11 Others:\n/sig network\nLooks like kube-proxy in ipvs mode listens on the nodeport ports to ensure they're not in use by something else. It just binds and listens, it doesn't serve requests. It binds on both ipv4 and ipv6 but never expects to receive connections because the iptables/ipvs rules intercept them, but on ipv4 clusters there is nothing stopping ipv6 connections coming in. The comment there does admit that only a bind is necessary to do this, but doing a full listen just made e2e tests easier. /cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen This now causes conformance failure on e2e tests due to the promotion of the Nodeport test in\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill an issue on 1.16 when running in standard IPv4 mode\nAs I understand this thread, I have the same problem. I thought that it is a node configuration or some kubernetes flag that I didn't set but it seems it ain't. I ask already on SO: Environment Kubernetes version (use kubectl version): Client Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:36:53Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-10-02T16:51:36Z\", GoVersion:\"go1.12.10\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: On premise, on virtual machines using hyper-v OS (e.g. from /etc/os-release): NAME=\"Ubuntu\" VERSION=\"18.04.3 LTS (Bionic Beaver)\" Kernel (e.g. uname -a): Linux kubernetes 5.0.0-29-generic # 31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm version: &version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:34:01Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n/lifecycle frozen\n/assign bowei\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nLooking through the comments, this looks like a bug that could have a targeted fix. /remove-triage unresolved /good-first-issue /help-wanted\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : Looking through the comments, this looks like a bug that could have a targeted fix. /good-first-issue /help-wanted </details\nI will attempt to solve this issue.\nany success or progress? If you left this issue I would like to give it a go as a first time contributor. Thanks, Yuval\nI'm still working on this as my first issue, and planning to produce a solution by 20th.\nI wasn't able to tackle the issue and will not continue trying, feel free to take it.\n/assign yuvalsteuer\nStill, open -- anyone actively working on this? I would like to attempt if not. :) /assign rkc007\nOK, again still open, doesn't look like anyone is working on this. I'd like to try it. The fix that occurs to me is simply to only listen to IPv6 addresses if the cluster is IPv6. If the e2e tests fail in this case (from looking at I don't think they will) then maybe they need to be updated. Does that make sense? What I'm not sure about is if we should do nothing with IPv6 ports or bind (to claim the port) but not listen.\n/assign michaelbeaumont", "positive_passages": [{"docid": "doc-en-kubernetes-08223336ee4efeb2f228a6a4f31802fa4dccc84a41bc5478b97ba488fa6a5208", "text": "klog.V(4).Infof(\"Port %s was open before and is still needed\", lp.String()) replacementPortsMap[lp] = proxier.portsMap[lp] } else if svcInfo.Protocol() != v1.ProtocolSCTP { <del> socket, err := proxier.portMapper.OpenLocalPort(&lp) </del> <ins> socket, err := proxier.portMapper.OpenLocalPort(&lp, isIPv6) </ins> if err != nil { klog.Errorf(\"can't open %s, skipping this nodePort: %v\", lp.String(), err) continue", "commid": "kubernetes_pr_87699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21d79d4b86405dc56238b9a9ac0bd543c859fd67cfeabcc17cfe386742e18a8d", "query": "/kind bug What happened: When creating a node port application (in this case the example guestbook) on a host server that is dual stacked and has AAAA and A DNS entries, the node port on the v6 address is open to kube-proxy and hangs. What you expected to happen: The v6 address would refuse the connection and the client would fall back onto the v4 address which would connect correctly. How to reproduce it (as minimally and precisely as possible): kubeadm init with the above, and join in some workers. Then install the guestbook application Obtain the node port with and telnet to one of the servers on that port from a dual stacked client. The client will connect and refuse to respond to 'GET /' telnet directly to the IPv4 address of the server on the port and all works as expected. Anything else we need to know?: kube-proxy is noted as listening on the port. Environment: Kubernetes version (use ): ubuntu kubectl version Client Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:53:20Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:43:26Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Brightbox OS (e.g. from /etc/os-release): Ubuntu 18.04.1 LTS Kernel (e.g. ): Linux srv-jidtj 4.15.0-29-generic -Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm 1.11 Others:\n/sig network\nLooks like kube-proxy in ipvs mode listens on the nodeport ports to ensure they're not in use by something else. It just binds and listens, it doesn't serve requests. It binds on both ipv4 and ipv6 but never expects to receive connections because the iptables/ipvs rules intercept them, but on ipv4 clusters there is nothing stopping ipv6 connections coming in. The comment there does admit that only a bind is necessary to do this, but doing a full listen just made e2e tests easier. /cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen This now causes conformance failure on e2e tests due to the promotion of the Nodeport test in\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill an issue on 1.16 when running in standard IPv4 mode\nAs I understand this thread, I have the same problem. I thought that it is a node configuration or some kubernetes flag that I didn't set but it seems it ain't. I ask already on SO: Environment Kubernetes version (use kubectl version): Client Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:36:53Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-10-02T16:51:36Z\", GoVersion:\"go1.12.10\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: On premise, on virtual machines using hyper-v OS (e.g. from /etc/os-release): NAME=\"Ubuntu\" VERSION=\"18.04.3 LTS (Bionic Beaver)\" Kernel (e.g. uname -a): Linux kubernetes 5.0.0-29-generic # 31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm version: &version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:34:01Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n/lifecycle frozen\n/assign bowei\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nLooking through the comments, this looks like a bug that could have a targeted fix. /remove-triage unresolved /good-first-issue /help-wanted\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : Looking through the comments, this looks like a bug that could have a targeted fix. /good-first-issue /help-wanted </details\nI will attempt to solve this issue.\nany success or progress? If you left this issue I would like to give it a go as a first time contributor. Thanks, Yuval\nI'm still working on this as my first issue, and planning to produce a solution by 20th.\nI wasn't able to tackle the issue and will not continue trying, feel free to take it.\n/assign yuvalsteuer\nStill, open -- anyone actively working on this? I would like to attempt if not. :) /assign rkc007\nOK, again still open, doesn't look like anyone is working on this. I'd like to try it. The fix that occurs to me is simply to only listen to IPv6 addresses if the cluster is IPv6. If the e2e tests fail in this case (from looking at I don't think they will) then maybe they need to be updated. Does that make sense? What I'm not sure about is if we should do nothing with IPv6 ports or bind (to claim the port) but not listen.\n/assign michaelbeaumont", "positive_passages": [{"docid": "doc-en-kubernetes-86261ee9f904138774d674fe8d96f91b723d183de8c960ec85032d098fe4946e", "text": "buf.WriteByte('n') } <del> func openLocalPort(lp *utilproxy.LocalPort) (utilproxy.Closeable, error) { </del> <ins> func openLocalPort(lp *utilproxy.LocalPort, isIPv6 bool) (utilproxy.Closeable, error) { </ins> // For ports on node IPs, open the actual port and hold it, even though we // use iptables to redirect traffic. // This ensures a) that it's safe to use that port and b) that (a) stays", "commid": "kubernetes_pr_87699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21d79d4b86405dc56238b9a9ac0bd543c859fd67cfeabcc17cfe386742e18a8d", "query": "/kind bug What happened: When creating a node port application (in this case the example guestbook) on a host server that is dual stacked and has AAAA and A DNS entries, the node port on the v6 address is open to kube-proxy and hangs. What you expected to happen: The v6 address would refuse the connection and the client would fall back onto the v4 address which would connect correctly. How to reproduce it (as minimally and precisely as possible): kubeadm init with the above, and join in some workers. Then install the guestbook application Obtain the node port with and telnet to one of the servers on that port from a dual stacked client. The client will connect and refuse to respond to 'GET /' telnet directly to the IPv4 address of the server on the port and all works as expected. Anything else we need to know?: kube-proxy is noted as listening on the port. Environment: Kubernetes version (use ): ubuntu kubectl version Client Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:53:20Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:43:26Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Brightbox OS (e.g. from /etc/os-release): Ubuntu 18.04.1 LTS Kernel (e.g. ): Linux srv-jidtj 4.15.0-29-generic -Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm 1.11 Others:\n/sig network\nLooks like kube-proxy in ipvs mode listens on the nodeport ports to ensure they're not in use by something else. It just binds and listens, it doesn't serve requests. It binds on both ipv4 and ipv6 but never expects to receive connections because the iptables/ipvs rules intercept them, but on ipv4 clusters there is nothing stopping ipv6 connections coming in. The comment there does admit that only a bind is necessary to do this, but doing a full listen just made e2e tests easier. /cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen This now causes conformance failure on e2e tests due to the promotion of the Nodeport test in\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill an issue on 1.16 when running in standard IPv4 mode\nAs I understand this thread, I have the same problem. I thought that it is a node configuration or some kubernetes flag that I didn't set but it seems it ain't. I ask already on SO: Environment Kubernetes version (use kubectl version): Client Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:36:53Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-10-02T16:51:36Z\", GoVersion:\"go1.12.10\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: On premise, on virtual machines using hyper-v OS (e.g. from /etc/os-release): NAME=\"Ubuntu\" VERSION=\"18.04.3 LTS (Bionic Beaver)\" Kernel (e.g. uname -a): Linux kubernetes 5.0.0-29-generic # 31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm version: &version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:34:01Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n/lifecycle frozen\n/assign bowei\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nLooking through the comments, this looks like a bug that could have a targeted fix. /remove-triage unresolved /good-first-issue /help-wanted\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : Looking through the comments, this looks like a bug that could have a targeted fix. /good-first-issue /help-wanted </details\nI will attempt to solve this issue.\nany success or progress? If you left this issue I would like to give it a go as a first time contributor. Thanks, Yuval\nI'm still working on this as my first issue, and planning to produce a solution by 20th.\nI wasn't able to tackle the issue and will not continue trying, feel free to take it.\n/assign yuvalsteuer\nStill, open -- anyone actively working on this? I would like to attempt if not. :) /assign rkc007\nOK, again still open, doesn't look like anyone is working on this. I'd like to try it. The fix that occurs to me is simply to only listen to IPv6 addresses if the cluster is IPv6. If the e2e tests fail in this case (from looking at I don't think they will) then maybe they need to be updated. Does that make sense? What I'm not sure about is if we should do nothing with IPv6 ports or bind (to claim the port) but not listen.\n/assign michaelbeaumont", "positive_passages": [{"docid": "doc-en-kubernetes-2de70c59ee837fce07e8169ead469f5ed4e34be16aeda2adfd79ba7cb5583bff", "text": "klog.Errorf(\"Failed to cast serviceInfo %q\", svcName.String()) continue } <ins> isIPv6 := utilnet.IsIPv6(svcInfo.ClusterIP()) </ins> protocol := strings.ToLower(string(svcInfo.Protocol())) // Precompute svcNameString; with many services the many calls // to ServicePortName.String() show up in CPU profiles.", "commid": "kubernetes_pr_87699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21d79d4b86405dc56238b9a9ac0bd543c859fd67cfeabcc17cfe386742e18a8d", "query": "/kind bug What happened: When creating a node port application (in this case the example guestbook) on a host server that is dual stacked and has AAAA and A DNS entries, the node port on the v6 address is open to kube-proxy and hangs. What you expected to happen: The v6 address would refuse the connection and the client would fall back onto the v4 address which would connect correctly. How to reproduce it (as minimally and precisely as possible): kubeadm init with the above, and join in some workers. Then install the guestbook application Obtain the node port with and telnet to one of the servers on that port from a dual stacked client. The client will connect and refuse to respond to 'GET /' telnet directly to the IPv4 address of the server on the port and all works as expected. Anything else we need to know?: kube-proxy is noted as listening on the port. Environment: Kubernetes version (use ): ubuntu kubectl version Client Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:53:20Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:43:26Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Brightbox OS (e.g. from /etc/os-release): Ubuntu 18.04.1 LTS Kernel (e.g. ): Linux srv-jidtj 4.15.0-29-generic -Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm 1.11 Others:\n/sig network\nLooks like kube-proxy in ipvs mode listens on the nodeport ports to ensure they're not in use by something else. It just binds and listens, it doesn't serve requests. It binds on both ipv4 and ipv6 but never expects to receive connections because the iptables/ipvs rules intercept them, but on ipv4 clusters there is nothing stopping ipv6 connections coming in. The comment there does admit that only a bind is necessary to do this, but doing a full listen just made e2e tests easier. /cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen This now causes conformance failure on e2e tests due to the promotion of the Nodeport test in\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill an issue on 1.16 when running in standard IPv4 mode\nAs I understand this thread, I have the same problem. I thought that it is a node configuration or some kubernetes flag that I didn't set but it seems it ain't. I ask already on SO: Environment Kubernetes version (use kubectl version): Client Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:36:53Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-10-02T16:51:36Z\", GoVersion:\"go1.12.10\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: On premise, on virtual machines using hyper-v OS (e.g. from /etc/os-release): NAME=\"Ubuntu\" VERSION=\"18.04.3 LTS (Bionic Beaver)\" Kernel (e.g. uname -a): Linux kubernetes 5.0.0-29-generic # 31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm version: &version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:34:01Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n/lifecycle frozen\n/assign bowei\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nLooking through the comments, this looks like a bug that could have a targeted fix. /remove-triage unresolved /good-first-issue /help-wanted\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : Looking through the comments, this looks like a bug that could have a targeted fix. /good-first-issue /help-wanted </details\nI will attempt to solve this issue.\nany success or progress? If you left this issue I would like to give it a go as a first time contributor. Thanks, Yuval\nI'm still working on this as my first issue, and planning to produce a solution by 20th.\nI wasn't able to tackle the issue and will not continue trying, feel free to take it.\n/assign yuvalsteuer\nStill, open -- anyone actively working on this? I would like to attempt if not. :) /assign rkc007\nOK, again still open, doesn't look like anyone is working on this. I'd like to try it. The fix that occurs to me is simply to only listen to IPv6 addresses if the cluster is IPv6. If the e2e tests fail in this case (from looking at I don't think they will) then maybe they need to be updated. Does that make sense? What I'm not sure about is if we should do nothing with IPv6 ports or bind (to claim the port) but not listen.\n/assign michaelbeaumont", "positive_passages": [{"docid": "doc-en-kubernetes-68b897f61f5f5d98395177eea1dc804d46542eb9ee06edcf4672f5e1b9cfe69d", "text": "klog.V(4).Infof(\"Port %s was open before and is still needed\", lp.String()) replacementPortsMap[lp] = proxier.portsMap[lp] } else { <del> socket, err := proxier.portMapper.OpenLocalPort(&lp) </del> <ins> socket, err := proxier.portMapper.OpenLocalPort(&lp, isIPv6) </ins> if err != nil { msg := fmt.Sprintf(\"can't open %s, skipping this externalIP: %v\", lp.String(), err)", "commid": "kubernetes_pr_87699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21d79d4b86405dc56238b9a9ac0bd543c859fd67cfeabcc17cfe386742e18a8d", "query": "/kind bug What happened: When creating a node port application (in this case the example guestbook) on a host server that is dual stacked and has AAAA and A DNS entries, the node port on the v6 address is open to kube-proxy and hangs. What you expected to happen: The v6 address would refuse the connection and the client would fall back onto the v4 address which would connect correctly. How to reproduce it (as minimally and precisely as possible): kubeadm init with the above, and join in some workers. Then install the guestbook application Obtain the node port with and telnet to one of the servers on that port from a dual stacked client. The client will connect and refuse to respond to 'GET /' telnet directly to the IPv4 address of the server on the port and all works as expected. Anything else we need to know?: kube-proxy is noted as listening on the port. Environment: Kubernetes version (use ): ubuntu kubectl version Client Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:53:20Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:43:26Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Brightbox OS (e.g. from /etc/os-release): Ubuntu 18.04.1 LTS Kernel (e.g. ): Linux srv-jidtj 4.15.0-29-generic -Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm 1.11 Others:\n/sig network\nLooks like kube-proxy in ipvs mode listens on the nodeport ports to ensure they're not in use by something else. It just binds and listens, it doesn't serve requests. It binds on both ipv4 and ipv6 but never expects to receive connections because the iptables/ipvs rules intercept them, but on ipv4 clusters there is nothing stopping ipv6 connections coming in. The comment there does admit that only a bind is necessary to do this, but doing a full listen just made e2e tests easier. /cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen This now causes conformance failure on e2e tests due to the promotion of the Nodeport test in\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill an issue on 1.16 when running in standard IPv4 mode\nAs I understand this thread, I have the same problem. I thought that it is a node configuration or some kubernetes flag that I didn't set but it seems it ain't. I ask already on SO: Environment Kubernetes version (use kubectl version): Client Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:36:53Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-10-02T16:51:36Z\", GoVersion:\"go1.12.10\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: On premise, on virtual machines using hyper-v OS (e.g. from /etc/os-release): NAME=\"Ubuntu\" VERSION=\"18.04.3 LTS (Bionic Beaver)\" Kernel (e.g. uname -a): Linux kubernetes 5.0.0-29-generic # 31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm version: &version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:34:01Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n/lifecycle frozen\n/assign bowei\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nLooking through the comments, this looks like a bug that could have a targeted fix. /remove-triage unresolved /good-first-issue /help-wanted\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : Looking through the comments, this looks like a bug that could have a targeted fix. /good-first-issue /help-wanted </details\nI will attempt to solve this issue.\nany success or progress? If you left this issue I would like to give it a go as a first time contributor. Thanks, Yuval\nI'm still working on this as my first issue, and planning to produce a solution by 20th.\nI wasn't able to tackle the issue and will not continue trying, feel free to take it.\n/assign yuvalsteuer\nStill, open -- anyone actively working on this? I would like to attempt if not. :) /assign rkc007\nOK, again still open, doesn't look like anyone is working on this. I'd like to try it. The fix that occurs to me is simply to only listen to IPv6 addresses if the cluster is IPv6. If the e2e tests fail in this case (from looking at I don't think they will) then maybe they need to be updated. Does that make sense? What I'm not sure about is if we should do nothing with IPv6 ports or bind (to claim the port) but not listen.\n/assign michaelbeaumont", "positive_passages": [{"docid": "doc-en-kubernetes-be14a23b8836d777acb23777dc3f999d0779bb26a4949601e049a79bfff1d4be", "text": "// We do not start listening on SCTP ports, according to our agreement in the // SCTP support KEP } else if svcInfo.Protocol() != v1.ProtocolSCTP { <del> socket, err := proxier.portMapper.OpenLocalPort(&lp) </del> <ins> socket, err := proxier.portMapper.OpenLocalPort(&lp, isIPv6) </ins> if err != nil { klog.Errorf(\"can't open %s, skipping this nodePort: %v\", lp.String(), err) continue } if lp.Protocol == \"udp\" { <del> isIPv6 := utilnet.IsIPv6(svcInfo.ClusterIP()) </del> conntrack.ClearEntriesForPort(proxier.exec, lp.Port, isIPv6, v1.ProtocolUDP) } replacementPortsMap[lp] = socket", "commid": "kubernetes_pr_87699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21d79d4b86405dc56238b9a9ac0bd543c859fd67cfeabcc17cfe386742e18a8d", "query": "/kind bug What happened: When creating a node port application (in this case the example guestbook) on a host server that is dual stacked and has AAAA and A DNS entries, the node port on the v6 address is open to kube-proxy and hangs. What you expected to happen: The v6 address would refuse the connection and the client would fall back onto the v4 address which would connect correctly. How to reproduce it (as minimally and precisely as possible): kubeadm init with the above, and join in some workers. Then install the guestbook application Obtain the node port with and telnet to one of the servers on that port from a dual stacked client. The client will connect and refuse to respond to 'GET /' telnet directly to the IPv4 address of the server on the port and all works as expected. Anything else we need to know?: kube-proxy is noted as listening on the port. Environment: Kubernetes version (use ): ubuntu kubectl version Client Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:53:20Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:43:26Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Brightbox OS (e.g. from /etc/os-release): Ubuntu 18.04.1 LTS Kernel (e.g. ): Linux srv-jidtj 4.15.0-29-generic -Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm 1.11 Others:\n/sig network\nLooks like kube-proxy in ipvs mode listens on the nodeport ports to ensure they're not in use by something else. It just binds and listens, it doesn't serve requests. It binds on both ipv4 and ipv6 but never expects to receive connections because the iptables/ipvs rules intercept them, but on ipv4 clusters there is nothing stopping ipv6 connections coming in. The comment there does admit that only a bind is necessary to do this, but doing a full listen just made e2e tests easier. /cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen This now causes conformance failure on e2e tests due to the promotion of the Nodeport test in\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill an issue on 1.16 when running in standard IPv4 mode\nAs I understand this thread, I have the same problem. I thought that it is a node configuration or some kubernetes flag that I didn't set but it seems it ain't. I ask already on SO: Environment Kubernetes version (use kubectl version): Client Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:36:53Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-10-02T16:51:36Z\", GoVersion:\"go1.12.10\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: On premise, on virtual machines using hyper-v OS (e.g. from /etc/os-release): NAME=\"Ubuntu\" VERSION=\"18.04.3 LTS (Bionic Beaver)\" Kernel (e.g. uname -a): Linux kubernetes 5.0.0-29-generic # 31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm version: &version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:34:01Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n/lifecycle frozen\n/assign bowei\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nLooking through the comments, this looks like a bug that could have a targeted fix. /remove-triage unresolved /good-first-issue /help-wanted\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : Looking through the comments, this looks like a bug that could have a targeted fix. /good-first-issue /help-wanted </details\nI will attempt to solve this issue.\nany success or progress? If you left this issue I would like to give it a go as a first time contributor. Thanks, Yuval\nI'm still working on this as my first issue, and planning to produce a solution by 20th.\nI wasn't able to tackle the issue and will not continue trying, feel free to take it.\n/assign yuvalsteuer\nStill, open -- anyone actively working on this? I would like to attempt if not. :) /assign rkc007\nOK, again still open, doesn't look like anyone is working on this. I'd like to try it. The fix that occurs to me is simply to only listen to IPv6 addresses if the cluster is IPv6. If the e2e tests fail in this case (from looking at I don't think they will) then maybe they need to be updated. Does that make sense? What I'm not sure about is if we should do nothing with IPv6 ports or bind (to claim the port) but not listen.\n/assign michaelbeaumont", "positive_passages": [{"docid": "doc-en-kubernetes-5723b118cffa789c9eae2162d5fa4c94c7096fa251d82ffc496911c5d3fbf344", "text": "type listenPortOpener struct{} // OpenLocalPort holds the given local port open. <del> func (l *listenPortOpener) OpenLocalPort(lp *utilproxy.LocalPort) (utilproxy.Closeable, error) { return openLocalPort(lp) </del> <ins> func (l *listenPortOpener) OpenLocalPort(lp *utilproxy.LocalPort, isIPv6 bool) (utilproxy.Closeable, error) { return openLocalPort(lp, isIPv6) </ins> } <del> func openLocalPort(lp *utilproxy.LocalPort) (utilproxy.Closeable, error) { </del> <ins> func openLocalPort(lp *utilproxy.LocalPort, isIPv6 bool) (utilproxy.Closeable, error) { </ins> // For ports on node IPs, open the actual port and hold it, even though we // use ipvs to redirect traffic. // This ensures a) that it's safe to use that port and b) that (a) stays", "commid": "kubernetes_pr_87699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21d79d4b86405dc56238b9a9ac0bd543c859fd67cfeabcc17cfe386742e18a8d", "query": "/kind bug What happened: When creating a node port application (in this case the example guestbook) on a host server that is dual stacked and has AAAA and A DNS entries, the node port on the v6 address is open to kube-proxy and hangs. What you expected to happen: The v6 address would refuse the connection and the client would fall back onto the v4 address which would connect correctly. How to reproduce it (as minimally and precisely as possible): kubeadm init with the above, and join in some workers. Then install the guestbook application Obtain the node port with and telnet to one of the servers on that port from a dual stacked client. The client will connect and refuse to respond to 'GET /' telnet directly to the IPv4 address of the server on the port and all works as expected. Anything else we need to know?: kube-proxy is noted as listening on the port. Environment: Kubernetes version (use ): ubuntu kubectl version Client Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:53:20Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:43:26Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Brightbox OS (e.g. from /etc/os-release): Ubuntu 18.04.1 LTS Kernel (e.g. ): Linux srv-jidtj 4.15.0-29-generic -Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm 1.11 Others:\n/sig network\nLooks like kube-proxy in ipvs mode listens on the nodeport ports to ensure they're not in use by something else. It just binds and listens, it doesn't serve requests. It binds on both ipv4 and ipv6 but never expects to receive connections because the iptables/ipvs rules intercept them, but on ipv4 clusters there is nothing stopping ipv6 connections coming in. The comment there does admit that only a bind is necessary to do this, but doing a full listen just made e2e tests easier. /cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen This now causes conformance failure on e2e tests due to the promotion of the Nodeport test in\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill an issue on 1.16 when running in standard IPv4 mode\nAs I understand this thread, I have the same problem. I thought that it is a node configuration or some kubernetes flag that I didn't set but it seems it ain't. I ask already on SO: Environment Kubernetes version (use kubectl version): Client Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:36:53Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-10-02T16:51:36Z\", GoVersion:\"go1.12.10\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: On premise, on virtual machines using hyper-v OS (e.g. from /etc/os-release): NAME=\"Ubuntu\" VERSION=\"18.04.3 LTS (Bionic Beaver)\" Kernel (e.g. uname -a): Linux kubernetes 5.0.0-29-generic # 31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm version: &version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:34:01Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n/lifecycle frozen\n/assign bowei\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nLooking through the comments, this looks like a bug that could have a targeted fix. /remove-triage unresolved /good-first-issue /help-wanted\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : Looking through the comments, this looks like a bug that could have a targeted fix. /good-first-issue /help-wanted </details\nI will attempt to solve this issue.\nany success or progress? If you left this issue I would like to give it a go as a first time contributor. Thanks, Yuval\nI'm still working on this as my first issue, and planning to produce a solution by 20th.\nI wasn't able to tackle the issue and will not continue trying, feel free to take it.\n/assign yuvalsteuer\nStill, open -- anyone actively working on this? I would like to attempt if not. :) /assign rkc007\nOK, again still open, doesn't look like anyone is working on this. I'd like to try it. The fix that occurs to me is simply to only listen to IPv6 addresses if the cluster is IPv6. If the e2e tests fail in this case (from looking at I don't think they will) then maybe they need to be updated. Does that make sense? What I'm not sure about is if we should do nothing with IPv6 ports or bind (to claim the port) but not listen.\n/assign michaelbeaumont", "positive_passages": [{"docid": "doc-en-kubernetes-9019d27716e03c22977dde1edfc4a8d2035e700b82b063043731276ee213e339", "text": "var socket utilproxy.Closeable switch lp.Protocol { case \"tcp\": <del> listener, err := net.Listen(\"tcp\", net.JoinHostPort(lp.IP, strconv.Itoa(lp.Port))) </del> <ins> network := \"tcp4\" if isIPv6 { network = \"tcp6\" } listener, err := net.Listen(network, net.JoinHostPort(lp.IP, strconv.Itoa(lp.Port))) </ins> if err != nil { return nil, err } socket = listener case \"udp\": <del> addr, err := net.ResolveUDPAddr(\"udp\", net.JoinHostPort(lp.IP, strconv.Itoa(lp.Port))) </del> <ins> network := \"udp4\" if isIPv6 { network = \"udp6\" } addr, err := net.ResolveUDPAddr(network, net.JoinHostPort(lp.IP, strconv.Itoa(lp.Port))) </ins> if err != nil { return nil, err } <del> conn, err := net.ListenUDP(\"udp\", addr) </del> <ins> conn, err := net.ListenUDP(network, addr) </ins> if err != nil { return nil, err }", "commid": "kubernetes_pr_87699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21d79d4b86405dc56238b9a9ac0bd543c859fd67cfeabcc17cfe386742e18a8d", "query": "/kind bug What happened: When creating a node port application (in this case the example guestbook) on a host server that is dual stacked and has AAAA and A DNS entries, the node port on the v6 address is open to kube-proxy and hangs. What you expected to happen: The v6 address would refuse the connection and the client would fall back onto the v4 address which would connect correctly. How to reproduce it (as minimally and precisely as possible): kubeadm init with the above, and join in some workers. Then install the guestbook application Obtain the node port with and telnet to one of the servers on that port from a dual stacked client. The client will connect and refuse to respond to 'GET /' telnet directly to the IPv4 address of the server on the port and all works as expected. Anything else we need to know?: kube-proxy is noted as listening on the port. Environment: Kubernetes version (use ): ubuntu kubectl version Client Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:53:20Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:43:26Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Brightbox OS (e.g. from /etc/os-release): Ubuntu 18.04.1 LTS Kernel (e.g. ): Linux srv-jidtj 4.15.0-29-generic -Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm 1.11 Others:\n/sig network\nLooks like kube-proxy in ipvs mode listens on the nodeport ports to ensure they're not in use by something else. It just binds and listens, it doesn't serve requests. It binds on both ipv4 and ipv6 but never expects to receive connections because the iptables/ipvs rules intercept them, but on ipv4 clusters there is nothing stopping ipv6 connections coming in. The comment there does admit that only a bind is necessary to do this, but doing a full listen just made e2e tests easier. /cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen This now causes conformance failure on e2e tests due to the promotion of the Nodeport test in\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill an issue on 1.16 when running in standard IPv4 mode\nAs I understand this thread, I have the same problem. I thought that it is a node configuration or some kubernetes flag that I didn't set but it seems it ain't. I ask already on SO: Environment Kubernetes version (use kubectl version): Client Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:36:53Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-10-02T16:51:36Z\", GoVersion:\"go1.12.10\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: On premise, on virtual machines using hyper-v OS (e.g. from /etc/os-release): NAME=\"Ubuntu\" VERSION=\"18.04.3 LTS (Bionic Beaver)\" Kernel (e.g. uname -a): Linux kubernetes 5.0.0-29-generic # 31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm version: &version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:34:01Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n/lifecycle frozen\n/assign bowei\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nLooking through the comments, this looks like a bug that could have a targeted fix. /remove-triage unresolved /good-first-issue /help-wanted\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : Looking through the comments, this looks like a bug that could have a targeted fix. /good-first-issue /help-wanted </details\nI will attempt to solve this issue.\nany success or progress? If you left this issue I would like to give it a go as a first time contributor. Thanks, Yuval\nI'm still working on this as my first issue, and planning to produce a solution by 20th.\nI wasn't able to tackle the issue and will not continue trying, feel free to take it.\n/assign yuvalsteuer\nStill, open -- anyone actively working on this? I would like to attempt if not. :) /assign rkc007\nOK, again still open, doesn't look like anyone is working on this. I'd like to try it. The fix that occurs to me is simply to only listen to IPv6 addresses if the cluster is IPv6. If the e2e tests fail in this case (from looking at I don't think they will) then maybe they need to be updated. Does that make sense? What I'm not sure about is if we should do nothing with IPv6 ports or bind (to claim the port) but not listen.\n/assign michaelbeaumont", "positive_passages": [{"docid": "doc-en-kubernetes-794d8bef7896ad34888010c053e465009adaac49facee7827081d5514ca09d31", "text": "// OpenLocalPort fakes out the listen() and bind() used by syncProxyRules // to lock a local port. <del> func (f *fakePortOpener) OpenLocalPort(lp *utilproxy.LocalPort) (utilproxy.Closeable, error) { </del> <ins> func (f *fakePortOpener) OpenLocalPort(lp *utilproxy.LocalPort, isIPv6 bool) (utilproxy.Closeable, error) { </ins> f.openPorts = append(f.openPorts, lp) return nil, nil }", "commid": "kubernetes_pr_87699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21d79d4b86405dc56238b9a9ac0bd543c859fd67cfeabcc17cfe386742e18a8d", "query": "/kind bug What happened: When creating a node port application (in this case the example guestbook) on a host server that is dual stacked and has AAAA and A DNS entries, the node port on the v6 address is open to kube-proxy and hangs. What you expected to happen: The v6 address would refuse the connection and the client would fall back onto the v4 address which would connect correctly. How to reproduce it (as minimally and precisely as possible): kubeadm init with the above, and join in some workers. Then install the guestbook application Obtain the node port with and telnet to one of the servers on that port from a dual stacked client. The client will connect and refuse to respond to 'GET /' telnet directly to the IPv4 address of the server on the port and all works as expected. Anything else we need to know?: kube-proxy is noted as listening on the port. Environment: Kubernetes version (use ): ubuntu kubectl version Client Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:53:20Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"11\", GitVersion:\"v1.11.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-07-17T18:43:26Z\", GoVersion:\"go1.10.3\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Brightbox OS (e.g. from /etc/os-release): Ubuntu 18.04.1 LTS Kernel (e.g. ): Linux srv-jidtj 4.15.0-29-generic -Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm 1.11 Others:\n/sig network\nLooks like kube-proxy in ipvs mode listens on the nodeport ports to ensure they're not in use by something else. It just binds and listens, it doesn't serve requests. It binds on both ipv4 and ipv6 but never expects to receive connections because the iptables/ipvs rules intercept them, but on ipv4 clusters there is nothing stopping ipv6 connections coming in. The comment there does admit that only a bind is necessary to do this, but doing a full listen just made e2e tests easier. /cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen This now causes conformance failure on e2e tests due to the promotion of the Nodeport test in\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill an issue on 1.16 when running in standard IPv4 mode\nAs I understand this thread, I have the same problem. I thought that it is a node configuration or some kubernetes flag that I didn't set but it seems it ain't. I ask already on SO: Environment Kubernetes version (use kubectl version): Client Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:36:53Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-10-02T16:51:36Z\", GoVersion:\"go1.12.10\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: On premise, on virtual machines using hyper-v OS (e.g. from /etc/os-release): NAME=\"Ubuntu\" VERSION=\"18.04.3 LTS (Bionic Beaver)\" Kernel (e.g. uname -a): Linux kubernetes 5.0.0-29-generic # 31~18.04.1-Ubuntu SMP Thu Sep 12 18:29:21 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm version: &version.Info{Major:\"1\", Minor:\"16\", GitVersion:\"v1.16.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2019-09-18T14:34:01Z\", GoVersion:\"go1.12.9\", Compiler:\"gc\", Platform:\"linux/amd64\"}\n/lifecycle frozen\n/assign bowei\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nLooking through the comments, this looks like a bug that could have a targeted fix. /remove-triage unresolved /good-first-issue /help-wanted\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : Looking through the comments, this looks like a bug that could have a targeted fix. /good-first-issue /help-wanted </details\nI will attempt to solve this issue.\nany success or progress? If you left this issue I would like to give it a go as a first time contributor. Thanks, Yuval\nI'm still working on this as my first issue, and planning to produce a solution by 20th.\nI wasn't able to tackle the issue and will not continue trying, feel free to take it.\n/assign yuvalsteuer\nStill, open -- anyone actively working on this? I would like to attempt if not. :) /assign rkc007\nOK, again still open, doesn't look like anyone is working on this. I'd like to try it. The fix that occurs to me is simply to only listen to IPv6 addresses if the cluster is IPv6. If the e2e tests fail in this case (from looking at I don't think they will) then maybe they need to be updated. Does that make sense? What I'm not sure about is if we should do nothing with IPv6 ports or bind (to claim the port) but not listen.\n/assign michaelbeaumont", "positive_passages": [{"docid": "doc-en-kubernetes-0adc53fbfa957689f36015921fe76dd015c59f7bc59540450261aad39d17f79d", "text": "// PortOpener is an interface around port opening/closing. // Abstracted out for testing. type PortOpener interface { <del> OpenLocalPort(lp *LocalPort) (Closeable, error) </del> <ins> OpenLocalPort(lp *LocalPort, isIPv6 bool) (Closeable, error) </ins> } // RevertPorts is closing ports in replacementPortsMap but not in originalPortsMap. In other words, it only", "commid": "kubernetes_pr_87699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-57b5e16394867179672bc71a3976bca45150df747198e4d516bcbb5c497411bc", "query": "/kind bug Hello, actually this is a bug about not about k8s. I use to observe request headers and found if the request have multiple same headers echoserver will give a wrong result: result: Expected result:\n/sig testing\nany chance you know some lua?\nI never used lua before, but I'm willing to try to fix this issue.", "positive_passages": [{"docid": "doc-en-kubernetes-ad52b923a9b0acee898a8ea9d892a5b66b2193f13f73720874e84c3f2679acb2", "text": "<del> 2.1 </del> <ins> 2.2 </ins>", "commid": "kubernetes_pr_67578"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-57b5e16394867179672bc71a3976bca45150df747198e4d516bcbb5c497411bc", "query": "/kind bug Hello, actually this is a bug about not about k8s. I use to observe request headers and found if the request have multiple same headers echoserver will give a wrong result: result: Expected result:\n/sig testing\nany chance you know some lua?\nI never used lua before, but I'm willing to try to fix this issue.", "positive_passages": [{"docid": "doc-en-kubernetes-6986f659db39717e571658b429dffecc8768bceca9a64ed111e7704b969c96a8", "text": "Request Headers: {% for i, key in ipairs(keys) do %} <del> {{key}}={{headers[key]}} </del> <ins> {% local val = headers[key] %} {% if type(val) == \"table\" then %} {% for i = 1,#val do %} {{key}}={{val[i]}} {% end %} {% else %} {{key}}={{val}} {% end %} </ins> {% end %} Request Body:", "commid": "kubernetes_pr_67578"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2d583728f7b7db25a152cbc0daa919f3cf4a41b0a2c72387b0cf92c2183ad4d1", "query": "Is this a BUG REPORT or FEATURE REQUEST?: What happened: Azure will not update the DNS label of the public IP, when update the service only changing the annotation of the DNS label from empty. annotations: -annotations: \"to-update\" What you expected to happen: It should update the dns label of the assigned public IP How to reproduce it (as minimally and precisely as possible): It probably caused when applying function 'getPublicIPAddress' in This function returns a bool 'existsPip' to judge the public ip existence. When only the annotations changed, the existsPip still returns true. Then, the reference in line 553 and line 446 step into this bug. pip, existsPip, err := az.getPublicIPAddress(pipResourceGroup, pipName) if err != nil { return false, err } if !existsPip { return true, nil } Firstly, in line 554, it will make function 'isFrontendIPChanged' return false, and then will not run 'ensurePublicIP' in line 691. Secondly, even if 'ensurePublicIP' in line 691 runs, it will detect the public ip exists and make no update to the DNS label in line 446_. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: Azure\n/sig azure\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- what's the status on this?\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/open I will take a look at this\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill not fixed. /reopen /kind bug /priority important-soon /milestone v1.16\nReopened this issue. <detailsIn response to : Still not fixed. /kind bug /priority important-soon /milestone v1.16 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig cloud-provider\ni'm working on it.\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-a4666785878f10db3fb3110b4c4b5e4f2a8e72991d9e642aa5a50e3d616dadf3", "text": "if err != nil { return nil, err } <del> if existsPip { return &pip, nil } </del> serviceName := getServiceName(service) <del> if shouldPIPExisted { return nil, fmt.Errorf(\"PublicIP from annotation azure-pip-name=%s for service %s doesn't exist\", pipName, serviceName) } pip.Name = to.StringPtr(pipName) pip.Location = to.StringPtr(az.Location) pip.PublicIPAddressPropertiesFormat = &network.PublicIPAddressPropertiesFormat{ PublicIPAllocationMethod: network.Static, </del> <ins> if existsPip { // return if pip exist and dns label is the same if getDomainNameLabel(&pip) == domainNameLabel { return &pip, nil } klog.V(2).Infof(\"ensurePublicIPExists for service(%s): pip(%s) - updating\", serviceName, *pip.Name) if pip.PublicIPAddressPropertiesFormat == nil { pip.PublicIPAddressPropertiesFormat = &network.PublicIPAddressPropertiesFormat{ PublicIPAllocationMethod: network.Static, } } } else { if shouldPIPExisted { return nil, fmt.Errorf(\"PublicIP from annotation azure-pip-name=%s for service %s doesn't exist\", pipName, serviceName) } pip.Name = to.StringPtr(pipName) pip.Location = to.StringPtr(az.Location) pip.PublicIPAddressPropertiesFormat = &network.PublicIPAddressPropertiesFormat{ PublicIPAllocationMethod: network.Static, } pip.Tags = map[string]*string{ serviceTagKey:  &serviceName, clusterNameKey: &clusterName, } if az.useStandardLoadBalancer() { pip.Sku = &network.PublicIPAddressSku{ Name: network.PublicIPAddressSkuNameStandard, } } klog.V(2).Infof(\"ensurePublicIPExists for service(%s): pip(%s) - creating\", serviceName, *pip.Name) </ins> } <del> if len(domainNameLabel) > 0 { </del> <ins> if len(domainNameLabel) == 0 { pip.PublicIPAddressPropertiesFormat.DNSSettings = nil } else { </ins> pip.PublicIPAddressPropertiesFormat.DNSSettings = &network.PublicIPAddressDNSSettings{ DomainNameLabel: &domainNameLabel, } } <del> pip.Tags = map[string]*string{ serviceTagKey:  &serviceName, clusterNameKey: &clusterName, } if az.useStandardLoadBalancer() { pip.Sku = &network.PublicIPAddressSku{ Name: network.PublicIPAddressSkuNameStandard, } } klog.V(2).Infof(\"ensurePublicIPExists for service(%s): pip(%s) - creating\", serviceName, *pip.Name) </del> klog.V(10).Infof(\"CreateOrUpdatePIP(%s, %q): start\", pipResourceGroup, *pip.Name) err = az.CreateOrUpdatePIP(service, pipResourceGroup, pip) if err != nil { <del> klog.V(2).Infof(\"ensure(%s) abort backoff: pip(%s) - creating\", serviceName, *pip.Name) </del> <ins> klog.V(2).Infof(\"ensure(%s) abort backoff: pip(%s)\", serviceName, *pip.Name) </ins> return nil, err } klog.V(10).Infof(\"CreateOrUpdatePIP(%s, %q): end\", pipResourceGroup, *pip.Name)", "commid": "kubernetes_pr_81262"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2d583728f7b7db25a152cbc0daa919f3cf4a41b0a2c72387b0cf92c2183ad4d1", "query": "Is this a BUG REPORT or FEATURE REQUEST?: What happened: Azure will not update the DNS label of the public IP, when update the service only changing the annotation of the DNS label from empty. annotations: -annotations: \"to-update\" What you expected to happen: It should update the dns label of the assigned public IP How to reproduce it (as minimally and precisely as possible): It probably caused when applying function 'getPublicIPAddress' in This function returns a bool 'existsPip' to judge the public ip existence. When only the annotations changed, the existsPip still returns true. Then, the reference in line 553 and line 446 step into this bug. pip, existsPip, err := az.getPublicIPAddress(pipResourceGroup, pipName) if err != nil { return false, err } if !existsPip { return true, nil } Firstly, in line 554, it will make function 'isFrontendIPChanged' return false, and then will not run 'ensurePublicIP' in line 691. Secondly, even if 'ensurePublicIP' in line 691 runs, it will detect the public ip exists and make no update to the DNS label in line 446_. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: Azure\n/sig azure\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- what's the status on this?\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/open I will take a look at this\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill not fixed. /reopen /kind bug /priority important-soon /milestone v1.16\nReopened this issue. <detailsIn response to : Still not fixed. /kind bug /priority important-soon /milestone v1.16 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig cloud-provider\ni'm working on it.\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-15b191e9da16a073af9cb1d2535afbdaccde608275f3eced7ad5e5f6f4437f92", "text": "return &pip, nil } <ins> func getDomainNameLabel(pip *network.PublicIPAddress) string { if pip == nil || pip.PublicIPAddressPropertiesFormat == nil || pip.PublicIPAddressPropertiesFormat.DNSSettings == nil { return \"\" } return to.String(pip.PublicIPAddressPropertiesFormat.DNSSettings.DomainNameLabel) } </ins> func getIdleTimeout(s *v1.Service) (*int32, error) { const ( min = 4", "commid": "kubernetes_pr_81262"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2d583728f7b7db25a152cbc0daa919f3cf4a41b0a2c72387b0cf92c2183ad4d1", "query": "Is this a BUG REPORT or FEATURE REQUEST?: What happened: Azure will not update the DNS label of the public IP, when update the service only changing the annotation of the DNS label from empty. annotations: -annotations: \"to-update\" What you expected to happen: It should update the dns label of the assigned public IP How to reproduce it (as minimally and precisely as possible): It probably caused when applying function 'getPublicIPAddress' in This function returns a bool 'existsPip' to judge the public ip existence. When only the annotations changed, the existsPip still returns true. Then, the reference in line 553 and line 446 step into this bug. pip, existsPip, err := az.getPublicIPAddress(pipResourceGroup, pipName) if err != nil { return false, err } if !existsPip { return true, nil } Firstly, in line 554, it will make function 'isFrontendIPChanged' return false, and then will not run 'ensurePublicIP' in line 691. Secondly, even if 'ensurePublicIP' in line 691 runs, it will detect the public ip exists and make no update to the DNS label in line 446_. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: Azure\n/sig azure\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- what's the status on this?\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/open I will take a look at this\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill not fixed. /reopen /kind bug /priority important-soon /milestone v1.16\nReopened this issue. <detailsIn response to : Still not fixed. /kind bug /priority important-soon /milestone v1.16 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig cloud-provider\ni'm working on it.\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-49444ccfa8ddd1192a5f11e96e4311d967b74ccb6e22ecae0b7e2c6973fd25e4", "text": "existingPIPs  []network.PublicIPAddress expectedPIP   *network.PublicIPAddress expectedID    string <ins> expectedDNS   string </ins> expectedError bool }{ {", "commid": "kubernetes_pr_81262"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2d583728f7b7db25a152cbc0daa919f3cf4a41b0a2c72387b0cf92c2183ad4d1", "query": "Is this a BUG REPORT or FEATURE REQUEST?: What happened: Azure will not update the DNS label of the public IP, when update the service only changing the annotation of the DNS label from empty. annotations: -annotations: \"to-update\" What you expected to happen: It should update the dns label of the assigned public IP How to reproduce it (as minimally and precisely as possible): It probably caused when applying function 'getPublicIPAddress' in This function returns a bool 'existsPip' to judge the public ip existence. When only the annotations changed, the existsPip still returns true. Then, the reference in line 553 and line 446 step into this bug. pip, existsPip, err := az.getPublicIPAddress(pipResourceGroup, pipName) if err != nil { return false, err } if !existsPip { return true, nil } Firstly, in line 554, it will make function 'isFrontendIPChanged' return false, and then will not run 'ensurePublicIP' in line 691. Secondly, even if 'ensurePublicIP' in line 691 runs, it will detect the public ip exists and make no update to the DNS label in line 446_. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: Azure\n/sig azure\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- what's the status on this?\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/open I will take a look at this\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill not fixed. /reopen /kind bug /priority important-soon /milestone v1.16\nReopened this issue. <detailsIn response to : Still not fixed. /kind bug /priority important-soon /milestone v1.16 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig cloud-provider\ni'm working on it.\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-8b1ec78870345e77b86b1e9a4d599f7f9e0f0f4a0d9b0e76372c5830e161d057", "text": "expectedID: \"/subscriptions/subscription/resourceGroups/rg/providers/\" + \"Microsoft.Network/publicIPAddresses/pip1\", }, <ins> { desc: \"ensurePublicIPExists shall update existed PIP's dns label\", existingPIPs: []network.PublicIPAddress{{ Name: to.StringPtr(\"pip1\"), PublicIPAddressPropertiesFormat: &network.PublicIPAddressPropertiesFormat{ DNSSettings: &network.PublicIPAddressDNSSettings{ DomainNameLabel: to.StringPtr(\"previousdns\"), }, }, }}, expectedPIP: &network.PublicIPAddress{ Name: to.StringPtr(\"pip1\"), ID: to.StringPtr(\"/subscriptions/subscription/resourceGroups/rg\" + \"/providers/Microsoft.Network/publicIPAddresses/pip1\"), PublicIPAddressPropertiesFormat: &network.PublicIPAddressPropertiesFormat{ DNSSettings: &network.PublicIPAddressDNSSettings{ DomainNameLabel: to.StringPtr(\"newdns\"), }, }, }, expectedDNS: \"newdns\", }, </ins> } for i, test := range testCases {", "commid": "kubernetes_pr_81262"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2d583728f7b7db25a152cbc0daa919f3cf4a41b0a2c72387b0cf92c2183ad4d1", "query": "Is this a BUG REPORT or FEATURE REQUEST?: What happened: Azure will not update the DNS label of the public IP, when update the service only changing the annotation of the DNS label from empty. annotations: -annotations: \"to-update\" What you expected to happen: It should update the dns label of the assigned public IP How to reproduce it (as minimally and precisely as possible): It probably caused when applying function 'getPublicIPAddress' in This function returns a bool 'existsPip' to judge the public ip existence. When only the annotations changed, the existsPip still returns true. Then, the reference in line 553 and line 446 step into this bug. pip, existsPip, err := az.getPublicIPAddress(pipResourceGroup, pipName) if err != nil { return false, err } if !existsPip { return true, nil } Firstly, in line 554, it will make function 'isFrontendIPChanged' return false, and then will not run 'ensurePublicIP' in line 691. Secondly, even if 'ensurePublicIP' in line 691 runs, it will detect the public ip exists and make no update to the DNS label in line 446_. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: Azure\n/sig azure\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- what's the status on this?\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/open I will take a look at this\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nStill not fixed. /reopen /kind bug /priority important-soon /milestone v1.16\nReopened this issue. <detailsIn response to : Still not fixed. /kind bug /priority important-soon /milestone v1.16 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig cloud-provider\ni'm working on it.\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-60356dcfe85c14d8fc32f3bf7b5abf78c94bf0447a7054063e6939a3b2ca6721", "text": "t.Fatalf(\"TestCase[%d] meets unexpected error: %v\", i, err) } } <del> pip, err := az.ensurePublicIPExists(&service, \"pip1\", \"\", \"\", false) </del> <ins> pip, err := az.ensurePublicIPExists(&service, \"pip1\", test.expectedDNS, \"\", false) </ins> if test.expectedID != \"\" { assert.Equal(t, test.expectedID, to.String(pip.ID), \"TestCase[%d]: %s\", i, test.desc) } else {", "commid": "kubernetes_pr_81262"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a38798d209f0702d464d1d4ca1e4d0e5108c803367931f11e6980bbace35c0ee", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: PR() fixed pull image error from a cross-subscription azure container registry by service principal, while for MSI, this issue is not fixed. Need to find a way how to fix this issue for MSI, related code is here: Here the difficulty is could not list all ACR since it's based on one subscriptionID: So if we could not get in a different subscription, how could we set the . What you expected to happen: How to reproduce it (as minimally and precisely as possible): error msg would be like following when pull a repository from an ACR in another subscription: Anything else we need to know?: Environment: Kubernetes version (use ): v.9 - v1.12 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig azure /assign\nBy further investigation, I think we should implement LazyProvider for azure acrProvider: Related code:\nUpdate: It's hard to fix this since in the beginning we cannot list ACR in another subscription, will always list acr under current subscription, and without target loginServer address of ACR, we cannot get : And in func, we cannot get target repo, it's not passed on\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- is this still an issue? If not, let's it out.\nit's still an issue, and currently it should be low priority, let's keep it\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-lifecycle rotten /reopen\nReopened this issue. <detailsIn response to : /remove-lifecycle rotten /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-1aebe7aa63a887ba25fb7e0c20be3cb3a249b2e40c794a580d0825b79ad0db1d", "text": "\"io\" \"io/ioutil\" \"os\" <ins> \"regexp\" </ins> \"time\" \"github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2017-10-01/containerregistry\"", "commid": "kubernetes_pr_77245"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a38798d209f0702d464d1d4ca1e4d0e5108c803367931f11e6980bbace35c0ee", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: PR() fixed pull image error from a cross-subscription azure container registry by service principal, while for MSI, this issue is not fixed. Need to find a way how to fix this issue for MSI, related code is here: Here the difficulty is could not list all ACR since it's based on one subscriptionID: So if we could not get in a different subscription, how could we set the . What you expected to happen: How to reproduce it (as minimally and precisely as possible): error msg would be like following when pull a repository from an ACR in another subscription: Anything else we need to know?: Environment: Kubernetes version (use ): v.9 - v1.12 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig azure /assign\nBy further investigation, I think we should implement LazyProvider for azure acrProvider: Related code:\nUpdate: It's hard to fix this since in the beginning we cannot list ACR in another subscription, will always list acr under current subscription, and without target loginServer address of ACR, we cannot get : And in func, we cannot get target repo, it's not passed on\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- is this still an issue? If not, let's it out.\nit's still an issue, and currently it should be low priority, let's keep it\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-lifecycle rotten /reopen\nReopened this issue. <detailsIn response to : /remove-lifecycle rotten /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-e3ff496c688cc87a5e2fa64aa47becde4a842a37251429104b5a5fe51fe39224", "text": "maxReadLength      = 10 * 1 << 20 // 10MB ) <del> var containerRegistryUrls = []string{\"*.azurecr.io\", \"*.azurecr.cn\", \"*.azurecr.de\", \"*.azurecr.us\"} </del> <ins> var ( containerRegistryUrls = []string{\"*.azurecr.io\", \"*.azurecr.cn\", \"*.azurecr.de\", \"*.azurecr.us\"} acrRE                 = regexp.MustCompile(`.*.azurecr.io|.*.azurecr.cn|.*.azurecr.de|.*.azurecr.us`) ) </ins> // init registers the various means by which credentials may // be resolved on Azure.", "commid": "kubernetes_pr_77245"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a38798d209f0702d464d1d4ca1e4d0e5108c803367931f11e6980bbace35c0ee", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: PR() fixed pull image error from a cross-subscription azure container registry by service principal, while for MSI, this issue is not fixed. Need to find a way how to fix this issue for MSI, related code is here: Here the difficulty is could not list all ACR since it's based on one subscriptionID: So if we could not get in a different subscription, how could we set the . What you expected to happen: How to reproduce it (as minimally and precisely as possible): error msg would be like following when pull a repository from an ACR in another subscription: Anything else we need to know?: Environment: Kubernetes version (use ): v.9 - v1.12 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig azure /assign\nBy further investigation, I think we should implement LazyProvider for azure acrProvider: Related code:\nUpdate: It's hard to fix this since in the beginning we cannot list ACR in another subscription, will always list acr under current subscription, and without target loginServer address of ACR, we cannot get : And in func, we cannot get target repo, it's not passed on\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- is this still an issue? If not, let's it out.\nit's still an issue, and currently it should be low priority, let's keep it\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-lifecycle rotten /reopen\nReopened this issue. <detailsIn response to : /remove-lifecycle rotten /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-f2e8616ab2f7c5b9f223dd75e830fb0206885ae6aab407957a5b1ed1053e9ff3", "text": "} func (a *acrProvider) Provide(image string) credentialprovider.DockerConfig { <ins> klog.V(4).Infof(\"try to provide secret for image %s\", image) </ins> cfg := credentialprovider.DockerConfig{} <del> ctx, cancel := getContextWithCancel() defer cancel() </del> if a.config.UseManagedIdentityExtension { <del> klog.V(4).Infof(\"listing registries\") result, err := a.registryClient.List(ctx) if err != nil { klog.Errorf(\"Failed to list registries: %v\", err) return cfg } for ix := range result { loginServer := getLoginServer(result[ix]) klog.V(2).Infof(\"loginServer: %s\", loginServer) cred, err := getACRDockerEntryFromARMToken(a, loginServer) if err != nil { continue </del> <ins> if loginServer := parseACRLoginServerFromImage(image); loginServer == \"\" { klog.V(4).Infof(\"image(%s) is not from ACR, skip MSI authentication\", image) } else { if cred, err := getACRDockerEntryFromARMToken(a, loginServer); err == nil { cfg[loginServer] = *cred </ins> } <del> cfg[loginServer] = *cred </del> } } else { // Add our entry for each of the supported container registry URLs", "commid": "kubernetes_pr_77245"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a38798d209f0702d464d1d4ca1e4d0e5108c803367931f11e6980bbace35c0ee", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: PR() fixed pull image error from a cross-subscription azure container registry by service principal, while for MSI, this issue is not fixed. Need to find a way how to fix this issue for MSI, related code is here: Here the difficulty is could not list all ACR since it's based on one subscriptionID: So if we could not get in a different subscription, how could we set the . What you expected to happen: How to reproduce it (as minimally and precisely as possible): error msg would be like following when pull a repository from an ACR in another subscription: Anything else we need to know?: Environment: Kubernetes version (use ): v.9 - v1.12 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig azure /assign\nBy further investigation, I think we should implement LazyProvider for azure acrProvider: Related code:\nUpdate: It's hard to fix this since in the beginning we cannot list ACR in another subscription, will always list acr under current subscription, and without target loginServer address of ACR, we cannot get : And in func, we cannot get target repo, it's not passed on\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- is this still an issue? If not, let's it out.\nit's still an issue, and currently it should be low priority, let's keep it\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-lifecycle rotten /reopen\nReopened this issue. <detailsIn response to : /remove-lifecycle rotten /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-e17fb485afeb23fb2d70dac684306f2521e565dc5131cc19717ce10ac757d53e", "text": "} func getACRDockerEntryFromARMToken(a *acrProvider, loginServer string) (*credentialprovider.DockerConfigEntry, error) { <ins> // Run EnsureFresh to make sure the token is valid and does not expire if err := a.servicePrincipalToken.EnsureFresh(); err != nil { klog.Errorf(\"Failed to ensure fresh service principal token: %v\", err) return nil, err } </ins> armAccessToken := a.servicePrincipalToken.OAuthToken() klog.V(4).Infof(\"discovering auth redirects for: %s\", loginServer)", "commid": "kubernetes_pr_77245"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a38798d209f0702d464d1d4ca1e4d0e5108c803367931f11e6980bbace35c0ee", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: PR() fixed pull image error from a cross-subscription azure container registry by service principal, while for MSI, this issue is not fixed. Need to find a way how to fix this issue for MSI, related code is here: Here the difficulty is could not list all ACR since it's based on one subscriptionID: So if we could not get in a different subscription, how could we set the . What you expected to happen: How to reproduce it (as minimally and precisely as possible): error msg would be like following when pull a repository from an ACR in another subscription: Anything else we need to know?: Environment: Kubernetes version (use ): v.9 - v1.12 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig azure /assign\nBy further investigation, I think we should implement LazyProvider for azure acrProvider: Related code:\nUpdate: It's hard to fix this since in the beginning we cannot list ACR in another subscription, will always list acr under current subscription, and without target loginServer address of ACR, we cannot get : And in func, we cannot get target repo, it's not passed on\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- is this still an issue? If not, let's it out.\nit's still an issue, and currently it should be low priority, let's keep it\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-lifecycle rotten /reopen\nReopened this issue. <detailsIn response to : /remove-lifecycle rotten /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-5ab69eb35adc0dadc12bfe20e20f0531b8a55ecf11d4ea97b0d72cfe6560f70f", "text": "}, nil } <ins> // parseACRLoginServerFromImage takes image as parameter and returns login server of it. // Parameter `image` is expected in following format: foo.azurecr.io/bar/imageName:version // If the provided image is not an acr image, this function will return an empty string. func parseACRLoginServerFromImage(image string) string { match := acrRE.FindAllString(image, -1) if len(match) == 1 { return match[0] } return \"\" } </ins> func (a *acrProvider) LazyProvide(image string) *credentialprovider.DockerConfigEntry { return nil }", "commid": "kubernetes_pr_77245"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a38798d209f0702d464d1d4ca1e4d0e5108c803367931f11e6980bbace35c0ee", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: PR() fixed pull image error from a cross-subscription azure container registry by service principal, while for MSI, this issue is not fixed. Need to find a way how to fix this issue for MSI, related code is here: Here the difficulty is could not list all ACR since it's based on one subscriptionID: So if we could not get in a different subscription, how could we set the . What you expected to happen: How to reproduce it (as minimally and precisely as possible): error msg would be like following when pull a repository from an ACR in another subscription: Anything else we need to know?: Environment: Kubernetes version (use ): v.9 - v1.12 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig azure /assign\nBy further investigation, I think we should implement LazyProvider for azure acrProvider: Related code:\nUpdate: It's hard to fix this since in the beginning we cannot list ACR in another subscription, will always list acr under current subscription, and without target loginServer address of ACR, we cannot get : And in func, we cannot get target repo, it's not passed on\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n-- is this still an issue? If not, let's it out.\nit's still an issue, and currently it should be low priority, let's keep it\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-lifecycle rotten /reopen\nReopened this issue. <detailsIn response to : /remove-lifecycle rotten /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-50969f894a1a0c27750ecf804f108ac9ab9eddf419335dd41f4002ad1f0b4f10", "text": "} } } <ins> func TestParseACRLoginServerFromImage(t *testing.T) { tests := []struct { image    string expected string }{ { image:    \"invalidImage\", expected: \"\", }, { image:    \"docker.io/library/busybox:latest\", expected: \"\", }, { image:    \"foo.azurecr.io/bar/image:version\", expected: \"foo.azurecr.io\", }, { image:    \"foo.azurecr.cn/bar/image:version\", expected: \"foo.azurecr.cn\", }, { image:    \"foo.azurecr.de/bar/image:version\", expected: \"foo.azurecr.de\", }, { image:    \"foo.azurecr.us/bar/image:version\", expected: \"foo.azurecr.us\", }, } for _, test := range tests { if loginServer := parseACRLoginServerFromImage(test.image); loginServer != test.expected { t.Errorf(\"function parseACRLoginServerFromImage returns \"%s\" for image %s, expected \"%s\"\", loginServer, test.image, test.expected) } } } </ins>", "commid": "kubernetes_pr_77245"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-ecc8841359217335701171eb35a235eceacf5e7e7d2e828e9a16269f873838b0", "text": "\"github.com/golang/glog\" \"github.com/xanzy/go-cloudstack/cloudstack\" \"k8s.io/api/core/v1\" <ins> cloudprovider \"k8s.io/cloud-provider\" </ins> ) type loadBalancer struct {", "commid": "kubernetes_pr_68350"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-e542e0f6543131f40640ce9755f32ef3be06c82fcb70fb02bb7fbf3c30779aae", "text": "// GetLoadBalancerName retrieves the name of the LoadBalancer. func (cs *CSCloud) GetLoadBalancerName(ctx context.Context, clusterName string, service *v1.Service) string { <del> return cs.GetLoadBalancerName(ctx, clusterName, service) </del> <ins> return cloudprovider.DefaultLoadBalancerName(service) </ins> } // getLoadBalancer retrieves the IP address and ID and all the existing rules it can find.", "commid": "kubernetes_pr_68350"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-e2e836054ec97697b1f7bae68182a579b48add44fe6dd5ff896a2efdcdc99382", "text": "\"//pkg/api/legacyscheme:go_default_library\", \"//pkg/apis/core:go_default_library\", \"//pkg/capabilities:go_default_library\", <del> \"//pkg/client/chaosclient:go_default_library\", </del> \"//pkg/cloudprovider:go_default_library\", \"//pkg/cloudprovider/providers:go_default_library\", \"//pkg/credentialprovider:go_default_library\",", "commid": "kubernetes_pr_68409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-3c49035bc7cc34be769eb78be0c7bc0146075b352b717ca4f2f2105bad903823", "text": "\"k8s.io/kubernetes/pkg/api/legacyscheme\" api \"k8s.io/kubernetes/pkg/apis/core\" \"k8s.io/kubernetes/pkg/capabilities\" <del> \"k8s.io/kubernetes/pkg/client/chaosclient\" </del> \"k8s.io/kubernetes/pkg/cloudprovider\" \"k8s.io/kubernetes/pkg/credentialprovider\" \"k8s.io/kubernetes/pkg/features\"", "commid": "kubernetes_pr_68409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-0e87698f6433d77fe28a15dc0ba5b9130a6225e745d31228a0491cac243f53ec", "text": "clientConfig.QPS = float32(s.KubeAPIQPS) clientConfig.Burst = int(s.KubeAPIBurst) <del> addChaosToClientConfig(s, clientConfig) </del> return clientConfig, nil } <del> // addChaosToClientConfig injects random errors into client connections if configured. func addChaosToClientConfig(s *options.KubeletServer, config *restclient.Config) { if s.ChaosChance != 0.0 { config.WrapTransport = func(rt http.RoundTripper) http.RoundTripper { seed := chaosclient.NewSeed(1) // TODO: introduce a standard chaos package with more tunables - this is just a proof of concept // TODO: introduce random latency and stalls return chaosclient.NewChaosRoundTripper(rt, chaosclient.LogChaos, seed.P(s.ChaosChance, chaosclient.ErrSimulatedConnectionResetByPeer)) } } } </del> // RunKubelet is responsible for setting up and running a kubelet.  It is used in three different applications: //   1 Integration tests //   2 Kubelet binary", "commid": "kubernetes_pr_68409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-707d907c31ab6ca84d382ec1f2cac534acfb0c11fe22ac7b0e444f7ac4dbb6dd", "text": "\"//pkg/auth/authorizer/abac:all-srcs\", \"//pkg/auth/nodeidentifier:all-srcs\", \"//pkg/capabilities:all-srcs\", <del> \"//pkg/client/chaosclient:all-srcs\", </del> \"//pkg/client/clientset_generated/internalclientset:all-srcs\", \"//pkg/client/conditions:all-srcs\", \"//pkg/client/informers/informers_generated/internalversion:all-srcs\",", "commid": "kubernetes_pr_68409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-dc761b30ce2de0daa9efe06c3764d41840acba14bfc07a5a5cfac02316b8733a", "text": "<del> package(default_visibility = [\"//visibility:public\"]) load( \"@io_bazel_rules_go//go:def.bzl\", \"go_library\", \"go_test\", ) go_library( name = \"go_default_library\", srcs = [\"chaosclient.go\"], importpath = \"k8s.io/kubernetes/pkg/client/chaosclient\", deps = [\"//staging/src/k8s.io/apimachinery/pkg/util/net:go_default_library\"], ) go_test( name = \"go_default_test\", srcs = [\"chaosclient_test.go\"], embed = [\":go_default_library\"], ) filegroup( name = \"package-srcs\", srcs = glob([\"**\"]), tags = [\"automanaged\"], visibility = [\"//visibility:private\"], ) filegroup( name = \"all-srcs\", srcs = [\":package-srcs\"], tags = [\"automanaged\"], ) </del>", "commid": "kubernetes_pr_68409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-b6fa9889c278e856af95f30786654e6dd79f0a603cef0fd3a0db10e4b1d8ef04", "text": "<del> reviewers: - smarterclayton - liggitt - davidopp - eparis - resouer </del>", "commid": "kubernetes_pr_68409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-c39fbc8d5f585bdd97fd3a1acf48901e4c5b2414b1df1aebef8dce9c5f55c6f3", "text": "<del> /* Copyright 2015 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ // Package chaosclient makes it easy to simulate network latency, misbehaving // servers, and random errors from servers. It is intended to stress test components // under failure conditions and expose weaknesses in the error handling logic // of the codebase. package chaosclient import ( \"errors\" \"fmt\" \"log\" \"math/rand\" \"net/http\" \"reflect\" \"runtime\" \"k8s.io/apimachinery/pkg/util/net\" ) // chaosrt provides the ability to perform simulations of HTTP client failures // under the Golang http.Transport interface. type chaosrt struct { rt     http.RoundTripper notify ChaosNotifier c      []Chaos } // Chaos intercepts requests to a remote HTTP endpoint and can inject arbitrary // failures. type Chaos interface { // Intercept should return true if the normal flow should be skipped, and the // return response and error used instead. Modifications to the request will // be ignored, but may be used to make decisions about types of failures. Intercept(req *http.Request) (bool, *http.Response, error) } // ChaosNotifier notifies another component that the ChaosRoundTripper has simulated // a failure. type ChaosNotifier interface { // OnChaos is invoked when a chaotic outcome was triggered. fn is the // source of Chaos and req was the outgoing request OnChaos(req *http.Request, c Chaos) } // ChaosFunc takes an http.Request and decides whether to alter the response. It // returns true if it wishes to mutate the response, with a http.Response or // error. type ChaosFunc func(req *http.Request) (bool, *http.Response, error) // Intercept calls the nested method `Intercept` func (fn ChaosFunc) Intercept(req *http.Request) (bool, *http.Response, error) { return fn.Intercept(req) } func (fn ChaosFunc) String() string { return runtime.FuncForPC(reflect.ValueOf(fn).Pointer()).Name() } // NewChaosRoundTripper creates an http.RoundTripper that will intercept requests // based on the provided Chaos functions. The notifier is invoked when a Chaos // Intercept is fired. func NewChaosRoundTripper(rt http.RoundTripper, notify ChaosNotifier, c ...Chaos) http.RoundTripper { return &chaosrt{rt, notify, c} } // RoundTrip gives each ChaosFunc an opportunity to intercept the request. The first // interceptor wins. func (rt *chaosrt) RoundTrip(req *http.Request) (*http.Response, error) { for _, c := range rt.c { if intercept, resp, err := c.Intercept(req); intercept { rt.notify.OnChaos(req, c) return resp, err } } return rt.rt.RoundTrip(req) } var _ = net.RoundTripperWrapper(&chaosrt{}) func (rt *chaosrt) WrappedRoundTripper() http.RoundTripper { return rt.rt } // Seed represents a consistent stream of chaos. type Seed struct { *rand.Rand } // NewSeed creates an object that assists in generating random chaotic events // based on a deterministic seed. func NewSeed(seed int64) Seed { return Seed{rand.New(rand.NewSource(seed))} } type pIntercept struct { Chaos s Seed p float64 } // P returns a ChaosFunc that fires with a probability of p (p between 0.0 // and 1.0 with 0.0 meaning never and 1.0 meaning always). func (s Seed) P(p float64, c Chaos) Chaos { return pIntercept{c, s, p} } // Intercept intercepts requests with the provided probability p. func (c pIntercept) Intercept(req *http.Request) (bool, *http.Response, error) { if c.s.Float64() < c.p { return c.Chaos.Intercept(req) } return false, nil, nil } func (c pIntercept) String() string { return fmt.Sprintf(\"P{%f %s}\", c.p, c.Chaos) } // ErrSimulatedConnectionResetByPeer emulates the golang net error when a connection // is reset by a peer. // TODO: make this more accurate // TODO: add other error types // TODO: add a helper for returning multiple errors randomly. var ErrSimulatedConnectionResetByPeer = Error{errors.New(\"connection reset by peer\")} // Error returns the nested error when C() is invoked. type Error struct { error } // Intercept returns the nested error func (e Error) Intercept(_ *http.Request) (bool, *http.Response, error) { return true, nil, e.error } // LogChaos is the default ChaosNotifier and writes a message to the Golang log. var LogChaos = ChaosNotifier(logChaos{}) type logChaos struct{} func (logChaos) OnChaos(req *http.Request, c Chaos) { log.Printf(\"Triggered chaotic behavior for %s %s: %v\", req.Method, req.URL.String(), c) } </del>", "commid": "kubernetes_pr_68409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-a4c16b5469fd17cb8ef530ab482c31acc2b20298d99bfbe5ab7d6d9286c6c1c3", "text": "<del> /* Copyright 2015 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package chaosclient import ( \"net/http\" \"net/http/httptest\" \"net/url\" \"testing\" ) type TestLogChaos struct { *testing.T } func (t TestLogChaos) OnChaos(req *http.Request, c Chaos) { t.Logf(\"CHAOS: chaotic behavior for %s %s: %v\", req.Method, req.URL.String(), c) } func unwrapURLError(err error) error { if urlErr, ok := err.(*url.Error); ok && urlErr != nil { return urlErr.Err } return err } func TestChaos(t *testing.T) { server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { w.WriteHeader(http.StatusOK) })) defer server.Close() client := http.Client{ Transport: NewChaosRoundTripper(http.DefaultTransport, TestLogChaos{t}, ErrSimulatedConnectionResetByPeer), } resp, err := client.Get(server.URL) if unwrapURLError(err) != ErrSimulatedConnectionResetByPeer.error { t.Fatalf(\"expected reset by peer: %v\", err) } if resp != nil { t.Fatalf(\"expected no response object: %#v\", resp) } } func TestPartialChaos(t *testing.T) { server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { w.WriteHeader(http.StatusOK) })) defer server.Close() seed := NewSeed(1) client := http.Client{ Transport: NewChaosRoundTripper( http.DefaultTransport, TestLogChaos{t}, seed.P(0.5, ErrSimulatedConnectionResetByPeer), ), } success, fail := 0, 0 for { _, err := client.Get(server.URL) if err != nil { fail++ } else { success++ } if success > 1 && fail > 1 { break } } } </del>", "commid": "kubernetes_pr_68409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3000984cb75e45bc5b032966c893f1be3072f7c8abd7255b07d061a11a831fe1", "query": "/kind bug /sig release Such as:\nCool issue. /assign\nI see the code in was pushed by you. I don't understand what Intercept() does. Do you think there is an Infinite recursive call?\nChaos client isn\u2019t used anywhere, and we need to remove it soon.\nOk, I can help remove it.\nBut there are also one place using it. How to deal with it? Delete it directly? Or something we need to do?\nHas never been anything other than experimental and was not used in practice. We can remove it and it\u2019s flag from kubelet as it was experimental. are we deprecating experimental flags for one release or can we just remove?", "positive_passages": [{"docid": "doc-en-kubernetes-d15cd06c83a61943f01d8f2fa440ac993ff9d6b39629d293d7b545aa1cae37ae", "text": "k8s.io/kubernetes/pkg/apis/rbac/validation,erictune,0, k8s.io/kubernetes/pkg/apis/storage/validation,caesarxuchao,1, k8s.io/kubernetes/pkg/auth/authorizer/abac,liggitt,0, <del> k8s.io/kubernetes/pkg/client/chaosclient,deads2k,1, </del> k8s.io/kubernetes/pkg/client/legacylisters,jsafrane,1, k8s.io/kubernetes/pkg/client/listers/batch/internalversion,mqliang,0, k8s.io/kubernetes/pkg/client/listers/extensions/internalversion,eparis,1,", "commid": "kubernetes_pr_68409"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844205b3dd953936ebb1454fae42d0bf5c5ef743dd58fd900c2a13921a65ebfc", "query": "We fixed invalid device path in bunch of places via - but call still could use invalid device path. That check can sometimes use invalid path and hence can cause UnmountDevice operation to fails even though device has already been unmounted. /sig storage /sig openstack /assign\nActually this does not affect version 1.10 onwards. Not sure if 1.9 is still supported. I think I will close this for now. /close\nI just noticed that 1.9 is still supported and hence it is probably worth fixing there for now.\nHow come the check can \"sometimes\" use invalid device path?\nSo on Cinder for example - call would return something like as attach device path. But if you see the linked PR(), will do a and use that device path for global mount. In general it is always a good idea to use device path returned by as single source of truth. This applies to something like EBS with NVMe too where device is discovered via call (but nvme disks aren't directly affected by this bug because returned device path on EBS is bogus).\nSo on EBS with NVMe for example - check will always fail (but still return success) because it will use something like as device path which does not actually exist on the node.\nYou said the issue only happens \"sometimes\". Can you clarify why it only happens occasionally?\ndoesn't the linked PR make it clear? detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. As for why - Cinder sometimes returns wrong device path on call, I don't know. But it happens and we have worked around it.\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-2a98a9d50643677c32eb18abbdb357e815ccb5f3d650086e193c4cebc2ec85c3", "text": "// must unmounted prior to detach. // If a volume with the name volumeName does not exist in the list of // attached volumes, an error is returned. <del> SetVolumeGloballyMounted(volumeName v1.UniqueVolumeName, globallyMounted bool) error </del> <ins> SetVolumeGloballyMounted(volumeName v1.UniqueVolumeName, globallyMounted bool, devicePath string) error </ins> // DeletePodFromVolume removes the given pod from the given volume in the // cache indicating the volume has been successfully unmounted from the pod.", "commid": "kubernetes_pr_68674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844205b3dd953936ebb1454fae42d0bf5c5ef743dd58fd900c2a13921a65ebfc", "query": "We fixed invalid device path in bunch of places via - but call still could use invalid device path. That check can sometimes use invalid path and hence can cause UnmountDevice operation to fails even though device has already been unmounted. /sig storage /sig openstack /assign\nActually this does not affect version 1.10 onwards. Not sure if 1.9 is still supported. I think I will close this for now. /close\nI just noticed that 1.9 is still supported and hence it is probably worth fixing there for now.\nHow come the check can \"sometimes\" use invalid device path?\nSo on Cinder for example - call would return something like as attach device path. But if you see the linked PR(), will do a and use that device path for global mount. In general it is always a good idea to use device path returned by as single source of truth. This applies to something like EBS with NVMe too where device is discovered via call (but nvme disks aren't directly affected by this bug because returned device path on EBS is bogus).\nSo on EBS with NVMe for example - check will always fail (but still return success) because it will use something like as device path which does not actually exist on the node.\nYou said the issue only happens \"sometimes\". Can you clarify why it only happens occasionally?\ndoesn't the linked PR make it clear? detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. As for why - Cinder sometimes returns wrong device path on call, I don't know. But it happens and we have worked around it.\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-7c5172710a6b366946e544290e250c11cc7efa836673d317eb30764412f5818b", "text": "} func (asw *actualStateOfWorld) MarkDeviceAsMounted( <del> volumeName v1.UniqueVolumeName) error { return asw.SetVolumeGloballyMounted(volumeName, true /* globallyMounted */) </del> <ins> volumeName v1.UniqueVolumeName, devicePath string) error { return asw.SetVolumeGloballyMounted(volumeName, true /* globallyMounted */, devicePath) </ins> } func (asw *actualStateOfWorld) MarkDeviceAsUnmounted( volumeName v1.UniqueVolumeName) error { <del> return asw.SetVolumeGloballyMounted(volumeName, false /* globallyMounted */) </del> <ins> return asw.SetVolumeGloballyMounted(volumeName, false /* globallyMounted */, \"\" /*devicePath*/) </ins> } // addVolume adds the given volume to the cache indicating the specified", "commid": "kubernetes_pr_68674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844205b3dd953936ebb1454fae42d0bf5c5ef743dd58fd900c2a13921a65ebfc", "query": "We fixed invalid device path in bunch of places via - but call still could use invalid device path. That check can sometimes use invalid path and hence can cause UnmountDevice operation to fails even though device has already been unmounted. /sig storage /sig openstack /assign\nActually this does not affect version 1.10 onwards. Not sure if 1.9 is still supported. I think I will close this for now. /close\nI just noticed that 1.9 is still supported and hence it is probably worth fixing there for now.\nHow come the check can \"sometimes\" use invalid device path?\nSo on Cinder for example - call would return something like as attach device path. But if you see the linked PR(), will do a and use that device path for global mount. In general it is always a good idea to use device path returned by as single source of truth. This applies to something like EBS with NVMe too where device is discovered via call (but nvme disks aren't directly affected by this bug because returned device path on EBS is bogus).\nSo on EBS with NVMe for example - check will always fail (but still return success) because it will use something like as device path which does not actually exist on the node.\nYou said the issue only happens \"sometimes\". Can you clarify why it only happens occasionally?\ndoesn't the linked PR make it clear? detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. As for why - Cinder sometimes returns wrong device path on call, I don't know. But it happens and we have worked around it.\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-822f103de9dc2ec5d578035b11839384cb2f49e2ad361a635c7cac411f0063aa", "text": "} func (asw *actualStateOfWorld) SetVolumeGloballyMounted( <del> volumeName v1.UniqueVolumeName, globallyMounted bool) error { </del> <ins> volumeName v1.UniqueVolumeName, globallyMounted bool, devicePath string) error { </ins> asw.Lock() defer asw.Unlock()", "commid": "kubernetes_pr_68674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844205b3dd953936ebb1454fae42d0bf5c5ef743dd58fd900c2a13921a65ebfc", "query": "We fixed invalid device path in bunch of places via - but call still could use invalid device path. That check can sometimes use invalid path and hence can cause UnmountDevice operation to fails even though device has already been unmounted. /sig storage /sig openstack /assign\nActually this does not affect version 1.10 onwards. Not sure if 1.9 is still supported. I think I will close this for now. /close\nI just noticed that 1.9 is still supported and hence it is probably worth fixing there for now.\nHow come the check can \"sometimes\" use invalid device path?\nSo on Cinder for example - call would return something like as attach device path. But if you see the linked PR(), will do a and use that device path for global mount. In general it is always a good idea to use device path returned by as single source of truth. This applies to something like EBS with NVMe too where device is discovered via call (but nvme disks aren't directly affected by this bug because returned device path on EBS is bogus).\nSo on EBS with NVMe for example - check will always fail (but still return success) because it will use something like as device path which does not actually exist on the node.\nYou said the issue only happens \"sometimes\". Can you clarify why it only happens occasionally?\ndoesn't the linked PR make it clear? detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. As for why - Cinder sometimes returns wrong device path on call, I don't know. But it happens and we have worked around it.\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-1fe7a32ff7a41c268027ccbcfb528cf014e64c1e01b1ca3cd7df6f104b5d6722", "text": "} volumeObj.globallyMounted = globallyMounted <ins> volumeObj.devicePath = devicePath </ins> asw.attachedVolumes[volumeName] = volumeObj return nil }", "commid": "kubernetes_pr_68674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844205b3dd953936ebb1454fae42d0bf5c5ef743dd58fd900c2a13921a65ebfc", "query": "We fixed invalid device path in bunch of places via - but call still could use invalid device path. That check can sometimes use invalid path and hence can cause UnmountDevice operation to fails even though device has already been unmounted. /sig storage /sig openstack /assign\nActually this does not affect version 1.10 onwards. Not sure if 1.9 is still supported. I think I will close this for now. /close\nI just noticed that 1.9 is still supported and hence it is probably worth fixing there for now.\nHow come the check can \"sometimes\" use invalid device path?\nSo on Cinder for example - call would return something like as attach device path. But if you see the linked PR(), will do a and use that device path for global mount. In general it is always a good idea to use device path returned by as single source of truth. This applies to something like EBS with NVMe too where device is discovered via call (but nvme disks aren't directly affected by this bug because returned device path on EBS is bogus).\nSo on EBS with NVMe for example - check will always fail (but still return success) because it will use something like as device path which does not actually exist on the node.\nYou said the issue only happens \"sometimes\". Can you clarify why it only happens occasionally?\ndoesn't the linked PR make it clear? detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. As for why - Cinder sometimes returns wrong device path on call, I don't know. But it happens and we have worked around it.\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-0ddfac4983c09eb8429c5395ebad167dd7bb82556e95d70fb56dcc06652ecdae", "text": "} // Act <del> err = asw.MarkDeviceAsMounted(generatedVolumeName) </del> <ins> err = asw.MarkDeviceAsMounted(generatedVolumeName, devicePath) </ins> // Assert if err != nil {", "commid": "kubernetes_pr_68674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844205b3dd953936ebb1454fae42d0bf5c5ef743dd58fd900c2a13921a65ebfc", "query": "We fixed invalid device path in bunch of places via - but call still could use invalid device path. That check can sometimes use invalid path and hence can cause UnmountDevice operation to fails even though device has already been unmounted. /sig storage /sig openstack /assign\nActually this does not affect version 1.10 onwards. Not sure if 1.9 is still supported. I think I will close this for now. /close\nI just noticed that 1.9 is still supported and hence it is probably worth fixing there for now.\nHow come the check can \"sometimes\" use invalid device path?\nSo on Cinder for example - call would return something like as attach device path. But if you see the linked PR(), will do a and use that device path for global mount. In general it is always a good idea to use device path returned by as single source of truth. This applies to something like EBS with NVMe too where device is discovered via call (but nvme disks aren't directly affected by this bug because returned device path on EBS is bogus).\nSo on EBS with NVMe for example - check will always fail (but still return success) because it will use something like as device path which does not actually exist on the node.\nYou said the issue only happens \"sometimes\". Can you clarify why it only happens occasionally?\ndoesn't the linked PR make it clear? detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. As for why - Cinder sometimes returns wrong device path on call, I don't know. But it happens and we have worked around it.\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-16fef5296348557a7f3ff2a03842638cb1d81c0102679ec7ceab4eacec0c20a9", "text": "continue } if volume.pluginIsAttachable { <del> err = rc.actualStateOfWorld.MarkDeviceAsMounted(volume.volumeName) </del> <ins> err = rc.actualStateOfWorld.MarkDeviceAsMounted(volume.volumeName, volume.devicePath) </ins> if err != nil { glog.Errorf(\"Could not mark device is mounted to actual state of world: %v\", err) continue", "commid": "kubernetes_pr_68674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844205b3dd953936ebb1454fae42d0bf5c5ef743dd58fd900c2a13921a65ebfc", "query": "We fixed invalid device path in bunch of places via - but call still could use invalid device path. That check can sometimes use invalid path and hence can cause UnmountDevice operation to fails even though device has already been unmounted. /sig storage /sig openstack /assign\nActually this does not affect version 1.10 onwards. Not sure if 1.9 is still supported. I think I will close this for now. /close\nI just noticed that 1.9 is still supported and hence it is probably worth fixing there for now.\nHow come the check can \"sometimes\" use invalid device path?\nSo on Cinder for example - call would return something like as attach device path. But if you see the linked PR(), will do a and use that device path for global mount. In general it is always a good idea to use device path returned by as single source of truth. This applies to something like EBS with NVMe too where device is discovered via call (but nvme disks aren't directly affected by this bug because returned device path on EBS is bogus).\nSo on EBS with NVMe for example - check will always fail (but still return success) because it will use something like as device path which does not actually exist on the node.\nYou said the issue only happens \"sometimes\". Can you clarify why it only happens occasionally?\ndoesn't the linked PR make it clear? detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. As for why - Cinder sometimes returns wrong device path on call, I don't know. But it happens and we have worked around it.\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-349700f9e3117a1a8e78dcf719dc4bbe33dd1b59a258373d834fdef3af4209b4", "text": "MarkVolumeAsUnmounted(podName volumetypes.UniquePodName, volumeName v1.UniqueVolumeName) error // Marks the specified volume as having been globally mounted. <del> MarkDeviceAsMounted(volumeName v1.UniqueVolumeName) error </del> <ins> MarkDeviceAsMounted(volumeName v1.UniqueVolumeName, devicePath string) error </ins> // Marks the specified volume as having its global mount unmounted. MarkDeviceAsUnmounted(volumeName v1.UniqueVolumeName) error", "commid": "kubernetes_pr_68674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844205b3dd953936ebb1454fae42d0bf5c5ef743dd58fd900c2a13921a65ebfc", "query": "We fixed invalid device path in bunch of places via - but call still could use invalid device path. That check can sometimes use invalid path and hence can cause UnmountDevice operation to fails even though device has already been unmounted. /sig storage /sig openstack /assign\nActually this does not affect version 1.10 onwards. Not sure if 1.9 is still supported. I think I will close this for now. /close\nI just noticed that 1.9 is still supported and hence it is probably worth fixing there for now.\nHow come the check can \"sometimes\" use invalid device path?\nSo on Cinder for example - call would return something like as attach device path. But if you see the linked PR(), will do a and use that device path for global mount. In general it is always a good idea to use device path returned by as single source of truth. This applies to something like EBS with NVMe too where device is discovered via call (but nvme disks aren't directly affected by this bug because returned device path on EBS is bogus).\nSo on EBS with NVMe for example - check will always fail (but still return success) because it will use something like as device path which does not actually exist on the node.\nYou said the issue only happens \"sometimes\". Can you clarify why it only happens occasionally?\ndoesn't the linked PR make it clear? detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. As for why - Cinder sometimes returns wrong device path on call, I don't know. But it happens and we have worked around it.\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-8d86d174329f8e7d5ee1501a755b0f2f9b6d38f7f0eea05322e5666ca69a5bde", "text": "// Update actual state of world to reflect volume is globally mounted markDeviceMountedErr := actualStateOfWorld.MarkDeviceAsMounted( <del> volumeToMount.VolumeName) </del> <ins> volumeToMount.VolumeName, devicePath) </ins> if markDeviceMountedErr != nil { // On failure, return error. Caller will log and retry. return volumeToMount.GenerateErrorDetailed(\"MountVolume.MarkDeviceAsMounted failed\", markDeviceMountedErr)", "commid": "kubernetes_pr_68674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844205b3dd953936ebb1454fae42d0bf5c5ef743dd58fd900c2a13921a65ebfc", "query": "We fixed invalid device path in bunch of places via - but call still could use invalid device path. That check can sometimes use invalid path and hence can cause UnmountDevice operation to fails even though device has already been unmounted. /sig storage /sig openstack /assign\nActually this does not affect version 1.10 onwards. Not sure if 1.9 is still supported. I think I will close this for now. /close\nI just noticed that 1.9 is still supported and hence it is probably worth fixing there for now.\nHow come the check can \"sometimes\" use invalid device path?\nSo on Cinder for example - call would return something like as attach device path. But if you see the linked PR(), will do a and use that device path for global mount. In general it is always a good idea to use device path returned by as single source of truth. This applies to something like EBS with NVMe too where device is discovered via call (but nvme disks aren't directly affected by this bug because returned device path on EBS is bogus).\nSo on EBS with NVMe for example - check will always fail (but still return success) because it will use something like as device path which does not actually exist on the node.\nYou said the issue only happens \"sometimes\". Can you clarify why it only happens occasionally?\ndoesn't the linked PR make it clear? detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. As for why - Cinder sometimes returns wrong device path on call, I don't know. But it happens and we have worked around it.\nFixed by", "positive_passages": [{"docid": "doc-en-kubernetes-22464ba153b548617c1b6e9d118cb09106870f3cf4f9427879c0766bf7064646", "text": "// Update actual state of world to reflect volume is globally mounted markDeviceMappedErr := actualStateOfWorld.MarkDeviceAsMounted( <del> volumeToMount.VolumeName) </del> <ins> volumeToMount.VolumeName, devicePath) </ins> if markDeviceMappedErr != nil { // On failure, return error. Caller will log and retry. return volumeToMount.GenerateErrorDetailed(\"MapVolume.MarkDeviceAsMounted failed\", markDeviceMappedErr)", "commid": "kubernetes_pr_68674"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-437d6c360673c1e8f00e42bdafdadaee2e596ba27a49b7d01b3a77e242c81c64", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: CSI Plugin calls to get node ID information (see ). If that call is not implemented by driver, registration with kubelet will fail. What you expected to happen: Per CSI Spec, the deprecated call should be supported until CSI 1.0 is released (see ). Therefore if a by Kubernetes fails (because it is not implemented by the driver), we should fall back and try call instead. How to reproduce it (as minimally and precisely as possible): Use any CSI driver that implements but not -- says OpenSDS driver is currently hitting this, and may be used for repro. Anything else we need to know?: When CSI moves to 1.0 we can drop this fall back logic. If a fix is available within , we can include it, but 1.12 release should NOT block on this. /sig storage Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:\nplease verify this is the issue you hit. Specifically see if you can find in your kubelet logs.\nCC who volunteered to take a look\nI don't see \"error during CSI NodeGetInfo\" in my kubelet logs. I don't see glog.Infof(log(\"Register new plugin with name: %s at endpoint: %s\", pluginName, endpoint)) so it seems that RegisterPlugin is not called. I do see a message: \"Plugin Watcher Start at /var/lib/kubelet/plugins\". I don't know why RegisterPlugin is not called. I'll continue to check.\nHere's an update. I implemented NodeGetInfo. I followed documentation about the Kubelet Plugin Watcher: https://kubernetes- to get my plugin registered. After that I don\u2019t see the \u201cdriver name csi-opensdsplugin not found in the list of registred CSI drivers\u201d any more. I see that now RegisterPlugin gets called and I see the following message in I0914 14:44:50. ] Register new plugin with name: csi-opensdsplugin at endpoint: /var/lib/kubelet/plugins/csi- So this confirmed that missing NodeGetInfo is the problem. I still have problems but I think that\u2019s a config issue on my side. I the following as cluster role rule for attacher and node: apiGroups: [\"\"] resources: [\"csidrivers\"] verbs: [\"get\", \"list\", \"watch\", \"update\"] However I\u2019m still getting the following errors in the logs: I0914 16:12:31. ] Listing and watching v1alpha1.CSIDriver from E0914 16:12:31. ] Failed to list v1alpha1.CSIDriver: is forbidden: User \"system:serviceaccount:kube-system:attachdetach-controller\" cannot list resource \"csidrivers\" in API group \"\" at the cluster scope kube-controller- I0914 16:11:51. ] Listing and watching v1alpha1.CSIDriver from E0914 16:11:51. ] Failed to list v1alpha1.CSIDriver: is forbidden: User \"system:node:127.0.0.1\" cannot list resource \"csidrivers\" in API group \"\" at the cluster scope\nDid more investigation on this. Here's an update. I set the following feature gate to true on my local cluster: alpha: CSICRDAutoInstall CSISkipAttach CSIPodInfo I got some new errors in and kube-controller- I0916 07:22:06. ] Listing and watching v1alpha1.CSIDriver from E0916 07:22:06. ] Failed to list v1alpha1.CSIDriver: the server could not find the requested resource (get ) I0916 07:25:24. ] Listing and watching v1alpha1.CSIDriver from E0916 07:25:24. ] Failed to list v1alpha1.CSIDriver: the server could not find the requested resource (get ) In addition, I found the following in kube-controller- E0916 07:22:01. ] failed to create CSIDrivers CRD: &v1beta1.CustomResourceDefinition{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, ObjectMeta:v1.ObjectMeta{Name:\"\", GenerateName:\"\", Namespace:\"\", SelfLink:\"\", UID:\"\", ResourceVersion:\"\", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(time.Location)(nil)}}, DeletionTimestamp:(v1.Time)(nil), DeletionGracePeriodSeconds:(int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:\"\"}, Spec:v1beta1.CustomResourceDefinitionSpec{Group:\"\", Version:\"\", Names:v1beta1.CustomResourceDefinitionNames{Plural:\"\", Singular:\"\", ShortNames:[]string(nil), Kind:\"\", ListKind:\"\", Categories:[]string(nil)}, Scope:\"\", Validation:(v1beta1.CustomResourceValidation)(nil), Subresources:(v1beta1.CustomResourceSubresources)(nil), Versions:[]v1beta1.CustomResourceDefinitionVersion(nil), AdditionalPrinterColumns:[]v1beta1.CustomResourceColumnDefinition(nil)}, Status:v1beta1.CustomResourceDefinitionStatus{Conditions:[]v1beta1.CustomResourceDefinitionCondition(nil), AcceptedNames:v1beta1.CustomResourceDefinitionNames{Plural:\"\", Singular:\"\", ShortNames:[]string(nil), Kind:\"\", ListKind:\"\", Categories:[]string(nil)}, StoredVersions:[]string(nil)}}, err: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, ListMeta:v1.ListMeta{SelfLink:\"\", ResourceVersion:\"\", Continue:\"\"}, Status:\"Failure\", Message:\" is forbidden: User \"system:serviceaccount:kube-system:attachdetach-controller\" cannot create resource \"customresourcedefinitions\" in API group \"\" at the cluster scope\", Reason:\"Forbidden\", Details:(*v1.StatusDetails)(0xc4212af560), Code:403}} So I made this change to add RBAC rule for customresourcedefinitions: After that, my CSI plugin is functional. I can create/attach/mount volumes successfully now.\n/cc\n(As we discussed offline) the latest code in master no longer has CSICRDAutoInstall, CSISkipAttach, CSIPodInfo flags. New CSI features are now flag gated under CSINodeInfo and CSIDriverRegistry flags (both alpha and disabled by default). KubeletPluginsWatcher must be enabled as well, but that's in beta now so it's enabled by default. Since this PR merged: , CRDs must be installed manually, and you can find an example of it here: (note they have to be created with --validation=false kubectl flag for the time being). This PR has not been cherry-picked to 1.12.0-rc.0 yet.\nThanks Tested latest code. If NodeGetInfo is implemented, we just need to make necessary changes when deploying driver-registrar sidecar container so KubeletPluginsWatcher can work. NodeGetInfo is needed for kubelet to register CSI plugins. Also tested with and without \"CSINodeInfo=true,CSIDriverRegistry=true\" and manually installed CRDs using when they are enabled.\nI have the same problem when deploying my CSI plugin based on CSI v0.2.0 on Kubernetes v.1.12.0. Daemonset pods of CSI plugin cannot launch successfully. Kubelet logs:\nConsidering Kubernetes v1.12 is already out, and we planned to deprecate the old call in CSI 1.0/Kubernetes 1.13 anyway, we'll pull of the bandaid and deprecate it now. If you are running Kubernetes 1.13, make sure your CSI driver implements the .\nlooks like you might be running in to a different issue: Kubernetes v1.13 also enables Kubelet device plugin registration by default. Before upgrading to v1.13, ensure the CSI sidecar container for your CSI driver is configured to handle plugin registration (set the parameter on to expose a new unix domain socket to handle Kubelet Plugin Registration). From\nHi Because goes Beta and is enabled by default in Kubernetes v1.12. After disabling this feater gate, I can run CSI plugin based on CSI spec v0.2.0 in Kubernetes v1.12.2. When Kubelet enable , Kubelet would call gRPC call to register CSI plugin. gRPC call was first proposed at CSI spec v0.3.0. Therefore, user should disable feature gate when running CSI plugin based on CSI spec v0.2.0 in Kubernetes v1.12.\nI have implement the NodeGetInfo call. But it still has this issue. My kubernetes version is 1.14.3.", "positive_passages": [{"docid": "doc-en-kubernetes-56a6ef697beab01e96c837c120ac625b9f941d042ecc0bc9a9f0bdd01e1a4161", "text": "* kube-apiserver: the `Priority` admission plugin is now enabled by default when using `--enable-admission-plugins`. If using `--admission-control` to fully specify the set of admission plugins, the `Priority` admission plugin should be added if using the `PodPriority` feature, which is enabled by default in 1.11. ([#65739](https://github.com/kubernetes/kubernetes/pull/65739), [@liggitt](https://github.com/liggitt)) * The `system-node-critical` and `system-cluster-critical` priority classes are now limited to the `kube-system` namespace by the `PodPriority` admission plugin. ([#65593](https://github.com/kubernetes/kubernetes/pull/65593), [@bsalamat](https://github.com/bsalamat)) * kubernetes-worker juju charm: Added support for setting the --enable-ssl-chain-completion option on the ingress proxy.  \"action required\": if your installation relies on supplying incomplete certificate chains and using OCSP to fill them in, you must set \"ingress-ssl-chain-completion\" to \"true\" in your juju configuration. ([#63845](https://github.com/kubernetes/kubernetes/pull/63845), [@paulgear](https://github.com/paulgear)) <ins> * In anticipation of CSI 1.0 in the next release, Kubernetes 1.12 calls the CSI `NodeGetInfo` RPC instead of `NodeGetId` RPC. Ensure your CSI Driver implements `NodeGetInfo(...)` before upgrading to 1.12. [@saad-ali](https://github.com/kubernetes/kubernetes/issues/68688) * Kubernetes 1.12 also enables [Kubelet device plugin registration](https://github.com/kubernetes/features/issues/595) feature by default. Before upgrading to 1.12, ensure the `driver-registrar` CSI sidecar container for your CSI driver is configured to handle plugin registration (set the `--kubelet-registration-path` parameter on `driver-registrar` to expose a new unix domain socket to handle Kubelet Plugin Registration). </ins> ### Other notable changes", "commid": "kubernetes_pr_69903"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-44de15891075df631b07f50c082635d98a7de9f9bd002018dc655f215347ea12", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: After running (on master branch), a new file named left as a surprise. and the file is not matched by git ignore so it's tracked by git which is really disturbing. I tried to find out where it's created but failed. Any one has a context w/ it? Environment: OS (e.g. from /etc/os-release): Darwin Kernel Version 17.6.0: Tue May 8 15:22:16 PDT 2018; root:xnu-4570.61.1~1/RELEASEX8664 x86_64\n/sig instrumentation\nthe only piece of code in local-up-cluster that touches the file is\ncan't reproduce this. Two questions: Can you see this everytime? What is the SHA of the commit on master when you tried this? Can check with that too.\nfinally i realize that the cause is command is built receiving different flags between Linux and OSX. on Linux, you'll find that for linux sed the is explained as: '--in-place[=SUFFIX]' This option specifies that files are to be edited in-place. GNU 'sed' does this by creating a temporary file and sending output to this file rather than to the standard output.(1). so the is optional. but for OSX, it is: Edit files in-place, saving backups with the specified extension. If a zero-length extension is given, no backup will be saved. It is not recommended to give a zero- length extension when in-place editing files, as you risk corruption or partial content in situations where disk space is exhausted, etc. the difference is that on OSX, flag is requiring a variable , so when we're using on OSX in the script: the which is supposed to be received as a flag will be a suffix for the backup file. then the magic happened.will raise a fix for this. /assign\nlinking the difference between and", "positive_passages": [{"docid": "doc-en-kubernetes-220a0cf07d816a166dbf08eb8387227178420ee74456d68ec76db5a15b43a78f", "text": "set -e source \"${KUBE_ROOT}/hack/lib/init.sh\" <ins> kube::util::ensure-gnu-sed </ins> function usage { echo \"This script starts a local kube cluster. \"", "commid": "kubernetes_pr_68970"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-44de15891075df631b07f50c082635d98a7de9f9bd002018dc655f215347ea12", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: After running (on master branch), a new file named left as a surprise. and the file is not matched by git ignore so it's tracked by git which is really disturbing. I tried to find out where it's created but failed. Any one has a context w/ it? Environment: OS (e.g. from /etc/os-release): Darwin Kernel Version 17.6.0: Tue May 8 15:22:16 PDT 2018; root:xnu-4570.61.1~1/RELEASEX8664 x86_64\n/sig instrumentation\nthe only piece of code in local-up-cluster that touches the file is\ncan't reproduce this. Two questions: Can you see this everytime? What is the SHA of the commit on master when you tried this? Can check with that too.\nfinally i realize that the cause is command is built receiving different flags between Linux and OSX. on Linux, you'll find that for linux sed the is explained as: '--in-place[=SUFFIX]' This option specifies that files are to be edited in-place. GNU 'sed' does this by creating a temporary file and sending output to this file rather than to the standard output.(1). so the is optional. but for OSX, it is: Edit files in-place, saving backups with the specified extension. If a zero-length extension is given, no backup will be saved. It is not recommended to give a zero- length extension when in-place editing files, as you risk corruption or partial content in situations where disk space is exhausted, etc. the difference is that on OSX, flag is requiring a variable , so when we're using on OSX in the script: the which is supposed to be received as a flag will be a suffix for the backup file. then the magic happened.will raise a fix for this. /assign\nlinking the difference between and", "positive_passages": [{"docid": "doc-en-kubernetes-e07f302731ad78c90d8821091a5ed9b3f61427167001f4ae3c7b840189661a72", "text": "#   foo: true #   bar: false for gate in $(echo ${FEATURE_GATES} | tr ',' ' '); do <del> echo $gate | sed -e 's/(.*)=(.*)/  1: 2/' </del> <ins> echo $gate | ${SED} -e 's/(.*)=(.*)/  1: 2/' </ins> done fi >>/tmp/kube-proxy.yaml", "commid": "kubernetes_pr_68970"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-44de15891075df631b07f50c082635d98a7de9f9bd002018dc655f215347ea12", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: After running (on master branch), a new file named left as a surprise. and the file is not matched by git ignore so it's tracked by git which is really disturbing. I tried to find out where it's created but failed. Any one has a context w/ it? Environment: OS (e.g. from /etc/os-release): Darwin Kernel Version 17.6.0: Tue May 8 15:22:16 PDT 2018; root:xnu-4570.61.1~1/RELEASEX8664 x86_64\n/sig instrumentation\nthe only piece of code in local-up-cluster that touches the file is\ncan't reproduce this. Two questions: Can you see this everytime? What is the SHA of the commit on master when you tried this? Can check with that too.\nfinally i realize that the cause is command is built receiving different flags between Linux and OSX. on Linux, you'll find that for linux sed the is explained as: '--in-place[=SUFFIX]' This option specifies that files are to be edited in-place. GNU 'sed' does this by creating a temporary file and sending output to this file rather than to the standard output.(1). so the is optional. but for OSX, it is: Edit files in-place, saving backups with the specified extension. If a zero-length extension is given, no backup will be saved. It is not recommended to give a zero- length extension when in-place editing files, as you risk corruption or partial content in situations where disk space is exhausted, etc. the difference is that on OSX, flag is requiring a variable , so when we're using on OSX in the script: the which is supposed to be received as a flag will be a suffix for the backup file. then the magic happened.will raise a fix for this. /assign\nlinking the difference between and", "positive_passages": [{"docid": "doc-en-kubernetes-a69affbbc5c958570b2b56dc29fbc34b3b3d716b6da9d9ab63c2951dd99b9c52", "text": "function start_kubedns { if [[ \"${ENABLE_CLUSTER_DNS}\" = true ]]; then cp \"${KUBE_ROOT}/cluster/addons/dns/kube-dns/kube-dns.yaml.in\" kube-dns.yaml <del> sed -i -e \"s/{{ pillar['dns_domain'] }}/${DNS_DOMAIN}/g\" kube-dns.yaml sed -i -e \"s/{{ pillar['dns_server'] }}/${DNS_SERVER_IP}/g\" kube-dns.yaml </del> <ins> ${SED} -i -e \"s/{{ pillar['dns_domain'] }}/${DNS_DOMAIN}/g\" kube-dns.yaml ${SED} -i -e \"s/{{ pillar['dns_server'] }}/${DNS_SERVER_IP}/g\" kube-dns.yaml </ins> # TODO update to dns role once we have one. # use kubectl to create kubedns addon ${KUBECTL} --kubeconfig=\"${CERT_DIR}/admin.kubeconfig\" --namespace=kube-system create -f kube-dns.yaml", "commid": "kubernetes_pr_68970"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-de5f2c37dc83b8e3c71ab19779fa4067a89caa68b2b68175821af26181b15923", "query": "/kind bug What happened: After upgrading 1.11.1 -1.12.0 , when a node gets terminated in AWS, the controller-manager doesn't delete the node in the API. This has lead to several side effect for us : pods don't get GC Prometheus alerts firing because 100 of nodes are in the NotReady state for a long period What you expected to happen: kube-controller-manager deletes the node when it stops reporting, after checking with the cloud provider. How to reproduce it (as minimally and precisely as possible): Looking at the code, I believe this is what introduced the behaviour change : - The node gets tainted with because it's in a Terminated state. But it doesn't get removed because it still \"exists\" in the cloud provider. The behaviour is probably correct for a shutdown node, but in AWS a terminated node can't be restarted so there's no good reason to keep it there ? Environment: Kubernetes version : 1.2.0 Cloud provider or hardware configuration: AWS OS (e.g. from /etc/os-release): CoreOS (sorry for the all the sigs, not sure who it belongs to) /sig aws /sig cloud-provider /sig cluster-lifecycle\nas I see it should delete node if instance is in terminated state have you tested that change in that row? I do not see what could be the issue there. Or could it be that the is not in place for all binaries in 1.12.0?\nI might be wrong, but I think that part of the code never gets executed once the node is tainted :\ngood finding. So we should remove terminated state from this row. Then it does not add shutdown taint if node is terminated - instead it will delete node. also this should return false.. because if it returns true node is not deleted\nI had the same issue. After I scale down my worker node instance number from 3 to 1. One node is stuck in status and never got deleted. However, one interesting thing is one of the other node is removed successfully. do you see similar behavior too?\n- can we make sure this gets cherry picked for 1.12 releases ? I think we already missed the cut for 1.12.2", "positive_passages": [{"docid": "doc-en-kubernetes-17a5129d9aee90b56084ddb1d7829317d74aea1e8db88bc080f6029761fa1aaf", "text": "} if len(instances) == 0 { glog.Warningf(\"the instance %s does not exist anymore\", providerID) <del> return true, nil </del> <ins> // returns false, because otherwise node is not deleted from cluster // false means that it will continue to check InstanceExistsByProviderID return false, nil </ins> } if len(instances) > 1 { return false, fmt.Errorf(\"multiple instances found for instance: %s\", instanceID)", "commid": "kubernetes_pr_69454"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-de5f2c37dc83b8e3c71ab19779fa4067a89caa68b2b68175821af26181b15923", "query": "/kind bug What happened: After upgrading 1.11.1 -1.12.0 , when a node gets terminated in AWS, the controller-manager doesn't delete the node in the API. This has lead to several side effect for us : pods don't get GC Prometheus alerts firing because 100 of nodes are in the NotReady state for a long period What you expected to happen: kube-controller-manager deletes the node when it stops reporting, after checking with the cloud provider. How to reproduce it (as minimally and precisely as possible): Looking at the code, I believe this is what introduced the behaviour change : - The node gets tainted with because it's in a Terminated state. But it doesn't get removed because it still \"exists\" in the cloud provider. The behaviour is probably correct for a shutdown node, but in AWS a terminated node can't be restarted so there's no good reason to keep it there ? Environment: Kubernetes version : 1.2.0 Cloud provider or hardware configuration: AWS OS (e.g. from /etc/os-release): CoreOS (sorry for the all the sigs, not sure who it belongs to) /sig aws /sig cloud-provider /sig cluster-lifecycle\nas I see it should delete node if instance is in terminated state have you tested that change in that row? I do not see what could be the issue there. Or could it be that the is not in place for all binaries in 1.12.0?\nI might be wrong, but I think that part of the code never gets executed once the node is tainted :\ngood finding. So we should remove terminated state from this row. Then it does not add shutdown taint if node is terminated - instead it will delete node. also this should return false.. because if it returns true node is not deleted\nI had the same issue. After I scale down my worker node instance number from 3 to 1. One node is stuck in status and never got deleted. However, one interesting thing is one of the other node is removed successfully. do you see similar behavior too?\n- can we make sure this gets cherry picked for 1.12 releases ? I think we already missed the cut for 1.12.2", "positive_passages": [{"docid": "doc-en-kubernetes-3f40507417225133fc15b5431023ca5898ab4e404a3ce6f029440b877b7c95e9", "text": "if instance.State != nil { state := aws.StringValue(instance.State.Name) // valid state for detaching volumes <del> if state == ec2.InstanceStateNameStopped || state == ec2.InstanceStateNameTerminated { </del> <ins> if state == ec2.InstanceStateNameStopped { </ins> return true, nil } }", "commid": "kubernetes_pr_69454"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3c94567dd7c22153dcd3c3d3fd52ec6b7d816a73e9f5b4c6749f041044699dee", "query": "Is this a BUG REPORT or FEATURE REQUEST?: What happened: After upgrade of Kubernetes 1.11.3 to 1.12.1 via kubeadm in bare-metal setup I see these errors in kubelet logs: What you expected to happen: Since this is a bare-metal setup I expect no messages concerning Azure cloud How to reproduce it (as minimally and precisely as possible): Do an upgrade from 1.11.3 to 1.12.1 Anything else we need to know?: kubelet-1.12.1- was downloaded from Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"12\", GitVersion:\"v1.12.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-10-05T16:46:06Z\", GoVersion:\"go1.10.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"12\", GitVersion:\"v1.12.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-10-05T16:36:14Z\", GoVersion:\"go1.10.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: bare-metal OS (e.g. from /etc/os-release): Oracle Linux Server 7.4 Kernel (e.g. ): 62 Install tools: Others:\nLines from kubelet log which say that no cloud provider was specified (that is a bare-metal setup): ..\n/sig azure\nhave the same issue related to the azure.. also a bare-metal cluster.. these messages are flooding my centralized logging elasticsearch (though they aren't really problematic more than being an annoyance). i also upgraded from 1.11.3 to 1.12.1 on a 3-master HA set up. i also noted (perhaps worthy of a separate issue) that the two of my three control-planes that are showing the azure error also previously had been having cert authority errors from the api-server container, when having used kubeadm upgrade.. (on the second two control plane systems, with the issue) (and on the first control without the issue) (and i needed to kubeadm reset and then kubeadm init all over again with 1.12.1 on the 2nd two control-plane nodes).. the first control-plane node that didn't need to do a reset/init didn't have the azure errors (nor the cert errors). so i kind of suspect it might not be an kubeadm upgrade issue but a general issue going from 1.11.3 to 1.12.1 ?\nSame problems +1\nSame problem on brand new bm 1.12.1 cluster built with kubeadm and latest 1alpha3 config based off of customized kubeadm config print-default example\n/assign\nSame problems +1\nOct 9 11:11:32 localhost kubelet: E1009 11:11:32. 3342 ] failed to get azure cloud in GetVolumeLimits, kubernetes-1 Oct 9 11:11:42 localhost kubelet: E1009 11:11:42. 3342 ] failed to get azure cloud in GetVolumeLimits, kubernetes-1 Oct 9 11:11:52 localhost kubelet: E1009 11:11:52. 3342 ] failed to get azure cloud in GetVolumeLimits, kubernetes-1 Oct 9 11:12:02 localhost kubelet: E1009 11:12:02. 3342 ] failed to get azure cloud in GetVolumeLimits, kubernetes-1 Oct 9 11:12:12 localhost kubelet: E1009 11:12:12. 3342 ] failed to get azure cloud in GetVolumeLimits, kubernetes-1 Oct 9 11:12:23 localhost kubelet: E1009 11:12:23. 3342 ] failed to get azure cloud in GetVolumeLimits, kubernetes-1 Oct 9 11:12:33 localhost kubelet: E1009 11:12:33. 3342 ] failed to get azure cloud in GetVolumeLimits, kubernetes-1 Oct 9 11:12:43 localhost kubelet: E1009 11:12:43. 3342 ] failed to get azure cloud in GetVolumeLimits, kubernetes-1 Oct 9 11:12:53 localhost kubelet: E1009 11:12:53. 3342 ] failed to get azure cloud in GetVolumeLimits, kubernetes-1 Oct 9 11:13:03 localhost kubelet: E1009 11:13:03. 3342 ] failed to get azure cloud in GetVolumeLimits, kubernetes-1\nhow often did you hit this error log: I am planning to make this log as , is that ok for you? Usually V(2) is the default info(see ) log for k8s on azure I am not sure what the default info log by kubeadmin installation.\nIt is logged every 10 seconds. I disagree. At least previous incarnation of GetVolumeLimits in version 1.11.3 : would have logged an error \"No cloudprovider present\". Which I didn't see in kubelet log. In fact, I didn't see any message in kubelet logs with 'azure' substring at all. I think it means that AzureDataDisk plugin was not instantiated at all in 1.11.3. So the question is: why azuredd is instantiated now in 1.12.1 in bare-metal setup (that is without cloud provider)? Do you mind checking this idea? (Besides your method of lowering message priority won't work as I said this is a bare-metal setup where kubelet systemd unit file has no --v option at all )\nThat's because feature reaches beta in v1.12, in v1.11.3, even the code is there, it won't be invoked since feature is still alpha in v1.11\nAnd in v1.12, aws, gce, and azure disk plugins are all loaded, take aws ebs for example, it will return error directly: And logging as V(4): I suppose V(4) logs won't display in logs. Let me make the same change as aws and gce.\nalso tries to address this error.\nThe same mistake, I also encountered NAME STATUS ROLES AGE VERSION INTERNAL-IP EXTERNAL-IP OS-IMAGE KERNEL-VERSION CONTAINER-RUNTIME 172.16.16.13 Ready <none5m27s v1.12.1 172.16.16.13 <noneCentOS Linux 7 (Core) 4.18.12- docker://18.6.0 failed to get azure cloud in GetVolumeLimits, 172.16.16.13 failed to get azure cloud in GetVolumeLimits, 172.16.16.13 failed to get azure cloud in GetVolumeLimits, 172.16.16.13\nI have cherry picked the fix to v1.12\nI understand that the feature Node-specific Volume Limits has now reached beta in 1.12, but for those of us running Kubernetes on-premises, this log error is pretty useless. In fact, I would even want to disable this plugin alltogether, since it will never be used on-prem. Is there a way to stop the plugin from loading, or in the very least make sure the log does not appear? Right now, it is polluting the system log file quite a lot.\nI second that. That was the key message of my bug report. That is we must not even instantiate cloud-specific plugins if no cloud provider is configured.\nI'm having exactly the same problem, doing an installation from scratch on DigitalOcean\n+1\n+1\nHi I have the same issue. It would be really nice to know how to disable this error message that floods the logs for no reason.\nFor those using logstash it was sufficient to just temporarily add this to your syslog filter: if [message] =~ \"\" { drop { } }\nAfter a fresh installation of Raspbian and kubernetes, same issue is occurring in my 4 node cluster. Client Version: version.Info{Major:\"1\", Minor:\"12\", GitVersion:\"v1.12.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-10-05T16:46:06Z\", GoVersion:\"go1.10.4\", Compiler:\"gc\", Platform:\"linux/arm\"} Server Version: version.Info{Major:\"1\", Minor:\"12\", GitVersion:\"v1.12.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2018-10-05T16:36:14Z\", GoVersion:\"go1.10.4\", Compiler:\"gc\", Platform:\"linux/arm\"} flood of this: epsilon kubelet[2412]: E1024 12:25:58. 2412 ] failed to get azure cloud in GetVolumeLimits, epsilon\ndisable in controller plane should work: \"--feature-gates=AttachVolumeLimit=false\"\nI have tried \"--feature-gates=AttachVolumeLimit=false\" and it's not working. I still see messages kubelet[]: E1024 22:51:02. ] failed to get azure cloud in GetVolumeLimits,\nI have the same problem here.., ] failed to get azure cloud in GetVolumeLimits,\n+1 same case here, also tried with --feature-gates=AttachVolumeLimit=false\nWill this be disabled by default in the next release?\nIt's already fixed in v1.12.2 and v1.13.0. do you know how to disable in kubelet in v1.12? Would add in kubelet command arguments work?\nI haven't updated to 1.12.2 yet (still on 1.12.1) but just to confirm, disabling that feature works. For those that are also running on CentOS and/or RHEL, just to the following: Edit file on your master server (control plane), and add the following: If you already have extra arguments in there, just add this one at the end of the line. Then restart kubelet on your master server:\nYes that will work.\n--feature-gates=AttachVolumeLimit property doesn't exist in the documentation\nUpdate tho 1.12.2 resolve for me Em qui, 1 de nov de 2018 9:22 PM, Abhilash Pallerlamudi < escreveu:\nadd follow line to \"your kubelet.service\" file. like this: [root ~]# systemctl daemon-reload [root ~]# sudo systemctl restart kubelet then it's ok\nSo to get rid of a bug we should disable an entire feature? Says it is supported by Azure-Disk. Why isn't node reporting the limit? It is getting instance metadata okay as all my nodes are tagged with SKU. Being that SKU determines attach limit as well, I do not understand why this cannot be made working? I am on 1.14 in Azure on Ubuntu.\nhow do you deploy k8s on Azure? To get volume limit, kubelet on agent node needs azure identity, e.g. service principal, usually it's under file\nI deployed with kubespray. I have cloudconfig set as such: KUBELETCLOUDPROVIDER=\"--cloud-provider=azure --cloud-config=/etc/kubernetes/cloudconfig\" Service principle is set in cloudconfig file.\nI triple checked and location was misspelled on some of the nodes for the cloud provider. Thanks!\nthe get vm size list call depends on location, so now it works?\nYes it does. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-bddc622e5822f3ef794148af10ba92e96814a468bb32c67dc99057b7e1588f17", "text": "// hoping external CCM or admin can set it. Returning // default values from here will mean, no one can // override them. <del> glog.Errorf(\"failed to get azure cloud in GetVolumeLimits, plugin.host: %s\", plugin.host.GetHostName()) return volumeLimits, nil </del> <ins> return nil, fmt.Errorf(\"failed to get azure cloud in GetVolumeLimits, plugin.host: %s\", plugin.host.GetHostName()) </ins> } instances, ok := az.Instances()", "commid": "kubernetes_pr_69558"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-20a4ccf4adcc587e9b1d97fc6976c0accb49e7f495374adff17fffda9a16848e", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: e2e test \"[sig-network] Network [It] should set TCP CLOSEWAIT timeout\" requires the test target OS supports /proc/net/nfconntrack, but Ubuntu 16.04 doesn't support it. Then the test fails today like the following: What you expected to happen: The test succeeded or was skipped. How to reproduce it (as minimally and precisely as possible): Just kick Anything else we need to know?: The existence of /proc/net/nfconntrack depends on the Linux kernel config CONFIGNFCONNTRACKPROCFS, but that is disabled on Ubuntu 16.04. In addition, the test is skipped if the node number is less than 2. So I guess that is one of reasons this issue was not present until today. Environment: Kubernetes version (use ): v1.11.3 Cloud provider or hardware configuration: OpenStack OS (e.g. from /etc/os-release): Ubuntu 16.04.4 LTS Kernel (e.g. ): 4.4.0-134-generic Install tools: kubeadm Others:\n/sig network\nSome kube-proxy functionalities depends on conntrack, is it possible to run a conformance cluster without having conntrack enable?", "positive_passages": [{"docid": "doc-en-kubernetes-dbb4032b8df9fc40976fc7df215f1ea8ff53add3f13cbeac8fc444b5bf461b13", "text": "LogSSHResult(result) if result.Code != 0 || err != nil { <del> return nil, fmt.Errorf(\"failed running %q: %v (exit code %d)\", cmd, err, result.Code) </del> <ins> return nil, fmt.Errorf(\"failed running %q: %v (exit code %d, stderr %v)\", cmd, err, result.Code, result.Stderr) </ins> } return &result, nil", "commid": "kubernetes_pr_69589"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-20a4ccf4adcc587e9b1d97fc6976c0accb49e7f495374adff17fffda9a16848e", "query": "Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: e2e test \"[sig-network] Network [It] should set TCP CLOSEWAIT timeout\" requires the test target OS supports /proc/net/nfconntrack, but Ubuntu 16.04 doesn't support it. Then the test fails today like the following: What you expected to happen: The test succeeded or was skipped. How to reproduce it (as minimally and precisely as possible): Just kick Anything else we need to know?: The existence of /proc/net/nfconntrack depends on the Linux kernel config CONFIGNFCONNTRACKPROCFS, but that is disabled on Ubuntu 16.04. In addition, the test is skipped if the node number is less than 2. So I guess that is one of reasons this issue was not present until today. Environment: Kubernetes version (use ): v1.11.3 Cloud provider or hardware configuration: OpenStack OS (e.g. from /etc/os-release): Ubuntu 16.04.4 LTS Kernel (e.g. ): 4.4.0-134-generic Install tools: kubeadm Others:\n/sig network\nSome kube-proxy functionalities depends on conntrack, is it possible to run a conformance cluster without having conntrack enable?", "positive_passages": [{"docid": "doc-en-kubernetes-1ce92c7fe6f91d42961b73a51afd7509152cc14780da0e272f4b2eff59be4c7e", "text": "zero := int64(0) <ins> // Some distributions (Ubuntu 16.04 etc.) don't support the proc file. _, err := framework.IssueSSHCommandWithResult( \"ls /proc/net/nf_conntrack\", framework.TestContext.Provider, clientNodeInfo.node) if err != nil && strings.Contains(err.Error(), \"No such file or directory\") { framework.Skipf(\"The node %s does not support /proc/net/nf_conntrack\", clientNodeInfo.name) } framework.ExpectNoError(err) </ins> clientPodSpec := &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name:      \"e2e-net-client\",", "commid": "kubernetes_pr_69589"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d9fc51e2d19fb7f62f6dafef99b2750dc74c15fbc41108be6037bea54208ac", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: the for a CRDs Established condition is always null What you expected to happen: it should have a timestamp How to reproduce it (as minimally and precisely as possible): create a CRD and then examine its yaml/json. For example: Anything else we need to know?: Environment: community master\n/assign\n/area custom-resource\n/sig api-machinery /area custom-resources\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n/remove-lifecycle rotten\nedit: actually, that issue is about kubectl display and clock skew. this issue is about the condition timestamp updating, which still requires correction\nClosing this issue. <detailsIn response to : duplicate of Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHello I'm a bug triage shadow for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. Code freeze is starting on August 29th (about 3 days from now), which means that this PR must merged by then. Do we still target this issue to be fixed for 1.16?\nyes, will take a look at it tomorrow /assign", "positive_passages": [{"docid": "doc-en-kubernetes-125df28c642b7eb936b111f34778fcc0c323dbe8dd1dd83ec1fa66da5578706f", "text": "// SetCRDCondition sets the status condition. It either overwrites the existing one or creates a new one. func SetCRDCondition(crd *CustomResourceDefinition, newCondition CustomResourceDefinitionCondition) { <ins> newCondition.LastTransitionTime = metav1.NewTime(time.Now()) </ins> existingCondition := FindCRDCondition(crd, newCondition.Type) if existingCondition == nil { <del> newCondition.LastTransitionTime = metav1.NewTime(time.Now()) </del> crd.Status.Conditions = append(crd.Status.Conditions, newCondition) return } <del> if existingCondition.Status != newCondition.Status { existingCondition.Status = newCondition.Status </del> <ins> if existingCondition.Status != newCondition.Status || existingCondition.LastTransitionTime.IsZero() { </ins> existingCondition.LastTransitionTime = newCondition.LastTransitionTime } <ins> existingCondition.Status = newCondition.Status </ins> existingCondition.Reason = newCondition.Reason existingCondition.Message = newCondition.Message }", "commid": "kubernetes_pr_69655"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d9fc51e2d19fb7f62f6dafef99b2750dc74c15fbc41108be6037bea54208ac", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: the for a CRDs Established condition is always null What you expected to happen: it should have a timestamp How to reproduce it (as minimally and precisely as possible): create a CRD and then examine its yaml/json. For example: Anything else we need to know?: Environment: community master\n/assign\n/area custom-resource\n/sig api-machinery /area custom-resources\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n/remove-lifecycle rotten\nedit: actually, that issue is about kubectl display and clock skew. this issue is about the condition timestamp updating, which still requires correction\nClosing this issue. <detailsIn response to : duplicate of Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHello I'm a bug triage shadow for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. Code freeze is starting on August 29th (about 3 days from now), which means that this PR must merged by then. Do we still target this issue to be fixed for 1.16?\nyes, will take a look at it tomorrow /assign", "positive_passages": [{"docid": "doc-en-kubernetes-eef38b083633348d10e9ee018b017447c7fb3f8858a8064102551f33877e8422", "text": "}, }, }, <ins> { name: \"set new condition which doesn't have lastTransitionTime set\", crdCondition: []CustomResourceDefinitionCondition{ { Type:               Established, Status:             ConditionTrue, Reason:             \"Accepted\", Message:            \"the initial names have been accepted\", LastTransitionTime: metav1.Date(2018, 1, 1, 0, 0, 0, 0, time.UTC), }, }, newCondition: CustomResourceDefinitionCondition{ Type:    Established, Status:  ConditionFalse, Reason:  \"NotAccepted\", Message: \"Not accepted\", }, expectedcrdCondition: []CustomResourceDefinitionCondition{ { Type:               Established, Status:             ConditionFalse, Reason:             \"NotAccepted\", Message:            \"Not accepted\", LastTransitionTime: metav1.Date(2018, 1, 2, 0, 0, 0, 0, time.UTC), }, }, }, { name: \"append new condition which doesn't have lastTransitionTime set\", crdCondition: []CustomResourceDefinitionCondition{ { Type:               Established, Status:             ConditionTrue, Reason:             \"Accepted\", Message:            \"the initial names have been accepted\", LastTransitionTime: metav1.Date(2018, 1, 1, 0, 0, 0, 0, time.UTC), }, }, newCondition: CustomResourceDefinitionCondition{ Type:    Terminating, Status:  ConditionFalse, Reason:  \"NeverEstablished\", Message: \"resource was never established\", }, expectedcrdCondition: []CustomResourceDefinitionCondition{ { Type:               Established, Status:             ConditionTrue, Reason:             \"Accepted\", Message:            \"the initial names have been accepted\", LastTransitionTime: metav1.Date(2018, 1, 1, 0, 0, 0, 0, time.UTC), }, { Type:               Terminating, Status:             ConditionFalse, Reason:             \"NeverEstablished\", Message:            \"resource was never established\", LastTransitionTime: metav1.Date(2018, 2, 1, 0, 0, 0, 0, time.UTC), }, }, }, </ins> } for _, tc := range tests { crd := generateCRDwithCondition(tc.crdCondition)", "commid": "kubernetes_pr_69655"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d9fc51e2d19fb7f62f6dafef99b2750dc74c15fbc41108be6037bea54208ac", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: the for a CRDs Established condition is always null What you expected to happen: it should have a timestamp How to reproduce it (as minimally and precisely as possible): create a CRD and then examine its yaml/json. For example: Anything else we need to know?: Environment: community master\n/assign\n/area custom-resource\n/sig api-machinery /area custom-resources\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n/remove-lifecycle rotten\nedit: actually, that issue is about kubectl display and clock skew. this issue is about the condition timestamp updating, which still requires correction\nClosing this issue. <detailsIn response to : duplicate of Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHello I'm a bug triage shadow for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. Code freeze is starting on August 29th (about 3 days from now), which means that this PR must merged by then. Do we still target this issue to be fixed for 1.16?\nyes, will take a look at it tomorrow /assign", "positive_passages": [{"docid": "doc-en-kubernetes-b58a5fb4bd995f9f6d7f0e03bc86c9cb414b5f16be4bdebaf3b6add04085c6a8", "text": "if !IsCRDConditionEquivalent(&tc.expectedcrdCondition[i], &crd.Status.Conditions[i]) { t.Errorf(\"%v expected %v, got %v\", tc.name, tc.expectedcrdCondition, crd.Status.Conditions) } <ins> if crd.Status.Conditions[i].LastTransitionTime.IsZero() { t.Errorf(\"%q lastTransitionTime should not be null: %v\", tc.name, i, crd.Status.Conditions) } </ins> } } }", "commid": "kubernetes_pr_69655"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1aa2b788ee8dcf8d8598c7b30272a10240375971a3f4c89bc972fae10098a876", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Here's an example from an e2e test: What you expected to happen: leader election success logs to be at a higher log level.\nLeader election library is not a part of the scheduler. The scheduler is only a user of the library. It is located in client-go. It is currently . I am not sure if it is a good idea to reduce verbosity further. The log messages seem to be excessive in the scheduler logs when the scheduler is idle in our tests.\nI think this is a common problem for all components, not just for scheduler.\nIn that case, we should consider reducing its verbosity to 5 or 6.\nFor some reason I thought that this was something new but I went back to 1.9 tests and checked the logs and I also see it printed every 2 seconds. So maybe this is fine for test environments.\nThis is certainly not new, but I am still in favor of lowering it verbosity unless there is a good reason for having it in tests by default.\nI'm ok with changing the verbosity but the code now lives in the api-machinery land.\nI'd like to pick this up. Could I do that?\nThe log level seems correct following these guidelines: I am not sold on the value of glog's infinite log levels feature, however I could be convinced that our logging guidelines need a TRACE level.\nThank you for your response. I'm on your side, How about ?", "positive_passages": [{"docid": "doc-en-kubernetes-e6a60db10a9be8407fb3825141863922a07fb53284c91e5c01cfd2661ddd8c40", "text": "le.maybeReportTransition() desc := le.config.Lock.Describe() if err == nil { <del> glog.V(4).Infof(\"successfully renewed lease %v\", desc) </del> <ins> glog.V(5).Infof(\"successfully renewed lease %v\", desc) </ins> return } le.config.Lock.RecordEvent(\"stopped leading\")", "commid": "kubernetes_pr_70525"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-688a1363ab44b38e73304094013c6bfb676fae85b86e65acef0c6925731c996d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind cleanup What happened: In PR we tightened the --provider parameter checking of the binary such that it only accepted known providers. This turned out to be problematic () because people had started to depend on the previous behavior, which was to accept anything and merely warn about it. For the sake of giving people time to adapt, PR reverted to the older behavior. What you expected to happen: In 1.14 we want to allow only known providers. While at it, the error handling for unknown providers should be enhanced (print proper error message instead of calling Failf, which panics). /assign /sig testing\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nkubeadm was one of the tools which got broken by the tightening of the parameter checking. Does kubeadm still rely on the acceptance of unknown provider parameters or can the current warning be turned into an error now? /remove-lifecycle stale\nyes the kubernetes-anywhere deployer is still bound to provider=kubernetes-anywhere (unknown) in test infra jobs. we went back and forth on this topic, but if you wish to replace this support for unknown deployers i can switch those jobs to . LMK.\ngiven one release has passed with the deprecated message on the CLI, it's probably safe to remove this functionality now. :)\n\"Lubomir I. Ivanov\" <: Yes, please do. Once that is complete, I'll turn the warning into an error.\ndone:", "positive_passages": [{"docid": "doc-en-kubernetes-29de97240d7a10f7ef624203ca661e07a0431e33cc2ed890ba3af9ae586be447", "text": "providers[name] = factory } <ins> // GetProviders returns the names of all currently registered providers. func GetProviders() []string { mutex.Lock() defer mutex.Unlock() var providerNames []string for name := range providers { providerNames = append(providerNames, name) } return providerNames } </ins> func init() { // \"local\" or \"skeleton\" can always be used. RegisterProvider(\"local\", func() (ProviderInterface, error) {", "commid": "kubernetes_pr_73402"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-688a1363ab44b38e73304094013c6bfb676fae85b86e65acef0c6925731c996d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind cleanup What happened: In PR we tightened the --provider parameter checking of the binary such that it only accepted known providers. This turned out to be problematic () because people had started to depend on the previous behavior, which was to accept anything and merely warn about it. For the sake of giving people time to adapt, PR reverted to the older behavior. What you expected to happen: In 1.14 we want to allow only known providers. While at it, the error handling for unknown providers should be enhanced (print proper error message instead of calling Failf, which panics). /assign /sig testing\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nkubeadm was one of the tools which got broken by the tightening of the parameter checking. Does kubeadm still rely on the acceptance of unknown provider parameters or can the current warning be turned into an error now? /remove-lifecycle stale\nyes the kubernetes-anywhere deployer is still bound to provider=kubernetes-anywhere (unknown) in test infra jobs. we went back and forth on this topic, but if you wish to replace this support for unknown deployers i can switch those jobs to . LMK.\ngiven one release has passed with the deprecated message on the CLI, it's probably safe to remove this functionality now. :)\n\"Lubomir I. Ivanov\" <: Yes, please do. Once that is complete, I'll turn the warning into an error.\ndone:", "positive_passages": [{"docid": "doc-en-kubernetes-99c4c93d3c6d8012cef00c15ef0e1058168a071191d33f12843c0ee2810ee25d", "text": "RegisterProvider(\"skeleton\", func() (ProviderInterface, error) { return NullProvider{}, nil }) <del> // The empty string also works, but triggers a warning. RegisterProvider(\"\", func() (ProviderInterface, error) { Logf(\"The --provider flag is not set.  Treating as a conformance test.  Some tests may not be run.\") return NullProvider{}, nil }) </del> <ins> // The empty string used to be accepted in the past, but is not // a valid value anymore. </ins> } // SetupProviderConfig validates the chosen provider and creates", "commid": "kubernetes_pr_73402"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-688a1363ab44b38e73304094013c6bfb676fae85b86e65acef0c6925731c996d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind cleanup What happened: In PR we tightened the --provider parameter checking of the binary such that it only accepted known providers. This turned out to be problematic () because people had started to depend on the previous behavior, which was to accept anything and merely warn about it. For the sake of giving people time to adapt, PR reverted to the older behavior. What you expected to happen: In 1.14 we want to allow only known providers. While at it, the error handling for unknown providers should be enhanced (print proper error message instead of calling Failf, which panics). /assign /sig testing\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nkubeadm was one of the tools which got broken by the tightening of the parameter checking. Does kubeadm still rely on the acceptance of unknown provider parameters or can the current warning be turned into an error now? /remove-lifecycle stale\nyes the kubernetes-anywhere deployer is still bound to provider=kubernetes-anywhere (unknown) in test infra jobs. we went back and forth on this topic, but if you wish to replace this support for unknown deployers i can switch those jobs to . LMK.\ngiven one release has passed with the deprecated message on the CLI, it's probably safe to remove this functionality now. :)\n\"Lubomir I. Ivanov\" <: Yes, please do. Once that is complete, I'll turn the warning into an error.\ndone:", "positive_passages": [{"docid": "doc-en-kubernetes-7dd70bac96f71bc3257af2c97318482ef425c2698ba1fa9ffdda73a923427fcd", "text": "\"fmt\" \"io/ioutil\" \"os\" <ins> \"sort\" \"strings\" </ins> \"time\" \"github.com/onsi/ginkgo/config\"", "commid": "kubernetes_pr_73402"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-688a1363ab44b38e73304094013c6bfb676fae85b86e65acef0c6925731c996d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind cleanup What happened: In PR we tightened the --provider parameter checking of the binary such that it only accepted known providers. This turned out to be problematic () because people had started to depend on the previous behavior, which was to accept anything and merely warn about it. For the sake of giving people time to adapt, PR reverted to the older behavior. What you expected to happen: In 1.14 we want to allow only known providers. While at it, the error handling for unknown providers should be enhanced (print proper error message instead of calling Failf, which panics). /assign /sig testing\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nkubeadm was one of the tools which got broken by the tightening of the parameter checking. Does kubeadm still rely on the acceptance of unknown provider parameters or can the current warning be turned into an error now? /remove-lifecycle stale\nyes the kubernetes-anywhere deployer is still bound to provider=kubernetes-anywhere (unknown) in test infra jobs. we went back and forth on this topic, but if you wish to replace this support for unknown deployers i can switch those jobs to . LMK.\ngiven one release has passed with the deprecated message on the CLI, it's probably safe to remove this functionality now. :)\n\"Lubomir I. Ivanov\" <: Yes, please do. Once that is complete, I'll turn the warning into an error.\ndone:", "positive_passages": [{"docid": "doc-en-kubernetes-d1cc82801e6e626c849b1beecd39daea491429f7c706dc4aec3bb367c67887c3", "text": "flag.StringVar(&TestContext.KubeVolumeDir, \"volume-dir\", \"/var/lib/kubelet\", \"Path to the directory containing the kubelet volumes.\") flag.StringVar(&TestContext.CertDir, \"cert-dir\", \"\", \"Path to the directory containing the certs. Default is empty, which doesn't use certs.\") flag.StringVar(&TestContext.RepoRoot, \"repo-root\", \"../../\", \"Root directory of kubernetes repository, for finding test files.\") <del> flag.StringVar(&TestContext.Provider, \"provider\", \"\", \"The name of the Kubernetes provider (gce, gke, local, etc.)\") </del> <ins> flag.StringVar(&TestContext.Provider, \"provider\", \"\", \"The name of the Kubernetes provider (gce, gke, local, skeleton (the fallback if not set), etc.)\") </ins> flag.StringVar(&TestContext.Tooling, \"tooling\", \"\", \"The tooling in use (kops, gke, etc.)\") flag.StringVar(&TestContext.KubectlPath, \"kubectl-path\", \"kubectl\", \"The kubectl binary to use. For development, you might use 'cluster/kubectl.sh' here.\") flag.StringVar(&TestContext.OutputDir, \"e2e-output-dir\", \"/tmp\", \"Output directory for interesting/useful test data, like performance data, benchmarks, and other metrics.\")", "commid": "kubernetes_pr_73402"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-688a1363ab44b38e73304094013c6bfb676fae85b86e65acef0c6925731c996d", "query": "<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind cleanup What happened: In PR we tightened the --provider parameter checking of the binary such that it only accepted known providers. This turned out to be problematic () because people had started to depend on the previous behavior, which was to accept anything and merely warn about it. For the sake of giving people time to adapt, PR reverted to the older behavior. What you expected to happen: In 1.14 we want to allow only known providers. While at it, the error handling for unknown providers should be enhanced (print proper error message instead of calling Failf, which panics). /assign /sig testing\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nkubeadm was one of the tools which got broken by the tightening of the parameter checking. Does kubeadm still rely on the acceptance of unknown provider parameters or can the current warning be turned into an error now? /remove-lifecycle stale\nyes the kubernetes-anywhere deployer is still bound to provider=kubernetes-anywhere (unknown) in test infra jobs. we went back and forth on this topic, but if you wish to replace this support for unknown deployers i can switch those jobs to . LMK.\ngiven one release has passed with the deprecated message on the CLI, it's probably safe to remove this functionality now. :)\n\"Lubomir I. Ivanov\" <: Yes, please do. Once that is complete, I'll turn the warning into an error.\ndone:", "positive_passages": [{"docid": "doc-en-kubernetes-3124eee514432c0429af63b0ab4ebe9c9c9b06b066f3504991cb7d4e3d771f07", "text": "} // Make sure that all test runs have a valid TestContext.CloudConfig.Provider. <ins> // TODO: whether and how long this code is needed is getting discussed // in https://github.com/kubernetes/kubernetes/issues/70194. if TestContext.Provider == \"\" { // Some users of the e2e.test binary pass --provider=. // We need to support that, changing it would break those usages. Logf(\"The --provider flag is not set. Continuing as if --provider=skeleton had been used.\") TestContext.Provider = \"skeleton\" } </ins> var err error TestContext.CloudConfig.Provider, err = SetupProviderConfig(TestContext.Provider) <del> if err == nil { return } if !os.IsNotExist(errors.Cause(err)) { Failf(\"Failed to setup provider config: %v\", err) } // We allow unknown provider parameters for historic reasons. At least log a // warning to catch typos. // TODO (https://github.com/kubernetes/kubernetes/issues/70200): // - remove the fallback for unknown providers // - proper error message instead of Failf (which panics) klog.Warningf(\"Unknown provider %q, proceeding as for --provider=skeleton.\", TestContext.Provider) TestContext.CloudConfig.Provider, err = SetupProviderConfig(\"skeleton\") </del> if err != nil { <del> Failf(\"Failed to setup fallback skeleton provider config: %v\", err) </del> <ins> if os.IsNotExist(errors.Cause(err)) { // Provide a more helpful error message when the provider is unknown. var providers []string for _, name := range GetProviders() { // The empty string is accepted, but looks odd in the output below unless we quote it. if name == \"\" { name = `\"\"` } providers = append(providers, name) } sort.Strings(providers) klog.Errorf(\"Unknown provider %q. The following providers are known: %v\", TestContext.Provider, strings.Join(providers, \" \")) } else { klog.Errorf(\"Failed to setup provider config for %q: %v\", TestContext.Provider, err) } os.Exit(1) </ins> } }", "commid": "kubernetes_pr_73402"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fcc3a4f0546a69a996e9acca03b96cb5d6a4520581f6771770c5248bc191f84b", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : a new addon to addon manager \"that automatically installs CSI CRDs if CSIDriverRegistry or CSINodeInfo feature gates are true\". But this is either broken or this addon manager isn't active in a cluster brough up with: This should work automatically also for such local clusters. Why is this needed: The CSI E2E tests are now expecting that the cluster has the CRDs and fail when that isn't the case. /kind feature (or perhaps a bug, not sure) /cc\n/assign\nIs this expected to be installed in other clusters? A lot of clusters are not going to be using cluster/* scripts.", "positive_passages": [{"docid": "doc-en-kubernetes-f49c9900400c30aa4775b00ea9fb1cc29dbdb798c10e6a9d886919ada25d0edf", "text": "fi } <ins> create_csi_crd() { echo \"create_csi_crd $1\" YAML_FILE=${KUBE_ROOT}/cluster/addons/storage-crds/$1.yaml if [ -e $YAML_FILE ]; then echo \"Create $1 crd\" ${KUBECTL} --kubeconfig=\"${CERT_DIR}/admin.kubeconfig\" create -f $YAML_FILE else echo \"No $1 available.\" fi } </ins> function print_success { if [[ \"${START_MODE}\" != \"kubeletonly\" ]]; then if [[ \"${ENABLE_DAEMON}\" = false ]]; then", "commid": "kubernetes_pr_72584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fcc3a4f0546a69a996e9acca03b96cb5d6a4520581f6771770c5248bc191f84b", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : a new addon to addon manager \"that automatically installs CSI CRDs if CSIDriverRegistry or CSINodeInfo feature gates are true\". But this is either broken or this addon manager isn't active in a cluster brough up with: This should work automatically also for such local clusters. Why is this needed: The CSI E2E tests are now expecting that the cluster has the CRDs and fail when that isn't the case. /kind feature (or perhaps a bug, not sure) /cc\n/assign\nIs this expected to be installed in other clusters? A lot of clusters are not going to be using cluster/* scripts.", "positive_passages": [{"docid": "doc-en-kubernetes-d6ef28cf1336cc67d04e4280ac9995ecd9e782a7f778877d52acabe986246609", "text": "create_storage_class fi <ins> if [[ \"${FEATURE_GATES:-}\" == \"AllAlpha=true\" || \"${FEATURE_GATES:-}\" =~ \"CSIDriverRegistry=true\" ]]; then create_csi_crd \"csidriver\" fi if [[ \"${FEATURE_GATES:-}\" == \"AllAlpha=true\" || \"${FEATURE_GATES:-}\" =~ \"CSINodeInfo=true\" ]]; then create_csi_crd \"csinodeinfo\" fi </ins> print_success if [[ \"${ENABLE_DAEMON}\" = false ]]; then", "commid": "kubernetes_pr_72584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-78b37d9fe8b38ac1317f8aaccb649830f24b3fef9915f4a2195d4feb676a7b80", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: gce-new-master-upgrade-cluster-new-parallel Which test(s) are failing: Varies, but all subpath failures, including: [sig-storage] CSI Volumes [Driver: csi-hostpath-v0] [Testpattern: Dynamic PV (default fs)] subPath should fail if subpath with backstepping is outside the volume [Slow] [sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: Dynamic PV (default fs)] subPath should fail if subpath directory is outside the volume [Slow] [sig-storage] CSI Volumes [Driver: csi-hostpath-v0] [Testpattern: Dynamic PV (default fs)] subPath should fail if subpath file is outside the volume [Slow] [sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: Dynamic PV (default fs)] subPath should fail if subpath file is outside the volume [Slow] ... and pretty much every other subpath test, but never all of them at once. There's also a few other storage tests failing, such as: [sig-storage] Volume expand [Slow] Verify if editing PVC allows resize [sig-storage] Detaching volumes should not work when mount is in progress Since when has it been failing: 11/22 Testgrid link: https://k8s- Reason for failure: These flakes started around the time that merged, but doesn't match up with the exact merge stamp, so it's probably coincidental. The subpath test failures seem to be mostly timeouts: ... so possibly this is just GCE fail. Anything else we need to know: This test job has always been flaky, with around a 40% failure rate. <!-- DO NOT EDIT BELOW THIS LINE --/kind flake /sig storage /priority important-soon cc\ncan you please help investigate this. It looks to me like the tests are flaking for and . I wonder if the v0 tests are racing with the non-v0 tests for something in this test?\nThe other tests including for the other CSI driver and non-CSI in-tree plugins are solid green which also makes me think this is a issue with the hostpath tests or driver.\n(just adding additional similar flakes here for tracking) Similar flakes in :\nadding to the milestone for triage since the flakes look new\nThese all 4 subpath tests call and it fails in finding a specific failed event by using . As uses to check if the specific error event happens, and , I guess that tests may flake if other failed event happens before the expected one. Also, already wait for the event, we might be able to delete  in . I will create a PR to fix above.\n/priority critical-urgent /remove-priority important-soon /milestone v1.13\nwhile we should update the test with your PR, I'm not sure if it's going to fix the failure. Looking at one failing test log, these are the events I see on the failing pod: So it seems to be failing before even reaching the subpath logic.\nTimeline of events: Test pod started getting processed by kubelet: It took a minute after the test pod was created for the csi driver to finish registering and mount to succeed, and then subpath event to trigger: So should address the issue. I was initially confused because the test logs didn't show the subpath event for some reason\nI opened up to investigate if 1 minute for csi plugin registration is expected\nI've a tracker issue for the complete list of storage flakes: This is so that we can track whether we're addressing most of the flakes with the subpath fixes, or if additional fixes are required.\nkeeping open until flakes are verified cleaned up\n/reopen Reopening this issue until we can verify the fix in CI\nAs of this morning we are seeing CSI \"subpath should fail\" flakes in the following job Multiple \"subpath should fail\" flakes in this slow job alone Multiple \"subpath should fail\" flakes in the 1.13 slow job, similar to master. The following 2 tests are flaky only in this upgrade job can you help us determine if these are cases are flaky tests that you are fixing or is there an underlying CSI bug that needs addressing?\nroot cause of this is a delay in an external sidecar containers and the tests not waiting long enough to accommodate the delay. There are no changes required in (outside of test) to handle this. These should not be 1.13 blocking. We'll continue to look in to getting them non-flaky today. In the meantime, we can mark these tests as flaky to reduce the noise, if you'd like. looks like the same issue () is still being hit. See : And logs from (): We need to make the tests handle this condition more gracefully. The suggestion here is one possible solution.\nWould be good to capture this as a known issue in release notes.\nto followup on capturing this in Release notes\nper , can you create a targeted fix increasing the timeout? Looks like marking these tests as flaky will be difficult for 1.13, but if that doesn't fix it we will need to do that.\nShort term fix to bump the test timeout:\nAs per discussion in release burndown meeting, this is not a 1.13 blocker. please move this issue to 1.14 if there are no pending issues you are concerned about\nOk looks like the test still flaked. Looking at , the mount succeeded after a minute and proceeded to subpath processing, which (correctly) failed. However, for some resaon, the test is not seeing the subpath event and still failed after 4 minutes. On kubelet, subpath processing failed after a minute and generated the event: But the test doesn't see it for some reason, and still times out after 4 more minutes:\nI saw the same on CSI volume mount succeeded at: Kubelet correctly failed the pod because of subpath But test still failed: Because the test failed to find the pod event. This looks like a test issue. Not a 1.13 blocker.\ncan you PTAL at this\nIs there a way to check if events are overloaded and not able to handle new events? The MountVolume retries while the driver is not registered is very frequent and could have overloaded the event server.\nChecking for the existence of an event seems like the wrong way to test this. Would checking pod status alone be insufficient? Ultimately that is what we really care about.\nChecking for the specific event guarantees that we are failing with the correct error. But perhaps events are not reliable enough to depend on. Checking if the Pod never came up running would probably reduce the flakes but could potentially mask false negatives. cc for any thoughts.\nTests are still flaking and actually it seems like in general storage flakes in slow are flaking more since 11-21 or so: https://k8s- My theory is that the driver registration delay is causing a flood of events, which causes tests that check for events to fail. I think this is revealing multiple issues in both the tests and product, and we should work on fixing them all, although any one of the fixes should mitigate the test flakes: Driver registrar can sometimes take a minute to come up: Volume manager operation executor doesn't seem to be throttling retries or backing off: Tests should not rely on events: Tests should wait for CSI driver to be registered on all nodes before creating test pods:\nand have been merged and will address the biggest issues. has been backported to 1.13 already, backport is still pending.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-36d1af981a2f7a57e56c0f0505737bcf02eee1720f902b1faa15386fba0c2527", "text": "if err != nil { return false, fmt.Errorf(\"got error while getting pod events: %s\", err) } <del> if len(events.Items) == 0 { return false, nil // no events have occurred yet </del> <ins> for _, event := range events.Items { if strings.Contains(event.Message, msg) { return true, nil } </ins> } <del> return strings.Contains(events.Items[0].Message, msg), nil </del> <ins> return false, nil </ins> } }", "commid": "kubernetes_pr_71428"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-78b37d9fe8b38ac1317f8aaccb649830f24b3fef9915f4a2195d4feb676a7b80", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: gce-new-master-upgrade-cluster-new-parallel Which test(s) are failing: Varies, but all subpath failures, including: [sig-storage] CSI Volumes [Driver: csi-hostpath-v0] [Testpattern: Dynamic PV (default fs)] subPath should fail if subpath with backstepping is outside the volume [Slow] [sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: Dynamic PV (default fs)] subPath should fail if subpath directory is outside the volume [Slow] [sig-storage] CSI Volumes [Driver: csi-hostpath-v0] [Testpattern: Dynamic PV (default fs)] subPath should fail if subpath file is outside the volume [Slow] [sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: Dynamic PV (default fs)] subPath should fail if subpath file is outside the volume [Slow] ... and pretty much every other subpath test, but never all of them at once. There's also a few other storage tests failing, such as: [sig-storage] Volume expand [Slow] Verify if editing PVC allows resize [sig-storage] Detaching volumes should not work when mount is in progress Since when has it been failing: 11/22 Testgrid link: https://k8s- Reason for failure: These flakes started around the time that merged, but doesn't match up with the exact merge stamp, so it's probably coincidental. The subpath test failures seem to be mostly timeouts: ... so possibly this is just GCE fail. Anything else we need to know: This test job has always been flaky, with around a 40% failure rate. <!-- DO NOT EDIT BELOW THIS LINE --/kind flake /sig storage /priority important-soon cc\ncan you please help investigate this. It looks to me like the tests are flaking for and . I wonder if the v0 tests are racing with the non-v0 tests for something in this test?\nThe other tests including for the other CSI driver and non-CSI in-tree plugins are solid green which also makes me think this is a issue with the hostpath tests or driver.\n(just adding additional similar flakes here for tracking) Similar flakes in :\nadding to the milestone for triage since the flakes look new\nThese all 4 subpath tests call and it fails in finding a specific failed event by using . As uses to check if the specific error event happens, and , I guess that tests may flake if other failed event happens before the expected one. Also, already wait for the event, we might be able to delete  in . I will create a PR to fix above.\n/priority critical-urgent /remove-priority important-soon /milestone v1.13\nwhile we should update the test with your PR, I'm not sure if it's going to fix the failure. Looking at one failing test log, these are the events I see on the failing pod: So it seems to be failing before even reaching the subpath logic.\nTimeline of events: Test pod started getting processed by kubelet: It took a minute after the test pod was created for the csi driver to finish registering and mount to succeed, and then subpath event to trigger: So should address the issue. I was initially confused because the test logs didn't show the subpath event for some reason\nI opened up to investigate if 1 minute for csi plugin registration is expected\nI've a tracker issue for the complete list of storage flakes: This is so that we can track whether we're addressing most of the flakes with the subpath fixes, or if additional fixes are required.\nkeeping open until flakes are verified cleaned up\n/reopen Reopening this issue until we can verify the fix in CI\nAs of this morning we are seeing CSI \"subpath should fail\" flakes in the following job Multiple \"subpath should fail\" flakes in this slow job alone Multiple \"subpath should fail\" flakes in the 1.13 slow job, similar to master. The following 2 tests are flaky only in this upgrade job can you help us determine if these are cases are flaky tests that you are fixing or is there an underlying CSI bug that needs addressing?\nroot cause of this is a delay in an external sidecar containers and the tests not waiting long enough to accommodate the delay. There are no changes required in (outside of test) to handle this. These should not be 1.13 blocking. We'll continue to look in to getting them non-flaky today. In the meantime, we can mark these tests as flaky to reduce the noise, if you'd like. looks like the same issue () is still being hit. See : And logs from (): We need to make the tests handle this condition more gracefully. The suggestion here is one possible solution.\nWould be good to capture this as a known issue in release notes.\nto followup on capturing this in Release notes\nper , can you create a targeted fix increasing the timeout? Looks like marking these tests as flaky will be difficult for 1.13, but if that doesn't fix it we will need to do that.\nShort term fix to bump the test timeout:\nAs per discussion in release burndown meeting, this is not a 1.13 blocker. please move this issue to 1.14 if there are no pending issues you are concerned about\nOk looks like the test still flaked. Looking at , the mount succeeded after a minute and proceeded to subpath processing, which (correctly) failed. However, for some resaon, the test is not seeing the subpath event and still failed after 4 minutes. On kubelet, subpath processing failed after a minute and generated the event: But the test doesn't see it for some reason, and still times out after 4 more minutes:\nI saw the same on CSI volume mount succeeded at: Kubelet correctly failed the pod because of subpath But test still failed: Because the test failed to find the pod event. This looks like a test issue. Not a 1.13 blocker.\ncan you PTAL at this\nIs there a way to check if events are overloaded and not able to handle new events? The MountVolume retries while the driver is not registered is very frequent and could have overloaded the event server.\nChecking for the existence of an event seems like the wrong way to test this. Would checking pod status alone be insufficient? Ultimately that is what we really care about.\nChecking for the specific event guarantees that we are failing with the correct error. But perhaps events are not reliable enough to depend on. Checking if the Pod never came up running would probably reduce the flakes but could potentially mask false negatives. cc for any thoughts.\nTests are still flaking and actually it seems like in general storage flakes in slow are flaking more since 11-21 or so: https://k8s- My theory is that the driver registration delay is causing a flood of events, which causes tests that check for events to fail. I think this is revealing multiple issues in both the tests and product, and we should work on fixing them all, although any one of the fixes should mitigate the test flakes: Driver registrar can sometimes take a minute to come up: Volume manager operation executor doesn't seem to be throttling retries or backing off: Tests should not rely on events: Tests should wait for CSI driver to be registered on all nodes before creating test pods:\nand have been merged and will address the biggest issues. has been backported to 1.13 already, backport is still pending.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-0a352af816a32a2c80d4209d9be04de73012cbc63c9d2c41388b6f4f9d33e893", "text": "defer func() { framework.DeletePodWithWait(f, f.ClientSet, pod) }() <del> err = framework.WaitForPodRunningInNamespace(f.ClientSet, pod) Expect(err).To(HaveOccurred(), \"while waiting for pod to be running\") </del> By(\"Checking for subpath error event\") selector := fields.Set{", "commid": "kubernetes_pr_71428"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-654ece199003f278d006ccf57d00b1bb1a0a4ea2c01afabbffd3256d622e5402", "query": "What happened: POST or PUT to a custom resource with a JSON body missing \"kind\" results in a 500 error: A missing \"apiVersion\" also results in a 500 error: Then with both \"kind\" and \"apiVersion\" defined we get the normal 4XX return codes. What you expected to happen: All bad inputs for create and update requests should be 4XX return codes. E.g. Creating a with body of results in the 422 error: How to reproduce it: Create a CRD or use a cluster that already has a one prepared (GKE 1.11.0+ clusters have the CRD installed which you could test against). HTTP to that custom resource with a JSON body of . E.g. Environment: Kubernetes version (use ): 1.11.2 Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): Kernel (e.g. ): /sig api-machinery <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThis is fixed on master, but I can reproduce it on 1.11. Posting a custom resource with a JSON body of : on master: on 1.11:\nwe are transforming all non-status error into 500 status error. in this case, it's the decoder returning a which is non-status. a quick fix by . (i like this number)\ninstead of fixed, it's rather been shadowed by i suppose. now when that empty unstructured obj going thru the decoder, the gvk is explicitly coerced, so this case is not reproducable on master for now.\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nI get the same response when trying to update the custom resource's 'status' sub-resource. On k8s v1.11.4\n/assign\nsubmitting the specified object on master returns a 400 badrequest, as desired /close\nClosing this issue. <detailsIn response to : submitting the specified object on master returns a 400 badrequest, as desired Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-70583c087c4cd896be9ecc635a74d36e7845959bd66534b055dc431dd82b57ec", "text": "\"//staging/src/k8s.io/apimachinery/pkg/api/meta:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured:go_default_library\", <ins> \"//staging/src/k8s.io/apimachinery/pkg/apis/testapigroup/v1:go_default_library\", </ins> \"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/runtime/schema:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/runtime/serializer:go_default_library\",", "commid": "kubernetes_pr_71500"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-654ece199003f278d006ccf57d00b1bb1a0a4ea2c01afabbffd3256d622e5402", "query": "What happened: POST or PUT to a custom resource with a JSON body missing \"kind\" results in a 500 error: A missing \"apiVersion\" also results in a 500 error: Then with both \"kind\" and \"apiVersion\" defined we get the normal 4XX return codes. What you expected to happen: All bad inputs for create and update requests should be 4XX return codes. E.g. Creating a with body of results in the 422 error: How to reproduce it: Create a CRD or use a cluster that already has a one prepared (GKE 1.11.0+ clusters have the CRD installed which you could test against). HTTP to that custom resource with a JSON body of . E.g. Environment: Kubernetes version (use ): 1.11.2 Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): Kernel (e.g. ): /sig api-machinery <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThis is fixed on master, but I can reproduce it on 1.11. Posting a custom resource with a JSON body of : on master: on 1.11:\nwe are transforming all non-status error into 500 status error. in this case, it's the decoder returning a which is non-status. a quick fix by . (i like this number)\ninstead of fixed, it's rather been shadowed by i suppose. now when that empty unstructured obj going thru the decoder, the gvk is explicitly coerced, so this case is not reproducable on master for now.\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nI get the same response when trying to update the custom resource's 'status' sub-resource. On k8s v1.11.4\n/assign\nsubmitting the specified object on master returns a 400 badrequest, as desired /close\nClosing this issue. <detailsIn response to : submitting the specified object on master returns a 400 badrequest, as desired Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-cdb2c4511f17e094806e2e334ef0e3a77ab73e04e7fcf40e04726d7f537dbf61", "text": "\"//staging/src/k8s.io/apiserver/pkg/apis/example/v1:go_default_library\", \"//staging/src/k8s.io/apiserver/pkg/endpoints/request:go_default_library\", \"//staging/src/k8s.io/apiserver/pkg/registry/rest:go_default_library\", <ins> \"//staging/src/k8s.io/client-go/kubernetes/scheme:go_default_library\", </ins> \"//vendor/github.com/evanphx/json-patch:go_default_library\", \"//vendor/github.com/google/gofuzz:go_default_library\", \"//vendor/k8s.io/utils/trace:go_default_library\",", "commid": "kubernetes_pr_71500"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-654ece199003f278d006ccf57d00b1bb1a0a4ea2c01afabbffd3256d622e5402", "query": "What happened: POST or PUT to a custom resource with a JSON body missing \"kind\" results in a 500 error: A missing \"apiVersion\" also results in a 500 error: Then with both \"kind\" and \"apiVersion\" defined we get the normal 4XX return codes. What you expected to happen: All bad inputs for create and update requests should be 4XX return codes. E.g. Creating a with body of results in the 422 error: How to reproduce it: Create a CRD or use a cluster that already has a one prepared (GKE 1.11.0+ clusters have the CRD installed which you could test against). HTTP to that custom resource with a JSON body of . E.g. Environment: Kubernetes version (use ): 1.11.2 Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): Kernel (e.g. ): /sig api-machinery <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThis is fixed on master, but I can reproduce it on 1.11. Posting a custom resource with a JSON body of : on master: on 1.11:\nwe are transforming all non-status error into 500 status error. in this case, it's the decoder returning a which is non-status. a quick fix by . (i like this number)\ninstead of fixed, it's rather been shadowed by i suppose. now when that empty unstructured obj going thru the decoder, the gvk is explicitly coerced, so this case is not reproducable on master for now.\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nI get the same response when trying to update the custom resource's 'status' sub-resource. On k8s v1.11.4\n/assign\nsubmitting the specified object on master returns a 400 badrequest, as desired /close\nClosing this issue. <detailsIn response to : submitting the specified object on master returns a 400 badrequest, as desired Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-15b772c5e1fc947582c5e39f1ea17577ab3a44afa1f2340054486a40d35f3e7d", "text": "} } <del> // transformDecodeError adds additional information when a decode fails. </del> <ins> // transformDecodeError adds additional information into a bad-request api error when a decode fails. </ins> func transformDecodeError(typer runtime.ObjectTyper, baseErr error, into runtime.Object, gvk *schema.GroupVersionKind, body []byte) error { objGVKs, _, err := typer.ObjectKinds(into) if err != nil { <del> return err </del> <ins> return errors.NewBadRequest(err.Error()) </ins> } objGVK := objGVKs[0] if gvk != nil && len(gvk.Kind) > 0 {", "commid": "kubernetes_pr_71500"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-654ece199003f278d006ccf57d00b1bb1a0a4ea2c01afabbffd3256d622e5402", "query": "What happened: POST or PUT to a custom resource with a JSON body missing \"kind\" results in a 500 error: A missing \"apiVersion\" also results in a 500 error: Then with both \"kind\" and \"apiVersion\" defined we get the normal 4XX return codes. What you expected to happen: All bad inputs for create and update requests should be 4XX return codes. E.g. Creating a with body of results in the 422 error: How to reproduce it: Create a CRD or use a cluster that already has a one prepared (GKE 1.11.0+ clusters have the CRD installed which you could test against). HTTP to that custom resource with a JSON body of . E.g. Environment: Kubernetes version (use ): 1.11.2 Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): Kernel (e.g. ): /sig api-machinery <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThis is fixed on master, but I can reproduce it on 1.11. Posting a custom resource with a JSON body of : on master: on 1.11:\nwe are transforming all non-status error into 500 status error. in this case, it's the decoder returning a which is non-status. a quick fix by . (i like this number)\ninstead of fixed, it's rather been shadowed by i suppose. now when that empty unstructured obj going thru the decoder, the gvk is explicitly coerced, so this case is not reproducable on master for now.\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nI get the same response when trying to update the custom resource's 'status' sub-resource. On k8s v1.11.4\n/assign\nsubmitting the specified object on master returns a 400 badrequest, as desired /close\nClosing this issue. <detailsIn response to : submitting the specified object on master returns a 400 badrequest, as desired Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-250c8253cd30053bbfd15615d7bbbc7be40dda9fa60f398b220bd16e512780ca", "text": "apierrors \"k8s.io/apimachinery/pkg/api/errors\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured\" <ins> testapigroupv1 \"k8s.io/apimachinery/pkg/apis/testapigroup/v1\" </ins> \"k8s.io/apimachinery/pkg/runtime\" \"k8s.io/apimachinery/pkg/runtime/schema\" \"k8s.io/apimachinery/pkg/runtime/serializer\"", "commid": "kubernetes_pr_71500"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-654ece199003f278d006ccf57d00b1bb1a0a4ea2c01afabbffd3256d622e5402", "query": "What happened: POST or PUT to a custom resource with a JSON body missing \"kind\" results in a 500 error: A missing \"apiVersion\" also results in a 500 error: Then with both \"kind\" and \"apiVersion\" defined we get the normal 4XX return codes. What you expected to happen: All bad inputs for create and update requests should be 4XX return codes. E.g. Creating a with body of results in the 422 error: How to reproduce it: Create a CRD or use a cluster that already has a one prepared (GKE 1.11.0+ clusters have the CRD installed which you could test against). HTTP to that custom resource with a JSON body of . E.g. Environment: Kubernetes version (use ): 1.11.2 Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): Kernel (e.g. ): /sig api-machinery <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThis is fixed on master, but I can reproduce it on 1.11. Posting a custom resource with a JSON body of : on master: on 1.11:\nwe are transforming all non-status error into 500 status error. in this case, it's the decoder returning a which is non-status. a quick fix by . (i like this number)\ninstead of fixed, it's rather been shadowed by i suppose. now when that empty unstructured obj going thru the decoder, the gvk is explicitly coerced, so this case is not reproducable on master for now.\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nI get the same response when trying to update the custom resource's 'status' sub-resource. On k8s v1.11.4\n/assign\nsubmitting the specified object on master returns a 400 badrequest, as desired /close\nClosing this issue. <detailsIn response to : submitting the specified object on master returns a 400 badrequest, as desired Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-6a0898daa82b8b906c547fbee05894a764e57462587318f6a2970aac3c0e79b6", "text": "examplev1 \"k8s.io/apiserver/pkg/apis/example/v1\" \"k8s.io/apiserver/pkg/endpoints/request\" \"k8s.io/apiserver/pkg/registry/rest\" <ins> clientgoscheme \"k8s.io/client-go/kubernetes/scheme\" </ins> utiltrace \"k8s.io/utils/trace\" )", "commid": "kubernetes_pr_71500"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-654ece199003f278d006ccf57d00b1bb1a0a4ea2c01afabbffd3256d622e5402", "query": "What happened: POST or PUT to a custom resource with a JSON body missing \"kind\" results in a 500 error: A missing \"apiVersion\" also results in a 500 error: Then with both \"kind\" and \"apiVersion\" defined we get the normal 4XX return codes. What you expected to happen: All bad inputs for create and update requests should be 4XX return codes. E.g. Creating a with body of results in the 422 error: How to reproduce it: Create a CRD or use a cluster that already has a one prepared (GKE 1.11.0+ clusters have the CRD installed which you could test against). HTTP to that custom resource with a JSON body of . E.g. Environment: Kubernetes version (use ): 1.11.2 Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): Kernel (e.g. ): /sig api-machinery <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThis is fixed on master, but I can reproduce it on 1.11. Posting a custom resource with a JSON body of : on master: on 1.11:\nwe are transforming all non-status error into 500 status error. in this case, it's the decoder returning a which is non-status. a quick fix by . (i like this number)\ninstead of fixed, it's rather been shadowed by i suppose. now when that empty unstructured obj going thru the decoder, the gvk is explicitly coerced, so this case is not reproducable on master for now.\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nI get the same response when trying to update the custom resource's 'status' sub-resource. On k8s v1.11.4\n/assign\nsubmitting the specified object on master returns a 400 badrequest, as desired /close\nClosing this issue. <detailsIn response to : submitting the specified object on master returns a 400 badrequest, as desired Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-a14fcfa40f75cd92a0f2e4cf3f99f7a8e3447924dcf26ced31e77024444e3488", "text": "func (f mutateObjectUpdateFunc) Admit(a admission.Attributes, o admission.ObjectInterfaces) (err error) { return f(a.GetObject(), a.GetOldObject()) } <ins> func TestTransformDecodeErrorEnsuresBadRequestError(t *testing.T) { testCases := []struct { name             string typer            runtime.ObjectTyper decodedGVK       *schema.GroupVersionKind decodeIntoObject runtime.Object baseErr          error expectedErr      error }{ { name:  \"decoding normal objects fails and returns a bad-request error\", typer: clientgoscheme.Scheme, decodedGVK: &schema.GroupVersionKind{ Group:   testapigroupv1.GroupName, Version: \"v1\", Kind:    \"Carp\", }, decodeIntoObject: &testapigroupv1.Carp{}, // which client-go's scheme doesn't recognize baseErr:          fmt.Errorf(\"plain error\"), }, { name:             \"decoding objects with unknown GVK fails and returns a bad-request error\", typer:            alwaysErrorTyper{}, decodedGVK:       nil, decodeIntoObject: &testapigroupv1.Carp{}, // which client-go's scheme doesn't recognize baseErr:          nil, }, } for _, testCase := range testCases { err := transformDecodeError(testCase.typer, testCase.baseErr, testCase.decodeIntoObject, testCase.decodedGVK, []byte(``)) if apiStatus, ok := err.(apierrors.APIStatus); !ok || apiStatus.Status().Code != http.StatusBadRequest { t.Errorf(\"expected bad request error but got: %v\", err) } } } var _ runtime.ObjectTyper = alwaysErrorTyper{} type alwaysErrorTyper struct{} func (alwaysErrorTyper) ObjectKinds(runtime.Object) ([]schema.GroupVersionKind, bool, error) { return nil, false, fmt.Errorf(\"always error\") } func (alwaysErrorTyper) Recognizes(gvk schema.GroupVersionKind) bool { return false } </ins>", "commid": "kubernetes_pr_71500"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8827ca63004a47357cfefee3cd648dabc7eed493bce201b21f63d05efb6b62be", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: If kubelet plugin registration fails during the registration process, the kubelet never attempts to register the socket again (assuming the error was transient), unless the socket for the driver is deleted & recreated to trigger a new registration. What you expected to happen: Maybe retry with exponential backoff when kubelet plugin registration fails instead of just logging and waiting for another filesystem event like it does today. Of course, if a socket returns a terminal error (does not implement the kubelet plugin registration service, for example), we should not retry. Follow up on /milestone v1.14 /sig storage How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nI'd like to work on this issue\n/assign\nRe opening. was a temporary work around for this. is the permanent fix.\nHello! We are starting Bug Freeze for 1.15. Is this issue still planned on being incorporated into 1.15?\nthe dependent PR is not yet merged. can we get this in for 1.15?\nsaid that is the \"permanent fix.\" and that has merged. So let's close this out /close\nClosing this issue. <detailsIn response to : said that is the \"permanent fix.\" and that has merged. So let's close this out Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-8437e21b771918767a9e687a9aa2e60258135c5634b9b4103b43784eb4d30874", "text": "\"fmt\" \"io\" \"net\" <ins> \"strings\" </ins> \"time\" csipbv1 \"github.com/container-storage-interface/spec/lib/go/csi\" \"google.golang.org/grpc\" api \"k8s.io/api/core/v1\" utilversion \"k8s.io/apimachinery/pkg/util/version\" <ins> \"k8s.io/apimachinery/pkg/util/wait\" </ins> utilfeature \"k8s.io/apiserver/pkg/util/feature\" \"k8s.io/klog\" \"k8s.io/kubernetes/pkg/features\"", "commid": "kubernetes_pr_72873"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8827ca63004a47357cfefee3cd648dabc7eed493bce201b21f63d05efb6b62be", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: If kubelet plugin registration fails during the registration process, the kubelet never attempts to register the socket again (assuming the error was transient), unless the socket for the driver is deleted & recreated to trigger a new registration. What you expected to happen: Maybe retry with exponential backoff when kubelet plugin registration fails instead of just logging and waiting for another filesystem event like it does today. Of course, if a socket returns a terminal error (does not implement the kubelet plugin registration service, for example), we should not retry. Follow up on /milestone v1.14 /sig storage How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nI'd like to work on this issue\n/assign\nRe opening. was a temporary work around for this. is the permanent fix.\nHello! We are starting Bug Freeze for 1.15. Is this issue still planned on being incorporated into 1.15?\nthe dependent PR is not yet merged. can we get this in for 1.15?\nsaid that is the \"permanent fix.\" and that has merged. So let's close this out /close\nClosing this issue. <detailsIn response to : said that is the \"permanent fix.\" and that has merged. So let's close this out Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-fe6122b6ab510cc11bd43fcaf6ae15629a6f4d158cddc6bbf4ee66b1dea00ecc", "text": "err error, ) <ins> const ( initialDuration = 1 * time.Second factor          = 2.0 steps           = 5 ) </ins> // newV1NodeClient creates a new NodeClient with the internally used gRPC // connection set up. It also returns a closer which must to be called to close // the gRPC connection when the NodeClient is not used anymore.", "commid": "kubernetes_pr_72873"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8827ca63004a47357cfefee3cd648dabc7eed493bce201b21f63d05efb6b62be", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: If kubelet plugin registration fails during the registration process, the kubelet never attempts to register the socket again (assuming the error was transient), unless the socket for the driver is deleted & recreated to trigger a new registration. What you expected to happen: Maybe retry with exponential backoff when kubelet plugin registration fails instead of just logging and waiting for another filesystem event like it does today. Of course, if a socket returns a terminal error (does not implement the kubelet plugin registration service, for example), we should not retry. Follow up on /milestone v1.14 /sig storage How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nI'd like to work on this issue\n/assign\nRe opening. was a temporary work around for this. is the permanent fix.\nHello! We are starting Bug Freeze for 1.15. Is this issue still planned on being incorporated into 1.15?\nthe dependent PR is not yet merged. can we get this in for 1.15?\nsaid that is the \"permanent fix.\" and that has merged. So let's close this out /close\nClosing this issue. <detailsIn response to : said that is the \"permanent fix.\" and that has merged. So let's close this out Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-900dccc9f43d8c12678606485e8f2d513fc8623da1641dbeb4276358955bc275", "text": "accessibleTopology map[string]string, err error) { klog.V(4).Info(log(\"calling NodeGetInfo rpc\")) <del> if c.nodeV1ClientCreator != nil { return c.nodeGetInfoV1(ctx) } else if c.nodeV0ClientCreator != nil { return c.nodeGetInfoV0(ctx) } err = fmt.Errorf(\"failed to call NodeGetInfo. Both nodeV1ClientCreator and nodeV0ClientCreator are nil\") </del> <ins> // TODO retries should happen at a lower layer (issue #73371) backoff := wait.Backoff{Duration: initialDuration, Factor: factor, Steps: steps} err = wait.ExponentialBackoff(backoff, func() (bool, error) { var getNodeInfoError error if c.nodeV1ClientCreator != nil { nodeID, maxVolumePerNode, accessibleTopology, getNodeInfoError = c.nodeGetInfoV1(ctx) } else if c.nodeV0ClientCreator != nil { nodeID, maxVolumePerNode, accessibleTopology, getNodeInfoError = c.nodeGetInfoV0(ctx) } if nodeID != \"\" { return true, nil } // kubelet plugin registration service not implemented is a terminal error, no need to retry if strings.Contains(getNodeInfoError.Error(), \"no handler registered for plugin type\") { return false, getNodeInfoError } // Continue with exponential backoff return false, nil }) </ins> return nodeID, maxVolumePerNode, accessibleTopology, err }", "commid": "kubernetes_pr_72873"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8827ca63004a47357cfefee3cd648dabc7eed493bce201b21f63d05efb6b62be", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: If kubelet plugin registration fails during the registration process, the kubelet never attempts to register the socket again (assuming the error was transient), unless the socket for the driver is deleted & recreated to trigger a new registration. What you expected to happen: Maybe retry with exponential backoff when kubelet plugin registration fails instead of just logging and waiting for another filesystem event like it does today. Of course, if a socket returns a terminal error (does not implement the kubelet plugin registration service, for example), we should not retry. Follow up on /milestone v1.14 /sig storage How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nI'd like to work on this issue\n/assign\nRe opening. was a temporary work around for this. is the permanent fix.\nHello! We are starting Bug Freeze for 1.15. Is this issue still planned on being incorporated into 1.15?\nthe dependent PR is not yet merged. can we get this in for 1.15?\nsaid that is the \"permanent fix.\" and that has merged. So let's close this out /close\nClosing this issue. <detailsIn response to : said that is the \"permanent fix.\" and that has merged. So let's close this out Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-7c98007d5fdee52516222849fd0297fbbc790519dc41270900f58b681a998457", "text": "return err } <del> // TODO (verult) retry with exponential backoff, possibly added in csi client library. </del> ctx, cancel := context.WithTimeout(context.Background(), csiTimeout) defer cancel()", "commid": "kubernetes_pr_72873"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8827ca63004a47357cfefee3cd648dabc7eed493bce201b21f63d05efb6b62be", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: If kubelet plugin registration fails during the registration process, the kubelet never attempts to register the socket again (assuming the error was transient), unless the socket for the driver is deleted & recreated to trigger a new registration. What you expected to happen: Maybe retry with exponential backoff when kubelet plugin registration fails instead of just logging and waiting for another filesystem event like it does today. Of course, if a socket returns a terminal error (does not implement the kubelet plugin registration service, for example), we should not retry. Follow up on /milestone v1.14 /sig storage How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nI'd like to work on this issue\n/assign\nRe opening. was a temporary work around for this. is the permanent fix.\nHello! We are starting Bug Freeze for 1.15. Is this issue still planned on being incorporated into 1.15?\nthe dependent PR is not yet merged. can we get this in for 1.15?\nsaid that is the \"permanent fix.\" and that has merged. So let's close this out /close\nClosing this issue. <detailsIn response to : said that is the \"permanent fix.\" and that has merged. So let's close this out Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-9c57d4c5798d552bc1aa6e9638450c0650e3d4524c8df4f6e5e357dc66670a54", "text": "if err != nil { klog.Error(log(\"registrationHandler.RegisterPlugin failed at CSI.NodeGetInfo: %v\", err)) if unregErr := unregisterDriver(pluginName); unregErr != nil { <del> klog.Error(log(\"registrationHandler.RegisterPlugin failed to unregister plugin due to previous: %v\", unregErr)) </del> <ins> klog.Error(log(\"registrationHandler.RegisterPlugin failed to unregister plugin due to previous error: %v\", unregErr)) </ins> return unregErr } return err", "commid": "kubernetes_pr_72873"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-754a337748c77aa830912aa5c369fd083977cc37177bb1280fd450d5c939bfe3", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: In the test failed due to namespace leakage: we created e2e-tests-load-30-nodepods-1-pfn9m, but never got response from api server (got 0-length response instead) we retried and created e2e-tests-load-30-nodepods-1-m9tq5 e2e-tests-load-30-nodepods-1-m9tq5 to f.namespacesToDelete and leaked -pfn9m next test case failed because e2e-tests-load-30-nodepods-1-pfn9m wasn't deleted. What you expected to happen: While it's unclear why we got 0-length response instead ( investigates that), we always can get error while the namespace was created (e.g. connection reset, timeout, io error). We should handle this case in retrying correctly. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.14.0-alpha.0.793+ Cloud provider or hardware configuration: gce OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-8359b74da41c66ae6cd4b76528d2bbfdec4160fe4da5db8601f78081ad4c5cc5", "text": "return fmt.Errorf(\"PersistentVolumeClaims %v not all in phase %s within %v\", pvcNames, phase, timeout) } <ins> // findAvailableNamespaceName random namespace name starting with baseName. func findAvailableNamespaceName(baseName string, c clientset.Interface) (string, error) { var name string err := wait.PollImmediate(Poll, 30*time.Second, func() (bool, error) { name = fmt.Sprintf(\"%v-%v\", baseName, randomSuffix()) _, err := c.CoreV1().Namespaces().Get(name, metav1.GetOptions{}) if err == nil { // Already taken return false, nil } if apierrs.IsNotFound(err) { return true, nil } Logf(\"Unexpected error while getting namespace: %v\", err) return false, nil }) return name, err } </ins> // CreateTestingNS should be used by every test, note that we append a common prefix to the provided test name. // Please see NewFramework instead of using this directly. func CreateTestingNS(baseName string, c clientset.Interface, labels map[string]string) (*v1.Namespace, error) {", "commid": "kubernetes_pr_72054"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-754a337748c77aa830912aa5c369fd083977cc37177bb1280fd450d5c939bfe3", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: In the test failed due to namespace leakage: we created e2e-tests-load-30-nodepods-1-pfn9m, but never got response from api server (got 0-length response instead) we retried and created e2e-tests-load-30-nodepods-1-m9tq5 e2e-tests-load-30-nodepods-1-m9tq5 to f.namespacesToDelete and leaked -pfn9m next test case failed because e2e-tests-load-30-nodepods-1-pfn9m wasn't deleted. What you expected to happen: While it's unclear why we got 0-length response instead ( investigates that), we always can get error while the namespace was created (e.g. connection reset, timeout, io error). We should handle this case in retrying correctly. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.14.0-alpha.0.793+ Cloud provider or hardware configuration: gce OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-63ab684902c6393fb60627763290fe3fc53a3311863fe9c305a6362e3ad9c9d1", "text": "} labels[\"e2e-run\"] = string(RunId) <ins> // We don't use ObjectMeta.GenerateName feature, as in case of API call // failure we don't know whether the namespace was created and what is its // name. name, err := findAvailableNamespaceName(baseName, c) if err != nil { return nil, err } </ins> namespaceObj := &v1.Namespace{ ObjectMeta: metav1.ObjectMeta{ <del> GenerateName: fmt.Sprintf(\"e2e-tests-%v-\", baseName), Namespace:    \"\", Labels:       labels, </del> <ins> Name:      name, Namespace: \"\", Labels:    labels, </ins> }, Status: v1.NamespaceStatus{}, }", "commid": "kubernetes_pr_72054"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-53cfc136f9589b29086751241b2b69f45850f5b53dcdf9ee898447ca23815858", "query": "What happened: AAD support in kubectl does not work for sovereign cloud The 'environment' parameter was introduced to support sovereign cloud, but it works in first round. The 'environment' value is not persisted, so follow-up requests will fail. What you expected to happen: 'environment' parameter persisted in kubectl config file. How to reproduce it (as minimally and precisely as possible): Use kubectl to connect to Azure sovereign cloud, make the token expire, and do auth. Anything else we need to know?: Environment: Kubernetes version (use ): 1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-04af920a3ae753b670023e2b7c66d786aeb988a6c17da3a72b3b66ac3680b728", "text": "type azureToken struct { token       adal.Token <ins> environment string </ins> clientID    string tenantID    string apiserverID string", "commid": "kubernetes_pr_72143"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-53cfc136f9589b29086751241b2b69f45850f5b53dcdf9ee898447ca23815858", "query": "What happened: AAD support in kubectl does not work for sovereign cloud The 'environment' parameter was introduced to support sovereign cloud, but it works in first round. The 'environment' value is not persisted, so follow-up requests will fail. What you expected to happen: 'environment' parameter persisted in kubectl config file. How to reproduce it (as minimally and precisely as possible): Use kubectl to connect to Azure sovereign cloud, make the token expire, and do auth. Anything else we need to know?: Environment: Kubernetes version (use ): 1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-d98977a4a7aff4fbf48b06c7a750f6387502edb1155a019645821ae7d3b091a6", "text": "if refreshToken == \"\" { return nil, fmt.Errorf(\"no refresh token in cfg: %s\", cfgRefreshToken) } <ins> environment := ts.cfg[cfgEnvironment] if environment == \"\" { return nil, fmt.Errorf(\"no environment in cfg: %s\", cfgEnvironment) } </ins> clientID := ts.cfg[cfgClientID] if clientID == \"\" { return nil, fmt.Errorf(\"no client ID in cfg: %s\", cfgClientID)", "commid": "kubernetes_pr_72143"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-53cfc136f9589b29086751241b2b69f45850f5b53dcdf9ee898447ca23815858", "query": "What happened: AAD support in kubectl does not work for sovereign cloud The 'environment' parameter was introduced to support sovereign cloud, but it works in first round. The 'environment' value is not persisted, so follow-up requests will fail. What you expected to happen: 'environment' parameter persisted in kubectl config file. How to reproduce it (as minimally and precisely as possible): Use kubectl to connect to Azure sovereign cloud, make the token expire, and do auth. Anything else we need to know?: Environment: Kubernetes version (use ): 1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-4cd66cd0e266dc3e8ee903a380497901267a667b37564741f9e8e9a9fb29ae7c", "text": "Resource:     fmt.Sprintf(\"spn:%s\", apiserverID), Type:         tokenType, }, <ins> environment: environment, </ins> clientID:    clientID, tenantID:    tenantID, apiserverID: apiserverID,", "commid": "kubernetes_pr_72143"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-53cfc136f9589b29086751241b2b69f45850f5b53dcdf9ee898447ca23815858", "query": "What happened: AAD support in kubectl does not work for sovereign cloud The 'environment' parameter was introduced to support sovereign cloud, but it works in first round. The 'environment' value is not persisted, so follow-up requests will fail. What you expected to happen: 'environment' parameter persisted in kubectl config file. How to reproduce it (as minimally and precisely as possible): Use kubectl to connect to Azure sovereign cloud, make the token expire, and do auth. Anything else we need to know?: Environment: Kubernetes version (use ): 1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-539cb8ff49fb6dc334c43e94d8431a8b1920cbf9e1aef004f9459fd2f3e8bbd9", "text": "newCfg := make(map[string]string) newCfg[cfgAccessToken] = token.token.AccessToken newCfg[cfgRefreshToken] = token.token.RefreshToken <ins> newCfg[cfgEnvironment] = token.environment </ins> newCfg[cfgClientID] = token.clientID newCfg[cfgTenantID] = token.tenantID newCfg[cfgApiserverID] = token.apiserverID", "commid": "kubernetes_pr_72143"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-53cfc136f9589b29086751241b2b69f45850f5b53dcdf9ee898447ca23815858", "query": "What happened: AAD support in kubectl does not work for sovereign cloud The 'environment' parameter was introduced to support sovereign cloud, but it works in first round. The 'environment' value is not persisted, so follow-up requests will fail. What you expected to happen: 'environment' parameter persisted in kubectl config file. How to reproduce it (as minimally and precisely as possible): Use kubectl to connect to Azure sovereign cloud, make the token expire, and do auth. Anything else we need to know?: Environment: Kubernetes version (use ): 1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-089e36ff9fc7ffa879f373a8bb280f2f9bcb62de055b4fbf22da9b68eedcb56f", "text": "} func (ts *azureTokenSource) refreshToken(token *azureToken) (*azureToken, error) { <del> oauthConfig, err := adal.NewOAuthConfig(azure.PublicCloud.ActiveDirectoryEndpoint, token.tenantID) </del> <ins> env, err := azure.EnvironmentFromName(token.environment) if err != nil { return nil, err } oauthConfig, err := adal.NewOAuthConfig(env.ActiveDirectoryEndpoint, token.tenantID) </ins> if err != nil { return nil, fmt.Errorf(\"building the OAuth configuration for token refresh: %v\", err) }", "commid": "kubernetes_pr_72143"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-53cfc136f9589b29086751241b2b69f45850f5b53dcdf9ee898447ca23815858", "query": "What happened: AAD support in kubectl does not work for sovereign cloud The 'environment' parameter was introduced to support sovereign cloud, but it works in first round. The 'environment' value is not persisted, so follow-up requests will fail. What you expected to happen: 'environment' parameter persisted in kubectl config file. How to reproduce it (as minimally and precisely as possible): Use kubectl to connect to Azure sovereign cloud, make the token expire, and do auth. Anything else we need to know?: Environment: Kubernetes version (use ): 1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-4b532f899f842a5efe75694da58080f7574178696ed27a0d4d7771387ffc9574", "text": "return &azureToken{ token:       spt.Token(), <ins> environment: token.environment, </ins> clientID:    token.clientID, tenantID:    token.tenantID, apiserverID: token.apiserverID,", "commid": "kubernetes_pr_72143"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-53cfc136f9589b29086751241b2b69f45850f5b53dcdf9ee898447ca23815858", "query": "What happened: AAD support in kubectl does not work for sovereign cloud The 'environment' parameter was introduced to support sovereign cloud, but it works in first round. The 'environment' value is not persisted, so follow-up requests will fail. What you expected to happen: 'environment' parameter persisted in kubectl config file. How to reproduce it (as minimally and precisely as possible): Use kubectl to connect to Azure sovereign cloud, make the token expire, and do auth. Anything else we need to know?: Environment: Kubernetes version (use ): 1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-4f5725782c06d956e8a7efe811c576b2eae37b1947a654457d8e0db04c07f978", "text": "return &azureToken{ token:       *token, <ins> environment: ts.environment.Name, </ins> clientID:    ts.clientID, tenantID:    ts.tenantID, apiserverID: ts.apiserverID,", "commid": "kubernetes_pr_72143"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-53cfc136f9589b29086751241b2b69f45850f5b53dcdf9ee898447ca23815858", "query": "What happened: AAD support in kubectl does not work for sovereign cloud The 'environment' parameter was introduced to support sovereign cloud, but it works in first round. The 'environment' value is not persisted, so follow-up requests will fail. What you expected to happen: 'environment' parameter persisted in kubectl config file. How to reproduce it (as minimally and precisely as possible): Use kubectl to connect to Azure sovereign cloud, make the token expire, and do auth. Anything else we need to know?: Environment: Kubernetes version (use ): 1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-a8cce56750e35e9e54be170bb03134eb7ee5b948a1b45c76b4d3eb2234ca94d8", "text": "wantCfg := token2Cfg(token) persistedCfg := persiter.Cache() <ins> wantCfgLen := len(wantCfg) persistedCfgLen := len(persistedCfg) if wantCfgLen != persistedCfgLen { t.Errorf(\"wantCfgLen and persistedCfgLen do not match, wantCfgLen=%v, persistedCfgLen=%v\", wantCfgLen, persistedCfgLen) } </ins> for k, v := range persistedCfg { if strings.Compare(v, wantCfg[k]) != 0 { t.Errorf(\"Token() persisted cfg %s: got %v, want %v\", k, v, wantCfg[k])", "commid": "kubernetes_pr_72143"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-53cfc136f9589b29086751241b2b69f45850f5b53dcdf9ee898447ca23815858", "query": "What happened: AAD support in kubectl does not work for sovereign cloud The 'environment' parameter was introduced to support sovereign cloud, but it works in first round. The 'environment' value is not persisted, so follow-up requests will fail. What you expected to happen: 'environment' parameter persisted in kubectl config file. How to reproduce it (as minimally and precisely as possible): Use kubectl to connect to Azure sovereign cloud, make the token expire, and do auth. Anything else we need to know?: Environment: Kubernetes version (use ): 1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-0c47b7e79f07d71bcecc90cc1dbde0efef3827e04b06331f903ccb3b3cbc9fac", "text": "func (ts *fakeTokenSource) Token() (*azureToken, error) { return &azureToken{ token:       newFackeAzureToken(ts.accessToken, ts.expiresOn), <ins> environment: \"testenv\", </ins> clientID:    \"fake\", tenantID:    \"fake\", apiserverID: \"fake\",", "commid": "kubernetes_pr_72143"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-53cfc136f9589b29086751241b2b69f45850f5b53dcdf9ee898447ca23815858", "query": "What happened: AAD support in kubectl does not work for sovereign cloud The 'environment' parameter was introduced to support sovereign cloud, but it works in first round. The 'environment' value is not persisted, so follow-up requests will fail. What you expected to happen: 'environment' parameter persisted in kubectl config file. How to reproduce it (as minimally and precisely as possible): Use kubectl to connect to Azure sovereign cloud, make the token expire, and do auth. Anything else we need to know?: Environment: Kubernetes version (use ): 1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-7d0d990cd50cf046087b3d52a631733ed0ca7f53332b30e1d5d95be2bfc78f17", "text": "cfg := make(map[string]string) cfg[cfgAccessToken] = token.token.AccessToken cfg[cfgRefreshToken] = token.token.RefreshToken <ins> cfg[cfgEnvironment] = token.environment </ins> cfg[cfgClientID] = token.clientID cfg[cfgTenantID] = token.tenantID cfg[cfgApiserverID] = token.apiserverID", "commid": "kubernetes_pr_72143"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0ed0c9c8e2de14d9bea2caa689fb3d4db2dcd076956a35485cb763c276972f01", "query": "What happened: removed reporting of the OutOfDisk condition in the kubelet. A 1.12 kubelet upgraded to a 1.13 kubelet leaves the previously reported OutOfDisk condition in place, and it eventually gets switched to Unknown status. What you expected to happen: If this condition is no longer reported, it should be removed by the kubelet. How to reproduce it (as minimally and precisely as possible): a 1.12 kubelet, let it report OutOfDisk condition status. to 1.13 the condition is no longer updated a while, the node controller flips the status to Unknown Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug /sig node\nThe fix for this should be picked to 1.13\n/assign happened to have a fix handy, if no one is working on it.\nafter upgrade kubelet should ignore this condition . or change it to 'DiskPressure'\nBetter not. What if both condition and exist?\nshould be picked to 1.13 also, I think.\n13.2 doesn't have this patch; would it be possible to make it for 1.13.3?\nUnfortunately this was not mentioned in the release notes (or I missed it), got hit by this too. 13.2 is affected too, would be good for me to see this getting fixed in 1.13.3", "positive_passages": [{"docid": "doc-en-kubernetes-f040fe5644e671e982af9893b2534d7e5b775117b27f587115806b55f7e62e03", "text": "nodestatus.PIDPressureCondition(kl.clock.Now, kl.evictionManager.IsUnderPIDPressure, kl.recordNodeStatusEvent), nodestatus.ReadyCondition(kl.clock.Now, kl.runtimeState.runtimeErrors, kl.runtimeState.networkErrors, validateHostFunc, kl.containerManager.Status, kl.recordNodeStatusEvent), nodestatus.VolumesInUse(kl.volumeManager.ReconcilerStatesHasBeenSynced, kl.volumeManager.GetVolumesInUse), <ins> nodestatus.RemoveOutOfDiskCondition(), </ins> // TODO(mtaufen): I decided not to move this setter for now, since all it does is send an event // and record state back to the Kubelet runtime object. In the future, I'd like to isolate // these side-effects by decoupling the decisions to send events and partial status recording", "commid": "kubernetes_pr_72507"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0ed0c9c8e2de14d9bea2caa689fb3d4db2dcd076956a35485cb763c276972f01", "query": "What happened: removed reporting of the OutOfDisk condition in the kubelet. A 1.12 kubelet upgraded to a 1.13 kubelet leaves the previously reported OutOfDisk condition in place, and it eventually gets switched to Unknown status. What you expected to happen: If this condition is no longer reported, it should be removed by the kubelet. How to reproduce it (as minimally and precisely as possible): a 1.12 kubelet, let it report OutOfDisk condition status. to 1.13 the condition is no longer updated a while, the node controller flips the status to Unknown Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug /sig node\nThe fix for this should be picked to 1.13\n/assign happened to have a fix handy, if no one is working on it.\nafter upgrade kubelet should ignore this condition . or change it to 'DiskPressure'\nBetter not. What if both condition and exist?\nshould be picked to 1.13 also, I think.\n13.2 doesn't have this patch; would it be possible to make it for 1.13.3?\nUnfortunately this was not mentioned in the release notes (or I missed it), got hit by this too. 13.2 is affected too, would be good for me to see this getting fixed in 1.13.3", "positive_passages": [{"docid": "doc-en-kubernetes-4ade082c4e52ff48f60d0fe5ac10ed4ca6b7322ed883510496959d159519c47b", "text": "return nil } } <ins> // RemoveOutOfDiskCondition removes stale OutOfDisk condition // OutOfDisk condition has been removed from kubelet in 1.12 func RemoveOutOfDiskCondition() Setter { return func(node *v1.Node) error { var conditions []v1.NodeCondition for i := range node.Status.Conditions { if node.Status.Conditions[i].Type != v1.NodeOutOfDisk { conditions = append(conditions, node.Status.Conditions[i]) } } node.Status.Conditions = conditions return nil } } </ins>", "commid": "kubernetes_pr_72507"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0ed0c9c8e2de14d9bea2caa689fb3d4db2dcd076956a35485cb763c276972f01", "query": "What happened: removed reporting of the OutOfDisk condition in the kubelet. A 1.12 kubelet upgraded to a 1.13 kubelet leaves the previously reported OutOfDisk condition in place, and it eventually gets switched to Unknown status. What you expected to happen: If this condition is no longer reported, it should be removed by the kubelet. How to reproduce it (as minimally and precisely as possible): a 1.12 kubelet, let it report OutOfDisk condition status. to 1.13 the condition is no longer updated a while, the node controller flips the status to Unknown Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: <!-- DO NOT EDIT BELOW THIS LINE --/kind bug /sig node\nThe fix for this should be picked to 1.13\n/assign happened to have a fix handy, if no one is working on it.\nafter upgrade kubelet should ignore this condition . or change it to 'DiskPressure'\nBetter not. What if both condition and exist?\nshould be picked to 1.13 also, I think.\n13.2 doesn't have this patch; would it be possible to make it for 1.13.3?\nUnfortunately this was not mentioned in the release notes (or I missed it), got hit by this too. 13.2 is affected too, would be good for me to see this getting fixed in 1.13.3", "positive_passages": [{"docid": "doc-en-kubernetes-66c091b0793ca0ccaf9c5770f8d241a285c18559e4579850116bd63bfa9f078d", "text": "} } <ins> func TestRemoveOutOfDiskCondition(t *testing.T) { now := time.Now() var cases = []struct { desc       string inputNode  *v1.Node expectNode *v1.Node }{ { desc: \"should remove stale OutOfDiskCondition from node status\", inputNode: &v1.Node{ Status: v1.NodeStatus{ Conditions: []v1.NodeCondition{ *makeMemoryPressureCondition(false, now, now), { Type:   v1.NodeOutOfDisk, Status: v1.ConditionFalse, }, *makeDiskPressureCondition(false, now, now), }, }, }, expectNode: &v1.Node{ Status: v1.NodeStatus{ Conditions: []v1.NodeCondition{ *makeMemoryPressureCondition(false, now, now), *makeDiskPressureCondition(false, now, now), }, }, }, }, } for _, tc := range cases { t.Run(tc.desc, func(t *testing.T) { // construct setter setter := RemoveOutOfDiskCondition() // call setter on node if err := setter(tc.inputNode); err != nil { t.Fatalf(\"unexpected error: %v\", err) } // check expected node assert.True(t, apiequality.Semantic.DeepEqual(tc.expectNode, tc.inputNode), \"Diff: %s\", diff.ObjectDiff(tc.expectNode, tc.inputNode)) }) } } </ins> // Test Helpers: // sortableNodeAddress is a type for sorting []v1.NodeAddress", "commid": "kubernetes_pr_72507"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-536ebee2479645b5b719f09972b970f703777471342fc75981f2b5f9dd5ef7ea", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: When using the function from Python's Kuberneets API, we noticed that Pods are terminated bythe cluster without respecting their preStop hooks or terminationGracePeriodSeconds seconds. What you expected to happen: When using the eviction API, just as when using delete, Pods should be allowed to run their preStop hooks, as well as be given terminationGracePeriodSeconds before being terminated with SIGKILL. How to reproduce it (as minimally and precisely as possible): the following pod: the pod logs in another window to evict the pod. Here is a sample curl equivalent of what (1.13) is doing - happy path: Here is a sample curl equivalent of what Python's is doing (when not passed ) - broken path: The log output generated by the guinea pod on the happy path looks like this: The \"Got signal 15\" message shows up only after the preStop hook is finished, so ~10 seconds after the evict call is made What happens on the broken path is: We seem to be getting 2x SIGTERM, there are no messages indicating continued processing after the signal, and the signal itself is registered immediately after the eviction call is made, suggesting that preStop didn't run. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: AWS OS (e.g. from /etc/os-release): CentOS Linux release 7.5.1804 Kernel (e.g. ): 3.10.0-862.14.4.el7.x8664 SMP Wed Sep 26 15:12:11 UTC 2018 x8664 x8664 x8664 GNU/Linux Install tools: in-house Others:\n/sig api-machinery\nthis is because of this code: invoked from here: it is passing in the eviction delete options field as-is, meaning nil gets propagated and defaulted to mean delete immediately. when calling delete APIs normally, delete options defaults to a non-nil empty set of options:\nFixed in\npatch looks legit. Thanks for the quick reaction and for the pointers!\nI've a elasticsearch stateful set which have a preHook which never completes and the pod is never killed despite terminationGracePeriodSeconds being set. Is it related ? If so can this be considered to be cherry-picked on v1.13.x release branch ?", "positive_passages": [{"docid": "doc-en-kubernetes-ee257af44e77a909d912997ff6303098bdbecc5162591f3e7a2d324dd78bdf08", "text": "go_test( name = \"go_default_test\", <del> srcs = [\"storage_test.go\"], </del> <ins> srcs = [ \"eviction_test.go\", \"storage_test.go\", ], </ins> embed = [\":go_default_library\"], deps = [ \"//pkg/apis/core:go_default_library\", <ins> \"//pkg/apis/policy:go_default_library\", \"//pkg/client/clientset_generated/internalclientset/fake:go_default_library\", </ins> \"//pkg/registry/registrytest:go_default_library\", \"//pkg/securitycontext:go_default_library\", \"//staging/src/k8s.io/api/core/v1:go_default_library\",", "commid": "kubernetes_pr_72730"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-536ebee2479645b5b719f09972b970f703777471342fc75981f2b5f9dd5ef7ea", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: When using the function from Python's Kuberneets API, we noticed that Pods are terminated bythe cluster without respecting their preStop hooks or terminationGracePeriodSeconds seconds. What you expected to happen: When using the eviction API, just as when using delete, Pods should be allowed to run their preStop hooks, as well as be given terminationGracePeriodSeconds before being terminated with SIGKILL. How to reproduce it (as minimally and precisely as possible): the following pod: the pod logs in another window to evict the pod. Here is a sample curl equivalent of what (1.13) is doing - happy path: Here is a sample curl equivalent of what Python's is doing (when not passed ) - broken path: The log output generated by the guinea pod on the happy path looks like this: The \"Got signal 15\" message shows up only after the preStop hook is finished, so ~10 seconds after the evict call is made What happens on the broken path is: We seem to be getting 2x SIGTERM, there are no messages indicating continued processing after the signal, and the signal itself is registered immediately after the eviction call is made, suggesting that preStop didn't run. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: AWS OS (e.g. from /etc/os-release): CentOS Linux release 7.5.1804 Kernel (e.g. ): 3.10.0-862.14.4.el7.x8664 SMP Wed Sep 26 15:12:11 UTC 2018 x8664 x8664 x8664 GNU/Linux Install tools: in-house Others:\n/sig api-machinery\nthis is because of this code: invoked from here: it is passing in the eviction delete options field as-is, meaning nil gets propagated and defaulted to mean delete immediately. when calling delete APIs normally, delete options defaults to a non-nil empty set of options:\nFixed in\npatch looks legit. Thanks for the quick reaction and for the pointers!\nI've a elasticsearch stateful set which have a preHook which never completes and the pod is never killed despite terminationGracePeriodSeconds being set. Is it related ? If so can this be considered to be cherry-picked on v1.13.x release branch ?", "positive_passages": [{"docid": "doc-en-kubernetes-eec4aa3499e09cb0a93f8ba9e4cb5fc2cc2aec9abd0fdc9abd118dd3542ef32c", "text": "// At this point there was either no PDB or we succeeded in decrementing // Try the delete <del> _, _, err = r.store.Delete(ctx, eviction.Name, eviction.DeleteOptions) </del> <ins> deletionOptions := eviction.DeleteOptions if deletionOptions == nil { // default to non-nil to trigger graceful deletion deletionOptions = &metav1.DeleteOptions{} } _, _, err = r.store.Delete(ctx, eviction.Name, deletionOptions) </ins> if err != nil { return nil, err }", "commid": "kubernetes_pr_72730"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-536ebee2479645b5b719f09972b970f703777471342fc75981f2b5f9dd5ef7ea", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: When using the function from Python's Kuberneets API, we noticed that Pods are terminated bythe cluster without respecting their preStop hooks or terminationGracePeriodSeconds seconds. What you expected to happen: When using the eviction API, just as when using delete, Pods should be allowed to run their preStop hooks, as well as be given terminationGracePeriodSeconds before being terminated with SIGKILL. How to reproduce it (as minimally and precisely as possible): the following pod: the pod logs in another window to evict the pod. Here is a sample curl equivalent of what (1.13) is doing - happy path: Here is a sample curl equivalent of what Python's is doing (when not passed ) - broken path: The log output generated by the guinea pod on the happy path looks like this: The \"Got signal 15\" message shows up only after the preStop hook is finished, so ~10 seconds after the evict call is made What happens on the broken path is: We seem to be getting 2x SIGTERM, there are no messages indicating continued processing after the signal, and the signal itself is registered immediately after the eviction call is made, suggesting that preStop didn't run. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: AWS OS (e.g. from /etc/os-release): CentOS Linux release 7.5.1804 Kernel (e.g. ): 3.10.0-862.14.4.el7.x8664 SMP Wed Sep 26 15:12:11 UTC 2018 x8664 x8664 x8664 GNU/Linux Install tools: in-house Others:\n/sig api-machinery\nthis is because of this code: invoked from here: it is passing in the eviction delete options field as-is, meaning nil gets propagated and defaulted to mean delete immediately. when calling delete APIs normally, delete options defaults to a non-nil empty set of options:\nFixed in\npatch looks legit. Thanks for the quick reaction and for the pointers!\nI've a elasticsearch stateful set which have a preHook which never completes and the pod is never killed despite terminationGracePeriodSeconds being set. Is it related ? If so can this be considered to be cherry-picked on v1.13.x release branch ?", "positive_passages": [{"docid": "doc-en-kubernetes-956940777e2c22051beeaa34d172dfbe6228c3a199b16221a45c1f790e7819b3", "text": "<ins> /* Copyright 2019 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package storage import ( \"testing\" apierrors \"k8s.io/apimachinery/pkg/api/errors\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/runtime\" genericapirequest \"k8s.io/apiserver/pkg/endpoints/request\" api \"k8s.io/kubernetes/pkg/apis/core\" \"k8s.io/kubernetes/pkg/apis/policy\" \"k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/fake\" ) func TestEviction(t *testing.T) { testcases := []struct { name     string pdbs     []runtime.Object pod      *api.Pod eviction *policy.Eviction expectError   bool expectDeleted bool }{ { name:          \"no pdbs, unscheduled pod, nil delete options, deletes immediately\", pdbs:          nil, pod:           validNewPod(), eviction:      &policy.Eviction{ObjectMeta: metav1.ObjectMeta{Name: \"foo\", Namespace: \"default\"}}, expectDeleted: true, }, { name:          \"no pdbs, scheduled pod, nil delete options, deletes gracefully\", pdbs:          nil, pod:           func() *api.Pod { pod := validNewPod(); pod.Spec.NodeName = \"foo\"; return pod }(), eviction:      &policy.Eviction{ObjectMeta: metav1.ObjectMeta{Name: \"foo\", Namespace: \"default\"}}, expectDeleted: false, // not deleted immediately because of graceful deletion }, { name:          \"no pdbs, scheduled pod, empty delete options, deletes gracefully\", pdbs:          nil, pod:           func() *api.Pod { pod := validNewPod(); pod.Spec.NodeName = \"foo\"; return pod }(), eviction:      &policy.Eviction{ObjectMeta: metav1.ObjectMeta{Name: \"foo\", Namespace: \"default\"}, DeleteOptions: &metav1.DeleteOptions{}}, expectDeleted: false, // not deleted immediately because of graceful deletion }, { name:          \"no pdbs, scheduled pod, graceless delete options, deletes immediately\", pdbs:          nil, pod:           func() *api.Pod { pod := validNewPod(); pod.Spec.NodeName = \"foo\"; return pod }(), eviction:      &policy.Eviction{ObjectMeta: metav1.ObjectMeta{Name: \"foo\", Namespace: \"default\"}, DeleteOptions: metav1.NewDeleteOptions(0)}, expectDeleted: true, }, { name: \"matching pdbs with no disruptions allowed\", pdbs: []runtime.Object{&policy.PodDisruptionBudget{ ObjectMeta: metav1.ObjectMeta{Name: \"foo\", Namespace: \"default\"}, Spec:       policy.PodDisruptionBudgetSpec{Selector: &metav1.LabelSelector{MatchLabels: map[string]string{\"a\": \"true\"}}}, Status:     policy.PodDisruptionBudgetStatus{PodDisruptionsAllowed: 0}, }}, pod: func() *api.Pod { pod := validNewPod() pod.Labels = map[string]string{\"a\": \"true\"} pod.Spec.NodeName = \"foo\" return pod }(), eviction:    &policy.Eviction{ObjectMeta: metav1.ObjectMeta{Name: \"foo\", Namespace: \"default\"}, DeleteOptions: metav1.NewDeleteOptions(0)}, expectError: true, }, { name: \"matching pdbs with disruptions allowed\", pdbs: []runtime.Object{&policy.PodDisruptionBudget{ ObjectMeta: metav1.ObjectMeta{Name: \"foo\", Namespace: \"default\"}, Spec:       policy.PodDisruptionBudgetSpec{Selector: &metav1.LabelSelector{MatchLabels: map[string]string{\"a\": \"true\"}}}, Status:     policy.PodDisruptionBudgetStatus{PodDisruptionsAllowed: 1}, }}, pod: func() *api.Pod { pod := validNewPod() pod.Labels = map[string]string{\"a\": \"true\"} pod.Spec.NodeName = \"foo\" return pod }(), eviction:      &policy.Eviction{ObjectMeta: metav1.ObjectMeta{Name: \"foo\", Namespace: \"default\"}, DeleteOptions: metav1.NewDeleteOptions(0)}, expectDeleted: true, }, { name: \"non-matching pdbs\", pdbs: []runtime.Object{&policy.PodDisruptionBudget{ ObjectMeta: metav1.ObjectMeta{Name: \"foo\", Namespace: \"default\"}, Spec:       policy.PodDisruptionBudgetSpec{Selector: &metav1.LabelSelector{MatchLabels: map[string]string{\"b\": \"true\"}}}, Status:     policy.PodDisruptionBudgetStatus{PodDisruptionsAllowed: 0}, }}, pod: func() *api.Pod { pod := validNewPod() pod.Labels = map[string]string{\"a\": \"true\"} pod.Spec.NodeName = \"foo\" return pod }(), eviction:      &policy.Eviction{ObjectMeta: metav1.ObjectMeta{Name: \"foo\", Namespace: \"default\"}, DeleteOptions: metav1.NewDeleteOptions(0)}, expectDeleted: true, }, } for _, tc := range testcases { t.Run(tc.name, func(t *testing.T) { testContext := genericapirequest.WithNamespace(genericapirequest.NewContext(), metav1.NamespaceDefault) storage, _, _, server := newStorage(t) defer server.Terminate(t) defer storage.Store.DestroyFunc() if tc.pod != nil { if _, err := storage.Create(testContext, tc.pod, nil, &metav1.CreateOptions{}); err != nil { t.Error(err) } } client := fake.NewSimpleClientset(tc.pdbs...) evictionRest := newEvictionStorage(storage.Store, client.Policy()) _, err := evictionRest.Create(testContext, tc.eviction, nil, &metav1.CreateOptions{}) if (err != nil) != tc.expectError { t.Errorf(\"expected error=%v, got %v\", tc.expectError, err) return } if tc.expectError { return } if tc.pod != nil { existingPod, err := storage.Get(testContext, tc.pod.Name, &metav1.GetOptions{}) if tc.expectDeleted { if !apierrors.IsNotFound(err) { t.Errorf(\"expected to be deleted, lookup returned %#v\", existingPod) } return } else if apierrors.IsNotFound(err) { t.Errorf(\"expected graceful deletion, got %v\", err) return } if err != nil { t.Errorf(\"%#v\", err) return } if existingPod.(*api.Pod).DeletionTimestamp == nil { t.Errorf(\"expected gracefully deleted pod with deletionTimestamp set, got %#v\", existingPod) } } }) } } </ins>", "commid": "kubernetes_pr_72730"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-536ebee2479645b5b719f09972b970f703777471342fc75981f2b5f9dd5ef7ea", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: When using the function from Python's Kuberneets API, we noticed that Pods are terminated bythe cluster without respecting their preStop hooks or terminationGracePeriodSeconds seconds. What you expected to happen: When using the eviction API, just as when using delete, Pods should be allowed to run their preStop hooks, as well as be given terminationGracePeriodSeconds before being terminated with SIGKILL. How to reproduce it (as minimally and precisely as possible): the following pod: the pod logs in another window to evict the pod. Here is a sample curl equivalent of what (1.13) is doing - happy path: Here is a sample curl equivalent of what Python's is doing (when not passed ) - broken path: The log output generated by the guinea pod on the happy path looks like this: The \"Got signal 15\" message shows up only after the preStop hook is finished, so ~10 seconds after the evict call is made What happens on the broken path is: We seem to be getting 2x SIGTERM, there are no messages indicating continued processing after the signal, and the signal itself is registered immediately after the eviction call is made, suggesting that preStop didn't run. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: AWS OS (e.g. from /etc/os-release): CentOS Linux release 7.5.1804 Kernel (e.g. ): 3.10.0-862.14.4.el7.x8664 SMP Wed Sep 26 15:12:11 UTC 2018 x8664 x8664 x8664 GNU/Linux Install tools: in-house Others:\n/sig api-machinery\nthis is because of this code: invoked from here: it is passing in the eviction delete options field as-is, meaning nil gets propagated and defaulted to mean delete immediately. when calling delete APIs normally, delete options defaults to a non-nil empty set of options:\nFixed in\npatch looks legit. Thanks for the quick reaction and for the pointers!\nI've a elasticsearch stateful set which have a preHook which never completes and the pod is never killed despite terminationGracePeriodSeconds being set. Is it related ? If so can this be considered to be cherry-picked on v1.13.x release branch ?", "positive_passages": [{"docid": "doc-en-kubernetes-e99d757f7cb833dd982e7a60aeb8d36d0d6cbba03e6139eaf704359c2a5e9556", "text": "} createNode2NormalPodEviction := func(client clientset.Interface) func() error { return func() error { <ins> zero := int64(0) </ins> return client.Policy().Evictions(\"ns\").Evict(&policy.Eviction{ TypeMeta: metav1.TypeMeta{ APIVersion: \"policy/v1beta1\",", "commid": "kubernetes_pr_72730"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-536ebee2479645b5b719f09972b970f703777471342fc75981f2b5f9dd5ef7ea", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: When using the function from Python's Kuberneets API, we noticed that Pods are terminated bythe cluster without respecting their preStop hooks or terminationGracePeriodSeconds seconds. What you expected to happen: When using the eviction API, just as when using delete, Pods should be allowed to run their preStop hooks, as well as be given terminationGracePeriodSeconds before being terminated with SIGKILL. How to reproduce it (as minimally and precisely as possible): the following pod: the pod logs in another window to evict the pod. Here is a sample curl equivalent of what (1.13) is doing - happy path: Here is a sample curl equivalent of what Python's is doing (when not passed ) - broken path: The log output generated by the guinea pod on the happy path looks like this: The \"Got signal 15\" message shows up only after the preStop hook is finished, so ~10 seconds after the evict call is made What happens on the broken path is: We seem to be getting 2x SIGTERM, there are no messages indicating continued processing after the signal, and the signal itself is registered immediately after the eviction call is made, suggesting that preStop didn't run. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: AWS OS (e.g. from /etc/os-release): CentOS Linux release 7.5.1804 Kernel (e.g. ): 3.10.0-862.14.4.el7.x8664 SMP Wed Sep 26 15:12:11 UTC 2018 x8664 x8664 x8664 GNU/Linux Install tools: in-house Others:\n/sig api-machinery\nthis is because of this code: invoked from here: it is passing in the eviction delete options field as-is, meaning nil gets propagated and defaulted to mean delete immediately. when calling delete APIs normally, delete options defaults to a non-nil empty set of options:\nFixed in\npatch looks legit. Thanks for the quick reaction and for the pointers!\nI've a elasticsearch stateful set which have a preHook which never completes and the pod is never killed despite terminationGracePeriodSeconds being set. Is it related ? If so can this be considered to be cherry-picked on v1.13.x release branch ?", "positive_passages": [{"docid": "doc-en-kubernetes-c4fe8052c3b0459d1f7ccb441047c8ad17706af9e1687a73bb029459b6d36e87", "text": "Name:      \"node2normalpod\", Namespace: \"ns\", }, <ins> DeleteOptions: &metav1.DeleteOptions{GracePeriodSeconds: &zero}, </ins> }) } } createNode2MirrorPodEviction := func(client clientset.Interface) func() error { return func() error { <ins> zero := int64(0) </ins> return client.Policy().Evictions(\"ns\").Evict(&policy.Eviction{ TypeMeta: metav1.TypeMeta{ APIVersion: \"policy/v1beta1\",", "commid": "kubernetes_pr_72730"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-536ebee2479645b5b719f09972b970f703777471342fc75981f2b5f9dd5ef7ea", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: When using the function from Python's Kuberneets API, we noticed that Pods are terminated bythe cluster without respecting their preStop hooks or terminationGracePeriodSeconds seconds. What you expected to happen: When using the eviction API, just as when using delete, Pods should be allowed to run their preStop hooks, as well as be given terminationGracePeriodSeconds before being terminated with SIGKILL. How to reproduce it (as minimally and precisely as possible): the following pod: the pod logs in another window to evict the pod. Here is a sample curl equivalent of what (1.13) is doing - happy path: Here is a sample curl equivalent of what Python's is doing (when not passed ) - broken path: The log output generated by the guinea pod on the happy path looks like this: The \"Got signal 15\" message shows up only after the preStop hook is finished, so ~10 seconds after the evict call is made What happens on the broken path is: We seem to be getting 2x SIGTERM, there are no messages indicating continued processing after the signal, and the signal itself is registered immediately after the eviction call is made, suggesting that preStop didn't run. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: AWS OS (e.g. from /etc/os-release): CentOS Linux release 7.5.1804 Kernel (e.g. ): 3.10.0-862.14.4.el7.x8664 SMP Wed Sep 26 15:12:11 UTC 2018 x8664 x8664 x8664 GNU/Linux Install tools: in-house Others:\n/sig api-machinery\nthis is because of this code: invoked from here: it is passing in the eviction delete options field as-is, meaning nil gets propagated and defaulted to mean delete immediately. when calling delete APIs normally, delete options defaults to a non-nil empty set of options:\nFixed in\npatch looks legit. Thanks for the quick reaction and for the pointers!\nI've a elasticsearch stateful set which have a preHook which never completes and the pod is never killed despite terminationGracePeriodSeconds being set. Is it related ? If so can this be considered to be cherry-picked on v1.13.x release branch ?", "positive_passages": [{"docid": "doc-en-kubernetes-b2191605d871de0a265683ec884acc97ba38a17259c9cf0590f0c81ae48e97e1", "text": "Name:      \"node2mirrorpod\", Namespace: \"ns\", }, <ins> DeleteOptions: &metav1.DeleteOptions{GracePeriodSeconds: &zero}, </ins> }) } }", "commid": "kubernetes_pr_72730"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8a691359afd12eed0a607a985abb219c9f1a4fc754f792f7946964f4e4d965ba", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: I'm running a K8s 1.13 cluster and a partial netsplit happened due to a defective linecard dropping only TCP packets above a certain sizes between two masters, but the third could still communicate with both (so the fault made the network non-transitive). etcd was run on the physical network, but Kubernetes traffic runs on a Wireguard overlay for security and routing is provided by OSPF (so internal communication was not affected since it was tunelled over UDP). Etcd experienced some temporary issues due to the connections dropping only certain packets (above ~1000 bytes), but quickly dropped one host out of the quorum, at which point it was degraded but all the remaining hosts could communicate freely. Each master node has an etcd instance and an apiserver. All apiservers are anycasted inside the overlay to balance the load and provide redundancy and the announcement is coupled to the health check, so in case any apiserver fails no traffic will be routed to it. The problem was that the apiserver did not fail its healthcheck even though all etcd write requests timed out. The non-working apiserver was still accessible and got routed its share of the anycast traffic since that was routed over the UDP overlay. Thus ~1/3 of all workloads and nodes were stuck on a non-working apiserver until I nuked the non-working apiserver. TLDR: One etcd server started timing out all writes due to a non-transitive netsplit and the Kubernetes apiserver healthcheck did not fail, causing 1/3 of K8s clients to not have a working control plane until manual intervention. What you expected to happen: The health check should've failed (in my opinion, I'm happy to discuss if you think otherwise). How to reproduce it (as minimally and precisely as possible): Set up 3 etcds with corresponding apiservers, introduce a split between two (shouldn't have to be a packet size limit, a full disconnect should reproduce cleanly), observe that all three report healthy even though at least one of them no longer works. Anything else we need to know?: Environment: Kubernetes version (use ): v1.13.0 Cloud provider or hardware configuration: Physical x86_64 servers OS (e.g. from /etc/os-release): Custom Kernel (e.g. ): Custom, based on 4.19. No patches affect this functionality. Install tools: Custom Others:\n/sig api-machinery (maybe cluster-ops?)\ncc\nLooks like the etcdctl endpoint health command does a random read after fetching the list of members - - we should probably do the same?\nLooks sane and would have prevented my issue. Should I PR this?\nsure. thanks\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-387370c29d14d810fd240ace1aacaa9f4b658c6f342bbe0bb70eb475f1705fe2", "text": "import ( \"context\" \"fmt\" <ins> \"path\" </ins> \"sync\" \"sync/atomic\" \"time\"", "commid": "kubernetes_pr_72896"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8a691359afd12eed0a607a985abb219c9f1a4fc754f792f7946964f4e4d965ba", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: I'm running a K8s 1.13 cluster and a partial netsplit happened due to a defective linecard dropping only TCP packets above a certain sizes between two masters, but the third could still communicate with both (so the fault made the network non-transitive). etcd was run on the physical network, but Kubernetes traffic runs on a Wireguard overlay for security and routing is provided by OSPF (so internal communication was not affected since it was tunelled over UDP). Etcd experienced some temporary issues due to the connections dropping only certain packets (above ~1000 bytes), but quickly dropped one host out of the quorum, at which point it was degraded but all the remaining hosts could communicate freely. Each master node has an etcd instance and an apiserver. All apiservers are anycasted inside the overlay to balance the load and provide redundancy and the announcement is coupled to the health check, so in case any apiserver fails no traffic will be routed to it. The problem was that the apiserver did not fail its healthcheck even though all etcd write requests timed out. The non-working apiserver was still accessible and got routed its share of the anycast traffic since that was routed over the UDP overlay. Thus ~1/3 of all workloads and nodes were stuck on a non-working apiserver until I nuked the non-working apiserver. TLDR: One etcd server started timing out all writes due to a non-transitive netsplit and the Kubernetes apiserver healthcheck did not fail, causing 1/3 of K8s clients to not have a working control plane until manual intervention. What you expected to happen: The health check should've failed (in my opinion, I'm happy to discuss if you think otherwise). How to reproduce it (as minimally and precisely as possible): Set up 3 etcds with corresponding apiservers, introduce a split between two (shouldn't have to be a packet size limit, a full disconnect should reproduce cleanly), observe that all three report healthy even though at least one of them no longer works. Anything else we need to know?: Environment: Kubernetes version (use ): v1.13.0 Cloud provider or hardware configuration: Physical x86_64 servers OS (e.g. from /etc/os-release): Custom Kernel (e.g. ): Custom, based on 4.19. No patches affect this functionality. Install tools: Custom Others:\n/sig api-machinery (maybe cluster-ops?)\ncc\nLooks like the etcdctl endpoint health command does a random read after fetching the list of members - - we should probably do the same?\nLooks sane and would have prevented my issue. Should I PR this?\nsure. thanks\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-1b08f8fa97e9fd0473c753acf9ddae7d6aaae16fcca42ce43d82e13b82fa119b", "text": "client := clientValue.Load().(*clientv3.Client) ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second) defer cancel() <del> if _, err := client.Cluster.MemberList(ctx); err != nil { return fmt.Errorf(\"error listing etcd members: %v\", err) </del> <ins> // See https://github.com/etcd-io/etcd/blob/master/etcdctl/ctlv3/command/ep_command.go#L118 _, err := client.Get(ctx, path.Join(c.Prefix, \"health\")) if err == nil { return nil </ins> } <del> return nil </del> <ins> return fmt.Errorf(\"error getting data from etcd: %v\", err) </ins> }, nil }", "commid": "kubernetes_pr_72896"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-54c721787801f302bf73cc1b2dd5a4c401204e68c80dfcb6e42ea3d8ce05c21e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: azure file remount on Windows in same node would fail What you expected to happen: If user delete a pod with azure file mount in deployment and it would probably schedule a pod on same node, azure file mount will fail since command would fail if file share is already mounted on the node: It's related to bug: Error logs would be like following: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.9-v1.12, master Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /assign\n/sig windows\n/sig azure\n/milestone v1.14 cc This may be good to backport to 1.12 or 1.13 too if customers are using those versions.", "positive_passages": [{"docid": "doc-en-kubernetes-ce015c87df116d623a6afdf5fd18940767194a6a6da911a161c6f57803974af3", "text": "} } <del> // Mount : mounts source to target as NTFS with given options. </del> <ins> // Mount : mounts source to target with given options. // currently only supports cifs(smb), bind mount(for disk) </ins> func (mounter *Mounter) Mount(source string, target string, fstype string, options []string) error { target = normalizeWindowsPath(target) if source == \"tmpfs\" { <del> klog.V(3).Infof(\"azureMount: mounting source (%q), target (%q), with options (%q)\", source, target, options) </del> <ins> klog.V(3).Infof(\"mounting source (%q), target (%q), with options (%q)\", source, target, options) </ins> return os.MkdirAll(target, 0755) }", "commid": "kubernetes_pr_73661"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-54c721787801f302bf73cc1b2dd5a4c401204e68c80dfcb6e42ea3d8ce05c21e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: azure file remount on Windows in same node would fail What you expected to happen: If user delete a pod with azure file mount in deployment and it would probably schedule a pod on same node, azure file mount will fail since command would fail if file share is already mounted on the node: It's related to bug: Error logs would be like following: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.9-v1.12, master Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /assign\n/sig windows\n/sig azure\n/milestone v1.14 cc This may be good to backport to 1.12 or 1.13 too if customers are using those versions.", "positive_passages": [{"docid": "doc-en-kubernetes-ce51aec141a822e4ed3997accf85cc21f71f76028d3fa6bd46cce5daeae04b41", "text": "return err } <del> klog.V(4).Infof(\"azureMount: mount options(%q) source:%q, target:%q, fstype:%q, begin to mount\", </del> <ins> klog.V(4).Infof(\"mount options(%q) source:%q, target:%q, fstype:%q, begin to mount\", </ins> options, source, target, fstype) <del> bindSource := \"\" </del> <ins> bindSource := source </ins> // tell it's going to mount azure disk or azure file according to options if bind, _, _ := isBind(options); bind {", "commid": "kubernetes_pr_73661"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-54c721787801f302bf73cc1b2dd5a4c401204e68c80dfcb6e42ea3d8ce05c21e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: azure file remount on Windows in same node would fail What you expected to happen: If user delete a pod with azure file mount in deployment and it would probably schedule a pod on same node, azure file mount will fail since command would fail if file share is already mounted on the node: It's related to bug: Error logs would be like following: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.9-v1.12, master Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /assign\n/sig windows\n/sig azure\n/milestone v1.14 cc This may be good to backport to 1.12 or 1.13 too if customers are using those versions.", "positive_passages": [{"docid": "doc-en-kubernetes-a2cb8bdcc942501e7b45d0ac639f4a515307a9d86fd5e4fb21186ab882e3ab22", "text": "bindSource = normalizeWindowsPath(source) } else { if len(options) < 2 { <del> klog.Warningf(\"azureMount: mount options(%q) command number(%d) less than 2, source:%q, target:%q, skip mounting\", </del> <ins> klog.Warningf(\"mount options(%q) command number(%d) less than 2, source:%q, target:%q, skip mounting\", </ins> options, len(options), source, target) return nil } // currently only cifs mount is supported if strings.ToLower(fstype) != \"cifs\" { <del> return fmt.Errorf(\"azureMount: only cifs mount is supported now, fstype: %q, mounting source (%q), target (%q), with options (%q)\", fstype, source, target, options) </del> <ins> return fmt.Errorf(\"only cifs mount is supported now, fstype: %q, mounting source (%q), target (%q), with options (%q)\", fstype, source, target, options) </ins> } <del> bindSource = source // use PowerShell Environment Variables to store user input string to prevent command line injection // https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_environment_variables?view=powershell-5.1 cmdLine := fmt.Sprintf(`$PWord = ConvertTo-SecureString -String $Env:smbpassword -AsPlainText -Force` + `;$Credential = New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList $Env:smbuser, $PWord` + `;New-SmbGlobalMapping -RemotePath $Env:smbremotepath -Credential $Credential`) cmd := exec.Command(\"powershell\", \"/c\", cmdLine) cmd.Env = append(os.Environ(), fmt.Sprintf(\"smbuser=%s\", options[0]), fmt.Sprintf(\"smbpassword=%s\", options[1]), fmt.Sprintf(\"smbremotepath=%s\", source)) if output, err := cmd.CombinedOutput(); err != nil { return fmt.Errorf(\"azureMount: SmbGlobalMapping failed: %v, only SMB mount is supported now, output: %q\", err, string(output)) </del> <ins> if output, err := newSMBMapping(options[0], options[1], source); err != nil { if isSMBMappingExist(source) { klog.V(2).Infof(\"SMB Mapping(%s) already exists, now begin to remove and remount\", source) if output, err := removeSMBMapping(source); err != nil { return fmt.Errorf(\"Remove-SmbGlobalMapping failed: %v, output: %q\", err, output) } if output, err := newSMBMapping(options[0], options[1], source); err != nil { return fmt.Errorf(\"New-SmbGlobalMapping remount failed: %v, output: %q\", err, output) } } else { return fmt.Errorf(\"New-SmbGlobalMapping failed: %v, output: %q\", err, output) } </ins> } }", "commid": "kubernetes_pr_73661"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-54c721787801f302bf73cc1b2dd5a4c401204e68c80dfcb6e42ea3d8ce05c21e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: azure file remount on Windows in same node would fail What you expected to happen: If user delete a pod with azure file mount in deployment and it would probably schedule a pod on same node, azure file mount will fail since command would fail if file share is already mounted on the node: It's related to bug: Error logs would be like following: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.9-v1.12, master Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /assign\n/sig windows\n/sig azure\n/milestone v1.14 cc This may be good to backport to 1.12 or 1.13 too if customers are using those versions.", "positive_passages": [{"docid": "doc-en-kubernetes-71a6d2fdd07d97361f94081c54ca0df81d389a8f4c1f6b69fcbe8f487c666ce3", "text": "return nil } <ins> // do the SMB mount with username, password, remotepath // return (output, error) func newSMBMapping(username, password, remotepath string) (string, error) { if username == \"\" || password == \"\" || remotepath == \"\" { return \"\", fmt.Errorf(\"invalid parameter(username: %s, password: %s, remoteapth: %s)\", username, password, remotepath) } // use PowerShell Environment Variables to store user input string to prevent command line injection // https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_environment_variables?view=powershell-5.1 cmdLine := `$PWord = ConvertTo-SecureString -String $Env:smbpassword -AsPlainText -Force` + `;$Credential = New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList $Env:smbuser, $PWord` + `;New-SmbGlobalMapping -RemotePath $Env:smbremotepath -Credential $Credential` cmd := exec.Command(\"powershell\", \"/c\", cmdLine) cmd.Env = append(os.Environ(), fmt.Sprintf(\"smbuser=%s\", username), fmt.Sprintf(\"smbpassword=%s\", password), fmt.Sprintf(\"smbremotepath=%s\", remotepath)) output, err := cmd.CombinedOutput() return string(output), err } // check whether remotepath is already mounted func isSMBMappingExist(remotepath string) bool { cmd := exec.Command(\"powershell\", \"/c\", `Get-SmbGlobalMapping -RemotePath $Env:smbremotepath`) cmd.Env = append(os.Environ(), fmt.Sprintf(\"smbremotepath=%s\", remotepath)) _, err := cmd.CombinedOutput() return err == nil } // remove SMB mapping func removeSMBMapping(remotepath string) (string, error) { cmd := exec.Command(\"powershell\", \"/c\", `Remove-SmbGlobalMapping -RemotePath $Env:smbremotepath -Force`) cmd.Env = append(os.Environ(), fmt.Sprintf(\"smbremotepath=%s\", remotepath)) output, err := cmd.CombinedOutput() return string(output), err } </ins> // Unmount unmounts the target. func (mounter *Mounter) Unmount(target string) error { klog.V(4).Infof(\"azureMount: Unmount target (%q)\", target)", "commid": "kubernetes_pr_73661"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-54c721787801f302bf73cc1b2dd5a4c401204e68c80dfcb6e42ea3d8ce05c21e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: azure file remount on Windows in same node would fail What you expected to happen: If user delete a pod with azure file mount in deployment and it would probably schedule a pod on same node, azure file mount will fail since command would fail if file share is already mounted on the node: It's related to bug: Error logs would be like following: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.9-v1.12, master Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /assign\n/sig windows\n/sig azure\n/milestone v1.14 cc This may be good to backport to 1.12 or 1.13 too if customers are using those versions.", "positive_passages": [{"docid": "doc-en-kubernetes-d47984bf983e95b842ef4be00fe353e1bb8948996c3e90d2fe94e042b8f2dfd2", "text": "} } } <ins> func TestNewSMBMapping(t *testing.T) { tests := []struct { username    string password    string remotepath  string expectError bool }{ { \"\", \"password\", `remotepath`, true, }, { \"username\", \"\", `remotepath`, true, }, { \"username\", \"password\", \"\", true, }, } for _, test := range tests { _, err := newSMBMapping(test.username, test.password, test.remotepath) if test.expectError { assert.NotNil(t, err, \"Expect error during newSMBMapping(%s, %s, %s, %v)\", test.username, test.password, test.remotepath) } else { assert.Nil(t, err, \"Expect error is nil during newSMBMapping(%s, %s, %s, %v)\", test.username, test.password, test.remotepath) } } } </ins>", "commid": "kubernetes_pr_73661"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8e63dbf625d4bef689d56756744a33822ff52bb047451e9e4f46ad247787e451", "query": "We need to add Windows-specific DNS tests to cover the following fields: Test cases needed for : Default, ClusterFirst, None Test cases needed for Test cases needed for Test cases needed for These need to run on Windows containers because the domain resolution policy is different, so different results need to be checked. Windows assumes that any name with a in it is a FQDN, not a PQDN. There is an to cover simple PQDN resolution, but they don't cover the Pod DNS configurations above. /sig windows /milestone v1.14\nFYI I'm working on this. I plan to start out by porting over to Windows.\nI just moved it into the in progress column. THanks!\nWhat test cases are needed for , , and ? My thoughts were that covers and . I'm adding test cases for Default and ClusterFirst. Does cover the test cases needed for and or do I need more? Or should I just be porting over the entire file?\nFor the first one - yes. The main differences will be checking the output of instead of , and maybe using instead of but the flow is the same Checking second one now\nAgree on second one. I think that will cover it. It may make sense to simplify it a bit because the common methods used there are all based on running bash + dig. If it works with busybox, that may be feasible. The description at matches those test cases\nIf at all possible, could we use native Windows cmdlets such as instead of relying on Linux cmdlets that have been ported to Windows like ? Am not 100% confident if they are going to behave consistently.\nyeah, I think what David's suggesting makes sense if the test cases are forked for Windows.\nOpened PR for enabling custom DNS on Azure CNI:\n/milestone clear This will need to merge after 1.14 as we're waiting on CNI updates for these tests to pass. I this status note to the Windows kep\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-326b1166293395eac03d777910db2588a3f1dcb02baf622fbd4dbb5e4098eb1f", "text": "name = \"go_default_library\", srcs = [ \"density.go\", <ins> \"dns.go\", </ins> \"framework.go\", \"gmsa.go\", \"hybrid_network.go\",", "commid": "kubernetes_pr_74925"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8e63dbf625d4bef689d56756744a33822ff52bb047451e9e4f46ad247787e451", "query": "We need to add Windows-specific DNS tests to cover the following fields: Test cases needed for : Default, ClusterFirst, None Test cases needed for Test cases needed for Test cases needed for These need to run on Windows containers because the domain resolution policy is different, so different results need to be checked. Windows assumes that any name with a in it is a FQDN, not a PQDN. There is an to cover simple PQDN resolution, but they don't cover the Pod DNS configurations above. /sig windows /milestone v1.14\nFYI I'm working on this. I plan to start out by porting over to Windows.\nI just moved it into the in progress column. THanks!\nWhat test cases are needed for , , and ? My thoughts were that covers and . I'm adding test cases for Default and ClusterFirst. Does cover the test cases needed for and or do I need more? Or should I just be porting over the entire file?\nFor the first one - yes. The main differences will be checking the output of instead of , and maybe using instead of but the flow is the same Checking second one now\nAgree on second one. I think that will cover it. It may make sense to simplify it a bit because the common methods used there are all based on running bash + dig. If it works with busybox, that may be feasible. The description at matches those test cases\nIf at all possible, could we use native Windows cmdlets such as instead of relying on Linux cmdlets that have been ported to Windows like ? Am not 100% confident if they are going to behave consistently.\nyeah, I think what David's suggesting makes sense if the test cases are forked for Windows.\nOpened PR for enabling custom DNS on Azure CNI:\n/milestone clear This will need to merge after 1.14 as we're waiting on CNI updates for these tests to pass. I this status note to the Windows kep\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-f0c794665e94cef32132ecb9f8c8484990771cdda799d35619c3cbe4c90571a1", "text": "<ins> /* Copyright 2019 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package windows import ( \"regexp\" \"strings\" v1 \"k8s.io/api/core/v1\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/kubernetes/test/e2e/framework\" e2elog \"k8s.io/kubernetes/test/e2e/framework/log\" imageutils \"k8s.io/kubernetes/test/utils/image\" \"github.com/onsi/ginkgo\" ) const dnsTestPodHostName = \"dns-querier-1\" const dnsTestServiceName = \"dns-test-service\" var _ = SIGDescribe(\"DNS\", func() { ginkgo.BeforeEach(func() { framework.SkipUnlessNodeOSDistroIs(\"windows\") }) f := framework.NewDefaultFramework(\"dns\") ginkgo.It(\"should support configurable pod DNS servers\", func() { ginkgo.By(\"Preparing a test DNS service with injected DNS names...\") testInjectedIP := \"1.1.1.1\" testSearchPath := \"resolv.conf.local\" ginkgo.By(\"Creating a pod with dnsPolicy=None and customized dnsConfig...\") testUtilsPod := generateDNSUtilsPod() testUtilsPod.Spec.DNSPolicy = v1.DNSNone testUtilsPod.Spec.DNSConfig = &v1.PodDNSConfig{ Nameservers: []string{testInjectedIP}, Searches:    []string{testSearchPath}, } testUtilsPod, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(testUtilsPod) framework.ExpectNoError(err) e2elog.Logf(\"Created pod %v\", testUtilsPod) defer func() { e2elog.Logf(\"Deleting pod %s...\", testUtilsPod.Name) if err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Delete(testUtilsPod.Name, metav1.NewDeleteOptions(0)); err != nil { e2elog.Failf(\"Failed to delete pod %s: %v\", testUtilsPod.Name, err) } }() framework.ExpectNoError(f.WaitForPodRunning(testUtilsPod.Name), \"failed to wait for pod %s to be running\", testUtilsPod.Name) ginkgo.By(\"Verifying customized DNS option is configured on pod...\") cmd := []string{\"ipconfig\", \"/all\"} stdout, _, err := f.ExecWithOptions(framework.ExecOptions{ Command:       cmd, Namespace:     f.Namespace.Name, PodName:       testUtilsPod.Name, ContainerName: \"util\", CaptureStdout: true, CaptureStderr: true, }) framework.ExpectNoError(err) e2elog.Logf(\"ipconfig /all:n%s\", stdout) dnsRegex, err := regexp.Compile(`DNS Servers[s*.]*:(s*[0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3})+`) if dnsRegex.MatchString(stdout) { match := dnsRegex.FindString(stdout) if !strings.Contains(match, testInjectedIP) { e2elog.Failf(\"customized DNS options not found in ipconfig /all, got: %s\", match) } } else { e2elog.Failf(\"cannot find DNS server info in ipconfig /all output: n%s\", stdout) } // TODO: Add more test cases for other DNSPolicies. }) }) func generateDNSUtilsPod() *v1.Pod { return &v1.Pod{ TypeMeta: metav1.TypeMeta{ Kind: \"Pod\", }, ObjectMeta: metav1.ObjectMeta{ GenerateName: \"e2e-dns-utils-\", }, Spec: v1.PodSpec{ Containers: []v1.Container{ { Name:    \"util\", Image:   imageutils.GetE2EImage(imageutils.Dnsutils), Command: []string{\"sleep\", \"10000\"}, }, }, }, } } </ins>", "commid": "kubernetes_pr_74925"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8baab40e69f0284fe537fe8f20f37c00d552721258221dd50325dab698334f76", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!--What happened: In an otherwise-stable bare-metal setup, with only LocalVolume and NFS storage, and without any volume mount activity, I get 80,000+ of these warning messages per day: What you expected to happen: No warnings; and if there is a reason to generate these warnings, more info about what operation is being attempted should be to the warnings message. How to reproduce it (as minimally and precisely as possible): I don't know. This issue emerged after I about 40 services and 300 volumes on a 3-worker cluster. Anything else we need to know?: Environment: Kubernetes version (use ): 1.13.0Cloud provider or hardware configuration: Bare-metal OS (e.g. from /etc/os-release): Ubuntu 18.04.1 bionic Kernel (e.g. ): 4.15.0-42-generic Install tools: kubeadm Others:\n/sig storage", "positive_passages": [{"docid": "doc-en-kubernetes-5c406def9f19d087b43622eba3441511fcbc5e75949e569c5e6683a747c5dd5b", "text": "if spec.IsKubeletExpandable() { // for kubelet expandable volumes, return a noop plugin that // returns success for expand on the controller <del> klog.Warningf(\"FindExpandablePluginBySpec(%s) -> returning noopExpandableVolumePluginInstance\", spec.Name()) </del> <ins> klog.V(4).Infof(\"FindExpandablePluginBySpec(%s) -> returning noopExpandableVolumePluginInstance\", spec.Name()) </ins> return &noopExpandableVolumePluginInstance{spec}, nil } <del> klog.Warningf(\"FindExpandablePluginBySpec(%s) -> err:%v\", spec.Name(), err) </del> <ins> klog.V(4).Infof(\"FindExpandablePluginBySpec(%s) -> err:%v\", spec.Name(), err) </ins> return nil, err }", "commid": "kubernetes_pr_73901"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a58991ec54e0de3f67ffc848889c93ae955a2930e4c50ed7fa5e4ebd3e04ff11", "query": "Which jobs are failing: Which test(s) are failing: Job Reason for failure --- --- Since when has it been failing: 2019-02-11 Anything else we need to know: started failing with commit started failing with commit cc /kind failing-test /priority important-soon /sig api-machinery", "positive_passages": [{"docid": "doc-en-kubernetes-21e119333236d4f8db2ed7f7b4cb2f60caaf61469f0957c8b4c7922fd65b0be7", "text": "optional APIServiceStatus status = 3; } <ins> // APIServiceCondition describes the state of an APIService at a particular point </ins> message APIServiceCondition { // Type is the type of the condition. optional string type = 1;", "commid": "kubernetes_pr_74012"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-da635c92143e1506eed36bd24ea751bd342a1a4539f250ba5d99681805edffe2", "query": "What happened: The preparation step of the e2e tests were failed sometimes on my local environment like What you expected to happen: These tests can be passed without any errors. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.13.1 Cloud provider or hardware configuration: OpenStack OS (e.g. from /etc/os-release): 16.04.4 LTS (Xenial Xerus) Kernel (e.g. ): 4.4.0-138-generic Install tools: kubeadm Others:\n/sig storage\nAfter discussing on the PR I have known I need to enable StorageObjectInUseProtection plugin of admission controller which is disabled by default. The corresponding e2e tests require the plugin is enabled, so I think it is better to enable the plugin by default for most users.\nInvestigation of StorageObjectInUseProtection plugin of admission controller under kubernetes/kubernetes: cluster/centos/config- Enabled cluster/gce/config- Enabled cluster/gce/config- Enabled cluster/kubemark/gce/config- Enabled hack/local-up- Enabled cluster/juju/layers/kubernetes- Disabled This is the reason why we don't face this issue on the upstream CI system, and I it on my local environment which is deployed with kubeadm.", "positive_passages": [{"docid": "doc-en-kubernetes-4267b3ec6dbc8c0d9d2ff70a382a0d4f2bde6b5200d2abbf5ffeb35ee35c28ae", "text": "# Admission Controllers to invoke prior to persisting objects in cluster ENABLE_ADMISSION_PLUGINS=\"LimitRanger,ResourceQuota\" <del> DISABLE_ADMISSION_PLUGINS=\"ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook\" </del> <ins> DISABLE_ADMISSION_PLUGINS=\"ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,StorageObjectInUseProtection\" </ins> # Include RBAC (to exercise bootstrapping), and AlwaysAllow to allow all actions AUTHORIZATION_MODE=\"RBAC,AlwaysAllow\"", "commid": "kubernetes_pr_74610"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-da635c92143e1506eed36bd24ea751bd342a1a4539f250ba5d99681805edffe2", "query": "What happened: The preparation step of the e2e tests were failed sometimes on my local environment like What you expected to happen: These tests can be passed without any errors. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.13.1 Cloud provider or hardware configuration: OpenStack OS (e.g. from /etc/os-release): 16.04.4 LTS (Xenial Xerus) Kernel (e.g. ): 4.4.0-138-generic Install tools: kubeadm Others:\n/sig storage\nAfter discussing on the PR I have known I need to enable StorageObjectInUseProtection plugin of admission controller which is disabled by default. The corresponding e2e tests require the plugin is enabled, so I think it is better to enable the plugin by default for most users.\nInvestigation of StorageObjectInUseProtection plugin of admission controller under kubernetes/kubernetes: cluster/centos/config- Enabled cluster/gce/config- Enabled cluster/gce/config- Enabled cluster/kubemark/gce/config- Enabled hack/local-up- Enabled cluster/juju/layers/kubernetes- Disabled This is the reason why we don't face this issue on the upstream CI system, and I it on my local environment which is deployed with kubeadm.", "positive_passages": [{"docid": "doc-en-kubernetes-6a354443d63dcc7852dfc234aff0605708480aaff761d6bac5fcd6004a11d5e8", "text": "ETCDCTL=$(which etcdctl) KUBECTL=\"${KUBE_OUTPUT_HOSTBIN}/kubectl\" UPDATE_ETCD_OBJECTS_SCRIPT=\"${KUBE_ROOT}/cluster/update-storage-objects.sh\" <del> DISABLE_ADMISSION_PLUGINS=\"ServiceAccount,NamespaceLifecycle,LimitRanger,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota,PersistentVolumeLabel,DefaultStorageClass\" </del> <ins> DISABLE_ADMISSION_PLUGINS=\"ServiceAccount,NamespaceLifecycle,LimitRanger,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota,PersistentVolumeLabel,DefaultStorageClass,StorageObjectInUseProtection\" </ins> function startApiServer() { local storage_versions=${1:-\"\"}", "commid": "kubernetes_pr_74610"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-da635c92143e1506eed36bd24ea751bd342a1a4539f250ba5d99681805edffe2", "query": "What happened: The preparation step of the e2e tests were failed sometimes on my local environment like What you expected to happen: These tests can be passed without any errors. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.13.1 Cloud provider or hardware configuration: OpenStack OS (e.g. from /etc/os-release): 16.04.4 LTS (Xenial Xerus) Kernel (e.g. ): 4.4.0-138-generic Install tools: kubeadm Others:\n/sig storage\nAfter discussing on the PR I have known I need to enable StorageObjectInUseProtection plugin of admission controller which is disabled by default. The corresponding e2e tests require the plugin is enabled, so I think it is better to enable the plugin by default for most users.\nInvestigation of StorageObjectInUseProtection plugin of admission controller under kubernetes/kubernetes: cluster/centos/config- Enabled cluster/gce/config- Enabled cluster/gce/config- Enabled cluster/kubemark/gce/config- Enabled hack/local-up- Enabled cluster/juju/layers/kubernetes- Disabled This is the reason why we don't face this issue on the upstream CI system, and I it on my local environment which is deployed with kubeadm.", "positive_passages": [{"docid": "doc-en-kubernetes-6bcb65b488b20e53230f85dbdfe443195b733d9c5a2d44a4a3b8683a9f562d70", "text": "// DefaultOffAdmissionPlugins get admission plugins off by default for kube-apiserver. func DefaultOffAdmissionPlugins() sets.String { defaultOnPlugins := sets.NewString( <del> lifecycle.PluginName,                //NamespaceLifecycle limitranger.PluginName,              //LimitRanger serviceaccount.PluginName,           //ServiceAccount setdefault.PluginName,               //DefaultStorageClass resize.PluginName,                   //PersistentVolumeClaimResize defaulttolerationseconds.PluginName, //DefaultTolerationSeconds mutatingwebhook.PluginName,          //MutatingAdmissionWebhook validatingwebhook.PluginName,        //ValidatingAdmissionWebhook resourcequota.PluginName,            //ResourceQuota </del> <ins> lifecycle.PluginName,                    //NamespaceLifecycle limitranger.PluginName,                  //LimitRanger serviceaccount.PluginName,               //ServiceAccount setdefault.PluginName,                   //DefaultStorageClass resize.PluginName,                       //PersistentVolumeClaimResize defaulttolerationseconds.PluginName,     //DefaultTolerationSeconds mutatingwebhook.PluginName,              //MutatingAdmissionWebhook validatingwebhook.PluginName,            //ValidatingAdmissionWebhook resourcequota.PluginName,                //ResourceQuota storageobjectinuseprotection.PluginName, //StorageObjectInUseProtection </ins> ) if utilfeature.DefaultFeatureGate.Enabled(features.PodPriority) {", "commid": "kubernetes_pr_74610"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a34100f2eb8400ab82f47190ab9c18caed04a9eb22795d23b67020c7edc6c623", "query": "I have been deploying master-branch kubernetes on Windows using flannel/host-gateway networking, with one master, one linux worker, and three windows worker. Recently, kube-proxy stopped running correctly. It exits with an error about not finding the HNS Network. I have confirmed that the HNS network exists on the host with the correct name (cbr0), and have identified the last commit where kube-proxy works. What happened: Starting with the commit merging , kube-proxy outputs the following error message: This is confusing because does show : (nat network removed from above output) What you expected to happen: kube-proxy to work in host-gateway mode. How to reproduce it (as minimally and precisely as possible): Build kubernetes at or after . Start flanneld, kubelet, and kube-proxy on a windows 2019 vm. See kube-proxy fail despite flanneld having created the network. Anything else we need to know?: Environment: Kubernetes version (use ): kube-proxy breaks on commit and later; works on Cloud provider or hardware configuration: vsphere OS (e.g: ): windows server 2019, with up-to-date patches Kernel (e.g. ): windows nodes are , linux master/worker are Install tools: deployed using /sig windows cc\nI'm aware of this issue. The fix will be out within an hour.", "positive_passages": [{"docid": "doc-en-kubernetes-7d6dad6af470623bf82d49ff3be1f0dc5b9ed002cc522acd8d85a3c575c266a8", "text": "var hns HostNetworkService hns = hnsV1{} supportedFeatures := hcn.GetSupportedFeatures() <del> if supportedFeatures.Api.V2 { </del> <ins> if supportedFeatures.RemoteSubnet { </ins> hns = hnsV2{} }", "commid": "kubernetes_pr_74436"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5560ce61eb1481212ee336127c07ce979a7d506aa207b599921813846f59ed3b", "query": "Which jobs are failing: All new tests introduced for api change Which test(s) are failing: New alpha subpathExpr tests [Feature:VolumeSubpathEnvExpansion][NodeAlphaFeature:VolumeSubpathEnvExpansion] Existing tests are working fine and the whole suite works correctly in the gce suite https://k8s- Since when has it been failing: 21st February 2019 (since merge of PR) Testgrid link: https://k8s- Reason for failure: Investigation shows that node e2e tests use a different framework pod creation pattern Doing some comparisons of tests that work and those that don't reveals differences in the standard client set as and the existing ones which do work go through the intermediate which uses The version has an additional function specifically for node tests\n/sig storage\n/sig node /sig test\n/assign\n/cc\n/sig test", "positive_passages": [{"docid": "doc-en-kubernetes-461c1cfc2820adde1e2bb4addde373da2c67ab09a9a4561e14fe1f21b7d1bde2", "text": "} By(\"creating the pod with failed condition\") <del> pod, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(pod) Expect(err).ToNot(HaveOccurred(), \"while creating pod\") err = framework.WaitTimeoutForPodRunningInNamespace(f.ClientSet, pod.Name, pod.Namespace, framework.PodStartShortTimeout) Expect(err).To(HaveOccurred(), \"while waiting for pod to be running\") </del> var podClient *framework.PodClient podClient = f.PodClient() <ins> pod = podClient.Create(pod) err := framework.WaitTimeoutForPodRunningInNamespace(f.ClientSet, pod.Name, pod.Namespace, framework.PodStartShortTimeout) Expect(err).To(HaveOccurred(), \"while waiting for pod to be running\") </ins> By(\"updating the pod\") podClient.Update(podName, func(pod *v1.Pod) {", "commid": "kubernetes_pr_74660"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5560ce61eb1481212ee336127c07ce979a7d506aa207b599921813846f59ed3b", "query": "Which jobs are failing: All new tests introduced for api change Which test(s) are failing: New alpha subpathExpr tests [Feature:VolumeSubpathEnvExpansion][NodeAlphaFeature:VolumeSubpathEnvExpansion] Existing tests are working fine and the whole suite works correctly in the gce suite https://k8s- Since when has it been failing: 21st February 2019 (since merge of PR) Testgrid link: https://k8s- Reason for failure: Investigation shows that node e2e tests use a different framework pod creation pattern Doing some comparisons of tests that work and those that don't reveals differences in the standard client set as and the existing ones which do work go through the intermediate which uses The version has an additional function specifically for node tests\n/sig storage\n/sig node /sig test\n/assign\n/cc\n/sig test", "positive_passages": [{"docid": "doc-en-kubernetes-6f81eb5f18c35d95c1265384fae11abfc82c1db09cff6bbc4ae106e0ac551783", "text": "} By(\"creating the pod\") <del> pod, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(pod) </del> <ins> var podClient *framework.PodClient podClient = f.PodClient() pod = podClient.Create(pod) </ins> By(\"waiting for pod running\") <del> err = framework.WaitTimeoutForPodRunningInNamespace(f.ClientSet, pod.Name, pod.Namespace, framework.PodStartShortTimeout) </del> <ins> err := framework.WaitTimeoutForPodRunningInNamespace(f.ClientSet, pod.Name, pod.Namespace, framework.PodStartShortTimeout) </ins> Expect(err).NotTo(HaveOccurred(), \"while waiting for pod to be running\") By(\"creating a file in subpath\")", "commid": "kubernetes_pr_74660"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5560ce61eb1481212ee336127c07ce979a7d506aa207b599921813846f59ed3b", "query": "Which jobs are failing: All new tests introduced for api change Which test(s) are failing: New alpha subpathExpr tests [Feature:VolumeSubpathEnvExpansion][NodeAlphaFeature:VolumeSubpathEnvExpansion] Existing tests are working fine and the whole suite works correctly in the gce suite https://k8s- Since when has it been failing: 21st February 2019 (since merge of PR) Testgrid link: https://k8s- Reason for failure: Investigation shows that node e2e tests use a different framework pod creation pattern Doing some comparisons of tests that work and those that don't reveals differences in the standard client set as and the existing ones which do work go through the intermediate which uses The version has an additional function specifically for node tests\n/sig storage\n/sig node /sig test\n/assign\n/cc\n/sig test", "positive_passages": [{"docid": "doc-en-kubernetes-43d645af64ccd6471e724a890fbf07dca6cd627bad6c8b9bccaa30b3789f5ff1", "text": "} By(\"updating the annotation value\") <del> var podClient *framework.PodClient podClient = f.PodClient() </del> podClient.Update(podName, func(pod *v1.Pod) { pod.ObjectMeta.Annotations[\"mysubpath\"] = \"mynewpath\" })", "commid": "kubernetes_pr_74660"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5560ce61eb1481212ee336127c07ce979a7d506aa207b599921813846f59ed3b", "query": "Which jobs are failing: All new tests introduced for api change Which test(s) are failing: New alpha subpathExpr tests [Feature:VolumeSubpathEnvExpansion][NodeAlphaFeature:VolumeSubpathEnvExpansion] Existing tests are working fine and the whole suite works correctly in the gce suite https://k8s- Since when has it been failing: 21st February 2019 (since merge of PR) Testgrid link: https://k8s- Reason for failure: Investigation shows that node e2e tests use a different framework pod creation pattern Doing some comparisons of tests that work and those that don't reveals differences in the standard client set as and the existing ones which do work go through the intermediate which uses The version has an additional function specifically for node tests\n/sig storage\n/sig node /sig test\n/assign\n/cc\n/sig test", "positive_passages": [{"docid": "doc-en-kubernetes-8f706dc69fcfd3384580aaa8f75853060d1fb2ee8f56c0b2ff0ccfec0b60f580", "text": "// Start pod By(fmt.Sprintf(\"Creating pod %s\", pod.Name)) <del> pod, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(pod) Expect(err).ToNot(HaveOccurred(), \"while creating pod\") </del> <ins> var podClient *framework.PodClient podClient = f.PodClient() pod = podClient.Create(pod) </ins> defer func() { framework.DeletePodWithWait(f, f.ClientSet, pod) }() <del> err = framework.WaitForPodRunningInNamespace(f.ClientSet, pod) </del> <ins> err := framework.WaitForPodRunningInNamespace(f.ClientSet, pod) </ins> Expect(err).ToNot(HaveOccurred(), \"while waiting for pod to be running\") <del> var podClient *framework.PodClient podClient = f.PodClient() </del> By(\"updating the pod\") podClient.Update(podName, func(pod *v1.Pod) { pod.ObjectMeta.Annotations = map[string]string{\"mysubpath\": \"newsubpath\"}", "commid": "kubernetes_pr_74660"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5560ce61eb1481212ee336127c07ce979a7d506aa207b599921813846f59ed3b", "query": "Which jobs are failing: All new tests introduced for api change Which test(s) are failing: New alpha subpathExpr tests [Feature:VolumeSubpathEnvExpansion][NodeAlphaFeature:VolumeSubpathEnvExpansion] Existing tests are working fine and the whole suite works correctly in the gce suite https://k8s- Since when has it been failing: 21st February 2019 (since merge of PR) Testgrid link: https://k8s- Reason for failure: Investigation shows that node e2e tests use a different framework pod creation pattern Doing some comparisons of tests that work and those that don't reveals differences in the standard client set as and the existing ones which do work go through the intermediate which uses The version has an additional function specifically for node tests\n/sig storage\n/sig node /sig test\n/assign\n/cc\n/sig test", "positive_passages": [{"docid": "doc-en-kubernetes-c65e24624e3311d679b55f03d170478739e91461856ba324dd88a1d791668ca8", "text": "func testPodFailSubpath(f *framework.Framework, pod *v1.Pod) { <del> pod, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(pod) Expect(err).ToNot(HaveOccurred(), \"while creating pod\") </del> <ins> var podClient *framework.PodClient podClient = f.PodClient() pod = podClient.Create(pod) </ins> defer func() { framework.DeletePodWithWait(f, f.ClientSet, pod) }() <del> err = framework.WaitTimeoutForPodRunningInNamespace(f.ClientSet, pod.Name, pod.Namespace, framework.PodStartShortTimeout) </del> <ins> err := framework.WaitTimeoutForPodRunningInNamespace(f.ClientSet, pod.Name, pod.Namespace, framework.PodStartShortTimeout) </ins> Expect(err).To(HaveOccurred(), \"while waiting for pod to be running\") }", "commid": "kubernetes_pr_74660"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8ea5b149739df9d1153565d68823c4c5efdc3c47d47da1083c1f8303bea2ce0", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: in Which test(s) are failing: Since when has it been failing: 2019-02-27 () -- since it was Testgrid link: Reason for failure: Timeout: Anything else we need to know: /kind failing-test /sig storage /priority important-soon /milestone v1.14 cc\ncc Could you help with this please?\n/assign\nNeither of the failing tests mentioned in this issue are present in testgrid anymore. is all clear", "positive_passages": [{"docid": "doc-en-kubernetes-4ced30d4993e469fe05e14443f0304caf18841914751d61e033ea4b715722700", "text": "var _ = utils.SIGDescribe(\"CSI mock volume\", func() { type testParameters struct { <del> attachable      bool </del> <ins> disableAttach   bool </ins> attachLimit     int registerDriver  bool podInfoVersion  *string", "commid": "kubernetes_pr_74811"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8ea5b149739df9d1153565d68823c4c5efdc3c47d47da1083c1f8303bea2ce0", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: in Which test(s) are failing: Since when has it been failing: 2019-02-27 () -- since it was Testgrid link: Reason for failure: Timeout: Anything else we need to know: /kind failing-test /sig storage /priority important-soon /milestone v1.14 cc\ncc Could you help with this please?\n/assign\nNeither of the failing tests mentioned in this issue are present in testgrid anymore. is all clear", "positive_passages": [{"docid": "doc-en-kubernetes-8c5fe8aafb80b59cc31861b9d1de23e5abbf43274d1f1989e3a03b8d4d1d5192", "text": "csics := f.CSIClientSet var err error <del> m.driver = drivers.InitMockCSIDriver(tp.registerDriver, tp.attachable, tp.podInfoVersion, tp.attachLimit) </del> <ins> m.driver = drivers.InitMockCSIDriver(tp.registerDriver, !tp.disableAttach, tp.podInfoVersion, tp.attachLimit) </ins> config, testCleanup := m.driver.PrepareTest(f) m.testCleanups = append(m.testCleanups, testCleanup) m.config = config", "commid": "kubernetes_pr_74811"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8ea5b149739df9d1153565d68823c4c5efdc3c47d47da1083c1f8303bea2ce0", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: in Which test(s) are failing: Since when has it been failing: 2019-02-27 () -- since it was Testgrid link: Reason for failure: Timeout: Anything else we need to know: /kind failing-test /sig storage /priority important-soon /milestone v1.14 cc\ncc Could you help with this please?\n/assign\nNeither of the failing tests mentioned in this issue are present in testgrid anymore. is all clear", "positive_passages": [{"docid": "doc-en-kubernetes-b4942d1e3ae82d318fcc3eec30b30ac3a1ccba14a26dc76c4ddc3f41de3e611b", "text": "// The CSIDriverRegistry feature gate is needed for this test in Kubernetes 1.12. Context(\"CSI attach test using mock driver [Feature:CSIDriverRegistry]\", func() { tests := []struct { <del> name             string driverAttachable bool deployDriverCRD  bool </del> <ins> name            string disableAttach   bool deployDriverCRD bool </ins> }{ { <del> name:             \"should not require VolumeAttach for drivers without attachment\", driverAttachable: false, deployDriverCRD:  true, </del> <ins> name:            \"should not require VolumeAttach for drivers without attachment\", disableAttach:   true, deployDriverCRD: true, </ins> }, { <del> name:             \"should require VolumeAttach for drivers with attachment\", driverAttachable: true, deployDriverCRD:  true, </del> <ins> name:            \"should require VolumeAttach for drivers with attachment\", deployDriverCRD: true, </ins> }, { <del> name:             \"should preserve attachment policy when no CSIDriver present\", driverAttachable: true, deployDriverCRD:  false, </del> <ins> name:            \"should preserve attachment policy when no CSIDriver present\", deployDriverCRD: false, </ins> }, } for _, t := range tests { test := t It(t.name, func() { var err error <del> init(testParameters{registerDriver: test.deployDriverCRD, attachable: test.driverAttachable}) </del> <ins> init(testParameters{registerDriver: test.deployDriverCRD, disableAttach: test.disableAttach}) </ins> defer cleanup() _, claim, pod := createPod()", "commid": "kubernetes_pr_74811"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8ea5b149739df9d1153565d68823c4c5efdc3c47d47da1083c1f8303bea2ce0", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: in Which test(s) are failing: Since when has it been failing: 2019-02-27 () -- since it was Testgrid link: Reason for failure: Timeout: Anything else we need to know: /kind failing-test /sig storage /priority important-soon /milestone v1.14 cc\ncc Could you help with this please?\n/assign\nNeither of the failing tests mentioned in this issue are present in testgrid anymore. is all clear", "positive_passages": [{"docid": "doc-en-kubernetes-d24b0902f4623ec0e625ea5ea18ab5cacbc10065e5aad2dbe9c4f94d19887768", "text": "_, err = m.cs.StorageV1beta1().VolumeAttachments().Get(attachmentName, metav1.GetOptions{}) if err != nil { if errors.IsNotFound(err) { <del> if test.driverAttachable { </del> <ins> if !test.disableAttach { </ins> framework.ExpectNoError(err, \"Expected VolumeAttachment but none was found\") } } else { framework.ExpectNoError(err, \"Failed to find VolumeAttachment\") } } <del> if !test.driverAttachable { </del> <ins> if test.disableAttach { </ins> Expect(err).To(HaveOccurred(), \"Unexpected VolumeAttachment found\") } })", "commid": "kubernetes_pr_74811"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8ea5b149739df9d1153565d68823c4c5efdc3c47d47da1083c1f8303bea2ce0", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: in Which test(s) are failing: Since when has it been failing: 2019-02-27 () -- since it was Testgrid link: Reason for failure: Timeout: Anything else we need to know: /kind failing-test /sig storage /priority important-soon /milestone v1.14 cc\ncc Could you help with this please?\n/assign\nNeither of the failing tests mentioned in this issue are present in testgrid anymore. is all clear", "positive_passages": [{"docid": "doc-en-kubernetes-ed9879deabe4187cdbf8eb4c52a8d5634645821a5a521791ad3abbbf63208bfd", "text": "// define volume limit to be 2 for this test var err error <del> init(testParameters{attachable: true, nodeSelectorKey: \"node-attach-limit-csi\", attachLimit: 2}) </del> <ins> init(testParameters{nodeSelectorKey: \"node-attach-limit-csi\", attachLimit: 2}) </ins> defer cleanup() nodeName := m.config.ClientNodeName attachKey := v1.ResourceName(volumeutil.GetCSIAttachLimitKey(m.provisioner))", "commid": "kubernetes_pr_74811"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aa432f08c029c053dd7cfcb048f4042f5867f2876fa4810ba8a4c59a6311440b", "query": "What happened: Currently starting Kubectl failing on Azure Stack. What you expected to happen: Kubectl should start on Azure Stack environment. How to reproduce it (as minimally and precisely as possible): Try to deploy Kubernets on Azure Stack environment.. Anything else we need to know?: Environment: Kubernetes version (use kubectl version): master Cloud provider or hardware configuration: OS (e.g: cat /etc/os-release): Kernel (e.g. uname -a): Install tools: Others: /sig azure /assign\nis it ? is a tool ...\nmy bad its kubelet. I update the title.\nthen could you provide the kubelet log? I am not sure kubelet on Azure stack is running as a container or process, you could get the logs by: And how do you deploy k8s on azure stack? cc", "positive_passages": [{"docid": "doc-en-kubernetes-84331981d2f8dbdadd0c4a3931e6fbf822afd1ab6156e104d1aaa822b5c74faa", "text": "func TestGetZone(t *testing.T) { cloud := &Cloud{ Config: Config{ <del> Location: \"eastus\", </del> <ins> Location:            \"eastus\", UseInstanceMetadata: true, </ins> }, } testcases := []struct {", "commid": "kubernetes_pr_74936"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aa432f08c029c053dd7cfcb048f4042f5867f2876fa4810ba8a4c59a6311440b", "query": "What happened: Currently starting Kubectl failing on Azure Stack. What you expected to happen: Kubectl should start on Azure Stack environment. How to reproduce it (as minimally and precisely as possible): Try to deploy Kubernets on Azure Stack environment.. Anything else we need to know?: Environment: Kubernetes version (use kubectl version): master Cloud provider or hardware configuration: OS (e.g: cat /etc/os-release): Kernel (e.g. uname -a): Install tools: Others: /sig azure /assign\nis it ? is a tool ...\nmy bad its kubelet. I update the title.\nthen could you provide the kubelet log? I am not sure kubelet on Azure stack is running as a container or process, you could get the logs by: And how do you deploy k8s on azure stack? cc", "positive_passages": [{"docid": "doc-en-kubernetes-e2a48b3c53b9b3fb3c4a6c3128cf0e8c188c016ea7e8e2ccabe26df16cfe5be4", "text": "import ( \"context\" \"fmt\" <ins> \"os\" </ins> \"strconv\" \"strings\"", "commid": "kubernetes_pr_74936"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aa432f08c029c053dd7cfcb048f4042f5867f2876fa4810ba8a4c59a6311440b", "query": "What happened: Currently starting Kubectl failing on Azure Stack. What you expected to happen: Kubectl should start on Azure Stack environment. How to reproduce it (as minimally and precisely as possible): Try to deploy Kubernets on Azure Stack environment.. Anything else we need to know?: Environment: Kubernetes version (use kubectl version): master Cloud provider or hardware configuration: OS (e.g: cat /etc/os-release): Kernel (e.g. uname -a): Install tools: Others: /sig azure /assign\nis it ? is a tool ...\nmy bad its kubelet. I update the title.\nthen could you provide the kubelet log? I am not sure kubelet on Azure stack is running as a container or process, you could get the logs by: And how do you deploy k8s on azure stack? cc", "positive_passages": [{"docid": "doc-en-kubernetes-f433fe13f3a25062648137a953850f7f4c58234d922a154d27be5976d1e0d199", "text": "// GetZone returns the Zone containing the current availability zone and locality region that the program is running in. // If the node is not running with availability zones, then it will fall back to fault domain. func (az *Cloud) GetZone(ctx context.Context) (cloudprovider.Zone, error) { <del> metadata, err := az.metadata.GetMetadata() if err != nil { return cloudprovider.Zone{}, err } </del> <ins> if az.UseInstanceMetadata { metadata, err := az.metadata.GetMetadata() if err != nil { return cloudprovider.Zone{}, err } </ins> <del> if metadata.Compute == nil { return cloudprovider.Zone{}, fmt.Errorf(\"failure of getting compute information from instance metadata\") } </del> <ins> if metadata.Compute == nil { return cloudprovider.Zone{}, fmt.Errorf(\"failure of getting compute information from instance metadata\") } </ins> <del> zone := \"\" if metadata.Compute.Zone != \"\" { zoneID, err := strconv.Atoi(metadata.Compute.Zone) if err != nil { return cloudprovider.Zone{}, fmt.Errorf(\"failed to parse zone ID %q: %v\", metadata.Compute.Zone, err) </del> <ins> zone := \"\" if metadata.Compute.Zone != \"\" { zoneID, err := strconv.Atoi(metadata.Compute.Zone) if err != nil { return cloudprovider.Zone{}, fmt.Errorf(\"failed to parse zone ID %q: %v\", metadata.Compute.Zone, err) } zone = az.makeZone(zoneID) } else { klog.V(3).Infof(\"Availability zone is not enabled for the node, falling back to fault domain\") zone = metadata.Compute.FaultDomain </ins> } <del> zone = az.makeZone(zoneID) } else { klog.V(3).Infof(\"Availability zone is not enabled for the node, falling back to fault domain\") zone = metadata.Compute.FaultDomain } return cloudprovider.Zone{ FailureDomain: zone, Region:        az.Location, }, nil </del> <ins> return cloudprovider.Zone{ FailureDomain: zone, Region:        az.Location, }, nil } // if UseInstanceMetadata is false, get Zone name by calling ARM hostname, err := os.Hostname() if err != nil { return cloudprovider.Zone{}, fmt.Errorf(\"failure getting hostname from kernel\") } return az.vmSet.GetZoneByNodeName(strings.ToLower(hostname)) </ins> } // GetZoneByProviderID implements Zones.GetZoneByProviderID", "commid": "kubernetes_pr_74936"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-892e0241d063b18638cd5cbf78924bd2bec214bc99c4a6b3f534188c99a38c9e", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : 1) add metrics into kubelet to monitor ; 2) add throttling to . Why is this needed: Kubelet provides lots of its functionalities through its http server, and currently there is no server-side monitoring and throttling mechanisms. Adding metrics into kubelet to monitor its http server will improve its observability and debuggability; adding throttling will prevent kubelet being overloaded from serving too many http requests.\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-cf358c6a382ddc504b10f10196871867a9bf38db84ea07ab7988ebdb636bcb22", "text": "\"//pkg/kubelet/apis/resourcemetrics/v1alpha1:go_default_library\", \"//pkg/kubelet/container:go_default_library\", \"//pkg/kubelet/prober:go_default_library\", <ins> \"//pkg/kubelet/server/metrics:go_default_library\", </ins> \"//pkg/kubelet/server/portforward:go_default_library\", \"//pkg/kubelet/server/remotecommand:go_default_library\", \"//pkg/kubelet/server/stats:go_default_library\",", "commid": "kubernetes_pr_75228"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-892e0241d063b18638cd5cbf78924bd2bec214bc99c4a6b3f534188c99a38c9e", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : 1) add metrics into kubelet to monitor ; 2) add throttling to . Why is this needed: Kubelet provides lots of its functionalities through its http server, and currently there is no server-side monitoring and throttling mechanisms. Adding metrics into kubelet to monitor its http server will improve its observability and debuggability; adding throttling will prevent kubelet being overloaded from serving too many http requests.\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-b22ea17444458c161bf326b91420aae2b36f81f949ea032516ae1a60ab15dae9", "text": "name = \"all-srcs\", srcs = [ \":package-srcs\", <ins> \"//pkg/kubelet/server/metrics:all-srcs\", </ins> \"//pkg/kubelet/server/portforward:all-srcs\", \"//pkg/kubelet/server/remotecommand:all-srcs\", \"//pkg/kubelet/server/stats:all-srcs\",", "commid": "kubernetes_pr_75228"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-892e0241d063b18638cd5cbf78924bd2bec214bc99c4a6b3f534188c99a38c9e", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : 1) add metrics into kubelet to monitor ; 2) add throttling to . Why is this needed: Kubelet provides lots of its functionalities through its http server, and currently there is no server-side monitoring and throttling mechanisms. Adding metrics into kubelet to monitor its http server will improve its observability and debuggability; adding throttling will prevent kubelet being overloaded from serving too many http requests.\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-2d18338f3f3b69a1af2638fe20e1bd88d65259605571be561834ed2070651fe8", "text": "<ins> package(default_visibility = [\"//visibility:public\"]) load( \"@io_bazel_rules_go//go:def.bzl\", \"go_library\", ) go_library( name = \"go_default_library\", srcs = [\"metrics.go\"], importpath = \"k8s.io/kubernetes/pkg/kubelet/server/metrics\", deps = [ \"//vendor/github.com/prometheus/client_golang/prometheus:go_default_library\", ], ) filegroup( name = \"package-srcs\", srcs = glob([\"**\"]), tags = [\"automanaged\"], visibility = [\"//visibility:private\"], ) filegroup( name = \"all-srcs\", srcs = [\":package-srcs\"], tags = [\"automanaged\"], ) </ins>", "commid": "kubernetes_pr_75228"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-892e0241d063b18638cd5cbf78924bd2bec214bc99c4a6b3f534188c99a38c9e", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : 1) add metrics into kubelet to monitor ; 2) add throttling to . Why is this needed: Kubelet provides lots of its functionalities through its http server, and currently there is no server-side monitoring and throttling mechanisms. Adding metrics into kubelet to monitor its http server will improve its observability and debuggability; adding throttling will prevent kubelet being overloaded from serving too many http requests.\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-0a59063922f00854bdcad24ea52a5f6feec5abea4759f984d1bd0288b4a95da6", "text": "<ins> /* Copyright 2019 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package metrics import ( \"sync\" \"time\" \"github.com/prometheus/client_golang/prometheus\" ) const ( kubeletSubsystem = \"kubelet\" ) var ( // HTTPRequests tracks the number of the http requests received since the server started. HTTPRequests = prometheus.NewCounterVec( prometheus.CounterOpts{ Subsystem: kubeletSubsystem, Name:      \"http_requests_total\", Help:      \"Number of the http requests received since the server started\", }, // server_type aims to differentiate the readonly server and the readwrite server. // long_running marks whether the request is long-running or not. // Currently, long-running requests include exec/attach/portforward/debug. []string{\"method\", \"path\", \"host\", \"server_type\", \"long_running\"}, ) // HTTPRequestsDuration tracks the duration in seconds to serve http requests. HTTPRequestsDuration = prometheus.NewHistogramVec( prometheus.HistogramOpts{ Subsystem: kubeletSubsystem, Name:      \"http_requests_duration_seconds\", Help:      \"Duration in seconds to serve http requests\", // Use DefBuckets for now, will customize the buckets if necessary. Buckets: prometheus.DefBuckets, }, []string{\"method\", \"path\", \"host\", \"server_type\", \"long_running\"}, ) // HTTPInflightRequests tracks the number of the inflight http requests. HTTPInflightRequests = prometheus.NewGaugeVec( prometheus.GaugeOpts{ Subsystem: kubeletSubsystem, Name:      \"http_inflight_requests\", Help:      \"Number of the inflight http requests\", }, []string{\"method\", \"path\", \"host\", \"server_type\", \"long_running\"}, ) ) var registerMetrics sync.Once // Register all metrics. func Register() { registerMetrics.Do(func() { prometheus.MustRegister(HTTPRequests) prometheus.MustRegister(HTTPRequestsDuration) prometheus.MustRegister(HTTPInflightRequests) }) } // SinceInSeconds gets the time since the specified start in seconds. func SinceInSeconds(start time.Time) float64 { return time.Since(start).Seconds() } </ins>", "commid": "kubernetes_pr_75228"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-892e0241d063b18638cd5cbf78924bd2bec214bc99c4a6b3f534188c99a38c9e", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : 1) add metrics into kubelet to monitor ; 2) add throttling to . Why is this needed: Kubelet provides lots of its functionalities through its http server, and currently there is no server-side monitoring and throttling mechanisms. Adding metrics into kubelet to monitor its http server will improve its observability and debuggability; adding throttling will prevent kubelet being overloaded from serving too many http requests.\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-2f9bde220860cfcada40e43e2392a5c5e55fafde418b8eff29cecb23461db0e0", "text": "\"k8s.io/kubernetes/pkg/kubelet/apis/resourcemetrics/v1alpha1\" kubecontainer \"k8s.io/kubernetes/pkg/kubelet/container\" \"k8s.io/kubernetes/pkg/kubelet/prober\" <ins> servermetrics \"k8s.io/kubernetes/pkg/kubelet/server/metrics\" </ins> \"k8s.io/kubernetes/pkg/kubelet/server/portforward\" remotecommandserver \"k8s.io/kubernetes/pkg/kubelet/server/remotecommand\" \"k8s.io/kubernetes/pkg/kubelet/server/stats\"", "commid": "kubernetes_pr_75228"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-892e0241d063b18638cd5cbf78924bd2bec214bc99c4a6b3f534188c99a38c9e", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : 1) add metrics into kubelet to monitor ; 2) add throttling to . Why is this needed: Kubelet provides lots of its functionalities through its http server, and currently there is no server-side monitoring and throttling mechanisms. Adding metrics into kubelet to monitor its http server will improve its observability and debuggability; adding throttling will prevent kubelet being overloaded from serving too many http requests.\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-698fc4b9b6356d57203b189d222080f840a4fda4f408eba97e096aff4aa2abf1", "text": "proxyStream(response.ResponseWriter, request.Request, url) } <ins> // trimURLPath trims a URL path. // For paths in the format of \"/metrics/xxx\", \"metrics/xxx\" is returned; // For all other paths, the first part of the path is returned. func trimURLPath(path string) string { parts := strings.SplitN(strings.TrimPrefix(path, \"/\"), \"/\", 3) if len(parts) == 0 { return path } if parts[0] == \"metrics\" && len(parts) > 1 { return fmt.Sprintf(\"%s/%s\", parts[0], parts[1]) } return parts[0] } // isLongRunningRequest determines whether the request is long-running or not. func isLongRunningRequest(path string) bool { longRunningRequestPaths := []string{\"exec\", \"attach\", \"portforward\", \"debug\"} for _, p := range longRunningRequestPaths { if p == path { return true } } return false } </ins> // ServeHTTP responds to HTTP requests on the Kubelet. func (s *Server) ServeHTTP(w http.ResponseWriter, req *http.Request) { defer httplog.NewLogged(req, &w).StacktraceWhen(", "commid": "kubernetes_pr_75228"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-892e0241d063b18638cd5cbf78924bd2bec214bc99c4a6b3f534188c99a38c9e", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : 1) add metrics into kubelet to monitor ; 2) add throttling to . Why is this needed: Kubelet provides lots of its functionalities through its http server, and currently there is no server-side monitoring and throttling mechanisms. Adding metrics into kubelet to monitor its http server will improve its observability and debuggability; adding throttling will prevent kubelet being overloaded from serving too many http requests.\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-b25d6f1ffbdf9be89767429efbf03854ab969f11a993ab7146f51ad701361689", "text": "http.StatusSwitchingProtocols, ), ).Log() <ins> // monitor http requests var serverType string if s.auth == nil { serverType = \"readonly\" } else { serverType = \"readwrite\" } method, path, host := req.Method, trimURLPath(req.URL.Path), req.URL.Host longRunning := strconv.FormatBool(isLongRunningRequest(path)) servermetrics.HTTPRequests.WithLabelValues(method, path, host, serverType, longRunning).Inc() servermetrics.HTTPInflightRequests.WithLabelValues(method, path, host, serverType, longRunning).Inc() defer servermetrics.HTTPInflightRequests.WithLabelValues(method, path, host, serverType, longRunning).Dec() startTime := time.Now() defer servermetrics.HTTPRequestsDuration.WithLabelValues(method, path, host, serverType, longRunning).Observe(servermetrics.SinceInSeconds(startTime)) </ins> s.restfulCont.ServeHTTP(w, req) }", "commid": "kubernetes_pr_75228"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-892e0241d063b18638cd5cbf78924bd2bec214bc99c4a6b3f534188c99a38c9e", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : 1) add metrics into kubelet to monitor ; 2) add throttling to . Why is this needed: Kubelet provides lots of its functionalities through its http server, and currently there is no server-side monitoring and throttling mechanisms. Adding metrics into kubelet to monitor its http server will improve its observability and debuggability; adding throttling will prevent kubelet being overloaded from serving too many http requests.\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-f29cd3a5c75b09dc27dc6f956e91ba0df3dc6eb2ed66d33d083397a8d18b4a34", "text": "assert.Equal(t, http.StatusOK, resp.StatusCode) } <ins> func TestTrimURLPath(t *testing.T) { tests := []struct { path, expected string }{ {\"\", \"\"}, {\"//\", \"\"}, {\"/pods\", \"pods\"}, {\"pods\", \"pods\"}, {\"pods/\", \"pods\"}, {\"good/\", \"good\"}, {\"pods/probes\", \"pods\"}, {\"metrics\", \"metrics\"}, {\"metrics/resource\", \"metrics/resource\"}, {\"metrics/hello\", \"metrics/hello\"}, } for _, test := range tests { assert.Equal(t, test.expected, trimURLPath(test.path), fmt.Sprintf(\"path is: %s\", test.path)) } } </ins>", "commid": "kubernetes_pr_75228"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4d0998f98cafdaec4256d215130088b83422619ea1d1b2223d6ff9d851b2d4d0", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When referencing init container's env value from its fields, kubelet complains What you expected to happen: Init container should be supported to get env values from its own fields, as to How to reproduce it (as minimally and precisely as possible): a pod with init container refering its fields value as env value kubectl create -f test-pod-1.yaml cannot be created pod events Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ):Kernel (e.g. ):Install tools: Others:\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe err happens at this line , it seems that we should search for init containers as well", "positive_passages": [{"docid": "doc-en-kubernetes-2a7ba1ec855649a9ebd07d5999c32b0b31c7e346070915ea7788f9a3ca370173", "text": "return &container, nil } } <ins> for _, container := range pod.Spec.InitContainers { if container.Name == containerName { return &container, nil } } </ins> return nil, fmt.Errorf(\"container %s not found\", containerName) }", "commid": "kubernetes_pr_75109"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4d0998f98cafdaec4256d215130088b83422619ea1d1b2223d6ff9d851b2d4d0", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When referencing init container's env value from its fields, kubelet complains What you expected to happen: Init container should be supported to get env values from its own fields, as to How to reproduce it (as minimally and precisely as possible): a pod with init container refering its fields value as env value kubectl create -f test-pod-1.yaml cannot be created pod events Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ):Kernel (e.g. ):Install tools: Others:\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe err happens at this line , it seems that we should search for init containers as well", "positive_passages": [{"docid": "doc-en-kubernetes-a6ee950038b7c4a2dc665d4d1fb6c43c5203da58be90719a9c10c66684a830b6", "text": "pod:           getPod(\"foo\", \"\", \"\", \"10Mi\", \"100Mi\"), expectedValue: \"104857600\", }, <ins> { fs: &v1.ResourceFieldSelector{ Resource: \"limits.cpu\", }, cName:         \"init-foo\", pod:           getPod(\"foo\", \"\", \"9\", \"\", \"\"), expectedValue: \"9\", }, { fs: &v1.ResourceFieldSelector{ Resource: \"requests.cpu\", }, cName:         \"init-foo\", pod:           getPod(\"foo\", \"\", \"\", \"\", \"\"), expectedValue: \"0\", }, { fs: &v1.ResourceFieldSelector{ Resource: \"requests.cpu\", }, cName:         \"init-foo\", pod:           getPod(\"foo\", \"8\", \"\", \"\", \"\"), expectedValue: \"8\", }, { fs: &v1.ResourceFieldSelector{ Resource: \"requests.cpu\", }, cName:         \"init-foo\", pod:           getPod(\"foo\", \"100m\", \"\", \"\", \"\"), expectedValue: \"1\", }, { fs: &v1.ResourceFieldSelector{ Resource: \"requests.cpu\", Divisor:  resource.MustParse(\"100m\"), }, cName:         \"init-foo\", pod:           getPod(\"foo\", \"1200m\", \"\", \"\", \"\"), expectedValue: \"12\", }, { fs: &v1.ResourceFieldSelector{ Resource: \"requests.memory\", }, cName:         \"init-foo\", pod:           getPod(\"foo\", \"\", \"\", \"100Mi\", \"\"), expectedValue: \"104857600\", }, { fs: &v1.ResourceFieldSelector{ Resource: \"requests.memory\", Divisor:  resource.MustParse(\"1Mi\"), }, cName:         \"init-foo\", pod:           getPod(\"foo\", \"\", \"\", \"100Mi\", \"1Gi\"), expectedValue: \"100\", }, { fs: &v1.ResourceFieldSelector{ Resource: \"limits.memory\", }, cName:         \"init-foo\", pod:           getPod(\"foo\", \"\", \"\", \"10Mi\", \"100Mi\"), expectedValue: \"104857600\", }, </ins> } as := assert.New(t) for idx, tc := range cases {", "commid": "kubernetes_pr_75109"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4d0998f98cafdaec4256d215130088b83422619ea1d1b2223d6ff9d851b2d4d0", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When referencing init container's env value from its fields, kubelet complains What you expected to happen: Init container should be supported to get env values from its own fields, as to How to reproduce it (as minimally and precisely as possible): a pod with init container refering its fields value as env value kubectl create -f test-pod-1.yaml cannot be created pod events Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ):Kernel (e.g. ):Install tools: Others:\nReiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe err happens at this line , it seems that we should search for init containers as well", "positive_passages": [{"docid": "doc-en-kubernetes-f87c74aca0410e393c09815892e79546e62f6fe97b270bacd65d93f136c8fa0c", "text": "Resources: resources, }, }, <ins> InitContainers: []v1.Container{ { Name:      \"init-\" + cname, Resources: resources, }, }, </ins> }, } }", "commid": "kubernetes_pr_75109"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-70af5a1cedf5015eefb116c0451b90a7456fd23ff69c19081db26ac7f1d62745", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: N/A Which test(s) are failing: Since when has it been failing: Ever Reason for failure: Vm on Azure with no public IP assigned aren't able to perform a command to the internet. Anything else we need to know: The test (see ) tries to test the internet connection for a pod by pinging 8.8.8.8. But azure does not provide ICMP support for VM without a public IP therefore this test cannot succeed.(see ) A fix would be to change the test method to a tcp request instead of a ping request (the test already performs a http get to in its BeforeSuite (see ))\n/sig network /sig testing /sig azure\nyou may refer to (Pods don't have connectivity to external networks )\ncc WDYT about the proposal to change this from an ICMP call? We probably need input from sig-architecture as well since this as well /sig architecture\n/triage unresolved\nAn alternative is to issue a TCP/UDP request to 8.8.8.8 on port 53.\nICMP is dropped by Azure for security reasons. This is intended. Can use curl as a replacement. I will fix the corresponding test.\nSGTM\nCan you please review the related PR? I'll in the PR again. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-e9e931422b114d50e6619238332ce3eabae1651b4b1681ab5195fa05e42d26e8", "text": "// BusyBoxImage is the image URI of BusyBox. BusyBoxImage = imageutils.GetE2EImage(imageutils.BusyBox) <ins> // AgnHostImage is the image URI of AgnHost AgnHostImage = imageutils.GetE2EImage(imageutils.Agnhost) </ins> // For parsing Kubectl version for version-skewed testing. gitVersionRegexp = regexp.MustCompile(\"GitVersion:\"(v.+?)\"\")", "commid": "kubernetes_pr_77794"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-70af5a1cedf5015eefb116c0451b90a7456fd23ff69c19081db26ac7f1d62745", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: N/A Which test(s) are failing: Since when has it been failing: Ever Reason for failure: Vm on Azure with no public IP assigned aren't able to perform a command to the internet. Anything else we need to know: The test (see ) tries to test the internet connection for a pod by pinging 8.8.8.8. But azure does not provide ICMP support for VM without a public IP therefore this test cannot succeed.(see ) A fix would be to change the test method to a tcp request instead of a ping request (the test already performs a http get to in its BeforeSuite (see ))\n/sig network /sig testing /sig azure\nyou may refer to (Pods don't have connectivity to external networks )\ncc WDYT about the proposal to change this from an ICMP call? We probably need input from sig-architecture as well since this as well /sig architecture\n/triage unresolved\nAn alternative is to issue a TCP/UDP request to 8.8.8.8 on port 53.\nICMP is dropped by Azure for security reasons. This is intended. Can use curl as a replacement. I will fix the corresponding test.\nSGTM\nCan you please review the related PR? I'll in the PR again. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-38541e4b7f3a9134ab574553218ddcbbe90a45ca08ce40892f6b4cc8f70ed200", "text": "Containers: []v1.Container{ { Name:    \"detector\", <del> Image:   imageutils.GetE2EImage(imageutils.Agnhost), Command: []string{\"/bin/sleep\", \"3600\"}, </del> <ins> Image:   AgnHostImage, Command: []string{\"pause\"}, </ins> }, }, },", "commid": "kubernetes_pr_77794"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-70af5a1cedf5015eefb116c0451b90a7456fd23ff69c19081db26ac7f1d62745", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: N/A Which test(s) are failing: Since when has it been failing: Ever Reason for failure: Vm on Azure with no public IP assigned aren't able to perform a command to the internet. Anything else we need to know: The test (see ) tries to test the internet connection for a pod by pinging 8.8.8.8. But azure does not provide ICMP support for VM without a public IP therefore this test cannot succeed.(see ) A fix would be to change the test method to a tcp request instead of a ping request (the test already performs a http get to in its BeforeSuite (see ))\n/sig network /sig testing /sig azure\nyou may refer to (Pods don't have connectivity to external networks )\ncc WDYT about the proposal to change this from an ICMP call? We probably need input from sig-architecture as well since this as well /sig architecture\n/triage unresolved\nAn alternative is to issue a TCP/UDP request to 8.8.8.8 on port 53.\nICMP is dropped by Azure for security reasons. This is intended. Can use curl as a replacement. I will fix the corresponding test.\nSGTM\nCan you please review the related PR? I'll in the PR again. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-0a6ca716dd54949193ed4602fc5e5ff01a687ee4157411a6e32f484236806fb3", "text": "} } <del> // PingCommand is the type to hold ping command. type PingCommand string const ( // IPv4PingCommand is a ping command for IPv4. IPv4PingCommand PingCommand = \"ping\" // IPv6PingCommand is a ping command for IPv6. IPv6PingCommand PingCommand = \"ping6\" ) </del> // CheckConnectivityToHost launches a pod to test connectivity to the specified // host. An error will be returned if the host is not reachable from the pod. // // An empty nodeName will use the schedule to choose where the pod is executed. <del> func CheckConnectivityToHost(f *Framework, nodeName, podName, host string, pingCmd PingCommand, timeout int) error { </del> <ins> func CheckConnectivityToHost(f *Framework, nodeName, podName, host string, port, timeout int) error { </ins> contName := fmt.Sprintf(\"%s-container\", podName) command := []string{ <del> string(pingCmd), \"-c\", \"3\", // send 3 pings \"-W\", \"2\", // wait at most 2 seconds for a reply </del> <ins> \"nc\", \"-vz\", </ins> \"-w\", strconv.Itoa(timeout), host, <ins> strconv.Itoa(port), </ins> } pod := &v1.Pod{", "commid": "kubernetes_pr_77794"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-70af5a1cedf5015eefb116c0451b90a7456fd23ff69c19081db26ac7f1d62745", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: N/A Which test(s) are failing: Since when has it been failing: Ever Reason for failure: Vm on Azure with no public IP assigned aren't able to perform a command to the internet. Anything else we need to know: The test (see ) tries to test the internet connection for a pod by pinging 8.8.8.8. But azure does not provide ICMP support for VM without a public IP therefore this test cannot succeed.(see ) A fix would be to change the test method to a tcp request instead of a ping request (the test already performs a http get to in its BeforeSuite (see ))\n/sig network /sig testing /sig azure\nyou may refer to (Pods don't have connectivity to external networks )\ncc WDYT about the proposal to change this from an ICMP call? We probably need input from sig-architecture as well since this as well /sig architecture\n/triage unresolved\nAn alternative is to issue a TCP/UDP request to 8.8.8.8 on port 53.\nICMP is dropped by Azure for security reasons. This is intended. Can use curl as a replacement. I will fix the corresponding test.\nSGTM\nCan you please review the related PR? I'll in the PR again. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-c9b51d34e6cfe070ce252a096a84d72f2dc77439a9b4906a130335390063237e", "text": "Containers: []v1.Container{ { Name:    contName, <del> Image:   BusyBoxImage, </del> <ins> Image:   AgnHostImage, </ins> Command: command, }, },", "commid": "kubernetes_pr_77794"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-70af5a1cedf5015eefb116c0451b90a7456fd23ff69c19081db26ac7f1d62745", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: N/A Which test(s) are failing: Since when has it been failing: Ever Reason for failure: Vm on Azure with no public IP assigned aren't able to perform a command to the internet. Anything else we need to know: The test (see ) tries to test the internet connection for a pod by pinging 8.8.8.8. But azure does not provide ICMP support for VM without a public IP therefore this test cannot succeed.(see ) A fix would be to change the test method to a tcp request instead of a ping request (the test already performs a http get to in its BeforeSuite (see ))\n/sig network /sig testing /sig azure\nyou may refer to (Pods don't have connectivity to external networks )\ncc WDYT about the proposal to change this from an ICMP call? We probably need input from sig-architecture as well since this as well /sig architecture\n/triage unresolved\nAn alternative is to issue a TCP/UDP request to 8.8.8.8 on port 53.\nICMP is dropped by Azure for security reasons. This is intended. Can use curl as a replacement. I will fix the corresponding test.\nSGTM\nCan you please review the related PR? I'll in the PR again. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-fbd8bb3b44d07c113bf3ba8e3b6889a7265fcaacff6705b689779678df3811f2", "text": "Containers: []v1.Container{ { Name:  \"agnhost\", <del> Image: imageutils.GetE2EImage(imageutils.Agnhost), </del> <ins> Image: AgnHostImage, </ins> Args:  args, }, },", "commid": "kubernetes_pr_77794"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-70af5a1cedf5015eefb116c0451b90a7456fd23ff69c19081db26ac7f1d62745", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: N/A Which test(s) are failing: Since when has it been failing: Ever Reason for failure: Vm on Azure with no public IP assigned aren't able to perform a command to the internet. Anything else we need to know: The test (see ) tries to test the internet connection for a pod by pinging 8.8.8.8. But azure does not provide ICMP support for VM without a public IP therefore this test cannot succeed.(see ) A fix would be to change the test method to a tcp request instead of a ping request (the test already performs a http get to in its BeforeSuite (see ))\n/sig network /sig testing /sig azure\nyou may refer to (Pods don't have connectivity to external networks )\ncc WDYT about the proposal to change this from an ICMP call? We probably need input from sig-architecture as well since this as well /sig architecture\n/triage unresolved\nAn alternative is to issue a TCP/UDP request to 8.8.8.8 on port 53.\nICMP is dropped by Azure for security reasons. This is intended. Can use curl as a replacement. I will fix the corresponding test.\nSGTM\nCan you please review the related PR? I'll in the PR again. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-b6e93be832656e556d1475c53afa9b56eeae10c6070757aceee1be6af87f1a77", "text": "}) ginkgo.It(\"should provide Internet connection for containers [Feature:Networking-IPv4]\", func() { <del> ginkgo.By(\"Running container which tries to ping 8.8.8.8\") </del> <ins> ginkgo.By(\"Running container which tries to connect to 8.8.8.8\") </ins> framework.ExpectNoError( <del> framework.CheckConnectivityToHost(f, \"\", \"ping-test\", \"8.8.8.8\", framework.IPv4PingCommand, 30)) </del> <ins> framework.CheckConnectivityToHost(f, \"\", \"connectivity-test\", \"8.8.8.8\", 53, 30)) </ins> }) ginkgo.It(\"should provide Internet connection for containers [Feature:Networking-IPv6][Experimental]\", func() { <del> ginkgo.By(\"Running container which tries to ping 2001:4860:4860::8888\") </del> <ins> ginkgo.By(\"Running container which tries to connect to 2001:4860:4860::8888\") </ins> framework.ExpectNoError( <del> framework.CheckConnectivityToHost(f, \"\", \"ping-test\", \"2001:4860:4860::8888\", framework.IPv6PingCommand, 30)) </del> <ins> framework.CheckConnectivityToHost(f, \"\", \"connectivity-test\", \"2001:4860:4860::8888\", 53, 30)) </ins> }) // First test because it has no dependencies on variables created later on.", "commid": "kubernetes_pr_77794"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-995d9901bec7e27fab2cf79fc167a930ec1037256d4fd506ff1df2260d69ee9e", "query": "What would you like to be : Remove any logic in kube-proxy that tries to automatically clean up proxy rules based on the proxy mode. Only attempt to clean up if is set. Why is this needed: This is a continuation of a discussion from There's a lot of complexity that comes with switching the proxy mode on kube-proxy because it tries to delete proxy rules created from other proxy modes. This has a lot of side-effects and we should be encouraging users to reboot thier nodes along with switching proxy modes. One example of this can be found\n/sig network\nI can take this on - does this issue have/need a KEP?\nI think not but will defer to\nI think a micro-KEP is appropriate. Specifically to talk about compatibility with regards to flags and to talk about docs (not sure which, but we have to write this down :)\nalso to talk about --cleanup (I think it should probably clean up its own mode, not the others -- or maybe I am wrong, please think about the right thing here :)\n/assign (Yay, I can do this now!)\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-729758a472fc8c64e0f6a2b8154f624a2f48ebb17d8715e463798e2fe6b3e6a0", "text": "fs.BoolVar(&o.CleanupAndExit, \"cleanup-iptables\", o.CleanupAndExit, \"If true cleanup iptables and ipvs rules and exit.\") fs.MarkDeprecated(\"cleanup-iptables\", \"This flag is replaced by --cleanup.\") fs.BoolVar(&o.CleanupAndExit, \"cleanup\", o.CleanupAndExit, \"If true cleanup iptables and ipvs rules and exit.\") <del> fs.BoolVar(&o.CleanupIPVS, \"cleanup-ipvs\", o.CleanupIPVS, \"If true make kube-proxy cleanup ipvs rules before running.  Default is true\") </del> <ins> fs.BoolVar(&o.CleanupIPVS, \"cleanup-ipvs\", o.CleanupIPVS, \"If true and --cleanup is specified, kube-proxy will also flush IPVS rules, in addition to normal cleanup.\") </ins> // All flags below here are deprecated and will eventually be removed.", "commid": "kubernetes_pr_76109"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-995d9901bec7e27fab2cf79fc167a930ec1037256d4fd506ff1df2260d69ee9e", "query": "What would you like to be : Remove any logic in kube-proxy that tries to automatically clean up proxy rules based on the proxy mode. Only attempt to clean up if is set. Why is this needed: This is a continuation of a discussion from There's a lot of complexity that comes with switching the proxy mode on kube-proxy because it tries to delete proxy rules created from other proxy modes. This has a lot of side-effects and we should be encouraging users to reboot thier nodes along with switching proxy modes. One example of this can be found\n/sig network\nI can take this on - does this issue have/need a KEP?\nI think not but will defer to\nI think a micro-KEP is appropriate. Specifically to talk about compatibility with regards to flags and to talk about docs (not sure which, but we have to write this down :)\nalso to talk about --cleanup (I think it should probably clean up its own mode, not the others -- or maybe I am wrong, please think about the right thing here :)\n/assign (Yay, I can do this now!)\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-f2ce1b2b9670fa7fb0d75067b3738b6fbf600ed064736e51ffa2540be4615659", "text": "// NewProxyServer returns a new ProxyServer. func NewProxyServer(o *Options) (*ProxyServer, error) { <del> return newProxyServer(o.config, o.CleanupAndExit, o.CleanupIPVS, o.scheme, o.master) </del> <ins> return newProxyServer(o.config, o.CleanupAndExit, o.scheme, o.master) </ins> } func newProxyServer( config *proxyconfigapi.KubeProxyConfiguration, cleanupAndExit bool, <del> cleanupIPVS bool, </del> scheme *runtime.Scheme, master string) (*ProxyServer, error) {", "commid": "kubernetes_pr_76109"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-995d9901bec7e27fab2cf79fc167a930ec1037256d4fd506ff1df2260d69ee9e", "query": "What would you like to be : Remove any logic in kube-proxy that tries to automatically clean up proxy rules based on the proxy mode. Only attempt to clean up if is set. Why is this needed: This is a continuation of a discussion from There's a lot of complexity that comes with switching the proxy mode on kube-proxy because it tries to delete proxy rules created from other proxy modes. This has a lot of side-effects and we should be encouraging users to reboot thier nodes along with switching proxy modes. One example of this can be found\n/sig network\nI can take this on - does this issue have/need a KEP?\nI think not but will defer to\nI think a micro-KEP is appropriate. Specifically to talk about compatibility with regards to flags and to talk about docs (not sure which, but we have to write this down :)\nalso to talk about --cleanup (I think it should probably clean up its own mode, not the others -- or maybe I am wrong, please think about the right thing here :)\n/assign (Yay, I can do this now!)\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-98bf17442d230a31d2ebe08a2930add9e13a3cbe8eedbd7fc5108faa845081a1", "text": "proxier = proxierIPTables serviceEventHandler = proxierIPTables endpointsEventHandler = proxierIPTables <del> // No turning back. Remove artifacts that might still exist from the userspace Proxier. klog.V(0).Info(\"Tearing down inactive rules.\") // TODO this has side effects that should only happen when Run() is invoked. userspace.CleanupLeftovers(iptInterface) // IPVS Proxier will generate some iptables rules, need to clean them before switching to other proxy mode. // Besides, ipvs proxier will create some ipvs rules as well.  Because there is no way to tell if a given // ipvs rule is created by IPVS proxier or not.  Users should explicitly specify `--clean-ipvs=true` to flush // all ipvs rules when kube-proxy start up.  Users do this operation should be with caution. if canUseIPVS { ipvs.CleanupLeftovers(ipvsInterface, iptInterface, ipsetInterface, cleanupIPVS) } </del> } else if proxyMode == proxyModeIPVS { klog.V(0).Info(\"Using ipvs Proxier.\") proxierIPVS, err := ipvs.NewProxier(", "commid": "kubernetes_pr_76109"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-995d9901bec7e27fab2cf79fc167a930ec1037256d4fd506ff1df2260d69ee9e", "query": "What would you like to be : Remove any logic in kube-proxy that tries to automatically clean up proxy rules based on the proxy mode. Only attempt to clean up if is set. Why is this needed: This is a continuation of a discussion from There's a lot of complexity that comes with switching the proxy mode on kube-proxy because it tries to delete proxy rules created from other proxy modes. This has a lot of side-effects and we should be encouraging users to reboot thier nodes along with switching proxy modes. One example of this can be found\n/sig network\nI can take this on - does this issue have/need a KEP?\nI think not but will defer to\nI think a micro-KEP is appropriate. Specifically to talk about compatibility with regards to flags and to talk about docs (not sure which, but we have to write this down :)\nalso to talk about --cleanup (I think it should probably clean up its own mode, not the others -- or maybe I am wrong, please think about the right thing here :)\n/assign (Yay, I can do this now!)\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-a080d8d485cdcd0784c7a2dbcbae37e1c4c15723238ad107b4320698b7c5ef3a", "text": "proxier = proxierIPVS serviceEventHandler = proxierIPVS endpointsEventHandler = proxierIPVS <del> klog.V(0).Info(\"Tearing down inactive rules.\") // TODO this has side effects that should only happen when Run() is invoked. userspace.CleanupLeftovers(iptInterface) iptables.CleanupLeftovers(iptInterface) </del> } else { klog.V(0).Info(\"Using userspace Proxier.\") // This is a proxy.LoadBalancer which NewProxier needs but has methods we don't need for", "commid": "kubernetes_pr_76109"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-995d9901bec7e27fab2cf79fc167a930ec1037256d4fd506ff1df2260d69ee9e", "query": "What would you like to be : Remove any logic in kube-proxy that tries to automatically clean up proxy rules based on the proxy mode. Only attempt to clean up if is set. Why is this needed: This is a continuation of a discussion from There's a lot of complexity that comes with switching the proxy mode on kube-proxy because it tries to delete proxy rules created from other proxy modes. This has a lot of side-effects and we should be encouraging users to reboot thier nodes along with switching proxy modes. One example of this can be found\n/sig network\nI can take this on - does this issue have/need a KEP?\nI think not but will defer to\nI think a micro-KEP is appropriate. Specifically to talk about compatibility with regards to flags and to talk about docs (not sure which, but we have to write this down :)\nalso to talk about --cleanup (I think it should probably clean up its own mode, not the others -- or maybe I am wrong, please think about the right thing here :)\n/assign (Yay, I can do this now!)\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-9f81c325c18f1c8f2ceb3e4d61af37518016f9a1c8224aa4135a332863aa3b7b", "text": "} serviceEventHandler = proxierUserspace proxier = proxierUserspace <del> // Remove artifacts from the iptables and ipvs Proxier, if not on Windows. klog.V(0).Info(\"Tearing down inactive rules.\") // TODO this has side effects that should only happen when Run() is invoked. iptables.CleanupLeftovers(iptInterface) // IPVS Proxier will generate some iptables rules, need to clean them before switching to other proxy mode. // Besides, ipvs proxier will create some ipvs rules as well.  Because there is no way to tell if a given // ipvs rule is created by IPVS proxier or not.  Users should explicitly specify `--clean-ipvs=true` to flush // all ipvs rules when kube-proxy start up.  Users do this operation should be with caution. if canUseIPVS { ipvs.CleanupLeftovers(ipvsInterface, iptInterface, ipsetInterface, cleanupIPVS) } </del> } iptInterface.AddReloadFunc(proxier.Sync)", "commid": "kubernetes_pr_76109"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-995d9901bec7e27fab2cf79fc167a930ec1037256d4fd506ff1df2260d69ee9e", "query": "What would you like to be : Remove any logic in kube-proxy that tries to automatically clean up proxy rules based on the proxy mode. Only attempt to clean up if is set. Why is this needed: This is a continuation of a discussion from There's a lot of complexity that comes with switching the proxy mode on kube-proxy because it tries to delete proxy rules created from other proxy modes. This has a lot of side-effects and we should be encouraging users to reboot thier nodes along with switching proxy modes. One example of this can be found\n/sig network\nI can take this on - does this issue have/need a KEP?\nI think not but will defer to\nI think a micro-KEP is appropriate. Specifically to talk about compatibility with regards to flags and to talk about docs (not sure which, but we have to write this down :)\nalso to talk about --cleanup (I think it should probably clean up its own mode, not the others -- or maybe I am wrong, please think about the right thing here :)\n/assign (Yay, I can do this now!)\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-9470bad82f9139750eece0dad1dd0f49b47ed91faf683330dcef6924295cbbcc", "text": "} proxier = proxierUserspace serviceEventHandler = proxierUserspace <del> klog.V(0).Info(\"Tearing down pure-winkernel proxy rules.\") winkernel.CleanupLeftovers() </del> } return &ProxyServer{", "commid": "kubernetes_pr_76109"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ff8db826b2d26ffcaf2a48d3e4e9fc88e37882937f2286a9da1d70678ae9597b", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: LoopbackHostPort code is calling the which depends on the machine on which this test is running. Especially in this particular testase it looks for the ipv6 ip address which does not exist because the machine is not configured for ipv6. Because of the LoopbackHostPort function bahaves based on the interfaces configured, test will fail if machine is not really configured with ipv6. Need to rewrite the testcase to handle such situation. What you expected to happen: Testcase should pass\n/sig network\n/cc\n/triage unresolved I am a bot run by \u200d\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\n/remove-triage unresolved", "positive_passages": [{"docid": "doc-en-kubernetes-4f67df2e87ba5a21f575627e7bc0b28ea95028a8fa45d13551a882b3e2d25308", "text": "\"testing\" ) <del> func TestLoopbackHostPort(t *testing.T) { </del> <ins> func TestLoopbackHostPortIPv4(t *testing.T) { _, ipv6only, err := isIPv6LoopbackSupported() if err != nil { t.Fatalf(\"fail to enumerate network interface, %s\", err) } if ipv6only { t.Fatalf(\"no ipv4 loopback interface\") } </ins> host, port, err := LoopbackHostPort(\"1.2.3.4:443\") if err != nil { t.Fatalf(\"unexpected error: %v\", err)", "commid": "kubernetes_pr_76966"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ff8db826b2d26ffcaf2a48d3e4e9fc88e37882937f2286a9da1d70678ae9597b", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: LoopbackHostPort code is calling the which depends on the machine on which this test is running. Especially in this particular testase it looks for the ipv6 ip address which does not exist because the machine is not configured for ipv6. Because of the LoopbackHostPort function bahaves based on the interfaces configured, test will fail if machine is not really configured with ipv6. Need to rewrite the testcase to handle such situation. What you expected to happen: Testcase should pass\n/sig network\n/cc\n/triage unresolved I am a bot run by \u200d\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\n/remove-triage unresolved", "positive_passages": [{"docid": "doc-en-kubernetes-6719055e8e5a07bd8cc7a4f33037185ef3b63593d6b789e79040e7f99e1bbdc3", "text": "if port != \"443\" { t.Fatalf(\"expected 443 as port, got %q\", port) } <ins> } func TestLoopbackHostPortIPv6(t *testing.T) { ipv6, _, err := isIPv6LoopbackSupported() if err != nil { t.Fatalf(\"fail to enumerate network interface, %s\", err) } if !ipv6 { t.Fatalf(\"no ipv6 loopback interface\") } </ins> <del> host, port, err = LoopbackHostPort(\"[ff06:0:0:0:0:0:0:c3]:443\") </del> <ins> host, port, err := LoopbackHostPort(\"[ff06:0:0:0:0:0:0:c3]:443\") </ins> if err != nil { t.Fatalf(\"unexpected error: %v\", err) }", "commid": "kubernetes_pr_76966"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ff8db826b2d26ffcaf2a48d3e4e9fc88e37882937f2286a9da1d70678ae9597b", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: LoopbackHostPort code is calling the which depends on the machine on which this test is running. Especially in this particular testase it looks for the ipv6 ip address which does not exist because the machine is not configured for ipv6. Because of the LoopbackHostPort function bahaves based on the interfaces configured, test will fail if machine is not really configured with ipv6. Need to rewrite the testcase to handle such situation. What you expected to happen: Testcase should pass\n/sig network\n/cc\n/triage unresolved I am a bot run by \u200d\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\n/remove-triage unresolved", "positive_passages": [{"docid": "doc-en-kubernetes-b4c475c125eeddaa879057e46795442ca846cf3c997e8dcb4b8ce6c1a3cdc2f3", "text": "if ip := net.ParseIP(host); ip == nil || !ip.IsLoopback() || ip.To4() != nil { t.Fatalf(\"expected IPv6 host to be loopback, got %q\", host) } if port != \"443\" { t.Fatalf(\"expected 443 as port, got %q\", port) } } <ins> func isIPv6LoopbackSupported() (ipv6 bool, ipv6only bool, err error) { addrs, err := net.InterfaceAddrs() if err != nil { return false, false, err } ipv4 := false for _, address := range addrs { ipnet, ok := address.(*net.IPNet) if !ok || !ipnet.IP.IsLoopback() { continue } if ipnet.IP.To4() == nil { ipv6 = true continue } ipv4 = true } ipv6only = ipv6 && !ipv4 return ipv6, ipv6only, nil } </ins>", "commid": "kubernetes_pr_76966"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7d23cd435e6e7fb198369752ef8cd3422b1f8a106c042cb30a911f62f0f37b32", "query": "What would you like to be : Change excludeCIDRs from []string to []*IPNet in Proxier and perform the parsing at construction of Proxier. Why is this needed: This was proposed by over comments in Pr This improves the performance of isIPInExcludeCIDRs since the cost of parsing becomes one time.\n/sig network /kind cleanup\n/remove-kind feature\n/triage unresolved I am a bot run by \u200d\nping", "positive_passages": [{"docid": "doc-en-kubernetes-276652e7609fc82a75614e54fdfd3dd55e8a50a6e0361b75370693ff857a1493", "text": "syncPeriod    time.Duration minSyncPeriod time.Duration // Values are CIDR's to exclude when cleaning up IPVS rules. <del> excludeCIDRs []string </del> <ins> excludeCIDRs []*net.IPNet </ins> // Set to true to set sysctls arp_ignore and arp_announce strictARP      bool iptables       utiliptables.Interface", "commid": "kubernetes_pr_76779"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7d23cd435e6e7fb198369752ef8cd3422b1f8a106c042cb30a911f62f0f37b32", "query": "What would you like to be : Change excludeCIDRs from []string to []*IPNet in Proxier and perform the parsing at construction of Proxier. Why is this needed: This was proposed by over comments in Pr This improves the performance of isIPInExcludeCIDRs since the cost of parsing becomes one time.\n/sig network /kind cleanup\n/remove-kind feature\n/triage unresolved I am a bot run by \u200d\nping", "positive_passages": [{"docid": "doc-en-kubernetes-8778cbfd5138b1022caa64d5f6c959eef9f99c43c74950f161f7943069e2327b", "text": "// Proxier implements ProxyProvider var _ proxy.ProxyProvider = &Proxier{} <ins> // ParseExcludedCIDRs parses the input strings and returns net.IPNet // The validation has been done earlier so the error condition will never happen under normal conditions func ParseExcludedCIDRs(excludeCIDRStrs []string) []*net.IPNet { var cidrExclusions []*net.IPNet for _, excludedCIDR := range excludeCIDRStrs { _, n, err := net.ParseCIDR(excludedCIDR) if err == nil { cidrExclusions = append(cidrExclusions, n) } } return cidrExclusions } </ins> // NewProxier returns a new Proxier given an iptables and ipvs Interface instance. // Because of the iptables and ipvs logic, it is assumed that there is only a single Proxier active on a machine. // An error will be returned if it fails to update or acquire the initial lock.", "commid": "kubernetes_pr_76779"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7d23cd435e6e7fb198369752ef8cd3422b1f8a106c042cb30a911f62f0f37b32", "query": "What would you like to be : Change excludeCIDRs from []string to []*IPNet in Proxier and perform the parsing at construction of Proxier. Why is this needed: This was proposed by over comments in Pr This improves the performance of isIPInExcludeCIDRs since the cost of parsing becomes one time.\n/sig network /kind cleanup\n/remove-kind feature\n/triage unresolved I am a bot run by \u200d\nping", "positive_passages": [{"docid": "doc-en-kubernetes-110b7379388b284a8be1f3b22e905b132886953cc89e12b2a47388c79f85b0e3", "text": "exec utilexec.Interface, syncPeriod time.Duration, minSyncPeriod time.Duration, <del> excludeCIDRs []string, </del> <ins> excludeCIDRStrs []string, </ins> strictARP bool, masqueradeAll bool, masqueradeBit int,", "commid": "kubernetes_pr_76779"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7d23cd435e6e7fb198369752ef8cd3422b1f8a106c042cb30a911f62f0f37b32", "query": "What would you like to be : Change excludeCIDRs from []string to []*IPNet in Proxier and perform the parsing at construction of Proxier. Why is this needed: This was proposed by over comments in Pr This improves the performance of isIPInExcludeCIDRs since the cost of parsing becomes one time.\n/sig network /kind cleanup\n/remove-kind feature\n/triage unresolved I am a bot run by \u200d\nping", "positive_passages": [{"docid": "doc-en-kubernetes-1ff21f193dc858938fb18637b2cdef1756d4e1a5008f0492ae12d4d46c7f9d70", "text": "endpointsChanges:      proxy.NewEndpointChangeTracker(hostname, nil, &isIPv6, recorder), syncPeriod:            syncPeriod, minSyncPeriod:         minSyncPeriod, <del> excludeCIDRs:          excludeCIDRs, </del> <ins> excludeCIDRs:          ParseExcludedCIDRs(excludeCIDRStrs), </ins> iptables:              ipt, masqueradeAll:         masqueradeAll, masqueradeMark:        masqueradeMark,", "commid": "kubernetes_pr_76779"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7d23cd435e6e7fb198369752ef8cd3422b1f8a106c042cb30a911f62f0f37b32", "query": "What would you like to be : Change excludeCIDRs from []string to []*IPNet in Proxier and perform the parsing at construction of Proxier. Why is this needed: This was proposed by over comments in Pr This improves the performance of isIPInExcludeCIDRs since the cost of parsing becomes one time.\n/sig network /kind cleanup\n/remove-kind feature\n/triage unresolved I am a bot run by \u200d\nping", "positive_passages": [{"docid": "doc-en-kubernetes-2556c988271d18e50517b935ec199a925fd072af9c1ec5f387e32164befe3e32", "text": "func (proxier *Proxier) isIPInExcludeCIDRs(ip net.IP) bool { // make sure it does not fall within an excluded CIDR range. for _, excludedCIDR := range proxier.excludeCIDRs { <del> // Any validation of this CIDR already should have occurred. _, n, _ := net.ParseCIDR(excludedCIDR) if n.Contains(ip) { </del> <ins> if excludedCIDR.Contains(ip) { </ins> return true } }", "commid": "kubernetes_pr_76779"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7d23cd435e6e7fb198369752ef8cd3422b1f8a106c042cb30a911f62f0f37b32", "query": "What would you like to be : Change excludeCIDRs from []string to []*IPNet in Proxier and perform the parsing at construction of Proxier. Why is this needed: This was proposed by over comments in Pr This improves the performance of isIPInExcludeCIDRs since the cost of parsing becomes one time.\n/sig network /kind cleanup\n/remove-kind feature\n/triage unresolved I am a bot run by \u200d\nping", "positive_passages": [{"docid": "doc-en-kubernetes-6781bd85107ba1641d962293fc825f091d7291be94c3462d246057063034be8c", "text": "return nil } <del> func NewFakeProxier(ipt utiliptables.Interface, ipvs utilipvs.Interface, ipset utilipset.Interface, nodeIPs []net.IP, excludeCIDRs []string) *Proxier { </del> <ins> func NewFakeProxier(ipt utiliptables.Interface, ipvs utilipvs.Interface, ipset utilipset.Interface, nodeIPs []net.IP, excludeCIDRs []*net.IPNet) *Proxier { </ins> fcmd := fakeexec.FakeCmd{ CombinedOutputScript: []fakeexec.FakeCombinedOutputAction{ func() ([]byte, error) { return []byte(\"dummy device have been created\"), nil },", "commid": "kubernetes_pr_76779"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7d23cd435e6e7fb198369752ef8cd3422b1f8a106c042cb30a911f62f0f37b32", "query": "What would you like to be : Change excludeCIDRs from []string to []*IPNet in Proxier and perform the parsing at construction of Proxier. Why is this needed: This was proposed by over comments in Pr This improves the performance of isIPInExcludeCIDRs since the cost of parsing becomes one time.\n/sig network /kind cleanup\n/remove-kind feature\n/triage unresolved I am a bot run by \u200d\nping", "positive_passages": [{"docid": "doc-en-kubernetes-70760f710d8128b2b3746527a77bfa0d34e7ce32891620aaa3b5e1d5d384e11e", "text": "ipt := iptablestest.NewFake() ipvs := ipvstest.NewFake() ipset := ipsettest.NewFake(testIPSetVersion) <del> fp := NewFakeProxier(ipt, ipvs, ipset, nil, []string{\"3.3.3.0/24\", \"4.4.4.0/24\"}) </del> <ins> fp := NewFakeProxier(ipt, ipvs, ipset, nil, ParseExcludedCIDRs([]string{\"3.3.3.0/24\", \"4.4.4.0/24\"})) </ins> // All ipvs services that were processed in the latest sync loop. activeServices := map[string]bool{\"ipvs0\": true, \"ipvs1\": true}", "commid": "kubernetes_pr_76779"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7d23cd435e6e7fb198369752ef8cd3422b1f8a106c042cb30a911f62f0f37b32", "query": "What would you like to be : Change excludeCIDRs from []string to []*IPNet in Proxier and perform the parsing at construction of Proxier. Why is this needed: This was proposed by over comments in Pr This improves the performance of isIPInExcludeCIDRs since the cost of parsing becomes one time.\n/sig network /kind cleanup\n/remove-kind feature\n/triage unresolved I am a bot run by \u200d\nping", "positive_passages": [{"docid": "doc-en-kubernetes-019f7e15ebbc2d48f8b95e52215350c0b75f01f4d547a3661f23a5054f90a52c", "text": "ipvs := ipvstest.NewFake() ipset := ipsettest.NewFake(testIPSetVersion) gtm := NewGracefulTerminationManager(ipvs) <del> fp := NewFakeProxier(ipt, ipvs, ipset, nil, []string{\"4.4.4.4/32\"}) </del> <ins> fp := NewFakeProxier(ipt, ipvs, ipset, nil, ParseExcludedCIDRs([]string{\"4.4.4.4/32\"})) </ins> fp.gracefuldeleteManager = gtm vs := &utilipvs.VirtualServer{", "commid": "kubernetes_pr_76779"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7d23cd435e6e7fb198369752ef8cd3422b1f8a106c042cb30a911f62f0f37b32", "query": "What would you like to be : Change excludeCIDRs from []string to []*IPNet in Proxier and perform the parsing at construction of Proxier. Why is this needed: This was proposed by over comments in Pr This improves the performance of isIPInExcludeCIDRs since the cost of parsing becomes one time.\n/sig network /kind cleanup\n/remove-kind feature\n/triage unresolved I am a bot run by \u200d\nping", "positive_passages": [{"docid": "doc-en-kubernetes-7845aba1be8efb1ec01cd4ccf8758abb72f064e70bd476b1200a6cdc354b4a00", "text": "ipt := iptablestest.NewFake() ipvs := ipvstest.NewFake() ipset := ipsettest.NewFake(testIPSetVersion) <del> fp := NewFakeProxier(ipt, ipvs, ipset, nil, []string{\"3000::/64\", \"4000::/64\"}) </del> <ins> fp := NewFakeProxier(ipt, ipvs, ipset, nil, ParseExcludedCIDRs([]string{\"3000::/64\", \"4000::/64\"})) </ins> fp.nodeIP = net.ParseIP(\"::1\") // All ipvs services that were processed in the latest sync loop.", "commid": "kubernetes_pr_76779"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-06090bc29717f53ed35b5f857d1a7f93dac3313da76c3b3f75481458fd51444a", "query": "What happened: We're running pod behind and sending logs via UDP to it. It is k8s v1.13.3 with ipvs services. When pod gets restarted logs getting blackholed. Simplified example on a node: So, old pod had IP 192.168.129.116, new pod - 192.168.128.193. Weight correctly forwards all new traffic to new pod, but there are some which are still sending traffic to non-existing IP: Minimal value for UDP connection expiration is 1s: But logs are being sent at much faster rates, so these broken connections are never expire. Issue introduced by Looks like this supposed to keep old pod running, while there are still connections to it But is there a reason to still keep these realServer entries, while old pod already cleaned up and no such IP exist? What you expected to happen: would cleanup all non-existing realServers from ipvs entries. How to reproduce it (as minimally and precisely as possible): Repro steps are same as for host-port issue: Anything else we need to know?: sysctls are default: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: on-premise OS (e.g: ): Debian 9 Kernel (e.g. ): 4.9.0-8-amd64 Install tools: Others:\n/sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by \u200d\ncc\nWe observe the same behavior in k8s v1.12.7 and it hits us hard. In our case Nginx in a pod uses coredns service IP as DNS resolver address and every time coredns pods get new addresses DNS queries are blackholed. Query rate is higher than ipvs UDP connection timeout (30s in our case), so the connection to a non-existent ip address stays forever. Kube-proxy keeps non-existent real server entry in ipvs service and conntrack entry is never getting removed either. Kube-proxy logs: ipvsadm -ln:\nI've been putting some thoughts on the issue (we actually have the same one). Currently, we handle graceful termination the same way for udp as we do for tcp. However on heavily loaded UDP services, (DNS for instance) udp ports are reused quickly and old backends are not deleted fast enough. There are two possible solutions: use more aggressive timeouts (30s instead of the default 300s). Not perfect but better immediately delete real servers and associated connections when a backend is not ready anymore (very good for DNS queries but this means no graceful termination for udp) / what do you think? I'm not sure what the exact behavior with iptables I can create a detailed issue with options to have a wider discussion. Or even directly send an email to the sig-network group\nI like the idea. BTW, iptables also does not support graceful termination for UDP connections.\nthis is very easy to implement: change the test here: make sure is set (which we do : )\nIf we agree this is the way to go, I can implement it (if iptables works this way this is the best solution, I agree) We could still tweak timeouts for TCP (defaults are very long: 900s, which can lead to complete blackholing for 15mn on a crash of a target because the connection is never closed)\nI agree.\n/area ipvs\nIf you have a test environment I have a test image with the fix discussed just above: Commit here: This is not perfect, but I believe it is much better. What happens is the following: udp target pod becomes NotReady IP is removed from RealServers immediately Because of any new packet reusing the port will generate a write error and the connection will be removed from the ipvs connection table (if the application retries you are fine) I think in addition to that we should set much more aggressive UDP timeouts (5s? instead of the default: 300s) and make it configurable with a flag for specific use-case (I haven't seen a use case for long lived udp \"connections\" with very low amount of traffic)\nSorry, i was unable to quick test this on local dev cluster. Tried to replace image with but it seems it does not work with k8s 1.13. It then generates a lot of the same messages, and no any ipvs VIPs are created. I've also tried on fresh new cluster with the same result. Then tried but was unable to even start the cluster (with modified config from our 1.13) Can you please cherry-pick this to 1.13 or 1.14 or am I doing something wrong?\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nWe tested this patch to kubernetes v1.12.7 and it works well in production. BTW, I don't know much about SCTP. But question is do we need to threat it as UDP or TCP in this case? But it seems more close to UDP.\nThanks for testing! The PR is limiting graceful termination to TCP which seems the safest. I don't know SCTP but making it behave like TCP would be an easy change.\nThis feels like a fundamental problem w/ endpoints... ideally the proxier would remove the realserver when the pod is nonexistent rather than relying on arbitrary timeouts. Otherwise, there is no way to support graceful termination with UDP based protocols. Not a big deal for most UDP things, but I imagine e.g. QUIC users would be affected. Immediately terminating udp connections is in line with the iptables behavior, which seems to be okay for most people, so the change seems reasonable until there is a better way to determine pod state.\nThe PR that was just merged will improve things a lot for UDP but I completely agree with you on the fundamental problem with endpoints. I think we should have 3 different states: Ready (accepting traffic), in which case we should route traffic to the endpoint NotReady (terminating for instance), in which case we should stop routing new traffic to the endpoint but should keep existing connections \"Gone\" (no in the endpoint object anymore), in which case we should remove the endpoint altogether Today the endpoint object is too simple to handle these differences. I hope the new EndpointCondition status in the EndpointSlice API will help address this problem. More than happy to integrate this in IPVS when it is released (cc / )", "positive_passages": [{"docid": "doc-en-kubernetes-6c704c71637da422eb25b0a00e9fa47999bc4f7e195acd0783dd70dbefe75b4f", "text": "package ipvs import ( <ins> \"fmt\" </ins> \"sync\" \"time\" <del> \"fmt\" </del> \"k8s.io/apimachinery/pkg/util/wait\" \"k8s.io/klog\" utilipvs \"k8s.io/kubernetes/pkg/util/ipvs\"", "commid": "kubernetes_pr_77802"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-06090bc29717f53ed35b5f857d1a7f93dac3313da76c3b3f75481458fd51444a", "query": "What happened: We're running pod behind and sending logs via UDP to it. It is k8s v1.13.3 with ipvs services. When pod gets restarted logs getting blackholed. Simplified example on a node: So, old pod had IP 192.168.129.116, new pod - 192.168.128.193. Weight correctly forwards all new traffic to new pod, but there are some which are still sending traffic to non-existing IP: Minimal value for UDP connection expiration is 1s: But logs are being sent at much faster rates, so these broken connections are never expire. Issue introduced by Looks like this supposed to keep old pod running, while there are still connections to it But is there a reason to still keep these realServer entries, while old pod already cleaned up and no such IP exist? What you expected to happen: would cleanup all non-existing realServers from ipvs entries. How to reproduce it (as minimally and precisely as possible): Repro steps are same as for host-port issue: Anything else we need to know?: sysctls are default: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: on-premise OS (e.g: ): Debian 9 Kernel (e.g. ): 4.9.0-8-amd64 Install tools: Others:\n/sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by \u200d\ncc\nWe observe the same behavior in k8s v1.12.7 and it hits us hard. In our case Nginx in a pod uses coredns service IP as DNS resolver address and every time coredns pods get new addresses DNS queries are blackholed. Query rate is higher than ipvs UDP connection timeout (30s in our case), so the connection to a non-existent ip address stays forever. Kube-proxy keeps non-existent real server entry in ipvs service and conntrack entry is never getting removed either. Kube-proxy logs: ipvsadm -ln:\nI've been putting some thoughts on the issue (we actually have the same one). Currently, we handle graceful termination the same way for udp as we do for tcp. However on heavily loaded UDP services, (DNS for instance) udp ports are reused quickly and old backends are not deleted fast enough. There are two possible solutions: use more aggressive timeouts (30s instead of the default 300s). Not perfect but better immediately delete real servers and associated connections when a backend is not ready anymore (very good for DNS queries but this means no graceful termination for udp) / what do you think? I'm not sure what the exact behavior with iptables I can create a detailed issue with options to have a wider discussion. Or even directly send an email to the sig-network group\nI like the idea. BTW, iptables also does not support graceful termination for UDP connections.\nthis is very easy to implement: change the test here: make sure is set (which we do : )\nIf we agree this is the way to go, I can implement it (if iptables works this way this is the best solution, I agree) We could still tweak timeouts for TCP (defaults are very long: 900s, which can lead to complete blackholing for 15mn on a crash of a target because the connection is never closed)\nI agree.\n/area ipvs\nIf you have a test environment I have a test image with the fix discussed just above: Commit here: This is not perfect, but I believe it is much better. What happens is the following: udp target pod becomes NotReady IP is removed from RealServers immediately Because of any new packet reusing the port will generate a write error and the connection will be removed from the ipvs connection table (if the application retries you are fine) I think in addition to that we should set much more aggressive UDP timeouts (5s? instead of the default: 300s) and make it configurable with a flag for specific use-case (I haven't seen a use case for long lived udp \"connections\" with very low amount of traffic)\nSorry, i was unable to quick test this on local dev cluster. Tried to replace image with but it seems it does not work with k8s 1.13. It then generates a lot of the same messages, and no any ipvs VIPs are created. I've also tried on fresh new cluster with the same result. Then tried but was unable to even start the cluster (with modified config from our 1.13) Can you please cherry-pick this to 1.13 or 1.14 or am I doing something wrong?\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\nWe tested this patch to kubernetes v1.12.7 and it works well in production. BTW, I don't know much about SCTP. But question is do we need to threat it as UDP or TCP in this case? But it seems more close to UDP.\nThanks for testing! The PR is limiting graceful termination to TCP which seems the safest. I don't know SCTP but making it behave like TCP would be an easy change.\nThis feels like a fundamental problem w/ endpoints... ideally the proxier would remove the realserver when the pod is nonexistent rather than relying on arbitrary timeouts. Otherwise, there is no way to support graceful termination with UDP based protocols. Not a big deal for most UDP things, but I imagine e.g. QUIC users would be affected. Immediately terminating udp connections is in line with the iptables behavior, which seems to be okay for most people, so the change seems reasonable until there is a better way to determine pod state.\nThe PR that was just merged will improve things a lot for UDP but I completely agree with you on the fundamental problem with endpoints. I think we should have 3 different states: Ready (accepting traffic), in which case we should route traffic to the endpoint NotReady (terminating for instance), in which case we should stop routing new traffic to the endpoint but should keep existing connections \"Gone\" (no in the endpoint object anymore), in which case we should remove the endpoint altogether Today the endpoint object is too simple to handle these differences. I hope the new EndpointCondition status in the EndpointSlice API will help address this problem. More than happy to integrate this in IPVS when it is released (cc / )", "positive_passages": [{"docid": "doc-en-kubernetes-8b0ac55d57483e1baa49f2e98ca6b7162ded15b5d7a5ce9a70f20d69fe7d6598", "text": "} for _, rs := range rss { if rsToDelete.RealServer.Equal(rs) { <del> // Delete RS with no connections // For UDP, ActiveConn is always 0 // For TCP, InactiveConn are connections not in ESTABLISHED state if rs.ActiveConn+rs.InactiveConn != 0 { </del> <ins> // For UDP traffic, no graceful termination, we immediately delete the RS //     (existing connections will be deleted on the next packet because sysctlExpireNoDestConn=1) // For other protocols, don't delete until all connections have expired) if rsToDelete.VirtualServer.Protocol != \"udp\" && rs.ActiveConn+rs.InactiveConn != 0 { </ins> klog.Infof(\"Not deleting, RS %v: %v ActiveConn, %v InactiveConn\", rsToDelete.String(), rs.ActiveConn, rs.InactiveConn) return false, nil }", "commid": "kubernetes_pr_77802"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a5fd3f8c97b71c1b6febd1e30a31e7696fb42552edc46c1b3df644e51c67f804", "query": "we need to add such a file under: test/e2e/framework see this file as an example: xref: /help /good-first-issue /area e2e-testing-framework /sig testing /kind cleanup\n/remove-good-first-issue /remove-kind feature\n/priority important-longterm /area e2e-test-framework\n/assign\ni think it might be a good idea to create the dep graph as JPG and have a chat about that during a meeting.\nWhat are the restrictions that we are trying to place in the e2e framework? In the example given it looks like the only thing blacklisted is provider-specific implementations or the internal client. I know one of the recent changes was ensuring we dont use the internal client, is that all we want to blacklist for now? Or also all specific provider implementations? Some other dep we want to prevent?\nI'd like to help on this issue, this would be my first issue so I'd need some help as well if that's OK.\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-70da332ac0f79e4bd7dc3b13567889fe3294088f50b90cba4aaace6c05c0e75a", "text": "<ins> { \"Rules\": [ { \"SelectorRegexp\": \"k8s[.]io/kubernetes/pkg/\", \"AllowedPrefixes\": [ \"k8s.io/kubernetes/pkg/api/legacyscheme\", \"k8s.io/kubernetes/pkg/api/service\", \"k8s.io/kubernetes/pkg/api/v1/pod\", \"k8s.io/kubernetes/pkg/apis/apps\", \"k8s.io/kubernetes/pkg/apis/apps/validation\", \"k8s.io/kubernetes/pkg/apis/autoscaling\", \"k8s.io/kubernetes/pkg/apis/batch\", \"k8s.io/kubernetes/pkg/apis/core\", \"k8s.io/kubernetes/pkg/apis/core/helper\", \"k8s.io/kubernetes/pkg/apis/core/install\", \"k8s.io/kubernetes/pkg/apis/core/pods\", \"k8s.io/kubernetes/pkg/apis/core/v1\", \"k8s.io/kubernetes/pkg/apis/core/v1/helper\", \"k8s.io/kubernetes/pkg/apis/core/v1/helper/qos\", \"k8s.io/kubernetes/pkg/apis/core/validation\", \"k8s.io/kubernetes/pkg/apis/extensions\", \"k8s.io/kubernetes/pkg/apis/networking\", \"k8s.io/kubernetes/pkg/apis/policy\", \"k8s.io/kubernetes/pkg/apis/policy/validation\", \"k8s.io/kubernetes/pkg/apis/scheduling\", \"k8s.io/kubernetes/pkg/apis/storage/v1/util\", \"k8s.io/kubernetes/pkg/capabilities\", \"k8s.io/kubernetes/pkg/client/conditions\", \"k8s.io/kubernetes/pkg/controller\", \"k8s.io/kubernetes/pkg/controller/deployment/util\", \"k8s.io/kubernetes/pkg/controller/nodelifecycle\", \"k8s.io/kubernetes/pkg/controller/nodelifecycle/scheduler\", \"k8s.io/kubernetes/pkg/controller/service\", \"k8s.io/kubernetes/pkg/controller/util/node\", \"k8s.io/kubernetes/pkg/controller/volume/persistentvolume/util\", \"k8s.io/kubernetes/pkg/controller/volume/scheduling\", \"k8s.io/kubernetes/pkg/features\", \"k8s.io/kubernetes/pkg/fieldpath\", \"k8s.io/kubernetes/pkg/kubectl\", \"k8s.io/kubernetes/pkg/kubectl/apps\", \"k8s.io/kubernetes/pkg/kubectl/describe\", \"k8s.io/kubernetes/pkg/kubectl/describe/versioned\", \"k8s.io/kubernetes/pkg/kubectl/scheme\", \"k8s.io/kubernetes/pkg/kubectl/util\", \"k8s.io/kubernetes/pkg/kubectl/util/certificate\", \"k8s.io/kubernetes/pkg/kubectl/util/deployment\", \"k8s.io/kubernetes/pkg/kubectl/util/event\", \"k8s.io/kubernetes/pkg/kubectl/util/fieldpath\", \"k8s.io/kubernetes/pkg/kubectl/util/podutils\", \"k8s.io/kubernetes/pkg/kubectl/util/qos\", \"k8s.io/kubernetes/pkg/kubectl/util/rbac\", \"k8s.io/kubernetes/pkg/kubectl/util/resource\", \"k8s.io/kubernetes/pkg/kubectl/util/slice\", \"k8s.io/kubernetes/pkg/kubectl/util/storage\", \"k8s.io/kubernetes/pkg/kubelet/apis\", \"k8s.io/kubernetes/pkg/kubelet/apis/config\", \"k8s.io/kubernetes/pkg/kubelet/apis/stats/v1alpha1\", \"k8s.io/kubernetes/pkg/kubelet/checkpoint\", \"k8s.io/kubernetes/pkg/kubelet/checkpointmanager\", \"k8s.io/kubernetes/pkg/kubelet/checkpointmanager/checksum\", \"k8s.io/kubernetes/pkg/kubelet/checkpointmanager/errors\", \"k8s.io/kubernetes/pkg/kubelet/configmap\", \"k8s.io/kubernetes/pkg/kubelet/container\", \"k8s.io/kubernetes/pkg/kubelet/dockershim/metrics\", \"k8s.io/kubernetes/pkg/kubelet/events\", \"k8s.io/kubernetes/pkg/kubelet/lifecycle\", \"k8s.io/kubernetes/pkg/kubelet/metrics\", \"k8s.io/kubernetes/pkg/kubelet/pod\", \"k8s.io/kubernetes/pkg/kubelet/secret\", \"k8s.io/kubernetes/pkg/kubelet/sysctl\", \"k8s.io/kubernetes/pkg/kubelet/types\", \"k8s.io/kubernetes/pkg/kubelet/util\", \"k8s.io/kubernetes/pkg/kubelet/util/format\", \"k8s.io/kubernetes/pkg/kubelet/util/manager\", \"k8s.io/kubernetes/pkg/kubelet/util/store\", \"k8s.io/kubernetes/pkg/master/ports\", \"k8s.io/kubernetes/pkg/registry/core/service/allocator\", \"k8s.io/kubernetes/pkg/registry/core/service/portallocator\", \"k8s.io/kubernetes/pkg/scheduler/algorithm\", \"k8s.io/kubernetes/pkg/scheduler/algorithm/predicates\", \"k8s.io/kubernetes/pkg/scheduler/algorithm/priorities/util\", \"k8s.io/kubernetes/pkg/scheduler/api\", \"k8s.io/kubernetes/pkg/scheduler/metrics\", \"k8s.io/kubernetes/pkg/scheduler/nodeinfo\", \"k8s.io/kubernetes/pkg/scheduler/util\", \"k8s.io/kubernetes/pkg/scheduler/volumebinder\", \"k8s.io/kubernetes/pkg/security/apparmor\", \"k8s.io/kubernetes/pkg/security/podsecuritypolicy/seccomp\", \"k8s.io/kubernetes/pkg/security/podsecuritypolicy/util\", \"k8s.io/kubernetes/pkg/serviceaccount\", \"k8s.io/kubernetes/pkg/ssh\", \"k8s.io/kubernetes/pkg/util/filesystem\", \"k8s.io/kubernetes/pkg/util/hash\", \"k8s.io/kubernetes/pkg/util/labels\", \"k8s.io/kubernetes/pkg/util/metrics\", \"k8s.io/kubernetes/pkg/util/mount\", \"k8s.io/kubernetes/pkg/util/node\", \"k8s.io/kubernetes/pkg/util/parsers\", \"k8s.io/kubernetes/pkg/util/resizefs\", \"k8s.io/kubernetes/pkg/util/slice\", \"k8s.io/kubernetes/pkg/util/system\", \"k8s.io/kubernetes/pkg/util/taints\", \"k8s.io/kubernetes/pkg/volume\", \"k8s.io/kubernetes/pkg/volume/util\", \"k8s.io/kubernetes/pkg/volume/util/fs\", \"k8s.io/kubernetes/pkg/volume/util/fsquota\", \"k8s.io/kubernetes/pkg/volume/util/recyclerclient\", \"k8s.io/kubernetes/pkg/volume/util/subpath\", \"k8s.io/kubernetes/pkg/volume/util/types\", \"k8s.io/kubernetes/pkg/volume/util/volumepathhandler\" ], \"ForbiddenPrefixes\": [] }, { \"SelectorRegexp\": \"k8s[.]io/kubernetes/test/\", \"AllowedPrefixes\": [ \"k8s.io/kubernetes/test/e2e/framework/auth\", \"k8s.io/kubernetes/test/e2e/framework/ginkgowrapper\", \"k8s.io/kubernetes/test/e2e/framework/log\", \"k8s.io/kubernetes/test/e2e/framework/metrics\", \"k8s.io/kubernetes/test/e2e/framework/node\", \"k8s.io/kubernetes/test/e2e/framework/pod\", \"k8s.io/kubernetes/test/e2e/framework/resource\", \"k8s.io/kubernetes/test/e2e/framework/ssh\", \"k8s.io/kubernetes/test/e2e/framework/testfiles\", \"k8s.io/kubernetes/test/e2e/manifest\", \"k8s.io/kubernetes/test/e2e/perftype\", \"k8s.io/kubernetes/test/utils\", \"k8s.io/kubernetes/test/utils/image\" ], \"ForbiddenPrefixes\": [] }, { \"SelectorRegexp\": \"k8s[.]io/kubernetes/third_party/\", \"AllowedPrefixes\": [ \"k8s.io/kubernetes/third_party/forked/golang/expansion\" ], \"ForbiddenPrefixes\": [] }, { \"SelectorRegexp\": \"k8s[.]io/utils/\", \"AllowedPrefixes\": [ \"k8s.io/utils/buffer\", \"k8s.io/utils/exec\", \"k8s.io/utils/integer\", \"k8s.io/utils/net\", \"k8s.io/utils/nsenter\", \"k8s.io/utils/path\", \"k8s.io/utils/pointer\", \"k8s.io/utils/strings\", \"k8s.io/utils/trace\" ], \"ForbiddenPrefixes\": [] }, { \"SelectorRegexp\": \"k8s[.]io/(api/|apimachinery/|apiextensions-apiserver/|apiserver/)\", \"AllowedPrefixes\": [ \"\" ] }, { \"SelectorRegexp\": \"k8s[.]io/client-go/\", \"AllowedPrefixes\": [ \"\" ] } ] } </ins>", "commid": "kubernetes_pr_80496"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-38db129a694acec080229fb8864bdeffe34dab3c8bb74b84a209c796e077985e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Make release of v1.14.2 failed. After facing the error () we did 4 : eaafa5952f8073f51b13dbeafe406019995c8c0ba commit in 's opening PR () Then the build process failed again: What we did was: we ran two commands called , after that, we did . And right after this command, the error happened. Environment: Kubernetes version (use ): v1.14.2 OS (e.g: ): ubuntu 16.04, bash version 4.3\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-2c9f433b6998d85f769acdc68231fd03e391ecd5050a68960a4520e149a067d3", "text": "IFS=\" \" read -ra KUBE_TEST_SERVER_TARGETS <<< \"$(kube::golang::server_test_targets)\" readonly KUBE_TEST_SERVER_TARGETS readonly KUBE_TEST_SERVER_BINARIES=(\"${KUBE_TEST_SERVER_TARGETS[@]##*/}\") <del> readonly KUBE_TEST_SERVER_PLATFORMS=(\"${KUBE_SERVER_PLATFORMS[@]}\") </del> <ins> readonly KUBE_TEST_SERVER_PLATFORMS=(\"${KUBE_SERVER_PLATFORMS[@]:+\"${KUBE_SERVER_PLATFORMS[@]}\"}\") </ins> # Gigabytes necessary for parallel platform builds. # As of January 2018, RAM usage is exceeding 30G", "commid": "kubernetes_pr_78059"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7dd992e79bede1333eea29d91300bc35053996291a11517e577968869cb33fdc", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Introduce a mechanism that allows specifying the IP protocol version used in the e2e testing. Why is this needed: This is a followup on , my understanding is that in order to discriminate between IPv4 or IPv6 we have to use the test labels and this adds complexity to the testing automation and doesn't allow to send this information to the context of the tests. Having a mechanism to specify the IP protocol will simplify the testing for IPv4 and IPv6 and will allow reusing most of the code.\n/sig testing /cc /assign Does this make sense? If affirmative, what should be the best way to add this functionality? Checking the code I think that or can provide this, don't know if checking some of the cluster config parameters, ...\nthe testing-commons group (sig-testing) maintains the framework, but ideally the decision on how to proceed in terms of adding ipv6 detection should come from sig-network. possibly having this as agenda for a sig-network meeting is a good start, then discussing it in a testing-commons meeting. /sig network the linked issue is a big one, so i don't have all the context here. but IMO existing tests should just work for ipv6 without the requirement for a new \"IPV6\" tag in test names. dual-stack or protocol specific tests should have their descriptions contain the details properly (i.e. what is this test doing) we might want to add an utility function under: (there is a PR to move it BTW ) then such an utility might be useful only to tests that need to detect the protocol. one of the goals is to refactor the code in testcontext / framework, so adding this logic there is less preferred.\n/area e2e-test-framework\nI think that we can add an option to test_context to specify the cluster IP family the same way that exists one for the cloud provider this is simpler because when setting up the CI jobs you will know beforehand what IP family you want to test, it also will allow reusing all the e2e code for IPv6 and Dual Stack (cc: and by default will be IPv4, so it\u00b4s backward compatible.\nBeing able to override and specify exactly what you want the test to beleive about your cluster is nice, but ideally it should generally work without specifying more flags. Surely we can detect this?\nI was thinking during some time about this, detecting the IP family is very simple having IPv4 or IPv6 only clusters, but with the introduction of dual stack I\u00b4m afraid about the supportability and reliability of the autodetecting mechanisms in the long term. If you see the dual stack PRs there are still a lot of unknowns about the cluster behavior. My point is, let\u00b4s have something first stable that works and is simple, and once dual stack is implemented, we can replace the flag with a function in the framework . I guess that migrating from a flag variable to a function is straight forward, is just replacing by , what do you think?\nin is as part of the context. do you mean adding as a function which will auto-detecting the ip family. less flags for the framework binary is preferred.\nonce we have this I will open a new issue to start cleaning up and , we no longer need to discriminate based on tags", "positive_passages": [{"docid": "doc-en-kubernetes-ad697a3f7fca92c071311a76cb6a85c18f199bc5ac946f703f84c2210e84ab5e", "text": "\"//vendor/github.com/onsi/ginkgo/reporters:go_default_library\", \"//vendor/github.com/onsi/gomega:go_default_library\", \"//vendor/k8s.io/klog:go_default_library\", <ins> \"//vendor/k8s.io/utils/net:go_default_library\", </ins> ], )", "commid": "kubernetes_pr_80398"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7dd992e79bede1333eea29d91300bc35053996291a11517e577968869cb33fdc", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Introduce a mechanism that allows specifying the IP protocol version used in the e2e testing. Why is this needed: This is a followup on , my understanding is that in order to discriminate between IPv4 or IPv6 we have to use the test labels and this adds complexity to the testing automation and doesn't allow to send this information to the context of the tests. Having a mechanism to specify the IP protocol will simplify the testing for IPv4 and IPv6 and will allow reusing most of the code.\n/sig testing /cc /assign Does this make sense? If affirmative, what should be the best way to add this functionality? Checking the code I think that or can provide this, don't know if checking some of the cluster config parameters, ...\nthe testing-commons group (sig-testing) maintains the framework, but ideally the decision on how to proceed in terms of adding ipv6 detection should come from sig-network. possibly having this as agenda for a sig-network meeting is a good start, then discussing it in a testing-commons meeting. /sig network the linked issue is a big one, so i don't have all the context here. but IMO existing tests should just work for ipv6 without the requirement for a new \"IPV6\" tag in test names. dual-stack or protocol specific tests should have their descriptions contain the details properly (i.e. what is this test doing) we might want to add an utility function under: (there is a PR to move it BTW ) then such an utility might be useful only to tests that need to detect the protocol. one of the goals is to refactor the code in testcontext / framework, so adding this logic there is less preferred.\n/area e2e-test-framework\nI think that we can add an option to test_context to specify the cluster IP family the same way that exists one for the cloud provider this is simpler because when setting up the CI jobs you will know beforehand what IP family you want to test, it also will allow reusing all the e2e code for IPv6 and Dual Stack (cc: and by default will be IPv4, so it\u00b4s backward compatible.\nBeing able to override and specify exactly what you want the test to beleive about your cluster is nice, but ideally it should generally work without specifying more flags. Surely we can detect this?\nI was thinking during some time about this, detecting the IP family is very simple having IPv4 or IPv6 only clusters, but with the introduction of dual stack I\u00b4m afraid about the supportability and reliability of the autodetecting mechanisms in the long term. If you see the dual stack PRs there are still a lot of unknowns about the cluster behavior. My point is, let\u00b4s have something first stable that works and is simple, and once dual stack is implemented, we can replace the flag with a function in the framework . I guess that migrating from a flag variable to a function is straight forward, is just replacing by , what do you think?\nin is as part of the context. do you mean adding as a function which will auto-detecting the ip family. less flags for the framework binary is preferred.\nonce we have this I will open a new issue to start cleaning up and , we no longer need to discriminate based on tags", "positive_passages": [{"docid": "doc-en-kubernetes-802164a7743aa18ee19ca4fc8067d54d882cc190495e79228edd3fdc8726711a", "text": "e2epod \"k8s.io/kubernetes/test/e2e/framework/pod\" \"k8s.io/kubernetes/test/e2e/manifest\" testutils \"k8s.io/kubernetes/test/utils\" <ins> utilnet \"k8s.io/utils/net\" </ins> // ensure auth plugins are loaded _ \"k8s.io/client-go/plugin/pkg/client/auth\"", "commid": "kubernetes_pr_80398"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7dd992e79bede1333eea29d91300bc35053996291a11517e577968869cb33fdc", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Introduce a mechanism that allows specifying the IP protocol version used in the e2e testing. Why is this needed: This is a followup on , my understanding is that in order to discriminate between IPv4 or IPv6 we have to use the test labels and this adds complexity to the testing automation and doesn't allow to send this information to the context of the tests. Having a mechanism to specify the IP protocol will simplify the testing for IPv4 and IPv6 and will allow reusing most of the code.\n/sig testing /cc /assign Does this make sense? If affirmative, what should be the best way to add this functionality? Checking the code I think that or can provide this, don't know if checking some of the cluster config parameters, ...\nthe testing-commons group (sig-testing) maintains the framework, but ideally the decision on how to proceed in terms of adding ipv6 detection should come from sig-network. possibly having this as agenda for a sig-network meeting is a good start, then discussing it in a testing-commons meeting. /sig network the linked issue is a big one, so i don't have all the context here. but IMO existing tests should just work for ipv6 without the requirement for a new \"IPV6\" tag in test names. dual-stack or protocol specific tests should have their descriptions contain the details properly (i.e. what is this test doing) we might want to add an utility function under: (there is a PR to move it BTW ) then such an utility might be useful only to tests that need to detect the protocol. one of the goals is to refactor the code in testcontext / framework, so adding this logic there is less preferred.\n/area e2e-test-framework\nI think that we can add an option to test_context to specify the cluster IP family the same way that exists one for the cloud provider this is simpler because when setting up the CI jobs you will know beforehand what IP family you want to test, it also will allow reusing all the e2e code for IPv6 and Dual Stack (cc: and by default will be IPv4, so it\u00b4s backward compatible.\nBeing able to override and specify exactly what you want the test to beleive about your cluster is nice, but ideally it should generally work without specifying more flags. Surely we can detect this?\nI was thinking during some time about this, detecting the IP family is very simple having IPv4 or IPv6 only clusters, but with the introduction of dual stack I\u00b4m afraid about the supportability and reliability of the autodetecting mechanisms in the long term. If you see the dual stack PRs there are still a lot of unknowns about the cluster behavior. My point is, let\u00b4s have something first stable that works and is simple, and once dual stack is implemented, we can replace the flag with a function in the framework . I guess that migrating from a flag variable to a function is straight forward, is just replacing by , what do you think?\nin is as part of the context. do you mean adding as a function which will auto-detecting the ip family. less flags for the framework binary is preferred.\nonce we have this I will open a new issue to start cleaning up and , we no longer need to discriminate based on tags", "positive_passages": [{"docid": "doc-en-kubernetes-c48e64e4995fdc9c558f74e4fd0877cee269a65d1d0aba6233429e7174be4344", "text": "e2elog.Logf(\"kube-apiserver version: %s\", serverVersion.GitVersion) } <ins> // Obtain the default IP family of the cluster // Some e2e test are designed to work on IPv4 only, this global variable // allows to adapt those tests to work on both IPv4 and IPv6 // TODO(dual-stack): dual stack clusters should pass full e2e testing at least with the primary IP family // the dual stack clusters can be ipv4-ipv6 or ipv6-ipv4, order matters, // and services use the primary IP family by default // If we\u00b4ll need to provide additional context for dual-stack, we can detect it // because pods have two addresses (one per family) framework.TestContext.IPFamily = getDefaultClusterIPFamily(c) e2elog.Logf(\"Cluster IP family: %s\", framework.TestContext.IPFamily) </ins> // Reference common test to make the import valid. commontest.CurrentSuite = commontest.E2E", "commid": "kubernetes_pr_80398"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7dd992e79bede1333eea29d91300bc35053996291a11517e577968869cb33fdc", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Introduce a mechanism that allows specifying the IP protocol version used in the e2e testing. Why is this needed: This is a followup on , my understanding is that in order to discriminate between IPv4 or IPv6 we have to use the test labels and this adds complexity to the testing automation and doesn't allow to send this information to the context of the tests. Having a mechanism to specify the IP protocol will simplify the testing for IPv4 and IPv6 and will allow reusing most of the code.\n/sig testing /cc /assign Does this make sense? If affirmative, what should be the best way to add this functionality? Checking the code I think that or can provide this, don't know if checking some of the cluster config parameters, ...\nthe testing-commons group (sig-testing) maintains the framework, but ideally the decision on how to proceed in terms of adding ipv6 detection should come from sig-network. possibly having this as agenda for a sig-network meeting is a good start, then discussing it in a testing-commons meeting. /sig network the linked issue is a big one, so i don't have all the context here. but IMO existing tests should just work for ipv6 without the requirement for a new \"IPV6\" tag in test names. dual-stack or protocol specific tests should have their descriptions contain the details properly (i.e. what is this test doing) we might want to add an utility function under: (there is a PR to move it BTW ) then such an utility might be useful only to tests that need to detect the protocol. one of the goals is to refactor the code in testcontext / framework, so adding this logic there is less preferred.\n/area e2e-test-framework\nI think that we can add an option to test_context to specify the cluster IP family the same way that exists one for the cloud provider this is simpler because when setting up the CI jobs you will know beforehand what IP family you want to test, it also will allow reusing all the e2e code for IPv6 and Dual Stack (cc: and by default will be IPv4, so it\u00b4s backward compatible.\nBeing able to override and specify exactly what you want the test to beleive about your cluster is nice, but ideally it should generally work without specifying more flags. Surely we can detect this?\nI was thinking during some time about this, detecting the IP family is very simple having IPv4 or IPv6 only clusters, but with the introduction of dual stack I\u00b4m afraid about the supportability and reliability of the autodetecting mechanisms in the long term. If you see the dual stack PRs there are still a lot of unknowns about the cluster behavior. My point is, let\u00b4s have something first stable that works and is simple, and once dual stack is implemented, we can replace the flag with a function in the framework . I guess that migrating from a flag variable to a function is straight forward, is just replacing by , what do you think?\nin is as part of the context. do you mean adding as a function which will auto-detecting the ip family. less flags for the framework binary is preferred.\nonce we have this I will open a new issue to start cleaning up and , we no longer need to discriminate based on tags", "positive_passages": [{"docid": "doc-en-kubernetes-9b7b2c2d2f80d319fe4f20e51930f4569a6b35bb41feb115a9cea020ce4e9ba4", "text": "e2elog.Logf(\"Output of clusterapi-tester:n%v\", logs) } } <ins> // getDefaultClusterIPFamily obtains the default IP family of the cluster // using the Cluster IP address of the kubernetes service created in the default namespace // This unequivocally identifies the default IP family because services are single family func getDefaultClusterIPFamily(c clientset.Interface) string { // Get the ClusterIP of the kubernetes service created in the default namespace svc, err := c.CoreV1().Services(metav1.NamespaceDefault).Get(\"kubernetes\", metav1.GetOptions{}) if err != nil { e2elog.Failf(\"Failed to get kubernetes service ClusterIP: %v\", err) } if utilnet.IsIPv6String(svc.Spec.ClusterIP) { return \"ipv6\" } return \"ipv4\" } </ins>", "commid": "kubernetes_pr_80398"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7dd992e79bede1333eea29d91300bc35053996291a11517e577968869cb33fdc", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Introduce a mechanism that allows specifying the IP protocol version used in the e2e testing. Why is this needed: This is a followup on , my understanding is that in order to discriminate between IPv4 or IPv6 we have to use the test labels and this adds complexity to the testing automation and doesn't allow to send this information to the context of the tests. Having a mechanism to specify the IP protocol will simplify the testing for IPv4 and IPv6 and will allow reusing most of the code.\n/sig testing /cc /assign Does this make sense? If affirmative, what should be the best way to add this functionality? Checking the code I think that or can provide this, don't know if checking some of the cluster config parameters, ...\nthe testing-commons group (sig-testing) maintains the framework, but ideally the decision on how to proceed in terms of adding ipv6 detection should come from sig-network. possibly having this as agenda for a sig-network meeting is a good start, then discussing it in a testing-commons meeting. /sig network the linked issue is a big one, so i don't have all the context here. but IMO existing tests should just work for ipv6 without the requirement for a new \"IPV6\" tag in test names. dual-stack or protocol specific tests should have their descriptions contain the details properly (i.e. what is this test doing) we might want to add an utility function under: (there is a PR to move it BTW ) then such an utility might be useful only to tests that need to detect the protocol. one of the goals is to refactor the code in testcontext / framework, so adding this logic there is less preferred.\n/area e2e-test-framework\nI think that we can add an option to test_context to specify the cluster IP family the same way that exists one for the cloud provider this is simpler because when setting up the CI jobs you will know beforehand what IP family you want to test, it also will allow reusing all the e2e code for IPv6 and Dual Stack (cc: and by default will be IPv4, so it\u00b4s backward compatible.\nBeing able to override and specify exactly what you want the test to beleive about your cluster is nice, but ideally it should generally work without specifying more flags. Surely we can detect this?\nI was thinking during some time about this, detecting the IP family is very simple having IPv4 or IPv6 only clusters, but with the introduction of dual stack I\u00b4m afraid about the supportability and reliability of the autodetecting mechanisms in the long term. If you see the dual stack PRs there are still a lot of unknowns about the cluster behavior. My point is, let\u00b4s have something first stable that works and is simple, and once dual stack is implemented, we can replace the flag with a function in the framework . I guess that migrating from a flag variable to a function is straight forward, is just replacing by , what do you think?\nin is as part of the context. do you mean adding as a function which will auto-detecting the ip family. less flags for the framework binary is preferred.\nonce we have this I will open a new issue to start cleaning up and , we no longer need to discriminate based on tags", "positive_passages": [{"docid": "doc-en-kubernetes-0cd1b83e4b51d2beeea4122edb8f4132e4eda3f1eeb8e7a3447ea02515e15add", "text": "\"//vendor/golang.org/x/net/websocket:go_default_library\", \"//vendor/k8s.io/klog:go_default_library\", \"//vendor/k8s.io/utils/exec:go_default_library\", <ins> \"//vendor/k8s.io/utils/net:go_default_library\", </ins> ], )", "commid": "kubernetes_pr_80398"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7dd992e79bede1333eea29d91300bc35053996291a11517e577968869cb33fdc", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Introduce a mechanism that allows specifying the IP protocol version used in the e2e testing. Why is this needed: This is a followup on , my understanding is that in order to discriminate between IPv4 or IPv6 we have to use the test labels and this adds complexity to the testing automation and doesn't allow to send this information to the context of the tests. Having a mechanism to specify the IP protocol will simplify the testing for IPv4 and IPv6 and will allow reusing most of the code.\n/sig testing /cc /assign Does this make sense? If affirmative, what should be the best way to add this functionality? Checking the code I think that or can provide this, don't know if checking some of the cluster config parameters, ...\nthe testing-commons group (sig-testing) maintains the framework, but ideally the decision on how to proceed in terms of adding ipv6 detection should come from sig-network. possibly having this as agenda for a sig-network meeting is a good start, then discussing it in a testing-commons meeting. /sig network the linked issue is a big one, so i don't have all the context here. but IMO existing tests should just work for ipv6 without the requirement for a new \"IPV6\" tag in test names. dual-stack or protocol specific tests should have their descriptions contain the details properly (i.e. what is this test doing) we might want to add an utility function under: (there is a PR to move it BTW ) then such an utility might be useful only to tests that need to detect the protocol. one of the goals is to refactor the code in testcontext / framework, so adding this logic there is less preferred.\n/area e2e-test-framework\nI think that we can add an option to test_context to specify the cluster IP family the same way that exists one for the cloud provider this is simpler because when setting up the CI jobs you will know beforehand what IP family you want to test, it also will allow reusing all the e2e code for IPv6 and Dual Stack (cc: and by default will be IPv4, so it\u00b4s backward compatible.\nBeing able to override and specify exactly what you want the test to beleive about your cluster is nice, but ideally it should generally work without specifying more flags. Surely we can detect this?\nI was thinking during some time about this, detecting the IP family is very simple having IPv4 or IPv6 only clusters, but with the introduction of dual stack I\u00b4m afraid about the supportability and reliability of the autodetecting mechanisms in the long term. If you see the dual stack PRs there are still a lot of unknowns about the cluster behavior. My point is, let\u00b4s have something first stable that works and is simple, and once dual stack is implemented, we can replace the flag with a function in the framework . I guess that migrating from a flag variable to a function is straight forward, is just replacing by , what do you think?\nin is as part of the context. do you mean adding as a function which will auto-detecting the ip family. less flags for the framework binary is preferred.\nonce we have this I will open a new issue to start cleaning up and , we no longer need to discriminate based on tags", "positive_passages": [{"docid": "doc-en-kubernetes-2627b4a123e0ca5209f27e2eee104645722b7ec371ff1dd3a41791636626c125", "text": "\"time\" \"github.com/onsi/ginkgo\" <del> \"k8s.io/api/core/v1\" </del> <ins> v1 \"k8s.io/api/core/v1\" </ins> metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/labels\" \"k8s.io/apimachinery/pkg/util/intstr\"", "commid": "kubernetes_pr_80398"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7dd992e79bede1333eea29d91300bc35053996291a11517e577968869cb33fdc", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Introduce a mechanism that allows specifying the IP protocol version used in the e2e testing. Why is this needed: This is a followup on , my understanding is that in order to discriminate between IPv4 or IPv6 we have to use the test labels and this adds complexity to the testing automation and doesn't allow to send this information to the context of the tests. Having a mechanism to specify the IP protocol will simplify the testing for IPv4 and IPv6 and will allow reusing most of the code.\n/sig testing /cc /assign Does this make sense? If affirmative, what should be the best way to add this functionality? Checking the code I think that or can provide this, don't know if checking some of the cluster config parameters, ...\nthe testing-commons group (sig-testing) maintains the framework, but ideally the decision on how to proceed in terms of adding ipv6 detection should come from sig-network. possibly having this as agenda for a sig-network meeting is a good start, then discussing it in a testing-commons meeting. /sig network the linked issue is a big one, so i don't have all the context here. but IMO existing tests should just work for ipv6 without the requirement for a new \"IPV6\" tag in test names. dual-stack or protocol specific tests should have their descriptions contain the details properly (i.e. what is this test doing) we might want to add an utility function under: (there is a PR to move it BTW ) then such an utility might be useful only to tests that need to detect the protocol. one of the goals is to refactor the code in testcontext / framework, so adding this logic there is less preferred.\n/area e2e-test-framework\nI think that we can add an option to test_context to specify the cluster IP family the same way that exists one for the cloud provider this is simpler because when setting up the CI jobs you will know beforehand what IP family you want to test, it also will allow reusing all the e2e code for IPv6 and Dual Stack (cc: and by default will be IPv4, so it\u00b4s backward compatible.\nBeing able to override and specify exactly what you want the test to beleive about your cluster is nice, but ideally it should generally work without specifying more flags. Surely we can detect this?\nI was thinking during some time about this, detecting the IP family is very simple having IPv4 or IPv6 only clusters, but with the introduction of dual stack I\u00b4m afraid about the supportability and reliability of the autodetecting mechanisms in the long term. If you see the dual stack PRs there are still a lot of unknowns about the cluster behavior. My point is, let\u00b4s have something first stable that works and is simple, and once dual stack is implemented, we can replace the flag with a function in the framework . I guess that migrating from a flag variable to a function is straight forward, is just replacing by , what do you think?\nin is as part of the context. do you mean adding as a function which will auto-detecting the ip family. less flags for the framework binary is preferred.\nonce we have this I will open a new issue to start cleaning up and , we no longer need to discriminate based on tags", "positive_passages": [{"docid": "doc-en-kubernetes-36e0e6e1e73a02898aacaa0c1881cf55c94cfed4feb5ffab9e57afc7c1850906", "text": "e2enode \"k8s.io/kubernetes/test/e2e/framework/node\" e2epod \"k8s.io/kubernetes/test/e2e/framework/pod\" imageutils \"k8s.io/kubernetes/test/utils/image\" <ins> k8utilnet \"k8s.io/utils/net\" </ins> ) const (", "commid": "kubernetes_pr_80398"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7dd992e79bede1333eea29d91300bc35053996291a11517e577968869cb33fdc", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Introduce a mechanism that allows specifying the IP protocol version used in the e2e testing. Why is this needed: This is a followup on , my understanding is that in order to discriminate between IPv4 or IPv6 we have to use the test labels and this adds complexity to the testing automation and doesn't allow to send this information to the context of the tests. Having a mechanism to specify the IP protocol will simplify the testing for IPv4 and IPv6 and will allow reusing most of the code.\n/sig testing /cc /assign Does this make sense? If affirmative, what should be the best way to add this functionality? Checking the code I think that or can provide this, don't know if checking some of the cluster config parameters, ...\nthe testing-commons group (sig-testing) maintains the framework, but ideally the decision on how to proceed in terms of adding ipv6 detection should come from sig-network. possibly having this as agenda for a sig-network meeting is a good start, then discussing it in a testing-commons meeting. /sig network the linked issue is a big one, so i don't have all the context here. but IMO existing tests should just work for ipv6 without the requirement for a new \"IPV6\" tag in test names. dual-stack or protocol specific tests should have their descriptions contain the details properly (i.e. what is this test doing) we might want to add an utility function under: (there is a PR to move it BTW ) then such an utility might be useful only to tests that need to detect the protocol. one of the goals is to refactor the code in testcontext / framework, so adding this logic there is less preferred.\n/area e2e-test-framework\nI think that we can add an option to test_context to specify the cluster IP family the same way that exists one for the cloud provider this is simpler because when setting up the CI jobs you will know beforehand what IP family you want to test, it also will allow reusing all the e2e code for IPv6 and Dual Stack (cc: and by default will be IPv4, so it\u00b4s backward compatible.\nBeing able to override and specify exactly what you want the test to beleive about your cluster is nice, but ideally it should generally work without specifying more flags. Surely we can detect this?\nI was thinking during some time about this, detecting the IP family is very simple having IPv4 or IPv6 only clusters, but with the introduction of dual stack I\u00b4m afraid about the supportability and reliability of the autodetecting mechanisms in the long term. If you see the dual stack PRs there are still a lot of unknowns about the cluster behavior. My point is, let\u00b4s have something first stable that works and is simple, and once dual stack is implemented, we can replace the flag with a function in the framework . I guess that migrating from a flag variable to a function is straight forward, is just replacing by , what do you think?\nin is as part of the context. do you mean adding as a function which will auto-detecting the ip family. less flags for the framework binary is preferred.\nonce we have this I will open a new issue to start cleaning up and , we no longer need to discriminate based on tags", "positive_passages": [{"docid": "doc-en-kubernetes-eb2cfd00fedba1f594ef8cfa0d681c9799907f9d8070274533050f3437517790", "text": "var netexecImageName = imageutils.GetE2EImage(imageutils.Agnhost) <ins> // TranslateIPv4ToIPv6 maps an IPv4 address into a valid IPv6 address // adding the well known prefix \"0::ffff:\" https://tools.ietf.org/html/rfc2765 // if the ip is IPv4 and the cluster IPFamily is IPv6, otherwise returns the same ip func TranslateIPv4ToIPv6(ip string) string { if TestContext.IPFamily == \"ipv6\" && !k8utilnet.IsIPv6String(ip) { ip = \"0::ffff:\" + ip } return ip } </ins> // NewNetworkingTestConfig creates and sets up a new test config helper. func NewNetworkingTestConfig(f *Framework) *NetworkingTestConfig { config := &NetworkingTestConfig{f: f, Namespace: f.Namespace.Name, HostNetwork: true}", "commid": "kubernetes_pr_80398"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7dd992e79bede1333eea29d91300bc35053996291a11517e577968869cb33fdc", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Introduce a mechanism that allows specifying the IP protocol version used in the e2e testing. Why is this needed: This is a followup on , my understanding is that in order to discriminate between IPv4 or IPv6 we have to use the test labels and this adds complexity to the testing automation and doesn't allow to send this information to the context of the tests. Having a mechanism to specify the IP protocol will simplify the testing for IPv4 and IPv6 and will allow reusing most of the code.\n/sig testing /cc /assign Does this make sense? If affirmative, what should be the best way to add this functionality? Checking the code I think that or can provide this, don't know if checking some of the cluster config parameters, ...\nthe testing-commons group (sig-testing) maintains the framework, but ideally the decision on how to proceed in terms of adding ipv6 detection should come from sig-network. possibly having this as agenda for a sig-network meeting is a good start, then discussing it in a testing-commons meeting. /sig network the linked issue is a big one, so i don't have all the context here. but IMO existing tests should just work for ipv6 without the requirement for a new \"IPV6\" tag in test names. dual-stack or protocol specific tests should have their descriptions contain the details properly (i.e. what is this test doing) we might want to add an utility function under: (there is a PR to move it BTW ) then such an utility might be useful only to tests that need to detect the protocol. one of the goals is to refactor the code in testcontext / framework, so adding this logic there is less preferred.\n/area e2e-test-framework\nI think that we can add an option to test_context to specify the cluster IP family the same way that exists one for the cloud provider this is simpler because when setting up the CI jobs you will know beforehand what IP family you want to test, it also will allow reusing all the e2e code for IPv6 and Dual Stack (cc: and by default will be IPv4, so it\u00b4s backward compatible.\nBeing able to override and specify exactly what you want the test to beleive about your cluster is nice, but ideally it should generally work without specifying more flags. Surely we can detect this?\nI was thinking during some time about this, detecting the IP family is very simple having IPv4 or IPv6 only clusters, but with the introduction of dual stack I\u00b4m afraid about the supportability and reliability of the autodetecting mechanisms in the long term. If you see the dual stack PRs there are still a lot of unknowns about the cluster behavior. My point is, let\u00b4s have something first stable that works and is simple, and once dual stack is implemented, we can replace the flag with a function in the framework . I guess that migrating from a flag variable to a function is straight forward, is just replacing by , what do you think?\nin is as part of the context. do you mean adding as a function which will auto-detecting the ip family. less flags for the framework binary is preferred.\nonce we have this I will open a new issue to start cleaning up and , we no longer need to discriminate based on tags", "positive_passages": [{"docid": "doc-en-kubernetes-c6211447ec695e53357eff7fb7331b1bca7ada265278c4867c6e4291a58cf13c", "text": "// The configuration of NodeKiller. NodeKiller NodeKillerConfig <ins> // The Default IP Family of the cluster (\"ipv4\" or \"ipv6\") IPFamily string </ins> } // NodeKillerConfig describes configuration of NodeKiller -- a utility to", "commid": "kubernetes_pr_80398"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7dd992e79bede1333eea29d91300bc35053996291a11517e577968869cb33fdc", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Introduce a mechanism that allows specifying the IP protocol version used in the e2e testing. Why is this needed: This is a followup on , my understanding is that in order to discriminate between IPv4 or IPv6 we have to use the test labels and this adds complexity to the testing automation and doesn't allow to send this information to the context of the tests. Having a mechanism to specify the IP protocol will simplify the testing for IPv4 and IPv6 and will allow reusing most of the code.\n/sig testing /cc /assign Does this make sense? If affirmative, what should be the best way to add this functionality? Checking the code I think that or can provide this, don't know if checking some of the cluster config parameters, ...\nthe testing-commons group (sig-testing) maintains the framework, but ideally the decision on how to proceed in terms of adding ipv6 detection should come from sig-network. possibly having this as agenda for a sig-network meeting is a good start, then discussing it in a testing-commons meeting. /sig network the linked issue is a big one, so i don't have all the context here. but IMO existing tests should just work for ipv6 without the requirement for a new \"IPV6\" tag in test names. dual-stack or protocol specific tests should have their descriptions contain the details properly (i.e. what is this test doing) we might want to add an utility function under: (there is a PR to move it BTW ) then such an utility might be useful only to tests that need to detect the protocol. one of the goals is to refactor the code in testcontext / framework, so adding this logic there is less preferred.\n/area e2e-test-framework\nI think that we can add an option to test_context to specify the cluster IP family the same way that exists one for the cloud provider this is simpler because when setting up the CI jobs you will know beforehand what IP family you want to test, it also will allow reusing all the e2e code for IPv6 and Dual Stack (cc: and by default will be IPv4, so it\u00b4s backward compatible.\nBeing able to override and specify exactly what you want the test to beleive about your cluster is nice, but ideally it should generally work without specifying more flags. Surely we can detect this?\nI was thinking during some time about this, detecting the IP family is very simple having IPv4 or IPv6 only clusters, but with the introduction of dual stack I\u00b4m afraid about the supportability and reliability of the autodetecting mechanisms in the long term. If you see the dual stack PRs there are still a lot of unknowns about the cluster behavior. My point is, let\u00b4s have something first stable that works and is simple, and once dual stack is implemented, we can replace the flag with a function in the framework . I guess that migrating from a flag variable to a function is straight forward, is just replacing by , what do you think?\nin is as part of the context. do you mean adding as a function which will auto-detecting the ip family. less flags for the framework binary is preferred.\nonce we have this I will open a new issue to start cleaning up and , we no longer need to discriminate based on tags", "positive_passages": [{"docid": "doc-en-kubernetes-b897724f3829acbc9d7cb9fdfa6f5965b13cebce7d9c4a6915451445096e8b9f", "text": "// create pod which using hostport on the specified node according to the nodeSelector func createHostPortPodOnNode(f *framework.Framework, podName, ns, hostIP string, port int32, protocol v1.Protocol, nodeSelector map[string]string, expectScheduled bool) { <ins> hostIP = framework.TranslateIPv4ToIPv6(hostIP) </ins> createPausePod(f, pausePodConfig{ Name: podName, Ports: []v1.ContainerPort{", "commid": "kubernetes_pr_80398"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844631212d61672d588215671b80c058c6787d965af7cbd5a18c20bcd00e1381", "query": "What happened: The externalName of a Service is not allowed to end with a trailing dot. What you expected to happen: The externalName of a Service should allow a trailing dot. This is very useful to denote a fully qualified value of the CNAME record created by the service and prevent DNS-trial-and-error by appending different (cluster-local) search domains. How to reproduce it (as minimally and precisely as possible): Try to set as a externalName for a Service of type ExternalName. More details The reference reads: RFC-1123 section 6.1.4.3 also states: Also in the errata of RFC-1123 a reference to RFC-1034 is to reiterate on what a legal hostname is. Section 3.1 of RFC-1034 explains the use and validity of a trailing dot. So while one could argue that a valid RFC-1123 subdomain may have a trailing dot, it might still be best to not change the which is used in a lot of places, but instead change the validation locally. Anything else we need to know?: I'll send a PR. Environment: Not much applicable.\n/sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d", "positive_passages": [{"docid": "doc-en-kubernetes-ab3e82462059f73d9fd258c46a15e2a4b37e5f7d037f3912201cd89c8f663e7d", "text": "if service.Spec.ClusterIP != \"\" { allErrs = append(allErrs, field.Forbidden(specPath.Child(\"clusterIP\"), \"must be empty for ExternalName services\")) } <del> if len(service.Spec.ExternalName) > 0 { allErrs = append(allErrs, ValidateDNS1123Subdomain(service.Spec.ExternalName, specPath.Child(\"externalName\"))...) </del> <ins> // The value (a CNAME) may have a trailing dot to denote it as fully qualified cname := strings.TrimSuffix(service.Spec.ExternalName, \".\") if len(cname) > 0 { allErrs = append(allErrs, ValidateDNS1123Subdomain(cname, specPath.Child(\"externalName\"))...) </ins> } else { allErrs = append(allErrs, field.Required(specPath.Child(\"externalName\"), \"\")) }", "commid": "kubernetes_pr_78385"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-844631212d61672d588215671b80c058c6787d965af7cbd5a18c20bcd00e1381", "query": "What happened: The externalName of a Service is not allowed to end with a trailing dot. What you expected to happen: The externalName of a Service should allow a trailing dot. This is very useful to denote a fully qualified value of the CNAME record created by the service and prevent DNS-trial-and-error by appending different (cluster-local) search domains. How to reproduce it (as minimally and precisely as possible): Try to set as a externalName for a Service of type ExternalName. More details The reference reads: RFC-1123 section 6.1.4.3 also states: Also in the errata of RFC-1123 a reference to RFC-1034 is to reiterate on what a legal hostname is. Section 3.1 of RFC-1034 explains the use and validity of a trailing dot. So while one could argue that a valid RFC-1123 subdomain may have a trailing dot, it might still be best to not change the which is used in a lot of places, but instead change the validation locally. Anything else we need to know?: I'll send a PR. Environment: Not much applicable.\n/sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d", "positive_passages": [{"docid": "doc-en-kubernetes-b6453372f90721db4fb533c1a4e75ff799d077bc81ac044c746996e5c388174f", "text": "numErrs: 0, }, { <ins> name: \"valid ExternalName (trailing dot)\", tweakSvc: func(s *core.Service) { s.Spec.Type = core.ServiceTypeExternalName s.Spec.ClusterIP = \"\" s.Spec.ExternalName = \"foo.bar.example.com.\" }, numErrs: 0, }, { </ins> name: \"invalid ExternalName clusterIP (valid IP)\", tweakSvc: func(s *core.Service) { s.Spec.Type = core.ServiceTypeExternalName", "commid": "kubernetes_pr_78385"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c82c8af2735bd0287155b4d0e1c197e36b2d063499f94b97cd0f5b47c16329a", "query": "What happened: Kops runs from a pod manifest stored on the node, having the annotation. We've experienced the case where the cluster autoscaler turned on a new node and, once the node has been to the cluster, application pods have been admitted before . Once it was the turn of , all system resources were utilized, so the pod has not been regularly admitted. However, since it's a critical pod, the executed the , which has tried to kill () a pod whose container wasn't started yet (it was downloading the Docker image), which has caused to timeout and return the error . The admission of failed with the following error: The pod execution has not been retried, so we've got a node without running and its networking broken. What you expected to happen: The should be eventually admitted. Anything else we need to know?: A minimal log extraction for comprehension: From the \"Failed to admit pod\" log I have been able to trace back the core code involved: () Logs: \"Failed to admit pod [POD] - [ERROR]\" () Error message: \"preemption: pod [POD] failed to evict [ERROR]\" () -() Error message: \"timeout waiting to kill pod\" Environment: Kubernetes version: Cloud provider: AWS OS: ubuntu 16.04.6 LTS (Xenial Xerus) Kernel: Install tools: kops Network plugin and version: kubenet\n/sig node\nI think the following change may alleviate the situation you encountered:\nThanks for your reply. To my understanding, when the is called it will return the minimum set of pods required to free up resources, so even if only 1 pod eviction fails it's likely that at the end of the the will not have enough resources anyway to admit the critical pod. In your opinion / experience: be an option introducing retries in the in case the eviction of 1 pod fails? yes, do you have any suggestion of a similar design adopted somewhere else in the ?\nLooking at getPodsToPreempt, I am not sure it returns the minimum set of Pods. For , retrying may not help much since the pod to be killed may not respond to the subsequent kill command.\nSorry to reiterate on this, but I double checked the code and - if I'm not missing anything - returns the minimum set of pods. Let's look at logic: pods by QOS class using that the total sum of evictable pods resources is enough to satify the requirements (resources to evict for the critical pod) the list of pods to evict, as the merge of three sublists: : the minimum set of pods to evict assuming we've already evicted all and all : the minimum set of pods to evict assuming we've already evicted all and the required : the minimum set of pods to evict to satify the requirements left Am I missing anything? A possible different approach to solve the issue is to refactor to return all input pods sorted by \"should be evicted first\". Then iterates over the full sorted list of potential pods to evict until the requirements are not satisfied (skipping to subtract pod resources from requirements if a pod fails on ) and breaking the loop as soon as the requirements are satisfied. What's your take on this? /cc who originally implemented this\nw.r.t. approach outlined above, it makes sense.\nWhether this evicts the \"minimum set\" depends on how you define the \"minimum set\". At the time this was implemented (k8s v1.5.0 IIRC), we didn't have PodPriority, so we used QoS to mirror the kubelet's eviction algorithm. It should probably prioritize low-priority pods for eviction today given the recent changes to the eviction algorithm to incorporate PodPriority. The current approach minimizes the eviction of guaranteed pods, and prioritizes evicting few larger pods over many smaller ones. Since eviction marks the evicted pod as failed, it should suffice to just admit the pod regardless of what is returned by the evictPod function. In future syncPod loops, the kubelet will retry the pod deletion steps that it was stuck on. It would eliminate this class of bugs entirely, which was the purpose of the feature in the first place.\nSee if the following aligns with your suggestion:\nSomething like that, yeah. I'm not sure the \"Failed to admit pod\" log warning is still required, but we can iron those things out during code review.\nDoing like this it means we do always admit pods, while we should do it only for critical pods, correct?\nPlease see this The change is for critical pod(s).", "positive_passages": [{"docid": "doc-en-kubernetes-711309b8a197481470234435c3fb1566d17746156bc15633764895be869cafde", "text": "// this is a blocking call and should only return when the pod and its containers are killed. err := c.killPodFunc(pod, status, nil) if err != nil { <del> return fmt.Errorf(\"preemption: pod %s failed to evict %v\", format.Pod(pod), err) </del> <ins> klog.Warningf(\"preemption: pod %s failed to evict %v\", format.Pod(pod), err) // In future syncPod loops, the kubelet will retry the pod deletion steps that it was stuck on. continue </ins> } klog.Infof(\"preemption: pod %s evicted successfully\", format.Pod(pod)) }", "commid": "kubernetes_pr_78493"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c82c8af2735bd0287155b4d0e1c197e36b2d063499f94b97cd0f5b47c16329a", "query": "What happened: Kops runs from a pod manifest stored on the node, having the annotation. We've experienced the case where the cluster autoscaler turned on a new node and, once the node has been to the cluster, application pods have been admitted before . Once it was the turn of , all system resources were utilized, so the pod has not been regularly admitted. However, since it's a critical pod, the executed the , which has tried to kill () a pod whose container wasn't started yet (it was downloading the Docker image), which has caused to timeout and return the error . The admission of failed with the following error: The pod execution has not been retried, so we've got a node without running and its networking broken. What you expected to happen: The should be eventually admitted. Anything else we need to know?: A minimal log extraction for comprehension: From the \"Failed to admit pod\" log I have been able to trace back the core code involved: () Logs: \"Failed to admit pod [POD] - [ERROR]\" () Error message: \"preemption: pod [POD] failed to evict [ERROR]\" () -() Error message: \"timeout waiting to kill pod\" Environment: Kubernetes version: Cloud provider: AWS OS: ubuntu 16.04.6 LTS (Xenial Xerus) Kernel: Install tools: kops Network plugin and version: kubenet\n/sig node\nI think the following change may alleviate the situation you encountered:\nThanks for your reply. To my understanding, when the is called it will return the minimum set of pods required to free up resources, so even if only 1 pod eviction fails it's likely that at the end of the the will not have enough resources anyway to admit the critical pod. In your opinion / experience: be an option introducing retries in the in case the eviction of 1 pod fails? yes, do you have any suggestion of a similar design adopted somewhere else in the ?\nLooking at getPodsToPreempt, I am not sure it returns the minimum set of Pods. For , retrying may not help much since the pod to be killed may not respond to the subsequent kill command.\nSorry to reiterate on this, but I double checked the code and - if I'm not missing anything - returns the minimum set of pods. Let's look at logic: pods by QOS class using that the total sum of evictable pods resources is enough to satify the requirements (resources to evict for the critical pod) the list of pods to evict, as the merge of three sublists: : the minimum set of pods to evict assuming we've already evicted all and all : the minimum set of pods to evict assuming we've already evicted all and the required : the minimum set of pods to evict to satify the requirements left Am I missing anything? A possible different approach to solve the issue is to refactor to return all input pods sorted by \"should be evicted first\". Then iterates over the full sorted list of potential pods to evict until the requirements are not satisfied (skipping to subtract pod resources from requirements if a pod fails on ) and breaking the loop as soon as the requirements are satisfied. What's your take on this? /cc who originally implemented this\nw.r.t. approach outlined above, it makes sense.\nWhether this evicts the \"minimum set\" depends on how you define the \"minimum set\". At the time this was implemented (k8s v1.5.0 IIRC), we didn't have PodPriority, so we used QoS to mirror the kubelet's eviction algorithm. It should probably prioritize low-priority pods for eviction today given the recent changes to the eviction algorithm to incorporate PodPriority. The current approach minimizes the eviction of guaranteed pods, and prioritizes evicting few larger pods over many smaller ones. Since eviction marks the evicted pod as failed, it should suffice to just admit the pod regardless of what is returned by the evictPod function. In future syncPod loops, the kubelet will retry the pod deletion steps that it was stuck on. It would eliminate this class of bugs entirely, which was the purpose of the feature in the first place.\nSee if the following aligns with your suggestion:\nSomething like that, yeah. I'm not sure the \"Failed to admit pod\" log warning is still required, but we can iron those things out during code review.\nDoing like this it means we do always admit pods, while we should do it only for critical pods, correct?\nPlease see this The change is for critical pod(s).", "positive_passages": [{"docid": "doc-en-kubernetes-850b6a8124b71cca5892a7aba48f0f9c649ef28f504e0f2836f3897ec607789f", "text": ") type fakePodKiller struct { <del> killedPods []*v1.Pod </del> <ins> killedPods          []*v1.Pod errDuringPodKilling bool </ins> } <del> func newFakePodKiller() *fakePodKiller { return &fakePodKiller{killedPods: []*v1.Pod{}} </del> <ins> func newFakePodKiller(errPodKilling bool) *fakePodKiller { return &fakePodKiller{killedPods: []*v1.Pod{}, errDuringPodKilling: errPodKilling} </ins> } func (f *fakePodKiller) clear() {", "commid": "kubernetes_pr_78493"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c82c8af2735bd0287155b4d0e1c197e36b2d063499f94b97cd0f5b47c16329a", "query": "What happened: Kops runs from a pod manifest stored on the node, having the annotation. We've experienced the case where the cluster autoscaler turned on a new node and, once the node has been to the cluster, application pods have been admitted before . Once it was the turn of , all system resources were utilized, so the pod has not been regularly admitted. However, since it's a critical pod, the executed the , which has tried to kill () a pod whose container wasn't started yet (it was downloading the Docker image), which has caused to timeout and return the error . The admission of failed with the following error: The pod execution has not been retried, so we've got a node without running and its networking broken. What you expected to happen: The should be eventually admitted. Anything else we need to know?: A minimal log extraction for comprehension: From the \"Failed to admit pod\" log I have been able to trace back the core code involved: () Logs: \"Failed to admit pod [POD] - [ERROR]\" () Error message: \"preemption: pod [POD] failed to evict [ERROR]\" () -() Error message: \"timeout waiting to kill pod\" Environment: Kubernetes version: Cloud provider: AWS OS: ubuntu 16.04.6 LTS (Xenial Xerus) Kernel: Install tools: kops Network plugin and version: kubenet\n/sig node\nI think the following change may alleviate the situation you encountered:\nThanks for your reply. To my understanding, when the is called it will return the minimum set of pods required to free up resources, so even if only 1 pod eviction fails it's likely that at the end of the the will not have enough resources anyway to admit the critical pod. In your opinion / experience: be an option introducing retries in the in case the eviction of 1 pod fails? yes, do you have any suggestion of a similar design adopted somewhere else in the ?\nLooking at getPodsToPreempt, I am not sure it returns the minimum set of Pods. For , retrying may not help much since the pod to be killed may not respond to the subsequent kill command.\nSorry to reiterate on this, but I double checked the code and - if I'm not missing anything - returns the minimum set of pods. Let's look at logic: pods by QOS class using that the total sum of evictable pods resources is enough to satify the requirements (resources to evict for the critical pod) the list of pods to evict, as the merge of three sublists: : the minimum set of pods to evict assuming we've already evicted all and all : the minimum set of pods to evict assuming we've already evicted all and the required : the minimum set of pods to evict to satify the requirements left Am I missing anything? A possible different approach to solve the issue is to refactor to return all input pods sorted by \"should be evicted first\". Then iterates over the full sorted list of potential pods to evict until the requirements are not satisfied (skipping to subtract pod resources from requirements if a pod fails on ) and breaking the loop as soon as the requirements are satisfied. What's your take on this? /cc who originally implemented this\nw.r.t. approach outlined above, it makes sense.\nWhether this evicts the \"minimum set\" depends on how you define the \"minimum set\". At the time this was implemented (k8s v1.5.0 IIRC), we didn't have PodPriority, so we used QoS to mirror the kubelet's eviction algorithm. It should probably prioritize low-priority pods for eviction today given the recent changes to the eviction algorithm to incorporate PodPriority. The current approach minimizes the eviction of guaranteed pods, and prioritizes evicting few larger pods over many smaller ones. Since eviction marks the evicted pod as failed, it should suffice to just admit the pod regardless of what is returned by the evictPod function. In future syncPod loops, the kubelet will retry the pod deletion steps that it was stuck on. It would eliminate this class of bugs entirely, which was the purpose of the feature in the first place.\nSee if the following aligns with your suggestion:\nSomething like that, yeah. I'm not sure the \"Failed to admit pod\" log warning is still required, but we can iron those things out during code review.\nDoing like this it means we do always admit pods, while we should do it only for critical pods, correct?\nPlease see this The change is for critical pod(s).", "positive_passages": [{"docid": "doc-en-kubernetes-2a8096b623bc3a2dec32c09d70148f82f9fa42bb49abf47c3763472814cbb214", "text": "} func (f *fakePodKiller) killPodNow(pod *v1.Pod, status v1.PodStatus, gracePeriodOverride *int64) error { <ins> if f.errDuringPodKilling { f.killedPods = []*v1.Pod{} return fmt.Errorf(\"problem killing pod %v\", pod) } </ins> f.killedPods = append(f.killedPods, pod) return nil }", "commid": "kubernetes_pr_78493"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c82c8af2735bd0287155b4d0e1c197e36b2d063499f94b97cd0f5b47c16329a", "query": "What happened: Kops runs from a pod manifest stored on the node, having the annotation. We've experienced the case where the cluster autoscaler turned on a new node and, once the node has been to the cluster, application pods have been admitted before . Once it was the turn of , all system resources were utilized, so the pod has not been regularly admitted. However, since it's a critical pod, the executed the , which has tried to kill () a pod whose container wasn't started yet (it was downloading the Docker image), which has caused to timeout and return the error . The admission of failed with the following error: The pod execution has not been retried, so we've got a node without running and its networking broken. What you expected to happen: The should be eventually admitted. Anything else we need to know?: A minimal log extraction for comprehension: From the \"Failed to admit pod\" log I have been able to trace back the core code involved: () Logs: \"Failed to admit pod [POD] - [ERROR]\" () Error message: \"preemption: pod [POD] failed to evict [ERROR]\" () -() Error message: \"timeout waiting to kill pod\" Environment: Kubernetes version: Cloud provider: AWS OS: ubuntu 16.04.6 LTS (Xenial Xerus) Kernel: Install tools: kops Network plugin and version: kubenet\n/sig node\nI think the following change may alleviate the situation you encountered:\nThanks for your reply. To my understanding, when the is called it will return the minimum set of pods required to free up resources, so even if only 1 pod eviction fails it's likely that at the end of the the will not have enough resources anyway to admit the critical pod. In your opinion / experience: be an option introducing retries in the in case the eviction of 1 pod fails? yes, do you have any suggestion of a similar design adopted somewhere else in the ?\nLooking at getPodsToPreempt, I am not sure it returns the minimum set of Pods. For , retrying may not help much since the pod to be killed may not respond to the subsequent kill command.\nSorry to reiterate on this, but I double checked the code and - if I'm not missing anything - returns the minimum set of pods. Let's look at logic: pods by QOS class using that the total sum of evictable pods resources is enough to satify the requirements (resources to evict for the critical pod) the list of pods to evict, as the merge of three sublists: : the minimum set of pods to evict assuming we've already evicted all and all : the minimum set of pods to evict assuming we've already evicted all and the required : the minimum set of pods to evict to satify the requirements left Am I missing anything? A possible different approach to solve the issue is to refactor to return all input pods sorted by \"should be evicted first\". Then iterates over the full sorted list of potential pods to evict until the requirements are not satisfied (skipping to subtract pod resources from requirements if a pod fails on ) and breaking the loop as soon as the requirements are satisfied. What's your take on this? /cc who originally implemented this\nw.r.t. approach outlined above, it makes sense.\nWhether this evicts the \"minimum set\" depends on how you define the \"minimum set\". At the time this was implemented (k8s v1.5.0 IIRC), we didn't have PodPriority, so we used QoS to mirror the kubelet's eviction algorithm. It should probably prioritize low-priority pods for eviction today given the recent changes to the eviction algorithm to incorporate PodPriority. The current approach minimizes the eviction of guaranteed pods, and prioritizes evicting few larger pods over many smaller ones. Since eviction marks the evicted pod as failed, it should suffice to just admit the pod regardless of what is returned by the evictPod function. In future syncPod loops, the kubelet will retry the pod deletion steps that it was stuck on. It would eliminate this class of bugs entirely, which was the purpose of the feature in the first place.\nSee if the following aligns with your suggestion:\nSomething like that, yeah. I'm not sure the \"Failed to admit pod\" log warning is still required, but we can iron those things out during code review.\nDoing like this it means we do always admit pods, while we should do it only for critical pods, correct?\nPlease see this The change is for critical pod(s).", "positive_passages": [{"docid": "doc-en-kubernetes-4f620cf759f8722ab8856392056ff7f4fd933bc5e037c926fcceb7c3d29e6dc2", "text": "} } <ins> func TestEvictPodsToFreeRequestsWithError(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ExperimentalCriticalPodAnnotation, true)() type testRun struct { testName              string inputPods             []*v1.Pod insufficientResources admissionRequirementList expectErr             bool expectedOutput        []*v1.Pod } podProvider := newFakePodProvider() podKiller := newFakePodKiller(true) criticalPodAdmissionHandler := getTestCriticalPodAdmissionHandler(podProvider, podKiller) allPods := getTestPods() runs := []testRun{ { testName: \"multiple pods eviction error\", inputPods: []*v1.Pod{ allPods[critical], allPods[bestEffort], allPods[burstable], allPods[highRequestBurstable], allPods[guaranteed], allPods[highRequestGuaranteed]}, insufficientResources: getAdmissionRequirementList(0, 550, 0), expectErr:             false, expectedOutput:        nil, }, } for _, r := range runs { podProvider.setPods(r.inputPods) outErr := criticalPodAdmissionHandler.evictPodsToFreeRequests(allPods[critical], r.insufficientResources) outputPods := podKiller.getKilledPods() if !r.expectErr && outErr != nil { t.Errorf(\"evictPodsToFreeRequests returned an unexpected error during the %s test.  Err: %v\", r.testName, outErr) } else if r.expectErr && outErr == nil { t.Errorf(\"evictPodsToFreeRequests expected an error but returned a successful output=%v during the %s test.\", outputPods, r.testName) } else if !podListEqual(r.expectedOutput, outputPods) { t.Errorf(\"evictPodsToFreeRequests expected %v but got %v during the %s test.\", r.expectedOutput, outputPods, r.testName) } podKiller.clear() } } </ins> func TestEvictPodsToFreeRequests(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ExperimentalCriticalPodAnnotation, true)() type testRun struct {", "commid": "kubernetes_pr_78493"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c82c8af2735bd0287155b4d0e1c197e36b2d063499f94b97cd0f5b47c16329a", "query": "What happened: Kops runs from a pod manifest stored on the node, having the annotation. We've experienced the case where the cluster autoscaler turned on a new node and, once the node has been to the cluster, application pods have been admitted before . Once it was the turn of , all system resources were utilized, so the pod has not been regularly admitted. However, since it's a critical pod, the executed the , which has tried to kill () a pod whose container wasn't started yet (it was downloading the Docker image), which has caused to timeout and return the error . The admission of failed with the following error: The pod execution has not been retried, so we've got a node without running and its networking broken. What you expected to happen: The should be eventually admitted. Anything else we need to know?: A minimal log extraction for comprehension: From the \"Failed to admit pod\" log I have been able to trace back the core code involved: () Logs: \"Failed to admit pod [POD] - [ERROR]\" () Error message: \"preemption: pod [POD] failed to evict [ERROR]\" () -() Error message: \"timeout waiting to kill pod\" Environment: Kubernetes version: Cloud provider: AWS OS: ubuntu 16.04.6 LTS (Xenial Xerus) Kernel: Install tools: kops Network plugin and version: kubenet\n/sig node\nI think the following change may alleviate the situation you encountered:\nThanks for your reply. To my understanding, when the is called it will return the minimum set of pods required to free up resources, so even if only 1 pod eviction fails it's likely that at the end of the the will not have enough resources anyway to admit the critical pod. In your opinion / experience: be an option introducing retries in the in case the eviction of 1 pod fails? yes, do you have any suggestion of a similar design adopted somewhere else in the ?\nLooking at getPodsToPreempt, I am not sure it returns the minimum set of Pods. For , retrying may not help much since the pod to be killed may not respond to the subsequent kill command.\nSorry to reiterate on this, but I double checked the code and - if I'm not missing anything - returns the minimum set of pods. Let's look at logic: pods by QOS class using that the total sum of evictable pods resources is enough to satify the requirements (resources to evict for the critical pod) the list of pods to evict, as the merge of three sublists: : the minimum set of pods to evict assuming we've already evicted all and all : the minimum set of pods to evict assuming we've already evicted all and the required : the minimum set of pods to evict to satify the requirements left Am I missing anything? A possible different approach to solve the issue is to refactor to return all input pods sorted by \"should be evicted first\". Then iterates over the full sorted list of potential pods to evict until the requirements are not satisfied (skipping to subtract pod resources from requirements if a pod fails on ) and breaking the loop as soon as the requirements are satisfied. What's your take on this? /cc who originally implemented this\nw.r.t. approach outlined above, it makes sense.\nWhether this evicts the \"minimum set\" depends on how you define the \"minimum set\". At the time this was implemented (k8s v1.5.0 IIRC), we didn't have PodPriority, so we used QoS to mirror the kubelet's eviction algorithm. It should probably prioritize low-priority pods for eviction today given the recent changes to the eviction algorithm to incorporate PodPriority. The current approach minimizes the eviction of guaranteed pods, and prioritizes evicting few larger pods over many smaller ones. Since eviction marks the evicted pod as failed, it should suffice to just admit the pod regardless of what is returned by the evictPod function. In future syncPod loops, the kubelet will retry the pod deletion steps that it was stuck on. It would eliminate this class of bugs entirely, which was the purpose of the feature in the first place.\nSee if the following aligns with your suggestion:\nSomething like that, yeah. I'm not sure the \"Failed to admit pod\" log warning is still required, but we can iron those things out during code review.\nDoing like this it means we do always admit pods, while we should do it only for critical pods, correct?\nPlease see this The change is for critical pod(s).", "positive_passages": [{"docid": "doc-en-kubernetes-1bf499caec70808c6aa4d545ed5021a8572fc499bdd53998d002a0bc1d820b6d", "text": "expectedOutput        []*v1.Pod } podProvider := newFakePodProvider() <del> podKiller := newFakePodKiller() </del> <ins> podKiller := newFakePodKiller(false) </ins> criticalPodAdmissionHandler := getTestCriticalPodAdmissionHandler(podProvider, podKiller) allPods := getTestPods() runs := []testRun{", "commid": "kubernetes_pr_78493"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5eb0ac65b3d30c0951e0da1f97bdb8adf05f535c840f17ca4a42ad70e61c0160", "query": "What happened: logs a nil error on success, EG: . What you expected to happen: kube-proxy shouldn't log an error on success. Either a nil error should be interpreted as success, or an explicit exit boolean should be returned & evaluated. How to reproduce it (as minimally and precisely as possible): Run in master/1.15, or 1.14.2+. Anything else we need to know?: Code indicates that this is a problem ever since exiting was introduced (kube-proxy previously hung). It calls log.Fatal() on the return result, under the now-false assumption that an exit -a crash. Environment: Hyperkube, 1.14.2\n/sig network /priority important-longterm /cc\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/assign\nGitHub didn't allow me to assign the following users: johscheuer. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI would start looking into this but it seems I can't assign myself\nthe bot only works on org members\nGitHub doesn't allow assigning people unless they are either members of the organization or repo \"collaborators\". There's no way around this. Kubernetes doesn't use the latter mechanism in favor of the org membership process. (some notes / links in the bot comment). You can certainly take a stab at this without assigning it though", "positive_passages": [{"docid": "doc-en-kubernetes-596c09ffcc4e884183e1645e13dac17c96ae28b0610d23bfc959ba43ee9b8e12", "text": "if err := opts.Validate(args); err != nil { klog.Fatalf(\"failed validate: %v\", err) } <del> klog.Fatal(opts.Run()) </del> <ins> if err := opts.Run(); err != nil { klog.Exit(err) } </ins> }, }", "commid": "kubernetes_pr_78775"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-083944d00199b655f25fb35f51e7ea3786d4181f487cac5cdbda9f2140ce4497", "query": "<!-- Please only use this template for submitting enhancement requests --The built-in and cluster roles here are deprecated in 1.13 when this issue was resolved: /sig storage /milestone v1.17 /priorit important-longterm\nYou must be a member of the GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. <detailsIn response to : <!-- Please only use this template for submitting enhancement requests -- /milestone v1.17 /priorit important-longterm Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /priority important-longterm\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale /assign\nBug triage for 1.17 here with a gentle reminder that code freeze for this release is on November 14. Is this issue still intended for 1.17?", "positive_passages": [{"docid": "doc-en-kubernetes-cb0107493533f820b34c539192006535d74417fa6f51a81419bf6e5cbe3d2296", "text": "}, }, { <del> // a role for the csi external attacher ObjectMeta: metav1.ObjectMeta{Name: \"system:csi-external-attacher\"}, Rules: []rbacv1.PolicyRule{ rbacv1helpers.NewRule(\"get\", \"list\", \"watch\", \"update\", \"patch\").Groups(legacyGroup).Resources(\"persistentvolumes\").RuleOrDie(), rbacv1helpers.NewRule(\"get\", \"list\", \"watch\").Groups(legacyGroup).Resources(\"nodes\").RuleOrDie(), rbacv1helpers.NewRule(\"get\", \"list\", \"watch\", \"update\", \"patch\").Groups(storageGroup).Resources(\"volumeattachments\").RuleOrDie(), rbacv1helpers.NewRule(\"get\", \"list\", \"watch\", \"create\", \"update\", \"patch\").Groups(legacyGroup).Resources(\"events\").RuleOrDie(), }, }, { </del> // a role making the csrapprover controller approve a node client CSR ObjectMeta: metav1.ObjectMeta{Name: \"system:certificates.k8s.io:certificatesigningrequests:nodeclient\"}, Rules: []rbacv1.PolicyRule{", "commid": "kubernetes_pr_84282"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-083944d00199b655f25fb35f51e7ea3786d4181f487cac5cdbda9f2140ce4497", "query": "<!-- Please only use this template for submitting enhancement requests --The built-in and cluster roles here are deprecated in 1.13 when this issue was resolved: /sig storage /milestone v1.17 /priorit important-longterm\nYou must be a member of the GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. <detailsIn response to : <!-- Please only use this template for submitting enhancement requests -- /milestone v1.17 /priorit important-longterm Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /priority important-longterm\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale /assign\nBug triage for 1.17 here with a gentle reminder that code freeze for this release is on November 14. Is this issue still intended for 1.17?", "positive_passages": [{"docid": "doc-en-kubernetes-01088ddce912f218dcbcf091f77a80ddf0c6b0f8ae14ba3434a6bb7f818d5397", "text": "Rules:      kubeSchedulerRules, }) <del> externalProvisionerRules := []rbacv1.PolicyRule{ rbacv1helpers.NewRule(\"create\", \"delete\", \"get\", \"list\", \"watch\").Groups(legacyGroup).Resources(\"persistentvolumes\").RuleOrDie(), rbacv1helpers.NewRule(\"get\", \"list\", \"watch\", \"update\", \"patch\").Groups(legacyGroup).Resources(\"persistentvolumeclaims\").RuleOrDie(), rbacv1helpers.NewRule(\"list\", \"watch\").Groups(storageGroup).Resources(\"storageclasses\").RuleOrDie(), rbacv1helpers.NewRule(\"get\", \"list\", \"watch\", \"create\", \"update\", \"patch\").Groups(legacyGroup).Resources(\"events\").RuleOrDie(), rbacv1helpers.NewRule(\"get\", \"list\", \"watch\").Groups(legacyGroup).Resources(\"nodes\").RuleOrDie(), } if utilfeature.DefaultFeatureGate.Enabled(features.CSINodeInfo) { externalProvisionerRules = append(externalProvisionerRules, rbacv1helpers.NewRule(\"get\", \"watch\", \"list\").Groups(\"storage.k8s.io\").Resources(\"csinodes\").RuleOrDie()) } roles = append(roles, rbacv1.ClusterRole{ // a role for the csi external provisioner ObjectMeta: metav1.ObjectMeta{Name: \"system:csi-external-provisioner\"}, Rules:      externalProvisionerRules, }) </del> addClusterRoleLabel(roles) return roles }", "commid": "kubernetes_pr_84282"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-083944d00199b655f25fb35f51e7ea3786d4181f487cac5cdbda9f2140ce4497", "query": "<!-- Please only use this template for submitting enhancement requests --The built-in and cluster roles here are deprecated in 1.13 when this issue was resolved: /sig storage /milestone v1.17 /priorit important-longterm\nYou must be a member of the GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. <detailsIn response to : <!-- Please only use this template for submitting enhancement requests -- /milestone v1.17 /priorit important-longterm Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /priority important-longterm\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale /assign\nBug triage for 1.17 here with a gentle reminder that code freeze for this release is on November 14. Is this issue still intended for 1.17?", "positive_passages": [{"docid": "doc-en-kubernetes-a35e2f6d2278a3d4338b67f593ae860d215763fd0fd83cb1828782d189d661f4", "text": "creationTimestamp: null labels: kubernetes.io/bootstrapping: rbac-defaults <del> name: system:csi-external-attacher rules: - apiGroups: - \"\" resources: - persistentvolumes verbs: - get - list - patch - update - watch - apiGroups: - \"\" resources: - nodes verbs: - get - list - watch - apiGroups: - storage.k8s.io resources: - volumeattachments verbs: - get - list - patch - update - watch - apiGroups: - \"\" resources: - events verbs: - create - get - list - patch - update - watch - apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: annotations: rbac.authorization.kubernetes.io/autoupdate: \"true\" creationTimestamp: null labels: kubernetes.io/bootstrapping: rbac-defaults name: system:csi-external-provisioner rules: - apiGroups: - \"\" resources: - persistentvolumes verbs: - create - delete - get - list - watch - apiGroups: - \"\" resources: - persistentvolumeclaims verbs: - get - list - patch - update - watch - apiGroups: - storage.k8s.io resources: - storageclasses verbs: - list - watch - apiGroups: - \"\" resources: - events verbs: - create - get - list - patch - update - watch - apiGroups: - \"\" resources: - nodes verbs: - get - list - watch - apiGroups: - storage.k8s.io resources: - csinodes verbs: - get - list - watch - apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: annotations: rbac.authorization.kubernetes.io/autoupdate: \"true\" creationTimestamp: null labels: kubernetes.io/bootstrapping: rbac-defaults </del> name: system:discovery rules: - nonResourceURLs:", "commid": "kubernetes_pr_84282"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ba159de838e276a42915cbe831ad277f6b9150cbf7cfdd40b9245b21c2eb7560", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: kubelet terminated unexpectedly during hack/local-up-cluster kubelet log as a result apiserver cannot find the node to schedule pods What you expected to happen: kubelet runs successfully and hack/local-up-cluster creates a single node cluster How to reproduce it (as minimally and precisely as possible): run hack/local-up-cluster from HEAD Anything else we need to know?: additional cgroups check seemed to be introduced in ; hack/local-up-cluster works when I check out the parent commit have CI for hack/local-up-cluster and , so I'm not sure if it's an error on my side. It would be greatly appreciated if someone could explain it to me Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Debian GNU/Linux Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /sig node cc\nThanks for raising such a detailed issue! cc any thoughts here? Confusingly, I think the kubelet has been assigned a different cgroup for memory and for cpu... however the fact that its using makes me think the user is relying on system defaults. out of curiosity, have you made any mods to how your system assigns cgroups?\nIt sounds like we might want to handle the error more gracefully. If we can't get the kubelet's cgroup, we should fall back to collecting metrics from all cgroups.\ncollecting metrics from all the cgroups on the system? Any concerns about how many cgroups there could be? Also, or any interest in implementing this fix (assuming we go with the fallback behavior)? If not, I can try.\nthanks for looking into this! Sorry I'm not familiar with cgroups. I'm don't know any modification to my system assigns cgroups in particular\nI can put out a PR this week\nxref\nThanks!", "positive_passages": [{"docid": "doc-en-kubernetes-018ecba037828f5f59349091e3f0f6427d58a2f18f64e7a933c38b6586b32e59", "text": "cgroupRoots = append(cgroupRoots, cm.NodeAllocatableRoot(s.CgroupRoot, s.CgroupDriver)) kubeletCgroup, err := cm.GetKubeletContainer(s.KubeletCgroups) if err != nil { <del> return fmt.Errorf(\"failed to get the kubelet's cgroup: %v\", err) } if kubeletCgroup != \"\" { </del> <ins> klog.Warningf(\"failed to get the kubelet's cgroup: %v.  Kubelet system container metrics may be missing.\", err) } else if kubeletCgroup != \"\" { </ins> cgroupRoots = append(cgroupRoots, kubeletCgroup) } runtimeCgroup, err := cm.GetRuntimeContainer(s.ContainerRuntime, s.RuntimeCgroups) if err != nil { <del> return fmt.Errorf(\"failed to get the container runtime's cgroup: %v\", err) } if runtimeCgroup != \"\" { </del> <ins> klog.Warningf(\"failed to get the container runtime's cgroup: %v. Runtime system container metrics may be missing.\", err) } else if runtimeCgroup != \"\" { </ins> // RuntimeCgroups is optional, so ignore if it isn't specified cgroupRoots = append(cgroupRoots, runtimeCgroup) }", "commid": "kubernetes_pr_79245"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3f173d1022a4408031efac17c8299f04d835794ab8a77d69bb7667b0107a08bf", "query": "Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /sig instrumentation /assign\nGitHub didn't allow me to assign the following users: solodov. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nrecommends that we generate those metrics in the GenericPLEG during the relist. We can generate the data directly from the pods call there ().\nI would be interested to work on this issue if no one else is working on it currently\nGo for it!\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-05cbbb1130d078f0cdb84100ef880fca820725df0ad18718541203fea4a908fe", "text": "}, []string{\"runtime_handler\"}, ) <ins> // RunningPodCount is a gauge that tracks the number of Pods currently running RunningPodCount = metrics.NewGauge( &metrics.GaugeOpts{ Subsystem:      KubeletSubsystem, Name:           \"running_pod_count\", Help:           \"Number of pods currently running\", StabilityLevel: metrics.ALPHA, }, ) // RunningContainerCount is a gauge that tracks the number of containers currently running RunningContainerCount = metrics.NewGaugeVec( &metrics.GaugeOpts{ Subsystem:      KubeletSubsystem, Name:           \"running_container_count\", Help:           \"Number of containers currently running\", StabilityLevel: metrics.ALPHA, }, []string{\"container_state\"}, ) </ins> ) var registerMetrics sync.Once", "commid": "kubernetes_pr_81573"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3f173d1022a4408031efac17c8299f04d835794ab8a77d69bb7667b0107a08bf", "query": "Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /sig instrumentation /assign\nGitHub didn't allow me to assign the following users: solodov. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nrecommends that we generate those metrics in the GenericPLEG during the relist. We can generate the data directly from the pods call there ().\nI would be interested to work on this issue if no one else is working on it currently\nGo for it!\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-17ff7a75a9db9e4ca6bc70a7ec1d793ea1974b069ef8822fa0a7e286df6efebc", "text": "legacyregistry.MustRegister(CgroupManagerDuration) legacyregistry.MustRegister(PodWorkerStartDuration) legacyregistry.MustRegister(ContainersPerPodCount) <del> legacyregistry.RawMustRegister(newPodAndContainerCollector(containerCache)) </del> legacyregistry.MustRegister(PLEGRelistDuration) legacyregistry.MustRegister(PLEGDiscardEvents) legacyregistry.MustRegister(PLEGRelistInterval)", "commid": "kubernetes_pr_81573"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3f173d1022a4408031efac17c8299f04d835794ab8a77d69bb7667b0107a08bf", "query": "Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /sig instrumentation /assign\nGitHub didn't allow me to assign the following users: solodov. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nrecommends that we generate those metrics in the GenericPLEG during the relist. We can generate the data directly from the pods call there ().\nI would be interested to work on this issue if no one else is working on it currently\nGo for it!\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-34e02a5b7da66294cb151af0a44c835598af80991b68a79683dc0a8d48e622e2", "text": "legacyregistry.MustRegister(DeprecatedEvictionStatsAge) legacyregistry.MustRegister(DeprecatedDevicePluginRegistrationCount) legacyregistry.MustRegister(DeprecatedDevicePluginAllocationLatency) <ins> legacyregistry.MustRegister(RunningContainerCount) legacyregistry.MustRegister(RunningPodCount) </ins> if utilfeature.DefaultFeatureGate.Enabled(features.DynamicKubeletConfig) { legacyregistry.MustRegister(AssignedConfig) legacyregistry.MustRegister(ActiveConfig)", "commid": "kubernetes_pr_81573"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3f173d1022a4408031efac17c8299f04d835794ab8a77d69bb7667b0107a08bf", "query": "Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /sig instrumentation /assign\nGitHub didn't allow me to assign the following users: solodov. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nrecommends that we generate those metrics in the GenericPLEG during the relist. We can generate the data directly from the pods call there ().\nI would be interested to work on this issue if no one else is working on it currently\nGo for it!\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-1719f8b5484dfc629f70b6ffffdab030df7896d0598f7417cff1da05b6362a47", "text": "return time.Since(start).Seconds() } <del> func newPodAndContainerCollector(containerCache kubecontainer.RuntimeCache) *podAndContainerCollector { return &podAndContainerCollector{ containerCache: containerCache, } } // Custom collector for current pod and container counts. type podAndContainerCollector struct { // Cache for accessing information about running containers. containerCache kubecontainer.RuntimeCache } // TODO(vmarmol): Split by source? var ( runningPodCountDesc = prometheus.NewDesc( prometheus.BuildFQName(\"\", KubeletSubsystem, \"running_pod_count\"), \"Number of pods currently running\", nil, nil) runningContainerCountDesc = prometheus.NewDesc( prometheus.BuildFQName(\"\", KubeletSubsystem, \"running_container_count\"), \"Number of containers currently running\", nil, nil) ) // Describe implements Prometheus' Describe method from the Collector interface. It sends all // available descriptions to the provided channel and retunrs once the last description has been sent. func (pc *podAndContainerCollector) Describe(ch chan<- *prometheus.Desc) { ch <- runningPodCountDesc ch <- runningContainerCountDesc } // Collect implements Prometheus' Collect method from the Collector interface. It's called by the Prometheus // registry when collecting metrics. func (pc *podAndContainerCollector) Collect(ch chan<- prometheus.Metric) { runningPods, err := pc.containerCache.GetPods() if err != nil { klog.Warningf(\"Failed to get running container information while collecting metrics: %v\", err) return } runningContainers := 0 for _, p := range runningPods { runningContainers += len(p.Containers) } ch <- prometheus.MustNewConstMetric( runningPodCountDesc, prometheus.GaugeValue, float64(len(runningPods))) ch <- prometheus.MustNewConstMetric( runningContainerCountDesc, prometheus.GaugeValue, float64(runningContainers)) } </del> const configMapAPIPathFmt = \"/api/v1/namespaces/%s/configmaps/%s\" func configLabels(source *corev1.NodeConfigSource) (map[string]string, error) {", "commid": "kubernetes_pr_81573"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3f173d1022a4408031efac17c8299f04d835794ab8a77d69bb7667b0107a08bf", "query": "Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /sig instrumentation /assign\nGitHub didn't allow me to assign the following users: solodov. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nrecommends that we generate those metrics in the GenericPLEG during the relist. We can generate the data directly from the pods call there ().\nI would be interested to work on this issue if no one else is working on it currently\nGo for it!\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-9543782f9f12fa4559a6dede0c9ffea8636fbf6ca800c33763147df6802a3ef4", "text": "deps = [ \"//pkg/kubelet/container:go_default_library\", \"//pkg/kubelet/container/testing:go_default_library\", <ins> \"//pkg/kubelet/metrics:go_default_library\", </ins> \"//staging/src/k8s.io/apimachinery/pkg/types:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/util/clock:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/util/diff:go_default_library\", <ins> \"//vendor/github.com/prometheus/client_model/go:go_default_library\", </ins> \"//vendor/github.com/stretchr/testify/assert:go_default_library\", ], )", "commid": "kubernetes_pr_81573"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3f173d1022a4408031efac17c8299f04d835794ab8a77d69bb7667b0107a08bf", "query": "Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /sig instrumentation /assign\nGitHub didn't allow me to assign the following users: solodov. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nrecommends that we generate those metrics in the GenericPLEG during the relist. We can generate the data directly from the pods call there ().\nI would be interested to work on this issue if no one else is working on it currently\nGo for it!\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-b47795c0ab3f44c72016f8b2f55103796171d6d1da611c35c00d395c7a95701e", "text": "g.updateRelistTime(timestamp) pods := kubecontainer.Pods(podList) <ins> // update running pod and container count updateRunningPodAndContainerMetrics(pods) </ins> g.podRecords.setCurrent(pods) // Compare the old and the current pods, and generate events.", "commid": "kubernetes_pr_81573"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3f173d1022a4408031efac17c8299f04d835794ab8a77d69bb7667b0107a08bf", "query": "Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /sig instrumentation /assign\nGitHub didn't allow me to assign the following users: solodov. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nrecommends that we generate those metrics in the GenericPLEG during the relist. We can generate the data directly from the pods call there ().\nI would be interested to work on this issue if no one else is working on it currently\nGo for it!\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-21f921969f0d4dfc592aceadceba3bf91413c5fd9364d3b30e36bcce31afdbdf", "text": "return state } <ins> func updateRunningPodAndContainerMetrics(pods []*kubecontainer.Pod) { // Set the number of running pods in the parameter metrics.RunningPodCount.Set(float64(len(pods))) // intermediate map to store the count of each \"container_state\" containerStateCount := make(map[string]int) for _, pod := range pods { containers := pod.Containers for _, container := range containers { // update the corresponding \"container_state\" in map to set value for the gaugeVec metrics containerStateCount[string(container.State)]++ } } for key, value := range containerStateCount { metrics.RunningContainerCount.WithLabelValues(key).Set(float64(value)) } } </ins> func (pr podRecords) getOld(id types.UID) *kubecontainer.Pod { r, ok := pr[id] if !ok {", "commid": "kubernetes_pr_81573"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3f173d1022a4408031efac17c8299f04d835794ab8a77d69bb7667b0107a08bf", "query": "Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /sig instrumentation /assign\nGitHub didn't allow me to assign the following users: solodov. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nrecommends that we generate those metrics in the GenericPLEG during the relist. We can generate the data directly from the pods call there ().\nI would be interested to work on this issue if no one else is working on it currently\nGo for it!\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-f9092873f54c1ef07c56a1364024bc84dfd5c8f62ea70ed79349cf7eba056d37", "text": "\"testing\" \"time\" <ins> dto \"github.com/prometheus/client_model/go\" </ins> \"github.com/stretchr/testify/assert\" \"k8s.io/apimachinery/pkg/types\" \"k8s.io/apimachinery/pkg/util/clock\" \"k8s.io/apimachinery/pkg/util/diff\" kubecontainer \"k8s.io/kubernetes/pkg/kubelet/container\" containertest \"k8s.io/kubernetes/pkg/kubelet/container/testing\" <ins> \"k8s.io/kubernetes/pkg/kubelet/metrics\" </ins> ) const (", "commid": "kubernetes_pr_81573"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3f173d1022a4408031efac17c8299f04d835794ab8a77d69bb7667b0107a08bf", "query": "Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /sig instrumentation /assign\nGitHub didn't allow me to assign the following users: solodov. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Some kubelet metrics use non-standard prometheus collectors unnecessarily. Specifically, we have which can be simple gauges. Since we cannot migrate non-standard prometheus collectors using the internal metrics stability framework, we will need to convert these metrics into standard prometheus variants. /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nrecommends that we generate those metrics in the GenericPLEG during the relist. We can generate the data directly from the pods call there ().\nI would be interested to work on this issue if no one else is working on it currently\nGo for it!\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-f8a6e0531ecdb6da2735962cfb98eb0c57cec7b361bde59f22317f92bc86ec5a", "text": "assert.Exactly(t, []*PodLifecycleEvent{event}, actualEvents) } } <ins> func TestRunningPodAndContainerCount(t *testing.T) { fakeRuntime := &containertest.FakeRuntime{} runtimeCache, _ := kubecontainer.NewRuntimeCache(fakeRuntime) metrics.Register(runtimeCache) testPleg := newTestGenericPLEG() pleg, runtime := testPleg.pleg, testPleg.runtime runtime.AllPodList = []*containertest.FakePod{ {Pod: &kubecontainer.Pod{ ID: \"1234\", Containers: []*kubecontainer.Container{ createTestContainer(\"c1\", kubecontainer.ContainerStateRunning), createTestContainer(\"c2\", kubecontainer.ContainerStateUnknown), createTestContainer(\"c3\", kubecontainer.ContainerStateUnknown), }, }}, {Pod: &kubecontainer.Pod{ ID: \"4567\", Containers: []*kubecontainer.Container{ createTestContainer(\"c1\", kubecontainer.ContainerStateExited), }, }}, } pleg.relist() // assert for container count with label \"running\" actualMetricRunningContainerCount := &dto.Metric{} expectedMetricRunningContainerCount := float64(1) metrics.RunningContainerCount.WithLabelValues(string(kubecontainer.ContainerStateRunning)).Write(actualMetricRunningContainerCount) assert.Equal(t, expectedMetricRunningContainerCount, actualMetricRunningContainerCount.GetGauge().GetValue()) // assert for container count with label \"unknown\" actualMetricUnknownContainerCount := &dto.Metric{} expectedMetricUnknownContainerCount := float64(2) metrics.RunningContainerCount.WithLabelValues(string(kubecontainer.ContainerStateUnknown)).Write(actualMetricUnknownContainerCount) assert.Equal(t, expectedMetricUnknownContainerCount, actualMetricUnknownContainerCount.GetGauge().GetValue()) // assert for running pod count actualMetricRunningPodCount := &dto.Metric{} metrics.RunningPodCount.Write(actualMetricRunningPodCount) expectedMetricRunningPodCount := float64(2) assert.Equal(t, expectedMetricRunningPodCount, actualMetricRunningPodCount.GetGauge().GetValue()) } </ins>", "commid": "kubernetes_pr_81573"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f5b1c2afeb6c20ee6d20a93f01654fa0f4acb253484063e97ce2510ee236c81b", "query": "What happened: tried promoting a test with a tag in its full test description. The hierarchy of ginko-relevant AST's was . The tag was a in the top level . The full test description only came from , so the tag was missed. What you expected to happen: The conformance test list generator should have logged and ERROR and failed a test on the PR, calling out Disruptive as an invalid tag How to reproduce it (as minimally and precisely as possible): Check out locally and follow the directions in to generate the conformance list. The invalid test is in the list. Anything else we need to know?: Is there a function we can use to get the full test description from Ginkgo instead of rolling our own? If not, we should probably be maintaining a stack rather than just the last FYI who ran into this FYI who wrote the code to keep track of last\n/sig architecture /area conformance\n/milestone v1.16\n/priority important-soon\n/assign\nGitHub didn't allow me to assign the following users: devaips. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-5dafb51231dc9dbd08233e7f2eba6d8689b1e61e7e379035727f5e3dfd5e629b", "text": ") const regexDescribe = \"Describe|KubeDescribe|SIGDescribe\" <del> const regexContext = \"Context\" </del> <ins> const regexContext = \"^Context$\" </ins> type visitor struct { <del> FileSet      *token.FileSet lastDescribe describe cMap         ast.CommentMap </del> <ins> FileSet   *token.FileSet describes []describe cMap      ast.CommentMap </ins> //list of all the conformance tests in the path tests []conformanceData } //describe contains text associated with ginkgo describe container type describe struct { <ins> rparen      token.Pos </ins> text        string lastContext context }", "commid": "kubernetes_pr_79405"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f5b1c2afeb6c20ee6d20a93f01654fa0f4acb253484063e97ce2510ee236c81b", "query": "What happened: tried promoting a test with a tag in its full test description. The hierarchy of ginko-relevant AST's was . The tag was a in the top level . The full test description only came from , so the tag was missed. What you expected to happen: The conformance test list generator should have logged and ERROR and failed a test on the PR, calling out Disruptive as an invalid tag How to reproduce it (as minimally and precisely as possible): Check out locally and follow the directions in to generate the conformance list. The invalid test is in the list. Anything else we need to know?: Is there a function we can use to get the full test description from Ginkgo instead of rolling our own? If not, we should probably be maintaining a stack rather than just the last FYI who ran into this FYI who wrote the code to keep track of last\n/sig architecture /area conformance\n/milestone v1.16\n/priority important-soon\n/assign\nGitHub didn't allow me to assign the following users: devaips. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-fab0943675aa8278428d8a70eecfaf133a4ea9c8b51e3c3694181ce6b2204f70", "text": "return } <del> err := validateTestName(v.getDescription(at.Value)) </del> <ins> description := v.getDescription(at.Value) err := validateTestName(description) </ins> if err != nil { v.failf(at, err.Error()) return", "commid": "kubernetes_pr_79405"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f5b1c2afeb6c20ee6d20a93f01654fa0f4acb253484063e97ce2510ee236c81b", "query": "What happened: tried promoting a test with a tag in its full test description. The hierarchy of ginko-relevant AST's was . The tag was a in the top level . The full test description only came from , so the tag was missed. What you expected to happen: The conformance test list generator should have logged and ERROR and failed a test on the PR, calling out Disruptive as an invalid tag How to reproduce it (as minimally and precisely as possible): Check out locally and follow the directions in to generate the conformance list. The invalid test is in the list. Anything else we need to know?: Is there a function we can use to get the full test description from Ginkgo instead of rolling our own? If not, we should probably be maintaining a stack rather than just the last FYI who ran into this FYI who wrote the code to keep track of last\n/sig architecture /area conformance\n/milestone v1.16\n/priority important-soon\n/assign\nGitHub didn't allow me to assign the following users: devaips. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-a1d6c4fa2cc096d0825a3a755ed85f4646a31f019598316d0c7740dc3cf5e00b", "text": "} func (v *visitor) getDescription(value string) string { <del> if len(v.lastDescribe.lastContext.text) > 0 { return strings.Trim(v.lastDescribe.text, \"\"\") + \" \" + strings.Trim(v.lastDescribe.lastContext.text, \"\"\") + \" \" + strings.Trim(value, \"\"\") </del> <ins> tokens := []string{} for _, describe := range v.describes { tokens = append(tokens, describe.text) if len(describe.lastContext.text) > 0 { tokens = append(tokens, describe.lastContext.text) } } tokens = append(tokens, value) trimmed := []string{} for _, token := range tokens { trimmed = append(trimmed, strings.Trim(token, \"\"\")) </ins> } <del> return strings.Trim(v.lastDescribe.text, \"\"\") + \" \" + strings.Trim(value, \"\"\") </del> <ins> return strings.Join(trimmed, \" \") </ins> } var (", "commid": "kubernetes_pr_79405"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f5b1c2afeb6c20ee6d20a93f01654fa0f4acb253484063e97ce2510ee236c81b", "query": "What happened: tried promoting a test with a tag in its full test description. The hierarchy of ginko-relevant AST's was . The tag was a in the top level . The full test description only came from , so the tag was missed. What you expected to happen: The conformance test list generator should have logged and ERROR and failed a test on the PR, calling out Disruptive as an invalid tag How to reproduce it (as minimally and precisely as possible): Check out locally and follow the directions in to generate the conformance list. The invalid test is in the list. Anything else we need to know?: Is there a function we can use to get the full test description from Ginkgo instead of rolling our own? If not, we should probably be maintaining a stack rather than just the last FYI who ran into this FYI who wrote the code to keep track of last\n/sig architecture /area conformance\n/milestone v1.16\n/priority important-soon\n/assign\nGitHub didn't allow me to assign the following users: devaips. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-1b7c5cf55e72b22da9f0dfe6cb118423eb0e4a45f9139cbc8117b22bfd9efa9f", "text": "// It() with a manually embedded [Conformance] tag, which it will complain // about. func (v *visitor) Visit(node ast.Node) (w ast.Visitor) { <ins> lastDescribe := len(v.describes) - 1 </ins> switch t := node.(type) { case *ast.CallExpr: if name := v.matchFuncName(t, regexDescribe); name != \"\" && len(t.Args) >= 2 { <del> v.lastDescribe = describe{text: name} </del> <ins> v.describes = append(v.describes, describe{text: name, rparen: t.Rparen}) </ins> } else if name := v.matchFuncName(t, regexContext); name != \"\" && len(t.Args) >= 2 { <del> v.lastDescribe.lastContext = context{text: name} </del> <ins> if lastDescribe > -1 { v.describes[lastDescribe].lastContext = context{text: name} } </ins> } else if v.isConformanceCall(t) { totalConfTests++ v.emit(t.Args[0])", "commid": "kubernetes_pr_79405"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f5b1c2afeb6c20ee6d20a93f01654fa0f4acb253484063e97ce2510ee236c81b", "query": "What happened: tried promoting a test with a tag in its full test description. The hierarchy of ginko-relevant AST's was . The tag was a in the top level . The full test description only came from , so the tag was missed. What you expected to happen: The conformance test list generator should have logged and ERROR and failed a test on the PR, calling out Disruptive as an invalid tag How to reproduce it (as minimally and precisely as possible): Check out locally and follow the directions in to generate the conformance list. The invalid test is in the list. Anything else we need to know?: Is there a function we can use to get the full test description from Ginkgo instead of rolling our own? If not, we should probably be maintaining a stack rather than just the last FYI who ran into this FYI who wrote the code to keep track of last\n/sig architecture /area conformance\n/milestone v1.16\n/priority important-soon\n/assign\nGitHub didn't allow me to assign the following users: devaips. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-9db5b58bda35d43d953b371c718e8fe720cbb0f795ca04b80f10d1df15faee76", "text": "return nil } } <ins> // If we're past the position of the last describe's rparen, pop the describe off if lastDescribe > -1 && node != nil { if node.Pos() > v.describes[lastDescribe].rparen { v.describes = v.describes[:lastDescribe] } } </ins> return v }", "commid": "kubernetes_pr_79405"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f5b1c2afeb6c20ee6d20a93f01654fa0f4acb253484063e97ce2510ee236c81b", "query": "What happened: tried promoting a test with a tag in its full test description. The hierarchy of ginko-relevant AST's was . The tag was a in the top level . The full test description only came from , so the tag was missed. What you expected to happen: The conformance test list generator should have logged and ERROR and failed a test on the PR, calling out Disruptive as an invalid tag How to reproduce it (as minimally and precisely as possible): Check out locally and follow the directions in to generate the conformance list. The invalid test is in the list. Anything else we need to know?: Is there a function we can use to get the full test description from Ginkgo instead of rolling our own? If not, we should probably be maintaining a stack rather than just the last FYI who ran into this FYI who wrote the code to keep track of last\n/sig architecture /area conformance\n/milestone v1.16\n/priority important-soon\n/assign\nGitHub didn't allow me to assign the following users: devaips. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-4d6a8e4f16dd704e186269fbbedbfbf667796bc05cdd2f97c9c7eac4fcd342ab", "text": "Description: `By default the stdout and stderr from the process being executed in a pod MUST be sent to the pod's logs.` + \"nn\"}}, }, <ins> // SIGDescribe + KubeDescribe + It, Describe + KubeDescribe + It {\"e2e/foo.go\", ` var _ = framework.SIGDescribe(\"Feature\", func() { KubeDescribe(\"Described by\", func() { // Description: description1 framework.ConformanceIt(\"A ConformanceIt\", func() {}) }) Describe(\"Also described via\", func() { KubeDescribe(\"A nested\", func() { // Description: description2 framework.ConformanceIt(\"ConformanceIt\", func() {}) }) }) })`, []conformanceData{ {URL: \"https://github.com/kubernetes/kubernetes/tree/master/e2e/foo.go#L6\", TestName: \"Feature Described by A ConformanceIt\", Description: \"description1nn\"}, {URL: \"https://github.com/kubernetes/kubernetes/tree/master/e2e/foo.go#L11\", TestName: \"Feature Also described via A nested ConformanceIt\", Description: \"description2nn\"}, }}, </ins> // KubeDescribe + Context + It {\"e2e/foo.go\", ` var _ = framework.KubeDescribe(\"Feature\", func() {", "commid": "kubernetes_pr_79405"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f5b1c2afeb6c20ee6d20a93f01654fa0f4acb253484063e97ce2510ee236c81b", "query": "What happened: tried promoting a test with a tag in its full test description. The hierarchy of ginko-relevant AST's was . The tag was a in the top level . The full test description only came from , so the tag was missed. What you expected to happen: The conformance test list generator should have logged and ERROR and failed a test on the PR, calling out Disruptive as an invalid tag How to reproduce it (as minimally and precisely as possible): Check out locally and follow the directions in to generate the conformance list. The invalid test is in the list. Anything else we need to know?: Is there a function we can use to get the full test description from Ginkgo instead of rolling our own? If not, we should probably be maintaining a stack rather than just the last FYI who ran into this FYI who wrote the code to keep track of last\n/sig architecture /area conformance\n/milestone v1.16\n/priority important-soon\n/assign\nGitHub didn't allow me to assign the following users: devaips. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-73af88422fc561709f5702363187384a43a09f9a1def9281ff34984b6828f93f", "text": "*confDoc = true tests := scanfile(test.filename, code) if !reflect.DeepEqual(tests, test.output) { <del> t.Errorf(\"code:n%sngot  %vnwant %v\", </del> <ins> t.Errorf(\"code:n%sngot  %+vnwant %+v\", </ins> code, tests, test.output) } }", "commid": "kubernetes_pr_79405"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-551b6084bfaac05cef6a997a25e281e330936f51feb2c4bba89f5a0e79ea7f67", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: attach/WaitForAttach timeout value is too small in CSI driver, it's all 15s which is really too small: Compared to built-in driver timeout, it's really too small: is , total is What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): 1.13 - 1.15 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /sig storage /assign", "positive_passages": [{"docid": "doc-en-kubernetes-98724a3dd6567fbc9b6a7f091b3c3d71aeb828059179a74ba47c6fcb0149a1ef", "text": "// TODO (vladimirvivien) would be nice to name socket with a .sock extension // for consistency. csiAddrTemplate = \"/var/lib/kubelet/plugins/%v/csi.sock\" <del> csiTimeout      = 15 * time.Second </del> <ins> csiTimeout      = 2 * time.Minute </ins> volNameSep      = \"^\" volDataFileName = \"vol_data.json\" fsTypeBlockName = \"block\"", "commid": "kubernetes_pr_79529"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e2ad17169ceb1098c807ca3a4621d8a63ce2959afa0affc3c6c5e92b949508b1", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: cd $ $ make ../image- bin webhook ../image- line 145: GOARM: unbound variable Makefile:23: recipe for target 'bin' failed make: [bin] Error 1 What you expected to happen: The binary or image should be built successfully. How to reproduce it (as minimally and precisely as possible): see my desc above, type \"make\" will see the error message. Anything else we need to know?: Environment*: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): Ubuntu Kernel (e.g. ): all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nI'm pretty sure this is supposed to be built via from which does default this environment variable.\n, thanks for the information! I think the harness of the shell scripts could bring us a little more, GOARM should only been set when the ARCH is ARM Make a binary is possible where a Makefile is presented\nThat seems reasonable, but we should probably avoid computing this in many places, currently the GOARM=${GOARM:-7} is going to always be 7 when building in the currently supported way. We should change that if we're going to compute it elsewhere. cc-ing for test/images fun ...", "positive_passages": [{"docid": "doc-en-kubernetes-3deefce19ef18251f431424bc0cf2b2c141a3750a807b9294aabebb343930379", "text": "export DOCKER_CLI_EXPERIMENTAL := enabled # golang version should match the golang version from https://github.com/coreos/etcd/releases for the current ETCD_VERSION. GOLANG_VERSION?=1.10.4 <del> GOARM=7 </del> <ins> GOARM?=7 </ins> TEMP_DIR:=$(shell mktemp -d) ifeq ($(ARCH),amd64)", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e2ad17169ceb1098c807ca3a4621d8a63ce2959afa0affc3c6c5e92b949508b1", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: cd $ $ make ../image- bin webhook ../image- line 145: GOARM: unbound variable Makefile:23: recipe for target 'bin' failed make: [bin] Error 1 What you expected to happen: The binary or image should be built successfully. How to reproduce it (as minimally and precisely as possible): see my desc above, type \"make\" will see the error message. Anything else we need to know?: Environment*: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): Ubuntu Kernel (e.g. ): all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nI'm pretty sure this is supposed to be built via from which does default this environment variable.\n, thanks for the information! I think the harness of the shell scripts could bring us a little more, GOARM should only been set when the ARCH is ARM Make a binary is possible where a Makefile is presented\nThat seems reasonable, but we should probably avoid computing this in many places, currently the GOARM=${GOARM:-7} is going to always be 7 when building in the currently supported way. We should change that if we're going to compute it elsewhere. cc-ing for test/images fun ...", "positive_passages": [{"docid": "doc-en-kubernetes-5199e8051f4a8a10507238d8502b89fb3cb75ca158d43eef07f28d02ee63e4a3", "text": "# Download etcd in a golang container and cross-compile it statically # For each release create a tmp dir 'etcd_release_tmp_dir' and unpack the release tar there. <ins> arch_prefix=\"\" ifeq ($(ARCH),arm) arch_prefix=\"GOARM=$(GOARM)\" endif </ins> for version in $(BUNDLED_ETCD_VERSIONS); do  etcd_release_tmp_dir=$(shell mktemp -d);  docker run --interactive -v $${etcd_release_tmp_dir}:/etcdbin golang:$(GOLANG_VERSION) /bin/bash -c  \"git clone https://github.com/coreos/etcd /go/src/github.com/coreos/etcd  && cd /go/src/github.com/coreos/etcd  && git checkout v$${version}  <del> && GOARM=$(GOARM) GOARCH=$(ARCH) ./build  </del> <ins> && $(arch_prefix) GOARCH=$(ARCH) ./build  </ins> && cp -f bin/$(ARCH)/etcd* bin/etcd* /etcdbin; echo 'done'\";  cp $$etcd_release_tmp_dir/etcd $$etcd_release_tmp_dir/etcdctl $(TEMP_DIR)/;  cp $(TEMP_DIR)/etcd $(TEMP_DIR)/etcd-$$version; ", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e2ad17169ceb1098c807ca3a4621d8a63ce2959afa0affc3c6c5e92b949508b1", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: cd $ $ make ../image- bin webhook ../image- line 145: GOARM: unbound variable Makefile:23: recipe for target 'bin' failed make: [bin] Error 1 What you expected to happen: The binary or image should be built successfully. How to reproduce it (as minimally and precisely as possible): see my desc above, type \"make\" will see the error message. Anything else we need to know?: Environment*: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): Ubuntu Kernel (e.g. ): all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nI'm pretty sure this is supposed to be built via from which does default this environment variable.\n, thanks for the information! I think the harness of the shell scripts could bring us a little more, GOARM should only been set when the ARCH is ARM Make a binary is possible where a Makefile is presented\nThat seems reasonable, but we should probably avoid computing this in many places, currently the GOARM=${GOARM:-7} is going to always be 7 when building in the currently supported way. We should change that if we're going to compute it elsewhere. cc-ing for test/images fun ...", "positive_passages": [{"docid": "doc-en-kubernetes-afeb873ad604deb3d1433110822bf5a88e7d9b03a642a7bf74222d89273cfc53", "text": "include  ../../hack/make-rules/Makefile.manifest REGISTRY ?= gcr.io/kubernetes-e2e-test-images <del> GOARM=7 </del> <ins> GOARM ?= 7 </ins> QEMUVERSION=v2.9.1 GOLANG_VERSION=1.12.6 export", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e2ad17169ceb1098c807ca3a4621d8a63ce2959afa0affc3c6c5e92b949508b1", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: cd $ $ make ../image- bin webhook ../image- line 145: GOARM: unbound variable Makefile:23: recipe for target 'bin' failed make: [bin] Error 1 What you expected to happen: The binary or image should be built successfully. How to reproduce it (as minimally and precisely as possible): see my desc above, type \"make\" will see the error message. Anything else we need to know?: Environment*: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): Ubuntu Kernel (e.g. ): all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nI'm pretty sure this is supposed to be built via from which does default this environment variable.\n, thanks for the information! I think the harness of the shell scripts could bring us a little more, GOARM should only been set when the ARCH is ARM Make a binary is possible where a Makefile is presented\nThat seems reasonable, but we should probably avoid computing this in many places, currently the GOARM=${GOARM:-7} is going to always be 7 when building in the currently supported way. We should change that if we're going to compute it elsewhere. cc-ing for test/images fun ...", "positive_passages": [{"docid": "doc-en-kubernetes-7b88e26f2bfc203b949f7c5346ae3746b2f67b1ab60783015d80cad07a8bf13a", "text": "if [[ $(id -u) != 0 ]]; then sudo=sudo fi <del> \"${sudo}\" \"${KUBE_ROOT}/third_party/multiarch/qemu-user-static/register/register.sh\" --reset </del> <ins> ${sudo} \"${KUBE_ROOT}/third_party/multiarch/qemu-user-static/register/register.sh\" --reset </ins> curl -sSL https://github.com/multiarch/qemu-user-static/releases/download/\"${QEMUVERSION}\"/x86_64_qemu-\"${QEMUARCHS[$arch]}\"-static.tar.gz | tar -xz -C \"${temp_dir}\" # Ensure we don't get surprised by umask settings chmod 0755 \"${temp_dir}/qemu-${QEMUARCHS[$arch]}-static\"", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e2ad17169ceb1098c807ca3a4621d8a63ce2959afa0affc3c6c5e92b949508b1", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: cd $ $ make ../image- bin webhook ../image- line 145: GOARM: unbound variable Makefile:23: recipe for target 'bin' failed make: [bin] Error 1 What you expected to happen: The binary or image should be built successfully. How to reproduce it (as minimally and precisely as possible): see my desc above, type \"make\" will see the error message. Anything else we need to know?: Environment*: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): Ubuntu Kernel (e.g. ): all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nI'm pretty sure this is supposed to be built via from which does default this environment variable.\n, thanks for the information! I think the harness of the shell scripts could bring us a little more, GOARM should only been set when the ARCH is ARM Make a binary is possible where a Makefile is presented\nThat seems reasonable, but we should probably avoid computing this in many places, currently the GOARM=${GOARM:-7} is going to always be 7 when building in the currently supported way. We should change that if we're going to compute it elsewhere. cc-ing for test/images fun ...", "positive_passages": [{"docid": "doc-en-kubernetes-7d5c958d2524a624d4bcceb9b75231c79efe99baa0737098c8882844da9ba670", "text": "# This function is for building the go code bin() { <ins> local arch_prefix=\"\" if [[ \"${ARCH}\" == \"arm\" ]]; then arch_prefix=\"GOARM=${GOARM:-7}\" fi </ins> for SRC in $@; do docker run --rm -it -v \"${TARGET}:${TARGET}:Z\" -v \"${KUBE_ROOT}\":/go/src/k8s.io/kubernetes:Z  golang:\"${GOLANG_VERSION}\"  /bin/bash -c \" cd /go/src/k8s.io/kubernetes/test/images/${SRC_DIR} &&  <del> CGO_ENABLED=0 GOARM=${GOARM} GOARCH=${ARCH} go build -a -installsuffix cgo --ldflags '-w' -o ${TARGET}/${SRC} ./$(dirname \"${SRC}\")\" </del> <ins> CGO_ENABLED=0 ${arch_prefix} GOARCH=${ARCH} go build -a -installsuffix cgo --ldflags '-w' -o ${TARGET}/${SRC} ./$(dirname \"${SRC}\")\" </ins> done }", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e2ad17169ceb1098c807ca3a4621d8a63ce2959afa0affc3c6c5e92b949508b1", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: cd $ $ make ../image- bin webhook ../image- line 145: GOARM: unbound variable Makefile:23: recipe for target 'bin' failed make: [bin] Error 1 What you expected to happen: The binary or image should be built successfully. How to reproduce it (as minimally and precisely as possible): see my desc above, type \"make\" will see the error message. Anything else we need to know?: Environment*: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): Ubuntu Kernel (e.g. ): all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nI'm pretty sure this is supposed to be built via from which does default this environment variable.\n, thanks for the information! I think the harness of the shell scripts could bring us a little more, GOARM should only been set when the ARCH is ARM Make a binary is possible where a Makefile is presented\nThat seems reasonable, but we should probably avoid computing this in many places, currently the GOARM=${GOARM:-7} is going to always be 7 when building in the currently supported way. We should change that if we're going to compute it elsewhere. cc-ing for test/images fun ...", "positive_passages": [{"docid": "doc-en-kubernetes-fc48e5f8a1a62067e66c99601a3167b06928d218c7eda19efabc6f9eaa85f28f", "text": "SRCS=regression-issue-74839 ARCH ?= amd64 TARGET ?= $(CURDIR) <del> GOARM = 7 </del> <ins> GOARM ?= 7 </ins> GOLANG_VERSION ?= latest SRC_DIR = $(notdir $(shell pwd))", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a9bb0fa341de4f203eba4b1a2198b6b5b48cdf4b2b045035cfa84b6b4f2a114", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: login system root, and run below command from \"test/images\" dir, Will fail with below error message, ./image- line 91: : command not found This is cause by the empty string like \"\" cannot be understood as a shell command. What you expected to happen: image should be built successfully. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): all Kernel (e.g. ):all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-3deefce19ef18251f431424bc0cf2b2c141a3750a807b9294aabebb343930379", "text": "export DOCKER_CLI_EXPERIMENTAL := enabled # golang version should match the golang version from https://github.com/coreos/etcd/releases for the current ETCD_VERSION. GOLANG_VERSION?=1.10.4 <del> GOARM=7 </del> <ins> GOARM?=7 </ins> TEMP_DIR:=$(shell mktemp -d) ifeq ($(ARCH),amd64)", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a9bb0fa341de4f203eba4b1a2198b6b5b48cdf4b2b045035cfa84b6b4f2a114", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: login system root, and run below command from \"test/images\" dir, Will fail with below error message, ./image- line 91: : command not found This is cause by the empty string like \"\" cannot be understood as a shell command. What you expected to happen: image should be built successfully. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): all Kernel (e.g. ):all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-5199e8051f4a8a10507238d8502b89fb3cb75ca158d43eef07f28d02ee63e4a3", "text": "# Download etcd in a golang container and cross-compile it statically # For each release create a tmp dir 'etcd_release_tmp_dir' and unpack the release tar there. <ins> arch_prefix=\"\" ifeq ($(ARCH),arm) arch_prefix=\"GOARM=$(GOARM)\" endif </ins> for version in $(BUNDLED_ETCD_VERSIONS); do  etcd_release_tmp_dir=$(shell mktemp -d);  docker run --interactive -v $${etcd_release_tmp_dir}:/etcdbin golang:$(GOLANG_VERSION) /bin/bash -c  \"git clone https://github.com/coreos/etcd /go/src/github.com/coreos/etcd  && cd /go/src/github.com/coreos/etcd  && git checkout v$${version}  <del> && GOARM=$(GOARM) GOARCH=$(ARCH) ./build  </del> <ins> && $(arch_prefix) GOARCH=$(ARCH) ./build  </ins> && cp -f bin/$(ARCH)/etcd* bin/etcd* /etcdbin; echo 'done'\";  cp $$etcd_release_tmp_dir/etcd $$etcd_release_tmp_dir/etcdctl $(TEMP_DIR)/;  cp $(TEMP_DIR)/etcd $(TEMP_DIR)/etcd-$$version; ", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a9bb0fa341de4f203eba4b1a2198b6b5b48cdf4b2b045035cfa84b6b4f2a114", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: login system root, and run below command from \"test/images\" dir, Will fail with below error message, ./image- line 91: : command not found This is cause by the empty string like \"\" cannot be understood as a shell command. What you expected to happen: image should be built successfully. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): all Kernel (e.g. ):all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-afeb873ad604deb3d1433110822bf5a88e7d9b03a642a7bf74222d89273cfc53", "text": "include  ../../hack/make-rules/Makefile.manifest REGISTRY ?= gcr.io/kubernetes-e2e-test-images <del> GOARM=7 </del> <ins> GOARM ?= 7 </ins> QEMUVERSION=v2.9.1 GOLANG_VERSION=1.12.6 export", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a9bb0fa341de4f203eba4b1a2198b6b5b48cdf4b2b045035cfa84b6b4f2a114", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: login system root, and run below command from \"test/images\" dir, Will fail with below error message, ./image- line 91: : command not found This is cause by the empty string like \"\" cannot be understood as a shell command. What you expected to happen: image should be built successfully. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): all Kernel (e.g. ):all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-7b88e26f2bfc203b949f7c5346ae3746b2f67b1ab60783015d80cad07a8bf13a", "text": "if [[ $(id -u) != 0 ]]; then sudo=sudo fi <del> \"${sudo}\" \"${KUBE_ROOT}/third_party/multiarch/qemu-user-static/register/register.sh\" --reset </del> <ins> ${sudo} \"${KUBE_ROOT}/third_party/multiarch/qemu-user-static/register/register.sh\" --reset </ins> curl -sSL https://github.com/multiarch/qemu-user-static/releases/download/\"${QEMUVERSION}\"/x86_64_qemu-\"${QEMUARCHS[$arch]}\"-static.tar.gz | tar -xz -C \"${temp_dir}\" # Ensure we don't get surprised by umask settings chmod 0755 \"${temp_dir}/qemu-${QEMUARCHS[$arch]}-static\"", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a9bb0fa341de4f203eba4b1a2198b6b5b48cdf4b2b045035cfa84b6b4f2a114", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: login system root, and run below command from \"test/images\" dir, Will fail with below error message, ./image- line 91: : command not found This is cause by the empty string like \"\" cannot be understood as a shell command. What you expected to happen: image should be built successfully. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): all Kernel (e.g. ):all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-7d5c958d2524a624d4bcceb9b75231c79efe99baa0737098c8882844da9ba670", "text": "# This function is for building the go code bin() { <ins> local arch_prefix=\"\" if [[ \"${ARCH}\" == \"arm\" ]]; then arch_prefix=\"GOARM=${GOARM:-7}\" fi </ins> for SRC in $@; do docker run --rm -it -v \"${TARGET}:${TARGET}:Z\" -v \"${KUBE_ROOT}\":/go/src/k8s.io/kubernetes:Z  golang:\"${GOLANG_VERSION}\"  /bin/bash -c \" cd /go/src/k8s.io/kubernetes/test/images/${SRC_DIR} &&  <del> CGO_ENABLED=0 GOARM=${GOARM} GOARCH=${ARCH} go build -a -installsuffix cgo --ldflags '-w' -o ${TARGET}/${SRC} ./$(dirname \"${SRC}\")\" </del> <ins> CGO_ENABLED=0 ${arch_prefix} GOARCH=${ARCH} go build -a -installsuffix cgo --ldflags '-w' -o ${TARGET}/${SRC} ./$(dirname \"${SRC}\")\" </ins> done }", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a9bb0fa341de4f203eba4b1a2198b6b5b48cdf4b2b045035cfa84b6b4f2a114", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: login system root, and run below command from \"test/images\" dir, Will fail with below error message, ./image- line 91: : command not found This is cause by the empty string like \"\" cannot be understood as a shell command. What you expected to happen: image should be built successfully. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): latest Cloud provider or hardware configuration: OS (e.g: ): all Kernel (e.g. ):all Install tools: Network plugin and version (if this is a network-related bug): Others:\nThere are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-fc48e5f8a1a62067e66c99601a3167b06928d218c7eda19efabc6f9eaa85f28f", "text": "SRCS=regression-issue-74839 ARCH ?= amd64 TARGET ?= $(CURDIR) <del> GOARM = 7 </del> <ins> GOARM ?= 7 </ins> GOLANG_VERSION ?= latest SRC_DIR = $(notdir $(shell pwd))", "commid": "kubernetes_pr_79692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c2fa5d68b30b20426b3cc550ef8c760b15b7eae41d09aebcd2cc187fe5717fd", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: pull-kubernetes-bazel-test Which test(s) are failing: Test_buildClientCertificateManager Testgrid link: Reason for failure: Anything else we need to know:\n/remove-kind failing-test /kind flake /sig scheduling\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-5ef2b01372a2f75b1530dcf928370fc3f705c29b1e9c11b68d7eed4d253ef79f", "text": "// get an expired CSR (simulating historical output) server.backdate = 2 * time.Hour <del> server.expectUserAgent = \"FirstClient\" </del> <ins> server.SetExpectUserAgent(\"FirstClient\") </ins> ok, err := r.RotateCerts() if !ok || err != nil { t.Fatalf(\"unexpected rotation err: %t %v\", ok, err)", "commid": "kubernetes_pr_80236"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c2fa5d68b30b20426b3cc550ef8c760b15b7eae41d09aebcd2cc187fe5717fd", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: pull-kubernetes-bazel-test Which test(s) are failing: Test_buildClientCertificateManager Testgrid link: Reason for failure: Anything else we need to know:\n/remove-kind failing-test /kind flake /sig scheduling\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-a86f9f82169b15d142963d9cbbe6ce4daacdd81c26b9518ed7b22ead5b1772e3", "text": "// if m.Current() == nil, then we try again and get a valid // client server.backdate = 0 <del> server.expectUserAgent = \"FirstClient\" </del> <ins> server.SetExpectUserAgent(\"FirstClient\") </ins> if ok, err := r.RotateCerts(); !ok || err != nil { t.Fatalf(\"unexpected rotation err: %t %v\", ok, err) }", "commid": "kubernetes_pr_80236"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c2fa5d68b30b20426b3cc550ef8c760b15b7eae41d09aebcd2cc187fe5717fd", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: pull-kubernetes-bazel-test Which test(s) are failing: Test_buildClientCertificateManager Testgrid link: Reason for failure: Anything else we need to know:\n/remove-kind failing-test /kind flake /sig scheduling\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-defaaf467cd86634adb5e63054402ed4ca6984ff4b3dd65672fdc46555014446", "text": "} // if m.Current() != nil, then we should use the second client <del> server.expectUserAgent = \"SecondClient\" </del> <ins> server.SetExpectUserAgent(\"SecondClient\") </ins> if ok, err := r.RotateCerts(); !ok || err != nil { t.Fatalf(\"unexpected rotation err: %t %v\", ok, err) }", "commid": "kubernetes_pr_80236"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c2fa5d68b30b20426b3cc550ef8c760b15b7eae41d09aebcd2cc187fe5717fd", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: pull-kubernetes-bazel-test Which test(s) are failing: Test_buildClientCertificateManager Testgrid link: Reason for failure: Anything else we need to know:\n/remove-kind failing-test /kind flake /sig scheduling\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-34068def6f22dabd8bab672186b322e3c545bda9bd0ccb9cb1ed2ca3bfbb9287", "text": "serverCA         *x509.Certificate backdate         time.Duration <ins> userAgentLock   sync.Mutex </ins> expectUserAgent string lock sync.Mutex csr  *certapi.CertificateSigningRequest } <ins> func (s *csrSimulator) SetExpectUserAgent(a string) { s.userAgentLock.Lock() defer s.userAgentLock.Unlock() s.expectUserAgent = a } func (s *csrSimulator) ExpectUserAgent() string { s.userAgentLock.Lock() defer s.userAgentLock.Unlock() return s.expectUserAgent } </ins> func (s *csrSimulator) ServeHTTP(w http.ResponseWriter, req *http.Request) { s.lock.Lock() defer s.lock.Unlock()", "commid": "kubernetes_pr_80236"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5c2fa5d68b30b20426b3cc550ef8c760b15b7eae41d09aebcd2cc187fe5717fd", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: pull-kubernetes-bazel-test Which test(s) are failing: Test_buildClientCertificateManager Testgrid link: Reason for failure: Anything else we need to know:\n/remove-kind failing-test /kind flake /sig scheduling\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-30f64af020860e042ceac227845873f39f0320232eabe65ad983ae62a460f02a", "text": "q := req.URL.Query() q.Del(\"timeout\") q.Del(\"timeoutSeconds\") <ins> q.Del(\"allowWatchBookmarks\") </ins> req.URL.RawQuery = q.Encode() t.Logf(\"Request %q %q %q\", req.Method, req.URL, req.UserAgent()) <del> if len(s.expectUserAgent) > 0 && req.UserAgent() != s.expectUserAgent { </del> <ins> if a := s.ExpectUserAgent(); len(a) > 0 && req.UserAgent() != a { </ins> t.Errorf(\"Unexpected user agent: %s\", req.UserAgent()) }", "commid": "kubernetes_pr_80236"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6bd1d79418aa070c75893275b9a56665000ecdc164e6d23c45498a1bfe6deca4", "query": "What happened: The new TestScorePlugin for the scheduler framework is flaky How to reproduce it (as minimally and precisely as possible): An example: Anything else we need to know?: The test evaluates that a pod should be scheduled on specific node with a higher score. I think the test sometimes fails because the higher score node that the test creates didn't propagate yet to the scheduler (i.e., the node exists in etcd, but scheduler hasn't been notified that it exists yet, and so it is not evaluated at all). /kind bug /sig scheduling /assign\n/kind flake", "positive_passages": [{"docid": "doc-en-kubernetes-a6183e92efe4e8867ac74ee1c9c13ba5ec072f29be9361c40892375548aaa126", "text": "if sp.failScore { return 0, framework.NewStatus(framework.Error, fmt.Sprintf(\"injecting failure for pod %v\", p.Name)) } score := 10 <del> if nodeName == sp.highScoreNode { </del> <ins> if sp.numCalled == 1 { // The first node is scored the highest, the rest is scored lower. sp.highScoreNode = nodeName </ins> score = 100 } return score, nil", "commid": "kubernetes_pr_80256"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6bd1d79418aa070c75893275b9a56665000ecdc164e6d23c45498a1bfe6deca4", "query": "What happened: The new TestScorePlugin for the scheduler framework is flaky How to reproduce it (as minimally and precisely as possible): An example: Anything else we need to know?: The test evaluates that a pod should be scheduled on specific node with a higher score. I think the test sometimes fails because the higher score node that the test creates didn't propagate yet to the scheduler (i.e., the node exists in etcd, but scheduler hasn't been notified that it exists yet, and so it is not evaluated at all). /kind bug /sig scheduling /assign\n/kind flake", "positive_passages": [{"docid": "doc-en-kubernetes-5061ef39869e7c4b7c8b25a2e4816212f77bc35dd6f603efab4f0d382e4695f0", "text": "cs := context.clientSet // Add multiple nodes, one of them will be scored much higher than the others. <del> nodes, err := createNodes(cs, \"test-node\", nil, 10) </del> <ins> _, err := createNodes(cs, \"test-node\", nil, 10) </ins> if err != nil { t.Fatalf(\"Cannot create nodes: %v\", err) } <del> scPlugin.highScoreNode = nodes[3].Name </del> for i, fail := range []bool{false, true} { scPlugin.failScore = fail", "commid": "kubernetes_pr_80256"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f2cf3fb164978f0a8c62bbea5f6f0d6f6c61435524bb489ae50eec1a242fdf48", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Error msg override when saveVolumeData fails. What you expected to happen: return the right error. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig storage\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-2277bb6b3d2e068cd7ca7d81c0459848f9fbd782d438e4b62fca4a558e9658c9", "text": "if err := saveVolumeData(dataDir, volDataFileName, volData); err != nil { klog.Error(log(\"failed to save volume info data: %v\", err)) <del> if err := os.RemoveAll(dataDir); err != nil { klog.Error(log(\"failed to remove dir after error [%s]: %v\", dataDir, err)) return nil, err </del> <ins> if removeErr := os.RemoveAll(dataDir); removeErr != nil { klog.Error(log(\"failed to remove dir after error [%s]: %v\", dataDir, removeErr)) </ins> } return nil, err }", "commid": "kubernetes_pr_80451"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b5b68ca719178ee7e086c976c8ddfc4c67500e8ea5e1389b8d55d179ba472c77", "query": "What happened: When using a yaml file for input, silently fails at the first missing resource, not returning any further results. What you expected to happen: Searching with cli arguments properly ignores missing resources and continues the query, eg: Would expect similar results with a file input, eg: How to reproduce it (as minimally and precisely as possible): With an input file of : the command fails at apparently the first missing resource: Note: that rearranging the inputs in (so that the missing resource is last) produces the \"expected\" output: Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: local OS (e.g: ): fedora 30 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: x-ref:\n/sig cli\n/assign\nGot around to reproducing it and can confirm that I'm getting the same behavior. I'm looking into fixing it now\nthanks, any updates on this?\nI've learned that in the case of a fake entry, kubectl stops sending API get requests altogether. Learned by running kubectl get -f --ignore-not-found --v=10, the result is shown below. Till now I've been looking into the cobra command framework but now I'm trying to find out where kubectl is making these API calls from(working on finding out where this connection is happening from Slack+debugging, I've asked a more detailed question here ). <img width=\"1440\" alt=\"Screen Shot 2019-08-12 at 4 13 41 PM\" src=\"https://user-\"\nthat's an interesting find, definitely helpful. When I looked into this I got to the section of get's main run function, and it seems like it should be continuing on any errors (see ) but maybe the ResourceBuilder is actually stopping when it hits a 404?\nThis behavior comes from where the not found errors are being ignored and where the input list is flattened. Errors are ignored here: While flattening occurs here: As the visitor iterates through the objects in the list if an error occurs, such as not found, it will stop iterating over the objects in the list and return that not found error. The logic will then ignore it and continue. Any objects that came before the not found object in the list will have been visited and will then be included in the output. To make the behavior consistent between the two ways of getting the set of objects, the would need to be updated to support filtering errors.\nJust submitted a PR adding that functionality to the FlattenListVisitor. The behavior is now consistent between the two methods.", "positive_passages": [{"docid": "doc-en-kubernetes-eaa826d28808d3a1dd132bb1b3e5e9e24b7ae07fc799f6caf1b97a5420d32784", "text": "// FlattenListVisitor flattens any objects that runtime.ExtractList recognizes as a list // - has an \"Items\" public field that is a slice of runtime.Objects or objects satisfying <del> // that interface - into multiple Infos. An error on any sub item (for instance, if a List // contains an object that does not have a registered client or resource) will terminate // the visit. // TODO: allow errors to be aggregated? </del> <ins> // that interface - into multiple Infos. Returns nil in the case of no errors. // When an error is hit on sub items (for instance, if a List contains an object that does // not have a registered client or resource), returns an aggregate error. </ins> type FlattenListVisitor struct { visitor Visitor typer   runtime.ObjectTyper", "commid": "kubernetes_pr_82120"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b5b68ca719178ee7e086c976c8ddfc4c67500e8ea5e1389b8d55d179ba472c77", "query": "What happened: When using a yaml file for input, silently fails at the first missing resource, not returning any further results. What you expected to happen: Searching with cli arguments properly ignores missing resources and continues the query, eg: Would expect similar results with a file input, eg: How to reproduce it (as minimally and precisely as possible): With an input file of : the command fails at apparently the first missing resource: Note: that rearranging the inputs in (so that the missing resource is last) produces the \"expected\" output: Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: local OS (e.g: ): fedora 30 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: x-ref:\n/sig cli\n/assign\nGot around to reproducing it and can confirm that I'm getting the same behavior. I'm looking into fixing it now\nthanks, any updates on this?\nI've learned that in the case of a fake entry, kubectl stops sending API get requests altogether. Learned by running kubectl get -f --ignore-not-found --v=10, the result is shown below. Till now I've been looking into the cobra command framework but now I'm trying to find out where kubectl is making these API calls from(working on finding out where this connection is happening from Slack+debugging, I've asked a more detailed question here ). <img width=\"1440\" alt=\"Screen Shot 2019-08-12 at 4 13 41 PM\" src=\"https://user-\"\nthat's an interesting find, definitely helpful. When I looked into this I got to the section of get's main run function, and it seems like it should be continuing on any errors (see ) but maybe the ResourceBuilder is actually stopping when it hits a 404?\nThis behavior comes from where the not found errors are being ignored and where the input list is flattened. Errors are ignored here: While flattening occurs here: As the visitor iterates through the objects in the list if an error occurs, such as not found, it will stop iterating over the objects in the list and return that not found error. The logic will then ignore it and continue. Any objects that came before the not found object in the list will have been visited and will then be included in the output. To make the behavior consistent between the two ways of getting the set of objects, the would need to be updated to support filtering errors.\nJust submitted a PR adding that functionality to the FlattenListVisitor. The behavior is now consistent between the two methods.", "positive_passages": [{"docid": "doc-en-kubernetes-4e054c9fcf038c2771f36245f66f256e14ac770ee2a8efde46c7b74b118f1acb", "text": "if info.Mapping != nil && !info.Mapping.GroupVersionKind.Empty() { preferredGVKs = append(preferredGVKs, info.Mapping.GroupVersionKind) } <ins> errs := []error{} </ins> for i := range items { item, err := v.mapper.infoForObject(items[i], v.typer, preferredGVKs) if err != nil { <del> return err </del> <ins> errs = append(errs, err) continue </ins> } if len(info.ResourceVersion) != 0 { item.ResourceVersion = info.ResourceVersion } if err := fn(item, nil); err != nil { <del> return err </del> <ins> errs = append(errs, err) </ins> } } <del> return nil </del> <ins> return utilerrors.NewAggregate(errs) </ins> }) }", "commid": "kubernetes_pr_82120"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b5b68ca719178ee7e086c976c8ddfc4c67500e8ea5e1389b8d55d179ba472c77", "query": "What happened: When using a yaml file for input, silently fails at the first missing resource, not returning any further results. What you expected to happen: Searching with cli arguments properly ignores missing resources and continues the query, eg: Would expect similar results with a file input, eg: How to reproduce it (as minimally and precisely as possible): With an input file of : the command fails at apparently the first missing resource: Note: that rearranging the inputs in (so that the missing resource is last) produces the \"expected\" output: Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: local OS (e.g: ): fedora 30 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: x-ref:\n/sig cli\n/assign\nGot around to reproducing it and can confirm that I'm getting the same behavior. I'm looking into fixing it now\nthanks, any updates on this?\nI've learned that in the case of a fake entry, kubectl stops sending API get requests altogether. Learned by running kubectl get -f --ignore-not-found --v=10, the result is shown below. Till now I've been looking into the cobra command framework but now I'm trying to find out where kubectl is making these API calls from(working on finding out where this connection is happening from Slack+debugging, I've asked a more detailed question here ). <img width=\"1440\" alt=\"Screen Shot 2019-08-12 at 4 13 41 PM\" src=\"https://user-\"\nthat's an interesting find, definitely helpful. When I looked into this I got to the section of get's main run function, and it seems like it should be continuing on any errors (see ) but maybe the ResourceBuilder is actually stopping when it hits a 404?\nThis behavior comes from where the not found errors are being ignored and where the input list is flattened. Errors are ignored here: While flattening occurs here: As the visitor iterates through the objects in the list if an error occurs, such as not found, it will stop iterating over the objects in the list and return that not found error. The logic will then ignore it and continue. Any objects that came before the not found object in the list will have been visited and will then be included in the output. To make the behavior consistent between the two ways of getting the set of objects, the would need to be updated to support filtering errors.\nJust submitted a PR adding that functionality to the FlattenListVisitor. The behavior is now consistent between the two methods.", "positive_passages": [{"docid": "doc-en-kubernetes-8edad56653fceaf1e013a4656519a883ca149bdd3de1ba9660eb9fb8e388b7de", "text": "import ( \"bytes\" <ins> \"errors\" </ins> \"fmt\" \"io\" \"io/ioutil\" <ins> \"strings\" </ins> \"testing\" \"time\"", "commid": "kubernetes_pr_82120"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b5b68ca719178ee7e086c976c8ddfc4c67500e8ea5e1389b8d55d179ba472c77", "query": "What happened: When using a yaml file for input, silently fails at the first missing resource, not returning any further results. What you expected to happen: Searching with cli arguments properly ignores missing resources and continues the query, eg: Would expect similar results with a file input, eg: How to reproduce it (as minimally and precisely as possible): With an input file of : the command fails at apparently the first missing resource: Note: that rearranging the inputs in (so that the missing resource is last) produces the \"expected\" output: Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: local OS (e.g: ): fedora 30 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: x-ref:\n/sig cli\n/assign\nGot around to reproducing it and can confirm that I'm getting the same behavior. I'm looking into fixing it now\nthanks, any updates on this?\nI've learned that in the case of a fake entry, kubectl stops sending API get requests altogether. Learned by running kubectl get -f --ignore-not-found --v=10, the result is shown below. Till now I've been looking into the cobra command framework but now I'm trying to find out where kubectl is making these API calls from(working on finding out where this connection is happening from Slack+debugging, I've asked a more detailed question here ). <img width=\"1440\" alt=\"Screen Shot 2019-08-12 at 4 13 41 PM\" src=\"https://user-\"\nthat's an interesting find, definitely helpful. When I looked into this I got to the section of get's main run function, and it seems like it should be continuing on any errors (see ) but maybe the ResourceBuilder is actually stopping when it hits a 404?\nThis behavior comes from where the not found errors are being ignored and where the input list is flattened. Errors are ignored here: While flattening occurs here: As the visitor iterates through the objects in the list if an error occurs, such as not found, it will stop iterating over the objects in the list and return that not found error. The logic will then ignore it and continue. Any objects that came before the not found object in the list will have been visited and will then be included in the output. To make the behavior consistent between the two ways of getting the set of objects, the would need to be updated to support filtering errors.\nJust submitted a PR adding that functionality to the FlattenListVisitor. The behavior is now consistent between the two methods.", "positive_passages": [{"docid": "doc-en-kubernetes-17d915fe4cc20cfba59f24b78016185f6e6c448928a63ed9757172fa828ad589", "text": "t.Fatal(spew.Sdump(test.Infos)) } } <ins> func TestFlattenListVisitorWithVisitorError(t *testing.T) { b := newDefaultBuilder(). FilenameParam(false, &FilenameOptions{Recursive: false, Filenames: []string{\"../../artifacts/deeply-nested.yaml\"}}). Flatten() test := &testVisitor{InjectErr: errors.New(\"visitor error\")} err := b.Do().Visit(test.Handle) if err == nil || !strings.Contains(err.Error(), \"visitor error\") { t.Fatal(err) } if len(test.Infos) != 6 { t.Fatal(spew.Sdump(test.Infos)) } } </ins>", "commid": "kubernetes_pr_82120"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-293cdea3c6ec5a83fbc9e02a1638fe58db21159d7cc077448d29d2c4fb193ff6", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: CRI-O e2e Which test(s) are failing: e2e suite [sig-network] Services should be able to change the type from ExternalName to NodePort e2e suite [sig-network] Services should be able to create a functioning NodePort service 19s See link: https://openshift-gce- Since when has it been failing: Anything else we need to know:\n/sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/milestone v1.16 /assign FYI Looks like two other release-blocking tests too: - The changes link testgrid gives () suggests two other PR's, but I agree that seems the likely culprit\nBased on the , Service is reachable on and but failing to reach on node's IP over nodePort i.e. . From the log, it is not clear why its not reachable on node's internal IP. Could you provide from the CRI-O based node when trying to reach nodePort service. Secondly, need to make sure, node is listening on allocated nodePort. As this issue seems much on system-level, I need to setup k8s cluster/node with CRI-O runtime and troubleshoot to find the root cause.\n[sig-network] ESIPP [Slow] [DisabledForLargeClusters] should work from pods [sig-network] Services should only allow access from service loadbalancer source ranges [Slow] seems flaky to me. Most of time execPod starts running and might be terminating immediately after some time which causes this issue. [1.] e2e is failing as might have terminated and so no PodIP leading to invalid . [2.] empty . The same issue had been observed in for E2E and to fix the issue, we introduced execPod deployment to make sure execPod would remain in desired running state. It's better to address this change in another PR and emphasize using pausePod deployment.\nThanks, for helping me setting up CRI-O based cluster. Kubernetes e2e suite [sig-network] Services should be able to change the type from ExternalName to NodePort e2e suite [sig-network] Services should be able to create a functioning NodePort service 19s From log, it is clear that, these services are failing to reach over allocated nodePort. But on my CRIO based testing cluster, they are reachable. or Could you please check if they failing at your end too or it's testgrid Job-specific issue?\nHey, I did some local tests and was able to reproduce the failure. I started the cluster via (check that the variable is correct and does not point to ): Executed the tests by (again, watch out for the variable to be correct): Error output: Since I'm now able to reproduce the issue I can go further in debugging and find out how to fix this. Is anyone furhter, or If not, then I will target for fixing the issue this week. :)\nThanks for reproducing this. FYI we've seem similar failure on , but I haven't reproduced the problem locally yet. We are looking to at least turn on verbose on the test command for debugging:\nThe issue is that we try to automatically discover the node IP by obtaining its status here: In our setup the node has IP which for sure does not work if we try to access it within the pod. I'm thinking about a proper solution and will propose it as a PR.\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-85585bad3884406a52bbbeefc29e8aa1c6cb204fb1544355dfe0eb5545463aea", "text": "testEndpointReachability(clusterIP, sp.Port, sp.Protocol, execPod) } } func testReachabilityOverNodePorts(nodes *v1.NodeList, sp v1.ServicePort, pod *v1.Pod) { internalAddrs := e2enode.CollectAddresses(nodes, v1.NodeInternalIP) externalAddrs := e2enode.CollectAddresses(nodes, v1.NodeExternalIP) for _, internalAddr := range internalAddrs { <ins> // If the node's internal address points to localhost, then we are not // able to test the service reachability via that address if isInvalidOrLocalhostAddress(internalAddr) { e2elog.Logf(\"skipping testEndpointReachability() for internal adddress %s\", internalAddr) continue } </ins> testEndpointReachability(internalAddr, sp.NodePort, sp.Protocol, pod) } for _, externalAddr := range externalAddrs {", "commid": "kubernetes_pr_81157"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-293cdea3c6ec5a83fbc9e02a1638fe58db21159d7cc077448d29d2c4fb193ff6", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: CRI-O e2e Which test(s) are failing: e2e suite [sig-network] Services should be able to change the type from ExternalName to NodePort e2e suite [sig-network] Services should be able to create a functioning NodePort service 19s See link: https://openshift-gce- Since when has it been failing: Anything else we need to know:\n/sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/milestone v1.16 /assign FYI Looks like two other release-blocking tests too: - The changes link testgrid gives () suggests two other PR's, but I agree that seems the likely culprit\nBased on the , Service is reachable on and but failing to reach on node's IP over nodePort i.e. . From the log, it is not clear why its not reachable on node's internal IP. Could you provide from the CRI-O based node when trying to reach nodePort service. Secondly, need to make sure, node is listening on allocated nodePort. As this issue seems much on system-level, I need to setup k8s cluster/node with CRI-O runtime and troubleshoot to find the root cause.\n[sig-network] ESIPP [Slow] [DisabledForLargeClusters] should work from pods [sig-network] Services should only allow access from service loadbalancer source ranges [Slow] seems flaky to me. Most of time execPod starts running and might be terminating immediately after some time which causes this issue. [1.] e2e is failing as might have terminated and so no PodIP leading to invalid . [2.] empty . The same issue had been observed in for E2E and to fix the issue, we introduced execPod deployment to make sure execPod would remain in desired running state. It's better to address this change in another PR and emphasize using pausePod deployment.\nThanks, for helping me setting up CRI-O based cluster. Kubernetes e2e suite [sig-network] Services should be able to change the type from ExternalName to NodePort e2e suite [sig-network] Services should be able to create a functioning NodePort service 19s From log, it is clear that, these services are failing to reach over allocated nodePort. But on my CRIO based testing cluster, they are reachable. or Could you please check if they failing at your end too or it's testgrid Job-specific issue?\nHey, I did some local tests and was able to reproduce the failure. I started the cluster via (check that the variable is correct and does not point to ): Executed the tests by (again, watch out for the variable to be correct): Error output: Since I'm now able to reproduce the issue I can go further in debugging and find out how to fix this. Is anyone furhter, or If not, then I will target for fixing the issue this week. :)\nThanks for reproducing this. FYI we've seem similar failure on , but I haven't reproduced the problem locally yet. We are looking to at least turn on verbose on the test command for debugging:\nThe issue is that we try to automatically discover the node IP by obtaining its status here: In our setup the node has IP which for sure does not work if we try to access it within the pod. I'm thinking about a proper solution and will propose it as a PR.\nIf this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. \u200d\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-34ff268fd37f741f9f03f9e11328dff361b69ced2cce89d554a792d34eb3d11d", "text": "} } <ins> // isInvalidOrLocalhostAddress returns `true` if the provided `ip` is either not // parsable or the loopback address. Otherwise it will return `false`. func isInvalidOrLocalhostAddress(ip string) bool { parsedIP := net.ParseIP(ip) if parsedIP == nil || parsedIP.IsLoopback() { return true } return false } </ins> // testEndpointReachability tests reachability to endpoints (i.e. IP, ServiceName) and ports. Test request is initiated from specified execPod. // TCP and UDP protocol based service are supported at this moment // TODO: add support to test SCTP Protocol based services.", "commid": "kubernetes_pr_81157"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f32b7c5428ec40f8176edd9ab6a3a19435c1e0344527c7b4f5c2634d6944e927", "query": "[x] write e2e tests for all admission operations [x] (for resource APIs) [x] (for discovery docs) [x] switch to v1 admission APIs in e2e - [x] remove skips/time.Sleeps - and promote to conformance tests - AdmissionWebhook should have tests for all stable operations. Those tests should go through the conformance process before being released. This ticket is to help track what operations are yet to be covered by conformance tests. These stable endpoints should be hit by e2e tests tagged with [conformance]. There are tests currently hitting 6 of the corresponding beta endpoints that could be updated to use stable. Tests should be written to exercise the remaining 9 untested stable endpoints as well. These twelve tests could be updated to use the stable API, and subsequently promoted to conformance. / ! ! These will need tests written for them.  untested beta/admissionregistration !\n/sig api-machinery\n/assign\n/area conformance\n/assign ^ This is a requirement for graduation to GA.\ncan we get another apisnoop run? We've coverage for admissionregistration and apiextensions and I'd like to get confirmation from apisnoop that we've got full coverage now.\nKeeping this open until tests are actually promoted to conformance\nis ready for review. It adds our admission e2e tests to conformance as part of graduation to GA.\nis updated currently not hit by any tests, one will need to be updated or written to cover it. Might want to ensure you've promoted one test that hit's each endpoint. !\nThe PR to do that is at", "positive_passages": [{"docid": "doc-en-kubernetes-4f3993d28aa2bd9ff74e7cc03bb0c723c068a08b0e8569ee9df56acab27fdb04", "text": "\"//staging/src/k8s.io/client-go/rest:go_default_library\", \"//staging/src/k8s.io/client-go/util/cert:go_default_library\", \"//staging/src/k8s.io/client-go/util/keyutil:go_default_library\", <ins> \"//staging/src/k8s.io/client-go/util/retry:go_default_library\", </ins> \"//staging/src/k8s.io/client-go/util/workqueue:go_default_library\", \"//staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1:go_default_library\", \"//staging/src/k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset:go_default_library\",", "commid": "kubernetes_pr_81381"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f32b7c5428ec40f8176edd9ab6a3a19435c1e0344527c7b4f5c2634d6944e927", "query": "[x] write e2e tests for all admission operations [x] (for resource APIs) [x] (for discovery docs) [x] switch to v1 admission APIs in e2e - [x] remove skips/time.Sleeps - and promote to conformance tests - AdmissionWebhook should have tests for all stable operations. Those tests should go through the conformance process before being released. This ticket is to help track what operations are yet to be covered by conformance tests. These stable endpoints should be hit by e2e tests tagged with [conformance]. There are tests currently hitting 6 of the corresponding beta endpoints that could be updated to use stable. Tests should be written to exercise the remaining 9 untested stable endpoints as well. These twelve tests could be updated to use the stable API, and subsequently promoted to conformance. / ! ! These will need tests written for them.  untested beta/admissionregistration !\n/sig api-machinery\n/assign\n/area conformance\n/assign ^ This is a requirement for graduation to GA.\ncan we get another apisnoop run? We've coverage for admissionregistration and apiextensions and I'd like to get confirmation from apisnoop that we've got full coverage now.\nKeeping this open until tests are actually promoted to conformance\nis ready for review. It adds our admission e2e tests to conformance as part of graduation to GA.\nis updated currently not hit by any tests, one will need to be updated or written to cover it. Might want to ensure you've promoted one test that hit's each endpoint. !\nThe PR to do that is at", "positive_passages": [{"docid": "doc-en-kubernetes-b5e8c0bb1d0772a409566084ba71761700eef2889803be7d3ad246717433c40f", "text": "\"strings\" \"time\" <ins> \"k8s.io/utils/pointer\" </ins> admissionregistrationv1 \"k8s.io/api/admissionregistration/v1\" appsv1 \"k8s.io/api/apps/v1\" v1 \"k8s.io/api/core/v1\"", "commid": "kubernetes_pr_81381"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f32b7c5428ec40f8176edd9ab6a3a19435c1e0344527c7b4f5c2634d6944e927", "query": "[x] write e2e tests for all admission operations [x] (for resource APIs) [x] (for discovery docs) [x] switch to v1 admission APIs in e2e - [x] remove skips/time.Sleeps - and promote to conformance tests - AdmissionWebhook should have tests for all stable operations. Those tests should go through the conformance process before being released. This ticket is to help track what operations are yet to be covered by conformance tests. These stable endpoints should be hit by e2e tests tagged with [conformance]. There are tests currently hitting 6 of the corresponding beta endpoints that could be updated to use stable. Tests should be written to exercise the remaining 9 untested stable endpoints as well. These twelve tests could be updated to use the stable API, and subsequently promoted to conformance. / ! ! These will need tests written for them.  untested beta/admissionregistration !\n/sig api-machinery\n/assign\n/area conformance\n/assign ^ This is a requirement for graduation to GA.\ncan we get another apisnoop run? We've coverage for admissionregistration and apiextensions and I'd like to get confirmation from apisnoop that we've got full coverage now.\nKeeping this open until tests are actually promoted to conformance\nis ready for review. It adds our admission e2e tests to conformance as part of graduation to GA.\nis updated currently not hit by any tests, one will need to be updated or written to cover it. Might want to ensure you've promoted one test that hit's each endpoint. !\nThe PR to do that is at", "positive_passages": [{"docid": "doc-en-kubernetes-235cd4e4f43057af653c31f4d80a15a18d2f09acfe7dd46e34603f04b2463964", "text": "\"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured\" \"k8s.io/apimachinery/pkg/types\" \"k8s.io/apimachinery/pkg/util/intstr\" <ins> \"k8s.io/apimachinery/pkg/util/uuid\" </ins> utilversion \"k8s.io/apimachinery/pkg/util/version\" \"k8s.io/apimachinery/pkg/util/wait\" \"k8s.io/client-go/dynamic\" clientset \"k8s.io/client-go/kubernetes\" <ins> \"k8s.io/client-go/util/retry\" </ins> \"k8s.io/kubernetes/test/e2e/framework\" e2edeploy \"k8s.io/kubernetes/test/e2e/framework/deployment\" e2elog \"k8s.io/kubernetes/test/e2e/framework/log\" e2epod \"k8s.io/kubernetes/test/e2e/framework/pod\" \"k8s.io/kubernetes/test/utils/crd\" imageutils \"k8s.io/kubernetes/test/utils/image\" <del> \"k8s.io/utils/pointer\" </del> \"github.com/onsi/ginkgo\" \"github.com/onsi/gomega\"", "commid": "kubernetes_pr_81381"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f32b7c5428ec40f8176edd9ab6a3a19435c1e0344527c7b4f5c2634d6944e927", "query": "[x] write e2e tests for all admission operations [x] (for resource APIs) [x] (for discovery docs) [x] switch to v1 admission APIs in e2e - [x] remove skips/time.Sleeps - and promote to conformance tests - AdmissionWebhook should have tests for all stable operations. Those tests should go through the conformance process before being released. This ticket is to help track what operations are yet to be covered by conformance tests. These stable endpoints should be hit by e2e tests tagged with [conformance]. There are tests currently hitting 6 of the corresponding beta endpoints that could be updated to use stable. Tests should be written to exercise the remaining 9 untested stable endpoints as well. These twelve tests could be updated to use the stable API, and subsequently promoted to conformance. / ! ! These will need tests written for them.  untested beta/admissionregistration !\n/sig api-machinery\n/assign\n/area conformance\n/assign ^ This is a requirement for graduation to GA.\ncan we get another apisnoop run? We've coverage for admissionregistration and apiextensions and I'd like to get confirmation from apisnoop that we've got full coverage now.\nKeeping this open until tests are actually promoted to conformance\nis ready for review. It adds our admission e2e tests to conformance as part of graduation to GA.\nis updated currently not hit by any tests, one will need to be updated or written to cover it. Might want to ensure you've promoted one test that hit's each endpoint. !\nThe PR to do that is at", "positive_passages": [{"docid": "doc-en-kubernetes-cff78a710cb05b150c423100ee6755bd7596de68884f304c721415a321d928e9", "text": "slowWebhookCleanup() }) <ins> ginkgo.It(\"patching/updating a validating webhook should work\", func() { client := f.ClientSet admissionClient := client.AdmissionregistrationV1() ginkgo.By(\"Creating a validating webhook configuration\") hook, err := createValidatingWebhookConfiguration(f, &admissionregistrationv1.ValidatingWebhookConfiguration{ ObjectMeta: metav1.ObjectMeta{ Name: f.UniqueName, }, Webhooks: []admissionregistrationv1.ValidatingWebhook{ newDenyConfigMapWebhookFixture(f, context), }, }) framework.ExpectNoError(err, \"Creating validating webhook configuration\") defer func() { err := client.AdmissionregistrationV1().ValidatingWebhookConfigurations().Delete(hook.Name, nil) framework.ExpectNoError(err, \"Deleting validating webhook configuration\") }() ginkgo.By(\"Creating a configMap that does not comply to the validation webhook rules\") err = wait.PollImmediate(100*time.Millisecond, 30*time.Second, func() (bool, error) { cm := namedNonCompliantConfigMap(string(uuid.NewUUID()), f) _, err = client.CoreV1().ConfigMaps(f.Namespace.Name).Create(cm) if err == nil { err = client.CoreV1().ConfigMaps(f.Namespace.Name).Delete(cm.Name, nil) framework.ExpectNoError(err, \"Deleting successfully created configMap\") return false, nil } if !strings.Contains(err.Error(), \"denied\") { return false, err } return true, nil }) ginkgo.By(\"Updating a validating webhook configuration's rules to not include the create operation\") err = retry.RetryOnConflict(retry.DefaultRetry, func() error { h, err := admissionClient.ValidatingWebhookConfigurations().Get(f.UniqueName, metav1.GetOptions{}) framework.ExpectNoError(err, \"Getting validating webhook configuration\") h.Webhooks[0].Rules[0].Operations = []admissionregistrationv1.OperationType{admissionregistrationv1.Update} _, err = admissionClient.ValidatingWebhookConfigurations().Update(h) return err }) framework.ExpectNoError(err, \"Updating validating webhook configuration\") ginkgo.By(\"Creating a configMap that does not comply to the validation webhook rules\") err = wait.PollImmediate(100*time.Millisecond, 30*time.Second, func() (bool, error) { cm := namedNonCompliantConfigMap(string(uuid.NewUUID()), f) _, err = client.CoreV1().ConfigMaps(f.Namespace.Name).Create(cm) if err != nil { if !strings.Contains(err.Error(), \"denied\") { return false, err } return false, nil } err = client.CoreV1().ConfigMaps(f.Namespace.Name).Delete(cm.Name, nil) framework.ExpectNoError(err, \"Deleting successfully created configMap\") return true, nil }) framework.ExpectNoError(err, \"Waiting for configMap in namespace %s to be allowed creation since webhook was updated to not validate create\", f.Namespace.Name) ginkgo.By(\"Patching a validating webhook configuration's rules to include the create operation\") hook, err = admissionClient.ValidatingWebhookConfigurations().Patch( f.UniqueName, types.JSONPatchType, []byte(`[{\"op\": \"replace\", \"path\": \"/webhooks/0/rules/0/operations\", \"value\": [\"CREATE\"]}]`)) framework.ExpectNoError(err, \"Patching validating webhook configuration\") ginkgo.By(\"Creating a configMap that does not comply to the validation webhook rules\") err = wait.PollImmediate(100*time.Millisecond, 30*time.Second, func() (bool, error) { cm := namedNonCompliantConfigMap(string(uuid.NewUUID()), f) _, err = client.CoreV1().ConfigMaps(f.Namespace.Name).Create(cm) if err == nil { err = client.CoreV1().ConfigMaps(f.Namespace.Name).Delete(cm.Name, nil) framework.ExpectNoError(err, \"Deleting successfully created configMap\") return false, nil } if !strings.Contains(err.Error(), \"denied\") { return false, err } return true, nil }) framework.ExpectNoError(err, \"Waiting for configMap in namespace %s to be denied creation by validating webhook\", f.Namespace.Name) }) ginkgo.It(\"patching/updating a mutating webhook should work\", func() { client := f.ClientSet admissionClient := client.AdmissionregistrationV1() ginkgo.By(\"Creating a mutating webhook configuration\") hook, err := createMutatingWebhookConfiguration(f, &admissionregistrationv1.MutatingWebhookConfiguration{ ObjectMeta: metav1.ObjectMeta{ Name: f.UniqueName, }, Webhooks: []admissionregistrationv1.MutatingWebhook{ newMutateConfigMapWebhookFixture(f, context, 1), }, }) framework.ExpectNoError(err, \"Creating mutating webhook configuration\") defer func() { err := client.AdmissionregistrationV1().MutatingWebhookConfigurations().Delete(hook.Name, nil) framework.ExpectNoError(err, \"Deleting mutating webhook configuration\") }() hook, err = admissionClient.MutatingWebhookConfigurations().Get(f.UniqueName, metav1.GetOptions{}) framework.ExpectNoError(err, \"Getting mutating webhook configuration\") ginkgo.By(\"Updating a mutating webhook configuration's rules to not include the create operation\") hook.Webhooks[0].Rules[0].Operations = []admissionregistrationv1.OperationType{admissionregistrationv1.Update} hook, err = admissionClient.MutatingWebhookConfigurations().Update(hook) framework.ExpectNoError(err, \"Updating mutating webhook configuration\") ginkgo.By(\"Creating a configMap that should not be mutated\") err = wait.PollImmediate(100*time.Millisecond, 30*time.Second, func() (bool, error) { cm := namedToBeMutatedConfigMap(string(uuid.NewUUID()), f) created, err := client.CoreV1().ConfigMaps(f.Namespace.Name).Create(cm) if err != nil { return false, err } err = client.CoreV1().ConfigMaps(f.Namespace.Name).Delete(cm.Name, nil) framework.ExpectNoError(err, \"Deleting successfully created configMap\") _, ok := created.Data[\"mutation-stage-1\"] return !ok, nil }) framework.ExpectNoError(err, \"Waiting for configMap in namespace %s this is not mutated\", f.Namespace.Name) ginkgo.By(\"Patching a mutating webhook configuration's rules to include the create operation\") hook, err = admissionClient.MutatingWebhookConfigurations().Patch( f.UniqueName, types.JSONPatchType, []byte(`[{\"op\": \"replace\", \"path\": \"/webhooks/0/rules/0/operations\", \"value\": [\"CREATE\"]}]`)) framework.ExpectNoError(err, \"Patching mutating webhook configuration\") ginkgo.By(\"Creating a configMap that should be mutated\") err = wait.PollImmediate(100*time.Millisecond, 30*time.Second, func() (bool, error) { cm := namedToBeMutatedConfigMap(string(uuid.NewUUID()), f) created, err := client.CoreV1().ConfigMaps(f.Namespace.Name).Create(cm) if err != nil { return false, err } err = client.CoreV1().ConfigMaps(f.Namespace.Name).Delete(cm.Name, nil) framework.ExpectNoError(err, \"Deleting successfully created configMap\") _, ok := created.Data[\"mutation-stage-1\"] return ok, nil }) framework.ExpectNoError(err, \"Waiting for configMap in namespace %s to be mutated\", f.Namespace.Name) }) ginkgo.It(\"listing validating webhooks should work\", func() { testListSize := 10 testUUID := string(uuid.NewUUID()) for i := 0; i < testListSize; i++ { name := fmt.Sprintf(\"%s-%d\", f.UniqueName, i) _, err := createValidatingWebhookConfiguration(f, &admissionregistrationv1.ValidatingWebhookConfiguration{ ObjectMeta: metav1.ObjectMeta{ Name:   name, Labels: map[string]string{\"e2e-list-test-uuid\": testUUID}, }, Webhooks: []admissionregistrationv1.ValidatingWebhook{ newDenyConfigMapWebhookFixture(f, context), }, }) framework.ExpectNoError(err, \"Creating validating webhook configuration\") } selectorListOpts := metav1.ListOptions{LabelSelector: \"e2e-list-test-uuid=\" + testUUID} ginkgo.By(\"Listing all of the created validation webhooks\") list, err := client.AdmissionregistrationV1beta1().ValidatingWebhookConfigurations().List(selectorListOpts) framework.ExpectNoError(err, \"Listing validating webhook configurations\") framework.ExpectEqual(len(list.Items), testListSize) ginkgo.By(\"Creating a configMap that does not comply to the validation webhook rules\") err = wait.PollImmediate(100*time.Millisecond, 30*time.Second, func() (bool, error) { cm := namedNonCompliantConfigMap(string(uuid.NewUUID()), f) _, err = client.CoreV1().ConfigMaps(f.Namespace.Name).Create(cm) if err == nil { err = client.CoreV1().ConfigMaps(f.Namespace.Name).Delete(cm.Name, nil) framework.ExpectNoError(err, \"Deleting successfully created configMap\") return false, nil } if !strings.Contains(err.Error(), \"denied\") { return false, err } return true, nil }) framework.ExpectNoError(err, \"Waiting for configMap in namespace %s to be denied creation by validating webhook\", f.Namespace.Name) ginkgo.By(\"Deleting the collection of validation webhooks\") err = client.AdmissionregistrationV1beta1().ValidatingWebhookConfigurations().DeleteCollection(nil, selectorListOpts) framework.ExpectNoError(err, \"Deleting collection of validating webhook configurations\") ginkgo.By(\"Creating a configMap that does not comply to the validation webhook rules\") err = wait.PollImmediate(100*time.Millisecond, 30*time.Second, func() (bool, error) { cm := namedNonCompliantConfigMap(string(uuid.NewUUID()), f) _, err = client.CoreV1().ConfigMaps(f.Namespace.Name).Create(cm) if err != nil { if !strings.Contains(err.Error(), \"denied\") { return false, err } return false, nil } err = client.CoreV1().ConfigMaps(f.Namespace.Name).Delete(cm.Name, nil) framework.ExpectNoError(err, \"Deleting successfully created configMap\") return true, nil }) framework.ExpectNoError(err, \"Waiting for configMap in namespace %s to be allowed creation since there are no webhooks\", f.Namespace.Name) }) ginkgo.It(\"listing mutating webhooks should work\", func() { testListSize := 10 testUUID := string(uuid.NewUUID()) for i := 0; i < testListSize; i++ { name := fmt.Sprintf(\"%s-%d\", f.UniqueName, i) _, err := createMutatingWebhookConfiguration(f, &admissionregistrationv1.MutatingWebhookConfiguration{ ObjectMeta: metav1.ObjectMeta{ Name:   name, Labels: map[string]string{\"e2e-list-test-uuid\": testUUID}, }, Webhooks: []admissionregistrationv1.MutatingWebhook{ newMutateConfigMapWebhookFixture(f, context, 1), }, }) framework.ExpectNoError(err, \"Creating mutating webhook configuration\") } selectorListOpts := metav1.ListOptions{LabelSelector: \"e2e-list-test-uuid=\" + testUUID} ginkgo.By(\"Listing all of the created validation webhooks\") list, err := client.AdmissionregistrationV1beta1().MutatingWebhookConfigurations().List(selectorListOpts) framework.ExpectNoError(err, \"Listing mutating webhook configurations\") framework.ExpectEqual(len(list.Items), testListSize) ginkgo.By(\"Creating a configMap that should be mutated\") err = wait.PollImmediate(100*time.Millisecond, 30*time.Second, func() (bool, error) { cm := namedToBeMutatedConfigMap(string(uuid.NewUUID()), f) created, err := client.CoreV1().ConfigMaps(f.Namespace.Name).Create(cm) if err != nil { return false, err } err = client.CoreV1().ConfigMaps(f.Namespace.Name).Delete(cm.Name, nil) framework.ExpectNoError(err, \"Deleting successfully created configMap\") _, ok := created.Data[\"mutation-stage-1\"] return ok, nil }) framework.ExpectNoError(err, \"Waiting for configMap in namespace %s to be mutated\", f.Namespace.Name) ginkgo.By(\"Deleting the collection of validation webhooks\") err = client.AdmissionregistrationV1beta1().MutatingWebhookConfigurations().DeleteCollection(nil, selectorListOpts) framework.ExpectNoError(err, \"Deleting collection of mutating webhook configurations\") ginkgo.By(\"Creating a configMap that should not be mutated\") err = wait.PollImmediate(100*time.Millisecond, 30*time.Second, func() (bool, error) { cm := namedToBeMutatedConfigMap(string(uuid.NewUUID()), f) created, err := client.CoreV1().ConfigMaps(f.Namespace.Name).Create(cm) if err != nil { return false, err } err = client.CoreV1().ConfigMaps(f.Namespace.Name).Delete(cm.Name, nil) framework.ExpectNoError(err, \"Deleting successfully created configMap\") _, ok := created.Data[\"mutation-stage-1\"] return !ok, nil }) framework.ExpectNoError(err, \"Waiting for configMap in namespace %s this is not mutated\", f.Namespace.Name) }) </ins> // TODO: add more e2e tests for mutating webhooks // 1. mutating webhook that mutates pod // 2. mutating webhook that sends empty patch", "commid": "kubernetes_pr_81381"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f32b7c5428ec40f8176edd9ab6a3a19435c1e0344527c7b4f5c2634d6944e927", "query": "[x] write e2e tests for all admission operations [x] (for resource APIs) [x] (for discovery docs) [x] switch to v1 admission APIs in e2e - [x] remove skips/time.Sleeps - and promote to conformance tests - AdmissionWebhook should have tests for all stable operations. Those tests should go through the conformance process before being released. This ticket is to help track what operations are yet to be covered by conformance tests. These stable endpoints should be hit by e2e tests tagged with [conformance]. There are tests currently hitting 6 of the corresponding beta endpoints that could be updated to use stable. Tests should be written to exercise the remaining 9 untested stable endpoints as well. These twelve tests could be updated to use the stable API, and subsequently promoted to conformance. / ! ! These will need tests written for them.  untested beta/admissionregistration !\n/sig api-machinery\n/assign\n/area conformance\n/assign ^ This is a requirement for graduation to GA.\ncan we get another apisnoop run? We've coverage for admissionregistration and apiextensions and I'd like to get confirmation from apisnoop that we've got full coverage now.\nKeeping this open until tests are actually promoted to conformance\nis ready for review. It adds our admission e2e tests to conformance as part of graduation to GA.\nis updated currently not hit by any tests, one will need to be updated or written to cover it. Might want to ensure you've promoted one test that hit's each endpoint. !\nThe PR to do that is at", "positive_passages": [{"docid": "doc-en-kubernetes-bb843dac607a7643afcf538ab1cf279ceef6bdb1550b6e7ad469e98636c770e7", "text": "MatchLabels: map[string]string{f.UniqueName: \"true\"}, } <del> sideEffectsNone := admissionregistrationv1.SideEffectClassNone </del> _, err := createValidatingWebhookConfiguration(f, &admissionregistrationv1.ValidatingWebhookConfiguration{ ObjectMeta: metav1.ObjectMeta{ Name: configName, }, Webhooks: []admissionregistrationv1.ValidatingWebhook{ <del> { Name: \"deny-unwanted-pod-container-name-and-label.k8s.io\", Rules: []admissionregistrationv1.RuleWithOperations{{ Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.Create}, Rule: admissionregistrationv1.Rule{ APIGroups:   []string{\"\"}, APIVersions: []string{\"v1\"}, Resources:   []string{\"pods\"}, }, }}, ClientConfig: admissionregistrationv1.WebhookClientConfig{ Service: &admissionregistrationv1.ServiceReference{ Namespace: namespace, Name:      serviceName, Path:      strPtr(\"/pods\"), Port:      pointer.Int32Ptr(servicePort), }, CABundle: context.signingCert, }, SideEffects:             &sideEffectsNone, AdmissionReviewVersions: []string{\"v1beta1\"}, // Scope the webhook to just this namespace NamespaceSelector: &metav1.LabelSelector{ MatchLabels: map[string]string{f.UniqueName: \"true\"}, }, }, { Name: \"deny-unwanted-configmap-data.k8s.io\", Rules: []admissionregistrationv1.RuleWithOperations{{ Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.Create, admissionregistrationv1.Update, admissionregistrationv1.Delete}, Rule: admissionregistrationv1.Rule{ APIGroups:   []string{\"\"}, APIVersions: []string{\"v1\"}, Resources:   []string{\"configmaps\"}, }, }}, // The webhook skips the namespace that has label \"skip-webhook-admission\":\"yes\" NamespaceSelector: &metav1.LabelSelector{ MatchLabels: map[string]string{f.UniqueName: \"true\"}, MatchExpressions: []metav1.LabelSelectorRequirement{ { Key:      skipNamespaceLabelKey, Operator: metav1.LabelSelectorOpNotIn, Values:   []string{skipNamespaceLabelValue}, }, }, }, ClientConfig: admissionregistrationv1.WebhookClientConfig{ Service: &admissionregistrationv1.ServiceReference{ Namespace: namespace, Name:      serviceName, Path:      strPtr(\"/configmaps\"), Port:      pointer.Int32Ptr(servicePort), }, CABundle: context.signingCert, }, SideEffects:             &sideEffectsNone, AdmissionReviewVersions: []string{\"v1beta1\"}, }, </del> <ins> newDenyPodWebhookFixture(f, context), newDenyConfigMapWebhookFixture(f, context), </ins> // Server cannot talk to this webhook, so it always fails. // Because this webhook is configured fail-open, request should be admitted after the call fails. failOpenHook,", "commid": "kubernetes_pr_81381"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f32b7c5428ec40f8176edd9ab6a3a19435c1e0344527c7b4f5c2634d6944e927", "query": "[x] write e2e tests for all admission operations [x] (for resource APIs) [x] (for discovery docs) [x] switch to v1 admission APIs in e2e - [x] remove skips/time.Sleeps - and promote to conformance tests - AdmissionWebhook should have tests for all stable operations. Those tests should go through the conformance process before being released. This ticket is to help track what operations are yet to be covered by conformance tests. These stable endpoints should be hit by e2e tests tagged with [conformance]. There are tests currently hitting 6 of the corresponding beta endpoints that could be updated to use stable. Tests should be written to exercise the remaining 9 untested stable endpoints as well. These twelve tests could be updated to use the stable API, and subsequently promoted to conformance. / ! ! These will need tests written for them.  untested beta/admissionregistration !\n/sig api-machinery\n/assign\n/area conformance\n/assign ^ This is a requirement for graduation to GA.\ncan we get another apisnoop run? We've coverage for admissionregistration and apiextensions and I'd like to get confirmation from apisnoop that we've got full coverage now.\nKeeping this open until tests are actually promoted to conformance\nis ready for review. It adds our admission e2e tests to conformance as part of graduation to GA.\nis updated currently not hit by any tests, one will need to be updated or written to cover it. Might want to ensure you've promoted one test that hit's each endpoint. !\nThe PR to do that is at", "positive_passages": [{"docid": "doc-en-kubernetes-063911b5d8a9cba0c6605b7fdfedb77a10164731f5f961c646b3086932e9638a", "text": "ginkgo.By(\"Registering the mutating configmap webhook via the AdmissionRegistration API\") namespace := f.Namespace.Name <del> sideEffectsNone := admissionregistrationv1.SideEffectClassNone </del> _, err := createMutatingWebhookConfiguration(f, &admissionregistrationv1.MutatingWebhookConfiguration{ ObjectMeta: metav1.ObjectMeta{ Name: configName, }, Webhooks: []admissionregistrationv1.MutatingWebhook{ <del> { Name: \"adding-configmap-data-stage-1.k8s.io\", Rules: []admissionregistrationv1.RuleWithOperations{{ Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.Create}, Rule: admissionregistrationv1.Rule{ APIGroups:   []string{\"\"}, APIVersions: []string{\"v1\"}, Resources:   []string{\"configmaps\"}, }, }}, ClientConfig: admissionregistrationv1.WebhookClientConfig{ Service: &admissionregistrationv1.ServiceReference{ Namespace: namespace, Name:      serviceName, Path:      strPtr(\"/mutating-configmaps\"), Port:      pointer.Int32Ptr(servicePort), }, CABundle: context.signingCert, }, SideEffects:             &sideEffectsNone, AdmissionReviewVersions: []string{\"v1beta1\"}, // Scope the webhook to just this namespace NamespaceSelector: &metav1.LabelSelector{ MatchLabels: map[string]string{f.UniqueName: \"true\"}, }, }, { Name: \"adding-configmap-data-stage-2.k8s.io\", Rules: []admissionregistrationv1.RuleWithOperations{{ Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.Create}, Rule: admissionregistrationv1.Rule{ APIGroups:   []string{\"\"}, APIVersions: []string{\"v1\"}, Resources:   []string{\"configmaps\"}, }, }}, ClientConfig: admissionregistrationv1.WebhookClientConfig{ Service: &admissionregistrationv1.ServiceReference{ Namespace: namespace, Name:      serviceName, Path:      strPtr(\"/mutating-configmaps\"), Port:      pointer.Int32Ptr(servicePort), }, CABundle: context.signingCert, }, SideEffects:             &sideEffectsNone, AdmissionReviewVersions: []string{\"v1beta1\"}, // Scope the webhook to just this namespace NamespaceSelector: &metav1.LabelSelector{ MatchLabels: map[string]string{f.UniqueName: \"true\"}, }, }, </del> <ins> newMutateConfigMapWebhookFixture(f, context, 1), newMutateConfigMapWebhookFixture(f, context, 2), </ins> }, }) framework.ExpectNoError(err, \"registering mutating webhook config %s with namespace %s\", configName, namespace)", "commid": "kubernetes_pr_81381"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f32b7c5428ec40f8176edd9ab6a3a19435c1e0344527c7b4f5c2634d6944e927", "query": "[x] write e2e tests for all admission operations [x] (for resource APIs) [x] (for discovery docs) [x] switch to v1 admission APIs in e2e - [x] remove skips/time.Sleeps - and promote to conformance tests - AdmissionWebhook should have tests for all stable operations. Those tests should go through the conformance process before being released. This ticket is to help track what operations are yet to be covered by conformance tests. These stable endpoints should be hit by e2e tests tagged with [conformance]. There are tests currently hitting 6 of the corresponding beta endpoints that could be updated to use stable. Tests should be written to exercise the remaining 9 untested stable endpoints as well. These twelve tests could be updated to use the stable API, and subsequently promoted to conformance. / ! ! These will need tests written for them.  untested beta/admissionregistration !\n/sig api-machinery\n/assign\n/area conformance\n/assign ^ This is a requirement for graduation to GA.\ncan we get another apisnoop run? We've coverage for admissionregistration and apiextensions and I'd like to get confirmation from apisnoop that we've got full coverage now.\nKeeping this open until tests are actually promoted to conformance\nis ready for review. It adds our admission e2e tests to conformance as part of graduation to GA.\nis updated currently not hit by any tests, one will need to be updated or written to cover it. Might want to ensure you've promoted one test that hit's each endpoint. !\nThe PR to do that is at", "positive_passages": [{"docid": "doc-en-kubernetes-ecbc37ada3b8e35d7e239afefb030a9d6d5d8925915ef70bb0662247b6e153e2", "text": "} func nonCompliantConfigMap(f *framework.Framework) *v1.ConfigMap { <ins> return namedNonCompliantConfigMap(disallowedConfigMapName, f) } func namedNonCompliantConfigMap(name string, f *framework.Framework) *v1.ConfigMap { </ins> return &v1.ConfigMap{ ObjectMeta: metav1.ObjectMeta{ <del> Name: disallowedConfigMapName, </del> <ins> Name: name, </ins> }, Data: map[string]string{ \"webhook-e2e-test\": \"webhook-disallow\",", "commid": "kubernetes_pr_81381"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f32b7c5428ec40f8176edd9ab6a3a19435c1e0344527c7b4f5c2634d6944e927", "query": "[x] write e2e tests for all admission operations [x] (for resource APIs) [x] (for discovery docs) [x] switch to v1 admission APIs in e2e - [x] remove skips/time.Sleeps - and promote to conformance tests - AdmissionWebhook should have tests for all stable operations. Those tests should go through the conformance process before being released. This ticket is to help track what operations are yet to be covered by conformance tests. These stable endpoints should be hit by e2e tests tagged with [conformance]. There are tests currently hitting 6 of the corresponding beta endpoints that could be updated to use stable. Tests should be written to exercise the remaining 9 untested stable endpoints as well. These twelve tests could be updated to use the stable API, and subsequently promoted to conformance. / ! ! These will need tests written for them.  untested beta/admissionregistration !\n/sig api-machinery\n/assign\n/area conformance\n/assign ^ This is a requirement for graduation to GA.\ncan we get another apisnoop run? We've coverage for admissionregistration and apiextensions and I'd like to get confirmation from apisnoop that we've got full coverage now.\nKeeping this open until tests are actually promoted to conformance\nis ready for review. It adds our admission e2e tests to conformance as part of graduation to GA.\nis updated currently not hit by any tests, one will need to be updated or written to cover it. Might want to ensure you've promoted one test that hit's each endpoint. !\nThe PR to do that is at", "positive_passages": [{"docid": "doc-en-kubernetes-f96dccccfbfcd785aa192ed156ec9f4df5fa381770f852a50ecfcd3004fdd3e6", "text": "} func toBeMutatedConfigMap(f *framework.Framework) *v1.ConfigMap { <ins> return namedToBeMutatedConfigMap(\"to-be-mutated\", f) } func namedToBeMutatedConfigMap(name string, f *framework.Framework) *v1.ConfigMap { </ins> return &v1.ConfigMap{ ObjectMeta: metav1.ObjectMeta{ <del> Name: \"to-be-mutated\", </del> <ins> Name: name, </ins> }, Data: map[string]string{ \"mutation-start\": \"yes\",", "commid": "kubernetes_pr_81381"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f32b7c5428ec40f8176edd9ab6a3a19435c1e0344527c7b4f5c2634d6944e927", "query": "[x] write e2e tests for all admission operations [x] (for resource APIs) [x] (for discovery docs) [x] switch to v1 admission APIs in e2e - [x] remove skips/time.Sleeps - and promote to conformance tests - AdmissionWebhook should have tests for all stable operations. Those tests should go through the conformance process before being released. This ticket is to help track what operations are yet to be covered by conformance tests. These stable endpoints should be hit by e2e tests tagged with [conformance]. There are tests currently hitting 6 of the corresponding beta endpoints that could be updated to use stable. Tests should be written to exercise the remaining 9 untested stable endpoints as well. These twelve tests could be updated to use the stable API, and subsequently promoted to conformance. / ! ! These will need tests written for them.  untested beta/admissionregistration !\n/sig api-machinery\n/assign\n/area conformance\n/assign ^ This is a requirement for graduation to GA.\ncan we get another apisnoop run? We've coverage for admissionregistration and apiextensions and I'd like to get confirmation from apisnoop that we've got full coverage now.\nKeeping this open until tests are actually promoted to conformance\nis ready for review. It adds our admission e2e tests to conformance as part of graduation to GA.\nis updated currently not hit by any tests, one will need to be updated or written to cover it. Might want to ensure you've promoted one test that hit's each endpoint. !\nThe PR to do that is at", "positive_passages": [{"docid": "doc-en-kubernetes-d4d8b822c7d52a09d9e4420481990ec7067e329d0f1a86dab19de94b9727d7e3", "text": "} return f.ClientSet.AdmissionregistrationV1().MutatingWebhookConfigurations().Create(config) } <ins> func newDenyPodWebhookFixture(f *framework.Framework, context *certContext) admissionregistrationv1.ValidatingWebhook { sideEffectsNone := admissionregistrationv1.SideEffectClassNone return admissionregistrationv1.ValidatingWebhook{ Name: \"deny-unwanted-pod-container-name-and-label.k8s.io\", Rules: []admissionregistrationv1.RuleWithOperations{{ Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.Create}, Rule: admissionregistrationv1.Rule{ APIGroups:   []string{\"\"}, APIVersions: []string{\"v1\"}, Resources:   []string{\"pods\"}, }, }}, ClientConfig: admissionregistrationv1.WebhookClientConfig{ Service: &admissionregistrationv1.ServiceReference{ Namespace: f.Namespace.Name, Name:      serviceName, Path:      strPtr(\"/pods\"), Port:      pointer.Int32Ptr(servicePort), }, CABundle: context.signingCert, }, SideEffects:             &sideEffectsNone, AdmissionReviewVersions: []string{\"v1beta1\"}, // Scope the webhook to just this namespace NamespaceSelector: &metav1.LabelSelector{ MatchLabels: map[string]string{f.UniqueName: \"true\"}, }, } } func newDenyConfigMapWebhookFixture(f *framework.Framework, context *certContext) admissionregistrationv1.ValidatingWebhook { sideEffectsNone := admissionregistrationv1.SideEffectClassNone return admissionregistrationv1.ValidatingWebhook{ Name: \"deny-unwanted-configmap-data.k8s.io\", Rules: []admissionregistrationv1.RuleWithOperations{{ Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.Create, admissionregistrationv1.Update, admissionregistrationv1.Delete}, Rule: admissionregistrationv1.Rule{ APIGroups:   []string{\"\"}, APIVersions: []string{\"v1\"}, Resources:   []string{\"configmaps\"}, }, }}, // The webhook skips the namespace that has label \"skip-webhook-admission\":\"yes\" NamespaceSelector: &metav1.LabelSelector{ MatchLabels: map[string]string{f.UniqueName: \"true\"}, MatchExpressions: []metav1.LabelSelectorRequirement{ { Key:      skipNamespaceLabelKey, Operator: metav1.LabelSelectorOpNotIn, Values:   []string{skipNamespaceLabelValue}, }, }, }, ClientConfig: admissionregistrationv1.WebhookClientConfig{ Service: &admissionregistrationv1.ServiceReference{ Namespace: f.Namespace.Name, Name:      serviceName, Path:      strPtr(\"/configmaps\"), Port:      pointer.Int32Ptr(servicePort), }, CABundle: context.signingCert, }, SideEffects:             &sideEffectsNone, AdmissionReviewVersions: []string{\"v1beta1\"}, } } func newMutateConfigMapWebhookFixture(f *framework.Framework, context *certContext, stage int) admissionregistrationv1.MutatingWebhook { sideEffectsNone := admissionregistrationv1.SideEffectClassNone return admissionregistrationv1.MutatingWebhook{ Name: fmt.Sprintf(\"adding-configmap-data-stage-%d.k8s.io\", stage), Rules: []admissionregistrationv1.RuleWithOperations{{ Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.Create}, Rule: admissionregistrationv1.Rule{ APIGroups:   []string{\"\"}, APIVersions: []string{\"v1\"}, Resources:   []string{\"configmaps\"}, }, }}, ClientConfig: admissionregistrationv1.WebhookClientConfig{ Service: &admissionregistrationv1.ServiceReference{ Namespace: f.Namespace.Name, Name:      serviceName, Path:      strPtr(\"/mutating-configmaps\"), Port:      pointer.Int32Ptr(servicePort), }, CABundle: context.signingCert, }, SideEffects:             &sideEffectsNone, AdmissionReviewVersions: []string{\"v1beta1\"}, // Scope the webhook to just this namespace NamespaceSelector: &metav1.LabelSelector{ MatchLabels: map[string]string{f.UniqueName: \"true\"}, }, } } </ins>", "commid": "kubernetes_pr_81381"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-16d20469cfbbebd3a63b2abd343d03ad47978a2d98b642d88d94294a2a31e03e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: With kubectl v1.16.0-alpha.2, completion with override flags fails. then hit TAB will produce error \"resource type must be specified\" What you expected to happen: It must show the namespaces without error. How to reproduce it (as minimally and precisely as possible): With kubectl v1.16.0-alpha.2, then hit TAB key. Anything else we need to know?: It looks like introduced this regression. Environment: Kubernetes version (use ): kubectl v1.16.0-alpha.2 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig cli\nI also reproduced this bug with the following steps:\nI'm fixing it.", "positive_passages": [{"docid": "doc-en-kubernetes-d345479daea5ef8fb6d3903341be39c6ee0c697d5287b15837c4e20ff123c17a", "text": "done for var in \"${__kubectl_override_flag_list[@]##*-}\"; do if eval \"test -n \"$${var}\"\"; then <del> eval \"echo ${${var}}\" </del> <ins> eval \"echo -n ${${var}}' '\" </ins> fi done }", "commid": "kubernetes_pr_80802"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9496dc8b8e00d14800df6ff70d9d0598864626d6dbfb05ec6d0deacd8726a6f4", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : We need to enhance Azure cloud provider code to support both AAD and ADFS authentication. Why is this needed: On Azure Stack customer can have two type of deployment .\n/sig azure\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-5301d12ecb5793f55a562462ee27143bb098ec062d51b1de18bc0c08318d3493", "text": "\"crypto/x509\" \"fmt\" \"io/ioutil\" <ins> \"strings\" </ins> \"github.com/Azure/go-autorest/autorest/adal\" \"github.com/Azure/go-autorest/autorest/azure\"", "commid": "kubernetes_pr_80841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9496dc8b8e00d14800df6ff70d9d0598864626d6dbfb05ec6d0deacd8726a6f4", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : We need to enhance Azure cloud provider code to support both AAD and ADFS authentication. Why is this needed: On Azure Stack customer can have two type of deployment .\n/sig azure\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-1081b2353ac78799b817223fb8453e79d2927d69ac2960d24721ad9c2fadf582", "text": "var ( // ErrorNoAuth indicates that no credentials are provided. ErrorNoAuth = fmt.Errorf(\"no credentials provided for Azure cloud provider\") <ins> // ADFSIdentitySystem indicates value of tenantId for ADFS on Azure Stack. ADFSIdentitySystem = \"ADFS\" </ins> ) // AzureAuthConfig holds auth related part of cloud config", "commid": "kubernetes_pr_80841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9496dc8b8e00d14800df6ff70d9d0598864626d6dbfb05ec6d0deacd8726a6f4", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : We need to enhance Azure cloud provider code to support both AAD and ADFS authentication. Why is this needed: On Azure Stack customer can have two type of deployment .\n/sig azure\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-db69d787daff1c2d141c6a8e729d15d6d71de7519d298287e840e1cfb9f3a9cf", "text": "UserAssignedIdentityID string `json:\"userAssignedIdentityID,omitempty\" yaml:\"userAssignedIdentityID,omitempty\"` // The ID of the Azure Subscription that the cluster is deployed in SubscriptionID string `json:\"subscriptionId,omitempty\" yaml:\"subscriptionId,omitempty\"` <ins> // Identity system value for the deployment. This gets populate for Azure Stack case. IdentitySystem string `json:\"identitySystem,omitempty\" yaml:\"identitySystem,omitempty\"` </ins> } // GetServicePrincipalToken creates a new service principal token based on the configuration func GetServicePrincipalToken(config *AzureAuthConfig, env *azure.Environment) (*adal.ServicePrincipalToken, error) { <ins> var tenantID string if strings.EqualFold(config.IdentitySystem, ADFSIdentitySystem) { tenantID = \"adfs\" } else { tenantID = config.TenantID } </ins> if config.UseManagedIdentityExtension { klog.V(2).Infoln(\"azure: using managed identity extension to retrieve access token\") msiEndpoint, err := adal.GetMSIVMEndpoint()", "commid": "kubernetes_pr_80841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9496dc8b8e00d14800df6ff70d9d0598864626d6dbfb05ec6d0deacd8726a6f4", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : We need to enhance Azure cloud provider code to support both AAD and ADFS authentication. Why is this needed: On Azure Stack customer can have two type of deployment .\n/sig azure\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-717aeb1e2766b8bc5e10fa126010f777c51f9d1b18919e5007ac682678a14964", "text": "env.ServiceManagementEndpoint) } <del> oauthConfig, err := adal.NewOAuthConfig(env.ActiveDirectoryEndpoint, config.TenantID) </del> <ins> oauthConfig, err := adal.NewOAuthConfig(env.ActiveDirectoryEndpoint, tenantID) </ins> if err != nil { return nil, fmt.Errorf(\"creating the OAuth config: %v\", err) }", "commid": "kubernetes_pr_80841"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcfa7bd39ff05f8f481c3621cc1f09ee2806ddcbff04ca803688eceda95fbb5e", "query": "What happened: In reviewing a test for promotion to conformance I noticed the kubelet API was being accessed via the API server's node proxy endpoint (ref: ). This seemed off, so I reviewed . It doesn't explicitly call out kubelet API access as allowed or disallowed. . and agreed kubelet API access seems like a bad idea. I'm now surveying what we have that does_ assume kubelet API access. It's definitely used by parts of e2e framework and some Conformance tests. I'm trying to verify how critical its use is. It appears that much of it is related to debugging or verifying whether kubelets and the control plane agree on who is running what. What you expected to happen: Find a blanket policy that bans kubelet API access for Conformance tests, whether directly, or indirectly through the API server's node proxy endpoint, at any time. Alternatively, find a policy that says kubelet API access may be allowed, but only for debugging or failure purposes (must not be on the critical path to make the test pass) Alternatively, find a policy that says kubelet API access is allowed, but only indirectly through the API server, and evaluated against the same constraints we use for control plane access (GA, non-optional) If we want to say kubelet API access is banned, we can use this as a tracking issue to demote whichever tests rely on it, and come up with a plan to verify the same behavior without kubelet API access. /area conformance /sig architecture /priority important-soon /milestone v1.16 /assign\nLook for anything that ends up calling calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test requires kubelet API access to pass may end up calling it if the test fails, via: Some Conformance tests may end up calling this if the test fails specifically Other areas this is used: only if the test fails required for a pre-stop hook test to pass required to make sure the readonly kubelet apis aren't exposed via api server proxy resource usage tracking tests require kubelet api access to pass tests call this in\nLooking for doesn't turn up any additional conformance tests, and I don't feel compelled to link the two other tests that use it as they are unlikely to ever be eligible.\nThe examples pointed out by on slack, the kubelet's endpoints is required to be available for these to pass\nHello! I'm the bug triage lead for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. The code freeze is starting on August 29th EOD PST (about 5 days from now) and once the code freeze starts, only release-blocking changes will be considered to be merged. Is this issue still planned to be fixed for the 1.16 release?\nare there further changes for this targeted at 1.16?\nAny update on this?\n/milestone v1.17\nBug Triage Release Team checking in. Code freeze for the 1.17 release is on November 14. Will this make it in? Thanks!\n/assign\nhi is this still targetting for 1.17 or can we move to 1.18? Code freeze is Nov 14th. thanks!\n/milestone v1.18\nSo we've updated the documented policy. My suggestion to close this out is to drop the [Conformance] tag from the tests that currently require the kubelet API to pass, and open issues that they need to be rewritten. Ignore whether the API is needed for diagnostic info in failure modes. SchedulerPredicates [Serial] calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test Pods should be submitted and removed [NodeConformance] requires kubelet API access to pass\ni'd support this ^^\nHello , Bug Triage team here for the 1.18 release. This is a friendly reminder that code freeze is scheduled for 5 March. Is this issue still intended for milestone 1.18?\nHello There's been no movement on this issue this year. Should this get pushed to the next milestone?\nyes, please John T Skarbek <:\n/milestone v1.19\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-91c2b75998672acc8f1ddce016ff53528397d0f5736d230ebc9f7708c4f5fc9e", "text": "\"//staging/src/k8s.io/client-go/tools/watch:go_default_library\", \"//test/e2e/framework:go_default_library\", \"//test/e2e/framework/events:go_default_library\", <del> \"//test/e2e/framework/kubelet:go_default_library\", </del> \"//test/e2e/framework/network:go_default_library\", \"//test/e2e/framework/node:go_default_library\", \"//test/e2e/framework/pod:go_default_library\",", "commid": "kubernetes_pr_89715"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcfa7bd39ff05f8f481c3621cc1f09ee2806ddcbff04ca803688eceda95fbb5e", "query": "What happened: In reviewing a test for promotion to conformance I noticed the kubelet API was being accessed via the API server's node proxy endpoint (ref: ). This seemed off, so I reviewed . It doesn't explicitly call out kubelet API access as allowed or disallowed. . and agreed kubelet API access seems like a bad idea. I'm now surveying what we have that does_ assume kubelet API access. It's definitely used by parts of e2e framework and some Conformance tests. I'm trying to verify how critical its use is. It appears that much of it is related to debugging or verifying whether kubelets and the control plane agree on who is running what. What you expected to happen: Find a blanket policy that bans kubelet API access for Conformance tests, whether directly, or indirectly through the API server's node proxy endpoint, at any time. Alternatively, find a policy that says kubelet API access may be allowed, but only for debugging or failure purposes (must not be on the critical path to make the test pass) Alternatively, find a policy that says kubelet API access is allowed, but only indirectly through the API server, and evaluated against the same constraints we use for control plane access (GA, non-optional) If we want to say kubelet API access is banned, we can use this as a tracking issue to demote whichever tests rely on it, and come up with a plan to verify the same behavior without kubelet API access. /area conformance /sig architecture /priority important-soon /milestone v1.16 /assign\nLook for anything that ends up calling calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test requires kubelet API access to pass may end up calling it if the test fails, via: Some Conformance tests may end up calling this if the test fails specifically Other areas this is used: only if the test fails required for a pre-stop hook test to pass required to make sure the readonly kubelet apis aren't exposed via api server proxy resource usage tracking tests require kubelet api access to pass tests call this in\nLooking for doesn't turn up any additional conformance tests, and I don't feel compelled to link the two other tests that use it as they are unlikely to ever be eligible.\nThe examples pointed out by on slack, the kubelet's endpoints is required to be available for these to pass\nHello! I'm the bug triage lead for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. The code freeze is starting on August 29th EOD PST (about 5 days from now) and once the code freeze starts, only release-blocking changes will be considered to be merged. Is this issue still planned to be fixed for the 1.16 release?\nare there further changes for this targeted at 1.16?\nAny update on this?\n/milestone v1.17\nBug Triage Release Team checking in. Code freeze for the 1.17 release is on November 14. Will this make it in? Thanks!\n/assign\nhi is this still targetting for 1.17 or can we move to 1.18? Code freeze is Nov 14th. thanks!\n/milestone v1.18\nSo we've updated the documented policy. My suggestion to close this out is to drop the [Conformance] tag from the tests that currently require the kubelet API to pass, and open issues that they need to be rewritten. Ignore whether the API is needed for diagnostic info in failure modes. SchedulerPredicates [Serial] calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test Pods should be submitted and removed [NodeConformance] requires kubelet API access to pass\ni'd support this ^^\nHello , Bug Triage team here for the 1.18 release. This is a friendly reminder that code freeze is scheduled for 5 March. Is this issue still intended for milestone 1.18?\nHello There's been no movement on this issue this year. Should this get pushed to the next milestone?\nyes, please John T Skarbek <:\n/milestone v1.19\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-ec10b2d0f17744380055a9d71c94ff91d45c844d8d7a20607b36986774f1969f", "text": "podutil \"k8s.io/kubernetes/pkg/api/v1/pod\" \"k8s.io/kubernetes/pkg/kubelet\" \"k8s.io/kubernetes/test/e2e/framework\" <del> e2ekubelet \"k8s.io/kubernetes/test/e2e/framework/kubelet\" </del> e2epod \"k8s.io/kubernetes/test/e2e/framework/pod\" e2ewebsocket \"k8s.io/kubernetes/test/e2e/framework/websocket\" imageutils \"k8s.io/kubernetes/test/utils/image\"", "commid": "kubernetes_pr_89715"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcfa7bd39ff05f8f481c3621cc1f09ee2806ddcbff04ca803688eceda95fbb5e", "query": "What happened: In reviewing a test for promotion to conformance I noticed the kubelet API was being accessed via the API server's node proxy endpoint (ref: ). This seemed off, so I reviewed . It doesn't explicitly call out kubelet API access as allowed or disallowed. . and agreed kubelet API access seems like a bad idea. I'm now surveying what we have that does_ assume kubelet API access. It's definitely used by parts of e2e framework and some Conformance tests. I'm trying to verify how critical its use is. It appears that much of it is related to debugging or verifying whether kubelets and the control plane agree on who is running what. What you expected to happen: Find a blanket policy that bans kubelet API access for Conformance tests, whether directly, or indirectly through the API server's node proxy endpoint, at any time. Alternatively, find a policy that says kubelet API access may be allowed, but only for debugging or failure purposes (must not be on the critical path to make the test pass) Alternatively, find a policy that says kubelet API access is allowed, but only indirectly through the API server, and evaluated against the same constraints we use for control plane access (GA, non-optional) If we want to say kubelet API access is banned, we can use this as a tracking issue to demote whichever tests rely on it, and come up with a plan to verify the same behavior without kubelet API access. /area conformance /sig architecture /priority important-soon /milestone v1.16 /assign\nLook for anything that ends up calling calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test requires kubelet API access to pass may end up calling it if the test fails, via: Some Conformance tests may end up calling this if the test fails specifically Other areas this is used: only if the test fails required for a pre-stop hook test to pass required to make sure the readonly kubelet apis aren't exposed via api server proxy resource usage tracking tests require kubelet api access to pass tests call this in\nLooking for doesn't turn up any additional conformance tests, and I don't feel compelled to link the two other tests that use it as they are unlikely to ever be eligible.\nThe examples pointed out by on slack, the kubelet's endpoints is required to be available for these to pass\nHello! I'm the bug triage lead for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. The code freeze is starting on August 29th EOD PST (about 5 days from now) and once the code freeze starts, only release-blocking changes will be considered to be merged. Is this issue still planned to be fixed for the 1.16 release?\nare there further changes for this targeted at 1.16?\nAny update on this?\n/milestone v1.17\nBug Triage Release Team checking in. Code freeze for the 1.17 release is on November 14. Will this make it in? Thanks!\n/assign\nhi is this still targetting for 1.17 or can we move to 1.18? Code freeze is Nov 14th. thanks!\n/milestone v1.18\nSo we've updated the documented policy. My suggestion to close this out is to drop the [Conformance] tag from the tests that currently require the kubelet API to pass, and open issues that they need to be rewritten. Ignore whether the API is needed for diagnostic info in failure modes. SchedulerPredicates [Serial] calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test Pods should be submitted and removed [NodeConformance] requires kubelet API access to pass\ni'd support this ^^\nHello , Bug Triage team here for the 1.18 release. This is a friendly reminder that code freeze is scheduled for 5 March. Is this issue still intended for milestone 1.18?\nHello There's been no movement on this issue this year. Should this get pushed to the next milestone?\nyes, please John T Skarbek <:\n/milestone v1.19\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-a2c6d6bb057469475f10372f729cce7ed770b791599f84bd8a69fa237636dd3e", "text": "err = podClient.Delete(context.TODO(), pod.Name, *metav1.NewDeleteOptions(30)) framework.ExpectNoError(err, \"failed to delete pod\") <del> ginkgo.By(\"verifying the kubelet observed the termination notice\") err = wait.Poll(time.Second*5, time.Second*30, func() (bool, error) { podList, err := e2ekubelet.GetKubeletPods(f.ClientSet, pod.Spec.NodeName) if err != nil { framework.Logf(\"Unable to retrieve kubelet pods for node %v: %v\", pod.Spec.NodeName, err) return false, nil } for _, kubeletPod := range podList.Items { if pod.Name != kubeletPod.Name { continue } if kubeletPod.ObjectMeta.DeletionTimestamp == nil { framework.Logf(\"deletion has not yet been observed\") return false, nil } return true, nil } framework.Logf(\"no pod exists with the name we were looking for, assuming the termination request was observed and completed\") return true, nil }) framework.ExpectNoError(err, \"kubelet never observed the termination notice\") </del> ginkgo.By(\"verifying pod deletion was observed\") deleted := false var lastPod *v1.Pod", "commid": "kubernetes_pr_89715"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcfa7bd39ff05f8f481c3621cc1f09ee2806ddcbff04ca803688eceda95fbb5e", "query": "What happened: In reviewing a test for promotion to conformance I noticed the kubelet API was being accessed via the API server's node proxy endpoint (ref: ). This seemed off, so I reviewed . It doesn't explicitly call out kubelet API access as allowed or disallowed. . and agreed kubelet API access seems like a bad idea. I'm now surveying what we have that does_ assume kubelet API access. It's definitely used by parts of e2e framework and some Conformance tests. I'm trying to verify how critical its use is. It appears that much of it is related to debugging or verifying whether kubelets and the control plane agree on who is running what. What you expected to happen: Find a blanket policy that bans kubelet API access for Conformance tests, whether directly, or indirectly through the API server's node proxy endpoint, at any time. Alternatively, find a policy that says kubelet API access may be allowed, but only for debugging or failure purposes (must not be on the critical path to make the test pass) Alternatively, find a policy that says kubelet API access is allowed, but only indirectly through the API server, and evaluated against the same constraints we use for control plane access (GA, non-optional) If we want to say kubelet API access is banned, we can use this as a tracking issue to demote whichever tests rely on it, and come up with a plan to verify the same behavior without kubelet API access. /area conformance /sig architecture /priority important-soon /milestone v1.16 /assign\nLook for anything that ends up calling calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test requires kubelet API access to pass may end up calling it if the test fails, via: Some Conformance tests may end up calling this if the test fails specifically Other areas this is used: only if the test fails required for a pre-stop hook test to pass required to make sure the readonly kubelet apis aren't exposed via api server proxy resource usage tracking tests require kubelet api access to pass tests call this in\nLooking for doesn't turn up any additional conformance tests, and I don't feel compelled to link the two other tests that use it as they are unlikely to ever be eligible.\nThe examples pointed out by on slack, the kubelet's endpoints is required to be available for these to pass\nHello! I'm the bug triage lead for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. The code freeze is starting on August 29th EOD PST (about 5 days from now) and once the code freeze starts, only release-blocking changes will be considered to be merged. Is this issue still planned to be fixed for the 1.16 release?\nare there further changes for this targeted at 1.16?\nAny update on this?\n/milestone v1.17\nBug Triage Release Team checking in. Code freeze for the 1.17 release is on November 14. Will this make it in? Thanks!\n/assign\nhi is this still targetting for 1.17 or can we move to 1.18? Code freeze is Nov 14th. thanks!\n/milestone v1.18\nSo we've updated the documented policy. My suggestion to close this out is to drop the [Conformance] tag from the tests that currently require the kubelet API to pass, and open issues that they need to be rewritten. Ignore whether the API is needed for diagnostic info in failure modes. SchedulerPredicates [Serial] calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test Pods should be submitted and removed [NodeConformance] requires kubelet API access to pass\ni'd support this ^^\nHello , Bug Triage team here for the 1.18 release. This is a friendly reminder that code freeze is scheduled for 5 March. Is this issue still intended for milestone 1.18?\nHello There's been no movement on this issue this year. Should this get pushed to the next milestone?\nyes, please John T Skarbek <:\n/milestone v1.19\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-bae8b1d7bdb7855b749998d9aa73199752abc1027d54aeefabc87435a1ca47a3", "text": "\"//test/e2e/framework:go_default_library\", \"//test/e2e/framework/gpu:go_default_library\", \"//test/e2e/framework/job:go_default_library\", <del> \"//test/e2e/framework/kubelet:go_default_library\", </del> \"//test/e2e/framework/node:go_default_library\", \"//test/e2e/framework/pod:go_default_library\", \"//test/e2e/framework/providers/gce:go_default_library\",", "commid": "kubernetes_pr_89715"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcfa7bd39ff05f8f481c3621cc1f09ee2806ddcbff04ca803688eceda95fbb5e", "query": "What happened: In reviewing a test for promotion to conformance I noticed the kubelet API was being accessed via the API server's node proxy endpoint (ref: ). This seemed off, so I reviewed . It doesn't explicitly call out kubelet API access as allowed or disallowed. . and agreed kubelet API access seems like a bad idea. I'm now surveying what we have that does_ assume kubelet API access. It's definitely used by parts of e2e framework and some Conformance tests. I'm trying to verify how critical its use is. It appears that much of it is related to debugging or verifying whether kubelets and the control plane agree on who is running what. What you expected to happen: Find a blanket policy that bans kubelet API access for Conformance tests, whether directly, or indirectly through the API server's node proxy endpoint, at any time. Alternatively, find a policy that says kubelet API access may be allowed, but only for debugging or failure purposes (must not be on the critical path to make the test pass) Alternatively, find a policy that says kubelet API access is allowed, but only indirectly through the API server, and evaluated against the same constraints we use for control plane access (GA, non-optional) If we want to say kubelet API access is banned, we can use this as a tracking issue to demote whichever tests rely on it, and come up with a plan to verify the same behavior without kubelet API access. /area conformance /sig architecture /priority important-soon /milestone v1.16 /assign\nLook for anything that ends up calling calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test requires kubelet API access to pass may end up calling it if the test fails, via: Some Conformance tests may end up calling this if the test fails specifically Other areas this is used: only if the test fails required for a pre-stop hook test to pass required to make sure the readonly kubelet apis aren't exposed via api server proxy resource usage tracking tests require kubelet api access to pass tests call this in\nLooking for doesn't turn up any additional conformance tests, and I don't feel compelled to link the two other tests that use it as they are unlikely to ever be eligible.\nThe examples pointed out by on slack, the kubelet's endpoints is required to be available for these to pass\nHello! I'm the bug triage lead for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. The code freeze is starting on August 29th EOD PST (about 5 days from now) and once the code freeze starts, only release-blocking changes will be considered to be merged. Is this issue still planned to be fixed for the 1.16 release?\nare there further changes for this targeted at 1.16?\nAny update on this?\n/milestone v1.17\nBug Triage Release Team checking in. Code freeze for the 1.17 release is on November 14. Will this make it in? Thanks!\n/assign\nhi is this still targetting for 1.17 or can we move to 1.18? Code freeze is Nov 14th. thanks!\n/milestone v1.18\nSo we've updated the documented policy. My suggestion to close this out is to drop the [Conformance] tag from the tests that currently require the kubelet API to pass, and open issues that they need to be rewritten. Ignore whether the API is needed for diagnostic info in failure modes. SchedulerPredicates [Serial] calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test Pods should be submitted and removed [NodeConformance] requires kubelet API access to pass\ni'd support this ^^\nHello , Bug Triage team here for the 1.18 release. This is a friendly reminder that code freeze is scheduled for 5 March. Is this issue still intended for milestone 1.18?\nHello There's been no movement on this issue this year. Should this get pushed to the next milestone?\nyes, please John T Skarbek <:\n/milestone v1.19\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-8c6db7a01aebadc43034727366944bbfbe84e138f874f1db5aba2f6acb50568b", "text": "clientset \"k8s.io/client-go/kubernetes\" podutil \"k8s.io/kubernetes/pkg/api/v1/pod\" \"k8s.io/kubernetes/test/e2e/framework\" <del> e2ekubelet \"k8s.io/kubernetes/test/e2e/framework/kubelet\" </del> e2enode \"k8s.io/kubernetes/test/e2e/framework/node\" e2epod \"k8s.io/kubernetes/test/e2e/framework/pod\" e2erc \"k8s.io/kubernetes/test/e2e/framework/rc\"", "commid": "kubernetes_pr_89715"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcfa7bd39ff05f8f481c3621cc1f09ee2806ddcbff04ca803688eceda95fbb5e", "query": "What happened: In reviewing a test for promotion to conformance I noticed the kubelet API was being accessed via the API server's node proxy endpoint (ref: ). This seemed off, so I reviewed . It doesn't explicitly call out kubelet API access as allowed or disallowed. . and agreed kubelet API access seems like a bad idea. I'm now surveying what we have that does_ assume kubelet API access. It's definitely used by parts of e2e framework and some Conformance tests. I'm trying to verify how critical its use is. It appears that much of it is related to debugging or verifying whether kubelets and the control plane agree on who is running what. What you expected to happen: Find a blanket policy that bans kubelet API access for Conformance tests, whether directly, or indirectly through the API server's node proxy endpoint, at any time. Alternatively, find a policy that says kubelet API access may be allowed, but only for debugging or failure purposes (must not be on the critical path to make the test pass) Alternatively, find a policy that says kubelet API access is allowed, but only indirectly through the API server, and evaluated against the same constraints we use for control plane access (GA, non-optional) If we want to say kubelet API access is banned, we can use this as a tracking issue to demote whichever tests rely on it, and come up with a plan to verify the same behavior without kubelet API access. /area conformance /sig architecture /priority important-soon /milestone v1.16 /assign\nLook for anything that ends up calling calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test requires kubelet API access to pass may end up calling it if the test fails, via: Some Conformance tests may end up calling this if the test fails specifically Other areas this is used: only if the test fails required for a pre-stop hook test to pass required to make sure the readonly kubelet apis aren't exposed via api server proxy resource usage tracking tests require kubelet api access to pass tests call this in\nLooking for doesn't turn up any additional conformance tests, and I don't feel compelled to link the two other tests that use it as they are unlikely to ever be eligible.\nThe examples pointed out by on slack, the kubelet's endpoints is required to be available for these to pass\nHello! I'm the bug triage lead for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. The code freeze is starting on August 29th EOD PST (about 5 days from now) and once the code freeze starts, only release-blocking changes will be considered to be merged. Is this issue still planned to be fixed for the 1.16 release?\nare there further changes for this targeted at 1.16?\nAny update on this?\n/milestone v1.17\nBug Triage Release Team checking in. Code freeze for the 1.17 release is on November 14. Will this make it in? Thanks!\n/assign\nhi is this still targetting for 1.17 or can we move to 1.18? Code freeze is Nov 14th. thanks!\n/milestone v1.18\nSo we've updated the documented policy. My suggestion to close this out is to drop the [Conformance] tag from the tests that currently require the kubelet API to pass, and open issues that they need to be rewritten. Ignore whether the API is needed for diagnostic info in failure modes. SchedulerPredicates [Serial] calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test Pods should be submitted and removed [NodeConformance] requires kubelet API access to pass\ni'd support this ^^\nHello , Bug Triage team here for the 1.18 release. This is a friendly reminder that code freeze is scheduled for 5 March. Is this issue still intended for milestone 1.18?\nHello There's been no movement on this issue this year. Should this get pushed to the next milestone?\nyes, please John T Skarbek <:\n/milestone v1.19\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-27073f64cdc56dde473df22411206fa917d87e59f7cfbd224f6d9c332cb97a57", "text": "framework.ExpectNoError(err) for _, node := range nodeList.Items { <del> framework.Logf(\"nLogging pods the kubelet thinks is on node %v before test\", node.Name) printAllKubeletPods(cs, node.Name) </del> <ins> framework.Logf(\"nLogging pods the apiserver thinks is on node %v before test\", node.Name) printAllPodsOnNode(cs, node.Name) </ins> } })", "commid": "kubernetes_pr_89715"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dcfa7bd39ff05f8f481c3621cc1f09ee2806ddcbff04ca803688eceda95fbb5e", "query": "What happened: In reviewing a test for promotion to conformance I noticed the kubelet API was being accessed via the API server's node proxy endpoint (ref: ). This seemed off, so I reviewed . It doesn't explicitly call out kubelet API access as allowed or disallowed. . and agreed kubelet API access seems like a bad idea. I'm now surveying what we have that does_ assume kubelet API access. It's definitely used by parts of e2e framework and some Conformance tests. I'm trying to verify how critical its use is. It appears that much of it is related to debugging or verifying whether kubelets and the control plane agree on who is running what. What you expected to happen: Find a blanket policy that bans kubelet API access for Conformance tests, whether directly, or indirectly through the API server's node proxy endpoint, at any time. Alternatively, find a policy that says kubelet API access may be allowed, but only for debugging or failure purposes (must not be on the critical path to make the test pass) Alternatively, find a policy that says kubelet API access is allowed, but only indirectly through the API server, and evaluated against the same constraints we use for control plane access (GA, non-optional) If we want to say kubelet API access is banned, we can use this as a tracking issue to demote whichever tests rely on it, and come up with a plan to verify the same behavior without kubelet API access. /area conformance /sig architecture /priority important-soon /milestone v1.16 /assign\nLook for anything that ends up calling calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test requires kubelet API access to pass may end up calling it if the test fails, via: Some Conformance tests may end up calling this if the test fails specifically Other areas this is used: only if the test fails required for a pre-stop hook test to pass required to make sure the readonly kubelet apis aren't exposed via api server proxy resource usage tracking tests require kubelet api access to pass tests call this in\nLooking for doesn't turn up any additional conformance tests, and I don't feel compelled to link the two other tests that use it as they are unlikely to ever be eligible.\nThe examples pointed out by on slack, the kubelet's endpoints is required to be available for these to pass\nHello! I'm the bug triage lead for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. The code freeze is starting on August 29th EOD PST (about 5 days from now) and once the code freeze starts, only release-blocking changes will be considered to be merged. Is this issue still planned to be fixed for the 1.16 release?\nare there further changes for this targeted at 1.16?\nAny update on this?\n/milestone v1.17\nBug Triage Release Team checking in. Code freeze for the 1.17 release is on November 14. Will this make it in? Thanks!\n/assign\nhi is this still targetting for 1.17 or can we move to 1.18? Code freeze is Nov 14th. thanks!\n/milestone v1.18\nSo we've updated the documented policy. My suggestion to close this out is to drop the [Conformance] tag from the tests that currently require the kubelet API to pass, and open issues that they need to be rewritten. Ignore whether the API is needed for diagnostic info in failure modes. SchedulerPredicates [Serial] calls this in BeforeEach, which will happen before some Conformance tests (if this fails, the tests will fail) Conformance test Pods should be submitted and removed [NodeConformance] requires kubelet API access to pass\ni'd support this ^^\nHello , Bug Triage team here for the 1.18 release. This is a friendly reminder that code freeze is scheduled for 5 March. Is this issue still intended for milestone 1.18?\nHello There's been no movement on this issue this year. Should this get pushed to the next milestone?\nyes, please John T Skarbek <:\n/milestone v1.19\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-6b6b85d207d3c29a16d06b87ca27e5ac030bf7beecab3e8e2a259bc38bbae59b", "text": "}) }) <del> // printAllKubeletPods outputs status of all kubelet pods into log. func printAllKubeletPods(c clientset.Interface, nodeName string) { podList, err := e2ekubelet.GetKubeletPods(c, nodeName) </del> <ins> // printAllPodsOnNode outputs status of all kubelet pods into log. func printAllPodsOnNode(c clientset.Interface, nodeName string) { podList, err := c.CoreV1().Pods(metav1.NamespaceAll).List(context.TODO(), metav1.ListOptions{FieldSelector: \"spec.nodeName=\" + nodeName}) </ins> if err != nil { <del> framework.Logf(\"Unable to retrieve kubelet pods for node %v: %v\", nodeName, err) </del> <ins> framework.Logf(\"Unable to retrieve pods for node %v: %v\", nodeName, err) </ins> return } for _, p := range podList.Items {", "commid": "kubernetes_pr_89715"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c5612df6fc8150ff4e6c5aa45fb73dc64d52cd4a3c4604a56174a837d5c098a3", "query": "This issue was reported in the Description The container manager used in kubelet checks for docker daemon process either via pidfile or process name. While the pidfile points to the docker daemon process PID, the dockerProcessName constant stores a docker cli name (docker) instead of docker daemon name (dockerd). Figure 30.1: Constants in file. Recommendation Correct the docker process name to dockerd. Anything else we need to know?: See for current status of all issues created from these findings. The vendor gave this issue an ID of TOB-K8S-025 and it was finding 31 of the report. The vendor considers this issue Informational Severity. To view the original finding, begin on page 77 of the Environment: Kubernetes version: 1.13.4\n/sig node /kind bug /remove-kind feature\n/lgtm\nlol, this is the issue. my bad!", "positive_passages": [{"docid": "doc-en-kubernetes-223148f8829a9050c570356fcdca47c3c208e100d426d2ad6c341d34d235fec7", "text": ") const ( <del> dockerProcessName     = \"docker\" </del> <ins> dockerProcessName     = \"dockerd\" </ins> dockerPidFile         = \"/var/run/docker.pid\" containerdProcessName = \"docker-containerd\" containerdPidFile     = \"/run/docker/libcontainerd/docker-containerd.pid\"", "commid": "kubernetes_pr_81083"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-af2c92409aa3d43952a89129e5e1ec7b247d66b5bf6b0f901e05f1e1149218e9", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : The scale client () currently works fine with namespaced resources. However, it doesn't work for non-namespaced resources e.g. cluster-scoped CRDs. The current implementation should be extended in order to support non-namespaced resources. The current interface: /area custom-resources /sig autoscaling\nI think scale subresource support for CRDs falls more into sig-apimachinery domain. After DirectXMan12 moved on from sig-autoscaling I don't think there is anyone in our sig-autoscaling with knowledge of scale subresource internals. /sig api-machinery\n/assign\nThe bug report sounds legit. Does the generic scale client need to be changed (I think so), or does solve your issue?\nNo, the dashboard PR doesn't solve this. I discovered this issue while working on that PR so when gets merged, it will only work for namespaced CRDs. I think the generic scale client needs to be updated, maybe by adding another getter to the ScalesGetter interface: /kind bug\nPR:", "positive_passages": [{"docid": "doc-en-kubernetes-2f6ca3ee32b4f31119f96bad679aa789db5ffd5e5ce4bcace37ff58c66f1d3f7", "text": "result := c.client.clientBase.Get(). AbsPath(path). <del> Namespace(c.namespace). </del> <ins> NamespaceIfScoped(c.namespace, c.namespace != \"\"). </ins> Resource(gvr.Resource). Name(name). SubResource(\"scale\").", "commid": "kubernetes_pr_81507"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-af2c92409aa3d43952a89129e5e1ec7b247d66b5bf6b0f901e05f1e1149218e9", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : The scale client () currently works fine with namespaced resources. However, it doesn't work for non-namespaced resources e.g. cluster-scoped CRDs. The current implementation should be extended in order to support non-namespaced resources. The current interface: /area custom-resources /sig autoscaling\nI think scale subresource support for CRDs falls more into sig-apimachinery domain. After DirectXMan12 moved on from sig-autoscaling I don't think there is anyone in our sig-autoscaling with knowledge of scale subresource internals. /sig api-machinery\n/assign\nThe bug report sounds legit. Does the generic scale client need to be changed (I think so), or does solve your issue?\nNo, the dashboard PR doesn't solve this. I discovered this issue while working on that PR so when gets merged, it will only work for namespaced CRDs. I think the generic scale client needs to be updated, maybe by adding another getter to the ScalesGetter interface: /kind bug\nPR:", "positive_passages": [{"docid": "doc-en-kubernetes-67b71e496c5b99b911220ec5aa173fdafd20e31acff4461b186b750c145a1504", "text": "result := c.client.clientBase.Put(). AbsPath(path). <del> Namespace(c.namespace). </del> <ins> NamespaceIfScoped(c.namespace, c.namespace != \"\"). </ins> Resource(gvr.Resource). Name(scale.Name). SubResource(\"scale\").", "commid": "kubernetes_pr_81507"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-af2c92409aa3d43952a89129e5e1ec7b247d66b5bf6b0f901e05f1e1149218e9", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : The scale client () currently works fine with namespaced resources. However, it doesn't work for non-namespaced resources e.g. cluster-scoped CRDs. The current implementation should be extended in order to support non-namespaced resources. The current interface: /area custom-resources /sig autoscaling\nI think scale subresource support for CRDs falls more into sig-apimachinery domain. After DirectXMan12 moved on from sig-autoscaling I don't think there is anyone in our sig-autoscaling with knowledge of scale subresource internals. /sig api-machinery\n/assign\nThe bug report sounds legit. Does the generic scale client need to be changed (I think so), or does solve your issue?\nNo, the dashboard PR doesn't solve this. I discovered this issue while working on that PR so when gets merged, it will only work for namespaced CRDs. I think the generic scale client needs to be updated, maybe by adding another getter to the ScalesGetter interface: /kind bug\nPR:", "positive_passages": [{"docid": "doc-en-kubernetes-ef1ab425471dbd7efd689f8c7f7c063ee4c2f3d1fa28a7ef8c1b4b9d1e8cb519", "text": "groupVersion := gvr.GroupVersion() result := c.client.clientBase.Patch(pt). AbsPath(c.client.apiPathFor(groupVersion)). <del> Namespace(c.namespace). </del> <ins> NamespaceIfScoped(c.namespace, c.namespace != \"\"). </ins> Resource(gvr.Resource). Name(name). SubResource(\"scale\").", "commid": "kubernetes_pr_81507"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-af2c92409aa3d43952a89129e5e1ec7b247d66b5bf6b0f901e05f1e1149218e9", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : The scale client () currently works fine with namespaced resources. However, it doesn't work for non-namespaced resources e.g. cluster-scoped CRDs. The current implementation should be extended in order to support non-namespaced resources. The current interface: /area custom-resources /sig autoscaling\nI think scale subresource support for CRDs falls more into sig-apimachinery domain. After DirectXMan12 moved on from sig-autoscaling I don't think there is anyone in our sig-autoscaling with knowledge of scale subresource internals. /sig api-machinery\n/assign\nThe bug report sounds legit. Does the generic scale client need to be changed (I think so), or does solve your issue?\nNo, the dashboard PR doesn't solve this. I discovered this issue while working on that PR so when gets merged, it will only work for namespaced CRDs. I think the generic scale client needs to be updated, maybe by adding another getter to the ScalesGetter interface: /kind bug\nPR:", "positive_passages": [{"docid": "doc-en-kubernetes-f727f46b58c8f33260668ef9ce374816b504cc56fc8d8079f08eee1c290faa31", "text": ") // ScalesGetter can produce a ScaleInterface <del> // for a particular namespace. </del> type ScalesGetter interface { <ins> // Scales produces a ScaleInterface for a particular namespace. // Set namespace to the empty string for non-namespaced resources. </ins> Scales(namespace string) ScaleInterface }", "commid": "kubernetes_pr_81507"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a8f763c740d3fb11e6b67f36722750f0a39e674fe923e77cebdc2dd4df02a0e7", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: ci-kubernetes-e2e-gci-gce-alpha-enabled-default Which test(s) are failing: CSI hostpath-v0 tests Since when has it been failing: 8/8 Testgrid link: https://k8s- Reason for failure: Anything else we need to know: We need to update client-go to get the fix for selfLink, build new nfs provisioner images, and update them in the e2e test. The fix for client-go is being cherry-picked to 1.15 if you want to use a tagged release:\n/assign\n/assign\nThis implies rebase to 1.15.x in external-storage, which seem to be challenging (at least to me :-) )\n14 cherry pick also in progress:\nOK, I guess this line in the lib is the culprit: So I need to update lib then external-storage to pull it in\nI don't think the lib itself needs to be updated. Only updating go-client to get the fix to is needed.\nRight, lib doesn't dictate what version of client-go to use. Will wait for client-go release/commit\n- thanks a lot for bumping the dependency. Did you have a chance to build the new container with it so that we could update it here:\nyeah, opened . (Not sure how to trigger test, or we can just merge and see.)\nYou can manually create a PVC on an alpha cluster to test.", "positive_passages": [{"docid": "doc-en-kubernetes-da53197942f8e1d3aa406e4ec8e05b4e57562dedfc18b94f1c6fee7b996faa74", "text": "Containers: []v1.Container{ { Name:  \"nfs-provisioner\", <del> Image: \"quay.io/kubernetes_incubator/nfs-provisioner:v2.2.0-k8s1.12\", </del> <ins> Image: \"quay.io/kubernetes_incubator/nfs-provisioner:v2.2.2\", </ins> SecurityContext: &v1.SecurityContext{ Capabilities: &v1.Capabilities{ Add: []v1.Capability{\"DAC_READ_SEARCH\"},", "commid": "kubernetes_pr_81620"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-36ab61066741b9409307c7a95f47ca9d3b5b7f4d54f14d141fffedbc5c4e7548", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Add a sort parameter (or similar concept) to the command. Why is this needed: With the numerous amount of API resources (not counting custom ones), it is sometimes difficult locating them in the output. By default, API resources are not sorted by the name column (the first on the left) and often this is the column holding the information one wishes to query. A sort parameter would help more easily identify the object to be understood.\n/sig usability", "positive_passages": [{"docid": "doc-en-kubernetes-de6a983284ca21c3857998246dbeb8dc1511dd2bfa3517570f26435b49b00c7d", "text": "# Print the supported API Resources with more information kubectl api-resources -o wide <ins> # Print the supported API Resources sorted by a column kubectl api-resources --sort-by=name </ins> # Print the supported namespaced resources kubectl api-resources --namespaced=true", "commid": "kubernetes_pr_81971"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-36ab61066741b9409307c7a95f47ca9d3b5b7f4d54f14d141fffedbc5c4e7548", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Add a sort parameter (or similar concept) to the command. Why is this needed: With the numerous amount of API resources (not counting custom ones), it is sometimes difficult locating them in the output. By default, API resources are not sorted by the name column (the first on the left) and often this is the column holding the information one wishes to query. A sort parameter would help more easily identify the object to be understood.\n/sig usability", "positive_passages": [{"docid": "doc-en-kubernetes-23079a0d960b329ff93e08a12e595e91fe957458555e25c53d368f19a9cd8199", "text": "// As new fields are added, add them here instead of referencing the cmd.Flags() type APIResourceOptions struct { Output     string <ins> SortBy     string </ins> APIGroup   string Namespaced bool Verbs      []string", "commid": "kubernetes_pr_81971"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-36ab61066741b9409307c7a95f47ca9d3b5b7f4d54f14d141fffedbc5c4e7548", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Add a sort parameter (or similar concept) to the command. Why is this needed: With the numerous amount of API resources (not counting custom ones), it is sometimes difficult locating them in the output. By default, API resources are not sorted by the name column (the first on the left) and often this is the column holding the information one wishes to query. A sort parameter would help more easily identify the object to be understood.\n/sig usability", "positive_passages": [{"docid": "doc-en-kubernetes-ed6cff1b472171be0a7869d6243f4a9382b45ae145cf7c634e0241df0dceb5ab", "text": "cmd.Flags().StringVar(&o.APIGroup, \"api-group\", o.APIGroup, \"Limit to resources in the specified API group.\") cmd.Flags().BoolVar(&o.Namespaced, \"namespaced\", o.Namespaced, \"If false, non-namespaced resources will be returned, otherwise returning namespaced resources by default.\") cmd.Flags().StringSliceVar(&o.Verbs, \"verbs\", o.Verbs, \"Limit to resources that support the specified verbs.\") <ins> cmd.Flags().StringVar(&o.SortBy, \"sort-by\", o.SortBy, \"If non-empty, sort nodes list using specified field. The field can be either 'name' or 'kind'.\") </ins> cmd.Flags().BoolVar(&o.Cached, \"cached\", o.Cached, \"Use the cached list of resources if available.\") return cmd }", "commid": "kubernetes_pr_81971"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-36ab61066741b9409307c7a95f47ca9d3b5b7f4d54f14d141fffedbc5c4e7548", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Add a sort parameter (or similar concept) to the command. Why is this needed: With the numerous amount of API resources (not counting custom ones), it is sometimes difficult locating them in the output. By default, API resources are not sorted by the name column (the first on the left) and often this is the column holding the information one wishes to query. A sort parameter would help more easily identify the object to be understood.\n/sig usability", "positive_passages": [{"docid": "doc-en-kubernetes-9738223e353c36ea9c88e585693671ab37857ce8a8db3063c57a74744237d6ad", "text": "if !supportedOutputTypes.Has(o.Output) { return fmt.Errorf(\"--output %v is not available\", o.Output) } <ins> supportedSortTypes := sets.NewString(\"\", \"name\", \"kind\") if len(o.SortBy) > 0 { if !supportedSortTypes.Has(o.SortBy) { return fmt.Errorf(\"--sort-by accepts only name or kind\") } } </ins> return nil }", "commid": "kubernetes_pr_81971"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-36ab61066741b9409307c7a95f47ca9d3b5b7f4d54f14d141fffedbc5c4e7548", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Add a sort parameter (or similar concept) to the command. Why is this needed: With the numerous amount of API resources (not counting custom ones), it is sometimes difficult locating them in the output. By default, API resources are not sorted by the name column (the first on the left) and often this is the column holding the information one wishes to query. A sort parameter would help more easily identify the object to be understood.\n/sig usability", "positive_passages": [{"docid": "doc-en-kubernetes-501720d154d1297c03a5518f84bbfb564baba0f1e5f667c0fc3ff3e9d53c8e94", "text": "} } <del> sort.Stable(sortableGroupResource(resources)) </del> <ins> sort.Stable(sortableResource{resources, o.SortBy}) </ins> for _, r := range resources { switch o.Output { case \"name\":", "commid": "kubernetes_pr_81971"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-36ab61066741b9409307c7a95f47ca9d3b5b7f4d54f14d141fffedbc5c4e7548", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Add a sort parameter (or similar concept) to the command. Why is this needed: With the numerous amount of API resources (not counting custom ones), it is sometimes difficult locating them in the output. By default, API resources are not sorted by the name column (the first on the left) and often this is the column holding the information one wishes to query. A sort parameter would help more easily identify the object to be understood.\n/sig usability", "positive_passages": [{"docid": "doc-en-kubernetes-df497ea4eb12cc0f35f6113a363f1a949e1138f5035dd9e40e070f0de9bd699d", "text": "return err } <del> type sortableGroupResource []groupResource </del> <ins> type sortableResource struct { resources []groupResource sortBy    string } </ins> <del> func (s sortableGroupResource) Len() int      { return len(s) } func (s sortableGroupResource) Swap(i, j int) { s[i], s[j] = s[j], s[i] } func (s sortableGroupResource) Less(i, j int) bool { ret := strings.Compare(s[i].APIGroup, s[j].APIGroup) </del> <ins> func (s sortableResource) Len() int { return len(s.resources) } func (s sortableResource) Swap(i, j int) { s.resources[i], s.resources[j] = s.resources[j], s.resources[i] } func (s sortableResource) Less(i, j int) bool { ret := strings.Compare(s.compareValues(i, j)) </ins> if ret > 0 { return false } else if ret == 0 { <del> return strings.Compare(s[i].APIResource.Name, s[j].APIResource.Name) < 0 </del> <ins> return strings.Compare(s.resources[i].APIResource.Name, s.resources[j].APIResource.Name) < 0 </ins> } return true } <ins> func (s sortableResource) compareValues(i, j int) (string, string) { switch s.sortBy { case \"name\": return s.resources[i].APIResource.Name, s.resources[j].APIResource.Name case \"kind\": return s.resources[i].APIResource.Kind, s.resources[j].APIResource.Kind } return s.resources[i].APIGroup, s.resources[j].APIGroup } </ins>", "commid": "kubernetes_pr_81971"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-02830743648dba6d35b2a5372ac09c56b9865c74b55a0ac8ad4b1c83d339c9c0", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: ci-kubernetes-node-kubelet-orphans Which test(s) are failing: [sig-storage] EmptyDir volumes [It] pod should support shared volumes between containers [Conformance] Since when has it been failing: Testgrid link: Reason for failure: Anything else we need to know:\nplease don't CC sig-testing on every test failure :( we own the infrastructure etc. the sig-storage owns these tests.", "positive_passages": [{"docid": "doc-en-kubernetes-a2355c65d4b3b0f45ea0b0766ff77c39c46ad975400f4448afa00af51b2e0914", "text": "import ( \"fmt\" \"path\" <del> \"time\" </del> \"github.com/onsi/ginkgo\" <del> \"k8s.io/api/core/v1\" </del> <ins> v1 \"k8s.io/api/core/v1\" </ins> metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/util/uuid\" \"k8s.io/kubernetes/test/e2e/framework\"", "commid": "kubernetes_pr_82812"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-02830743648dba6d35b2a5372ac09c56b9865c74b55a0ac8ad4b1c83d339c9c0", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: ci-kubernetes-node-kubelet-orphans Which test(s) are failing: [sig-storage] EmptyDir volumes [It] pod should support shared volumes between containers [Conformance] Since when has it been failing: Testgrid link: Reason for failure: Anything else we need to know:\nplease don't CC sig-testing on every test failure :( we own the infrastructure etc. the sig-storage owns these tests.", "positive_passages": [{"docid": "doc-en-kubernetes-ca25ca0ec56892838190e3fa62c05bd5ffaa3fea4a2c31b681f8b3e6ac72c273", "text": "framework.ExpectNoError(err, \"failed to get pod %s\", pod.Name) ginkgo.By(\"Reading file content from the nginx-container\") <del> resultString, err = framework.LookForStringInFile(f.Namespace.Name, pod.Name, busyBoxMainContainerName, busyBoxMainVolumeFilePath, message, 30*time.Second) framework.ExpectNoError(err, \"failed to match expected string %s with %s\", message, resultString) </del> <ins> result := f.ExecShellInContainer(pod.Name, busyBoxMainContainerName, fmt.Sprintf(\"cat %s\", busyBoxMainVolumeFilePath)) framework.ExpectEqual(result, message, \"failed to match expected string %s with %s\", message, resultString) </ins> }) })", "commid": "kubernetes_pr_82812"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-49dfc85fc8498e0db279cbaabc579f0a0b63f738c4ccea222e5a413fa241b959", "query": "What happened: There's a typo typo in and What you expected to happen: \u201cdepreciated\u201d should be \u201cdeprecated\u201d. How to reproduce it (as minimally and precisely as possible): View the release notes Anything else we need to know?: /lifecycle active I have a PR to fix this /sig docs Environment: Kubernetes version (use ): v1.16 Cloud provider or hardware configuration: not applicable OS (e.g: ): not applicable Kernel (e.g. ): not applicable Install tools: not applicable", "positive_passages": [{"docid": "doc-en-kubernetes-6269d544de6cc10dac81751d18279f9bcc8aab2e8788e78a754268e0ccf49ec1", "text": "- [Metrics Changes](#metrics-changes) - [Added metrics](#added-metrics) - [Removed metrics](#removed-metrics) <del> - [Depreciated/changed metrics](#depreciatedchanged-metrics) </del> <ins> - [Deprecated/changed metrics](#deprecatedchanged-metrics) </ins> - [Notable Features](#notable-features) - [Beta](#beta) - [Alpha](#alpha)", "commid": "kubernetes_pr_82867"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-49dfc85fc8498e0db279cbaabc579f0a0b63f738c4ccea222e5a413fa241b959", "query": "What happened: There's a typo typo in and What you expected to happen: \u201cdepreciated\u201d should be \u201cdeprecated\u201d. How to reproduce it (as minimally and precisely as possible): View the release notes Anything else we need to know?: /lifecycle active I have a PR to fix this /sig docs Environment: Kubernetes version (use ): v1.16 Cloud provider or hardware configuration: not applicable OS (e.g: ): not applicable Kernel (e.g. ): not applicable Install tools: not applicable", "positive_passages": [{"docid": "doc-en-kubernetes-9a0b96ebb0144138b512c972906f53e88688c4c372ce2b5e0bc138d3c7015d83", "text": "- Removed cadvisor metric labels `pod_name` and `container_name` to match instrumentation guidelines. Any Prometheus queries that match `pod_name` and `container_name` labels (e.g. cadvisor or kubelet probe metrics) must be updated to use `pod` and `container` instead. ([#80376](https://github.com/kubernetes/kubernetes/pull/80376), [@ehashman](https://github.com/ehashman)) <del> ### Depreciated/changed metrics </del> <ins> ### Deprecated/changed metrics </ins> - kube-controller-manager and cloud-controller-manager metrics are now marked as with the ALPHA stability level. ([#81624](https://github.com/kubernetes/kubernetes/pull/81624), [@logicalhan](https://github.com/logicalhan)) - kube-proxy metrics are now marked as with the ALPHA stability level. ([#81626](https://github.com/kubernetes/kubernetes/pull/81626), [@logicalhan](https://github.com/logicalhan))", "commid": "kubernetes_pr_82867"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99cf00288bb2f26fdcbec632d47295247bf238cc0435db3bc55f75aa0f1ddc53", "query": "What would you like to be : Currently the apiserver has request latencies metrics, which are a histogram of requests to the apiserver. However, these request metrics do not include healthz. While we have recently the ability to get back health check metrics from the healthz endpoint directly, we should also emit this data as a metric, so that we can monitor health check latencies. /assign /sig api-machinery instrumentation\nGitHub didn't allow me to assign the following users: jktomer. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : What would you like to be : /sig api-machinery instrumentation Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI noticed this is informally assigned. Has there been any progress? Is this a place I can fit in?\nYes, I'm working on a PR.\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-6d4b8fac3241b8f0a5a599f2b25836cc8066f8b89525c1213365f6e86bc82891", "text": "embed = [\":go_default_library\"], deps = [ \"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library\", <ins> \"//staging/src/k8s.io/apiserver/pkg/endpoints/metrics:go_default_library\", \"//staging/src/k8s.io/component-base/metrics/legacyregistry:go_default_library\", \"//staging/src/k8s.io/component-base/metrics/testutil:go_default_library\", </ins> ], )", "commid": "kubernetes_pr_83598"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99cf00288bb2f26fdcbec632d47295247bf238cc0435db3bc55f75aa0f1ddc53", "query": "What would you like to be : Currently the apiserver has request latencies metrics, which are a histogram of requests to the apiserver. However, these request metrics do not include healthz. While we have recently the ability to get back health check metrics from the healthz endpoint directly, we should also emit this data as a metric, so that we can monitor health check latencies. /assign /sig api-machinery instrumentation\nGitHub didn't allow me to assign the following users: jktomer. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : What would you like to be : /sig api-machinery instrumentation Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI noticed this is informally assigned. Has there been any progress? Is this a place I can fit in?\nYes, I'm working on a PR.\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-45114805302a162ed45756b78d6af76d8f4e24b96350f86fd5495c0d7e20ead9", "text": "deps = [ \"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library\", <ins> \"//staging/src/k8s.io/apiserver/pkg/endpoints/metrics:go_default_library\", </ins> \"//staging/src/k8s.io/apiserver/pkg/server/httplog:go_default_library\", \"//vendor/k8s.io/klog:go_default_library\", ],", "commid": "kubernetes_pr_83598"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99cf00288bb2f26fdcbec632d47295247bf238cc0435db3bc55f75aa0f1ddc53", "query": "What would you like to be : Currently the apiserver has request latencies metrics, which are a histogram of requests to the apiserver. However, these request metrics do not include healthz. While we have recently the ability to get back health check metrics from the healthz endpoint directly, we should also emit this data as a metric, so that we can monitor health check latencies. /assign /sig api-machinery instrumentation\nGitHub didn't allow me to assign the following users: jktomer. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : What would you like to be : /sig api-machinery instrumentation Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI noticed this is informally assigned. Has there been any progress? Is this a place I can fit in?\nYes, I'm working on a PR.\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-c485fd806bea4e9814a0c49b01a1951237e239b0bad447731e299d024a2b6e7f", "text": "\"k8s.io/apimachinery/pkg/util/sets\" \"k8s.io/apimachinery/pkg/util/wait\" <ins> \"k8s.io/apiserver/pkg/endpoints/metrics\" </ins> \"k8s.io/apiserver/pkg/server/httplog\" \"k8s.io/klog\" )", "commid": "kubernetes_pr_83598"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99cf00288bb2f26fdcbec632d47295247bf238cc0435db3bc55f75aa0f1ddc53", "query": "What would you like to be : Currently the apiserver has request latencies metrics, which are a histogram of requests to the apiserver. However, these request metrics do not include healthz. While we have recently the ability to get back health check metrics from the healthz endpoint directly, we should also emit this data as a metric, so that we can monitor health check latencies. /assign /sig api-machinery instrumentation\nGitHub didn't allow me to assign the following users: jktomer. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : What would you like to be : /sig api-machinery instrumentation Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI noticed this is informally assigned. Has there been any progress? Is this a place I can fit in?\nYes, I'm working on a PR.\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-69cde6a70cbe6cff70ed51d4439584a01a5330de7ac1639e3c044610e2f36d25", "text": "klog.V(5).Infof(\"Installing health checkers for (%v): %v\", path, formatQuoted(checkerNames(checks...)...)) <del> mux.Handle(path, handleRootHealthz(checks...)) </del> <ins> mux.Handle(path, metrics.InstrumentHandlerFunc(\"GET\", /* group = */ \"\", /* version = */ \"\", /* resource = */ \"\", /* subresource = */ path, /* scope = */ \"\", /* component = */ \"\", handleRootHealthz(checks...))) </ins> for _, check := range checks { mux.Handle(fmt.Sprintf(\"%s/%v\", path, check.Name()), adaptCheckToHandler(check.Check)) }", "commid": "kubernetes_pr_83598"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99cf00288bb2f26fdcbec632d47295247bf238cc0435db3bc55f75aa0f1ddc53", "query": "What would you like to be : Currently the apiserver has request latencies metrics, which are a histogram of requests to the apiserver. However, these request metrics do not include healthz. While we have recently the ability to get back health check metrics from the healthz endpoint directly, we should also emit this data as a metric, so that we can monitor health check latencies. /assign /sig api-machinery instrumentation\nGitHub didn't allow me to assign the following users: jktomer. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : What would you like to be : /sig api-machinery instrumentation Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI noticed this is informally assigned. Has there been any progress? Is this a place I can fit in?\nYes, I'm working on a PR.\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-fc77ba563ad84f6f588971abcd7e73d0631ff948013e4ab91e84dd81e0a6f920", "text": "\"net/http/httptest\" \"net/url\" \"reflect\" <ins> \"strings\" </ins> \"testing\" \"k8s.io/apimachinery/pkg/util/sets\" <ins> \"k8s.io/apiserver/pkg/endpoints/metrics\" \"k8s.io/component-base/metrics/legacyregistry\" \"k8s.io/component-base/metrics/testutil\" </ins> ) func TestInstallHandler(t *testing.T) {", "commid": "kubernetes_pr_83598"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99cf00288bb2f26fdcbec632d47295247bf238cc0435db3bc55f75aa0f1ddc53", "query": "What would you like to be : Currently the apiserver has request latencies metrics, which are a histogram of requests to the apiserver. However, these request metrics do not include healthz. While we have recently the ability to get back health check metrics from the healthz endpoint directly, we should also emit this data as a metric, so that we can monitor health check latencies. /assign /sig api-machinery instrumentation\nGitHub didn't allow me to assign the following users: jktomer. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : What would you like to be : /sig api-machinery instrumentation Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI noticed this is informally assigned. Has there been any progress? Is this a place I can fit in?\nYes, I'm working on a PR.\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-7d659a7870c402c05aeb8187f442d7e5aa862ac06f08b9804b5b453aff606ef1", "text": "} } <ins> func TestMetrics(t *testing.T) { mux := http.NewServeMux() InstallHandler(mux) InstallLivezHandler(mux) InstallReadyzHandler(mux) metrics.Register() metrics.Reset() paths := []string{\"/healthz\", \"/livez\", \"/readyz\"} for _, path := range paths { req, err := http.NewRequest(\"GET\", fmt.Sprintf(\"http://example.com%s\", path), nil) if err != nil { t.Errorf(\"%v\", err) } mux.ServeHTTP(httptest.NewRecorder(), req) } expected := strings.NewReader(` # HELP apiserver_request_total [ALPHA] Counter of apiserver requests broken out for each verb, dry run value, group, version, resource, scope, component, client, and HTTP response contentType and code. # TYPE apiserver_request_total counter apiserver_request_total{client=\"unknown\",code=\"200\",component=\"\",contentType=\"text/plain; charset=utf-8\",dry_run=\"\",group=\"\",resource=\"\",scope=\"\",subresource=\"/healthz\",verb=\"GET\",version=\"\"} 1 apiserver_request_total{client=\"unknown\",code=\"200\",component=\"\",contentType=\"text/plain; charset=utf-8\",dry_run=\"\",group=\"\",resource=\"\",scope=\"\",subresource=\"/livez\",verb=\"GET\",version=\"\"} 1 apiserver_request_total{client=\"unknown\",code=\"200\",component=\"\",contentType=\"text/plain; charset=utf-8\",dry_run=\"\",group=\"\",resource=\"\",scope=\"\",subresource=\"/readyz\",verb=\"GET\",version=\"\"} 1 `) if err := testutil.GatherAndCompare(legacyregistry.DefaultGatherer, expected, \"apiserver_request_total\"); err != nil { t.Error(err) } } </ins> func createGetRequestWithUrl(rawUrlString string) *http.Request { url, _ := url.Parse(rawUrlString) return &http.Request{", "commid": "kubernetes_pr_83598"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0a2762540f2b531dffff6c46a9c4e32e93e7219960664c0ebd76521a168b5c1a", "query": "What happened: Provisioning of a volume with failed and this event were created on a pod: The event does not say anything useful and only confuses users. What you expected to happen: Either no event (event on PVC about failed provisioning could be enough) or something generic about \"waiting for provisioning to finish\". How to reproduce it (as minimally and precisely as possible): Tested on AWS. It should be the same with GCE and other block-based in-tree volumes. StorageClass with PVC requesting RWX (so provisioning fails): pod that uses the PVC. Pod events: Anything else we need to know?: I've been able to track down what happens: Scheduler adds to the PVC Provisioner tries to create a volume for the PVC and fails. The annotation is removed in  The scheduler expects that the annotation exists here: I am not sure how to fix it though. Ignoring the error might be the easiest thing to do. Environment: Kubernetes version (use ): today's master /sig storage /sig scheduling /assign\nyes, the error message is confusing. \"FailedScheduling\" event will be emitted if the scheduler failed to schedule the pod. How about wrapping the internal error message in function, e.g. ? Users will know the pod failed because pod volumes not bound successfully. Sometimes, users can't just wait for the scheduler to recover from the error state, manual intervention might be required. The internal reason will be useful. In this scenario, .\n's suggestion sounds good to me", "positive_passages": [{"docid": "doc-en-kubernetes-670b673ef85999f2ba7f5e05ac69cdacf3dbe8e315ff89c46dffc4836fd0bf09", "text": "return err } <del> return wait.Poll(time.Second, b.bindTimeout, func() (bool, error) { </del> <ins> err = wait.Poll(time.Second, b.bindTimeout, func() (bool, error) { </ins> b, err := b.checkBindings(assumedPod, bindings, claimsToProvision) return b, err }) <ins> if err != nil { pvcName := \"\" if len(claimsToProvision) > 0 { pvcName = claimsToProvision[0].Name } return fmt.Errorf(\"Failed to bind volumes: provisioning failed for PVC %q: %v\", pvcName, err) } return nil </ins> } func getPodName(pod *v1.Pod) string {", "commid": "kubernetes_pr_83343"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a42868a9b37565bd02ba94bbf4c6ffa3c24eec324dcbcc175becdaa7054bb2f9", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: The kubelet metrics related to , except for one, are missing from the kubelet metric endpoint. This applies to these metrics: What you expected to happen: I expect that the metrics mentioned above should be found in the endpoint on the kubelet. How to reproduce it (as minimally and precisely as possible): Run kubelet with a valid , and (defaults to true). or run the node e2e tests: Anything else we need to know?: All e2e tests related to DynamicKubeletConfig fails in master (and in v1.16): This bug/error was introduced in Environment: Kubernetes version (use ): && Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node /cc logicalhan tallclair mtaufen\n/cc\n/assign WIP proof of concept solution to fix (make it a bit easier to understand the problem) here:\n/assign\nedit: I misunderstood the issue. discussed with offline, and he has an idea to restore previous behavior\nThat sounds perfect! He answered in the PR, so hopefully we can get this working again. I have wrapped my head around this issue for quite a few hours now, so I understand that it is kinda hard to understand by just reading this issue. Here is some more background info that hopefully makes sense.\n/priority important-soon /milestone v1.17\nLooks like the CI jobs are cleaning up now! ! Finally down to single digit number test failures, and away from the 30+ :smile:", "positive_passages": [{"docid": "doc-en-kubernetes-5d5563484c7f345d3e867772fe5336b8c26db5a760b0e59335ae2a48c719ca88", "text": "} } <del> // If the kubelet config controller is available, and dynamic config is enabled, start the config and status sync loops if utilfeature.DefaultFeatureGate.Enabled(features.DynamicKubeletConfig) && len(s.DynamicConfigDir.Value()) > 0 && kubeDeps.KubeletConfigController != nil && !standaloneMode && !s.RunOnce { if err := kubeDeps.KubeletConfigController.StartSync(kubeDeps.KubeClient, kubeDeps.EventClient, string(nodeName)); err != nil { return err } } </del> if kubeDeps.Auth == nil { auth, err := BuildAuth(nodeName, kubeDeps.KubeClient, s.KubeletConfiguration) if err != nil {", "commid": "kubernetes_pr_83184"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a42868a9b37565bd02ba94bbf4c6ffa3c24eec324dcbcc175becdaa7054bb2f9", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: The kubelet metrics related to , except for one, are missing from the kubelet metric endpoint. This applies to these metrics: What you expected to happen: I expect that the metrics mentioned above should be found in the endpoint on the kubelet. How to reproduce it (as minimally and precisely as possible): Run kubelet with a valid , and (defaults to true). or run the node e2e tests: Anything else we need to know?: All e2e tests related to DynamicKubeletConfig fails in master (and in v1.16): This bug/error was introduced in Environment: Kubernetes version (use ): && Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node /cc logicalhan tallclair mtaufen\n/cc\n/assign WIP proof of concept solution to fix (make it a bit easier to understand the problem) here:\n/assign\nedit: I misunderstood the issue. discussed with offline, and he has an idea to restore previous behavior\nThat sounds perfect! He answered in the PR, so hopefully we can get this working again. I have wrapped my head around this issue for quite a few hours now, so I understand that it is kinda hard to understand by just reading this issue. Here is some more background info that hopefully makes sense.\n/priority important-soon /milestone v1.17\nLooks like the CI jobs are cleaning up now! ! Finally down to single digit number test failures, and away from the 30+ :smile:", "positive_passages": [{"docid": "doc-en-kubernetes-4ec5eeb72e899bfc3aa2b3a65ec438a4af4716c5ff6d5c0a9b8f73149aff7efa", "text": "return err } <ins> // If the kubelet config controller is available, and dynamic config is enabled, start the config and status sync loops if utilfeature.DefaultFeatureGate.Enabled(features.DynamicKubeletConfig) && len(s.DynamicConfigDir.Value()) > 0 && kubeDeps.KubeletConfigController != nil && !standaloneMode && !s.RunOnce { if err := kubeDeps.KubeletConfigController.StartSync(kubeDeps.KubeClient, kubeDeps.EventClient, string(nodeName)); err != nil { return err } } </ins> if s.HealthzPort > 0 { mux := http.NewServeMux() healthz.InstallHandler(mux)", "commid": "kubernetes_pr_83184"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-747d699b97976a530bdb275e803e2be1bb68ac7168a6ff8b59806b000dbdf33f", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Change scheduler metric from Gauge to Histogram Why is this needed: is recorded for each preemption attempt. A histogram is better. /sig scheduling /help /good-first-issue\n/help /good-first-issue\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI can work on this issue.\n/assign\nI could work on this as well if doesn't have time to work on this.\nI am working on it, I will create the initial PR in less than a week. Sorry for the delay.", "positive_passages": [{"docid": "doc-en-kubernetes-79bcc461bc8d80201179cb07876ba1d6533924ce2fc4644ea6cb250d6c006bdc", "text": "StabilityLevel: metrics.ALPHA, }, ) <del> PreemptionVictims = metrics.NewGauge( &metrics.GaugeOpts{ Subsystem:      SchedulerSubsystem, Name:           \"pod_preemption_victims\", Help:           \"Number of selected preemption victims\", </del> <ins> PreemptionVictims = metrics.NewHistogram( &metrics.HistogramOpts{ Subsystem: SchedulerSubsystem, Name:      \"pod_preemption_victims\", Help:      \"Number of selected preemption victims\", // we think #victims>50 is pretty rare, therefore [50, +Inf) is considered a single bucket. Buckets:        metrics.LinearBuckets(5, 5, 10), </ins> StabilityLevel: metrics.ALPHA, }) PreemptionAttempts = metrics.NewCounter(", "commid": "kubernetes_pr_83603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-747d699b97976a530bdb275e803e2be1bb68ac7168a6ff8b59806b000dbdf33f", "query": "<!-- Please only use this template for submitting enhancement requests --What would you like to be : Change scheduler metric from Gauge to Histogram Why is this needed: is recorded for each preemption attempt. A histogram is better. /sig scheduling /help /good-first-issue\n/help /good-first-issue\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI can work on this issue.\n/assign\nI could work on this as well if doesn't have time to work on this.\nI am working on it, I will create the initial PR in less than a week. Sorry for the delay.", "positive_passages": [{"docid": "doc-en-kubernetes-446c0fe158a7ca6d4ebe84bb45be7b738d139e3cf5ad857da2ed3f68f90812c3", "text": "sched.Recorder.Eventf(victim, preemptor, v1.EventTypeNormal, \"Preempted\", \"Preempting\", \"Preempted by %v/%v on node %v\", preemptor.Namespace, preemptor.Name, nodeName) } <del> metrics.PreemptionVictims.Set(float64(len(victims))) </del> <ins> metrics.PreemptionVictims.Observe(float64(len(victims))) </ins> } // Clearing nominated pods should happen outside of \"if node != nil\". Node could // be nil when a pod with nominated node name is eligible to preempt again,", "commid": "kubernetes_pr_83603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f44ef0bcf2f9c8d0399d4efb9b080a7dd533e835c60e6b9400ac5a442e4901db", "query": "Currently custom predicate and priorities can be created through the . The problem is that a custom predicate/priority, like ServiceAffinity, can be multiple times in the Policy with different names, possibly with different arguments. This semantic (i.e., specifying multiple instances of the same custom predicate with different arguments) is only useful if different s were specified because in all cases of custom predicates/priorities the arguments are merge-able (for example, from multiple CheckServiceAffinity custom predicates can be merged into one set). In the world of framework plugins, we don't currently have a way to maintain those semantics. to run. The question here: do we really want to maintain the old semantics of custom predicates and priorities? in other words, do we need to change the ComponentConfig API to somehow allow specifying multiple instances of the same Plugin with different arguments/weights, or should we consider that this is not supported? I always lean towards simplifying things, so my suggestion is to not support that, but I would like to know if there are actual deployments that rely on this. /sig scheduling /cc\n/cc\nWe discussed this in the sig meeting, and put the issue for discussion on the scheduler and kubernetes-dev mailing list, I believe this behavior is not intentional, and so we should add logic to fail the scheduler configuration when a policy includes more than one custom predicate/priority of the same type. /assign\n/assign\nany progress on this one?\nI haven't made any progress on this yet, but it's on my priority now\nIn migrating custom predicates to filter plugins , I am gonna ignore the custom predicate name and use the default name.", "positive_passages": [{"docid": "doc-en-kubernetes-072defee6a578fe8ac77148940f4a60b6ebdbd3da59f10a285e0948f3c98abf9", "text": "func ValidatePolicy(policy schedulerapi.Policy) error { var validationErrors []error <ins> priorities := make(map[string]schedulerapi.PriorityPolicy, len(policy.Priorities)) </ins> for _, priority := range policy.Priorities { if priority.Weight <= 0 || priority.Weight >= framework.MaxWeight { validationErrors = append(validationErrors, fmt.Errorf(\"Priority %s should have a positive weight applied to it or it has overflown\", priority.Name)) } <ins> validationErrors = append(validationErrors, validatePriorityRedeclared(priorities, priority)) } predicates := make(map[string]schedulerapi.PredicatePolicy, len(policy.Predicates)) for _, predicate := range policy.Predicates { validationErrors = append(validationErrors, validatePredicateRedeclared(predicates, predicate)) </ins> } binders := 0", "commid": "kubernetes_pr_83963"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f44ef0bcf2f9c8d0399d4efb9b080a7dd533e835c60e6b9400ac5a442e4901db", "query": "Currently custom predicate and priorities can be created through the . The problem is that a custom predicate/priority, like ServiceAffinity, can be multiple times in the Policy with different names, possibly with different arguments. This semantic (i.e., specifying multiple instances of the same custom predicate with different arguments) is only useful if different s were specified because in all cases of custom predicates/priorities the arguments are merge-able (for example, from multiple CheckServiceAffinity custom predicates can be merged into one set). In the world of framework plugins, we don't currently have a way to maintain those semantics. to run. The question here: do we really want to maintain the old semantics of custom predicates and priorities? in other words, do we need to change the ComponentConfig API to somehow allow specifying multiple instances of the same Plugin with different arguments/weights, or should we consider that this is not supported? I always lean towards simplifying things, so my suggestion is to not support that, but I would like to know if there are actual deployments that rely on this. /sig scheduling /cc\n/cc\nWe discussed this in the sig meeting, and put the issue for discussion on the scheduler and kubernetes-dev mailing list, I believe this behavior is not intentional, and so we should add logic to fail the scheduler configuration when a policy includes more than one custom predicate/priority of the same type. /assign\n/assign\nany progress on this one?\nI haven't made any progress on this yet, but it's on my priority now\nIn migrating custom predicates to filter plugins , I am gonna ignore the custom predicate name and use the default name.", "positive_passages": [{"docid": "doc-en-kubernetes-2abc58f0a2c67744c2d5497413448cf556e1656ad4757c063e3b0d5a395b6b71", "text": "return utilerrors.NewAggregate(validationErrors) } <ins> // validatePriorityRedeclared checks if any custom priorities have been declared multiple times in the policy config // by examining the specified priority arguments func validatePriorityRedeclared(priorities map[string]schedulerapi.PriorityPolicy, priority schedulerapi.PriorityPolicy) error { var priorityType string if priority.Argument != nil { if priority.Argument.LabelPreference != nil { priorityType = \"LabelPreference\" } else if priority.Argument.RequestedToCapacityRatioArguments != nil { priorityType = \"RequestedToCapacityRatioArguments\" } else if priority.Argument.ServiceAntiAffinity != nil { priorityType = \"ServiceAntiAffinity\" } else { return fmt.Errorf(\"No priority arguments set for priority %s\", priority.Name) } if existing, alreadyDeclared := priorities[priorityType]; alreadyDeclared { return fmt.Errorf(\"Priority '%s' redeclares custom priority '%s', from:'%s'\", priority.Name, priorityType, existing.Name) } priorities[priorityType] = priority } return nil } // validatePredicateRedeclared checks if any custom predicates have been declared multiple times in the policy config // by examining the specified predicate arguments func validatePredicateRedeclared(predicates map[string]schedulerapi.PredicatePolicy, predicate schedulerapi.PredicatePolicy) error { var predicateType string if predicate.Argument != nil { if predicate.Argument.LabelsPresence != nil { predicateType = \"LabelsPresence\" } else if predicate.Argument.ServiceAffinity != nil { predicateType = \"ServiceAffinity\" } else { return fmt.Errorf(\"No priority arguments set for priority %s\", predicate.Name) } if existing, alreadyDeclared := predicates[predicateType]; alreadyDeclared { return fmt.Errorf(\"Predicate '%s' redeclares custom predicate '%s', from:'%s'\", predicate.Name, predicateType, existing.Name) } predicates[predicateType] = predicate } return nil } </ins> // validateExtendedResourceName checks whether the specified name is a valid // extended resource name. func validateExtendedResourceName(name v1.ResourceName) []error {", "commid": "kubernetes_pr_83963"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f44ef0bcf2f9c8d0399d4efb9b080a7dd533e835c60e6b9400ac5a442e4901db", "query": "Currently custom predicate and priorities can be created through the . The problem is that a custom predicate/priority, like ServiceAffinity, can be multiple times in the Policy with different names, possibly with different arguments. This semantic (i.e., specifying multiple instances of the same custom predicate with different arguments) is only useful if different s were specified because in all cases of custom predicates/priorities the arguments are merge-able (for example, from multiple CheckServiceAffinity custom predicates can be merged into one set). In the world of framework plugins, we don't currently have a way to maintain those semantics. to run. The question here: do we really want to maintain the old semantics of custom predicates and priorities? in other words, do we need to change the ComponentConfig API to somehow allow specifying multiple instances of the same Plugin with different arguments/weights, or should we consider that this is not supported? I always lean towards simplifying things, so my suggestion is to not support that, but I would like to know if there are actual deployments that rely on this. /sig scheduling /cc\n/cc\nWe discussed this in the sig meeting, and put the issue for discussion on the scheduler and kubernetes-dev mailing list, I believe this behavior is not intentional, and so we should add logic to fail the scheduler configuration when a policy includes more than one custom predicate/priority of the same type. /assign\n/assign\nany progress on this one?\nI haven't made any progress on this yet, but it's on my priority now\nIn migrating custom predicates to filter plugins , I am gonna ignore the custom predicate name and use the default name.", "positive_passages": [{"docid": "doc-en-kubernetes-0602033de7d9444ee8d3d0365086065def9d3d7eb8db28b32c88dad97462363c", "text": "}}, expected: errors.New(\"kubernetes.io/foo is an invalid extended resource name\"), }, <ins> { name: \"invalid redeclared custom predicate\", policy: api.Policy{ Predicates: []api.PredicatePolicy{ {Name: \"customPredicate1\", Argument: &api.PredicateArgument{ServiceAffinity: &api.ServiceAffinity{Labels: []string{\"label1\"}}}}, {Name: \"customPredicate2\", Argument: &api.PredicateArgument{ServiceAffinity: &api.ServiceAffinity{Labels: []string{\"label2\"}}}}, }, }, expected: errors.New(\"Predicate 'customPredicate2' redeclares custom predicate 'ServiceAffinity', from:'customPredicate1'\"), }, { name: \"invalid redeclared custom priority\", policy: api.Policy{ Priorities: []api.PriorityPolicy{ {Name: \"customPriority1\", Weight: 1, Argument: &api.PriorityArgument{ServiceAntiAffinity: &api.ServiceAntiAffinity{Label: \"label1\"}}}, {Name: \"customPriority2\", Weight: 1, Argument: &api.PriorityArgument{ServiceAntiAffinity: &api.ServiceAntiAffinity{Label: \"label2\"}}}, }, }, expected: errors.New(\"Priority 'customPriority2' redeclares custom priority 'ServiceAntiAffinity', from:'customPriority1'\"), }, </ins> } for _, test := range tests {", "commid": "kubernetes_pr_83963"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e344d7170961bb0b5ea1388aadba785b1fc66be8acebee6a3bdcfe8f657da4d", "query": "<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: cloud-provider-openstack jobs Which test(s) are failing: hack/local-up- itself fails. Since when has it been failing: Recent change , checks for node ready by doing a grep of KUBELETHOST. But when HOSTNAMEOVERRIDE is set , its unable to find the ip and exits. Testgrid link: Reason for failure: Anything else we need to know:\nRepalce KUBELETHOST with HOSTNAMEOVERRIDE shoud fix this issue, I have created a pull request\nThanks. But what if HOSTNAME_OVERRIDE is not set , then again it would fail? I guess its optional parameter\ncc\nIf not set, the default value is 127.0.0.1, won't fail\nHi ramineni, nodpad is correct. HOSTNAME_OVERRIDE do have default value which is 127.0.0.1.\nThanks. Then grep HOSTNAME_OVERRIDE is ideal solution. That would work for me. Hopefully PR gets merged soon", "positive_passages": [{"docid": "doc-en-kubernetes-a53151258f592821194517c0be3f5383ce4f4f332a20ddb028132953bb571217", "text": "function wait_node_ready(){ # check the nodes information after kubelet daemon start local nodes_stats=\"${KUBECTL} --kubeconfig '${CERT_DIR}/admin.kubeconfig' get nodes\" <del> local node_name=$KUBELET_HOST </del> <ins> local node_name=$HOSTNAME_OVERRIDE </ins> local system_node_wait_time=30 local interval_time=2 kube::util::wait_for_success \"$system_node_wait_time\" \"$interval_time\" \"$nodes_stats | grep $node_name\"", "commid": "kubernetes_pr_84008"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-047f808e04b31271a571d492a12584e78df3565487565320590578c7b2755139", "query": "What would you like to be : A unit test that verifies the evaluation order of the nodes in the scheduler. Why is this needed: The scheduler evaluates the nodes in a specific order until it finds a pre-defined minimum number of feasible nodes. To give all nodes a fair chance of being evaluated, in each scheduling cycle, the scheduler starts evaluating from where it left off in the previous cycle. This is captured by the parameter in  We need to add a unit test that captures regressions related to this behavior to avoid bugs like /sig scheduling /priority important-soon /help\n/assign\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-20d33e0ad15d715bd6c39311b857475ef9d0c660af4ccfe9884a6c1df5e19454", "text": "disablePreemption        bool percentageOfNodesToScore int32 enableNonPreempting      bool <del> lastProcessedNodeIndex   int </del> <ins> nextStartNodeIndex       int </ins> } // snapshot snapshots scheduler cache and node infos for all fit and priority", "commid": "kubernetes_pr_84335"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-047f808e04b31271a571d492a12584e78df3565487565320590578c7b2755139", "query": "What would you like to be : A unit test that verifies the evaluation order of the nodes in the scheduler. Why is this needed: The scheduler evaluates the nodes in a specific order until it finds a pre-defined minimum number of feasible nodes. To give all nodes a fair chance of being evaluated, in each scheduling cycle, the scheduler starts evaluating from where it left off in the previous cycle. This is captured by the parameter in  We need to add a unit test that captures regressions related to this behavior to avoid bugs like /sig scheduling /priority important-soon /help\n/assign\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-0272028c35d14e49c7ca92d41fdec1b420b26a999a538465c87890a28771c34c", "text": "checkNode := func(i int) { // We check the nodes starting from where we left off in the previous scheduling cycle, // this is to make sure all nodes have the same chance of being examined across pods. <del> nodeInfo := g.nodeInfoSnapshot.NodeInfoList[(g.lastProcessedNodeIndex+i)%allNodes] </del> <ins> nodeInfo := g.nodeInfoSnapshot.NodeInfoList[(g.nextStartNodeIndex+i)%allNodes] </ins> fits, failedPredicates, status, err := g.podFitsOnNode( ctx, state,", "commid": "kubernetes_pr_84335"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-047f808e04b31271a571d492a12584e78df3565487565320590578c7b2755139", "query": "What would you like to be : A unit test that verifies the evaluation order of the nodes in the scheduler. Why is this needed: The scheduler evaluates the nodes in a specific order until it finds a pre-defined minimum number of feasible nodes. To give all nodes a fair chance of being evaluated, in each scheduling cycle, the scheduler starts evaluating from where it left off in the previous cycle. This is captured by the parameter in  We need to add a unit test that captures regressions related to this behavior to avoid bugs like /sig scheduling /priority important-soon /help\n/assign\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-dac35ff61264ecad9a24c4b7f81deeeceec24a470ac2cb9239ec204aa7373af6", "text": "// are found. workqueue.ParallelizeUntil(ctx, 16, allNodes, checkNode) processedNodes := int(filteredLen) + len(filteredNodesStatuses) + len(failedPredicateMap) <del> g.lastProcessedNodeIndex = (g.lastProcessedNodeIndex + processedNodes) % allNodes </del> <ins> g.nextStartNodeIndex = (g.nextStartNodeIndex + processedNodes) % allNodes </ins> filtered = filtered[:filteredLen] if err := errCh.ReceiveError(); err != nil {", "commid": "kubernetes_pr_84335"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-047f808e04b31271a571d492a12584e78df3565487565320590578c7b2755139", "query": "What would you like to be : A unit test that verifies the evaluation order of the nodes in the scheduler. Why is this needed: The scheduler evaluates the nodes in a specific order until it finds a pre-defined minimum number of feasible nodes. To give all nodes a fair chance of being evaluated, in each scheduling cycle, the scheduler starts evaluating from where it left off in the previous cycle. This is captured by the parameter in  We need to add a unit test that captures regressions related to this behavior to avoid bugs like /sig scheduling /priority important-soon /help\n/assign\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-617a9cc25eb0e814c94d130b5a9b4928ae000298639b2f8909e631b330a1a29a", "text": "} } } <ins> func TestFairEvaluationForNodes(t *testing.T) { defer algorithmpredicates.SetPredicatesOrderingDuringTest(order)() predicates := map[string]algorithmpredicates.FitPredicate{\"true\": truePredicate} numAllNodes := 500 nodeNames := make([]string, 0, numAllNodes) for i := 0; i < numAllNodes; i++ { nodeNames = append(nodeNames, strconv.Itoa(i)) } nodes := makeNodeList(nodeNames) g := makeScheduler(predicates, nodes) // To make numAllNodes % nodesToFind != 0 g.percentageOfNodesToScore = 30 nodesToFind := int(g.numFeasibleNodesToFind(int32(numAllNodes))) // Iterating over all nodes more than twice for i := 0; i < 2*(numAllNodes/nodesToFind+1); i++ { nodesThatFit, _, _, err := g.findNodesThatFit(context.Background(), framework.NewCycleState(), &v1.Pod{}) if err != nil { t.Errorf(\"unexpected error: %v\", err) } if len(nodesThatFit) != nodesToFind { t.Errorf(\"got %d nodes filtered, want %d\", len(nodesThatFit), nodesToFind) } if g.nextStartNodeIndex != (i+1)*nodesToFind%numAllNodes { t.Errorf(\"got %d lastProcessedNodeIndex, want %d\", g.nextStartNodeIndex, (i+1)*nodesToFind%numAllNodes) } } } </ins>", "commid": "kubernetes_pr_84335"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-12f7047d8d873a7d6bac7023fc38517c350449071b3fe2b6d53f3ea14de5351f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: EndpointSlice for masters was not created after enabling EndpointSlice on a pre-existing cluster. Only those EndpointSlices managed by kube-controller-manager were created. What you expected to happen: EndpointSlice for masters should be created after enabling EndpointSlice on a pre-existing cluster, the same as the EndpointSlices managed by kube-controller-manager. How to reproduce it (as minimally and precisely as possible): kubeadm to create a cluster: the EndpointSlice feature by editing the kube-apiserver, kube-controller-manager, kube-proxy manifest kube-apiserver and kube-controller-manager is restarted, the EndpointSlice in namespace will be missing. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools:Network plugin and version (if this is a network-related bug): Others:\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/remove-triage unresolved /assign", "positive_passages": [{"docid": "doc-en-kubernetes-64aed225b31f5566fdcd522d235959dbfa6315616ecabcf577dc3ca95ee1f1d7", "text": "\"//pkg/api/v1/endpoints:go_default_library\", \"//staging/src/k8s.io/api/core/v1:go_default_library\", \"//staging/src/k8s.io/api/discovery/v1alpha1:go_default_library\", <ins> \"//staging/src/k8s.io/apimachinery/pkg/api/equality:go_default_library\", </ins> \"//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library\",", "commid": "kubernetes_pr_84421"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-12f7047d8d873a7d6bac7023fc38517c350449071b3fe2b6d53f3ea14de5351f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: EndpointSlice for masters was not created after enabling EndpointSlice on a pre-existing cluster. Only those EndpointSlices managed by kube-controller-manager were created. What you expected to happen: EndpointSlice for masters should be created after enabling EndpointSlice on a pre-existing cluster, the same as the EndpointSlices managed by kube-controller-manager. How to reproduce it (as minimally and precisely as possible): kubeadm to create a cluster: the EndpointSlice feature by editing the kube-apiserver, kube-controller-manager, kube-proxy manifest kube-apiserver and kube-controller-manager is restarted, the EndpointSlice in namespace will be missing. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools:Network plugin and version (if this is a network-related bug): Others:\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/remove-triage unresolved /assign", "positive_passages": [{"docid": "doc-en-kubernetes-3a2f39f9abc333fc5d2af805bd7a4774965e2f6b5759e12c20950eedd1dd77f9", "text": "import ( corev1 \"k8s.io/api/core/v1\" discovery \"k8s.io/api/discovery/v1alpha1\" <ins> apiequality \"k8s.io/apimachinery/pkg/api/equality\" </ins> \"k8s.io/apimachinery/pkg/api/errors\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" corev1client \"k8s.io/client-go/kubernetes/typed/core/v1\"", "commid": "kubernetes_pr_84421"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-12f7047d8d873a7d6bac7023fc38517c350449071b3fe2b6d53f3ea14de5351f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: EndpointSlice for masters was not created after enabling EndpointSlice on a pre-existing cluster. Only those EndpointSlices managed by kube-controller-manager were created. What you expected to happen: EndpointSlice for masters should be created after enabling EndpointSlice on a pre-existing cluster, the same as the EndpointSlices managed by kube-controller-manager. How to reproduce it (as minimally and precisely as possible): kubeadm to create a cluster: the EndpointSlice feature by editing the kube-apiserver, kube-controller-manager, kube-proxy manifest kube-apiserver and kube-controller-manager is restarted, the EndpointSlice in namespace will be missing. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools:Network plugin and version (if this is a network-related bug): Others:\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/remove-triage unresolved /assign", "positive_passages": [{"docid": "doc-en-kubernetes-29d3000b1c61d5cc8a6a262939249245b4bbe901dffef43c7587c9b61e54e5e7", "text": "// returned. func (adapter *EndpointsAdapter) Create(namespace string, endpoints *corev1.Endpoints) (*corev1.Endpoints, error) { endpoints, err := adapter.endpointClient.Endpoints(namespace).Create(endpoints) <del> if err == nil && adapter.endpointSliceClient != nil { _, err = adapter.ensureEndpointSliceFromEndpoints(namespace, endpoints) </del> <ins> if err == nil { err = adapter.EnsureEndpointSliceFromEndpoints(namespace, endpoints) </ins> } return endpoints, err }", "commid": "kubernetes_pr_84421"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-12f7047d8d873a7d6bac7023fc38517c350449071b3fe2b6d53f3ea14de5351f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: EndpointSlice for masters was not created after enabling EndpointSlice on a pre-existing cluster. Only those EndpointSlices managed by kube-controller-manager were created. What you expected to happen: EndpointSlice for masters should be created after enabling EndpointSlice on a pre-existing cluster, the same as the EndpointSlices managed by kube-controller-manager. How to reproduce it (as minimally and precisely as possible): kubeadm to create a cluster: the EndpointSlice feature by editing the kube-apiserver, kube-controller-manager, kube-proxy manifest kube-apiserver and kube-controller-manager is restarted, the EndpointSlice in namespace will be missing. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools:Network plugin and version (if this is a network-related bug): Others:\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/remove-triage unresolved /assign", "positive_passages": [{"docid": "doc-en-kubernetes-e80ff961b20b1b5a1e447b9624aca9f22c977f1df75594679a1eb60d05525d27", "text": "// updated. The updated Endpoints object or an error will be returned. func (adapter *EndpointsAdapter) Update(namespace string, endpoints *corev1.Endpoints) (*corev1.Endpoints, error) { endpoints, err := adapter.endpointClient.Endpoints(namespace).Update(endpoints) <del> if err == nil && adapter.endpointSliceClient != nil { _, err = adapter.ensureEndpointSliceFromEndpoints(namespace, endpoints) </del> <ins> if err == nil { err = adapter.EnsureEndpointSliceFromEndpoints(namespace, endpoints) </ins> } return endpoints, err } <del> // ensureEndpointSliceFromEndpoints accepts a namespace and Endpoints resource // and creates or updates a corresponding EndpointSlice. The EndpointSlice // and/or an error will be returned. func (adapter *EndpointsAdapter) ensureEndpointSliceFromEndpoints(namespace string, endpoints *corev1.Endpoints) (*discovery.EndpointSlice, error) { </del> <ins> // EnsureEndpointSliceFromEndpoints accepts a namespace and Endpoints resource // and creates or updates a corresponding EndpointSlice if an endpointSliceClient // exists. An error will be returned if it fails to sync the EndpointSlice. func (adapter *EndpointsAdapter) EnsureEndpointSliceFromEndpoints(namespace string, endpoints *corev1.Endpoints) error { if adapter.endpointSliceClient == nil { return nil } </ins> endpointSlice := endpointSliceFromEndpoints(endpoints) <del> _, err := adapter.endpointSliceClient.EndpointSlices(namespace).Get(endpointSlice.Name, metav1.GetOptions{}) </del> <ins> currentEndpointSlice, err := adapter.endpointSliceClient.EndpointSlices(namespace).Get(endpointSlice.Name, metav1.GetOptions{}) </ins> if err != nil { if errors.IsNotFound(err) { <del> return adapter.endpointSliceClient.EndpointSlices(namespace).Create(endpointSlice) </del> <ins> if _, err = adapter.endpointSliceClient.EndpointSlices(namespace).Create(endpointSlice); errors.IsAlreadyExists(err) { err = nil } </ins> } <del> return nil, err </del> <ins> return err } if apiequality.Semantic.DeepEqual(currentEndpointSlice.Endpoints, endpointSlice.Endpoints) && apiequality.Semantic.DeepEqual(currentEndpointSlice.Ports, endpointSlice.Ports) && apiequality.Semantic.DeepEqual(currentEndpointSlice.Labels, endpointSlice.Labels) { return nil </ins> } <del> return adapter.endpointSliceClient.EndpointSlices(namespace).Update(endpointSlice) </del> <ins> _, err = adapter.endpointSliceClient.EndpointSlices(namespace).Update(endpointSlice) return err </ins> } // endpointSliceFromEndpoints generates an EndpointSlice from an Endpoints", "commid": "kubernetes_pr_84421"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-12f7047d8d873a7d6bac7023fc38517c350449071b3fe2b6d53f3ea14de5351f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: EndpointSlice for masters was not created after enabling EndpointSlice on a pre-existing cluster. Only those EndpointSlices managed by kube-controller-manager were created. What you expected to happen: EndpointSlice for masters should be created after enabling EndpointSlice on a pre-existing cluster, the same as the EndpointSlices managed by kube-controller-manager. How to reproduce it (as minimally and precisely as possible): kubeadm to create a cluster: the EndpointSlice feature by editing the kube-apiserver, kube-controller-manager, kube-proxy manifest kube-apiserver and kube-controller-manager is restarted, the EndpointSlice in namespace will be missing. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools:Network plugin and version (if this is a network-related bug): Others:\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/remove-triage unresolved /assign", "positive_passages": [{"docid": "doc-en-kubernetes-1569220cdd6645154e4e59ada26c2ee9510c3a953d16557a170bc8354fd53dd0", "text": "Subsets:    []corev1.EndpointSubset{subset}, }, epSlice } <ins> func TestEndpointsAdapterEnsureEndpointSliceFromEndpoints(t *testing.T) { endpoints1, epSlice1 := generateEndpointsAndSlice(\"foo\", \"testing\", []int{80, 443}, []string{\"10.1.2.3\", \"10.1.2.4\"}) endpoints2, epSlice2 := generateEndpointsAndSlice(\"foo\", \"testing\", []int{80, 443}, []string{\"10.1.2.3\", \"10.1.2.4\", \"10.1.2.5\"}) testCases := map[string]struct { endpointSlicesEnabled bool expectedError         error expectedEndpointSlice *discovery.EndpointSlice endpointSlices        []*discovery.EndpointSlice namespaceParam        string endpointsParam        *corev1.Endpoints }{ \"existing-endpointslice-no-change\": { endpointSlicesEnabled: true, expectedError:         nil, expectedEndpointSlice: epSlice1, endpointSlices:        []*discovery.EndpointSlice{epSlice1}, namespaceParam:        \"testing\", endpointsParam:        endpoints1, }, \"existing-endpointslice-change\": { endpointSlicesEnabled: true, expectedError:         nil, expectedEndpointSlice: epSlice2, endpointSlices:        []*discovery.EndpointSlice{epSlice1}, namespaceParam:        \"testing\", endpointsParam:        endpoints2, }, \"missing-endpointslice\": { endpointSlicesEnabled: true, expectedError:         nil, expectedEndpointSlice: epSlice1, endpointSlices:        []*discovery.EndpointSlice{}, namespaceParam:        \"testing\", endpointsParam:        endpoints1, }, \"endpointslices-disabled\": { endpointSlicesEnabled: false, expectedError:         nil, expectedEndpointSlice: nil, endpointSlices:        []*discovery.EndpointSlice{}, namespaceParam:        \"testing\", endpointsParam:        endpoints1, }, } for name, testCase := range testCases { t.Run(name, func(t *testing.T) { client := fake.NewSimpleClientset() epAdapter := EndpointsAdapter{endpointClient: client.CoreV1()} if testCase.endpointSlicesEnabled { epAdapter.endpointSliceClient = client.DiscoveryV1alpha1() } for _, endpointSlice := range testCase.endpointSlices { _, err := client.DiscoveryV1alpha1().EndpointSlices(endpointSlice.Namespace).Create(endpointSlice) if err != nil { t.Fatalf(\"Error creating EndpointSlice: %v\", err) } } err := epAdapter.EnsureEndpointSliceFromEndpoints(testCase.namespaceParam, testCase.endpointsParam) if !apiequality.Semantic.DeepEqual(testCase.expectedError, err) { t.Errorf(\"Expected error: %v, got: %v\", testCase.expectedError, err) } endpointSlice, err := client.DiscoveryV1alpha1().EndpointSlices(testCase.namespaceParam).Get(testCase.endpointsParam.Name, metav1.GetOptions{}) if err != nil && !errors.IsNotFound(err) { t.Fatalf(\"Error getting Endpoint Slice: %v\", err) } if !apiequality.Semantic.DeepEqual(endpointSlice, testCase.expectedEndpointSlice) { t.Errorf(\"Expected Endpoint Slice: %v, got: %v\", testCase.expectedEndpointSlice, endpointSlice) } }) } } </ins>", "commid": "kubernetes_pr_84421"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-12f7047d8d873a7d6bac7023fc38517c350449071b3fe2b6d53f3ea14de5351f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: EndpointSlice for masters was not created after enabling EndpointSlice on a pre-existing cluster. Only those EndpointSlices managed by kube-controller-manager were created. What you expected to happen: EndpointSlice for masters should be created after enabling EndpointSlice on a pre-existing cluster, the same as the EndpointSlices managed by kube-controller-manager. How to reproduce it (as minimally and precisely as possible): kubeadm to create a cluster: the EndpointSlice feature by editing the kube-apiserver, kube-controller-manager, kube-proxy manifest kube-apiserver and kube-controller-manager is restarted, the EndpointSlice in namespace will be missing. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools:Network plugin and version (if this is a network-related bug): Others:\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/remove-triage unresolved /assign", "positive_passages": [{"docid": "doc-en-kubernetes-4f066e1ef1219d8400b200e9240cc51649f113dc853472d51a8c46601b646fba", "text": "// Next, we compare the current list of endpoints with the list of master IP keys formatCorrect, ipCorrect, portsCorrect := checkEndpointSubsetFormatWithLease(e, masterIPs, endpointPorts, reconcilePorts) if formatCorrect && ipCorrect && portsCorrect { <del> return nil </del> <ins> return r.epAdapter.EnsureEndpointSliceFromEndpoints(corev1.NamespaceDefault, e) </ins> } if !formatCorrect {", "commid": "kubernetes_pr_84421"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-12f7047d8d873a7d6bac7023fc38517c350449071b3fe2b6d53f3ea14de5351f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: EndpointSlice for masters was not created after enabling EndpointSlice on a pre-existing cluster. Only those EndpointSlices managed by kube-controller-manager were created. What you expected to happen: EndpointSlice for masters should be created after enabling EndpointSlice on a pre-existing cluster, the same as the EndpointSlices managed by kube-controller-manager. How to reproduce it (as minimally and precisely as possible): kubeadm to create a cluster: the EndpointSlice feature by editing the kube-apiserver, kube-controller-manager, kube-proxy manifest kube-apiserver and kube-controller-manager is restarted, the EndpointSlice in namespace will be missing. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools:Network plugin and version (if this is a network-related bug): Others:\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/remove-triage unresolved /assign", "positive_passages": [{"docid": "doc-en-kubernetes-ad37c38d08e42ab61110b1b4d3870be9b90fe2526bdbdd29f964ad6463465a40", "text": "return err } if ipCorrect && portsCorrect { <del> return nil </del> <ins> return r.epAdapter.EnsureEndpointSliceFromEndpoints(metav1.NamespaceDefault, e) </ins> } if !ipCorrect { // We *always* add our own IP address.", "commid": "kubernetes_pr_84421"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c62d28c0cab8ac8c425758491c93f526d0f109b8db3aef1e60198c10830f3c12", "query": "What happened: Housekeeping sync loop finds an orphaned pod and tries to clean it up. The kubepod slice, as seen below, is not removed by with no indication as to why. This leads to the docker scope timing out and entering a failed state. The returned error(s) from runc are swallowed making debugging difficult. What you expected to happen: As per other areas of the sync loop, useful errors are logged at debug level due to the async calls. How to reproduce it (as minimally and precisely as possible): N/A Anything else we need to know?: N/A Environment: Kubernetes version (use ): master\n/sig node\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nHave you seen the comment above pcm.Destroy() call ? Did you have a chance to look at kubelet log to see if the above was true ?\n/remove-lifecycle stale\nThis would give us some clue about the error:\nyes, definitely looked! In this specific situation, the pods are never retried. What we see happen with these pods: ADD -RECONCILE -Started Volumes -Created slice -No sandbox for pod -Started libcontainer -ContainerStarted -ContainerStarted -RECONSILE -ContainerDied -RECONCILE -Unmounts -Killing unwanted pod -Orphaned removing pod cgroups -container kill failed because of 'container not found' or 'no such process' -cleanup: failed to unmount secrets -ContainerDied -Container garbage collection succeeded -SyncLoop (SYNC): 141 pods (including this one) -stopping timed out. Killing. -Stopped libcontainer -Removed slice -DELETE -REMOVE -err: pod not found Destroy all cgroups of the pod that should not be running, by first killing all the attached processes to these cgroups. We ignore errors thrown by the method, as the housekeeping loop would again try to delete these unwanted pod cgroups Despite running, the slice is not removed and we do not log or indicate why. Subsequently, the pod is NOT determined to be either an active pod or for some reason not in the cgroup list that is passed into kl.cleanupOrphanedPodCgroups(cgroupPods, activePods) during housekeeping loops. A more detailed look, which I believe is accurate ;): housekeepingCh -HandlePodCleanups -cgroupPods=UID+CGroupName=GetAllPodsFromCgroups -allPods=GetPodsAndMirrorPods -activePods=filterOutTerminatedPods -cleanupOrphanedPodCgroups I do not think desiredPods and runningPods are relevant here.. So either: a) the pod is not found and to allPods (seems unlikely) but we can't know for sure.. b) the pod is incorrectly determined to be active via activePods which again we can not determine.. Any pod that is not Failed, Succeeded or has a DeletionTimestamp set and a status of Terminated or Waiting - anything else returns false and is deemed active c) the pod cgroup is not found in m.subsystems.MountPoints and to cgroupPods - unlikely, but could be a bug but the root of this issue is the fact that all of the scopes and slices exist and keep building up until things start failing... GetAllPodsFromCgroups could use some logging... Maybe a V 5 log that prints out foundPods at the end... From there, they're passed into the cleanup: kl.cleanupOrphanedPodCgroups(cgroupPods, activePods) 1) All activePod UIDs are put into a podSet 2) A range loop of uid and cgroup name from cgroupPods looks to see if the uid from cgroupPods also exists in the podSet (active pods) 3) If the uid from cgroupPods exists in the podSet we skip out of the loop 4) If it doesn't, the pod is orphaned (not active w/ cgroups on the filesystem) and we call pcm.Destroy(val) on the cgroup name. Doesn't make sense why pcm.Destroy(val) ignores errors... it would be helpful! tryKillingCgroupProcesses logs any error and also returns the an error which is always swallowed.. we don't see any issues here More problematic, the call to cgroupManager.Destroy only returns an error which would be swallowed... Could probably use a similar level 3 log here like what you have for tryKillingCgroupProcesses because as you can see, were totally blind here...\nyour change is of a similar nature to what I proposed in my PR for this issue, just a level higher. I think there are a few areas noted above the could help further debug this.. Still haven't been able to get my PR merged with additional logging.\nThe following code was relatively new (compared to when you logged this issue):\nIndeed... I looked into it a while ago and those changes are new via: - Could definitely make a different if the issue is related to pod getting filtered out from activePods when they have not been fully cleaned up yet on the subsequent housekeeping syncloop runs.\nI think is promising, but I still think it makes sense to add some logging here. Do you want want to proceed with my open PR, your suggestion in or both?\nYou can proceed with your PR.", "positive_passages": [{"docid": "doc-en-kubernetes-f3c5418cd6fa9e0e73ab047dbd49a31e8cffc1f72b47067856b47942bce3dded", "text": "func (m *podContainerManagerImpl) Destroy(podCgroup CgroupName) error { // Try killing all the processes attached to the pod cgroup if err := m.tryKillingCgroupProcesses(podCgroup); err != nil { <del> klog.V(3).Infof(\"failed to kill all the processes attached to the %v cgroups\", podCgroup) </del> <ins> klog.Warningf(\"failed to kill all the processes attached to the %v cgroups\", podCgroup) </ins> return fmt.Errorf(\"failed to kill all the processes attached to the %v cgroups : %v\", podCgroup, err) }", "commid": "kubernetes_pr_84599"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c62d28c0cab8ac8c425758491c93f526d0f109b8db3aef1e60198c10830f3c12", "query": "What happened: Housekeeping sync loop finds an orphaned pod and tries to clean it up. The kubepod slice, as seen below, is not removed by with no indication as to why. This leads to the docker scope timing out and entering a failed state. The returned error(s) from runc are swallowed making debugging difficult. What you expected to happen: As per other areas of the sync loop, useful errors are logged at debug level due to the async calls. How to reproduce it (as minimally and precisely as possible): N/A Anything else we need to know?: N/A Environment: Kubernetes version (use ): master\n/sig node\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nHave you seen the comment above pcm.Destroy() call ? Did you have a chance to look at kubelet log to see if the above was true ?\n/remove-lifecycle stale\nThis would give us some clue about the error:\nyes, definitely looked! In this specific situation, the pods are never retried. What we see happen with these pods: ADD -RECONCILE -Started Volumes -Created slice -No sandbox for pod -Started libcontainer -ContainerStarted -ContainerStarted -RECONSILE -ContainerDied -RECONCILE -Unmounts -Killing unwanted pod -Orphaned removing pod cgroups -container kill failed because of 'container not found' or 'no such process' -cleanup: failed to unmount secrets -ContainerDied -Container garbage collection succeeded -SyncLoop (SYNC): 141 pods (including this one) -stopping timed out. Killing. -Stopped libcontainer -Removed slice -DELETE -REMOVE -err: pod not found Destroy all cgroups of the pod that should not be running, by first killing all the attached processes to these cgroups. We ignore errors thrown by the method, as the housekeeping loop would again try to delete these unwanted pod cgroups Despite running, the slice is not removed and we do not log or indicate why. Subsequently, the pod is NOT determined to be either an active pod or for some reason not in the cgroup list that is passed into kl.cleanupOrphanedPodCgroups(cgroupPods, activePods) during housekeeping loops. A more detailed look, which I believe is accurate ;): housekeepingCh -HandlePodCleanups -cgroupPods=UID+CGroupName=GetAllPodsFromCgroups -allPods=GetPodsAndMirrorPods -activePods=filterOutTerminatedPods -cleanupOrphanedPodCgroups I do not think desiredPods and runningPods are relevant here.. So either: a) the pod is not found and to allPods (seems unlikely) but we can't know for sure.. b) the pod is incorrectly determined to be active via activePods which again we can not determine.. Any pod that is not Failed, Succeeded or has a DeletionTimestamp set and a status of Terminated or Waiting - anything else returns false and is deemed active c) the pod cgroup is not found in m.subsystems.MountPoints and to cgroupPods - unlikely, but could be a bug but the root of this issue is the fact that all of the scopes and slices exist and keep building up until things start failing... GetAllPodsFromCgroups could use some logging... Maybe a V 5 log that prints out foundPods at the end... From there, they're passed into the cleanup: kl.cleanupOrphanedPodCgroups(cgroupPods, activePods) 1) All activePod UIDs are put into a podSet 2) A range loop of uid and cgroup name from cgroupPods looks to see if the uid from cgroupPods also exists in the podSet (active pods) 3) If the uid from cgroupPods exists in the podSet we skip out of the loop 4) If it doesn't, the pod is orphaned (not active w/ cgroups on the filesystem) and we call pcm.Destroy(val) on the cgroup name. Doesn't make sense why pcm.Destroy(val) ignores errors... it would be helpful! tryKillingCgroupProcesses logs any error and also returns the an error which is always swallowed.. we don't see any issues here More problematic, the call to cgroupManager.Destroy only returns an error which would be swallowed... Could probably use a similar level 3 log here like what you have for tryKillingCgroupProcesses because as you can see, were totally blind here...\nyour change is of a similar nature to what I proposed in my PR for this issue, just a level higher. I think there are a few areas noted above the could help further debug this.. Still haven't been able to get my PR merged with additional logging.\nThe following code was relatively new (compared to when you logged this issue):\nIndeed... I looked into it a while ago and those changes are new via: - Could definitely make a different if the issue is related to pod getting filtered out from activePods when they have not been fully cleaned up yet on the subsequent housekeeping syncloop runs.\nI think is promising, but I still think it makes sense to add some logging here. Do you want want to proceed with my open PR, your suggestion in or both?\nYou can proceed with your PR.", "positive_passages": [{"docid": "doc-en-kubernetes-b75df5bece3611a0fee15b3caaa28446979609edc16f2d3ac4db541ba87fe508", "text": "ResourceParameters: &ResourceConfig{}, } if err := m.cgroupManager.Destroy(containerConfig); err != nil { <ins> klog.Warningf(\"failed to delete cgroup paths for %v : %v\", podCgroup, err) </ins> return fmt.Errorf(\"failed to delete cgroup paths for %v : %v\", podCgroup, err) } return nil", "commid": "kubernetes_pr_84599"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e980982f61b83c27c7ae4bdf180c05d465fe500056a9b182ab82110619c2947", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: It returns an error when I create a pod of yaml file over 1M. I checked the codes and found that the coded wrong. It should be \u201cjson.Unmarshal(p.patchBytes, &v)\u201d, not \u201cjson.Unmarshal(p.patchBytes, v)\u201d in the 344 and 368 line. What you expected to happen: It can be parsed correctly. How to reproduce it (as minimally and precisely as possible): Look at the code and you'll see or you can test it. Anything else we need to know?: no. Environment: Kubernetes version (use ): Community latest code Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/kind bug\n/sig api-machinery\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-ef04b78697ac4420c37ef3b798738cdcdb9117a5bf6d15705f992467744eff05", "text": "// TODO(liggitt): drop this once golang json parser limits stack depth (https://github.com/golang/go/issues/31789) if len(p.patchBytes) > 1024*1024 { v := []interface{}{} <del> if err := json.Unmarshal(p.patchBytes, v); err != nil { </del> <ins> if err := json.Unmarshal(p.patchBytes, &v); err != nil { </ins> return nil, errors.NewBadRequest(fmt.Sprintf(\"error decoding patch: %v\", err)) } }", "commid": "kubernetes_pr_84963"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e980982f61b83c27c7ae4bdf180c05d465fe500056a9b182ab82110619c2947", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: It returns an error when I create a pod of yaml file over 1M. I checked the codes and found that the coded wrong. It should be \u201cjson.Unmarshal(p.patchBytes, &v)\u201d, not \u201cjson.Unmarshal(p.patchBytes, v)\u201d in the 344 and 368 line. What you expected to happen: It can be parsed correctly. How to reproduce it (as minimally and precisely as possible): Look at the code and you'll see or you can test it. Anything else we need to know?: no. Environment: Kubernetes version (use ): Community latest code Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/kind bug\n/sig api-machinery\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-73dfa9e845bdb53882e727b1cc9cfb99c64cb0aeb85ff7c306aea52c3ab94c5c", "text": "// TODO(liggitt): drop this once golang json parser limits stack depth (https://github.com/golang/go/issues/31789) if len(p.patchBytes) > 1024*1024 { v := map[string]interface{}{} <del> if err := json.Unmarshal(p.patchBytes, v); err != nil { </del> <ins> if err := json.Unmarshal(p.patchBytes, &v); err != nil { </ins> return nil, errors.NewBadRequest(fmt.Sprintf(\"error decoding patch: %v\", err)) } }", "commid": "kubernetes_pr_84963"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e980982f61b83c27c7ae4bdf180c05d465fe500056a9b182ab82110619c2947", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: It returns an error when I create a pod of yaml file over 1M. I checked the codes and found that the coded wrong. It should be \u201cjson.Unmarshal(p.patchBytes, &v)\u201d, not \u201cjson.Unmarshal(p.patchBytes, v)\u201d in the 344 and 368 line. What you expected to happen: It can be parsed correctly. How to reproduce it (as minimally and precisely as possible): Look at the code and you'll see or you can test it. Anything else we need to know?: no. Environment: Kubernetes version (use ): Community latest code Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/kind bug\n/sig api-machinery\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-4ddeaf9e40f6bc028710a41a25e0fe607dd85ee90f329a08becf55950d437312", "text": "t.Errorf(\"expected success or bad request err, got %v\", err) } }) <ins> t.Run(\"JSONPatchType should handle a valid patch just under the max limit\", func(t *testing.T) { patchBody := []byte(`[{\"op\":\"add\",\"path\":\"/foo\",\"value\":0` + strings.Repeat(\" \", 3*1024*1024-100) + `}]`) err = rest.Patch(types.JSONPatchType).AbsPath(fmt.Sprintf(\"/api/v1/namespaces/default/secrets/test\")). Body(patchBody).Do().Error() if err != nil { t.Errorf(\"unexpected error: %v\", err) } }) </ins> t.Run(\"MergePatchType should handle a patch just under the max limit\", func(t *testing.T) { patchBody := []byte(`{\"value\":` + strings.Repeat(\"[\", 3*1024*1024/2-100) + strings.Repeat(\"]\", 3*1024*1024/2-100) + `}`) err = rest.Patch(types.MergePatchType).AbsPath(fmt.Sprintf(\"/api/v1/namespaces/default/secrets/test\")).", "commid": "kubernetes_pr_84963"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e980982f61b83c27c7ae4bdf180c05d465fe500056a9b182ab82110619c2947", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: It returns an error when I create a pod of yaml file over 1M. I checked the codes and found that the coded wrong. It should be \u201cjson.Unmarshal(p.patchBytes, &v)\u201d, not \u201cjson.Unmarshal(p.patchBytes, v)\u201d in the 344 and 368 line. What you expected to happen: It can be parsed correctly. How to reproduce it (as minimally and precisely as possible): Look at the code and you'll see or you can test it. Anything else we need to know?: no. Environment: Kubernetes version (use ): Community latest code Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/kind bug\n/sig api-machinery\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-b963884e350ff8046d6ffbe0280ff926096fc2e75c1627b21c26f0ab25d165af", "text": "t.Errorf(\"expected success or bad request err, got %v\", err) } }) <ins> t.Run(\"MergePatchType should handle a valid patch just under the max limit\", func(t *testing.T) { patchBody := []byte(`{\"value\":0` + strings.Repeat(\" \", 3*1024*1024-100) + `}`) err = rest.Patch(types.MergePatchType).AbsPath(fmt.Sprintf(\"/api/v1/namespaces/default/secrets/test\")). Body(patchBody).Do().Error() if err != nil { t.Errorf(\"unexpected error: %v\", err) } }) </ins> t.Run(\"StrategicMergePatchType should handle a patch just under the max limit\", func(t *testing.T) { patchBody := []byte(`{\"value\":` + strings.Repeat(\"[\", 3*1024*1024/2-100) + strings.Repeat(\"]\", 3*1024*1024/2-100) + `}`) err = rest.Patch(types.StrategicMergePatchType).AbsPath(fmt.Sprintf(\"/api/v1/namespaces/default/secrets/test\")).", "commid": "kubernetes_pr_84963"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e980982f61b83c27c7ae4bdf180c05d465fe500056a9b182ab82110619c2947", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: It returns an error when I create a pod of yaml file over 1M. I checked the codes and found that the coded wrong. It should be \u201cjson.Unmarshal(p.patchBytes, &v)\u201d, not \u201cjson.Unmarshal(p.patchBytes, v)\u201d in the 344 and 368 line. What you expected to happen: It can be parsed correctly. How to reproduce it (as minimally and precisely as possible): Look at the code and you'll see or you can test it. Anything else we need to know?: no. Environment: Kubernetes version (use ): Community latest code Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/kind bug\n/sig api-machinery\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-e6a488a252f930ffbc5e20149add79bd3159ad09f48221db456bf02ecc7a9922", "text": "t.Errorf(\"expected success or bad request err, got %v\", err) } }) <ins> t.Run(\"StrategicMergePatchType should handle a valid patch just under the max limit\", func(t *testing.T) { patchBody := []byte(`{\"value\":0` + strings.Repeat(\" \", 3*1024*1024-100) + `}`) err = rest.Patch(types.StrategicMergePatchType).AbsPath(fmt.Sprintf(\"/api/v1/namespaces/default/secrets/test\")). Body(patchBody).Do().Error() if err != nil { t.Errorf(\"unexpected error: %v\", err) } }) </ins> t.Run(\"ApplyPatchType should handle a patch just under the max limit\", func(t *testing.T) { patchBody := []byte(`{\"value\":` + strings.Repeat(\"[\", 3*1024*1024/2-100) + strings.Repeat(\"]\", 3*1024*1024/2-100) + `}`) err = rest.Patch(types.ApplyPatchType).Param(\"fieldManager\", \"test\").AbsPath(fmt.Sprintf(\"/api/v1/namespaces/default/secrets/test\")).", "commid": "kubernetes_pr_84963"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2e980982f61b83c27c7ae4bdf180c05d465fe500056a9b182ab82110619c2947", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: It returns an error when I create a pod of yaml file over 1M. I checked the codes and found that the coded wrong. It should be \u201cjson.Unmarshal(p.patchBytes, &v)\u201d, not \u201cjson.Unmarshal(p.patchBytes, v)\u201d in the 344 and 368 line. What you expected to happen: It can be parsed correctly. How to reproduce it (as minimally and precisely as possible): Look at the code and you'll see or you can test it. Anything else we need to know?: no. Environment: Kubernetes version (use ): Community latest code Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/kind bug\n/sig api-machinery\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-d60f5361ad8552ff5c09ea2aee9725c23fc3508ed916d7092305db3ff96dbb04", "text": "t.Errorf(\"expected success or bad request err, got %#v\", err) } }) <ins> t.Run(\"ApplyPatchType should handle a valid patch just under the max limit\", func(t *testing.T) { patchBody := []byte(`{\"apiVersion\":\"v1\",\"kind\":\"Secret\"` + strings.Repeat(\" \", 3*1024*1024-100) + `}`) err = rest.Patch(types.ApplyPatchType).Param(\"fieldManager\", \"test\").AbsPath(fmt.Sprintf(\"/api/v1/namespaces/default/secrets/test\")). Body(patchBody).Do().Error() if err != nil { t.Errorf(\"unexpected error: %v\", err) } }) </ins> t.Run(\"Delete should limit the request body size\", func(t *testing.T) { err = c.Delete().AbsPath(fmt.Sprintf(\"/api/v1/namespaces/default/secrets/test\")). Body(hugeData).Do().Error()", "commid": "kubernetes_pr_84963"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-754626d269fd40f941348e993264e68393021cfd29fde0f04b37efaba8a1dae3", "query": "What happened: While testing out the flag, I created a manifest with the following contents: I ran , and the resources appeared on my minikube cluster: Then, I removed the deployment from the manifest: And re-ran the same command, . To my surprise, however, the deployment wasn't removed; the only output from kubectl was . What you expected to happen: I expected the pruner to find the deployment with the matching label, , and prune it. How to reproduce it (as minimally and precisely as possible): I believe my example above is minimal and easily reproducible. Anything else we need to know?: This small change to the code for resolves the issue: Environment: Kubernetes version (use ): v1.16.3 Cloud provider or hardware configuration: N/A OS (e.g: ): N/A Kernel (e.g. ): N/A Install tools: N/A Network plugin and version (if this is a network-related bug): N/A Others: N/A\n/sig cli\n/assign cc", "positive_passages": [{"docid": "doc-en-kubernetes-2ed962974f9e2a41f59af0b16789012ddc7520ab4b86611085e9092696a42420", "text": "} } <ins> // Enforce CLI specified namespace on server request. if o.EnforceNamespace { o.VisitedNamespaces.Insert(o.Namespace) } </ins> // Generates the objects using the resource builder if they have not // already been stored by calling \"SetObjects()\" in the pre-processor. infos, err := o.GetObjects()", "commid": "kubernetes_pr_85613"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-754626d269fd40f941348e993264e68393021cfd29fde0f04b37efaba8a1dae3", "query": "What happened: While testing out the flag, I created a manifest with the following contents: I ran , and the resources appeared on my minikube cluster: Then, I removed the deployment from the manifest: And re-ran the same command, . To my surprise, however, the deployment wasn't removed; the only output from kubectl was . What you expected to happen: I expected the pruner to find the deployment with the matching label, , and prune it. How to reproduce it (as minimally and precisely as possible): I believe my example above is minimal and easily reproducible. Anything else we need to know?: This small change to the code for resolves the issue: Environment: Kubernetes version (use ): v1.16.3 Cloud provider or hardware configuration: N/A OS (e.g: ): N/A Kernel (e.g. ): N/A Install tools: N/A Network plugin and version (if this is a network-related bug): N/A Others: N/A\n/sig cli\n/assign cc", "positive_passages": [{"docid": "doc-en-kubernetes-ce88f1d888398b1723ec1d056b142b5201b82198851e9eb266e49b3e08578d2f", "text": "} if errors.IsConflict(err) { err = fmt.Errorf(`%v Please review the fields above--they currently have other managers. Here are the ways you can resolve this warning: * If you intend to manage all of these fields, please re-run the apply", "commid": "kubernetes_pr_85613"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-754626d269fd40f941348e993264e68393021cfd29fde0f04b37efaba8a1dae3", "query": "What happened: While testing out the flag, I created a manifest with the following contents: I ran , and the resources appeared on my minikube cluster: Then, I removed the deployment from the manifest: And re-ran the same command, . To my surprise, however, the deployment wasn't removed; the only output from kubectl was . What you expected to happen: I expected the pruner to find the deployment with the matching label, , and prune it. How to reproduce it (as minimally and precisely as possible): I believe my example above is minimal and easily reproducible. Anything else we need to know?: This small change to the code for resolves the issue: Environment: Kubernetes version (use ): v1.16.3 Cloud provider or hardware configuration: N/A OS (e.g: ): N/A Kernel (e.g. ): N/A Install tools: N/A Network plugin and version (if this is a network-related bug): N/A Others: N/A\n/sig cli\n/assign cc", "positive_passages": [{"docid": "doc-en-kubernetes-d447385b890f931146592aec1d279ac84350269ede9d27ef96095cb34b3aabe6", "text": "* You may co-own fields by updating your manifest to match the existing value; in this case, you'll become the manager if the other manager(s) stop managing the field (remove it from their configuration). See http://k8s.io/docs/reference/using-api/api-concepts/#conflicts`, err) } return err", "commid": "kubernetes_pr_85613"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-754626d269fd40f941348e993264e68393021cfd29fde0f04b37efaba8a1dae3", "query": "What happened: While testing out the flag, I created a manifest with the following contents: I ran , and the resources appeared on my minikube cluster: Then, I removed the deployment from the manifest: And re-ran the same command, . To my surprise, however, the deployment wasn't removed; the only output from kubectl was . What you expected to happen: I expected the pruner to find the deployment with the matching label, , and prune it. How to reproduce it (as minimally and precisely as possible): I believe my example above is minimal and easily reproducible. Anything else we need to know?: This small change to the code for resolves the issue: Environment: Kubernetes version (use ): v1.16.3 Cloud provider or hardware configuration: N/A OS (e.g: ): N/A Kernel (e.g. ): N/A Install tools: N/A Network plugin and version (if this is a network-related bug): N/A Others: N/A\n/sig cli\n/assign cc", "positive_passages": [{"docid": "doc-en-kubernetes-d7ee5bdc648b2e686f153cd7212792672c86bbea5698ecd3b8a15d7adf9ddd9a", "text": "} } <ins> func TestApplyPruneObjects(t *testing.T) { cmdtesting.InitTestErrorHandler(t) nameRC, currentRC := readAndAnnotateReplicationController(t, filenameRC) pathRC := \"/namespaces/test/replicationcontrollers/\" + nameRC for _, fn := range testingOpenAPISchemaFns { t.Run(\"test apply returns correct output\", func(t *testing.T) { tf := cmdtesting.NewTestFactory().WithNamespace(\"test\") defer tf.Cleanup() tf.UnstructuredClient = &fake.RESTClient{ NegotiatedSerializer: resource.UnstructuredPlusDefaultContentConfig().NegotiatedSerializer, Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) { switch p, m := req.URL.Path, req.Method; { case p == pathRC && m == \"GET\": bodyRC := ioutil.NopCloser(bytes.NewReader(currentRC)) return &http.Response{StatusCode: http.StatusOK, Header: cmdtesting.DefaultHeader(), Body: bodyRC}, nil case p == pathRC && m == \"PATCH\": validatePatchApplication(t, req) bodyRC := ioutil.NopCloser(bytes.NewReader(currentRC)) return &http.Response{StatusCode: http.StatusOK, Header: cmdtesting.DefaultHeader(), Body: bodyRC}, nil default: t.Fatalf(\"unexpected request: %#vn%#v\", req.URL, req) return nil, nil } }), } tf.OpenAPISchemaFunc = fn tf.ClientConfigVal = cmdtesting.DefaultClientConfig() ioStreams, _, buf, errBuf := genericclioptions.NewTestIOStreams() cmd := NewCmdApply(\"kubectl\", tf, ioStreams) cmd.Flags().Set(\"filename\", filenameRC) cmd.Flags().Set(\"prune\", \"true\") cmd.Flags().Set(\"namespace\", \"test\") cmd.Flags().Set(\"output\", \"yaml\") cmd.Flags().Set(\"all\", \"true\") cmd.Run(cmd, []string{}) if !strings.Contains(buf.String(), \"test-rc\") { t.Fatalf(\"unexpected output: %snexpected to contain: %s\", buf.String(), \"test-rc\") } if errBuf.String() != \"\" { t.Fatalf(\"unexpected error output: %s\", errBuf.String()) } }) } } </ins> func TestApplyObjectOutput(t *testing.T) { cmdtesting.InitTestErrorHandler(t) nameRC, currentRC := readAndAnnotateReplicationController(t, filenameRC)", "commid": "kubernetes_pr_85613"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aaa23a6dfbac4923cc88d1230b36a82c16015c99fdfc56d40a0659c9be5002f8", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When trying to use the webhookConversionServer, im getting . I was able to figure out that the unicode character displayed maps to port 443. see code What you expected to happen: If the service reference doesnt define 443, it should show an error that the service doesnt have the port number (whatever the number may be). How to reproduce it (as minimally and precisely as possible): your service (missing the default port 443) your CRD (one version no conversion webhook) your resource at this old version crd with new version and conversion webhook, and use new version for storage. to get the resource yaml, and see error Anything else we need to know?: current implementation will convert port number into a unicode character. ie. im seeing where . Must use instead of to maintain decimal. Environment: Kubernetes version (use ): v1.15.4+IKS Cloud provider or hardware configuration: IBM IKS OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery\nAre you planning to send out a PR ?\ni was going to.. but didnt know which repo was relevant and didnt feel like reading through all contibution gorp.\nCreated a PR to fix the message output.", "positive_passages": [{"docid": "doc-en-kubernetes-bc4ef2ac35ca7cdc3797296760bf1ca371c187b93885ef71195ad8c18f670b35", "text": "return &svcPort, nil } } <del> return nil, errors.NewServiceUnavailable(fmt.Sprintf(\"no service port %q found for service %q\", port, svc.Name)) </del> <ins> return nil, errors.NewServiceUnavailable(fmt.Sprintf(\"no service port %d found for service %q\", port, svc.Name)) </ins> } // ResourceLocation returns a URL to which one can send traffic for the specified service.", "commid": "kubernetes_pr_85558"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-de464a32cf340b19edfa7e83f192f3b1617eeff5aab3c9a4e1e526a7d46b9840", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Azure cloud provider is sending unexpected LoadBalancer update requests even if the LoadBalancer rules are already identical. The reason is GetIdleTimeout() returns nil when the annotation is not set While find rule doens't check whether it is nil or not. What you expected to happen: Azure cloud provider shouldn't send unexpected LoadBalancer updates. It is easily to get throttled if there're too many services running on the cluster. How to reproduce it (as minimally and precisely as possible): kubectl annotate service nginx testlabel=value Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /kind bug /area provider/azure /assign\n/sig cloud-provider", "positive_passages": [{"docid": "doc-en-kubernetes-314194f5f320f0449ab88ce779a3cd3cfae0d3243e911a62486b1c6df02d67cf", "text": "reflect.DeepEqual(s.EnableTCPReset, t.EnableTCPReset) && reflect.DeepEqual(s.DisableOutboundSnat, t.DisableOutboundSnat) <del> if wantLB { </del> <ins> if wantLB && s.IdleTimeoutInMinutes != nil && t.IdleTimeoutInMinutes != nil { </ins> return properties && reflect.DeepEqual(s.IdleTimeoutInMinutes, t.IdleTimeoutInMinutes) } return properties", "commid": "kubernetes_pr_85990"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-de464a32cf340b19edfa7e83f192f3b1617eeff5aab3c9a4e1e526a7d46b9840", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Azure cloud provider is sending unexpected LoadBalancer update requests even if the LoadBalancer rules are already identical. The reason is GetIdleTimeout() returns nil when the annotation is not set While find rule doens't check whether it is nil or not. What you expected to happen: Azure cloud provider shouldn't send unexpected LoadBalancer updates. It is easily to get throttled if there're too many services running on the cluster. How to reproduce it (as minimally and precisely as possible): kubectl annotate service nginx testlabel=value Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /kind bug /area provider/azure /assign\n/sig cloud-provider", "positive_passages": [{"docid": "doc-en-kubernetes-a9b8b34940d57a9631781638362d02269d2368e9e38f39bdb7c88913253d4b40", "text": "expected: false, }, { <ins> msg: \"rule names match while idletimeout unmatch should return false\", existingRule: []network.LoadBalancingRule{ { Name: to.StringPtr(\"httpRule\"), LoadBalancingRulePropertiesFormat: &network.LoadBalancingRulePropertiesFormat{ IdleTimeoutInMinutes: to.Int32Ptr(1), }, }, }, curRule: network.LoadBalancingRule{ Name: to.StringPtr(\"httpRule\"), LoadBalancingRulePropertiesFormat: &network.LoadBalancingRulePropertiesFormat{ IdleTimeoutInMinutes: to.Int32Ptr(2), }, }, expected: false, }, { msg: \"rule names match while idletimeout nil should return true\", existingRule: []network.LoadBalancingRule{ { Name:                              to.StringPtr(\"httpRule\"), LoadBalancingRulePropertiesFormat: &network.LoadBalancingRulePropertiesFormat{}, }, }, curRule: network.LoadBalancingRule{ Name: to.StringPtr(\"httpRule\"), LoadBalancingRulePropertiesFormat: &network.LoadBalancingRulePropertiesFormat{ IdleTimeoutInMinutes: to.Int32Ptr(2), }, }, expected: true, }, { </ins> msg: \"rule names match while LoadDistribution unmatch should return false\", existingRule: []network.LoadBalancingRule{ {", "commid": "kubernetes_pr_85990"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f4017862a33fbac1520d07447f039f12ce4e46548fea44bde023d16fb063d85c", "query": "If you give a prerelease version to , it'll match both and . Based on this logic: We'll end up trying to pull binaries for this prerelease from the CI bucket () rather than the release bucket (). These pre-release versions are usually* pushed to the release bucket as part of the release process (e.g. ), and so should probably prefer these over the CI versions (which may or may not exist, depending on whether a commit was pushed to the release branch between when the tag was created and the build occurred). More explicitly, the current logic is: the release bucket by default. a version matches the CI regex, use the CI bucket. , if a version matches the release regex, we're good - continue to use the default (release bucket). , bail out - invalid version. The correct logic would probably be something like the release bucket by default. a version matches the release version regex, continue to use the release bucket. , if a version doesn't match the release version regex, but it matches the CI regex, use the CI bucket. it matches neither, bail out. Important note: due to our hotfix for , there is a somewhat fake prerelease tag () which doesn't have any bits in the release bucket, and we expect others soon. We should not fix this bug in until the latest pointers in the CI bucket do not point to valid release/prerelease versions.\n/sig testing /sig release I guess?\n/area release-eng /priority critical-urgent /assign /milestone v1.18\nHello With code freeze approaching for 1.18 (5 March), can you please check if the current issue is still intended for milestone 1.18?\n-- I'm pretty sure I can get to this before the cycle is out.\nif our current approach for tagging release branch pre-releases doesn't trigger this, this seems like it is not critical for the milestone, is that correct?\n-- Good point! /milestone v1.19 /remove-priority critical-urgent /priority important-soon\nGiven the priority dip on this one, I think it's fine for someone in Releng other than Tim or I to pick this up. /unassign -- This is a good one to work on. /help\nI can look that, after the release 1.18, if is that fine then can we have a short discussion about this one? /remove-help /assign\n-- SGTM", "positive_passages": [{"docid": "doc-en-kubernetes-8f7d889af3fb19085c7630e326fa852a8dc6c0e4cf8a395b5744b6a5284b7bfa", "text": "# Translate a published version <bucket>/<version> (e.g. \"release/stable\") to version number. set_binary_version \"${release}\" if [[ -z \"${KUBERNETES_SKIP_RELEASE_VALIDATION-}\" ]]; then <del> if [[ ${KUBE_VERSION} =~ ${KUBE_CI_VERSION_REGEX} ]]; then </del> <ins> if [[ ${KUBE_VERSION} =~ ${KUBE_RELEASE_VERSION_REGEX} ]]; then # Use KUBERNETES_RELEASE_URL for Releases and Pre-Releases # ie. 1.18.0 or 1.19.0-beta.0 KUBERNETES_RELEASE_URL=\"${KUBERNETES_RELEASE_URL}\" elif [[ ${KUBE_VERSION} =~ ${KUBE_CI_VERSION_REGEX} ]]; then </ins> # Override KUBERNETES_RELEASE_URL to point to the CI bucket; # this will be used by get-kube-binaries.sh. <ins> # ie. v1.19.0-beta.0.318+b618411f1edb98 </ins> KUBERNETES_RELEASE_URL=\"${KUBERNETES_CI_RELEASE_URL}\" <del> elif ! [[ ${KUBE_VERSION} =~ ${KUBE_RELEASE_VERSION_REGEX} ]]; then </del> <ins> else </ins> echo \"Version doesn't match regexp\" >&2 exit 1 fi", "commid": "kubernetes_pr_91635"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d229adfbea12aef3b49af22ccc6144a0f39cff69fa180ff4396be871aeac05e1", "query": "What would you like to be : There are many useful scripts in \"\". For example, I often use and for creating simple k8s cluster quickly. However, there are only few explanation or nothing how to use it. I think it becomes more useful and helpful if some instruction or guidance is explained in each script. Why is this needed: It aims and expects to increase new k8s developers by describing how to use each script. My proposal Add the following description under the copyright for each script file. Overview of the script Simple usage Supplementary explanation(This is option) Other concern I would like to know the purpose of use about hack directory. (e.g. Where to put tools for developers(therefore there is no guidance?).)\nI don't know who is in charge of each scripts of hack, but if he agrees the idea of this feature request , I am going to do this task myself!!\n/sig testing\nI believe there is a script generating swagger/openapi specfilters under hack, but I am still struggling with it. It could be of great help if there is some how-to doc for each scripts.\nthis basis, why not create a file under the hack folder, because a lot of kk CIs are derived from multiple script commands under the hack. There are already 268+ files under the hack file. For contributors unfamiliar with these, these comments and instructions are helpful to them, and it is also helpful for new contributors to handle pr ci error reports.\n/cc What do you think\nI think it's good idea to create (It may be easy to understand if the script's explanation is described by category or use in ) Apart from that, it is helpful that the script file itself has a brief description.\nWhen we create , it may tough work if creating it including all scripts explanation at one time. (There are many scripts and I understand only some scripts now.) Regarding , current my idea is to add a description to each script little by little and update the at the same time. This means that will be completed little by little in conjunction with adding the description of each script. In the future, if someone create new script in hack, he also may have to add description of his script into\nSelf-documenting commands sound useful. A high level overview also sounds useful.\n/cc /cc Regarding adding help information, I suggest that we can submit pr in one or several files as a unit, so that we can track and statistics. For the documentation, I think it should be concise and not too long. How about this advice? We can claim tasks through , the pr title yes , i agree with you. [x] kubernetes/hack/benchmark- [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] kubernetes/hack/boilerplate/BUILD [ ] kubernetes/hack/boilerplate/test/BUILD [ ] [ ] [ ] [ ] [ ] kubernetes/hack/BUILD [x] kubernetes/hack/build- [x] kubernetes/hack/build- [x] [ ] kubernetes/hack/conformance/BUILD [ ] [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-push- [ ] kubernetes/hack/e2e-internal/BUILD [ ] kubernetes/hack/e2e-internal/e2e-cluster- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e-grow- [ ] kubernetes/hack/e2e-internal/e2e-shrink- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e- [x] kubernetes/hack/e2e-node- [ ] kubernetes/hack/generate- [x] kubernetes/hack/generate- [ ] kubernetes/hack/gen-swagger-doc/gen-swagger- [x] kubernetes/hack/get- [x] kubernetes/hack/ginkgo- [x] kubernetes/hack/grab- [x] kubernetes/hack/install- [ ] kubernetes/hack/jenkins/benchmark- [ ] kubernetes/hack/jenkins/OWNERS [ ] [ ] kubernetes/hack/jenkins/test- [ ] kubernetes/hack/jenkins/verify- [ ] kubernetes/hack/lib/BUILD [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [x] kubernetes/hack/lint- [x] kubernetes/hack/list-feature- [x] kubernetes/hack/local-up- [ ] kubernetes/hack/make-rules/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/subdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-without-gofiles/README [ ] kubernetes/hack/make-rules/Makefile.manifest [ ] kubernetes/hack/make-rules/make- [ ] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make-rules/test-e2e- [ ] kubernetes/hack/make-rules/test-e2e- [x] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/OWNERS [x] kubernetes/hack/pin- [x] kubernetes/hack/print-workspace- [x] kubernetes/hack/run-in- [ ] kubernetes/hack/testdata/auth- [x] [x] [x] kubernetes/hack/testdata/CRD/foo-- [x] kubernetes/hack/testdata/CRD/foo-deleted- [x] kubernetes/hack/testdata/CRD/foo-updated- [x] [x] kubernetes/hack/testdata/CRD/multi-crd-list-- [x] kubernetes/hack/testdata/CRD/multi-crd-list-deleted- [x] kubernetes/hack/testdata/CRD/multi-crd-list-updated- [x] kubernetes/hack/testdata/CRD/multi-crd- [x] [x] [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-multicontainer- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment-with- [x] [x] [x] [x] [x] [x] kubernetes/hack/testdata/filter/pod-apply- [x] kubernetes/hack/testdata/filter/pod-dont- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/invalid-rc-with-empty- [x] kubernetes/hack/testdata/kubernetes- [x] [x] [x] [x] [x] [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-json- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-list- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-rclist- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-svclist- [x] kubernetes/hack/testdata/multi-resource-yaml- [x] kubernetes/hack/testdata/multi-resource- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/OWNERS [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod-with-api- [x] kubernetes/hack/testdata/pod-with-large- [x] kubernetes/hack/testdata/pod-with- [x] [x] [x] [x] [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/recursive/deployment/deployment/nginx- [x] [x] [x] [x] [x] kubernetes/hack/testdata/recursive/pod/pod/busybox- [x] [x] [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod-modify/pod/busybox- [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod- [x] [x] kubernetes/hack/testdata/recursive/rc/rc/busybox- [x] [x] [x] kubernetes/hack/testdata/redis-slave- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/rollingupdate-daemonset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/rollingupdate-statefulset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/scale-deploy-1.yaml [x] kubernetes/hack/testdata/scale-deploy-2.yaml [x] kubernetes/hack/testdata/scale-deploy-3.yaml [x] [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [ ] [ ] [x] kubernetes/hack/test- [ ] kubernetes/hack/test- [x] kubernetes/hack/update- [ ] kubernetes/hack/update- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-generated-api-compatibility- [x] kubernetes/hack/update-generated-device-plugin- [ ] kubernetes/hack/update-generated-device- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-kms- [ ] kubernetes/hack/update-generated- [x] kubernetes/hack/update-generated-kubelet-plugin-registration- [ ] kubernetes/hack/update-generated-kubelet-plugin- [x] kubernetes/hack/update-generated-pod-resources- [ ] kubernetes/hack/update-generated-pod- [ ] kubernetes/hack/update-generated-protobuf- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-runtime- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-swagger- [x] kubernetes/hack/update- [x] kubernetes/hack/update-import- [ ] kubernetes/hack/update-openapi- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-vendor- [ ] kubernetes/hack/update- [ ] kubernetes/hack/update-workspace- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-api- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-cli- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-conformance- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-external-dependencies- [ ] kubernetes/hack/verify-flags/excluded- [x] kubernetes/hack/verify-flags/OWNERS [x] kubernetes/hack/OWNERS [ ] kubernetes/hack/verify-flags- [x] kubernetes/hack/verify-generated-device- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-files- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-kubelet-plugin- [x] kubernetes/hack/verify-generated-pod- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-swagger- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-no-vendor- [x] kubernetes/hack/verify-openapi- [x] kubernetes/hack/verify-pkg- [x] kubernetes/hack/verify-publishing- [x] kubernetes/hack/verify-readonly- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-staging-meta- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-typecheck- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-vendor- [x] kubernetes/hack/verify- [x]\ni will pick up , i will do it step by step.\nI agree with your idea, and thanks the checkbox to check progress. there are many scripts, so let's work together!\n/assign /assign\nI will pick up hack/verify-\nI will pick up hack/verify-\nI will pick up hack/verify- (all of verify scripts). But there are large number of scripts(over 40), I want to split it into two or three PRs.\nI will pick up hack/update-\nI will pick up these scripts. kubernetes/hack/benchmark- kubernetes/hack/build- kubernetes/hack/build- kubernetes/hack/dev-build-and- kubernetes/hack/dev-build-and- kubernetes/hack/dev-push- kubernetes/hack/e2e-node- kubernetes/hack/generate-\nI will pick up these scripts get- ginkgo- grab- install- lint- list-feature- local-up- pin- print-workspace- run-in- test- test-\nHow about this now? /help Marking this tag so that others can easily access it.\nThis request has been marked as needing help from a contributor. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : How about this now? /help Marking this tag so that others can easily access it. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI think we've finished adding simple explanations to the almost scripts. It seems that several scripts of update- does not complete yet. I think we may able to close after that work.\nI will pick up these scripts:\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-450485b507cab32ababb87b967fa70364fc95122c493305b1711d07b7815dd18", "text": "# See the License for the specific language governing permissions and # limitations under the License. <ins> # This script generates `/pkg/kubelet/apis/podresources/v1alpha1/api.pb.go` # from the protobuf file `/pkg/kubelet/apis/podresources/v1alpha1/api.proto` # for pods. # Usage: `hack/update-generated-pod-resources.sh`. </ins> set -o errexit set -o nounset set -o pipefail", "commid": "kubernetes_pr_91479"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d229adfbea12aef3b49af22ccc6144a0f39cff69fa180ff4396be871aeac05e1", "query": "What would you like to be : There are many useful scripts in \"\". For example, I often use and for creating simple k8s cluster quickly. However, there are only few explanation or nothing how to use it. I think it becomes more useful and helpful if some instruction or guidance is explained in each script. Why is this needed: It aims and expects to increase new k8s developers by describing how to use each script. My proposal Add the following description under the copyright for each script file. Overview of the script Simple usage Supplementary explanation(This is option) Other concern I would like to know the purpose of use about hack directory. (e.g. Where to put tools for developers(therefore there is no guidance?).)\nI don't know who is in charge of each scripts of hack, but if he agrees the idea of this feature request , I am going to do this task myself!!\n/sig testing\nI believe there is a script generating swagger/openapi specfilters under hack, but I am still struggling with it. It could be of great help if there is some how-to doc for each scripts.\nthis basis, why not create a file under the hack folder, because a lot of kk CIs are derived from multiple script commands under the hack. There are already 268+ files under the hack file. For contributors unfamiliar with these, these comments and instructions are helpful to them, and it is also helpful for new contributors to handle pr ci error reports.\n/cc What do you think\nI think it's good idea to create (It may be easy to understand if the script's explanation is described by category or use in ) Apart from that, it is helpful that the script file itself has a brief description.\nWhen we create , it may tough work if creating it including all scripts explanation at one time. (There are many scripts and I understand only some scripts now.) Regarding , current my idea is to add a description to each script little by little and update the at the same time. This means that will be completed little by little in conjunction with adding the description of each script. In the future, if someone create new script in hack, he also may have to add description of his script into\nSelf-documenting commands sound useful. A high level overview also sounds useful.\n/cc /cc Regarding adding help information, I suggest that we can submit pr in one or several files as a unit, so that we can track and statistics. For the documentation, I think it should be concise and not too long. How about this advice? We can claim tasks through , the pr title yes , i agree with you. [x] kubernetes/hack/benchmark- [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] kubernetes/hack/boilerplate/BUILD [ ] kubernetes/hack/boilerplate/test/BUILD [ ] [ ] [ ] [ ] [ ] kubernetes/hack/BUILD [x] kubernetes/hack/build- [x] kubernetes/hack/build- [x] [ ] kubernetes/hack/conformance/BUILD [ ] [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-push- [ ] kubernetes/hack/e2e-internal/BUILD [ ] kubernetes/hack/e2e-internal/e2e-cluster- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e-grow- [ ] kubernetes/hack/e2e-internal/e2e-shrink- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e- [x] kubernetes/hack/e2e-node- [ ] kubernetes/hack/generate- [x] kubernetes/hack/generate- [ ] kubernetes/hack/gen-swagger-doc/gen-swagger- [x] kubernetes/hack/get- [x] kubernetes/hack/ginkgo- [x] kubernetes/hack/grab- [x] kubernetes/hack/install- [ ] kubernetes/hack/jenkins/benchmark- [ ] kubernetes/hack/jenkins/OWNERS [ ] [ ] kubernetes/hack/jenkins/test- [ ] kubernetes/hack/jenkins/verify- [ ] kubernetes/hack/lib/BUILD [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [x] kubernetes/hack/lint- [x] kubernetes/hack/list-feature- [x] kubernetes/hack/local-up- [ ] kubernetes/hack/make-rules/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/subdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-without-gofiles/README [ ] kubernetes/hack/make-rules/Makefile.manifest [ ] kubernetes/hack/make-rules/make- [ ] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make-rules/test-e2e- [ ] kubernetes/hack/make-rules/test-e2e- [x] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/OWNERS [x] kubernetes/hack/pin- [x] kubernetes/hack/print-workspace- [x] kubernetes/hack/run-in- [ ] kubernetes/hack/testdata/auth- [x] [x] [x] kubernetes/hack/testdata/CRD/foo-- [x] kubernetes/hack/testdata/CRD/foo-deleted- [x] kubernetes/hack/testdata/CRD/foo-updated- [x] [x] kubernetes/hack/testdata/CRD/multi-crd-list-- [x] kubernetes/hack/testdata/CRD/multi-crd-list-deleted- [x] kubernetes/hack/testdata/CRD/multi-crd-list-updated- [x] kubernetes/hack/testdata/CRD/multi-crd- [x] [x] [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-multicontainer- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment-with- [x] [x] [x] [x] [x] [x] kubernetes/hack/testdata/filter/pod-apply- [x] kubernetes/hack/testdata/filter/pod-dont- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/invalid-rc-with-empty- [x] kubernetes/hack/testdata/kubernetes- [x] [x] [x] [x] [x] [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-json- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-list- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-rclist- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-svclist- [x] kubernetes/hack/testdata/multi-resource-yaml- [x] kubernetes/hack/testdata/multi-resource- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/OWNERS [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod-with-api- [x] kubernetes/hack/testdata/pod-with-large- [x] kubernetes/hack/testdata/pod-with- [x] [x] [x] [x] [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/recursive/deployment/deployment/nginx- [x] [x] [x] [x] [x] kubernetes/hack/testdata/recursive/pod/pod/busybox- [x] [x] [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod-modify/pod/busybox- [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod- [x] [x] kubernetes/hack/testdata/recursive/rc/rc/busybox- [x] [x] [x] kubernetes/hack/testdata/redis-slave- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/rollingupdate-daemonset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/rollingupdate-statefulset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/scale-deploy-1.yaml [x] kubernetes/hack/testdata/scale-deploy-2.yaml [x] kubernetes/hack/testdata/scale-deploy-3.yaml [x] [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [ ] [ ] [x] kubernetes/hack/test- [ ] kubernetes/hack/test- [x] kubernetes/hack/update- [ ] kubernetes/hack/update- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-generated-api-compatibility- [x] kubernetes/hack/update-generated-device-plugin- [ ] kubernetes/hack/update-generated-device- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-kms- [ ] kubernetes/hack/update-generated- [x] kubernetes/hack/update-generated-kubelet-plugin-registration- [ ] kubernetes/hack/update-generated-kubelet-plugin- [x] kubernetes/hack/update-generated-pod-resources- [ ] kubernetes/hack/update-generated-pod- [ ] kubernetes/hack/update-generated-protobuf- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-runtime- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-swagger- [x] kubernetes/hack/update- [x] kubernetes/hack/update-import- [ ] kubernetes/hack/update-openapi- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-vendor- [ ] kubernetes/hack/update- [ ] kubernetes/hack/update-workspace- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-api- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-cli- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-conformance- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-external-dependencies- [ ] kubernetes/hack/verify-flags/excluded- [x] kubernetes/hack/verify-flags/OWNERS [x] kubernetes/hack/OWNERS [ ] kubernetes/hack/verify-flags- [x] kubernetes/hack/verify-generated-device- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-files- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-kubelet-plugin- [x] kubernetes/hack/verify-generated-pod- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-swagger- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-no-vendor- [x] kubernetes/hack/verify-openapi- [x] kubernetes/hack/verify-pkg- [x] kubernetes/hack/verify-publishing- [x] kubernetes/hack/verify-readonly- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-staging-meta- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-typecheck- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-vendor- [x] kubernetes/hack/verify- [x]\ni will pick up , i will do it step by step.\nI agree with your idea, and thanks the checkbox to check progress. there are many scripts, so let's work together!\n/assign /assign\nI will pick up hack/verify-\nI will pick up hack/verify-\nI will pick up hack/verify- (all of verify scripts). But there are large number of scripts(over 40), I want to split it into two or three PRs.\nI will pick up hack/update-\nI will pick up these scripts. kubernetes/hack/benchmark- kubernetes/hack/build- kubernetes/hack/build- kubernetes/hack/dev-build-and- kubernetes/hack/dev-build-and- kubernetes/hack/dev-push- kubernetes/hack/e2e-node- kubernetes/hack/generate-\nI will pick up these scripts get- ginkgo- grab- install- lint- list-feature- local-up- pin- print-workspace- run-in- test- test-\nHow about this now? /help Marking this tag so that others can easily access it.\nThis request has been marked as needing help from a contributor. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : How about this now? /help Marking this tag so that others can easily access it. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI think we've finished adding simple explanations to the almost scripts. It seems that several scripts of update- does not complete yet. I think we may able to close after that work.\nI will pick up these scripts:\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-f405ca742e5d3d1c3c38cee8a75423f6697d724b5a80b24f0d585910ac6e485a", "text": "# See the License for the specific language governing permissions and # limitations under the License. <ins> # This script genertates `*/api.pb.go` from the protobuf file `*/api.proto`. # Usage: #     hack/update-generated-protobuf-dockerized.sh \"${APIROOTS}\" #     An example APIROOT is: \"k8s.io/api/admissionregistration/v1\" </ins> set -o errexit set -o nounset set -o pipefail", "commid": "kubernetes_pr_91479"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d229adfbea12aef3b49af22ccc6144a0f39cff69fa180ff4396be871aeac05e1", "query": "What would you like to be : There are many useful scripts in \"\". For example, I often use and for creating simple k8s cluster quickly. However, there are only few explanation or nothing how to use it. I think it becomes more useful and helpful if some instruction or guidance is explained in each script. Why is this needed: It aims and expects to increase new k8s developers by describing how to use each script. My proposal Add the following description under the copyright for each script file. Overview of the script Simple usage Supplementary explanation(This is option) Other concern I would like to know the purpose of use about hack directory. (e.g. Where to put tools for developers(therefore there is no guidance?).)\nI don't know who is in charge of each scripts of hack, but if he agrees the idea of this feature request , I am going to do this task myself!!\n/sig testing\nI believe there is a script generating swagger/openapi specfilters under hack, but I am still struggling with it. It could be of great help if there is some how-to doc for each scripts.\nthis basis, why not create a file under the hack folder, because a lot of kk CIs are derived from multiple script commands under the hack. There are already 268+ files under the hack file. For contributors unfamiliar with these, these comments and instructions are helpful to them, and it is also helpful for new contributors to handle pr ci error reports.\n/cc What do you think\nI think it's good idea to create (It may be easy to understand if the script's explanation is described by category or use in ) Apart from that, it is helpful that the script file itself has a brief description.\nWhen we create , it may tough work if creating it including all scripts explanation at one time. (There are many scripts and I understand only some scripts now.) Regarding , current my idea is to add a description to each script little by little and update the at the same time. This means that will be completed little by little in conjunction with adding the description of each script. In the future, if someone create new script in hack, he also may have to add description of his script into\nSelf-documenting commands sound useful. A high level overview also sounds useful.\n/cc /cc Regarding adding help information, I suggest that we can submit pr in one or several files as a unit, so that we can track and statistics. For the documentation, I think it should be concise and not too long. How about this advice? We can claim tasks through , the pr title yes , i agree with you. [x] kubernetes/hack/benchmark- [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] kubernetes/hack/boilerplate/BUILD [ ] kubernetes/hack/boilerplate/test/BUILD [ ] [ ] [ ] [ ] [ ] kubernetes/hack/BUILD [x] kubernetes/hack/build- [x] kubernetes/hack/build- [x] [ ] kubernetes/hack/conformance/BUILD [ ] [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-push- [ ] kubernetes/hack/e2e-internal/BUILD [ ] kubernetes/hack/e2e-internal/e2e-cluster- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e-grow- [ ] kubernetes/hack/e2e-internal/e2e-shrink- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e- [x] kubernetes/hack/e2e-node- [ ] kubernetes/hack/generate- [x] kubernetes/hack/generate- [ ] kubernetes/hack/gen-swagger-doc/gen-swagger- [x] kubernetes/hack/get- [x] kubernetes/hack/ginkgo- [x] kubernetes/hack/grab- [x] kubernetes/hack/install- [ ] kubernetes/hack/jenkins/benchmark- [ ] kubernetes/hack/jenkins/OWNERS [ ] [ ] kubernetes/hack/jenkins/test- [ ] kubernetes/hack/jenkins/verify- [ ] kubernetes/hack/lib/BUILD [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [x] kubernetes/hack/lint- [x] kubernetes/hack/list-feature- [x] kubernetes/hack/local-up- [ ] kubernetes/hack/make-rules/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/subdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-without-gofiles/README [ ] kubernetes/hack/make-rules/Makefile.manifest [ ] kubernetes/hack/make-rules/make- [ ] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make-rules/test-e2e- [ ] kubernetes/hack/make-rules/test-e2e- [x] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/OWNERS [x] kubernetes/hack/pin- [x] kubernetes/hack/print-workspace- [x] kubernetes/hack/run-in- [ ] kubernetes/hack/testdata/auth- [x] [x] [x] kubernetes/hack/testdata/CRD/foo-- [x] kubernetes/hack/testdata/CRD/foo-deleted- [x] kubernetes/hack/testdata/CRD/foo-updated- [x] [x] kubernetes/hack/testdata/CRD/multi-crd-list-- [x] kubernetes/hack/testdata/CRD/multi-crd-list-deleted- [x] kubernetes/hack/testdata/CRD/multi-crd-list-updated- [x] kubernetes/hack/testdata/CRD/multi-crd- [x] [x] [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-multicontainer- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment-with- [x] [x] [x] [x] [x] [x] kubernetes/hack/testdata/filter/pod-apply- [x] kubernetes/hack/testdata/filter/pod-dont- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/invalid-rc-with-empty- [x] kubernetes/hack/testdata/kubernetes- [x] [x] [x] [x] [x] [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-json- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-list- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-rclist- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-svclist- [x] kubernetes/hack/testdata/multi-resource-yaml- [x] kubernetes/hack/testdata/multi-resource- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/OWNERS [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod-with-api- [x] kubernetes/hack/testdata/pod-with-large- [x] kubernetes/hack/testdata/pod-with- [x] [x] [x] [x] [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/recursive/deployment/deployment/nginx- [x] [x] [x] [x] [x] kubernetes/hack/testdata/recursive/pod/pod/busybox- [x] [x] [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod-modify/pod/busybox- [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod- [x] [x] kubernetes/hack/testdata/recursive/rc/rc/busybox- [x] [x] [x] kubernetes/hack/testdata/redis-slave- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/rollingupdate-daemonset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/rollingupdate-statefulset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/scale-deploy-1.yaml [x] kubernetes/hack/testdata/scale-deploy-2.yaml [x] kubernetes/hack/testdata/scale-deploy-3.yaml [x] [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [ ] [ ] [x] kubernetes/hack/test- [ ] kubernetes/hack/test- [x] kubernetes/hack/update- [ ] kubernetes/hack/update- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-generated-api-compatibility- [x] kubernetes/hack/update-generated-device-plugin- [ ] kubernetes/hack/update-generated-device- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-kms- [ ] kubernetes/hack/update-generated- [x] kubernetes/hack/update-generated-kubelet-plugin-registration- [ ] kubernetes/hack/update-generated-kubelet-plugin- [x] kubernetes/hack/update-generated-pod-resources- [ ] kubernetes/hack/update-generated-pod- [ ] kubernetes/hack/update-generated-protobuf- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-runtime- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-swagger- [x] kubernetes/hack/update- [x] kubernetes/hack/update-import- [ ] kubernetes/hack/update-openapi- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-vendor- [ ] kubernetes/hack/update- [ ] kubernetes/hack/update-workspace- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-api- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-cli- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-conformance- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-external-dependencies- [ ] kubernetes/hack/verify-flags/excluded- [x] kubernetes/hack/verify-flags/OWNERS [x] kubernetes/hack/OWNERS [ ] kubernetes/hack/verify-flags- [x] kubernetes/hack/verify-generated-device- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-files- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-kubelet-plugin- [x] kubernetes/hack/verify-generated-pod- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-swagger- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-no-vendor- [x] kubernetes/hack/verify-openapi- [x] kubernetes/hack/verify-pkg- [x] kubernetes/hack/verify-publishing- [x] kubernetes/hack/verify-readonly- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-staging-meta- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-typecheck- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-vendor- [x] kubernetes/hack/verify- [x]\ni will pick up , i will do it step by step.\nI agree with your idea, and thanks the checkbox to check progress. there are many scripts, so let's work together!\n/assign /assign\nI will pick up hack/verify-\nI will pick up hack/verify-\nI will pick up hack/verify- (all of verify scripts). But there are large number of scripts(over 40), I want to split it into two or three PRs.\nI will pick up hack/update-\nI will pick up these scripts. kubernetes/hack/benchmark- kubernetes/hack/build- kubernetes/hack/build- kubernetes/hack/dev-build-and- kubernetes/hack/dev-build-and- kubernetes/hack/dev-push- kubernetes/hack/e2e-node- kubernetes/hack/generate-\nI will pick up these scripts get- ginkgo- grab- install- lint- list-feature- local-up- pin- print-workspace- run-in- test- test-\nHow about this now? /help Marking this tag so that others can easily access it.\nThis request has been marked as needing help from a contributor. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : How about this now? /help Marking this tag so that others can easily access it. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI think we've finished adding simple explanations to the almost scripts. It seems that several scripts of update- does not complete yet. I think we may able to close after that work.\nI will pick up these scripts:\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-9895ac4046e5d5225abf97168583dae16c8498d163fca0813781b650d9db13ce", "text": "# See the License for the specific language governing permissions and # limitations under the License. <ins> # This script generates all go files from the corresponding protobuf files. # Usage: `hack/update-generated-protobuf.sh`. </ins> set -o errexit set -o nounset set -o pipefail", "commid": "kubernetes_pr_91479"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d229adfbea12aef3b49af22ccc6144a0f39cff69fa180ff4396be871aeac05e1", "query": "What would you like to be : There are many useful scripts in \"\". For example, I often use and for creating simple k8s cluster quickly. However, there are only few explanation or nothing how to use it. I think it becomes more useful and helpful if some instruction or guidance is explained in each script. Why is this needed: It aims and expects to increase new k8s developers by describing how to use each script. My proposal Add the following description under the copyright for each script file. Overview of the script Simple usage Supplementary explanation(This is option) Other concern I would like to know the purpose of use about hack directory. (e.g. Where to put tools for developers(therefore there is no guidance?).)\nI don't know who is in charge of each scripts of hack, but if he agrees the idea of this feature request , I am going to do this task myself!!\n/sig testing\nI believe there is a script generating swagger/openapi specfilters under hack, but I am still struggling with it. It could be of great help if there is some how-to doc for each scripts.\nthis basis, why not create a file under the hack folder, because a lot of kk CIs are derived from multiple script commands under the hack. There are already 268+ files under the hack file. For contributors unfamiliar with these, these comments and instructions are helpful to them, and it is also helpful for new contributors to handle pr ci error reports.\n/cc What do you think\nI think it's good idea to create (It may be easy to understand if the script's explanation is described by category or use in ) Apart from that, it is helpful that the script file itself has a brief description.\nWhen we create , it may tough work if creating it including all scripts explanation at one time. (There are many scripts and I understand only some scripts now.) Regarding , current my idea is to add a description to each script little by little and update the at the same time. This means that will be completed little by little in conjunction with adding the description of each script. In the future, if someone create new script in hack, he also may have to add description of his script into\nSelf-documenting commands sound useful. A high level overview also sounds useful.\n/cc /cc Regarding adding help information, I suggest that we can submit pr in one or several files as a unit, so that we can track and statistics. For the documentation, I think it should be concise and not too long. How about this advice? We can claim tasks through , the pr title yes , i agree with you. [x] kubernetes/hack/benchmark- [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] kubernetes/hack/boilerplate/BUILD [ ] kubernetes/hack/boilerplate/test/BUILD [ ] [ ] [ ] [ ] [ ] kubernetes/hack/BUILD [x] kubernetes/hack/build- [x] kubernetes/hack/build- [x] [ ] kubernetes/hack/conformance/BUILD [ ] [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-push- [ ] kubernetes/hack/e2e-internal/BUILD [ ] kubernetes/hack/e2e-internal/e2e-cluster- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e-grow- [ ] kubernetes/hack/e2e-internal/e2e-shrink- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e- [x] kubernetes/hack/e2e-node- [ ] kubernetes/hack/generate- [x] kubernetes/hack/generate- [ ] kubernetes/hack/gen-swagger-doc/gen-swagger- [x] kubernetes/hack/get- [x] kubernetes/hack/ginkgo- [x] kubernetes/hack/grab- [x] kubernetes/hack/install- [ ] kubernetes/hack/jenkins/benchmark- [ ] kubernetes/hack/jenkins/OWNERS [ ] [ ] kubernetes/hack/jenkins/test- [ ] kubernetes/hack/jenkins/verify- [ ] kubernetes/hack/lib/BUILD [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [x] kubernetes/hack/lint- [x] kubernetes/hack/list-feature- [x] kubernetes/hack/local-up- [ ] kubernetes/hack/make-rules/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/subdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-without-gofiles/README [ ] kubernetes/hack/make-rules/Makefile.manifest [ ] kubernetes/hack/make-rules/make- [ ] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make-rules/test-e2e- [ ] kubernetes/hack/make-rules/test-e2e- [x] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/OWNERS [x] kubernetes/hack/pin- [x] kubernetes/hack/print-workspace- [x] kubernetes/hack/run-in- [ ] kubernetes/hack/testdata/auth- [x] [x] [x] kubernetes/hack/testdata/CRD/foo-- [x] kubernetes/hack/testdata/CRD/foo-deleted- [x] kubernetes/hack/testdata/CRD/foo-updated- [x] [x] kubernetes/hack/testdata/CRD/multi-crd-list-- [x] kubernetes/hack/testdata/CRD/multi-crd-list-deleted- [x] kubernetes/hack/testdata/CRD/multi-crd-list-updated- [x] kubernetes/hack/testdata/CRD/multi-crd- [x] [x] [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-multicontainer- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment-with- [x] [x] [x] [x] [x] [x] kubernetes/hack/testdata/filter/pod-apply- [x] kubernetes/hack/testdata/filter/pod-dont- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/invalid-rc-with-empty- [x] kubernetes/hack/testdata/kubernetes- [x] [x] [x] [x] [x] [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-json- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-list- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-rclist- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-svclist- [x] kubernetes/hack/testdata/multi-resource-yaml- [x] kubernetes/hack/testdata/multi-resource- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/OWNERS [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod-with-api- [x] kubernetes/hack/testdata/pod-with-large- [x] kubernetes/hack/testdata/pod-with- [x] [x] [x] [x] [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/recursive/deployment/deployment/nginx- [x] [x] [x] [x] [x] kubernetes/hack/testdata/recursive/pod/pod/busybox- [x] [x] [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod-modify/pod/busybox- [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod- [x] [x] kubernetes/hack/testdata/recursive/rc/rc/busybox- [x] [x] [x] kubernetes/hack/testdata/redis-slave- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/rollingupdate-daemonset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/rollingupdate-statefulset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/scale-deploy-1.yaml [x] kubernetes/hack/testdata/scale-deploy-2.yaml [x] kubernetes/hack/testdata/scale-deploy-3.yaml [x] [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [ ] [ ] [x] kubernetes/hack/test- [ ] kubernetes/hack/test- [x] kubernetes/hack/update- [ ] kubernetes/hack/update- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-generated-api-compatibility- [x] kubernetes/hack/update-generated-device-plugin- [ ] kubernetes/hack/update-generated-device- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-kms- [ ] kubernetes/hack/update-generated- [x] kubernetes/hack/update-generated-kubelet-plugin-registration- [ ] kubernetes/hack/update-generated-kubelet-plugin- [x] kubernetes/hack/update-generated-pod-resources- [ ] kubernetes/hack/update-generated-pod- [ ] kubernetes/hack/update-generated-protobuf- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-runtime- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-swagger- [x] kubernetes/hack/update- [x] kubernetes/hack/update-import- [ ] kubernetes/hack/update-openapi- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-vendor- [ ] kubernetes/hack/update- [ ] kubernetes/hack/update-workspace- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-api- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-cli- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-conformance- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-external-dependencies- [ ] kubernetes/hack/verify-flags/excluded- [x] kubernetes/hack/verify-flags/OWNERS [x] kubernetes/hack/OWNERS [ ] kubernetes/hack/verify-flags- [x] kubernetes/hack/verify-generated-device- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-files- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-kubelet-plugin- [x] kubernetes/hack/verify-generated-pod- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-swagger- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-no-vendor- [x] kubernetes/hack/verify-openapi- [x] kubernetes/hack/verify-pkg- [x] kubernetes/hack/verify-publishing- [x] kubernetes/hack/verify-readonly- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-staging-meta- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-typecheck- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-vendor- [x] kubernetes/hack/verify- [x]\ni will pick up , i will do it step by step.\nI agree with your idea, and thanks the checkbox to check progress. there are many scripts, so let's work together!\n/assign /assign\nI will pick up hack/verify-\nI will pick up hack/verify-\nI will pick up hack/verify- (all of verify scripts). But there are large number of scripts(over 40), I want to split it into two or three PRs.\nI will pick up hack/update-\nI will pick up these scripts. kubernetes/hack/benchmark- kubernetes/hack/build- kubernetes/hack/build- kubernetes/hack/dev-build-and- kubernetes/hack/dev-build-and- kubernetes/hack/dev-push- kubernetes/hack/e2e-node- kubernetes/hack/generate-\nI will pick up these scripts get- ginkgo- grab- install- lint- list-feature- local-up- pin- print-workspace- run-in- test- test-\nHow about this now? /help Marking this tag so that others can easily access it.\nThis request has been marked as needing help from a contributor. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : How about this now? /help Marking this tag so that others can easily access it. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI think we've finished adding simple explanations to the almost scripts. It seems that several scripts of update- does not complete yet. I think we may able to close after that work.\nI will pick up these scripts:\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-e44b1165f54a8c25d540b19ff63913bbdce4a2574f1a4b338091a6eedc86e094", "text": "# See the License for the specific language governing permissions and # limitations under the License. <ins> # This script builds protoc-gen-gogo binary in runtime and genertates # `*/api.pb.go` from the protobuf file `*/api.proto`. </ins> set -o errexit set -o nounset set -o pipefail", "commid": "kubernetes_pr_91479"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d229adfbea12aef3b49af22ccc6144a0f39cff69fa180ff4396be871aeac05e1", "query": "What would you like to be : There are many useful scripts in \"\". For example, I often use and for creating simple k8s cluster quickly. However, there are only few explanation or nothing how to use it. I think it becomes more useful and helpful if some instruction or guidance is explained in each script. Why is this needed: It aims and expects to increase new k8s developers by describing how to use each script. My proposal Add the following description under the copyright for each script file. Overview of the script Simple usage Supplementary explanation(This is option) Other concern I would like to know the purpose of use about hack directory. (e.g. Where to put tools for developers(therefore there is no guidance?).)\nI don't know who is in charge of each scripts of hack, but if he agrees the idea of this feature request , I am going to do this task myself!!\n/sig testing\nI believe there is a script generating swagger/openapi specfilters under hack, but I am still struggling with it. It could be of great help if there is some how-to doc for each scripts.\nthis basis, why not create a file under the hack folder, because a lot of kk CIs are derived from multiple script commands under the hack. There are already 268+ files under the hack file. For contributors unfamiliar with these, these comments and instructions are helpful to them, and it is also helpful for new contributors to handle pr ci error reports.\n/cc What do you think\nI think it's good idea to create (It may be easy to understand if the script's explanation is described by category or use in ) Apart from that, it is helpful that the script file itself has a brief description.\nWhen we create , it may tough work if creating it including all scripts explanation at one time. (There are many scripts and I understand only some scripts now.) Regarding , current my idea is to add a description to each script little by little and update the at the same time. This means that will be completed little by little in conjunction with adding the description of each script. In the future, if someone create new script in hack, he also may have to add description of his script into\nSelf-documenting commands sound useful. A high level overview also sounds useful.\n/cc /cc Regarding adding help information, I suggest that we can submit pr in one or several files as a unit, so that we can track and statistics. For the documentation, I think it should be concise and not too long. How about this advice? We can claim tasks through , the pr title yes , i agree with you. [x] kubernetes/hack/benchmark- [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] kubernetes/hack/boilerplate/BUILD [ ] kubernetes/hack/boilerplate/test/BUILD [ ] [ ] [ ] [ ] [ ] kubernetes/hack/BUILD [x] kubernetes/hack/build- [x] kubernetes/hack/build- [x] [ ] kubernetes/hack/conformance/BUILD [ ] [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-push- [ ] kubernetes/hack/e2e-internal/BUILD [ ] kubernetes/hack/e2e-internal/e2e-cluster- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e-grow- [ ] kubernetes/hack/e2e-internal/e2e-shrink- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e- [x] kubernetes/hack/e2e-node- [ ] kubernetes/hack/generate- [x] kubernetes/hack/generate- [ ] kubernetes/hack/gen-swagger-doc/gen-swagger- [x] kubernetes/hack/get- [x] kubernetes/hack/ginkgo- [x] kubernetes/hack/grab- [x] kubernetes/hack/install- [ ] kubernetes/hack/jenkins/benchmark- [ ] kubernetes/hack/jenkins/OWNERS [ ] [ ] kubernetes/hack/jenkins/test- [ ] kubernetes/hack/jenkins/verify- [ ] kubernetes/hack/lib/BUILD [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [x] kubernetes/hack/lint- [x] kubernetes/hack/list-feature- [x] kubernetes/hack/local-up- [ ] kubernetes/hack/make-rules/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/subdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-without-gofiles/README [ ] kubernetes/hack/make-rules/Makefile.manifest [ ] kubernetes/hack/make-rules/make- [ ] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make-rules/test-e2e- [ ] kubernetes/hack/make-rules/test-e2e- [x] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/OWNERS [x] kubernetes/hack/pin- [x] kubernetes/hack/print-workspace- [x] kubernetes/hack/run-in- [ ] kubernetes/hack/testdata/auth- [x] [x] [x] kubernetes/hack/testdata/CRD/foo-- [x] kubernetes/hack/testdata/CRD/foo-deleted- [x] kubernetes/hack/testdata/CRD/foo-updated- [x] [x] kubernetes/hack/testdata/CRD/multi-crd-list-- [x] kubernetes/hack/testdata/CRD/multi-crd-list-deleted- [x] kubernetes/hack/testdata/CRD/multi-crd-list-updated- [x] kubernetes/hack/testdata/CRD/multi-crd- [x] [x] [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-multicontainer- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment-with- [x] [x] [x] [x] [x] [x] kubernetes/hack/testdata/filter/pod-apply- [x] kubernetes/hack/testdata/filter/pod-dont- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/invalid-rc-with-empty- [x] kubernetes/hack/testdata/kubernetes- [x] [x] [x] [x] [x] [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-json- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-list- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-rclist- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-svclist- [x] kubernetes/hack/testdata/multi-resource-yaml- [x] kubernetes/hack/testdata/multi-resource- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/OWNERS [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod-with-api- [x] kubernetes/hack/testdata/pod-with-large- [x] kubernetes/hack/testdata/pod-with- [x] [x] [x] [x] [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/recursive/deployment/deployment/nginx- [x] [x] [x] [x] [x] kubernetes/hack/testdata/recursive/pod/pod/busybox- [x] [x] [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod-modify/pod/busybox- [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod- [x] [x] kubernetes/hack/testdata/recursive/rc/rc/busybox- [x] [x] [x] kubernetes/hack/testdata/redis-slave- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/rollingupdate-daemonset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/rollingupdate-statefulset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/scale-deploy-1.yaml [x] kubernetes/hack/testdata/scale-deploy-2.yaml [x] kubernetes/hack/testdata/scale-deploy-3.yaml [x] [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [ ] [ ] [x] kubernetes/hack/test- [ ] kubernetes/hack/test- [x] kubernetes/hack/update- [ ] kubernetes/hack/update- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-generated-api-compatibility- [x] kubernetes/hack/update-generated-device-plugin- [ ] kubernetes/hack/update-generated-device- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-kms- [ ] kubernetes/hack/update-generated- [x] kubernetes/hack/update-generated-kubelet-plugin-registration- [ ] kubernetes/hack/update-generated-kubelet-plugin- [x] kubernetes/hack/update-generated-pod-resources- [ ] kubernetes/hack/update-generated-pod- [ ] kubernetes/hack/update-generated-protobuf- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-runtime- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-swagger- [x] kubernetes/hack/update- [x] kubernetes/hack/update-import- [ ] kubernetes/hack/update-openapi- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-vendor- [ ] kubernetes/hack/update- [ ] kubernetes/hack/update-workspace- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-api- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-cli- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-conformance- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-external-dependencies- [ ] kubernetes/hack/verify-flags/excluded- [x] kubernetes/hack/verify-flags/OWNERS [x] kubernetes/hack/OWNERS [ ] kubernetes/hack/verify-flags- [x] kubernetes/hack/verify-generated-device- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-files- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-kubelet-plugin- [x] kubernetes/hack/verify-generated-pod- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-swagger- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-no-vendor- [x] kubernetes/hack/verify-openapi- [x] kubernetes/hack/verify-pkg- [x] kubernetes/hack/verify-publishing- [x] kubernetes/hack/verify-readonly- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-staging-meta- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-typecheck- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-vendor- [x] kubernetes/hack/verify- [x]\ni will pick up , i will do it step by step.\nI agree with your idea, and thanks the checkbox to check progress. there are many scripts, so let's work together!\n/assign /assign\nI will pick up hack/verify-\nI will pick up hack/verify-\nI will pick up hack/verify- (all of verify scripts). But there are large number of scripts(over 40), I want to split it into two or three PRs.\nI will pick up hack/update-\nI will pick up these scripts. kubernetes/hack/benchmark- kubernetes/hack/build- kubernetes/hack/build- kubernetes/hack/dev-build-and- kubernetes/hack/dev-build-and- kubernetes/hack/dev-push- kubernetes/hack/e2e-node- kubernetes/hack/generate-\nI will pick up these scripts get- ginkgo- grab- install- lint- list-feature- local-up- pin- print-workspace- run-in- test- test-\nHow about this now? /help Marking this tag so that others can easily access it.\nThis request has been marked as needing help from a contributor. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : How about this now? /help Marking this tag so that others can easily access it. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI think we've finished adding simple explanations to the almost scripts. It seems that several scripts of update- does not complete yet. I think we may able to close after that work.\nI will pick up these scripts:\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-3bf207ba365062c68f3268b1162028992068989ffc586fe06ffa5591f302e246", "text": "# See the License for the specific language governing permissions and # limitations under the License. <ins> # This script builds protoc-gen-gogo binary in runtime and genertates # `*/api.pb.go` from the protobuf file `*/api.proto`. # Usage: #     hack/update-generated-runtime.sh </ins> set -o errexit set -o nounset set -o pipefail", "commid": "kubernetes_pr_91479"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d229adfbea12aef3b49af22ccc6144a0f39cff69fa180ff4396be871aeac05e1", "query": "What would you like to be : There are many useful scripts in \"\". For example, I often use and for creating simple k8s cluster quickly. However, there are only few explanation or nothing how to use it. I think it becomes more useful and helpful if some instruction or guidance is explained in each script. Why is this needed: It aims and expects to increase new k8s developers by describing how to use each script. My proposal Add the following description under the copyright for each script file. Overview of the script Simple usage Supplementary explanation(This is option) Other concern I would like to know the purpose of use about hack directory. (e.g. Where to put tools for developers(therefore there is no guidance?).)\nI don't know who is in charge of each scripts of hack, but if he agrees the idea of this feature request , I am going to do this task myself!!\n/sig testing\nI believe there is a script generating swagger/openapi specfilters under hack, but I am still struggling with it. It could be of great help if there is some how-to doc for each scripts.\nthis basis, why not create a file under the hack folder, because a lot of kk CIs are derived from multiple script commands under the hack. There are already 268+ files under the hack file. For contributors unfamiliar with these, these comments and instructions are helpful to them, and it is also helpful for new contributors to handle pr ci error reports.\n/cc What do you think\nI think it's good idea to create (It may be easy to understand if the script's explanation is described by category or use in ) Apart from that, it is helpful that the script file itself has a brief description.\nWhen we create , it may tough work if creating it including all scripts explanation at one time. (There are many scripts and I understand only some scripts now.) Regarding , current my idea is to add a description to each script little by little and update the at the same time. This means that will be completed little by little in conjunction with adding the description of each script. In the future, if someone create new script in hack, he also may have to add description of his script into\nSelf-documenting commands sound useful. A high level overview also sounds useful.\n/cc /cc Regarding adding help information, I suggest that we can submit pr in one or several files as a unit, so that we can track and statistics. For the documentation, I think it should be concise and not too long. How about this advice? We can claim tasks through , the pr title yes , i agree with you. [x] kubernetes/hack/benchmark- [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] kubernetes/hack/boilerplate/BUILD [ ] kubernetes/hack/boilerplate/test/BUILD [ ] [ ] [ ] [ ] [ ] kubernetes/hack/BUILD [x] kubernetes/hack/build- [x] kubernetes/hack/build- [x] [ ] kubernetes/hack/conformance/BUILD [ ] [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-build-and- [x] kubernetes/hack/dev-push- [ ] kubernetes/hack/e2e-internal/BUILD [ ] kubernetes/hack/e2e-internal/e2e-cluster- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e-grow- [ ] kubernetes/hack/e2e-internal/e2e-shrink- [ ] kubernetes/hack/e2e-internal/e2e- [ ] kubernetes/hack/e2e-internal/e2e- [x] kubernetes/hack/e2e-node- [ ] kubernetes/hack/generate- [x] kubernetes/hack/generate- [ ] kubernetes/hack/gen-swagger-doc/gen-swagger- [x] kubernetes/hack/get- [x] kubernetes/hack/ginkgo- [x] kubernetes/hack/grab- [x] kubernetes/hack/install- [ ] kubernetes/hack/jenkins/benchmark- [ ] kubernetes/hack/jenkins/OWNERS [ ] [ ] kubernetes/hack/jenkins/test- [ ] kubernetes/hack/jenkins/verify- [ ] kubernetes/hack/lib/BUILD [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [ ] [x] kubernetes/hack/lint- [x] kubernetes/hack/list-feature- [x] kubernetes/hack/local-up- [ ] kubernetes/hack/make-rules/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/BUILD [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with- [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/skipme/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/subdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/testdata/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/subsubdir/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/underscore/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-with-gofiles/README [ ] kubernetes/hack/make-rules/helpers/go2make/testdata/dir-without-gofiles/README [ ] kubernetes/hack/make-rules/Makefile.manifest [ ] kubernetes/hack/make-rules/make- [ ] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make-rules/test-e2e- [ ] kubernetes/hack/make-rules/test-e2e- [x] kubernetes/hack/make-rules/test- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/make- [ ] kubernetes/hack/OWNERS [x] kubernetes/hack/pin- [x] kubernetes/hack/print-workspace- [x] kubernetes/hack/run-in- [ ] kubernetes/hack/testdata/auth- [x] [x] [x] kubernetes/hack/testdata/CRD/foo-- [x] kubernetes/hack/testdata/CRD/foo-deleted- [x] kubernetes/hack/testdata/CRD/foo-updated- [x] [x] kubernetes/hack/testdata/CRD/multi-crd-list-- [x] kubernetes/hack/testdata/CRD/multi-crd-list-deleted- [x] kubernetes/hack/testdata/CRD/multi-crd-list-updated- [x] kubernetes/hack/testdata/CRD/multi-crd- [x] [x] [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-label- [x] kubernetes/hack/testdata/deployment-multicontainer- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment- [x] kubernetes/hack/testdata/deployment-with- [x] [x] [x] [x] [x] [x] kubernetes/hack/testdata/filter/pod-apply- [x] kubernetes/hack/testdata/filter/pod-dont- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/frontend- [x] kubernetes/hack/testdata/invalid-rc-with-empty- [x] kubernetes/hack/testdata/kubernetes- [x] [x] [x] [x] [x] [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-json- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-list- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-rclist- [ ] kubernetes/hack/testdata/multi-resource- [ ] kubernetes/hack/testdata/multi-resource-svclist- [x] kubernetes/hack/testdata/multi-resource-yaml- [x] kubernetes/hack/testdata/multi-resource- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/null-propagation/deployment- [x] kubernetes/hack/testdata/OWNERS [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod- [x] kubernetes/hack/testdata/pod-with-api- [x] kubernetes/hack/testdata/pod-with-large- [x] kubernetes/hack/testdata/pod-with- [x] [x] [x] [x] [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/prune- [x] kubernetes/hack/testdata/recursive/deployment/deployment/nginx- [x] [x] [x] [x] [x] kubernetes/hack/testdata/recursive/pod/pod/busybox- [x] [x] [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod-modify/pod/busybox- [x] kubernetes/hack/testdata/recursive/pod- [x] kubernetes/hack/testdata/recursive/pod- [x] [x] kubernetes/hack/testdata/recursive/rc/rc/busybox- [x] [x] [x] kubernetes/hack/testdata/redis-slave- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/retainKeys/deployment/deployment- [x] kubernetes/hack/testdata/rollingupdate-daemonset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/rollingupdate-statefulset- [x] kubernetes/hack/testdata/rollingupdate- [x] kubernetes/hack/testdata/scale-deploy-1.yaml [x] kubernetes/hack/testdata/scale-deploy-2.yaml [x] kubernetes/hack/testdata/scale-deploy-3.yaml [x] [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/service- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [x] kubernetes/hack/testdata/sorted-pods/sorted- [ ] [ ] [x] kubernetes/hack/test- [ ] kubernetes/hack/test- [x] kubernetes/hack/update- [ ] kubernetes/hack/update- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-generated-api-compatibility- [x] kubernetes/hack/update-generated-device-plugin- [ ] kubernetes/hack/update-generated-device- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-kms- [ ] kubernetes/hack/update-generated- [x] kubernetes/hack/update-generated-kubelet-plugin-registration- [ ] kubernetes/hack/update-generated-kubelet-plugin- [x] kubernetes/hack/update-generated-pod-resources- [ ] kubernetes/hack/update-generated-pod- [ ] kubernetes/hack/update-generated-protobuf- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-runtime- [ ] kubernetes/hack/update-generated- [ ] kubernetes/hack/update-generated-swagger- [x] kubernetes/hack/update- [x] kubernetes/hack/update-import- [ ] kubernetes/hack/update-openapi- [x] kubernetes/hack/update- [ ] kubernetes/hack/update-vendor- [ ] kubernetes/hack/update- [ ] kubernetes/hack/update-workspace- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-api- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-cli- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-conformance- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-external-dependencies- [ ] kubernetes/hack/verify-flags/excluded- [x] kubernetes/hack/verify-flags/OWNERS [x] kubernetes/hack/OWNERS [ ] kubernetes/hack/verify-flags- [x] kubernetes/hack/verify-generated-device- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-files- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-kubelet-plugin- [x] kubernetes/hack/verify-generated-pod- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated- [x] kubernetes/hack/verify-generated-swagger- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify-import- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-no-vendor- [x] kubernetes/hack/verify-openapi- [x] kubernetes/hack/verify-pkg- [x] kubernetes/hack/verify-publishing- [x] kubernetes/hack/verify-readonly- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-staging-meta- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-test- [x] kubernetes/hack/verify-typecheck- [x] kubernetes/hack/verify- [x] kubernetes/hack/verify-vendor- [x] kubernetes/hack/verify- [x]\ni will pick up , i will do it step by step.\nI agree with your idea, and thanks the checkbox to check progress. there are many scripts, so let's work together!\n/assign /assign\nI will pick up hack/verify-\nI will pick up hack/verify-\nI will pick up hack/verify- (all of verify scripts). But there are large number of scripts(over 40), I want to split it into two or three PRs.\nI will pick up hack/update-\nI will pick up these scripts. kubernetes/hack/benchmark- kubernetes/hack/build- kubernetes/hack/build- kubernetes/hack/dev-build-and- kubernetes/hack/dev-build-and- kubernetes/hack/dev-push- kubernetes/hack/e2e-node- kubernetes/hack/generate-\nI will pick up these scripts get- ginkgo- grab- install- lint- list-feature- local-up- pin- print-workspace- run-in- test- test-\nHow about this now? /help Marking this tag so that others can easily access it.\nThis request has been marked as needing help from a contributor. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : How about this now? /help Marking this tag so that others can easily access it. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI think we've finished adding simple explanations to the almost scripts. It seems that several scripts of update- does not complete yet. I think we may able to close after that work.\nI will pick up these scripts:\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-23a965315d9c022d034fcb0a4dd4bf67ebc2d21431a5b3023cae44316cbe0afd", "text": "# See the License for the specific language governing permissions and # limitations under the License. <del> # Generates `types_swagger_doc_generated.go` files for API group </del> <ins> # This script generates `types_swagger_doc_generated.go` files for API group </ins> # versions. That file contains functions on API structs that return # the comments that should be surfaced for the corresponding API type # in our API docs.", "commid": "kubernetes_pr_91479"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21f6b622d037a3471bbf2d53c2f298df7029b0752f80faeb870e98f01c0e5129", "query": "In a few utility function in current test/e2e/storage/utils, we found that the err variable gets shadowed. Because of this, it might get nil pointer error. See code\nfixed by", "positive_passages": [{"docid": "doc-en-kubernetes-c7b0f69b34324804e65e16c8ecfaf717fed1ad8662dd7d169bd26019dca3d0ed", "text": "func VerifyExecInPodSucceed(f *framework.Framework, pod *v1.Pod, shExec string) { _, err := PodExec(f, pod, shExec) if err != nil { <del> if err, ok := err.(uexec.CodeExitError); ok { exitCode := err.ExitStatus() </del> <ins> if exiterr, ok := err.(uexec.CodeExitError); ok { exitCode := exiterr.ExitStatus() </ins> framework.ExpectNoError(err, \"%q should succeed, but failed with exit code %d and error message %q\", <del> shExec, exitCode, err) </del> <ins> shExec, exitCode, exiterr) </ins> } else { framework.ExpectNoError(err, \"%q should succeed, but failed with error message %q\",", "commid": "kubernetes_pr_86886"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-21f6b622d037a3471bbf2d53c2f298df7029b0752f80faeb870e98f01c0e5129", "query": "In a few utility function in current test/e2e/storage/utils, we found that the err variable gets shadowed. Because of this, it might get nil pointer error. See code\nfixed by", "positive_passages": [{"docid": "doc-en-kubernetes-0fea54305987694793abaa1c224ea0c4475213476a32f3faaac224d6a5276713", "text": "func VerifyExecInPodFail(f *framework.Framework, pod *v1.Pod, shExec string, exitCode int) { _, err := PodExec(f, pod, shExec) if err != nil { <del> if err, ok := err.(clientexec.ExitError); ok { actualExitCode := err.ExitStatus() </del> <ins> if exiterr, ok := err.(clientexec.ExitError); ok { actualExitCode := exiterr.ExitStatus() </ins> framework.ExpectEqual(actualExitCode, exitCode, \"%q should fail with exit code %d, but failed with exit code %d and error message %q\", <del> shExec, exitCode, actualExitCode, err) </del> <ins> shExec, exitCode, actualExitCode, exiterr) </ins> } else { framework.ExpectNoError(err, \"%q should fail with exit code %d, but failed with error message %q\",", "commid": "kubernetes_pr_86886"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-22956ba2135ab6f3796239a359e3855984bd4cb916049da6b7ec54d0501cca5c", "query": "What would you like to be : An integration test for NodeResourceLimits plugin. Why is this needed: No end-to-end test coverage current exist for this alpha feature. /sig scheduling /help\n/assign /remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-8ab9556751547aa424e8a4a37d2406e9dbaad02961c21b76897629f627df8f99", "text": "\"extender_test.go\", \"framework_test.go\", \"main_test.go\", <ins> \"plugins_test.go\", </ins> \"predicates_test.go\", \"preemption_test.go\", \"priorities_test.go\",", "commid": "kubernetes_pr_87192"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-22956ba2135ab6f3796239a359e3855984bd4cb916049da6b7ec54d0501cca5c", "query": "What would you like to be : An integration test for NodeResourceLimits plugin. Why is this needed: No end-to-end test coverage current exist for this alpha feature. /sig scheduling /help\n/assign /remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-e4560e5c3f852e1448d92bd26ea2210028a5760f89eef9bab15cd9109fe67a3a", "text": "<ins> /* Copyright 2020 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package scheduler import ( \"testing\" \"k8s.io/api/core/v1\" \"k8s.io/apimachinery/pkg/api/resource\" utilfeature \"k8s.io/apiserver/pkg/util/feature\" featuregatetesting \"k8s.io/component-base/featuregate/testing\" \"k8s.io/kubernetes/pkg/features\" ) func TestNodeResourceLimits(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ResourceLimitsPriorityFunction, true)() context := initTest(t, \"node-resource-limits\") defer cleanupTest(t, context) // Add one node expectedNode, err := createNode(context.clientSet, \"test-node1\", &v1.ResourceList{ v1.ResourcePods:   *resource.NewQuantity(32, resource.DecimalSI), v1.ResourceCPU:    *resource.NewMilliQuantity(2000, resource.DecimalSI), v1.ResourceMemory: *resource.NewQuantity(2000, resource.DecimalSI), }) if err != nil { t.Fatalf(\"Cannot create node: %v\", err) } // Add another node with less resource _, err = createNode(context.clientSet, \"test-node2\", &v1.ResourceList{ v1.ResourcePods:   *resource.NewQuantity(32, resource.DecimalSI), v1.ResourceCPU:    *resource.NewMilliQuantity(1000, resource.DecimalSI), v1.ResourceMemory: *resource.NewQuantity(1000, resource.DecimalSI), }) if err != nil { t.Fatalf(\"Cannot create node: %v\", err) } podName := \"pod-with-resource-limits\" pod, err := runPausePod(context.clientSet, initPausePod(context.clientSet, &pausePodConfig{ Name:      podName, Namespace: context.ns.Name, Resources: &v1.ResourceRequirements{Requests: v1.ResourceList{ v1.ResourceCPU:    *resource.NewMilliQuantity(500, resource.DecimalSI), v1.ResourceMemory: *resource.NewQuantity(500, resource.DecimalSI)}, }, })) if err != nil { t.Fatalf(\"Error running pause pod: %v\", err) } if pod.Spec.NodeName != expectedNode.Name { t.Errorf(\"pod %v got scheduled on an unexpected node: %v. Expected node: %v.\", podName, pod.Spec.NodeName, expectedNode.Name) } else { t.Logf(\"pod %v got successfully scheduled on node %v.\", podName, pod.Spec.NodeName) } } </ins>", "commid": "kubernetes_pr_87192"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1fe3cf19c1c7d9bc5268ad985f5c595dbb9bea2e0f983d49a1ad7b835b3259e", "query": "When trying to see why pods don't start using either kubectl get events or kubectl describe pod , the base message is not detailed enough. Warning FailedScheduling 5s (x4 over 65s) default-scheduler 0/1 nodes are available: 1 node(s) had taints that the pod didn't tolerate. What would you like to be : Details of the taint and details of what it didn't tolerate Why is this needed: To get much much better debug information by default when trying to understand why pods can't launch.\n/sig cli\n/sig scheduling /priority important-longterm\n/cc\n/remove-sig cli\nThose labels are not set on the issue: <detailsIn response to : /remove-sig cli </details\n/good-first-issue\n/assign starizard\nCan I get an idea of what this would involve? I might be able to put some work on it.\nI assume is taking this already. The error message is produced in We probably also require changes in to get the name of the missing toleration.\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-3ae82e0bbc3c8d9a54af45edf3383f74c5037f0275a175946c70e687b17049fe", "text": "// TolerationsTolerateTaintsWithFilter checks if given tolerations tolerates // all the taints that apply to the filter in given taint list. <ins> // DEPRECATED: Please use FindMatchingUntoleratedTaint instead. </ins> func TolerationsTolerateTaintsWithFilter(tolerations []v1.Toleration, taints []v1.Taint, applyFilter taintsFilterFunc) bool { <del> if len(taints) == 0 { return true } </del> <ins> _, isUntolerated := FindMatchingUntoleratedTaint(taints, tolerations, applyFilter) return !isUntolerated } </ins> <del> for i := range taints { if applyFilter != nil && !applyFilter(&taints[i]) { continue </del> <ins> // FindMatchingUntoleratedTaint checks if the given tolerations tolerates // all the filtered taints, and returns the first taint without a toleration func FindMatchingUntoleratedTaint(taints []v1.Taint, tolerations []v1.Toleration, inclusionFilter taintsFilterFunc) (v1.Taint, bool) { filteredTaints := getFilteredTaints(taints, inclusionFilter) for _, taint := range filteredTaints { if !TolerationsTolerateTaint(tolerations, &taint) { return taint, true </ins> } <ins> } return v1.Taint{}, false } </ins> <del> if !TolerationsTolerateTaint(tolerations, &taints[i]) { return false </del> <ins> // getFilteredTaints returns a list of taints satisfying the filter predicate func getFilteredTaints(taints []v1.Taint, inclusionFilter taintsFilterFunc) []v1.Taint { if inclusionFilter == nil { return taints } filteredTaints := []v1.Taint{} for _, taint := range taints { if !inclusionFilter(&taint) { continue </ins> } <ins> filteredTaints = append(filteredTaints, taint) </ins> } <del> return true </del> <ins> return filteredTaints </ins> } // Returns true and list of Tolerations matching all Taints if all are tolerated, or false otherwise.", "commid": "kubernetes_pr_87250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1fe3cf19c1c7d9bc5268ad985f5c595dbb9bea2e0f983d49a1ad7b835b3259e", "query": "When trying to see why pods don't start using either kubectl get events or kubectl describe pod , the base message is not detailed enough. Warning FailedScheduling 5s (x4 over 65s) default-scheduler 0/1 nodes are available: 1 node(s) had taints that the pod didn't tolerate. What would you like to be : Details of the taint and details of what it didn't tolerate Why is this needed: To get much much better debug information by default when trying to understand why pods can't launch.\n/sig cli\n/sig scheduling /priority important-longterm\n/cc\n/remove-sig cli\nThose labels are not set on the issue: <detailsIn response to : /remove-sig cli </details\n/good-first-issue\n/assign starizard\nCan I get an idea of what this would involve? I might be able to put some work on it.\nI assume is taking this already. The error message is produced in We probably also require changes in to get the name of the missing toleration.\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-fc3d43ace78b9fc22d1f99f61a92546c4432b87381073c20e0158e1eb368cdf0", "text": "return framework.NewStatus(framework.Error, err.Error()) } <del> if v1helper.TolerationsTolerateTaintsWithFilter(pod.Spec.Tolerations, taints, func(t *v1.Taint) bool { </del> <ins> filterPredicate := func(t *v1.Taint) bool { </ins> // PodToleratesNodeTaints is only interested in NoSchedule and NoExecute taints. return t.Effect == v1.TaintEffectNoSchedule || t.Effect == v1.TaintEffectNoExecute <del> }) { </del> <ins> } taint, isUntolerated := v1helper.FindMatchingUntoleratedTaint(taints, pod.Spec.Tolerations, filterPredicate) if !isUntolerated { </ins> return nil } <del> return framework.NewStatus(framework.UnschedulableAndUnresolvable, ErrReasonNotMatch) </del> <ins> errReason := fmt.Sprintf(\"node(s) had taint {%s: %s}, that the pod didn't tolerate\", taint.Key, taint.Value) return framework.NewStatus(framework.UnschedulableAndUnresolvable, errReason) </ins> } // postFilterState computed at PostFilter and used at Score.", "commid": "kubernetes_pr_87250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1fe3cf19c1c7d9bc5268ad985f5c595dbb9bea2e0f983d49a1ad7b835b3259e", "query": "When trying to see why pods don't start using either kubectl get events or kubectl describe pod , the base message is not detailed enough. Warning FailedScheduling 5s (x4 over 65s) default-scheduler 0/1 nodes are available: 1 node(s) had taints that the pod didn't tolerate. What would you like to be : Details of the taint and details of what it didn't tolerate Why is this needed: To get much much better debug information by default when trying to understand why pods can't launch.\n/sig cli\n/sig scheduling /priority important-longterm\n/cc\n/remove-sig cli\nThose labels are not set on the issue: <detailsIn response to : /remove-sig cli </details\n/good-first-issue\n/assign starizard\nCan I get an idea of what this would involve? I might be able to put some work on it.\nI assume is taking this already. The error message is produced in We probably also require changes in to get the name of the missing toleration.\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-0849c110ea21df8bc827c31633303dbe259e2ed5df2325a3035069eed5de1547", "text": "} func TestTaintTolerationFilter(t *testing.T) { <del> unschedulable := framework.NewStatus(framework.UnschedulableAndUnresolvable, ErrReasonNotMatch) </del> tests := []struct { name       string pod        *v1.Pod", "commid": "kubernetes_pr_87250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1fe3cf19c1c7d9bc5268ad985f5c595dbb9bea2e0f983d49a1ad7b835b3259e", "query": "When trying to see why pods don't start using either kubectl get events or kubectl describe pod , the base message is not detailed enough. Warning FailedScheduling 5s (x4 over 65s) default-scheduler 0/1 nodes are available: 1 node(s) had taints that the pod didn't tolerate. What would you like to be : Details of the taint and details of what it didn't tolerate Why is this needed: To get much much better debug information by default when trying to understand why pods can't launch.\n/sig cli\n/sig scheduling /priority important-longterm\n/cc\n/remove-sig cli\nThose labels are not set on the issue: <detailsIn response to : /remove-sig cli </details\n/good-first-issue\n/assign starizard\nCan I get an idea of what this would involve? I might be able to put some work on it.\nI assume is taking this already. The error message is produced in We probably also require changes in to get the name of the missing toleration.\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-a967c9c630df81013b54636f76e528459f9cf5ca5130cc544e6e6f0aba7014be", "text": "wantStatus *framework.Status }{ { <del> name:       \"A pod having no tolerations can't be scheduled onto a node with nonempty taints\", pod:        podWithTolerations(\"pod1\", []v1.Toleration{}), node:       nodeWithTaints(\"nodeA\", []v1.Taint{{Key: \"dedicated\", Value: \"user1\", Effect: \"NoSchedule\"}}), wantStatus: unschedulable, </del> <ins> name: \"A pod having no tolerations can't be scheduled onto a node with nonempty taints\", pod:  podWithTolerations(\"pod1\", []v1.Toleration{}), node: nodeWithTaints(\"nodeA\", []v1.Taint{{Key: \"dedicated\", Value: \"user1\", Effect: \"NoSchedule\"}}), wantStatus: framework.NewStatus(framework.UnschedulableAndUnresolvable, \"node(s) had taint {dedicated: user1}, that the pod didn't tolerate\"), </ins> }, { name: \"A pod which can be scheduled on a dedicated node assigned to user1 with effect NoSchedule\",", "commid": "kubernetes_pr_87250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1fe3cf19c1c7d9bc5268ad985f5c595dbb9bea2e0f983d49a1ad7b835b3259e", "query": "When trying to see why pods don't start using either kubectl get events or kubectl describe pod , the base message is not detailed enough. Warning FailedScheduling 5s (x4 over 65s) default-scheduler 0/1 nodes are available: 1 node(s) had taints that the pod didn't tolerate. What would you like to be : Details of the taint and details of what it didn't tolerate Why is this needed: To get much much better debug information by default when trying to understand why pods can't launch.\n/sig cli\n/sig scheduling /priority important-longterm\n/cc\n/remove-sig cli\nThose labels are not set on the issue: <detailsIn response to : /remove-sig cli </details\n/good-first-issue\n/assign starizard\nCan I get an idea of what this would involve? I might be able to put some work on it.\nI assume is taking this already. The error message is produced in We probably also require changes in to get the name of the missing toleration.\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-c4897998f52c98fc539084d11a4bf341fbffa8f4884db26b3cc58daf48a56cd4", "text": "node: nodeWithTaints(\"nodeA\", []v1.Taint{{Key: \"dedicated\", Value: \"user1\", Effect: \"NoSchedule\"}}), }, { <del> name:       \"A pod which can't be scheduled on a dedicated node assigned to user2 with effect NoSchedule\", pod:        podWithTolerations(\"pod1\", []v1.Toleration{{Key: \"dedicated\", Operator: \"Equal\", Value: \"user2\", Effect: \"NoSchedule\"}}), node:       nodeWithTaints(\"nodeA\", []v1.Taint{{Key: \"dedicated\", Value: \"user1\", Effect: \"NoSchedule\"}}), wantStatus: unschedulable, </del> <ins> name: \"A pod which can't be scheduled on a dedicated node assigned to user2 with effect NoSchedule\", pod:  podWithTolerations(\"pod1\", []v1.Toleration{{Key: \"dedicated\", Operator: \"Equal\", Value: \"user2\", Effect: \"NoSchedule\"}}), node: nodeWithTaints(\"nodeA\", []v1.Taint{{Key: \"dedicated\", Value: \"user1\", Effect: \"NoSchedule\"}}), wantStatus: framework.NewStatus(framework.UnschedulableAndUnresolvable, \"node(s) had taint {dedicated: user1}, that the pod didn't tolerate\"), </ins> }, { name: \"A pod can be scheduled onto the node, with a toleration uses operator Exists that tolerates the taints on the node\",", "commid": "kubernetes_pr_87250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1fe3cf19c1c7d9bc5268ad985f5c595dbb9bea2e0f983d49a1ad7b835b3259e", "query": "When trying to see why pods don't start using either kubectl get events or kubectl describe pod , the base message is not detailed enough. Warning FailedScheduling 5s (x4 over 65s) default-scheduler 0/1 nodes are available: 1 node(s) had taints that the pod didn't tolerate. What would you like to be : Details of the taint and details of what it didn't tolerate Why is this needed: To get much much better debug information by default when trying to understand why pods can't launch.\n/sig cli\n/sig scheduling /priority important-longterm\n/cc\n/remove-sig cli\nThose labels are not set on the issue: <detailsIn response to : /remove-sig cli </details\n/good-first-issue\n/assign starizard\nCan I get an idea of what this would involve? I might be able to put some work on it.\nI assume is taking this already. The error message is produced in We probably also require changes in to get the name of the missing toleration.\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-d58bff5f9ecde2aa18df816711ca1a096a3bc826b5b9bc7b7fe2ecedd6007e69", "text": "{ name: \"A pod has a toleration that keys and values match the taint on the node, but (non-empty) effect doesn't match, \" + \"can't be scheduled onto the node\", <del> pod:        podWithTolerations(\"pod1\", []v1.Toleration{{Key: \"foo\", Operator: \"Equal\", Value: \"bar\", Effect: \"PreferNoSchedule\"}}), node:       nodeWithTaints(\"nodeA\", []v1.Taint{{Key: \"foo\", Value: \"bar\", Effect: \"NoSchedule\"}}), wantStatus: unschedulable, </del> <ins> pod:  podWithTolerations(\"pod1\", []v1.Toleration{{Key: \"foo\", Operator: \"Equal\", Value: \"bar\", Effect: \"PreferNoSchedule\"}}), node: nodeWithTaints(\"nodeA\", []v1.Taint{{Key: \"foo\", Value: \"bar\", Effect: \"NoSchedule\"}}), wantStatus: framework.NewStatus(framework.UnschedulableAndUnresolvable, \"node(s) had taint {foo: bar}, that the pod didn't tolerate\"), </ins> }, { name: \"The pod has a toleration that keys and values match the taint on the node, the effect of toleration is empty, \" +", "commid": "kubernetes_pr_87250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1fe3cf19c1c7d9bc5268ad985f5c595dbb9bea2e0f983d49a1ad7b835b3259e", "query": "When trying to see why pods don't start using either kubectl get events or kubectl describe pod , the base message is not detailed enough. Warning FailedScheduling 5s (x4 over 65s) default-scheduler 0/1 nodes are available: 1 node(s) had taints that the pod didn't tolerate. What would you like to be : Details of the taint and details of what it didn't tolerate Why is this needed: To get much much better debug information by default when trying to understand why pods can't launch.\n/sig cli\n/sig scheduling /priority important-longterm\n/cc\n/remove-sig cli\nThose labels are not set on the issue: <detailsIn response to : /remove-sig cli </details\n/good-first-issue\n/assign starizard\nCan I get an idea of what this would involve? I might be able to put some work on it.\nI assume is taking this already. The error message is produced in We probably also require changes in to get the name of the missing toleration.\n/remove-help", "positive_passages": [{"docid": "doc-en-kubernetes-5fce6bc877a2641a0153a71ca65db4d46f373f23e1fe0a81af577858284d2ca8", "text": "}, { name: \"The pod has a toleration that key and value don't match the taint on the node, \" + <del> \"but the effect of taint on node is PreferNochedule. Pod can be scheduled onto the node\", </del> <ins> \"but the effect of taint on node is PreferNoSchedule. Pod can be scheduled onto the node\", </ins> pod:  podWithTolerations(\"pod1\", []v1.Toleration{{Key: \"dedicated\", Operator: \"Equal\", Value: \"user2\", Effect: \"NoSchedule\"}}), node: nodeWithTaints(\"nodeA\", []v1.Taint{{Key: \"dedicated\", Value: \"user1\", Effect: \"PreferNoSchedule\"}}), }, { name: \"The pod has no toleration, \" + <del> \"but the effect of taint on node is PreferNochedule. Pod can be scheduled onto the node\", </del> <ins> \"but the effect of taint on node is PreferNoSchedule. Pod can be scheduled onto the node\", </ins> pod:  podWithTolerations(\"pod1\", []v1.Toleration{}), node: nodeWithTaints(\"nodeA\", []v1.Taint{{Key: \"dedicated\", Value: \"user1\", Effect: \"PreferNoSchedule\"}}), },", "commid": "kubernetes_pr_87250"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6bd3b0b5b88d2c4e52fa7e7988f3bc34e4f6c96dcec415eb9240194b302773b8", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: I am testing API Priority and Fairness. I launched it like this: After the logging said the cluster is running and told me how to set KUBECONFIG, I did so in another shell and went looking for FlowSchema objects. But kubectl erroneously told me there is no such thing. However, looking in the kube-apiserver log shows flowschemas and prioritylevelconfigurations being read and written; for example: Also, I am able to read them with against the insecure port. Interestingly, the kube-apiserver log also includes this complaint: I will attach the kube-apiserver log. What you expected to happen: I expected to list them. How to reproduce it (as minimally and precisely as possible): I think the report above is pretty minimal. Anything else we need to know?: Environment: Kubernetes version (use ): this is the branch, git commit 916edd922e528f2f27542d3ca5967ca11fe153f8Cloud provider or hardware configuration: bare metal, intel, 16 \"CPUs\", 64 GB of memory OS (e.g: ): 18.04.2 LTS (Bionic Beaver) Kernel (e.g. ): Linux mjs-dev-1 4.15.0-74-generic -Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: hack/local-up- Network plugin and version (if this is a network-related bug): Others: Docker version 18.09.7 go version go1.13.4 linux/amd64\n/sig api-machinery\n/cc /cc /cc /cc\n/assign\nthe \"\" API group is not included in the list of known groups to register at startup: That means resources inside that group will not appear in discovery, and clients like kubectl will not know how to find them.\nYou can see all resources visible via discovery by running\njust as said, for now we have to manually create an apiservice into the cluster to get kubectl work. i dont think we're adding this to the list until the beta stage, can we make an exception for the case?\nIt is fine to add alpha things to the list I linked so they get created automatically if needed. They only get registered if the relevant runtime-config is enabled.\nInterrupts control plane upgrade in lazy scenario where it's assumed dns name isn't changed properly to active node or or single node control plane\noh cool actually it succeeds on the second main node but the kube apiserver pod doesnt start\nthe hacky way being to adjust that api creation based on this?\nAnd I removed the flags too\nWait what is this? This was to my api manifest during kubeadm upgrade?", "positive_passages": [{"docid": "doc-en-kubernetes-b25a13a220109ab56b45447b902aaaba9ddccb83302eb97c3e6618bd0312bb51", "text": "// can reasonably expect seems questionable. {Group: \"extensions\", Version: \"v1beta1\"}: {group: 17900, version: 1}, // to my knowledge, nothing below here collides <del> {Group: \"apps\", Version: \"v1\"}:                              {group: 17800, version: 15}, {Group: \"events.k8s.io\", Version: \"v1beta1\"}:                {group: 17750, version: 5}, {Group: \"authentication.k8s.io\", Version: \"v1\"}:             {group: 17700, version: 15}, {Group: \"authentication.k8s.io\", Version: \"v1beta1\"}:        {group: 17700, version: 9}, {Group: \"authorization.k8s.io\", Version: \"v1\"}:              {group: 17600, version: 15}, {Group: \"authorization.k8s.io\", Version: \"v1beta1\"}:         {group: 17600, version: 9}, {Group: \"autoscaling\", Version: \"v1\"}:                       {group: 17500, version: 15}, {Group: \"autoscaling\", Version: \"v2beta1\"}:                  {group: 17500, version: 9}, {Group: \"autoscaling\", Version: \"v2beta2\"}:                  {group: 17500, version: 1}, {Group: \"batch\", Version: \"v1\"}:                             {group: 17400, version: 15}, {Group: \"batch\", Version: \"v1beta1\"}:                        {group: 17400, version: 9}, {Group: \"batch\", Version: \"v2alpha1\"}:                       {group: 17400, version: 9}, {Group: \"certificates.k8s.io\", Version: \"v1beta1\"}:          {group: 17300, version: 9}, {Group: \"networking.k8s.io\", Version: \"v1\"}:                 {group: 17200, version: 15}, {Group: \"networking.k8s.io\", Version: \"v1beta1\"}:            {group: 17200, version: 9}, {Group: \"policy\", Version: \"v1beta1\"}:                       {group: 17100, version: 9}, {Group: \"rbac.authorization.k8s.io\", Version: \"v1\"}:         {group: 17000, version: 15}, {Group: \"rbac.authorization.k8s.io\", Version: \"v1beta1\"}:    {group: 17000, version: 12}, {Group: \"rbac.authorization.k8s.io\", Version: \"v1alpha1\"}:   {group: 17000, version: 9}, {Group: \"settings.k8s.io\", Version: \"v1alpha1\"}:             {group: 16900, version: 9}, {Group: \"storage.k8s.io\", Version: \"v1\"}:                    {group: 16800, version: 15}, {Group: \"storage.k8s.io\", Version: \"v1beta1\"}:               {group: 16800, version: 9}, {Group: \"storage.k8s.io\", Version: \"v1alpha1\"}:              {group: 16800, version: 1}, {Group: \"apiextensions.k8s.io\", Version: \"v1\"}:              {group: 16700, version: 15}, {Group: \"apiextensions.k8s.io\", Version: \"v1beta1\"}:         {group: 16700, version: 9}, {Group: \"admissionregistration.k8s.io\", Version: \"v1\"}:      {group: 16700, version: 15}, {Group: \"admissionregistration.k8s.io\", Version: \"v1beta1\"}: {group: 16700, version: 12}, {Group: \"scheduling.k8s.io\", Version: \"v1\"}:                 {group: 16600, version: 15}, {Group: \"scheduling.k8s.io\", Version: \"v1beta1\"}:            {group: 16600, version: 12}, {Group: \"scheduling.k8s.io\", Version: \"v1alpha1\"}:           {group: 16600, version: 9}, {Group: \"coordination.k8s.io\", Version: \"v1\"}:               {group: 16500, version: 15}, {Group: \"coordination.k8s.io\", Version: \"v1beta1\"}:          {group: 16500, version: 9}, {Group: \"auditregistration.k8s.io\", Version: \"v1alpha1\"}:    {group: 16400, version: 1}, {Group: \"node.k8s.io\", Version: \"v1alpha1\"}:                 {group: 16300, version: 1}, {Group: \"node.k8s.io\", Version: \"v1beta1\"}:                  {group: 16300, version: 9}, {Group: \"discovery.k8s.io\", Version: \"v1beta1\"}:             {group: 16200, version: 12}, {Group: \"discovery.k8s.io\", Version: \"v1alpha1\"}:            {group: 16200, version: 9}, </del> <ins> {Group: \"apps\", Version: \"v1\"}:                               {group: 17800, version: 15}, {Group: \"events.k8s.io\", Version: \"v1beta1\"}:                 {group: 17750, version: 5}, {Group: \"authentication.k8s.io\", Version: \"v1\"}:              {group: 17700, version: 15}, {Group: \"authentication.k8s.io\", Version: \"v1beta1\"}:         {group: 17700, version: 9}, {Group: \"authorization.k8s.io\", Version: \"v1\"}:               {group: 17600, version: 15}, {Group: \"authorization.k8s.io\", Version: \"v1beta1\"}:          {group: 17600, version: 9}, {Group: \"autoscaling\", Version: \"v1\"}:                        {group: 17500, version: 15}, {Group: \"autoscaling\", Version: \"v2beta1\"}:                   {group: 17500, version: 9}, {Group: \"autoscaling\", Version: \"v2beta2\"}:                   {group: 17500, version: 1}, {Group: \"batch\", Version: \"v1\"}:                              {group: 17400, version: 15}, {Group: \"batch\", Version: \"v1beta1\"}:                         {group: 17400, version: 9}, {Group: \"batch\", Version: \"v2alpha1\"}:                        {group: 17400, version: 9}, {Group: \"certificates.k8s.io\", Version: \"v1beta1\"}:           {group: 17300, version: 9}, {Group: \"networking.k8s.io\", Version: \"v1\"}:                  {group: 17200, version: 15}, {Group: \"networking.k8s.io\", Version: \"v1beta1\"}:             {group: 17200, version: 9}, {Group: \"policy\", Version: \"v1beta1\"}:                        {group: 17100, version: 9}, {Group: \"rbac.authorization.k8s.io\", Version: \"v1\"}:          {group: 17000, version: 15}, {Group: \"rbac.authorization.k8s.io\", Version: \"v1beta1\"}:     {group: 17000, version: 12}, {Group: \"rbac.authorization.k8s.io\", Version: \"v1alpha1\"}:    {group: 17000, version: 9}, {Group: \"settings.k8s.io\", Version: \"v1alpha1\"}:              {group: 16900, version: 9}, {Group: \"storage.k8s.io\", Version: \"v1\"}:                     {group: 16800, version: 15}, {Group: \"storage.k8s.io\", Version: \"v1beta1\"}:                {group: 16800, version: 9}, {Group: \"storage.k8s.io\", Version: \"v1alpha1\"}:               {group: 16800, version: 1}, {Group: \"apiextensions.k8s.io\", Version: \"v1\"}:               {group: 16700, version: 15}, {Group: \"apiextensions.k8s.io\", Version: \"v1beta1\"}:          {group: 16700, version: 9}, {Group: \"admissionregistration.k8s.io\", Version: \"v1\"}:       {group: 16700, version: 15}, {Group: \"admissionregistration.k8s.io\", Version: \"v1beta1\"}:  {group: 16700, version: 12}, {Group: \"scheduling.k8s.io\", Version: \"v1\"}:                  {group: 16600, version: 15}, {Group: \"scheduling.k8s.io\", Version: \"v1beta1\"}:             {group: 16600, version: 12}, {Group: \"scheduling.k8s.io\", Version: \"v1alpha1\"}:            {group: 16600, version: 9}, {Group: \"coordination.k8s.io\", Version: \"v1\"}:                {group: 16500, version: 15}, {Group: \"coordination.k8s.io\", Version: \"v1beta1\"}:           {group: 16500, version: 9}, {Group: \"auditregistration.k8s.io\", Version: \"v1alpha1\"}:     {group: 16400, version: 1}, {Group: \"node.k8s.io\", Version: \"v1alpha1\"}:                  {group: 16300, version: 1}, {Group: \"node.k8s.io\", Version: \"v1beta1\"}:                   {group: 16300, version: 9}, {Group: \"discovery.k8s.io\", Version: \"v1beta1\"}:              {group: 16200, version: 12}, {Group: \"discovery.k8s.io\", Version: \"v1alpha1\"}:             {group: 16200, version: 9}, {Group: \"flowcontrol.apiserver.k8s.io\", Version: \"v1alpha1\"}: {group: 16100, version: 9}, </ins> // Append a new group to the end of the list if unsure. // You can use min(existing group)-100 as the initial value for a group. // Version can be set to 9 (to have space around) for a new group.", "commid": "kubernetes_pr_87357"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6bd3b0b5b88d2c4e52fa7e7988f3bc34e4f6c96dcec415eb9240194b302773b8", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: I am testing API Priority and Fairness. I launched it like this: After the logging said the cluster is running and told me how to set KUBECONFIG, I did so in another shell and went looking for FlowSchema objects. But kubectl erroneously told me there is no such thing. However, looking in the kube-apiserver log shows flowschemas and prioritylevelconfigurations being read and written; for example: Also, I am able to read them with against the insecure port. Interestingly, the kube-apiserver log also includes this complaint: I will attach the kube-apiserver log. What you expected to happen: I expected to list them. How to reproduce it (as minimally and precisely as possible): I think the report above is pretty minimal. Anything else we need to know?: Environment: Kubernetes version (use ): this is the branch, git commit 916edd922e528f2f27542d3ca5967ca11fe153f8Cloud provider or hardware configuration: bare metal, intel, 16 \"CPUs\", 64 GB of memory OS (e.g: ): 18.04.2 LTS (Bionic Beaver) Kernel (e.g. ): Linux mjs-dev-1 4.15.0-74-generic -Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x8664 x8664 x86_64 GNU/Linux Install tools: hack/local-up- Network plugin and version (if this is a network-related bug): Others: Docker version 18.09.7 go version go1.13.4 linux/amd64\n/sig api-machinery\n/cc /cc /cc /cc\n/assign\nthe \"\" API group is not included in the list of known groups to register at startup: That means resources inside that group will not appear in discovery, and clients like kubectl will not know how to find them.\nYou can see all resources visible via discovery by running\njust as said, for now we have to manually create an apiservice into the cluster to get kubectl work. i dont think we're adding this to the list until the beta stage, can we make an exception for the case?\nIt is fine to add alpha things to the list I linked so they get created automatically if needed. They only get registered if the relevant runtime-config is enabled.\nInterrupts control plane upgrade in lazy scenario where it's assumed dns name isn't changed properly to active node or or single node control plane\noh cool actually it succeeds on the second main node but the kube apiserver pod doesnt start\nthe hacky way being to adjust that api creation based on this?\nAnd I removed the flags too\nWait what is this? This was to my api manifest during kubeadm upgrade?", "positive_passages": [{"docid": "doc-en-kubernetes-2fe7e53d41c635b6a9d24a8d2772cc32417f7dd1545b8273a7ba327d45819103", "text": "}, // -- <ins> // k8s.io/kubernetes/pkg/apis/flowcontrol/v1alpha1 gvr(\"flowcontrol.apiserver.k8s.io\", \"v1alpha1\", \"flowschemas\"): { Stub:             `{\"metadata\": {\"name\": \"va1\"}, \"spec\": {\"priorityLevelConfiguration\": {\"name\": \"name1\"}}}`, ExpectedEtcdPath: \"/registry/flowschemas/va1\", }, // -- // k8s.io/kubernetes/pkg/apis/flowcontrol/v1alpha1 gvr(\"flowcontrol.apiserver.k8s.io\", \"v1alpha1\", \"prioritylevelconfigurations\"): { Stub:             `{\"metadata\": {\"name\": \"conf1\"}, \"spec\": {\"type\": \"Limited\", \"limited\": {\"assuredConcurrencyShares\":3, \"limitResponse\": {\"type\": \"Reject\"}}}}`, ExpectedEtcdPath: \"/registry/prioritylevelconfigurations/conf1\", }, // -- </ins> // k8s.io/kubernetes/pkg/apis/storage/v1beta1 gvr(\"storage.k8s.io\", \"v1beta1\", \"volumeattachments\"): { Stub:             `{\"metadata\": {\"name\": \"va2\"}, \"spec\": {\"attacher\": \"gce\", \"nodeName\": \"localhost\", \"source\": {\"persistentVolumeName\": \"pv2\"}}}`,", "commid": "kubernetes_pr_87357"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31635c902aff9f8a2a2d4b7ec7f766a933cc4b8a93f6aa67e00afd6d1cd1a418", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: With the exec credentials plugin configured in my kubeconf, and a stale/expired token present in the same file issuing e.g. triggers the authentication flow as handled by the plugin - once the flow is returned to kubectl (by printing the ExecCredential object) the new token is stored to the kubeconfig but not immediately used to resolve the request, leading to: Immediately issuing again works as kubectl now seem to use the credentials (token) stored following the first request. What you expected to happen: That kubectl would read the new token as fetched by the exec credential plugin and use it already for the first command issued. How to reproduce it (as minimally and precisely as possible): the kubernetes API server with the OIDC authenticator enabled. kubectl to use an exec credential plugin printing the token received out of band. that the token was indeed written to the kubeconf file. that the first kubectl command failed. that the next identical command succeeds. Anything else we need to know?: This works as expected when there is no token previously stored in the kubeconf - the behavior is only triggered when there is a token stored but it expired, or for whatever other reason not accepted by the API server. Environment: Kubernetes version (use ): 1.14, also tried with 1.17 Cloud provider or hardware configuration: OS (e.g: ): Mac OS for kubectl client Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig auth /sig cli\ncould you provide more details around how is configured. For example, it is unclear to me if you are using the built in oidc plugin or a custom exec plugin. I think you are using a custom exec plugin but its also trying to write tokens to the file (which it should not do)? /triage needs-information\nThanks for looking into it . You are indeed correct in your assumption that I'm using a which stores the token in the after retrieval. I'd love to learn why this should not be done, but the problem remains also without persisting the token after retrieval. Basically the steps to reproduce could be reduced to these: containing an expired token. same configuring an exec plugin which retrieves a valid token out of band and echoes it. Expected behavior: The valid token retrieved is used for the subsequent authentication. Possibly expected behavior: The exec plugin flow not started (or exited with a warning) due to an expired token being present in the . Current behavior seems to acknowledge the invalid token and hence tries to retrieve a new, valid one - which it then discards as soon as it arrives.\nSeems we can reduce it even further by removing the token altogether from the file and instead provide it directly. So the only step needed to reproduce is essentially this: configuring an exec plugin which retrieves a valid token out of band and echoes it as part of an . Now any will trigger the exec plugin to retrieve a valid token, but will still not use it for subsequent authentication.\nThis one is caused by config merging with clientcmd overrides: and exec.Auth not being in this switch:\nInteresting, thanks Will add it to the switch along with some tests and if everything works out well I'll submit a PR next week.\nHaving spent some time on this in the debugger, it seems somewhat more intricate than I first thought. Turns out the exec plugin is executed whether the presented is invalid or valid - the exec action is actually called before the first call is even dispatched. This due to the exec credential plugin possibly being needed to setup the client certificate requested for the transport. Once the exec plugin's is called it assign the authenticators function to : ..which is then called when setting up the transport, thus triggering the exec plugin regardless of a token being present or not: Since the exec plugin has no way of knowing whether a token or a client certificate will be returned by the exec action, this kind of makes sense. It however defeats letting any present to override the exec plugin, which clearly seems to be the intent: Possible options here that I can think of: (and fix) behavior of letting override the exec plugin. This looks doable by adding a check for token auth early in the 's method body: But might be there are consequences to this I'm not aware of. the behavior of letting override the exec plugin being called. third, more complex option, would be to keep the token override but dispatch to the exec credential plugin should the response from the first call with the token come back with a 401. This was what I originally believed was the intent as my first tests always included an invalid token. While this behavior seems nice I'm more and more thinking it may violate the principle of least surprise. Either you present a token and use that for auth or you let the exec plugin fetch the credentials for you. What do you guys think?\nAs a colleague just made me aware of, certain tools like kubetail seem to have kubectl call the exec plugin so many times that eventually the threshold of 1000 is reached and warn logs (exec:201) start spewing - even though no certificate (and hence no rotation) should be involved. This has me more convinced that the first option is the right one, skipping the client TLS ceremonies should a token be present for authentication.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-ffce7929d4b2ba7cc1a0cb8456bdd662c249946920387ff35538153cc32ad832", "text": "OPENSSL_BIN=$(command -v openssl) } <ins> # Query the API server for client certificate authentication capabilities function kube::util::test_client_certificate_authentication_enabled { local output kube::util::test_openssl_installed output=$(echo  | \"${OPENSSL_BIN}\" s_client -connect \"127.0.0.1:${SECURE_API_PORT}\" 2> /dev/null  | grep -A3 'Acceptable client certificate CA names') if [[ \"${output}\" != *\"/CN=127.0.0.1\"* ]] && [[ \"${output}\" != *\"CN = 127.0.0.1\"* ]]; then echo \"API server not configured for client certificate authentication\" echo \"Output of from acceptable client certificate check: ${output}\" exit 1 fi } </ins> # creates a client CA, args are sudo, dest-dir, ca-id, purpose # purpose is dropped in after \"key encipherment\", you usually want # '\"client auth\"'", "commid": "kubernetes_pr_91745"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31635c902aff9f8a2a2d4b7ec7f766a933cc4b8a93f6aa67e00afd6d1cd1a418", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: With the exec credentials plugin configured in my kubeconf, and a stale/expired token present in the same file issuing e.g. triggers the authentication flow as handled by the plugin - once the flow is returned to kubectl (by printing the ExecCredential object) the new token is stored to the kubeconfig but not immediately used to resolve the request, leading to: Immediately issuing again works as kubectl now seem to use the credentials (token) stored following the first request. What you expected to happen: That kubectl would read the new token as fetched by the exec credential plugin and use it already for the first command issued. How to reproduce it (as minimally and precisely as possible): the kubernetes API server with the OIDC authenticator enabled. kubectl to use an exec credential plugin printing the token received out of band. that the token was indeed written to the kubeconf file. that the first kubectl command failed. that the next identical command succeeds. Anything else we need to know?: This works as expected when there is no token previously stored in the kubeconf - the behavior is only triggered when there is a token stored but it expired, or for whatever other reason not accepted by the API server. Environment: Kubernetes version (use ): 1.14, also tried with 1.17 Cloud provider or hardware configuration: OS (e.g: ): Mac OS for kubectl client Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig auth /sig cli\ncould you provide more details around how is configured. For example, it is unclear to me if you are using the built in oidc plugin or a custom exec plugin. I think you are using a custom exec plugin but its also trying to write tokens to the file (which it should not do)? /triage needs-information\nThanks for looking into it . You are indeed correct in your assumption that I'm using a which stores the token in the after retrieval. I'd love to learn why this should not be done, but the problem remains also without persisting the token after retrieval. Basically the steps to reproduce could be reduced to these: containing an expired token. same configuring an exec plugin which retrieves a valid token out of band and echoes it. Expected behavior: The valid token retrieved is used for the subsequent authentication. Possibly expected behavior: The exec plugin flow not started (or exited with a warning) due to an expired token being present in the . Current behavior seems to acknowledge the invalid token and hence tries to retrieve a new, valid one - which it then discards as soon as it arrives.\nSeems we can reduce it even further by removing the token altogether from the file and instead provide it directly. So the only step needed to reproduce is essentially this: configuring an exec plugin which retrieves a valid token out of band and echoes it as part of an . Now any will trigger the exec plugin to retrieve a valid token, but will still not use it for subsequent authentication.\nThis one is caused by config merging with clientcmd overrides: and exec.Auth not being in this switch:\nInteresting, thanks Will add it to the switch along with some tests and if everything works out well I'll submit a PR next week.\nHaving spent some time on this in the debugger, it seems somewhat more intricate than I first thought. Turns out the exec plugin is executed whether the presented is invalid or valid - the exec action is actually called before the first call is even dispatched. This due to the exec credential plugin possibly being needed to setup the client certificate requested for the transport. Once the exec plugin's is called it assign the authenticators function to : ..which is then called when setting up the transport, thus triggering the exec plugin regardless of a token being present or not: Since the exec plugin has no way of knowing whether a token or a client certificate will be returned by the exec action, this kind of makes sense. It however defeats letting any present to override the exec plugin, which clearly seems to be the intent: Possible options here that I can think of: (and fix) behavior of letting override the exec plugin. This looks doable by adding a check for token auth early in the 's method body: But might be there are consequences to this I'm not aware of. the behavior of letting override the exec plugin being called. third, more complex option, would be to keep the token override but dispatch to the exec credential plugin should the response from the first call with the token come back with a 401. This was what I originally believed was the intent as my first tests always included an invalid token. While this behavior seems nice I'm more and more thinking it may violate the principle of least surprise. Either you present a token and use that for auth or you let the exec plugin fetch the credentials for you. What do you guys think?\nAs a colleague just made me aware of, certain tools like kubetail seem to have kubectl call the exec plugin so many times that eventually the threshold of 1000 is reached and warn logs (exec:201) start spewing - even though no certificate (and hence no rotation) should be involved. This has me more convinced that the first option is the right one, skipping the client TLS ceremonies should a token be present for authentication.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-a94781fe035c6f4fb55ac560ad09f9b8d878245c94cd835a872399a720623772", "text": "--storage-media-type=\"${KUBE_TEST_API_STORAGE_TYPE-}\"  --cert-dir=\"${TMPDIR:-/tmp/}\"  --service-cluster-ip-range=\"10.0.0.0/24\"  <ins> --client-ca-file=hack/testdata/ca.crt  </ins> --token-auth-file=hack/testdata/auth-tokens.csv 1>&2 & export APISERVER_PID=$!", "commid": "kubernetes_pr_91745"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31635c902aff9f8a2a2d4b7ec7f766a933cc4b8a93f6aa67e00afd6d1cd1a418", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: With the exec credentials plugin configured in my kubeconf, and a stale/expired token present in the same file issuing e.g. triggers the authentication flow as handled by the plugin - once the flow is returned to kubectl (by printing the ExecCredential object) the new token is stored to the kubeconfig but not immediately used to resolve the request, leading to: Immediately issuing again works as kubectl now seem to use the credentials (token) stored following the first request. What you expected to happen: That kubectl would read the new token as fetched by the exec credential plugin and use it already for the first command issued. How to reproduce it (as minimally and precisely as possible): the kubernetes API server with the OIDC authenticator enabled. kubectl to use an exec credential plugin printing the token received out of band. that the token was indeed written to the kubeconf file. that the first kubectl command failed. that the next identical command succeeds. Anything else we need to know?: This works as expected when there is no token previously stored in the kubeconf - the behavior is only triggered when there is a token stored but it expired, or for whatever other reason not accepted by the API server. Environment: Kubernetes version (use ): 1.14, also tried with 1.17 Cloud provider or hardware configuration: OS (e.g: ): Mac OS for kubectl client Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig auth /sig cli\ncould you provide more details around how is configured. For example, it is unclear to me if you are using the built in oidc plugin or a custom exec plugin. I think you are using a custom exec plugin but its also trying to write tokens to the file (which it should not do)? /triage needs-information\nThanks for looking into it . You are indeed correct in your assumption that I'm using a which stores the token in the after retrieval. I'd love to learn why this should not be done, but the problem remains also without persisting the token after retrieval. Basically the steps to reproduce could be reduced to these: containing an expired token. same configuring an exec plugin which retrieves a valid token out of band and echoes it. Expected behavior: The valid token retrieved is used for the subsequent authentication. Possibly expected behavior: The exec plugin flow not started (or exited with a warning) due to an expired token being present in the . Current behavior seems to acknowledge the invalid token and hence tries to retrieve a new, valid one - which it then discards as soon as it arrives.\nSeems we can reduce it even further by removing the token altogether from the file and instead provide it directly. So the only step needed to reproduce is essentially this: configuring an exec plugin which retrieves a valid token out of band and echoes it as part of an . Now any will trigger the exec plugin to retrieve a valid token, but will still not use it for subsequent authentication.\nThis one is caused by config merging with clientcmd overrides: and exec.Auth not being in this switch:\nInteresting, thanks Will add it to the switch along with some tests and if everything works out well I'll submit a PR next week.\nHaving spent some time on this in the debugger, it seems somewhat more intricate than I first thought. Turns out the exec plugin is executed whether the presented is invalid or valid - the exec action is actually called before the first call is even dispatched. This due to the exec credential plugin possibly being needed to setup the client certificate requested for the transport. Once the exec plugin's is called it assign the authenticators function to : ..which is then called when setting up the transport, thus triggering the exec plugin regardless of a token being present or not: Since the exec plugin has no way of knowing whether a token or a client certificate will be returned by the exec action, this kind of makes sense. It however defeats letting any present to override the exec plugin, which clearly seems to be the intent: Possible options here that I can think of: (and fix) behavior of letting override the exec plugin. This looks doable by adding a check for token auth early in the 's method body: But might be there are consequences to this I'm not aware of. the behavior of letting override the exec plugin being called. third, more complex option, would be to keep the token override but dispatch to the exec credential plugin should the response from the first call with the token come back with a 401. This was what I originally believed was the intent as my first tests always included an invalid token. While this behavior seems nice I'm more and more thinking it may violate the principle of least surprise. Either you present a token and use that for auth or you let the exec plugin fetch the credentials for you. What do you guys think?\nAs a colleague just made me aware of, certain tools like kubetail seem to have kubectl call the exec plugin so many times that eventually the threshold of 1000 is reached and warn logs (exec:201) start spewing - even though no certificate (and hence no rotation) should be involved. This has me more convinced that the first option is the right one, skipping the client TLS ceremonies should a token be present for authentication.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-1f7fbf72dc0af7c50e2c4ea309783ce49923977ee349a9f9732cc33a3016ad7d", "text": "<ins> -----BEGIN CERTIFICATE----- MIICpjCCAY4CCQCZBiNB23olFzANBgkqhkiG9w0BAQsFADAUMRIwEAYDVQQDDAkx MjcuMC4wLjEwIBcNMjAwNjE0MTk0OTM4WhgPMjI5NDAzMzAxOTQ5MzhaMBQxEjAQ BgNVBAMMCTEyNy4wLjAuMTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEB AMxIjMd58IhiiyK4VjmuCWBUZksSs1CcQuo5HSpOqogVZ+vR5mdJDZ56Pw/NSM5c RqOB3cvjGrxYQe/lKvo9D3UmWLcRKtxdlWxCfPekioJ25/dhGOxtBQcjtp/TSqTM txprwT4fvsVwiwaURFoCOivF4xjQFG0K1i3/m7CiMHODy67M1EfJDrM7Vv5XPIuJ VF8HhWBH2HiM25ak34XhxVTX8K97k6wO9OZ5GMqbYuVobTZrSRdiv8s95rkmik6P jn0ePKqSz6cXNXgXqTl11WtsuoGgjOdB8j/noqTF3m3z17sSBqqG/xBFuSFoNceA yBDb9ohbs8oY3NIZzyMrt8MCAwEAATANBgkqhkiG9w0BAQsFAAOCAQEAFgcaqRgv qylx4ogL5iUr0K2e/8YzsvH7zLHG6xnr7HxpR/p0lQt3dPlppECZMGDKElbCgU8f xVDdZ3FOxHTJ51Vnq/U5xJo+UOMJ4sS8fEH8cfNliSsvmSKzjxpPKqbCJ7VTnkW8 lonedCPRksnhlD1U8CF21rEjKsXcLoX5PsxlS4DX3PtO0+e8aUh9F4XyZagpejq8 0ttXkWd3IyYrpFRGDlFDxIiKx7pf+mG6JZ/ms6jloBSwwcz/Nkn5FMxiq75bQuOH EV+99S2du/X2bRmD1JxCiMDw8cMacIFBr6BYXsvKOlivwfHBWk8U0f+lVi60jWje PpKFRd1mYuEZgw== -----END CERTIFICATE----- </ins>", "commid": "kubernetes_pr_91745"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31635c902aff9f8a2a2d4b7ec7f766a933cc4b8a93f6aa67e00afd6d1cd1a418", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: With the exec credentials plugin configured in my kubeconf, and a stale/expired token present in the same file issuing e.g. triggers the authentication flow as handled by the plugin - once the flow is returned to kubectl (by printing the ExecCredential object) the new token is stored to the kubeconfig but not immediately used to resolve the request, leading to: Immediately issuing again works as kubectl now seem to use the credentials (token) stored following the first request. What you expected to happen: That kubectl would read the new token as fetched by the exec credential plugin and use it already for the first command issued. How to reproduce it (as minimally and precisely as possible): the kubernetes API server with the OIDC authenticator enabled. kubectl to use an exec credential plugin printing the token received out of band. that the token was indeed written to the kubeconf file. that the first kubectl command failed. that the next identical command succeeds. Anything else we need to know?: This works as expected when there is no token previously stored in the kubeconf - the behavior is only triggered when there is a token stored but it expired, or for whatever other reason not accepted by the API server. Environment: Kubernetes version (use ): 1.14, also tried with 1.17 Cloud provider or hardware configuration: OS (e.g: ): Mac OS for kubectl client Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig auth /sig cli\ncould you provide more details around how is configured. For example, it is unclear to me if you are using the built in oidc plugin or a custom exec plugin. I think you are using a custom exec plugin but its also trying to write tokens to the file (which it should not do)? /triage needs-information\nThanks for looking into it . You are indeed correct in your assumption that I'm using a which stores the token in the after retrieval. I'd love to learn why this should not be done, but the problem remains also without persisting the token after retrieval. Basically the steps to reproduce could be reduced to these: containing an expired token. same configuring an exec plugin which retrieves a valid token out of band and echoes it. Expected behavior: The valid token retrieved is used for the subsequent authentication. Possibly expected behavior: The exec plugin flow not started (or exited with a warning) due to an expired token being present in the . Current behavior seems to acknowledge the invalid token and hence tries to retrieve a new, valid one - which it then discards as soon as it arrives.\nSeems we can reduce it even further by removing the token altogether from the file and instead provide it directly. So the only step needed to reproduce is essentially this: configuring an exec plugin which retrieves a valid token out of band and echoes it as part of an . Now any will trigger the exec plugin to retrieve a valid token, but will still not use it for subsequent authentication.\nThis one is caused by config merging with clientcmd overrides: and exec.Auth not being in this switch:\nInteresting, thanks Will add it to the switch along with some tests and if everything works out well I'll submit a PR next week.\nHaving spent some time on this in the debugger, it seems somewhat more intricate than I first thought. Turns out the exec plugin is executed whether the presented is invalid or valid - the exec action is actually called before the first call is even dispatched. This due to the exec credential plugin possibly being needed to setup the client certificate requested for the transport. Once the exec plugin's is called it assign the authenticators function to : ..which is then called when setting up the transport, thus triggering the exec plugin regardless of a token being present or not: Since the exec plugin has no way of knowing whether a token or a client certificate will be returned by the exec action, this kind of makes sense. It however defeats letting any present to override the exec plugin, which clearly seems to be the intent: Possible options here that I can think of: (and fix) behavior of letting override the exec plugin. This looks doable by adding a check for token auth early in the 's method body: But might be there are consequences to this I'm not aware of. the behavior of letting override the exec plugin being called. third, more complex option, would be to keep the token override but dispatch to the exec credential plugin should the response from the first call with the token come back with a 401. This was what I originally believed was the intent as my first tests always included an invalid token. While this behavior seems nice I'm more and more thinking it may violate the principle of least surprise. Either you present a token and use that for auth or you let the exec plugin fetch the credentials for you. What do you guys think?\nAs a colleague just made me aware of, certain tools like kubetail seem to have kubectl call the exec plugin so many times that eventually the threshold of 1000 is reached and warn logs (exec:201) start spewing - even though no certificate (and hence no rotation) should be involved. This has me more convinced that the first option is the right one, skipping the client TLS ceremonies should a token be present for authentication.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-92ce169c54acf357dce7e2e3961009df3b2a3aed6a5e2ea9ba6a5cac8c5f6be0", "text": "// UpdateTransportConfig updates the transport.Config to use credentials // returned by the plugin. func (a *Authenticator) UpdateTransportConfig(c *transport.Config) error { <ins> // If a bearer token is present in the request - avoid the GetCert callback when // setting up the transport, as that triggers the exec action if the server is // also configured to allow client certificates for authentication. For requests // like \"kubectl get --token (token) pods\" we should assume the intention is to // use the provided token for authentication. if c.HasTokenAuth() { return nil } </ins> c.Wrap(func(rt http.RoundTripper) http.RoundTripper { return &roundTripper{a, rt} })", "commid": "kubernetes_pr_91745"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31635c902aff9f8a2a2d4b7ec7f766a933cc4b8a93f6aa67e00afd6d1cd1a418", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: With the exec credentials plugin configured in my kubeconf, and a stale/expired token present in the same file issuing e.g. triggers the authentication flow as handled by the plugin - once the flow is returned to kubectl (by printing the ExecCredential object) the new token is stored to the kubeconfig but not immediately used to resolve the request, leading to: Immediately issuing again works as kubectl now seem to use the credentials (token) stored following the first request. What you expected to happen: That kubectl would read the new token as fetched by the exec credential plugin and use it already for the first command issued. How to reproduce it (as minimally and precisely as possible): the kubernetes API server with the OIDC authenticator enabled. kubectl to use an exec credential plugin printing the token received out of band. that the token was indeed written to the kubeconf file. that the first kubectl command failed. that the next identical command succeeds. Anything else we need to know?: This works as expected when there is no token previously stored in the kubeconf - the behavior is only triggered when there is a token stored but it expired, or for whatever other reason not accepted by the API server. Environment: Kubernetes version (use ): 1.14, also tried with 1.17 Cloud provider or hardware configuration: OS (e.g: ): Mac OS for kubectl client Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig auth /sig cli\ncould you provide more details around how is configured. For example, it is unclear to me if you are using the built in oidc plugin or a custom exec plugin. I think you are using a custom exec plugin but its also trying to write tokens to the file (which it should not do)? /triage needs-information\nThanks for looking into it . You are indeed correct in your assumption that I'm using a which stores the token in the after retrieval. I'd love to learn why this should not be done, but the problem remains also without persisting the token after retrieval. Basically the steps to reproduce could be reduced to these: containing an expired token. same configuring an exec plugin which retrieves a valid token out of band and echoes it. Expected behavior: The valid token retrieved is used for the subsequent authentication. Possibly expected behavior: The exec plugin flow not started (or exited with a warning) due to an expired token being present in the . Current behavior seems to acknowledge the invalid token and hence tries to retrieve a new, valid one - which it then discards as soon as it arrives.\nSeems we can reduce it even further by removing the token altogether from the file and instead provide it directly. So the only step needed to reproduce is essentially this: configuring an exec plugin which retrieves a valid token out of band and echoes it as part of an . Now any will trigger the exec plugin to retrieve a valid token, but will still not use it for subsequent authentication.\nThis one is caused by config merging with clientcmd overrides: and exec.Auth not being in this switch:\nInteresting, thanks Will add it to the switch along with some tests and if everything works out well I'll submit a PR next week.\nHaving spent some time on this in the debugger, it seems somewhat more intricate than I first thought. Turns out the exec plugin is executed whether the presented is invalid or valid - the exec action is actually called before the first call is even dispatched. This due to the exec credential plugin possibly being needed to setup the client certificate requested for the transport. Once the exec plugin's is called it assign the authenticators function to : ..which is then called when setting up the transport, thus triggering the exec plugin regardless of a token being present or not: Since the exec plugin has no way of knowing whether a token or a client certificate will be returned by the exec action, this kind of makes sense. It however defeats letting any present to override the exec plugin, which clearly seems to be the intent: Possible options here that I can think of: (and fix) behavior of letting override the exec plugin. This looks doable by adding a check for token auth early in the 's method body: But might be there are consequences to this I'm not aware of. the behavior of letting override the exec plugin being called. third, more complex option, would be to keep the token override but dispatch to the exec credential plugin should the response from the first call with the token come back with a 401. This was what I originally believed was the intent as my first tests always included an invalid token. While this behavior seems nice I'm more and more thinking it may violate the principle of least surprise. Either you present a token and use that for auth or you let the exec plugin fetch the credentials for you. What do you guys think?\nAs a colleague just made me aware of, certain tools like kubetail seem to have kubectl call the exec plugin so many times that eventually the threshold of 1000 is reached and warn logs (exec:201) start spewing - even though no certificate (and hence no rotation) should be involved. This has me more convinced that the first option is the right one, skipping the client TLS ceremonies should a token be present for authentication.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-2f35858ae116578b4761da69a27012f29a93dde7faa482bde4eddfb634a7f6b7", "text": "get(t, http.StatusOK) } <ins> func TestTokenPresentCancelsExecAction(t *testing.T) { a, err := newAuthenticator(newCache(), &api.ExecConfig{ Command:    \"./testdata/test-plugin.sh\", APIVersion: \"client.authentication.k8s.io/v1alpha1\", }) if err != nil { t.Fatal(err) } // UpdateTransportConfig returns error on existing TLS certificate callback, unless a bearer token is present in the // transport config, in which case it takes precedence cert := func() (*tls.Certificate, error) { return nil, nil } tc := &transport.Config{BearerToken: \"token1\", TLS: transport.TLSConfig{Insecure: true, GetCert: cert}} if err := a.UpdateTransportConfig(tc); err != nil { t.Error(\"Expected presence of bearer token in config to cancel exec action\") } } </ins> func TestTLSCredentials(t *testing.T) { now := time.Now()", "commid": "kubernetes_pr_91745"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31635c902aff9f8a2a2d4b7ec7f766a933cc4b8a93f6aa67e00afd6d1cd1a418", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: With the exec credentials plugin configured in my kubeconf, and a stale/expired token present in the same file issuing e.g. triggers the authentication flow as handled by the plugin - once the flow is returned to kubectl (by printing the ExecCredential object) the new token is stored to the kubeconfig but not immediately used to resolve the request, leading to: Immediately issuing again works as kubectl now seem to use the credentials (token) stored following the first request. What you expected to happen: That kubectl would read the new token as fetched by the exec credential plugin and use it already for the first command issued. How to reproduce it (as minimally and precisely as possible): the kubernetes API server with the OIDC authenticator enabled. kubectl to use an exec credential plugin printing the token received out of band. that the token was indeed written to the kubeconf file. that the first kubectl command failed. that the next identical command succeeds. Anything else we need to know?: This works as expected when there is no token previously stored in the kubeconf - the behavior is only triggered when there is a token stored but it expired, or for whatever other reason not accepted by the API server. Environment: Kubernetes version (use ): 1.14, also tried with 1.17 Cloud provider or hardware configuration: OS (e.g: ): Mac OS for kubectl client Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig auth /sig cli\ncould you provide more details around how is configured. For example, it is unclear to me if you are using the built in oidc plugin or a custom exec plugin. I think you are using a custom exec plugin but its also trying to write tokens to the file (which it should not do)? /triage needs-information\nThanks for looking into it . You are indeed correct in your assumption that I'm using a which stores the token in the after retrieval. I'd love to learn why this should not be done, but the problem remains also without persisting the token after retrieval. Basically the steps to reproduce could be reduced to these: containing an expired token. same configuring an exec plugin which retrieves a valid token out of band and echoes it. Expected behavior: The valid token retrieved is used for the subsequent authentication. Possibly expected behavior: The exec plugin flow not started (or exited with a warning) due to an expired token being present in the . Current behavior seems to acknowledge the invalid token and hence tries to retrieve a new, valid one - which it then discards as soon as it arrives.\nSeems we can reduce it even further by removing the token altogether from the file and instead provide it directly. So the only step needed to reproduce is essentially this: configuring an exec plugin which retrieves a valid token out of band and echoes it as part of an . Now any will trigger the exec plugin to retrieve a valid token, but will still not use it for subsequent authentication.\nThis one is caused by config merging with clientcmd overrides: and exec.Auth not being in this switch:\nInteresting, thanks Will add it to the switch along with some tests and if everything works out well I'll submit a PR next week.\nHaving spent some time on this in the debugger, it seems somewhat more intricate than I first thought. Turns out the exec plugin is executed whether the presented is invalid or valid - the exec action is actually called before the first call is even dispatched. This due to the exec credential plugin possibly being needed to setup the client certificate requested for the transport. Once the exec plugin's is called it assign the authenticators function to : ..which is then called when setting up the transport, thus triggering the exec plugin regardless of a token being present or not: Since the exec plugin has no way of knowing whether a token or a client certificate will be returned by the exec action, this kind of makes sense. It however defeats letting any present to override the exec plugin, which clearly seems to be the intent: Possible options here that I can think of: (and fix) behavior of letting override the exec plugin. This looks doable by adding a check for token auth early in the 's method body: But might be there are consequences to this I'm not aware of. the behavior of letting override the exec plugin being called. third, more complex option, would be to keep the token override but dispatch to the exec credential plugin should the response from the first call with the token come back with a 401. This was what I originally believed was the intent as my first tests always included an invalid token. While this behavior seems nice I'm more and more thinking it may violate the principle of least surprise. Either you present a token and use that for auth or you let the exec plugin fetch the credentials for you. What do you guys think?\nAs a colleague just made me aware of, certain tools like kubetail seem to have kubectl call the exec plugin so many times that eventually the threshold of 1000 is reached and warn logs (exec:201) start spewing - even though no certificate (and hence no rotation) should be involved. This has me more convinced that the first option is the right one, skipping the client TLS ceremonies should a token be present for authentication.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-652868b7d7f90ee9cb17ab783c3394c60c4a429cd8cac7c76d51789f9a7e494a", "text": "<ins> #!/usr/bin/env bash # Copyright 2020 The Kubernetes Authors. # # Licensed under the Apache License, Version 2.0 (the \"License\"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #     http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an \"AS IS\" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. set -o errexit set -o nounset set -o pipefail run_exec_credentials_tests() { set -o nounset set -o errexit kube::log::status \"Testing kubectl with configured exec credentials plugin\" cat > \"${TMPDIR:-/tmp}\"/invalid_exec_plugin.yaml << EOF apiVersion: v1 clusters: - cluster: name: test contexts: - context: cluster: test user: invalid_token_user name: test current-context: test kind: Config preferences: {} users: - name: invalid_token_user user: exec: apiVersion: client.authentication.k8s.io/v1beta1 # Any invalid exec credential plugin will do to demonstrate command: ls EOF ### Provided --token should take precedence, thus not triggering the (invalid) exec credential plugin # Pre-condition: Client certificate authentication enabled on the API server kube::util::test_client_certificate_authentication_enabled # Command output=$(kubectl \"${kube_flags_with_token[@]:?}\" --kubeconfig=\"${TMPDIR:-/tmp}\"/invalid_exec_plugin.yaml get namespace kube-system -o name || true) if [[ \"${output}\" == \"namespace/kube-system\" ]]; then kube::log::status \"exec credential plugin not triggered since kubectl was called with provided --token\" else kube::log::status \"Unexpected output when providing --token for authentication - exec credential plugin likely triggered. Output: ${output}\" exit 1 fi # Post-condition: None ### Without provided --token, the exec credential plugin should be triggered # Pre-condition: Client certificate authentication enabled on the API server - already checked by positive test above # Command output2=$(kubectl \"${kube_flags_without_token[@]:?}\" --kubeconfig=\"${TMPDIR:-/tmp}\"/invalid_exec_plugin.yaml get namespace kube-system -o name 2>&1 || true) if [[ \"${output2}\" =~ \"json parse error\" ]]; then kube::log::status \"exec credential plugin triggered since kubectl was called without provided --token\" else kube::log::status \"Unexpected output when not providing --token for authentication - exec credential plugin not triggered. Output: ${output2}\" exit 1 fi # Post-condition: None rm \"${TMPDIR:-/tmp}\"/invalid_exec_plugin.yaml set +o nounset set +o errexit } </ins>", "commid": "kubernetes_pr_91745"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31635c902aff9f8a2a2d4b7ec7f766a933cc4b8a93f6aa67e00afd6d1cd1a418", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: With the exec credentials plugin configured in my kubeconf, and a stale/expired token present in the same file issuing e.g. triggers the authentication flow as handled by the plugin - once the flow is returned to kubectl (by printing the ExecCredential object) the new token is stored to the kubeconfig but not immediately used to resolve the request, leading to: Immediately issuing again works as kubectl now seem to use the credentials (token) stored following the first request. What you expected to happen: That kubectl would read the new token as fetched by the exec credential plugin and use it already for the first command issued. How to reproduce it (as minimally and precisely as possible): the kubernetes API server with the OIDC authenticator enabled. kubectl to use an exec credential plugin printing the token received out of band. that the token was indeed written to the kubeconf file. that the first kubectl command failed. that the next identical command succeeds. Anything else we need to know?: This works as expected when there is no token previously stored in the kubeconf - the behavior is only triggered when there is a token stored but it expired, or for whatever other reason not accepted by the API server. Environment: Kubernetes version (use ): 1.14, also tried with 1.17 Cloud provider or hardware configuration: OS (e.g: ): Mac OS for kubectl client Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig auth /sig cli\ncould you provide more details around how is configured. For example, it is unclear to me if you are using the built in oidc plugin or a custom exec plugin. I think you are using a custom exec plugin but its also trying to write tokens to the file (which it should not do)? /triage needs-information\nThanks for looking into it . You are indeed correct in your assumption that I'm using a which stores the token in the after retrieval. I'd love to learn why this should not be done, but the problem remains also without persisting the token after retrieval. Basically the steps to reproduce could be reduced to these: containing an expired token. same configuring an exec plugin which retrieves a valid token out of band and echoes it. Expected behavior: The valid token retrieved is used for the subsequent authentication. Possibly expected behavior: The exec plugin flow not started (or exited with a warning) due to an expired token being present in the . Current behavior seems to acknowledge the invalid token and hence tries to retrieve a new, valid one - which it then discards as soon as it arrives.\nSeems we can reduce it even further by removing the token altogether from the file and instead provide it directly. So the only step needed to reproduce is essentially this: configuring an exec plugin which retrieves a valid token out of band and echoes it as part of an . Now any will trigger the exec plugin to retrieve a valid token, but will still not use it for subsequent authentication.\nThis one is caused by config merging with clientcmd overrides: and exec.Auth not being in this switch:\nInteresting, thanks Will add it to the switch along with some tests and if everything works out well I'll submit a PR next week.\nHaving spent some time on this in the debugger, it seems somewhat more intricate than I first thought. Turns out the exec plugin is executed whether the presented is invalid or valid - the exec action is actually called before the first call is even dispatched. This due to the exec credential plugin possibly being needed to setup the client certificate requested for the transport. Once the exec plugin's is called it assign the authenticators function to : ..which is then called when setting up the transport, thus triggering the exec plugin regardless of a token being present or not: Since the exec plugin has no way of knowing whether a token or a client certificate will be returned by the exec action, this kind of makes sense. It however defeats letting any present to override the exec plugin, which clearly seems to be the intent: Possible options here that I can think of: (and fix) behavior of letting override the exec plugin. This looks doable by adding a check for token auth early in the 's method body: But might be there are consequences to this I'm not aware of. the behavior of letting override the exec plugin being called. third, more complex option, would be to keep the token override but dispatch to the exec credential plugin should the response from the first call with the token come back with a 401. This was what I originally believed was the intent as my first tests always included an invalid token. While this behavior seems nice I'm more and more thinking it may violate the principle of least surprise. Either you present a token and use that for auth or you let the exec plugin fetch the credentials for you. What do you guys think?\nAs a colleague just made me aware of, certain tools like kubetail seem to have kubectl call the exec plugin so many times that eventually the threshold of 1000 is reached and warn logs (exec:201) start spewing - even though no certificate (and hence no rotation) should be involved. This has me more convinced that the first option is the right one, skipping the client TLS ceremonies should a token be present for authentication.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-0d398164d07851ea670f3f4007623067c1ea545236957340c1b14046c594cb9f", "text": "# source \"${KUBE_ROOT}/hack/lib/test.sh\" source \"${KUBE_ROOT}/test/cmd/apply.sh\" source \"${KUBE_ROOT}/test/cmd/apps.sh\" <ins> source \"${KUBE_ROOT}/test/cmd/authentication.sh\" </ins> source \"${KUBE_ROOT}/test/cmd/authorization.sh\" source \"${KUBE_ROOT}/test/cmd/batch.sh\" source \"${KUBE_ROOT}/test/cmd/certificate.sh\"", "commid": "kubernetes_pr_91745"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31635c902aff9f8a2a2d4b7ec7f766a933cc4b8a93f6aa67e00afd6d1cd1a418", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: With the exec credentials plugin configured in my kubeconf, and a stale/expired token present in the same file issuing e.g. triggers the authentication flow as handled by the plugin - once the flow is returned to kubectl (by printing the ExecCredential object) the new token is stored to the kubeconfig but not immediately used to resolve the request, leading to: Immediately issuing again works as kubectl now seem to use the credentials (token) stored following the first request. What you expected to happen: That kubectl would read the new token as fetched by the exec credential plugin and use it already for the first command issued. How to reproduce it (as minimally and precisely as possible): the kubernetes API server with the OIDC authenticator enabled. kubectl to use an exec credential plugin printing the token received out of band. that the token was indeed written to the kubeconf file. that the first kubectl command failed. that the next identical command succeeds. Anything else we need to know?: This works as expected when there is no token previously stored in the kubeconf - the behavior is only triggered when there is a token stored but it expired, or for whatever other reason not accepted by the API server. Environment: Kubernetes version (use ): 1.14, also tried with 1.17 Cloud provider or hardware configuration: OS (e.g: ): Mac OS for kubectl client Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig auth /sig cli\ncould you provide more details around how is configured. For example, it is unclear to me if you are using the built in oidc plugin or a custom exec plugin. I think you are using a custom exec plugin but its also trying to write tokens to the file (which it should not do)? /triage needs-information\nThanks for looking into it . You are indeed correct in your assumption that I'm using a which stores the token in the after retrieval. I'd love to learn why this should not be done, but the problem remains also without persisting the token after retrieval. Basically the steps to reproduce could be reduced to these: containing an expired token. same configuring an exec plugin which retrieves a valid token out of band and echoes it. Expected behavior: The valid token retrieved is used for the subsequent authentication. Possibly expected behavior: The exec plugin flow not started (or exited with a warning) due to an expired token being present in the . Current behavior seems to acknowledge the invalid token and hence tries to retrieve a new, valid one - which it then discards as soon as it arrives.\nSeems we can reduce it even further by removing the token altogether from the file and instead provide it directly. So the only step needed to reproduce is essentially this: configuring an exec plugin which retrieves a valid token out of band and echoes it as part of an . Now any will trigger the exec plugin to retrieve a valid token, but will still not use it for subsequent authentication.\nThis one is caused by config merging with clientcmd overrides: and exec.Auth not being in this switch:\nInteresting, thanks Will add it to the switch along with some tests and if everything works out well I'll submit a PR next week.\nHaving spent some time on this in the debugger, it seems somewhat more intricate than I first thought. Turns out the exec plugin is executed whether the presented is invalid or valid - the exec action is actually called before the first call is even dispatched. This due to the exec credential plugin possibly being needed to setup the client certificate requested for the transport. Once the exec plugin's is called it assign the authenticators function to : ..which is then called when setting up the transport, thus triggering the exec plugin regardless of a token being present or not: Since the exec plugin has no way of knowing whether a token or a client certificate will be returned by the exec action, this kind of makes sense. It however defeats letting any present to override the exec plugin, which clearly seems to be the intent: Possible options here that I can think of: (and fix) behavior of letting override the exec plugin. This looks doable by adding a check for token auth early in the 's method body: But might be there are consequences to this I'm not aware of. the behavior of letting override the exec plugin being called. third, more complex option, would be to keep the token override but dispatch to the exec credential plugin should the response from the first call with the token come back with a 401. This was what I originally believed was the intent as my first tests always included an invalid token. While this behavior seems nice I'm more and more thinking it may violate the principle of least surprise. Either you present a token and use that for auth or you let the exec plugin fetch the credentials for you. What do you guys think?\nAs a colleague just made me aware of, certain tools like kubetail seem to have kubectl call the exec plugin so many times that eventually the threshold of 1000 is reached and warn logs (exec:201) start spewing - even though no certificate (and hence no rotation) should be involved. This has me more convinced that the first option is the right one, skipping the client TLS ceremonies should a token be present for authentication.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-2c90dab34971eac96519a918ee7caaf7a394dde783bc3a3d53d7f6b9e405e092", "text": "'-s' \"http://127.0.0.1:${API_PORT}\" ) <del> # token defined in hack/testdata/auth-tokens.csv kube_flags_with_token=( '-s' \"https://127.0.0.1:${SECURE_API_PORT}\" '--token=admin-token' '--insecure-skip-tls-verify=true' </del> <ins> kube_flags_without_token=( '-s' \"https://127.0.0.1:${SECURE_API_PORT}\" '--insecure-skip-tls-verify=true' </ins> ) <ins> # token defined in hack/testdata/auth-tokens.csv kube_flags_with_token=( \"${kube_flags_without_token[@]}\" '--token=admin-token' ) </ins> if [[ -z \"${ALLOW_SKEW:-}\" ]]; then kube_flags+=('--match-server-version') kube_flags_with_token+=('--match-server-version')", "commid": "kubernetes_pr_91745"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-31635c902aff9f8a2a2d4b7ec7f766a933cc4b8a93f6aa67e00afd6d1cd1a418", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: With the exec credentials plugin configured in my kubeconf, and a stale/expired token present in the same file issuing e.g. triggers the authentication flow as handled by the plugin - once the flow is returned to kubectl (by printing the ExecCredential object) the new token is stored to the kubeconfig but not immediately used to resolve the request, leading to: Immediately issuing again works as kubectl now seem to use the credentials (token) stored following the first request. What you expected to happen: That kubectl would read the new token as fetched by the exec credential plugin and use it already for the first command issued. How to reproduce it (as minimally and precisely as possible): the kubernetes API server with the OIDC authenticator enabled. kubectl to use an exec credential plugin printing the token received out of band. that the token was indeed written to the kubeconf file. that the first kubectl command failed. that the next identical command succeeds. Anything else we need to know?: This works as expected when there is no token previously stored in the kubeconf - the behavior is only triggered when there is a token stored but it expired, or for whatever other reason not accepted by the API server. Environment: Kubernetes version (use ): 1.14, also tried with 1.17 Cloud provider or hardware configuration: OS (e.g: ): Mac OS for kubectl client Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig auth /sig cli\ncould you provide more details around how is configured. For example, it is unclear to me if you are using the built in oidc plugin or a custom exec plugin. I think you are using a custom exec plugin but its also trying to write tokens to the file (which it should not do)? /triage needs-information\nThanks for looking into it . You are indeed correct in your assumption that I'm using a which stores the token in the after retrieval. I'd love to learn why this should not be done, but the problem remains also without persisting the token after retrieval. Basically the steps to reproduce could be reduced to these: containing an expired token. same configuring an exec plugin which retrieves a valid token out of band and echoes it. Expected behavior: The valid token retrieved is used for the subsequent authentication. Possibly expected behavior: The exec plugin flow not started (or exited with a warning) due to an expired token being present in the . Current behavior seems to acknowledge the invalid token and hence tries to retrieve a new, valid one - which it then discards as soon as it arrives.\nSeems we can reduce it even further by removing the token altogether from the file and instead provide it directly. So the only step needed to reproduce is essentially this: configuring an exec plugin which retrieves a valid token out of band and echoes it as part of an . Now any will trigger the exec plugin to retrieve a valid token, but will still not use it for subsequent authentication.\nThis one is caused by config merging with clientcmd overrides: and exec.Auth not being in this switch:\nInteresting, thanks Will add it to the switch along with some tests and if everything works out well I'll submit a PR next week.\nHaving spent some time on this in the debugger, it seems somewhat more intricate than I first thought. Turns out the exec plugin is executed whether the presented is invalid or valid - the exec action is actually called before the first call is even dispatched. This due to the exec credential plugin possibly being needed to setup the client certificate requested for the transport. Once the exec plugin's is called it assign the authenticators function to : ..which is then called when setting up the transport, thus triggering the exec plugin regardless of a token being present or not: Since the exec plugin has no way of knowing whether a token or a client certificate will be returned by the exec action, this kind of makes sense. It however defeats letting any present to override the exec plugin, which clearly seems to be the intent: Possible options here that I can think of: (and fix) behavior of letting override the exec plugin. This looks doable by adding a check for token auth early in the 's method body: But might be there are consequences to this I'm not aware of. the behavior of letting override the exec plugin being called. third, more complex option, would be to keep the token override but dispatch to the exec credential plugin should the response from the first call with the token come back with a 401. This was what I originally believed was the intent as my first tests always included an invalid token. While this behavior seems nice I'm more and more thinking it may violate the principle of least surprise. Either you present a token and use that for auth or you let the exec plugin fetch the credentials for you. What do you guys think?\nAs a colleague just made me aware of, certain tools like kubetail seem to have kubectl call the exec plugin so many times that eventually the threshold of 1000 is reached and warn logs (exec:201) start spewing - even though no certificate (and hence no rotation) should be involved. This has me more convinced that the first option is the right one, skipping the client TLS ceremonies should a token be present for authentication.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-4709195ade87d1c81bfe035cfe42a36fb2d31f117fb6cc1ca9a7df7fcd403a54", "text": "record_command run_nodes_tests fi <ins> ######################## # Authentication ######################## record_command run_exec_credentials_tests </ins> ######################## # authorization.k8s.io #", "commid": "kubernetes_pr_91745"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1374383302c8b2f5e1d9227ad3e6a5cd40003fd3af4f018f460ca706631944c5", "query": "What happened: Used kube- to bring up a GCE cluster and then logged on to the master. Run kubectl on the master, is hangs for a while (30 seconds) and then returns an error. $ kubectl get nodes Error from server (InternalError): an error on the server (\"\") has prevented the request from succeeding What you expected to happen: I expected to get the node list. If I use one of the system account's kubeconfig files it works. $ sudo kubectl --kubeconfig=/mnt/disks/master-pd/srv/kubernetes/kube-bootstrap/kubeconfig get nodes NAME STATUS ROLES AGE VERSION kubernetes-master Ready,SchedulingDisabled <none26m v1.18.0-alpha.2.55+-dirty kubernetes-minion-group-jfk6 Ready <none26m v1.18.0-alpha.2.55+-dirty kubernetes-minion-group-mqnp Ready <none26m v1.18.0-alpha.2.55+-dirty kubernetes-minion-group-x540 Ready <none26m v1.18.0-alpha.2.55+-dirty How to reproduce it (as minimally and precisely as possible): Bring up a GCE cluster from head, ssh to master and run \"kubectl get nodes\" Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:\"1\", Minor:\"18+\", GitVersion:\"v1.18.0-alpha.2.55+-dirty\", GitCommit:\"\", GitTreeState:\"dirty\", BuildDate:\"2020-01-23T00:38:39Z\", GoVersion:\"go1.13.6\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"18+\", GitVersion:\"v1.18.0-alpha.2.55+-dirty\", GitCommit:\"\", GitTreeState:\"dirty\", BuildDate:\"2020-01-23T00:36:29Z\", GoVersion:\"go1.13.6\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: GCE OS (e.g: ): COS m_77 Kernel (e.g. ): 4.19.76 Install tools: cluster/kube- Network plugin and version (if this is a network-related bug): Others: I believe this used to work based on talking to KAS on the insecure port using no authentication. The insecure port is now turned off and we require authentication materials. We should probably setup an admin account specifically for the master.\n/sig cli\n/assign\nI also would not have expected a hang, but an immediate error, and I would have expected an authentication error, not an internal error\nI believe the internal error is due to it defaulting to port 8080. Nothing is listening on that port. This used to work but I would guess it stopped working when we stopped listening on the insecure port.\nchanged behavior of client-go on connection refused errors, which changed a short wait and an \"invalid host/port\" error into a long retry wait and a confusing \"internal server\" error /assign\nif kubectl is intended to work automatically against the local API server, then a kubeconfig file should be set up, but the 30 second delay and incorrect error are a bug that should be fixed in client-go /sig api-machinery\n/remove-sig api-machinery /unassign actually, moved the client-go issue to will keep this one for the GCE $KUBECONFIG resolution\nI agree that seems like the right fix.\nI'm not sure this belong to sig-cli... looks like made this change /sig cluster-lifecycle /cc\nRe: set up a kubeconfig That's what we do for GKE: create an authenticated kubeconfig and set the env var. E.g. if you have an authenticated kubeconfig at :\nYes, GKE sets up an admin system account for the master(s) as part of the internal-configure-helper. I believe we should do the same thing for GCE.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-be154280fbc5f3c17ed3cbbd234943c6b4c0e94016a737a13ea06649549f2491", "text": "echo \"Running GKE internal configuration script\" . \"${KUBE_HOME}/bin/gke-internal-configure-helper.sh\" gke-internal-master-start <ins> elif [[ -n \"${KUBE_BEARER_TOKEN:-}\" ]]; then echo \"setting up local admin kubeconfig\" create-kubeconfig \"local-admin\" \"${KUBE_BEARER_TOKEN}\" echo \"export KUBECONFIG=/etc/srv/kubernetes/local-admin/kubeconfig\" > /etc/profile.d/kubeconfig.sh </ins> fi }", "commid": "kubernetes_pr_90826"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-143b0f1aae2935f6e5093d1fc3fbf7fef6f1f25a0d6c2f039aa34d7fd3e325f8", "query": "What happened: When running external CSI Driver tests with the Kubernetes E2E: We seem to be getting the following error. From initial investigation it looks like this happens in the during check but only when the test is being skipped. Hunch is that maybe since the test is skipped some resources are never created or they are cleaned up already and they are nil when the is called and expecting them. Kind of low priority since it doesn't make any tests actually fail. /cc /sig storage\nsee\nI think should address this", "positive_passages": [{"docid": "doc-en-kubernetes-4199feaea31b98961f9adb935bfeaf2f89b41e194e3d50aed913be127cb172c2", "text": "// the various afterEaches afterEaches map[string]AfterEachActionFunc <ins> // beforeEachStarted indicates that BeforeEach has started beforeEachStarted bool </ins> // configuration for framework's client Options Options", "commid": "kubernetes_pr_87511"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-143b0f1aae2935f6e5093d1fc3fbf7fef6f1f25a0d6c2f039aa34d7fd3e325f8", "query": "What happened: When running external CSI Driver tests with the Kubernetes E2E: We seem to be getting the following error. From initial investigation it looks like this happens in the during check but only when the test is being skipped. Hunch is that maybe since the test is skipped some resources are never created or they are cleaned up already and they are nil when the is called and expecting them. Kind of low priority since it doesn't make any tests actually fail. /cc /sig storage\nsee\nI think should address this", "positive_passages": [{"docid": "doc-en-kubernetes-d7555334cd9d3ee3b3c9b22e37e169ccb525beb158ebb0da9f7a9ffd55ac79c2", "text": "// BeforeEach gets a client and makes a namespace. func (f *Framework) BeforeEach() { <ins> f.beforeEachStarted = true </ins> // The fact that we need this feels like a bug in ginkgo. // https://github.com/onsi/ginkgo/issues/222 f.cleanupHandle = AddCleanupAction(f.AfterEach)", "commid": "kubernetes_pr_87511"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-143b0f1aae2935f6e5093d1fc3fbf7fef6f1f25a0d6c2f039aa34d7fd3e325f8", "query": "What happened: When running external CSI Driver tests with the Kubernetes E2E: We seem to be getting the following error. From initial investigation it looks like this happens in the during check but only when the test is being skipped. Hunch is that maybe since the test is skipped some resources are never created or they are cleaned up already and they are nil when the is called and expecting them. Kind of low priority since it doesn't make any tests actually fail. /cc /sig storage\nsee\nI think should address this", "positive_passages": [{"docid": "doc-en-kubernetes-6df302733686ab045686921f35d464b30352a3789f5be170dd4a29781f2e4e62", "text": "// AfterEach deletes the namespace, after reading its events. func (f *Framework) AfterEach() { <ins> // If BeforeEach never started AfterEach should be skipped. // Currently some tests under e2e/storage have this condition. if !f.beforeEachStarted { return } </ins> RemoveCleanupAction(f.cleanupHandle) <ins> // This should not happen. Given ClientSet is a public field a test must have updated it! // Error out early before any API calls during cleanup. if f.ClientSet == nil { Failf(\"The framework ClientSet must not be nil at this point\") } </ins> // DeleteNamespace at the very end in defer, to avoid any // expectation failures preventing deleting the namespace. defer func() {", "commid": "kubernetes_pr_87511"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-915370850f922c52baff913af6698146cfcbf304105ee540e15c6286e1599323", "query": "Not sure if this is a bug, feature requests, or a documentation issue. What happened: I am trying to apply some configs with --prune, and was surprised by the behavior. I have a config file with objects in multiple namespaces, and apply with (note: no flag). By kube context was set to a namespace that was not in the manifests. Here is what I found: If my context is set to a random namespace, nothing is pruned If its set to namespace X, only objects in namespace X are applied If I pass a flag I can control which namespace gets pruned, but that will break the apply because the file has multiple namespaces in it What you expected to happen: I expect some way to be able to apply a config file with objects in multiple namespace and having pruning across all namespaces. Seems there are a few options: all namespaces referenced in the file, prune these across all namespaces warn about why we are not pruning due to namespace mismatch How to reproduce it (as minimally and precisely as possible): Run the script from namespace default, a, and b. You will see different behavior on each run. Related? Environment: Kubernetes version (use ): 1.17.0 Others: /sig cli\nI encountered this issue. I think has the bug that o.namespace gets \"default\" if no namespace is given. Then only a single namespace is visited with or without namespace. If my observation is correct, it changes the bahaviour drastically. In my work, pruning just stops working.", "positive_passages": [{"docid": "doc-en-kubernetes-e4a7355151d6250448555f7fc9df36bc54e17d02766e53f95b8d769411c98c7d", "text": "} for n := range p.visitedNamespaces { <del> if len(o.Namespace) != 0 && n != o.Namespace { continue } </del> for _, m := range namespacedRESTMappings { if err := p.prune(n, m); err != nil { return fmt.Errorf(\"error pruning namespaced object %v: %v\", m.GroupVersionKind, err)", "commid": "kubernetes_pr_89551"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-915370850f922c52baff913af6698146cfcbf304105ee540e15c6286e1599323", "query": "Not sure if this is a bug, feature requests, or a documentation issue. What happened: I am trying to apply some configs with --prune, and was surprised by the behavior. I have a config file with objects in multiple namespaces, and apply with (note: no flag). By kube context was set to a namespace that was not in the manifests. Here is what I found: If my context is set to a random namespace, nothing is pruned If its set to namespace X, only objects in namespace X are applied If I pass a flag I can control which namespace gets pruned, but that will break the apply because the file has multiple namespaces in it What you expected to happen: I expect some way to be able to apply a config file with objects in multiple namespace and having pruning across all namespaces. Seems there are a few options: all namespaces referenced in the file, prune these across all namespaces warn about why we are not pruning due to namespace mismatch How to reproduce it (as minimally and precisely as possible): Run the script from namespace default, a, and b. You will see different behavior on each run. Related? Environment: Kubernetes version (use ): 1.17.0 Others: /sig cli\nI encountered this issue. I think has the bug that o.namespace gets \"default\" if no namespace is given. Then only a single namespace is visited with or without namespace. If my observation is correct, it changes the bahaviour drastically. In my work, pruning just stops working.", "positive_passages": [{"docid": "doc-en-kubernetes-fd5527661bb7851c9a6f715a391c5b55b9fb44088dd3105212a1cdc2d183d186", "text": "# cleanup kubectl delete svc prune-svc 2>&1 \"${kube_flags[@]:?}\" <ins> ## kubectl apply --prune can prune resources not in the defaulted namespace # Pre-Condition: namespace nsb exists; no POD exists kubectl create ns nsb kube::test::get_object_assert pods \"{{range.items}}{{${id_field:?}}}:{{end}}\" '' # apply a into namespace nsb kubectl apply --namespace nsb -f hack/testdata/prune/a.yaml \"${kube_flags[@]:?}\" kube::test::get_object_assert 'pods a -n nsb' \"{{${id_field:?}}}\" 'a' # apply b with namespace kubectl apply --namespace nsb -f hack/testdata/prune/b.yaml \"${kube_flags[@]:?}\" kube::test::get_object_assert 'pods b -n nsb' \"{{${id_field:?}}}\" 'b' # apply --prune must prune a kubectl apply --prune --all -f hack/testdata/prune/b.yaml # check wrong pod doesn't exist output_message=$(! kubectl get pods a -n nsb 2>&1 \"${kube_flags[@]:?}\") kube::test::if_has_string \"${output_message}\" 'pods \"a\" not found' # check right pod exists kube::test::get_object_assert 'pods b -n nsb' \"{{${id_field:?}}}\" 'b' # cleanup kubectl delete ns nsb ## kubectl apply -n must fail if input file contains namespace other than the one given in -n output_message=$(! kubectl apply -n foo -f hack/testdata/prune/b.yaml 2>&1 \"${kube_flags[@]:?}\") kube::test::if_has_string \"${output_message}\" 'the namespace from the provided object \"nsb\" does not match the namespace \"foo\".' </ins> ## kubectl apply -f some.yml --force # Pre-condition: no service exists", "commid": "kubernetes_pr_89551"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0f75b4e031b6dedf26dcd668791c9b4bd7f0f9329b05e0f830ed2db15c090fe1", "query": "What happened: Using leaderelection with ConfigMapLock, I get a panic when I fail to renew the lease. What you expected to happen: No crash How to reproduce it (as minimally and precisely as possible): Create a leaderelection setup with ReleaseOnCancel=true Run the program, allow a lock to be acquired. Change RBAC permissions to block configmap access Eventually we fail to acquire the lock and run into the panic above\n/sig api-machinery\n/assign\nlet me know if you need help getting more info, I am not sure if its easy to reproduce or not. I can add some extra debug logging, etc\nI will see if I can reproduce via unit test.\n/cc\nCan you check the log around the time of crash to see if there was the following ? Checking the events around the time of crash would also help: thanks\nI have the log snippet at the top, there is a\nI can also hit race conditions from a unit test. I can make this a new issue if preferred. and similar but slightly different:\nThere is some race around accessing observedRecord. We can use a Lock to protect the access. Please log a new issue. Thanks", "positive_passages": [{"docid": "doc-en-kubernetes-eb78ef48d36d92d2d60b75459752731eedf8c34ad519f3fa0c70d2d31a2f0e5e", "text": "if err != nil { return err } <ins> if cml.cm.Annotations == nil { cml.cm.Annotations = make(map[string]string) } </ins> cml.cm.Annotations[LeaderElectionRecordAnnotationKey] = string(recordBytes) cml.cm, err = cml.Client.ConfigMaps(cml.ConfigMapMeta.Namespace).Update(cml.cm) return err", "commid": "kubernetes_pr_87821"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5e5b950d571506f3e848bbc335531428e82786cb9d209d69a84a78892574f681", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Kubelet dies with a panic exception if CSI plugin returns NodeId == \"\" and nil error. Exception log see at the end of the message What you expected to happen: Kubelet should just raise an error to the plugin and ignore the registration. How to reproduce it (as minimally and precisely as possible): Create a CSI plugin with only Node that would implement GetNodeInfo as follows: Register it as a DaemonSet and see kublet crush Anything else we need to know?: Environment: Kubernetes version (use ): 1.14.10-gke.17 Cloud provider or hardware configuration: GKE OS (e.g: ): Container-Optimized OS (cos) Kernel (e.g. ): - Install tools: Network plugin and version (if this is a network-related bug): Others: Related exception Related line of code: - no check whether error is not nil before calling Error() on it.\n/sig storage\n/sig node is this the version of the kubelet too? 14 is out of support. is the issue reproducible with a 1.15+ kubelet?\n/assign\nI checked the code - same defect still exists in current codebase.\nthanks /priority important-soon\nWow, that was fast. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-35f8ef6033d0baea94ce57a1ca54b860d5114b8b07c253e6a3c41839b745f07e", "text": "\"fmt\" \"io\" \"net\" <del> \"strings\" </del> \"sync\" \"time\"", "commid": "kubernetes_pr_87818"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5e5b950d571506f3e848bbc335531428e82786cb9d209d69a84a78892574f681", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Kubelet dies with a panic exception if CSI plugin returns NodeId == \"\" and nil error. Exception log see at the end of the message What you expected to happen: Kubelet should just raise an error to the plugin and ignore the registration. How to reproduce it (as minimally and precisely as possible): Create a CSI plugin with only Node that would implement GetNodeInfo as follows: Register it as a DaemonSet and see kublet crush Anything else we need to know?: Environment: Kubernetes version (use ): 1.14.10-gke.17 Cloud provider or hardware configuration: GKE OS (e.g: ): Container-Optimized OS (cos) Kernel (e.g. ): - Install tools: Network plugin and version (if this is a network-related bug): Others: Related exception Related line of code: - no check whether error is not nil before calling Error() on it.\n/sig storage\n/sig node is this the version of the kubelet too? 14 is out of support. is the issue reproducible with a 1.15+ kubelet?\n/assign\nI checked the code - same defect still exists in current codebase.\nthanks /priority important-soon\nWow, that was fast. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-63199030474f215438269bc015ea20517745ce832d56bc568f13d0b1060130b4", "text": "if nodeID != \"\" { return true, nil } <del> // kubelet plugin registration service not implemented is a terminal error, no need to retry if strings.Contains(getNodeInfoError.Error(), \"no handler registered for plugin type\") { return false, getNodeInfoError </del> <ins> if getNodeInfoError != nil { klog.Warningf(\"Error calling CSI NodeGetInfo(): %v\", getNodeInfoError.Error()) </ins> } // Continue with exponential backoff return false, nil", "commid": "kubernetes_pr_87818"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5e5b950d571506f3e848bbc335531428e82786cb9d209d69a84a78892574f681", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Kubelet dies with a panic exception if CSI plugin returns NodeId == \"\" and nil error. Exception log see at the end of the message What you expected to happen: Kubelet should just raise an error to the plugin and ignore the registration. How to reproduce it (as minimally and precisely as possible): Create a CSI plugin with only Node that would implement GetNodeInfo as follows: Register it as a DaemonSet and see kublet crush Anything else we need to know?: Environment: Kubernetes version (use ): 1.14.10-gke.17 Cloud provider or hardware configuration: GKE OS (e.g: ): Container-Optimized OS (cos) Kernel (e.g. ): - Install tools: Network plugin and version (if this is a network-related bug): Others: Related exception Related line of code: - no check whether error is not nil before calling Error() on it.\n/sig storage\n/sig node is this the version of the kubelet too? 14 is out of support. is the issue reproducible with a 1.15+ kubelet?\n/assign\nI checked the code - same defect still exists in current codebase.\nthanks /priority important-soon\nWow, that was fast. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-f87e634c0100745834ea3b14130f6ea88882419ea1a25afe15ac20246b4e1e6d", "text": "csipbv1 \"github.com/container-storage-interface/spec/lib/go/csi\" api \"k8s.io/api/core/v1\" \"k8s.io/apimachinery/pkg/api/resource\" <ins> \"k8s.io/apimachinery/pkg/util/wait\" </ins> \"k8s.io/kubernetes/pkg/volume\" \"k8s.io/kubernetes/pkg/volume/csi/fake\" volumetypes \"k8s.io/kubernetes/pkg/volume/util/types\"", "commid": "kubernetes_pr_87818"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5e5b950d571506f3e848bbc335531428e82786cb9d209d69a84a78892574f681", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Kubelet dies with a panic exception if CSI plugin returns NodeId == \"\" and nil error. Exception log see at the end of the message What you expected to happen: Kubelet should just raise an error to the plugin and ignore the registration. How to reproduce it (as minimally and precisely as possible): Create a CSI plugin with only Node that would implement GetNodeInfo as follows: Register it as a DaemonSet and see kublet crush Anything else we need to know?: Environment: Kubernetes version (use ): 1.14.10-gke.17 Cloud provider or hardware configuration: GKE OS (e.g: ): Container-Optimized OS (cos) Kernel (e.g. ): - Install tools: Network plugin and version (if this is a network-related bug): Others: Related exception Related line of code: - no check whether error is not nil before calling Error() on it.\n/sig storage\n/sig node is this the version of the kubelet too? 14 is out of support. is the issue reproducible with a 1.15+ kubelet?\n/assign\nI checked the code - same defect still exists in current codebase.\nthanks /priority important-soon\nWow, that was fast. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-dbef861ecc1eaaae344351a0bbf3dcc79d74e2d3340c09bc74faf37c5b6716a9", "text": "expectedMaxVolumePerNode   int64 expectedAccessibleTopology map[string]string mustFail                   bool <ins> mustTimeout                bool </ins> err                        error }{ {", "commid": "kubernetes_pr_87818"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5e5b950d571506f3e848bbc335531428e82786cb9d209d69a84a78892574f681", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Kubelet dies with a panic exception if CSI plugin returns NodeId == \"\" and nil error. Exception log see at the end of the message What you expected to happen: Kubelet should just raise an error to the plugin and ignore the registration. How to reproduce it (as minimally and precisely as possible): Create a CSI plugin with only Node that would implement GetNodeInfo as follows: Register it as a DaemonSet and see kublet crush Anything else we need to know?: Environment: Kubernetes version (use ): 1.14.10-gke.17 Cloud provider or hardware configuration: GKE OS (e.g: ): Container-Optimized OS (cos) Kernel (e.g. ): - Install tools: Network plugin and version (if this is a network-related bug): Others: Related exception Related line of code: - no check whether error is not nil before calling Error() on it.\n/sig storage\n/sig node is this the version of the kubelet too? 14 is out of support. is the issue reproducible with a 1.15+ kubelet?\n/assign\nI checked the code - same defect still exists in current codebase.\nthanks /priority important-soon\nWow, that was fast. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-32225258249a66f8878e774c55af4001f0ba55a28b4b562e43b996edb730b033", "text": "mustFail: true, err:      errors.New(\"grpc error\"), }, <ins> { name:                       \"test empty nodeId\", mustTimeout:                true, expectedNodeID:             \"\", expectedMaxVolumePerNode:   16, expectedAccessibleTopology: map[string]string{\"com.example.csi-topology/zone\": \"zone1\"}, }, </ins> } for _, tc := range testCases {", "commid": "kubernetes_pr_87818"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5e5b950d571506f3e848bbc335531428e82786cb9d209d69a84a78892574f681", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Kubelet dies with a panic exception if CSI plugin returns NodeId == \"\" and nil error. Exception log see at the end of the message What you expected to happen: Kubelet should just raise an error to the plugin and ignore the registration. How to reproduce it (as minimally and precisely as possible): Create a CSI plugin with only Node that would implement GetNodeInfo as follows: Register it as a DaemonSet and see kublet crush Anything else we need to know?: Environment: Kubernetes version (use ): 1.14.10-gke.17 Cloud provider or hardware configuration: GKE OS (e.g: ): Container-Optimized OS (cos) Kernel (e.g. ): - Install tools: Network plugin and version (if this is a network-related bug): Others: Related exception Related line of code: - no check whether error is not nil before calling Error() on it.\n/sig storage\n/sig node is this the version of the kubelet too? 14 is out of support. is the issue reproducible with a 1.15+ kubelet?\n/assign\nI checked the code - same defect still exists in current codebase.\nthanks /priority important-soon\nWow, that was fast. Thanks!", "positive_passages": [{"docid": "doc-en-kubernetes-107790bc4006221b922c19e2cc8d7e22d936d9c8aa6177851983d8bc33783b57", "text": "} nodeID, maxVolumePerNode, accessibleTopology, err := client.NodeGetInfo(context.Background()) <del> checkErr(t, tc.mustFail, err) </del> <ins> if tc.mustTimeout { if wait.ErrWaitTimeout.Error() != err.Error() { t.Errorf(\"should have timed out : %s\", tc.name) } } else { checkErr(t, tc.mustFail, err) } </ins> if nodeID != tc.expectedNodeID { t.Errorf(\"expected nodeID: %v; got: %v\", tc.expectedNodeID, nodeID)", "commid": "kubernetes_pr_87818"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-99d5f10dcf25cc2fbe358f74e31ff561469628287156fd4c3b1b75db0492fdf9", "query": "Which jobs are failing: Since when has it been failing: Testgrid link: Reason for failure: Anything else we need to know: /milestone v1.18 /priority critical-urgent /cc /sig cluster-lifecycle /area provider/gcp\n/reopen Reopening, to observe the job.\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nSeveral of the recent failures appear to be this: cc\nnext run should pick up the change in we have had boskos outage clearing up now.\nThis is still not going to work because k/k has removed the .deb files we've been downloading from the CI artifacts:\nFYI we are discussing in Slack how to proceed to resolve this. I doubt it will be a simple, quick fix, though.\nme and did mention this on the k-dev: !msg/kubernetes-sig-cluster-lifecycle/q934Ah3SD64/JukDA9wsAgAJ given there were no replies we assumed there are no users. but this is definitely for the better as we removed the Bazel build of packages from k/k. 's PR seems to use binaries directly: i will have a look.\nClosed via There is a possibility we will publish debs again in the future (via ), but while that tool is in flux, I don't want anyone depending on it. Thanks for the fix, /close\nClosing this issue. <detailsIn response to : Closed via /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-c6bfe16ca608432eadacb34ef855356e710b1addb68f7a8ed30b79ae5869339a", "text": "exit 1 fi <ins> # Travis continuous build uses a head go release that doesn't report # a version number, so we skip this check on Travis.  Its unnecessary # there anyway. if [ ${TRAVIS} != \"true\" ]; then GO_VERSION=($(go version)) if [ ${GO_VERSION[2]} < \"go1.2\" ]; then echo \"Detected go version: ${GO_VERSION}.\" echo \"Kubernetes requires go version 1.2 or greater.\" echo \"Please install Go version 1.2 or later\" exit 1 fi fi </ins> pushd $(dirname \"${BASH_SOURCE}\")/.. >/dev/null KUBE_REPO_ROOT=\"${PWD}\" KUBE_TARGET=\"${KUBE_REPO_ROOT}/output/go\"", "commid": "kubernetes_pr_155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-23453cfe9279d45b88b1b76bf59719d6724b15443ac3ffc3c4eacd0d07ffeb70", "query": "Problem: Preferred pod/node affinity and preferred PodTopologySpread may not be respected because of conflicts with other scoring functions, like node utilization or image locality. Scheduler Scoring functions have weights, by default they are all set to 1 (apart from one): Having equal weights is problematic because of the way we score: each Scoring plugin returns a score [0, MaxScore], which get multiplied by the configured weight of the plugin, and a node score is the sum over all scores. Therefore, even if the user explicitly indicates that they prefer to place pod x on node y, this preference may not be respected and the scheduler may decide to place the pod on node z because it has lower usage and the container that the pod is requesting. Proposed Solution: Scoring functions that allow users to explicitly express preference should have higher weights than generic scoring functions. This includes: inter-pod affinity, node affinity, taint/toleration and pod topology spread. This issue is proposing to change the default behavior of the scheduler, I am not sure how k8s deprecation policy applies here, although I would argue that this change should help the scheduler make decisions closer to users expectations. We will start with pod topology pod spread since as of creating this issue, the feature is still in beta. /sig scheduling\nQuote from the : Rule : Deprecated behaviors must function for no less than 1 year after their announced deprecation. I think the rule doesn't apply to this proposal since it is not impacting the correctness of applications or impact administration of the cluster.\nAs nodepreferavoidpods already exercised to set its weight to 1000 by default, it sounds fair to me to increase the default weight for inter-pod affinity, node affinity, taint/toleration and pod topology spread. BTW: to some extent, we can use e2e tests verifying the to-proposed default weight. Right now we have some e2e tests covering priorities (scoring), but they depend on to ensure cpu/mem are at the same ratio of usage: and hence IMO a bit fragile.\nStrongly agree with this change. But, IMO, we may need to reconsider the default impact weights of each scoring plugin. Maybe they should have more weight ladders, rather than simply 1 or 1000. For example, from practical experience, in most cases should not be set to the same weight as , , etc. (Yes, we need to consider this for users, because most users may not notice this change).\nIMO a reasonable criterion to guide which Score plugins should have non-default weight is: whether the Score plugin is associated with an API (e.g., PodTopologySpread Score plugin is associated with .\nIf we give a higher weight only to the API-facing scores, then workloads that don't use these features are not affected, which is a good thing. I think a good weight to give to these scores is one that avoids it to be diluted among the rest of the scores. So, maybe a weight that is half the sum of all non-API-facing scores. Now, if a user uses the API for more than one score, I think we can safely assume that they want equal weights for them.\n/cc Daniel, can you comment on whether or not the proposed change conforms with k8s deprecation policy?\nI hate to say it, but I think you have to make the new set of weights an option and use the deprecation process to move people over. It's quite difficult to predict what a change in these weights might do to the overall scheduling behavior, no? If it was already possible to specify the settings (via flag or config file), then maybe there's a case to be made that the deprecation process is heavier than needed here. To make that case, you'd need to test and be VERY sure that the new settings are actually an improvement. The change sounds like an improvement, but I'd like to see that quantified / tested somehow. Perhaps even more importantly, I'd like to know the conditions under which it makes things worse, and along which dimensions. can give a second opinion if you don't like this answer :)\nThis may have an impact on availability (since by default the scheduler will prefer less under utilized nodes) and pod startup (less preference to node that already has the image) IF the pod have explicit preference for being on a specific node or with a specific pod. Those weights are actually configurable via the component config file, but most cloud providers don't allow customers to provide a custom configuration, they just use the default. Regarding the change of behavior, this effectively create two level scoring: first level is by user-specified preferences (affinity), second level is by workload-agnostic ones (e.g., image existence). If users are not specifying preferences, then this change have no impact.\nThose are good points, but how many users specify preferences? Should we encourage those users to use non-optional constraints, instead? I can imagine arguing that making the preferences more likely to be obeyed makes it rarer and therefore more surprising and worse when they can't be honored.\nI'm not sure if I'm understanding this correctly. Examples of non-optional scores are \"topology spreading\", \"resources utilization\" and \"image locality\". Users (aka Pods) can not opt-in or opt-out from them. Cluster operators (on prem or cloud-providers) can opt-out or change weights, but for a whole cluster. Remember that we are talking about node scoring. The nodes to be scored should have already passed the filters. Let's take an API-facing score (node affinity) and non-API-facing score (image locality) for illustrating the effect of weights: Imagine a pod is using \"preferred\" node affinity and there are no nodes available that satisfy that affinity. That means that in this case all nodes would get a low (or zero) score for node affinity. In this case the score given by image locality will provide the difference in score between all nodes. Now, let's say some nodes satisfy the node affinity. Those nodes will have the same high score for node affinity. But they will defer in image locality, which will be (in this case) the determining factor to select a node. However, in real (default) clusters we have more than 2 scores. And the problem is that pod preferences end up being diluted with all the other default scores summed up. What the proposal would achieve is that we first honor pod preferences and then we differentiate among the resulting nodes using the default scores.\nOK, so I guess the case where this hurts users is: They specified preferences The preferences are actually bad (plot twist) they're diluted so much that they're not having much effect but now the scheduler starts honoring them more often But it's still probabilistic, so we can expect some percentage of the time, the preferences continue to not get honored? Numerically, suppose 50% have preferences, 2% of those got them wrong, 80% of those are currently diluted (i.e., not already broken), and 10% of those are in environments where they'll suddenly get honored 100% after this change (becoming broken). That's .5.02.8*.1 = .08% of users, or 1 out of 1250 users this change could break. That's still maybe a little high for my taste, but maybe you have an alternative estimate?\nI think we can tweak how many of the currently diluted cases become honored. In I proposed that we use a weight of half the sum of the non-API-facing weights. We can be less aggressive and do a quarter or just 2 (we currently put weight of 1 for all).\nOn another note, I would say weights are actually part of the component config API. In both v1alpha1 and the new v1alpha2 (), you can tweak the weights of individual scores. Users might be setting up these weights assuming that the defaults are 1. This is not a problem with the old Policy API, because you have to specify all the scores with their weights. So, if we decide to change the weights, better do so now for v1alpha2.\nDaniel, I don't expect that 50% of k8s workloads have preferred pod/node affinities, but I don't have data to suggest an alternative estimate. I guess we could make the change behind a feature flag that gets graduated over multiple releases.\nIt is permissible for the default to change over versions, in fact that's the way to do it for API types. Since the type is alpha, I guess it's OK to just do this. So, if the config file is v1alpha1, do the old defaults; if it's v1alpha2, use the new ones. How does that sound?\nsgtm. But the question of what's a good weight for api-facing scores still remains. By default we only have 4 non-api-facing scores: NodeResourcesBalancedAllocation ImageLocality NodeResourcesLeastAllocated DefaultPodTopologySpread So my two proposals are actually the same number: 2 :sweat:\nWhat about the case where a config file is not provided at all (which is very common across all cloud providers)? I guess we will have to keep the old defaults, and so we didn't actually solve the issue, right? it will also be confusing to users who pass a config file that doesn't change any of the weights.\nIf there's no config file at all, I think it's fair game, users can easily get the old behavior if needed. Others might disagree with me, but that's what I think. A completely separate thought: are you sure changing the weights is good? What about changing the way they're evaluated? E.g. in ML it's common to use e.g. a softmax function at the last layer to force a NN to make a choice / assign a consistent set of probabilities to each option. I think the way that might look here is instead of using F(N) as F's priority for node N, use exp(F(N)) / SUM (N0-Nn) { exp(F(N)) }. This would have the effect of magnifying minor preferences. Basically, I'm claiming that priority functions should be distributing the same amount of \"probability mass\" over the N possible nodes. It's not fair for one function to say \".3\" for everything while another says \".6\" for everything. You maybe need to normalize this before applying the weighting function anyway. But if you do the softmax, you might not even need the weight, as priority functions that give each node the same score will basically be no-ops, letting ones with differing opinions win.\nInteresting proposal, but don't you think weights will still be needed because unlike NN, the scheduler didn't go through a training phase to discover which features (in this case priority functions) provide the most important signal?\nLet's put an scenario with three simplified scores: selected: a score that prefers a particular set of nodes (maybe a particular zone). : existence of an image. : low utilization Now let's assume they give the following scores: Notice that they all have the same distribution (so they all give good signal). Even when using softmax the sum of scores (with the same weight for every score) will be: Nodes 1, 4 and 7 have the same score and thus the same probability to be chosen. I would argue that the user intention was that node 4 would be selected. It's still called a preference because if would give 0 to all nodes, then the pod can still go to the nodes, and the automatic scores take all the decision. Now, in the default scheduler, we have 4 automatic scores, so the user preference is quite unlikely to get respected. It's not necessarily a matter of good signal from the score.\nYup good points-- I agree a weight is still needed. If all the numbers are 0 or 1 (I had thought that it was a floating point and not a binary signal) then I don't think softmax is going to be different than a linear normalization (?). I guess it's debatable whether one wants a priority function that selects fewer nodes to have its opinion on those nodes be weighted more highly, which is what normalization would do. Anyway sorry if this is a rabbit hole. :) I think this idea would make more sense if the priority functions could express a strength for their preference and not just yes/no.\nIt's not binary necessarily... I was over simplifying. Node affinity and image locality certainly are, but node utilization is not.\nIt might be worth some experiments, then... if you have some way of telling whether or not it's actually better? Aldo Culquicondor <:\nWe have an HA use case that involves spreading pods across nodes and zone with preferred scheduling since we'd rather schedule the pods than not. Before 1.18, we've been using the something like the following: Now with the 1.18 beta, we tried the following: The later yields better scheduling results than the former on a 9 nodes multi-zone cluster with 3 nodes in each node. So while was better it surprisingly didn't yield a perfect spread. So I decided to combine both and ... boom ... we had a perfect pod spread for our deployment with 9 replicas. I'm not sure how these results fit into the discussions so far but I would have expected either option by itself to yield a better spread. Combining the two lets me reinforce my desires to the scheduler. IMO, I would like to see the scheduler give my explicit request more weight.\nthanks a lot for sharing. Giving more weight to explicit requests is what we are proposing. However, I'm a little surprised that you need these constraints. The scheduler already spreads by default when using services, replica set or stateful sets. Are these pods not members of any of those? I assume you are not modifying the scheduler configuration? But, of course, there are other scores in play. It makes sense that spreading constraints are more effective than antiaffinity, because there is a lot of antiaffinity with the node that is ultimately selected as well. Adding both specs works too. However, this increases scheduling latency, as we have to calculate more things. The main motivation for this issue was actually to make scoring more effective for the opposite case, which is not done by default: \"packing\". But your use case is just as valid.\nThese pods are part of a deployment. I tried without any scheduling preferences and the results are similar to podAntiAffinity preferred scheduling. Here is the baseline deployment yaml used for the tests: I have not modified the scheduler configuration.\nYes, deployments are affected because they create a replica set that owns the pods. But there are always other scores at play that might also be important, which is why a \"preferred\" spreading is never going to be perfect. This is kind of the point that was trying to make: guarding users from over-fitting and degrading the clusters in some way.\nWhat if we reduce the scope to just PodTopologySpreading, which is beta since 1.18? We could give it a weight of 2 now, before going to GA.\nAldo, one thing to take into account is the new default spread logic which is based on default pod topology spread constraints. For default spread constraints, I think the weight shouldn't increase, so things will get a little complicated with how we treat this case.\nGiven that default spread constraints is explicitly specified by users in , maybe we can assume they are already aware of adjusting the \"Weight\" in ? While for regular users, they won't touch , so a default non-1 weight is a no-op for them.\nthe default constraints (which we plan to introduce to replace the current defaultpodspreading score plugin) are not explicitly specified in PluginConfig.\nMaybe I missed something, are we talking about the same default constraints defined here?\nyes we are, but isn't the plan to have a default value for DefaultConstraints when not set: two constraints, one for zone and one for hostname, which mimic the current defaultpodspread behaviour and allows us to deprecate it?\nI think the only way around that is to introduce a weight for default constraints in the plugin config. And then set it to 50% for the k8s default.\nhmm, this will be a confusing configuration parameter to users. Another approach to consider is to bake it into the TopologySpread plugin instantiation without needing to pass it through PluginConfig (similar to what we did for volumebinder in the past: ).\nurgh, this will be tricky to do since defaulting will be done via component config, and so we don't have a way to communicate whether the values were defaults or explicitly set by the user. If defaulting is done in then it might be possible, but we shouldn't do that.\nDefaulting is going to happen in in the near future\nWe can have it in the internal type, but not the external one then. This will hide it from the users. But how do we communicate that to conversion logic?!\nIt doesn't seem there is a way because defaulting happens before conversion...\nTo make the new parameter semantically clear, we can treat it as a weight override rather than a percentage of the plugin weight, and so it's default would be 1 rather than 50%, internally the plugin computes the ratio as the override weight divided by the plugin weight, which it uses to scale scores computed for pods that don't have topology spread specified in their spec.\nGot it now. I thought the default constraints would default to nil if not specified by users. I think we should introduce a field called \"multiplexer\" and default to 1, so it's friendly to defaulting and conversion.\n+1.\nWhat if we start giving meaning to MaxSkew for scoring? If you set a low MaxSkew, you probably want it to have a higher effect than if you set a bigger value. We can discuss the exact formula, but I think adding these semantics make sense. On Sat., Apr. 18, 2020, 5:50 p.m. Wei Huang, <:\nThat's possible. Current Score function doesn't take into consideration - it's just following a simple \"the less number of matching Pods a topology has, the higher score the Nodes on that topology are given\" principle.\nNote that if we add another parameter to the args, it would only be relevant for scoring, adding to the confusion.\n: This score calculation is somewhat complicated, but can be resumed as: Calculate number of matching pods per topology. There is some new feature that takes in consideration the skew Normalize by . The effect is that pods with the lowest count get a score of . Then the rest of the scores go from a certain number to . A score is given to a node with when is . This formula has the effect of reducing differentiation among nodes as the increases. : The formula is very simple, the score is equal to the percentage of free space (averaged for cpu and memory). Each score on their own give the differentiation we want, but they kind of have different scales. As a result tends to be stronger. I'm using a 9 nodes (3 in each zone) cluster as an example. I've set different initial loads, and in all cases I simulate a Deployment of 30 pods (each assumed to take 1% of node resources). Here are the scenarios, where numbers are percentage of use: For equal score weights (current configuration), this is the distribution of new pods: for both nodes and zones Note how a node with only 40% utilization gets only 1 or 0 pods. For double score weights for both nodes and zones Only at 80% utilization we observe bigger skews, which is reasonable. But the spreading is still pretty good at 40% For planned default spreading See , but this might change, depending on feedback here. I think this is enough justification to increase the weight of to 2 in its 2nd beta release.\nSounds reasonable. It's mathematically equivalent to changing the formula to e.g. , right? Have you considered doing that instead of changing the weight? It seems like that'd help everyone except those who specifically already increased , instead of just people who are using the defaults?\nIt'd make sense to me if the available functions were in the same scale / units so that they'd compose better, but it's not obvious how to do that--what would the units be? One thought is to make the units \"std deviations from the mean\"--if we knew the output frequency of each function, we could maybe do that. So basically this would measure how unusual a preference is, I guess. (I don't think this is an actionable thought. It really bugs me that the outputs of these functions are combined when they are not really in the same units, though!)\nYes 100 is the maximum score we have defined any plugins to have. I'm not convinced this would work. The variance in my examples for initial resource usage is quite high. So it would still get a lot of importance. But, you have triggered me to start thinking about the linearity of the scores. The formula is good because it reduce the variance as increases. However, that reduction is too aggressive. On the other hand, is completely linear. I'll experiment changing the linearity of either function, but preferring to do so for the beta plugin.\nHere go 2 alternatives, with the same situations as We either solution, we wouldn't need to modify the weights Although we are not getting as good spreading as simply doubling the weight. But this is only in the last scenario, where we have usages of 80%. So I would call this rather a win (we should be paying greater attention to resource usage at this point). I think option B is simpler to understand and gives slightly better results (only noticeable in the last case). So this would be my algorithmic preference. However, I'm fine with option A.\nYeah, that's a great idea. You can generalize that and give each function a both a linear weight and a \"gamma\" (name from image processing): or even go for (but in this case I'm in favor of just making a targeted fix to that one function)\nAwesome, Any concerns against option B? Given that it's an older feature.\nhow would option B impact node ranking in the absence of spreading? would image size scores start to have bigger impact?\nI think SIG Scheduling should probably have a discussion. I could go either way, my naive inclination is to just go for the change, but I'm sure it'll break someone. We probably need a way to get back the old behavior, or a suggested weight change that would approximate it (not clear how well that could do though). I also have question, which is how well does this new value compose with other functions? I feel like the proper answer looks like an evaluation criteria + {long list of scenarios} + {list of workloads to schedule} + randomized testing / benchmarking. Basically the multi-dimensional version of the analysis here. That sounds like a lot of work but it would permit actual optimization of these functions.\nconfigurable gamma is an obvious way... :/\nI don't think we want another config parameter, we already have the weight concept and it is configurable, so I think we should go with that, just double the spreading score weight by default, and users who don't favor this behavior can configure it back to 1.\nYeah, that sounds expedient. ahg-g <:\nIn short, yes. Although that score has a mechanism to avoid the \"node heating problem\" we could have undesirable consequences unless we carefully analyze the impact. But that same reasoning doesn't apply to option A (improving PodTopologySpreading), for the following reasons: The score in 1.18 had pretty weak signal, that was only useful with very small number of pods. We have drastically improved this . So it can only be compared to other scores now. The score can now be tweaked in the PodSpec through maxSkew I would argue that option ~B~ A is better that simply doubling the weight because its signal is more conservative when it matters (nodes have high usage).\nI am not clear on the following: you say \"we could have undesirable consequences unless we carefully analyze the impact.\" but then you argue for the option at the end, can you clarify? We had default spreading that was giving similar strong signal, we should compare with that. My concern with modifying the is that we may break someone. Increasing the weight is something that users can revert, while option B can't be reverted.\nSorry, I meant option A, improve PodTopologySpread\nOne potential advantage to doubling the weight is that topology spread currently offers a signal comparable to default spreading, which we can think of as a baseline for spreading signal since it has been used for a while now. Doubling the weight will allow admins to revert back to the old behavior if they wish to do so. Also, from my perspective, doubling the weight is giving better placement at high utilization ( vs )", "positive_passages": [{"docid": "doc-en-kubernetes-9fa0e1aaa6135f2e34f257f350af1152f3eeb43c4483643583950f14e9bdb37b", "text": "config.PreFilter.Enabled = append(config.PreFilter.Enabled, f) config.Filter.Enabled = append(config.Filter.Enabled, f) config.PreScore.Enabled = append(config.PreScore.Enabled, f) <del> s := schedulerapi.Plugin{Name: podtopologyspread.Name, Weight: 1} </del> <ins> // Weight is doubled because: // - This is a score coming from user preference. // - It makes its signal comparable to NodeResourcesLeastAllocated. s := schedulerapi.Plugin{Name: podtopologyspread.Name, Weight: 2} </ins> config.Score.Enabled = append(config.Score.Enabled, s) }", "commid": "kubernetes_pr_91258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-23453cfe9279d45b88b1b76bf59719d6724b15443ac3ffc3c4eacd0d07ffeb70", "query": "Problem: Preferred pod/node affinity and preferred PodTopologySpread may not be respected because of conflicts with other scoring functions, like node utilization or image locality. Scheduler Scoring functions have weights, by default they are all set to 1 (apart from one): Having equal weights is problematic because of the way we score: each Scoring plugin returns a score [0, MaxScore], which get multiplied by the configured weight of the plugin, and a node score is the sum over all scores. Therefore, even if the user explicitly indicates that they prefer to place pod x on node y, this preference may not be respected and the scheduler may decide to place the pod on node z because it has lower usage and the container that the pod is requesting. Proposed Solution: Scoring functions that allow users to explicitly express preference should have higher weights than generic scoring functions. This includes: inter-pod affinity, node affinity, taint/toleration and pod topology spread. This issue is proposing to change the default behavior of the scheduler, I am not sure how k8s deprecation policy applies here, although I would argue that this change should help the scheduler make decisions closer to users expectations. We will start with pod topology pod spread since as of creating this issue, the feature is still in beta. /sig scheduling\nQuote from the : Rule : Deprecated behaviors must function for no less than 1 year after their announced deprecation. I think the rule doesn't apply to this proposal since it is not impacting the correctness of applications or impact administration of the cluster.\nAs nodepreferavoidpods already exercised to set its weight to 1000 by default, it sounds fair to me to increase the default weight for inter-pod affinity, node affinity, taint/toleration and pod topology spread. BTW: to some extent, we can use e2e tests verifying the to-proposed default weight. Right now we have some e2e tests covering priorities (scoring), but they depend on to ensure cpu/mem are at the same ratio of usage: and hence IMO a bit fragile.\nStrongly agree with this change. But, IMO, we may need to reconsider the default impact weights of each scoring plugin. Maybe they should have more weight ladders, rather than simply 1 or 1000. For example, from practical experience, in most cases should not be set to the same weight as , , etc. (Yes, we need to consider this for users, because most users may not notice this change).\nIMO a reasonable criterion to guide which Score plugins should have non-default weight is: whether the Score plugin is associated with an API (e.g., PodTopologySpread Score plugin is associated with .\nIf we give a higher weight only to the API-facing scores, then workloads that don't use these features are not affected, which is a good thing. I think a good weight to give to these scores is one that avoids it to be diluted among the rest of the scores. So, maybe a weight that is half the sum of all non-API-facing scores. Now, if a user uses the API for more than one score, I think we can safely assume that they want equal weights for them.\n/cc Daniel, can you comment on whether or not the proposed change conforms with k8s deprecation policy?\nI hate to say it, but I think you have to make the new set of weights an option and use the deprecation process to move people over. It's quite difficult to predict what a change in these weights might do to the overall scheduling behavior, no? If it was already possible to specify the settings (via flag or config file), then maybe there's a case to be made that the deprecation process is heavier than needed here. To make that case, you'd need to test and be VERY sure that the new settings are actually an improvement. The change sounds like an improvement, but I'd like to see that quantified / tested somehow. Perhaps even more importantly, I'd like to know the conditions under which it makes things worse, and along which dimensions. can give a second opinion if you don't like this answer :)\nThis may have an impact on availability (since by default the scheduler will prefer less under utilized nodes) and pod startup (less preference to node that already has the image) IF the pod have explicit preference for being on a specific node or with a specific pod. Those weights are actually configurable via the component config file, but most cloud providers don't allow customers to provide a custom configuration, they just use the default. Regarding the change of behavior, this effectively create two level scoring: first level is by user-specified preferences (affinity), second level is by workload-agnostic ones (e.g., image existence). If users are not specifying preferences, then this change have no impact.\nThose are good points, but how many users specify preferences? Should we encourage those users to use non-optional constraints, instead? I can imagine arguing that making the preferences more likely to be obeyed makes it rarer and therefore more surprising and worse when they can't be honored.\nI'm not sure if I'm understanding this correctly. Examples of non-optional scores are \"topology spreading\", \"resources utilization\" and \"image locality\". Users (aka Pods) can not opt-in or opt-out from them. Cluster operators (on prem or cloud-providers) can opt-out or change weights, but for a whole cluster. Remember that we are talking about node scoring. The nodes to be scored should have already passed the filters. Let's take an API-facing score (node affinity) and non-API-facing score (image locality) for illustrating the effect of weights: Imagine a pod is using \"preferred\" node affinity and there are no nodes available that satisfy that affinity. That means that in this case all nodes would get a low (or zero) score for node affinity. In this case the score given by image locality will provide the difference in score between all nodes. Now, let's say some nodes satisfy the node affinity. Those nodes will have the same high score for node affinity. But they will defer in image locality, which will be (in this case) the determining factor to select a node. However, in real (default) clusters we have more than 2 scores. And the problem is that pod preferences end up being diluted with all the other default scores summed up. What the proposal would achieve is that we first honor pod preferences and then we differentiate among the resulting nodes using the default scores.\nOK, so I guess the case where this hurts users is: They specified preferences The preferences are actually bad (plot twist) they're diluted so much that they're not having much effect but now the scheduler starts honoring them more often But it's still probabilistic, so we can expect some percentage of the time, the preferences continue to not get honored? Numerically, suppose 50% have preferences, 2% of those got them wrong, 80% of those are currently diluted (i.e., not already broken), and 10% of those are in environments where they'll suddenly get honored 100% after this change (becoming broken). That's .5.02.8*.1 = .08% of users, or 1 out of 1250 users this change could break. That's still maybe a little high for my taste, but maybe you have an alternative estimate?\nI think we can tweak how many of the currently diluted cases become honored. In I proposed that we use a weight of half the sum of the non-API-facing weights. We can be less aggressive and do a quarter or just 2 (we currently put weight of 1 for all).\nOn another note, I would say weights are actually part of the component config API. In both v1alpha1 and the new v1alpha2 (), you can tweak the weights of individual scores. Users might be setting up these weights assuming that the defaults are 1. This is not a problem with the old Policy API, because you have to specify all the scores with their weights. So, if we decide to change the weights, better do so now for v1alpha2.\nDaniel, I don't expect that 50% of k8s workloads have preferred pod/node affinities, but I don't have data to suggest an alternative estimate. I guess we could make the change behind a feature flag that gets graduated over multiple releases.\nIt is permissible for the default to change over versions, in fact that's the way to do it for API types. Since the type is alpha, I guess it's OK to just do this. So, if the config file is v1alpha1, do the old defaults; if it's v1alpha2, use the new ones. How does that sound?\nsgtm. But the question of what's a good weight for api-facing scores still remains. By default we only have 4 non-api-facing scores: NodeResourcesBalancedAllocation ImageLocality NodeResourcesLeastAllocated DefaultPodTopologySpread So my two proposals are actually the same number: 2 :sweat:\nWhat about the case where a config file is not provided at all (which is very common across all cloud providers)? I guess we will have to keep the old defaults, and so we didn't actually solve the issue, right? it will also be confusing to users who pass a config file that doesn't change any of the weights.\nIf there's no config file at all, I think it's fair game, users can easily get the old behavior if needed. Others might disagree with me, but that's what I think. A completely separate thought: are you sure changing the weights is good? What about changing the way they're evaluated? E.g. in ML it's common to use e.g. a softmax function at the last layer to force a NN to make a choice / assign a consistent set of probabilities to each option. I think the way that might look here is instead of using F(N) as F's priority for node N, use exp(F(N)) / SUM (N0-Nn) { exp(F(N)) }. This would have the effect of magnifying minor preferences. Basically, I'm claiming that priority functions should be distributing the same amount of \"probability mass\" over the N possible nodes. It's not fair for one function to say \".3\" for everything while another says \".6\" for everything. You maybe need to normalize this before applying the weighting function anyway. But if you do the softmax, you might not even need the weight, as priority functions that give each node the same score will basically be no-ops, letting ones with differing opinions win.\nInteresting proposal, but don't you think weights will still be needed because unlike NN, the scheduler didn't go through a training phase to discover which features (in this case priority functions) provide the most important signal?\nLet's put an scenario with three simplified scores: selected: a score that prefers a particular set of nodes (maybe a particular zone). : existence of an image. : low utilization Now let's assume they give the following scores: Notice that they all have the same distribution (so they all give good signal). Even when using softmax the sum of scores (with the same weight for every score) will be: Nodes 1, 4 and 7 have the same score and thus the same probability to be chosen. I would argue that the user intention was that node 4 would be selected. It's still called a preference because if would give 0 to all nodes, then the pod can still go to the nodes, and the automatic scores take all the decision. Now, in the default scheduler, we have 4 automatic scores, so the user preference is quite unlikely to get respected. It's not necessarily a matter of good signal from the score.\nYup good points-- I agree a weight is still needed. If all the numbers are 0 or 1 (I had thought that it was a floating point and not a binary signal) then I don't think softmax is going to be different than a linear normalization (?). I guess it's debatable whether one wants a priority function that selects fewer nodes to have its opinion on those nodes be weighted more highly, which is what normalization would do. Anyway sorry if this is a rabbit hole. :) I think this idea would make more sense if the priority functions could express a strength for their preference and not just yes/no.\nIt's not binary necessarily... I was over simplifying. Node affinity and image locality certainly are, but node utilization is not.\nIt might be worth some experiments, then... if you have some way of telling whether or not it's actually better? Aldo Culquicondor <:\nWe have an HA use case that involves spreading pods across nodes and zone with preferred scheduling since we'd rather schedule the pods than not. Before 1.18, we've been using the something like the following: Now with the 1.18 beta, we tried the following: The later yields better scheduling results than the former on a 9 nodes multi-zone cluster with 3 nodes in each node. So while was better it surprisingly didn't yield a perfect spread. So I decided to combine both and ... boom ... we had a perfect pod spread for our deployment with 9 replicas. I'm not sure how these results fit into the discussions so far but I would have expected either option by itself to yield a better spread. Combining the two lets me reinforce my desires to the scheduler. IMO, I would like to see the scheduler give my explicit request more weight.\nthanks a lot for sharing. Giving more weight to explicit requests is what we are proposing. However, I'm a little surprised that you need these constraints. The scheduler already spreads by default when using services, replica set or stateful sets. Are these pods not members of any of those? I assume you are not modifying the scheduler configuration? But, of course, there are other scores in play. It makes sense that spreading constraints are more effective than antiaffinity, because there is a lot of antiaffinity with the node that is ultimately selected as well. Adding both specs works too. However, this increases scheduling latency, as we have to calculate more things. The main motivation for this issue was actually to make scoring more effective for the opposite case, which is not done by default: \"packing\". But your use case is just as valid.\nThese pods are part of a deployment. I tried without any scheduling preferences and the results are similar to podAntiAffinity preferred scheduling. Here is the baseline deployment yaml used for the tests: I have not modified the scheduler configuration.\nYes, deployments are affected because they create a replica set that owns the pods. But there are always other scores at play that might also be important, which is why a \"preferred\" spreading is never going to be perfect. This is kind of the point that was trying to make: guarding users from over-fitting and degrading the clusters in some way.\nWhat if we reduce the scope to just PodTopologySpreading, which is beta since 1.18? We could give it a weight of 2 now, before going to GA.\nAldo, one thing to take into account is the new default spread logic which is based on default pod topology spread constraints. For default spread constraints, I think the weight shouldn't increase, so things will get a little complicated with how we treat this case.\nGiven that default spread constraints is explicitly specified by users in , maybe we can assume they are already aware of adjusting the \"Weight\" in ? While for regular users, they won't touch , so a default non-1 weight is a no-op for them.\nthe default constraints (which we plan to introduce to replace the current defaultpodspreading score plugin) are not explicitly specified in PluginConfig.\nMaybe I missed something, are we talking about the same default constraints defined here?\nyes we are, but isn't the plan to have a default value for DefaultConstraints when not set: two constraints, one for zone and one for hostname, which mimic the current defaultpodspread behaviour and allows us to deprecate it?\nI think the only way around that is to introduce a weight for default constraints in the plugin config. And then set it to 50% for the k8s default.\nhmm, this will be a confusing configuration parameter to users. Another approach to consider is to bake it into the TopologySpread plugin instantiation without needing to pass it through PluginConfig (similar to what we did for volumebinder in the past: ).\nurgh, this will be tricky to do since defaulting will be done via component config, and so we don't have a way to communicate whether the values were defaults or explicitly set by the user. If defaulting is done in then it might be possible, but we shouldn't do that.\nDefaulting is going to happen in in the near future\nWe can have it in the internal type, but not the external one then. This will hide it from the users. But how do we communicate that to conversion logic?!\nIt doesn't seem there is a way because defaulting happens before conversion...\nTo make the new parameter semantically clear, we can treat it as a weight override rather than a percentage of the plugin weight, and so it's default would be 1 rather than 50%, internally the plugin computes the ratio as the override weight divided by the plugin weight, which it uses to scale scores computed for pods that don't have topology spread specified in their spec.\nGot it now. I thought the default constraints would default to nil if not specified by users. I think we should introduce a field called \"multiplexer\" and default to 1, so it's friendly to defaulting and conversion.\n+1.\nWhat if we start giving meaning to MaxSkew for scoring? If you set a low MaxSkew, you probably want it to have a higher effect than if you set a bigger value. We can discuss the exact formula, but I think adding these semantics make sense. On Sat., Apr. 18, 2020, 5:50 p.m. Wei Huang, <:\nThat's possible. Current Score function doesn't take into consideration - it's just following a simple \"the less number of matching Pods a topology has, the higher score the Nodes on that topology are given\" principle.\nNote that if we add another parameter to the args, it would only be relevant for scoring, adding to the confusion.\n: This score calculation is somewhat complicated, but can be resumed as: Calculate number of matching pods per topology. There is some new feature that takes in consideration the skew Normalize by . The effect is that pods with the lowest count get a score of . Then the rest of the scores go from a certain number to . A score is given to a node with when is . This formula has the effect of reducing differentiation among nodes as the increases. : The formula is very simple, the score is equal to the percentage of free space (averaged for cpu and memory). Each score on their own give the differentiation we want, but they kind of have different scales. As a result tends to be stronger. I'm using a 9 nodes (3 in each zone) cluster as an example. I've set different initial loads, and in all cases I simulate a Deployment of 30 pods (each assumed to take 1% of node resources). Here are the scenarios, where numbers are percentage of use: For equal score weights (current configuration), this is the distribution of new pods: for both nodes and zones Note how a node with only 40% utilization gets only 1 or 0 pods. For double score weights for both nodes and zones Only at 80% utilization we observe bigger skews, which is reasonable. But the spreading is still pretty good at 40% For planned default spreading See , but this might change, depending on feedback here. I think this is enough justification to increase the weight of to 2 in its 2nd beta release.\nSounds reasonable. It's mathematically equivalent to changing the formula to e.g. , right? Have you considered doing that instead of changing the weight? It seems like that'd help everyone except those who specifically already increased , instead of just people who are using the defaults?\nIt'd make sense to me if the available functions were in the same scale / units so that they'd compose better, but it's not obvious how to do that--what would the units be? One thought is to make the units \"std deviations from the mean\"--if we knew the output frequency of each function, we could maybe do that. So basically this would measure how unusual a preference is, I guess. (I don't think this is an actionable thought. It really bugs me that the outputs of these functions are combined when they are not really in the same units, though!)\nYes 100 is the maximum score we have defined any plugins to have. I'm not convinced this would work. The variance in my examples for initial resource usage is quite high. So it would still get a lot of importance. But, you have triggered me to start thinking about the linearity of the scores. The formula is good because it reduce the variance as increases. However, that reduction is too aggressive. On the other hand, is completely linear. I'll experiment changing the linearity of either function, but preferring to do so for the beta plugin.\nHere go 2 alternatives, with the same situations as We either solution, we wouldn't need to modify the weights Although we are not getting as good spreading as simply doubling the weight. But this is only in the last scenario, where we have usages of 80%. So I would call this rather a win (we should be paying greater attention to resource usage at this point). I think option B is simpler to understand and gives slightly better results (only noticeable in the last case). So this would be my algorithmic preference. However, I'm fine with option A.\nYeah, that's a great idea. You can generalize that and give each function a both a linear weight and a \"gamma\" (name from image processing): or even go for (but in this case I'm in favor of just making a targeted fix to that one function)\nAwesome, Any concerns against option B? Given that it's an older feature.\nhow would option B impact node ranking in the absence of spreading? would image size scores start to have bigger impact?\nI think SIG Scheduling should probably have a discussion. I could go either way, my naive inclination is to just go for the change, but I'm sure it'll break someone. We probably need a way to get back the old behavior, or a suggested weight change that would approximate it (not clear how well that could do though). I also have question, which is how well does this new value compose with other functions? I feel like the proper answer looks like an evaluation criteria + {long list of scenarios} + {list of workloads to schedule} + randomized testing / benchmarking. Basically the multi-dimensional version of the analysis here. That sounds like a lot of work but it would permit actual optimization of these functions.\nconfigurable gamma is an obvious way... :/\nI don't think we want another config parameter, we already have the weight concept and it is configurable, so I think we should go with that, just double the spreading score weight by default, and users who don't favor this behavior can configure it back to 1.\nYeah, that sounds expedient. ahg-g <:\nIn short, yes. Although that score has a mechanism to avoid the \"node heating problem\" we could have undesirable consequences unless we carefully analyze the impact. But that same reasoning doesn't apply to option A (improving PodTopologySpreading), for the following reasons: The score in 1.18 had pretty weak signal, that was only useful with very small number of pods. We have drastically improved this . So it can only be compared to other scores now. The score can now be tweaked in the PodSpec through maxSkew I would argue that option ~B~ A is better that simply doubling the weight because its signal is more conservative when it matters (nodes have high usage).\nI am not clear on the following: you say \"we could have undesirable consequences unless we carefully analyze the impact.\" but then you argue for the option at the end, can you clarify? We had default spreading that was giving similar strong signal, we should compare with that. My concern with modifying the is that we may break someone. Increasing the weight is something that users can revert, while option B can't be reverted.\nSorry, I meant option A, improve PodTopologySpread\nOne potential advantage to doubling the weight is that topology spread currently offers a signal comparable to default spreading, which we can think of as a baseline for spreading signal since it has been used for a while now. Doubling the weight will allow admins to revert back to the old behavior if they wish to do so. Also, from my perspective, doubling the weight is giving better placement at high utilization ( vs )", "positive_passages": [{"docid": "doc-en-kubernetes-bb65167780875d86ac887f82ef6660af7b4c0a90de48f937d8b7742028d7e77d", "text": "{Name: nodepreferavoidpods.Name, Weight: 10000}, {Name: defaultpodtopologyspread.Name, Weight: 1}, {Name: tainttoleration.Name, Weight: 1}, <del> {Name: podtopologyspread.Name, Weight: 1}, </del> <ins> {Name: podtopologyspread.Name, Weight: 2}, </ins> }, }, Reserve: &schedulerapi.PluginSet{", "commid": "kubernetes_pr_91258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-23453cfe9279d45b88b1b76bf59719d6724b15443ac3ffc3c4eacd0d07ffeb70", "query": "Problem: Preferred pod/node affinity and preferred PodTopologySpread may not be respected because of conflicts with other scoring functions, like node utilization or image locality. Scheduler Scoring functions have weights, by default they are all set to 1 (apart from one): Having equal weights is problematic because of the way we score: each Scoring plugin returns a score [0, MaxScore], which get multiplied by the configured weight of the plugin, and a node score is the sum over all scores. Therefore, even if the user explicitly indicates that they prefer to place pod x on node y, this preference may not be respected and the scheduler may decide to place the pod on node z because it has lower usage and the container that the pod is requesting. Proposed Solution: Scoring functions that allow users to explicitly express preference should have higher weights than generic scoring functions. This includes: inter-pod affinity, node affinity, taint/toleration and pod topology spread. This issue is proposing to change the default behavior of the scheduler, I am not sure how k8s deprecation policy applies here, although I would argue that this change should help the scheduler make decisions closer to users expectations. We will start with pod topology pod spread since as of creating this issue, the feature is still in beta. /sig scheduling\nQuote from the : Rule : Deprecated behaviors must function for no less than 1 year after their announced deprecation. I think the rule doesn't apply to this proposal since it is not impacting the correctness of applications or impact administration of the cluster.\nAs nodepreferavoidpods already exercised to set its weight to 1000 by default, it sounds fair to me to increase the default weight for inter-pod affinity, node affinity, taint/toleration and pod topology spread. BTW: to some extent, we can use e2e tests verifying the to-proposed default weight. Right now we have some e2e tests covering priorities (scoring), but they depend on to ensure cpu/mem are at the same ratio of usage: and hence IMO a bit fragile.\nStrongly agree with this change. But, IMO, we may need to reconsider the default impact weights of each scoring plugin. Maybe they should have more weight ladders, rather than simply 1 or 1000. For example, from practical experience, in most cases should not be set to the same weight as , , etc. (Yes, we need to consider this for users, because most users may not notice this change).\nIMO a reasonable criterion to guide which Score plugins should have non-default weight is: whether the Score plugin is associated with an API (e.g., PodTopologySpread Score plugin is associated with .\nIf we give a higher weight only to the API-facing scores, then workloads that don't use these features are not affected, which is a good thing. I think a good weight to give to these scores is one that avoids it to be diluted among the rest of the scores. So, maybe a weight that is half the sum of all non-API-facing scores. Now, if a user uses the API for more than one score, I think we can safely assume that they want equal weights for them.\n/cc Daniel, can you comment on whether or not the proposed change conforms with k8s deprecation policy?\nI hate to say it, but I think you have to make the new set of weights an option and use the deprecation process to move people over. It's quite difficult to predict what a change in these weights might do to the overall scheduling behavior, no? If it was already possible to specify the settings (via flag or config file), then maybe there's a case to be made that the deprecation process is heavier than needed here. To make that case, you'd need to test and be VERY sure that the new settings are actually an improvement. The change sounds like an improvement, but I'd like to see that quantified / tested somehow. Perhaps even more importantly, I'd like to know the conditions under which it makes things worse, and along which dimensions. can give a second opinion if you don't like this answer :)\nThis may have an impact on availability (since by default the scheduler will prefer less under utilized nodes) and pod startup (less preference to node that already has the image) IF the pod have explicit preference for being on a specific node or with a specific pod. Those weights are actually configurable via the component config file, but most cloud providers don't allow customers to provide a custom configuration, they just use the default. Regarding the change of behavior, this effectively create two level scoring: first level is by user-specified preferences (affinity), second level is by workload-agnostic ones (e.g., image existence). If users are not specifying preferences, then this change have no impact.\nThose are good points, but how many users specify preferences? Should we encourage those users to use non-optional constraints, instead? I can imagine arguing that making the preferences more likely to be obeyed makes it rarer and therefore more surprising and worse when they can't be honored.\nI'm not sure if I'm understanding this correctly. Examples of non-optional scores are \"topology spreading\", \"resources utilization\" and \"image locality\". Users (aka Pods) can not opt-in or opt-out from them. Cluster operators (on prem or cloud-providers) can opt-out or change weights, but for a whole cluster. Remember that we are talking about node scoring. The nodes to be scored should have already passed the filters. Let's take an API-facing score (node affinity) and non-API-facing score (image locality) for illustrating the effect of weights: Imagine a pod is using \"preferred\" node affinity and there are no nodes available that satisfy that affinity. That means that in this case all nodes would get a low (or zero) score for node affinity. In this case the score given by image locality will provide the difference in score between all nodes. Now, let's say some nodes satisfy the node affinity. Those nodes will have the same high score for node affinity. But they will defer in image locality, which will be (in this case) the determining factor to select a node. However, in real (default) clusters we have more than 2 scores. And the problem is that pod preferences end up being diluted with all the other default scores summed up. What the proposal would achieve is that we first honor pod preferences and then we differentiate among the resulting nodes using the default scores.\nOK, so I guess the case where this hurts users is: They specified preferences The preferences are actually bad (plot twist) they're diluted so much that they're not having much effect but now the scheduler starts honoring them more often But it's still probabilistic, so we can expect some percentage of the time, the preferences continue to not get honored? Numerically, suppose 50% have preferences, 2% of those got them wrong, 80% of those are currently diluted (i.e., not already broken), and 10% of those are in environments where they'll suddenly get honored 100% after this change (becoming broken). That's .5.02.8*.1 = .08% of users, or 1 out of 1250 users this change could break. That's still maybe a little high for my taste, but maybe you have an alternative estimate?\nI think we can tweak how many of the currently diluted cases become honored. In I proposed that we use a weight of half the sum of the non-API-facing weights. We can be less aggressive and do a quarter or just 2 (we currently put weight of 1 for all).\nOn another note, I would say weights are actually part of the component config API. In both v1alpha1 and the new v1alpha2 (), you can tweak the weights of individual scores. Users might be setting up these weights assuming that the defaults are 1. This is not a problem with the old Policy API, because you have to specify all the scores with their weights. So, if we decide to change the weights, better do so now for v1alpha2.\nDaniel, I don't expect that 50% of k8s workloads have preferred pod/node affinities, but I don't have data to suggest an alternative estimate. I guess we could make the change behind a feature flag that gets graduated over multiple releases.\nIt is permissible for the default to change over versions, in fact that's the way to do it for API types. Since the type is alpha, I guess it's OK to just do this. So, if the config file is v1alpha1, do the old defaults; if it's v1alpha2, use the new ones. How does that sound?\nsgtm. But the question of what's a good weight for api-facing scores still remains. By default we only have 4 non-api-facing scores: NodeResourcesBalancedAllocation ImageLocality NodeResourcesLeastAllocated DefaultPodTopologySpread So my two proposals are actually the same number: 2 :sweat:\nWhat about the case where a config file is not provided at all (which is very common across all cloud providers)? I guess we will have to keep the old defaults, and so we didn't actually solve the issue, right? it will also be confusing to users who pass a config file that doesn't change any of the weights.\nIf there's no config file at all, I think it's fair game, users can easily get the old behavior if needed. Others might disagree with me, but that's what I think. A completely separate thought: are you sure changing the weights is good? What about changing the way they're evaluated? E.g. in ML it's common to use e.g. a softmax function at the last layer to force a NN to make a choice / assign a consistent set of probabilities to each option. I think the way that might look here is instead of using F(N) as F's priority for node N, use exp(F(N)) / SUM (N0-Nn) { exp(F(N)) }. This would have the effect of magnifying minor preferences. Basically, I'm claiming that priority functions should be distributing the same amount of \"probability mass\" over the N possible nodes. It's not fair for one function to say \".3\" for everything while another says \".6\" for everything. You maybe need to normalize this before applying the weighting function anyway. But if you do the softmax, you might not even need the weight, as priority functions that give each node the same score will basically be no-ops, letting ones with differing opinions win.\nInteresting proposal, but don't you think weights will still be needed because unlike NN, the scheduler didn't go through a training phase to discover which features (in this case priority functions) provide the most important signal?\nLet's put an scenario with three simplified scores: selected: a score that prefers a particular set of nodes (maybe a particular zone). : existence of an image. : low utilization Now let's assume they give the following scores: Notice that they all have the same distribution (so they all give good signal). Even when using softmax the sum of scores (with the same weight for every score) will be: Nodes 1, 4 and 7 have the same score and thus the same probability to be chosen. I would argue that the user intention was that node 4 would be selected. It's still called a preference because if would give 0 to all nodes, then the pod can still go to the nodes, and the automatic scores take all the decision. Now, in the default scheduler, we have 4 automatic scores, so the user preference is quite unlikely to get respected. It's not necessarily a matter of good signal from the score.\nYup good points-- I agree a weight is still needed. If all the numbers are 0 or 1 (I had thought that it was a floating point and not a binary signal) then I don't think softmax is going to be different than a linear normalization (?). I guess it's debatable whether one wants a priority function that selects fewer nodes to have its opinion on those nodes be weighted more highly, which is what normalization would do. Anyway sorry if this is a rabbit hole. :) I think this idea would make more sense if the priority functions could express a strength for their preference and not just yes/no.\nIt's not binary necessarily... I was over simplifying. Node affinity and image locality certainly are, but node utilization is not.\nIt might be worth some experiments, then... if you have some way of telling whether or not it's actually better? Aldo Culquicondor <:\nWe have an HA use case that involves spreading pods across nodes and zone with preferred scheduling since we'd rather schedule the pods than not. Before 1.18, we've been using the something like the following: Now with the 1.18 beta, we tried the following: The later yields better scheduling results than the former on a 9 nodes multi-zone cluster with 3 nodes in each node. So while was better it surprisingly didn't yield a perfect spread. So I decided to combine both and ... boom ... we had a perfect pod spread for our deployment with 9 replicas. I'm not sure how these results fit into the discussions so far but I would have expected either option by itself to yield a better spread. Combining the two lets me reinforce my desires to the scheduler. IMO, I would like to see the scheduler give my explicit request more weight.\nthanks a lot for sharing. Giving more weight to explicit requests is what we are proposing. However, I'm a little surprised that you need these constraints. The scheduler already spreads by default when using services, replica set or stateful sets. Are these pods not members of any of those? I assume you are not modifying the scheduler configuration? But, of course, there are other scores in play. It makes sense that spreading constraints are more effective than antiaffinity, because there is a lot of antiaffinity with the node that is ultimately selected as well. Adding both specs works too. However, this increases scheduling latency, as we have to calculate more things. The main motivation for this issue was actually to make scoring more effective for the opposite case, which is not done by default: \"packing\". But your use case is just as valid.\nThese pods are part of a deployment. I tried without any scheduling preferences and the results are similar to podAntiAffinity preferred scheduling. Here is the baseline deployment yaml used for the tests: I have not modified the scheduler configuration.\nYes, deployments are affected because they create a replica set that owns the pods. But there are always other scores at play that might also be important, which is why a \"preferred\" spreading is never going to be perfect. This is kind of the point that was trying to make: guarding users from over-fitting and degrading the clusters in some way.\nWhat if we reduce the scope to just PodTopologySpreading, which is beta since 1.18? We could give it a weight of 2 now, before going to GA.\nAldo, one thing to take into account is the new default spread logic which is based on default pod topology spread constraints. For default spread constraints, I think the weight shouldn't increase, so things will get a little complicated with how we treat this case.\nGiven that default spread constraints is explicitly specified by users in , maybe we can assume they are already aware of adjusting the \"Weight\" in ? While for regular users, they won't touch , so a default non-1 weight is a no-op for them.\nthe default constraints (which we plan to introduce to replace the current defaultpodspreading score plugin) are not explicitly specified in PluginConfig.\nMaybe I missed something, are we talking about the same default constraints defined here?\nyes we are, but isn't the plan to have a default value for DefaultConstraints when not set: two constraints, one for zone and one for hostname, which mimic the current defaultpodspread behaviour and allows us to deprecate it?\nI think the only way around that is to introduce a weight for default constraints in the plugin config. And then set it to 50% for the k8s default.\nhmm, this will be a confusing configuration parameter to users. Another approach to consider is to bake it into the TopologySpread plugin instantiation without needing to pass it through PluginConfig (similar to what we did for volumebinder in the past: ).\nurgh, this will be tricky to do since defaulting will be done via component config, and so we don't have a way to communicate whether the values were defaults or explicitly set by the user. If defaulting is done in then it might be possible, but we shouldn't do that.\nDefaulting is going to happen in in the near future\nWe can have it in the internal type, but not the external one then. This will hide it from the users. But how do we communicate that to conversion logic?!\nIt doesn't seem there is a way because defaulting happens before conversion...\nTo make the new parameter semantically clear, we can treat it as a weight override rather than a percentage of the plugin weight, and so it's default would be 1 rather than 50%, internally the plugin computes the ratio as the override weight divided by the plugin weight, which it uses to scale scores computed for pods that don't have topology spread specified in their spec.\nGot it now. I thought the default constraints would default to nil if not specified by users. I think we should introduce a field called \"multiplexer\" and default to 1, so it's friendly to defaulting and conversion.\n+1.\nWhat if we start giving meaning to MaxSkew for scoring? If you set a low MaxSkew, you probably want it to have a higher effect than if you set a bigger value. We can discuss the exact formula, but I think adding these semantics make sense. On Sat., Apr. 18, 2020, 5:50 p.m. Wei Huang, <:\nThat's possible. Current Score function doesn't take into consideration - it's just following a simple \"the less number of matching Pods a topology has, the higher score the Nodes on that topology are given\" principle.\nNote that if we add another parameter to the args, it would only be relevant for scoring, adding to the confusion.\n: This score calculation is somewhat complicated, but can be resumed as: Calculate number of matching pods per topology. There is some new feature that takes in consideration the skew Normalize by . The effect is that pods with the lowest count get a score of . Then the rest of the scores go from a certain number to . A score is given to a node with when is . This formula has the effect of reducing differentiation among nodes as the increases. : The formula is very simple, the score is equal to the percentage of free space (averaged for cpu and memory). Each score on their own give the differentiation we want, but they kind of have different scales. As a result tends to be stronger. I'm using a 9 nodes (3 in each zone) cluster as an example. I've set different initial loads, and in all cases I simulate a Deployment of 30 pods (each assumed to take 1% of node resources). Here are the scenarios, where numbers are percentage of use: For equal score weights (current configuration), this is the distribution of new pods: for both nodes and zones Note how a node with only 40% utilization gets only 1 or 0 pods. For double score weights for both nodes and zones Only at 80% utilization we observe bigger skews, which is reasonable. But the spreading is still pretty good at 40% For planned default spreading See , but this might change, depending on feedback here. I think this is enough justification to increase the weight of to 2 in its 2nd beta release.\nSounds reasonable. It's mathematically equivalent to changing the formula to e.g. , right? Have you considered doing that instead of changing the weight? It seems like that'd help everyone except those who specifically already increased , instead of just people who are using the defaults?\nIt'd make sense to me if the available functions were in the same scale / units so that they'd compose better, but it's not obvious how to do that--what would the units be? One thought is to make the units \"std deviations from the mean\"--if we knew the output frequency of each function, we could maybe do that. So basically this would measure how unusual a preference is, I guess. (I don't think this is an actionable thought. It really bugs me that the outputs of these functions are combined when they are not really in the same units, though!)\nYes 100 is the maximum score we have defined any plugins to have. I'm not convinced this would work. The variance in my examples for initial resource usage is quite high. So it would still get a lot of importance. But, you have triggered me to start thinking about the linearity of the scores. The formula is good because it reduce the variance as increases. However, that reduction is too aggressive. On the other hand, is completely linear. I'll experiment changing the linearity of either function, but preferring to do so for the beta plugin.\nHere go 2 alternatives, with the same situations as We either solution, we wouldn't need to modify the weights Although we are not getting as good spreading as simply doubling the weight. But this is only in the last scenario, where we have usages of 80%. So I would call this rather a win (we should be paying greater attention to resource usage at this point). I think option B is simpler to understand and gives slightly better results (only noticeable in the last case). So this would be my algorithmic preference. However, I'm fine with option A.\nYeah, that's a great idea. You can generalize that and give each function a both a linear weight and a \"gamma\" (name from image processing): or even go for (but in this case I'm in favor of just making a targeted fix to that one function)\nAwesome, Any concerns against option B? Given that it's an older feature.\nhow would option B impact node ranking in the absence of spreading? would image size scores start to have bigger impact?\nI think SIG Scheduling should probably have a discussion. I could go either way, my naive inclination is to just go for the change, but I'm sure it'll break someone. We probably need a way to get back the old behavior, or a suggested weight change that would approximate it (not clear how well that could do though). I also have question, which is how well does this new value compose with other functions? I feel like the proper answer looks like an evaluation criteria + {long list of scenarios} + {list of workloads to schedule} + randomized testing / benchmarking. Basically the multi-dimensional version of the analysis here. That sounds like a lot of work but it would permit actual optimization of these functions.\nconfigurable gamma is an obvious way... :/\nI don't think we want another config parameter, we already have the weight concept and it is configurable, so I think we should go with that, just double the spreading score weight by default, and users who don't favor this behavior can configure it back to 1.\nYeah, that sounds expedient. ahg-g <:\nIn short, yes. Although that score has a mechanism to avoid the \"node heating problem\" we could have undesirable consequences unless we carefully analyze the impact. But that same reasoning doesn't apply to option A (improving PodTopologySpreading), for the following reasons: The score in 1.18 had pretty weak signal, that was only useful with very small number of pods. We have drastically improved this . So it can only be compared to other scores now. The score can now be tweaked in the PodSpec through maxSkew I would argue that option ~B~ A is better that simply doubling the weight because its signal is more conservative when it matters (nodes have high usage).\nI am not clear on the following: you say \"we could have undesirable consequences unless we carefully analyze the impact.\" but then you argue for the option at the end, can you clarify? We had default spreading that was giving similar strong signal, we should compare with that. My concern with modifying the is that we may break someone. Increasing the weight is something that users can revert, while option B can't be reverted.\nSorry, I meant option A, improve PodTopologySpread\nOne potential advantage to doubling the weight is that topology spread currently offers a signal comparable to default spreading, which we can think of as a baseline for spreading signal since it has been used for a while now. Doubling the weight will allow admins to revert back to the old behavior if they wish to do so. Also, from my perspective, doubling the weight is giving better placement at high utilization ( vs )", "positive_passages": [{"docid": "doc-en-kubernetes-e923f9c6f85410a6562057b52b8d118063afec3e05b84bebce02356d9516e084", "text": "{Name: nodepreferavoidpods.Name, Weight: 10000}, {Name: defaultpodtopologyspread.Name, Weight: 1}, {Name: tainttoleration.Name, Weight: 1}, <del> {Name: podtopologyspread.Name, Weight: 1}, </del> <ins> {Name: podtopologyspread.Name, Weight: 2}, </ins> {Name: noderesources.ResourceLimitsName, Weight: 1}, }, },", "commid": "kubernetes_pr_91258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-23453cfe9279d45b88b1b76bf59719d6724b15443ac3ffc3c4eacd0d07ffeb70", "query": "Problem: Preferred pod/node affinity and preferred PodTopologySpread may not be respected because of conflicts with other scoring functions, like node utilization or image locality. Scheduler Scoring functions have weights, by default they are all set to 1 (apart from one): Having equal weights is problematic because of the way we score: each Scoring plugin returns a score [0, MaxScore], which get multiplied by the configured weight of the plugin, and a node score is the sum over all scores. Therefore, even if the user explicitly indicates that they prefer to place pod x on node y, this preference may not be respected and the scheduler may decide to place the pod on node z because it has lower usage and the container that the pod is requesting. Proposed Solution: Scoring functions that allow users to explicitly express preference should have higher weights than generic scoring functions. This includes: inter-pod affinity, node affinity, taint/toleration and pod topology spread. This issue is proposing to change the default behavior of the scheduler, I am not sure how k8s deprecation policy applies here, although I would argue that this change should help the scheduler make decisions closer to users expectations. We will start with pod topology pod spread since as of creating this issue, the feature is still in beta. /sig scheduling\nQuote from the : Rule : Deprecated behaviors must function for no less than 1 year after their announced deprecation. I think the rule doesn't apply to this proposal since it is not impacting the correctness of applications or impact administration of the cluster.\nAs nodepreferavoidpods already exercised to set its weight to 1000 by default, it sounds fair to me to increase the default weight for inter-pod affinity, node affinity, taint/toleration and pod topology spread. BTW: to some extent, we can use e2e tests verifying the to-proposed default weight. Right now we have some e2e tests covering priorities (scoring), but they depend on to ensure cpu/mem are at the same ratio of usage: and hence IMO a bit fragile.\nStrongly agree with this change. But, IMO, we may need to reconsider the default impact weights of each scoring plugin. Maybe they should have more weight ladders, rather than simply 1 or 1000. For example, from practical experience, in most cases should not be set to the same weight as , , etc. (Yes, we need to consider this for users, because most users may not notice this change).\nIMO a reasonable criterion to guide which Score plugins should have non-default weight is: whether the Score plugin is associated with an API (e.g., PodTopologySpread Score plugin is associated with .\nIf we give a higher weight only to the API-facing scores, then workloads that don't use these features are not affected, which is a good thing. I think a good weight to give to these scores is one that avoids it to be diluted among the rest of the scores. So, maybe a weight that is half the sum of all non-API-facing scores. Now, if a user uses the API for more than one score, I think we can safely assume that they want equal weights for them.\n/cc Daniel, can you comment on whether or not the proposed change conforms with k8s deprecation policy?\nI hate to say it, but I think you have to make the new set of weights an option and use the deprecation process to move people over. It's quite difficult to predict what a change in these weights might do to the overall scheduling behavior, no? If it was already possible to specify the settings (via flag or config file), then maybe there's a case to be made that the deprecation process is heavier than needed here. To make that case, you'd need to test and be VERY sure that the new settings are actually an improvement. The change sounds like an improvement, but I'd like to see that quantified / tested somehow. Perhaps even more importantly, I'd like to know the conditions under which it makes things worse, and along which dimensions. can give a second opinion if you don't like this answer :)\nThis may have an impact on availability (since by default the scheduler will prefer less under utilized nodes) and pod startup (less preference to node that already has the image) IF the pod have explicit preference for being on a specific node or with a specific pod. Those weights are actually configurable via the component config file, but most cloud providers don't allow customers to provide a custom configuration, they just use the default. Regarding the change of behavior, this effectively create two level scoring: first level is by user-specified preferences (affinity), second level is by workload-agnostic ones (e.g., image existence). If users are not specifying preferences, then this change have no impact.\nThose are good points, but how many users specify preferences? Should we encourage those users to use non-optional constraints, instead? I can imagine arguing that making the preferences more likely to be obeyed makes it rarer and therefore more surprising and worse when they can't be honored.\nI'm not sure if I'm understanding this correctly. Examples of non-optional scores are \"topology spreading\", \"resources utilization\" and \"image locality\". Users (aka Pods) can not opt-in or opt-out from them. Cluster operators (on prem or cloud-providers) can opt-out or change weights, but for a whole cluster. Remember that we are talking about node scoring. The nodes to be scored should have already passed the filters. Let's take an API-facing score (node affinity) and non-API-facing score (image locality) for illustrating the effect of weights: Imagine a pod is using \"preferred\" node affinity and there are no nodes available that satisfy that affinity. That means that in this case all nodes would get a low (or zero) score for node affinity. In this case the score given by image locality will provide the difference in score between all nodes. Now, let's say some nodes satisfy the node affinity. Those nodes will have the same high score for node affinity. But they will defer in image locality, which will be (in this case) the determining factor to select a node. However, in real (default) clusters we have more than 2 scores. And the problem is that pod preferences end up being diluted with all the other default scores summed up. What the proposal would achieve is that we first honor pod preferences and then we differentiate among the resulting nodes using the default scores.\nOK, so I guess the case where this hurts users is: They specified preferences The preferences are actually bad (plot twist) they're diluted so much that they're not having much effect but now the scheduler starts honoring them more often But it's still probabilistic, so we can expect some percentage of the time, the preferences continue to not get honored? Numerically, suppose 50% have preferences, 2% of those got them wrong, 80% of those are currently diluted (i.e., not already broken), and 10% of those are in environments where they'll suddenly get honored 100% after this change (becoming broken). That's .5.02.8*.1 = .08% of users, or 1 out of 1250 users this change could break. That's still maybe a little high for my taste, but maybe you have an alternative estimate?\nI think we can tweak how many of the currently diluted cases become honored. In I proposed that we use a weight of half the sum of the non-API-facing weights. We can be less aggressive and do a quarter or just 2 (we currently put weight of 1 for all).\nOn another note, I would say weights are actually part of the component config API. In both v1alpha1 and the new v1alpha2 (), you can tweak the weights of individual scores. Users might be setting up these weights assuming that the defaults are 1. This is not a problem with the old Policy API, because you have to specify all the scores with their weights. So, if we decide to change the weights, better do so now for v1alpha2.\nDaniel, I don't expect that 50% of k8s workloads have preferred pod/node affinities, but I don't have data to suggest an alternative estimate. I guess we could make the change behind a feature flag that gets graduated over multiple releases.\nIt is permissible for the default to change over versions, in fact that's the way to do it for API types. Since the type is alpha, I guess it's OK to just do this. So, if the config file is v1alpha1, do the old defaults; if it's v1alpha2, use the new ones. How does that sound?\nsgtm. But the question of what's a good weight for api-facing scores still remains. By default we only have 4 non-api-facing scores: NodeResourcesBalancedAllocation ImageLocality NodeResourcesLeastAllocated DefaultPodTopologySpread So my two proposals are actually the same number: 2 :sweat:\nWhat about the case where a config file is not provided at all (which is very common across all cloud providers)? I guess we will have to keep the old defaults, and so we didn't actually solve the issue, right? it will also be confusing to users who pass a config file that doesn't change any of the weights.\nIf there's no config file at all, I think it's fair game, users can easily get the old behavior if needed. Others might disagree with me, but that's what I think. A completely separate thought: are you sure changing the weights is good? What about changing the way they're evaluated? E.g. in ML it's common to use e.g. a softmax function at the last layer to force a NN to make a choice / assign a consistent set of probabilities to each option. I think the way that might look here is instead of using F(N) as F's priority for node N, use exp(F(N)) / SUM (N0-Nn) { exp(F(N)) }. This would have the effect of magnifying minor preferences. Basically, I'm claiming that priority functions should be distributing the same amount of \"probability mass\" over the N possible nodes. It's not fair for one function to say \".3\" for everything while another says \".6\" for everything. You maybe need to normalize this before applying the weighting function anyway. But if you do the softmax, you might not even need the weight, as priority functions that give each node the same score will basically be no-ops, letting ones with differing opinions win.\nInteresting proposal, but don't you think weights will still be needed because unlike NN, the scheduler didn't go through a training phase to discover which features (in this case priority functions) provide the most important signal?\nLet's put an scenario with three simplified scores: selected: a score that prefers a particular set of nodes (maybe a particular zone). : existence of an image. : low utilization Now let's assume they give the following scores: Notice that they all have the same distribution (so they all give good signal). Even when using softmax the sum of scores (with the same weight for every score) will be: Nodes 1, 4 and 7 have the same score and thus the same probability to be chosen. I would argue that the user intention was that node 4 would be selected. It's still called a preference because if would give 0 to all nodes, then the pod can still go to the nodes, and the automatic scores take all the decision. Now, in the default scheduler, we have 4 automatic scores, so the user preference is quite unlikely to get respected. It's not necessarily a matter of good signal from the score.\nYup good points-- I agree a weight is still needed. If all the numbers are 0 or 1 (I had thought that it was a floating point and not a binary signal) then I don't think softmax is going to be different than a linear normalization (?). I guess it's debatable whether one wants a priority function that selects fewer nodes to have its opinion on those nodes be weighted more highly, which is what normalization would do. Anyway sorry if this is a rabbit hole. :) I think this idea would make more sense if the priority functions could express a strength for their preference and not just yes/no.\nIt's not binary necessarily... I was over simplifying. Node affinity and image locality certainly are, but node utilization is not.\nIt might be worth some experiments, then... if you have some way of telling whether or not it's actually better? Aldo Culquicondor <:\nWe have an HA use case that involves spreading pods across nodes and zone with preferred scheduling since we'd rather schedule the pods than not. Before 1.18, we've been using the something like the following: Now with the 1.18 beta, we tried the following: The later yields better scheduling results than the former on a 9 nodes multi-zone cluster with 3 nodes in each node. So while was better it surprisingly didn't yield a perfect spread. So I decided to combine both and ... boom ... we had a perfect pod spread for our deployment with 9 replicas. I'm not sure how these results fit into the discussions so far but I would have expected either option by itself to yield a better spread. Combining the two lets me reinforce my desires to the scheduler. IMO, I would like to see the scheduler give my explicit request more weight.\nthanks a lot for sharing. Giving more weight to explicit requests is what we are proposing. However, I'm a little surprised that you need these constraints. The scheduler already spreads by default when using services, replica set or stateful sets. Are these pods not members of any of those? I assume you are not modifying the scheduler configuration? But, of course, there are other scores in play. It makes sense that spreading constraints are more effective than antiaffinity, because there is a lot of antiaffinity with the node that is ultimately selected as well. Adding both specs works too. However, this increases scheduling latency, as we have to calculate more things. The main motivation for this issue was actually to make scoring more effective for the opposite case, which is not done by default: \"packing\". But your use case is just as valid.\nThese pods are part of a deployment. I tried without any scheduling preferences and the results are similar to podAntiAffinity preferred scheduling. Here is the baseline deployment yaml used for the tests: I have not modified the scheduler configuration.\nYes, deployments are affected because they create a replica set that owns the pods. But there are always other scores at play that might also be important, which is why a \"preferred\" spreading is never going to be perfect. This is kind of the point that was trying to make: guarding users from over-fitting and degrading the clusters in some way.\nWhat if we reduce the scope to just PodTopologySpreading, which is beta since 1.18? We could give it a weight of 2 now, before going to GA.\nAldo, one thing to take into account is the new default spread logic which is based on default pod topology spread constraints. For default spread constraints, I think the weight shouldn't increase, so things will get a little complicated with how we treat this case.\nGiven that default spread constraints is explicitly specified by users in , maybe we can assume they are already aware of adjusting the \"Weight\" in ? While for regular users, they won't touch , so a default non-1 weight is a no-op for them.\nthe default constraints (which we plan to introduce to replace the current defaultpodspreading score plugin) are not explicitly specified in PluginConfig.\nMaybe I missed something, are we talking about the same default constraints defined here?\nyes we are, but isn't the plan to have a default value for DefaultConstraints when not set: two constraints, one for zone and one for hostname, which mimic the current defaultpodspread behaviour and allows us to deprecate it?\nI think the only way around that is to introduce a weight for default constraints in the plugin config. And then set it to 50% for the k8s default.\nhmm, this will be a confusing configuration parameter to users. Another approach to consider is to bake it into the TopologySpread plugin instantiation without needing to pass it through PluginConfig (similar to what we did for volumebinder in the past: ).\nurgh, this will be tricky to do since defaulting will be done via component config, and so we don't have a way to communicate whether the values were defaults or explicitly set by the user. If defaulting is done in then it might be possible, but we shouldn't do that.\nDefaulting is going to happen in in the near future\nWe can have it in the internal type, but not the external one then. This will hide it from the users. But how do we communicate that to conversion logic?!\nIt doesn't seem there is a way because defaulting happens before conversion...\nTo make the new parameter semantically clear, we can treat it as a weight override rather than a percentage of the plugin weight, and so it's default would be 1 rather than 50%, internally the plugin computes the ratio as the override weight divided by the plugin weight, which it uses to scale scores computed for pods that don't have topology spread specified in their spec.\nGot it now. I thought the default constraints would default to nil if not specified by users. I think we should introduce a field called \"multiplexer\" and default to 1, so it's friendly to defaulting and conversion.\n+1.\nWhat if we start giving meaning to MaxSkew for scoring? If you set a low MaxSkew, you probably want it to have a higher effect than if you set a bigger value. We can discuss the exact formula, but I think adding these semantics make sense. On Sat., Apr. 18, 2020, 5:50 p.m. Wei Huang, <:\nThat's possible. Current Score function doesn't take into consideration - it's just following a simple \"the less number of matching Pods a topology has, the higher score the Nodes on that topology are given\" principle.\nNote that if we add another parameter to the args, it would only be relevant for scoring, adding to the confusion.\n: This score calculation is somewhat complicated, but can be resumed as: Calculate number of matching pods per topology. There is some new feature that takes in consideration the skew Normalize by . The effect is that pods with the lowest count get a score of . Then the rest of the scores go from a certain number to . A score is given to a node with when is . This formula has the effect of reducing differentiation among nodes as the increases. : The formula is very simple, the score is equal to the percentage of free space (averaged for cpu and memory). Each score on their own give the differentiation we want, but they kind of have different scales. As a result tends to be stronger. I'm using a 9 nodes (3 in each zone) cluster as an example. I've set different initial loads, and in all cases I simulate a Deployment of 30 pods (each assumed to take 1% of node resources). Here are the scenarios, where numbers are percentage of use: For equal score weights (current configuration), this is the distribution of new pods: for both nodes and zones Note how a node with only 40% utilization gets only 1 or 0 pods. For double score weights for both nodes and zones Only at 80% utilization we observe bigger skews, which is reasonable. But the spreading is still pretty good at 40% For planned default spreading See , but this might change, depending on feedback here. I think this is enough justification to increase the weight of to 2 in its 2nd beta release.\nSounds reasonable. It's mathematically equivalent to changing the formula to e.g. , right? Have you considered doing that instead of changing the weight? It seems like that'd help everyone except those who specifically already increased , instead of just people who are using the defaults?\nIt'd make sense to me if the available functions were in the same scale / units so that they'd compose better, but it's not obvious how to do that--what would the units be? One thought is to make the units \"std deviations from the mean\"--if we knew the output frequency of each function, we could maybe do that. So basically this would measure how unusual a preference is, I guess. (I don't think this is an actionable thought. It really bugs me that the outputs of these functions are combined when they are not really in the same units, though!)\nYes 100 is the maximum score we have defined any plugins to have. I'm not convinced this would work. The variance in my examples for initial resource usage is quite high. So it would still get a lot of importance. But, you have triggered me to start thinking about the linearity of the scores. The formula is good because it reduce the variance as increases. However, that reduction is too aggressive. On the other hand, is completely linear. I'll experiment changing the linearity of either function, but preferring to do so for the beta plugin.\nHere go 2 alternatives, with the same situations as We either solution, we wouldn't need to modify the weights Although we are not getting as good spreading as simply doubling the weight. But this is only in the last scenario, where we have usages of 80%. So I would call this rather a win (we should be paying greater attention to resource usage at this point). I think option B is simpler to understand and gives slightly better results (only noticeable in the last case). So this would be my algorithmic preference. However, I'm fine with option A.\nYeah, that's a great idea. You can generalize that and give each function a both a linear weight and a \"gamma\" (name from image processing): or even go for (but in this case I'm in favor of just making a targeted fix to that one function)\nAwesome, Any concerns against option B? Given that it's an older feature.\nhow would option B impact node ranking in the absence of spreading? would image size scores start to have bigger impact?\nI think SIG Scheduling should probably have a discussion. I could go either way, my naive inclination is to just go for the change, but I'm sure it'll break someone. We probably need a way to get back the old behavior, or a suggested weight change that would approximate it (not clear how well that could do though). I also have question, which is how well does this new value compose with other functions? I feel like the proper answer looks like an evaluation criteria + {long list of scenarios} + {list of workloads to schedule} + randomized testing / benchmarking. Basically the multi-dimensional version of the analysis here. That sounds like a lot of work but it would permit actual optimization of these functions.\nconfigurable gamma is an obvious way... :/\nI don't think we want another config parameter, we already have the weight concept and it is configurable, so I think we should go with that, just double the spreading score weight by default, and users who don't favor this behavior can configure it back to 1.\nYeah, that sounds expedient. ahg-g <:\nIn short, yes. Although that score has a mechanism to avoid the \"node heating problem\" we could have undesirable consequences unless we carefully analyze the impact. But that same reasoning doesn't apply to option A (improving PodTopologySpreading), for the following reasons: The score in 1.18 had pretty weak signal, that was only useful with very small number of pods. We have drastically improved this . So it can only be compared to other scores now. The score can now be tweaked in the PodSpec through maxSkew I would argue that option ~B~ A is better that simply doubling the weight because its signal is more conservative when it matters (nodes have high usage).\nI am not clear on the following: you say \"we could have undesirable consequences unless we carefully analyze the impact.\" but then you argue for the option at the end, can you clarify? We had default spreading that was giving similar strong signal, we should compare with that. My concern with modifying the is that we may break someone. Increasing the weight is something that users can revert, while option B can't be reverted.\nSorry, I meant option A, improve PodTopologySpread\nOne potential advantage to doubling the weight is that topology spread currently offers a signal comparable to default spreading, which we can think of as a baseline for spreading signal since it has been used for a while now. Doubling the weight will allow admins to revert back to the old behavior if they wish to do so. Also, from my perspective, doubling the weight is giving better placement at high utilization ( vs )", "positive_passages": [{"docid": "doc-en-kubernetes-deca14d0110197a7dc51927c0610c692ca00203c9ff0e0cac8cb42691c027d21", "text": "{Name: \"NodePreferAvoidPods\", Weight: 10000}, {Name: \"DefaultPodTopologySpread\", Weight: 1}, {Name: \"TaintToleration\", Weight: 1}, <del> {Name: \"PodTopologySpread\", Weight: 1}, </del> <ins> {Name: \"PodTopologySpread\", Weight: 2}, </ins> }, \"BindPlugin\":      {{Name: \"DefaultBinder\"}}, \"ReservePlugin\":   {{Name: \"VolumeBinding\"}},", "commid": "kubernetes_pr_91258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-23453cfe9279d45b88b1b76bf59719d6724b15443ac3ffc3c4eacd0d07ffeb70", "query": "Problem: Preferred pod/node affinity and preferred PodTopologySpread may not be respected because of conflicts with other scoring functions, like node utilization or image locality. Scheduler Scoring functions have weights, by default they are all set to 1 (apart from one): Having equal weights is problematic because of the way we score: each Scoring plugin returns a score [0, MaxScore], which get multiplied by the configured weight of the plugin, and a node score is the sum over all scores. Therefore, even if the user explicitly indicates that they prefer to place pod x on node y, this preference may not be respected and the scheduler may decide to place the pod on node z because it has lower usage and the container that the pod is requesting. Proposed Solution: Scoring functions that allow users to explicitly express preference should have higher weights than generic scoring functions. This includes: inter-pod affinity, node affinity, taint/toleration and pod topology spread. This issue is proposing to change the default behavior of the scheduler, I am not sure how k8s deprecation policy applies here, although I would argue that this change should help the scheduler make decisions closer to users expectations. We will start with pod topology pod spread since as of creating this issue, the feature is still in beta. /sig scheduling\nQuote from the : Rule : Deprecated behaviors must function for no less than 1 year after their announced deprecation. I think the rule doesn't apply to this proposal since it is not impacting the correctness of applications or impact administration of the cluster.\nAs nodepreferavoidpods already exercised to set its weight to 1000 by default, it sounds fair to me to increase the default weight for inter-pod affinity, node affinity, taint/toleration and pod topology spread. BTW: to some extent, we can use e2e tests verifying the to-proposed default weight. Right now we have some e2e tests covering priorities (scoring), but they depend on to ensure cpu/mem are at the same ratio of usage: and hence IMO a bit fragile.\nStrongly agree with this change. But, IMO, we may need to reconsider the default impact weights of each scoring plugin. Maybe they should have more weight ladders, rather than simply 1 or 1000. For example, from practical experience, in most cases should not be set to the same weight as , , etc. (Yes, we need to consider this for users, because most users may not notice this change).\nIMO a reasonable criterion to guide which Score plugins should have non-default weight is: whether the Score plugin is associated with an API (e.g., PodTopologySpread Score plugin is associated with .\nIf we give a higher weight only to the API-facing scores, then workloads that don't use these features are not affected, which is a good thing. I think a good weight to give to these scores is one that avoids it to be diluted among the rest of the scores. So, maybe a weight that is half the sum of all non-API-facing scores. Now, if a user uses the API for more than one score, I think we can safely assume that they want equal weights for them.\n/cc Daniel, can you comment on whether or not the proposed change conforms with k8s deprecation policy?\nI hate to say it, but I think you have to make the new set of weights an option and use the deprecation process to move people over. It's quite difficult to predict what a change in these weights might do to the overall scheduling behavior, no? If it was already possible to specify the settings (via flag or config file), then maybe there's a case to be made that the deprecation process is heavier than needed here. To make that case, you'd need to test and be VERY sure that the new settings are actually an improvement. The change sounds like an improvement, but I'd like to see that quantified / tested somehow. Perhaps even more importantly, I'd like to know the conditions under which it makes things worse, and along which dimensions. can give a second opinion if you don't like this answer :)\nThis may have an impact on availability (since by default the scheduler will prefer less under utilized nodes) and pod startup (less preference to node that already has the image) IF the pod have explicit preference for being on a specific node or with a specific pod. Those weights are actually configurable via the component config file, but most cloud providers don't allow customers to provide a custom configuration, they just use the default. Regarding the change of behavior, this effectively create two level scoring: first level is by user-specified preferences (affinity), second level is by workload-agnostic ones (e.g., image existence). If users are not specifying preferences, then this change have no impact.\nThose are good points, but how many users specify preferences? Should we encourage those users to use non-optional constraints, instead? I can imagine arguing that making the preferences more likely to be obeyed makes it rarer and therefore more surprising and worse when they can't be honored.\nI'm not sure if I'm understanding this correctly. Examples of non-optional scores are \"topology spreading\", \"resources utilization\" and \"image locality\". Users (aka Pods) can not opt-in or opt-out from them. Cluster operators (on prem or cloud-providers) can opt-out or change weights, but for a whole cluster. Remember that we are talking about node scoring. The nodes to be scored should have already passed the filters. Let's take an API-facing score (node affinity) and non-API-facing score (image locality) for illustrating the effect of weights: Imagine a pod is using \"preferred\" node affinity and there are no nodes available that satisfy that affinity. That means that in this case all nodes would get a low (or zero) score for node affinity. In this case the score given by image locality will provide the difference in score between all nodes. Now, let's say some nodes satisfy the node affinity. Those nodes will have the same high score for node affinity. But they will defer in image locality, which will be (in this case) the determining factor to select a node. However, in real (default) clusters we have more than 2 scores. And the problem is that pod preferences end up being diluted with all the other default scores summed up. What the proposal would achieve is that we first honor pod preferences and then we differentiate among the resulting nodes using the default scores.\nOK, so I guess the case where this hurts users is: They specified preferences The preferences are actually bad (plot twist) they're diluted so much that they're not having much effect but now the scheduler starts honoring them more often But it's still probabilistic, so we can expect some percentage of the time, the preferences continue to not get honored? Numerically, suppose 50% have preferences, 2% of those got them wrong, 80% of those are currently diluted (i.e., not already broken), and 10% of those are in environments where they'll suddenly get honored 100% after this change (becoming broken). That's .5.02.8*.1 = .08% of users, or 1 out of 1250 users this change could break. That's still maybe a little high for my taste, but maybe you have an alternative estimate?\nI think we can tweak how many of the currently diluted cases become honored. In I proposed that we use a weight of half the sum of the non-API-facing weights. We can be less aggressive and do a quarter or just 2 (we currently put weight of 1 for all).\nOn another note, I would say weights are actually part of the component config API. In both v1alpha1 and the new v1alpha2 (), you can tweak the weights of individual scores. Users might be setting up these weights assuming that the defaults are 1. This is not a problem with the old Policy API, because you have to specify all the scores with their weights. So, if we decide to change the weights, better do so now for v1alpha2.\nDaniel, I don't expect that 50% of k8s workloads have preferred pod/node affinities, but I don't have data to suggest an alternative estimate. I guess we could make the change behind a feature flag that gets graduated over multiple releases.\nIt is permissible for the default to change over versions, in fact that's the way to do it for API types. Since the type is alpha, I guess it's OK to just do this. So, if the config file is v1alpha1, do the old defaults; if it's v1alpha2, use the new ones. How does that sound?\nsgtm. But the question of what's a good weight for api-facing scores still remains. By default we only have 4 non-api-facing scores: NodeResourcesBalancedAllocation ImageLocality NodeResourcesLeastAllocated DefaultPodTopologySpread So my two proposals are actually the same number: 2 :sweat:\nWhat about the case where a config file is not provided at all (which is very common across all cloud providers)? I guess we will have to keep the old defaults, and so we didn't actually solve the issue, right? it will also be confusing to users who pass a config file that doesn't change any of the weights.\nIf there's no config file at all, I think it's fair game, users can easily get the old behavior if needed. Others might disagree with me, but that's what I think. A completely separate thought: are you sure changing the weights is good? What about changing the way they're evaluated? E.g. in ML it's common to use e.g. a softmax function at the last layer to force a NN to make a choice / assign a consistent set of probabilities to each option. I think the way that might look here is instead of using F(N) as F's priority for node N, use exp(F(N)) / SUM (N0-Nn) { exp(F(N)) }. This would have the effect of magnifying minor preferences. Basically, I'm claiming that priority functions should be distributing the same amount of \"probability mass\" over the N possible nodes. It's not fair for one function to say \".3\" for everything while another says \".6\" for everything. You maybe need to normalize this before applying the weighting function anyway. But if you do the softmax, you might not even need the weight, as priority functions that give each node the same score will basically be no-ops, letting ones with differing opinions win.\nInteresting proposal, but don't you think weights will still be needed because unlike NN, the scheduler didn't go through a training phase to discover which features (in this case priority functions) provide the most important signal?\nLet's put an scenario with three simplified scores: selected: a score that prefers a particular set of nodes (maybe a particular zone). : existence of an image. : low utilization Now let's assume they give the following scores: Notice that they all have the same distribution (so they all give good signal). Even when using softmax the sum of scores (with the same weight for every score) will be: Nodes 1, 4 and 7 have the same score and thus the same probability to be chosen. I would argue that the user intention was that node 4 would be selected. It's still called a preference because if would give 0 to all nodes, then the pod can still go to the nodes, and the automatic scores take all the decision. Now, in the default scheduler, we have 4 automatic scores, so the user preference is quite unlikely to get respected. It's not necessarily a matter of good signal from the score.\nYup good points-- I agree a weight is still needed. If all the numbers are 0 or 1 (I had thought that it was a floating point and not a binary signal) then I don't think softmax is going to be different than a linear normalization (?). I guess it's debatable whether one wants a priority function that selects fewer nodes to have its opinion on those nodes be weighted more highly, which is what normalization would do. Anyway sorry if this is a rabbit hole. :) I think this idea would make more sense if the priority functions could express a strength for their preference and not just yes/no.\nIt's not binary necessarily... I was over simplifying. Node affinity and image locality certainly are, but node utilization is not.\nIt might be worth some experiments, then... if you have some way of telling whether or not it's actually better? Aldo Culquicondor <:\nWe have an HA use case that involves spreading pods across nodes and zone with preferred scheduling since we'd rather schedule the pods than not. Before 1.18, we've been using the something like the following: Now with the 1.18 beta, we tried the following: The later yields better scheduling results than the former on a 9 nodes multi-zone cluster with 3 nodes in each node. So while was better it surprisingly didn't yield a perfect spread. So I decided to combine both and ... boom ... we had a perfect pod spread for our deployment with 9 replicas. I'm not sure how these results fit into the discussions so far but I would have expected either option by itself to yield a better spread. Combining the two lets me reinforce my desires to the scheduler. IMO, I would like to see the scheduler give my explicit request more weight.\nthanks a lot for sharing. Giving more weight to explicit requests is what we are proposing. However, I'm a little surprised that you need these constraints. The scheduler already spreads by default when using services, replica set or stateful sets. Are these pods not members of any of those? I assume you are not modifying the scheduler configuration? But, of course, there are other scores in play. It makes sense that spreading constraints are more effective than antiaffinity, because there is a lot of antiaffinity with the node that is ultimately selected as well. Adding both specs works too. However, this increases scheduling latency, as we have to calculate more things. The main motivation for this issue was actually to make scoring more effective for the opposite case, which is not done by default: \"packing\". But your use case is just as valid.\nThese pods are part of a deployment. I tried without any scheduling preferences and the results are similar to podAntiAffinity preferred scheduling. Here is the baseline deployment yaml used for the tests: I have not modified the scheduler configuration.\nYes, deployments are affected because they create a replica set that owns the pods. But there are always other scores at play that might also be important, which is why a \"preferred\" spreading is never going to be perfect. This is kind of the point that was trying to make: guarding users from over-fitting and degrading the clusters in some way.\nWhat if we reduce the scope to just PodTopologySpreading, which is beta since 1.18? We could give it a weight of 2 now, before going to GA.\nAldo, one thing to take into account is the new default spread logic which is based on default pod topology spread constraints. For default spread constraints, I think the weight shouldn't increase, so things will get a little complicated with how we treat this case.\nGiven that default spread constraints is explicitly specified by users in , maybe we can assume they are already aware of adjusting the \"Weight\" in ? While for regular users, they won't touch , so a default non-1 weight is a no-op for them.\nthe default constraints (which we plan to introduce to replace the current defaultpodspreading score plugin) are not explicitly specified in PluginConfig.\nMaybe I missed something, are we talking about the same default constraints defined here?\nyes we are, but isn't the plan to have a default value for DefaultConstraints when not set: two constraints, one for zone and one for hostname, which mimic the current defaultpodspread behaviour and allows us to deprecate it?\nI think the only way around that is to introduce a weight for default constraints in the plugin config. And then set it to 50% for the k8s default.\nhmm, this will be a confusing configuration parameter to users. Another approach to consider is to bake it into the TopologySpread plugin instantiation without needing to pass it through PluginConfig (similar to what we did for volumebinder in the past: ).\nurgh, this will be tricky to do since defaulting will be done via component config, and so we don't have a way to communicate whether the values were defaults or explicitly set by the user. If defaulting is done in then it might be possible, but we shouldn't do that.\nDefaulting is going to happen in in the near future\nWe can have it in the internal type, but not the external one then. This will hide it from the users. But how do we communicate that to conversion logic?!\nIt doesn't seem there is a way because defaulting happens before conversion...\nTo make the new parameter semantically clear, we can treat it as a weight override rather than a percentage of the plugin weight, and so it's default would be 1 rather than 50%, internally the plugin computes the ratio as the override weight divided by the plugin weight, which it uses to scale scores computed for pods that don't have topology spread specified in their spec.\nGot it now. I thought the default constraints would default to nil if not specified by users. I think we should introduce a field called \"multiplexer\" and default to 1, so it's friendly to defaulting and conversion.\n+1.\nWhat if we start giving meaning to MaxSkew for scoring? If you set a low MaxSkew, you probably want it to have a higher effect than if you set a bigger value. We can discuss the exact formula, but I think adding these semantics make sense. On Sat., Apr. 18, 2020, 5:50 p.m. Wei Huang, <:\nThat's possible. Current Score function doesn't take into consideration - it's just following a simple \"the less number of matching Pods a topology has, the higher score the Nodes on that topology are given\" principle.\nNote that if we add another parameter to the args, it would only be relevant for scoring, adding to the confusion.\n: This score calculation is somewhat complicated, but can be resumed as: Calculate number of matching pods per topology. There is some new feature that takes in consideration the skew Normalize by . The effect is that pods with the lowest count get a score of . Then the rest of the scores go from a certain number to . A score is given to a node with when is . This formula has the effect of reducing differentiation among nodes as the increases. : The formula is very simple, the score is equal to the percentage of free space (averaged for cpu and memory). Each score on their own give the differentiation we want, but they kind of have different scales. As a result tends to be stronger. I'm using a 9 nodes (3 in each zone) cluster as an example. I've set different initial loads, and in all cases I simulate a Deployment of 30 pods (each assumed to take 1% of node resources). Here are the scenarios, where numbers are percentage of use: For equal score weights (current configuration), this is the distribution of new pods: for both nodes and zones Note how a node with only 40% utilization gets only 1 or 0 pods. For double score weights for both nodes and zones Only at 80% utilization we observe bigger skews, which is reasonable. But the spreading is still pretty good at 40% For planned default spreading See , but this might change, depending on feedback here. I think this is enough justification to increase the weight of to 2 in its 2nd beta release.\nSounds reasonable. It's mathematically equivalent to changing the formula to e.g. , right? Have you considered doing that instead of changing the weight? It seems like that'd help everyone except those who specifically already increased , instead of just people who are using the defaults?\nIt'd make sense to me if the available functions were in the same scale / units so that they'd compose better, but it's not obvious how to do that--what would the units be? One thought is to make the units \"std deviations from the mean\"--if we knew the output frequency of each function, we could maybe do that. So basically this would measure how unusual a preference is, I guess. (I don't think this is an actionable thought. It really bugs me that the outputs of these functions are combined when they are not really in the same units, though!)\nYes 100 is the maximum score we have defined any plugins to have. I'm not convinced this would work. The variance in my examples for initial resource usage is quite high. So it would still get a lot of importance. But, you have triggered me to start thinking about the linearity of the scores. The formula is good because it reduce the variance as increases. However, that reduction is too aggressive. On the other hand, is completely linear. I'll experiment changing the linearity of either function, but preferring to do so for the beta plugin.\nHere go 2 alternatives, with the same situations as We either solution, we wouldn't need to modify the weights Although we are not getting as good spreading as simply doubling the weight. But this is only in the last scenario, where we have usages of 80%. So I would call this rather a win (we should be paying greater attention to resource usage at this point). I think option B is simpler to understand and gives slightly better results (only noticeable in the last case). So this would be my algorithmic preference. However, I'm fine with option A.\nYeah, that's a great idea. You can generalize that and give each function a both a linear weight and a \"gamma\" (name from image processing): or even go for (but in this case I'm in favor of just making a targeted fix to that one function)\nAwesome, Any concerns against option B? Given that it's an older feature.\nhow would option B impact node ranking in the absence of spreading? would image size scores start to have bigger impact?\nI think SIG Scheduling should probably have a discussion. I could go either way, my naive inclination is to just go for the change, but I'm sure it'll break someone. We probably need a way to get back the old behavior, or a suggested weight change that would approximate it (not clear how well that could do though). I also have question, which is how well does this new value compose with other functions? I feel like the proper answer looks like an evaluation criteria + {long list of scenarios} + {list of workloads to schedule} + randomized testing / benchmarking. Basically the multi-dimensional version of the analysis here. That sounds like a lot of work but it would permit actual optimization of these functions.\nconfigurable gamma is an obvious way... :/\nI don't think we want another config parameter, we already have the weight concept and it is configurable, so I think we should go with that, just double the spreading score weight by default, and users who don't favor this behavior can configure it back to 1.\nYeah, that sounds expedient. ahg-g <:\nIn short, yes. Although that score has a mechanism to avoid the \"node heating problem\" we could have undesirable consequences unless we carefully analyze the impact. But that same reasoning doesn't apply to option A (improving PodTopologySpreading), for the following reasons: The score in 1.18 had pretty weak signal, that was only useful with very small number of pods. We have drastically improved this . So it can only be compared to other scores now. The score can now be tweaked in the PodSpec through maxSkew I would argue that option ~B~ A is better that simply doubling the weight because its signal is more conservative when it matters (nodes have high usage).\nI am not clear on the following: you say \"we could have undesirable consequences unless we carefully analyze the impact.\" but then you argue for the option at the end, can you clarify? We had default spreading that was giving similar strong signal, we should compare with that. My concern with modifying the is that we may break someone. Increasing the weight is something that users can revert, while option B can't be reverted.\nSorry, I meant option A, improve PodTopologySpread\nOne potential advantage to doubling the weight is that topology spread currently offers a signal comparable to default spreading, which we can think of as a baseline for spreading signal since it has been used for a while now. Doubling the weight will allow admins to revert back to the old behavior if they wish to do so. Also, from my perspective, doubling the weight is giving better placement at high utilization ( vs )", "positive_passages": [{"docid": "doc-en-kubernetes-00630fe3953bdbe1a1a5a5dd3aaf30508c98b47d7d7cf76582f2954e4166a3e6", "text": "{Name: \"NodePreferAvoidPods\", Weight: 10000}, {Name: \"DefaultPodTopologySpread\", Weight: 1}, {Name: \"TaintToleration\", Weight: 1}, <del> {Name: \"PodTopologySpread\", Weight: 1}, </del> <ins> {Name: \"PodTopologySpread\", Weight: 2}, </ins> }, \"ReservePlugin\":   {{Name: \"VolumeBinding\"}}, \"UnreservePlugin\": {{Name: \"VolumeBinding\"}},", "commid": "kubernetes_pr_91258"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-da2fde1c088200d5610f06fd7955a1151e1a7aecd68788e3d49161d2a8de99d3", "query": "Once we upgrade to go1.14, we can use the new CipherSuites and InsecureCipherSuites functions and CipherSuiteName function to build the supported cipher suite flags. /sig api-machinery\n/sig auth\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nas the project was upgraded to go-1.14+ is that still something that needs to be done?\nyes, these manually maintained maps should be swapped to the stdlib impls:\n/assign\n/triage accepted Thanks,", "positive_passages": [{"docid": "doc-en-kubernetes-6615fadb28b5831db1d91160c73f94b48c5d2f956e47eebad21e106f9323635b", "text": "\"k8s.io/apimachinery/pkg/util/sets\" ) <del> // ciphers maps strings into tls package cipher constants in // https://golang.org/pkg/crypto/tls/#pkg-constants // to be replaced by tls.CipherSuites() when the project migrates to go1.14. var ciphers = map[string]uint16{ \"TLS_RSA_WITH_3DES_EDE_CBC_SHA\":           tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA, \"TLS_RSA_WITH_AES_128_CBC_SHA\":            tls.TLS_RSA_WITH_AES_128_CBC_SHA, \"TLS_RSA_WITH_AES_256_CBC_SHA\":            tls.TLS_RSA_WITH_AES_256_CBC_SHA, \"TLS_RSA_WITH_AES_128_GCM_SHA256\":         tls.TLS_RSA_WITH_AES_128_GCM_SHA256, \"TLS_RSA_WITH_AES_256_GCM_SHA384\":         tls.TLS_RSA_WITH_AES_256_GCM_SHA384, \"TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA\":    tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA, \"TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA\":    tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA, \"TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA\":     tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA, \"TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA\":      tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, \"TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA\":      tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, \"TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256\":   tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, \"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256\": tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, \"TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384\":   tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, \"TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384\": tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, \"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305\":    tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305, \"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305\":  tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305, \"TLS_AES_128_GCM_SHA256\":                  tls.TLS_AES_128_GCM_SHA256, \"TLS_CHACHA20_POLY1305_SHA256\":            tls.TLS_CHACHA20_POLY1305_SHA256, \"TLS_AES_256_GCM_SHA384\":                  tls.TLS_AES_256_GCM_SHA384, } </del> <ins> var ( // ciphers maps strings into tls package cipher constants in // https://golang.org/pkg/crypto/tls/#pkg-constants ciphers         = map[string]uint16{} insecureCiphers = map[string]uint16{} ) </ins> <del> // to be replaced by tls.InsecureCipherSuites() when the project migrates to go1.14. var insecureCiphers = map[string]uint16{ \"TLS_RSA_WITH_RC4_128_SHA\":                tls.TLS_RSA_WITH_RC4_128_SHA, \"TLS_RSA_WITH_AES_128_CBC_SHA256\":         tls.TLS_RSA_WITH_AES_128_CBC_SHA256, \"TLS_ECDHE_ECDSA_WITH_RC4_128_SHA\":        tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA, \"TLS_ECDHE_RSA_WITH_RC4_128_SHA\":          tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA, \"TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256\": tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256, \"TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256\":   tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, </del> <ins> func init() { for _, suite := range tls.CipherSuites() { ciphers[suite.Name] = suite.ID } // keep legacy names for backward compatibility ciphers[\"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305\"] = tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 ciphers[\"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305\"] = tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 for _, suite := range tls.InsecureCipherSuites() { insecureCiphers[suite.Name] = suite.ID } </ins> } // InsecureTLSCiphers returns the cipher suites implemented by crypto/tls which have", "commid": "kubernetes_pr_105064"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-da2fde1c088200d5610f06fd7955a1151e1a7aecd68788e3d49161d2a8de99d3", "query": "Once we upgrade to go1.14, we can use the new CipherSuites and InsecureCipherSuites functions and CipherSuiteName function to build the supported cipher suite flags. /sig api-machinery\n/sig auth\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nas the project was upgraded to go-1.14+ is that still something that needs to be done?\nyes, these manually maintained maps should be swapped to the stdlib impls:\n/assign\n/triage accepted Thanks,", "positive_passages": [{"docid": "doc-en-kubernetes-55537165e9a1395bc93c67301ecad54fe7a91a7d642fd3e5c26f31746f3f16d2", "text": "<del> //go:build go1.14 // +build go1.14 /* Copyright 2020 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package flag import ( \"crypto/tls\" ) func init() { // support official IANA names as well on go1.14 ciphers[\"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256\"] = tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 ciphers[\"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256\"] = tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 } </del>", "commid": "kubernetes_pr_105064"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-da2fde1c088200d5610f06fd7955a1151e1a7aecd68788e3d49161d2a8de99d3", "query": "Once we upgrade to go1.14, we can use the new CipherSuites and InsecureCipherSuites functions and CipherSuiteName function to build the supported cipher suite flags. /sig api-machinery\n/sig auth\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nas the project was upgraded to go-1.14+ is that still something that needs to be done?\nyes, these manually maintained maps should be swapped to the stdlib impls:\n/assign\n/triage accepted Thanks,", "positive_passages": [{"docid": "doc-en-kubernetes-d128e1514991df576633943c57e544f6701ce565c9f6435e9e60acffccf32984", "text": "import ( \"crypto/tls\" <del> \"fmt\" \"go/importer\" </del> \"reflect\" <del> \"strings\" </del> \"testing\" )", "commid": "kubernetes_pr_105064"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-da2fde1c088200d5610f06fd7955a1151e1a7aecd68788e3d49161d2a8de99d3", "query": "Once we upgrade to go1.14, we can use the new CipherSuites and InsecureCipherSuites functions and CipherSuiteName function to build the supported cipher suite flags. /sig api-machinery\n/sig auth\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nas the project was upgraded to go-1.14+ is that still something that needs to be done?\nyes, these manually maintained maps should be swapped to the stdlib impls:\n/assign\n/triage accepted Thanks,", "positive_passages": [{"docid": "doc-en-kubernetes-4fb88d7bddee2420e2d2ada7b6d3b70a101b151123d0be195ffa1f16c350fe2d", "text": "expected:       nil, expected_error: true, }, <ins> { // All existing cipher suites flag: []string{ \"TLS_RSA_WITH_3DES_EDE_CBC_SHA\", \"TLS_RSA_WITH_AES_128_CBC_SHA\", \"TLS_RSA_WITH_AES_256_CBC_SHA\", \"TLS_RSA_WITH_AES_128_GCM_SHA256\", \"TLS_RSA_WITH_AES_256_GCM_SHA384\", \"TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA\", \"TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA\", \"TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA\", \"TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA\", \"TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA\", \"TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256\", \"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256\", \"TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384\", \"TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384\", \"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305\", \"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305\", \"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256\", \"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256\", \"TLS_AES_128_GCM_SHA256\", \"TLS_CHACHA20_POLY1305_SHA256\", \"TLS_AES_256_GCM_SHA384\", \"TLS_RSA_WITH_RC4_128_SHA\", \"TLS_RSA_WITH_AES_128_CBC_SHA256\", \"TLS_ECDHE_ECDSA_WITH_RC4_128_SHA\", \"TLS_ECDHE_RSA_WITH_RC4_128_SHA\", \"TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256\", \"TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256\", }, expected: []uint16{ tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA, tls.TLS_RSA_WITH_AES_128_CBC_SHA, tls.TLS_RSA_WITH_AES_256_CBC_SHA, tls.TLS_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_AES_256_GCM_SHA384, tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA, tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA, tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305, tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305, tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256, tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256, tls.TLS_AES_128_GCM_SHA256, tls.TLS_CHACHA20_POLY1305_SHA256, tls.TLS_AES_256_GCM_SHA384, tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_RSA_WITH_AES_128_CBC_SHA256, tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256, tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, }, }, </ins> } for i, test := range tests { uIntFlags, err := TLSCipherSuites(test.flag) <del> if reflect.DeepEqual(uIntFlags, test.expected) == false { </del> <ins> if !reflect.DeepEqual(uIntFlags, test.expected) { </ins> t.Errorf(\"%d: expected %+v, got %+v\", i, test.expected, uIntFlags) } if test.expected_error && err == nil {", "commid": "kubernetes_pr_105064"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-da2fde1c088200d5610f06fd7955a1151e1a7aecd68788e3d49161d2a8de99d3", "query": "Once we upgrade to go1.14, we can use the new CipherSuites and InsecureCipherSuites functions and CipherSuiteName function to build the supported cipher suite flags. /sig api-machinery\n/sig auth\n/cc\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nas the project was upgraded to go-1.14+ is that still something that needs to be done?\nyes, these manually maintained maps should be swapped to the stdlib impls:\n/assign\n/triage accepted Thanks,", "positive_passages": [{"docid": "doc-en-kubernetes-6c7ccdc7cedfbbe88c762918116cbdfb4575833f0369ff9a958d7ef4c256c18a", "text": "} } } <del> func TestConstantMaps(t *testing.T) { pkg, err := importer.Default().Import(\"crypto/tls\") if err != nil { fmt.Printf(\"error: %sn\", err.Error()) return } discoveredVersions := map[string]bool{} discoveredCiphers := map[string]bool{} for _, declName := range pkg.Scope().Names() { if strings.HasPrefix(declName, \"VersionTLS\") { discoveredVersions[declName] = true } if strings.HasPrefix(declName, \"TLS_\") && !strings.HasPrefix(declName, \"TLS_FALLBACK_\") { discoveredCiphers[declName] = true } } acceptedCiphers := allCiphers() for k := range discoveredCiphers { if _, ok := acceptedCiphers[k]; !ok { t.Errorf(\"discovered cipher tls.%s not in ciphers map\", k) } } for k := range acceptedCiphers { if _, ok := discoveredCiphers[k]; !ok { t.Errorf(\"ciphers map has %s not in tls package\", k) } } for k := range discoveredVersions { if _, ok := versions[k]; !ok { t.Errorf(\"discovered version tls.%s not in version map\", k) } } for k := range versions { if _, ok := discoveredVersions[k]; !ok { t.Errorf(\"versions map has %s not in tls package\", k) } } } </del>", "commid": "kubernetes_pr_105064"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7bf8455a3a807df05b77f0e3ec29c1e5ea4153da582875cc4d458bc01acfad36", "query": "What happened: https://k8s- These tests failed consistently: Anything else we need to know?: Volume snapshot tests need to be reworked to use / helper functions that support block volume mode. In addition, csi-driver-host-path fails when restoring block volume snapshots. /assign /sig storage\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : What happened: https://k8s- Anything else we need to know?: Volume snapshot tests need to be reworked to use / helper functions that support block volume mode. In addition, csi-driver-host-path fails when restoring block volume snapshots. /sig stroage Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhostpath driver fix:\nE2e test fix: (needs hostpath driver release first).", "positive_passages": [{"docid": "doc-en-kubernetes-73c1a615a098195931aa07c1bd3ed57d8b2295fed8d99bb36b338aa95f91db1f", "text": "dc := l.config.Framework.DynamicClient vsc := sDriver.GetSnapshotClass(l.config) <del> dataSource, cleanupFunc := prepareSnapshotDataSourceForProvisioning(l.config.ClientNodeSelection, l.cs, dc, l.pvc, l.sc, vsc) </del> <ins> testConfig := convertTestConfig(l.config) expectedContent := fmt.Sprintf(\"Hello from namespace %s\", f.Namespace.Name) dataSource, cleanupFunc := prepareSnapshotDataSourceForProvisioning(f, testConfig, l.cs, dc, l.pvc, l.sc, vsc, pattern.VolMode, expectedContent) </ins> defer cleanupFunc() l.pvc.Spec.DataSource = dataSource l.testCase.PvCheck = func(claim *v1.PersistentVolumeClaim) { ginkgo.By(\"checking whether the created volume has the pre-populated data\") <del> command := fmt.Sprintf(\"grep '%s' /mnt/test/initialData\", claim.Namespace) RunInPodWithVolume(l.cs, claim.Namespace, claim.Name, \"pvc-snapshot-tester\", command, l.config.ClientNodeSelection) </del> <ins> tests := []volume.Test{ { Volume:          *createVolumeSource(claim.Name, false /* readOnly */), Mode:            pattern.VolMode, File:            \"index.html\", ExpectedContent: expectedContent, }, } volume.TestVolumeClient(f, testConfig, nil, \"\", tests) </ins> } l.testCase.TestDynamicProvisioning() })", "commid": "kubernetes_pr_88727"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7bf8455a3a807df05b77f0e3ec29c1e5ea4153da582875cc4d458bc01acfad36", "query": "What happened: https://k8s- These tests failed consistently: Anything else we need to know?: Volume snapshot tests need to be reworked to use / helper functions that support block volume mode. In addition, csi-driver-host-path fails when restoring block volume snapshots. /assign /sig storage\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : What happened: https://k8s- Anything else we need to know?: Volume snapshot tests need to be reworked to use / helper functions that support block volume mode. In addition, csi-driver-host-path fails when restoring block volume snapshots. /sig stroage Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhostpath driver fix:\nE2e test fix: (needs hostpath driver release first).", "positive_passages": [{"docid": "doc-en-kubernetes-ce78ad8eb7148c5b307d25e7e44cfd04510f761f8febb90b45f43e1e51e9c29e", "text": "} func prepareSnapshotDataSourceForProvisioning( <del> node e2epod.NodeSelection, </del> <ins> f *framework.Framework, config volume.TestConfig, </ins> client clientset.Interface, dynamicClient dynamic.Interface, initClaim *v1.PersistentVolumeClaim, class *storagev1.StorageClass, snapshotClass *unstructured.Unstructured, <ins> mode v1.PersistentVolumeMode, injectContent string, </ins> ) (*v1.TypedLocalObjectReference, func()) { var err error if class != nil {", "commid": "kubernetes_pr_88727"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7bf8455a3a807df05b77f0e3ec29c1e5ea4153da582875cc4d458bc01acfad36", "query": "What happened: https://k8s- These tests failed consistently: Anything else we need to know?: Volume snapshot tests need to be reworked to use / helper functions that support block volume mode. In addition, csi-driver-host-path fails when restoring block volume snapshots. /assign /sig storage\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : What happened: https://k8s- Anything else we need to know?: Volume snapshot tests need to be reworked to use / helper functions that support block volume mode. In addition, csi-driver-host-path fails when restoring block volume snapshots. /sig stroage Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhostpath driver fix:\nE2e test fix: (needs hostpath driver release first).", "positive_passages": [{"docid": "doc-en-kubernetes-e5dceb4f67002741f15bf0925d0b13abfb7d4a392a22e809578a945a7e5fc02e", "text": "framework.ExpectNoError(err) // write namespace to the /mnt/test (= the volume). <del> ginkgo.By(\"[Initialize dataSource]write data to volume\") command := fmt.Sprintf(\"echo '%s' > /mnt/test/initialData\", updatedClaim.GetNamespace()) RunInPodWithVolume(client, updatedClaim.Namespace, updatedClaim.Name, \"pvc-snapshot-writer\", command, node) err = e2epv.WaitForPersistentVolumeClaimPhase(v1.ClaimBound, client, updatedClaim.Namespace, updatedClaim.Name, framework.Poll, framework.ClaimProvisionTimeout) framework.ExpectNoError(err) ginkgo.By(\"[Initialize dataSource]checking the initClaim\") // Get new copy of the initClaim _, err = client.CoreV1().PersistentVolumeClaims(updatedClaim.Namespace).Get(context.TODO(), updatedClaim.Name, metav1.GetOptions{}) framework.ExpectNoError(err) </del> <ins> tests := []volume.Test{ { Volume:          *createVolumeSource(updatedClaim.Name, false /* readOnly */), Mode:            mode, File:            \"index.html\", ExpectedContent: injectContent, }, } volume.InjectContent(f, config, nil, \"\", tests) </ins> ginkgo.By(\"[Initialize dataSource]creating a SnapshotClass\") snapshotClass, err = dynamicClient.Resource(snapshotClassGVR).Create(snapshotClass, metav1.CreateOptions{}) <ins> framework.ExpectNoError(err) </ins> ginkgo.By(\"[Initialize dataSource]creating a snapshot\") snapshot := getSnapshot(updatedClaim.Name, updatedClaim.Namespace, snapshotClass.GetName())", "commid": "kubernetes_pr_88727"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7bf8455a3a807df05b77f0e3ec29c1e5ea4153da582875cc4d458bc01acfad36", "query": "What happened: https://k8s- These tests failed consistently: Anything else we need to know?: Volume snapshot tests need to be reworked to use / helper functions that support block volume mode. In addition, csi-driver-host-path fails when restoring block volume snapshots. /assign /sig storage\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : What happened: https://k8s- Anything else we need to know?: Volume snapshot tests need to be reworked to use / helper functions that support block volume mode. In addition, csi-driver-host-path fails when restoring block volume snapshots. /sig stroage Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhostpath driver fix:\nE2e test fix: (needs hostpath driver release first).", "positive_passages": [{"docid": "doc-en-kubernetes-8cf9f6596b7a989a7e424ffe472288d562d33407ca6526ff9064f0654ab85506", "text": "name: csi-data-dir - name: hostpath <del> image: quay.io/k8scsi/hostpathplugin:v1.4.0-rc1 </del> <ins> image: quay.io/k8scsi/hostpathplugin:v1.4.0-rc2 </ins> args: - \"--drivername=hostpath.csi.k8s.io\" - \"--v=5\"", "commid": "kubernetes_pr_88727"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a74dc91d29df1600cf3137c4656606581d4ad54be7e0389561e161808edd7df", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: pull-kubernetes-e2e-gce Which test(s) are flaking: Testgrid link: Reason for failure: Anything else we need to know: Triage board shows flakes here spiked dramatically on 3/4 /sig node /priority critical-urgent /milestone v1.18\nare you able to assist if this is related to recent topology work?\nsure, I'll take a look\nis this the test you just in ?\nAs mentioned above, this is a new test that was just , and the test sometimes fails. I don't see that any of the recent topology manager changes would cause these failures. I'll be happy to help out and dig more if or others think otherwise.\nThis is me, the bugs are untriaged containerd / Kubelet failures with low occurrence rates that this test now exposes. Investigating.\nstill flaking in non-dockershim environments: pod pod-submit-status-0-14 on node kind-worker2 container unexpected exit code 128: start=1970-01-01 00:00:00 +0000 UTC end=2020-03-06 16:16:54 +0000 UTC reason=StartError message=failed to create containerd task: OCI runtime create failed: starting container process caused \" container init caused \" mounting \"/var/lib/kubelet/pods/-819e-4840-8369-\" to rootfs \"\" at \"\" caused \"stat /var/lib/kubelet/pods/-819e-4840-8369- no such file or directory\"\"\": unknown `\nDifferent reason this time. Will continue to enumerate failure modes.", "positive_passages": [{"docid": "doc-en-kubernetes-16ea4d21b317d9cbef400aa3d027a4e5aadbbe17631b1d1944ec60787c1800bd", "text": "ginkgo.It(\"should never report success for a pending container\", func() { ginkgo.By(\"creating pods that should always exit 1 and terminating the pod after a random delay\") <del> var reBug88766 = regexp.MustCompile(`ContainerCannotRun.*rootfs_linux.go.*kubernetes.io~secret.*no such file or directory`) </del> <ins> var reBug88766 = regexp.MustCompile(`rootfs_linux.*kubernetes.io~secret.*no such file or directory`) </ins> var ( lock sync.Mutex", "commid": "kubernetes_pr_88872"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a74dc91d29df1600cf3137c4656606581d4ad54be7e0389561e161808edd7df", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: pull-kubernetes-e2e-gce Which test(s) are flaking: Testgrid link: Reason for failure: Anything else we need to know: Triage board shows flakes here spiked dramatically on 3/4 /sig node /priority critical-urgent /milestone v1.18\nare you able to assist if this is related to recent topology work?\nsure, I'll take a look\nis this the test you just in ?\nAs mentioned above, this is a new test that was just , and the test sometimes fails. I don't see that any of the recent topology manager changes would cause these failures. I'll be happy to help out and dig more if or others think otherwise.\nThis is me, the bugs are untriaged containerd / Kubelet failures with low occurrence rates that this test now exposes. Investigating.\nstill flaking in non-dockershim environments: pod pod-submit-status-0-14 on node kind-worker2 container unexpected exit code 128: start=1970-01-01 00:00:00 +0000 UTC end=2020-03-06 16:16:54 +0000 UTC reason=StartError message=failed to create containerd task: OCI runtime create failed: starting container process caused \" container init caused \" mounting \"/var/lib/kubelet/pods/-819e-4840-8369-\" to rootfs \"\" at \"\" caused \"stat /var/lib/kubelet/pods/-819e-4840-8369- no such file or directory\"\"\": unknown `\nDifferent reason this time. Will continue to enumerate failure modes.", "positive_passages": [{"docid": "doc-en-kubernetes-b13977e5dd832c7d7f671e0f825322199a5bf1c6d4ec112d486129a93f3e302e", "text": "switch { case t.ExitCode == 1: // expected <del> case t.ExitCode == 128 && reBug88766.MatchString(t.Message): </del> <ins> case t.ExitCode == 128 && t.Reason == \"ContainerCannotRun\" && reBug88766.MatchString(t.Message): </ins> // pod volume teardown races with container start in CRI, which reports a failure framework.Logf(\"pod %s on node %s failed with the symptoms of https://github.com/kubernetes/kubernetes/issues/88766\") default:", "commid": "kubernetes_pr_88872"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a74dc91d29df1600cf3137c4656606581d4ad54be7e0389561e161808edd7df", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: pull-kubernetes-e2e-gce Which test(s) are flaking: Testgrid link: Reason for failure: Anything else we need to know: Triage board shows flakes here spiked dramatically on 3/4 /sig node /priority critical-urgent /milestone v1.18\nare you able to assist if this is related to recent topology work?\nsure, I'll take a look\nis this the test you just in ?\nAs mentioned above, this is a new test that was just , and the test sometimes fails. I don't see that any of the recent topology manager changes would cause these failures. I'll be happy to help out and dig more if or others think otherwise.\nThis is me, the bugs are untriaged containerd / Kubelet failures with low occurrence rates that this test now exposes. Investigating.\nstill flaking in non-dockershim environments: pod pod-submit-status-0-14 on node kind-worker2 container unexpected exit code 128: start=1970-01-01 00:00:00 +0000 UTC end=2020-03-06 16:16:54 +0000 UTC reason=StartError message=failed to create containerd task: OCI runtime create failed: starting container process caused \" container init caused \" mounting \"/var/lib/kubelet/pods/-819e-4840-8369-\" to rootfs \"\" at \"\" caused \"stat /var/lib/kubelet/pods/-819e-4840-8369- no such file or directory\"\"\": unknown `\nDifferent reason this time. Will continue to enumerate failure modes.", "positive_passages": [{"docid": "doc-en-kubernetes-4340ce61bb0c350ea9809e436d1b629f8d751075c7b6ffcd1843844263ca7abe", "text": "switch { case t.ExitCode == 1: // expected <del> case t.ExitCode == 128 && t.Reason == \"ContainerCannotRun\" && reBug88766.MatchString(t.Message): </del> <ins> case t.ExitCode == 128 && (t.Reason == \"StartError\" || t.Reason == \"ContainerCannotRun\") && reBug88766.MatchString(t.Message): </ins> // pod volume teardown races with container start in CRI, which reports a failure framework.Logf(\"pod %s on node %s failed with the symptoms of https://github.com/kubernetes/kubernetes/issues/88766\") default:", "commid": "kubernetes_pr_88952"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-27ad9593cabf1355cf849e43656d227454220bbe6ecc2987e545b250f692c951", "query": "What happened: A SystemOOM event was not reported even when the memory limit hit was the root cgroup memory limit. What you expected to happen: A SystemOOM event should have been reported. How to reproduce it (as minimally and precisely as possible): Do not set or , and set to disable memory eviction on the kubelet. Run a pod without memory limits which slowly consumes memory, such as with from Use arguments -mem-alloc-size\", \"100Mi\", \"-mem-alloc-sleep\", \"10s\". This should trigger an OOM on the root cgroup, but no event will be generated. Anything else we need to know?: cAdvisor populates ContainerName and VictimContainerName from matching the regexp: instead in the kubelet. cc\n/sig node /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-bd4a84219da020c6231b1f6cd75870cc682ce2845576e01f51b3de9b6e8d5b53", "text": "defer runtime.HandleCrash() for event := range outStream { <del> if event.ContainerName == recordEventContainerName { </del> <ins> if event.VictimContainerName == recordEventContainerName { </ins> klog.V(1).Infof(\"Got sys oom event: %v\", event) eventMsg := \"System OOM encountered\" if event.ProcessName != \"\" && event.Pid != 0 {", "commid": "kubernetes_pr_88871"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-27ad9593cabf1355cf849e43656d227454220bbe6ecc2987e545b250f692c951", "query": "What happened: A SystemOOM event was not reported even when the memory limit hit was the root cgroup memory limit. What you expected to happen: A SystemOOM event should have been reported. How to reproduce it (as minimally and precisely as possible): Do not set or , and set to disable memory eviction on the kubelet. Run a pod without memory limits which slowly consumes memory, such as with from Use arguments -mem-alloc-size\", \"100Mi\", \"-mem-alloc-sleep\", \"10s\". This should trigger an OOM on the root cgroup, but no event will be generated. Anything else we need to know?: cAdvisor populates ContainerName and VictimContainerName from matching the regexp: instead in the kubelet. cc\n/sig node /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-d91b3037e35d6d2f8da5ea09b08408a215ec3d82b3f5309cf830de6c98f2641b", "text": "Pid:                 1000, ProcessName:         \"fakeProcess\", TimeOfDeath:         time.Now(), <del> ContainerName:       recordEventContainerName, VictimContainerName: \"some-container\", </del> <ins> ContainerName:       recordEventContainerName + \"some-container\", VictimContainerName: recordEventContainerName, </ins> }, } numExpectedOomEvents := len(oomInstancesToStream)", "commid": "kubernetes_pr_88871"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-27ad9593cabf1355cf849e43656d227454220bbe6ecc2987e545b250f692c951", "query": "What happened: A SystemOOM event was not reported even when the memory limit hit was the root cgroup memory limit. What you expected to happen: A SystemOOM event should have been reported. How to reproduce it (as minimally and precisely as possible): Do not set or , and set to disable memory eviction on the kubelet. Run a pod without memory limits which slowly consumes memory, such as with from Use arguments -mem-alloc-size\", \"100Mi\", \"-mem-alloc-sleep\", \"10s\". This should trigger an OOM on the root cgroup, but no event will be generated. Anything else we need to know?: cAdvisor populates ContainerName and VictimContainerName from matching the regexp: instead in the kubelet. cc\n/sig node /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-8cb2062934168fd7ea2436a9298cdcfacc43a89b64bee492d1befdddf58a7a84", "text": "Pid:                 1000, ProcessName:         \"fakeProcess\", TimeOfDeath:         time.Now(), <del> ContainerName:       recordEventContainerName, VictimContainerName: \"some-container\", </del> <ins> ContainerName:       recordEventContainerName + \"some-container\", VictimContainerName: recordEventContainerName, </ins> }, { Pid:                 1000, ProcessName:         \"fakeProcess\", TimeOfDeath:         time.Now(), <del> ContainerName:       \"/dont-record-oom-event\", VictimContainerName: \"some-container\", </del> <ins> ContainerName:       recordEventContainerName + \"kubepods/some-container\", VictimContainerName: recordEventContainerName + \"kubepods\", </ins> }, } numExpectedOomEvents := len(oomInstancesToStream) - numOomEventsWithIncorrectContainerName", "commid": "kubernetes_pr_88871"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-27ad9593cabf1355cf849e43656d227454220bbe6ecc2987e545b250f692c951", "query": "What happened: A SystemOOM event was not reported even when the memory limit hit was the root cgroup memory limit. What you expected to happen: A SystemOOM event should have been reported. How to reproduce it (as minimally and precisely as possible): Do not set or , and set to disable memory eviction on the kubelet. Run a pod without memory limits which slowly consumes memory, such as with from Use arguments -mem-alloc-size\", \"100Mi\", \"-mem-alloc-sleep\", \"10s\". This should trigger an OOM on the root cgroup, but no event will be generated. Anything else we need to know?: cAdvisor populates ContainerName and VictimContainerName from matching the regexp: instead in the kubelet. cc\n/sig node /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-95b313faaa79b8aba832b5e0b978467c56635f2bba62277e8480914530ba251d", "text": "Pid:                 eventPid, ProcessName:         processName, TimeOfDeath:         time.Now(), <del> ContainerName:       recordEventContainerName, VictimContainerName: \"some-container\", </del> <ins> ContainerName:       recordEventContainerName + \"some-container\", VictimContainerName: recordEventContainerName, </ins> }, } numExpectedOomEvents := len(oomInstancesToStream)", "commid": "kubernetes_pr_88871"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a6279e17e106d236da2df8ae406c43b54aa2a31f961ca6490921619691d8981", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: k8s 1.17.2 config kubelet with those parameters cgroupDriver: cgroupfs cgroupRoot: /docker cgroupsPerQOS: false kubelet log always prints those E0303 17:25:03. ] Failed to get system container stats for \"/docker\": failed to get cgroup stats for \"/docker\": failed to get container info for \"/docker\": unknown container \"/docker\" E0303 17:25:03. ] eviction manager: failed to construct signal: \"allocatableMemory.available\" error: system container \"pods\" not found in metrics What you expected to happen: kubelet does not print those error information How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-07ddc511062230e204d96f97c07d178c4ddabe449ea759780ecf5f4d8118f136", "text": "} var cgroupRoots []string <del> cgroupRoots = append(cgroupRoots, cm.NodeAllocatableRoot(s.CgroupRoot, s.CgroupDriver)) </del> <ins> nodeAllocatableRoot := cm.NodeAllocatableRoot(s.CgroupRoot, s.CgroupsPerQOS, s.CgroupDriver) cgroupRoots = append(cgroupRoots, nodeAllocatableRoot) </ins> kubeletCgroup, err := cm.GetKubeletContainer(s.KubeletCgroups) if err != nil { klog.Warningf(\"failed to get the kubelet's cgroup: %v.  Kubelet system container metrics may be missing.\", err)", "commid": "kubernetes_pr_88970"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a6279e17e106d236da2df8ae406c43b54aa2a31f961ca6490921619691d8981", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: k8s 1.17.2 config kubelet with those parameters cgroupDriver: cgroupfs cgroupRoot: /docker cgroupsPerQOS: false kubelet log always prints those E0303 17:25:03. ] Failed to get system container stats for \"/docker\": failed to get cgroup stats for \"/docker\": failed to get container info for \"/docker\": unknown container \"/docker\" E0303 17:25:03. ] eviction manager: failed to construct signal: \"allocatableMemory.available\" error: system container \"pods\" not found in metrics What you expected to happen: kubelet does not print those error information How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-92485987d907c4634e38c53190fa82ee8760a44a70341bbe9331d30e14cd481d", "text": "} // NodeAllocatableRoot returns the literal cgroup path for the node allocatable cgroup <del> func NodeAllocatableRoot(cgroupRoot, cgroupDriver string) string { root := ParseCgroupfsToCgroupName(cgroupRoot) nodeAllocatableRoot := NewCgroupName(root, defaultNodeAllocatableCgroupName) </del> <ins> func NodeAllocatableRoot(cgroupRoot string, cgroupsPerQOS bool, cgroupDriver string) string { nodeAllocatableRoot := ParseCgroupfsToCgroupName(cgroupRoot) if cgroupsPerQOS { nodeAllocatableRoot = NewCgroupName(nodeAllocatableRoot, defaultNodeAllocatableCgroupName) } </ins> if libcontainerCgroupManagerType(cgroupDriver) == libcontainerSystemd { return nodeAllocatableRoot.ToSystemd() }", "commid": "kubernetes_pr_88970"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a6279e17e106d236da2df8ae406c43b54aa2a31f961ca6490921619691d8981", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: k8s 1.17.2 config kubelet with those parameters cgroupDriver: cgroupfs cgroupRoot: /docker cgroupsPerQOS: false kubelet log always prints those E0303 17:25:03. ] Failed to get system container stats for \"/docker\": failed to get cgroup stats for \"/docker\": failed to get container info for \"/docker\": unknown container \"/docker\" E0303 17:25:03. ] eviction manager: failed to construct signal: \"allocatableMemory.available\" error: system container \"pods\" not found in metrics What you expected to happen: kubelet does not print those error information How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-6158a7acbcd7a5f6735863c60a489b6c6a005150f5a5fe166f7de5aae4afbfb4", "text": "} // NodeAllocatableRoot returns the literal cgroup path for the node allocatable cgroup <del> func NodeAllocatableRoot(cgroupRoot, cgroupDriver string) string { </del> <ins> func NodeAllocatableRoot(cgroupRoot string, cgroupsPerQOS bool, cgroupDriver string) string { </ins> return \"\" }", "commid": "kubernetes_pr_88970"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f207c102634d5fe622f73c0749707049f74cd1865ef73e2bb5f934cd8861b8b", "query": "Which jobs are flaking: pull-kubernetes-integration Which test(s) are flaking: TestNominatedNodeCleanUp Testgrid link: Reason for failure: /sig scheduling\n/assign\nany progress on this one?\nI was working on it and tried to find the root cause. I will give my solution within this week\nAnother one\nStill happening cc\n/assign\n/close dupe\nClosing this issue. <detailsIn response to : /close dupe Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-a0cb1092c4b04ade1d5d2f6165579296152c918506d5fd27263c1dbab5d2fb65", "text": "\"//staging/src/k8s.io/apimachinery/pkg/types:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/util/runtime:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library\", <ins> \"//staging/src/k8s.io/apimachinery/pkg/util/strategicpatch:go_default_library\", </ins> \"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library\", \"//staging/src/k8s.io/apiserver/pkg/util/feature:go_default_library\", \"//staging/src/k8s.io/client-go/informers:go_default_library\",", "commid": "kubernetes_pr_90978"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f207c102634d5fe622f73c0749707049f74cd1865ef73e2bb5f934cd8861b8b", "query": "Which jobs are flaking: pull-kubernetes-integration Which test(s) are flaking: TestNominatedNodeCleanUp Testgrid link: Reason for failure: /sig scheduling\n/assign\nany progress on this one?\nI was working on it and tried to find the root cause. I will give my solution within this week\nAnother one\nStill happening cc\n/assign\n/close dupe\nClosing this issue. <detailsIn response to : /close dupe Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-75dda362ac28a2112e8d803b32f7bf25f886b7ec7981d3a08e06b6aac8a59545", "text": "import ( \"context\" <ins> \"encoding/json\" </ins> \"fmt\" \"io/ioutil\" \"math/rand\"", "commid": "kubernetes_pr_90978"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f207c102634d5fe622f73c0749707049f74cd1865ef73e2bb5f934cd8861b8b", "query": "Which jobs are flaking: pull-kubernetes-integration Which test(s) are flaking: TestNominatedNodeCleanUp Testgrid link: Reason for failure: /sig scheduling\n/assign\nany progress on this one?\nI was working on it and tried to find the root cause. I will give my solution within this week\nAnother one\nStill happening cc\n/assign\n/close dupe\nClosing this issue. <detailsIn response to : /close dupe Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-ed1e4b4bd3d9eb64ea4ae07f2213f9bfbc118683f23fdb63ea5a3be88ed34808", "text": "v1 \"k8s.io/api/core/v1\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/runtime\" <ins> \"k8s.io/apimachinery/pkg/types\" \"k8s.io/apimachinery/pkg/util/strategicpatch\" </ins> \"k8s.io/apimachinery/pkg/util/wait\" \"k8s.io/client-go/informers\" coreinformers \"k8s.io/client-go/informers/core/v1\"", "commid": "kubernetes_pr_90978"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f207c102634d5fe622f73c0749707049f74cd1865ef73e2bb5f934cd8861b8b", "query": "Which jobs are flaking: pull-kubernetes-integration Which test(s) are flaking: TestNominatedNodeCleanUp Testgrid link: Reason for failure: /sig scheduling\n/assign\nany progress on this one?\nI was working on it and tried to find the root cause. I will give my solution within this week\nAnother one\nStill happening cc\n/assign\n/close dupe\nClosing this issue. <detailsIn response to : /close dupe Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-32416125416e9216d581219364dafff38cec0df6208834c873bfee7556b5d743", "text": "func (p *podConditionUpdaterImpl) update(pod *v1.Pod, condition *v1.PodCondition) error { klog.V(3).Infof(\"Updating pod condition for %s/%s to (%s==%s, Reason=%s)\", pod.Namespace, pod.Name, condition.Type, condition.Status, condition.Reason) <del> if podutil.UpdatePodCondition(&pod.Status, condition) { _, err := p.Client.CoreV1().Pods(pod.Namespace).UpdateStatus(context.TODO(), pod, metav1.UpdateOptions{}) </del> <ins> oldData, err := json.Marshal(pod) if err != nil { </ins> return err } <del> return nil </del> <ins> if !podutil.UpdatePodCondition(&pod.Status, condition) { return nil } newData, err := json.Marshal(pod) if err != nil { return err } patchBytes, err := strategicpatch.CreateTwoWayMergePatch(oldData, newData, &v1.Pod{}) if err != nil { return fmt.Errorf(\"failed to create merge patch for pod %q/%q: %v\", pod.Namespace, pod.Name, err) } _, err = p.Client.CoreV1().Pods(pod.Namespace).Patch(context.TODO(), pod.Name, types.StrategicMergePatchType, patchBytes, metav1.PatchOptions{}, \"status\") return err </ins> } type podPreemptorImpl struct {", "commid": "kubernetes_pr_90978"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f207c102634d5fe622f73c0749707049f74cd1865ef73e2bb5f934cd8861b8b", "query": "Which jobs are flaking: pull-kubernetes-integration Which test(s) are flaking: TestNominatedNodeCleanUp Testgrid link: Reason for failure: /sig scheduling\n/assign\nany progress on this one?\nI was working on it and tried to find the root cause. I will give my solution within this week\nAnother one\nStill happening cc\n/assign\n/close dupe\nClosing this issue. <detailsIn response to : /close dupe Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-0db79fc88a2cafc81468140ddda0f15a2ecefff9724a6ef741bf11ca2d9b6fe4", "text": "} func (p *podPreemptorImpl) setNominatedNodeName(pod *v1.Pod, nominatedNodeName string) error { <ins> klog.V(3).Infof(\"Setting nominated node name for %s/%s to \"%s\"\", pod.Namespace, pod.Name, nominatedNodeName) if pod.Status.NominatedNodeName == nominatedNodeName { return nil } </ins> podCopy := pod.DeepCopy() <ins> oldData, err := json.Marshal(podCopy) if err != nil { return err } </ins> podCopy.Status.NominatedNodeName = nominatedNodeName <del> _, err := p.Client.CoreV1().Pods(pod.Namespace).UpdateStatus(context.TODO(), podCopy, metav1.UpdateOptions{}) </del> <ins> newData, err := json.Marshal(podCopy) if err != nil { return err } patchBytes, err := strategicpatch.CreateTwoWayMergePatch(oldData, newData, &v1.Pod{}) if err != nil { return fmt.Errorf(\"failed to create merge patch for pod %q/%q: %v\", pod.Namespace, pod.Name, err) } _, err = p.Client.CoreV1().Pods(pod.Namespace).Patch(context.TODO(), pod.Name, types.StrategicMergePatchType, patchBytes, metav1.PatchOptions{}, \"status\") </ins> return err }", "commid": "kubernetes_pr_90978"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f207c102634d5fe622f73c0749707049f74cd1865ef73e2bb5f934cd8861b8b", "query": "Which jobs are flaking: pull-kubernetes-integration Which test(s) are flaking: TestNominatedNodeCleanUp Testgrid link: Reason for failure: /sig scheduling\n/assign\nany progress on this one?\nI was working on it and tried to find the root cause. I will give my solution within this week\nAnother one\nStill happening cc\n/assign\n/close dupe\nClosing this issue. <detailsIn response to : /close dupe Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-fa87e7900f5577d412c0eb651bfc572f025957916ed4f4f846df0f9bb36ef4fa", "text": "\"os\" \"path\" \"reflect\" <ins> \"regexp\" </ins> \"sort\" \"strings\" \"sync\"", "commid": "kubernetes_pr_90978"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f207c102634d5fe622f73c0749707049f74cd1865ef73e2bb5f934cd8861b8b", "query": "Which jobs are flaking: pull-kubernetes-integration Which test(s) are flaking: TestNominatedNodeCleanUp Testgrid link: Reason for failure: /sig scheduling\n/assign\nany progress on this one?\nI was working on it and tried to find the root cause. I will give my solution within this week\nAnother one\nStill happening cc\n/assign\n/close dupe\nClosing this issue. <detailsIn response to : /close dupe Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-d083f3aae93c17570b32f7e948993041c5a63a43f49aa1f3c92d95bf2eb92246", "text": "} } } <ins> func TestSetNominatedNodeName(t *testing.T) { tests := []struct { name                     string currentNominatedNodeName string newNominatedNodeName     string expectedPatchRequests    int expectedPatchData        string }{ { name:                     \"Should make patch request to set node name\", currentNominatedNodeName: \"\", newNominatedNodeName:     \"node1\", expectedPatchRequests:    1, expectedPatchData:        `{\"status\":{\"nominatedNodeName\":\"node1\"}}`, }, { name:                     \"Should make patch request to clear node name\", currentNominatedNodeName: \"node1\", newNominatedNodeName:     \"\", expectedPatchRequests:    1, expectedPatchData:        `{\"status\":{\"nominatedNodeName\":null}}`, }, { name:                     \"Should not make patch request if nominated node is already set to the specified value\", currentNominatedNodeName: \"node1\", newNominatedNodeName:     \"node1\", expectedPatchRequests:    0, }, { name:                     \"Should not make patch request if nominated node is already cleared\", currentNominatedNodeName: \"\", newNominatedNodeName:     \"\", expectedPatchRequests:    0, }, } for _, test := range tests { t.Run(test.name, func(t *testing.T) { actualPatchRequests := 0 var actualPatchData string cs := &clientsetfake.Clientset{} cs.AddReactor(\"patch\", \"pods\", func(action clienttesting.Action) (bool, runtime.Object, error) { actualPatchRequests++ patch := action.(clienttesting.PatchAction) actualPatchData = string(patch.GetPatch()) // For this test, we don't care about the result of the patched pod, just that we got the expected // patch request, so just returning &v1.Pod{} here is OK because scheduler doesn't use the response. return true, &v1.Pod{}, nil }) pod := &v1.Pod{ ObjectMeta: metav1.ObjectMeta{Name: \"foo\"}, Status:     v1.PodStatus{NominatedNodeName: test.currentNominatedNodeName}, } preemptor := &podPreemptorImpl{Client: cs} if err := preemptor.setNominatedNodeName(pod, test.newNominatedNodeName); err != nil { t.Fatalf(\"Error calling setNominatedNodeName: %v\", err) } if actualPatchRequests != test.expectedPatchRequests { t.Fatalf(\"Actual patch requests (%d) dos not equal expected patch requests (%d)\", actualPatchRequests, test.expectedPatchRequests) } if test.expectedPatchRequests > 0 && actualPatchData != test.expectedPatchData { t.Fatalf(\"Patch data mismatch: Actual was %v, but expected %v\", actualPatchData, test.expectedPatchData) } }) } } func TestUpdatePodCondition(t *testing.T) { tests := []struct { name                     string currentPodConditions     []v1.PodCondition newPodCondition          *v1.PodCondition expectedPatchRequests    int expectedPatchDataPattern string }{ { name:                 \"Should make patch request to add pod condition when there are none currently\", currentPodConditions: []v1.PodCondition{}, newPodCondition: &v1.PodCondition{ Type:               \"newType\", Status:             \"newStatus\", LastProbeTime:      metav1.NewTime(time.Date(2020, 5, 13, 1, 1, 1, 1, time.UTC)), LastTransitionTime: metav1.NewTime(time.Date(2020, 5, 12, 1, 1, 1, 1, time.UTC)), Reason:             \"newReason\", Message:            \"newMessage\", }, expectedPatchRequests:    1, expectedPatchDataPattern: `{\"status\":{\"conditions\":[{\"lastProbeTime\":\"2020-05-13T01:01:01Z\",\"lastTransitionTime\":\".*\",\"message\":\"newMessage\",\"reason\":\"newReason\",\"status\":\"newStatus\",\"type\":\"newType\"}]}}`, }, { name: \"Should make patch request to add a new pod condition when there is already one with another type\", currentPodConditions: []v1.PodCondition{ { Type:               \"someOtherType\", Status:             \"someOtherTypeStatus\", LastProbeTime:      metav1.NewTime(time.Date(2020, 5, 11, 0, 0, 0, 0, time.UTC)), LastTransitionTime: metav1.NewTime(time.Date(2020, 5, 10, 0, 0, 0, 0, time.UTC)), Reason:             \"someOtherTypeReason\", Message:            \"someOtherTypeMessage\", }, }, newPodCondition: &v1.PodCondition{ Type:               \"newType\", Status:             \"newStatus\", LastProbeTime:      metav1.NewTime(time.Date(2020, 5, 13, 1, 1, 1, 1, time.UTC)), LastTransitionTime: metav1.NewTime(time.Date(2020, 5, 12, 1, 1, 1, 1, time.UTC)), Reason:             \"newReason\", Message:            \"newMessage\", }, expectedPatchRequests:    1, expectedPatchDataPattern: `{\"status\":{\"$setElementOrder/conditions\":[{\"type\":\"someOtherType\"},{\"type\":\"newType\"}],\"conditions\":[{\"lastProbeTime\":\"2020-05-13T01:01:01Z\",\"lastTransitionTime\":\".*\",\"message\":\"newMessage\",\"reason\":\"newReason\",\"status\":\"newStatus\",\"type\":\"newType\"}]}}`, }, { name: \"Should make patch request to update an existing pod condition\", currentPodConditions: []v1.PodCondition{ { Type:               \"currentType\", Status:             \"currentStatus\", LastProbeTime:      metav1.NewTime(time.Date(2020, 5, 13, 0, 0, 0, 0, time.UTC)), LastTransitionTime: metav1.NewTime(time.Date(2020, 5, 12, 0, 0, 0, 0, time.UTC)), Reason:             \"currentReason\", Message:            \"currentMessage\", }, }, newPodCondition: &v1.PodCondition{ Type:               \"currentType\", Status:             \"newStatus\", LastProbeTime:      metav1.NewTime(time.Date(2020, 5, 13, 1, 1, 1, 1, time.UTC)), LastTransitionTime: metav1.NewTime(time.Date(2020, 5, 12, 1, 1, 1, 1, time.UTC)), Reason:             \"newReason\", Message:            \"newMessage\", }, expectedPatchRequests:    1, expectedPatchDataPattern: `{\"status\":{\"$setElementOrder/conditions\":[{\"type\":\"currentType\"}],\"conditions\":[{\"lastProbeTime\":\"2020-05-13T01:01:01Z\",\"lastTransitionTime\":\".*\",\"message\":\"newMessage\",\"reason\":\"newReason\",\"status\":\"newStatus\",\"type\":\"currentType\"}]}}`, }, { name: \"Should make patch request to update an existing pod condition, but the transition time should remain unchanged because the status is the same\", currentPodConditions: []v1.PodCondition{ { Type:               \"currentType\", Status:             \"currentStatus\", LastProbeTime:      metav1.NewTime(time.Date(2020, 5, 13, 0, 0, 0, 0, time.UTC)), LastTransitionTime: metav1.NewTime(time.Date(2020, 5, 12, 0, 0, 0, 0, time.UTC)), Reason:             \"currentReason\", Message:            \"currentMessage\", }, }, newPodCondition: &v1.PodCondition{ Type:               \"currentType\", Status:             \"currentStatus\", LastProbeTime:      metav1.NewTime(time.Date(2020, 5, 13, 1, 1, 1, 1, time.UTC)), LastTransitionTime: metav1.NewTime(time.Date(2020, 5, 12, 0, 0, 0, 0, time.UTC)), Reason:             \"newReason\", Message:            \"newMessage\", }, expectedPatchRequests:    1, expectedPatchDataPattern: `{\"status\":{\"$setElementOrder/conditions\":[{\"type\":\"currentType\"}],\"conditions\":[{\"lastProbeTime\":\"2020-05-13T01:01:01Z\",\"message\":\"newMessage\",\"reason\":\"newReason\",\"type\":\"currentType\"}]}}`, }, { name: \"Should not make patch request if pod condition already exists and is identical\", currentPodConditions: []v1.PodCondition{ { Type:               \"currentType\", Status:             \"currentStatus\", LastProbeTime:      metav1.NewTime(time.Date(2020, 5, 13, 0, 0, 0, 0, time.UTC)), LastTransitionTime: metav1.NewTime(time.Date(2020, 5, 12, 0, 0, 0, 0, time.UTC)), Reason:             \"currentReason\", Message:            \"currentMessage\", }, }, newPodCondition: &v1.PodCondition{ Type:               \"currentType\", Status:             \"currentStatus\", LastProbeTime:      metav1.NewTime(time.Date(2020, 5, 13, 0, 0, 0, 0, time.UTC)), LastTransitionTime: metav1.NewTime(time.Date(2020, 5, 12, 0, 0, 0, 0, time.UTC)), Reason:             \"currentReason\", Message:            \"currentMessage\", }, expectedPatchRequests: 0, }, } for _, test := range tests { t.Run(test.name, func(t *testing.T) { actualPatchRequests := 0 var actualPatchData string cs := &clientsetfake.Clientset{} cs.AddReactor(\"patch\", \"pods\", func(action clienttesting.Action) (bool, runtime.Object, error) { actualPatchRequests++ patch := action.(clienttesting.PatchAction) actualPatchData = string(patch.GetPatch()) // For this test, we don't care about the result of the patched pod, just that we got the expected // patch request, so just returning &v1.Pod{} here is OK because scheduler doesn't use the response. return true, &v1.Pod{}, nil }) pod := &v1.Pod{ ObjectMeta: metav1.ObjectMeta{Name: \"foo\"}, Status:     v1.PodStatus{Conditions: test.currentPodConditions}, } updater := &podConditionUpdaterImpl{Client: cs} if err := updater.update(pod, test.newPodCondition); err != nil { t.Fatalf(\"Error calling update: %v\", err) } if actualPatchRequests != test.expectedPatchRequests { t.Fatalf(\"Actual patch requests (%d) dos not equal expected patch requests (%d)\", actualPatchRequests, test.expectedPatchRequests) } regex, err := regexp.Compile(test.expectedPatchDataPattern) if err != nil { t.Fatalf(\"Error compiling regexp for %v: %v\", test.expectedPatchDataPattern, err) } if test.expectedPatchRequests > 0 && !regex.MatchString(actualPatchData) { t.Fatalf(\"Patch data mismatch: Actual was %v, but expected to match regexp %v\", actualPatchData, test.expectedPatchDataPattern) } }) } } </ins>", "commid": "kubernetes_pr_90978"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f207c102634d5fe622f73c0749707049f74cd1865ef73e2bb5f934cd8861b8b", "query": "Which jobs are flaking: pull-kubernetes-integration Which test(s) are flaking: TestNominatedNodeCleanUp Testgrid link: Reason for failure: /sig scheduling\n/assign\nany progress on this one?\nI was working on it and tried to find the root cause. I will give my solution within this week\nAnother one\nStill happening cc\n/assign\n/close dupe\nClosing this issue. <detailsIn response to : /close dupe Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-7113a84af3e8f2361f4b1dabfd119c6bd3d5af2aaef05ff6cc9826fabb44528c", "text": "framework \"k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1\" \"k8s.io/kubernetes/plugin/pkg/admission/priority\" testutils \"k8s.io/kubernetes/test/integration/util\" <del> utils \"k8s.io/kubernetes/test/utils\" </del> <ins> \"k8s.io/kubernetes/test/utils\" </ins> ) var lowPriority, mediumPriority, highPriority = int32(100), int32(200), int32(300)", "commid": "kubernetes_pr_90978"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f207c102634d5fe622f73c0749707049f74cd1865ef73e2bb5f934cd8861b8b", "query": "Which jobs are flaking: pull-kubernetes-integration Which test(s) are flaking: TestNominatedNodeCleanUp Testgrid link: Reason for failure: /sig scheduling\n/assign\nany progress on this one?\nI was working on it and tried to find the root cause. I will give my solution within this week\nAnother one\nStill happening cc\n/assign\n/close dupe\nClosing this issue. <detailsIn response to : /close dupe Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-9fa550cd56fde647acbbcfbeb7366ed71712a79662357b6cca53816054735678", "text": "Labels:    map[string]string{\"pod\": name}, Resources: defaultPodRes, }) <del> // Setting grace period to zero. Otherwise, we may never see the actual deletion // of the pods in integration tests. </del> pod.Spec.TerminationGracePeriodSeconds = &grace return pod }", "commid": "kubernetes_pr_90978"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7f207c102634d5fe622f73c0749707049f74cd1865ef73e2bb5f934cd8861b8b", "query": "Which jobs are flaking: pull-kubernetes-integration Which test(s) are flaking: TestNominatedNodeCleanUp Testgrid link: Reason for failure: /sig scheduling\n/assign\nany progress on this one?\nI was working on it and tried to find the root cause. I will give my solution within this week\nAnother one\nStill happening cc\n/assign\n/close dupe\nClosing this issue. <detailsIn response to : /close dupe Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-642f052f0cb8b16a19f242af429fd44cb2fab6253c6182082b191fd33cf9738d", "text": "} // Step 5. Check that nominated node name of the high priority pod is set. if err := waitForNominatedNodeName(cs, highPriPod); err != nil { <del> t.Errorf(\"NominatedNodeName annotation was not set for pod %v/%v: %v\", medPriPod.Namespace, medPriPod.Name, err) </del> <ins> t.Errorf(\"NominatedNodeName annotation was not set for pod %v/%v: %v\", highPriPod.Namespace, highPriPod.Name, err) </ins> } // And the nominated node name of the medium priority pod is cleared. if err := wait.Poll(100*time.Millisecond, wait.ForeverTestTimeout, func() (bool, error) {", "commid": "kubernetes_pr_90978"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a166ddd65322b2b4c2d8cbe35891249f4d033568413f3b77fc1f46ee1d1ee8b8", "query": "/kind cleanup /sig storage /sig node Description: Feature gate VolumeSubpathEnvExpansion was GA in 1.17 and is marked for removal in 1.19 Related Issues: GA Release:\n/assign\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-3e708e0786301606b2891ccc96a71d9fb3cf156b4bfd5e8f74ffeb0840ddfc86", "text": "podSpec.EphemeralContainers = nil } <del> if (!utilfeature.DefaultFeatureGate.Enabled(features.VolumeSubpath) || !utilfeature.DefaultFeatureGate.Enabled(features.VolumeSubpathEnvExpansion)) && !subpathExprInUse(oldPodSpec) { // drop subpath env expansion from the pod if either of the subpath features is disabled and the old spec did not specify subpath env expansion </del> <ins> if !utilfeature.DefaultFeatureGate.Enabled(features.VolumeSubpath) && !subpathExprInUse(oldPodSpec) { // drop subpath env expansion from the pod if subpath feature is disabled and the old spec did not specify subpath env expansion </ins> VisitContainers(podSpec, AllContainers, func(c *api.Container, containerType ContainerType) bool { for i := range c.VolumeMounts { c.VolumeMounts[i].SubPathExpr = \"\"", "commid": "kubernetes_pr_89584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a166ddd65322b2b4c2d8cbe35891249f4d033568413f3b77fc1f46ee1d1ee8b8", "query": "/kind cleanup /sig storage /sig node Description: Feature gate VolumeSubpathEnvExpansion was GA in 1.17 and is marked for removal in 1.19 Related Issues: GA Release:\n/assign\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-021f53738c2b4ca56970222e0a3c72d68689504e7dbac9188a359ffba5b32a2b", "text": "} t.Run(fmt.Sprintf(\"feature enabled=%v, old pod %v, new pod %v\", enabled, oldPodInfo.description, newPodInfo.description), func(t *testing.T) { <del> defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.VolumeSubpathEnvExpansion, enabled)() </del> var oldPodSpec *api.PodSpec if oldPod != nil {", "commid": "kubernetes_pr_89584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a166ddd65322b2b4c2d8cbe35891249f4d033568413f3b77fc1f46ee1d1ee8b8", "query": "/kind cleanup /sig storage /sig node Description: Feature gate VolumeSubpathEnvExpansion was GA in 1.17 and is marked for removal in 1.19 Related Issues: GA Release:\n/assign\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-452a706cf53cc356105437790e5016c3d926759c016b802b4f1ebe760dd770f7", "text": "} func TestValidateSubpathMutuallyExclusive(t *testing.T) { <del> // Enable feature VolumeSubpathEnvExpansion and VolumeSubpath defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.VolumeSubpathEnvExpansion, true)() </del> <ins> // Enable feature VolumeSubpath </ins> defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.VolumeSubpath, true)() volumes := []core.Volume{", "commid": "kubernetes_pr_89584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a166ddd65322b2b4c2d8cbe35891249f4d033568413f3b77fc1f46ee1d1ee8b8", "query": "/kind cleanup /sig storage /sig node Description: Feature gate VolumeSubpathEnvExpansion was GA in 1.17 and is marked for removal in 1.19 Related Issues: GA Release:\n/assign\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-cf2ba9a1038c82b0b72a2ac59a6f288d78e28e5a1c8c5462d890dee115dbe1ec", "text": "} func TestValidateDisabledSubpathExpr(t *testing.T) { <del> // Enable feature VolumeSubpathEnvExpansion defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.VolumeSubpathEnvExpansion, true)() </del> volumes := []core.Volume{ {Name: \"abc\", VolumeSource: core.VolumeSource{PersistentVolumeClaim: &core.PersistentVolumeClaimVolumeSource{ClaimName: \"testclaim1\"}}},", "commid": "kubernetes_pr_89584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a166ddd65322b2b4c2d8cbe35891249f4d033568413f3b77fc1f46ee1d1ee8b8", "query": "/kind cleanup /sig storage /sig node Description: Feature gate VolumeSubpathEnvExpansion was GA in 1.17 and is marked for removal in 1.19 Related Issues: GA Release:\n/assign\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-17dfa8b63183135c62429b65a3ff62c93a116978ac68f015b9192b8735715001", "text": "// while making decisions. BalanceAttachedNodeVolumes featuregate.Feature = \"BalanceAttachedNodeVolumes\" <del> // owner: @kevtaylor // alpha: v1.14 // beta: v1.15 // ga: v1.17 // // Allow subpath environment variable substitution // Only applicable if the VolumeSubpath feature is also enabled VolumeSubpathEnvExpansion featuregate.Feature = \"VolumeSubpathEnvExpansion\" </del> // owner: @vladimirvivien // alpha: v1.11 // beta:  v1.14", "commid": "kubernetes_pr_89584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a166ddd65322b2b4c2d8cbe35891249f4d033568413f3b77fc1f46ee1d1ee8b8", "query": "/kind cleanup /sig storage /sig node Description: Feature gate VolumeSubpathEnvExpansion was GA in 1.17 and is marked for removal in 1.19 Related Issues: GA Release:\n/assign\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-bbd8cb150cf000f93af2cb1d30f843b55174d1adbdd850d35819aa46d1236c09", "text": "VolumeSubpath:                  {Default: true, PreRelease: featuregate.GA}, ConfigurableFSGroupPolicy:      {Default: false, PreRelease: featuregate.Alpha}, BalanceAttachedNodeVolumes:     {Default: false, PreRelease: featuregate.Alpha}, <del> VolumeSubpathEnvExpansion:      {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.19, </del> CSIBlockVolume:                 {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20 CSIInlineVolume:                {Default: true, PreRelease: featuregate.Beta}, RuntimeClass:                   {Default: true, PreRelease: featuregate.Beta},", "commid": "kubernetes_pr_89584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a166ddd65322b2b4c2d8cbe35891249f4d033568413f3b77fc1f46ee1d1ee8b8", "query": "/kind cleanup /sig storage /sig node Description: Feature gate VolumeSubpathEnvExpansion was GA in 1.17 and is marked for removal in 1.19 Related Issues: GA Release:\n/assign\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-113aeead39e8af4504fecb1c2529c94203bfbe9d643650eedefa712e4e83d1f5", "text": "return nil, cleanupAction, fmt.Errorf(\"volume subpaths are disabled\") } <del> if !utilfeature.DefaultFeatureGate.Enabled(features.VolumeSubpathEnvExpansion) { return nil, cleanupAction, fmt.Errorf(\"volume subpath expansion is disabled\") } </del> subPath, err = kubecontainer.ExpandContainerVolumeMounts(mount, expandEnvs) if err != nil {", "commid": "kubernetes_pr_89584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4d425eb67b342ad1bffa32583e9ce70b5b7f385bf982ed87181deda55eeafb05", "query": "When using the package, one can easily add a flag to a CLI tool. However, the output of invocation with is hard-coded to . As such, the package is not very usable in non-Kubernetes projects. /wg component-standard /assign", "positive_passages": [{"docid": "doc-en-kubernetes-5154883151e32e437f6fdfde58697009998e3f68950f68a11609cb30ebceccdc", "text": "var ( versionFlag = Version(versionFlagName, VersionFalse, \"Print version information and quit\") <ins> programName = \"Kubernetes\" </ins> ) // AddFlags registers this package's flags on arbitrary FlagSets, such that they point to the", "commid": "kubernetes_pr_90139"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4d425eb67b342ad1bffa32583e9ce70b5b7f385bf982ed87181deda55eeafb05", "query": "When using the package, one can easily add a flag to a CLI tool. However, the output of invocation with is hard-coded to . As such, the package is not very usable in non-Kubernetes projects. /wg component-standard /assign", "positive_passages": [{"docid": "doc-en-kubernetes-96b3b8aa8f19305a76ed9386fe361906db382f7cf14d9bf7390bea79042b4793", "text": "fmt.Printf(\"%#vn\", version.Get()) os.Exit(0) } else if *versionFlag == VersionTrue { <del> fmt.Printf(\"Kubernetes %sn\", version.Get()) </del> <ins> fmt.Printf(\"%s %sn\", programName, version.Get()) </ins> os.Exit(0) } }", "commid": "kubernetes_pr_90139"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-82438b7d3ab1a91c738ff981f5a7edec77d479950cb2b6233ab4c9b673847adb", "query": "What happened: there are many kubelet warnings in the systemd logs I initialized the cluster with kubeadm init (no modifications) What you expected to happen: Not to have that many kubelet warnings in the system logs Anything else we need to know?: Environment: Kubernetes version (use kubectl version):Cloud provider or hardware configuration:OS (e.g: cat /etc/os-release):Kernel (e.g. uname -a):Install tools:\nI have the same issue\nshould add a option or an annotationo to resolve this /sig node /area kubelet\nSame issue kops, kubernetes 1.18.3, aws cloudprovider\nSame issue on v1.17.4 installed with rancher\nSame issue on v1.18.0 ~\nSame issue on 1.17.6\nHappens on v1.18.3 as well. This issue only occurs when container has some fsGroup set in its securityContext AND volume being mounted is either secret or a configmap. I guess they are being re-mounted every 70s or so. It's okay when the volume being mounted is a standard PV - log only appears once and doesn't get repeated.\nI'm seeing the same issue. I'm willing to fix it.\nI've digged into this a little bit further. I believe this is just a annoying warning message. AFAICS, it does not show any issue... I was reading the kubelet, its volume manager and the volume plugins source files. It seems that's the expected behavior. The desiredStateOfWorldPopulator sync loop always call the . The finds the volume plugin and check if the plugin requires mount. Secret plugin, wich is the plugin in discussion, always returns . Thus, the of the volume manager remounts the volume every time. I think the problem is in the which prints the warning message. It's more and I believe it does not take these plugins into account. The secret plugin is as it is now since . Is that make sense to you?\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-258d6152845ba33e836c22f06d734ee3fc8cd4e62ccee8fa8b5fc811993015f5", "text": "\"syscall\" \"os\" <ins> \"time\" </ins> v1 \"k8s.io/api/core/v1\" utilfeature \"k8s.io/apiserver/pkg/util/feature\"", "commid": "kubernetes_pr_92878"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-82438b7d3ab1a91c738ff981f5a7edec77d479950cb2b6233ab4c9b673847adb", "query": "What happened: there are many kubelet warnings in the systemd logs I initialized the cluster with kubeadm init (no modifications) What you expected to happen: Not to have that many kubelet warnings in the system logs Anything else we need to know?: Environment: Kubernetes version (use kubectl version):Cloud provider or hardware configuration:OS (e.g: cat /etc/os-release):Kernel (e.g. uname -a):Install tools:\nI have the same issue\nshould add a option or an annotationo to resolve this /sig node /area kubelet\nSame issue kops, kubernetes 1.18.3, aws cloudprovider\nSame issue on v1.17.4 installed with rancher\nSame issue on v1.18.0 ~\nSame issue on 1.17.6\nHappens on v1.18.3 as well. This issue only occurs when container has some fsGroup set in its securityContext AND volume being mounted is either secret or a configmap. I guess they are being re-mounted every 70s or so. It's okay when the volume being mounted is a standard PV - log only appears once and doesn't get repeated.\nI'm seeing the same issue. I'm willing to fix it.\nI've digged into this a little bit further. I believe this is just a annoying warning message. AFAICS, it does not show any issue... I was reading the kubelet, its volume manager and the volume plugins source files. It seems that's the expected behavior. The desiredStateOfWorldPopulator sync loop always call the . The finds the volume plugin and check if the plugin requires mount. Secret plugin, wich is the plugin in discussion, always returns . Thus, the of the volume manager remounts the volume every time. I think the problem is in the which prints the warning message. It's more and I believe it does not take these plugins into account. The secret plugin is as it is now since . Is that make sense to you?\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-3087642969987a4b3ac6acee5bdca1719265f718657ea273a3d111c0982977ba", "text": "fsGroupPolicyEnabled := utilfeature.DefaultFeatureGate.Enabled(features.ConfigurableFSGroupPolicy) <del> klog.Warningf(\"Setting volume ownership for %s and fsGroup set. If the volume has a lot of files then setting volume ownership could be slow, see https://github.com/kubernetes/kubernetes/issues/69699\", mounter.GetPath()) </del> <ins> timer := time.AfterFunc(30*time.Second, func() { klog.Warningf(\"Setting volume ownership for %s and fsGroup set. If the volume has a lot of files then setting volume ownership could be slow, see https://github.com/kubernetes/kubernetes/issues/69699\", mounter.GetPath()) }) defer timer.Stop() </ins> // This code exists for legacy purposes, so as old behaviour is entirely preserved when feature gate is disabled // TODO: remove this when ConfigurableFSGroupPolicy turns GA.", "commid": "kubernetes_pr_92878"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6ef31dc84da87e31587c45884e44fac62afa58423be65897f264bf2a209b64be", "query": "What happened: Pods get stuck in terminating state, as kubelet failed to unmount volume: nodev on /var/lib/kubelet/pods/-120c-45c4-aeac- type hugetlbfs (rw,relatime,pagesize=2Mi) What you expected to happen: Pod to get deleted and volumes to be cleaned up. How to reproduce it (as minimally and precisely as possible): kvm based virtual machines on ubuntu 16.04. create a pod with hugepage volumes () Delete the pod. Anything else we need to know?: Changes are related to mentioned commit id: In this file : , line no 72 : pageSize, err := resource.ParseQuantity(strings.TrimPrefix(opt, prefix) + \"i\") The mount already has a pagesize 2Mi in my case as shown here : (rw,relatime,pagesize=2Mi) But the code here suffix/appends \"i\" assuming pagesize can be only of type 2M or 1024M resulting in failure to clean up this volume. Documentation from code: / NOTE: Adding suffix 'i' as result should be comparable with a medium size. // pagesize mount option is specified without a suffix, // e.g. pagesize=2M or pagesize=1024M for x86 CPUs pageSize, err := resource.ParseQuantity(strings.TrimPrefix(opt, prefix) + \"i\") if err != nil { return nil, fmt.Errorf(\"error getting page size from '%s' mount option: %v\", opt, err) } when the pod is deployed, kubelet creates the mount and we can see from logs that it already has pagesize=2Mi for my environment. Environment: Kubernetes version: kubectl version Client Version: version.Info{Major:\"1\", Minor:\"18\", GitVersion:\"v1.18.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2020-03-25T14:58:59Z\", GoVersion:\"go1.13.8\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"18\", GitVersion:\"v1.18.2\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2020-04-16T11:48:36Z\", GoVersion:\"go1.13.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Kvm hypervisor based virual machine setupOS (e.g: ): NAME=\"Ubuntu\" VERSION=\"16.04.6 LTS (Xenial Xerus)\" ID=ubuntu IDLIKE=debian PRETTYNAME=\"Ubuntu 16.04.6 LTS\" VERSIONID=\"16.04\" HOMEURL=\"\" SUPPORTURL=\"\" BUGREPORTURL=\"\" VERSIONCODENAME=xenial UBUNTUCODENAME=xenial Kernel (e.g. ): Linux master 4.4.0-169-generic -Ubuntu SMP Tue Nov 12 10:38:00 UTC 2019 x8664 x8664 x8664 GNU/LinuxInstall tools: Network plugin and version (if this is a network-related bug): Others:\n/assign bart0sh\n/sig storage\nWhat about this change ?\nThe change looks good to me. Would you be willing to submit a PR?\n& : Thanks for the quick turnaround.\nWe are seeing this issue in 1.18.6 version, can you please push the fix to this branch as well.\nCould we know when the problem was introduced? As I suppose we don't have the same issue with K8S 1.17.x release?\nHi same issue found in 1.18.2\nIt is not yet ported into v1.18.6 as well.\nCan you submit your PR for release-1.18 branch?", "positive_passages": [{"docid": "doc-en-kubernetes-6af6c8b320510f096283b30fecd3040a7522030eaaf7d63f61cc56ac7c03e528", "text": "// NOTE: Adding suffix 'i' as result should be comparable with a medium size. // pagesize mount option is specified without a suffix, // e.g. pagesize=2M or pagesize=1024M for x86 CPUs <del> pageSize, err := resource.ParseQuantity(strings.TrimPrefix(opt, prefix) + \"i\") </del> <ins> trimmedOpt := strings.TrimPrefix(opt, prefix) if !strings.HasSuffix(trimmedOpt, \"i\") { trimmedOpt = trimmedOpt + \"i\" } pageSize, err := resource.ParseQuantity(trimmedOpt) </ins> if err != nil { return nil, fmt.Errorf(\"error getting page size from '%s' mount option: %v\", opt, err) }", "commid": "kubernetes_pr_90897"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6ef31dc84da87e31587c45884e44fac62afa58423be65897f264bf2a209b64be", "query": "What happened: Pods get stuck in terminating state, as kubelet failed to unmount volume: nodev on /var/lib/kubelet/pods/-120c-45c4-aeac- type hugetlbfs (rw,relatime,pagesize=2Mi) What you expected to happen: Pod to get deleted and volumes to be cleaned up. How to reproduce it (as minimally and precisely as possible): kvm based virtual machines on ubuntu 16.04. create a pod with hugepage volumes () Delete the pod. Anything else we need to know?: Changes are related to mentioned commit id: In this file : , line no 72 : pageSize, err := resource.ParseQuantity(strings.TrimPrefix(opt, prefix) + \"i\") The mount already has a pagesize 2Mi in my case as shown here : (rw,relatime,pagesize=2Mi) But the code here suffix/appends \"i\" assuming pagesize can be only of type 2M or 1024M resulting in failure to clean up this volume. Documentation from code: / NOTE: Adding suffix 'i' as result should be comparable with a medium size. // pagesize mount option is specified without a suffix, // e.g. pagesize=2M or pagesize=1024M for x86 CPUs pageSize, err := resource.ParseQuantity(strings.TrimPrefix(opt, prefix) + \"i\") if err != nil { return nil, fmt.Errorf(\"error getting page size from '%s' mount option: %v\", opt, err) } when the pod is deployed, kubelet creates the mount and we can see from logs that it already has pagesize=2Mi for my environment. Environment: Kubernetes version: kubectl version Client Version: version.Info{Major:\"1\", Minor:\"18\", GitVersion:\"v1.18.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2020-03-25T14:58:59Z\", GoVersion:\"go1.13.8\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"18\", GitVersion:\"v1.18.2\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2020-04-16T11:48:36Z\", GoVersion:\"go1.13.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} Cloud provider or hardware configuration: Kvm hypervisor based virual machine setupOS (e.g: ): NAME=\"Ubuntu\" VERSION=\"16.04.6 LTS (Xenial Xerus)\" ID=ubuntu IDLIKE=debian PRETTYNAME=\"Ubuntu 16.04.6 LTS\" VERSIONID=\"16.04\" HOMEURL=\"\" SUPPORTURL=\"\" BUGREPORTURL=\"\" VERSIONCODENAME=xenial UBUNTUCODENAME=xenial Kernel (e.g. ): Linux master 4.4.0-169-generic -Ubuntu SMP Tue Nov 12 10:38:00 UTC 2019 x8664 x8664 x8664 GNU/LinuxInstall tools: Network plugin and version (if this is a network-related bug): Others:\n/assign bart0sh\n/sig storage\nWhat about this change ?\nThe change looks good to me. Would you be willing to submit a PR?\n& : Thanks for the quick turnaround.\nWe are seeing this issue in 1.18.6 version, can you please push the fix to this branch as well.\nCould we know when the problem was introduced? As I suppose we don't have the same issue with K8S 1.17.x release?\nHi same issue found in 1.18.2\nIt is not yet ported into v1.18.6 as well.\nCan you submit your PR for release-1.18 branch?", "positive_passages": [{"docid": "doc-en-kubernetes-727324fd90255ab3a214966b71e41f96d2d25f58ce6c6c858b33b237f9a87db1", "text": "Opts:   []string{\"rw\", \"relatime\", \"pagesize=2M\"}, }, { <ins> Device: \"/dev/hugepages\", Type:   \"hugetlbfs\", Path:   \"/mnt/hugepages-2Mi\", Opts:   []string{\"rw\", \"relatime\", \"pagesize=2Mi\"}, }, { </ins> Device: \"sysfs\", Type:   \"sysfs\", Path:   \"/sys\",", "commid": "kubernetes_pr_90897"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0fc661983815db7faba77c39fd6b3524bd9cdac0d42845f086e33294e3a9b733", "query": "Currently we don't have an easy way of determining what number of requests are apiserver self-requests. This has historically bitten us, since we used to have a 50(?) QPS limit on apiserver self-requests (which thus has been removed). Even so, it would be a good idea to know this generally, since this may be helpful in pinpointing performance regressions for apiserver. /sig api-machinery instrumentation\nCan this issue be considered a newbie one? I'm hunting for issues which might be a good first PR.\nIn the triage meeting was mentioned that would be good to have similar issues to track other well known actors like controller-manager and kubelet. But let's keep this one for api-server calling itself to have it done. /cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-ee26942c125e2e577fea779aea767c1dbe3402fa6ebbc440ec1198c2d9c6fdd8", "text": "\"//staging/src/k8s.io/apimachinery/pkg/types:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library\", \"//staging/src/k8s.io/apiserver/pkg/audit:go_default_library\", <ins> \"//staging/src/k8s.io/apiserver/pkg/authentication/user:go_default_library\", </ins> \"//staging/src/k8s.io/apiserver/pkg/endpoints/request:go_default_library\", \"//staging/src/k8s.io/apiserver/pkg/features:go_default_library\", \"//staging/src/k8s.io/apiserver/pkg/util/feature:go_default_library\",", "commid": "kubernetes_pr_94288"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0fc661983815db7faba77c39fd6b3524bd9cdac0d42845f086e33294e3a9b733", "query": "Currently we don't have an easy way of determining what number of requests are apiserver self-requests. This has historically bitten us, since we used to have a 50(?) QPS limit on apiserver self-requests (which thus has been removed). Even so, it would be a good idea to know this generally, since this may be helpful in pinpointing performance regressions for apiserver. /sig api-machinery instrumentation\nCan this issue be considered a newbie one? I'm hunting for issues which might be a good first PR.\nIn the triage meeting was mentioned that would be good to have similar issues to track other well known actors like controller-manager and kubelet. But let's keep this one for api-server calling itself to have it done. /cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-fd07735b8e180817fb64a159cf6c33b71e64da17393dc78575f40b0ab4a0f6b0", "text": "\"k8s.io/apimachinery/pkg/types\" utilsets \"k8s.io/apimachinery/pkg/util/sets\" \"k8s.io/apiserver/pkg/audit\" <ins> \"k8s.io/apiserver/pkg/authentication/user\" </ins> \"k8s.io/apiserver/pkg/endpoints/request\" \"k8s.io/apiserver/pkg/features\" utilfeature \"k8s.io/apiserver/pkg/util/feature\"", "commid": "kubernetes_pr_94288"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0fc661983815db7faba77c39fd6b3524bd9cdac0d42845f086e33294e3a9b733", "query": "Currently we don't have an easy way of determining what number of requests are apiserver self-requests. This has historically bitten us, since we used to have a 50(?) QPS limit on apiserver self-requests (which thus has been removed). Even so, it would be a good idea to know this generally, since this may be helpful in pinpointing performance regressions for apiserver. /sig api-machinery instrumentation\nCan this issue be considered a newbie one? I'm hunting for issues which might be a good first PR.\nIn the triage meeting was mentioned that would be good to have similar issues to track other well known actors like controller-manager and kubelet. But let's keep this one for api-server calling itself to have it done. /cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-95074a2521f332feaa0089cc80ca032a405d42a8727b880f104623b2cd4f6ba6", "text": "}, []string{\"verb\", \"group\", \"version\", \"resource\", \"subresource\", \"scope\", \"component\", \"code\"}, ) <ins> apiSelfRequestCounter = compbasemetrics.NewCounterVec( &compbasemetrics.CounterOpts{ Name:           \"apiserver_selfrequest_total\", Help:           \"Counter of apiserver self-requests broken out for each verb, API resource and subresource.\", StabilityLevel: compbasemetrics.ALPHA, }, []string{\"verb\", \"resource\", \"subresource\"}, ) </ins> kubectlExeRegexp = regexp.MustCompile(`^.*((?i:kubectl.exe))`) metrics = []resettableCollector{", "commid": "kubernetes_pr_94288"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0fc661983815db7faba77c39fd6b3524bd9cdac0d42845f086e33294e3a9b733", "query": "Currently we don't have an easy way of determining what number of requests are apiserver self-requests. This has historically bitten us, since we used to have a 50(?) QPS limit on apiserver self-requests (which thus has been removed). Even so, it would be a good idea to know this generally, since this may be helpful in pinpointing performance regressions for apiserver. /sig api-machinery instrumentation\nCan this issue be considered a newbie one? I'm hunting for issues which might be a good first PR.\nIn the triage meeting was mentioned that would be good to have similar issues to track other well known actors like controller-manager and kubelet. But let's keep this one for api-server calling itself to have it done. /cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-ff67ff88265b275efc52277b668bd4b7edc21b30da155870dcbb30ee3e1399a1", "text": "currentInflightRequests, currentInqueueRequests, requestTerminationsTotal, <ins> apiSelfRequestCounter, </ins> } // these are the known (e.g. whitelisted/known) content types which we will report for", "commid": "kubernetes_pr_94288"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0fc661983815db7faba77c39fd6b3524bd9cdac0d42845f086e33294e3a9b733", "query": "Currently we don't have an easy way of determining what number of requests are apiserver self-requests. This has historically bitten us, since we used to have a 50(?) QPS limit on apiserver self-requests (which thus has been removed). Even so, it would be a good idea to know this generally, since this may be helpful in pinpointing performance regressions for apiserver. /sig api-machinery instrumentation\nCan this issue be considered a newbie one? I'm hunting for issues which might be a good first PR.\nIn the triage meeting was mentioned that would be good to have similar issues to track other well known actors like controller-manager and kubelet. But let's keep this one for api-server calling itself to have it done. /cc\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-553bb1fea3112e943434c5ebced1e8badc845d8a13c5617d6288a8ef231a7165", "text": "elapsedSeconds := elapsed.Seconds() cleanContentType := cleanContentType(contentType) requestCounter.WithLabelValues(reportedVerb, dryRun, group, version, resource, subresource, scope, component, cleanContentType, codeToString(httpCode)).Inc() <ins> // MonitorRequest happens after authentication, so we can trust the username given by the request info, ok := request.UserFrom(req.Context()) if ok && info.GetName() == user.APIServerUser { apiSelfRequestCounter.WithLabelValues(reportedVerb, resource, subresource).Inc() } </ins> if deprecated { deprecatedRequestGauge.WithLabelValues(group, version, resource, subresource, removedRelease).Set(1) audit.AddAuditAnnotation(req.Context(), deprecatedAnnotationKey, \"true\")", "commid": "kubernetes_pr_94288"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d3ce650be53c7e46a0ac0bcc623a0dec5f6925c142d33c15ed61fa9c7810444a", "query": "[x] Original approval issue: 09 July 2020 [x] Two weeks soak end date: 24 July 2020 This issue is created to allow edit by /wip /hold According to this APIsnoop query, there are still an endpoint which is untested. a set of 3 Pods with a static label within a Namespace. that all 3 Pods with the label in the Namespace are created. the set of Namespaced Pods with a label via DeleteCollection. that all Pods with the label have been deleted. Discover useragents: List endpoints hit by the test: Display endpoint coverage change: Two other endpoints tested here have tests in progress to conformance already. If a test with these calls gets merged, test coverage will go up by 1 points This test is also created with the goal of conformance promotion.\n/sig testing /sig architecture /area conformance\nDuring Conformance Meeting: Is there a way to write this test so it is resource agnostic? If we are just changing the resource... can be parameterize the resource-type\n/assign\nGitHub didn't allow me to assign the following users: heyste. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nTest to be created using \"Polling\" and not \"Watch tooling\"\n/reopen Merged Issue open, waiting for Promotion PR\nReopened this issue. <detailsIn response to : /reopen Merged Issue open, waiting for Promotion PR Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nThe test appears to be flaking, need to reach out to #sig-node for some feedback.\nCan you point us to the link of the flaky tests? Thanks!\nThe Promotion The testgrid Thank you!", "positive_passages": [{"docid": "doc-en-kubernetes-38f83b88b1f9d1b3a21fcfcc972cd64a3d672e8c36ef9f40fa2c0ffaa0ddb4bd", "text": "buildBackOffDuration = time.Minute syncLoopFrequency    = 10 * time.Second maxBackOffTolerance  = time.Duration(1.3 * float64(kubelet.MaxContainerBackOff)) <ins> podRetryPeriod       = 1 * time.Second podRetryTimeout      = 1 * time.Minute </ins> ) // testHostIP tests that a pod gets a host IP", "commid": "kubernetes_pr_92479"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d3ce650be53c7e46a0ac0bcc623a0dec5f6925c142d33c15ed61fa9c7810444a", "query": "[x] Original approval issue: 09 July 2020 [x] Two weeks soak end date: 24 July 2020 This issue is created to allow edit by /wip /hold According to this APIsnoop query, there are still an endpoint which is untested. a set of 3 Pods with a static label within a Namespace. that all 3 Pods with the label in the Namespace are created. the set of Namespaced Pods with a label via DeleteCollection. that all Pods with the label have been deleted. Discover useragents: List endpoints hit by the test: Display endpoint coverage change: Two other endpoints tested here have tests in progress to conformance already. If a test with these calls gets merged, test coverage will go up by 1 points This test is also created with the goal of conformance promotion.\n/sig testing /sig architecture /area conformance\nDuring Conformance Meeting: Is there a way to write this test so it is resource agnostic? If we are just changing the resource... can be parameterize the resource-type\n/assign\nGitHub didn't allow me to assign the following users: heyste. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nTest to be created using \"Polling\" and not \"Watch tooling\"\n/reopen Merged Issue open, waiting for Promotion PR\nReopened this issue. <detailsIn response to : /reopen Merged Issue open, waiting for Promotion PR Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nThe test appears to be flaking, need to reach out to #sig-node for some feedback.\nCan you point us to the link of the flaky tests? Thanks!\nThe Promotion The testgrid Thank you!", "positive_passages": [{"docid": "doc-en-kubernetes-11e064269755632799c90cdf5078418dc624d48638deb05bc93ae7204be98867", "text": "validatePodReadiness(false) }) <ins> ginkgo.It(\"should delete a collection of pods\", func() { podTestNames := []string{\"test-pod-1\", \"test-pod-2\", \"test-pod-3\"} ginkgo.By(\"Create set of pods\") // create a set of pods in test namespace for _, podTestName := range podTestNames { _, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(context.TODO(), &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: podTestName, Labels: map[string]string{ \"type\": \"Testing\"}, }, Spec: v1.PodSpec{ Containers: []v1.Container{{ Image: imageutils.GetE2EImage(imageutils.Agnhost), Name:  \"token-test\", }}, RestartPolicy: v1.RestartPolicyNever, }}, metav1.CreateOptions{}) framework.ExpectNoError(err, \"failed to create pod\") framework.Logf(\"created %v\", podTestName) } // wait as required for all 3 pods to be found ginkgo.By(\"waiting for all 3 pods to be located\") err := wait.PollImmediate(podRetryPeriod, podRetryTimeout, checkPodListQuantity(f, \"type=Testing\", 3)) framework.ExpectNoError(err, \"3 pods not found\") // delete Collection of pods with a label in the current namespace err = f.ClientSet.CoreV1().Pods(f.Namespace.Name).DeleteCollection(context.TODO(), metav1.DeleteOptions{}, metav1.ListOptions{ LabelSelector: \"type=Testing\"}) framework.ExpectNoError(err, \"failed to delete collection of pods\") // wait for all pods to be deleted ginkgo.By(\"waiting for all pods to be deleted\") err = wait.PollImmediate(podRetryPeriod, podRetryTimeout, checkPodListQuantity(f, \"type=Testing\", 0)) framework.ExpectNoError(err, \"found a pod(s)\") }) </ins> }) <ins> func checkPodListQuantity(f *framework.Framework, label string, quantity int) func() (bool, error) { return func() (bool, error) { var err error list, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).List(context.TODO(), metav1.ListOptions{ LabelSelector: label}) if err != nil { return false, err } if len(list.Items) != quantity { framework.Logf(\"Pod quantity %d is different from expected quantity %d\", len(list.Items), quantity) return false, err } return true, nil } } </ins>", "commid": "kubernetes_pr_92479"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d3ce650be53c7e46a0ac0bcc623a0dec5f6925c142d33c15ed61fa9c7810444a", "query": "[x] Original approval issue: 09 July 2020 [x] Two weeks soak end date: 24 July 2020 This issue is created to allow edit by /wip /hold According to this APIsnoop query, there are still an endpoint which is untested. a set of 3 Pods with a static label within a Namespace. that all 3 Pods with the label in the Namespace are created. the set of Namespaced Pods with a label via DeleteCollection. that all Pods with the label have been deleted. Discover useragents: List endpoints hit by the test: Display endpoint coverage change: Two other endpoints tested here have tests in progress to conformance already. If a test with these calls gets merged, test coverage will go up by 1 points This test is also created with the goal of conformance promotion.\n/sig testing /sig architecture /area conformance\nDuring Conformance Meeting: Is there a way to write this test so it is resource agnostic? If we are just changing the resource... can be parameterize the resource-type\n/assign\nGitHub didn't allow me to assign the following users: heyste. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nTest to be created using \"Polling\" and not \"Watch tooling\"\n/reopen Merged Issue open, waiting for Promotion PR\nReopened this issue. <detailsIn response to : /reopen Merged Issue open, waiting for Promotion PR Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nThe test appears to be flaking, need to reach out to #sig-node for some feedback.\nCan you point us to the link of the flaky tests? Thanks!\nThe Promotion The testgrid Thank you!", "positive_passages": [{"docid": "doc-en-kubernetes-a82d9b9a4d81e30cafa0437ea5a95d5f70da8e3eddb40246ee9d5722b110fb7c", "text": "and FOOSERVICE_PORT_8765_TCP_ADDR that are populated with proper values. release: v1.9 file: test/e2e/common/pods.go <ins> - testname: Pods, delete a collection codename: '[k8s.io] Pods should delete a collection of pods [Conformance]' description: A set of pods is created with a label selector which MUST be found when listed. The set of pods is deleted and MUST NOT show up when listed by its label selector. release: v1.19 file: test/e2e/common/pods.go </ins> - testname: Pods, assigned hostip codename: '[k8s.io] Pods should get a host IP [NodeConformance] [Conformance]' description: Create a Pod. Pod status MUST return successfully and contains a valid", "commid": "kubernetes_pr_93086"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d3ce650be53c7e46a0ac0bcc623a0dec5f6925c142d33c15ed61fa9c7810444a", "query": "[x] Original approval issue: 09 July 2020 [x] Two weeks soak end date: 24 July 2020 This issue is created to allow edit by /wip /hold According to this APIsnoop query, there are still an endpoint which is untested. a set of 3 Pods with a static label within a Namespace. that all 3 Pods with the label in the Namespace are created. the set of Namespaced Pods with a label via DeleteCollection. that all Pods with the label have been deleted. Discover useragents: List endpoints hit by the test: Display endpoint coverage change: Two other endpoints tested here have tests in progress to conformance already. If a test with these calls gets merged, test coverage will go up by 1 points This test is also created with the goal of conformance promotion.\n/sig testing /sig architecture /area conformance\nDuring Conformance Meeting: Is there a way to write this test so it is resource agnostic? If we are just changing the resource... can be parameterize the resource-type\n/assign\nGitHub didn't allow me to assign the following users: heyste. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nTest to be created using \"Polling\" and not \"Watch tooling\"\n/reopen Merged Issue open, waiting for Promotion PR\nReopened this issue. <detailsIn response to : /reopen Merged Issue open, waiting for Promotion PR Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nThe test appears to be flaking, need to reach out to #sig-node for some feedback.\nCan you point us to the link of the flaky tests? Thanks!\nThe Promotion The testgrid Thank you!", "positive_passages": [{"docid": "doc-en-kubernetes-32482c9fdbf4c1d2ed232b519d570fb4579d161e244e9dd0a180b062eb313f94", "text": "}) <del> ginkgo.It(\"should delete a collection of pods\", func() { </del> <ins> /* Release : v1.19 Testname: Pods, delete a collection Description: A set of pods is created with a label selector which MUST be found when listed. The set of pods is deleted and MUST NOT show up when listed by its label selector. */ framework.ConformanceIt(\"should delete a collection of pods\", func() { </ins> podTestNames := []string{\"test-pod-1\", \"test-pod-2\", \"test-pod-3\"} ginkgo.By(\"Create set of pods\")", "commid": "kubernetes_pr_93086"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-23c5335b00aca0eec51c917ea7725032775eef25c4e2b03a4a38794b0414d296", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Same symtoms as The detach is not successful until controller-manager is restarted controller-manager logs: What you expected to happen: The detach operation should know that a node is not active or its been deleted and should assume the disk is detached. How to reproduce it (as minimally and precisely as possible): This seems quite hard to reproduce, but we do run into it quite a few times where the pod is stuck in , because the controller-manager is unable to detach disks from deleted nodes. Anything else we need to know?: Environment: Kubernetes version (use ): v1.15.11 Cloud provider or hardware configuration: azure (self-managed) OS (e.g: ): Ubuntu 18.04.3 LTS Kernel (e.g. ): 5.0.0-1027-azure Install tools: kubeadm Network plugin and version (if this is a network-related bug): Others: /sig cloud-provider /area provider/azure paging\n/sig azure\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /sig azure Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig cloud-provider\n/area provider/azure\nhi have you done sth manually on the node? if node is deleted finally, the disk would be in unattached state finally, then disk attach to another node would succeed finally.\nas discussed offline, the issue is probably due to vmss instance compute name change(incorrect format: , correct format: ), user should not change vmss instance compute name, otherwise it would break disk attach/detach, since compute name is used in vmss node name passing, code is here:\nHi We don't change the instance compute name - however what i do see in the azure metadata service is in the form - What you're referring to seems to be the computer name, and we do use the defaults as provided by azure. See The attach/detach operations works fairly well most of the time, and I think we're running into some edge case here. One thing i might have missed out is the fact that there seems to have been an issue with the VM at the time. So the VM was present, but azure platform would return 400 bad request for a detach operation which probably led to this .. But when the VM was eventually deleted by the autoscaler, the re-attach was never attempted by the reconciler it would seem. and the last message about that disk was\nshould be a valid compute name according to , do you know why we define the format like this?\nThe function is used to get the name from IMDS, and its format is .\nFrom the above errors, seems the request has been sent to VMSS but failed because it's not active. Do you know the VM state during that time?\nI am not sure of the state at the time, but i believe the VM was in some kind of failed state. The VM has since been deleted, but we had errors on the scaleset at the time. The events on the VMSS look like this. The VM was eventually deleted by the autoscaler, but the disk was never re-attached to a different node, and the pod remained in for about 2 days until controller-manager was restarted.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nApparently we hit this issue today as a result of replacing the nodepool. We 2 new nodepools and deleted the old one, and now we have 718 of 1672 pods stuck with this error in one of our clusters. The volumes are failing to be attached to new pods, the VMSS for old nodepool is removed. In AKS portal disks are still reported to be attached to VM instances in the VMSS that was deleted. hundreds of pods are stuck in Init state won't likely go forward. /remove-lifecycle rotten\n/remove-lifecycle rotten\nI have seen similar issue when handling one customer's case, it's probably caused by broken vmss cluster, pls file a ticket to VMSS team to fix the issue.\nI happened to find this issue in one customer case, this issue is caused by obsolete cache in kube-controller-manager, should skip attach/detach retry when it's 400, below are the details, following two instances were deleted 3min ago before kube-controller-manager trying to attach/detach: workaround restart kube-controller-manager should work\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-736105b5935b462d42d1eb28b53af7fff1f0674ac283240d976d1fcd91aeb25a", "text": "errLeaseFailed       = \"AcquireDiskLeaseFailed\" errLeaseIDMissing    = \"LeaseIdMissing\" errContainerNotFound = \"ContainerNotFound\" <del> errDiskBlobNotFound  = \"DiskBlobNotFound\" </del> <ins> errStatusCode400     = \"statuscode=400\" errInvalidParameter  = `code=\"invalidparameter\"` errTargetInstanceIds = `target=\"instanceids\"` </ins> sourceSnapshot       = \"snapshot\" sourceVolume         = \"volume\"", "commid": "kubernetes_pr_95177"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-23c5335b00aca0eec51c917ea7725032775eef25c4e2b03a4a38794b0414d296", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Same symtoms as The detach is not successful until controller-manager is restarted controller-manager logs: What you expected to happen: The detach operation should know that a node is not active or its been deleted and should assume the disk is detached. How to reproduce it (as minimally and precisely as possible): This seems quite hard to reproduce, but we do run into it quite a few times where the pod is stuck in , because the controller-manager is unable to detach disks from deleted nodes. Anything else we need to know?: Environment: Kubernetes version (use ): v1.15.11 Cloud provider or hardware configuration: azure (self-managed) OS (e.g: ): Ubuntu 18.04.3 LTS Kernel (e.g. ): 5.0.0-1027-azure Install tools: kubeadm Network plugin and version (if this is a network-related bug): Others: /sig cloud-provider /area provider/azure paging\n/sig azure\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /sig azure Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig cloud-provider\n/area provider/azure\nhi have you done sth manually on the node? if node is deleted finally, the disk would be in unattached state finally, then disk attach to another node would succeed finally.\nas discussed offline, the issue is probably due to vmss instance compute name change(incorrect format: , correct format: ), user should not change vmss instance compute name, otherwise it would break disk attach/detach, since compute name is used in vmss node name passing, code is here:\nHi We don't change the instance compute name - however what i do see in the azure metadata service is in the form - What you're referring to seems to be the computer name, and we do use the defaults as provided by azure. See The attach/detach operations works fairly well most of the time, and I think we're running into some edge case here. One thing i might have missed out is the fact that there seems to have been an issue with the VM at the time. So the VM was present, but azure platform would return 400 bad request for a detach operation which probably led to this .. But when the VM was eventually deleted by the autoscaler, the re-attach was never attempted by the reconciler it would seem. and the last message about that disk was\nshould be a valid compute name according to , do you know why we define the format like this?\nThe function is used to get the name from IMDS, and its format is .\nFrom the above errors, seems the request has been sent to VMSS but failed because it's not active. Do you know the VM state during that time?\nI am not sure of the state at the time, but i believe the VM was in some kind of failed state. The VM has since been deleted, but we had errors on the scaleset at the time. The events on the VMSS look like this. The VM was eventually deleted by the autoscaler, but the disk was never re-attached to a different node, and the pod remained in for about 2 days until controller-manager was restarted.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nApparently we hit this issue today as a result of replacing the nodepool. We 2 new nodepools and deleted the old one, and now we have 718 of 1672 pods stuck with this error in one of our clusters. The volumes are failing to be attached to new pods, the VMSS for old nodepool is removed. In AKS portal disks are still reported to be attached to VM instances in the VMSS that was deleted. hundreds of pods are stuck in Init state won't likely go forward. /remove-lifecycle rotten\n/remove-lifecycle rotten\nI have seen similar issue when handling one customer's case, it's probably caused by broken vmss cluster, pls file a ticket to VMSS team to fix the issue.\nI happened to find this issue in one customer case, this issue is caused by obsolete cache in kube-controller-manager, should skip attach/detach retry when it's 400, below are the details, following two instances were deleted 3min ago before kube-controller-manager trying to attach/detach: workaround restart kube-controller-manager should work\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-68f09be650347e4603cd29896f4bc1ec73e17d525e7331267adc1d1483ebf3ed", "text": "c.diskAttachDetachMap.Delete(strings.ToLower(diskURI)) c.vmLockMap.UnlockEntry(strings.ToLower(string(nodeName))) <del> if err != nil && retry.IsErrorRetriable(err) && c.cloud.CloudProviderBackoff { klog.V(2).Infof(\"azureDisk - update backing off: detach disk(%s, %s), err: %v\", diskName, diskURI, err) retryErr := kwait.ExponentialBackoff(c.cloud.RequestBackoff(), func() (bool, error) { c.vmLockMap.LockEntry(strings.ToLower(string(nodeName))) c.diskAttachDetachMap.Store(strings.ToLower(diskURI), \"detaching\") err := vmset.DetachDisk(diskName, diskURI, nodeName) c.diskAttachDetachMap.Delete(strings.ToLower(diskURI)) c.vmLockMap.UnlockEntry(strings.ToLower(string(nodeName))) retriable := false if err != nil && retry.IsErrorRetriable(err) { retriable = true </del> <ins> if err != nil { if isInstanceNotFoundError(err) { // if host doesn't exist, no need to detach klog.Warningf(\"azureDisk - got InstanceNotFoundError(%v), DetachDisk(%s) will assume disk is already detached\", err, diskURI) return nil } if retry.IsErrorRetriable(err) && c.cloud.CloudProviderBackoff { klog.Warningf(\"azureDisk - update backing off: detach disk(%s, %s), err: %v\", diskName, diskURI, err) retryErr := kwait.ExponentialBackoff(c.cloud.RequestBackoff(), func() (bool, error) { c.vmLockMap.LockEntry(strings.ToLower(string(nodeName))) c.diskAttachDetachMap.Store(strings.ToLower(diskURI), \"detaching\") err := vmset.DetachDisk(diskName, diskURI, nodeName) c.diskAttachDetachMap.Delete(strings.ToLower(diskURI)) c.vmLockMap.UnlockEntry(strings.ToLower(string(nodeName))) retriable := false if err != nil && retry.IsErrorRetriable(err) { retriable = true } return !retriable, err }) if retryErr != nil { err = retryErr klog.V(2).Infof(\"azureDisk - update abort backoff: detach disk(%s, %s), err: %v\", diskName, diskURI, err) </ins> } <del> return !retriable, err }) if retryErr != nil { err = retryErr klog.V(2).Infof(\"azureDisk - update abort backoff: detach disk(%s, %s), err: %v\", diskName, diskURI, err) </del> } } if err != nil {", "commid": "kubernetes_pr_95177"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-23c5335b00aca0eec51c917ea7725032775eef25c4e2b03a4a38794b0414d296", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Same symtoms as The detach is not successful until controller-manager is restarted controller-manager logs: What you expected to happen: The detach operation should know that a node is not active or its been deleted and should assume the disk is detached. How to reproduce it (as minimally and precisely as possible): This seems quite hard to reproduce, but we do run into it quite a few times where the pod is stuck in , because the controller-manager is unable to detach disks from deleted nodes. Anything else we need to know?: Environment: Kubernetes version (use ): v1.15.11 Cloud provider or hardware configuration: azure (self-managed) OS (e.g: ): Ubuntu 18.04.3 LTS Kernel (e.g. ): 5.0.0-1027-azure Install tools: kubeadm Network plugin and version (if this is a network-related bug): Others: /sig cloud-provider /area provider/azure paging\n/sig azure\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /sig azure Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig cloud-provider\n/area provider/azure\nhi have you done sth manually on the node? if node is deleted finally, the disk would be in unattached state finally, then disk attach to another node would succeed finally.\nas discussed offline, the issue is probably due to vmss instance compute name change(incorrect format: , correct format: ), user should not change vmss instance compute name, otherwise it would break disk attach/detach, since compute name is used in vmss node name passing, code is here:\nHi We don't change the instance compute name - however what i do see in the azure metadata service is in the form - What you're referring to seems to be the computer name, and we do use the defaults as provided by azure. See The attach/detach operations works fairly well most of the time, and I think we're running into some edge case here. One thing i might have missed out is the fact that there seems to have been an issue with the VM at the time. So the VM was present, but azure platform would return 400 bad request for a detach operation which probably led to this .. But when the VM was eventually deleted by the autoscaler, the re-attach was never attempted by the reconciler it would seem. and the last message about that disk was\nshould be a valid compute name according to , do you know why we define the format like this?\nThe function is used to get the name from IMDS, and its format is .\nFrom the above errors, seems the request has been sent to VMSS but failed because it's not active. Do you know the VM state during that time?\nI am not sure of the state at the time, but i believe the VM was in some kind of failed state. The VM has since been deleted, but we had errors on the scaleset at the time. The events on the VMSS look like this. The VM was eventually deleted by the autoscaler, but the disk was never re-attached to a different node, and the pod remained in for about 2 days until controller-manager was restarted.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nApparently we hit this issue today as a result of replacing the nodepool. We 2 new nodepools and deleted the old one, and now we have 718 of 1672 pods stuck with this error in one of our clusters. The volumes are failing to be attached to new pods, the VMSS for old nodepool is removed. In AKS portal disks are still reported to be attached to VM instances in the VMSS that was deleted. hundreds of pods are stuck in Init state won't likely go forward. /remove-lifecycle rotten\n/remove-lifecycle rotten\nI have seen similar issue when handling one customer's case, it's probably caused by broken vmss cluster, pls file a ticket to VMSS team to fix the issue.\nI happened to find this issue in one customer case, this issue is caused by obsolete cache in kube-controller-manager, should skip attach/detach retry when it's 400, below are the details, following two instances were deleted 3min ago before kube-controller-manager trying to attach/detach: workaround restart kube-controller-manager should work\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-b53b1fdb18d26cd8bcdf1c2db27c8ddbcf9804464af6174b9c5f084313aac6b6", "text": "SourceResourceID: &sourceResourceID, }, nil } <ins> func isInstanceNotFoundError(err error) bool { errMsg := strings.ToLower(err.Error()) return strings.Contains(errMsg, errStatusCode400) && strings.Contains(errMsg, errInvalidParameter) && strings.Contains(errMsg, errTargetInstanceIds) } </ins>", "commid": "kubernetes_pr_95177"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-23c5335b00aca0eec51c917ea7725032775eef25c4e2b03a4a38794b0414d296", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Same symtoms as The detach is not successful until controller-manager is restarted controller-manager logs: What you expected to happen: The detach operation should know that a node is not active or its been deleted and should assume the disk is detached. How to reproduce it (as minimally and precisely as possible): This seems quite hard to reproduce, but we do run into it quite a few times where the pod is stuck in , because the controller-manager is unable to detach disks from deleted nodes. Anything else we need to know?: Environment: Kubernetes version (use ): v1.15.11 Cloud provider or hardware configuration: azure (self-managed) OS (e.g: ): Ubuntu 18.04.3 LTS Kernel (e.g. ): 5.0.0-1027-azure Install tools: kubeadm Network plugin and version (if this is a network-related bug): Others: /sig cloud-provider /area provider/azure paging\n/sig azure\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /sig azure Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig cloud-provider\n/area provider/azure\nhi have you done sth manually on the node? if node is deleted finally, the disk would be in unattached state finally, then disk attach to another node would succeed finally.\nas discussed offline, the issue is probably due to vmss instance compute name change(incorrect format: , correct format: ), user should not change vmss instance compute name, otherwise it would break disk attach/detach, since compute name is used in vmss node name passing, code is here:\nHi We don't change the instance compute name - however what i do see in the azure metadata service is in the form - What you're referring to seems to be the computer name, and we do use the defaults as provided by azure. See The attach/detach operations works fairly well most of the time, and I think we're running into some edge case here. One thing i might have missed out is the fact that there seems to have been an issue with the VM at the time. So the VM was present, but azure platform would return 400 bad request for a detach operation which probably led to this .. But when the VM was eventually deleted by the autoscaler, the re-attach was never attempted by the reconciler it would seem. and the last message about that disk was\nshould be a valid compute name according to , do you know why we define the format like this?\nThe function is used to get the name from IMDS, and its format is .\nFrom the above errors, seems the request has been sent to VMSS but failed because it's not active. Do you know the VM state during that time?\nI am not sure of the state at the time, but i believe the VM was in some kind of failed state. The VM has since been deleted, but we had errors on the scaleset at the time. The events on the VMSS look like this. The VM was eventually deleted by the autoscaler, but the disk was never re-attached to a different node, and the pod remained in for about 2 days until controller-manager was restarted.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nApparently we hit this issue today as a result of replacing the nodepool. We 2 new nodepools and deleted the old one, and now we have 718 of 1672 pods stuck with this error in one of our clusters. The volumes are failing to be attached to new pods, the VMSS for old nodepool is removed. In AKS portal disks are still reported to be attached to VM instances in the VMSS that was deleted. hundreds of pods are stuck in Init state won't likely go forward. /remove-lifecycle rotten\n/remove-lifecycle rotten\nI have seen similar issue when handling one customer's case, it's probably caused by broken vmss cluster, pls file a ticket to VMSS team to fix the issue.\nI happened to find this issue in one customer case, this issue is caused by obsolete cache in kube-controller-manager, should skip attach/detach retry when it's 400, below are the details, following two instances were deleted 3min ago before kube-controller-manager trying to attach/detach: workaround restart kube-controller-manager should work\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-7e6b4ed613ff168077390325b44e6e42d40657af0f39b473a1cd92a971200a42", "text": "assert.Equal(t, 1, len(filteredDisks)) assert.Equal(t, newDiskName, *filteredDisks[0].Name) } <ins> func TestIsInstanceNotFoundError(t *testing.T) { testCases := []struct { errMsg         string expectedResult bool }{ { errMsg:         \"\", expectedResult: false, }, { errMsg:         \"other error\", expectedResult: false, }, { errMsg:         \"not an active Virtual Machine scale set vm\", expectedResult: false, }, { errMsg:         `compute.VirtualMachineScaleSetVMsClient#Update: Failure sending request: StatusCode=400 -- Original Error: Code=\"InvalidParameter\" Message=\"The provided instanceId 1181 is not an active Virtual Machine Scale Set VM instanceId.\" Target=\"instanceIds\"`, expectedResult: true, }, } for i, test := range testCases { result := isInstanceNotFoundError(fmt.Errorf(test.errMsg)) assert.Equal(t, test.expectedResult, result, \"TestCase[%d]\", i, result) } } </ins>", "commid": "kubernetes_pr_95177"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-46cd7c4715ee42faad931721887eefd6a42fe48f3f45f3077b49b6fc07c07d89", "query": "After has been implemented and enabled the 5k node kubemark run has extra ~10k lines of logs like this ones: Example kubemark 5k run: We should get rid of that, it doesn't bring any value only pollutes the log\n/sig scalability /cc", "positive_passages": [{"docid": "doc-en-kubernetes-30ecc1d86dadb150301cf919fb406558b15997be4ad6fa817f89898093052cc2", "text": "echo \"Annotating node objects with ${annotation_size_bytes} byte label\" label=$( (< /dev/urandom tr -dc 'a-zA-Z0-9' | fold -w \"$annotation_size_bytes\"; true) | head -n 1) \"${KUBECTL}\" --kubeconfig=\"${LOCAL_KUBECONFIG}\" get nodes -o name  <del> | xargs -n10 -P100 -r -I% \"${KUBECTL}\" --kubeconfig=\"${LOCAL_KUBECONFIG}\" annotate --overwrite % label=\"$label\" </del> <ins> | xargs -n10 -P100 -r -I% \"${KUBECTL}\" --kubeconfig=\"${LOCAL_KUBECONFIG}\" annotate --overwrite % label=\"$label\" > /dev/null </ins> echo \"Annotating node objects completed\" }", "commid": "kubernetes_pr_91205"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a5e229fd70ce573d53baf12b4a14c90677be4e835206788149f7a3ce3798d9b0", "query": "Graduate seccomp to GA, as defined on the respective . This is an umbrella issue to track all outstanding work. [x] API Server changes (MERGED) [x] Kubelet changes (MERGED) [x] Mark flag as deprecated (MERGED) [x] Update PSP to support seccomp fields (MERGED) [x] Document Kubernetes seccomp support (MERGED)[x] Add seccomp least privilege for docker sandbox (MERGED) [x] Add seccomp least privilege for kuberuntime (MERGED) ) /area kubelet /area kubelet-api /sig node /area security /assign\n/cc\njust a heads up that we have concluded all the core items for seccomp to go GA. There are still 2 pending PRs that ideally would also go in 1.19, but we are waiting for them to be reviewed: and\nneeds to be rebased apparently and isn't just waiting in the merge pool as verify is not passing.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nI think the warning mechanism was blocked by a not existing API. This is now tracked in\n/remove-lifecycle stale\nUpdated the description to given that the warning mechanism is now set to that milestone.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/priority backlog\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/lifecycle frozen What is the remaining work here?\nI guess we have to follow-up on and implement: I can take care of that if we agree that we want to ship that in 1.27. /cc", "positive_passages": [{"docid": "doc-en-kubernetes-04c704fcc85d97565ce2b708453222440d0562453423d6c3dee2e0fefd3bd3e1", "text": "return len(podSpec.SchedulingGates) != 0 } <del> // SeccompAnnotationForField takes a pod seccomp profile field and returns the // converted annotation value func SeccompAnnotationForField(field *api.SeccompProfile) string { // If only seccomp fields are specified, add the corresponding annotations. // This ensures that the fields are enforced even if the node version // trails the API version switch field.Type { case api.SeccompProfileTypeUnconfined: return v1.SeccompProfileNameUnconfined case api.SeccompProfileTypeRuntimeDefault: return v1.SeccompProfileRuntimeDefault case api.SeccompProfileTypeLocalhost: if field.LocalhostProfile != nil { return v1.SeccompLocalhostProfileNamePrefix + *field.LocalhostProfile } } // we can only reach this code path if the LocalhostProfile is nil but the // provided field type is SeccompProfileTypeLocalhost or if an unrecognized // type is specified return \"\" } </del> func hasInvalidLabelValueInAffinitySelector(spec *api.PodSpec) bool { if spec.Affinity != nil { if spec.Affinity.PodAffinity != nil {", "commid": "kubernetes_pr_114947"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a5e229fd70ce573d53baf12b4a14c90677be4e835206788149f7a3ce3798d9b0", "query": "Graduate seccomp to GA, as defined on the respective . This is an umbrella issue to track all outstanding work. [x] API Server changes (MERGED) [x] Kubelet changes (MERGED) [x] Mark flag as deprecated (MERGED) [x] Update PSP to support seccomp fields (MERGED) [x] Document Kubernetes seccomp support (MERGED)[x] Add seccomp least privilege for docker sandbox (MERGED) [x] Add seccomp least privilege for kuberuntime (MERGED) ) /area kubelet /area kubelet-api /sig node /area security /assign\n/cc\njust a heads up that we have concluded all the core items for seccomp to go GA. There are still 2 pending PRs that ideally would also go in 1.19, but we are waiting for them to be reviewed: and\nneeds to be rebased apparently and isn't just waiting in the merge pool as verify is not passing.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nI think the warning mechanism was blocked by a not existing API. This is now tracked in\n/remove-lifecycle stale\nUpdated the description to given that the warning mechanism is now set to that milestone.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/priority backlog\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/lifecycle frozen What is the remaining work here?\nI guess we have to follow-up on and implement: I can take care of that if we agree that we want to ship that in 1.27. /cc", "positive_passages": [{"docid": "doc-en-kubernetes-fbd40fb5d560fda1c423093bb155f5cad783b40d500c723a0f53dcedefbfa282", "text": "// use of pod seccomp annotation without accompanying field if podSpec.SecurityContext == nil || podSpec.SecurityContext.SeccompProfile == nil { if _, exists := meta.Annotations[api.SeccompPodAnnotationKey]; exists { <del> warnings = append(warnings, fmt.Sprintf(`%s: deprecated since v1.19, non-functional in a future release; use the \"seccompProfile\" field instead`, fieldPath.Child(\"metadata\", \"annotations\").Key(api.SeccompPodAnnotationKey))) </del> <ins> warnings = append(warnings, fmt.Sprintf(`%s: non-functional in v1.27+; use the \"seccompProfile\" field instead`, fieldPath.Child(\"metadata\", \"annotations\").Key(api.SeccompPodAnnotationKey))) </ins> } }", "commid": "kubernetes_pr_114947"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a5e229fd70ce573d53baf12b4a14c90677be4e835206788149f7a3ce3798d9b0", "query": "Graduate seccomp to GA, as defined on the respective . This is an umbrella issue to track all outstanding work. [x] API Server changes (MERGED) [x] Kubelet changes (MERGED) [x] Mark flag as deprecated (MERGED) [x] Update PSP to support seccomp fields (MERGED) [x] Document Kubernetes seccomp support (MERGED)[x] Add seccomp least privilege for docker sandbox (MERGED) [x] Add seccomp least privilege for kuberuntime (MERGED) ) /area kubelet /area kubelet-api /sig node /area security /assign\n/cc\njust a heads up that we have concluded all the core items for seccomp to go GA. There are still 2 pending PRs that ideally would also go in 1.19, but we are waiting for them to be reviewed: and\nneeds to be rebased apparently and isn't just waiting in the merge pool as verify is not passing.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nI think the warning mechanism was blocked by a not existing API. This is now tracked in\n/remove-lifecycle stale\nUpdated the description to given that the warning mechanism is now set to that milestone.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/priority backlog\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/lifecycle frozen What is the remaining work here?\nI guess we have to follow-up on and implement: I can take care of that if we agree that we want to ship that in 1.27. /cc", "positive_passages": [{"docid": "doc-en-kubernetes-0352be6d2bffb2bdb4d8112abfb7f483fdd5aa61ed2eff5fb72b0ea91a8f7f70", "text": "// use of container seccomp annotation without accompanying field if c.SecurityContext == nil || c.SecurityContext.SeccompProfile == nil { if _, exists := meta.Annotations[api.SeccompContainerAnnotationKeyPrefix+c.Name]; exists { <del> warnings = append(warnings, fmt.Sprintf(`%s: deprecated since v1.19, non-functional in a future release; use the \"seccompProfile\" field instead`, fieldPath.Child(\"metadata\", \"annotations\").Key(api.SeccompContainerAnnotationKeyPrefix+c.Name))) </del> <ins> warnings = append(warnings, fmt.Sprintf(`%s: non-functional in v1.27+; use the \"seccompProfile\" field instead`, fieldPath.Child(\"metadata\", \"annotations\").Key(api.SeccompContainerAnnotationKeyPrefix+c.Name))) </ins> } }", "commid": "kubernetes_pr_114947"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a5e229fd70ce573d53baf12b4a14c90677be4e835206788149f7a3ce3798d9b0", "query": "Graduate seccomp to GA, as defined on the respective . This is an umbrella issue to track all outstanding work. [x] API Server changes (MERGED) [x] Kubelet changes (MERGED) [x] Mark flag as deprecated (MERGED) [x] Update PSP to support seccomp fields (MERGED) [x] Document Kubernetes seccomp support (MERGED)[x] Add seccomp least privilege for docker sandbox (MERGED) [x] Add seccomp least privilege for kuberuntime (MERGED) ) /area kubelet /area kubelet-api /sig node /area security /assign\n/cc\njust a heads up that we have concluded all the core items for seccomp to go GA. There are still 2 pending PRs that ideally would also go in 1.19, but we are waiting for them to be reviewed: and\nneeds to be rebased apparently and isn't just waiting in the merge pool as verify is not passing.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nI think the warning mechanism was blocked by a not existing API. This is now tracked in\n/remove-lifecycle stale\nUpdated the description to given that the warning mechanism is now set to that milestone.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/priority backlog\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/lifecycle frozen What is the remaining work here?\nI guess we have to follow-up on and implement: I can take care of that if we agree that we want to ship that in 1.27. /cc", "positive_passages": [{"docid": "doc-en-kubernetes-a3a6964f0146fcef733def508a848f3a42f28e4e30ca740a4a47dfe75261eda2", "text": "}, expected: []string{ `metadata.annotations[scheduler.alpha.kubernetes.io/critical-pod]: non-functional in v1.16+; use the \"priorityClassName\" field instead`, <del> `metadata.annotations[seccomp.security.alpha.kubernetes.io/pod]: deprecated since v1.19, non-functional in a future release; use the \"seccompProfile\" field instead`, `metadata.annotations[container.seccomp.security.alpha.kubernetes.io/foo]: deprecated since v1.19, non-functional in a future release; use the \"seccompProfile\" field instead`, </del> <ins> `metadata.annotations[seccomp.security.alpha.kubernetes.io/pod]: non-functional in v1.27+; use the \"seccompProfile\" field instead`, `metadata.annotations[container.seccomp.security.alpha.kubernetes.io/foo]: non-functional in v1.27+; use the \"seccompProfile\" field instead`, </ins> `metadata.annotations[security.alpha.kubernetes.io/sysctls]: non-functional in v1.11+; use the \"sysctls\" field instead`, `metadata.annotations[security.alpha.kubernetes.io/unsafe-sysctls]: non-functional in v1.11+; use the \"sysctls\" field instead`, },", "commid": "kubernetes_pr_114947"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a5e229fd70ce573d53baf12b4a14c90677be4e835206788149f7a3ce3798d9b0", "query": "Graduate seccomp to GA, as defined on the respective . This is an umbrella issue to track all outstanding work. [x] API Server changes (MERGED) [x] Kubelet changes (MERGED) [x] Mark flag as deprecated (MERGED) [x] Update PSP to support seccomp fields (MERGED) [x] Document Kubernetes seccomp support (MERGED)[x] Add seccomp least privilege for docker sandbox (MERGED) [x] Add seccomp least privilege for kuberuntime (MERGED) ) /area kubelet /area kubelet-api /sig node /area security /assign\n/cc\njust a heads up that we have concluded all the core items for seccomp to go GA. There are still 2 pending PRs that ideally would also go in 1.19, but we are waiting for them to be reviewed: and\nneeds to be rebased apparently and isn't just waiting in the merge pool as verify is not passing.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nI think the warning mechanism was blocked by a not existing API. This is now tracked in\n/remove-lifecycle stale\nUpdated the description to given that the warning mechanism is now set to that milestone.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/priority backlog\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/lifecycle frozen What is the remaining work here?\nI guess we have to follow-up on and implement: I can take care of that if we agree that we want to ship that in 1.27. /cc", "positive_passages": [{"docid": "doc-en-kubernetes-ab98912cc1318d2b9548464a4612af1dcf31ba4fce38adec6e6ebe27a6e3bd56", "text": "\"strings\" \"time\" <del> v1 \"k8s.io/api/core/v1\" </del> \"k8s.io/apimachinery/pkg/api/errors\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/fields\"", "commid": "kubernetes_pr_114947"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a5e229fd70ce573d53baf12b4a14c90677be4e835206788149f7a3ce3798d9b0", "query": "Graduate seccomp to GA, as defined on the respective . This is an umbrella issue to track all outstanding work. [x] API Server changes (MERGED) [x] Kubelet changes (MERGED) [x] Mark flag as deprecated (MERGED) [x] Update PSP to support seccomp fields (MERGED) [x] Document Kubernetes seccomp support (MERGED)[x] Add seccomp least privilege for docker sandbox (MERGED) [x] Add seccomp least privilege for kuberuntime (MERGED) ) /area kubelet /area kubelet-api /sig node /area security /assign\n/cc\njust a heads up that we have concluded all the core items for seccomp to go GA. There are still 2 pending PRs that ideally would also go in 1.19, but we are waiting for them to be reviewed: and\nneeds to be rebased apparently and isn't just waiting in the merge pool as verify is not passing.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nI think the warning mechanism was blocked by a not existing API. This is now tracked in\n/remove-lifecycle stale\nUpdated the description to given that the warning mechanism is now set to that milestone.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/priority backlog\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/lifecycle frozen What is the remaining work here?\nI guess we have to follow-up on and implement: I can take care of that if we agree that we want to ship that in 1.27. /cc", "positive_passages": [{"docid": "doc-en-kubernetes-29a2d9ca3da7616e4413bf81f08ba21d54fc0cb682fd68616ee22d630a5568a3", "text": "podutil.DropDisabledPodFields(pod, nil) <del> applySeccompVersionSkew(pod) </del> applyWaitingForSchedulingGatesCondition(pod) }", "commid": "kubernetes_pr_114947"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a5e229fd70ce573d53baf12b4a14c90677be4e835206788149f7a3ce3798d9b0", "query": "Graduate seccomp to GA, as defined on the respective . This is an umbrella issue to track all outstanding work. [x] API Server changes (MERGED) [x] Kubelet changes (MERGED) [x] Mark flag as deprecated (MERGED) [x] Update PSP to support seccomp fields (MERGED) [x] Document Kubernetes seccomp support (MERGED)[x] Add seccomp least privilege for docker sandbox (MERGED) [x] Add seccomp least privilege for kuberuntime (MERGED) ) /area kubelet /area kubelet-api /sig node /area security /assign\n/cc\njust a heads up that we have concluded all the core items for seccomp to go GA. There are still 2 pending PRs that ideally would also go in 1.19, but we are waiting for them to be reviewed: and\nneeds to be rebased apparently and isn't just waiting in the merge pool as verify is not passing.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nI think the warning mechanism was blocked by a not existing API. This is now tracked in\n/remove-lifecycle stale\nUpdated the description to given that the warning mechanism is now set to that milestone.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/priority backlog\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/lifecycle frozen What is the remaining work here?\nI guess we have to follow-up on and implement: I can take care of that if we agree that we want to ship that in 1.27. /cc", "positive_passages": [{"docid": "doc-en-kubernetes-bd26f052962fbcaa40f5b2d20fa39fa9f8432a8fd74214655c1fad6157c195bf", "text": "Message: \"Scheduling is blocked due to non-empty scheduling gates\", }) } <del> // applySeccompVersionSkew implements the version skew behavior described in: // https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/135-seccomp#version-skew-strategy // Note that we dropped copying the field to annotation synchronization in // v1.25 with the functional removal of the annotations. func applySeccompVersionSkew(pod *api.Pod) { // get possible annotation and field annotation, hasAnnotation := pod.Annotations[v1.SeccompPodAnnotationKey] hasField := false if pod.Spec.SecurityContext != nil && pod.Spec.SecurityContext.SeccompProfile != nil { hasField = true } // sync field and annotation if hasAnnotation && !hasField { newField := seccompFieldForAnnotation(annotation) if newField != nil { if pod.Spec.SecurityContext == nil { pod.Spec.SecurityContext = &api.PodSecurityContext{} } pod.Spec.SecurityContext.SeccompProfile = newField } } // Handle the containers of the pod podutil.VisitContainers(&pod.Spec, podutil.AllFeatureEnabledContainers(), func(ctr *api.Container, _ podutil.ContainerType) bool { // get possible annotation and field key := api.SeccompContainerAnnotationKeyPrefix + ctr.Name annotation, hasAnnotation := pod.Annotations[key] hasField := false if ctr.SecurityContext != nil && ctr.SecurityContext.SeccompProfile != nil { hasField = true } // sync field and annotation if hasAnnotation && !hasField { newField := seccompFieldForAnnotation(annotation) if newField != nil { if ctr.SecurityContext == nil { ctr.SecurityContext = &api.SecurityContext{} } ctr.SecurityContext.SeccompProfile = newField } } return true }) } // seccompFieldForAnnotation takes a pod annotation and returns the converted // seccomp profile field. func seccompFieldForAnnotation(annotation string) *api.SeccompProfile { // If only seccomp annotations are specified, copy the values into the // corresponding fields. This ensures that existing applications continue // to enforce seccomp, and prevents the kubelet from needing to resolve // annotations & fields. if annotation == v1.SeccompProfileNameUnconfined { return &api.SeccompProfile{Type: api.SeccompProfileTypeUnconfined} } if annotation == api.SeccompProfileRuntimeDefault || annotation == api.DeprecatedSeccompProfileDockerDefault { return &api.SeccompProfile{Type: api.SeccompProfileTypeRuntimeDefault} } if strings.HasPrefix(annotation, v1.SeccompLocalhostProfileNamePrefix) { localhostProfile := strings.TrimPrefix(annotation, v1.SeccompLocalhostProfileNamePrefix) if localhostProfile != \"\" { return &api.SeccompProfile{ Type:             api.SeccompProfileTypeLocalhost, LocalhostProfile: &localhostProfile, } } } // we can only reach this code path if the localhostProfile name has a zero // length or if the annotation has an unrecognized value return nil } </del>", "commid": "kubernetes_pr_114947"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a5e229fd70ce573d53baf12b4a14c90677be4e835206788149f7a3ce3798d9b0", "query": "Graduate seccomp to GA, as defined on the respective . This is an umbrella issue to track all outstanding work. [x] API Server changes (MERGED) [x] Kubelet changes (MERGED) [x] Mark flag as deprecated (MERGED) [x] Update PSP to support seccomp fields (MERGED) [x] Document Kubernetes seccomp support (MERGED)[x] Add seccomp least privilege for docker sandbox (MERGED) [x] Add seccomp least privilege for kuberuntime (MERGED) ) /area kubelet /area kubelet-api /sig node /area security /assign\n/cc\njust a heads up that we have concluded all the core items for seccomp to go GA. There are still 2 pending PRs that ideally would also go in 1.19, but we are waiting for them to be reviewed: and\nneeds to be rebased apparently and isn't just waiting in the merge pool as verify is not passing.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nI think the warning mechanism was blocked by a not existing API. This is now tracked in\n/remove-lifecycle stale\nUpdated the description to given that the warning mechanism is now set to that milestone.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/priority backlog\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/lifecycle frozen What is the remaining work here?\nI guess we have to follow-up on and implement: I can take care of that if we agree that we want to ship that in 1.27. /cc", "positive_passages": [{"docid": "doc-en-kubernetes-f6c3eefda0d3112d06b4e1e5d0fd609edea03743f42965e42e2ad93ff9b91618", "text": "\"github.com/google/go-cmp/cmp\" \"github.com/google/go-cmp/cmp/cmpopts\" <del> \"github.com/stretchr/testify/require\" v1 \"k8s.io/api/core/v1\" </del> \"k8s.io/apimachinery/pkg/api/errors\" \"k8s.io/apimachinery/pkg/api/resource\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"", "commid": "kubernetes_pr_114947"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a5e229fd70ce573d53baf12b4a14c90677be4e835206788149f7a3ce3798d9b0", "query": "Graduate seccomp to GA, as defined on the respective . This is an umbrella issue to track all outstanding work. [x] API Server changes (MERGED) [x] Kubelet changes (MERGED) [x] Mark flag as deprecated (MERGED) [x] Update PSP to support seccomp fields (MERGED) [x] Document Kubernetes seccomp support (MERGED)[x] Add seccomp least privilege for docker sandbox (MERGED) [x] Add seccomp least privilege for kuberuntime (MERGED) ) /area kubelet /area kubelet-api /sig node /area security /assign\n/cc\njust a heads up that we have concluded all the core items for seccomp to go GA. There are still 2 pending PRs that ideally would also go in 1.19, but we are waiting for them to be reviewed: and\nneeds to be rebased apparently and isn't just waiting in the merge pool as verify is not passing.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nI think the warning mechanism was blocked by a not existing API. This is now tracked in\n/remove-lifecycle stale\nUpdated the description to given that the warning mechanism is now set to that milestone.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/priority backlog\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/lifecycle frozen What is the remaining work here?\nI guess we have to follow-up on and implement: I can take care of that if we agree that we want to ship that in 1.27. /cc", "positive_passages": [{"docid": "doc-en-kubernetes-8661db54ce9d7ae94849eafec40b3e4ea1cc152437906abcae9be39f192cb2e3", "text": "} } <del> func TestApplySeccompVersionSkew(t *testing.T) { const containerName = \"container\" testProfile := \"test\" for _, test := range []struct { description string pod         *api.Pod validation  func(*testing.T, *api.Pod) }{ { description: \"Security context nil\", pod:         &api.Pod{}, validation: func(t *testing.T, pod *api.Pod) { require.NotNil(t, pod) }, }, { description: \"Security context not nil\", pod: &api.Pod{ Spec: api.PodSpec{SecurityContext: &api.PodSecurityContext{}}, }, validation: func(t *testing.T, pod *api.Pod) { require.NotNil(t, pod) }, }, { description: \"Field set and no annotation present\", pod: &api.Pod{ Spec: api.PodSpec{ SecurityContext: &api.PodSecurityContext{ SeccompProfile: &api.SeccompProfile{ Type: api.SeccompProfileTypeUnconfined, }, }, }, }, validation: func(t *testing.T, pod *api.Pod) { require.Len(t, pod.Annotations, 0) }, }, { description: \"Annotation 'unconfined' and no field present\", pod: &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Annotations: map[string]string{ v1.SeccompPodAnnotationKey: v1.SeccompProfileNameUnconfined, }, }, Spec: api.PodSpec{}, }, validation: func(t *testing.T, pod *api.Pod) { require.Equal(t, api.SeccompProfileTypeUnconfined, pod.Spec.SecurityContext.SeccompProfile.Type) require.Nil(t, pod.Spec.SecurityContext.SeccompProfile.LocalhostProfile) }, }, { description: \"Annotation 'runtime/default' and no field present\", pod: &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Annotations: map[string]string{ v1.SeccompPodAnnotationKey: v1.SeccompProfileRuntimeDefault, }, }, Spec: api.PodSpec{SecurityContext: &api.PodSecurityContext{}}, }, validation: func(t *testing.T, pod *api.Pod) { require.Equal(t, api.SeccompProfileTypeRuntimeDefault, pod.Spec.SecurityContext.SeccompProfile.Type) require.Nil(t, pod.Spec.SecurityContext.SeccompProfile.LocalhostProfile) }, }, { description: \"Annotation 'docker/default' and no field present\", pod: &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Annotations: map[string]string{ v1.SeccompPodAnnotationKey: v1.DeprecatedSeccompProfileDockerDefault, }, }, Spec: api.PodSpec{SecurityContext: &api.PodSecurityContext{}}, }, validation: func(t *testing.T, pod *api.Pod) { require.Equal(t, api.SeccompProfileTypeRuntimeDefault, pod.Spec.SecurityContext.SeccompProfile.Type) require.Nil(t, pod.Spec.SecurityContext.SeccompProfile.LocalhostProfile) }, }, { description: \"Annotation 'localhost/test' and no field present\", pod: &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Annotations: map[string]string{ v1.SeccompPodAnnotationKey: v1.SeccompLocalhostProfileNamePrefix + testProfile, }, }, Spec: api.PodSpec{SecurityContext: &api.PodSecurityContext{}}, }, validation: func(t *testing.T, pod *api.Pod) { require.Equal(t, api.SeccompProfileTypeLocalhost, pod.Spec.SecurityContext.SeccompProfile.Type) require.Equal(t, testProfile, *pod.Spec.SecurityContext.SeccompProfile.LocalhostProfile) }, }, { description: \"Annotation 'localhost/' has zero length\", pod: &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Annotations: map[string]string{ v1.SeccompPodAnnotationKey: v1.SeccompLocalhostProfileNamePrefix, }, }, Spec: api.PodSpec{SecurityContext: &api.PodSecurityContext{}}, }, validation: func(t *testing.T, pod *api.Pod) { require.Nil(t, pod.Spec.SecurityContext.SeccompProfile) }, }, { description: \"Security context nil (container)\", pod: &api.Pod{ Spec: api.PodSpec{ Containers: []api.Container{{}}, }, }, validation: func(t *testing.T, pod *api.Pod) { require.NotNil(t, pod) }, }, { description: \"Security context not nil (container)\", pod: &api.Pod{ Spec: api.PodSpec{ Containers: []api.Container{{ SecurityContext: &api.SecurityContext{}, }}, }, }, validation: func(t *testing.T, pod *api.Pod) { require.NotNil(t, pod) }, }, { description: \"Field set and no annotation present (container)\", pod: &api.Pod{ Spec: api.PodSpec{ Containers: []api.Container{ { Name: containerName, SecurityContext: &api.SecurityContext{ SeccompProfile: &api.SeccompProfile{ Type: api.SeccompProfileTypeUnconfined, }, }, }, }, }, }, validation: func(t *testing.T, pod *api.Pod) { require.Len(t, pod.Annotations, 0) }, }, { description: \"Multiple containers with fields (container)\", pod: &api.Pod{ Spec: api.PodSpec{ Containers: []api.Container{ { Name: containerName + \"1\", SecurityContext: &api.SecurityContext{ SeccompProfile: &api.SeccompProfile{ Type: api.SeccompProfileTypeUnconfined, }, }, }, { Name: containerName + \"2\", }, { Name: containerName + \"3\", SecurityContext: &api.SecurityContext{ SeccompProfile: &api.SeccompProfile{ Type: api.SeccompProfileTypeRuntimeDefault, }, }, }, }, }, }, validation: func(t *testing.T, pod *api.Pod) { require.Len(t, pod.Annotations, 0) }, }, { description: \"Annotation 'unconfined' and no field present (container)\", pod: &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Annotations: map[string]string{ v1.SeccompContainerAnnotationKeyPrefix + containerName: v1.SeccompProfileNameUnconfined, }, }, Spec: api.PodSpec{ Containers: []api.Container{{ Name: containerName, }}, }, }, validation: func(t *testing.T, pod *api.Pod) { require.Equal(t, api.SeccompProfileTypeUnconfined, pod.Spec.Containers[0].SecurityContext.SeccompProfile.Type) require.Nil(t, pod.Spec.Containers[0].SecurityContext.SeccompProfile.LocalhostProfile) }, }, { description: \"Annotation 'runtime/default' and no field present (container)\", pod: &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Annotations: map[string]string{ v1.SeccompContainerAnnotationKeyPrefix + containerName: v1.SeccompProfileRuntimeDefault, }, }, Spec: api.PodSpec{ Containers: []api.Container{{ Name:            containerName, SecurityContext: &api.SecurityContext{}, }}, }, }, validation: func(t *testing.T, pod *api.Pod) { require.Equal(t, api.SeccompProfileTypeRuntimeDefault, pod.Spec.Containers[0].SecurityContext.SeccompProfile.Type) require.Nil(t, pod.Spec.Containers[0].SecurityContext.SeccompProfile.LocalhostProfile) }, }, { description: \"Annotation 'docker/default' and no field present (container)\", pod: &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Annotations: map[string]string{ v1.SeccompContainerAnnotationKeyPrefix + containerName: v1.DeprecatedSeccompProfileDockerDefault, }, }, Spec: api.PodSpec{ Containers: []api.Container{{ Name:            containerName, SecurityContext: &api.SecurityContext{}, }}, }, }, validation: func(t *testing.T, pod *api.Pod) { require.Equal(t, api.SeccompProfileTypeRuntimeDefault, pod.Spec.Containers[0].SecurityContext.SeccompProfile.Type) require.Nil(t, pod.Spec.Containers[0].SecurityContext.SeccompProfile.LocalhostProfile) }, }, { description: \"Multiple containers by annotations (container)\", pod: &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Annotations: map[string]string{ v1.SeccompContainerAnnotationKeyPrefix + containerName + \"1\": v1.SeccompLocalhostProfileNamePrefix + testProfile, v1.SeccompContainerAnnotationKeyPrefix + containerName + \"3\": v1.SeccompProfileRuntimeDefault, }, }, Spec: api.PodSpec{ Containers: []api.Container{ {Name: containerName + \"1\"}, {Name: containerName + \"2\"}, {Name: containerName + \"3\"}, }, }, }, validation: func(t *testing.T, pod *api.Pod) { require.Equal(t, api.SeccompProfileTypeLocalhost, pod.Spec.Containers[0].SecurityContext.SeccompProfile.Type) require.Equal(t, testProfile, *pod.Spec.Containers[0].SecurityContext.SeccompProfile.LocalhostProfile) require.Equal(t, api.SeccompProfileTypeRuntimeDefault, pod.Spec.Containers[2].SecurityContext.SeccompProfile.Type) }, }, { description: \"Annotation 'localhost/test' and no field present (container)\", pod: &api.Pod{ ObjectMeta: metav1.ObjectMeta{ Annotations: map[string]string{ v1.SeccompContainerAnnotationKeyPrefix + containerName: v1.SeccompLocalhostProfileNamePrefix + testProfile, }, }, Spec: api.PodSpec{ Containers: []api.Container{{ Name:            containerName, SecurityContext: &api.SecurityContext{}, }}, }, }, validation: func(t *testing.T, pod *api.Pod) { require.Equal(t, api.SeccompProfileTypeLocalhost, pod.Spec.Containers[0].SecurityContext.SeccompProfile.Type) require.Equal(t, testProfile, *pod.Spec.Containers[0].SecurityContext.SeccompProfile.LocalhostProfile) }, }, } { output := &api.Pod{ ObjectMeta: metav1.ObjectMeta{Annotations: map[string]string{}}, } for i, ctr := range test.pod.Spec.Containers { output.Spec.Containers = append(output.Spec.Containers, api.Container{}) if ctr.SecurityContext != nil && ctr.SecurityContext.SeccompProfile != nil { output.Spec.Containers[i].SecurityContext = &api.SecurityContext{ SeccompProfile: &api.SeccompProfile{ Type:             api.SeccompProfileType(ctr.SecurityContext.SeccompProfile.Type), LocalhostProfile: ctr.SecurityContext.SeccompProfile.LocalhostProfile, }, } } } applySeccompVersionSkew(test.pod) test.validation(t, test.pod) } } </del> func newPodWithHugePageValue(resourceName api.ResourceName, value resource.Quantity) *api.Pod { return &api.Pod{", "commid": "kubernetes_pr_114947"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04a7465ce5cc37d6e8b4f5a3688fe336581dbf09f1490dc9271f31d40db1f63d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: I created several Workloads which require up to ten ports for both UDP and TCP protocol. Now my logs get spammed with . What you expected to happen: should consider -combination instead of only . How to reproduce it (as minimally and precisely as possible): Deploy any service with a node-port with both protocols, e.g.: Anything else we need to know?: This was already acknowledged by here: However, as this thread addresses a different bug and seems kind of stuck, i'd like to suggest that this might be addressed in a new context. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Deployed via Rancher v2.4.3\n/sig api-machinery\n/remove-sig api-machinery /sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\nHow did you get into this situation? The allocator should not have granted the same node port twice?\nOh right, that issue. The only real way out is to de-allocate the NodePorts and then re-allocate them, I think\nAs this happens for all of my ports in the said Production Application (the one where my log gets spammed) as well as complete fresh installation (where i verified the bug), i think there's no \"way out\" except fixing the bug. As said, for me it's necessary to assign both protocols to the same port. This might be a niche-use-case, but checking the it's actually very likely for ports to allow tcp AND udp. I'm not sure about the history of this, but it might be that issue was the origin, which was adressed in PR (\"Allow services which use same port, different protocol to use the same nodePort for both\"). But this PR doesn't contain the adjustment of the said , so still considers the behaviour as invalid, while it's actually allowed and supported.\n/assign\nAhh, I thought you meant that you had accidentally been allocated the same nodePorts and I was very confused when you said \"all of them\". I have reproduced this issue, and I can see it by inspection. The obvious fix would be to collect ports split by protocol, but I think that's not right since we don't store it split. An even simpler fix would be for to build a . Then for each protocol, for each port, build that contains all the port numbers, but remove any duplicates ONLY IF they are duplicated across protocols. Duplicates in the same protocol should be retained (to report an error later). I don't have time to tackle this tonight (and write a test), but it seems like a good bug.\nperhaps I can fix this problem /assign\nthings may be a little more complicated. Right now the is not aware of the protocol of the port so I guess simply rewriting function to return is not enough, the port allocator will still return on same node port even with different protocol. perhaps we need to refactor the to make it protocol-aware.\nI don't think we need to do make the allocator be protocol aware. IIRC we allow you to use the same nodeport on different protocols ONLY within a single service. This means (I think) that we can do hyper-local deduplication as we collect the nodeports for each service. If we find the same nodeport number with different protocols, just remove the duplicates because it is allowed. I.e. a service that looks like: return - deduped. if ANY OTHER service tried to use it would be an error at the \"rebuilt\" allocator Likewise if a single Service claims to use the same nodeport number more than once on the same protocol, it should be an error: return - NOT deduped.\nobviously, we want a great unit test here :P\nah got it! thanks for your detailed explanation!\nHi! I have filed a PR to resolve this issue, could you take a look?", "positive_passages": [{"docid": "doc-en-kubernetes-af532b0662b3fb32cd8400ce4524f4bfbf5ac5caf8455958531f029eddce26bd", "text": "\"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/util/net:go_default_library\", \"//staging/src/k8s.io/apimachinery/pkg/util/runtime:go_default_library\", <ins> \"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library\", </ins> \"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library\", \"//staging/src/k8s.io/client-go/kubernetes/typed/core/v1:go_default_library\", \"//staging/src/k8s.io/client-go/tools/record:go_default_library\",", "commid": "kubernetes_pr_91590"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04a7465ce5cc37d6e8b4f5a3688fe336581dbf09f1490dc9271f31d40db1f63d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: I created several Workloads which require up to ten ports for both UDP and TCP protocol. Now my logs get spammed with . What you expected to happen: should consider -combination instead of only . How to reproduce it (as minimally and precisely as possible): Deploy any service with a node-port with both protocols, e.g.: Anything else we need to know?: This was already acknowledged by here: However, as this thread addresses a different bug and seems kind of stuck, i'd like to suggest that this might be addressed in a new context. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Deployed via Rancher v2.4.3\n/sig api-machinery\n/remove-sig api-machinery /sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\nHow did you get into this situation? The allocator should not have granted the same node port twice?\nOh right, that issue. The only real way out is to de-allocate the NodePorts and then re-allocate them, I think\nAs this happens for all of my ports in the said Production Application (the one where my log gets spammed) as well as complete fresh installation (where i verified the bug), i think there's no \"way out\" except fixing the bug. As said, for me it's necessary to assign both protocols to the same port. This might be a niche-use-case, but checking the it's actually very likely for ports to allow tcp AND udp. I'm not sure about the history of this, but it might be that issue was the origin, which was adressed in PR (\"Allow services which use same port, different protocol to use the same nodePort for both\"). But this PR doesn't contain the adjustment of the said , so still considers the behaviour as invalid, while it's actually allowed and supported.\n/assign\nAhh, I thought you meant that you had accidentally been allocated the same nodePorts and I was very confused when you said \"all of them\". I have reproduced this issue, and I can see it by inspection. The obvious fix would be to collect ports split by protocol, but I think that's not right since we don't store it split. An even simpler fix would be for to build a . Then for each protocol, for each port, build that contains all the port numbers, but remove any duplicates ONLY IF they are duplicated across protocols. Duplicates in the same protocol should be retained (to report an error later). I don't have time to tackle this tonight (and write a test), but it seems like a good bug.\nperhaps I can fix this problem /assign\nthings may be a little more complicated. Right now the is not aware of the protocol of the port so I guess simply rewriting function to return is not enough, the port allocator will still return on same node port even with different protocol. perhaps we need to refactor the to make it protocol-aware.\nI don't think we need to do make the allocator be protocol aware. IIRC we allow you to use the same nodeport on different protocols ONLY within a single service. This means (I think) that we can do hyper-local deduplication as we collect the nodeports for each service. If we find the same nodeport number with different protocols, just remove the duplicates because it is allowed. I.e. a service that looks like: return - deduped. if ANY OTHER service tried to use it would be an error at the \"rebuilt\" allocator Likewise if a single Service claims to use the same nodeport number more than once on the same protocol, it should be an error: return - NOT deduped.\nobviously, we want a great unit test here :P\nah got it! thanks for your detailed explanation!\nHi! I have filed a PR to resolve this issue, could you take a look?", "positive_passages": [{"docid": "doc-en-kubernetes-f0ca2c87c1f9890ea3d6b385e3be0c7ea12642650ac0fb57e159d06c3d6b97bc", "text": "metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/util/net\" \"k8s.io/apimachinery/pkg/util/runtime\" <ins> \"k8s.io/apimachinery/pkg/util/sets\" </ins> \"k8s.io/apimachinery/pkg/util/wait\" corev1client \"k8s.io/client-go/kubernetes/typed/core/v1\" \"k8s.io/client-go/tools/record\"", "commid": "kubernetes_pr_91590"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04a7465ce5cc37d6e8b4f5a3688fe336581dbf09f1490dc9271f31d40db1f63d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: I created several Workloads which require up to ten ports for both UDP and TCP protocol. Now my logs get spammed with . What you expected to happen: should consider -combination instead of only . How to reproduce it (as minimally and precisely as possible): Deploy any service with a node-port with both protocols, e.g.: Anything else we need to know?: This was already acknowledged by here: However, as this thread addresses a different bug and seems kind of stuck, i'd like to suggest that this might be addressed in a new context. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Deployed via Rancher v2.4.3\n/sig api-machinery\n/remove-sig api-machinery /sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\nHow did you get into this situation? The allocator should not have granted the same node port twice?\nOh right, that issue. The only real way out is to de-allocate the NodePorts and then re-allocate them, I think\nAs this happens for all of my ports in the said Production Application (the one where my log gets spammed) as well as complete fresh installation (where i verified the bug), i think there's no \"way out\" except fixing the bug. As said, for me it's necessary to assign both protocols to the same port. This might be a niche-use-case, but checking the it's actually very likely for ports to allow tcp AND udp. I'm not sure about the history of this, but it might be that issue was the origin, which was adressed in PR (\"Allow services which use same port, different protocol to use the same nodePort for both\"). But this PR doesn't contain the adjustment of the said , so still considers the behaviour as invalid, while it's actually allowed and supported.\n/assign\nAhh, I thought you meant that you had accidentally been allocated the same nodePorts and I was very confused when you said \"all of them\". I have reproduced this issue, and I can see it by inspection. The obvious fix would be to collect ports split by protocol, but I think that's not right since we don't store it split. An even simpler fix would be for to build a . Then for each protocol, for each port, build that contains all the port numbers, but remove any duplicates ONLY IF they are duplicated across protocols. Duplicates in the same protocol should be retained (to report an error later). I don't have time to tackle this tonight (and write a test), but it seems like a good bug.\nperhaps I can fix this problem /assign\nthings may be a little more complicated. Right now the is not aware of the protocol of the port so I guess simply rewriting function to return is not enough, the port allocator will still return on same node port even with different protocol. perhaps we need to refactor the to make it protocol-aware.\nI don't think we need to do make the allocator be protocol aware. IIRC we allow you to use the same nodeport on different protocols ONLY within a single service. This means (I think) that we can do hyper-local deduplication as we collect the nodeports for each service. If we find the same nodeport number with different protocols, just remove the duplicates because it is allowed. I.e. a service that looks like: return - deduped. if ANY OTHER service tried to use it would be an error at the \"rebuilt\" allocator Likewise if a single Service claims to use the same nodeport number more than once on the same protocol, it should be an error: return - NOT deduped.\nobviously, we want a great unit test here :P\nah got it! thanks for your detailed explanation!\nHi! I have filed a PR to resolve this issue, could you take a look?", "positive_passages": [{"docid": "doc-en-kubernetes-20644f7f031ef6c8714dc2df2cab74c03aea4af1b81f26171d757f8b2fc3c201", "text": "return nil } <ins> // collectServiceNodePorts returns nodePorts specified in the Service. // Please note that: //   1. same nodePort with *same* protocol will be duplicated as it is //   2. same nodePort with *different* protocol will be deduplicated </ins> func collectServiceNodePorts(service *corev1.Service) []int { <del> servicePorts := []int{} for i := range service.Spec.Ports { servicePort := &service.Spec.Ports[i] if servicePort.NodePort != 0 { servicePorts = append(servicePorts, int(servicePort.NodePort)) </del> <ins> var servicePorts []int // map from nodePort to set of protocols seen := make(map[int]sets.String) for _, port := range service.Spec.Ports { nodePort := int(port.NodePort) if nodePort == 0 { continue } proto := string(port.Protocol) s := seen[nodePort] if s == nil { // have not seen this nodePort before s = sets.NewString(proto) servicePorts = append(servicePorts, nodePort) } else if s.Has(proto) { // same nodePort with same protocol servicePorts = append(servicePorts, nodePort) } else { // same nodePort with different protocol s.Insert(proto) </ins> } <ins> seen[nodePort] = s </ins> } <del> if service.Spec.HealthCheckNodePort != 0 { servicePorts = append(servicePorts, int(service.Spec.HealthCheckNodePort)) </del> <ins> healthPort := int(service.Spec.HealthCheckNodePort) if healthPort != 0 { s := seen[healthPort] // TODO: is it safe to assume the protocol is always TCP? if s == nil || s.Has(string(corev1.ProtocolTCP)) { servicePorts = append(servicePorts, healthPort) } </ins> } return servicePorts", "commid": "kubernetes_pr_91590"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04a7465ce5cc37d6e8b4f5a3688fe336581dbf09f1490dc9271f31d40db1f63d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: I created several Workloads which require up to ten ports for both UDP and TCP protocol. Now my logs get spammed with . What you expected to happen: should consider -combination instead of only . How to reproduce it (as minimally and precisely as possible): Deploy any service with a node-port with both protocols, e.g.: Anything else we need to know?: This was already acknowledged by here: However, as this thread addresses a different bug and seems kind of stuck, i'd like to suggest that this might be addressed in a new context. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Deployed via Rancher v2.4.3\n/sig api-machinery\n/remove-sig api-machinery /sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\nHow did you get into this situation? The allocator should not have granted the same node port twice?\nOh right, that issue. The only real way out is to de-allocate the NodePorts and then re-allocate them, I think\nAs this happens for all of my ports in the said Production Application (the one where my log gets spammed) as well as complete fresh installation (where i verified the bug), i think there's no \"way out\" except fixing the bug. As said, for me it's necessary to assign both protocols to the same port. This might be a niche-use-case, but checking the it's actually very likely for ports to allow tcp AND udp. I'm not sure about the history of this, but it might be that issue was the origin, which was adressed in PR (\"Allow services which use same port, different protocol to use the same nodePort for both\"). But this PR doesn't contain the adjustment of the said , so still considers the behaviour as invalid, while it's actually allowed and supported.\n/assign\nAhh, I thought you meant that you had accidentally been allocated the same nodePorts and I was very confused when you said \"all of them\". I have reproduced this issue, and I can see it by inspection. The obvious fix would be to collect ports split by protocol, but I think that's not right since we don't store it split. An even simpler fix would be for to build a . Then for each protocol, for each port, build that contains all the port numbers, but remove any duplicates ONLY IF they are duplicated across protocols. Duplicates in the same protocol should be retained (to report an error later). I don't have time to tackle this tonight (and write a test), but it seems like a good bug.\nperhaps I can fix this problem /assign\nthings may be a little more complicated. Right now the is not aware of the protocol of the port so I guess simply rewriting function to return is not enough, the port allocator will still return on same node port even with different protocol. perhaps we need to refactor the to make it protocol-aware.\nI don't think we need to do make the allocator be protocol aware. IIRC we allow you to use the same nodeport on different protocols ONLY within a single service. This means (I think) that we can do hyper-local deduplication as we collect the nodeports for each service. If we find the same nodeport number with different protocols, just remove the duplicates because it is allowed. I.e. a service that looks like: return - deduped. if ANY OTHER service tried to use it would be an error at the \"rebuilt\" allocator Likewise if a single Service claims to use the same nodeport number more than once on the same protocol, it should be an error: return - NOT deduped.\nobviously, we want a great unit test here :P\nah got it! thanks for your detailed explanation!\nHi! I have filed a PR to resolve this issue, could you take a look?", "positive_passages": [{"docid": "doc-en-kubernetes-81608425dfcbd2e96c854a2c42df027809867c7435e640ade348ea730f341be9", "text": "import ( \"fmt\" <ins> \"reflect\" \"sort\" </ins> \"strings\" \"testing\"", "commid": "kubernetes_pr_91590"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04a7465ce5cc37d6e8b4f5a3688fe336581dbf09f1490dc9271f31d40db1f63d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: I created several Workloads which require up to ten ports for both UDP and TCP protocol. Now my logs get spammed with . What you expected to happen: should consider -combination instead of only . How to reproduce it (as minimally and precisely as possible): Deploy any service with a node-port with both protocols, e.g.: Anything else we need to know?: This was already acknowledged by here: However, as this thread addresses a different bug and seems kind of stuck, i'd like to suggest that this might be addressed in a new context. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Deployed via Rancher v2.4.3\n/sig api-machinery\n/remove-sig api-machinery /sig network\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\nHow did you get into this situation? The allocator should not have granted the same node port twice?\nOh right, that issue. The only real way out is to de-allocate the NodePorts and then re-allocate them, I think\nAs this happens for all of my ports in the said Production Application (the one where my log gets spammed) as well as complete fresh installation (where i verified the bug), i think there's no \"way out\" except fixing the bug. As said, for me it's necessary to assign both protocols to the same port. This might be a niche-use-case, but checking the it's actually very likely for ports to allow tcp AND udp. I'm not sure about the history of this, but it might be that issue was the origin, which was adressed in PR (\"Allow services which use same port, different protocol to use the same nodePort for both\"). But this PR doesn't contain the adjustment of the said , so still considers the behaviour as invalid, while it's actually allowed and supported.\n/assign\nAhh, I thought you meant that you had accidentally been allocated the same nodePorts and I was very confused when you said \"all of them\". I have reproduced this issue, and I can see it by inspection. The obvious fix would be to collect ports split by protocol, but I think that's not right since we don't store it split. An even simpler fix would be for to build a . Then for each protocol, for each port, build that contains all the port numbers, but remove any duplicates ONLY IF they are duplicated across protocols. Duplicates in the same protocol should be retained (to report an error later). I don't have time to tackle this tonight (and write a test), but it seems like a good bug.\nperhaps I can fix this problem /assign\nthings may be a little more complicated. Right now the is not aware of the protocol of the port so I guess simply rewriting function to return is not enough, the port allocator will still return on same node port even with different protocol. perhaps we need to refactor the to make it protocol-aware.\nI don't think we need to do make the allocator be protocol aware. IIRC we allow you to use the same nodeport on different protocols ONLY within a single service. This means (I think) that we can do hyper-local deduplication as we collect the nodeports for each service. If we find the same nodeport number with different protocols, just remove the duplicates because it is allowed. I.e. a service that looks like: return - deduped. if ANY OTHER service tried to use it would be an error at the \"rebuilt\" allocator Likewise if a single Service claims to use the same nodeport number more than once on the same protocol, it should be an error: return - NOT deduped.\nobviously, we want a great unit test here :P\nah got it! thanks for your detailed explanation!\nHi! I have filed a PR to resolve this issue, could you take a look?", "positive_passages": [{"docid": "doc-en-kubernetes-04ca28e209619b51de2fc00ab3155bf930e55991a0c8a1b712ecaf344bf00a5a", "text": "t.Errorf(\"unexpected portallocator state: %d free\", free) } } <ins> func TestCollectServiceNodePorts(t *testing.T) { tests := []struct { name        string serviceSpec corev1.ServiceSpec expected    []int }{ { name: \"no duplicated nodePorts\", serviceSpec: corev1.ServiceSpec{ Ports: []corev1.ServicePort{ {NodePort: 111, Protocol: corev1.ProtocolTCP}, {NodePort: 112, Protocol: corev1.ProtocolUDP}, {NodePort: 113, Protocol: corev1.ProtocolUDP}, }, }, expected: []int{111, 112, 113}, }, { name: \"duplicated nodePort with TCP protocol\", serviceSpec: corev1.ServiceSpec{ Ports: []corev1.ServicePort{ {NodePort: 111, Protocol: corev1.ProtocolTCP}, {NodePort: 111, Protocol: corev1.ProtocolTCP}, {NodePort: 112, Protocol: corev1.ProtocolUDP}, }, }, expected: []int{111, 111, 112}, }, { name: \"duplicated nodePort with UDP protocol\", serviceSpec: corev1.ServiceSpec{ Ports: []corev1.ServicePort{ {NodePort: 111, Protocol: corev1.ProtocolUDP}, {NodePort: 111, Protocol: corev1.ProtocolUDP}, {NodePort: 112, Protocol: corev1.ProtocolTCP}, }, }, expected: []int{111, 111, 112}, }, { name: \"duplicated nodePort with different protocol\", serviceSpec: corev1.ServiceSpec{ Ports: []corev1.ServicePort{ {NodePort: 111, Protocol: corev1.ProtocolTCP}, {NodePort: 112, Protocol: corev1.ProtocolTCP}, {NodePort: 111, Protocol: corev1.ProtocolUDP}, }, }, expected: []int{111, 112}, }, { name: \"no duplicated port(with health check port)\", serviceSpec: corev1.ServiceSpec{ Ports: []corev1.ServicePort{ {NodePort: 111, Protocol: corev1.ProtocolTCP}, {NodePort: 112, Protocol: corev1.ProtocolUDP}, }, HealthCheckNodePort: 113, }, expected: []int{111, 112, 113}, }, { name: \"nodePort has different protocol with duplicated health check port\", serviceSpec: corev1.ServiceSpec{ Ports: []corev1.ServicePort{ {NodePort: 111, Protocol: corev1.ProtocolUDP}, {NodePort: 112, Protocol: corev1.ProtocolTCP}, }, HealthCheckNodePort: 111, }, expected: []int{111, 112}, }, { name: \"nodePort has same protocol as duplicated health check port\", serviceSpec: corev1.ServiceSpec{ Ports: []corev1.ServicePort{ {NodePort: 111, Protocol: corev1.ProtocolUDP}, {NodePort: 112, Protocol: corev1.ProtocolTCP}, }, HealthCheckNodePort: 112, }, expected: []int{111, 112, 112}, }, } for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { ports := collectServiceNodePorts(&corev1.Service{ ObjectMeta: metav1.ObjectMeta{Namespace: \"one\", Name: \"one\"}, Spec:       tc.serviceSpec, }) sort.Ints(ports) if !reflect.DeepEqual(tc.expected, ports) { t.Fatalf(\"Invalid resultnexpected: %vngot: %v\", tc.expected, ports) } }) } } </ins>", "commid": "kubernetes_pr_91590"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ab71f408e008080218422bbeafb97e78bd9dc60107a358858d77c0817cb34c3e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: add a CRD resource with kind only a single character while cause kube-apiserver crashslice bounds out of range What you expected to happen: add validation to limit CRD kind definition or fix the bug of slice out of bounds How to reproduce it (as minimally and precisely as possible): apiVersion: kind: CustomResourceDefinition metadata: name: spec: group: version: v1 names: kind: R plural: rs singular: r scope: Cluster Anything else we need to know?: apiserverlogs: 10:05:32. 6 ] Shutting down OpenAPI controller E6606 10:05:32. 6 ] Observed a panic: runtime.boundsError{x:-1, y:1, signed:true, code:0x3(runtime error: slice bounds out of range [-1:]) goroutine 1670 [running]: (0x41458a0, Gxc00ed66d40) /workspace/anago-v1.17.G- +0xa3 (0x0, 0x0, 0x0) /workspace/anago-v1.17.G- +0x82 panic(0x41458a0, Oxc0Oed66d40) +0x1b2 (0x7493232, 0x1, 0x447d778, 0x1, 0x130, 0xc00ed13680) /workspace/anago-v1.17.0- +0x2b8 (\"builder).descriptionFor(\u20acxc007b351f0, 0x0, 0x0, 0x4481982, 0x6, Gxc00ed06d00, 0x18) /workspace/anago-v1.17.0- +0x3c6 (\"builder).buildRoute(GxcGG7b351fG, 0xc00ed66d00, 0x18, 0x0, 0x0, 0x447f0F3, 0x4, 0x447f71b, 0x4, 0x4481982, ...) /workspace/anago-v1.17.0- .go :281 +0x197 (0xc66b7bcfd0, 0xc005d24a3c, 0x2, 0x101, 0x1, 0x2, Gxc60b76aec8) /workspace/anago-v1.17.0-rc .2.10+70132b0F130acc/src/k8s .io/kubernetes/output/dockerized/go/src/k8s .io/kubernetes/vendor/k8s .io/apiextensions-apiserver/pkg/controller/openapi/builder/builder .go :146 +0x49d (0xc66b7bcfd0, 0x0, Oxb, Gx447f1db, 0x4, 0x1) /workspace/anago-v1.17.0- +0x1a8 (\"Controller).Run(0xc0012c8050, Gxc0G1d61200, 0xc007a6d1e0, 0xc069cced80) /workspace/anago-v1.17.0- +0x2da created by /workspace/anago-v1.17.0- .go :236 +0x244 panic: runtime error: slice bounds out of range [-1:] [recovered] panic: runtime error: slice bounds out of range [-1:] Environment: Kubernetes version (use ): 1.18.0 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ):Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig apps\n/assign\nThere is a typo in the subject.", "positive_passages": [{"docid": "doc-en-kubernetes-9fbbb84effe798a2de84ca922d663adf1b33bdb6fa315bc0c822772b5f92020a", "text": "// GetArticleForNoun returns the article needed for the given noun. func GetArticleForNoun(noun string, padding string) string { <del> if noun[len(noun)-2:] != \"ss\" && noun[len(noun)-1:] == \"s\" { </del> <ins> if !strings.HasSuffix(noun, \"ss\") && strings.HasSuffix(noun, \"s\") { </ins> // Plurals don't have an article. // Don't catch words like class return fmt.Sprintf(\"%v\", padding)", "commid": "kubernetes_pr_91859"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ab71f408e008080218422bbeafb97e78bd9dc60107a358858d77c0817cb34c3e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: add a CRD resource with kind only a single character while cause kube-apiserver crashslice bounds out of range What you expected to happen: add validation to limit CRD kind definition or fix the bug of slice out of bounds How to reproduce it (as minimally and precisely as possible): apiVersion: kind: CustomResourceDefinition metadata: name: spec: group: version: v1 names: kind: R plural: rs singular: r scope: Cluster Anything else we need to know?: apiserverlogs: 10:05:32. 6 ] Shutting down OpenAPI controller E6606 10:05:32. 6 ] Observed a panic: runtime.boundsError{x:-1, y:1, signed:true, code:0x3(runtime error: slice bounds out of range [-1:]) goroutine 1670 [running]: (0x41458a0, Gxc00ed66d40) /workspace/anago-v1.17.G- +0xa3 (0x0, 0x0, 0x0) /workspace/anago-v1.17.G- +0x82 panic(0x41458a0, Oxc0Oed66d40) +0x1b2 (0x7493232, 0x1, 0x447d778, 0x1, 0x130, 0xc00ed13680) /workspace/anago-v1.17.0- +0x2b8 (\"builder).descriptionFor(\u20acxc007b351f0, 0x0, 0x0, 0x4481982, 0x6, Gxc00ed06d00, 0x18) /workspace/anago-v1.17.0- +0x3c6 (\"builder).buildRoute(GxcGG7b351fG, 0xc00ed66d00, 0x18, 0x0, 0x0, 0x447f0F3, 0x4, 0x447f71b, 0x4, 0x4481982, ...) /workspace/anago-v1.17.0- .go :281 +0x197 (0xc66b7bcfd0, 0xc005d24a3c, 0x2, 0x101, 0x1, 0x2, Gxc60b76aec8) /workspace/anago-v1.17.0-rc .2.10+70132b0F130acc/src/k8s .io/kubernetes/output/dockerized/go/src/k8s .io/kubernetes/vendor/k8s .io/apiextensions-apiserver/pkg/controller/openapi/builder/builder .go :146 +0x49d (0xc66b7bcfd0, 0x0, Oxb, Gx447f1db, 0x4, 0x1) /workspace/anago-v1.17.0- +0x1a8 (\"Controller).Run(0xc0012c8050, Gxc0G1d61200, 0xc007a6d1e0, 0xc069cced80) /workspace/anago-v1.17.0- +0x2da created by /workspace/anago-v1.17.0- .go :236 +0x244 panic: runtime error: slice bounds out of range [-1:] [recovered] panic: runtime error: slice bounds out of range [-1:] Environment: Kubernetes version (use ): 1.18.0 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ):Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig apps\n/assign\nThere is a typo in the subject.", "positive_passages": [{"docid": "doc-en-kubernetes-ee39e1a28d62a8c5ed373220fb8d0325c568da694b330437b8c69f95ce4b4f7c", "text": "padding: \" \", want:    \" a \", }, <ins> { noun:    \"S\", padding: \" \", want:    \" a \", }, { noun:    \"O\", padding: \" \", want:    \" an \", }, </ins> } for _, tt := range tests { if got := GetArticleForNoun(tt.noun, tt.padding); got != tt.want {", "commid": "kubernetes_pr_91859"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-96914a35e7b0e014c5e344e430617ac0eb0a5cf91e6bc5fb60b57bece6b152e8", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: Which test(s) are failing: Since when has it been failing: Testgrid link: Reason for failure: Anything else we need to know: /sig testing /cc /priority critical-urgent /milestone v1.19\n/assign\nI see the PR merged, however, the job still failing in the recent run 22:31 PDT Failures for bootstrap-e2e-minion-group (if any): W0611 06:08:56.190] 2020/06/11 06:08:56 Step './cluster/log-dump/log- /workspace/artifacts' finished in 2m14.442417098s W0611 06:08:44.597] ERROR: () [/usr/bin/scp] exited with return code [1]. W0611 06:08:46.070] scp: No such file or directory W0611 06:08:46.070] scp: /var/log/node-problem- No such file or directory W0611 06:08:46.072] scp: No such file or directory W0611 06:08:46.072] scp: No such file or directory W0611 06:08:46.073] scp: No such file or directory W0611 06:08:46.074] scp: /var/log/node-problem- No such file or directory W0611 06:08:46.075] scp: No such file or directory W0611 06:08:46.075] scp: No such file or directory W0611 06:08:46.079] ERROR: () [/usr/bin/scp] exited with return code [1]. W0611 06:08:46.084] ERROR: () [/usr/bin/scp] exited with return code [1]. W0611 06:08:51.917] INSTANCEGROUPS=bootstrap-e2e-minion-group W0611 06:08:51.918] NODENAMES=bootstrap-e2e-minion-group-dq3m bootstrap-e2e-minion-group-gjk0 bootstrap-e2e-minion-group-qpxw I0611 06:08:54.017] Failures for bootstrap-e2e-minion-group (if any): W0611 06:08:56.190] 2020/06/11 06:08:56 Step './cluster/log-dump/log- /workspace/artifacts' finished in 2m14.442417098s W0611 06:08:56.191] 2020/06/11 06:08:56 Running: ./hack/e2e-internal/e2e-\nI see the issue closed by the PR however the job still failing since 06-10 16:31 PDT\nlooks like we just turned green :)\ncool! :)\nYes it's indeed ... thanks for the support!", "positive_passages": [{"docid": "doc-en-kubernetes-e208a5036af79ee7fb2a405a6fd5336cb6bc317c7941b358d6628504e8e9928a", "text": "# Set default values with override if [[ \"${CONTAINER_RUNTIME}\" == \"docker\" ]]; then <del> export CONTAINER_RUNTIME_ENDPOINT=${KUBE_CONTAINER_RUNTIME_ENDPOINT:-unix:///var/run/docker.sock} </del> <ins> export CONTAINER_RUNTIME_ENDPOINT=${KUBE_CONTAINER_RUNTIME_ENDPOINT:-unix:///var/run/dockershim.sock} </ins> export CONTAINER_RUNTIME_NAME=${KUBE_CONTAINER_RUNTIME_NAME:-docker} export LOAD_IMAGE_COMMAND=${KUBE_LOAD_IMAGE_COMMAND:-} elif [[ \"${CONTAINER_RUNTIME}\" == \"containerd\" ]]; then", "commid": "kubernetes_pr_92031"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0b006d7026e2b9b88292d9991e285eb8c6e152091f24ce82370f6211f56b3dec", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: https://k8s- Which test(s) are failing: sig-network] SCTP [Feature:SCTP] [LinuxOnly] should create a Pod with SCTP HostPort Since when has it been failing: Test [sig-network] SCTP [Feature:SCTP] [LinuxOnly] should create a Pod with SCTP HostPort has failed 3 times since it last passed at commit/. It started failing between commit/ (Tue Jun 09 13:25 PDT) and commit/ (Wed Jun 10 01:26 PDT): Testgrid link: https://k8s- Reason for failure: Anything else we need to know: I'm not sure if we already did it but there was a proposal to change from dockershim to containerd for the GCE jobs\nThere are no sig labels on this issue. Please add an appropriate label by using one of the following commands: - Please see the for a listing of the SIGs, working groups, and committees available. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign /cc\nGitHub didn't allow me to assign the following users: janosi. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign /cc Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nyes, that would break us... the test checks \"are we using kubenet\", but it didn't occur to me that we would need to deal with kubenet with CRI instead of kubenet with dockershim. It should be easy to make it check for both the dockershim rule and the CNI portmap rule though...\nyes, according to the \"Changes\" link on the dashboard, containerd replaced docker in GCE right before the failures.\nLet's see if I can make it :)\nSo actually the test is pretty generic (it just looks for and ) and it seems like it ought to pass correctly with CNI portmap too. I'm not sure what's failing. You may need to add some debugging...\nOK, so as I can see, containerd's CRI implementation just ignores all HostPort definitions that do not have TCP or UDP Protocol value. I.e. containerd will not send HostPort mapping definitions to the CNI if the protocol is not TCP or UDP.\nseems this is the reason why sctp was skipped\nYes, exactly. Introduced right after SCTP support was merged in k8s. Just found this in the package: Though not sure it \"knows\" the right runtime at runtime, because there is no user of it in :)\njust curious, why do we skip in containerd and allow it with dockershim?\nHmm, do you mean why do not we skip in case of containerd? The reason is that I did not remember that containerd PR about the SCTP support. Let's see if I can skip it.\nHm, that is not true. My search engine was wrong. After a restart I found usage of that in e2e_node\nHas a bug been filed upstream in containerd? Just skipping the tests seems like the wrong approach here.\nsorry, I meant why we are not allowing it in containerd, does this feature should work in all container runtimes? CRIO, docker and containerd? if affirmative, we can submit a PR to containerd/cri to allow SCTP, I can do it if you don't have time\nExcuse me, I misunderstood your question. Yep, why not. I mean, it could work in all container runtimes. As I understand the containerd implementation is based on a misunderstanding: that the host port mapping loads the SCTP kernel module and that would be bad for those apps that want to use user space SCTP. But as long as there is no SCTP socket created on a node the SCTP kernel module is not loaded.\nI can initiate a discussion with containerd about this.\nseems this dates back to the original SCTP KEP, seems like it should be a pretty simple fix (?) thanks for filing the bug and for the details there!\nCRI-O seems to have the same issue:\nJust confirming you want this filter to be gone now. Or do you need the filter to be manageable in some way.. filtered by a config switch?\nFor TCP and UDP HostPorts, the runtime is expected to do two things: a listening socket on that port so the kernel will think it's in use and not allocate it to anyone else iptables rules (or whatever) to route traffic from the host port to the container port For SCTP HostPorts, the runtime should do the second part (iptables rules), but should not do the first part (listening socket), for two reasons: Some users want to use \"userspace SCTP\", in which case they will be referring to SCTP at the Kubernetes level but need to keep the kernel module from ever being loaded. (This is discussed more .) If is not loaded when Kubernetes starts, we want to avoid having Kubernetes itself cause it to be auto-loaded, for security reasons. (More discussion of this .) So, runtimes should be filtering out SCTP for the opening-listening-sockets part, but not for the making-iptables-rules part. (Some implementations, notably CNI , don't actually do the opening-listening-sockets part, so they wouldn't be filtering at all.)\nExactly. The current state in the runtimes: Docker (dockershim, actually): OK. The logic was implemented together with the basic SCTP feature, so listening on the host port is filtered for SCTP, but the iptables rules are created Containerd (CRI, actually): the patch which was applied 2 years ago filters out every SCTP host port handling, because it filters SCTP ports from the list of port mappings that are passed to CNI (portmap) later. Actually, containerd (CRI) does not perform the \"listen\" part at all, so the patch is not needed at all CRI-O: the patch applied 2 years ago filters out everything. CRI-O imports the host port manager implementation from kubelet/dockershim. For this reason it has the logic that can filter out SCTP ports from the \"listen\" part, but still applies the iptables rules. I.e. the patch is not needed in CRI-O either.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale The test is flaky now :thinking: https://k8s-\nI guess it is a timing issue? Do you think some extra polling rounds would help? (I did not disappear, but currently I am very loaded with my regular job...)\nI've submitted a PR to fix it and another one to test the sctp connectivity, please review them, I've pinged you there :smile:", "positive_passages": [{"docid": "doc-en-kubernetes-2359a283211f452be8e2b746458287b5643b2f421310d3df06d6ca6354ddf2f7", "text": "err := cs.CoreV1().Pods(f.Namespace.Name).Delete(context.TODO(), podName, metav1.DeleteOptions{}) framework.ExpectNoError(err, \"failed to delete pod: %s in namespace: %s\", podName, f.Namespace.Name) }() <del> ginkgo.By(\"dumping iptables rules on the node\") </del> <ins> // wait until host port manager syncs rules </ins> cmd = \"sudo iptables-save\" <del> framework.Logf(\"Executing cmd %q on node %v\", cmd, node.Name) result, err := hostExec.IssueCommandWithResult(cmd, node) if err != nil { framework.Failf(\"Interrogation of iptables rules failed on node %v\", node.Name) </del> <ins> if framework.TestContext.ClusterIsIPv6() { cmd = \"sudo ip6tables-save\" </ins> } <ins> err = wait.PollImmediate(framework.Poll, framework.PollShortTimeout, func() (bool, error) { framework.Logf(\"Executing cmd %q on node %v\", cmd, node.Name) result, err := hostExec.IssueCommandWithResult(cmd, node) if err != nil { framework.Logf(\"Interrogation of iptables rules failed on node %v\", node.Name) return false, nil } </ins> <del> ginkgo.By(\"checking that iptables contains the necessary iptables rules\") found := false for _, line := range strings.Split(result, \"n\") { if strings.Contains(line, \"-p sctp\") && strings.Contains(line, \"--dport 5060\") { found = true break </del> <ins> for _, line := range strings.Split(result, \"n\") { if strings.Contains(line, \"-p sctp\") && strings.Contains(line, \"--dport 5060\") { return true, nil } </ins> } <del> } if !found { </del> <ins> framework.Logf(\"retrying ... not hostport sctp iptables rules found on node %v\", node.Name) return false, nil }) if err != nil { </ins> framework.Failf(\"iptables rules are not set for a pod with sctp hostport\") } ginkgo.By(\"validating sctp module is still not loaded\")", "commid": "kubernetes_pr_94828"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0b006d7026e2b9b88292d9991e285eb8c6e152091f24ce82370f6211f56b3dec", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: https://k8s- Which test(s) are failing: sig-network] SCTP [Feature:SCTP] [LinuxOnly] should create a Pod with SCTP HostPort Since when has it been failing: Test [sig-network] SCTP [Feature:SCTP] [LinuxOnly] should create a Pod with SCTP HostPort has failed 3 times since it last passed at commit/. It started failing between commit/ (Tue Jun 09 13:25 PDT) and commit/ (Wed Jun 10 01:26 PDT): Testgrid link: https://k8s- Reason for failure: Anything else we need to know: I'm not sure if we already did it but there was a proposal to change from dockershim to containerd for the GCE jobs\nThere are no sig labels on this issue. Please add an appropriate label by using one of the following commands: - Please see the for a listing of the SIGs, working groups, and committees available. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign /cc\nGitHub didn't allow me to assign the following users: janosi. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign /cc Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nyes, that would break us... the test checks \"are we using kubenet\", but it didn't occur to me that we would need to deal with kubenet with CRI instead of kubenet with dockershim. It should be easy to make it check for both the dockershim rule and the CNI portmap rule though...\nyes, according to the \"Changes\" link on the dashboard, containerd replaced docker in GCE right before the failures.\nLet's see if I can make it :)\nSo actually the test is pretty generic (it just looks for and ) and it seems like it ought to pass correctly with CNI portmap too. I'm not sure what's failing. You may need to add some debugging...\nOK, so as I can see, containerd's CRI implementation just ignores all HostPort definitions that do not have TCP or UDP Protocol value. I.e. containerd will not send HostPort mapping definitions to the CNI if the protocol is not TCP or UDP.\nseems this is the reason why sctp was skipped\nYes, exactly. Introduced right after SCTP support was merged in k8s. Just found this in the package: Though not sure it \"knows\" the right runtime at runtime, because there is no user of it in :)\njust curious, why do we skip in containerd and allow it with dockershim?\nHmm, do you mean why do not we skip in case of containerd? The reason is that I did not remember that containerd PR about the SCTP support. Let's see if I can skip it.\nHm, that is not true. My search engine was wrong. After a restart I found usage of that in e2e_node\nHas a bug been filed upstream in containerd? Just skipping the tests seems like the wrong approach here.\nsorry, I meant why we are not allowing it in containerd, does this feature should work in all container runtimes? CRIO, docker and containerd? if affirmative, we can submit a PR to containerd/cri to allow SCTP, I can do it if you don't have time\nExcuse me, I misunderstood your question. Yep, why not. I mean, it could work in all container runtimes. As I understand the containerd implementation is based on a misunderstanding: that the host port mapping loads the SCTP kernel module and that would be bad for those apps that want to use user space SCTP. But as long as there is no SCTP socket created on a node the SCTP kernel module is not loaded.\nI can initiate a discussion with containerd about this.\nseems this dates back to the original SCTP KEP, seems like it should be a pretty simple fix (?) thanks for filing the bug and for the details there!\nCRI-O seems to have the same issue:\nJust confirming you want this filter to be gone now. Or do you need the filter to be manageable in some way.. filtered by a config switch?\nFor TCP and UDP HostPorts, the runtime is expected to do two things: a listening socket on that port so the kernel will think it's in use and not allocate it to anyone else iptables rules (or whatever) to route traffic from the host port to the container port For SCTP HostPorts, the runtime should do the second part (iptables rules), but should not do the first part (listening socket), for two reasons: Some users want to use \"userspace SCTP\", in which case they will be referring to SCTP at the Kubernetes level but need to keep the kernel module from ever being loaded. (This is discussed more .) If is not loaded when Kubernetes starts, we want to avoid having Kubernetes itself cause it to be auto-loaded, for security reasons. (More discussion of this .) So, runtimes should be filtering out SCTP for the opening-listening-sockets part, but not for the making-iptables-rules part. (Some implementations, notably CNI , don't actually do the opening-listening-sockets part, so they wouldn't be filtering at all.)\nExactly. The current state in the runtimes: Docker (dockershim, actually): OK. The logic was implemented together with the basic SCTP feature, so listening on the host port is filtered for SCTP, but the iptables rules are created Containerd (CRI, actually): the patch which was applied 2 years ago filters out every SCTP host port handling, because it filters SCTP ports from the list of port mappings that are passed to CNI (portmap) later. Actually, containerd (CRI) does not perform the \"listen\" part at all, so the patch is not needed at all CRI-O: the patch applied 2 years ago filters out everything. CRI-O imports the host port manager implementation from kubelet/dockershim. For this reason it has the logic that can filter out SCTP ports from the \"listen\" part, but still applies the iptables rules. I.e. the patch is not needed in CRI-O either.\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale The test is flaky now :thinking: https://k8s-\nI guess it is a timing issue? Do you think some extra polling rounds would help? (I did not disappear, but currently I am very loaded with my regular job...)\nI've submitted a PR to fix it and another one to test the sctp connectivity, please review them, I've pinged you there :smile:", "positive_passages": [{"docid": "doc-en-kubernetes-3da5748301900987f14d0c77a246e058d45eafe54714dc39372d290841d4a6f0", "text": "err = e2enetwork.WaitForService(f.ClientSet, ns, serviceName, true, 5*time.Second, e2eservice.TestTimeout) framework.ExpectNoError(err, fmt.Sprintf(\"error while waiting for service:%s err: %v\", serviceName, err)) <del> ginkgo.By(\"dumping iptables rules on a node\") </del> hostExec := utils.NewHostExec(f) defer hostExec.Cleanup() node, err := e2enode.GetRandomReadySchedulableNode(cs) framework.ExpectNoError(err) cmd := \"sudo iptables-save\" <del> framework.Logf(\"Executing cmd %q on node %v\", cmd, node.Name) result, err := hostExec.IssueCommandWithResult(cmd, node) if err != nil { framework.Failf(\"Interrogation of iptables rules failed on node %v\", node.Name) </del> <ins> if framework.TestContext.ClusterIsIPv6() { cmd = \"sudo ip6tables-save\" </ins> } <ins> err = wait.PollImmediate(framework.Poll, e2eservice.KubeProxyLagTimeout, func() (bool, error) { framework.Logf(\"Executing cmd %q on node %v\", cmd, node.Name) result, err := hostExec.IssueCommandWithResult(cmd, node) if err != nil { framework.Logf(\"Interrogation of iptables rules failed on node %v\", node.Name) return false, nil } </ins> <del> ginkgo.By(\"checking that iptables contains the necessary iptables rules\") kubeService := false for _, line := range strings.Split(result, \"n\") { if strings.Contains(line, \"-A KUBE-SERVICES\") && strings.Contains(line, \"-p sctp\") { kubeService = true break </del> <ins> for _, line := range strings.Split(result, \"n\") { if strings.Contains(line, \"-A KUBE-SERVICES\") && strings.Contains(line, \"-p sctp\") { return true, nil } </ins> } <del> } if !kubeService { </del> <ins> framework.Logf(\"retrying ... no iptables rules found for service with sctp ports on node %v\", node.Name) return false, nil }) if err != nil { </ins> framework.Failf(\"iptables rules are not set for a clusterip service with sctp ports\") } ginkgo.By(\"validating sctp module is still not loaded\")", "commid": "kubernetes_pr_94828"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fad8ee5585f13cbd059c3b23e9b0beba24a9e5cc8dc4cbda61f103e29d873595", "query": "The purpose of the file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes in the event that a security issue related to the repository is discovered or disclosed. As described in the file, those on the list should agree to our . Please update the  file for the apimachinery repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user. The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo. See for more information /area security /committee product-security /kind cleanup /lifecycle frozen /priority important-soon /sig api-machinery", "positive_passages": [{"docid": "doc-en-kubernetes-9e65032d5be8d1eb334d7d135d9d0bd3b466ac135631274abed97cccfa3bb82f", "text": "# DO NOT REPORT SECURITY VULNERABILITIES DIRECTLY TO THESE NAMES, FOLLOW THE # INSTRUCTIONS AT https://kubernetes.io/security/ <del> cjcullen joelsmith liggitt philips </del> <ins> caesarxuchao deads2k lavalamp </ins> sttts <del> tallclair </del>", "commid": "kubernetes_pr_92768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fad8ee5585f13cbd059c3b23e9b0beba24a9e5cc8dc4cbda61f103e29d873595", "query": "The purpose of the file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes in the event that a security issue related to the repository is discovered or disclosed. As described in the file, those on the list should agree to our . Please update the  file for the apimachinery repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user. The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo. See for more information /area security /committee product-security /kind cleanup /lifecycle frozen /priority important-soon /sig api-machinery", "positive_passages": [{"docid": "doc-en-kubernetes-d20d3c4c7e590cfd60ac1f75c4b53673cd9bbca32e3294e6fb83435e05856d3b", "text": "# DO NOT REPORT SECURITY VULNERABILITIES DIRECTLY TO THESE NAMES, FOLLOW THE # INSTRUCTIONS AT https://kubernetes.io/security/ <del> cjcullen joelsmith liggitt philips </del> <ins> cheftako deads2k lavalamp </ins> sttts <del> tallclair </del>", "commid": "kubernetes_pr_92768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-33911e735262f8481400ca2430d671c6536468b71d87ed87bbe4f11626c79fd6", "query": "The purpose of the file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes in the event that a security issue related to the repository is discovered or disclosed. As described in the file, those on the list should agree to our . Please update the  file for the sample-apiserver repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user. The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo. See for more information /area security /committee product-security /kind cleanup /lifecycle frozen /priority important-soon /sig api-machinery", "positive_passages": [{"docid": "doc-en-kubernetes-9e65032d5be8d1eb334d7d135d9d0bd3b466ac135631274abed97cccfa3bb82f", "text": "# DO NOT REPORT SECURITY VULNERABILITIES DIRECTLY TO THESE NAMES, FOLLOW THE # INSTRUCTIONS AT https://kubernetes.io/security/ <del> cjcullen joelsmith liggitt philips </del> <ins> caesarxuchao deads2k lavalamp </ins> sttts <del> tallclair </del>", "commid": "kubernetes_pr_92768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-33911e735262f8481400ca2430d671c6536468b71d87ed87bbe4f11626c79fd6", "query": "The purpose of the file for each Kubernetes repository is to provide a list of people who can assist the Kubernetes in the event that a security issue related to the repository is discovered or disclosed. As described in the file, those on the list should agree to our . Please update the  file for the sample-apiserver repository. After finding people who are willing to work in this capacity, you should add them to the list, then remove PSC members (except any PSC member will be working as a security contact for this repository). The list is GitHub usernames, optionally followed by an email address. If no email address is listed, the PSC will use the email address found on git commits made by the listed user. The file may already have people listed who are secuirty contacts. In that case, simply remove any PSC members who aren't also security contacts for the repo. See for more information /area security /committee product-security /kind cleanup /lifecycle frozen /priority important-soon /sig api-machinery", "positive_passages": [{"docid": "doc-en-kubernetes-d20d3c4c7e590cfd60ac1f75c4b53673cd9bbca32e3294e6fb83435e05856d3b", "text": "# DO NOT REPORT SECURITY VULNERABILITIES DIRECTLY TO THESE NAMES, FOLLOW THE # INSTRUCTIONS AT https://kubernetes.io/security/ <del> cjcullen joelsmith liggitt philips </del> <ins> cheftako deads2k lavalamp </ins> sttts <del> tallclair </del>", "commid": "kubernetes_pr_92768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-92c02c7b117b26d0de6fc38be2278efcef8362879c74a9a2126914da420991a4", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: ci-kubernetes-e2e-aks-engine-azure-master-windows-2004 Which test(s) are failing: [] Container Runtime blackbox test when running a container with a new image should be able to pull from private registry with secret [NodeConformance] Since when has it been failing: since enabling the Windows 2004 SAC release tests Testgrid link: Reason for failure: The manifest for is missing the new windows server version 2004. This has occurred before: I looks like we need someone with appropriate permissions to update the manifests once the images are ready. Anything else we need to know: There was some work done in to automate some of this. Is there something missing? There are a few other tests that are failing in this job but should be covered by updating /cc /sig windows\nThe test passed 2x consecutively. We can close this now. /close\nClosing this issue. <detailsIn response to : The test passed 2x consecutively. We can close this now. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-b73b667c6757a1f028e21b0a4cb6fed6dbc778c532e2f694d597aa0f9eb8d08d", "text": "\"port\": 10001, \"labels\": { \"name\": \"redisslave\" <del> } </del> <ins> }, </ins> \"selector\": { \"name\": \"redisslave\" }", "commid": "kubernetes_pr_184"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1e994e5749edcd07edbd0f19c7df9185dabd2833b25fd1731e4d47ccf8dce07", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: pull-kubernetes-e2e-gce Which test(s) are flaking: Discovery should validate PreferredVersion for each APIGroup Testgrid link: Reason for failure: The test does not handle API groups which are or removed dynamically during the run of the test. Just because an API group is present in at the beginning of the test does not mean or will be present by the end of the test. This is particularly true for the dynamic/custom-resource API groups registered/unregistered during the e2e test run /sig api-machinery /assign\nmitigation opened at\nSaw this today in It seems to happen relatively often Likely due to the CRD created in: Should the ValidatingAdmissionPolicy test CRD have its group name template changed to match the existing test exclusion for groups ending in /cc", "positive_passages": [{"docid": "doc-en-kubernetes-f8bad76e6eb67ed972dc87604f81ab99a4bcebe934e7e5bad9316d817dfbec77", "text": "import ( \"context\" <ins> \"strings\" </ins> metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" utilversion \"k8s.io/apimachinery/pkg/util/version\" \"k8s.io/apiserver/pkg/endpoints/discovery\"", "commid": "kubernetes_pr_93216"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d1e994e5749edcd07edbd0f19c7df9185dabd2833b25fd1731e4d47ccf8dce07", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: pull-kubernetes-e2e-gce Which test(s) are flaking: Discovery should validate PreferredVersion for each APIGroup Testgrid link: Reason for failure: The test does not handle API groups which are or removed dynamically during the run of the test. Just because an API group is present in at the beginning of the test does not mean or will be present by the end of the test. This is particularly true for the dynamic/custom-resource API groups registered/unregistered during the e2e test run /sig api-machinery /assign\nmitigation opened at\nSaw this today in It seems to happen relatively often Likely due to the CRD created in: Should the ValidatingAdmissionPolicy test CRD have its group name template changed to match the existing test exclusion for groups ending in /cc", "positive_passages": [{"docid": "doc-en-kubernetes-58cfa79db15c0869c9d140c472c12933cb529008f1a39edb0c8cb31a44324efd", "text": "framework.ExpectNotEqual(len(list.Groups), 0, \"Missing APIGroups\") for _, group := range list.Groups { <ins> if strings.HasSuffix(group.Name, \".example.com\") { // ignore known example dynamic API groups that are added/removed during the e2e test run continue } </ins> framework.Logf(\"Checking APIGroup: %v\", group.Name) // locate APIGroup endpoint", "commid": "kubernetes_pr_93216"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-32f73fe3230f64533d19b392edefbaf0b0e1a8feaecfa7ce5826559c53a1a616", "query": "Which jobs are flaking: ci-kubernetes-node-kubelet-serial-hugepages Which test(s) are flaking: all Testgrid link: https://k8s- Reason for failure:\n/sig node\n/assign /cc\nGitHub didn't allow me to assign the following users: cynepco3hahue. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign /cc Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ntestgrid alert:\n/cc\nI started to look into logs and the issue that one of the kubelet restarts fails on: I will try to reproduce the issue locally.\nany news? Have you managed to reproduce the issue locally?\nI already have a fix that is waiting for merge -", "positive_passages": [{"docid": "doc-en-kubernetes-0132744d9d2e28d96bc6f1c64a6478043b0dd60ad6e5263b52be76874a3e48dc", "text": "func restartKubelet() { kubeletServiceName := findRunningKubletServiceName() <del> stdout, err := exec.Command(\"sudo\", \"systemctl\", \"restart\", kubeletServiceName).CombinedOutput() </del> <ins> // reset the kubelet service start-limit-hit stdout, err := exec.Command(\"sudo\", \"systemctl\", \"reset-failed\", kubeletServiceName).CombinedOutput() framework.ExpectNoError(err, \"Failed to reset kubelet start-limit-hit with systemctl: %v, %v\", err, stdout) stdout, err = exec.Command(\"sudo\", \"systemctl\", \"restart\", kubeletServiceName).CombinedOutput() </ins> framework.ExpectNoError(err, \"Failed to restart kubelet with systemctl: %v, %v\", err, stdout) }", "commid": "kubernetes_pr_93328"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8f9ac5fdef0c838965d475f11d5aa85a5be83149ab6d29c24d50d1d19652ecb3", "query": "What happened: This issue was originally reported via the Kubernetes HackerOne bug bounty by HackerOne user but we have decided that due to the high privileges required, it can be addressed publicly. A user able to create CRDs could create a malicious CRD such that listing CRs will cause enormous amounts of CPU usage on the API server. What you expected to happen: The function should not expand strings with more than two consecutive periods. Either it should collapse additional repeated periods or it should return an error. How to reproduce it (as minimally and precisely as possible): /kind bug /area apiserver /area security /committee product-security /priority important-longterm\nHow about we take it a step further by rejecting the jsonpath which contains when parsing it? as more than 2 periods seem to make no sense IMO\ngood idea. I have posted to do what you suggest.\n/sig api-machinery\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-b9318860de90b898b69d42bdeee89ea15d57774005ad0579f9bf0c29afa12030", "text": "{\"allarray\", \"{.Book[*].Author}\", storeData, \"Nigel Rees Evelyn Waugh Herman Melville\", false}, {\"allfields\", `{range .Bicycle[*]}{ \"{\" }{ @.* }{ \"} \" }{end}`, storeData, \"{red 19.95 true} {green 20.01 false} \", false}, {\"recurfields\", \"{..Price}\", storeData, \"8.95 12.99 8.99 19.95 20.01\", false}, <ins> {\"recurdotfields\", \"{...Price}\", storeData, \"8.95 12.99 8.99 19.95 20.01\", false}, {\"superrecurfields\", \"{............................................................Price}\", storeData, \"\", true}, </ins> {\"allstructsSlice\", \"{.Bicycle}\", storeData, `[{\"Color\":\"red\",\"Price\":19.95,\"IsNew\":true},{\"Color\":\"green\",\"Price\":20.01,\"IsNew\":false}]`, false}, {\"allstructs\", `{range .Bicycle[*]}{ @ }{ \" \" }{end}`, storeData,", "commid": "kubernetes_pr_93408"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8f9ac5fdef0c838965d475f11d5aa85a5be83149ab6d29c24d50d1d19652ecb3", "query": "What happened: This issue was originally reported via the Kubernetes HackerOne bug bounty by HackerOne user but we have decided that due to the high privileges required, it can be addressed publicly. A user able to create CRDs could create a malicious CRD such that listing CRs will cause enormous amounts of CPU usage on the API server. What you expected to happen: The function should not expand strings with more than two consecutive periods. Either it should collapse additional repeated periods or it should return an error. How to reproduce it (as minimally and precisely as possible): /kind bug /area apiserver /area security /committee product-security /priority important-longterm\nHow about we take it a step further by rejecting the jsonpath which contains when parsing it? as more than 2 periods seem to make no sense IMO\ngood idea. I have posted to do what you suggest.\n/sig api-machinery\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-43fd9eb6e7a13940084c13bf05333138c25462b4851581f0ff54d08ab5958181", "text": "return p.parseInsideAction(cur) } <del> // parseRecursive scans the recursive desent operator .. </del> <ins> // parseRecursive scans the recursive descent operator .. </ins> func (p *Parser) parseRecursive(cur *ListNode) error { <ins> if lastIndex := len(cur.Nodes) - 1; lastIndex >= 0 && cur.Nodes[lastIndex].Type() == NodeRecursive { return fmt.Errorf(\"invalid multiple recursive descent\") } </ins> p.pos += len(\"..\") p.consumeText() cur.append(newRecursive())", "commid": "kubernetes_pr_93408"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8f9ac5fdef0c838965d475f11d5aa85a5be83149ab6d29c24d50d1d19652ecb3", "query": "What happened: This issue was originally reported via the Kubernetes HackerOne bug bounty by HackerOne user but we have decided that due to the high privileges required, it can be addressed publicly. A user able to create CRDs could create a malicious CRD such that listing CRs will cause enormous amounts of CPU usage on the API server. What you expected to happen: The function should not expand strings with more than two consecutive periods. Either it should collapse additional repeated periods or it should return an error. How to reproduce it (as minimally and precisely as possible): /kind bug /area apiserver /area security /committee product-security /priority important-longterm\nHow about we take it a step further by rejecting the jsonpath which contains when parsing it? as more than 2 periods seem to make no sense IMO\ngood idea. I have posted to do what you suggest.\n/sig api-machinery\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-ac934444bfd00aea426a1e3b801c8603a852b256df8dd454a8ad2cf3de005d84", "text": "{\"invalid number\", \"{+12.3.0}\", \"cannot parse number +12.3.0\"}, {\"unterminated array\", \"{[1}\", \"unterminated array\"}, {\"unterminated filter\", \"{[?(.price]}\", \"unterminated filter\"}, <ins> {\"invalid multiple recursive descent\", \"{........}\", \"invalid multiple recursive descent\"}, </ins> } for _, test := range failParserTests { _, err := Parse(test.name, test.text)", "commid": "kubernetes_pr_93408"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fb153de2f1893790dcc98459ecf834aed330320a9fa128246d064c46ffa677ee", "query": "Looks like this test is never able to succeed because service does not exist: /kind failing-test /sig instrumentation\npossibly related to\n/assign\n/assign\n/assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten\nwhere did we get with this?\nLooks like those tests didn't work for at least half a year and nobody cared... Should we delete this e2e test as well? If so I can help with that.\nYes, let's remove them. Would appreciate the help! /remove-lifecycle rotten\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nStill failing: /remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-a3b143ba921e1193599078c7f5940ac74174aa0d3bf0c2f620423817f589da97", "text": "kube-up echo \"... calling validate-cluster\" >&2 <del> if [[ \"${EXIT_ON_WEAK_ERROR}\" == \"true\" ]]; then validate-cluster else validate-cluster validate_result=\"$?\" if [[ ${validate_result} != \"0\" ]]; then if [[ \"${validate_result}\" == \"1\" ]]; then exit 1 elif [[ \"${validate_result}\" == \"2\" ]]; then echo \"...ignoring non-fatal errors in validate-cluster\" >&2 else echo \"Got unknown validate result: ${validate_result}\" fi </del> <ins> # Override errexit (validate-cluster) && validate_result=\"$?\" || validate_result=\"$?\" # We have two different failure modes from validate cluster: # - 1: fatal error - cluster won't be working correctly # - 2: weak error - something went wrong, but cluster probably will be working correctly # We always exit in case 1), but if EXIT_ON_WEAK_ERROR != true, then we don't fail on 2). if [[ \"${validate_result}\" == \"1\" ]]; then exit 1 elif [[ \"${validate_result}\" == \"2\" ]]; then if [[ \"${EXIT_ON_WEAK_ERROR}\" == \"true\" ]]; then exit 1; else echo \"...ignoring non-fatal errors in validate-cluster\" >&2 </ins> fi fi", "commid": "kubernetes_pr_21860"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0a1bf2fc3bac35f872e7d40363318016d86b1c04208fb60bb87350c6a712505d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: For each NLB created, K8s creates an ingress rule on the node group's security group for each port exposed for each CIDR attached to the VPC to allow health checks to succeed. AWS limits the number of rules per security group to 60 by default. This quota is adjustable but multiplied by the quota for security groups per network interface cannot exceed 1000. I have a VPC with 16 CIDR blocks attached to it and a quota for rules per security group set to 80. Each NLB created adds 18 new rules (16 for Health Check, 1 for Client, and 1 for MTU) to the node group's security groups. This high number of unnecessary rules created makes it impossible to create more than 4 NLBs per node group (if each one has a single port exposed). What you expected to happen: For the health check to succeed, the NLB must be able to ping the node port for the service on the cluster's node group. So the node group's security group just needs an inbound rule for each ENI of the NLB, making the number of rules necessary on the cluster's node group directly proportional to the number of AZs the NLB is configured. How to reproduce it (as minimally and precisely as possible): Create a VPC on AWS with 8 CIDRs attached to it; Create a K8s Cluster; Create a Network Load Balancer with 6 ports exposed; If the default quota of rules per security group has not been changed, the NLB creation will fail with RulesPerSecurityGroupLimitExceeded. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ):Kernel (e.g. ):Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig cloud-provider\n/area provider/aws", "positive_passages": [{"docid": "doc-en-kubernetes-b6fc330b7a1641d2d3fa2eb78449889e9e971ea0d4f8ef5fd20007759c467dfb", "text": "return listener, nil } <ins> func (c *Cloud) getSubnetCidrs(subnetIDs []string) ([]string, error) { request := &ec2.DescribeSubnetsInput{} for _, subnetID := range subnetIDs { request.SubnetIds = append(request.SubnetIds, aws.String(subnetID)) } subnets, err := c.ec2.DescribeSubnets(request) if err != nil { return nil, fmt.Errorf(\"error querying Subnet for ELB: %q\", err) } if len(subnets) != len(subnetIDs) { return nil, fmt.Errorf(\"error querying Subnet for ELB, got %d subnets for %v\", len(subnets), subnetIDs) } cidrs := make([]string, 0, len(subnets)) for _, subnet := range subnets { cidrs = append(cidrs, aws.StringValue(subnet.CidrBlock)) } return cidrs, nil } </ins> // EnsureLoadBalancer implements LoadBalancer.EnsureLoadBalancer func (c *Cloud) EnsureLoadBalancer(ctx context.Context, clusterName string, apiService *v1.Service, nodes []*v1.Node) (*v1.LoadBalancerStatus, error) { annotations := apiService.Annotations", "commid": "kubernetes_pr_93515"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0a1bf2fc3bac35f872e7d40363318016d86b1c04208fb60bb87350c6a712505d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: For each NLB created, K8s creates an ingress rule on the node group's security group for each port exposed for each CIDR attached to the VPC to allow health checks to succeed. AWS limits the number of rules per security group to 60 by default. This quota is adjustable but multiplied by the quota for security groups per network interface cannot exceed 1000. I have a VPC with 16 CIDR blocks attached to it and a quota for rules per security group set to 80. Each NLB created adds 18 new rules (16 for Health Check, 1 for Client, and 1 for MTU) to the node group's security groups. This high number of unnecessary rules created makes it impossible to create more than 4 NLBs per node group (if each one has a single port exposed). What you expected to happen: For the health check to succeed, the NLB must be able to ping the node port for the service on the cluster's node group. So the node group's security group just needs an inbound rule for each ENI of the NLB, making the number of rules necessary on the cluster's node group directly proportional to the number of AZs the NLB is configured. How to reproduce it (as minimally and precisely as possible): Create a VPC on AWS with 8 CIDRs attached to it; Create a K8s Cluster; Create a Network Load Balancer with 6 ports exposed; If the default quota of rules per security group has not been changed, the NLB creation will fail with RulesPerSecurityGroupLimitExceeded. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ):Kernel (e.g. ):Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig cloud-provider\n/area provider/aws", "positive_passages": [{"docid": "doc-en-kubernetes-090fed8acd0ff6b39d8aeda956a9e7448079b4997d39051d24b611c708a3c53e", "text": "return nil, err } <ins> subnetCidrs, err := c.getSubnetCidrs(subnetIDs) if err != nil { klog.Errorf(\"Error getting subnet cidrs: %q\", err) return nil, err } </ins> sourceRangeCidrs := []string{} for cidr := range sourceRanges { sourceRangeCidrs = append(sourceRangeCidrs, cidr)", "commid": "kubernetes_pr_93515"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0a1bf2fc3bac35f872e7d40363318016d86b1c04208fb60bb87350c6a712505d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: For each NLB created, K8s creates an ingress rule on the node group's security group for each port exposed for each CIDR attached to the VPC to allow health checks to succeed. AWS limits the number of rules per security group to 60 by default. This quota is adjustable but multiplied by the quota for security groups per network interface cannot exceed 1000. I have a VPC with 16 CIDR blocks attached to it and a quota for rules per security group set to 80. Each NLB created adds 18 new rules (16 for Health Check, 1 for Client, and 1 for MTU) to the node group's security groups. This high number of unnecessary rules created makes it impossible to create more than 4 NLBs per node group (if each one has a single port exposed). What you expected to happen: For the health check to succeed, the NLB must be able to ping the node port for the service on the cluster's node group. So the node group's security group just needs an inbound rule for each ENI of the NLB, making the number of rules necessary on the cluster's node group directly proportional to the number of AZs the NLB is configured. How to reproduce it (as minimally and precisely as possible): Create a VPC on AWS with 8 CIDRs attached to it; Create a K8s Cluster; Create a Network Load Balancer with 6 ports exposed; If the default quota of rules per security group has not been changed, the NLB creation will fail with RulesPerSecurityGroupLimitExceeded. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ):Kernel (e.g. ):Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig cloud-provider\n/area provider/aws", "positive_passages": [{"docid": "doc-en-kubernetes-a0968b689bf2059cc67b7c71cd506f0da73696f2c75452eb1e99a835bbc8c79f", "text": "sourceRangeCidrs = append(sourceRangeCidrs, \"0.0.0.0/0\") } <del> err = c.updateInstanceSecurityGroupsForNLB(loadBalancerName, instances, sourceRangeCidrs, v2Mappings) </del> <ins> err = c.updateInstanceSecurityGroupsForNLB(loadBalancerName, instances, subnetCidrs, sourceRangeCidrs, v2Mappings) </ins> if err != nil { klog.Warningf(\"Error opening ingress rules for the load balancer to the instances: %q\", err) return nil, err", "commid": "kubernetes_pr_93515"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0a1bf2fc3bac35f872e7d40363318016d86b1c04208fb60bb87350c6a712505d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: For each NLB created, K8s creates an ingress rule on the node group's security group for each port exposed for each CIDR attached to the VPC to allow health checks to succeed. AWS limits the number of rules per security group to 60 by default. This quota is adjustable but multiplied by the quota for security groups per network interface cannot exceed 1000. I have a VPC with 16 CIDR blocks attached to it and a quota for rules per security group set to 80. Each NLB created adds 18 new rules (16 for Health Check, 1 for Client, and 1 for MTU) to the node group's security groups. This high number of unnecessary rules created makes it impossible to create more than 4 NLBs per node group (if each one has a single port exposed). What you expected to happen: For the health check to succeed, the NLB must be able to ping the node port for the service on the cluster's node group. So the node group's security group just needs an inbound rule for each ENI of the NLB, making the number of rules necessary on the cluster's node group directly proportional to the number of AZs the NLB is configured. How to reproduce it (as minimally and precisely as possible): Create a VPC on AWS with 8 CIDRs attached to it; Create a K8s Cluster; Create a Network Load Balancer with 6 ports exposed; If the default quota of rules per security group has not been changed, the NLB creation will fail with RulesPerSecurityGroupLimitExceeded. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ):Kernel (e.g. ):Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig cloud-provider\n/area provider/aws", "positive_passages": [{"docid": "doc-en-kubernetes-55409f2a86edc4f1333cfe145283718da839863f03b43ac4228c4d85969644b8", "text": "} } <del> return c.updateInstanceSecurityGroupsForNLB(loadBalancerName, nil, nil, nil) </del> <ins> return c.updateInstanceSecurityGroupsForNLB(loadBalancerName, nil, nil, nil, nil) </ins> } lb, err := c.describeLoadBalancer(loadBalancerName)", "commid": "kubernetes_pr_93515"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0a1bf2fc3bac35f872e7d40363318016d86b1c04208fb60bb87350c6a712505d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: For each NLB created, K8s creates an ingress rule on the node group's security group for each port exposed for each CIDR attached to the VPC to allow health checks to succeed. AWS limits the number of rules per security group to 60 by default. This quota is adjustable but multiplied by the quota for security groups per network interface cannot exceed 1000. I have a VPC with 16 CIDR blocks attached to it and a quota for rules per security group set to 80. Each NLB created adds 18 new rules (16 for Health Check, 1 for Client, and 1 for MTU) to the node group's security groups. This high number of unnecessary rules created makes it impossible to create more than 4 NLBs per node group (if each one has a single port exposed). What you expected to happen: For the health check to succeed, the NLB must be able to ping the node port for the service on the cluster's node group. So the node group's security group just needs an inbound rule for each ENI of the NLB, making the number of rules necessary on the cluster's node group directly proportional to the number of AZs the NLB is configured. How to reproduce it (as minimally and precisely as possible): Create a VPC on AWS with 8 CIDRs attached to it; Create a K8s Cluster; Create a Network Load Balancer with 6 ports exposed; If the default quota of rules per security group has not been changed, the NLB creation will fail with RulesPerSecurityGroupLimitExceeded. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ):Kernel (e.g. ):Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig cloud-provider\n/area provider/aws", "positive_passages": [{"docid": "doc-en-kubernetes-d3d991764ee10b0c03eb8f33c8e96ca4e8a2b94d11f7358feb9e16b40b464b05", "text": "return targetGroup, nil } <del> func (c *Cloud) getVpcCidrBlocks() ([]string, error) { vpcs, err := c.ec2.DescribeVpcs(&ec2.DescribeVpcsInput{ VpcIds: []*string{aws.String(c.vpcID)}, }) if err != nil { return nil, fmt.Errorf(\"error querying VPC for ELB: %q\", err) } if len(vpcs.Vpcs) != 1 { return nil, fmt.Errorf(\"error querying VPC for ELB, got %d vpcs for %s\", len(vpcs.Vpcs), c.vpcID) } cidrBlocks := make([]string, 0, len(vpcs.Vpcs[0].CidrBlockAssociationSet)) for _, cidr := range vpcs.Vpcs[0].CidrBlockAssociationSet { if aws.StringValue(cidr.CidrBlockState.State) != ec2.VpcCidrBlockStateCodeAssociated { continue } cidrBlocks = append(cidrBlocks, aws.StringValue(cidr.CidrBlock)) } return cidrBlocks, nil } </del> // updateInstanceSecurityGroupsForNLB will adjust securityGroup's settings to allow inbound traffic into instances from clientCIDRs and portMappings. // TIP: if either instances or clientCIDRs or portMappings are nil, then the securityGroup rules for lbName are cleared. <del> func (c *Cloud) updateInstanceSecurityGroupsForNLB(lbName string, instances map[InstanceID]*ec2.Instance, clientCIDRs []string, portMappings []nlbPortMapping) error { </del> <ins> func (c *Cloud) updateInstanceSecurityGroupsForNLB(lbName string, instances map[InstanceID]*ec2.Instance, subnetCIDRs []string, clientCIDRs []string, portMappings []nlbPortMapping) error { </ins> if c.cfg.Global.DisableSecurityGroupIngress { return nil }", "commid": "kubernetes_pr_93515"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0a1bf2fc3bac35f872e7d40363318016d86b1c04208fb60bb87350c6a712505d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: For each NLB created, K8s creates an ingress rule on the node group's security group for each port exposed for each CIDR attached to the VPC to allow health checks to succeed. AWS limits the number of rules per security group to 60 by default. This quota is adjustable but multiplied by the quota for security groups per network interface cannot exceed 1000. I have a VPC with 16 CIDR blocks attached to it and a quota for rules per security group set to 80. Each NLB created adds 18 new rules (16 for Health Check, 1 for Client, and 1 for MTU) to the node group's security groups. This high number of unnecessary rules created makes it impossible to create more than 4 NLBs per node group (if each one has a single port exposed). What you expected to happen: For the health check to succeed, the NLB must be able to ping the node port for the service on the cluster's node group. So the node group's security group just needs an inbound rule for each ENI of the NLB, making the number of rules necessary on the cluster's node group directly proportional to the number of AZs the NLB is configured. How to reproduce it (as minimally and precisely as possible): Create a VPC on AWS with 8 CIDRs attached to it; Create a K8s Cluster; Create a Network Load Balancer with 6 ports exposed; If the default quota of rules per security group has not been changed, the NLB creation will fail with RulesPerSecurityGroupLimitExceeded. Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ):Kernel (e.g. ):Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig cloud-provider\n/area provider/aws", "positive_passages": [{"docid": "doc-en-kubernetes-2b4d8407d314e56b14282bf83c542d23350c34330490668a30497162550b6ae1", "text": "} clientRuleAnnotation := fmt.Sprintf(\"%s=%s\", NLBClientRuleDescription, lbName) healthRuleAnnotation := fmt.Sprintf(\"%s=%s\", NLBHealthCheckRuleDescription, lbName) <del> vpcCIDRs, err := c.getVpcCidrBlocks() if err != nil { return err } </del> for sgID, sg := range clusterSGs { sgPerms := NewIPPermissionSet(sg.IpPermissions...).Ungroup() if desiredSGIDs.Has(sgID) { <del> if err := c.updateInstanceSecurityGroupForNLBTraffic(sgID, sgPerms, healthRuleAnnotation, \"tcp\", healthCheckPorts, vpcCIDRs); err != nil { </del> <ins> if err := c.updateInstanceSecurityGroupForNLBTraffic(sgID, sgPerms, healthRuleAnnotation, \"tcp\", healthCheckPorts, subnetCIDRs); err != nil { </ins> return err } if err := c.updateInstanceSecurityGroupForNLBTraffic(sgID, sgPerms, clientRuleAnnotation, clientProtocol, clientPorts, clientCIDRs); err != nil {", "commid": "kubernetes_pr_93515"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-78e05eb7f06c339373840cdecc454b25eff99bf89941b5ab73426b97281b26d9", "query": "Running : cpu usage goes to 2 cores @ 100% What you expected to happen: Way lower cpu usage. Environment: Kubernetes version (use ):Cloud provider or hardware configuration: GKE OS (e.g: ):Kernel (e.g. ): Linux felix-Latitude-7490 5.3.0-62-generic ~18.04.1-Ubuntu SMP Wed Jun 24 16:17:03 UTC 2020 x8664 x8664 x86_64 GNU/Linux\nHey I just did not understood, the cpu goes to 200% in the node or in the place where kubectl is running? Thanks!\n/priority awaiting-more-evidence /sig cli\nOn my laptop running kubectl\nSame issue on mac: kubectl version Client Version: version.Info{Major:\"1\", Minor:\"17+\", GitVersion:\"v1.17.9-eks-\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2020-07-17T19:00:19Z\", GoVersion:\"go1.13.9\", Compiler:\"gc\", Platform:\"darwin/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"16+\", GitVersion:\"v1.16.13-eks-\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2020-07-17T18:48:53Z\", GoVersion:\"go1.13.9\", Compiler:\"gc\", Platform:\"linux/amd64\"} PID COMMAND %CPU TIME #TH #WQ #PORTS MEM PURG CMPRS PGRP PPID STATE BOOSTS %CPUME %CPUOTHRS UID FAULTS COW MSGSENT MSGRECV SYSBSD SYSMACH CSW PAGEINS IDLEW POWER INSTRS CYCLES USER #MREGS RPRVT VPRVT VSIZE KPRVT KSHRD kubectl 100.5 03:30.41 32/1 0 43 16M 0B 0B 1322 running *0[1] 0. 0. 274 36 16 + 117 + 3730 266+ 100.5 costel.lupoaie N/A N/A N/A N/A N/A N/A I noticed the problem after upgrade from 1.15. Maybe it't not kubectl itself but the way it communicates with external auth provider like IAM in my case.\noh I see. Thanks I've no access to cloud providers right now to test, but as you've provisioned in EKS using IAM and is using GKE it MIGHT be a thing. Will wait to see if someone else have access to cloud providers and can test this :)\nMaybe I am wrong and it's just some busy waiting. In my case I noticed it when draining nodes with many pods that cannot immediately be stopped because it would break the deployments maxUnavailable limits, so kubectl has to wait until it can stop all the pods on the draining node.\nIn my case also this was triggered when pods couldn't be evicted immediately because of a violation of pdb.\ndoes not lead to high cpu usage in my case, so I suspect it has nothing to do with IAM/GKE auth, but with evictions failing because of pdb (but I am not experienced enough to know kubectl works in the background).\nI can confirm 100% (not 200%) CPU core usage for each process. Currently I'm draining four nodes in parallel (4x ), all four are waiting due to PDB's, and all are at 100% CPU most of the time. I'll try with a newer kubectl next time.\nOK, so it seems to be related to PDB and Drain. I'll try to take a look into it, try to reproduce with the last supported clients. Thank you for reporting! /assign\nThanks for looking into it! And my apologies, I forgot to comment on this before: Our cluster is deployed on bare metal on premise, so it's probably not EKS og GKE related.\nIs that possible you try draining with \"disable-eviction\" just to make sure PDB or eviction control is causing this? Thanks!\nI found a newer kubectl lying around, so it's now v1.18.8 (1.17 didn't include it seems) I couldn't test on the same cluster, but I just drained a host from our staging env with a similar amount of pods to what we run in prod (~85 vs ~100), and I think you're right. CPU usage certainly didn't go above 20% at any point on any core, and that's basically background noise on this host.\nSo my theory here is that kubectl keeps waiting for the node to drain and this is causing a high CPU usage. I'm also creating a cluster here to reproduce the behavior, and see what part of the code is this being caused\nConfirmed here :) Even in last kubectl v1.19.2 the problem happens. It seems also it's putting some pressure in API Server because of the amount of nodes vs PDB. disable-eviction is a \"workaround\" not desired if using PDB /remove-priority awaiting-more-evidence /priority important-soon\nI'm hitting my head in the wall here trying to figure out why the goroutine causes the peak of CPU usage, so anyone with better skills then me in Go, feel free to join :) is the function taking the whole CPU apparently Will keep digging what part of this function is taking the whole CPU. When removing the and making this 'serial' it seems to keep the CPU in low usage but I don't know if this is the desired scenario, as draining a node could take much longer since other Pods may not be using PDB. EDIT: but it also seems that the drain does not goes further because I forgot to change the return/break stuff inside the loop. So I'm thinking tomorrow maybe create a new 'queue' of the 'failed because of PDB' Pods, and deal with them in a separate way.", "positive_passages": [{"docid": "doc-en-kubernetes-a776dc86655480f0640c5b3be229ea190ed56dd62ca3ced0f0eb95cb11cfc1db", "text": "if err != nil { errors = append(errors, err) } <del> default: </del> } }", "commid": "kubernetes_pr_95260"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f814eb6fee82e38bddac144e6361725a95839de7b8ffd5deb6dd60487e14c610", "query": "Using scheduler like or , it always get unwanted output like: It simply because when adding the flags in scheduler, it will try to look up the And this will invoke: Since flag already has to prevent running other code when having : We should not print the klog info when using or right?\n/sig scheduling\nthat's annoying. Can you help to fix it?\nOk I'll take care of this. /assign", "positive_passages": [{"docid": "doc-en-kubernetes-bff72c1c63d59e1d46f645012cd13be5396fc76c06905476e87956ea2a6f48d5", "text": "package algorithmprovider import ( <del> \"sort\" \"strings\" </del> <ins> \"fmt\" </ins> utilfeature \"k8s.io/apiserver/pkg/util/feature\" \"k8s.io/klog/v2\"", "commid": "kubernetes_pr_93808"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f814eb6fee82e38bddac144e6361725a95839de7b8ffd5deb6dd60487e14c610", "query": "Using scheduler like or , it always get unwanted output like: It simply because when adding the flags in scheduler, it will try to look up the And this will invoke: Since flag already has to prevent running other code when having : We should not print the klog info when using or right?\n/sig scheduling\nthat's annoying. Can you help to fix it?\nOk I'll take care of this. /assign", "positive_passages": [{"docid": "doc-en-kubernetes-a9a029785ffb93f1470ce9ca611fd917960bfe1abf2a8e32e259808d736e40ae", "text": "// ListAlgorithmProviders lists registered algorithm providers. func ListAlgorithmProviders() string { <del> r := NewRegistry() var providers []string for k := range r { providers = append(providers, k) } sort.Strings(providers) return strings.Join(providers, \" | \") </del> <ins> return fmt.Sprintf(\"%s | %s\", ClusterAutoscalerProvider, schedulerapi.SchedulerDefaultProviderName) </ins> } func getDefaultConfig() *schedulerapi.Plugins {", "commid": "kubernetes_pr_93808"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8b2b2e2ffd22fe6758944952b9978a29f1bcbd284b0e2f61b9aae2c62c2ca39a", "query": "Which test(s) are flaking: TestWatchHTTPTimeout Reason for failure: This test is flaking, but not enough to fail our presubmit CI (which currently retries up to 3 times and passes on a single green run). Observed in when trying to disable this flake toleration. Reproducer steps: test binary: with : This is reproducible on release-1.18 as well, though is happening an order of magnitude more frequently on master: /sig api-machinery\n/assign I would like to give it a shot.\nthanks for looking", "positive_passages": [{"docid": "doc-en-kubernetes-152f6fe2a56500eb2c573cad395c033479c45b2259968ba578ec758b8f4f6780", "text": "close(timeoutCh) select { case <-done: <del> if !watcher.IsStopped() { </del> <ins> eventCh := watcher.ResultChan() select { case _, opened := <-eventCh: if opened { t.Errorf(\"Watcher received unexpected event\") } if !watcher.IsStopped() { t.Errorf(\"Watcher is not stopped\") } case <-time.After(wait.ForeverTestTimeout): </ins> t.Errorf(\"Leaked watch on timeout\") } case <-time.After(wait.ForeverTestTimeout):", "commid": "kubernetes_pr_93895"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-71c52100bb44d787a3e8fee2a4cf4c2e3b2b14a4cab61aabfb0663937ac238a8", "query": "There was an effort at one point to promote it to Beta This may have moved to Service Catalog repo So question, do we remove it from kubernetes/kubernetes ?\n/sig apps /sig service-catalog Thoughts please!\nI see removal of perma-alpha APIs as a natural next step after the \"\" work to put end dates on beta APIs\nThe PodPreset functionality is not used in Service Catalog, we have an issue to remove references to it in the svc-cat repo, see: In the separate issue, we will figure out how to implement the e2e functionality for injecting secrets into an application: IMO it's ok to remove it as right now there is no decision about how to use it in svc-cat and currently we do not have enough capacity to work on that. In Kyma project but we also . /cc\nMany of us have been waiting for this to become mature since along time. Removing PodPresets would be quite sad, as it would allow many people to stop having to write their own mutating webhooks for things PodPresets could do really well. Also I had in mind to use it for automatically mounting common volumes into pods and much more.\nMe too Doing my usual check of has-this-thing-got-to-beta-so-I-can-finally-use-it only to find PodPresets had entirely disappeared This feature was going to greatly simplify our manifests. We do have the mutating webhooks feature now, which we didn't when PodPresets were created. However PodPresets are a lot cleaner would have received a lot of use. Even chart designs could be greatly simplified with optional PodPreset manifests. So I was looking forward to getting them available for use. Things in alpha can never gain traction or significant interest because managed providers won't let you enable them. This is not really a case of 'perma-beta'. But, if they were not going anywhere then I can understand removing them.\nSpeaking of gaining traction and momentum, the 'Avoiding permanent beta' policy only has a nine-month countdown for beta features. This new policy clashes with the recent popularity of managed releases, which tend to lag upstream releases by 6-9 months (2-3 releases). E.g. the current . That is before users can start planning upgrades in the 3-6 months after that. So a brand-spanking new beta feature won't reach cloud provider users until 9-15 months after it reaches beta upstream. Then users will start trying it out, and if it works well and get some interest and momentum behind it, only to find it has been already removed from a subsequent releases because of the mandatory 9-month policy In practice AWS probably won't enable a beta feature that is already removed upstream, so we can basically expect beta features will never reach, or get a chance for real-world feedback from cloud provider users. It is going to be tough for when the real world can't test a release with a beta feature until after it has already hit mandatory removal\nFor long running alpha features I usually recommend announcing depreaction and removing after one release, instead of right away. For extending the beta policy please see:\nPlease don't remove this feature! We only just discovered it this week and it was positioned to solve a real issue with common volume specs, in the same way mentioned by It would be really sad to now see it removed when it was going to fix some integration issues for us!\nCould you elaborate on why PodPresets were never promoted to beta and why you want to remove them now? It seems like a useful feature.\nThis feature would have been very useful in several operating scenarios, such as setting proxy settings before a deployment.\nCan anyone comment on what alternatives are? Without this feature we'll have a lot of duplication. No one likes duplication. We can address the Environment variables via ConfigMap and the envFrom keyword, however I cannot see anything for volumes, imagePullSecret etc.\nIt seems the alternative is just to use mutating webhooks. And there is even a port of PodPreset to a mutating web hook by redhat:\n-1000 Removing PodPreset is terrible. Shame on you!\nIt doesn't look much maintained and active, sadly\nRelated:", "positive_passages": [{"docid": "doc-en-kubernetes-96c10a01e84121159d2aeea8a9af7e74fcece96b1a07089d231b1127c29aa5c4", "text": "} if container == nil { <del> // The container is not available yet, e.g. during validation of // PodPreset. Stop validation now, Pod validation will refuse final </del> <ins> // The container is not available yet. // Stop validation now, Pod validation will refuse final </ins> // Pods with Bidirectional propagation in non-privileged containers. return allErrs }", "commid": "kubernetes_pr_102336"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-71c52100bb44d787a3e8fee2a4cf4c2e3b2b14a4cab61aabfb0663937ac238a8", "query": "There was an effort at one point to promote it to Beta This may have moved to Service Catalog repo So question, do we remove it from kubernetes/kubernetes ?\n/sig apps /sig service-catalog Thoughts please!\nI see removal of perma-alpha APIs as a natural next step after the \"\" work to put end dates on beta APIs\nThe PodPreset functionality is not used in Service Catalog, we have an issue to remove references to it in the svc-cat repo, see: In the separate issue, we will figure out how to implement the e2e functionality for injecting secrets into an application: IMO it's ok to remove it as right now there is no decision about how to use it in svc-cat and currently we do not have enough capacity to work on that. In Kyma project but we also . /cc\nMany of us have been waiting for this to become mature since along time. Removing PodPresets would be quite sad, as it would allow many people to stop having to write their own mutating webhooks for things PodPresets could do really well. Also I had in mind to use it for automatically mounting common volumes into pods and much more.\nMe too Doing my usual check of has-this-thing-got-to-beta-so-I-can-finally-use-it only to find PodPresets had entirely disappeared This feature was going to greatly simplify our manifests. We do have the mutating webhooks feature now, which we didn't when PodPresets were created. However PodPresets are a lot cleaner would have received a lot of use. Even chart designs could be greatly simplified with optional PodPreset manifests. So I was looking forward to getting them available for use. Things in alpha can never gain traction or significant interest because managed providers won't let you enable them. This is not really a case of 'perma-beta'. But, if they were not going anywhere then I can understand removing them.\nSpeaking of gaining traction and momentum, the 'Avoiding permanent beta' policy only has a nine-month countdown for beta features. This new policy clashes with the recent popularity of managed releases, which tend to lag upstream releases by 6-9 months (2-3 releases). E.g. the current . That is before users can start planning upgrades in the 3-6 months after that. So a brand-spanking new beta feature won't reach cloud provider users until 9-15 months after it reaches beta upstream. Then users will start trying it out, and if it works well and get some interest and momentum behind it, only to find it has been already removed from a subsequent releases because of the mandatory 9-month policy In practice AWS probably won't enable a beta feature that is already removed upstream, so we can basically expect beta features will never reach, or get a chance for real-world feedback from cloud provider users. It is going to be tough for when the real world can't test a release with a beta feature until after it has already hit mandatory removal\nFor long running alpha features I usually recommend announcing depreaction and removing after one release, instead of right away. For extending the beta policy please see:\nPlease don't remove this feature! We only just discovered it this week and it was positioned to solve a real issue with common volume specs, in the same way mentioned by It would be really sad to now see it removed when it was going to fix some integration issues for us!\nCould you elaborate on why PodPresets were never promoted to beta and why you want to remove them now? It seems like a useful feature.\nThis feature would have been very useful in several operating scenarios, such as setting proxy settings before a deployment.\nCan anyone comment on what alternatives are? Without this feature we'll have a lot of duplication. No one likes duplication. We can address the Environment variables via ConfigMap and the envFrom keyword, however I cannot see anything for volumes, imagePullSecret etc.\nIt seems the alternative is just to use mutating webhooks. And there is even a port of PodPreset to a mutating web hook by redhat:\n-1000 Removing PodPreset is terrible. Shame on you!\nIt doesn't look much maintained and active, sadly\nRelated:", "positive_passages": [{"docid": "doc-en-kubernetes-204fdb3cfff1123b9ed8007395bfedeafe62453e2e49d2157956bf594ec2d541", "text": "<del> { \"kind\": \"PodPreset\", \"apiVersion\": \"settings.k8s.io/v1alpha1\", \"metadata\": { \"name\": \"2\", \"generateName\": \"3\", \"namespace\": \"4\", \"selfLink\": \"5\", \"uid\": \"7\", \"resourceVersion\": \"11042405498087606203\", \"generation\": 8071137005907523419, \"creationTimestamp\": null, \"deletionGracePeriodSeconds\": -4955867275792137171, \"labels\": { \"7\": \"8\" }, \"annotations\": { \"9\": \"10\" }, \"ownerReferences\": [ { \"apiVersion\": \"11\", \"kind\": \"12\", \"name\": \"13\", \"uid\": \"Dz\u5ed4\u0207{s\u014a\u018fp\", \"controller\": false, \"blockOwnerDeletion\": true } ], \"finalizers\": [ \"14\" ], \"clusterName\": \"15\", \"managedFields\": [ { \"manager\": \"16\", \"operation\": \"\u940a\u550a\u98d9\u015e-U\u5734\u00f7a/\u0254}\u6441(\u6e57\u0106]\", \"apiVersion\": \"17\", \"fieldsType\": \"18\" } ] }, \"spec\": { \"selector\": { \"matchLabels\": { \"8---jop9641lg.p-g8c2-k-912e5-c-e63-n-3n/E9.8ThjT9s-j41-0-6p-JFHn7y-74.-0MUORQQ.N2.3\": \"68._bQw.-dG6c-.6--_x.--0wmZk1_8._3s_-_Bq.m_4\" }, \"matchExpressions\": [ { \"key\": \"p503---477-49p---o61---4fy--9---7--9-9s-0-u5lj2--10pq-0-7-9-2-0/fP81.-.9Vdx.TB_M-H_5_.t..bG0\", \"operator\": \"In\", \"values\": [ \"D07.a_.y_y_o0_5qN2_---_M.N_._a6.9bHjdH.-.5_.I8__n\" ] } ] }, \"env\": [ { \"name\": \"25\", \"value\": \"26\", \"valueFrom\": { \"fieldRef\": { \"apiVersion\": \"27\", \"fieldPath\": \"28\" }, \"resourceFieldRef\": { \"containerName\": \"29\", \"resource\": \"30\", \"divisor\": \"91\" }, \"configMapKeyRef\": { \"name\": \"31\", \"key\": \"32\", \"optional\": false }, \"secretKeyRef\": { \"name\": \"33\", \"key\": \"34\", \"optional\": true } } } ], \"envFrom\": [ { \"prefix\": \"35\", \"configMapRef\": { \"name\": \"36\", \"optional\": true }, \"secretRef\": { \"name\": \"37\", \"optional\": false } } ], \"volumes\": [ { \"name\": \"38\", \"hostPath\": { \"path\": \"39\", \"type\": \"3f\u01bbf\u02a3\u7e61\u6959\u00af\u0126E\" }, \"emptyDir\": { \"sizeLimit\": \"700\" }, \"gcePersistentDisk\": { \"pdName\": \"40\", \"fsType\": \"41\", \"partition\": -1215463021, \"readOnly\": true }, \"awsElasticBlockStore\": { \"volumeID\": \"42\", \"fsType\": \"43\", \"partition\": 1686297225, \"readOnly\": true }, \"gitRepo\": { \"repository\": \"44\", \"revision\": \"45\", \"directory\": \"46\" }, \"secret\": { \"secretName\": \"47\", \"items\": [ { \"key\": \"48\", \"path\": \"49\", \"mode\": -815194340 } ], \"defaultMode\": -999327618, \"optional\": false }, \"nfs\": { \"server\": \"50\", \"path\": \"51\", \"readOnly\": true }, \"iscsi\": { \"targetPortal\": \"52\", \"iqn\": \"53\", \"lun\": -388204860, \"iscsiInterface\": \"54\", \"fsType\": \"55\", \"readOnly\": true, \"portals\": [ \"56\" ], \"secretRef\": { \"name\": \"57\" }, \"initiatorName\": \"58\" }, \"glusterfs\": { \"endpoints\": \"59\", \"path\": \"60\" }, \"persistentVolumeClaim\": { \"claimName\": \"61\" }, \"rbd\": { \"monitors\": [ \"62\" ], \"image\": \"63\", \"fsType\": \"64\", \"pool\": \"65\", \"user\": \"66\", \"keyring\": \"67\", \"secretRef\": { \"name\": \"68\" }, \"readOnly\": true }, \"flexVolume\": { \"driver\": \"69\", \"fsType\": \"70\", \"secretRef\": { \"name\": \"71\" }, \"options\": { \"72\": \"73\" } }, \"cinder\": { \"volumeID\": \"74\", \"fsType\": \"75\", \"secretRef\": { \"name\": \"76\" } }, \"cephfs\": { \"monitors\": [ \"77\" ], \"path\": \"78\", \"user\": \"79\", \"secretFile\": \"80\", \"secretRef\": { \"name\": \"81\" }, \"readOnly\": true }, \"flocker\": { \"datasetName\": \"82\", \"datasetUUID\": \"83\" }, \"downwardAPI\": { \"items\": [ { \"path\": \"84\", \"fieldRef\": { \"apiVersion\": \"85\", \"fieldPath\": \"86\" }, \"resourceFieldRef\": { \"containerName\": \"87\", \"resource\": \"88\", \"divisor\": \"965\" }, \"mode\": 345648859 } ], \"defaultMode\": 1169718433 }, \"fc\": { \"targetWWNs\": [ \"89\" ], \"lun\": -460478410, \"fsType\": \"90\", \"wwids\": [ \"91\" ] }, \"azureFile\": { \"secretName\": \"92\", \"shareName\": \"93\", \"readOnly\": true }, \"configMap\": { \"name\": \"94\", \"items\": [ { \"key\": \"95\", \"path\": \"96\", \"mode\": -513127725 } ], \"defaultMode\": -958191807, \"optional\": true }, \"vsphereVolume\": { \"volumePath\": \"97\", \"fsType\": \"98\", \"storagePolicyName\": \"99\", \"storagePolicyID\": \"100\" }, \"quobyte\": { \"registry\": \"101\", \"volume\": \"102\", \"user\": \"103\", \"group\": \"104\", \"tenant\": \"105\" }, \"azureDisk\": { \"diskName\": \"106\", \"diskURI\": \"107\", \"cachingMode\": \"\u7a60C]\u8ea2|)\u9ef0e\u022a\u5d5b4$%Q\u0270\", \"fsType\": \"108\", \"readOnly\": false, \"kind\": \"\u00cf\u62b4\u0168fZhU\u028e\u6d75\u0272\u00f5Tou0026\u856dk\" }, \"photonPersistentDisk\": { \"pdID\": \"109\", \"fsType\": \"110\" }, \"projected\": { \"sources\": [ { \"secret\": { \"name\": \"111\", \"items\": [ { \"key\": \"112\", \"path\": \"113\", \"mode\": -163325250 } ], \"optional\": false }, \"downwardAPI\": { \"items\": [ { \"path\": \"114\", \"fieldRef\": { \"apiVersion\": \"115\", \"fieldPath\": \"116\" }, \"resourceFieldRef\": { \"containerName\": \"117\", \"resource\": \"118\", \"divisor\": \"85\" }, \"mode\": -1996616480 } ] }, \"configMap\": { \"name\": \"119\", \"items\": [ { \"key\": \"120\", \"path\": \"121\", \"mode\": -1120128337 } ], \"optional\": false }, \"serviceAccountToken\": { \"audience\": \"122\", \"expirationSeconds\": -1239370187818888272, \"path\": \"123\" } } ], \"defaultMode\": 1366821517 }, \"portworxVolume\": { \"volumeID\": \"124\", \"fsType\": \"125\", \"readOnly\": true }, \"scaleIO\": { \"gateway\": \"126\", \"system\": \"127\", \"secretRef\": { \"name\": \"128\" }, \"sslEnabled\": true, \"protectionDomain\": \"129\", \"storagePool\": \"130\", \"storageMode\": \"131\", \"volumeName\": \"132\", \"fsType\": \"133\" }, \"storageos\": { \"volumeName\": \"134\", \"volumeNamespace\": \"135\", \"fsType\": \"136\", \"secretRef\": { \"name\": \"137\" } }, \"csi\": { \"driver\": \"138\", \"readOnly\": true, \"fsType\": \"139\", \"volumeAttributes\": { \"140\": \"141\" }, \"nodePublishSecretRef\": { \"name\": \"142\" } }, \"ephemeral\": { \"volumeClaimTemplate\": { \"metadata\": { \"name\": \"143\", \"generateName\": \"144\", \"namespace\": \"145\", \"selfLink\": \"146\", \"uid\": \"y\u7db8_\u00da8\u53c3\u907c\u016b\", \"resourceVersion\": \"16267283576845911679\", \"generation\": 2131277878630553496, \"creationTimestamp\": null, \"deletionGracePeriodSeconds\": -2351574817327272831, \"labels\": { \"148\": \"149\" }, \"annotations\": { \"150\": \"151\" }, \"ownerReferences\": [ { \"apiVersion\": \"152\", \"kind\": \"153\", \"name\": \"154\", \"uid\": \"\u81f7\u013d\u00f0\u00bb\u0173K\u0135u00264\u0291%:;\u680dd\u02aa\", \"controller\": false, \"blockOwnerDeletion\": false } ], \"finalizers\": [ \"155\" ], \"clusterName\": \"156\", \"managedFields\": [ { \"manager\": \"157\", \"operation\": \"\u024di\u7e31\u00f9\u58b41R\u01a5\u8d2b\", \"apiVersion\": \"158\", \"fieldsType\": \"159\" } ] }, \"spec\": { \"accessModes\": [ \"\u638a\u00b0n\u02ae\u95bc\u548e\u6af8e\u0294\u014a\u019e\u7a76:ho\u0102\u024b\u7010\" ], \"selector\": { \"matchLabels\": { \"d.iUaC_wYSJfB._.zS-._..3le-Q4-R-083.SD..P.---5.-Z3P__D__6t-2.-m\": \"wE._._3.-.83_iQ\" }, \"matchExpressions\": [ { \"key\": \"x--r7v66bm71u-n4f9wk-3--652x01--p--n4-4-t--2/C.A-j..9dfn3Y8d_0_.---M_4FpF_W-1._-vL_i.-_-a--G-I.-_Y33--.8U.6\", \"operator\": \"In\", \"values\": [ \"A.0.__cd..lv-_aLQbI2_-.XFw.8._..._Wxpe..J7r6\" ] } ] }, \"resources\": { \"limits\": { \"u003c\u9d12\u7fc1\u6759\u0166\u76438\u9e16\u0271J\u0209\u7f74\": \"587\" }, \"requests\": { \"\u00d36\u01f3\u5a1d\u561a\u5e8eD}\u57fdu\u028e\u023a\u7716R#yV\": \"156\" } }, \"volumeName\": \"166\", \"storageClassName\": \"167\", \"volumeMode\": \"\u7626\u0256\u7dd5\u021a\u00cd\u52c5\u8de6Opw\u01e9\u66ec\u9034\", \"dataSource\": { \"apiGroup\": \"168\", \"kind\": \"169\", \"name\": \"170\" } } }, \"readOnly\": true } } ], \"volumeMounts\": [ { \"name\": \"171\", \"readOnly\": true, \"mountPath\": \"172\", \"subPath\": \"173\", \"mountPropagation\": \"\u0153\u0220\u01acQg\u9120[\u9890o\u555b\u66f4\u5062\u0247\u5377\u8359JL\u0139]\", \"subPathExpr\": \"174\" } ] } } </del>  No newline at end of file", "commid": "kubernetes_pr_102336"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-71c52100bb44d787a3e8fee2a4cf4c2e3b2b14a4cab61aabfb0663937ac238a8", "query": "There was an effort at one point to promote it to Beta This may have moved to Service Catalog repo So question, do we remove it from kubernetes/kubernetes ?\n/sig apps /sig service-catalog Thoughts please!\nI see removal of perma-alpha APIs as a natural next step after the \"\" work to put end dates on beta APIs\nThe PodPreset functionality is not used in Service Catalog, we have an issue to remove references to it in the svc-cat repo, see: In the separate issue, we will figure out how to implement the e2e functionality for injecting secrets into an application: IMO it's ok to remove it as right now there is no decision about how to use it in svc-cat and currently we do not have enough capacity to work on that. In Kyma project but we also . /cc\nMany of us have been waiting for this to become mature since along time. Removing PodPresets would be quite sad, as it would allow many people to stop having to write their own mutating webhooks for things PodPresets could do really well. Also I had in mind to use it for automatically mounting common volumes into pods and much more.\nMe too Doing my usual check of has-this-thing-got-to-beta-so-I-can-finally-use-it only to find PodPresets had entirely disappeared This feature was going to greatly simplify our manifests. We do have the mutating webhooks feature now, which we didn't when PodPresets were created. However PodPresets are a lot cleaner would have received a lot of use. Even chart designs could be greatly simplified with optional PodPreset manifests. So I was looking forward to getting them available for use. Things in alpha can never gain traction or significant interest because managed providers won't let you enable them. This is not really a case of 'perma-beta'. But, if they were not going anywhere then I can understand removing them.\nSpeaking of gaining traction and momentum, the 'Avoiding permanent beta' policy only has a nine-month countdown for beta features. This new policy clashes with the recent popularity of managed releases, which tend to lag upstream releases by 6-9 months (2-3 releases). E.g. the current . That is before users can start planning upgrades in the 3-6 months after that. So a brand-spanking new beta feature won't reach cloud provider users until 9-15 months after it reaches beta upstream. Then users will start trying it out, and if it works well and get some interest and momentum behind it, only to find it has been already removed from a subsequent releases because of the mandatory 9-month policy In practice AWS probably won't enable a beta feature that is already removed upstream, so we can basically expect beta features will never reach, or get a chance for real-world feedback from cloud provider users. It is going to be tough for when the real world can't test a release with a beta feature until after it has already hit mandatory removal\nFor long running alpha features I usually recommend announcing depreaction and removing after one release, instead of right away. For extending the beta policy please see:\nPlease don't remove this feature! We only just discovered it this week and it was positioned to solve a real issue with common volume specs, in the same way mentioned by It would be really sad to now see it removed when it was going to fix some integration issues for us!\nCould you elaborate on why PodPresets were never promoted to beta and why you want to remove them now? It seems like a useful feature.\nThis feature would have been very useful in several operating scenarios, such as setting proxy settings before a deployment.\nCan anyone comment on what alternatives are? Without this feature we'll have a lot of duplication. No one likes duplication. We can address the Environment variables via ConfigMap and the envFrom keyword, however I cannot see anything for volumes, imagePullSecret etc.\nIt seems the alternative is just to use mutating webhooks. And there is even a port of PodPreset to a mutating web hook by redhat:\n-1000 Removing PodPreset is terrible. Shame on you!\nIt doesn't look much maintained and active, sadly\nRelated:", "positive_passages": [{"docid": "doc-en-kubernetes-e1b8f5ce86e875f6c810973200e0d14bb3190ea9350dc1798fc9e36f8eda5340", "text": "<del> apiVersion: settings.k8s.io/v1alpha1 kind: PodPreset metadata: annotations: \"9\": \"10\" clusterName: \"15\" creationTimestamp: null deletionGracePeriodSeconds: -4955867275792137171 finalizers: - \"14\" generateName: \"3\" generation: 8071137005907523419 labels: \"7\": \"8\" managedFields: - apiVersion: \"17\" fieldsType: \"18\" manager: \"16\" operation: \u940a\u550a\u98d9\u015e-U\u5734\u00f7a/\u0254}\u6441(\u6e57\u0106] name: \"2\" namespace: \"4\" ownerReferences: - apiVersion: \"11\" blockOwnerDeletion: true controller: false kind: \"12\" name: \"13\" uid: Dz\u5ed4\u0207{s\u014a\u018fp resourceVersion: \"11042405498087606203\" selfLink: \"5\" uid: \"7\" spec: env: - name: \"25\" value: \"26\" valueFrom: configMapKeyRef: key: \"32\" name: \"31\" optional: false fieldRef: apiVersion: \"27\" fieldPath: \"28\" resourceFieldRef: containerName: \"29\" divisor: \"91\" resource: \"30\" secretKeyRef: key: \"34\" name: \"33\" optional: true envFrom: - configMapRef: name: \"36\" optional: true prefix: \"35\" secretRef: name: \"37\" optional: false selector: matchExpressions: - key: p503---477-49p---o61---4fy--9---7--9-9s-0-u5lj2--10pq-0-7-9-2-0/fP81.-.9Vdx.TB_M-H_5_.t..bG0 operator: In values: - D07.a_.y_y_o0_5qN2_---_M.N_._a6.9bHjdH.-.5_.I8__n matchLabels: 8---jop9641lg.p-g8c2-k-912e5-c-e63-n-3n/E9.8ThjT9s-j41-0-6p-JFHn7y-74.-0MUORQQ.N2.3: 68._bQw.-dG6c-.6--_x.--0wmZk1_8._3s_-_Bq.m_4 volumeMounts: - mountPath: \"172\" mountPropagation: \u0153\u0220\u01acQg\u9120[\u9890o\u555b\u66f4\u5062\u0247\u5377\u8359JL\u0139] name: \"171\" readOnly: true subPath: \"173\" subPathExpr: \"174\" volumes: - awsElasticBlockStore: fsType: \"43\" partition: 1686297225 readOnly: true volumeID: \"42\" azureDisk: cachingMode: \u7a60C]\u8ea2|)\u9ef0e\u022a\u5d5b4$%Q\u0270 diskName: \"106\" diskURI: \"107\" fsType: \"108\" kind: \u00cf\u62b4\u0168fZhU\u028e\u6d75\u0272\u00f5To&\u856dk readOnly: false azureFile: readOnly: true secretName: \"92\" shareName: \"93\" cephfs: monitors: - \"77\" path: \"78\" readOnly: true secretFile: \"80\" secretRef: name: \"81\" user: \"79\" cinder: fsType: \"75\" secretRef: name: \"76\" volumeID: \"74\" configMap: defaultMode: -958191807 items: - key: \"95\" mode: -513127725 path: \"96\" name: \"94\" optional: true csi: driver: \"138\" fsType: \"139\" nodePublishSecretRef: name: \"142\" readOnly: true volumeAttributes: \"140\": \"141\" downwardAPI: defaultMode: 1169718433 items: - fieldRef: apiVersion: \"85\" fieldPath: \"86\" mode: 345648859 path: \"84\" resourceFieldRef: containerName: \"87\" divisor: \"965\" resource: \"88\" emptyDir: sizeLimit: \"700\" ephemeral: readOnly: true volumeClaimTemplate: metadata: annotations: \"150\": \"151\" clusterName: \"156\" creationTimestamp: null deletionGracePeriodSeconds: -2351574817327272831 finalizers: - \"155\" generateName: \"144\" generation: 2131277878630553496 labels: \"148\": \"149\" managedFields: - apiVersion: \"158\" fieldsType: \"159\" manager: \"157\" operation: \u024di\u7e31\u00f9\u58b41R\u01a5\u8d2b name: \"143\" namespace: \"145\" ownerReferences: - apiVersion: \"152\" blockOwnerDeletion: false controller: false kind: \"153\" name: \"154\" uid: \u81f7\u013d\u00f0\u00bb\u0173K\u0135&4\u0291%:;\u680dd\u02aa resourceVersion: \"16267283576845911679\" selfLink: \"146\" uid: y\u7db8_\u00da8\u53c3\u907c\u016b spec: accessModes: - \u638a\u00b0n\u02ae\u95bc\u548e\u6af8e\u0294\u014a\u019e\u7a76:ho\u0102\u024b\u7010 dataSource: apiGroup: \"168\" kind: \"169\" name: \"170\" resources: limits: <\u9d12\u7fc1\u6759\u0166\u76438\u9e16\u0271J\u0209\u7f74: \"587\" requests: \u00d36\u01f3\u5a1d\u561a\u5e8eD}\u57fdu\u028e\u023a\u7716R#yV: \"156\" selector: matchExpressions: - key: x--r7v66bm71u-n4f9wk-3--652x01--p--n4-4-t--2/C.A-j..9dfn3Y8d_0_.---M_4FpF_W-1._-vL_i.-_-a--G-I.-_Y33--.8U.6 operator: In values: - A.0.__cd..lv-_aLQbI2_-.XFw.8._..._Wxpe..J7r6 matchLabels: d.iUaC_wYSJfB._.zS-._..3le-Q4-R-083.SD..P.---5.-Z3P__D__6t-2.-m: wE._._3.-.83_iQ storageClassName: \"167\" volumeMode: \u7626\u0256\u7dd5\u021a\u00cd\u52c5\u8de6Opw\u01e9\u66ec\u9034 volumeName: \"166\" fc: fsType: \"90\" lun: -460478410 targetWWNs: - \"89\" wwids: - \"91\" flexVolume: driver: \"69\" fsType: \"70\" options: \"72\": \"73\" secretRef: name: \"71\" flocker: datasetName: \"82\" datasetUUID: \"83\" gcePersistentDisk: fsType: \"41\" partition: -1215463021 pdName: \"40\" readOnly: true gitRepo: directory: \"46\" repository: \"44\" revision: \"45\" glusterfs: endpoints: \"59\" path: \"60\" hostPath: path: \"39\" type: 3f\u01bbf\u02a3\u7e61\u6959\u00af\u0126E iscsi: fsType: \"55\" initiatorName: \"58\" iqn: \"53\" iscsiInterface: \"54\" lun: -388204860 portals: - \"56\" readOnly: true secretRef: name: \"57\" targetPortal: \"52\" name: \"38\" nfs: path: \"51\" readOnly: true server: \"50\" persistentVolumeClaim: claimName: \"61\" photonPersistentDisk: fsType: \"110\" pdID: \"109\" portworxVolume: fsType: \"125\" readOnly: true volumeID: \"124\" projected: defaultMode: 1366821517 sources: - configMap: items: - key: \"120\" mode: -1120128337 path: \"121\" name: \"119\" optional: false downwardAPI: items: - fieldRef: apiVersion: \"115\" fieldPath: \"116\" mode: -1996616480 path: \"114\" resourceFieldRef: containerName: \"117\" divisor: \"85\" resource: \"118\" secret: items: - key: \"112\" mode: -163325250 path: \"113\" name: \"111\" optional: false serviceAccountToken: audience: \"122\" expirationSeconds: -1239370187818888272 path: \"123\" quobyte: group: \"104\" registry: \"101\" tenant: \"105\" user: \"103\" volume: \"102\" rbd: fsType: \"64\" image: \"63\" keyring: \"67\" monitors: - \"62\" pool: \"65\" readOnly: true secretRef: name: \"68\" user: \"66\" scaleIO: fsType: \"133\" gateway: \"126\" protectionDomain: \"129\" secretRef: name: \"128\" sslEnabled: true storageMode: \"131\" storagePool: \"130\" system: \"127\" volumeName: \"132\" secret: defaultMode: -999327618 items: - key: \"48\" mode: -815194340 path: \"49\" optional: false secretName: \"47\" storageos: fsType: \"136\" secretRef: name: \"137\" volumeName: \"134\" volumeNamespace: \"135\" vsphereVolume: fsType: \"98\" storagePolicyID: \"100\" storagePolicyName: \"99\" volumePath: \"97\" </del>", "commid": "kubernetes_pr_102336"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-71c52100bb44d787a3e8fee2a4cf4c2e3b2b14a4cab61aabfb0663937ac238a8", "query": "There was an effort at one point to promote it to Beta This may have moved to Service Catalog repo So question, do we remove it from kubernetes/kubernetes ?\n/sig apps /sig service-catalog Thoughts please!\nI see removal of perma-alpha APIs as a natural next step after the \"\" work to put end dates on beta APIs\nThe PodPreset functionality is not used in Service Catalog, we have an issue to remove references to it in the svc-cat repo, see: In the separate issue, we will figure out how to implement the e2e functionality for injecting secrets into an application: IMO it's ok to remove it as right now there is no decision about how to use it in svc-cat and currently we do not have enough capacity to work on that. In Kyma project but we also . /cc\nMany of us have been waiting for this to become mature since along time. Removing PodPresets would be quite sad, as it would allow many people to stop having to write their own mutating webhooks for things PodPresets could do really well. Also I had in mind to use it for automatically mounting common volumes into pods and much more.\nMe too Doing my usual check of has-this-thing-got-to-beta-so-I-can-finally-use-it only to find PodPresets had entirely disappeared This feature was going to greatly simplify our manifests. We do have the mutating webhooks feature now, which we didn't when PodPresets were created. However PodPresets are a lot cleaner would have received a lot of use. Even chart designs could be greatly simplified with optional PodPreset manifests. So I was looking forward to getting them available for use. Things in alpha can never gain traction or significant interest because managed providers won't let you enable them. This is not really a case of 'perma-beta'. But, if they were not going anywhere then I can understand removing them.\nSpeaking of gaining traction and momentum, the 'Avoiding permanent beta' policy only has a nine-month countdown for beta features. This new policy clashes with the recent popularity of managed releases, which tend to lag upstream releases by 6-9 months (2-3 releases). E.g. the current . That is before users can start planning upgrades in the 3-6 months after that. So a brand-spanking new beta feature won't reach cloud provider users until 9-15 months after it reaches beta upstream. Then users will start trying it out, and if it works well and get some interest and momentum behind it, only to find it has been already removed from a subsequent releases because of the mandatory 9-month policy In practice AWS probably won't enable a beta feature that is already removed upstream, so we can basically expect beta features will never reach, or get a chance for real-world feedback from cloud provider users. It is going to be tough for when the real world can't test a release with a beta feature until after it has already hit mandatory removal\nFor long running alpha features I usually recommend announcing depreaction and removing after one release, instead of right away. For extending the beta policy please see:\nPlease don't remove this feature! We only just discovered it this week and it was positioned to solve a real issue with common volume specs, in the same way mentioned by It would be really sad to now see it removed when it was going to fix some integration issues for us!\nCould you elaborate on why PodPresets were never promoted to beta and why you want to remove them now? It seems like a useful feature.\nThis feature would have been very useful in several operating scenarios, such as setting proxy settings before a deployment.\nCan anyone comment on what alternatives are? Without this feature we'll have a lot of duplication. No one likes duplication. We can address the Environment variables via ConfigMap and the envFrom keyword, however I cannot see anything for volumes, imagePullSecret etc.\nIt seems the alternative is just to use mutating webhooks. And there is even a port of PodPreset to a mutating web hook by redhat:\n-1000 Removing PodPreset is terrible. Shame on you!\nIt doesn't look much maintained and active, sadly\nRelated:", "positive_passages": [{"docid": "doc-en-kubernetes-9c32799a595e38a66b9e214e9215a1421da0854d18c8ba6009587856518616a5", "text": "\"ResourceQuota\", \"Role\", \"PriorityClass\", <del> \"PodPreset\", </del> \"AuditSink\", )", "commid": "kubernetes_pr_102336"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-24e50eba12cc5bb3b5fa8345e285846b14a09171148bf8d2bcc8a56f1bc6a4de", "query": "Currently we unconditionally move pods out of unschedulable status when an event happens. However, we can optimize this by setting some conditions for each event to avoid unnecessarily doing that: 1) PV, PVC, StorageClass or CSINode add/update: move only pods with a PVC. 2) Service add/update: only if ServiceAffinity plugin is enabled in one of the profiles 3) Node add/update: test the pods against the , this include: NodeAffinity, NodeName NodePorts, NodeResources and TaintsTolerations filters. 4) Pod delete: keep it as is (spreading or affinity constraints must be tested, which is expensive to do) This is necessary to avoid wasting scheduling cycles. Related proposal: /sig scheduling /assign\nGitHub didn't allow me to assign the following users: adtac. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Currently we unconditionally move pods out of unschedulable status when an event happens. However, we can optimize this by setting some conditions for each event to avoid unnecessarily doing that: 2) Service add/update: only if ServiceAffinity plugin is enabled in one of the profiles 3) Node add/update: test the pods against the , this include: NodeAffinity, NodeName NodePorts, NodeResources and TaintsTolerations filters. 4) Pod delete: keep it as is (spreading or affinity constraints must be tested, which is expensive to do) /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/cc I'm thinking of if we can amplify the scope: which is to say, not only enable/disable moving (all) pods, but also provides mechanics to let plugins notify the scheduler framework which particular pods should be moved. This would benefits in 's coscheduling implementation to move the preceding (N-1) pods back to activeQ when the Nth pod comes - which satisfies the \"minAvaialbe\" requirement. Moreover, this would help in getting rid of flushing pods back to activeQ .\nThe suggestion is not to enable/disable moving all pods in all events, this is only true for the Service events. For the other two, node and volumes, we will test each pod and move the ones that pass the condition. I agree that our proposal of integrating this with filters/permit plugins is more generic, but it adds a lot of complexity and potential for bugs, so we need to be careful with that I think.\nOne approach could be to start simple, validate and establish a reference point in terms of perf improvements, and then migrate to something more generic. The more generic approach will not be more performant than what is proposed in this issue.\nYes, filters/permit runs in the critical path, and move Pods isn't a lock-free operation. What I want to say is during the design/implementation of this proposal, keep it in mind that plugins may need to actively \"suggest\" moving particular Pods back to activeQ. Agree.\nRight, we already designed the interface for such a potential eventuality:\njust fixing double \"moving\" in title: /retitle Avoid moving pods out of unschedulable status unconditionally\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\n/assign /unassign\n/cc\nwhat is the current plan? Is it to do the entire proposal in \"Efficient Requeuing\" doc or just the minimal checks proposed in the issue?\nI plan to fix the problems mentioned in this issue, but not entirely following the logic mentioned here. For example, it's inappropriate to move a Pod with PVC once a CSINode happens - the Pod may fail due to a reason irrelevant to its PVC. What I'm proposing is more aligned with the Google doc, but there are 2 major distinctions: I'm not associating the interface to a particular extension point - the EventsToRegister is more a general hook instead of semantically associated with a particular scheduling phase. I'm not going to pass the changed event object to let users decide whether to move or not - that'd increase the latency, also impose an extra burden on plugin developers. Fixing this issue is the minimum goal I can promise in 1.21, but in the future, we may provide other interfaces like enable users to proactively move Pods inside scheduling queue.\nThat is true, but this is the case right now, not something new this issue is proposing to do. This issue is proposing to address the obvious moves that we can avoid with minimal complexity, which will also likely give us the most bang for the buck. Do you have a more detailed proposal for what you are planning to do?\nYes, the code is almost complete - PR1 () and PR2 (), I will send out another PR later to use ServiceAffinity as an example to show case how it works in details. Basically, the plugin can implement an optional interface called and return a number of ClusterEvents that a Pod failed by that plugin can be made re-schedulable, and also upon a Pod's scheduling failure, we store the \"failed plugin\" into , so that upon moving Pods in the internal queues, we're able to tell whether the Pod's failed plugins are associated/registered with the current event, and hence perform efficient enqueuing.\nYou can wait late today or tomorrow when the 3rd PoC PR will be ready, and it'd show you a whole picture.\nFYI: the 3rd PR to showcase how it works: PoC: ServiceAffinity enqueue .\nDo we have a benchmark we can use to prove that the changes are having a positive impact?\nAlso, are we planning to keep the existing checks that some events have?\nWill do that. Yes, they will be kept.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nI think we should still do 3: or even just NodeAffinity+TaintsTolerations The problem is that just one node is being and potentially we are retrying all pending pods. And this means that we are testing all Nodes for each of those Pods.\nI think we can do sth. like this: upon a Node Add/Update, for each unschedulablePodInfo, only verify if the Pod can pass NodeAffinity/NodePorr/etc. filtering logic when the Pod failed by NodeAffinity/NodePort/etc. plugin. In this way, we can save cycles for Pods not failed with NodeAffinity/NodePort.\nLatest status of this issue: Interface and implementation in framework side [x] Surface info of failed plugins during PerFilter, Filter and Permit [] [x] Store a cluster event to plugin map in SchedulerQueue [] Plugin implementation and perf evaluation.\n/help Some tips/notes for contributors who are interested: please dedicate some time to the item(s) you claimed as code freeze is around the corner, we'd like to finish the above items as early as possible works as a sample you can refer, basically you need to think about which events can make the unschedulabed Pods failed by the specified plugins schedulable, and specify the reasons. Also give a benchmark test result proving it. to design a desired benchmark test, you may need to try the \"churn operator\", which means you need to rebase locally (unless they get merged) if you meet timeout issue frequently during running a 5000Nodes test, you can work it around by rebasing it's a good practice to run the benchmark test multiple times and eliminate the outliers. Here is a for your information.\nI would like to take \u2018 tainttoleration\u2019 to learn something about scheduling plugins.\nThanks! I updated the tips to include a to automate running the benchmark tests multiple times.\nI claim \"nodeports\" and shall learn about it firstly.\nCan I try to deal with the \"nodeaffinity\" plugin\nI would like take \"podtopologyspread\" plugin.\nCan I take ?\nI can take plugin.\nCan I take ?\nCan i take ?\nI opened and will add testcase and test result tommorrow.\nI would like to take on\nI think I'm left with\nupdated with proper owners. Thanks! Please assign the reviewer to me when your PR is ready. /remove-help\nWei, there were followups from , are we tracking them somewhere?\nthe only followup is I will work on that. Let me know if any other followup I missed.\nsg, can you open an issue to track that unless you have an open PR.\nSure, create two issues tracking the follow-ups: [ ] sched: cleanup clusterEventReg from [] [x] sched: requeue optimization upon Node Add/Update []\nI submitted a PR ( ) for NodePorts, not yet tested. I shall test it this week.\nAfter discussion with , due to 1.21 code freeze (today), we decided to postpone merging most of the opening PRs here. Apologize for that - we'd better not rush to avoid regressions. So priority your time on the on-going PRs, we will still review them, just take your time :)\nUse to convert the json files to table.\nThat's a really useful tool thanks so much for writing that!\noh bummer. I would have liked at least serviceaffinity to go in.\nActually, to get rid of the reaction to service changes... all plugins would have to opt-out, so nvm.\nYes, to achieve that, every plugin has to implement EventsToRegister()... BTW: one way is work it around is to add some temporary logic on framework side - skip movingPods upon Service events if ServiceAffinity is not enabled. And remove this temporary logic when all plugins opt-in EventsToRegister() in the next release.\nThat wouldn't qualify for codefreeze though.\nNvm then :)\nWe should simply not register for service updates at all if ServiceAffinity is not configured, which is the default.\nProbably not a great idea to totally disable the registration, as an out-of-tree plugin may choose to respond to Service events.\nWe need to find a way for external plugins to register events because we will remove this registration once the plugin is deprecated.\nYes, also should take CRD into consideration. Probably dynamic informer.\nI still think we should disabled Service event handlers when the plugin is not registered. If an external plugin is using it, then they could enable the service affinity filter plugin with an empty affinity labels or patch event handlers until we figure out a way for external plugins to register extra events. btw, do you know of any external plugins that actually rely on service events?\nThat's fair, and I can work on this, adding some comments caveating this is a temporary workaround. I'm not aware so far.\ntbh, I would say plugins depending on services is an antipattern, given the existence of pod affinity. Probably some CRDs might make sense for specialized plugins.\nwe should add metrics to track the efficiency of the solution. The metric would track the number of pods that were not put back into the queue broken down by plugin and even type for example.\nSG. I compiled a list to include on-going and to-do items here .\nAre you still working on this?\ndid we have PRs for number 2 and number 3?\nI am asking about the two points from the four mentioned in the description of this issue:\nOops, misunderstanding, ignore me.\nnumber 2: mitigated the problem. In short, includes two parts: one part is to remove Service event from default list so that only Pods failed by a plugin (e.g., ServiceAffinity) which explicitly are interested in Service events can be moved; the other part is to implement EventsToRegister() in ServcieAfffinity plugin. But that doesn't prevent the internal processing cycles like going through the unschedulabe pods and verify whether each is failed by that plugin, so it's a mitigation. PR will fix this problem thoroughly. number 3:\nah, yeah, I knew we worked on that in the previous release, lol. Thanks.", "positive_passages": [{"docid": "doc-en-kubernetes-a2615d99e302f31d92054e248471930d2c2303d96966feb85e326f3b8acfaf59", "text": "} var _ framework.FilterPlugin = &CSILimits{} <ins> var _ framework.EnqueueExtensions = &CSILimits{} </ins> // CSIName is the name of the plugin used in the plugin registry and configurations. const CSIName = \"NodeVolumeLimits\"", "commid": "kubernetes_pr_100026"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-24e50eba12cc5bb3b5fa8345e285846b14a09171148bf8d2bcc8a56f1bc6a4de", "query": "Currently we unconditionally move pods out of unschedulable status when an event happens. However, we can optimize this by setting some conditions for each event to avoid unnecessarily doing that: 1) PV, PVC, StorageClass or CSINode add/update: move only pods with a PVC. 2) Service add/update: only if ServiceAffinity plugin is enabled in one of the profiles 3) Node add/update: test the pods against the , this include: NodeAffinity, NodeName NodePorts, NodeResources and TaintsTolerations filters. 4) Pod delete: keep it as is (spreading or affinity constraints must be tested, which is expensive to do) This is necessary to avoid wasting scheduling cycles. Related proposal: /sig scheduling /assign\nGitHub didn't allow me to assign the following users: adtac. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Currently we unconditionally move pods out of unschedulable status when an event happens. However, we can optimize this by setting some conditions for each event to avoid unnecessarily doing that: 2) Service add/update: only if ServiceAffinity plugin is enabled in one of the profiles 3) Node add/update: test the pods against the , this include: NodeAffinity, NodeName NodePorts, NodeResources and TaintsTolerations filters. 4) Pod delete: keep it as is (spreading or affinity constraints must be tested, which is expensive to do) /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/cc I'm thinking of if we can amplify the scope: which is to say, not only enable/disable moving (all) pods, but also provides mechanics to let plugins notify the scheduler framework which particular pods should be moved. This would benefits in 's coscheduling implementation to move the preceding (N-1) pods back to activeQ when the Nth pod comes - which satisfies the \"minAvaialbe\" requirement. Moreover, this would help in getting rid of flushing pods back to activeQ .\nThe suggestion is not to enable/disable moving all pods in all events, this is only true for the Service events. For the other two, node and volumes, we will test each pod and move the ones that pass the condition. I agree that our proposal of integrating this with filters/permit plugins is more generic, but it adds a lot of complexity and potential for bugs, so we need to be careful with that I think.\nOne approach could be to start simple, validate and establish a reference point in terms of perf improvements, and then migrate to something more generic. The more generic approach will not be more performant than what is proposed in this issue.\nYes, filters/permit runs in the critical path, and move Pods isn't a lock-free operation. What I want to say is during the design/implementation of this proposal, keep it in mind that plugins may need to actively \"suggest\" moving particular Pods back to activeQ. Agree.\nRight, we already designed the interface for such a potential eventuality:\njust fixing double \"moving\" in title: /retitle Avoid moving pods out of unschedulable status unconditionally\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\n/assign /unassign\n/cc\nwhat is the current plan? Is it to do the entire proposal in \"Efficient Requeuing\" doc or just the minimal checks proposed in the issue?\nI plan to fix the problems mentioned in this issue, but not entirely following the logic mentioned here. For example, it's inappropriate to move a Pod with PVC once a CSINode happens - the Pod may fail due to a reason irrelevant to its PVC. What I'm proposing is more aligned with the Google doc, but there are 2 major distinctions: I'm not associating the interface to a particular extension point - the EventsToRegister is more a general hook instead of semantically associated with a particular scheduling phase. I'm not going to pass the changed event object to let users decide whether to move or not - that'd increase the latency, also impose an extra burden on plugin developers. Fixing this issue is the minimum goal I can promise in 1.21, but in the future, we may provide other interfaces like enable users to proactively move Pods inside scheduling queue.\nThat is true, but this is the case right now, not something new this issue is proposing to do. This issue is proposing to address the obvious moves that we can avoid with minimal complexity, which will also likely give us the most bang for the buck. Do you have a more detailed proposal for what you are planning to do?\nYes, the code is almost complete - PR1 () and PR2 (), I will send out another PR later to use ServiceAffinity as an example to show case how it works in details. Basically, the plugin can implement an optional interface called and return a number of ClusterEvents that a Pod failed by that plugin can be made re-schedulable, and also upon a Pod's scheduling failure, we store the \"failed plugin\" into , so that upon moving Pods in the internal queues, we're able to tell whether the Pod's failed plugins are associated/registered with the current event, and hence perform efficient enqueuing.\nYou can wait late today or tomorrow when the 3rd PoC PR will be ready, and it'd show you a whole picture.\nFYI: the 3rd PR to showcase how it works: PoC: ServiceAffinity enqueue .\nDo we have a benchmark we can use to prove that the changes are having a positive impact?\nAlso, are we planning to keep the existing checks that some events have?\nWill do that. Yes, they will be kept.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nI think we should still do 3: or even just NodeAffinity+TaintsTolerations The problem is that just one node is being and potentially we are retrying all pending pods. And this means that we are testing all Nodes for each of those Pods.\nI think we can do sth. like this: upon a Node Add/Update, for each unschedulablePodInfo, only verify if the Pod can pass NodeAffinity/NodePorr/etc. filtering logic when the Pod failed by NodeAffinity/NodePort/etc. plugin. In this way, we can save cycles for Pods not failed with NodeAffinity/NodePort.\nLatest status of this issue: Interface and implementation in framework side [x] Surface info of failed plugins during PerFilter, Filter and Permit [] [x] Store a cluster event to plugin map in SchedulerQueue [] Plugin implementation and perf evaluation.\n/help Some tips/notes for contributors who are interested: please dedicate some time to the item(s) you claimed as code freeze is around the corner, we'd like to finish the above items as early as possible works as a sample you can refer, basically you need to think about which events can make the unschedulabed Pods failed by the specified plugins schedulable, and specify the reasons. Also give a benchmark test result proving it. to design a desired benchmark test, you may need to try the \"churn operator\", which means you need to rebase locally (unless they get merged) if you meet timeout issue frequently during running a 5000Nodes test, you can work it around by rebasing it's a good practice to run the benchmark test multiple times and eliminate the outliers. Here is a for your information.\nI would like to take \u2018 tainttoleration\u2019 to learn something about scheduling plugins.\nThanks! I updated the tips to include a to automate running the benchmark tests multiple times.\nI claim \"nodeports\" and shall learn about it firstly.\nCan I try to deal with the \"nodeaffinity\" plugin\nI would like take \"podtopologyspread\" plugin.\nCan I take ?\nI can take plugin.\nCan I take ?\nCan i take ?\nI opened and will add testcase and test result tommorrow.\nI would like to take on\nI think I'm left with\nupdated with proper owners. Thanks! Please assign the reviewer to me when your PR is ready. /remove-help\nWei, there were followups from , are we tracking them somewhere?\nthe only followup is I will work on that. Let me know if any other followup I missed.\nsg, can you open an issue to track that unless you have an open PR.\nSure, create two issues tracking the follow-ups: [ ] sched: cleanup clusterEventReg from [] [x] sched: requeue optimization upon Node Add/Update []\nI submitted a PR ( ) for NodePorts, not yet tested. I shall test it this week.\nAfter discussion with , due to 1.21 code freeze (today), we decided to postpone merging most of the opening PRs here. Apologize for that - we'd better not rush to avoid regressions. So priority your time on the on-going PRs, we will still review them, just take your time :)\nUse to convert the json files to table.\nThat's a really useful tool thanks so much for writing that!\noh bummer. I would have liked at least serviceaffinity to go in.\nActually, to get rid of the reaction to service changes... all plugins would have to opt-out, so nvm.\nYes, to achieve that, every plugin has to implement EventsToRegister()... BTW: one way is work it around is to add some temporary logic on framework side - skip movingPods upon Service events if ServiceAffinity is not enabled. And remove this temporary logic when all plugins opt-in EventsToRegister() in the next release.\nThat wouldn't qualify for codefreeze though.\nNvm then :)\nWe should simply not register for service updates at all if ServiceAffinity is not configured, which is the default.\nProbably not a great idea to totally disable the registration, as an out-of-tree plugin may choose to respond to Service events.\nWe need to find a way for external plugins to register events because we will remove this registration once the plugin is deprecated.\nYes, also should take CRD into consideration. Probably dynamic informer.\nI still think we should disabled Service event handlers when the plugin is not registered. If an external plugin is using it, then they could enable the service affinity filter plugin with an empty affinity labels or patch event handlers until we figure out a way for external plugins to register extra events. btw, do you know of any external plugins that actually rely on service events?\nThat's fair, and I can work on this, adding some comments caveating this is a temporary workaround. I'm not aware so far.\ntbh, I would say plugins depending on services is an antipattern, given the existence of pod affinity. Probably some CRDs might make sense for specialized plugins.\nwe should add metrics to track the efficiency of the solution. The metric would track the number of pods that were not put back into the queue broken down by plugin and even type for example.\nSG. I compiled a list to include on-going and to-do items here .\nAre you still working on this?\ndid we have PRs for number 2 and number 3?\nI am asking about the two points from the four mentioned in the description of this issue:\nOops, misunderstanding, ignore me.\nnumber 2: mitigated the problem. In short, includes two parts: one part is to remove Service event from default list so that only Pods failed by a plugin (e.g., ServiceAffinity) which explicitly are interested in Service events can be moved; the other part is to implement EventsToRegister() in ServcieAfffinity plugin. But that doesn't prevent the internal processing cycles like going through the unschedulabe pods and verify whether each is failed by that plugin, so it's a mitigation. PR will fix this problem thoroughly. number 3:\nah, yeah, I knew we worked on that in the previous release, lol. Thanks.", "positive_passages": [{"docid": "doc-en-kubernetes-7dcd8a2daebd0abaa5cce8f5c0f1e8dbfec9e48550ef4a0018db40b286cb670e", "text": "return CSIName } <ins> // EventsToRegister returns the possible events that may make a Pod // failed by this plugin schedulable. func (pl *CSILimits) EventsToRegister() []framework.ClusterEvent { return []framework.ClusterEvent{ {Resource: framework.CSINode, ActionType: framework.Add}, {Resource: framework.Pod, ActionType: framework.Delete}, } } </ins> // Filter invoked at the filter extension point. func (pl *CSILimits) Filter(ctx context.Context, _ *framework.CycleState, pod *v1.Pod, nodeInfo *framework.NodeInfo) *framework.Status { // If the new pod doesn't have any volume attached to it, the predicate will always be true", "commid": "kubernetes_pr_100026"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-24e50eba12cc5bb3b5fa8345e285846b14a09171148bf8d2bcc8a56f1bc6a4de", "query": "Currently we unconditionally move pods out of unschedulable status when an event happens. However, we can optimize this by setting some conditions for each event to avoid unnecessarily doing that: 1) PV, PVC, StorageClass or CSINode add/update: move only pods with a PVC. 2) Service add/update: only if ServiceAffinity plugin is enabled in one of the profiles 3) Node add/update: test the pods against the , this include: NodeAffinity, NodeName NodePorts, NodeResources and TaintsTolerations filters. 4) Pod delete: keep it as is (spreading or affinity constraints must be tested, which is expensive to do) This is necessary to avoid wasting scheduling cycles. Related proposal: /sig scheduling /assign\nGitHub didn't allow me to assign the following users: adtac. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Currently we unconditionally move pods out of unschedulable status when an event happens. However, we can optimize this by setting some conditions for each event to avoid unnecessarily doing that: 2) Service add/update: only if ServiceAffinity plugin is enabled in one of the profiles 3) Node add/update: test the pods against the , this include: NodeAffinity, NodeName NodePorts, NodeResources and TaintsTolerations filters. 4) Pod delete: keep it as is (spreading or affinity constraints must be tested, which is expensive to do) /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/cc I'm thinking of if we can amplify the scope: which is to say, not only enable/disable moving (all) pods, but also provides mechanics to let plugins notify the scheduler framework which particular pods should be moved. This would benefits in 's coscheduling implementation to move the preceding (N-1) pods back to activeQ when the Nth pod comes - which satisfies the \"minAvaialbe\" requirement. Moreover, this would help in getting rid of flushing pods back to activeQ .\nThe suggestion is not to enable/disable moving all pods in all events, this is only true for the Service events. For the other two, node and volumes, we will test each pod and move the ones that pass the condition. I agree that our proposal of integrating this with filters/permit plugins is more generic, but it adds a lot of complexity and potential for bugs, so we need to be careful with that I think.\nOne approach could be to start simple, validate and establish a reference point in terms of perf improvements, and then migrate to something more generic. The more generic approach will not be more performant than what is proposed in this issue.\nYes, filters/permit runs in the critical path, and move Pods isn't a lock-free operation. What I want to say is during the design/implementation of this proposal, keep it in mind that plugins may need to actively \"suggest\" moving particular Pods back to activeQ. Agree.\nRight, we already designed the interface for such a potential eventuality:\njust fixing double \"moving\" in title: /retitle Avoid moving pods out of unschedulable status unconditionally\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\n/assign /unassign\n/cc\nwhat is the current plan? Is it to do the entire proposal in \"Efficient Requeuing\" doc or just the minimal checks proposed in the issue?\nI plan to fix the problems mentioned in this issue, but not entirely following the logic mentioned here. For example, it's inappropriate to move a Pod with PVC once a CSINode happens - the Pod may fail due to a reason irrelevant to its PVC. What I'm proposing is more aligned with the Google doc, but there are 2 major distinctions: I'm not associating the interface to a particular extension point - the EventsToRegister is more a general hook instead of semantically associated with a particular scheduling phase. I'm not going to pass the changed event object to let users decide whether to move or not - that'd increase the latency, also impose an extra burden on plugin developers. Fixing this issue is the minimum goal I can promise in 1.21, but in the future, we may provide other interfaces like enable users to proactively move Pods inside scheduling queue.\nThat is true, but this is the case right now, not something new this issue is proposing to do. This issue is proposing to address the obvious moves that we can avoid with minimal complexity, which will also likely give us the most bang for the buck. Do you have a more detailed proposal for what you are planning to do?\nYes, the code is almost complete - PR1 () and PR2 (), I will send out another PR later to use ServiceAffinity as an example to show case how it works in details. Basically, the plugin can implement an optional interface called and return a number of ClusterEvents that a Pod failed by that plugin can be made re-schedulable, and also upon a Pod's scheduling failure, we store the \"failed plugin\" into , so that upon moving Pods in the internal queues, we're able to tell whether the Pod's failed plugins are associated/registered with the current event, and hence perform efficient enqueuing.\nYou can wait late today or tomorrow when the 3rd PoC PR will be ready, and it'd show you a whole picture.\nFYI: the 3rd PR to showcase how it works: PoC: ServiceAffinity enqueue .\nDo we have a benchmark we can use to prove that the changes are having a positive impact?\nAlso, are we planning to keep the existing checks that some events have?\nWill do that. Yes, they will be kept.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nI think we should still do 3: or even just NodeAffinity+TaintsTolerations The problem is that just one node is being and potentially we are retrying all pending pods. And this means that we are testing all Nodes for each of those Pods.\nI think we can do sth. like this: upon a Node Add/Update, for each unschedulablePodInfo, only verify if the Pod can pass NodeAffinity/NodePorr/etc. filtering logic when the Pod failed by NodeAffinity/NodePort/etc. plugin. In this way, we can save cycles for Pods not failed with NodeAffinity/NodePort.\nLatest status of this issue: Interface and implementation in framework side [x] Surface info of failed plugins during PerFilter, Filter and Permit [] [x] Store a cluster event to plugin map in SchedulerQueue [] Plugin implementation and perf evaluation.\n/help Some tips/notes for contributors who are interested: please dedicate some time to the item(s) you claimed as code freeze is around the corner, we'd like to finish the above items as early as possible works as a sample you can refer, basically you need to think about which events can make the unschedulabed Pods failed by the specified plugins schedulable, and specify the reasons. Also give a benchmark test result proving it. to design a desired benchmark test, you may need to try the \"churn operator\", which means you need to rebase locally (unless they get merged) if you meet timeout issue frequently during running a 5000Nodes test, you can work it around by rebasing it's a good practice to run the benchmark test multiple times and eliminate the outliers. Here is a for your information.\nI would like to take \u2018 tainttoleration\u2019 to learn something about scheduling plugins.\nThanks! I updated the tips to include a to automate running the benchmark tests multiple times.\nI claim \"nodeports\" and shall learn about it firstly.\nCan I try to deal with the \"nodeaffinity\" plugin\nI would like take \"podtopologyspread\" plugin.\nCan I take ?\nI can take plugin.\nCan I take ?\nCan i take ?\nI opened and will add testcase and test result tommorrow.\nI would like to take on\nI think I'm left with\nupdated with proper owners. Thanks! Please assign the reviewer to me when your PR is ready. /remove-help\nWei, there were followups from , are we tracking them somewhere?\nthe only followup is I will work on that. Let me know if any other followup I missed.\nsg, can you open an issue to track that unless you have an open PR.\nSure, create two issues tracking the follow-ups: [ ] sched: cleanup clusterEventReg from [] [x] sched: requeue optimization upon Node Add/Update []\nI submitted a PR ( ) for NodePorts, not yet tested. I shall test it this week.\nAfter discussion with , due to 1.21 code freeze (today), we decided to postpone merging most of the opening PRs here. Apologize for that - we'd better not rush to avoid regressions. So priority your time on the on-going PRs, we will still review them, just take your time :)\nUse to convert the json files to table.\nThat's a really useful tool thanks so much for writing that!\noh bummer. I would have liked at least serviceaffinity to go in.\nActually, to get rid of the reaction to service changes... all plugins would have to opt-out, so nvm.\nYes, to achieve that, every plugin has to implement EventsToRegister()... BTW: one way is work it around is to add some temporary logic on framework side - skip movingPods upon Service events if ServiceAffinity is not enabled. And remove this temporary logic when all plugins opt-in EventsToRegister() in the next release.\nThat wouldn't qualify for codefreeze though.\nNvm then :)\nWe should simply not register for service updates at all if ServiceAffinity is not configured, which is the default.\nProbably not a great idea to totally disable the registration, as an out-of-tree plugin may choose to respond to Service events.\nWe need to find a way for external plugins to register events because we will remove this registration once the plugin is deprecated.\nYes, also should take CRD into consideration. Probably dynamic informer.\nI still think we should disabled Service event handlers when the plugin is not registered. If an external plugin is using it, then they could enable the service affinity filter plugin with an empty affinity labels or patch event handlers until we figure out a way for external plugins to register extra events. btw, do you know of any external plugins that actually rely on service events?\nThat's fair, and I can work on this, adding some comments caveating this is a temporary workaround. I'm not aware so far.\ntbh, I would say plugins depending on services is an antipattern, given the existence of pod affinity. Probably some CRDs might make sense for specialized plugins.\nwe should add metrics to track the efficiency of the solution. The metric would track the number of pods that were not put back into the queue broken down by plugin and even type for example.\nSG. I compiled a list to include on-going and to-do items here .\nAre you still working on this?\ndid we have PRs for number 2 and number 3?\nI am asking about the two points from the four mentioned in the description of this issue:\nOops, misunderstanding, ignore me.\nnumber 2: mitigated the problem. In short, includes two parts: one part is to remove Service event from default list so that only Pods failed by a plugin (e.g., ServiceAffinity) which explicitly are interested in Service events can be moved; the other part is to implement EventsToRegister() in ServcieAfffinity plugin. But that doesn't prevent the internal processing cycles like going through the unschedulabe pods and verify whether each is failed by that plugin, so it's a mitigation. PR will fix this problem thoroughly. number 3:\nah, yeah, I knew we worked on that in the previous release, lol. Thanks.", "positive_passages": [{"docid": "doc-en-kubernetes-75ba70bd223c63c8178c6a04906b71f37242db219cf51f71cda8068b467f0fa3", "text": "} var _ framework.FilterPlugin = &nonCSILimits{} <ins> var _ framework.EnqueueExtensions = &nonCSILimits{} </ins> // newNonCSILimitsWithInformerFactory returns a plugin with filter name and informer factory. func newNonCSILimitsWithInformerFactory(", "commid": "kubernetes_pr_100026"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-24e50eba12cc5bb3b5fa8345e285846b14a09171148bf8d2bcc8a56f1bc6a4de", "query": "Currently we unconditionally move pods out of unschedulable status when an event happens. However, we can optimize this by setting some conditions for each event to avoid unnecessarily doing that: 1) PV, PVC, StorageClass or CSINode add/update: move only pods with a PVC. 2) Service add/update: only if ServiceAffinity plugin is enabled in one of the profiles 3) Node add/update: test the pods against the , this include: NodeAffinity, NodeName NodePorts, NodeResources and TaintsTolerations filters. 4) Pod delete: keep it as is (spreading or affinity constraints must be tested, which is expensive to do) This is necessary to avoid wasting scheduling cycles. Related proposal: /sig scheduling /assign\nGitHub didn't allow me to assign the following users: adtac. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : Currently we unconditionally move pods out of unschedulable status when an event happens. However, we can optimize this by setting some conditions for each event to avoid unnecessarily doing that: 2) Service add/update: only if ServiceAffinity plugin is enabled in one of the profiles 3) Node add/update: test the pods against the , this include: NodeAffinity, NodeName NodePorts, NodeResources and TaintsTolerations filters. 4) Pod delete: keep it as is (spreading or affinity constraints must be tested, which is expensive to do) /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/cc I'm thinking of if we can amplify the scope: which is to say, not only enable/disable moving (all) pods, but also provides mechanics to let plugins notify the scheduler framework which particular pods should be moved. This would benefits in 's coscheduling implementation to move the preceding (N-1) pods back to activeQ when the Nth pod comes - which satisfies the \"minAvaialbe\" requirement. Moreover, this would help in getting rid of flushing pods back to activeQ .\nThe suggestion is not to enable/disable moving all pods in all events, this is only true for the Service events. For the other two, node and volumes, we will test each pod and move the ones that pass the condition. I agree that our proposal of integrating this with filters/permit plugins is more generic, but it adds a lot of complexity and potential for bugs, so we need to be careful with that I think.\nOne approach could be to start simple, validate and establish a reference point in terms of perf improvements, and then migrate to something more generic. The more generic approach will not be more performant than what is proposed in this issue.\nYes, filters/permit runs in the critical path, and move Pods isn't a lock-free operation. What I want to say is during the design/implementation of this proposal, keep it in mind that plugins may need to actively \"suggest\" moving particular Pods back to activeQ. Agree.\nRight, we already designed the interface for such a potential eventuality:\njust fixing double \"moving\" in title: /retitle Avoid moving pods out of unschedulable status unconditionally\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\n/assign /unassign\n/cc\nwhat is the current plan? Is it to do the entire proposal in \"Efficient Requeuing\" doc or just the minimal checks proposed in the issue?\nI plan to fix the problems mentioned in this issue, but not entirely following the logic mentioned here. For example, it's inappropriate to move a Pod with PVC once a CSINode happens - the Pod may fail due to a reason irrelevant to its PVC. What I'm proposing is more aligned with the Google doc, but there are 2 major distinctions: I'm not associating the interface to a particular extension point - the EventsToRegister is more a general hook instead of semantically associated with a particular scheduling phase. I'm not going to pass the changed event object to let users decide whether to move or not - that'd increase the latency, also impose an extra burden on plugin developers. Fixing this issue is the minimum goal I can promise in 1.21, but in the future, we may provide other interfaces like enable users to proactively move Pods inside scheduling queue.\nThat is true, but this is the case right now, not something new this issue is proposing to do. This issue is proposing to address the obvious moves that we can avoid with minimal complexity, which will also likely give us the most bang for the buck. Do you have a more detailed proposal for what you are planning to do?\nYes, the code is almost complete - PR1 () and PR2 (), I will send out another PR later to use ServiceAffinity as an example to show case how it works in details. Basically, the plugin can implement an optional interface called and return a number of ClusterEvents that a Pod failed by that plugin can be made re-schedulable, and also upon a Pod's scheduling failure, we store the \"failed plugin\" into , so that upon moving Pods in the internal queues, we're able to tell whether the Pod's failed plugins are associated/registered with the current event, and hence perform efficient enqueuing.\nYou can wait late today or tomorrow when the 3rd PoC PR will be ready, and it'd show you a whole picture.\nFYI: the 3rd PR to showcase how it works: PoC: ServiceAffinity enqueue .\nDo we have a benchmark we can use to prove that the changes are having a positive impact?\nAlso, are we planning to keep the existing checks that some events have?\nWill do that. Yes, they will be kept.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nI think we should still do 3: or even just NodeAffinity+TaintsTolerations The problem is that just one node is being and potentially we are retrying all pending pods. And this means that we are testing all Nodes for each of those Pods.\nI think we can do sth. like this: upon a Node Add/Update, for each unschedulablePodInfo, only verify if the Pod can pass NodeAffinity/NodePorr/etc. filtering logic when the Pod failed by NodeAffinity/NodePort/etc. plugin. In this way, we can save cycles for Pods not failed with NodeAffinity/NodePort.\nLatest status of this issue: Interface and implementation in framework side [x] Surface info of failed plugins during PerFilter, Filter and Permit [] [x] Store a cluster event to plugin map in SchedulerQueue [] Plugin implementation and perf evaluation.\n/help Some tips/notes for contributors who are interested: please dedicate some time to the item(s) you claimed as code freeze is around the corner, we'd like to finish the above items as early as possible works as a sample you can refer, basically you need to think about which events can make the unschedulabed Pods failed by the specified plugins schedulable, and specify the reasons. Also give a benchmark test result proving it. to design a desired benchmark test, you may need to try the \"churn operator\", which means you need to rebase locally (unless they get merged) if you meet timeout issue frequently during running a 5000Nodes test, you can work it around by rebasing it's a good practice to run the benchmark test multiple times and eliminate the outliers. Here is a for your information.\nI would like to take \u2018 tainttoleration\u2019 to learn something about scheduling plugins.\nThanks! I updated the tips to include a to automate running the benchmark tests multiple times.\nI claim \"nodeports\" and shall learn about it firstly.\nCan I try to deal with the \"nodeaffinity\" plugin\nI would like take \"podtopologyspread\" plugin.\nCan I take ?\nI can take plugin.\nCan I take ?\nCan i take ?\nI opened and will add testcase and test result tommorrow.\nI would like to take on\nI think I'm left with\nupdated with proper owners. Thanks! Please assign the reviewer to me when your PR is ready. /remove-help\nWei, there were followups from , are we tracking them somewhere?\nthe only followup is I will work on that. Let me know if any other followup I missed.\nsg, can you open an issue to track that unless you have an open PR.\nSure, create two issues tracking the follow-ups: [ ] sched: cleanup clusterEventReg from [] [x] sched: requeue optimization upon Node Add/Update []\nI submitted a PR ( ) for NodePorts, not yet tested. I shall test it this week.\nAfter discussion with , due to 1.21 code freeze (today), we decided to postpone merging most of the opening PRs here. Apologize for that - we'd better not rush to avoid regressions. So priority your time on the on-going PRs, we will still review them, just take your time :)\nUse to convert the json files to table.\nThat's a really useful tool thanks so much for writing that!\noh bummer. I would have liked at least serviceaffinity to go in.\nActually, to get rid of the reaction to service changes... all plugins would have to opt-out, so nvm.\nYes, to achieve that, every plugin has to implement EventsToRegister()... BTW: one way is work it around is to add some temporary logic on framework side - skip movingPods upon Service events if ServiceAffinity is not enabled. And remove this temporary logic when all plugins opt-in EventsToRegister() in the next release.\nThat wouldn't qualify for codefreeze though.\nNvm then :)\nWe should simply not register for service updates at all if ServiceAffinity is not configured, which is the default.\nProbably not a great idea to totally disable the registration, as an out-of-tree plugin may choose to respond to Service events.\nWe need to find a way for external plugins to register events because we will remove this registration once the plugin is deprecated.\nYes, also should take CRD into consideration. Probably dynamic informer.\nI still think we should disabled Service event handlers when the plugin is not registered. If an external plugin is using it, then they could enable the service affinity filter plugin with an empty affinity labels or patch event handlers until we figure out a way for external plugins to register extra events. btw, do you know of any external plugins that actually rely on service events?\nThat's fair, and I can work on this, adding some comments caveating this is a temporary workaround. I'm not aware so far.\ntbh, I would say plugins depending on services is an antipattern, given the existence of pod affinity. Probably some CRDs might make sense for specialized plugins.\nwe should add metrics to track the efficiency of the solution. The metric would track the number of pods that were not put back into the queue broken down by plugin and even type for example.\nSG. I compiled a list to include on-going and to-do items here .\nAre you still working on this?\ndid we have PRs for number 2 and number 3?\nI am asking about the two points from the four mentioned in the description of this issue:\nOops, misunderstanding, ignore me.\nnumber 2: mitigated the problem. In short, includes two parts: one part is to remove Service event from default list so that only Pods failed by a plugin (e.g., ServiceAffinity) which explicitly are interested in Service events can be moved; the other part is to implement EventsToRegister() in ServcieAfffinity plugin. But that doesn't prevent the internal processing cycles like going through the unschedulabe pods and verify whether each is failed by that plugin, so it's a mitigation. PR will fix this problem thoroughly. number 3:\nah, yeah, I knew we worked on that in the previous release, lol. Thanks.", "positive_passages": [{"docid": "doc-en-kubernetes-3c6936e2f5d138320ca27843db3357f3b2084b06bf5e626ccd7ab2c6b3fd816c", "text": "return pl.name } <ins> // EventsToRegister returns the possible events that may make a Pod // failed by this plugin schedulable. func (pl *nonCSILimits) EventsToRegister() []framework.ClusterEvent { return []framework.ClusterEvent{ {Resource: framework.Node, ActionType: framework.Add}, {Resource: framework.Pod, ActionType: framework.Delete}, } } </ins> // Filter invoked at the filter extension point. func (pl *nonCSILimits) Filter(ctx context.Context, _ *framework.CycleState, pod *v1.Pod, nodeInfo *framework.NodeInfo) *framework.Status { // If a pod doesn't have any volume attached to it, the predicate will always be true.", "commid": "kubernetes_pr_100026"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4f93c5799e56971be0d3796b0b592551cd30baaaf66c87c579655acba8af4b2a", "query": "What happened: We're seeing legacy-cloud-providers/azure/clients (in our case, the synchronised copy used by latest cluster-autoscaler (1.19)) segfaulting under heavy pressure and ARM throttling: In that specific case the cluster-autoscaler triggered the issue, but it can likely affect other ARM clients using that code, including in-tree kubelet or controller-manager. What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.18.8 Cloud provider or hardware configuration: Azure OS (e.g: ): Ubuntu 20.04.1 LTS Kernel (e.g. ): 5.4.0-1022-azure -Ubuntu SMP Install tools: Network plugin and version (if this is a network-related bug): Others: /kind bug /sig cloud-provider /area provider/azure\n/milestone v1.20", "positive_passages": [{"docid": "doc-en-kubernetes-d4d49d0bd8ef4029f6bf031ccbe975d6c5275e03990d2f76eff021e9699e4ba2", "text": "request, retry.DoExponentialBackoffRetry(&sendBackoff), ) <ins> if response == nil && err == nil { return response, retry.NewError(false, fmt.Errorf(\"Empty response and no HTTP code\")) } </ins> return response, retry.GetError(response, err) }", "commid": "kubernetes_pr_94078"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-09f1be3358f1008ea8ae3f56d8aeca95a4589f9723026541a3a3d10cb2e0c00f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: is created on a cgroup2 host What you expected to happen: Such directory should not be created How to reproduce it (as minimally and precisely as possible): Boot Ubuntu 20.04 with Install moby/moby with containerd/containerd and opencontainers/runc Install kubernetes-sigs/kind . This version uses as the base image. Run with Run Run to drop into the shell of the node The following directories are unexpectedly created. (No process seems to belong to these groups actually) Environment: (See above)\ncc\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-a932de7f601b2ce44f9b3a0df075c96a2647220b6b124bef583c6bcff3fde7dc", "text": "if m.adapter.cgroupManagerType == libcontainerSystemd { updateSystemdCgroupInfo(libcontainerCgroupConfig, cgroupConfig.Name) } else { <del> if libcontainercgroups.IsCgroup2UnifiedMode() { libcontainerCgroupConfig.Path = m.buildCgroupUnifiedPath(cgroupConfig.Name) } else { libcontainerCgroupConfig.Path = cgroupConfig.Name.ToCgroupfs() } </del> <ins> libcontainerCgroupConfig.Path = cgroupConfig.Name.ToCgroupfs() </ins> } manager, err := m.adapter.newManager(libcontainerCgroupConfig, cgroupPaths)", "commid": "kubernetes_pr_94111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-09f1be3358f1008ea8ae3f56d8aeca95a4589f9723026541a3a3d10cb2e0c00f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: is created on a cgroup2 host What you expected to happen: Such directory should not be created How to reproduce it (as minimally and precisely as possible): Boot Ubuntu 20.04 with Install moby/moby with containerd/containerd and opencontainers/runc Install kubernetes-sigs/kind . This version uses as the base image. Run with Run Run to drop into the shell of the node The following directories are unexpectedly created. (No process seems to belong to these groups actually) Environment: (See above)\ncc\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-b2221d938525126b8fefac3ad05570cef7e40dcf0b629f8ea7aafa5f66e112c8", "text": "// propagateControllers on an unified hierarchy enables all the supported controllers for the specified cgroup func propagateControllers(path string) error { <del> if err := os.MkdirAll(path, 0755); err != nil { </del> <ins> if err := os.MkdirAll(filepath.Join(cmutil.CgroupRoot, path), 0755); err != nil { </ins> return fmt.Errorf(\"failed to create cgroup %q : %v\", path, err) }", "commid": "kubernetes_pr_94111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-09f1be3358f1008ea8ae3f56d8aeca95a4589f9723026541a3a3d10cb2e0c00f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: is created on a cgroup2 host What you expected to happen: Such directory should not be created How to reproduce it (as minimally and precisely as possible): Boot Ubuntu 20.04 with Install moby/moby with containerd/containerd and opencontainers/runc Install kubernetes-sigs/kind . This version uses as the base image. Run with Run Run to drop into the shell of the node The following directories are unexpectedly created. (No process seems to belong to these groups actually) Environment: (See above)\ncc\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-e5dba9993f71556af19136f43117f0ad80fbf9b3ba85c14f29de9656194ec536", "text": "} current := cmutil.CgroupRoot <del> relPath, err := filepath.Rel(cmutil.CgroupRoot, path) if err != nil { return fmt.Errorf(\"failed to get relative path to cgroup root from %q: %v\", path, err) } </del> // Write the controllers list to each \"cgroup.subtree_control\" file until it reaches the parent cgroup. // For the /foo/bar/baz cgroup, controllers must be enabled sequentially in the files: // - /sys/fs/cgroup/foo/cgroup.subtree_control // - /sys/fs/cgroup/foo/bar/cgroup.subtree_control <del> for _, p := range strings.Split(filepath.Dir(relPath), \"/\") { </del> <ins> for _, p := range strings.Split(filepath.Dir(path), \"/\") { </ins> current = filepath.Join(current, p) if err := ioutil.WriteFile(filepath.Join(current, \"cgroup.subtree_control\"), []byte(controllers), 0755); err != nil { return fmt.Errorf(\"failed to enable controllers on %q: %v\", cmutil.CgroupRoot, err)", "commid": "kubernetes_pr_94111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-09f1be3358f1008ea8ae3f56d8aeca95a4589f9723026541a3a3d10cb2e0c00f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: is created on a cgroup2 host What you expected to happen: Such directory should not be created How to reproduce it (as minimally and precisely as possible): Boot Ubuntu 20.04 with Install moby/moby with containerd/containerd and opencontainers/runc Install kubernetes-sigs/kind . This version uses as the base image. Run with Run Run to drop into the shell of the node The following directories are unexpectedly created. (No process seems to belong to these groups actually) Environment: (See above)\ncc\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-8db86bc2b2f146ac58c6dc7215a3881ea5e894a8943171b5570d8858a04b21c5", "text": "klog.V(6).Infof(\"Optional subsystem not supported: hugetlb\") } <del> manager, err := cgroupfs2.NewManager(cgroupConfig, cgroupConfig.Path, false) </del> <ins> manager, err := cgroupfs2.NewManager(cgroupConfig, filepath.Join(cmutil.CgroupRoot, cgroupConfig.Path), false) </ins> if err != nil { return fmt.Errorf(\"failed to create cgroup v2 manager: %v\", err) }", "commid": "kubernetes_pr_94111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-09f1be3358f1008ea8ae3f56d8aeca95a4589f9723026541a3a3d10cb2e0c00f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: is created on a cgroup2 host What you expected to happen: Such directory should not be created How to reproduce it (as minimally and precisely as possible): Boot Ubuntu 20.04 with Install moby/moby with containerd/containerd and opencontainers/runc Install kubernetes-sigs/kind . This version uses as the base image. Run with Run Run to drop into the shell of the node The following directories are unexpectedly created. (No process seems to belong to these groups actually) Environment: (See above)\ncc\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-a20a4c596998a3ae709d3ced222753090e18e3e81aa2bc685fb81916b84c2f3c", "text": "unified := libcontainercgroups.IsCgroup2UnifiedMode() if unified { <del> libcontainerCgroupConfig.Path = m.buildCgroupUnifiedPath(cgroupConfig.Name) </del> <ins> libcontainerCgroupConfig.Path = cgroupConfig.Name.ToCgroupfs() </ins> } else { libcontainerCgroupConfig.Paths = m.buildCgroupPaths(cgroupConfig.Name) }", "commid": "kubernetes_pr_94111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-09f1be3358f1008ea8ae3f56d8aeca95a4589f9723026541a3a3d10cb2e0c00f", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: is created on a cgroup2 host What you expected to happen: Such directory should not be created How to reproduce it (as minimally and precisely as possible): Boot Ubuntu 20.04 with Install moby/moby with containerd/containerd and opencontainers/runc Install kubernetes-sigs/kind . This version uses as the base image. Run with Run Run to drop into the shell of the node The following directories are unexpectedly created. (No process seems to belong to these groups actually) Environment: (See above)\ncc\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-e4ac7aad7fbd90d7a501cb685b200ef8983c655cbbaa9f0bf4253692842577d9", "text": "if m.adapter.cgroupManagerType == libcontainerSystemd { updateSystemdCgroupInfo(libcontainerCgroupConfig, cgroupConfig.Name) } else { <del> if libcontainercgroups.IsCgroup2UnifiedMode() { libcontainerCgroupConfig.Path = m.buildCgroupUnifiedPath(cgroupConfig.Name) } else { libcontainerCgroupConfig.Path = cgroupConfig.Name.ToCgroupfs() } </del> <ins> libcontainerCgroupConfig.Path = cgroupConfig.Name.ToCgroupfs() </ins> } if utilfeature.DefaultFeatureGate.Enabled(kubefeatures.SupportPodPidsLimit) && cgroupConfig.ResourceParameters != nil && cgroupConfig.ResourceParameters.PidsLimit != nil {", "commid": "kubernetes_pr_94111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e7c476bc2d5f844c8e73dc71610efcbcfe941552138dfa628e2e9ebb146eabad", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Deploy a Windows cluster with containerd configured, SMB mount does not work by trying following project: It reports following error: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.18.6 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /sig windows /sig storage\n/cc\nI was able to repro your issue using the azurefile-csi-driver for Windows. I also tried to set up a repo where I would mount an azure file share to a Windows node manually, create symlinks to the share and then schedule a pod to the node using a hostPath volume and the container was able to start up fine using contianerd. Here is the pod-spec i used I tried to mount the Azure file share with both New-PsDrive and New-SmbGlobalMapping and saw date being written the the in the azure file share in both instances. I used mklink /D to create the symlinks - and also tried creating a symlink chain because it looks like that is how they get set up when when using azurefile-csi-driver and csi-proxy Right now I think this issue may be specific to either how the csi-proxy is setting up the SMB share for Windows or how paths are getting passed around between the various components.\nthis is not related to csi-proxy, in-tree azure file does not use csi-proxy, and it does not work\nhostPath on containerd Windows does not work too:\nI captured containerd logs for this and see I spoke with and he thinks this may be related to a known issue where go-lang is getting confused on Windows if a symlink points directly to the root of a SBM share (which is does in this case). He suggested adding a trailing  to see if this fixes the issue. I will try that out now and report back.\nI tested some updates to CSI proxy to ensure the symlink to the sharepath had a trailing backslash and it looks like that resolved the issue. On my node running contianerd i have the following symlinks Previously the  on pvc--f195-4d9e-841b- was missing.\nThe core issue here is that containerd calls on the mount source path, and that function has a bug which prevents it from working when the path is a UNC share root. If the path has a trailing appended, then works properly. I have filed a bug on Go to fix this, and am working on a fix: golang/go\n/close\nClosing this issue. <detailsIn response to : /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is not resolved, right?\nI see this issue is resolved in csi-proxy v0.2.2, while it's not resolved for the in-tree azure file driver.\n/triage accepted\nAh, good point. yes, this is not fully resolved.", "positive_passages": [{"docid": "doc-en-kubernetes-daa501b199fa6570e4802de4391d6d64f107da113ae8669f2213deddae7f6978", "text": "} } <del> output, err := exec.Command(\"cmd\", \"/c\", \"mklink\", \"/D\", target, bindSource).CombinedOutput() </del> <ins> // There is an issue in golang where EvalSymlinks fails on Windows when passed a // UNC share root path without a trailing backslash. // Ex: SERVERshare will fail to resolve but SERVERshare will resolve // containerD on Windows calls EvalSymlinks so we'll add the backslash when making the symlink if it is missing. // https://github.com/golang/go/pull/42096 fixes this issue in golang but a fix will not be available until // golang v1.16 mklinkSource := bindSource if !strings.HasSuffix(mklinkSource, \"\") { mklinkSource = mklinkSource + \"\" } output, err := exec.Command(\"cmd\", \"/c\", \"mklink\", \"/D\", target, mklinkSource).CombinedOutput() </ins> if err != nil { <del> klog.Errorf(\"mklink failed: %v, source(%q) target(%q) output: %q\", err, bindSource, target, string(output)) </del> <ins> klog.Errorf(\"mklink failed: %v, source(%q) target(%q) output: %q\", err, mklinkSource, target, string(output)) </ins> return err } <del> klog.V(2).Infof(\"mklink source(%q) on target(%q) successfully, output: %q\", bindSource, target, string(output)) </del> <ins> klog.V(2).Infof(\"mklink source(%q) on target(%q) successfully, output: %q\", mklinkSource, target, string(output)) </ins> return nil }", "commid": "kubernetes_pr_96396"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b6c9f2814c257fcf076aee6432b3853318e13bb6778498e0a239839fa2da32e9", "query": "Note: this issue should be viewed in the context of . If this happens, this is very likely a typo where someone used a parameter in a way they didn't mean to (for example, ). /sig scheduling /assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/good-first-issue\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHi this is my first time contributing to kubernetes. can you provide me some guidance on how to to get started?\nHi, is this issue still valid to work on?\nyes, this is still valid. I recommend starting with the and reading from there.\nare you still working on this issue or should I work on it.\nI would like to work on this issue if you haven't started already.\nwould it be ok if I took a look at this?\n/assign\nHi Can you help me in why its not assigning the values to createNodes and createPods directly and using the opcode and countParam in performance-\nWe use a field to differentiate between different operations. The value of the field (e.g. \"createNodes\") determines the operation. The field defines the number of pods/nodes to create. What do you mean by \"assigning the values to createNodes and createPods directly\"?\nThanks for the information. By assigning, I just meant that whether we can assign createNodes directly like ( createNodes: $initNodes ).\nI don't think that's possible since there can potentially be other parameters besides the countParam. For example: Different operations could potentially have different parameters.\ncreateNodes and createPods aren't the only operations. Other operations (e.g. churn and barrier), including future ones, may not fit that format. It's also easier to parse and more explicit this way.\nThanks , Having a doubt more, in performance- under the name:SchedulingPodAntiAffinity, ! why are we giving the same values in 5000Nodes as given in 500Nodes, or this is an error.\nthat sounds like a typo indeed\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nHello Are you still going to work on this issue?\nHi I have worked on the issue but not working for a while as was unsure about the exact problem.\n, no problem if you are willing to work on this issue, shall unassign myself\n/unassign\nThanks :)\n/assign\n/remove-lifecycle stale\nhey! I am beginner and I interested in scheduling and I know basics of scheduling , so how can I start to contribute on this issue.\nSorry, PR for this issue has already created.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-adf3a0d07b8bd2acc9f80a26fed1559978b64adecd07aac5d1d716d339e7ebdd", "text": "// Name of the workload. Name string // Values of parameters used in the workloadTemplate. <del> Params map[string]int </del> <ins> Params params } type params struct { params map[string]int // isUsed field records whether params is used or not. isUsed map[string]bool } // UnmarshalJSON is a custom unmarshaler for params. // // from(json): // \t{ // \t\t\"initNodes\": 500, // \t\t\"initPods\": 50 // \t} // // to: //\tparams{ //\t\tparams: map[string]int{ //\t\t\t\"intNodes\": 500, //\t\t\t\"initPods\": 50, //\t\t}, //\t\tisUsed: map[string]bool{}, // empty map //\t} // func (p *params) UnmarshalJSON(b []byte) error { aux := map[string]int{} if err := json.Unmarshal(b, &aux); err != nil { return err } p.params = aux p.isUsed = map[string]bool{} return nil } // get returns param. func (p params) get(key string) (int, error) { p.isUsed[key] = true param, ok := p.params[key] if ok { return param, nil } return 0, fmt.Errorf(\"parameter %s is undefined\", key) } // unusedParams returns the names of unusedParams func (w workload) unusedParams() []string { var ret []string for name := range w.Params.params { if !w.Params.isUsed[name] { ret = append(ret, name) } } return ret </ins> } // op is a dummy struct which stores the real op in itself.", "commid": "kubernetes_pr_104716"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b6c9f2814c257fcf076aee6432b3853318e13bb6778498e0a239839fa2da32e9", "query": "Note: this issue should be viewed in the context of . If this happens, this is very likely a typo where someone used a parameter in a way they didn't mean to (for example, ). /sig scheduling /assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/good-first-issue\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHi this is my first time contributing to kubernetes. can you provide me some guidance on how to to get started?\nHi, is this issue still valid to work on?\nyes, this is still valid. I recommend starting with the and reading from there.\nare you still working on this issue or should I work on it.\nI would like to work on this issue if you haven't started already.\nwould it be ok if I took a look at this?\n/assign\nHi Can you help me in why its not assigning the values to createNodes and createPods directly and using the opcode and countParam in performance-\nWe use a field to differentiate between different operations. The value of the field (e.g. \"createNodes\") determines the operation. The field defines the number of pods/nodes to create. What do you mean by \"assigning the values to createNodes and createPods directly\"?\nThanks for the information. By assigning, I just meant that whether we can assign createNodes directly like ( createNodes: $initNodes ).\nI don't think that's possible since there can potentially be other parameters besides the countParam. For example: Different operations could potentially have different parameters.\ncreateNodes and createPods aren't the only operations. Other operations (e.g. churn and barrier), including future ones, may not fit that format. It's also easier to parse and more explicit this way.\nThanks , Having a doubt more, in performance- under the name:SchedulingPodAntiAffinity, ! why are we giving the same values in 5000Nodes as given in 500Nodes, or this is an error.\nthat sounds like a typo indeed\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nHello Are you still going to work on this issue?\nHi I have worked on the issue but not working for a while as was unsure about the exact problem.\n, no problem if you are willing to work on this issue, shall unassign myself\n/unassign\nThanks :)\n/assign\n/remove-lifecycle stale\nhey! I am beginner and I interested in scheduling and I know basics of scheduling , so how can I start to contribute on this issue.\nSorry, PR for this issue has already created.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-8889a662a5e42f4447fa19f66502b06fd62c21c156634100629ac07ddd4d4f08", "text": "func (cno createNodesOp) patchParams(w *workload) (realOp, error) { if cno.CountParam != \"\" { <del> var ok bool if cno.Count, ok = w.Params[cno.CountParam[1:]]; !ok { return nil, fmt.Errorf(\"parameter %s is undefined\", cno.CountParam) </del> <ins> var err error cno.Count, err = w.Params.get(cno.CountParam[1:]) if err != nil { return nil, err </ins> } } return &cno, (&cno).isValid(false)", "commid": "kubernetes_pr_104716"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b6c9f2814c257fcf076aee6432b3853318e13bb6778498e0a239839fa2da32e9", "query": "Note: this issue should be viewed in the context of . If this happens, this is very likely a typo where someone used a parameter in a way they didn't mean to (for example, ). /sig scheduling /assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/good-first-issue\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHi this is my first time contributing to kubernetes. can you provide me some guidance on how to to get started?\nHi, is this issue still valid to work on?\nyes, this is still valid. I recommend starting with the and reading from there.\nare you still working on this issue or should I work on it.\nI would like to work on this issue if you haven't started already.\nwould it be ok if I took a look at this?\n/assign\nHi Can you help me in why its not assigning the values to createNodes and createPods directly and using the opcode and countParam in performance-\nWe use a field to differentiate between different operations. The value of the field (e.g. \"createNodes\") determines the operation. The field defines the number of pods/nodes to create. What do you mean by \"assigning the values to createNodes and createPods directly\"?\nThanks for the information. By assigning, I just meant that whether we can assign createNodes directly like ( createNodes: $initNodes ).\nI don't think that's possible since there can potentially be other parameters besides the countParam. For example: Different operations could potentially have different parameters.\ncreateNodes and createPods aren't the only operations. Other operations (e.g. churn and barrier), including future ones, may not fit that format. It's also easier to parse and more explicit this way.\nThanks , Having a doubt more, in performance- under the name:SchedulingPodAntiAffinity, ! why are we giving the same values in 5000Nodes as given in 500Nodes, or this is an error.\nthat sounds like a typo indeed\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nHello Are you still going to work on this issue?\nHi I have worked on the issue but not working for a while as was unsure about the exact problem.\n, no problem if you are willing to work on this issue, shall unassign myself\n/unassign\nThanks :)\n/assign\n/remove-lifecycle stale\nhey! I am beginner and I interested in scheduling and I know basics of scheduling , so how can I start to contribute on this issue.\nSorry, PR for this issue has already created.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-662c7c7e26cbd2736249d648219fc2b6afe0748e94a842d9422847dadecf59b2", "text": "func (cmo createNamespacesOp) patchParams(w *workload) (realOp, error) { if cmo.CountParam != \"\" { <del> var ok bool if cmo.Count, ok = w.Params[cmo.CountParam[1:]]; !ok { return nil, fmt.Errorf(\"parameter %s is undefined\", cmo.CountParam) </del> <ins> var err error cmo.Count, err = w.Params.get(cmo.CountParam[1:]) if err != nil { return nil, err </ins> } } return &cmo, (&cmo).isValid(false)", "commid": "kubernetes_pr_104716"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b6c9f2814c257fcf076aee6432b3853318e13bb6778498e0a239839fa2da32e9", "query": "Note: this issue should be viewed in the context of . If this happens, this is very likely a typo where someone used a parameter in a way they didn't mean to (for example, ). /sig scheduling /assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/good-first-issue\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHi this is my first time contributing to kubernetes. can you provide me some guidance on how to to get started?\nHi, is this issue still valid to work on?\nyes, this is still valid. I recommend starting with the and reading from there.\nare you still working on this issue or should I work on it.\nI would like to work on this issue if you haven't started already.\nwould it be ok if I took a look at this?\n/assign\nHi Can you help me in why its not assigning the values to createNodes and createPods directly and using the opcode and countParam in performance-\nWe use a field to differentiate between different operations. The value of the field (e.g. \"createNodes\") determines the operation. The field defines the number of pods/nodes to create. What do you mean by \"assigning the values to createNodes and createPods directly\"?\nThanks for the information. By assigning, I just meant that whether we can assign createNodes directly like ( createNodes: $initNodes ).\nI don't think that's possible since there can potentially be other parameters besides the countParam. For example: Different operations could potentially have different parameters.\ncreateNodes and createPods aren't the only operations. Other operations (e.g. churn and barrier), including future ones, may not fit that format. It's also easier to parse and more explicit this way.\nThanks , Having a doubt more, in performance- under the name:SchedulingPodAntiAffinity, ! why are we giving the same values in 5000Nodes as given in 500Nodes, or this is an error.\nthat sounds like a typo indeed\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nHello Are you still going to work on this issue?\nHi I have worked on the issue but not working for a while as was unsure about the exact problem.\n, no problem if you are willing to work on this issue, shall unassign myself\n/unassign\nThanks :)\n/assign\n/remove-lifecycle stale\nhey! I am beginner and I interested in scheduling and I know basics of scheduling , so how can I start to contribute on this issue.\nSorry, PR for this issue has already created.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-9788a4a4bdfdb59cbc13733ab10c5527d68ec96963e67e9c4435b8e9523ae385", "text": "func (cpo createPodsOp) patchParams(w *workload) (realOp, error) { if cpo.CountParam != \"\" { <del> var ok bool if cpo.Count, ok = w.Params[cpo.CountParam[1:]]; !ok { return nil, fmt.Errorf(\"parameter %s is undefined\", cpo.CountParam) </del> <ins> var err error cpo.Count, err = w.Params.get(cpo.CountParam[1:]) if err != nil { return nil, err </ins> } } return &cpo, (&cpo).isValid(false)", "commid": "kubernetes_pr_104716"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b6c9f2814c257fcf076aee6432b3853318e13bb6778498e0a239839fa2da32e9", "query": "Note: this issue should be viewed in the context of . If this happens, this is very likely a typo where someone used a parameter in a way they didn't mean to (for example, ). /sig scheduling /assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/good-first-issue\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHi this is my first time contributing to kubernetes. can you provide me some guidance on how to to get started?\nHi, is this issue still valid to work on?\nyes, this is still valid. I recommend starting with the and reading from there.\nare you still working on this issue or should I work on it.\nI would like to work on this issue if you haven't started already.\nwould it be ok if I took a look at this?\n/assign\nHi Can you help me in why its not assigning the values to createNodes and createPods directly and using the opcode and countParam in performance-\nWe use a field to differentiate between different operations. The value of the field (e.g. \"createNodes\") determines the operation. The field defines the number of pods/nodes to create. What do you mean by \"assigning the values to createNodes and createPods directly\"?\nThanks for the information. By assigning, I just meant that whether we can assign createNodes directly like ( createNodes: $initNodes ).\nI don't think that's possible since there can potentially be other parameters besides the countParam. For example: Different operations could potentially have different parameters.\ncreateNodes and createPods aren't the only operations. Other operations (e.g. churn and barrier), including future ones, may not fit that format. It's also easier to parse and more explicit this way.\nThanks , Having a doubt more, in performance- under the name:SchedulingPodAntiAffinity, ! why are we giving the same values in 5000Nodes as given in 500Nodes, or this is an error.\nthat sounds like a typo indeed\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nHello Are you still going to work on this issue?\nHi I have worked on the issue but not working for a while as was unsure about the exact problem.\n, no problem if you are willing to work on this issue, shall unassign myself\n/unassign\nThanks :)\n/assign\n/remove-lifecycle stale\nhey! I am beginner and I interested in scheduling and I know basics of scheduling , so how can I start to contribute on this issue.\nSorry, PR for this issue has already created.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-c9cfb12696929fa8868fad4347314134fca80526aca62114bc3ce500a4086a56", "text": "func (cpso createPodSetsOp) patchParams(w *workload) (realOp, error) { if cpso.CountParam != \"\" { <del> var ok bool if cpso.Count, ok = w.Params[cpso.CountParam[1:]]; !ok { return nil, fmt.Errorf(\"parameter %s is undefined\", cpso.CountParam) </del> <ins> var err error cpso.Count, err = w.Params.get(cpso.CountParam[1:]) if err != nil { return nil, err </ins> } } return &cpso, (&cpso).isValid(true)", "commid": "kubernetes_pr_104716"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b6c9f2814c257fcf076aee6432b3853318e13bb6778498e0a239839fa2da32e9", "query": "Note: this issue should be viewed in the context of . If this happens, this is very likely a typo where someone used a parameter in a way they didn't mean to (for example, ). /sig scheduling /assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale\n/remove-lifecycle stale\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\n/good-first-issue\nThis request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nHi this is my first time contributing to kubernetes. can you provide me some guidance on how to to get started?\nHi, is this issue still valid to work on?\nyes, this is still valid. I recommend starting with the and reading from there.\nare you still working on this issue or should I work on it.\nI would like to work on this issue if you haven't started already.\nwould it be ok if I took a look at this?\n/assign\nHi Can you help me in why its not assigning the values to createNodes and createPods directly and using the opcode and countParam in performance-\nWe use a field to differentiate between different operations. The value of the field (e.g. \"createNodes\") determines the operation. The field defines the number of pods/nodes to create. What do you mean by \"assigning the values to createNodes and createPods directly\"?\nThanks for the information. By assigning, I just meant that whether we can assign createNodes directly like ( createNodes: $initNodes ).\nI don't think that's possible since there can potentially be other parameters besides the countParam. For example: Different operations could potentially have different parameters.\ncreateNodes and createPods aren't the only operations. Other operations (e.g. churn and barrier), including future ones, may not fit that format. It's also easier to parse and more explicit this way.\nThanks , Having a doubt more, in performance- under the name:SchedulingPodAntiAffinity, ! why are we giving the same values in 5000Nodes as given in 500Nodes, or this is an error.\nthat sounds like a typo indeed\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nHello Are you still going to work on this issue?\nHi I have worked on the issue but not working for a while as was unsure about the exact problem.\n, no problem if you are willing to work on this issue, shall unassign myself\n/unassign\nThanks :)\n/assign\n/remove-lifecycle stale\nhey! I am beginner and I interested in scheduling and I know basics of scheduling , so how can I start to contribute on this issue.\nSorry, PR for this issue has already created.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-4098952c908d30cd004be3980784915e2d73f5b3e3b484a709a5b3afbe43b9a9", "text": "b.Fatalf(\"op %d: invalid op %v\", opIndex, concreteOp) } } <ins> // check unused params and inform users unusedParams := w.unusedParams() if len(unusedParams) != 0 { b.Fatalf(\"the parameters %v are defined on workload %s, but unused.nPlease make sure there are no typos.\", unusedParams, w.Name) } </ins> // Some tests have unschedulable pods. Do not add an implicit barrier at the // end as we do not want to wait for them. return dataItems", "commid": "kubernetes_pr_104716"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4700b6431d53fed3ac6cc4bc51c5b0e7fdf43657f232453edec23d6ad11df27a", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: /test pull-kubernetes-node-crio1-18-e2e Which test(s) are failing: pull-kubernetes-node-crio1-18-e2e Reason for failure: Just before node e2e tests are started, we verify that the runtime (containerd or docker) is properly running or not on the target system. This check doesn't include crio, so the targeted node is not reported ready if it's using crio as the runtime.\n/sig testing\n/sig node /remove-sig testing This check is owned by SIG node\nThe code has also not allowed this sort of dependency (beyond some legacy dockershim specific bits), but I guess it's somewhat more understandable to check in .", "positive_passages": [{"docid": "doc-en-kubernetes-72b947ef23e13129ad71526f2b799c76c4bd87319f4f4c788eb465a506095a81", "text": "var output string output, err = remote.SSH(name, \"sh\", \"-c\", <del> \"'systemctl list-units  --type=service  --state=running | grep -e docker -e containerd'\") </del> <ins> \"'systemctl list-units  --type=service  --state=running | grep -e docker -e containerd -e crio'\") </ins> if err != nil { <del> err = fmt.Errorf(\"instance %s not running docker/containerd daemon - Command failed: %s\", name, output) </del> <ins> err = fmt.Errorf(\"instance %s not running docker/containerd/crio daemon - Command failed: %s\", name, output) </ins> continue } if !strings.Contains(output, \"docker.service\") && <del> !strings.Contains(output, \"containerd.service\") { err = fmt.Errorf(\"instance %s not running docker/containerd daemon: %s\", name, output) </del> <ins> !strings.Contains(output, \"containerd.service\") && !strings.Contains(output, \"crio.service\") { err = fmt.Errorf(\"instance %s not running docker/containerd/crio daemon: %s\", name, output) </ins> continue } instanceRunning = true", "commid": "kubernetes_pr_94760"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e392226d1eb576bb46e52e7a6bfd6dd4b8cfb2ebe6708d3d3dea7c04613110b", "query": "Warning: The v0.1 and v1beta1 metadata server endpoints are deprecated and scheduled for shutdown on September 30, 2020. This test (which runs in most e2e jobs that run on GCE): Schedules a container that runs this: Resulting in a number of legacy metadata endpoints getting hit. To see if this test is going to start failing across all release branches on Sep 30th, we could try disabling the endpoints ahead of time via: In fact and support for expecting different results based on whether is set. My concern is the test expects 200 for some root endpoints, and 403 for disabled endpoints. However the e-mail I received as a GCP customer tells me any legacy endpoints may return 404. I'm inclined to suggest we remove the legacy endpoints from the check, bump the image version, and cherry-pick use of the new image version back to all release-branches. WDYT since you were involved with the earlier PRs /sig auth /sig cloud-provider /provider gcp /sig testing /priority important-soon (I'm tempted to critical-urgent this but it's not drop-everything yet) /milestone v1.20\n/kind cleanup\nHeyho I wanted to check how it is going? The code freeze is starting 12.11.2020 (about 3-4 weeks from now) and while there is still plenty of time, we want to ensure that each relevant issue has a chance to be considered. As the issue is tagged for 1.20, is it still planned for this release?\nBug Triage here, we're pretty late into code freeze and it doesn't look like there has been much activity recently. I am going to clear the milestone on this issue. /milestone clear\nany update here?\nTry to cleanup the legacy endpoints in\n/milestone v1.21\n/reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: )\nReopened this issue. <detailsIn response to : /reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: ) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-e5fce742c53fb0f52364b5e3ecb3385fe9a68877d456362049d34946be5b13bc", "text": "<del> 1.5 </del> <ins> 1.6 </ins>", "commid": "kubernetes_pr_97789"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e392226d1eb576bb46e52e7a6bfd6dd4b8cfb2ebe6708d3d3dea7c04613110b", "query": "Warning: The v0.1 and v1beta1 metadata server endpoints are deprecated and scheduled for shutdown on September 30, 2020. This test (which runs in most e2e jobs that run on GCE): Schedules a container that runs this: Resulting in a number of legacy metadata endpoints getting hit. To see if this test is going to start failing across all release branches on Sep 30th, we could try disabling the endpoints ahead of time via: In fact and support for expecting different results based on whether is set. My concern is the test expects 200 for some root endpoints, and 403 for disabled endpoints. However the e-mail I received as a GCP customer tells me any legacy endpoints may return 404. I'm inclined to suggest we remove the legacy endpoints from the check, bump the image version, and cherry-pick use of the new image version back to all release-branches. WDYT since you were involved with the earlier PRs /sig auth /sig cloud-provider /provider gcp /sig testing /priority important-soon (I'm tempted to critical-urgent this but it's not drop-everything yet) /milestone v1.20\n/kind cleanup\nHeyho I wanted to check how it is going? The code freeze is starting 12.11.2020 (about 3-4 weeks from now) and while there is still plenty of time, we want to ensure that each relevant issue has a chance to be considered. As the issue is tagged for 1.20, is it still planned for this release?\nBug Triage here, we're pretty late into code freeze and it doesn't look like there has been much activity recently. I am going to clear the milestone on this issue. /milestone clear\nany update here?\nTry to cleanup the legacy endpoints in\n/milestone v1.21\n/reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: )\nReopened this issue. <detailsIn response to : /reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: ) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-4945be8bae2a3392af66a5318b0034a8df8168ba3b23a48b365b75a5dfef08e4", "text": "\"http://metadata.google.internal\", \"http://169.254.169.254/\", \"http://metadata.google.internal/\", <del> \"http://metadata.google.internal/0.1\", \"http://metadata.google.internal/0.1/\", </del> \"http://metadata.google.internal/computeMetadata\", \"http://metadata.google.internal/computeMetadata/v1\", // Allowed API versions.", "commid": "kubernetes_pr_97789"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e392226d1eb576bb46e52e7a6bfd6dd4b8cfb2ebe6708d3d3dea7c04613110b", "query": "Warning: The v0.1 and v1beta1 metadata server endpoints are deprecated and scheduled for shutdown on September 30, 2020. This test (which runs in most e2e jobs that run on GCE): Schedules a container that runs this: Resulting in a number of legacy metadata endpoints getting hit. To see if this test is going to start failing across all release branches on Sep 30th, we could try disabling the endpoints ahead of time via: In fact and support for expecting different results based on whether is set. My concern is the test expects 200 for some root endpoints, and 403 for disabled endpoints. However the e-mail I received as a GCP customer tells me any legacy endpoints may return 404. I'm inclined to suggest we remove the legacy endpoints from the check, bump the image version, and cherry-pick use of the new image version back to all release-branches. WDYT since you were involved with the earlier PRs /sig auth /sig cloud-provider /provider gcp /sig testing /priority important-soon (I'm tempted to critical-urgent this but it's not drop-everything yet) /milestone v1.20\n/kind cleanup\nHeyho I wanted to check how it is going? The code freeze is starting 12.11.2020 (about 3-4 weeks from now) and while there is still plenty of time, we want to ensure that each relevant issue has a chance to be considered. As the issue is tagged for 1.20, is it still planned for this release?\nBug Triage here, we're pretty late into code freeze and it doesn't look like there has been much activity recently. I am going to clear the milestone on this issue. /milestone clear\nany update here?\nTry to cleanup the legacy endpoints in\n/milestone v1.21\n/reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: )\nReopened this issue. <detailsIn response to : /reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: ) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-162678183284232606abe99dd606022465cb369e3e637372a1c15b2b619ab0c5", "text": "\"http://metadata.google.internal/computeMetadata/v1/instance/tags?wait_for_change=true&timeout_sec=0\", \"http://metadata.google.internal/computeMetadata/v1/instance/tags?wait_for_change=true&last_etag=d34db33f\", } <del> legacySuccessEndpoints = []string{ // Discovery \"http://metadata.google.internal/0.1/meta-data\", \"http://metadata.google.internal/computeMetadata/v1beta1\", // Allowed API versions. \"http://metadata.google.internal/0.1/meta-data/\", \"http://metadata.google.internal/computeMetadata/v1beta1/\", // Service account token endpoints. \"http://metadata.google.internal/0.1/meta-data/service-accounts/default/acquire\", \"http://metadata.google.internal/computeMetadata/v1beta1/instance/service-accounts/default/token\", // Known query params. \"http://metadata.google.internal/0.1/meta-data/service-accounts/default/acquire?scopes\", } </del> noKubeEnvEndpoints = []string{ // Check that these don't get a recursive result. \"http://metadata.google.internal/computeMetadata/v1/instance/?recursive%3Dtrue\",   // urlencoded", "commid": "kubernetes_pr_97789"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e392226d1eb576bb46e52e7a6bfd6dd4b8cfb2ebe6708d3d3dea7c04613110b", "query": "Warning: The v0.1 and v1beta1 metadata server endpoints are deprecated and scheduled for shutdown on September 30, 2020. This test (which runs in most e2e jobs that run on GCE): Schedules a container that runs this: Resulting in a number of legacy metadata endpoints getting hit. To see if this test is going to start failing across all release branches on Sep 30th, we could try disabling the endpoints ahead of time via: In fact and support for expecting different results based on whether is set. My concern is the test expects 200 for some root endpoints, and 403 for disabled endpoints. However the e-mail I received as a GCP customer tells me any legacy endpoints may return 404. I'm inclined to suggest we remove the legacy endpoints from the check, bump the image version, and cherry-pick use of the new image version back to all release-branches. WDYT since you were involved with the earlier PRs /sig auth /sig cloud-provider /provider gcp /sig testing /priority important-soon (I'm tempted to critical-urgent this but it's not drop-everything yet) /milestone v1.20\n/kind cleanup\nHeyho I wanted to check how it is going? The code freeze is starting 12.11.2020 (about 3-4 weeks from now) and while there is still plenty of time, we want to ensure that each relevant issue has a chance to be considered. As the issue is tagged for 1.20, is it still planned for this release?\nBug Triage here, we're pretty late into code freeze and it doesn't look like there has been much activity recently. I am going to clear the milestone on this issue. /milestone clear\nany update here?\nTry to cleanup the legacy endpoints in\n/milestone v1.21\n/reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: )\nReopened this issue. <detailsIn response to : /reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: ) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-37ceb11673d55a75f460911c28548238ae26894e63e73aa67534ff352a64adf0", "text": "\"http://metadata.google.internal/0.2/\", \"http://metadata.google.internal/computeMetadata/v2/\", // kube-env. <del> \"http://metadata.google.internal/0.1/meta-data/attributes/kube-env\", \"http://metadata.google.internal/computeMetadata/v1beta1/instance/attributes/kube-env\", </del> \"http://metadata.google.internal/computeMetadata/v1/instance/attributes/kube-env\", // VM identity. <del> \"http://metadata.google.internal/0.1/meta-data/service-accounts/default/identity\", \"http://metadata.google.internal/computeMetadata/v1beta1/instance/service-accounts/default/identity\", </del> \"http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/identity\", // Forbidden recursive queries. \"http://metadata.google.internal/computeMetadata/v1/instance/?recursive=true\",", "commid": "kubernetes_pr_97789"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e392226d1eb576bb46e52e7a6bfd6dd4b8cfb2ebe6708d3d3dea7c04613110b", "query": "Warning: The v0.1 and v1beta1 metadata server endpoints are deprecated and scheduled for shutdown on September 30, 2020. This test (which runs in most e2e jobs that run on GCE): Schedules a container that runs this: Resulting in a number of legacy metadata endpoints getting hit. To see if this test is going to start failing across all release branches on Sep 30th, we could try disabling the endpoints ahead of time via: In fact and support for expecting different results based on whether is set. My concern is the test expects 200 for some root endpoints, and 403 for disabled endpoints. However the e-mail I received as a GCP customer tells me any legacy endpoints may return 404. I'm inclined to suggest we remove the legacy endpoints from the check, bump the image version, and cherry-pick use of the new image version back to all release-branches. WDYT since you were involved with the earlier PRs /sig auth /sig cloud-provider /provider gcp /sig testing /priority important-soon (I'm tempted to critical-urgent this but it's not drop-everything yet) /milestone v1.20\n/kind cleanup\nHeyho I wanted to check how it is going? The code freeze is starting 12.11.2020 (about 3-4 weeks from now) and while there is still plenty of time, we want to ensure that each relevant issue has a chance to be considered. As the issue is tagged for 1.20, is it still planned for this release?\nBug Triage here, we're pretty late into code freeze and it doesn't look like there has been much activity recently. I am going to clear the milestone on this issue. /milestone clear\nany update here?\nTry to cleanup the legacy endpoints in\n/milestone v1.21\n/reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: )\nReopened this issue. <detailsIn response to : /reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: ) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-6e15a6ae5921d117408957eb119df714f44162ed4bceeb3a2b43e0c3f228b230", "text": "} } <del> legacyEndpointExpectedStatus := 200 if err := checkURL(\"http://metadata.google.internal/computeMetadata/v1/instance/attributes/disable-legacy-endpoints\", h, 200, \"true\", \"\"); err == nil { // If `disable-legacy-endpoints` is set to true, queries to unconcealed legacy endpoints will return a 403. legacyEndpointExpectedStatus = 403 } for _, e := range legacySuccessEndpoints { if err := checkURL(e, h, legacyEndpointExpectedStatus, \"\", \"\"); err != nil { log.Printf(\"Wrong response for %v: %v\", e, err) success = 1 } } </del> xForwardedForHeader := map[string][]string{ \"X-Forwarded-For\": {\"Somebody-somewhere\"}, }", "commid": "kubernetes_pr_97789"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e392226d1eb576bb46e52e7a6bfd6dd4b8cfb2ebe6708d3d3dea7c04613110b", "query": "Warning: The v0.1 and v1beta1 metadata server endpoints are deprecated and scheduled for shutdown on September 30, 2020. This test (which runs in most e2e jobs that run on GCE): Schedules a container that runs this: Resulting in a number of legacy metadata endpoints getting hit. To see if this test is going to start failing across all release branches on Sep 30th, we could try disabling the endpoints ahead of time via: In fact and support for expecting different results based on whether is set. My concern is the test expects 200 for some root endpoints, and 403 for disabled endpoints. However the e-mail I received as a GCP customer tells me any legacy endpoints may return 404. I'm inclined to suggest we remove the legacy endpoints from the check, bump the image version, and cherry-pick use of the new image version back to all release-branches. WDYT since you were involved with the earlier PRs /sig auth /sig cloud-provider /provider gcp /sig testing /priority important-soon (I'm tempted to critical-urgent this but it's not drop-everything yet) /milestone v1.20\n/kind cleanup\nHeyho I wanted to check how it is going? The code freeze is starting 12.11.2020 (about 3-4 weeks from now) and while there is still plenty of time, we want to ensure that each relevant issue has a chance to be considered. As the issue is tagged for 1.20, is it still planned for this release?\nBug Triage here, we're pretty late into code freeze and it doesn't look like there has been much activity recently. I am going to clear the milestone on this issue. /milestone clear\nany update here?\nTry to cleanup the legacy endpoints in\n/milestone v1.21\n/reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: )\nReopened this issue. <detailsIn response to : /reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: ) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-9f2b52bbddfe25f85dcb208fb6acc0b55837e9c0f9a19813f7f629067c69b82f", "text": "match: k8s.gcr.io/pause:d+.d+ - path: test/utils/image/manifest.go match: configs[Pause] = Config{gcRegistry, \"pause\", \"d+.d+\"} <ins> # metadata-concealment: bump this one first - name: \"metadata-concealment\" version: \"1.6\" refPaths: - path: test/images/metadata-concealment/VERSION match: d.d # then after merge and successful postsubmit image push / promotion, bump this - name: \"metadata-concealment: dependents\" version: \"1.6\" refPaths: - path: test/utils/image/manifest.go match: configs[CheckMetadataConcealment] = Config{promoterE2eRegistry, \"metadata-concealment\", \"d+.d+\"} </ins>", "commid": "kubernetes_pr_98336"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e392226d1eb576bb46e52e7a6bfd6dd4b8cfb2ebe6708d3d3dea7c04613110b", "query": "Warning: The v0.1 and v1beta1 metadata server endpoints are deprecated and scheduled for shutdown on September 30, 2020. This test (which runs in most e2e jobs that run on GCE): Schedules a container that runs this: Resulting in a number of legacy metadata endpoints getting hit. To see if this test is going to start failing across all release branches on Sep 30th, we could try disabling the endpoints ahead of time via: In fact and support for expecting different results based on whether is set. My concern is the test expects 200 for some root endpoints, and 403 for disabled endpoints. However the e-mail I received as a GCP customer tells me any legacy endpoints may return 404. I'm inclined to suggest we remove the legacy endpoints from the check, bump the image version, and cherry-pick use of the new image version back to all release-branches. WDYT since you were involved with the earlier PRs /sig auth /sig cloud-provider /provider gcp /sig testing /priority important-soon (I'm tempted to critical-urgent this but it's not drop-everything yet) /milestone v1.20\n/kind cleanup\nHeyho I wanted to check how it is going? The code freeze is starting 12.11.2020 (about 3-4 weeks from now) and while there is still plenty of time, we want to ensure that each relevant issue has a chance to be considered. As the issue is tagged for 1.20, is it still planned for this release?\nBug Triage here, we're pretty late into code freeze and it doesn't look like there has been much activity recently. I am going to clear the milestone on this issue. /milestone clear\nany update here?\nTry to cleanup the legacy endpoints in\n/milestone v1.21\n/reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: )\nReopened this issue. <detailsIn response to : /reopen This needs to stay open until the new image has been verified to work and has been promoted (ref: ) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-2af6f584df20a174859d5c1c27a1795381d76e85e59a083ef3bbb87dc3b875c1", "text": "configs[APIServer] = Config{e2eRegistry, \"sample-apiserver\", \"1.17\"} configs[AppArmorLoader] = Config{e2eRegistry, \"apparmor-loader\", \"1.0\"} configs[BusyBox] = Config{dockerLibraryRegistry, \"busybox\", \"1.29\"} <del> configs[CheckMetadataConcealment] = Config{e2eRegistry, \"metadata-concealment\", \"1.2\"} </del> <ins> configs[CheckMetadataConcealment] = Config{promoterE2eRegistry, \"metadata-concealment\", \"1.6\"} </ins> configs[CudaVectorAdd] = Config{e2eRegistry, \"cuda-vector-add\", \"1.0\"} configs[CudaVectorAdd2] = Config{e2eRegistry, \"cuda-vector-add\", \"2.0\"} configs[DebianIptables] = Config{buildImageRegistry, \"debian-iptables\", \"buster-v1.3.0\"}", "commid": "kubernetes_pr_98336"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-adc864120b4bf3f0c4719014a19f7db55b0b10439d7006f29b684827d46fc0cb", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: ci-kubernetes-node-kubelet-serial node-kubelet-serial job Which test(s) are failing: Hard to tell, but everything at one point or another. Since when has it been failing: A month or two, by recollection. would indicate several years... ci-kubernetes-node-kubelet-serial | failing_days | 992 Testgrid link: Reason for failure: Hard to tell, some is timeout, but I think timeouts due to test failures. Anything else we need to know: Nothing consistent about the failures that I can tell besides timeouts. This is the only place these serial tests are running.\n/sig node\n/cc\nI will take a look at what happens with the serial lane.\nSo the kubelet failed to restart because of I think it can be related to the topology manager scope PR, I will dig into the code tomorrow. FYI\nIt actually looks like it was introduced by: With the same issue reported here: And Alexey has a fix for it here (I haven't reviewed it):\nThanks for the update.\nSome of these failures are definitely due to , which is causing tests to fail since pods aren't terminating in time. See e.g.\n/assign\nUnder the latest run, I saw that the kubelet failed to restart because of The problem that one of the topology manager tests failed in the middle and did not remove the state file, I can not guarantee that it a single problem, but let's start from it.", "positive_passages": [{"docid": "doc-en-kubernetes-abc60e2427ecbd2618aeac36bfaeab76d1c1e74ce1382a18e4a46799b6bc0515", "text": "ginkgo.By(\"wait for the deleted pod to be cleaned up from the state file\") waitForStateFileCleanedUp() ginkgo.By(\"the deleted pod has already been deleted from the state file\") <ins> }) ginkgo.AfterEach(func() { </ins> setOldKubeletConfig(f, oldCfg) }) }", "commid": "kubernetes_pr_98342"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-adc864120b4bf3f0c4719014a19f7db55b0b10439d7006f29b684827d46fc0cb", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: ci-kubernetes-node-kubelet-serial node-kubelet-serial job Which test(s) are failing: Hard to tell, but everything at one point or another. Since when has it been failing: A month or two, by recollection. would indicate several years... ci-kubernetes-node-kubelet-serial | failing_days | 992 Testgrid link: Reason for failure: Hard to tell, some is timeout, but I think timeouts due to test failures. Anything else we need to know: Nothing consistent about the failures that I can tell besides timeouts. This is the only place these serial tests are running.\n/sig node\n/cc\nI will take a look at what happens with the serial lane.\nSo the kubelet failed to restart because of I think it can be related to the topology manager scope PR, I will dig into the code tomorrow. FYI\nIt actually looks like it was introduced by: With the same issue reported here: And Alexey has a fix for it here (I haven't reviewed it):\nThanks for the update.\nSome of these failures are definitely due to , which is causing tests to fail since pods aren't terminating in time. See e.g.\n/assign\nUnder the latest run, I saw that the kubelet failed to restart because of The problem that one of the topology manager tests failed in the middle and did not remove the state file, I can not guarantee that it a single problem, but let's start from it.", "positive_passages": [{"docid": "doc-en-kubernetes-94d2369f15199129458f92f6e51d07ee84bd685fd74193014eed1d26a387c725", "text": "// Run the tests runTopologyManagerPolicySuiteTests(f) } <del> // restore kubelet config setOldKubeletConfig(f, oldCfg) // Delete state file to allow repeated runs deleteStateFile() </del> }) ginkgo.It(\"run Topology Manager node alignment test suite\", func() {", "commid": "kubernetes_pr_98342"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-adc864120b4bf3f0c4719014a19f7db55b0b10439d7006f29b684827d46fc0cb", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: ci-kubernetes-node-kubelet-serial node-kubelet-serial job Which test(s) are failing: Hard to tell, but everything at one point or another. Since when has it been failing: A month or two, by recollection. would indicate several years... ci-kubernetes-node-kubelet-serial | failing_days | 992 Testgrid link: Reason for failure: Hard to tell, some is timeout, but I think timeouts due to test failures. Anything else we need to know: Nothing consistent about the failures that I can tell besides timeouts. This is the only place these serial tests are running.\n/sig node\n/cc\nI will take a look at what happens with the serial lane.\nSo the kubelet failed to restart because of I think it can be related to the topology manager scope PR, I will dig into the code tomorrow. FYI\nIt actually looks like it was introduced by: With the same issue reported here: And Alexey has a fix for it here (I haven't reviewed it):\nThanks for the update.\nSome of these failures are definitely due to , which is causing tests to fail since pods aren't terminating in time. See e.g.\n/assign\nUnder the latest run, I saw that the kubelet failed to restart because of The problem that one of the topology manager tests failed in the middle and did not remove the state file, I can not guarantee that it a single problem, but let's start from it.", "positive_passages": [{"docid": "doc-en-kubernetes-2674c5354346531e3647bfe6aab575877f482bce036a8ea025bfc50a26c03ac3", "text": "runTopologyManagerNodeAlignmentSuiteTests(f, sd, reservedSystemCPUs, policy, numaNodes, coreCount) } <del> // restore kubelet config setOldKubeletConfig(f, oldCfg) // Delete state file to allow repeated runs deleteStateFile() </del> }) ginkgo.It(\"run the Topology Manager pod scope alignment test suite\", func() {", "commid": "kubernetes_pr_98342"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-adc864120b4bf3f0c4719014a19f7db55b0b10439d7006f29b684827d46fc0cb", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: ci-kubernetes-node-kubelet-serial node-kubelet-serial job Which test(s) are failing: Hard to tell, but everything at one point or another. Since when has it been failing: A month or two, by recollection. would indicate several years... ci-kubernetes-node-kubelet-serial | failing_days | 992 Testgrid link: Reason for failure: Hard to tell, some is timeout, but I think timeouts due to test failures. Anything else we need to know: Nothing consistent about the failures that I can tell besides timeouts. This is the only place these serial tests are running.\n/sig node\n/cc\nI will take a look at what happens with the serial lane.\nSo the kubelet failed to restart because of I think it can be related to the topology manager scope PR, I will dig into the code tomorrow. FYI\nIt actually looks like it was introduced by: With the same issue reported here: And Alexey has a fix for it here (I haven't reviewed it):\nThanks for the update.\nSome of these failures are definitely due to , which is causing tests to fail since pods aren't terminating in time. See e.g.\n/assign\nUnder the latest run, I saw that the kubelet failed to restart because of The problem that one of the topology manager tests failed in the middle and did not remove the state file, I can not guarantee that it a single problem, but let's start from it.", "positive_passages": [{"docid": "doc-en-kubernetes-5efe5c18c4d38d7266c5309de2421216a1405c5d4ff8d8f403d33033d480b3e9", "text": "reservedSystemCPUs := configureTopologyManagerInKubelet(f, oldCfg, policy, scope, configMap, numaNodes) runTMScopeResourceAlignmentTestSuite(f, configMap, reservedSystemCPUs, policy, numaNodes, coreCount) <ins> }) ginkgo.AfterEach(func() { // restore kubelet config </ins> setOldKubeletConfig(f, oldCfg) <del> deleteStateFile() </del> }) }", "commid": "kubernetes_pr_98342"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-adc864120b4bf3f0c4719014a19f7db55b0b10439d7006f29b684827d46fc0cb", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: ci-kubernetes-node-kubelet-serial node-kubelet-serial job Which test(s) are failing: Hard to tell, but everything at one point or another. Since when has it been failing: A month or two, by recollection. would indicate several years... ci-kubernetes-node-kubelet-serial | failing_days | 992 Testgrid link: Reason for failure: Hard to tell, some is timeout, but I think timeouts due to test failures. Anything else we need to know: Nothing consistent about the failures that I can tell besides timeouts. This is the only place these serial tests are running.\n/sig node\n/cc\nI will take a look at what happens with the serial lane.\nSo the kubelet failed to restart because of I think it can be related to the topology manager scope PR, I will dig into the code tomorrow. FYI\nIt actually looks like it was introduced by: With the same issue reported here: And Alexey has a fix for it here (I haven't reviewed it):\nThanks for the update.\nSome of these failures are definitely due to , which is causing tests to fail since pods aren't terminating in time. See e.g.\n/assign\nUnder the latest run, I saw that the kubelet failed to restart because of The problem that one of the topology manager tests failed in the middle and did not remove the state file, I can not guarantee that it a single problem, but let's start from it.", "positive_passages": [{"docid": "doc-en-kubernetes-a859a8cf2dfd815b3ed383566b6f71f674ba137e40902c19efb1459249aeac4f", "text": "ginkgo.Context(\"With kubeconfig updated to static CPU Manager policy run the Topology Manager tests\", func() { runTopologyManagerTests(f) }) })", "commid": "kubernetes_pr_98342"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-74931a9f052513bf144ba059c4e4fc0b79a9524532a0c3ceb7b1249903c7dd42", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: Which test(s) are flaking: Testgrid link: Reason for failure: Timeout while - trying to gave a 404 or 502 Anything else we need to know: 4 flakes in the past week: Triage: /sig network <!-- Please see the deflaking doc () for more guidance! --\n/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. \u200d\n/assign\nHi and any update on this ?\n/assign\nMinhan -- can you take a look?\n/triage accepted\nLooks like the LB did not stabilize before timeout. Still looking. We are considering disabling some of the tests here\nThis test is still flaking a bit -- recent failures from the past 2 days:\nIt looks like this test is still flaking quite frequently: Any ideas on how to move forward?\nI will start disabling the tests.", "positive_passages": [{"docid": "doc-en-kubernetes-28d7ddeea80c30f9af1a2a7eac351608b036154842fe1cc23eee3ab06523f068", "text": "// zone based on pod labels. }) <del> ginkgo.Describe(\"GCE [Slow] [Feature:NEG]\", func() { </del> <ins> ginkgo.Describe(\"GCE [Slow] [Feature:NEG] [Flaky]\", func() { </ins> var gceController *gce.IngressController // Platform specific setup", "commid": "kubernetes_pr_99798"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-162d21370c7ec4f102f2431400d4199b14f98f0bc1d8c77b086f1c16b68f0424", "text": "// Defines a time budget that can be spend on waiting for not-ready watchers // while dispatching event before shutting them down. <del> dispatchTimeoutBudget *timeBudget </del> <ins> dispatchTimeoutBudget timeBudget </ins> // Handling graceful termination. stopLock sync.RWMutex", "commid": "kubernetes_pr_95869"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-4d4f0aac6f4a37ba02e1f8ebffc14cb3e9dd4e2b9c9e5c025a7b66a6776072ea", "text": "wg.Wait() } <ins> type fakeTimeBudget struct{} func (f *fakeTimeBudget) takeAvailable() time.Duration { return 2 * time.Second } func (f *fakeTimeBudget) returnUnused(_ time.Duration) {} </ins> func TestDispatchEventWillNotBeBlockedByTimedOutWatcher(t *testing.T) { backingStorage := &dummyStorage{} cacher, _, err := newTestCacher(backingStorage)", "commid": "kubernetes_pr_95869"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-21b4783472b08ad3a00a2feff617f4605830080373b61c438d6c91dea9c6f9a3", "text": "cacher.ready.wait() // Ensure there is some budget for slowing down processing. <del> cacher.dispatchTimeoutBudget.returnUnused(50 * time.Millisecond) </del> <ins> // When using the official `timeBudgetImpl` we were observing flakiness // due under the following conditions: // 1) the watch w1 is blocked, so we were consuming the whole budget once //    its buffer was filled in (10 items) // 2) the budget is refreshed once per second, so it basically wasn't //    happening in the test at all // 3) if the test was cpu-starved and we weren't able to consume events //    from w2 ResultCh it could have happened that its buffer was also //    filling in and given we no longer had timeBudget (consumed in (1)) //    trying to put next item was simply breaking the watch // Using fakeTimeBudget gives us always a budget to wait and have a test // pick up something from ResultCh in the meantime. cacher.dispatchTimeoutBudget = &fakeTimeBudget{} </ins> makePod := func(i int) *examplev1.Pod { return &examplev1.Pod{", "commid": "kubernetes_pr_95869"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-b51a191c9e1fdc4b358eb239d446e9ceefe4354bcf7b3169b8e50f7f422f37a0", "text": "shouldContinue = false break } <del> // Ensure there is some budget for fast watcher after slower one is blocked. cacher.dispatchTimeoutBudget.returnUnused(50 * time.Millisecond) </del> if event.Type == watch.Added { eventsCount++ if eventsCount == totalPods {", "commid": "kubernetes_pr_95869"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-8ca5641233e503805e9ea599915314d81879ffcb5738caed6eb85b841d0d3cbf", "text": "// NOTE: It's not recommended to be used concurrently from multiple threads - // if first user takes the whole timeout, the second one will get 0 timeout // even though the first one may return something later. <del> type timeBudget struct { </del> <ins> type timeBudget interface { takeAvailable() time.Duration returnUnused(unused time.Duration) } type timeBudgetImpl struct { </ins> sync.Mutex budget time.Duration", "commid": "kubernetes_pr_95869"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-695216a7754772536fb004371a4f10a72d9a5397a4c440da043d80655c9def4e", "text": "maxBudget time.Duration } <del> func newTimeBudget(stopCh <-chan struct{}) *timeBudget { result := &timeBudget{ </del> <ins> func newTimeBudget(stopCh <-chan struct{}) timeBudget { result := &timeBudgetImpl{ </ins> budget:    time.Duration(0), refresh:   refreshPerSecond, maxBudget: maxBudget,", "commid": "kubernetes_pr_95869"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-90e098cf8c873f7ca88ec3a21f2216252f7eb3faabb733d0a01bf844c94573c6", "text": "return result } <del> func (t *timeBudget) periodicallyRefresh(stopCh <-chan struct{}) { </del> <ins> func (t *timeBudgetImpl) periodicallyRefresh(stopCh <-chan struct{}) { </ins> ticker := time.NewTicker(time.Second) defer ticker.Stop() for {", "commid": "kubernetes_pr_95869"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-539582514ab4719fb943613bcf043849bd24a1c0f981db44bfb5006c0fa59541", "text": "} } <del> func (t *timeBudget) takeAvailable() time.Duration { </del> <ins> func (t *timeBudgetImpl) takeAvailable() time.Duration { </ins> t.Lock() defer t.Unlock() result := t.budget", "commid": "kubernetes_pr_95869"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-2b51c17b396d7ca9cb0541a9ab21e2a4d69ea8d621bf5543778e95a5b44d5292", "text": "return result } <del> func (t *timeBudget) returnUnused(unused time.Duration) { </del> <ins> func (t *timeBudgetImpl) returnUnused(unused time.Duration) { </ins> t.Lock() defer t.Unlock() if unused < 0 {", "commid": "kubernetes_pr_95869"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-3a533d75e0c39c10c04b1c8d3a6262b78c04ae47e5aff94584096b507a5efe0d", "text": ") func TestTimeBudget(t *testing.T) { <del> budget := &timeBudget{ </del> <ins> budget := &timeBudgetImpl{ </ins> budget:    time.Duration(0), maxBudget: time.Duration(200), }", "commid": "kubernetes_pr_95869"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b671bef88144f0cebade813d78d73aec8a03a4e2cf1c4e228cccedb3bfc2e2a", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master (periodic-kubernetes-bazel-test-master ) Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --cc\n/sig api-machinery\nThis is continuing to be flaky with more recent failure:\n/assign Would you mind taking a look here? thanks! /triage accepted\n- can we somehow uncover when this started happening? This test is very old and it seems it started happening very recently, so it would be helpful to see when this started happening...\nTriage shows flakes starting ~Sept 30: Before Sept 30 it seems the job was flaking much less frequently.\nMight be related to I will take a look.\nIt seems it's not related to that PR (neither to the previous: ) As there were already failures like that on Sep 24th (before this one was merged). I will take a deeper look.\nOK - it's not related to any changes mentioned before. I can reproduce this particular failure by simply adding somewhere in this block: So it's probably connected to cpu-starvation at the test level and the solution is to switch to less aggressive timeouts. Will send out a PR.\nActually - it appeared to be slightly more subtle then that. But I already fully understand the problem. It's purely test issue, but require a bit more changes (and I won't get to it today/tomorrow). I will send a fix for that early next week.\n- if that changes anything from your tracking perspective ^^\nNo board changes yet - the next stage is \"Observing\" once this issue gets closed :) If you have time - I'd love to pick your brain/understand the error more thoroughly though! Hoping you drop a good explanation in your PR next week\nThanks for sharing those insights, on your discovery of the solution to this bug.\nIt seems the PR didn't address that fully. Looking.\nout for review", "positive_passages": [{"docid": "doc-en-kubernetes-b424421a0b165deac5950ead5abeba9a738ab80fbe2ae3acd66a4e29ce963a1f", "text": "shouldContinue = false } } <del> case <-time.After(2 * time.Second): </del> <ins> case <-time.After(wait.ForeverTestTimeout): </ins> shouldContinue = false w2.Stop() }", "commid": "kubernetes_pr_95918"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9d9bedd3f0610afcad243ef7558bc22ee3b89ec8b1f120499439bd302201b62b", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: gci-gce-serial-kube-dns-nodecache Which test(s) are failing: N/A Since when has it been failing: 10/13 Testgrid link: https://k8s- Reason for failure: Cluster failed to start: Anything else we need to know: /cc\nSo, is a failing job, we can see that there is a error around binding to a specific IP address. In passing jobs, the initial core file isn't printed out () so not sure how to do an apples to apples comparison of what is broken here yet.\n/kind bug I have been looking at this offline with and The only difference between a failing and a passing job is the arguments to the bind plugin. Failing Job: Link - Image - Config: Passing Job: Link - Image: Config:\nIssue is reproducible when spinning up a cluster via kubetest using:\nchanges to lines 907-910 in hack/local-up- and lines 2467 to 2469 in configure- seem like the issue.\nWhat we see is substitution works correctly for line , but for line , it replaces \"PILLARLOCALDNS\" with empty string.\n/assign Can you investigate?\nYeah lookin into it\nRegex is matching the entire line :). Should be easy fix . Will verify in hack local up and issue PR shortly\n/sig network /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-a80a2dfdabb9c3874e607c66dae917e93f8c64b78513aa27e8a38f87dec3552f", "text": "setup-addon-manifests \"addons\" \"0-dns/nodelocaldns\" local -r localdns_file=\"${dst_dir}/0-dns/nodelocaldns/nodelocaldns.yaml\" setup-addon-custom-yaml \"addons\" \"0-dns/nodelocaldns\" \"nodelocaldns.yaml\" \"${CUSTOM_NODELOCAL_DNS_YAML:-}\" <del> # Replace the sed configurations with variable values. sed -i -e \"s/_.*_DNS__DOMAIN__/${DNS_DOMAIN}/g\" \"${localdns_file}\" sed -i -e \"s/_.*_DNS__SERVER__/${DNS_SERVER_IP}/g\" \"${localdns_file}\" sed -i -e \"s/_.*_LOCAL__DNS__/${LOCAL_DNS_IP}/g\" \"${localdns_file}\" </del> <ins> # eventually all the __PILLAR__ stuff will be gone, but theyre still in nodelocaldns for backward compat. sed -i -e \"s/__PILLAR__DNS__DOMAIN__/${DNS_DOMAIN}/g\" \"${localdns_file}\" sed -i -e \"s/__PILLAR__DNS__SERVER__/${DNS_SERVER_IP}/g\" \"${localdns_file}\" sed -i -e \"s/__PILLAR__LOCAL__DNS__/${LOCAL_DNS_IP}/g\" \"${localdns_file}\" </ins> } # Sets up the manifests of netd for k8s addons.", "commid": "kubernetes_pr_95580"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9d9bedd3f0610afcad243ef7558bc22ee3b89ec8b1f120499439bd302201b62b", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: gci-gce-serial-kube-dns-nodecache Which test(s) are failing: N/A Since when has it been failing: 10/13 Testgrid link: https://k8s- Reason for failure: Cluster failed to start: Anything else we need to know: /cc\nSo, is a failing job, we can see that there is a error around binding to a specific IP address. In passing jobs, the initial core file isn't printed out () so not sure how to do an apples to apples comparison of what is broken here yet.\n/kind bug I have been looking at this offline with and The only difference between a failing and a passing job is the arguments to the bind plugin. Failing Job: Link - Image - Config: Passing Job: Link - Image: Config:\nIssue is reproducible when spinning up a cluster via kubetest using:\nchanges to lines 907-910 in hack/local-up- and lines 2467 to 2469 in configure- seem like the issue.\nWhat we see is substitution works correctly for line , but for line , it replaces \"PILLARLOCALDNS\" with empty string.\n/assign Can you investigate?\nYeah lookin into it\nRegex is matching the entire line :). Should be easy fix . Will verify in hack local up and issue PR shortly\n/sig network /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-17e709e02b02debadba15e2815bd3f6d02c7313e25a1462a512b9fc30153034e", "text": "function start_nodelocaldns { cp \"${KUBE_ROOT}/cluster/addons/dns/nodelocaldns/nodelocaldns.yaml\" nodelocaldns.yaml <del> # .* because of the __PILLLAR__ references that eventually will be removed ${SED} -i -e \"s/_.*_DNS__DOMAIN__/${DNS_DOMAIN}/g\" nodelocaldns.yaml ${SED} -i -e \"s/_.*_DNS__SERVER__/${DNS_SERVER_IP}/g\" nodelocaldns.yaml ${SED} -i -e \"s/_.*_LOCAL__DNS__/${LOCAL_DNS_IP}/g\" nodelocaldns.yaml </del> <ins> # eventually all the __PILLAR__ stuff will be gone, but theyre still in nodelocaldns for backward compat. ${SED} -i -e \"s/__PILLAR__DNS__DOMAIN__/${DNS_DOMAIN}/g\" nodelocaldns.yaml ${SED} -i -e \"s/__PILLAR__DNS__SERVER__/${DNS_SERVER_IP}/g\" nodelocaldns.yaml ${SED} -i -e \"s/__PILLAR__LOCAL__DNS__/${LOCAL_DNS_IP}/g\" nodelocaldns.yaml </ins> # use kubectl to create nodelocaldns addon ${KUBECTL} --kubeconfig=\"${CERT_DIR}/admin.kubeconfig\" --namespace=kube-system create -f nodelocaldns.yaml echo \"NodeLocalDNS addon successfully deployed.\"", "commid": "kubernetes_pr_95580"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8ed1dbe8b468fe9f76018304d329e1539d0aa653ea1e07f2f9f7ec2da0a06e7", "query": "What would you like to be : Add integration tests for Why is this needed: This is part of the kubernetes/enhancements /sig cli /priority important-soon\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-224209f2d74abe06997c383300e2871ca10cf03edfe20c70355a74d1f152d8bb", "text": "<ins> #!/usr/bin/env bash # Copyright 2020 The Kubernetes Authors. # # Licensed under the Apache License, Version 2.0 (the \"License\"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #     http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an \"AS IS\" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. set -o errexit set -o nounset set -o pipefail run_kubectl_debug_pod_tests() { set -o nounset set -o errexit create_and_use_new_namespace kube::log::status \"Testing kubectl debug (pod tests)\" ### Pod Troubleshooting by Copy # Pre-Condition: Pod \"nginx\" is created kubectl run target \"--image=${IMAGE_NGINX:?}\" \"${kube_flags[@]:?}\" kube::test::get_object_assert pod \"{{range.items}}{{${id_field:?}}}:{{end}}\" 'target:' # Command: create a copy of target with a new debug container kubectl alpha debug target -it --copy-to=target-copy --image=busybox --container=debug-container --attach=false \"${kube_flags[@]:?}\" # Post-Conditions kube::test::get_object_assert pod \"{{range.items}}{{${id_field:?}}}:{{end}}\" 'target:target-copy:' kube::test::get_object_assert pod/target-copy '{{range.spec.containers}}{{.name}}:{{end}}' 'target:debug-container:' kube::test::get_object_assert pod/target-copy '{{range.spec.containers}}{{.image}}:{{end}}' \"${IMAGE_NGINX:?}:busybox:\" # Clean up kubectl delete pod target target-copy \"${kube_flags[@]:?}\" # Pre-Condition: Pod \"nginx\" is created kubectl run target \"--image=${IMAGE_NGINX:?}\" \"${kube_flags[@]:?}\" kube::test::get_object_assert pod \"{{range.items}}{{${id_field:?}}}:{{end}}\" 'target:' # Command: create a copy of target with a new debug container replacing the previous pod kubectl alpha debug target -it --copy-to=target-copy --image=busybox --container=debug-container --attach=false --replace \"${kube_flags[@]:?}\" # Post-Conditions kube::test::get_object_assert pod \"{{range.items}}{{${id_field:?}}}:{{end}}\" 'target-copy:' kube::test::get_object_assert pod/target-copy '{{range.spec.containers}}{{.name}}:{{end}}' 'target:debug-container:' kube::test::get_object_assert pod/target-copy '{{range.spec.containers}}{{.image}}:{{end}}' \"${IMAGE_NGINX:?}:busybox:\" # Clean up kubectl delete pod target-copy \"${kube_flags[@]:?}\" # Pre-Condition: Pod \"nginx\" is created kubectl run target \"--image=${IMAGE_NGINX:?}\" \"${kube_flags[@]:?}\" kube::test::get_object_assert pod \"{{range.items}}{{${id_field:?}}}:{{end}}\" 'target:' kube::test::get_object_assert pod/target '{{(index .spec.containers 0).name}}' 'target' # Command: copy the pod and replace the image of an existing container kubectl alpha debug target --image=busybox --container=target --copy-to=target-copy \"${kube_flags[@]:?}\" -- sleep 1m # Post-Conditions kube::test::get_object_assert pod \"{{range.items}}{{${id_field:?}}}:{{end}}\" 'target:target-copy:' kube::test::get_object_assert pod/target-copy \"{{(len .spec.containers)}}:{{${image_field:?}}}\" '1:busybox' # Clean up kubectl delete pod target target-copy \"${kube_flags[@]:?}\" set +o nounset set +o errexit } run_kubectl_debug_node_tests() { set -o nounset set -o errexit create_and_use_new_namespace kube::log::status \"Testing kubectl debug (pod tests)\" ### Node Troubleshooting by Privileged Container # Pre-Condition: Pod \"nginx\" is created kube::test::get_object_assert nodes \"{{range.items}}{{${id_field:?}}}:{{end}}\" '127.0.0.1:' # Command: create a new node debugger pod output_message=$(kubectl alpha debug node/127.0.0.1 --image=busybox --attach=false \"${kube_flags[@]:?}\" -- true) # Post-Conditions kube::test::get_object_assert pod \"{{(len .items)}}\" '1' debugger=$(kubectl get pod -o go-template=\"{{(index .items 0)${id_field:?}}}\") kube::test::if_has_string \"${output_message:?}\" \"${debugger:?}\" kube::test::get_object_assert \"pod/${debugger:?}\" \"{{${image_field:?}}}\" 'busybox' kube::test::get_object_assert \"pod/${debugger:?}\" '{{.spec.nodeName}}' '127.0.0.1' kube::test::get_object_assert \"pod/${debugger:?}\" '{{.spec.hostIPC}}' 'true' kube::test::get_object_assert \"pod/${debugger:?}\" '{{.spec.hostNetwork}}' 'true' kube::test::get_object_assert \"pod/${debugger:?}\" '{{.spec.hostPID}}' 'true' kube::test::get_object_assert \"pod/${debugger:?}\" '{{(index (index .spec.containers 0).volumeMounts 0).mountPath}}' '/host' kube::test::get_object_assert \"pod/${debugger:?}\" '{{(index .spec.volumes 0).hostPath.path}}' '/' # Clean up # pod.spec.nodeName is set by kubectl debug node which causes the delete to hang, # presumably waiting for a kubelet that's not present. Force the delete. kubectl delete --force pod \"${debugger:?}\" \"${kube_flags[@]:?}\" set +o nounset set +o errexit } </ins>", "commid": "kubernetes_pr_95737"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8ed1dbe8b468fe9f76018304d329e1539d0aa653ea1e07f2f9f7ec2da0a06e7", "query": "What would you like to be : Add integration tests for Why is this needed: This is part of the kubernetes/enhancements /sig cli /priority important-soon\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-b120513474cb43bd43433d677c53d294e0a2cb23dc279a6382bf371ca73467f5", "text": "source \"${KUBE_ROOT}/test/cmd/core.sh\" source \"${KUBE_ROOT}/test/cmd/crd.sh\" source \"${KUBE_ROOT}/test/cmd/create.sh\" <ins> source \"${KUBE_ROOT}/test/cmd/debug.sh\" </ins> source \"${KUBE_ROOT}/test/cmd/delete.sh\" source \"${KUBE_ROOT}/test/cmd/diff.sh\" source \"${KUBE_ROOT}/test/cmd/discovery.sh\"", "commid": "kubernetes_pr_95737"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b8ed1dbe8b468fe9f76018304d329e1539d0aa653ea1e07f2f9f7ec2da0a06e7", "query": "What would you like to be : Add integration tests for Why is this needed: This is part of the kubernetes/enhancements /sig cli /priority important-soon\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-69b8db6f07c877a925ebd4fd91117c05f8c92280c726a5cb477a114d042b647e", "text": "record_command run_wait_tests <ins> #################### # kubectl debug    # #################### if kube::test::if_supports_resource \"${pods}\" ; then record_command run_kubectl_debug_pod_tests fi if kube::test::if_supports_resource \"${nodes}\" ; then record_command run_kubectl_debug_node_tests fi </ins> cleanup_tests }", "commid": "kubernetes_pr_95737"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b19831576787b8f74d1ac763ee7547be79eedfdf3aa07547bdd6452e8f905b8a", "query": "What would you like to be : e2e test for service ExternalIPs Why is this needed: There is no test covering Service ExternalIPs Since we can not assume that the e2e binary will have connectivity against the nodes and that we can add routes to the environment, we are going to test it from a pod. I've verified that this works locally with the following commands: The test should leverage current framework, maybe something as A good example is here, maybe adding a ?\n/sig network /help wanted /triage accepted\n/help wanted /good-first-issue\n/assign\nI'd like to pick this up!\nOk,I'm not started :) /unassign /assign\nThere are two different externalIP codepaths, one for the case where the claimed external IP exists as an IP on the default interface, and one for where it does not. I suppose we could just temporarily add an IP to the default interface...\ngood idea Dan Please remember, it has to work for IPv6 and for IPv4 ... anyway, we can address these things during the review\nThis has been partially implemented with . Covering the code path for when an IP is does not exist on a node. I'll assign this back to you so you can split this issue or close it in favor of another issue. Thanks! /unassign /assign\nwhat is the different codepath for ExternalIPs that already exist on the host? ~My reading is that the only difference is that it opens a local socket on that port, can you expand on this?~ Found it\nso, it seems that this work in some environments because they are not using the bridge plugin why is not allowed that pods can reach ExternalIPs?\nWow, this is ancient and needs some fixing. This is not about preventing pod traffic from reaching those IPs. I had to really stare at it, and I am not 100% in my interpretation. First, we recognize such traffic from \"off machine\" (!physdev-is-in && !src=LOCAL, which we should probably switch to localDetector) and steer it to the Service. Second, we recognize ANY such traffic that is destined for a LOCAL address and shortcut that to the Service, Implicitly, traffic destined for this IP where the IP is not local goes to the system's default routing logic. The reliance on the bridge plugin is awful and archaic and I will buy a beverage of your choice for whomever gets rid of that. I think localDetector can cover this, but not 100% sure\nbut the ExternalIP belongs to a service and we(kube-proxy) \"knows\" where to send it (to the service) , that is the part I'm not sure to understand, because whatever the user is doing with that ExternalIP it has to send it back to the cluster to reach the service. However, there is always context that is important and maybe I'm missing something. Assuming we want to handle ALL the ExternalIP traffic with kube-proxy, the logic will be much simpler: traffic to an externalIP will be ALWAYS sent to the Service (DNAT) if traffic is NOT LOCAL, we also SNAT\n/remove-good-first-issue /remove-help-wanted", "positive_passages": [{"docid": "doc-en-kubernetes-0dd50982f29f46d0c47282ac93b0714f9a2145385cdc298bd9986568e87dbf87", "text": ") destChain := svcXlbChain <del> // We have to SNAT packets to external IPs if externalTrafficPolicy is cluster. </del> <ins> // We have to SNAT packets to external IPs if externalTrafficPolicy is cluster // and the traffic is NOT Local. Local traffic coming from Pods and Nodes will // be always forwarded to the corresponding Service, so no need to SNAT // If we can't differentiate the local traffic we always SNAT. </ins> if !svcInfo.OnlyNodeLocalEndpoints() { destChain = svcChain <del> writeLine(proxier.natRules, append(args, \"-j\", string(KubeMarkMasqChain))...) </del> <ins> // This masquerades off-cluster traffic to a External IP. if proxier.localDetector.IsImplemented() { writeLine(proxier.natRules, proxier.localDetector.JumpIfNotLocal(args, string(KubeMarkMasqChain))...) } else { writeLine(proxier.natRules, append(args, \"-j\", string(KubeMarkMasqChain))...) } </ins> } <ins> // Sent traffic bound for external IPs to the service chain. writeLine(proxier.natRules, append(args, \"-j\", string(destChain))...) </ins> <del> // Allow traffic for external IPs that does not come from a bridge (i.e. not from a container) // nor from a local process to be forwarded to the service. // This rule roughly translates to \"all traffic from off-machine\". // This is imperfect in the face of network plugins that might not use a bridge, but we can revisit that later. externalTrafficOnlyArgs := append(args, \"-m\", \"physdev\", \"!\", \"--physdev-is-in\", \"-m\", \"addrtype\", \"!\", \"--src-type\", \"LOCAL\") writeLine(proxier.natRules, append(externalTrafficOnlyArgs, \"-j\", string(destChain))...) dstLocalOnlyArgs := append(args, \"-m\", \"addrtype\", \"--dst-type\", \"LOCAL\") // Allow traffic bound for external IPs that happen to be recognized as local IPs to stay local. // This covers cases like GCE load-balancers which get added to the local routing table. writeLine(proxier.natRules, append(dstLocalOnlyArgs, \"-j\", string(destChain))...) </del> } else { // No endpoints. writeLine(proxier.filterRules,", "commid": "kubernetes_pr_96296"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b19831576787b8f74d1ac763ee7547be79eedfdf3aa07547bdd6452e8f905b8a", "query": "What would you like to be : e2e test for service ExternalIPs Why is this needed: There is no test covering Service ExternalIPs Since we can not assume that the e2e binary will have connectivity against the nodes and that we can add routes to the environment, we are going to test it from a pod. I've verified that this works locally with the following commands: The test should leverage current framework, maybe something as A good example is here, maybe adding a ?\n/sig network /help wanted /triage accepted\n/help wanted /good-first-issue\n/assign\nI'd like to pick this up!\nOk,I'm not started :) /unassign /assign\nThere are two different externalIP codepaths, one for the case where the claimed external IP exists as an IP on the default interface, and one for where it does not. I suppose we could just temporarily add an IP to the default interface...\ngood idea Dan Please remember, it has to work for IPv6 and for IPv4 ... anyway, we can address these things during the review\nThis has been partially implemented with . Covering the code path for when an IP is does not exist on a node. I'll assign this back to you so you can split this issue or close it in favor of another issue. Thanks! /unassign /assign\nwhat is the different codepath for ExternalIPs that already exist on the host? ~My reading is that the only difference is that it opens a local socket on that port, can you expand on this?~ Found it\nso, it seems that this work in some environments because they are not using the bridge plugin why is not allowed that pods can reach ExternalIPs?\nWow, this is ancient and needs some fixing. This is not about preventing pod traffic from reaching those IPs. I had to really stare at it, and I am not 100% in my interpretation. First, we recognize such traffic from \"off machine\" (!physdev-is-in && !src=LOCAL, which we should probably switch to localDetector) and steer it to the Service. Second, we recognize ANY such traffic that is destined for a LOCAL address and shortcut that to the Service, Implicitly, traffic destined for this IP where the IP is not local goes to the system's default routing logic. The reliance on the bridge plugin is awful and archaic and I will buy a beverage of your choice for whomever gets rid of that. I think localDetector can cover this, but not 100% sure\nbut the ExternalIP belongs to a service and we(kube-proxy) \"knows\" where to send it (to the service) , that is the part I'm not sure to understand, because whatever the user is doing with that ExternalIP it has to send it back to the cluster to reach the service. However, there is always context that is important and maybe I'm missing something. Assuming we want to handle ALL the ExternalIP traffic with kube-proxy, the logic will be much simpler: traffic to an externalIP will be ALWAYS sent to the Service (DNAT) if traffic is NOT LOCAL, we also SNAT\n/remove-good-first-issue /remove-help-wanted", "positive_passages": [{"docid": "doc-en-kubernetes-cdad361c2c50c39029aa17a1993b3dc0d1a8d980e7d2815a25433bd78e725d58", "text": "return nil } <ins> func testReachabilityOverExternalIP(externalIP string, sp v1.ServicePort, execPod *v1.Pod) error { return testEndpointReachability(externalIP, sp.Port, sp.Protocol, execPod) } </ins> func testReachabilityOverNodePorts(nodes *v1.NodeList, sp v1.ServicePort, pod *v1.Pod, clusterIP string) error { internalAddrs := e2enode.CollectAddresses(nodes, v1.NodeInternalIP) externalAddrs := e2enode.CollectAddresses(nodes, v1.NodeExternalIP)", "commid": "kubernetes_pr_96296"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b19831576787b8f74d1ac763ee7547be79eedfdf3aa07547bdd6452e8f905b8a", "query": "What would you like to be : e2e test for service ExternalIPs Why is this needed: There is no test covering Service ExternalIPs Since we can not assume that the e2e binary will have connectivity against the nodes and that we can add routes to the environment, we are going to test it from a pod. I've verified that this works locally with the following commands: The test should leverage current framework, maybe something as A good example is here, maybe adding a ?\n/sig network /help wanted /triage accepted\n/help wanted /good-first-issue\n/assign\nI'd like to pick this up!\nOk,I'm not started :) /unassign /assign\nThere are two different externalIP codepaths, one for the case where the claimed external IP exists as an IP on the default interface, and one for where it does not. I suppose we could just temporarily add an IP to the default interface...\ngood idea Dan Please remember, it has to work for IPv6 and for IPv4 ... anyway, we can address these things during the review\nThis has been partially implemented with . Covering the code path for when an IP is does not exist on a node. I'll assign this back to you so you can split this issue or close it in favor of another issue. Thanks! /unassign /assign\nwhat is the different codepath for ExternalIPs that already exist on the host? ~My reading is that the only difference is that it opens a local socket on that port, can you expand on this?~ Found it\nso, it seems that this work in some environments because they are not using the bridge plugin why is not allowed that pods can reach ExternalIPs?\nWow, this is ancient and needs some fixing. This is not about preventing pod traffic from reaching those IPs. I had to really stare at it, and I am not 100% in my interpretation. First, we recognize such traffic from \"off machine\" (!physdev-is-in && !src=LOCAL, which we should probably switch to localDetector) and steer it to the Service. Second, we recognize ANY such traffic that is destined for a LOCAL address and shortcut that to the Service, Implicitly, traffic destined for this IP where the IP is not local goes to the system's default routing logic. The reliance on the bridge plugin is awful and archaic and I will buy a beverage of your choice for whomever gets rid of that. I think localDetector can cover this, but not 100% sure\nbut the ExternalIP belongs to a service and we(kube-proxy) \"knows\" where to send it (to the service) , that is the part I'm not sure to understand, because whatever the user is doing with that ExternalIP it has to send it back to the cluster to reach the service. However, there is always context that is important and maybe I'm missing something. Assuming we want to handle ALL the ExternalIP traffic with kube-proxy, the logic will be much simpler: traffic to an externalIP will be ALWAYS sent to the Service (DNAT) if traffic is NOT LOCAL, we also SNAT\n/remove-good-first-issue /remove-help-wanted", "positive_passages": [{"docid": "doc-en-kubernetes-e7398ac1f9914e0f2eab743d3b6ecc4cedc2f9891e15bcc09d1c25cf5af228fa", "text": "func (j *TestJig) checkClusterIPServiceReachability(svc *v1.Service, pod *v1.Pod) error { clusterIP := svc.Spec.ClusterIP servicePorts := svc.Spec.Ports <ins> externalIPs := svc.Spec.ExternalIPs </ins> err := j.waitForAvailableEndpoint(ServiceEndpointsTimeout) if err != nil {", "commid": "kubernetes_pr_96296"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b19831576787b8f74d1ac763ee7547be79eedfdf3aa07547bdd6452e8f905b8a", "query": "What would you like to be : e2e test for service ExternalIPs Why is this needed: There is no test covering Service ExternalIPs Since we can not assume that the e2e binary will have connectivity against the nodes and that we can add routes to the environment, we are going to test it from a pod. I've verified that this works locally with the following commands: The test should leverage current framework, maybe something as A good example is here, maybe adding a ?\n/sig network /help wanted /triage accepted\n/help wanted /good-first-issue\n/assign\nI'd like to pick this up!\nOk,I'm not started :) /unassign /assign\nThere are two different externalIP codepaths, one for the case where the claimed external IP exists as an IP on the default interface, and one for where it does not. I suppose we could just temporarily add an IP to the default interface...\ngood idea Dan Please remember, it has to work for IPv6 and for IPv4 ... anyway, we can address these things during the review\nThis has been partially implemented with . Covering the code path for when an IP is does not exist on a node. I'll assign this back to you so you can split this issue or close it in favor of another issue. Thanks! /unassign /assign\nwhat is the different codepath for ExternalIPs that already exist on the host? ~My reading is that the only difference is that it opens a local socket on that port, can you expand on this?~ Found it\nso, it seems that this work in some environments because they are not using the bridge plugin why is not allowed that pods can reach ExternalIPs?\nWow, this is ancient and needs some fixing. This is not about preventing pod traffic from reaching those IPs. I had to really stare at it, and I am not 100% in my interpretation. First, we recognize such traffic from \"off machine\" (!physdev-is-in && !src=LOCAL, which we should probably switch to localDetector) and steer it to the Service. Second, we recognize ANY such traffic that is destined for a LOCAL address and shortcut that to the Service, Implicitly, traffic destined for this IP where the IP is not local goes to the system's default routing logic. The reliance on the bridge plugin is awful and archaic and I will buy a beverage of your choice for whomever gets rid of that. I think localDetector can cover this, but not 100% sure\nbut the ExternalIP belongs to a service and we(kube-proxy) \"knows\" where to send it (to the service) , that is the part I'm not sure to understand, because whatever the user is doing with that ExternalIP it has to send it back to the cluster to reach the service. However, there is always context that is important and maybe I'm missing something. Assuming we want to handle ALL the ExternalIP traffic with kube-proxy, the logic will be much simpler: traffic to an externalIP will be ALWAYS sent to the Service (DNAT) if traffic is NOT LOCAL, we also SNAT\n/remove-good-first-issue /remove-help-wanted", "positive_passages": [{"docid": "doc-en-kubernetes-0bc494552dd1fe929ff1e7aff4df579562b06cb775f6cc456b7ba7c9c82669e1", "text": "if err != nil { return err } <ins> if len(externalIPs) > 0 { for _, externalIP := range externalIPs { err = testReachabilityOverExternalIP(externalIP, servicePort, pod) if err != nil { return err } } } </ins> } return nil }", "commid": "kubernetes_pr_96296"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b19831576787b8f74d1ac763ee7547be79eedfdf3aa07547bdd6452e8f905b8a", "query": "What would you like to be : e2e test for service ExternalIPs Why is this needed: There is no test covering Service ExternalIPs Since we can not assume that the e2e binary will have connectivity against the nodes and that we can add routes to the environment, we are going to test it from a pod. I've verified that this works locally with the following commands: The test should leverage current framework, maybe something as A good example is here, maybe adding a ?\n/sig network /help wanted /triage accepted\n/help wanted /good-first-issue\n/assign\nI'd like to pick this up!\nOk,I'm not started :) /unassign /assign\nThere are two different externalIP codepaths, one for the case where the claimed external IP exists as an IP on the default interface, and one for where it does not. I suppose we could just temporarily add an IP to the default interface...\ngood idea Dan Please remember, it has to work for IPv6 and for IPv4 ... anyway, we can address these things during the review\nThis has been partially implemented with . Covering the code path for when an IP is does not exist on a node. I'll assign this back to you so you can split this issue or close it in favor of another issue. Thanks! /unassign /assign\nwhat is the different codepath for ExternalIPs that already exist on the host? ~My reading is that the only difference is that it opens a local socket on that port, can you expand on this?~ Found it\nso, it seems that this work in some environments because they are not using the bridge plugin why is not allowed that pods can reach ExternalIPs?\nWow, this is ancient and needs some fixing. This is not about preventing pod traffic from reaching those IPs. I had to really stare at it, and I am not 100% in my interpretation. First, we recognize such traffic from \"off machine\" (!physdev-is-in && !src=LOCAL, which we should probably switch to localDetector) and steer it to the Service. Second, we recognize ANY such traffic that is destined for a LOCAL address and shortcut that to the Service, Implicitly, traffic destined for this IP where the IP is not local goes to the system's default routing logic. The reliance on the bridge plugin is awful and archaic and I will buy a beverage of your choice for whomever gets rid of that. I think localDetector can cover this, but not 100% sure\nbut the ExternalIP belongs to a service and we(kube-proxy) \"knows\" where to send it (to the service) , that is the part I'm not sure to understand, because whatever the user is doing with that ExternalIP it has to send it back to the cluster to reach the service. However, there is always context that is important and maybe I'm missing something. Assuming we want to handle ALL the ExternalIP traffic with kube-proxy, the logic will be much simpler: traffic to an externalIP will be ALWAYS sent to the Service (DNAT) if traffic is NOT LOCAL, we also SNAT\n/remove-good-first-issue /remove-help-wanted", "positive_passages": [{"docid": "doc-en-kubernetes-a9de0de187f28bac73daaefdb22d29bbf02df5b2e2e19c101a22e287974a2581", "text": "framework.ExpectNoError(err) }) <ins> /* Create a ClusterIP service with an External IP that is not assigned to an interface. The IP ranges here are reserved for documentation according to [RFC 5737](https://tools.ietf.org/html/rfc5737) Section 3 and should not be used by any host. */ ginkgo.It(\"should be possible to connect to a service via ExternalIP when the external IP is not assigned to a node\", func() { serviceName := \"externalip-test\" ns := f.Namespace.Name externalIP := \"203.0.113.250\" if framework.TestContext.ClusterIsIPv6() { externalIP = \"2001:DB8::cb00:71fa\" } jig := e2eservice.NewTestJig(cs, ns, serviceName) ginkgo.By(\"creating service \" + serviceName + \" with type=clusterIP in namespace \" + ns) clusterIPService, err := jig.CreateTCPService(func(svc *v1.Service) { svc.Spec.Type = v1.ServiceTypeClusterIP svc.Spec.ExternalIPs = []string{externalIP} svc.Spec.Ports = []v1.ServicePort{ {Port: 80, Name: \"http\", Protocol: v1.ProtocolTCP, TargetPort: intstr.FromInt(9376)}, } }) framework.ExpectNoError(err) err = jig.CreateServicePods(2) framework.ExpectNoError(err) execPod := e2epod.CreateExecPodOrFail(cs, ns, \"execpod\", nil) err = jig.CheckServiceReachability(clusterIPService, execPod) framework.ExpectNoError(err) }) </ins> // TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. ginkgo.It(\"should be able to change the type and ports of a service [Slow] [DisabledForLargeClusters]\", func() { // requires cloud load-balancer support", "commid": "kubernetes_pr_96296"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bf3f2554164b636c15af30366e6e5bdc5625dbcdc6f39ed32305e9b53962aee7", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Using example for from documentation failed with: What you expected to happen: Example from documentation works. How to reproduce it (as minimally and precisely as possible): How should configuration look like for ? Environment: Kubernetes version (use ):OS (e.g: ):Kernel (e.g. ):\n/sig scheduling\n/triage accepted oh, I missed a dash. It should be: Would you mind sending a PR to kubernetes/website?", "positive_passages": [{"docid": "doc-en-kubernetes-476c4c0972998fe2451b4e3367a925c1e278d2c80df2962647126557d9701642", "text": "<del> ## Contributor guidelines 1. Please read our [contributor guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md). 1. See our [developer guide](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md). 1. Follow the instructions for [labeling and writing a release note for this PR](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes) in the block below. (_this would also contain updated detail later about this new template_) ```release-note * Use the release-note-* labels to set the release note state * Clear this block to use the PR title as the release note -OR- * Enter your extended release note here ``` </del>", "commid": "kubernetes_pr_24699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bf3f2554164b636c15af30366e6e5bdc5625dbcdc6f39ed32305e9b53962aee7", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Using example for from documentation failed with: What you expected to happen: Example from documentation works. How to reproduce it (as minimally and precisely as possible): How should configuration look like for ? Environment: Kubernetes version (use ):OS (e.g: ):Kernel (e.g. ):\n/sig scheduling\n/triage accepted oh, I missed a dash. It should be: Would you mind sending a PR to kubernetes/website?", "positive_passages": [{"docid": "doc-en-kubernetes-3268db52d8a2f8041d0d1a8d7b379ee615afc63d2222832bfc3fa574573b3e94", "text": "<ins> ## Pull Request Guidelines 1. Please read our [contributor guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md). 1. See our [developer guide](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md). 1. Follow the instructions for [labeling and writing a release note for this PR](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes) in the block below. ```release-note * Use the release-note-* labels to set the release note state * Clear this block to use the PR title as the release note -OR- * Enter your extended release note here ``` [![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]() </ins>", "commid": "kubernetes_pr_24699"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fe836db0f396b7544c45d10c1bdc83b467bb243decb6d399f76c072a922c10ac", "query": "What happened: Process running as non-root will fail to work as it cannot access /etc/hosts inside the container when umask of kubelet is configured as 027. It is because the ioutil.WriteFile() used to create /etc/hosts is impacted by umask. Even though kubelet specify the permission of 0644 explicitly, with umask of 0027, it will be configured as 0640. As a result, application running inside the pods with non-root user, failed to access it. What you expected to happen: kubelet should pre-configure required umask by itself, instead of depending on the environment. At least we should document the required umask. How to reproduce it (as minimally and precisely as possible): Lauch kubelet with umask of 027 Anything else we need to know?: It's the same problem figured out. Environment: Kubernetes version (use ): 1.19 Cloud provider or hardware configuration: N/A OS (e.g: ): Ubuntu 18.04.4 LTS Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\n/area kubelet\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-contributor-experience at . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-4c1e9b59d43d2db2622babf0ee503c21b58b822ca7486e0971e2f187eedb9474", "text": "hostsFileContent = managedHostsFileContent(hostIPs, hostName, hostDomainName, hostAliases) } <del> return os.WriteFile(fileName, hostsFileContent, 0644) </del> <ins> hostsFilePerm := os.FileMode(0644) if err := os.WriteFile(fileName, hostsFileContent, hostsFilePerm); err != nil { return err } return os.Chmod(fileName, hostsFilePerm) </ins> } // nodeHostsFileContent reads the content of node's hosts file.", "commid": "kubernetes_pr_113209"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cef38c378015a3c37c6ee1632d82c03243825979d637fc81c55115a5c8a6f392", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: Which test(s) are failing: Since when has it been failing: Testgrid link: Reason for failure: Anything else we need to know: Introduced in /cc /sig node /assign /milestone v1.20\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-66db5386d5a73eed6d3c114455e92a28b1abdf210671e1af1af06a3470ef9d2d", "text": "fmt.Sprintf(\"%s::%s::%s\", f.Namespace.Name, pod1, \"busybox-container\"): boundedSample(10*e2evolume.Kb, 80*e2evolume.Mb), }), <del> \"pod_cpu_usage_seconds_total\": gstruct.MatchElements(containerID, gstruct.IgnoreExtras, gstruct.Elements{ </del> <ins> \"pod_cpu_usage_seconds_total\": gstruct.MatchElements(podID, gstruct.IgnoreExtras, gstruct.Elements{ </ins> fmt.Sprintf(\"%s::%s\", f.Namespace.Name, pod0): boundedSample(0, 100), fmt.Sprintf(\"%s::%s\", f.Namespace.Name, pod1): boundedSample(0, 100), }), <del> \"pod_memory_working_set_bytes\": gstruct.MatchAllElements(containerID, gstruct.Elements{ </del> <ins> \"pod_memory_working_set_bytes\": gstruct.MatchElements(podID, gstruct.IgnoreExtras, gstruct.Elements{ </ins> fmt.Sprintf(\"%s::%s\", f.Namespace.Name, pod0): boundedSample(10*e2evolume.Kb, 80*e2evolume.Mb), fmt.Sprintf(\"%s::%s\", f.Namespace.Name, pod1): boundedSample(10*e2evolume.Kb, 80*e2evolume.Mb), }),", "commid": "kubernetes_pr_96570"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cef38c378015a3c37c6ee1632d82c03243825979d637fc81c55115a5c8a6f392", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: Which test(s) are failing: Since when has it been failing: Testgrid link: Reason for failure: Anything else we need to know: Introduced in /cc /sig node /assign /milestone v1.20\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-1c7888aa19ca6dcfdc2e964f6ff52b119f3e198434841b1758af69fff91af64f", "text": "return \"\" } <ins> func podID(element interface{}) string { el := element.(*model.Sample) return fmt.Sprintf(\"%s::%s\", el.Metric[\"namespace\"], el.Metric[\"pod\"]) } </ins> func containerID(element interface{}) string { el := element.(*model.Sample) return fmt.Sprintf(\"%s::%s::%s\", el.Metric[\"namespace\"], el.Metric[\"pod\"], el.Metric[\"container\"])", "commid": "kubernetes_pr_96570"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-44740d4070d0501af97dd465c140fe134e86e61a92e57be660e314c999c2fc8e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When I register a device plugin and set the option in true, then when I create a pod and specify this resource as 0 in yaml, an error will be reported. Examples are as follows. The request to register the device pluginA pod yaml with the resource 0kubelet return error What you expected to happen: I think when the kubelet calls , the resource value should be checked. If it is 0, the step should be skipped to avoid errors. How to reproduce it (as minimally and precisely as possible): Register a device plugin which set option is true Create a pod with the above resource 0 Anything else we need to know?: In fact, when the amount of requested resources is 0, devicemanager will get the number of allocated devices as nil, resulting in the internal cache not storing the application resource information corresponding to the container. But if is set to true at the same time, then devicemanager will check podDevices cache. The two processing steps contradict each other so it will return an error.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-89382f994ae211d0ce576d253b9060b7448bc60d5f40c46308d774b6e602294e", "text": "podUID := string(pod.UID) contName := container.Name needsReAllocate := false <del> for k := range container.Resources.Limits { </del> <ins> for k, v := range container.Resources.Limits { </ins> resource := string(k) <del> if !m.isDevicePluginResource(resource) { </del> <ins> if !m.isDevicePluginResource(resource) || v.Value() == 0 { </ins> continue } err := m.callPreStartContainerIfNeeded(podUID, contName, resource)", "commid": "kubernetes_pr_96781"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-44740d4070d0501af97dd465c140fe134e86e61a92e57be660e314c999c2fc8e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When I register a device plugin and set the option in true, then when I create a pod and specify this resource as 0 in yaml, an error will be reported. Examples are as follows. The request to register the device pluginA pod yaml with the resource 0kubelet return error What you expected to happen: I think when the kubelet calls , the resource value should be checked. If it is 0, the step should be skipped to avoid errors. How to reproduce it (as minimally and precisely as possible): Register a device plugin which set option is true Create a pod with the above resource 0 Anything else we need to know?: In fact, when the amount of requested resources is 0, devicemanager will get the number of allocated devices as nil, resulting in the internal cache not storing the application resource information corresponding to the container. But if is set to true at the same time, then devicemanager will check podDevices cache. The two processing steps contradict each other so it will return an error.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node", "positive_passages": [{"docid": "doc-en-kubernetes-98ab66a7dabaa33462983b13ab4e757a22ceab4bc64bde46533d2c1ad41545b4", "text": "as.Equal(len(runContainerOpts.Devices), len(expectedResp.Devices)) as.Equal(len(runContainerOpts.Mounts), len(expectedResp.Mounts)) as.Equal(len(runContainerOpts.Envs), len(expectedResp.Envs)) <ins> pod2 := makePod(v1.ResourceList{ v1.ResourceName(res1.resourceName): *resource.NewQuantity(int64(0), resource.DecimalSI)}) activePods = append(activePods, pod2) podsStub.updateActivePods(activePods) err = testManager.Allocate(pod2, &pod2.Spec.Containers[0]) as.Nil(err) _, err = testManager.GetDeviceRunContainerOptions(pod2, &pod2.Spec.Containers[0]) as.Nil(err) select { case <-time.After(time.Millisecond): t.Log(\"When pod resourceQuantity is 0,  PreStartContainer RPC stub will be skipped\") case <-ch: break } </ins> } func TestResetExtendedResource(t *testing.T) {", "commid": "kubernetes_pr_96781"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-43b17effa5a0f40b960beadbb50098bc7d24e26a5775c33f71d691800c42fb26", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Below k8s UT fail when run with master-golang. TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON error:=== RUN TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON I1124 05:38:14. ] [cpumanager] initializing new in-memory state store unexpected error while creatng checkpointState: could not restore state from checkpoint: json: unexpected end of JSON input, please drain this node and delete the CPU manager checkpoint file \"/tmp/cpumanagerstatetest479660663/cpumanagercheckpointtest\" before restarting Kubelet --- FAIL: TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON (0.00s) TestStrategicMergePatchInvalid error:=== RUN TestStrategicMergePatchInvalid expected \"invalid character 'b' looking for beginning of value\", got \"json: invalid character 'b' looking for beginning of value\" --- FAIL: TestStrategicMergePatchInvalid (0.00s) TestJSONPatch error:=== RUN TestJSONPatch invalid-syntax: expected error invalid character 'i' looking for beginning of value, but got json: invalid character 'i' looking for beginning of value --- FAIL: TestJSONPatch (0.00s) TestV4ErrorDecoder expandless error:=== RUN TestV4ErrorDecoder wrong error for message \"{\": want=\"error stream protocol error: unexpected end of JSON input in \"{\"\", got=\"error stream protocol error: json: unexpected end of JSON input in \"{\"\" --- FAIL: TestV4ErrorDecoder (0.00s What you expected to happen: The tests should pass with no error. How to reproduce it (as minimally and precisely as possible): a stable version of golang installed master go from upstream git clone cd go/src cd ../.. cp -r ./go /usr/local export PATH=/usr/local/go/bin:$PATH kubernetes repo and run the unit tests. () Anything else we need to know?: These failures are occurring due to mismatch of error messages between upstream go and the k8s tests. There is an addition \"json:\" prefix to SyntaxError messages after this below commit: Environment: Kubernetes version (use ): latest source code from upstream Cloud provider or hardware configuration: OS (e.g: ): \"CentOS Linux 8 (Core)\" Kernel (e.g. ): Linux rajalakshmi-workspace 4.18.0-193.19.1.el82.ppc64le SMP Mon Sep 14 14:48:04 UTC 2020 ppc64le ppc64le ppc64le GNU/Linux Install tools: [root go]# go version go version devel + Fri Nov 20 00:54:43 2020 +0000 linux/ppc64le [root go]# Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig testing\nwill fix it in Go 1.16 as release-blocker.\nI would fix the test here to be more tolerant. exact string matches on error messages aren't really an API\u2026 I would not expect that to block the golang release\nAgree too, we can think about having a substring match to avoid these issues instead!\n/assign Lets see if we can fix this in the k8s tests", "positive_passages": [{"docid": "doc-en-kubernetes-660938dbcb689c10815d857f44eecac7a3d9fae6269cf6811e70ee267c5c7a60", "text": "restoredState, err := NewCheckpointState(testingDir, testingCheckpoint, tc.policyName, tc.initialContainers) if err != nil { if strings.TrimSpace(tc.expectedError) != \"\" { <del> tc.expectedError = \"could not restore state from checkpoint: \" + tc.expectedError if strings.HasPrefix(err.Error(), tc.expectedError) { </del> <ins> if strings.Contains(err.Error(), \"could not restore state from checkpoint\") && strings.Contains(err.Error(), tc.expectedError) { </ins> t.Logf(\"got expected error: %v\", err) return }", "commid": "kubernetes_pr_96906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-43b17effa5a0f40b960beadbb50098bc7d24e26a5775c33f71d691800c42fb26", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Below k8s UT fail when run with master-golang. TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON error:=== RUN TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON I1124 05:38:14. ] [cpumanager] initializing new in-memory state store unexpected error while creatng checkpointState: could not restore state from checkpoint: json: unexpected end of JSON input, please drain this node and delete the CPU manager checkpoint file \"/tmp/cpumanagerstatetest479660663/cpumanagercheckpointtest\" before restarting Kubelet --- FAIL: TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON (0.00s) TestStrategicMergePatchInvalid error:=== RUN TestStrategicMergePatchInvalid expected \"invalid character 'b' looking for beginning of value\", got \"json: invalid character 'b' looking for beginning of value\" --- FAIL: TestStrategicMergePatchInvalid (0.00s) TestJSONPatch error:=== RUN TestJSONPatch invalid-syntax: expected error invalid character 'i' looking for beginning of value, but got json: invalid character 'i' looking for beginning of value --- FAIL: TestJSONPatch (0.00s) TestV4ErrorDecoder expandless error:=== RUN TestV4ErrorDecoder wrong error for message \"{\": want=\"error stream protocol error: unexpected end of JSON input in \"{\"\", got=\"error stream protocol error: json: unexpected end of JSON input in \"{\"\" --- FAIL: TestV4ErrorDecoder (0.00s What you expected to happen: The tests should pass with no error. How to reproduce it (as minimally and precisely as possible): a stable version of golang installed master go from upstream git clone cd go/src cd ../.. cp -r ./go /usr/local export PATH=/usr/local/go/bin:$PATH kubernetes repo and run the unit tests. () Anything else we need to know?: These failures are occurring due to mismatch of error messages between upstream go and the k8s tests. There is an addition \"json:\" prefix to SyntaxError messages after this below commit: Environment: Kubernetes version (use ): latest source code from upstream Cloud provider or hardware configuration: OS (e.g: ): \"CentOS Linux 8 (Core)\" Kernel (e.g. ): Linux rajalakshmi-workspace 4.18.0-193.19.1.el82.ppc64le SMP Mon Sep 14 14:48:04 UTC 2020 ppc64le ppc64le ppc64le GNU/Linux Install tools: [root go]# go version go version devel + Fri Nov 20 00:54:43 2020 +0000 linux/ppc64le [root go]# Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig testing\nwill fix it in Go 1.16 as release-blocker.\nI would fix the test here to be more tolerant. exact string matches on error messages aren't really an API\u2026 I would not expect that to block the golang release\nAgree too, we can think about having a substring match to avoid these issues instead!\n/assign Lets see if we can fix this in the k8s tests", "positive_passages": [{"docid": "doc-en-kubernetes-3ff1b8d08100a08f3d19a06321feeddf479f63a137fb9563a2d32342ce18fd1e", "text": "if !apierrors.IsBadRequest(err) { t.Errorf(\"expected HTTP status: BadRequest, got: %#v\", apierrors.ReasonForError(err)) } <del> if err.Error() != expectedError { </del> <ins> if !strings.Contains(err.Error(), expectedError) { </ins> t.Errorf(\"expected %#v, got %#v\", expectedError, err.Error()) } }", "commid": "kubernetes_pr_96906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-43b17effa5a0f40b960beadbb50098bc7d24e26a5775c33f71d691800c42fb26", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Below k8s UT fail when run with master-golang. TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON error:=== RUN TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON I1124 05:38:14. ] [cpumanager] initializing new in-memory state store unexpected error while creatng checkpointState: could not restore state from checkpoint: json: unexpected end of JSON input, please drain this node and delete the CPU manager checkpoint file \"/tmp/cpumanagerstatetest479660663/cpumanagercheckpointtest\" before restarting Kubelet --- FAIL: TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON (0.00s) TestStrategicMergePatchInvalid error:=== RUN TestStrategicMergePatchInvalid expected \"invalid character 'b' looking for beginning of value\", got \"json: invalid character 'b' looking for beginning of value\" --- FAIL: TestStrategicMergePatchInvalid (0.00s) TestJSONPatch error:=== RUN TestJSONPatch invalid-syntax: expected error invalid character 'i' looking for beginning of value, but got json: invalid character 'i' looking for beginning of value --- FAIL: TestJSONPatch (0.00s) TestV4ErrorDecoder expandless error:=== RUN TestV4ErrorDecoder wrong error for message \"{\": want=\"error stream protocol error: unexpected end of JSON input in \"{\"\", got=\"error stream protocol error: json: unexpected end of JSON input in \"{\"\" --- FAIL: TestV4ErrorDecoder (0.00s What you expected to happen: The tests should pass with no error. How to reproduce it (as minimally and precisely as possible): a stable version of golang installed master go from upstream git clone cd go/src cd ../.. cp -r ./go /usr/local export PATH=/usr/local/go/bin:$PATH kubernetes repo and run the unit tests. () Anything else we need to know?: These failures are occurring due to mismatch of error messages between upstream go and the k8s tests. There is an addition \"json:\" prefix to SyntaxError messages after this below commit: Environment: Kubernetes version (use ): latest source code from upstream Cloud provider or hardware configuration: OS (e.g: ): \"CentOS Linux 8 (Core)\" Kernel (e.g. ): Linux rajalakshmi-workspace 4.18.0-193.19.1.el82.ppc64le SMP Mon Sep 14 14:48:04 UTC 2020 ppc64le ppc64le ppc64le GNU/Linux Install tools: [root go]# go version go version devel + Fri Nov 20 00:54:43 2020 +0000 linux/ppc64le [root go]# Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig testing\nwill fix it in Go 1.16 as release-blocker.\nI would fix the test here to be more tolerant. exact string matches on error messages aren't really an API\u2026 I would not expect that to block the golang release\nAgree too, we can think about having a substring match to avoid these issues instead!\n/assign Lets see if we can fix this in the k8s tests", "positive_passages": [{"docid": "doc-en-kubernetes-c9667454a72dbef147eaf74d68005f5c9c6db06ba9b7460f165ea628a3bdcdbc", "text": "t.Errorf(\"%s: expect no error when applying json patch, but got %v\", test.name, err) continue } <del> if err.Error() != test.expectedError { </del> <ins> if !strings.Contains(err.Error(), test.expectedError) { </ins> t.Errorf(\"%s: expected error %v, but got %v\", test.name, test.expectedError, err) } if test.expectedErrorType != apierrors.ReasonForError(err) {", "commid": "kubernetes_pr_96906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-43b17effa5a0f40b960beadbb50098bc7d24e26a5775c33f71d691800c42fb26", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Below k8s UT fail when run with master-golang. TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON error:=== RUN TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON I1124 05:38:14. ] [cpumanager] initializing new in-memory state store unexpected error while creatng checkpointState: could not restore state from checkpoint: json: unexpected end of JSON input, please drain this node and delete the CPU manager checkpoint file \"/tmp/cpumanagerstatetest479660663/cpumanagercheckpointtest\" before restarting Kubelet --- FAIL: TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON (0.00s) TestStrategicMergePatchInvalid error:=== RUN TestStrategicMergePatchInvalid expected \"invalid character 'b' looking for beginning of value\", got \"json: invalid character 'b' looking for beginning of value\" --- FAIL: TestStrategicMergePatchInvalid (0.00s) TestJSONPatch error:=== RUN TestJSONPatch invalid-syntax: expected error invalid character 'i' looking for beginning of value, but got json: invalid character 'i' looking for beginning of value --- FAIL: TestJSONPatch (0.00s) TestV4ErrorDecoder expandless error:=== RUN TestV4ErrorDecoder wrong error for message \"{\": want=\"error stream protocol error: unexpected end of JSON input in \"{\"\", got=\"error stream protocol error: json: unexpected end of JSON input in \"{\"\" --- FAIL: TestV4ErrorDecoder (0.00s What you expected to happen: The tests should pass with no error. How to reproduce it (as minimally and precisely as possible): a stable version of golang installed master go from upstream git clone cd go/src cd ../.. cp -r ./go /usr/local export PATH=/usr/local/go/bin:$PATH kubernetes repo and run the unit tests. () Anything else we need to know?: These failures are occurring due to mismatch of error messages between upstream go and the k8s tests. There is an addition \"json:\" prefix to SyntaxError messages after this below commit: Environment: Kubernetes version (use ): latest source code from upstream Cloud provider or hardware configuration: OS (e.g: ): \"CentOS Linux 8 (Core)\" Kernel (e.g. ): Linux rajalakshmi-workspace 4.18.0-193.19.1.el82.ppc64le SMP Mon Sep 14 14:48:04 UTC 2020 ppc64le ppc64le ppc64le GNU/Linux Install tools: [root go]# go version go version devel + Fri Nov 20 00:54:43 2020 +0000 linux/ppc64le [root go]# Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig testing\nwill fix it in Go 1.16 as release-blocker.\nI would fix the test here to be more tolerant. exact string matches on error messages aren't really an API\u2026 I would not expect that to block the golang release\nAgree too, we can think about having a substring match to avoid these issues instead!\n/assign Lets see if we can fix this in the k8s tests", "positive_passages": [{"docid": "doc-en-kubernetes-497eaace1e80105629b4df313bb48300a519f943ad476b33c965fe0906a44b21", "text": "import ( \"fmt\" <ins> \"strings\" </ins> \"testing\" )", "commid": "kubernetes_pr_96906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-43b17effa5a0f40b960beadbb50098bc7d24e26a5775c33f71d691800c42fb26", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Below k8s UT fail when run with master-golang. TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON error:=== RUN TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON I1124 05:38:14. ] [cpumanager] initializing new in-memory state store unexpected error while creatng checkpointState: could not restore state from checkpoint: json: unexpected end of JSON input, please drain this node and delete the CPU manager checkpoint file \"/tmp/cpumanagerstatetest479660663/cpumanagercheckpointtest\" before restarting Kubelet --- FAIL: TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON (0.00s) TestStrategicMergePatchInvalid error:=== RUN TestStrategicMergePatchInvalid expected \"invalid character 'b' looking for beginning of value\", got \"json: invalid character 'b' looking for beginning of value\" --- FAIL: TestStrategicMergePatchInvalid (0.00s) TestJSONPatch error:=== RUN TestJSONPatch invalid-syntax: expected error invalid character 'i' looking for beginning of value, but got json: invalid character 'i' looking for beginning of value --- FAIL: TestJSONPatch (0.00s) TestV4ErrorDecoder expandless error:=== RUN TestV4ErrorDecoder wrong error for message \"{\": want=\"error stream protocol error: unexpected end of JSON input in \"{\"\", got=\"error stream protocol error: json: unexpected end of JSON input in \"{\"\" --- FAIL: TestV4ErrorDecoder (0.00s What you expected to happen: The tests should pass with no error. How to reproduce it (as minimally and precisely as possible): a stable version of golang installed master go from upstream git clone cd go/src cd ../.. cp -r ./go /usr/local export PATH=/usr/local/go/bin:$PATH kubernetes repo and run the unit tests. () Anything else we need to know?: These failures are occurring due to mismatch of error messages between upstream go and the k8s tests. There is an addition \"json:\" prefix to SyntaxError messages after this below commit: Environment: Kubernetes version (use ): latest source code from upstream Cloud provider or hardware configuration: OS (e.g: ): \"CentOS Linux 8 (Core)\" Kernel (e.g. ): Linux rajalakshmi-workspace 4.18.0-193.19.1.el82.ppc64le SMP Mon Sep 14 14:48:04 UTC 2020 ppc64le ppc64le ppc64le GNU/Linux Install tools: [root go]# go version go version devel + Fri Nov 20 00:54:43 2020 +0000 linux/ppc64le [root go]# Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig testing\nwill fix it in Go 1.16 as release-blocker.\nI would fix the test here to be more tolerant. exact string matches on error messages aren't really an API\u2026 I would not expect that to block the golang release\nAgree too, we can think about having a substring match to avoid these issues instead!\n/assign Lets see if we can fix this in the k8s tests", "positive_passages": [{"docid": "doc-en-kubernetes-f286a1e96d66903fca4ee0789949116482edb1c5736ca29bf6dd3033dfb39405", "text": "}, { message: \"{\", <del> err:     \"error stream protocol error: unexpected end of JSON input in \"{\"\", </del> <ins> err:     \"unexpected end of JSON input in \"{\"\", </ins> }, { message: `{\"status\": \"Success\" }`,", "commid": "kubernetes_pr_96906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-43b17effa5a0f40b960beadbb50098bc7d24e26a5775c33f71d691800c42fb26", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Below k8s UT fail when run with master-golang. TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON error:=== RUN TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON I1124 05:38:14. ] [cpumanager] initializing new in-memory state store unexpected error while creatng checkpointState: could not restore state from checkpoint: json: unexpected end of JSON input, please drain this node and delete the CPU manager checkpoint file \"/tmp/cpumanagerstatetest479660663/cpumanagercheckpointtest\" before restarting Kubelet --- FAIL: TestCheckpointStateRestore/RestorecheckpointwithinvalidJSON (0.00s) TestStrategicMergePatchInvalid error:=== RUN TestStrategicMergePatchInvalid expected \"invalid character 'b' looking for beginning of value\", got \"json: invalid character 'b' looking for beginning of value\" --- FAIL: TestStrategicMergePatchInvalid (0.00s) TestJSONPatch error:=== RUN TestJSONPatch invalid-syntax: expected error invalid character 'i' looking for beginning of value, but got json: invalid character 'i' looking for beginning of value --- FAIL: TestJSONPatch (0.00s) TestV4ErrorDecoder expandless error:=== RUN TestV4ErrorDecoder wrong error for message \"{\": want=\"error stream protocol error: unexpected end of JSON input in \"{\"\", got=\"error stream protocol error: json: unexpected end of JSON input in \"{\"\" --- FAIL: TestV4ErrorDecoder (0.00s What you expected to happen: The tests should pass with no error. How to reproduce it (as minimally and precisely as possible): a stable version of golang installed master go from upstream git clone cd go/src cd ../.. cp -r ./go /usr/local export PATH=/usr/local/go/bin:$PATH kubernetes repo and run the unit tests. () Anything else we need to know?: These failures are occurring due to mismatch of error messages between upstream go and the k8s tests. There is an addition \"json:\" prefix to SyntaxError messages after this below commit: Environment: Kubernetes version (use ): latest source code from upstream Cloud provider or hardware configuration: OS (e.g: ): \"CentOS Linux 8 (Core)\" Kernel (e.g. ): Linux rajalakshmi-workspace 4.18.0-193.19.1.el82.ppc64le SMP Mon Sep 14 14:48:04 UTC 2020 ppc64le ppc64le ppc64le GNU/Linux Install tools: [root go]# go version go version devel + Fri Nov 20 00:54:43 2020 +0000 linux/ppc64le [root go]# Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig testing\nwill fix it in Go 1.16 as release-blocker.\nI would fix the test here to be more tolerant. exact string matches on error messages aren't really an API\u2026 I would not expect that to block the golang release\nAgree too, we can think about having a substring match to avoid these issues instead!\n/assign Lets see if we can fix this in the k8s tests", "positive_passages": [{"docid": "doc-en-kubernetes-e21bdc5763b59871a954222e0bdac0c992772aab12ead9263a9ec2d15935431d", "text": "if want == \"\" { want = \"<nil>\" } <del> if got := fmt.Sprintf(\"%v\", err); got != want { </del> <ins> if got := fmt.Sprintf(\"%v\", err); !strings.Contains(got, want) { </ins> t.Errorf(\"wrong error for message %q: want=%q, got=%q\", test.message, want, got) } }", "commid": "kubernetes_pr_96906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f9766970ccd4222b6bcd610bf151cff19f58f52961a6419348e3fed09954e4dc", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master Which test(s) are flaking: //pkg/kubelet/cm/devicemanager/godefaulttest:run2of_2 Testgrid link: Reason for failure: Anything else we need to know: links to appreciated Triage shows nothings (seems to not have updated data), but there are multiple failures in the job bazel-test-master. links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --\n/sig release\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /sig sig-release Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nDigging further as the step has another recent test fail ... So on the two runs reported by has 2 test failures has 1 test failure And the most recent failure in this area is a TestAdmit/match test failure but on a different test.\n/sig node\n/assign /triage accepted I'll take a look at them and fix.", "positive_passages": [{"docid": "doc-en-kubernetes-b2d26e8fdf24bd363852be94473683dd76a378f7355c56dc40b59bba825eee56", "text": "func setupInProbeMode(t *testing.T, devs []*pluginapi.Device, callback monitorCallback, socketName string, pluginSocketName string) (Manager, <-chan interface{}, *Stub, pluginmanager.PluginManager) { m, updateChan := setupDeviceManager(t, devs, callback, socketName) <del> pm := setupPluginManager(t, pluginSocketName, m) </del> p := setupDevicePlugin(t, devs, pluginSocketName) <ins> pm := setupPluginManager(t, pluginSocketName, m) </ins> return m, updateChan, p, pm }", "commid": "kubernetes_pr_97193"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f9766970ccd4222b6bcd610bf151cff19f58f52961a6419348e3fed09954e4dc", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master Which test(s) are flaking: //pkg/kubelet/cm/devicemanager/godefaulttest:run2of_2 Testgrid link: Reason for failure: Anything else we need to know: links to appreciated Triage shows nothings (seems to not have updated data), but there are multiple failures in the job bazel-test-master. links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --\n/sig release\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /sig sig-release Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nDigging further as the step has another recent test fail ... So on the two runs reported by has 2 test failures has 1 test failure And the most recent failure in this area is a TestAdmit/match test failure but on a different test.\n/sig node\n/assign /triage accepted I'll take a look at them and fix.", "positive_passages": [{"docid": "doc-en-kubernetes-6e0a05c53c652a5392e049071dfba6053c56bbd1625c28e246d072127162f5c5", "text": "rc.RLock() defer rc.RUnlock() <del> return rc.handlers </del> <ins> var copyHandlers = make(map[string]cache.PluginHandler) for pluginType, handler := range rc.handlers { copyHandlers[pluginType] = handler } return copyHandlers </ins> } func (rc *reconciler) reconcile() {", "commid": "kubernetes_pr_97193"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ccdb74dbd9ebc4bd41922c370ab977e3c1e001639e0c07715bc14f84fc8b75bc", "query": "What happened: I was running the subpath testsuite against Azurefile. This test failed and can be easily reproduced: Basically what this test does is: a PVC use azurefile a pod that has two containers. One of it mounts the volume itself. The second container mounts the subpath of the volume. the subpath dir from the container that has the whole volume the pod, the pod will stuck in terminating status and cannot be cleaned up other than What you expected to happen: The pod can be deleted successfully. How to reproduce it (as minimally and precisely as possible): the pvc the pod the subpath dir from the parent pod the pod Anything else we need to know?: The volume is being formatted as cifs type Environment: Kubernetes version (use ): v1.18.6 Cloud provider or hardware configuration: Azurefile-csi-driver 0.9.0 OS (e.g: ): Ubuntu 20.04 Kernel (e.g. ): Linux nodepool-- 5.4.0-1016-azure -Ubuntu SMP Thu Jun 4 22:49:15 UTC 2020 x8664 x8664 x86_64 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig storage /cc /cc\nlog After debugging with and offline, the issue is that: After the dir from the subpath was removed, the subpath mountpoint on the host machine becomes into a weird state where you can still find the dir by doing a readdir to its parent. But doing or something like that will result in a \"No such file or directory\". When you do a ls on the path:\n/triage accepted\nSo the issue from code is that It will fail the path exists check while the actual mountpoint exists. So when the code logic runs to here: It will fail to remove the container dir because it somehow detect there is still file there. To fix this as a workaround, user can manually , and then the kubelet can take care of this. To fix it ultimately, we need to see if this is an issue specific to cifs filesystem? Or we should consider do an umount regardless if the path exists.\n/assign\n/assign\nTried the same scenario using NFS. It works as expected using NFS.\nYeah, that's why I am wondering if this is something special with CIFS?\nLooks like it has something to do with the azurefile-csi storage class mount options. I was getting the below error when I was trying to do ls on the subpath. So I realized there might be some issue with the file permissions. root ls ls: cannot open directory '.': No such file or directory When I removed the dirmode and filemode properties from the storageclass and performed the same steps as mentioned in the issue, the pod got deleted successfully.(Although it took a lot of time 10-15 mins for the pod to get deleted)\nFYI, I am planning to use this PR to fix the unmount issue in Azure File & SMB CSI driver: Not sure how to handle gracefully in k8s subPath code since that's common code.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nSo this PR does not fix the Azurefile subpath test issue?\nno, that PR only fixed the unmount issue inside CSI driver. While for the subPath issue, we should fix it in k8s upstream code as you mentioned above:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nback to original discussion, shall we use instead of inside func? That will solve the issue of smb file PathExists check issue.\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Reopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /close [1]:\nClosing this issue. <detailsIn response to : The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closedReopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Reopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /close [1]:\nClosing this issue. <detailsIn response to : The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closedReopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nthis subPath issue was fixed in , ,", "positive_passages": [{"docid": "doc-en-kubernetes-4d5f45013f521509fc13f927f84cb91746955b92595dc602fbd953090c60afee", "text": "} return notMnt, nil } <del> // PathExists returns true if the specified path exists. // TODO: clean this up to use pkg/util/file/FileExists func PathExists(path string) (bool, error) { _, err := os.Stat(path) if err == nil { return true, nil } else if os.IsNotExist(err) { return false, nil } else if IsCorruptedMnt(err) { return true, err } return false, err } </del>", "commid": "kubernetes_pr_106906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ccdb74dbd9ebc4bd41922c370ab977e3c1e001639e0c07715bc14f84fc8b75bc", "query": "What happened: I was running the subpath testsuite against Azurefile. This test failed and can be easily reproduced: Basically what this test does is: a PVC use azurefile a pod that has two containers. One of it mounts the volume itself. The second container mounts the subpath of the volume. the subpath dir from the container that has the whole volume the pod, the pod will stuck in terminating status and cannot be cleaned up other than What you expected to happen: The pod can be deleted successfully. How to reproduce it (as minimally and precisely as possible): the pvc the pod the subpath dir from the parent pod the pod Anything else we need to know?: The volume is being formatted as cifs type Environment: Kubernetes version (use ): v1.18.6 Cloud provider or hardware configuration: Azurefile-csi-driver 0.9.0 OS (e.g: ): Ubuntu 20.04 Kernel (e.g. ): Linux nodepool-- 5.4.0-1016-azure -Ubuntu SMP Thu Jun 4 22:49:15 UTC 2020 x8664 x8664 x86_64 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig storage /cc /cc\nlog After debugging with and offline, the issue is that: After the dir from the subpath was removed, the subpath mountpoint on the host machine becomes into a weird state where you can still find the dir by doing a readdir to its parent. But doing or something like that will result in a \"No such file or directory\". When you do a ls on the path:\n/triage accepted\nSo the issue from code is that It will fail the path exists check while the actual mountpoint exists. So when the code logic runs to here: It will fail to remove the container dir because it somehow detect there is still file there. To fix this as a workaround, user can manually , and then the kubelet can take care of this. To fix it ultimately, we need to see if this is an issue specific to cifs filesystem? Or we should consider do an umount regardless if the path exists.\n/assign\n/assign\nTried the same scenario using NFS. It works as expected using NFS.\nYeah, that's why I am wondering if this is something special with CIFS?\nLooks like it has something to do with the azurefile-csi storage class mount options. I was getting the below error when I was trying to do ls on the subpath. So I realized there might be some issue with the file permissions. root ls ls: cannot open directory '.': No such file or directory When I removed the dirmode and filemode properties from the storageclass and performed the same steps as mentioned in the issue, the pod got deleted successfully.(Although it took a lot of time 10-15 mins for the pod to get deleted)\nFYI, I am planning to use this PR to fix the unmount issue in Azure File & SMB CSI driver: Not sure how to handle gracefully in k8s subPath code since that's common code.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nSo this PR does not fix the Azurefile subpath test issue?\nno, that PR only fixed the unmount issue inside CSI driver. While for the subPath issue, we should fix it in k8s upstream code as you mentioned above:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nback to original discussion, shall we use instead of inside func? That will solve the issue of smb file PathExists check issue.\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Reopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /close [1]:\nClosing this issue. <detailsIn response to : The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closedReopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Reopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /close [1]:\nClosing this issue. <detailsIn response to : The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closedReopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nthis subPath issue was fixed in , ,", "positive_passages": [{"docid": "doc-en-kubernetes-53e51dd4dbace44d65ae77d0723d46165784a88f9206bbdd5d4f14a2e66bf5ab", "text": "package mount import ( <ins> \"errors\" </ins> \"fmt\" <ins> \"io/fs\" </ins> \"os\" \"strconv\" \"strings\" \"syscall\" <ins> \"k8s.io/klog/v2\" </ins> utilio \"k8s.io/utils/io\" )", "commid": "kubernetes_pr_106906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ccdb74dbd9ebc4bd41922c370ab977e3c1e001639e0c07715bc14f84fc8b75bc", "query": "What happened: I was running the subpath testsuite against Azurefile. This test failed and can be easily reproduced: Basically what this test does is: a PVC use azurefile a pod that has two containers. One of it mounts the volume itself. The second container mounts the subpath of the volume. the subpath dir from the container that has the whole volume the pod, the pod will stuck in terminating status and cannot be cleaned up other than What you expected to happen: The pod can be deleted successfully. How to reproduce it (as minimally and precisely as possible): the pvc the pod the subpath dir from the parent pod the pod Anything else we need to know?: The volume is being formatted as cifs type Environment: Kubernetes version (use ): v1.18.6 Cloud provider or hardware configuration: Azurefile-csi-driver 0.9.0 OS (e.g: ): Ubuntu 20.04 Kernel (e.g. ): Linux nodepool-- 5.4.0-1016-azure -Ubuntu SMP Thu Jun 4 22:49:15 UTC 2020 x8664 x8664 x86_64 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig storage /cc /cc\nlog After debugging with and offline, the issue is that: After the dir from the subpath was removed, the subpath mountpoint on the host machine becomes into a weird state where you can still find the dir by doing a readdir to its parent. But doing or something like that will result in a \"No such file or directory\". When you do a ls on the path:\n/triage accepted\nSo the issue from code is that It will fail the path exists check while the actual mountpoint exists. So when the code logic runs to here: It will fail to remove the container dir because it somehow detect there is still file there. To fix this as a workaround, user can manually , and then the kubelet can take care of this. To fix it ultimately, we need to see if this is an issue specific to cifs filesystem? Or we should consider do an umount regardless if the path exists.\n/assign\n/assign\nTried the same scenario using NFS. It works as expected using NFS.\nYeah, that's why I am wondering if this is something special with CIFS?\nLooks like it has something to do with the azurefile-csi storage class mount options. I was getting the below error when I was trying to do ls on the subpath. So I realized there might be some issue with the file permissions. root ls ls: cannot open directory '.': No such file or directory When I removed the dirmode and filemode properties from the storageclass and performed the same steps as mentioned in the issue, the pod got deleted successfully.(Although it took a lot of time 10-15 mins for the pod to get deleted)\nFYI, I am planning to use this PR to fix the unmount issue in Azure File & SMB CSI driver: Not sure how to handle gracefully in k8s subPath code since that's common code.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nSo this PR does not fix the Azurefile subpath test issue?\nno, that PR only fixed the unmount issue inside CSI driver. While for the subPath issue, we should fix it in k8s upstream code as you mentioned above:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nback to original discussion, shall we use instead of inside func? That will solve the issue of smb file PathExists check issue.\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Reopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /close [1]:\nClosing this issue. <detailsIn response to : The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closedReopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Reopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /close [1]:\nClosing this issue. <detailsIn response to : The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closedReopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nthis subPath issue was fixed in , ,", "positive_passages": [{"docid": "doc-en-kubernetes-314244ba10360ed7e87fb7f76e509a4166312087972367d986bd68d6a0e2b187", "text": "underlyingError = pe.Err case *os.SyscallError: underlyingError = pe.Err <ins> case syscall.Errno: underlyingError = err </ins> } return underlyingError == syscall.ENOTCONN || underlyingError == syscall.ESTALE || underlyingError == syscall.EIO || underlyingError == syscall.EACCES || underlyingError == syscall.EHOSTDOWN", "commid": "kubernetes_pr_106906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ccdb74dbd9ebc4bd41922c370ab977e3c1e001639e0c07715bc14f84fc8b75bc", "query": "What happened: I was running the subpath testsuite against Azurefile. This test failed and can be easily reproduced: Basically what this test does is: a PVC use azurefile a pod that has two containers. One of it mounts the volume itself. The second container mounts the subpath of the volume. the subpath dir from the container that has the whole volume the pod, the pod will stuck in terminating status and cannot be cleaned up other than What you expected to happen: The pod can be deleted successfully. How to reproduce it (as minimally and precisely as possible): the pvc the pod the subpath dir from the parent pod the pod Anything else we need to know?: The volume is being formatted as cifs type Environment: Kubernetes version (use ): v1.18.6 Cloud provider or hardware configuration: Azurefile-csi-driver 0.9.0 OS (e.g: ): Ubuntu 20.04 Kernel (e.g. ): Linux nodepool-- 5.4.0-1016-azure -Ubuntu SMP Thu Jun 4 22:49:15 UTC 2020 x8664 x8664 x86_64 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig storage /cc /cc\nlog After debugging with and offline, the issue is that: After the dir from the subpath was removed, the subpath mountpoint on the host machine becomes into a weird state where you can still find the dir by doing a readdir to its parent. But doing or something like that will result in a \"No such file or directory\". When you do a ls on the path:\n/triage accepted\nSo the issue from code is that It will fail the path exists check while the actual mountpoint exists. So when the code logic runs to here: It will fail to remove the container dir because it somehow detect there is still file there. To fix this as a workaround, user can manually , and then the kubelet can take care of this. To fix it ultimately, we need to see if this is an issue specific to cifs filesystem? Or we should consider do an umount regardless if the path exists.\n/assign\n/assign\nTried the same scenario using NFS. It works as expected using NFS.\nYeah, that's why I am wondering if this is something special with CIFS?\nLooks like it has something to do with the azurefile-csi storage class mount options. I was getting the below error when I was trying to do ls on the subpath. So I realized there might be some issue with the file permissions. root ls ls: cannot open directory '.': No such file or directory When I removed the dirmode and filemode properties from the storageclass and performed the same steps as mentioned in the issue, the pod got deleted successfully.(Although it took a lot of time 10-15 mins for the pod to get deleted)\nFYI, I am planning to use this PR to fix the unmount issue in Azure File & SMB CSI driver: Not sure how to handle gracefully in k8s subPath code since that's common code.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nSo this PR does not fix the Azurefile subpath test issue?\nno, that PR only fixed the unmount issue inside CSI driver. While for the subPath issue, we should fix it in k8s upstream code as you mentioned above:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nback to original discussion, shall we use instead of inside func? That will solve the issue of smb file PathExists check issue.\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Reopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /close [1]:\nClosing this issue. <detailsIn response to : The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closedReopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Reopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /close [1]:\nClosing this issue. <detailsIn response to : The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closedReopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nthis subPath issue was fixed in , ,", "positive_passages": [{"docid": "doc-en-kubernetes-bf2450c591d634a4bc0fd48fadc504018104465a2b65253d0c17024a0df2289a", "text": "deletedDir := fmt.Sprintf(\"%s040(deleted)\", dir) return ((mp.Path == dir) || (mp.Path == deletedDir)) } <ins> // PathExists returns true if the specified path exists. // TODO: clean this up to use pkg/util/file/FileExists func PathExists(path string) (bool, error) { _, err := os.Stat(path) if err == nil { return true, nil } else if errors.Is(err, fs.ErrNotExist) { err = syscall.Access(path, syscall.F_OK) if err == nil { // The access syscall says the file exists, the stat syscall says it // doesn't. This was observed on CIFS when the path was removed at // the server somehow. POSIX calls this a stale file handle, let's fake // that error and treat the path as existing but corrupted. klog.Warningf(\"Potential stale file handle detected: %s\", path) return true, syscall.ESTALE } return false, nil } else if IsCorruptedMnt(err) { return true, err } return false, err } </ins>", "commid": "kubernetes_pr_106906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ccdb74dbd9ebc4bd41922c370ab977e3c1e001639e0c07715bc14f84fc8b75bc", "query": "What happened: I was running the subpath testsuite against Azurefile. This test failed and can be easily reproduced: Basically what this test does is: a PVC use azurefile a pod that has two containers. One of it mounts the volume itself. The second container mounts the subpath of the volume. the subpath dir from the container that has the whole volume the pod, the pod will stuck in terminating status and cannot be cleaned up other than What you expected to happen: The pod can be deleted successfully. How to reproduce it (as minimally and precisely as possible): the pvc the pod the subpath dir from the parent pod the pod Anything else we need to know?: The volume is being formatted as cifs type Environment: Kubernetes version (use ): v1.18.6 Cloud provider or hardware configuration: Azurefile-csi-driver 0.9.0 OS (e.g: ): Ubuntu 20.04 Kernel (e.g. ): Linux nodepool-- 5.4.0-1016-azure -Ubuntu SMP Thu Jun 4 22:49:15 UTC 2020 x8664 x8664 x86_64 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig storage /cc /cc\nlog After debugging with and offline, the issue is that: After the dir from the subpath was removed, the subpath mountpoint on the host machine becomes into a weird state where you can still find the dir by doing a readdir to its parent. But doing or something like that will result in a \"No such file or directory\". When you do a ls on the path:\n/triage accepted\nSo the issue from code is that It will fail the path exists check while the actual mountpoint exists. So when the code logic runs to here: It will fail to remove the container dir because it somehow detect there is still file there. To fix this as a workaround, user can manually , and then the kubelet can take care of this. To fix it ultimately, we need to see if this is an issue specific to cifs filesystem? Or we should consider do an umount regardless if the path exists.\n/assign\n/assign\nTried the same scenario using NFS. It works as expected using NFS.\nYeah, that's why I am wondering if this is something special with CIFS?\nLooks like it has something to do with the azurefile-csi storage class mount options. I was getting the below error when I was trying to do ls on the subpath. So I realized there might be some issue with the file permissions. root ls ls: cannot open directory '.': No such file or directory When I removed the dirmode and filemode properties from the storageclass and performed the same steps as mentioned in the issue, the pod got deleted successfully.(Although it took a lot of time 10-15 mins for the pod to get deleted)\nFYI, I am planning to use this PR to fix the unmount issue in Azure File & SMB CSI driver: Not sure how to handle gracefully in k8s subPath code since that's common code.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nSo this PR does not fix the Azurefile subpath test issue?\nno, that PR only fixed the unmount issue inside CSI driver. While for the subPath issue, we should fix it in k8s upstream code as you mentioned above:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nback to original discussion, shall we use instead of inside func? That will solve the issue of smb file PathExists check issue.\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Reopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /close [1]:\nClosing this issue. <detailsIn response to : The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closedReopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Reopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /close [1]:\nClosing this issue. <detailsIn response to : The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closedReopen this issue or PR with Mark this issue or PR as fresh with Offer to help out with [Issue Triage][1] Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nthis subPath issue was fixed in , ,", "positive_passages": [{"docid": "doc-en-kubernetes-38301c467e8e59bddaac6857fe5b586629be238c609d05fe2e6d99338529f3d7", "text": "func isMountPointMatch(mp MountPoint, dir string) bool { return mp.Path == dir } <ins> // PathExists returns true if the specified path exists. // TODO: clean this up to use pkg/util/file/FileExists func PathExists(path string) (bool, error) { _, err := os.Stat(path) if err == nil { return true, nil } else if os.IsNotExist(err) { return false, nil } else if IsCorruptedMnt(err) { return true, err } return false, err } </ins>", "commid": "kubernetes_pr_106906"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-181aae799cc8ee94e98a4ca4ae02cf540a79a602ea6edbc2b4ddfec20f7725f2", "query": "What happened: Adding a VolumeMount to a container with a multi-part subpath results in only the leaf directory having 777 permissions. If you define e.g. then within the volume, and will have permissions, whereas will have permissions. This means that if you want to remove and eventually from within a pod, you will need to use a privileged pod. If the sub-directories already exist, their permissions are unchanged, and the order in which these subpaths are created appears to be the order in which they appear within the spec -- if we see first, then will be created with 755 permissions and will be created with 777 permissions, even if there's another volumeMount for further down. What you expected to happen: Sub-directories created to support a volumeMount should all have the same permissions as the leaf directory. How to reproduce it (as minimally and precisely as possible): the yaml below. The first example has volume mounts so that is created before ; the second example has volume mounts in reversed order, so is encountered before , which results in being unwritable. <details<summaryThis pod will complete</summary</details<details<summaryThis pod will fail</summary</detailsAnything else we need to know?: I believe this is the return of Environment: Reproduces on minikube and a (OpenShift) development cluster I have access to Kubernetes version (use ): minikube: OpenShift cluster: output: Cloud provider or hardware configuration: Minikube: v1.15.1; docker driver; hostpath volumes (all default) OpenShift cluster: AWS, EBS volumes OS (e.g: ): Minikube: Fedora 32 OpenShift cluster: RHEL 8.2 Kernel (e.g. ): Minikube: OpenShift cluster: Install tools: minikube v1.15.1 / Not sure Network plugin and version (if this is a network-related bug): N/A Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/assign\nGitHub didn't allow me to assign the following users: mengjiao-liu. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-10dcc33eb27f5a19af28b0257cc33a8229a063a9f5daf525f6d8148e87ad1e61", "text": "} parentFD = childFD childFD = -1 <del> } // Everything was created. mkdirat(..., perm) above was affected by current // umask and we must apply the right permissions to the last directory // (that's the one that will be available to the container as subpath) // so user can read/write it. This is the behavior of previous code. // TODO: chmod all created directories, not just the last one. // parentFD is the last created directory. </del> <ins> // Everything was created. mkdirat(..., perm) above was affected by current // umask and we must apply the right permissions to the all created directory. // (that's the one that will be available to the container as subpath) // so user can read/write it. // parentFD is the last created directory. </ins> <del> // Translate perm (os.FileMode) to uint32 that fchmod() expects kernelPerm := uint32(perm & os.ModePerm) if perm&os.ModeSetgid > 0 { kernelPerm |= syscall.S_ISGID } if perm&os.ModeSetuid > 0 { kernelPerm |= syscall.S_ISUID } if perm&os.ModeSticky > 0 { kernelPerm |= syscall.S_ISVTX } if err = syscall.Fchmod(parentFD, kernelPerm); err != nil { return fmt.Errorf(\"chmod %q failed: %s\", currentPath, err) </del> <ins> // Translate perm (os.FileMode) to uint32 that fchmod() expects kernelPerm := uint32(perm & os.ModePerm) if perm&os.ModeSetgid > 0 { kernelPerm |= syscall.S_ISGID } if perm&os.ModeSetuid > 0 { kernelPerm |= syscall.S_ISUID } if perm&os.ModeSticky > 0 { kernelPerm |= syscall.S_ISVTX } if err = syscall.Fchmod(parentFD, kernelPerm); err != nil { return fmt.Errorf(\"chmod %q failed: %s\", currentPath, err) } </ins> } return nil }", "commid": "kubernetes_pr_98717"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-181aae799cc8ee94e98a4ca4ae02cf540a79a602ea6edbc2b4ddfec20f7725f2", "query": "What happened: Adding a VolumeMount to a container with a multi-part subpath results in only the leaf directory having 777 permissions. If you define e.g. then within the volume, and will have permissions, whereas will have permissions. This means that if you want to remove and eventually from within a pod, you will need to use a privileged pod. If the sub-directories already exist, their permissions are unchanged, and the order in which these subpaths are created appears to be the order in which they appear within the spec -- if we see first, then will be created with 755 permissions and will be created with 777 permissions, even if there's another volumeMount for further down. What you expected to happen: Sub-directories created to support a volumeMount should all have the same permissions as the leaf directory. How to reproduce it (as minimally and precisely as possible): the yaml below. The first example has volume mounts so that is created before ; the second example has volume mounts in reversed order, so is encountered before , which results in being unwritable. <details<summaryThis pod will complete</summary</details<details<summaryThis pod will fail</summary</detailsAnything else we need to know?: I believe this is the return of Environment: Reproduces on minikube and a (OpenShift) development cluster I have access to Kubernetes version (use ): minikube: OpenShift cluster: output: Cloud provider or hardware configuration: Minikube: v1.15.1; docker driver; hostpath volumes (all default) OpenShift cluster: AWS, EBS volumes OS (e.g: ): Minikube: Fedora 32 OpenShift cluster: RHEL 8.2 Kernel (e.g. ): Minikube: OpenShift cluster: Install tools: minikube v1.15.1 / Not sure Network plugin and version (if this is a network-related bug): N/A Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/assign\nGitHub didn't allow me to assign the following users: mengjiao-liu. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-31ef9545a786e531bc7ef7fce14bf30ffe1030526c3bdfcd8bad3c0b550c223b", "text": "func TestSafeMakeDir(t *testing.T) { defaultPerm := os.FileMode(0750) + os.ModeDir <ins> maxPerm := os.FileMode(0777) + os.ModeDir </ins> tests := []struct { name string // Function that prepares directory structure for the test under given", "commid": "kubernetes_pr_98717"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-181aae799cc8ee94e98a4ca4ae02cf540a79a602ea6edbc2b4ddfec20f7725f2", "query": "What happened: Adding a VolumeMount to a container with a multi-part subpath results in only the leaf directory having 777 permissions. If you define e.g. then within the volume, and will have permissions, whereas will have permissions. This means that if you want to remove and eventually from within a pod, you will need to use a privileged pod. If the sub-directories already exist, their permissions are unchanged, and the order in which these subpaths are created appears to be the order in which they appear within the spec -- if we see first, then will be created with 755 permissions and will be created with 777 permissions, even if there's another volumeMount for further down. What you expected to happen: Sub-directories created to support a volumeMount should all have the same permissions as the leaf directory. How to reproduce it (as minimally and precisely as possible): the yaml below. The first example has volume mounts so that is created before ; the second example has volume mounts in reversed order, so is encountered before , which results in being unwritable. <details<summaryThis pod will complete</summary</details<details<summaryThis pod will fail</summary</detailsAnything else we need to know?: I believe this is the return of Environment: Reproduces on minikube and a (OpenShift) development cluster I have access to Kubernetes version (use ): minikube: OpenShift cluster: output: Cloud provider or hardware configuration: Minikube: v1.15.1; docker driver; hostpath volumes (all default) OpenShift cluster: AWS, EBS volumes OS (e.g: ): Minikube: Fedora 32 OpenShift cluster: RHEL 8.2 Kernel (e.g. ): Minikube: OpenShift cluster: Install tools: minikube v1.15.1 / Not sure Network plugin and version (if this is a network-related bug): N/A Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/assign\nGitHub didn't allow me to assign the following users: mengjiao-liu. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-f6428e1588a7bfa56bc58dd0985bfabefaca4d8ad493c8548ad0d13c48d978f2", "text": "false, }, { <ins> \"all-created-subpath-directory-with-permissions\", func(base string) error { return nil }, \"test/directory\", \"test\", maxPerm, false, }, { </ins> \"directory-with-sgid\", func(base string) error { return nil", "commid": "kubernetes_pr_98717"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-374a80502f6b8859498039c88f587dc8f22c2abb9974a05e714dfd17aa2252f6", "query": "In reference to conversation on #sig-network-policy-api.  What would you like to be : Add a test to the netpol validation framework to validate a scenario where traffic between two pods has egress and ingress rules defined. Why is this needed: To ensure consistent behavior between different implementations of networkPolicy. For example, describes different behavior between Calico networkPolicy and Azure networkPolicy\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig sig-network\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /sig sig-network Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network\nthanks for offering to hack on this\n/sig network\ncc\nI reviewed the current networkpolicy tests, and I believe this case is already captured in the currents tests.\nThanks for digging into this ... so Your case, yesterday was more then just combining egress and ingress. Your case , was one where Egress blocked a traffic that was allowed by other rules. Which is quite interesting and confuses alot of people. ... It highlights the 'podselector centric' nature of policies.... I think you want to do , right? In that case, Egress rule is specifically created that disallows but Ingress rules explicitly allow And the result is that Egress wins, and traffic is blocked ...\nThis is an interesting test case, I'd be happy to hack on this and look at adding a table-driven netpol test case but don't want to step on your toes if you're already looking into ! Definitely see the value of illuminating this corner case with a clear test scenario!\nThx for the feedback. You are right that it's still a different case. : I'm looking at what I can throw together today. Stay tuned, and would love your input.\nI created the initial version of the test.  The code (and comments) are likely a bit verbose at this point. Should I open a PR against this repo now, or do you want me to make changes to that code prior to the PR?\nLooks awesome, I'd go ahead with the PR!\ncan you reference this issue in your new PR ?\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-e7934ef5eadbab9f9295fd6601acf6989e5fa45c0f6864cee5aaed19d7f5979d", "text": "ValidateOrFail(k8s, model, &TestCase{FromPort: 81, ToPort: 81, Protocol: v1.ProtocolTCP, Reachability: reachabilityPort81}) }) <ins> ginkgo.It(\"should support denying of egress traffic on the client side (even if the server explicitly allows this traffic) [Feature:NetworkPolicy]\", func() { // x/a --> y/a and y/b // Egress allowed to y/a only. Egress to y/b should be blocked // Ingress on y/a and y/b allow traffic from x/a // Expectation: traffic from x/a to y/a allowed only, traffic from x/a to y/b denied by egress policy nsX, nsY, _, model, k8s := getK8SModel(f) // Building egress policy for x/a to y/a only allowedEgressNamespaces := &metav1.LabelSelector{ MatchLabels: map[string]string{ \"ns\": nsY, }, } allowedEgressPods := &metav1.LabelSelector{ MatchLabels: map[string]string{ \"pod\": \"a\", }, } egressPolicy := GetAllowEgressByNamespaceAndPod(\"allow-to-ns-y-pod-a\", map[string]string{\"pod\": \"a\"}, allowedEgressNamespaces, allowedEgressPods) CreatePolicy(k8s, egressPolicy, nsX) // Creating ingress policy to allow from x/a to y/a and y/b allowedIngressNamespaces := &metav1.LabelSelector{ MatchLabels: map[string]string{ \"ns\": nsX, }, } allowedIngressPods := &metav1.LabelSelector{ MatchLabels: map[string]string{ \"pod\": \"a\", }, } allowIngressPolicyPodA := GetAllowIngressByNamespaceAndPod(\"allow-from-xa-on-ya-match-selector\", map[string]string{\"pod\": \"a\"}, allowedIngressNamespaces, allowedIngressPods) allowIngressPolicyPodB := GetAllowIngressByNamespaceAndPod(\"allow-from-xa-on-yb-match-selector\", map[string]string{\"pod\": \"b\"}, allowedIngressNamespaces, allowedIngressPods) CreatePolicy(k8s, allowIngressPolicyPodA, nsY) CreatePolicy(k8s, allowIngressPolicyPodB, nsY) // While applying the policies, traffic needs to be allowed by both egress and ingress rules. // Egress rules only // \txa\txb\txc\tya\tyb\tyc\tza\tzb\tzc // xa\tX\tX\tX\t.\t*X*\tX\tX\tX\tX // xb\t.\t.\t.\t.\t.\t.\t.\t.\t. // xc\t.\t.\t.\t.\t.\t.\t.\t.\t. // ya\t.\t.\t.\t.\t.\t.\t.\t.\t. // yb\t.\t.\t.\t.\t.\t.\t.\t.\t. // yc\t.\t.\t.\t.\t.\t.\t.\t.\t. // za\t.\t.\t.\t.\t.\t.\t.\t.\t. // zb\t.\t.\t.\t.\t.\t.\t.\t.\t. // zc\t.\t.\t.\t.\t.\t.\t.\t.\t. // Ingress rules only // \txa\txb\txc\tya\tyb\tyc\tza\tzb\tzc // xa\t.\t.\t.\t*.*\t.\t.\t.\t.\t. // xb\t.\t.\tX\tX\t.\t.\t.\t.\t. // xc\t.\t.\tX\tX\t.\t.\t.\t.\t. // ya\t.\t.\tX\tX\t.\t.\t.\t.\t. // yb\t.\t.\tX\tX\t.\t.\t.\t.\t. // yc\t.\t.\tX\tX\t.\t.\t.\t.\t. // za\t.\t.\tX\tX\t.\t.\t.\t.\t. // zb\t.\t.\tX\tX\t.\t.\t.\t.\t. // zc\t.\t.\tX\tX\t.\t.\t.\t.\t. // In the resulting truth table, connections from x/a should only be allowed to y/a. x/a to y/b should be blocked by the egress on x/a. // Expected results // \txa\txb\txc\tya\tyb\tyc\tza\tzb\tzc // xa\tX\tX\tX\t.\t*X*\tX\tX\tX\tX // xb\t.\t.\t.\tX\tX\t.\t.\t.\t. // xc\t.\t.\t.\tX\tX\t.\t.\t.\t. // ya\t.\t.\t.\tX\tX\t.\t.\t.\t. // yb\t.\t.\t.\tX\tX\t.\t.\t.\t. // yc\t.\t.\t.\tX\tX\t.\t.\t.\t. // za\t.\t.\t.\tX\tX\t.\t.\t.\t. // zb\t.\t.\t.\tX\tX\t.\t.\t.\t. // zc\t.\t.\t.\tX\tX\t.\t.\t.\t. reachability := NewReachability(model.AllPods(), true) // Default all traffic flows. // Exception: x/a can only egress to y/a, others are false // Exception: y/a can only allow ingress from x/a, others are false // Exception: y/b has no allowed traffic (due to limit on x/a egress) reachability.ExpectPeer(&Peer{Namespace: nsX, Pod: \"a\"}, &Peer{}, false) reachability.ExpectPeer(&Peer{}, &Peer{Namespace: nsY, Pod: \"a\"}, false) reachability.ExpectPeer(&Peer{Namespace: nsX, Pod: \"a\"}, &Peer{Namespace: nsY, Pod: \"a\"}, true) reachability.ExpectPeer(&Peer{}, &Peer{Namespace: nsY, Pod: \"b\"}, false) ValidateOrFail(k8s, model, &TestCase{FromPort: 81, ToPort: 80, Protocol: v1.ProtocolTCP, Reachability: reachability}) }) </ins> ginkgo.It(\"should enforce egress policy allowing traffic to a server in a different namespace based on PodSelector and NamespaceSelector [Feature:NetworkPolicy]\", func() { nsX, nsY, _, model, k8s := getK8SModel(f) allowedNamespaces := &metav1.LabelSelector{", "commid": "kubernetes_pr_97524"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b7e5bceb9e558da9f3a941788a29989a1d233b0b46f0b77ff1f2e63e703dc964", "query": "We could either: where appropriate - least amount of code change but cumbersome OS version in the tag instead of the repository /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows\n/kind bug", "positive_passages": [{"docid": "doc-en-kubernetes-e6067591872630dbb5a04be38754512fc6afa9fe34f3b60fd9e51033a854ac59", "text": "REGISTRY ?= staging-k8s.gcr.io IMAGE = $(REGISTRY)/pause <del> IMAGE_WITH_OS_ARCH = $(IMAGE)-$(OS)-$(ARCH) TAG = 3.4 </del> <ins> TAG = 3.4.1 </ins> REV = $(shell git describe --contains --always --match='v*') # Architectures supported: amd64, arm, arm64, ppc64le and s390x", "commid": "kubernetes_pr_97782"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b7e5bceb9e558da9f3a941788a29989a1d233b0b46f0b77ff1f2e63e703dc964", "query": "We could either: where appropriate - least amount of code change but cumbersome OS version in the tag instead of the repository /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows\n/kind bug", "positive_passages": [{"docid": "doc-en-kubernetes-1a27181ce8bcabc10cd8b884d1d599077cb3710cf103bcfba90de32d36958148", "text": "all-push: all-container-registry push-manifest push-manifest: <del> docker manifest create --amend $(IMAGE):$(TAG) $(shell echo $(ALL_OS_ARCH) | sed -e \"s~[^ ]*~$(IMAGE)-&:$(TAG)~g\") set -x; for arch in $(ALL_ARCH.linux); do docker manifest annotate --os linux --arch $${arch} ${IMAGE}:${TAG} ${IMAGE}-linux-$${arch}:${TAG}; done </del> <ins> docker manifest create --amend $(IMAGE):$(TAG) $(shell echo $(ALL_OS_ARCH) | sed -e \"s~[^ ]*~$(IMAGE):$(TAG)-&~g\") set -x; for arch in $(ALL_ARCH.linux); do docker manifest annotate --os linux --arch $${arch} ${IMAGE}:${TAG} ${IMAGE}:${TAG}-linux-$${arch}; done </ins> # For Windows images, we also need to include the \"os.version\" in the manifest list, so the Windows node can pull the proper image it needs. # At the moment, docker manifest annotate doesn't allow us to set the os.version, so we'll have to it ourselves. The manifest list can be found locally as JSONs. # See: https://github.com/moby/moby/issues/41417", "commid": "kubernetes_pr_97782"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b7e5bceb9e558da9f3a941788a29989a1d233b0b46f0b77ff1f2e63e703dc964", "query": "We could either: where appropriate - least amount of code change but cumbersome OS version in the tag instead of the repository /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows\n/kind bug", "positive_passages": [{"docid": "doc-en-kubernetes-6466db1a79003cb7cedbb76c5a5274111db4f0008e5bf13ad23b2b804f84f2eb", "text": "manifest_image_folder=`echo \"$${registry_prefix}${IMAGE}\" | sed \"s|/|_|g\" | sed \"s/:/-/\"`;  for arch in $(ALL_ARCH.windows);  do  for osversion in ${ALL_OSVERSIONS.windows}; do  <del> docker manifest annotate --os windows --arch $${arch} ${IMAGE}:${TAG} ${IMAGE}-windows-$${arch}-$${osversion}:${TAG};  </del> <ins> docker manifest annotate --os windows --arch $${arch} ${IMAGE}:${TAG} ${IMAGE}:${TAG}-windows-$${arch}-$${osversion};  </ins> BASEIMAGE=${BASE.windows}:$${osversion};  full_version=`docker manifest inspect ${BASE.windows}:$${osversion} | grep \"os.version\" | head -n 1 | awk '{print $$2}'` || true;  <del> sed -i -r \"s/(\"os\":\"windows\")/0,\"os.version\":$${full_version}/\" \"${HOME}/.docker/manifests/$${manifest_image_folder}-${TAG}/$${manifest_image_folder}-windows-$${arch}-$${osversion}-${TAG}\";  </del> <ins> sed -i -r \"s/(\"os\":\"windows\")/0,\"os.version\":$${full_version}/\" \"${HOME}/.docker/manifests/$${manifest_image_folder}-${TAG}/$${manifest_image_folder}-${TAG}-windows-$${arch}-$${osversion}\";  </ins> done;  done docker manifest push --purge ${IMAGE}:${TAG}", "commid": "kubernetes_pr_97782"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b7e5bceb9e558da9f3a941788a29989a1d233b0b46f0b77ff1f2e63e703dc964", "query": "We could either: where appropriate - least amount of code change but cumbersome OS version in the tag instead of the repository /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows\n/kind bug", "positive_passages": [{"docid": "doc-en-kubernetes-2f75e46c3fc4e4605b140fbf800a627ccd1f255facf14488b4dac200f7572a22", "text": "container: .container-${OS}-$(ARCH) .container-linux-$(ARCH): bin/$(BIN)-$(OS)-$(ARCH) docker buildx build --pull --output=type=${OUTPUT_TYPE} --platform ${OS}/$(ARCH)  <del> -t $(IMAGE_WITH_OS_ARCH):$(TAG) --build-arg BASE=${BASE} --build-arg ARCH=$(ARCH) . </del> <ins> -t $(IMAGE):$(TAG)-${OS}-$(ARCH) --build-arg BASE=${BASE} --build-arg ARCH=$(ARCH) . </ins> touch $@ .container-windows-$(ARCH): $(foreach binary, ${BIN}, bin/${binary}-${OS}-${ARCH}) docker buildx build --pull --output=type=${OUTPUT_TYPE} --platform ${OS}/$(ARCH)  <del> -t $(IMAGE_WITH_OS_ARCH)-${OSVERSION}:$(TAG) --build-arg BASE=${BASE}:${OSVERSION} --build-arg ARCH=$(ARCH) -f Dockerfile_windows . </del> <ins> -t $(IMAGE):$(TAG)-${OS}-$(ARCH)-${OSVERSION} --build-arg BASE=${BASE}:${OSVERSION} --build-arg ARCH=$(ARCH) -f Dockerfile_windows . </ins> touch $@ # Useful for testing, not automatically included in container image", "commid": "kubernetes_pr_97782"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e13a3765f3b220183700c97220ce5674ec114ad3ff68bc827eafde8e290c4a4e", "query": "[ ] two weeks soak start date : testgrid-link [ ] two weeks soak end date : [ ] test promotion pr : kubernetes/kubernetes#? According to this APIsnoop query, there are still some remaining StatefulsetScale endpoints that are untested. with this query, you can filter untested endpoints by their category and eligibility for conformance. e.g below shows a query to find all conformance eligible untested, stable, apps endpoints sql-mode select distinct endpoint, right(useragent,73) AS useragent from testing.auditevent -- where useragent ilike '%subresource%' where endpoint ilike '%AppsV1NamespacedStatefulSetScale%' and releasedate::BIGINT round(((EXTRACT(EPOCH FROM NOW()))::numeric)1000,0) - and useragent like 'e2e%' order by endpoint limit 30; example endpoint | useragent -----------------------------------------|--------------------------------------------------------------------------- patchAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] readAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] replaceAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] (3 rows) If a test with these calls gets merged, test coverage will go up by 1 point* This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-f860c6c560dcdb33a13ba631c255ba3daeedf941a07fc253a9871983eba50388", "text": "description: Create a StatefulSet resource. Newly created StatefulSet resource MUST have a scale of one. Bring the scale of the StatefulSet resource up to two. StatefulSet scale MUST be at two replicas. <del> release: v1.16 </del> <ins> release: v1.16, v1.21 </ins> file: test/e2e/apps/statefulset.go - testname: StatefulSet, Rolling Update with Partition codename: '[sig-apps] StatefulSet [k8s.io] Basic StatefulSet functionality [StatefulSetBasic]", "commid": "kubernetes_pr_98126"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e13a3765f3b220183700c97220ce5674ec114ad3ff68bc827eafde8e290c4a4e", "query": "[ ] two weeks soak start date : testgrid-link [ ] two weeks soak end date : [ ] test promotion pr : kubernetes/kubernetes#? According to this APIsnoop query, there are still some remaining StatefulsetScale endpoints that are untested. with this query, you can filter untested endpoints by their category and eligibility for conformance. e.g below shows a query to find all conformance eligible untested, stable, apps endpoints sql-mode select distinct endpoint, right(useragent,73) AS useragent from testing.auditevent -- where useragent ilike '%subresource%' where endpoint ilike '%AppsV1NamespacedStatefulSetScale%' and releasedate::BIGINT round(((EXTRACT(EPOCH FROM NOW()))::numeric)1000,0) - and useragent like 'e2e%' order by endpoint limit 30; example endpoint | useragent -----------------------------------------|--------------------------------------------------------------------------- patchAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] readAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] replaceAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] (3 rows) If a test with these calls gets merged, test coverage will go up by 1 point* This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-7fda540bd0d703609a9fdc95a7a4e4d787b0d9bc2561c6fec1e1a029ef380091", "text": "import ( \"context\" <ins> \"encoding/json\" </ins> \"fmt\" \"strings\" \"sync\"", "commid": "kubernetes_pr_98126"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e13a3765f3b220183700c97220ce5674ec114ad3ff68bc827eafde8e290c4a4e", "query": "[ ] two weeks soak start date : testgrid-link [ ] two weeks soak end date : [ ] test promotion pr : kubernetes/kubernetes#? According to this APIsnoop query, there are still some remaining StatefulsetScale endpoints that are untested. with this query, you can filter untested endpoints by their category and eligibility for conformance. e.g below shows a query to find all conformance eligible untested, stable, apps endpoints sql-mode select distinct endpoint, right(useragent,73) AS useragent from testing.auditevent -- where useragent ilike '%subresource%' where endpoint ilike '%AppsV1NamespacedStatefulSetScale%' and releasedate::BIGINT round(((EXTRACT(EPOCH FROM NOW()))::numeric)1000,0) - and useragent like 'e2e%' order by endpoint limit 30; example endpoint | useragent -----------------------------------------|--------------------------------------------------------------------------- patchAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] readAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] replaceAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] (3 rows) If a test with these calls gets merged, test coverage will go up by 1 point* This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-2d9c12829852a49465d3dd8e7d26ccaad413cfc2e79d05f9fefefedd74e5a822", "text": "\"github.com/onsi/gomega\" appsv1 \"k8s.io/api/apps/v1\" <ins> autoscalingv1 \"k8s.io/api/autoscaling/v1\" </ins> v1 \"k8s.io/api/core/v1\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/fields\"", "commid": "kubernetes_pr_98126"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e13a3765f3b220183700c97220ce5674ec114ad3ff68bc827eafde8e290c4a4e", "query": "[ ] two weeks soak start date : testgrid-link [ ] two weeks soak end date : [ ] test promotion pr : kubernetes/kubernetes#? According to this APIsnoop query, there are still some remaining StatefulsetScale endpoints that are untested. with this query, you can filter untested endpoints by their category and eligibility for conformance. e.g below shows a query to find all conformance eligible untested, stable, apps endpoints sql-mode select distinct endpoint, right(useragent,73) AS useragent from testing.auditevent -- where useragent ilike '%subresource%' where endpoint ilike '%AppsV1NamespacedStatefulSetScale%' and releasedate::BIGINT round(((EXTRACT(EPOCH FROM NOW()))::numeric)1000,0) - and useragent like 'e2e%' order by endpoint limit 30; example endpoint | useragent -----------------------------------------|--------------------------------------------------------------------------- patchAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] readAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] replaceAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] (3 rows) If a test with these calls gets merged, test coverage will go up by 1 point* This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-900e329b7d0e0c0989d866f858b1a4a12a1ca99375c9d28f9a9979e9dfb342c8", "text": "}) /* <del> Release: v1.16 </del> <ins> Release: v1.16, v1.21 </ins> Testname: StatefulSet resource Replica scaling Description: Create a StatefulSet resource. Newly created StatefulSet resource MUST have a scale of one.", "commid": "kubernetes_pr_98126"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e13a3765f3b220183700c97220ce5674ec114ad3ff68bc827eafde8e290c4a4e", "query": "[ ] two weeks soak start date : testgrid-link [ ] two weeks soak end date : [ ] test promotion pr : kubernetes/kubernetes#? According to this APIsnoop query, there are still some remaining StatefulsetScale endpoints that are untested. with this query, you can filter untested endpoints by their category and eligibility for conformance. e.g below shows a query to find all conformance eligible untested, stable, apps endpoints sql-mode select distinct endpoint, right(useragent,73) AS useragent from testing.auditevent -- where useragent ilike '%subresource%' where endpoint ilike '%AppsV1NamespacedStatefulSetScale%' and releasedate::BIGINT round(((EXTRACT(EPOCH FROM NOW()))::numeric)1000,0) - and useragent like 'e2e%' order by endpoint limit 30; example endpoint | useragent -----------------------------------------|--------------------------------------------------------------------------- patchAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] readAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] replaceAppsV1NamespacedStatefulSetScale | [StatefulSetBasic] should have a working scale subresource [Conformance] (3 rows) If a test with these calls gets merged, test coverage will go up by 1 point* This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-b8c6c6db3f30040287c89a4b45b532cada1c12debc7ec94f5231df5036085712", "text": "framework.Failf(\"Failed to get statefulset resource: %v\", err) } framework.ExpectEqual(*(ss.Spec.Replicas), int32(2)) <ins> ginkgo.By(\"Patch a scale subresource\") scale.ResourceVersion = \"\" // indicate the scale update should be unconditional scale.Spec.Replicas = 4    // should be 2 after \"UpdateScale\" operation, now Patch to 4 ssScalePatchPayload, err := json.Marshal(autoscalingv1.Scale{ Spec: autoscalingv1.ScaleSpec{ Replicas: scale.Spec.Replicas, }, }) framework.ExpectNoError(err, \"Could not Marshal JSON for patch payload\") _, err = c.AppsV1().StatefulSets(ns).Patch(context.TODO(), ssName, types.StrategicMergePatchType, []byte(ssScalePatchPayload), metav1.PatchOptions{}, \"scale\") framework.ExpectNoError(err, \"Failed to patch stateful set: %v\", err) ginkgo.By(\"verifying the statefulset Spec.Replicas was modified\") ss, err = c.AppsV1().StatefulSets(ns).Get(context.TODO(), ssName, metav1.GetOptions{}) framework.ExpectNoError(err, \"Failed to get statefulset resource: %v\", err) framework.ExpectEqual(*(ss.Spec.Replicas), int32(4), \"statefulset should have 4 replicas\") </ins> }) })", "commid": "kubernetes_pr_98126"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-444fa5b2edd377b73e5bc84b27cebb7f3765c55163f585dc8d441d2a1c256789", "query": "What happened: with --cpu-manager-policy=static kubelet will panic when pause container lose during kubelet restarting What you expected to happen: kubelet can start normally How to reproduce it (as minimally and precisely as possible): 1,config kubelet with --cpu-manager-policy=static 2, Run a large number of pods on the test node 3,stop kubelet use command: 4,kill and remove all the pause container like this: ! 5,start kubelet use command: and then kubelet maybe panic, log is : Anything else we need to know?: When we actually encountered this problem, only one pause container was lost. In order to reproduce this bug, I deleted all pause containers. Environment: Kubernetes version (use ): 1.20.1 Cloud provider or hardware configuration: x8664 OS (e.g: ):18.04.5 LTS (Bionic Beaver) Kernel (e.g. ): Linux ecs-linux-0008-43ee 4.15.0-123-generic -Ubuntu SMP Wed Oct 21 09:40:11 UTC 2020 x8664 x8664 x8664 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node /assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-contributor-experience at . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI think it makes sense to reopen this issue as the referenced PR is still open.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-lifecycle rotten\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nI am seeing this issue with a customer also. What is the timeline for this PR to be reviewed and merged?", "positive_passages": [{"docid": "doc-en-kubernetes-f9d36f2b580349bd706c86df4afb2f7145d7314cb1ce61a1c3538d570135adc1", "text": "// Initialize CPU manager if utilfeature.DefaultFeatureGate.Enabled(kubefeatures.CPUManager) { <del> containerMap, err := buildContainerMapFromRuntime(runtimeService) if err != nil { return fmt.Errorf(\"failed to build map of initial containers from runtime: %v\", err) } err = cm.cpuManager.Start(cpumanager.ActivePodsFunc(activePods), sourcesReady, podStatusProvider, runtimeService, containerMap) </del> <ins> containerMap := buildContainerMapFromRuntime(runtimeService) err := cm.cpuManager.Start(cpumanager.ActivePodsFunc(activePods), sourcesReady, podStatusProvider, runtimeService, containerMap) </ins> if err != nil { return fmt.Errorf(\"start cpu manager error: %v\", err) }", "commid": "kubernetes_pr_108325"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-444fa5b2edd377b73e5bc84b27cebb7f3765c55163f585dc8d441d2a1c256789", "query": "What happened: with --cpu-manager-policy=static kubelet will panic when pause container lose during kubelet restarting What you expected to happen: kubelet can start normally How to reproduce it (as minimally and precisely as possible): 1,config kubelet with --cpu-manager-policy=static 2, Run a large number of pods on the test node 3,stop kubelet use command: 4,kill and remove all the pause container like this: ! 5,start kubelet use command: and then kubelet maybe panic, log is : Anything else we need to know?: When we actually encountered this problem, only one pause container was lost. In order to reproduce this bug, I deleted all pause containers. Environment: Kubernetes version (use ): 1.20.1 Cloud provider or hardware configuration: x8664 OS (e.g: ):18.04.5 LTS (Bionic Beaver) Kernel (e.g. ): Linux ecs-linux-0008-43ee 4.15.0-123-generic -Ubuntu SMP Wed Oct 21 09:40:11 UTC 2020 x8664 x8664 x8664 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node /assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-contributor-experience at . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI think it makes sense to reopen this issue as the referenced PR is still open.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-lifecycle rotten\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nI am seeing this issue with a customer also. What is the timeline for this PR to be reviewed and merged?", "positive_passages": [{"docid": "doc-en-kubernetes-39c680af728bf7303a666067244cfa3046879a011009dbc0dd954838f172d759", "text": "// Initialize memory manager if utilfeature.DefaultFeatureGate.Enabled(kubefeatures.MemoryManager) { <del> containerMap, err := buildContainerMapFromRuntime(runtimeService) if err != nil { return fmt.Errorf(\"failed to build map of initial containers from runtime: %v\", err) } err = cm.memoryManager.Start(memorymanager.ActivePodsFunc(activePods), sourcesReady, podStatusProvider, runtimeService, containerMap) </del> <ins> containerMap := buildContainerMapFromRuntime(runtimeService) err := cm.memoryManager.Start(memorymanager.ActivePodsFunc(activePods), sourcesReady, podStatusProvider, runtimeService, containerMap) </ins> if err != nil { return fmt.Errorf(\"start memory manager error: %v\", err) }", "commid": "kubernetes_pr_108325"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-444fa5b2edd377b73e5bc84b27cebb7f3765c55163f585dc8d441d2a1c256789", "query": "What happened: with --cpu-manager-policy=static kubelet will panic when pause container lose during kubelet restarting What you expected to happen: kubelet can start normally How to reproduce it (as minimally and precisely as possible): 1,config kubelet with --cpu-manager-policy=static 2, Run a large number of pods on the test node 3,stop kubelet use command: 4,kill and remove all the pause container like this: ! 5,start kubelet use command: and then kubelet maybe panic, log is : Anything else we need to know?: When we actually encountered this problem, only one pause container was lost. In order to reproduce this bug, I deleted all pause containers. Environment: Kubernetes version (use ): 1.20.1 Cloud provider or hardware configuration: x8664 OS (e.g: ):18.04.5 LTS (Bionic Beaver) Kernel (e.g. ): Linux ecs-linux-0008-43ee 4.15.0-123-generic -Ubuntu SMP Wed Oct 21 09:40:11 UTC 2020 x8664 x8664 x8664 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node /assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-contributor-experience at . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI think it makes sense to reopen this issue as the referenced PR is still open.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-lifecycle rotten\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nI am seeing this issue with a customer also. What is the timeline for this PR to be reviewed and merged?", "positive_passages": [{"docid": "doc-en-kubernetes-5998c5b703858219c4e15088ee5be6086da32e7d27e9b72edb290426616e122c", "text": "} } <del> func buildContainerMapFromRuntime(runtimeService internalapi.RuntimeService) (containermap.ContainerMap, error) { </del> <ins> func buildContainerMapFromRuntime(runtimeService internalapi.RuntimeService) containermap.ContainerMap { </ins> podSandboxMap := make(map[string]string) podSandboxList, _ := runtimeService.ListPodSandbox(nil) for _, p := range podSandboxList {", "commid": "kubernetes_pr_108325"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-444fa5b2edd377b73e5bc84b27cebb7f3765c55163f585dc8d441d2a1c256789", "query": "What happened: with --cpu-manager-policy=static kubelet will panic when pause container lose during kubelet restarting What you expected to happen: kubelet can start normally How to reproduce it (as minimally and precisely as possible): 1,config kubelet with --cpu-manager-policy=static 2, Run a large number of pods on the test node 3,stop kubelet use command: 4,kill and remove all the pause container like this: ! 5,start kubelet use command: and then kubelet maybe panic, log is : Anything else we need to know?: When we actually encountered this problem, only one pause container was lost. In order to reproduce this bug, I deleted all pause containers. Environment: Kubernetes version (use ): 1.20.1 Cloud provider or hardware configuration: x8664 OS (e.g: ):18.04.5 LTS (Bionic Beaver) Kernel (e.g. ): Linux ecs-linux-0008-43ee 4.15.0-123-generic -Ubuntu SMP Wed Oct 21 09:40:11 UTC 2020 x8664 x8664 x8664 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node /assign\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\nStale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle rotten\nRotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-contributor-experience at . /close\nClosing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI think it makes sense to reopen this issue as the referenced PR is still open.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-lifecycle rotten\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nI am seeing this issue with a customer also. What is the timeline for this PR to be reviewed and merged?", "positive_passages": [{"docid": "doc-en-kubernetes-f89229e84df458218cd833a7cd75eb300245bac17e86b5773f2e1e6088a249e0", "text": "containerList, _ := runtimeService.ListContainers(nil) for _, c := range containerList { if _, exists := podSandboxMap[c.PodSandboxId]; !exists { <del> return nil, fmt.Errorf(\"no PodsandBox found with Id '%s' for container with ID '%s' and Name '%s'\", c.PodSandboxId, c.Id, c.Metadata.Name) </del> <ins> klog.InfoS(\"no PodSandBox found for the container\", \"podSandboxId\", c.PodSandboxId, \"containerName\", c.Metadata.Name, \"containerId\", c.Id) continue </ins> } containerMap.Add(podSandboxMap[c.PodSandboxId], c.Metadata.Name, c.Id) } <del> return containerMap, nil </del> <ins> return containerMap </ins> } func isProcessRunningInHost(pid int) (bool, error) {", "commid": "kubernetes_pr_108325"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ee0826757468ea334f95c77509b257c3d392b6713b4311ba7afa125d642dcec9", "query": "The based container images for are shipped with the wrong architecture within the manifest if not amd64: Refers to We updated the images a few minutes ago to buster-v1.3.0, which are now ready to be used as base for the multi-architecture images. If the images contain the right architectures, then it may magically happen that the kube-proxy images are fixed, too. This is because we already use the build syntax for it: /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-fd22047972ce572eb059f1c19db7b9072555918440d247d8f5829932cb870413", "text": "# # $1 - server architecture kube::build::get_docker_wrapped_binaries() { <del> local debian_iptables_version=buster-v1.4.0 </del> <ins> local debian_iptables_version=buster-v1.5.0 </ins> local go_runner_version=buster-v2.2.4 ### If you change any of these lists, please also update DOCKERIZED_BINARIES ### in build/BUILD. And kube::golang::server_image_targets", "commid": "kubernetes_pr_98526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ee0826757468ea334f95c77509b257c3d392b6713b4311ba7afa125d642dcec9", "query": "The based container images for are shipped with the wrong architecture within the manifest if not amd64: Refers to We updated the images a few minutes ago to buster-v1.3.0, which are now ready to be used as base for the multi-architecture images. If the images contain the right architectures, then it may magically happen that the kube-proxy images are fixed, too. This is because we already use the build syntax for it: /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-b801831883f01477a39d432c9e77dc4213e98ee0bdf60355e9f382018e89fd93", "text": "# Base images - name: \"k8s.gcr.io/debian-base: dependents\" <del> version: buster-v1.3.0 </del> <ins> version: buster-v1.4.0 </ins> refPaths: - path: build/workspace.bzl match: tag =", "commid": "kubernetes_pr_98526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ee0826757468ea334f95c77509b257c3d392b6713b4311ba7afa125d642dcec9", "query": "The based container images for are shipped with the wrong architecture within the manifest if not amd64: Refers to We updated the images a few minutes ago to buster-v1.3.0, which are now ready to be used as base for the multi-architecture images. If the images contain the right architectures, then it may magically happen that the kube-proxy images are fixed, too. This is because we already use the build syntax for it: /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-5f2fb841329d3cccb57bb3ba72f0a542792802bf1f1c84cc3829c59e5488753f", "text": "match: BASEIMAGE?=k8s.gcr.io/build-image/debian-base-s390x:[a-zA-Z]+-v((([0-9]+).([0-9]+).([0-9]+)(?:-([0-9a-zA-Z-]+(?:.[0-9a-zA-Z-]+)*))?)(?:+([0-9a-zA-Z-]+(?:.[0-9a-zA-Z-]+)*))?) - name: \"k8s.gcr.io/debian-iptables: dependents\" <del> version: buster-v1.4.0 </del> <ins> version: buster-v1.5.0 </ins> refPaths: - path: build/common.sh match: debian_iptables_version=", "commid": "kubernetes_pr_98526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ee0826757468ea334f95c77509b257c3d392b6713b4311ba7afa125d642dcec9", "query": "The based container images for are shipped with the wrong architecture within the manifest if not amd64: Refers to We updated the images a few minutes ago to buster-v1.3.0, which are now ready to be used as base for the multi-architecture images. If the images contain the right architectures, then it may magically happen that the kube-proxy images are fixed, too. This is because we already use the build syntax for it: /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-acc4196190eea24ea44133d74f1897487191bf3099e4a941a823dfe8a63b45f2", "text": "# Use skopeo to find these values: https://github.com/containers/skopeo # # Example <del> # Manifest: skopeo inspect docker://gcr.io/k8s-staging-build-image/debian-base:buster-v1.3.0 # Arches: skopeo inspect --raw docker://gcr.io/k8s-staging-build-image/debian-base:buster-v1.3.0 </del> <ins> # Manifest: skopeo inspect docker://gcr.io/k8s-staging-build-image/debian-base:buster-v1.4.0 # Arches: skopeo inspect --raw docker://gcr.io/k8s-staging-build-image/debian-base:buster-v1.4.0 </ins> _DEBIAN_BASE_DIGEST = { <del> \"manifest\": \"sha256:d66137c7c362d1026dca670d1ff4c25e5b0770e8ace87ac3d008d52e4b0db338\", \"amd64\": \"sha256:a5ab028d9a730b78af9abb15b5db9b2e6f82448ab269d6f3a07d1834c571ccc6\", \"arm\": \"sha256:94e611363760607366ca1fed9375105b6c5fc922ab1249869b708690ca13733c\", \"arm64\": \"sha256:83512c52d44587271cd0f355c0a9a7e6c2412ddc66b8a8eb98f994277297a72f\", \"ppc64le\": \"sha256:9c8284b2797b114ebe8f3f1b2b5817a9c7f07f3f82513c49a30e6191a1acc1fc\", \"s390x\": \"sha256:d617637dd4df0bc1cfa524fae3b4892cfe57f7fec9402ad8dfa28e38e82ec688\", </del> <ins> \"manifest\": \"sha256:36652ef8e4dd6715de02e9b68e5c122ed8ee06c75f83f5c574b97301e794c3fb\", \"amd64\": \"sha256:afff10fcd513483e492807f8d934bdf0be4a237997f55e0f1f8e34c04a6cb213\", \"arm\": \"sha256:27e6e66ea3c4c4ca6dbfc8c949f0c4c870f038f4500fd267c242422a244f233c\", \"arm64\": \"sha256:4333a5edc9ce6d6660c76104749c2e50e6158e57c8e5956f732991bb032a8ce1\", \"ppc64le\": \"sha256:01a0ba2645883ea8d985460c2913070a90a098056cc6d188122942678923ddb7\", \"s390x\": \"sha256:610526b047d4b528d9e14b4f15347aa4e37af0c47e1307a2f7aebf8745c8a323\", </ins> } # Use skopeo to find these values: https://github.com/containers/skopeo # # Example <del> # Manifest: skopeo inspect docker://gcr.io/k8s-staging-build-image/debian-iptables:buster-v1.4.0 # Arches: skopeo inspect --raw docker://gcr.io/k8s-staging-build-image/debian-iptables:buster-v1.4.0 </del> <ins> # Manifest: skopeo inspect docker://gcr.io/k8s-staging-build-image/debian-iptables:buster-v1.5.0 # Arches: skopeo inspect --raw docker://gcr.io/k8s-staging-build-image/debian-iptables:buster-v1.5.0 </ins> _DEBIAN_IPTABLES_DIGEST = { <del> \"manifest\": \"sha256:87f97cf2b62eb107871ee810f204ccde41affb70b29883aa898e93df85dea0f0\", \"amd64\": \"sha256:da837f39cf3af78adb796c0caa9733449ae99e51cf624590c328e4c9951ace7a\", \"arm\": \"sha256:bb6677337a4dbc3e578a3e87642d99be740dea391dc5e8987f04211c5e23abcd\", \"arm64\": \"sha256:6ad4717d69db2cc47bc2efc91cebb96ba736be1de49e62e0deffdbaf0fa2318c\", \"ppc64le\": \"sha256:168ccfeb861239536826a26da24ab5f68bb5349d7439424b7008b01e8f6534fc\", \"s390x\": \"sha256:5a88d4f4c29bac5b5c93195059b928f7346be11d0f0f7f6da0e14c0bfdbd1362\", </del> <ins> \"manifest\": \"sha256:abe8cef9e116f2d5ec1175c386e33841ff3386779138b425af876384b0fd7ccb\", \"amd64\": \"sha256:b4b8b1e0d4617011dd03f20b804cc2e50bf48bafc36b1c8c7bd23fd44bfd641e\", \"arm\": \"sha256:09f79b3a00268705a8f8462f1528fed536e204905359f21e9965f08dd306c60a\", \"arm64\": \"sha256:b4fa11965f34a9f668c424b401c0af22e88f600d22c899699bdb0bd1e6953ad6\", \"ppc64le\": \"sha256:0ea0be4dec281b506f6ceef4cb3594cabea8d80e2dc0d93c7eb09d46259dd837\", \"s390x\": \"sha256:50ef25fba428b6002ef0a9dea7ceae5045430dc1035d50498a478eefccba17f5\", </ins> } # Use skopeo to find these values: https://github.com/containers/skopeo", "commid": "kubernetes_pr_98526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ee0826757468ea334f95c77509b257c3d392b6713b4311ba7afa125d642dcec9", "query": "The based container images for are shipped with the wrong architecture within the manifest if not amd64: Refers to We updated the images a few minutes ago to buster-v1.3.0, which are now ready to be used as base for the multi-architecture images. If the images contain the right architectures, then it may magically happen that the kube-proxy images are fixed, too. This is because we already use the build syntax for it: /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-92618f9008bfb67b8195de8208c30a4726f24c48504df0cd40f940aeab112be8", "text": "registry = \"k8s.gcr.io/build-image\", repository = \"debian-base\", # Ensure the digests above are updated to match a new tag <del> tag = \"buster-v1.3.0\",  # ignored, but kept here for documentation </del> <ins> tag = \"buster-v1.4.0\",  # ignored, but kept here for documentation </ins> ) container_pull(", "commid": "kubernetes_pr_98526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ee0826757468ea334f95c77509b257c3d392b6713b4311ba7afa125d642dcec9", "query": "The based container images for are shipped with the wrong architecture within the manifest if not amd64: Refers to We updated the images a few minutes ago to buster-v1.3.0, which are now ready to be used as base for the multi-architecture images. If the images contain the right architectures, then it may magically happen that the kube-proxy images are fixed, too. This is because we already use the build syntax for it: /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-dfa1f907939ed4f08b1d3a4a0f5678850ca45f6291ee7ef3472b32ac5adbf122", "text": "registry = \"k8s.gcr.io/build-image\", repository = \"debian-iptables\", # Ensure the digests above are updated to match a new tag <del> tag = \"buster-v1.4.0\",  # ignored, but kept here for documentation </del> <ins> tag = \"buster-v1.5.0\",  # ignored, but kept here for documentation </ins> ) def etcd_tarballs():", "commid": "kubernetes_pr_98526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ee0826757468ea334f95c77509b257c3d392b6713b4311ba7afa125d642dcec9", "query": "The based container images for are shipped with the wrong architecture within the manifest if not amd64: Refers to We updated the images a few minutes ago to buster-v1.3.0, which are now ready to be used as base for the multi-architecture images. If the images contain the right architectures, then it may magically happen that the kube-proxy images are fixed, too. This is because we already use the build syntax for it: /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-5c1cc06492bafc26d6777b37484b3d518c341f6ad9a09f3a800dc2adccfbc3b8", "text": "# REVISION provides a version number fo this image and all it's bundled # artifacts. It should start at zero for each LATEST_ETCD_VERSION and increment # for each revision of this image at that etcd version. <del> REVISION?=2 </del> <ins> REVISION?=3 </ins> # IMAGE_TAG Uniquely identifies k8s.gcr.io/etcd docker image with a tag of the form \"<etcd-version>-<revision>\". IMAGE_TAG=$(LATEST_ETCD_VERSION)-$(REVISION)", "commid": "kubernetes_pr_98526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ee0826757468ea334f95c77509b257c3d392b6713b4311ba7afa125d642dcec9", "query": "The based container images for are shipped with the wrong architecture within the manifest if not amd64: Refers to We updated the images a few minutes ago to buster-v1.3.0, which are now ready to be used as base for the multi-architecture images. If the images contain the right architectures, then it may magically happen that the kube-proxy images are fixed, too. This is because we already use the build syntax for it: /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-6c4e91a988d6c2cf43075e523b28868790ea0987e2c64d256bbdaa1824540e42", "text": "TEMP_DIR:=$(shell mktemp -d) ifeq ($(ARCH),amd64) <del> BASEIMAGE?=k8s.gcr.io/build-image/debian-base:buster-v1.3.0 </del> <ins> BASEIMAGE?=k8s.gcr.io/build-image/debian-base:buster-v1.4.0 </ins> endif ifeq ($(ARCH),arm) <del> BASEIMAGE?=k8s.gcr.io/build-image/debian-base-arm:buster-v1.3.0 </del> <ins> BASEIMAGE?=k8s.gcr.io/build-image/debian-base-arm:buster-v1.4.0 </ins> endif ifeq ($(ARCH),arm64) <del> BASEIMAGE?=k8s.gcr.io/build-image/debian-base-arm64:buster-v1.3.0 </del> <ins> BASEIMAGE?=k8s.gcr.io/build-image/debian-base-arm64:buster-v1.4.0 </ins> endif ifeq ($(ARCH),ppc64le) <del> BASEIMAGE?=k8s.gcr.io/build-image/debian-base-ppc64le:buster-v1.3.0 </del> <ins> BASEIMAGE?=k8s.gcr.io/build-image/debian-base-ppc64le:buster-v1.4.0 </ins> endif ifeq ($(ARCH),s390x) <del> BASEIMAGE?=k8s.gcr.io/build-image/debian-base-s390x:buster-v1.3.0 </del> <ins> BASEIMAGE?=k8s.gcr.io/build-image/debian-base-s390x:buster-v1.4.0 </ins> endif RUNNERIMAGE?=gcr.io/distroless/static:latest", "commid": "kubernetes_pr_98526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ee0826757468ea334f95c77509b257c3d392b6713b4311ba7afa125d642dcec9", "query": "The based container images for are shipped with the wrong architecture within the manifest if not amd64: Refers to We updated the images a few minutes ago to buster-v1.3.0, which are now ready to be used as base for the multi-architecture images. If the images contain the right architectures, then it may magically happen that the kube-proxy images are fixed, too. This is because we already use the build syntax for it: /cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-4b575b1c0df097d3d6bbe8f23323aa3c062c69815f9ca6c1e1d569975ca2c8d1", "text": "configs[CheckMetadataConcealment] = Config{e2eRegistry, \"metadata-concealment\", \"1.2\"} configs[CudaVectorAdd] = Config{e2eRegistry, \"cuda-vector-add\", \"1.0\"} configs[CudaVectorAdd2] = Config{e2eRegistry, \"cuda-vector-add\", \"2.0\"} <del> configs[DebianIptables] = Config{buildImageRegistry, \"debian-iptables\", \"buster-v1.4.0\"} </del> <ins> configs[DebianIptables] = Config{buildImageRegistry, \"debian-iptables\", \"buster-v1.5.0\"} </ins> configs[EchoServer] = Config{e2eRegistry, \"echoserver\", \"2.2\"} configs[Etcd] = Config{gcRegistry, \"etcd\", \"3.4.13-0\"} configs[GlusterDynamicProvisioner] = Config{dockerGluster, \"glusterdynamic-provisioner\", \"v1.0\"}", "commid": "kubernetes_pr_98526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3444fabb883927bdace65eb5d9db61f45e39011ade9a032d43fca15b1006c909", "query": "What happened: The current in-tree PV topology is still using beta version label \"failure-\". This was intentionally not upgrade because of CSI migration. However, since the CSI migration timeline is likely to slip, and with the fix of , it should be safe to update the in-tree PVC to GA version () So that we can unblock removing the beta label from node. What you expected to happen: Replace all beta topology label to GA version once merged. /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: kassarl. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\ngce-pd topology update already merged:\naws-ebs topology update is here:\n/triage accepted\ncinder topology fix is here: Waiting for topology label update.\nOpenStack Cinder:\n/reopen Has vsphere made the fix?\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nNot yet. is going to make the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-02bdd479102388cc7f3b5299a6d1947e4f12ea431ee54b6de00ec86127673481", "text": "for k, v := range labels { pv.Labels[k] = v var values []string <del> if k == v1.LabelFailureDomainBetaZone { </del> <ins> if k == v1.LabelTopologyZone || k == v1.LabelFailureDomainBetaZone { </ins> values, err = volumehelpers.LabelZonesToList(v) if err != nil { return nil, fmt.Errorf(\"failed to convert label string for Zone: %s to a List: %v\", v, err)", "commid": "kubernetes_pr_102414"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3444fabb883927bdace65eb5d9db61f45e39011ade9a032d43fca15b1006c909", "query": "What happened: The current in-tree PV topology is still using beta version label \"failure-\". This was intentionally not upgrade because of CSI migration. However, since the CSI migration timeline is likely to slip, and with the fix of , it should be safe to update the in-tree PVC to GA version () So that we can unblock removing the beta label from node. What you expected to happen: Replace all beta topology label to GA version once merged. /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: kassarl. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\ngce-pd topology update already merged:\naws-ebs topology update is here:\n/triage accepted\ncinder topology fix is here: Waiting for topology label update.\nOpenStack Cinder:\n/reopen Has vsphere made the fix?\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nNot yet. is going to make the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-080cce53daed321928ef9a9b17bb84ac6fdd8960a370be2aeba98dd0ac09ad3a", "text": "translator := NewvSphereCSITranslator() topologySelectorTerm := v1.TopologySelectorTerm{[]v1.TopologySelectorLabelRequirement{ { <ins> Key:    v1.LabelTopologyZone, Values: []string{\"zone-a\"}, }, { Key:    v1.LabelTopologyRegion, Values: []string{\"region-a\"}, }, }} topologySelectorTermWithBetaLabels := v1.TopologySelectorTerm{[]v1.TopologySelectorLabelRequirement{ { </ins> Key:    v1.LabelFailureDomainBetaZone, Values: []string{\"zone-a\"}, },", "commid": "kubernetes_pr_102414"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3444fabb883927bdace65eb5d9db61f45e39011ade9a032d43fca15b1006c909", "query": "What happened: The current in-tree PV topology is still using beta version label \"failure-\". This was intentionally not upgrade because of CSI migration. However, since the CSI migration timeline is likely to slip, and with the fix of , it should be safe to update the in-tree PVC to GA version () So that we can unblock removing the beta label from node. What you expected to happen: Replace all beta topology label to GA version once merged. /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: kassarl. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\ngce-pd topology update already merged:\naws-ebs topology update is here:\n/triage accepted\ncinder topology fix is here: Waiting for topology label update.\nOpenStack Cinder:\n/reopen Has vsphere made the fix?\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nNot yet. is going to make the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-f2463c6f416fd9bb47e7dc54afea340ab49dc3dbef1692321c72d860cebebfa5", "text": "expSc: NewStorageClass(map[string]string{\"storagepolicyname\": \"test-policy-name\", paramcsiMigration: \"true\"}, []v1.TopologySelectorTerm{topologySelectorTerm}), }, { <ins> name:  \"translate with storagepolicyname and allowedTopology beta labels\", sc:    NewStorageClass(map[string]string{\"storagepolicyname\": \"test-policy-name\"}, []v1.TopologySelectorTerm{topologySelectorTermWithBetaLabels}), expSc: NewStorageClass(map[string]string{\"storagepolicyname\": \"test-policy-name\", paramcsiMigration: \"true\"}, []v1.TopologySelectorTerm{topologySelectorTermWithBetaLabels}), }, { </ins> name:  \"translate with raw vSAN policy parameters, datastore and diskformat\", sc:    NewStorageClass(map[string]string{\"hostfailurestotolerate\": \"2\", \"datastore\": \"vsanDatastore\", \"diskformat\": \"thin\"}, []v1.TopologySelectorTerm{topologySelectorTerm}), expSc: NewStorageClass(map[string]string{\"hostfailurestotolerate-migrationparam\": \"2\", \"datastore-migrationparam\": \"vsanDatastore\", \"diskformat-migrationparam\": \"thin\", paramcsiMigration: \"true\"}, []v1.TopologySelectorTerm{topologySelectorTerm}),", "commid": "kubernetes_pr_102414"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3444fabb883927bdace65eb5d9db61f45e39011ade9a032d43fca15b1006c909", "query": "What happened: The current in-tree PV topology is still using beta version label \"failure-\". This was intentionally not upgrade because of CSI migration. However, since the CSI migration timeline is likely to slip, and with the fix of , it should be safe to update the in-tree PVC to GA version () So that we can unblock removing the beta label from node. What you expected to happen: Replace all beta topology label to GA version once merged. /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: kassarl. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\ngce-pd topology update already merged:\naws-ebs topology update is here:\n/triage accepted\ncinder topology fix is here: Waiting for topology label update.\nOpenStack Cinder:\n/reopen Has vsphere made the fix?\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nNot yet. is going to make the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-92489d610f7f6c659ee9a228813494e3bfe1d807aade79da58caf808f8b53874", "text": "} } // Get the node zone information <del> nodeFd := node.ObjectMeta.Labels[v1.LabelFailureDomainBetaZone] nodeRegion := node.ObjectMeta.Labels[v1.LabelFailureDomainBetaRegion] </del> <ins> nodeFd := node.ObjectMeta.Labels[v1.LabelTopologyZone] nodeRegion := node.ObjectMeta.Labels[v1.LabelTopologyRegion] </ins> nodeZone := &cloudprovider.Zone{FailureDomain: nodeFd, Region: nodeRegion} nodeInfo := &NodeInfo{dataCenter: res.datacenter, vm: vm, vcServer: res.vc, vmUUID: nodeUUID, zone: nodeZone} nm.addNodeInfo(node.ObjectMeta.Name, nodeInfo)", "commid": "kubernetes_pr_102414"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3444fabb883927bdace65eb5d9db61f45e39011ade9a032d43fca15b1006c909", "query": "What happened: The current in-tree PV topology is still using beta version label \"failure-\". This was intentionally not upgrade because of CSI migration. However, since the CSI migration timeline is likely to slip, and with the fix of , it should be safe to update the in-tree PVC to GA version () So that we can unblock removing the beta label from node. What you expected to happen: Replace all beta topology label to GA version once merged. /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: kassarl. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\ngce-pd topology update already merged:\naws-ebs topology update is here:\n/triage accepted\ncinder topology fix is here: Waiting for topology label update.\nOpenStack Cinder:\n/reopen Has vsphere made the fix?\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nNot yet. is going to make the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-fe295468090b77d20925042596cd13d991b8f07c0a754840f2fe9436420e3864", "text": "// FIXME: For now, pick the first zone of datastore as the zone of volume labels := make(map[string]string) if len(dsZones) > 0 { <del> labels[v1.LabelFailureDomainBetaRegion] = dsZones[0].Region labels[v1.LabelFailureDomainBetaZone] = dsZones[0].FailureDomain </del> <ins> labels[v1.LabelTopologyRegion] = dsZones[0].Region labels[v1.LabelTopologyZone] = dsZones[0].FailureDomain </ins> } return labels, nil }", "commid": "kubernetes_pr_102414"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3444fabb883927bdace65eb5d9db61f45e39011ade9a032d43fca15b1006c909", "query": "What happened: The current in-tree PV topology is still using beta version label \"failure-\". This was intentionally not upgrade because of CSI migration. However, since the CSI migration timeline is likely to slip, and with the fix of , it should be safe to update the in-tree PVC to GA version () So that we can unblock removing the beta label from node. What you expected to happen: Replace all beta topology label to GA version once merged. /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: kassarl. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\ngce-pd topology update already merged:\naws-ebs topology update is here:\n/triage accepted\ncinder topology fix is here: Waiting for topology label update.\nOpenStack Cinder:\n/reopen Has vsphere made the fix?\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nNot yet. is going to make the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-0d25c393fbd569107602a8ba2f8611d98068affb180db7970873ff7fd831dc92", "text": "term := v1.TopologySelectorTerm{ MatchLabelExpressions: []v1.TopologySelectorLabelRequirement{ { <del> Key:    v1.LabelFailureDomainBetaZone, </del> <ins> Key:    v1.LabelTopologyZone, </ins> Values: zones, }, },", "commid": "kubernetes_pr_102414"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3444fabb883927bdace65eb5d9db61f45e39011ade9a032d43fca15b1006c909", "query": "What happened: The current in-tree PV topology is still using beta version label \"failure-\". This was intentionally not upgrade because of CSI migration. However, since the CSI migration timeline is likely to slip, and with the fix of , it should be safe to update the in-tree PVC to GA version () So that we can unblock removing the beta label from node. What you expected to happen: Replace all beta topology label to GA version once merged. /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: kassarl. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\ngce-pd topology update already merged:\naws-ebs topology update is here:\n/triage accepted\ncinder topology fix is here: Waiting for topology label update.\nOpenStack Cinder:\n/reopen Has vsphere made the fix?\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nNot yet. is going to make the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-227c45bc91e95d461bf1a73c563edd2e596b4c356a6c9fd629d5fe595c44623a", "text": "zones = append(zones, zoneA) nodeSelectorMap := map[string]string{ // nodeSelector set as zoneB <del> v1.LabelFailureDomainBetaZone: zoneB, </del> <ins> v1.LabelTopologyZone: zoneB, </ins> } verifyPodSchedulingFails(client, namespace, nodeSelectorMap, scParameters, zones, storagev1.VolumeBindingWaitForFirstConsumer) })", "commid": "kubernetes_pr_102414"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3444fabb883927bdace65eb5d9db61f45e39011ade9a032d43fca15b1006c909", "query": "What happened: The current in-tree PV topology is still using beta version label \"failure-\". This was intentionally not upgrade because of CSI migration. However, since the CSI migration timeline is likely to slip, and with the fix of , it should be safe to update the in-tree PVC to GA version () So that we can unblock removing the beta label from node. What you expected to happen: Replace all beta topology label to GA version once merged. /sig storage /cc\n/assign\nGitHub didn't allow me to assign the following users: kassarl. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\ngce-pd topology update already merged:\naws-ebs topology update is here:\n/triage accepted\ncinder topology fix is here: Waiting for topology label update.\nOpenStack Cinder:\n/reopen Has vsphere made the fix?\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nNot yet. is going to make the fix.", "positive_passages": [{"docid": "doc-en-kubernetes-11a3b2238eaf26655289df8bca981b12791a3530983e674247a0880759afff94", "text": "ginkgo.By(\"Verify zone information is present in the volume labels\") for _, pv := range persistentvolumes { // Multiple zones are separated with \"__\" <del> pvZoneLabels := strings.Split(pv.ObjectMeta.Labels[\"failure-domain.beta.kubernetes.io/zone\"], \"__\") </del> <ins> pvZoneLabels := strings.Split(pv.ObjectMeta.Labels[v1.LabelTopologyZone], \"__\") </ins> for _, zone := range zones { gomega.Expect(pvZoneLabels).Should(gomega.ContainElement(zone), \"Incorrect or missing zone labels in pv.\") }", "commid": "kubernetes_pr_102414"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c41f05d8910be5009b755790528ec94d72d551b527b45c1ed91bde3c53341f9a", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When reviewing Windows kubelet logs noticed errors like: What you expected to happen: The stats should be returned How to reproduce it (as minimally and precisely as possible): This occurs when the pods has just started or during termination. To simulate the issue: Then deploy pod: Anything else we need to know?: The container is in a state but is has not started running so the call to get the stats fails: This is handled in other places like moby: and Environment: Kubernetes version (use ): 1.18+ Cloud provider or hardware configuration: aks-engine OS (e.g: ): Windows Kernel (e.g. ): 2019 Install tools: Network plugin and version (if this is a network-related bug): Others: Dockershim /sig windows /priority critical-urgent /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ncc:", "positive_passages": [{"docid": "doc-en-kubernetes-17cd28d52a52dae457980210513e44b65fbbc4050d1f2a37fa062f99f688f2d6", "text": "case err := <-injectedError: return nil, err } <del> // Never get here. return nil, nil </del> }", "commid": "kubernetes_pr_901"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c41f05d8910be5009b755790528ec94d72d551b527b45c1ed91bde3c53341f9a", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When reviewing Windows kubelet logs noticed errors like: What you expected to happen: The stats should be returned How to reproduce it (as minimally and precisely as possible): This occurs when the pods has just started or during termination. To simulate the issue: Then deploy pod: Anything else we need to know?: The container is in a state but is has not started running so the call to get the stats fails: This is handled in other places like moby: and Environment: Kubernetes version (use ): 1.18+ Cloud provider or hardware configuration: aks-engine OS (e.g: ): Windows Kernel (e.g. ): 2019 Install tools: Network plugin and version (if this is a network-related bug): Others: Dockershim /sig windows /priority critical-urgent /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ncc:", "positive_passages": [{"docid": "doc-en-kubernetes-ba22ea670240b30b8506f7c544e52e154fb237babef124befb10e3e9ce35de5e", "text": "import ( \"context\" <ins> \"strings\" </ins> \"time\" \"github.com/Microsoft/hcsshim\"", "commid": "kubernetes_pr_98510"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c41f05d8910be5009b755790528ec94d72d551b527b45c1ed91bde3c53341f9a", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When reviewing Windows kubelet logs noticed errors like: What you expected to happen: The stats should be returned How to reproduce it (as minimally and precisely as possible): This occurs when the pods has just started or during termination. To simulate the issue: Then deploy pod: Anything else we need to know?: The container is in a state but is has not started running so the call to get the stats fails: This is handled in other places like moby: and Environment: Kubernetes version (use ): 1.18+ Cloud provider or hardware configuration: aks-engine OS (e.g: ): Windows Kernel (e.g. ): 2019 Install tools: Network plugin and version (if this is a network-related bug): Others: Dockershim /sig windows /priority critical-urgent /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ncc:", "positive_passages": [{"docid": "doc-en-kubernetes-d0fa5f3c89e6a9a267d1e6acb2f371adbd4cf5cb32208496d4ce88a71ca3ba8f", "text": "// That will typically happen with init-containers in Exited state. Docker still knows about them but the HCS does not. // As we don't want to block stats retrieval for other containers, we only log errors. if !hcsshim.IsNotExist(err) && !hcsshim.IsAlreadyStopped(err) { <del> klog.Errorf(\"Error opening container (stats will be missing) '%s': %v\", containerID, err) </del> <ins> klog.V(4).Infof(\"Error opening container (stats will be missing) '%s': %v\", containerID, err) </ins> } return nil, nil }", "commid": "kubernetes_pr_98510"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c41f05d8910be5009b755790528ec94d72d551b527b45c1ed91bde3c53341f9a", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When reviewing Windows kubelet logs noticed errors like: What you expected to happen: The stats should be returned How to reproduce it (as minimally and precisely as possible): This occurs when the pods has just started or during termination. To simulate the issue: Then deploy pod: Anything else we need to know?: The container is in a state but is has not started running so the call to get the stats fails: This is handled in other places like moby: and Environment: Kubernetes version (use ): 1.18+ Cloud provider or hardware configuration: aks-engine OS (e.g: ): Windows Kernel (e.g. ): 2019 Install tools: Network plugin and version (if this is a network-related bug): Others: Dockershim /sig windows /priority critical-urgent /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ncc:", "positive_passages": [{"docid": "doc-en-kubernetes-bf0a1deb47cbe99659b29921e99fbdda1d40b752f9109e98ea6eb2bf823f78ac", "text": "stats, err := hcsshimContainer.Statistics() if err != nil { <ins> if strings.Contains(err.Error(), \"0x5\") || strings.Contains(err.Error(), \"0xc0370105\") { // When the container is just created, querying for stats causes access errors because it hasn't started yet // This is transient; skip container for now // // These hcs errors do not have helpers exposed in public package so need to query for the known codes // https://github.com/microsoft/hcsshim/blob/master/internal/hcs/errors.go // PR to expose helpers in hcsshim: https://github.com/microsoft/hcsshim/pull/933 klog.V(4).Infof(\"Container is not in a state that stats can be accessed '%s': %v. This occurs when the container is created but not started.\", containerID, err) return nil, nil } </ins> return nil, err }", "commid": "kubernetes_pr_98510"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bfd32e3b4446984b607eec8f1f52f6ed2d0a69f7505b06c358a314b66387192a", "query": "What happened: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Run the netpol test suite. Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/triage accepted\n/sig network", "positive_passages": [{"docid": "doc-en-kubernetes-b6d4832c8afc1c115b22b9c5f6f77e1458217aba001f83efd05151b78f84d119", "text": "func (r *Reachability) PrintSummary(printExpected bool, printObserved bool, printComparison bool) { right, wrong, ignored, comparison := r.Summary(ignoreLoopback) if ignored > 0 { <del> framework.Logf(\"warning: the results of %d pod->pod cases have been ignored\", ignored) </del> <ins> framework.Logf(\"warning: this test doesn't take into consideration hairpin traffic, i.e. traffic whose source and destination is the same pod: %d cases ignored\", ignored) </ins> } framework.Logf(\"reachability: correct:%v, incorrect:%v, result=%tnn\", right, wrong, wrong == 0) if printExpected {", "commid": "kubernetes_pr_98584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ea38d7e555d00e2e1e1f80a069d48e0be42991c74b8337dc8123f04000087f50", "query": "MetricsGrabber tests failing when scheduler & controller-manager not visible. In managed offerings, like GKE, scheduler and controller-manager are not visible causing BeforeSuite of MetricsGrabber to fail. Test is failing then control plane pods can't be found (as on GKE): HasControlPlanePods was in /assign\n/sig instrumentation\nJust removing this check allows tests to run without problems (some skipped, one passing).\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-78dfd471ecc7fc14335433351520ba31f0b2fc2e85afeb2c7ad46acddb2de8d6", "text": "f := framework.NewDefaultFramework(\"metrics-grabber\") var c, ec clientset.Interface var grabber *e2emetrics.Grabber <ins> var masterRegistered bool </ins> ginkgo.BeforeEach(func() { var err error c = f.ClientSet ec = f.KubemarkExternalClusterClientSet <ins> // Check if master Node is registered nodes, err := c.CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{}) </ins> framework.ExpectNoError(err) <ins> for _, node := range nodes.Items { if strings.HasSuffix(node.Name, \"master\") { masterRegistered = true } } </ins> gomega.Eventually(func() error { grabber, err = e2emetrics.NewMetricsGrabber(c, ec, true, true, true, true, true) if err != nil { return fmt.Errorf(\"failed to create metrics grabber: %v\", err) } <del> if !grabber.HasControlPlanePods() { </del> <ins> if masterRegistered && !grabber.HasControlPlanePods() { </ins> return fmt.Errorf(\"unable to get find control plane pods\") } return nil", "commid": "kubernetes_pr_98972"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ea38d7e555d00e2e1e1f80a069d48e0be42991c74b8337dc8123f04000087f50", "query": "MetricsGrabber tests failing when scheduler & controller-manager not visible. In managed offerings, like GKE, scheduler and controller-manager are not visible causing BeforeSuite of MetricsGrabber to fail. Test is failing then control plane pods can't be found (as on GKE): HasControlPlanePods was in /assign\n/sig instrumentation\nJust removing this check allows tests to run without problems (some skipped, one passing).\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-afa940021177fdf46d5ea181bacea040d3fb9a5f95cb2308c20fcf7471b4b8e2", "text": "ginkgo.It(\"should grab all metrics from a Scheduler.\", func() { ginkgo.By(\"Proxying to Pod through the API server\") <del> // Check if master Node is registered nodes, err := c.CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{}) framework.ExpectNoError(err) var masterRegistered = false for _, node := range nodes.Items { if strings.HasSuffix(node.Name, \"master\") { masterRegistered = true } } </del> if !masterRegistered { framework.Logf(\"Master is node api.Registry. Skipping testing Scheduler metrics.\") return", "commid": "kubernetes_pr_98972"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ea38d7e555d00e2e1e1f80a069d48e0be42991c74b8337dc8123f04000087f50", "query": "MetricsGrabber tests failing when scheduler & controller-manager not visible. In managed offerings, like GKE, scheduler and controller-manager are not visible causing BeforeSuite of MetricsGrabber to fail. Test is failing then control plane pods can't be found (as on GKE): HasControlPlanePods was in /assign\n/sig instrumentation\nJust removing this check allows tests to run without problems (some skipped, one passing).\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-2db68db85e8dd99d493b98cfe43a4505366f59fde87aff5279df7c6bfdf1617c", "text": "ginkgo.It(\"should grab all metrics from a ControllerManager.\", func() { ginkgo.By(\"Proxying to Pod through the API server\") <del> // Check if master Node is registered nodes, err := c.CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{}) framework.ExpectNoError(err) var masterRegistered = false for _, node := range nodes.Items { if strings.HasSuffix(node.Name, \"master\") { masterRegistered = true } } </del> if !masterRegistered { framework.Logf(\"Master is node api.Registry. Skipping testing ControllerManager metrics.\") return", "commid": "kubernetes_pr_98972"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a22b7be5e953790da465f200505d8aba99618aabc30b0801e44f633857f7538", "query": "[x] two weeks soak end date : 26 Feb 2021 According to this APIsnoop query, there are still some remaining RESOURCENAME endpoints which are untested. with this query you can filter untested endpoints by their category and eligiblity for conformance. e.g below shows a query to find all conformance eligible untested,stable,core endpoints Create a ReplicaSet with a static label Read the ReplicaSetScale Update the ReplicaSetScale Get the ReplicaSetScale to ensure it is updated Patch the ReplicaSetScale Read the ReplicaSetScale to ensure it is Patch Delete the Namespace and ReplicaSet Due to the complexity of setting up the resources for APIService we have used the current e2e test as template. It has been extended in a for review. example endpoint | useragent ----------------------------------------|\npatchAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource readAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource replaceAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource (3 rows) If a test with these calls gets merged, test coverage will go up by 3 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture\n/triage accepted\nPresented in Conformance meeting of 9 Feb 2021 and it was agreed that that method see to achieve the purpose and a PR can be created. A similar approach would be taken for the DepoymentScale endpoints.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-ade7c52498941f596eebc8f88c256efaa8a986f2c76e5d32914b7cc7da27445a", "text": "import ( \"context\" <ins> \"encoding/json\" </ins> \"fmt\" \"time\" appsv1 \"k8s.io/api/apps/v1\" <ins> autoscalingv1 \"k8s.io/api/autoscaling/v1\" \"k8s.io/apimachinery/pkg/types\" </ins> v1 \"k8s.io/api/core/v1\" apierrors \"k8s.io/apimachinery/pkg/api/errors\" \"k8s.io/apimachinery/pkg/api/resource\"", "commid": "kubernetes_pr_98987"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a22b7be5e953790da465f200505d8aba99618aabc30b0801e44f633857f7538", "query": "[x] two weeks soak end date : 26 Feb 2021 According to this APIsnoop query, there are still some remaining RESOURCENAME endpoints which are untested. with this query you can filter untested endpoints by their category and eligiblity for conformance. e.g below shows a query to find all conformance eligible untested,stable,core endpoints Create a ReplicaSet with a static label Read the ReplicaSetScale Update the ReplicaSetScale Get the ReplicaSetScale to ensure it is updated Patch the ReplicaSetScale Read the ReplicaSetScale to ensure it is Patch Delete the Namespace and ReplicaSet Due to the complexity of setting up the resources for APIService we have used the current e2e test as template. It has been extended in a for review. example endpoint | useragent ----------------------------------------|\npatchAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource readAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource replaceAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource (3 rows) If a test with these calls gets merged, test coverage will go up by 3 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture\n/triage accepted\nPresented in Conformance meeting of 9 Feb 2021 and it was agreed that that method see to achieve the purpose and a PR can be created. A similar approach would be taken for the DepoymentScale endpoints.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-28a3ebdb84a99d2903be99953b4b80fa59648b315a13cfce32c9665181ed188e", "text": "framework.ConformanceIt(\"should adopt matching pods on creation and release no longer matching pods\", func() { testRSAdoptMatchingAndReleaseNotMatching(f) }) <ins> ginkgo.It(\"Replicaset should have a working scale subresource\", func() { testRSScaleSubresources(f) }) </ins> }) // A basic test to check the deployment of an image using a ReplicaSet. The", "commid": "kubernetes_pr_98987"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a22b7be5e953790da465f200505d8aba99618aabc30b0801e44f633857f7538", "query": "[x] two weeks soak end date : 26 Feb 2021 According to this APIsnoop query, there are still some remaining RESOURCENAME endpoints which are untested. with this query you can filter untested endpoints by their category and eligiblity for conformance. e.g below shows a query to find all conformance eligible untested,stable,core endpoints Create a ReplicaSet with a static label Read the ReplicaSetScale Update the ReplicaSetScale Get the ReplicaSetScale to ensure it is updated Patch the ReplicaSetScale Read the ReplicaSetScale to ensure it is Patch Delete the Namespace and ReplicaSet Due to the complexity of setting up the resources for APIService we have used the current e2e test as template. It has been extended in a for review. example endpoint | useragent ----------------------------------------|\npatchAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource readAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource replaceAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource (3 rows) If a test with these calls gets merged, test coverage will go up by 3 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture\n/triage accepted\nPresented in Conformance meeting of 9 Feb 2021 and it was agreed that that method see to achieve the purpose and a PR can be created. A similar approach would be taken for the DepoymentScale endpoints.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-6f3c50dee60966e4d0743254aa3d175df5b28f7a956cd6a92fce4e4e38fbf2ef", "text": "}) framework.ExpectNoError(err) } <ins> func testRSScaleSubresources(f *framework.Framework) { ns := f.Namespace.Name c := f.ClientSet // Create webserver pods. rsPodLabels := map[string]string{ \"name\": \"sample-pod\", \"pod\":  WebserverImageName, } rsName := \"test-rs\" replicas := int32(1) ginkgo.By(fmt.Sprintf(\"Creating replica set %q that asks for more than the allowed pod quota\", rsName)) rs := newRS(rsName, replicas, rsPodLabels, WebserverImageName, WebserverImage, nil) _, err := c.AppsV1().ReplicaSets(ns).Create(context.TODO(), rs, metav1.CreateOptions{}) framework.ExpectNoError(err) // Verify that the required pods have come up. err = e2epod.VerifyPodsRunning(c, ns, \"sample-pod\", false, replicas) framework.ExpectNoError(err, \"error in waiting for pods to come up: %s\", err) ginkgo.By(\"getting scale subresource\") scale, err := c.AppsV1().ReplicaSets(ns).GetScale(context.TODO(), rsName, metav1.GetOptions{}) if err != nil { framework.Failf(\"Failed to get scale subresource: %v\", err) } framework.ExpectEqual(scale.Spec.Replicas, int32(1)) framework.ExpectEqual(scale.Status.Replicas, int32(1)) ginkgo.By(\"updating a scale subresource\") scale.ResourceVersion = \"\" // indicate the scale update should be unconditional scale.Spec.Replicas = 2 scaleResult, err := c.AppsV1().ReplicaSets(ns).UpdateScale(context.TODO(), rsName, scale, metav1.UpdateOptions{}) if err != nil { framework.Failf(\"Failed to put scale subresource: %v\", err) } framework.ExpectEqual(scaleResult.Spec.Replicas, int32(2)) ginkgo.By(\"verifying the replicaset Spec.Replicas was modified\") rs, err = c.AppsV1().ReplicaSets(ns).Get(context.TODO(), rsName, metav1.GetOptions{}) if err != nil { framework.Failf(\"Failed to get statefulset resource: %v\", err) } framework.ExpectEqual(*(rs.Spec.Replicas), int32(2)) ginkgo.By(\"Patch a scale subresource\") scale.ResourceVersion = \"\" // indicate the scale update should be unconditional scale.Spec.Replicas = 4    // should be 2 after \"UpdateScale\" operation, now Patch to 4 rsScalePatchPayload, err := json.Marshal(autoscalingv1.Scale{ Spec: autoscalingv1.ScaleSpec{ Replicas: scale.Spec.Replicas, }, }) framework.ExpectNoError(err, \"Could not Marshal JSON for patch payload\") _, err = c.AppsV1().ReplicaSets(ns).Patch(context.TODO(), rsName, types.StrategicMergePatchType, []byte(rsScalePatchPayload), metav1.PatchOptions{}, \"scale\") framework.ExpectNoError(err, \"Failed to patch replicaset: %v\", err) rs, err = c.AppsV1().ReplicaSets(ns).Get(context.TODO(), rsName, metav1.GetOptions{}) framework.ExpectNoError(err, \"Failed to get replicaset resource: %v\", err) framework.ExpectEqual(*(rs.Spec.Replicas), int32(4), \"replicaset should have 4 replicas\") } </ins>", "commid": "kubernetes_pr_98987"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a22b7be5e953790da465f200505d8aba99618aabc30b0801e44f633857f7538", "query": "[x] two weeks soak end date : 26 Feb 2021 According to this APIsnoop query, there are still some remaining RESOURCENAME endpoints which are untested. with this query you can filter untested endpoints by their category and eligiblity for conformance. e.g below shows a query to find all conformance eligible untested,stable,core endpoints Create a ReplicaSet with a static label Read the ReplicaSetScale Update the ReplicaSetScale Get the ReplicaSetScale to ensure it is updated Patch the ReplicaSetScale Read the ReplicaSetScale to ensure it is Patch Delete the Namespace and ReplicaSet Due to the complexity of setting up the resources for APIService we have used the current e2e test as template. It has been extended in a for review. example endpoint | useragent ----------------------------------------|\npatchAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource readAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource replaceAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource (3 rows) If a test with these calls gets merged, test coverage will go up by 3 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture\n/triage accepted\nPresented in Conformance meeting of 9 Feb 2021 and it was agreed that that method see to achieve the purpose and a PR can be created. A similar approach would be taken for the DepoymentScale endpoints.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-89ccecfb7a48fe5e3f828d66a19808b668f1365f8d96e342cbde62e5e344bb35", "text": "the Job MUST execute to completion. release: v1.16 file: test/e2e/apps/job.go <ins> - testname: ReplicaSet, completes the scaling of a ReplicaSet subresource codename: '[sig-apps] ReplicaSet Replicaset should have a working scale subresource [Conformance]' description: Create a ReplicaSet (RS) with a single Pod. The Pod MUST be verified that it is running. The RS MUST get and verify the scale subresource count. The RS MUST update and verify the scale subresource. The RS MUST patch and verify a scale subresource. release: v1.21 file: test/e2e/apps/replica_set.go </ins> - testname: Replica Set, adopt matching pods and release non matching pods codename: '[sig-apps] ReplicaSet should adopt matching pods on creation and release no longer matching pods [Conformance]'", "commid": "kubernetes_pr_99282"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a22b7be5e953790da465f200505d8aba99618aabc30b0801e44f633857f7538", "query": "[x] two weeks soak end date : 26 Feb 2021 According to this APIsnoop query, there are still some remaining RESOURCENAME endpoints which are untested. with this query you can filter untested endpoints by their category and eligiblity for conformance. e.g below shows a query to find all conformance eligible untested,stable,core endpoints Create a ReplicaSet with a static label Read the ReplicaSetScale Update the ReplicaSetScale Get the ReplicaSetScale to ensure it is updated Patch the ReplicaSetScale Read the ReplicaSetScale to ensure it is Patch Delete the Namespace and ReplicaSet Due to the complexity of setting up the resources for APIService we have used the current e2e test as template. It has been extended in a for review. example endpoint | useragent ----------------------------------------|\npatchAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource readAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource replaceAppsV1NamespacedReplicaSetScale | (linux/amd64) kubernetes/$Format -- [sig-apps] ReplicaSet Replicaset should have a working scale subresource (3 rows) If a test with these calls gets merged, test coverage will go up by 3 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture\n/triage accepted\nPresented in Conformance meeting of 9 Feb 2021 and it was agreed that that method see to achieve the purpose and a PR can be created. A similar approach would be taken for the DepoymentScale endpoints.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-2370a1166f68d542ad8a6b452ce4d5eb9adf3174aefbd435b9daf7b546abdf3f", "text": "testRSAdoptMatchingAndReleaseNotMatching(f) }) <del> ginkgo.It(\"Replicaset should have a working scale subresource\", func() { </del> <ins> /* Release: v1.21 Testname: ReplicaSet, completes the scaling of a ReplicaSet subresource Description: Create a ReplicaSet (RS) with a single Pod. The Pod MUST be verified that it is running. The RS MUST get and verify the scale subresource count. The RS MUST update and verify the scale subresource. The RS MUST patch and verify a scale subresource. */ framework.ConformanceIt(\"Replicaset should have a working scale subresource\", func() { </ins> testRSScaleSubresources(f) }) })", "commid": "kubernetes_pr_99282"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ea5dfa8ca4c60a50617e7c454844a28b8df064eecf8f8671a6154c2ab71f66c0", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: What you expected to happen: The test should pass How to reproduce it (as minimally and precisely as possible): I think the key here is being on a linux host with cgroupsv2 enabled. Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /sig node\n/assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-a6cb3f7d0d0df29c4e666050be02013fa572e143810b691d53da0d79966f2966", "text": "package oom import ( <ins> \"os\" </ins> \"github.com/opencontainers/runc/libcontainer/cgroups\" \"testing\"", "commid": "kubernetes_pr_98960"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ea5dfa8ca4c60a50617e7c454844a28b8df064eecf8f8671a6154c2ab71f66c0", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: What you expected to happen: The test should pass How to reproduce it (as minimally and precisely as possible): I think the key here is being on a linux host with cgroupsv2 enabled. Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /sig node\n/assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-922506670d687f708855563b6b3e4580e6fb88d96639cc2dc1ddc6019a6b1507", "text": "func TestPidListerFailure(t *testing.T) { _, err := getPids(\"/does/not/exist\") <del> assert.True(t, cgroups.IsNotFound(err), \"expected getPids to return not exists error. Got %v\", err) </del> <ins> assert.True(t, cgroups.IsNotFound(err) || os.IsNotExist(err), \"expected getPids to return not exists error. Got %v\", err) </ins> }", "commid": "kubernetes_pr_98960"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-613d127cd5afdadcbee3c136bb9a085f17e19f478307e1e6bd53399b9c176078", "query": "file was found 'empty'. It blocked running etcd in a fail loop with Before this issue: Data disk (etcd) run out of space due to . .txt be not corrupted. It should be updated: only when needed (infrequently) safely (rename swap or writing on pre-allocated space) migrator script that runs etcd in case of the file not being found. Use whole space of etcd data disk and restart migrator+etcd when concurrent process is disk hungry. Requires changes of this logic: This logic (file write) should not trigger if the minor version matches: The write itself: should be defensive: Please notice that truncates file before writingKubernetes version: 1.18 Cloud provider or hardware configuration: GCE\n/sig api-machinery\n/assign /triage accepted\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale /lifecycle frozen", "positive_passages": [{"docid": "doc-en-kubernetes-7ab4bdd52914e8f04788fa57c810d85fe8970e687349c460e20dbf7967dc60e2", "text": "path string } <ins> func (v *VersionFile) nextPath() string { return fmt.Sprintf(\"%s-next\", v.path) } </ins> // Exists returns true if a version.txt file exists on the file system. func (v *VersionFile) Exists() (bool, error) { return exists(v.path)", "commid": "kubernetes_pr_106653"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-613d127cd5afdadcbee3c136bb9a085f17e19f478307e1e6bd53399b9c176078", "query": "file was found 'empty'. It blocked running etcd in a fail loop with Before this issue: Data disk (etcd) run out of space due to . .txt be not corrupted. It should be updated: only when needed (infrequently) safely (rename swap or writing on pre-allocated space) migrator script that runs etcd in case of the file not being found. Use whole space of etcd data disk and restart migrator+etcd when concurrent process is disk hungry. Requires changes of this logic: This logic (file write) should not trigger if the minor version matches: The write itself: should be defensive: Please notice that truncates file before writingKubernetes version: 1.18 Cloud provider or hardware configuration: GCE\n/sig api-machinery\n/assign /triage accepted\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale /lifecycle frozen", "positive_passages": [{"docid": "doc-en-kubernetes-38dac15bb17380f5fb84dbf1161b14ff70f62b584b5c4eada5926c1f5ecf34c9", "text": "// Write creates or overwrites the contents of the version.txt file with the given EtcdVersionPair. func (v *VersionFile) Write(vp *EtcdVersionPair) error { <del> data := []byte(fmt.Sprintf(\"%s/%s\", vp.version, vp.storageVersion)) return ioutil.WriteFile(v.path, data, 0666) </del> <ins> // We do write + rename instead of just write to protect from version.txt // corruption under full disk condition. // See https://github.com/kubernetes/kubernetes/issues/98989. err := ioutil.WriteFile(v.nextPath(), []byte(vp.String()), 0666) if err != nil { return fmt.Errorf(\"failed to write new version file %s: %v\", v.nextPath(), err) } return os.Rename(v.nextPath(), v.path) </ins> } func exists(path string) (bool, error) {", "commid": "kubernetes_pr_106653"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9e77c1eae275c1db9b153ebc2059acc2c6dc209d44d586853b1d6ddfc8aedcc0", "query": "was removed in 1.20 in favor of a plugin. However, this is not included in release artifacts. The binary is included in release artifacts, and ideally easily installable via kubectl plugin managers like . /sig cli /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis question came up in a docs review of a page referencing () Once this is resolved, please ensure the website is updated to document installation/use of this tool.\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-74c0e4dbd66a8372b732844fa078e072a5e64c89ecb52ee807bb1681813084ce", "text": "name = \"client-targets\", conditioned_srcs = for_platforms(for_client = [ \"//cmd/kubectl\", <ins> \"//cmd/kubectl-convert\", </ins> ]), )", "commid": "kubernetes_pr_99155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9e77c1eae275c1db9b153ebc2059acc2c6dc209d44d586853b1d6ddfc8aedcc0", "query": "was removed in 1.20 in favor of a plugin. However, this is not included in release artifacts. The binary is included in release artifacts, and ideally easily installable via kubectl plugin managers like . /sig cli /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis question came up in a docs review of a page referencing () Once this is resolved, please ensure the website is updated to document installation/use of this tool.\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-0c021fda3a84b93f07d21361967470ba39f994cee3fb4e43c230f6ba50aaf92d", "text": "load(\"//staging/src/k8s.io/component-base/version:def.bzl\", \"version_x_defs\") go_binary( <del> name = \"kubectl\", </del> <ins> name = \"kubectl-convert\", </ins> embed = [\":go_default_library\"], pure = \"on\", visibility = [\"//visibility:public\"],", "commid": "kubernetes_pr_99155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9e77c1eae275c1db9b153ebc2059acc2c6dc209d44d586853b1d6ddfc8aedcc0", "query": "was removed in 1.20 in favor of a plugin. However, this is not included in release artifacts. The binary is included in release artifacts, and ideally easily installable via kubectl plugin managers like . /sig cli /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis question came up in a docs review of a page referencing () Once this is resolved, please ensure the website is updated to document installation/use of this tool.\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-11d6939a9598f7637f050895e12f33270db136807c3c29083d2963fb6d794360", "text": "# If you update this list, please also update build/BUILD. readonly KUBE_CLIENT_TARGETS=( cmd/kubectl <ins> cmd/kubectl-convert </ins> ) readonly KUBE_CLIENT_BINARIES=(\"${KUBE_CLIENT_TARGETS[@]##*/}\") readonly KUBE_CLIENT_BINARIES_WIN=(\"${KUBE_CLIENT_BINARIES[@]/%/.exe}\")", "commid": "kubernetes_pr_99155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9e77c1eae275c1db9b153ebc2059acc2c6dc209d44d586853b1d6ddfc8aedcc0", "query": "was removed in 1.20 in favor of a plugin. However, this is not included in release artifacts. The binary is included in release artifacts, and ideally easily installable via kubectl plugin managers like . /sig cli /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis question came up in a docs review of a page referencing () Once this is resolved, please ensure the website is updated to document installation/use of this tool.\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-2d46af9986a9452cf5cefdf6201eec8cbea93c2fb13a78ecad92321ec4dbebf9", "text": "<ins> #!/usr/bin/env bash # Copyright 2021 The Kubernetes Authors. # # Licensed under the Apache License, Version 2.0 (the \"License\"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #     http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an \"AS IS\" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. set -o errexit set -o nounset set -o pipefail run_convert_tests() { set -o nounset set -o errexit ### Convert deployment YAML file locally without affecting the live deployment # Pre-condition: no deployments exist kube::test::get_object_assert deployment \"{{range.items}}{{${id_field:?}}}:{{end}}\" '' # Command # Create a deployment (revision 1) kubectl create -f hack/testdata/deployment-revision1.yaml \"${kube_flags[@]:?}\" kube::test::get_object_assert deployment \"{{range.items}}{{${id_field:?}}}:{{end}}\" 'nginx:' kube::test::get_object_assert deployment \"{{range.items}}{{${image_field0:?}}}:{{end}}\" \"${IMAGE_DEPLOYMENT_R1}:\" # Command output_message=$(kubectl convert --local -f hack/testdata/deployment-revision1.yaml --output-version=apps/v1beta1 -o yaml \"${kube_flags[@]:?}\") # Post-condition: apiVersion is still apps/v1 in the live deployment, but command output is the new value kube::test::get_object_assert 'deployment nginx' \"{{ .apiVersion }}\" 'apps/v1' kube::test::if_has_string \"${output_message}\" \"apps/v1beta1\" # Clean up kubectl delete deployment nginx \"${kube_flags[@]:?}\" ## Convert multiple busybox PODs recursively from directory of YAML files # Command output_message=$(! kubectl-convert -f hack/testdata/recursive/pod --recursive 2>&1 \"${kube_flags[@]:?}\") # Post-condition: busybox0 & busybox1 PODs are converted, and since busybox2 is malformed, it should error kube::test::if_has_string \"${output_message}\" \"Object 'Kind' is missing\" # check that convert command supports --template output output_message=$(kubectl-convert \"${kube_flags[@]:?}\" -f hack/testdata/deployment-revision1.yaml --output-version=apps/v1beta2 --template=\"{{ .metadata.name }}:\") kube::test::if_has_string \"${output_message}\" 'nginx:' set +o nounset set +o errexit } </ins>", "commid": "kubernetes_pr_99155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9e77c1eae275c1db9b153ebc2059acc2c6dc209d44d586853b1d6ddfc8aedcc0", "query": "was removed in 1.20 in favor of a plugin. However, this is not included in release artifacts. The binary is included in release artifacts, and ideally easily installable via kubectl plugin managers like . /sig cli /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis question came up in a docs review of a page referencing () Once this is resolved, please ensure the website is updated to document installation/use of this tool.\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-d44d3770baec486001a4f04ccd6335fea8dc87a929d11a53a31b1496749a97ca", "text": "source \"${KUBE_ROOT}/test/cmd/authorization.sh\" source \"${KUBE_ROOT}/test/cmd/batch.sh\" source \"${KUBE_ROOT}/test/cmd/certificate.sh\" <ins> source \"${KUBE_ROOT}/test/cmd/convert.sh\" </ins> source \"${KUBE_ROOT}/test/cmd/core.sh\" source \"${KUBE_ROOT}/test/cmd/crd.sh\" source \"${KUBE_ROOT}/test/cmd/create.sh\"", "commid": "kubernetes_pr_99155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9e77c1eae275c1db9b153ebc2059acc2c6dc209d44d586853b1d6ddfc8aedcc0", "query": "was removed in 1.20 in favor of a plugin. However, this is not included in release artifacts. The binary is included in release artifacts, and ideally easily installable via kubectl plugin managers like . /sig cli /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis question came up in a docs review of a page referencing () Once this is resolved, please ensure the website is updated to document installation/use of this tool.\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-7fc4bb672d4bd61fdfc61b264308c07665d5b5a8cfd5c8f0f900ca7dcc557c67", "text": "kube::util::ensure-gnu-sed kube::log::status \"Building kubectl\" <del> make -C \"${KUBE_ROOT}\" WHAT=\"cmd/kubectl\" </del> <ins> make -C \"${KUBE_ROOT}\" WHAT=\"cmd/kubectl cmd/kubectl-convert\" </ins> # Check kubectl kube::log::status \"Running kubectl with no options\"", "commid": "kubernetes_pr_99155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9e77c1eae275c1db9b153ebc2059acc2c6dc209d44d586853b1d6ddfc8aedcc0", "query": "was removed in 1.20 in favor of a plugin. However, this is not included in release artifacts. The binary is included in release artifacts, and ideally easily installable via kubectl plugin managers like . /sig cli /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis question came up in a docs review of a page referencing () Once this is resolved, please ensure the website is updated to document installation/use of this tool.\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-0dd001c145f11102e969b80c643726dbf14f98f8fe507894193bd7373efd9da7", "text": "fi ###################### <ins> # Convert            # ###################### if kube::test::if_supports_resource \"${deployments}\"; then record_command run_convert_tests fi ###################### </ins> # Delete             # ###################### if kube::test::if_supports_resource \"${configmaps}\" ; then", "commid": "kubernetes_pr_99155"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fa126d79950d466047e6ed1ac3816f4c853174133d960101916fac2981f766f8", "query": "on the new node fails sometimes. The following error appears in the log: on the new node succeeds every time Join a control plane node The node has over 40 GB of free space on its root partition. I some more logging to the following functions: , , , , , , It appears that the ephemeral storage is detected a bit too late: /sig node storage Kubernetes version (use ): 1.20.4, commit Kernel (e.g. ): 4.9.252-1.ph2\n/assign I will try to reproduce it today.\nLocalStorageCapacityIsolation is a feature gate for kubelet. Can you check if you disable it? ReadyCondition will check ephemeral-storage as required capacities if this feature gate is enabled in kubelet configuration. Would you check it first?\n[x] 1.8 alpha ephemeral-storage [x] 1.10 Promote LocalStorageCapacityIsolation feature to beta [x] 1.15 KEPs Quotas for ephemeral-storage for LocalStorageCapacityIsolationFSQuotaMonitoring default to false is Alpha since 1.15 [x] Failed to promote LocalStorageCapacityIsolationFSQuotaMonitoring feature to beta [x] 1.20 Honor disabled LocalStorageCapacityIsolation in scheduling I am no sure whether there is a plan to GA LocalStorageCapacityIsolation?\nI tried to fix it in . Need some testing later.\nIt appears that the pod fails before sees the storage capacity:\nWould you try this ? I build it with on PR branch.\nI tried to apply the PR to 1.20.4. After four successful s, one failed. I got the following error:\n! It means that during the node resource updated the first time, the cadvisor is not available yet. If we wait here, it would be a problem. I would think more of how to fix it.\nHi, Same problem here. I'm using K8s v1.20.4 with CentOS7 (2 cores, 4GB and 20GB storage) Cluster creation with kubeadm init always works, but when I try to add several master nodes with kubeadm join it takes a lot of time waiting for etcd pod to be created. In most of cases, etcd pod never runs. The rest of components (APIserver, controller, scheduler and proxy) exists and works (except APIServer which reboots trying to connect the missing etcd) Checking the kubelet logs in the missing etcd hosts I have found this: Mar 10 14:23:27 kmaster-02 kubelet[9448]: W0310 14:23:27. 9448 ] Failed to admit pod etcd-kmaster-02_kube-system() - Unexpected error while attempting to recover from admission failure: preemption: error finding a set of pods to preempt: no set of running pods found to reclaim resources: [(res: ephemeral-storage, q: ), ] That node have 17GB storage free. If kubelet is restarted, the etcd (pod and container in docker ps -a) appears. If I could help doing something please tell me. I would like to help\nFor anyone who is experiencing this issue and still wants to use kubeadm until it is fixed: You can remove the ephemeral-storage request from the etcd static pod and the join will work. Just make sure that your nodes actually have more than 100MB free storage left. You can reinsert the storage request by patching the etcd manifests after the nodes are up. To patch etcd during a create the following file (the filename matters, the file location doesn't) and use to join additional control plane nodes.\nThanks for the workaround I'm encountering this same issue and the workaround worked for me. Edit: the patch I tried doesn't work though (not sure if this is really a problem). I issued the command: and the response shows that the resource can't be patched this way: There may be another way but I'm still fairly new to Kubernetes so it is not obvious to me at the moment. Anyhow, thanks for the suggestion!\nI updated Add a start-delay of 10 seconds for a condition that the capacity of node ephemeral-storage is 0. Not sure if this will fix it.\nwe are starting to see reports about this every week.\ncc\ncc\nFrom it sounds like the issue is kubeadm etcd ephemeral-storage requests are too big for some environments? So far this is sounding like a kubeadm issue, not a kubernetes issue.\nit seems to be something else. i doubt that users are trying machines that don't satisfy 100Mi. for example, the report in the OP points out that the machine has 40GB.\nI can confirm that the VMs on which I installed k8s control plane components had sufficient disk space when I encountered the problem. I'm running Kubernetes v1.20.4 and kubeadm v1.20.4.\nI think the root cause here sounds right. There is kind of race here. adding delay will help, but it does not have 100% guarantee. Not sure whether it is easy to add logic to make sure capacity is reported correctly before starting pods..\nDid something change in 1.20 regarding the ordering of cadvisor and node startup?\nIf the reason would be a disk problem(or something we can figure out) and the delay can solve it, I think we should add a warning besides the delay.\nWe need to figure out what triggers the race condition. This only happens on some machines. I have not seen this myself.\nWe're able to repro this nearly 100% of the time with Cluster API Provider Azure + k8s 1.20.x + Ubuntu 18.04 + default template, which makes k8s 1.20 pretty much unusable at this point. Trying to see if this repros with other non-Azure cluster-api providers with kubeadm 1.20.\nDoes anyone know why this only repros on and not ? The ephemeral storage resource requirement here is used in common by both and : In practice I can workaround this issue in cluster-api + Azure by adding a sleep command to my spec, but it requires a significant number to make work ~100% of the time (like 90 seconds). Does the flow take significantly longer before it gets to the part where it submits an etcd pod to the apiserver? Is there any other explanation for this being a -only symptom?\ni can see this failing for any static pod with ephemeral storage requests. that is, unless there is proof that this is somehow specific to the kubeadm static pod for etcd that kubeadm deploys.\nI agree that the specific kubeadm-delivered etcd pod is not interesting. (In fact it's very permissive, it's only asking for 100Mi.) What definitely seems to be happening (in Azure) is that kubelet takes a long time to know about its underlying node's ephemeral-storage availability. Kubelet starts: ~2 mins later, it complains that it can't schedule etcd: Again, why does this not repro on nodes created by ?\nit also seems to be an even more scoped problem because it's not reproducible for me locally (i create a number of clusters every day, usually), the kubeadm CI or in other high level projects that use kubeadm (e.g. kind, minikube, etc). we should try to find a common reason / condition from all the reporting users that are seeing this.\nExperiencing same problem on openSuSE Kubic/Tumbletweed snapshot with kubeadm/kubelet 1.20.2, kernel 5.11.15 running on Xen, 2 CPU, 4GB ram 30GB disk (BRTFS)\nProblem consistently appear/disappear when switching between snapshots (Working) and , so a package update in that period has probably triggered this. Following files contains changes between those two snapshots.\nare you suggesting a root cause in underlying Linux storage driver surface area that is adding delay/uncertainty to kubelet's ability to introspect available ephemeral-storage on the node host OS?\nA bit of luck combined with 6th sense i got it narrowed down to systemd update here Looking at the changelog, one item sticks out: Anyone else enabled cgroupsv2 on i.e. the CentOS cases (it needs to be enabled explicitly for that AFAIK)?\nACK on your latest respond regarding unified cgroup hierarchy. Is there a quick, cross-distro way to verify that any folks who are repro'ing have a similar systemd config?\nThe precence of file/dir /sys/fs/cgroup/cgroup.controllers should mean you are using cgroupsv2 ( Ref: ) I can confirm that the file is present on the kubic snapshot which is not working. It is not present on the one that does work. ( I'm using cri-o as runtime which should support cgroupsv2 ) cgroup2 support was introduced for K8S in 1.19 ( ).\nThanks. So tl;dr your working theory is that cgroupsv2 + kubelet ephemeral-storage admission has some pathologies. I'll post quickly with what my repro containerd + Ubuntu 18.04-LTS OS surface area looks like.\nI ran into this issue consistently on Ubuntu 20.04.2 LTS using cri-o but is not present on my systems.\nI can also confirm that cgroupsv2 is not a factor in my repro'ing environment:\nAlso, I'm not using cri-o, containerd here:\nOk - so much for that theory. But still: What I did to narrow it to systemd-update was taking the working kubic snapshot () and run zypper update systemd which updates systemd (along with systemd-sysvinit and udev packages to same version). That consistently made it fail. So I think a pointer to the root-cause might still be hiding somewhere around this changelog - even if it is not cgroupsv2. That part was just a theory (seemed like a \"big\" thing), but the update of systemd package is fairly hard evidence.\nI have identified where these particular symptoms (probably) originate, and cursory testing suggests something like this eliminates the issue: I'll be advocating for a few mins in today's sig-node discussion if any folks following this thread want to chime in. cc\n/sig cluster-lifecycle /triage accepted\nI've also observed that on some occasions the node allocatable storage is in a continual state of reporting \"0\". Restarting kubelet immediately fixed that. More debugging to do....\ndid you manage to reproduce this with an arbitrary static pod that is not the etcd one?\nI was not able to reproduce in a non-kubeadm test, but I suspect that the way kubelet bootstrap is implemented there (and possibly environmental reasons) the static pod handling was always happening after this code executed: (the above is in the containerManager method) kubeadm w/ ephemeral-storage requirements in etcd is the most effective repro at this time\nthe writing of the etcd pod manifest in during is after the kubelet has already started and i wonder if that is contributing to the observed failures. probably not given this is a cadvisor related problem. to verify that i would write an arbitrary static pod manifest with the same request in : before (which also starts the kubelet) right after the kubelet has started if is causing such racy problems i don't think it should be graduated to GA. though, it has been Beta for ~12 releases (on by default), so it's already used everywhere.\nBased on your assessment do you think we should remove the ephemeral-storage requirement from default kubeadm etcd static pod? I can make that change.\nbased on the investigations here (thanks all), it feels like is a feature that may or may not work (for static pods at least). it doesn't feel right to mitigate a kubelet bug on the side of the deployer, but given how many reports there are about this i think it should be done at this point. happy to LGTM approve your PRs. note it must also be backported to all versions in support (back to 1.19). suggesting the following release note: we should keep this issue open, too.\nSounds good. I'll submit a PR soon with the kubeadm change, and I'll continue to drive toward a root cause solution on the kubelet side. I'll bring this up at sig-node tomorrow. Thanks!\nis a possible duplicate of this issue - seeing a CrashLoopBackOff failure for kube-apiserver under a similar scenario to those mentioned here, e.g. failure to join a third control plane node with mentions of in the kubelet logs.\nAn ugly as sin workaroud: (please don't hate me :D )\nIt seems like this could be closed with and related cherry picks now being part of the newest releases? Bumping to 1.21.2 allowed me to remove the hack for etcd and several test deployments have steered clear entirely of the original issue. Thanks\ngreat news. I'd prefer to pin this issue to this PR: That PR will deliver more race condition resilience for all static pod + ephemeral-storage requirement scenarios.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-77e714dd4d9458966f59b16cde4eeda345f839b3a819c7f9ed5b80b43b2b4193", "text": "return err != nil && os.IsNotExist(err) } <ins> // GetCapacity returns node capacity data for \"cpu\", \"memory\", \"ephemeral-storage\", and \"huge-pages*\" // At present this method is only invoked when introspecting ephemeral storage </ins> func (cm *containerManagerImpl) GetCapacity() v1.ResourceList { <ins> if utilfeature.DefaultFeatureGate.Enabled(kubefeatures.LocalStorageCapacityIsolation) { // We store allocatable ephemeral-storage in the capacity property once we Start() the container manager if _, ok := cm.capacity[v1.ResourceEphemeralStorage]; !ok { // If we haven't yet stored the capacity for ephemeral-storage, we can try to fetch it directly from cAdvisor, if cm.cadvisorInterface != nil { rootfs, err := cm.cadvisorInterface.RootFsInfo() if err != nil { klog.ErrorS(err, \"Unable to get rootfs data from cAdvisor interface\") // If the rootfsinfo retrieval from cAdvisor fails for any reason, fallback to returning the capacity property with no ephemeral storage data return cm.capacity } // We don't want to mutate cm.capacity here so we'll manually construct a v1.ResourceList from it, // and add ephemeral-storage capacityWithEphemeralStorage := v1.ResourceList{} for rName, rQuant := range cm.capacity { capacityWithEphemeralStorage[rName] = rQuant } capacityWithEphemeralStorage[v1.ResourceEphemeralStorage] = cadvisor.EphemeralStorageCapacityFromFsInfo(rootfs)[v1.ResourceEphemeralStorage] return capacityWithEphemeralStorage } } } </ins> return cm.capacity }", "commid": "kubernetes_pr_101882"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fa126d79950d466047e6ed1ac3816f4c853174133d960101916fac2981f766f8", "query": "on the new node fails sometimes. The following error appears in the log: on the new node succeeds every time Join a control plane node The node has over 40 GB of free space on its root partition. I some more logging to the following functions: , , , , , , It appears that the ephemeral storage is detected a bit too late: /sig node storage Kubernetes version (use ): 1.20.4, commit Kernel (e.g. ): 4.9.252-1.ph2\n/assign I will try to reproduce it today.\nLocalStorageCapacityIsolation is a feature gate for kubelet. Can you check if you disable it? ReadyCondition will check ephemeral-storage as required capacities if this feature gate is enabled in kubelet configuration. Would you check it first?\n[x] 1.8 alpha ephemeral-storage [x] 1.10 Promote LocalStorageCapacityIsolation feature to beta [x] 1.15 KEPs Quotas for ephemeral-storage for LocalStorageCapacityIsolationFSQuotaMonitoring default to false is Alpha since 1.15 [x] Failed to promote LocalStorageCapacityIsolationFSQuotaMonitoring feature to beta [x] 1.20 Honor disabled LocalStorageCapacityIsolation in scheduling I am no sure whether there is a plan to GA LocalStorageCapacityIsolation?\nI tried to fix it in . Need some testing later.\nIt appears that the pod fails before sees the storage capacity:\nWould you try this ? I build it with on PR branch.\nI tried to apply the PR to 1.20.4. After four successful s, one failed. I got the following error:\n! It means that during the node resource updated the first time, the cadvisor is not available yet. If we wait here, it would be a problem. I would think more of how to fix it.\nHi, Same problem here. I'm using K8s v1.20.4 with CentOS7 (2 cores, 4GB and 20GB storage) Cluster creation with kubeadm init always works, but when I try to add several master nodes with kubeadm join it takes a lot of time waiting for etcd pod to be created. In most of cases, etcd pod never runs. The rest of components (APIserver, controller, scheduler and proxy) exists and works (except APIServer which reboots trying to connect the missing etcd) Checking the kubelet logs in the missing etcd hosts I have found this: Mar 10 14:23:27 kmaster-02 kubelet[9448]: W0310 14:23:27. 9448 ] Failed to admit pod etcd-kmaster-02_kube-system() - Unexpected error while attempting to recover from admission failure: preemption: error finding a set of pods to preempt: no set of running pods found to reclaim resources: [(res: ephemeral-storage, q: ), ] That node have 17GB storage free. If kubelet is restarted, the etcd (pod and container in docker ps -a) appears. If I could help doing something please tell me. I would like to help\nFor anyone who is experiencing this issue and still wants to use kubeadm until it is fixed: You can remove the ephemeral-storage request from the etcd static pod and the join will work. Just make sure that your nodes actually have more than 100MB free storage left. You can reinsert the storage request by patching the etcd manifests after the nodes are up. To patch etcd during a create the following file (the filename matters, the file location doesn't) and use to join additional control plane nodes.\nThanks for the workaround I'm encountering this same issue and the workaround worked for me. Edit: the patch I tried doesn't work though (not sure if this is really a problem). I issued the command: and the response shows that the resource can't be patched this way: There may be another way but I'm still fairly new to Kubernetes so it is not obvious to me at the moment. Anyhow, thanks for the suggestion!\nI updated Add a start-delay of 10 seconds for a condition that the capacity of node ephemeral-storage is 0. Not sure if this will fix it.\nwe are starting to see reports about this every week.\ncc\ncc\nFrom it sounds like the issue is kubeadm etcd ephemeral-storage requests are too big for some environments? So far this is sounding like a kubeadm issue, not a kubernetes issue.\nit seems to be something else. i doubt that users are trying machines that don't satisfy 100Mi. for example, the report in the OP points out that the machine has 40GB.\nI can confirm that the VMs on which I installed k8s control plane components had sufficient disk space when I encountered the problem. I'm running Kubernetes v1.20.4 and kubeadm v1.20.4.\nI think the root cause here sounds right. There is kind of race here. adding delay will help, but it does not have 100% guarantee. Not sure whether it is easy to add logic to make sure capacity is reported correctly before starting pods..\nDid something change in 1.20 regarding the ordering of cadvisor and node startup?\nIf the reason would be a disk problem(or something we can figure out) and the delay can solve it, I think we should add a warning besides the delay.\nWe need to figure out what triggers the race condition. This only happens on some machines. I have not seen this myself.\nWe're able to repro this nearly 100% of the time with Cluster API Provider Azure + k8s 1.20.x + Ubuntu 18.04 + default template, which makes k8s 1.20 pretty much unusable at this point. Trying to see if this repros with other non-Azure cluster-api providers with kubeadm 1.20.\nDoes anyone know why this only repros on and not ? The ephemeral storage resource requirement here is used in common by both and : In practice I can workaround this issue in cluster-api + Azure by adding a sleep command to my spec, but it requires a significant number to make work ~100% of the time (like 90 seconds). Does the flow take significantly longer before it gets to the part where it submits an etcd pod to the apiserver? Is there any other explanation for this being a -only symptom?\ni can see this failing for any static pod with ephemeral storage requests. that is, unless there is proof that this is somehow specific to the kubeadm static pod for etcd that kubeadm deploys.\nI agree that the specific kubeadm-delivered etcd pod is not interesting. (In fact it's very permissive, it's only asking for 100Mi.) What definitely seems to be happening (in Azure) is that kubelet takes a long time to know about its underlying node's ephemeral-storage availability. Kubelet starts: ~2 mins later, it complains that it can't schedule etcd: Again, why does this not repro on nodes created by ?\nit also seems to be an even more scoped problem because it's not reproducible for me locally (i create a number of clusters every day, usually), the kubeadm CI or in other high level projects that use kubeadm (e.g. kind, minikube, etc). we should try to find a common reason / condition from all the reporting users that are seeing this.\nExperiencing same problem on openSuSE Kubic/Tumbletweed snapshot with kubeadm/kubelet 1.20.2, kernel 5.11.15 running on Xen, 2 CPU, 4GB ram 30GB disk (BRTFS)\nProblem consistently appear/disappear when switching between snapshots (Working) and , so a package update in that period has probably triggered this. Following files contains changes between those two snapshots.\nare you suggesting a root cause in underlying Linux storage driver surface area that is adding delay/uncertainty to kubelet's ability to introspect available ephemeral-storage on the node host OS?\nA bit of luck combined with 6th sense i got it narrowed down to systemd update here Looking at the changelog, one item sticks out: Anyone else enabled cgroupsv2 on i.e. the CentOS cases (it needs to be enabled explicitly for that AFAIK)?\nACK on your latest respond regarding unified cgroup hierarchy. Is there a quick, cross-distro way to verify that any folks who are repro'ing have a similar systemd config?\nThe precence of file/dir /sys/fs/cgroup/cgroup.controllers should mean you are using cgroupsv2 ( Ref: ) I can confirm that the file is present on the kubic snapshot which is not working. It is not present on the one that does work. ( I'm using cri-o as runtime which should support cgroupsv2 ) cgroup2 support was introduced for K8S in 1.19 ( ).\nThanks. So tl;dr your working theory is that cgroupsv2 + kubelet ephemeral-storage admission has some pathologies. I'll post quickly with what my repro containerd + Ubuntu 18.04-LTS OS surface area looks like.\nI ran into this issue consistently on Ubuntu 20.04.2 LTS using cri-o but is not present on my systems.\nI can also confirm that cgroupsv2 is not a factor in my repro'ing environment:\nAlso, I'm not using cri-o, containerd here:\nOk - so much for that theory. But still: What I did to narrow it to systemd-update was taking the working kubic snapshot () and run zypper update systemd which updates systemd (along with systemd-sysvinit and udev packages to same version). That consistently made it fail. So I think a pointer to the root-cause might still be hiding somewhere around this changelog - even if it is not cgroupsv2. That part was just a theory (seemed like a \"big\" thing), but the update of systemd package is fairly hard evidence.\nI have identified where these particular symptoms (probably) originate, and cursory testing suggests something like this eliminates the issue: I'll be advocating for a few mins in today's sig-node discussion if any folks following this thread want to chime in. cc\n/sig cluster-lifecycle /triage accepted\nI've also observed that on some occasions the node allocatable storage is in a continual state of reporting \"0\". Restarting kubelet immediately fixed that. More debugging to do....\ndid you manage to reproduce this with an arbitrary static pod that is not the etcd one?\nI was not able to reproduce in a non-kubeadm test, but I suspect that the way kubelet bootstrap is implemented there (and possibly environmental reasons) the static pod handling was always happening after this code executed: (the above is in the containerManager method) kubeadm w/ ephemeral-storage requirements in etcd is the most effective repro at this time\nthe writing of the etcd pod manifest in during is after the kubelet has already started and i wonder if that is contributing to the observed failures. probably not given this is a cadvisor related problem. to verify that i would write an arbitrary static pod manifest with the same request in : before (which also starts the kubelet) right after the kubelet has started if is causing such racy problems i don't think it should be graduated to GA. though, it has been Beta for ~12 releases (on by default), so it's already used everywhere.\nBased on your assessment do you think we should remove the ephemeral-storage requirement from default kubeadm etcd static pod? I can make that change.\nbased on the investigations here (thanks all), it feels like is a feature that may or may not work (for static pods at least). it doesn't feel right to mitigate a kubelet bug on the side of the deployer, but given how many reports there are about this i think it should be done at this point. happy to LGTM approve your PRs. note it must also be backported to all versions in support (back to 1.19). suggesting the following release note: we should keep this issue open, too.\nSounds good. I'll submit a PR soon with the kubeadm change, and I'll continue to drive toward a root cause solution on the kubelet side. I'll bring this up at sig-node tomorrow. Thanks!\nis a possible duplicate of this issue - seeing a CrashLoopBackOff failure for kube-apiserver under a similar scenario to those mentioned here, e.g. failure to join a third control plane node with mentions of in the kubelet logs.\nAn ugly as sin workaroud: (please don't hate me :D )\nIt seems like this could be closed with and related cherry picks now being part of the newest releases? Bumping to 1.21.2 allowed me to remove the hack for etcd and several test deployments have steered clear entirely of the original issue. Thanks\ngreat news. I'd prefer to pin this issue to this PR: That PR will deliver more race condition resilience for all static pod + ephemeral-storage requirement scenarios.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-0e2ddbba1e82ebfa544b28834ca3ea3550b89335d80222b3f486015e5101578f", "text": "package cm import ( <ins> \"errors\" </ins> \"io/ioutil\" \"os\" \"path\" \"testing\" <ins> gomock \"github.com/golang/mock/gomock\" cadvisorapiv2 \"github.com/google/cadvisor/info/v2\" utilfeature \"k8s.io/apiserver/pkg/util/feature\" featuregatetesting \"k8s.io/component-base/featuregate/testing\" kubefeatures \"k8s.io/kubernetes/pkg/features\" </ins> \"github.com/opencontainers/runc/libcontainer/cgroups\" \"github.com/stretchr/testify/assert\" \"github.com/stretchr/testify/require\" <ins> v1 \"k8s.io/api/core/v1\" \"k8s.io/apimachinery/pkg/api/resource\" cadvisortest \"k8s.io/kubernetes/pkg/kubelet/cadvisor/testing\" </ins> \"k8s.io/mount-utils\" )", "commid": "kubernetes_pr_101882"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fa126d79950d466047e6ed1ac3816f4c853174133d960101916fac2981f766f8", "query": "on the new node fails sometimes. The following error appears in the log: on the new node succeeds every time Join a control plane node The node has over 40 GB of free space on its root partition. I some more logging to the following functions: , , , , , , It appears that the ephemeral storage is detected a bit too late: /sig node storage Kubernetes version (use ): 1.20.4, commit Kernel (e.g. ): 4.9.252-1.ph2\n/assign I will try to reproduce it today.\nLocalStorageCapacityIsolation is a feature gate for kubelet. Can you check if you disable it? ReadyCondition will check ephemeral-storage as required capacities if this feature gate is enabled in kubelet configuration. Would you check it first?\n[x] 1.8 alpha ephemeral-storage [x] 1.10 Promote LocalStorageCapacityIsolation feature to beta [x] 1.15 KEPs Quotas for ephemeral-storage for LocalStorageCapacityIsolationFSQuotaMonitoring default to false is Alpha since 1.15 [x] Failed to promote LocalStorageCapacityIsolationFSQuotaMonitoring feature to beta [x] 1.20 Honor disabled LocalStorageCapacityIsolation in scheduling I am no sure whether there is a plan to GA LocalStorageCapacityIsolation?\nI tried to fix it in . Need some testing later.\nIt appears that the pod fails before sees the storage capacity:\nWould you try this ? I build it with on PR branch.\nI tried to apply the PR to 1.20.4. After four successful s, one failed. I got the following error:\n! It means that during the node resource updated the first time, the cadvisor is not available yet. If we wait here, it would be a problem. I would think more of how to fix it.\nHi, Same problem here. I'm using K8s v1.20.4 with CentOS7 (2 cores, 4GB and 20GB storage) Cluster creation with kubeadm init always works, but when I try to add several master nodes with kubeadm join it takes a lot of time waiting for etcd pod to be created. In most of cases, etcd pod never runs. The rest of components (APIserver, controller, scheduler and proxy) exists and works (except APIServer which reboots trying to connect the missing etcd) Checking the kubelet logs in the missing etcd hosts I have found this: Mar 10 14:23:27 kmaster-02 kubelet[9448]: W0310 14:23:27. 9448 ] Failed to admit pod etcd-kmaster-02_kube-system() - Unexpected error while attempting to recover from admission failure: preemption: error finding a set of pods to preempt: no set of running pods found to reclaim resources: [(res: ephemeral-storage, q: ), ] That node have 17GB storage free. If kubelet is restarted, the etcd (pod and container in docker ps -a) appears. If I could help doing something please tell me. I would like to help\nFor anyone who is experiencing this issue and still wants to use kubeadm until it is fixed: You can remove the ephemeral-storage request from the etcd static pod and the join will work. Just make sure that your nodes actually have more than 100MB free storage left. You can reinsert the storage request by patching the etcd manifests after the nodes are up. To patch etcd during a create the following file (the filename matters, the file location doesn't) and use to join additional control plane nodes.\nThanks for the workaround I'm encountering this same issue and the workaround worked for me. Edit: the patch I tried doesn't work though (not sure if this is really a problem). I issued the command: and the response shows that the resource can't be patched this way: There may be another way but I'm still fairly new to Kubernetes so it is not obvious to me at the moment. Anyhow, thanks for the suggestion!\nI updated Add a start-delay of 10 seconds for a condition that the capacity of node ephemeral-storage is 0. Not sure if this will fix it.\nwe are starting to see reports about this every week.\ncc\ncc\nFrom it sounds like the issue is kubeadm etcd ephemeral-storage requests are too big for some environments? So far this is sounding like a kubeadm issue, not a kubernetes issue.\nit seems to be something else. i doubt that users are trying machines that don't satisfy 100Mi. for example, the report in the OP points out that the machine has 40GB.\nI can confirm that the VMs on which I installed k8s control plane components had sufficient disk space when I encountered the problem. I'm running Kubernetes v1.20.4 and kubeadm v1.20.4.\nI think the root cause here sounds right. There is kind of race here. adding delay will help, but it does not have 100% guarantee. Not sure whether it is easy to add logic to make sure capacity is reported correctly before starting pods..\nDid something change in 1.20 regarding the ordering of cadvisor and node startup?\nIf the reason would be a disk problem(or something we can figure out) and the delay can solve it, I think we should add a warning besides the delay.\nWe need to figure out what triggers the race condition. This only happens on some machines. I have not seen this myself.\nWe're able to repro this nearly 100% of the time with Cluster API Provider Azure + k8s 1.20.x + Ubuntu 18.04 + default template, which makes k8s 1.20 pretty much unusable at this point. Trying to see if this repros with other non-Azure cluster-api providers with kubeadm 1.20.\nDoes anyone know why this only repros on and not ? The ephemeral storage resource requirement here is used in common by both and : In practice I can workaround this issue in cluster-api + Azure by adding a sleep command to my spec, but it requires a significant number to make work ~100% of the time (like 90 seconds). Does the flow take significantly longer before it gets to the part where it submits an etcd pod to the apiserver? Is there any other explanation for this being a -only symptom?\ni can see this failing for any static pod with ephemeral storage requests. that is, unless there is proof that this is somehow specific to the kubeadm static pod for etcd that kubeadm deploys.\nI agree that the specific kubeadm-delivered etcd pod is not interesting. (In fact it's very permissive, it's only asking for 100Mi.) What definitely seems to be happening (in Azure) is that kubelet takes a long time to know about its underlying node's ephemeral-storage availability. Kubelet starts: ~2 mins later, it complains that it can't schedule etcd: Again, why does this not repro on nodes created by ?\nit also seems to be an even more scoped problem because it's not reproducible for me locally (i create a number of clusters every day, usually), the kubeadm CI or in other high level projects that use kubeadm (e.g. kind, minikube, etc). we should try to find a common reason / condition from all the reporting users that are seeing this.\nExperiencing same problem on openSuSE Kubic/Tumbletweed snapshot with kubeadm/kubelet 1.20.2, kernel 5.11.15 running on Xen, 2 CPU, 4GB ram 30GB disk (BRTFS)\nProblem consistently appear/disappear when switching between snapshots (Working) and , so a package update in that period has probably triggered this. Following files contains changes between those two snapshots.\nare you suggesting a root cause in underlying Linux storage driver surface area that is adding delay/uncertainty to kubelet's ability to introspect available ephemeral-storage on the node host OS?\nA bit of luck combined with 6th sense i got it narrowed down to systemd update here Looking at the changelog, one item sticks out: Anyone else enabled cgroupsv2 on i.e. the CentOS cases (it needs to be enabled explicitly for that AFAIK)?\nACK on your latest respond regarding unified cgroup hierarchy. Is there a quick, cross-distro way to verify that any folks who are repro'ing have a similar systemd config?\nThe precence of file/dir /sys/fs/cgroup/cgroup.controllers should mean you are using cgroupsv2 ( Ref: ) I can confirm that the file is present on the kubic snapshot which is not working. It is not present on the one that does work. ( I'm using cri-o as runtime which should support cgroupsv2 ) cgroup2 support was introduced for K8S in 1.19 ( ).\nThanks. So tl;dr your working theory is that cgroupsv2 + kubelet ephemeral-storage admission has some pathologies. I'll post quickly with what my repro containerd + Ubuntu 18.04-LTS OS surface area looks like.\nI ran into this issue consistently on Ubuntu 20.04.2 LTS using cri-o but is not present on my systems.\nI can also confirm that cgroupsv2 is not a factor in my repro'ing environment:\nAlso, I'm not using cri-o, containerd here:\nOk - so much for that theory. But still: What I did to narrow it to systemd-update was taking the working kubic snapshot () and run zypper update systemd which updates systemd (along with systemd-sysvinit and udev packages to same version). That consistently made it fail. So I think a pointer to the root-cause might still be hiding somewhere around this changelog - even if it is not cgroupsv2. That part was just a theory (seemed like a \"big\" thing), but the update of systemd package is fairly hard evidence.\nI have identified where these particular symptoms (probably) originate, and cursory testing suggests something like this eliminates the issue: I'll be advocating for a few mins in today's sig-node discussion if any folks following this thread want to chime in. cc\n/sig cluster-lifecycle /triage accepted\nI've also observed that on some occasions the node allocatable storage is in a continual state of reporting \"0\". Restarting kubelet immediately fixed that. More debugging to do....\ndid you manage to reproduce this with an arbitrary static pod that is not the etcd one?\nI was not able to reproduce in a non-kubeadm test, but I suspect that the way kubelet bootstrap is implemented there (and possibly environmental reasons) the static pod handling was always happening after this code executed: (the above is in the containerManager method) kubeadm w/ ephemeral-storage requirements in etcd is the most effective repro at this time\nthe writing of the etcd pod manifest in during is after the kubelet has already started and i wonder if that is contributing to the observed failures. probably not given this is a cadvisor related problem. to verify that i would write an arbitrary static pod manifest with the same request in : before (which also starts the kubelet) right after the kubelet has started if is causing such racy problems i don't think it should be graduated to GA. though, it has been Beta for ~12 releases (on by default), so it's already used everywhere.\nBased on your assessment do you think we should remove the ephemeral-storage requirement from default kubeadm etcd static pod? I can make that change.\nbased on the investigations here (thanks all), it feels like is a feature that may or may not work (for static pods at least). it doesn't feel right to mitigate a kubelet bug on the side of the deployer, but given how many reports there are about this i think it should be done at this point. happy to LGTM approve your PRs. note it must also be backported to all versions in support (back to 1.19). suggesting the following release note: we should keep this issue open, too.\nSounds good. I'll submit a PR soon with the kubeadm change, and I'll continue to drive toward a root cause solution on the kubelet side. I'll bring this up at sig-node tomorrow. Thanks!\nis a possible duplicate of this issue - seeing a CrashLoopBackOff failure for kube-apiserver under a similar scenario to those mentioned here, e.g. failure to join a third control plane node with mentions of in the kubelet logs.\nAn ugly as sin workaroud: (please don't hate me :D )\nIt seems like this could be closed with and related cherry picks now being part of the newest releases? Bumping to 1.21.2 allowed me to remove the hack for etcd and several test deployments have steered clear entirely of the original issue. Thanks\ngreat news. I'd prefer to pin this issue to this PR: That PR will deliver more race condition resilience for all static pod + ephemeral-storage requirement scenarios.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-cd8becd23a8ca5fccf482224d545968fe613fd18bb97de29eafe8e2c1229ba0c", "text": "assert.NoError(t, err) assert.True(t, f.cpuHardcapping, \"cpu hardcapping is expected to be enabled\") } <ins> func TestGetCapacity(t *testing.T) { ephemeralStorageFromCapacity := int64(2000) ephemeralStorageFromCadvisor := int64(8000) mockCtrl := gomock.NewController(t) defer mockCtrl.Finish() mockCtrlError := gomock.NewController(t) defer mockCtrlError.Finish() mockCadvisor := cadvisortest.NewMockInterface(mockCtrl) rootfs := cadvisorapiv2.FsInfo{ Capacity: 8000, } mockCadvisor.EXPECT().RootFsInfo().Return(rootfs, nil) mockCadvisorError := cadvisortest.NewMockInterface(mockCtrlError) mockCadvisorError.EXPECT().RootFsInfo().Return(cadvisorapiv2.FsInfo{}, errors.New(\"Unable to get rootfs data from cAdvisor interface\")) cases := []struct { name                                string cm                                  *containerManagerImpl expectedResourceQuantity            *resource.Quantity expectedNoEphemeralStorage          bool enableLocalStorageCapacityIsolation bool }{ { name: \"capacity property has ephemeral-storage\", cm: &containerManagerImpl{ cadvisorInterface: mockCadvisor, capacity: v1.ResourceList{ v1.ResourceEphemeralStorage: *resource.NewQuantity(ephemeralStorageFromCapacity, resource.BinarySI), }, }, expectedResourceQuantity:            resource.NewQuantity(ephemeralStorageFromCapacity, resource.BinarySI), expectedNoEphemeralStorage:          false, enableLocalStorageCapacityIsolation: true, }, { name: \"capacity property does not have ephemeral-storage\", cm: &containerManagerImpl{ cadvisorInterface: mockCadvisor, capacity:          v1.ResourceList{}, }, expectedResourceQuantity:            resource.NewQuantity(ephemeralStorageFromCadvisor, resource.BinarySI), expectedNoEphemeralStorage:          false, enableLocalStorageCapacityIsolation: true, }, { name: \"capacity property does not have ephemeral-storage, error from rootfs\", cm: &containerManagerImpl{ cadvisorInterface: mockCadvisorError, capacity:          v1.ResourceList{}, }, expectedNoEphemeralStorage:          true, enableLocalStorageCapacityIsolation: true, }, { name: \"capacity property does not have ephemeral-storage, cadvisor interface is nil\", cm: &containerManagerImpl{ cadvisorInterface: nil, capacity:          v1.ResourceList{}, }, expectedNoEphemeralStorage:          true, enableLocalStorageCapacityIsolation: true, }, { name: \"LocalStorageCapacityIsolation feature flag is disabled\", cm: &containerManagerImpl{ cadvisorInterface: mockCadvisor, capacity: v1.ResourceList{ v1.ResourceCPU:    resource.MustParse(\"4\"), v1.ResourceMemory: resource.MustParse(\"16G\"), }, }, expectedNoEphemeralStorage:          true, enableLocalStorageCapacityIsolation: false, }, } for _, c := range cases { t.Run(c.name, func(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, kubefeatures.LocalStorageCapacityIsolation, c.enableLocalStorageCapacityIsolation)() ret := c.cm.GetCapacity() if v, exists := ret[v1.ResourceEphemeralStorage]; !exists { if !c.expectedNoEphemeralStorage { t.Errorf(\"did not get any ephemeral storage data\") } } else { if v.Value() != c.expectedResourceQuantity.Value() { t.Errorf(\"got unexpected %s value, expected %d, got %d\", v1.ResourceEphemeralStorage, c.expectedResourceQuantity.Value(), v.Value()) } } }) } } </ins>", "commid": "kubernetes_pr_101882"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a06ff54733d6ac38b4f9939973a6ee6122f6dc6b2f472cc33182e26504501d9f", "query": "Currently whenever a vSphere volume is provisioned, we are looking at all nodes in the cluster and then fetching their hosts and then their datastores and then ensuring that selected datastore in present on all the nodes. This is done every time a new PVC is provisioned. It can be pretty expensive in large clusters and number of involved API calls can be big. /sig storage /area vsphere cc\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : Currently whenever a vSphere volume is provisioned, we are looking at all nodes in the cluster and then fetching their hosts and then their datastores and then ensuring that selected datastore in present on all the nodes. This is done every time a new PVC is provisioned. /area vsphere Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-a5a73cb282789ffac91ee292b78f9d6173bd8f476b668b81b784d4ef8a35c24a", "text": "<ins> // +build !providerless /* Copyright 2021 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package vsphere import ( \"context\" \"fmt\" \"github.com/vmware/govmomi/property\" \"github.com/vmware/govmomi/vim25/mo\" \"github.com/vmware/govmomi/vim25/types\" \"k8s.io/klog/v2\" \"k8s.io/legacy-cloud-providers/vsphere/vclib\" ) type sharedDatastore struct { nodeManager         *NodeManager candidateDatastores []*vclib.DatastoreInfo } type hostInfo struct { hostUUID   string hostMOID   string datacenter string } const ( summary       = \"summary\" runtimeHost   = \"summary.runtime.host\" hostsProperty = \"host\" nameProperty  = \"name\" ) func (shared *sharedDatastore) getSharedDatastore(ctcx context.Context) (*vclib.DatastoreInfo, error) { nodes := shared.nodeManager.getNodes() // Segregate nodes according to VC-DC dcNodes := make(map[string][]NodeInfo) nodeHosts := make(map[string]hostInfo) for nodeName, node := range nodes { nodeInfo, err := shared.nodeManager.GetNodeInfoWithNodeObject(node) if err != nil { return nil, fmt.Errorf(\"unable to find node %s: %v\", nodeName, err) } vcDC := nodeInfo.vcServer + nodeInfo.dataCenter.String() dcNodes[vcDC] = append(dcNodes[vcDC], nodeInfo) } for vcDC, nodes := range dcNodes { var hostInfos []hostInfo var err error hostInfos, err = shared.getNodeHosts(ctcx, nodes, vcDC) if err != nil { if vclib.IsManagedObjectNotFoundError(err) { klog.Warningf(\"SharedHost.getSharedDatastore: batch fetching of hosts failed - switching to fetching them individually.\") hostInfos, err = shared.getEachNodeHost(ctcx, nodes, vcDC) if err != nil { klog.Errorf(\"SharedHost.getSharedDatastore: error fetching node hosts individually: %v\", err) return nil, err } } else { return nil, err } } for _, host := range hostInfos { hostDCName := fmt.Sprintf(\"%s/%s\", host.datacenter, host.hostMOID) nodeHosts[hostDCName] = host } } if len(nodeHosts) < 1 { msg := fmt.Sprintf(\"SharedHost.getSharedDatastore unable to find hosts associated with nodes\") klog.Error(msg) return nil, fmt.Errorf(\"\") } for _, datastoreInfo := range shared.candidateDatastores { dataStoreHosts, err := shared.getAttachedHosts(ctcx, datastoreInfo.Datastore) if err != nil { msg := fmt.Sprintf(\"error finding attached hosts to datastore %s: %v\", datastoreInfo.Name(), err) klog.Error(msg) return nil, fmt.Errorf(msg) } if shared.isIncluded(dataStoreHosts, nodeHosts) { return datastoreInfo, nil } } return nil, fmt.Errorf(\"SharedHost.getSharedDatastore: unable to find any shared datastores\") } // check if all of the nodeHosts are included in the dataStoreHosts func (shared *sharedDatastore) isIncluded(dataStoreHosts []hostInfo, nodeHosts map[string]hostInfo) bool { result := true for _, host := range nodeHosts { hostFound := false for _, targetHost := range dataStoreHosts { if host.hostUUID == targetHost.hostUUID && host.hostMOID == targetHost.hostMOID { hostFound = true } } if !hostFound { result = false } } return result } func (shared *sharedDatastore) getEachNodeHost(ctx context.Context, nodes []NodeInfo, dcVC string) ([]hostInfo, error) { var hosts []hostInfo for _, node := range nodes { host, err := node.vm.GetHost(ctx) if err != nil { klog.Errorf(\"SharedHost.getEachNodeHost: unable to find host for vm %s: %v\", node.vm.InventoryPath, err) return nil, err } hosts = append(hosts, hostInfo{ hostUUID:   host.Summary.Hardware.Uuid, hostMOID:   host.Summary.Host.String(), datacenter: node.dataCenter.String(), }) } return hosts, nil } func (shared *sharedDatastore) getNodeHosts(ctx context.Context, nodes []NodeInfo, dcVC string) ([]hostInfo, error) { var vmRefs []types.ManagedObjectReference if len(nodes) < 1 { return nil, fmt.Errorf(\"no nodes found for dc-vc: %s\", dcVC) } var nodeInfo NodeInfo for _, n := range nodes { nodeInfo = n vmRefs = append(vmRefs, n.vm.Reference()) } pc := property.DefaultCollector(nodeInfo.dataCenter.Client()) var vmoList []mo.VirtualMachine err := pc.Retrieve(ctx, vmRefs, []string{nameProperty, runtimeHost}, &vmoList) if err != nil { klog.Errorf(\"SharedHost.getNodeHosts: unable to fetch vms from datacenter %s: %w\", nodeInfo.dataCenter.String(), err) return nil, err } var hostMoList []mo.HostSystem var hostRefs []types.ManagedObjectReference for _, vmo := range vmoList { if vmo.Summary.Runtime.Host == nil { msg := fmt.Sprintf(\"SharedHost.getNodeHosts: no host associated with vm %s\", vmo.Name) klog.Error(msg) return nil, fmt.Errorf(msg) } hostRefs = append(hostRefs, vmo.Summary.Runtime.Host.Reference()) } pc = property.DefaultCollector(nodeInfo.dataCenter.Client()) err = pc.Retrieve(ctx, hostRefs, []string{summary}, &hostMoList) if err != nil { klog.Errorf(\"SharedHost.getNodeHosts: unable to fetch hosts from datacenter %s: %w\", nodeInfo.dataCenter.String(), err) return nil, err } var hosts []hostInfo for _, host := range hostMoList { hosts = append(hosts, hostInfo{hostMOID: host.Summary.Host.String(), hostUUID: host.Summary.Hardware.Uuid, datacenter: nodeInfo.dataCenter.String()}) } return hosts, nil } func (shared *sharedDatastore) getAttachedHosts(ctx context.Context, datastore *vclib.Datastore) ([]hostInfo, error) { var ds mo.Datastore pc := property.DefaultCollector(datastore.Client()) err := pc.RetrieveOne(ctx, datastore.Reference(), []string{hostsProperty}, &ds) if err != nil { return nil, err } mounts := make(map[types.ManagedObjectReference]types.DatastoreHostMount) var refs []types.ManagedObjectReference for _, host := range ds.Host { refs = append(refs, host.Key) mounts[host.Key] = host } var hs []mo.HostSystem err = pc.Retrieve(ctx, refs, []string{summary}, &hs) if err != nil { return nil, err } var hosts []hostInfo for _, h := range hs { hosts = append(hosts, hostInfo{hostUUID: h.Summary.Hardware.Uuid, hostMOID: h.Summary.Host.String()}) } return hosts, nil } </ins>", "commid": "kubernetes_pr_100054"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a06ff54733d6ac38b4f9939973a6ee6122f6dc6b2f472cc33182e26504501d9f", "query": "Currently whenever a vSphere volume is provisioned, we are looking at all nodes in the cluster and then fetching their hosts and then their datastores and then ensuring that selected datastore in present on all the nodes. This is done every time a new PVC is provisioned. It can be pretty expensive in large clusters and number of involved API calls can be big. /sig storage /area vsphere cc\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : Currently whenever a vSphere volume is provisioned, we are looking at all nodes in the cluster and then fetching their hosts and then their datastores and then ensuring that selected datastore in present on all the nodes. This is done every time a new PVC is provisioned. /area vsphere Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-9c432942f6e9b7776a5ccba0a8bfe7bbda38dbef54e885786f43f73f2790dffa", "text": "return diskUUID, nil } <ins> // GetHost returns host of the virtual machine func (vm *VirtualMachine) GetHost(ctx context.Context) (mo.HostSystem, error) { host, err := vm.HostSystem(ctx) var hostSystemMo mo.HostSystem if err != nil { klog.Errorf(\"Failed to get host system for VM: %q. err: %+v\", vm.InventoryPath, err) return hostSystemMo, err } s := object.NewSearchIndex(vm.Client()) err = s.Properties(ctx, host.Reference(), []string{\"summary\"}, &hostSystemMo) if err != nil { klog.Errorf(\"Failed to retrieve datastores for host: %+v. err: %+v\", host, err) return hostSystemMo, err } return hostSystemMo, nil } </ins> // DetachDisk detaches the disk specified by vmDiskPath func (vm *VirtualMachine) DetachDisk(ctx context.Context, vmDiskPath string) error { device, err := vm.getVirtualDeviceByPath(ctx, vmDiskPath)", "commid": "kubernetes_pr_100054"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a06ff54733d6ac38b4f9939973a6ee6122f6dc6b2f472cc33182e26504501d9f", "query": "Currently whenever a vSphere volume is provisioned, we are looking at all nodes in the cluster and then fetching their hosts and then their datastores and then ensuring that selected datastore in present on all the nodes. This is done every time a new PVC is provisioned. It can be pretty expensive in large clusters and number of involved API calls can be big. /sig storage /area vsphere cc\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : Currently whenever a vSphere volume is provisioned, we are looking at all nodes in the cluster and then fetching their hosts and then their datastores and then ensuring that selected datastore in present on all the nodes. This is done every time a new PVC is provisioned. /area vsphere Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-a07a58a40735b16e7d1eb38ec98a73cc3281e8082e9009305a041c2d56f1c710", "text": "if len(zonesToSearch) == 0 { // If zone is not provided, get the shared datastore across all node VMs. klog.V(4).Infof(\"Validating if datastore %s is shared across all node VMs\", datastoreName) <del> sharedDsList, err = getSharedDatastoresInK8SCluster(ctx, vs.nodeManager) </del> <ins> sharedDSFinder := &sharedDatastore{ nodeManager:         vs.nodeManager, candidateDatastores: candidateDatastoreInfos, } datastoreInfo, err = sharedDSFinder.getSharedDatastore(ctx) </ins> if err != nil { klog.Errorf(\"Failed to get shared datastore: %+v\", err) return \"\", err } <del> // Prepare error msg to be used later, if required. err = fmt.Errorf(\"The specified datastore %s is not a shared datastore across node VMs\", datastoreName) </del> <ins> if datastoreInfo == nil { err = fmt.Errorf(\"The specified datastore %s is not a shared datastore across node VMs\", datastoreName) klog.Error(err) return \"\", err } </ins> } else { // If zone is provided, get the shared datastores in that zone. klog.V(4).Infof(\"Validating if datastore %s is in zone %s \", datastoreName, zonesToSearch)", "commid": "kubernetes_pr_100054"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a06ff54733d6ac38b4f9939973a6ee6122f6dc6b2f472cc33182e26504501d9f", "query": "Currently whenever a vSphere volume is provisioned, we are looking at all nodes in the cluster and then fetching their hosts and then their datastores and then ensuring that selected datastore in present on all the nodes. This is done every time a new PVC is provisioned. It can be pretty expensive in large clusters and number of involved API calls can be big. /sig storage /area vsphere cc\nThe label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : Currently whenever a vSphere volume is provisioned, we are looking at all nodes in the cluster and then fetching their hosts and then their datastores and then ensuring that selected datastore in present on all the nodes. This is done every time a new PVC is provisioned. /area vsphere Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-6300f762dea7ec46943f7f1621bb33320c02bc30a152a4d9834d2dad4f721b95", "text": "klog.Errorf(\"Failed to find a shared datastore matching zone %s. err: %+v\", zonesToSearch, err) return \"\", err } <del> // Prepare error msg to be used later, if required. err = fmt.Errorf(\"The specified datastore %s does not match the provided zones : %s\", datastoreName, zonesToSearch) } found := false // Check if the selected datastore belongs to the list of shared datastores computed. for _, sharedDs := range sharedDsList { if datastoreInfo, found = candidateDatastores[sharedDs.Info.Url]; found { klog.V(4).Infof(\"Datastore validation succeeded\") found = true break </del> <ins> found := false for _, sharedDs := range sharedDsList { if datastoreInfo, found = candidateDatastores[sharedDs.Info.Url]; found { klog.V(4).Infof(\"Datastore validation succeeded\") found = true break } } if !found { err = fmt.Errorf(\"The specified datastore %s does not match the provided zones : %s\", datastoreName, zonesToSearch) klog.Error(err) return \"\", err </ins> } <del> } if !found { klog.Error(err) return \"\", err </del> } } }", "commid": "kubernetes_pr_100054"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-947136ea8248fb75219d4a2780e225b9730b8db4ff2d00fa7ad31a0a1295b1db", "query": "Seen while running on If hack/update- fails, the output should make it clear Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /area code-organization /sig architecture /cc /assign\nMaybe we can add a to check the exit code.\n/cc\nsomething like that seems like a good idea\nusually when we want to do stuff like that we instead record the exit code for specific steps with something like so we can check after and inform the user of the specific failure (and suggest what to do), then\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-b4609efa9b0f71950556496fa61a473ef3376255609e8d5d6d69752488d5aa3d", "text": "LOG_FILE=\"${LOG_FILE:-${TMP_DIR}/update-vendor.log}\" kube::log::status \"logfile at ${LOG_FILE}\" <ins> function finish { ret=$? if [[ ${ret} != 0 ]]; then echo \"An error has occurred. Please see more details in ${LOG_FILE}\" fi exit ${ret} } trap finish EXIT </ins> if [ -z \"${BASH_XTRACEFD:-}\" ]; then exec 19> \"${LOG_FILE}\" export BASH_XTRACEFD=\"19\"", "commid": "kubernetes_pr_99596"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-008ca2b69bf6f84855aa7fc74e613d0733365e6cd47dcc25c8f18519fbaaf463", "query": "Scheduler throughput drops significantly in http://perf- ! After , seems to be the curlspirit.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority critical-urgent /sig scheduling /sig scalability", "positive_passages": [{"docid": "doc-en-kubernetes-3213574cc641de0acf4fd6f427885099b917a706a1c2a7527106b0de680b5ac8", "text": "\"context\" \"fmt\" \"math/rand\" <del> \"sort\" </del> \"sync\" \"sync/atomic\" \"time\"", "commid": "kubernetes_pr_99914"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-008ca2b69bf6f84855aa7fc74e613d0733365e6cd47dcc25c8f18519fbaaf463", "query": "Scheduler throughput drops significantly in http://perf- ! After , seems to be the curlspirit.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority critical-urgent /sig scheduling /sig scalability", "positive_passages": [{"docid": "doc-en-kubernetes-71a56af80b333d369ea5436decfac8d8bc987f9747310af3a27f973e0960eff4", "text": "return feasibleNodes, nil } <del> type pluginScores struct { Plugin           string Score            int64 AverageNodeScore float64 } </del> // prioritizeNodes prioritizes the nodes by running the score plugins, // which return a score for each node from the call to RunScorePlugins(). // The scores from each plugin are added together to make the score for that node, then", "commid": "kubernetes_pr_99914"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-008ca2b69bf6f84855aa7fc74e613d0733365e6cd47dcc25c8f18519fbaaf463", "query": "Scheduler throughput drops significantly in http://perf- ! After , seems to be the curlspirit.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority critical-urgent /sig scheduling /sig scalability", "positive_passages": [{"docid": "doc-en-kubernetes-b66fa12fd85eca477b99c426659b99a57817f0d8385bd93fc6b781568669f206", "text": "return nil, scoreStatus.AsError() } <ins> if klog.V(10).Enabled() { for plugin, nodeScoreList := range scoresMap { for _, nodeScore := range nodeScoreList { klog.InfoS(\"Plugin scored node for pod\", \"pod\", klog.KObj(pod), \"plugin\", plugin, \"node\", nodeScore.Name, \"score\", nodeScore.Score) } } } </ins> // Summarize all scores. result := make(framework.NodeScoreList, 0, len(nodes)) for i := range nodes { result = append(result, framework.NodeScore{Name: nodes[i].Name, Score: 0}) for j := range scoresMap {", "commid": "kubernetes_pr_99914"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-008ca2b69bf6f84855aa7fc74e613d0733365e6cd47dcc25c8f18519fbaaf463", "query": "Scheduler throughput drops significantly in http://perf- ! After , seems to be the curlspirit.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority critical-urgent /sig scheduling /sig scalability", "positive_passages": [{"docid": "doc-en-kubernetes-b8b221586c9a339b4cded0642f070bdefd3a9123aa9480cebaaa29f6b7733789", "text": "} } <del> if klog.V(4).Enabled() { logPluginScores(nodes, scoresMap, pod) } </del> if len(g.extenders) != 0 && nodes != nil { var mu sync.Mutex var wg sync.WaitGroup", "commid": "kubernetes_pr_99914"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-008ca2b69bf6f84855aa7fc74e613d0733365e6cd47dcc25c8f18519fbaaf463", "query": "Scheduler throughput drops significantly in http://perf- ! After , seems to be the curlspirit.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority critical-urgent /sig scheduling /sig scalability", "positive_passages": [{"docid": "doc-en-kubernetes-31193288258fee76a48a170644cc613a75dea9d3538d3115465a1f5ecf8a7a34", "text": "} } <del> if klog.V(4).Enabled() { </del> <ins> if klog.V(10).Enabled() { </ins> for i := range result { klog.InfoS(\"Calculated node's final score for pod\", \"pod\", klog.KObj(pod), \"node\", result[i].Name, \"score\", result[i].Score) }", "commid": "kubernetes_pr_99914"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-008ca2b69bf6f84855aa7fc74e613d0733365e6cd47dcc25c8f18519fbaaf463", "query": "Scheduler throughput drops significantly in http://perf- ! After , seems to be the curlspirit.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority critical-urgent /sig scheduling /sig scalability", "positive_passages": [{"docid": "doc-en-kubernetes-c8bcc7042b38357d7109a141bb451b4a21562314f08d0d74c22a791455b5500c", "text": "return result, nil } <del> // logPluginScores adds summarized plugin score logging. The goal of this block is to show the highest scoring plugins on // each node, and the average score for those plugins across all nodes. func logPluginScores(nodes []*v1.Node, scoresMap framework.PluginToNodeScores, pod *v1.Pod) { totalPluginScores := make(map[string]int64) for j := range scoresMap { for i := range nodes { totalPluginScores[j] += scoresMap[j][i].Score } } // Build a map of Nodes->PluginScores on that node nodeToPluginScores := make(framework.PluginToNodeScores, len(nodes)) for _, node := range nodes { nodeToPluginScores[node.Name] = make(framework.NodeScoreList, len(scoresMap)) } // Convert the scoresMap (which contains Plugins->NodeScores) to the Nodes->PluginScores map for plugin, nodeScoreList := range scoresMap { for _, nodeScore := range nodeScoreList { klog.V(10).InfoS(\"Plugin scored node for pod\", \"pod\", klog.KObj(pod), \"plugin\", plugin, \"node\", nodeScore.Name, \"score\", nodeScore.Score) nodeToPluginScores[nodeScore.Name] = append(nodeToPluginScores[nodeScore.Name], framework.NodeScore{Name: plugin, Score: nodeScore.Score}) } } for node, scores := range nodeToPluginScores { // Get the top 3 scoring plugins for each node sort.Slice(scores, func(i, j int) bool { return scores[i].Score > scores[j].Score }) var topScores []pluginScores for _, score := range scores { pluginScore := pluginScores{ Plugin:           score.Name, Score:            score.Score, AverageNodeScore: float64(totalPluginScores[score.Name]) / float64(len(nodes)), } topScores = append(topScores, pluginScore) if len(topScores) == 3 { break } } klog.InfoS(\"Top 3 plugins for pod on node\", \"pod\", klog.KObj(pod), \"node\", node, \"scores\", topScores, ) } } </del> // NewGenericScheduler creates a genericScheduler object. func NewGenericScheduler( cache internalcache.Cache,", "commid": "kubernetes_pr_99914"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c392df55ab7dc72e13e65c63fc1f61f730cca43a7c22b90fcf3fe28c2fb22e91", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --Serializing a v2beta2 HorizontalPodAutoscaler with (and ) produces yaml that cannot be applied due to a ValidationError on the field which is under the optional field . A valid HPA serialized with should be able to be applied to the cluster with no validation errors, without filling out the optional field. Other valid objects (such as Namespaces and Deployments) can be applied directly, without filling out their optional fields. Run this to generate the serialized yaml (same outcome with both and functions) Running the go code should yield this yaml: Writing the above yaml to a file and applying it (with ) will result in: Kubernetes version (use ): Server: v1.20.2, Client: v1.20.4 go version: go1.16 darwin/amd64 has: cc cc\n/sig api-machinery /sig autoscaling /sig cli\n/assign /triage accepted\nmarking conditions as +optional in the API type would resolve the client-side apply error\nIt would remove the validation error, but I'd be concerned about any side effects or unwanted outcomes when moving that field from required to optional. A somewhat analogous field is required. But if you anticipate this won't change much else, that will work.\nClient-side validation is non-authoritative, and problematic for the reasons described in this issue ... the client is disallowing a request the server would actually have no problems with. No field the server would permit to be empty (e.g. succeeds with ) should be marked as required for this reason. fwiw, openapi schema generation marks fields tagged as as optional:\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-acf12c778bb57597d83182144382281788f7f9175a351247ce61e6c5f0ab9ebc", "text": "}, \"required\": [ \"currentReplicas\", <del> \"desiredReplicas\", \"conditions\" </del> <ins> \"desiredReplicas\" </ins> ], \"type\": \"object\" },", "commid": "kubernetes_pr_100318"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c392df55ab7dc72e13e65c63fc1f61f730cca43a7c22b90fcf3fe28c2fb22e91", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --Serializing a v2beta2 HorizontalPodAutoscaler with (and ) produces yaml that cannot be applied due to a ValidationError on the field which is under the optional field . A valid HPA serialized with should be able to be applied to the cluster with no validation errors, without filling out the optional field. Other valid objects (such as Namespaces and Deployments) can be applied directly, without filling out their optional fields. Run this to generate the serialized yaml (same outcome with both and functions) Running the go code should yield this yaml: Writing the above yaml to a file and applying it (with ) will result in: Kubernetes version (use ): Server: v1.20.2, Client: v1.20.4 go version: go1.16 darwin/amd64 has: cc cc\n/sig api-machinery /sig autoscaling /sig cli\n/assign /triage accepted\nmarking conditions as +optional in the API type would resolve the client-side apply error\nIt would remove the validation error, but I'd be concerned about any side effects or unwanted outcomes when moving that field from required to optional. A somewhat analogous field is required. But if you anticipate this won't change much else, that will work.\nClient-side validation is non-authoritative, and problematic for the reasons described in this issue ... the client is disallowing a request the server would actually have no problems with. No field the server would permit to be empty (e.g. succeeds with ) should be marked as required for this reason. fwiw, openapi schema generation marks fields tagged as as optional:\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-07d18eb9894ec424a8cc36e9af8f13b61faac0a9986e1a91911d8a45cbe12a82", "text": "// conditions is the set of conditions required for this autoscaler to scale its target, // and indicates whether or not those conditions are met. <ins> // +optional </ins> repeated HorizontalPodAutoscalerCondition conditions = 6; }", "commid": "kubernetes_pr_100318"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c392df55ab7dc72e13e65c63fc1f61f730cca43a7c22b90fcf3fe28c2fb22e91", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --Serializing a v2beta2 HorizontalPodAutoscaler with (and ) produces yaml that cannot be applied due to a ValidationError on the field which is under the optional field . A valid HPA serialized with should be able to be applied to the cluster with no validation errors, without filling out the optional field. Other valid objects (such as Namespaces and Deployments) can be applied directly, without filling out their optional fields. Run this to generate the serialized yaml (same outcome with both and functions) Running the go code should yield this yaml: Writing the above yaml to a file and applying it (with ) will result in: Kubernetes version (use ): Server: v1.20.2, Client: v1.20.4 go version: go1.16 darwin/amd64 has: cc cc\n/sig api-machinery /sig autoscaling /sig cli\n/assign /triage accepted\nmarking conditions as +optional in the API type would resolve the client-side apply error\nIt would remove the validation error, but I'd be concerned about any side effects or unwanted outcomes when moving that field from required to optional. A somewhat analogous field is required. But if you anticipate this won't change much else, that will work.\nClient-side validation is non-authoritative, and problematic for the reasons described in this issue ... the client is disallowing a request the server would actually have no problems with. No field the server would permit to be empty (e.g. succeeds with ) should be marked as required for this reason. fwiw, openapi schema generation marks fields tagged as as optional:\nIssues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-contributor-experience at . /lifecycle stale\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-deefe00dfcf16faf86ce00092fde83c780354d8e4ee3f0fbdfa6a02f4ef250ff", "text": "// conditions is the set of conditions required for this autoscaler to scale its target, // and indicates whether or not those conditions are met. <ins> // +optional </ins> Conditions []HorizontalPodAutoscalerCondition `json:\"conditions\" protobuf:\"bytes,6,rep,name=conditions\"` }", "commid": "kubernetes_pr_100318"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-401bd803bf545c47b9f079f4e133a5da93cd748cff1afbf545e3f20a5f25f893", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --ci-kubernetes-e2e-ubuntu-gce [sig-storage] Subpath Container restart should verify that container can restart successfully after configmaps modified links to appreciated links to specific failures in spyglass appreciated Triage shows that this has been flaking quite frequently: It has flaked in 5 of the last 10 runs: /sig storage /priority important-soon <!-- Please see the deflaking doc () for more guidance! --\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nNoticed some more flakes on this one\nYep, looks like this is still flaking quite frequently: Going to re-ping SIG Storage.\n/assign\nTest is flaking maybe half of the time. ~This test is failing in gce-ubuntu-master-default - not sure if it's failing in any other dashboards, nor whether this is run anywhere else.~ edit: This is failing on Ubuntu only. Not sure if this is limited to master branch. Fix to the original issue was in since 1.19. This is a subpath test which a configmap a container that mounts the configmap a liveness probe and waits for the container to restart. liveness probe and waits for the container to stop restarting. The test failed at the last step - the container never stopped restarting. Timeout is 2min. The liveness probe continuously checks whether a \"probeFile\" exists in (an emptyDir), and if it doesn't exist, whether the configmap file contains the modified value. The probeFile essentially acts as a condition which guards the probe from checking the configmap file. The test fails the liveness probe by removing the probeFile without updating the configmap just yet. It then fixes the liveness probe by updating the configmap to the modified value. So if the container keeps restarting, the liveness probe could've been failing continuously within 2min, due to one of the following: (? not sure about this one) Command can't be executed (for example if container can't start) configmap file was never updated. Within 2min, the pod only restarted 5 times. The liveness probe's period is 2s, initial delay is 1s, and failure threshold is 1, so a restart due to liveness probe failure is triggered every 3s. The image is busybox. The command is just , so it's unlikely for the container to have crashed. There were no liveness probe unhealthy events after the test fixes the probe, and yet it continued to restart. No more events after probe is fixed.\nCould we check if the configmap value was updated for sure to rule out that scenario ? I have not tried to run an end to end test locally :) so am not sure how to debug it\nWill do! I ran the test in a GKE Ubuntu cluster running 1.19.6 and couldn't reproduce the failure. I'm now trying to run a cluster on GCE with Ubuntu nodes running k8s master, but haven't been successful after trying a number of techniques. If anyone happens to know how to do this let me know; I'll keep asking around otherwise.\nI got a repro on a GKE cluster backed by COS. After the test failed the container ends up in Running state eventually, and the configmap file outputs the expected modified value. The fix is to increase the test timeout. PR coming up.", "positive_passages": [{"docid": "doc-en-kubernetes-d960957fb25b6ed083708366c18bc6011e015213511483bf1612eb244312e04f", "text": "// Check that container has restarted ginkgo.By(\"Waiting for container to restart\") restarts := int32(0) <del> err = wait.PollImmediate(10*time.Second, 2*time.Minute, func() (bool, error) { </del> <ins> err = wait.PollImmediate(10*time.Second, framework.PodStartTimeout, func() (bool, error) { </ins> pod, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Get(context.TODO(), pod.Name, metav1.GetOptions{}) if err != nil { return false, err", "commid": "kubernetes_pr_101347"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-401bd803bf545c47b9f079f4e133a5da93cd748cff1afbf545e3f20a5f25f893", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --ci-kubernetes-e2e-ubuntu-gce [sig-storage] Subpath Container restart should verify that container can restart successfully after configmaps modified links to appreciated links to specific failures in spyglass appreciated Triage shows that this has been flaking quite frequently: It has flaked in 5 of the last 10 runs: /sig storage /priority important-soon <!-- Please see the deflaking doc () for more guidance! --\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nNoticed some more flakes on this one\nYep, looks like this is still flaking quite frequently: Going to re-ping SIG Storage.\n/assign\nTest is flaking maybe half of the time. ~This test is failing in gce-ubuntu-master-default - not sure if it's failing in any other dashboards, nor whether this is run anywhere else.~ edit: This is failing on Ubuntu only. Not sure if this is limited to master branch. Fix to the original issue was in since 1.19. This is a subpath test which a configmap a container that mounts the configmap a liveness probe and waits for the container to restart. liveness probe and waits for the container to stop restarting. The test failed at the last step - the container never stopped restarting. Timeout is 2min. The liveness probe continuously checks whether a \"probeFile\" exists in (an emptyDir), and if it doesn't exist, whether the configmap file contains the modified value. The probeFile essentially acts as a condition which guards the probe from checking the configmap file. The test fails the liveness probe by removing the probeFile without updating the configmap just yet. It then fixes the liveness probe by updating the configmap to the modified value. So if the container keeps restarting, the liveness probe could've been failing continuously within 2min, due to one of the following: (? not sure about this one) Command can't be executed (for example if container can't start) configmap file was never updated. Within 2min, the pod only restarted 5 times. The liveness probe's period is 2s, initial delay is 1s, and failure threshold is 1, so a restart due to liveness probe failure is triggered every 3s. The image is busybox. The command is just , so it's unlikely for the container to have crashed. There were no liveness probe unhealthy events after the test fixes the probe, and yet it continued to restart. No more events after probe is fixed.\nCould we check if the configmap value was updated for sure to rule out that scenario ? I have not tried to run an end to end test locally :) so am not sure how to debug it\nWill do! I ran the test in a GKE Ubuntu cluster running 1.19.6 and couldn't reproduce the failure. I'm now trying to run a cluster on GCE with Ubuntu nodes running k8s master, but haven't been successful after trying a number of techniques. If anyone happens to know how to do this let me know; I'll keep asking around otherwise.\nI got a repro on a GKE cluster backed by COS. After the test failed the container ends up in Running state eventually, and the configmap file outputs the expected modified value. The fix is to increase the test timeout. PR coming up.", "positive_passages": [{"docid": "doc-en-kubernetes-8a847e2cea909eaaab7638c220b89fbc1ea74bdd65321ba50dad97a86f61471b", "text": "ginkgo.By(\"Waiting for container to stop restarting\") stableCount := int(0) stableThreshold := int(time.Minute / framework.Poll) <del> err = wait.PollImmediate(framework.Poll, 2*time.Minute, func() (bool, error) { </del> <ins> err = wait.PollImmediate(framework.Poll, framework.PodStartTimeout, func() (bool, error) { </ins> pod, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Get(context.TODO(), pod.Name, metav1.GetOptions{}) if err != nil { return false, err", "commid": "kubernetes_pr_101347"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-32aefc1c9667deeac25c7fa9b9550d239ed1fdf9d6a45f9e42a1f0f724022acf", "query": "found this in while finding beta API dependencies for 1.22. This will block from running at all in 1.22 I think this is for this deployment: , and in ingress-gce I found\n/sig network /triage accepted I pinged some GCE sig-network folks in the PR\ngiven that uses extensions/v1beta1 Deployments, that particular manifest seems unused\nonce we land the fix in , anyone know how to update the image we use in e2e tests?\n/assign The update to use v1 APIs is merged to in What version should be tagged we can pick up in Does need to be picked back to one or more release branches?\nIt would be helpful to get a version containing the fix tagged, so the manifest can be updated in to get e2e signal even before opens for 1.22.\nAck. We are planning to cut a release soon. Once the release is cut, I will update the k/k to use that\nwhat's the ETA for cutting ingress-gce release? I think it might be related to failing pull-kubernetes-e2e-gce-100-performance run in", "positive_passages": [{"docid": "doc-en-kubernetes-5aad0960a5782a3e7c2e8f0bbc4abff1ad8a96bd6901dd8f5d76c267ef7f6d9b", "text": "var ( // TODO: Deprecate gitMajor and gitMinor, use only gitVersion instead. gitMajor     string = \"0\"              // major version, always numeric <del> gitMinor     string = \"2+\"             // minor version, numeric possibly followed by \"+\" gitVersion   string = \"v0.2-dev\"       // version from git, output of $(git describe) </del> <ins> gitMinor     string = \"3+\"             // minor version, numeric possibly followed by \"+\" gitVersion   string = \"v0.3-dev\"       // version from git, output of $(git describe) </ins> gitCommit    string = \"\"               // sha1 from git, output of $(git rev-parse HEAD) gitTreeState string = \"not a git tree\" // state of git tree, either \"clean\" or \"dirty\" )", "commid": "kubernetes_pr_1384"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-32aefc1c9667deeac25c7fa9b9550d239ed1fdf9d6a45f9e42a1f0f724022acf", "query": "found this in while finding beta API dependencies for 1.22. This will block from running at all in 1.22 I think this is for this deployment: , and in ingress-gce I found\n/sig network /triage accepted I pinged some GCE sig-network folks in the PR\ngiven that uses extensions/v1beta1 Deployments, that particular manifest seems unused\nonce we land the fix in , anyone know how to update the image we use in e2e tests?\n/assign The update to use v1 APIs is merged to in What version should be tagged we can pick up in Does need to be picked back to one or more release branches?\nIt would be helpful to get a version containing the fix tagged, so the manifest can be updated in to get e2e signal even before opens for 1.22.\nAck. We are planning to cut a release soon. Once the release is cut, I will update the k/k to use that\nwhat's the ETA for cutting ingress-gce release? I think it might be related to failing pull-kubernetes-e2e-gce-100-performance run in", "positive_passages": [{"docid": "doc-en-kubernetes-e39a29feb3e0df54bb296cdc8acfd730572015d5170370992655ba6f62fa5416", "text": "terminationGracePeriodSeconds: 600 hostNetwork: true containers: <del> - image: gcr.io/k8s-ingress-image-push/ingress-gce-glbc-amd64:v1.11.0 </del> <ins> - image: gcr.io/k8s-ingress-image-push/ingress-gce-glbc-amd64:v1.12.0 </ins> livenessProbe: httpGet: path: /healthz", "commid": "kubernetes_pr_101772"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bd154303d20599beecef17a46b6ca985c48134dc369a3996d772f4c6675030ec", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --In , client-go don't share transport when c.Dial is not nil, but kubelet custorm Dial by default, After PR is integrated, the connections between kubelet and kube-apiserver in our cluster with 4000 nodes increases by five times. kubelet share transport by default, one kubelet only keep one connection to kube-apiserver. start kubelet with rotate-certificates=false Kubernetes version (use ): v1.19.4 Cloud provider or hardware configuration: OS (e.g: ):EulerOS 2.9 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery /sig node\n/triage accepted /assign\nhow many connections between kubelet and kube apiserver on one node after PR in your case? it's mentioned it increases by five times, does that mean before the PR, there is one connection, after the PR, there are 5 or 6 connections?\nbefore the PR, there is one connection, after the PR, there 3 connections, there are some customization capabilities in our product, and we'll have another two connections. In our kubelet startup parameters, rotate-certificates=false\nSome increase was expected, since multiple REST clients constructed from a config with a custom dialer cannot safely share a transport, and client-go constructs a REST client for each API group/version accessed. Something like would be required to rework how client-go constructs clients to start sharing REST clients above the transport level between API groups/versions. I think this is working as intended until client-go client construction is reworked.\ndo you know where in the code the 5 connections are created? are they all safe to share the transport? also are the 5 connections all active all the time? if not, IdleConnTimeout should cause the connection to be closed.\nI test the code on master branch, if I change rotateCertificates to false, there are 6 connections between kubelet and kube-apiserver ! !\ntransport will share when config.Transport not nil if rotateCertificates is true, config.Transport will been set in kubeletcertificate.UpdateTransport but if rotateCertificates is false, config.Transport will not been set.\n/area kubelet Any update on this issue?\nI will work on this issue\nHi if rotate-certificates=false kubelet customizes the dialer to provide a closeAllConns to close the connection when the connection is dead but not been closed. In , there is a discuss about another solution after client-go has HTTP 2.0 health check, so we don't need this change. So we can solve the current problem by reverting . I have submitted to revert , and this change requires your final confirmation. Thanks you.\nare we guaranteed kubelets always speak to kube-apiserver over http/2? if they use a load-balancer that is not http/2 capable, isn't the \"close all connections\" fix still required as a backstop?\nI thought http1.1 wasn't affected because it will always try to connect a new connection\nI'm not confident in that. The original issue dated back to before client-go defaulted to http/2, and we definitely saw issues with stuck TCP connections then.\nyeah, I could reproduce it with http1.1, however, it can be solved using the transport CloseIdleConnections method please take a look , the last commit needs more work, but I think that the 2 first commits exposeing the CloseIdleConnections() are useful\nok, this seems to work , but it will be nice to have more feedback would you be able to test and see if this solve your issue?\nHi aojea, I have test on v1.21.1 before merge , there are 6 connections to kube-apiserver from kubelet ! after merge , there is only 1 connection to kube-apiserver from kubelet ! so, can solve my issue. thank you very much.", "positive_passages": [{"docid": "doc-en-kubernetes-b94179b413da9697058467ebff6d1d5a70fca3f66354e4e195d09973fe6be687", "text": "metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/runtime\" \"k8s.io/apimachinery/pkg/types\" <ins> utilnet \"k8s.io/apimachinery/pkg/util/net\" </ins> utilruntime \"k8s.io/apimachinery/pkg/util/runtime\" \"k8s.io/apimachinery/pkg/util/sets\" \"k8s.io/apimachinery/pkg/util/wait\"", "commid": "kubernetes_pr_104844"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bd154303d20599beecef17a46b6ca985c48134dc369a3996d772f4c6675030ec", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --In , client-go don't share transport when c.Dial is not nil, but kubelet custorm Dial by default, After PR is integrated, the connections between kubelet and kube-apiserver in our cluster with 4000 nodes increases by five times. kubelet share transport by default, one kubelet only keep one connection to kube-apiserver. start kubelet with rotate-certificates=false Kubernetes version (use ): v1.19.4 Cloud provider or hardware configuration: OS (e.g: ):EulerOS 2.9 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery /sig node\n/triage accepted /assign\nhow many connections between kubelet and kube apiserver on one node after PR in your case? it's mentioned it increases by five times, does that mean before the PR, there is one connection, after the PR, there are 5 or 6 connections?\nbefore the PR, there is one connection, after the PR, there 3 connections, there are some customization capabilities in our product, and we'll have another two connections. In our kubelet startup parameters, rotate-certificates=false\nSome increase was expected, since multiple REST clients constructed from a config with a custom dialer cannot safely share a transport, and client-go constructs a REST client for each API group/version accessed. Something like would be required to rework how client-go constructs clients to start sharing REST clients above the transport level between API groups/versions. I think this is working as intended until client-go client construction is reworked.\ndo you know where in the code the 5 connections are created? are they all safe to share the transport? also are the 5 connections all active all the time? if not, IdleConnTimeout should cause the connection to be closed.\nI test the code on master branch, if I change rotateCertificates to false, there are 6 connections between kubelet and kube-apiserver ! !\ntransport will share when config.Transport not nil if rotateCertificates is true, config.Transport will been set in kubeletcertificate.UpdateTransport but if rotateCertificates is false, config.Transport will not been set.\n/area kubelet Any update on this issue?\nI will work on this issue\nHi if rotate-certificates=false kubelet customizes the dialer to provide a closeAllConns to close the connection when the connection is dead but not been closed. In , there is a discuss about another solution after client-go has HTTP 2.0 health check, so we don't need this change. So we can solve the current problem by reverting . I have submitted to revert , and this change requires your final confirmation. Thanks you.\nare we guaranteed kubelets always speak to kube-apiserver over http/2? if they use a load-balancer that is not http/2 capable, isn't the \"close all connections\" fix still required as a backstop?\nI thought http1.1 wasn't affected because it will always try to connect a new connection\nI'm not confident in that. The original issue dated back to before client-go defaulted to http/2, and we definitely saw issues with stuck TCP connections then.\nyeah, I could reproduce it with http1.1, however, it can be solved using the transport CloseIdleConnections method please take a look , the last commit needs more work, but I think that the 2 first commits exposeing the CloseIdleConnections() are useful\nok, this seems to work , but it will be nice to have more feedback would you be able to test and see if this solve your issue?\nHi aojea, I have test on v1.21.1 before merge , there are 6 connections to kube-apiserver from kubelet ! after merge , there is only 1 connection to kube-apiserver from kubelet ! so, can solve my issue. thank you very much.", "positive_passages": [{"docid": "doc-en-kubernetes-9afaecfcb66be4ca73dc343902104e28a21bb77a3d2ab484b36ea85d3da3fc72", "text": "} kubeClientConfigOverrides(s, clientConfig) <del> closeAllConns, err := updateDialer(clientConfig) if err != nil { return nil, nil, err </del> <ins> // Kubelet needs to be able to recover from stale http connections. // HTTP2 has a mechanism to detect broken connections by sending periodical pings. // HTTP1 only can have one persistent connection, and it will close all Idle connections // once the Kubelet heartbeat fails. However, since there are many edge cases that we can't // control, users can still opt-in to the previous behavior for closing the connections by // setting the environment variable DISABLE_HTTP2. var closeAllConns func() if s := os.Getenv(\"DISABLE_HTTP2\"); len(s) > 0 { klog.InfoS(\"HTTP2 has been explicitly disabled, updating Kubelet client Dialer to forcefully close active connections on heartbeat failures\") closeAllConns, err = updateDialer(clientConfig) if err != nil { return nil, nil, err } } else { closeAllConns = func() { utilnet.CloseIdleConnectionsFor(clientConfig.Transport) } </ins> } return clientConfig, closeAllConns, nil }", "commid": "kubernetes_pr_104844"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bd154303d20599beecef17a46b6ca985c48134dc369a3996d772f4c6675030ec", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --In , client-go don't share transport when c.Dial is not nil, but kubelet custorm Dial by default, After PR is integrated, the connections between kubelet and kube-apiserver in our cluster with 4000 nodes increases by five times. kubelet share transport by default, one kubelet only keep one connection to kube-apiserver. start kubelet with rotate-certificates=false Kubernetes version (use ): v1.19.4 Cloud provider or hardware configuration: OS (e.g: ):EulerOS 2.9 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery /sig node\n/triage accepted /assign\nhow many connections between kubelet and kube apiserver on one node after PR in your case? it's mentioned it increases by five times, does that mean before the PR, there is one connection, after the PR, there are 5 or 6 connections?\nbefore the PR, there is one connection, after the PR, there 3 connections, there are some customization capabilities in our product, and we'll have another two connections. In our kubelet startup parameters, rotate-certificates=false\nSome increase was expected, since multiple REST clients constructed from a config with a custom dialer cannot safely share a transport, and client-go constructs a REST client for each API group/version accessed. Something like would be required to rework how client-go constructs clients to start sharing REST clients above the transport level between API groups/versions. I think this is working as intended until client-go client construction is reworked.\ndo you know where in the code the 5 connections are created? are they all safe to share the transport? also are the 5 connections all active all the time? if not, IdleConnTimeout should cause the connection to be closed.\nI test the code on master branch, if I change rotateCertificates to false, there are 6 connections between kubelet and kube-apiserver ! !\ntransport will share when config.Transport not nil if rotateCertificates is true, config.Transport will been set in kubeletcertificate.UpdateTransport but if rotateCertificates is false, config.Transport will not been set.\n/area kubelet Any update on this issue?\nI will work on this issue\nHi if rotate-certificates=false kubelet customizes the dialer to provide a closeAllConns to close the connection when the connection is dead but not been closed. In , there is a discuss about another solution after client-go has HTTP 2.0 health check, so we don't need this change. So we can solve the current problem by reverting . I have submitted to revert , and this change requires your final confirmation. Thanks you.\nare we guaranteed kubelets always speak to kube-apiserver over http/2? if they use a load-balancer that is not http/2 capable, isn't the \"close all connections\" fix still required as a backstop?\nI thought http1.1 wasn't affected because it will always try to connect a new connection\nI'm not confident in that. The original issue dated back to before client-go defaulted to http/2, and we definitely saw issues with stuck TCP connections then.\nyeah, I could reproduce it with http1.1, however, it can be solved using the transport CloseIdleConnections method please take a look , the last commit needs more work, but I think that the 2 first commits exposeing the CloseIdleConnections() are useful\nok, this seems to work , but it will be nice to have more feedback would you be able to test and see if this solve your issue?\nHi aojea, I have test on v1.21.1 before merge , there are 6 connections to kube-apiserver from kubelet ! after merge , there is only 1 connection to kube-apiserver from kubelet ! so, can solve my issue. thank you very much.", "positive_passages": [{"docid": "doc-en-kubernetes-692f0bc67755d603b7887e23fcb0e1fde104b1e7c9757e1d4a7c6f0cdeff8aac", "text": "} } <ins> // CloseIdleConnectionsFor close idles connections for the Transport. // If the Transport is wrapped it iterates over the wrapped round trippers // until it finds one that implements the CloseIdleConnections method. // If the Transport does not have a CloseIdleConnections method // then this function does nothing. func CloseIdleConnectionsFor(transport http.RoundTripper) { if transport == nil { return } type closeIdler interface { CloseIdleConnections() } switch transport := transport.(type) { case closeIdler: transport.CloseIdleConnections() case RoundTripperWrapper: CloseIdleConnectionsFor(transport.WrappedRoundTripper()) default: klog.Warningf(\"unknown transport type: %T\", transport) } } </ins> type TLSClientConfigHolder interface { TLSClientConfig() *tls.Config }", "commid": "kubernetes_pr_104844"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bd154303d20599beecef17a46b6ca985c48134dc369a3996d772f4c6675030ec", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --In , client-go don't share transport when c.Dial is not nil, but kubelet custorm Dial by default, After PR is integrated, the connections between kubelet and kube-apiserver in our cluster with 4000 nodes increases by five times. kubelet share transport by default, one kubelet only keep one connection to kube-apiserver. start kubelet with rotate-certificates=false Kubernetes version (use ): v1.19.4 Cloud provider or hardware configuration: OS (e.g: ):EulerOS 2.9 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery /sig node\n/triage accepted /assign\nhow many connections between kubelet and kube apiserver on one node after PR in your case? it's mentioned it increases by five times, does that mean before the PR, there is one connection, after the PR, there are 5 or 6 connections?\nbefore the PR, there is one connection, after the PR, there 3 connections, there are some customization capabilities in our product, and we'll have another two connections. In our kubelet startup parameters, rotate-certificates=false\nSome increase was expected, since multiple REST clients constructed from a config with a custom dialer cannot safely share a transport, and client-go constructs a REST client for each API group/version accessed. Something like would be required to rework how client-go constructs clients to start sharing REST clients above the transport level between API groups/versions. I think this is working as intended until client-go client construction is reworked.\ndo you know where in the code the 5 connections are created? are they all safe to share the transport? also are the 5 connections all active all the time? if not, IdleConnTimeout should cause the connection to be closed.\nI test the code on master branch, if I change rotateCertificates to false, there are 6 connections between kubelet and kube-apiserver ! !\ntransport will share when config.Transport not nil if rotateCertificates is true, config.Transport will been set in kubeletcertificate.UpdateTransport but if rotateCertificates is false, config.Transport will not been set.\n/area kubelet Any update on this issue?\nI will work on this issue\nHi if rotate-certificates=false kubelet customizes the dialer to provide a closeAllConns to close the connection when the connection is dead but not been closed. In , there is a discuss about another solution after client-go has HTTP 2.0 health check, so we don't need this change. So we can solve the current problem by reverting . I have submitted to revert , and this change requires your final confirmation. Thanks you.\nare we guaranteed kubelets always speak to kube-apiserver over http/2? if they use a load-balancer that is not http/2 capable, isn't the \"close all connections\" fix still required as a backstop?\nI thought http1.1 wasn't affected because it will always try to connect a new connection\nI'm not confident in that. The original issue dated back to before client-go defaulted to http/2, and we definitely saw issues with stuck TCP connections then.\nyeah, I could reproduce it with http1.1, however, it can be solved using the transport CloseIdleConnections method please take a look , the last commit needs more work, but I think that the 2 first commits exposeing the CloseIdleConnections() are useful\nok, this seems to work , but it will be nice to have more feedback would you be able to test and see if this solve your issue?\nHi aojea, I have test on v1.21.1 before merge , there are 6 connections to kube-apiserver from kubelet ! after merge , there is only 1 connection to kube-apiserver from kubelet ! so, can solve my issue. thank you very much.", "positive_passages": [{"docid": "doc-en-kubernetes-8f6b7df6b3c803197c9c2181176c3ee8700493e9aaf3de42eb49e72233ac8798", "text": "\"k8s.io/apimachinery/pkg/runtime/schema\" \"k8s.io/apimachinery/pkg/runtime/serializer\" utilnet \"k8s.io/apimachinery/pkg/util/net\" <ins> \"k8s.io/apimachinery/pkg/util/wait\" </ins> ) type tcpLB struct {", "commid": "kubernetes_pr_104844"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bd154303d20599beecef17a46b6ca985c48134dc369a3996d772f4c6675030ec", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --In , client-go don't share transport when c.Dial is not nil, but kubelet custorm Dial by default, After PR is integrated, the connections between kubelet and kube-apiserver in our cluster with 4000 nodes increases by five times. kubelet share transport by default, one kubelet only keep one connection to kube-apiserver. start kubelet with rotate-certificates=false Kubernetes version (use ): v1.19.4 Cloud provider or hardware configuration: OS (e.g: ):EulerOS 2.9 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery /sig node\n/triage accepted /assign\nhow many connections between kubelet and kube apiserver on one node after PR in your case? it's mentioned it increases by five times, does that mean before the PR, there is one connection, after the PR, there are 5 or 6 connections?\nbefore the PR, there is one connection, after the PR, there 3 connections, there are some customization capabilities in our product, and we'll have another two connections. In our kubelet startup parameters, rotate-certificates=false\nSome increase was expected, since multiple REST clients constructed from a config with a custom dialer cannot safely share a transport, and client-go constructs a REST client for each API group/version accessed. Something like would be required to rework how client-go constructs clients to start sharing REST clients above the transport level between API groups/versions. I think this is working as intended until client-go client construction is reworked.\ndo you know where in the code the 5 connections are created? are they all safe to share the transport? also are the 5 connections all active all the time? if not, IdleConnTimeout should cause the connection to be closed.\nI test the code on master branch, if I change rotateCertificates to false, there are 6 connections between kubelet and kube-apiserver ! !\ntransport will share when config.Transport not nil if rotateCertificates is true, config.Transport will been set in kubeletcertificate.UpdateTransport but if rotateCertificates is false, config.Transport will not been set.\n/area kubelet Any update on this issue?\nI will work on this issue\nHi if rotate-certificates=false kubelet customizes the dialer to provide a closeAllConns to close the connection when the connection is dead but not been closed. In , there is a discuss about another solution after client-go has HTTP 2.0 health check, so we don't need this change. So we can solve the current problem by reverting . I have submitted to revert , and this change requires your final confirmation. Thanks you.\nare we guaranteed kubelets always speak to kube-apiserver over http/2? if they use a load-balancer that is not http/2 capable, isn't the \"close all connections\" fix still required as a backstop?\nI thought http1.1 wasn't affected because it will always try to connect a new connection\nI'm not confident in that. The original issue dated back to before client-go defaulted to http/2, and we definitely saw issues with stuck TCP connections then.\nyeah, I could reproduce it with http1.1, however, it can be solved using the transport CloseIdleConnections method please take a look , the last commit needs more work, but I think that the 2 first commits exposeing the CloseIdleConnections() are useful\nok, this seems to work , but it will be nice to have more feedback would you be able to test and see if this solve your issue?\nHi aojea, I have test on v1.21.1 before merge , there are 6 connections to kube-apiserver from kubelet ! after merge , there is only 1 connection to kube-apiserver from kubelet ! so, can solve my issue. thank you very much.", "positive_passages": [{"docid": "doc-en-kubernetes-45d90e6ba99a658772ebdcbc571701b7b12581acd3ec0363a64f0b834898c474", "text": "} } <ins> // 1. connect to https server with http1.1 using a TCP proxy // 2. the connection has keepalive enabled so it will be reused // 3. break the TCP connection stopping the proxy // 4. close the idle connection to force creating a new connection // 5. count that there are 2 connection to the server (we didn't reuse the original connection) func TestReconnectBrokenTCP_HTTP1(t *testing.T) { ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { fmt.Fprintf(w, \"Hello, %s\", r.Proto) })) ts.EnableHTTP2 = false ts.StartTLS() defer ts.Close() u, err := url.Parse(ts.URL) if err != nil { t.Fatalf(\"failed to parse URL from %q: %v\", ts.URL, err) } lb := newLB(t, u.Host) defer lb.ln.Close() stopCh := make(chan struct{}) go lb.serve(stopCh) transport, ok := ts.Client().Transport.(*http.Transport) if !ok { t.Fatal(\"failed to assert *http.Transport\") } config := &Config{ Host:      \"https://\" + lb.ln.Addr().String(), Transport: utilnet.SetTransportDefaults(transport), // large timeout, otherwise the broken connection will be cleaned by it Timeout: wait.ForeverTestTimeout, // These fields are required to create a REST client. ContentConfig: ContentConfig{ GroupVersion:         &schema.GroupVersion{}, NegotiatedSerializer: &serializer.CodecFactory{}, }, } config.TLSClientConfig.NextProtos = []string{\"http/1.1\"} client, err := RESTClientFor(config) if err != nil { t.Fatalf(\"failed to create REST client: %v\", err) } data, err := client.Get().AbsPath(\"/\").DoRaw(context.TODO()) if err != nil { t.Fatalf(\"unexpected err: %s: %v\", data, err) } if string(data) != \"Hello, HTTP/1.1\" { t.Fatalf(\"unexpected response: %s\", data) } // Deliberately let the LB stop proxying traffic for the current // connection. This mimics a broken TCP connection that's not properly // closed. close(stopCh) stopCh = make(chan struct{}) go lb.serve(stopCh) // Close the idle connections utilnet.CloseIdleConnectionsFor(client.Client.Transport) // If the client didn't close the idle connections, the broken connection // would still be in the connection pool, the following request would // then reuse the broken connection instead of creating a new one, and // thus would fail. data, err = client.Get().AbsPath(\"/\").DoRaw(context.TODO()) if err != nil { t.Fatalf(\"unexpected err: %v\", err) } if string(data) != \"Hello, HTTP/1.1\" { t.Fatalf(\"unexpected response: %s\", data) } dials := atomic.LoadInt32(&lb.dials) if dials != 2 { t.Fatalf(\"expected %d dials, got %d\", 2, dials) } } // 1. connect to https server with http1.1 using a TCP proxy making the connection to timeout // 2. the connection has keepalive enabled so it will be reused // 3. close the in-flight connection to force creating a new connection // 4. count that there are 2 connection on the LB but only one succeeds func TestReconnectBrokenTCPInFlight_HTTP1(t *testing.T) { done := make(chan struct{}) defer close(done) received := make(chan struct{}) ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { if r.URL.Path == \"/hang\" { conn, _, _ := w.(http.Hijacker).Hijack() close(received) <-done conn.Close() } fmt.Fprintf(w, \"Hello, %s\", r.Proto) })) ts.EnableHTTP2 = false ts.StartTLS() defer ts.Close() u, err := url.Parse(ts.URL) if err != nil { t.Fatalf(\"failed to parse URL from %q: %v\", ts.URL, err) } lb := newLB(t, u.Host) defer lb.ln.Close() stopCh := make(chan struct{}) go lb.serve(stopCh) transport, ok := ts.Client().Transport.(*http.Transport) if !ok { t.Fatal(\"failed to assert *http.Transport\") } config := &Config{ Host:      \"https://\" + lb.ln.Addr().String(), Transport: utilnet.SetTransportDefaults(transport), // Use something extraordinary large to not hit the timeout Timeout: wait.ForeverTestTimeout, // These fields are required to create a REST client. ContentConfig: ContentConfig{ GroupVersion:         &schema.GroupVersion{}, NegotiatedSerializer: &serializer.CodecFactory{}, }, } config.TLSClientConfig.NextProtos = []string{\"http/1.1\"} client, err := RESTClientFor(config) if err != nil { t.Fatalf(\"failed to create REST client: %v\", err) } // The request will connect, hang and eventually time out // but we can use a context to close once the test is done // we are only interested in have an inflight connection ctx, cancel := context.WithCancel(context.Background()) reqErrCh := make(chan error, 1) defer close(reqErrCh) go func() { _, err = client.Get().AbsPath(\"/hang\").DoRaw(ctx) reqErrCh <- err }() // wait until it connect to the server select { case <-received: case <-time.After(wait.ForeverTestTimeout): t.Fatal(\"Test timed out waiting for first request to fail\") } // Deliberately let the LB stop proxying traffic for the current // connection. This mimics a broken TCP connection that's not properly // closed. close(stopCh) stopCh = make(chan struct{}) go lb.serve(stopCh) // New request will fail if tries to reuse the connection data, err := client.Get().AbsPath(\"/\").DoRaw(context.Background()) if err != nil { t.Fatalf(\"unexpected err: %v\", err) } if string(data) != \"Hello, HTTP/1.1\" { t.Fatalf(\"unexpected response: %s\", data) } dials := atomic.LoadInt32(&lb.dials) if dials != 2 { t.Fatalf(\"expected %d dials, got %d\", 2, dials) } // cancel the in-flight connection cancel() select { case <-reqErrCh: if err == nil { t.Fatal(\"Connection succeeded but was expected to timeout\") } case <-time.After(10 * time.Second): t.Fatal(\"Test timed out waiting for the request to fail\") } } </ins> func TestRestClientTimeout(t *testing.T) { ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { time.Sleep(2 * time.Second)", "commid": "kubernetes_pr_104844"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bd154303d20599beecef17a46b6ca985c48134dc369a3996d772f4c6675030ec", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --In , client-go don't share transport when c.Dial is not nil, but kubelet custorm Dial by default, After PR is integrated, the connections between kubelet and kube-apiserver in our cluster with 4000 nodes increases by five times. kubelet share transport by default, one kubelet only keep one connection to kube-apiserver. start kubelet with rotate-certificates=false Kubernetes version (use ): v1.19.4 Cloud provider or hardware configuration: OS (e.g: ):EulerOS 2.9 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery /sig node\n/triage accepted /assign\nhow many connections between kubelet and kube apiserver on one node after PR in your case? it's mentioned it increases by five times, does that mean before the PR, there is one connection, after the PR, there are 5 or 6 connections?\nbefore the PR, there is one connection, after the PR, there 3 connections, there are some customization capabilities in our product, and we'll have another two connections. In our kubelet startup parameters, rotate-certificates=false\nSome increase was expected, since multiple REST clients constructed from a config with a custom dialer cannot safely share a transport, and client-go constructs a REST client for each API group/version accessed. Something like would be required to rework how client-go constructs clients to start sharing REST clients above the transport level between API groups/versions. I think this is working as intended until client-go client construction is reworked.\ndo you know where in the code the 5 connections are created? are they all safe to share the transport? also are the 5 connections all active all the time? if not, IdleConnTimeout should cause the connection to be closed.\nI test the code on master branch, if I change rotateCertificates to false, there are 6 connections between kubelet and kube-apiserver ! !\ntransport will share when config.Transport not nil if rotateCertificates is true, config.Transport will been set in kubeletcertificate.UpdateTransport but if rotateCertificates is false, config.Transport will not been set.\n/area kubelet Any update on this issue?\nI will work on this issue\nHi if rotate-certificates=false kubelet customizes the dialer to provide a closeAllConns to close the connection when the connection is dead but not been closed. In , there is a discuss about another solution after client-go has HTTP 2.0 health check, so we don't need this change. So we can solve the current problem by reverting . I have submitted to revert , and this change requires your final confirmation. Thanks you.\nare we guaranteed kubelets always speak to kube-apiserver over http/2? if they use a load-balancer that is not http/2 capable, isn't the \"close all connections\" fix still required as a backstop?\nI thought http1.1 wasn't affected because it will always try to connect a new connection\nI'm not confident in that. The original issue dated back to before client-go defaulted to http/2, and we definitely saw issues with stuck TCP connections then.\nyeah, I could reproduce it with http1.1, however, it can be solved using the transport CloseIdleConnections method please take a look , the last commit needs more work, but I think that the 2 first commits exposeing the CloseIdleConnections() are useful\nok, this seems to work , but it will be nice to have more feedback would you be able to test and see if this solve your issue?\nHi aojea, I have test on v1.21.1 before merge , there are 6 connections to kube-apiserver from kubelet ! after merge , there is only 1 connection to kube-apiserver from kubelet ! so, can solve my issue. thank you very much.", "positive_passages": [{"docid": "doc-en-kubernetes-7e66759cc0960f956fd1839ac22ab7e507686fc13ef0869c9ce6d8126ed2c27e", "text": "metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/runtime\" \"k8s.io/apimachinery/pkg/runtime/schema\" <ins> \"k8s.io/apimachinery/pkg/runtime/serializer\" </ins> \"k8s.io/apimachinery/pkg/runtime/serializer/streaming\" \"k8s.io/apimachinery/pkg/util/diff\" \"k8s.io/apimachinery/pkg/util/httpstream\" \"k8s.io/apimachinery/pkg/util/intstr\" <ins> utilnet \"k8s.io/apimachinery/pkg/util/net\" </ins> \"k8s.io/apimachinery/pkg/watch\" \"k8s.io/client-go/kubernetes/scheme\" restclientwatch \"k8s.io/client-go/rest/watch\"", "commid": "kubernetes_pr_104844"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bd154303d20599beecef17a46b6ca985c48134dc369a3996d772f4c6675030ec", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --In , client-go don't share transport when c.Dial is not nil, but kubelet custorm Dial by default, After PR is integrated, the connections between kubelet and kube-apiserver in our cluster with 4000 nodes increases by five times. kubelet share transport by default, one kubelet only keep one connection to kube-apiserver. start kubelet with rotate-certificates=false Kubernetes version (use ): v1.19.4 Cloud provider or hardware configuration: OS (e.g: ):EulerOS 2.9 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery /sig node\n/triage accepted /assign\nhow many connections between kubelet and kube apiserver on one node after PR in your case? it's mentioned it increases by five times, does that mean before the PR, there is one connection, after the PR, there are 5 or 6 connections?\nbefore the PR, there is one connection, after the PR, there 3 connections, there are some customization capabilities in our product, and we'll have another two connections. In our kubelet startup parameters, rotate-certificates=false\nSome increase was expected, since multiple REST clients constructed from a config with a custom dialer cannot safely share a transport, and client-go constructs a REST client for each API group/version accessed. Something like would be required to rework how client-go constructs clients to start sharing REST clients above the transport level between API groups/versions. I think this is working as intended until client-go client construction is reworked.\ndo you know where in the code the 5 connections are created? are they all safe to share the transport? also are the 5 connections all active all the time? if not, IdleConnTimeout should cause the connection to be closed.\nI test the code on master branch, if I change rotateCertificates to false, there are 6 connections between kubelet and kube-apiserver ! !\ntransport will share when config.Transport not nil if rotateCertificates is true, config.Transport will been set in kubeletcertificate.UpdateTransport but if rotateCertificates is false, config.Transport will not been set.\n/area kubelet Any update on this issue?\nI will work on this issue\nHi if rotate-certificates=false kubelet customizes the dialer to provide a closeAllConns to close the connection when the connection is dead but not been closed. In , there is a discuss about another solution after client-go has HTTP 2.0 health check, so we don't need this change. So we can solve the current problem by reverting . I have submitted to revert , and this change requires your final confirmation. Thanks you.\nare we guaranteed kubelets always speak to kube-apiserver over http/2? if they use a load-balancer that is not http/2 capable, isn't the \"close all connections\" fix still required as a backstop?\nI thought http1.1 wasn't affected because it will always try to connect a new connection\nI'm not confident in that. The original issue dated back to before client-go defaulted to http/2, and we definitely saw issues with stuck TCP connections then.\nyeah, I could reproduce it with http1.1, however, it can be solved using the transport CloseIdleConnections method please take a look , the last commit needs more work, but I think that the 2 first commits exposeing the CloseIdleConnections() are useful\nok, this seems to work , but it will be nice to have more feedback would you be able to test and see if this solve your issue?\nHi aojea, I have test on v1.21.1 before merge , there are 6 connections to kube-apiserver from kubelet ! after merge , there is only 1 connection to kube-apiserver from kubelet ! so, can solve my issue. thank you very much.", "positive_passages": [{"docid": "doc-en-kubernetes-c85d8891e2bc9829396fe6c77c1a0fab5f5a33bb80a57aa557d6c61065f88875", "text": "func testRESTClientWithConfig(t testing.TB, srv *httptest.Server, contentConfig ClientContentConfig) *RESTClient { base, _ := url.Parse(\"http://localhost\") <ins> var c *http.Client </ins> if srv != nil { var err error base, err = url.Parse(srv.URL) if err != nil { t.Fatalf(\"failed to parse test URL: %v\", err) } <ins> c = srv.Client() </ins> } versionedAPIPath := defaultResourcePathWithPrefix(\"\", \"\", \"\", \"\") <del> client, err := NewRESTClient(base, versionedAPIPath, contentConfig, nil, nil) </del> <ins> client, err := NewRESTClient(base, versionedAPIPath, contentConfig, nil, c) </ins> if err != nil { t.Fatalf(\"failed to create a client: %v\", err) }", "commid": "kubernetes_pr_104844"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bd154303d20599beecef17a46b6ca985c48134dc369a3996d772f4c6675030ec", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --In , client-go don't share transport when c.Dial is not nil, but kubelet custorm Dial by default, After PR is integrated, the connections between kubelet and kube-apiserver in our cluster with 4000 nodes increases by five times. kubelet share transport by default, one kubelet only keep one connection to kube-apiserver. start kubelet with rotate-certificates=false Kubernetes version (use ): v1.19.4 Cloud provider or hardware configuration: OS (e.g: ):EulerOS 2.9 Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery /sig node\n/triage accepted /assign\nhow many connections between kubelet and kube apiserver on one node after PR in your case? it's mentioned it increases by five times, does that mean before the PR, there is one connection, after the PR, there are 5 or 6 connections?\nbefore the PR, there is one connection, after the PR, there 3 connections, there are some customization capabilities in our product, and we'll have another two connections. In our kubelet startup parameters, rotate-certificates=false\nSome increase was expected, since multiple REST clients constructed from a config with a custom dialer cannot safely share a transport, and client-go constructs a REST client for each API group/version accessed. Something like would be required to rework how client-go constructs clients to start sharing REST clients above the transport level between API groups/versions. I think this is working as intended until client-go client construction is reworked.\ndo you know where in the code the 5 connections are created? are they all safe to share the transport? also are the 5 connections all active all the time? if not, IdleConnTimeout should cause the connection to be closed.\nI test the code on master branch, if I change rotateCertificates to false, there are 6 connections between kubelet and kube-apiserver ! !\ntransport will share when config.Transport not nil if rotateCertificates is true, config.Transport will been set in kubeletcertificate.UpdateTransport but if rotateCertificates is false, config.Transport will not been set.\n/area kubelet Any update on this issue?\nI will work on this issue\nHi if rotate-certificates=false kubelet customizes the dialer to provide a closeAllConns to close the connection when the connection is dead but not been closed. In , there is a discuss about another solution after client-go has HTTP 2.0 health check, so we don't need this change. So we can solve the current problem by reverting . I have submitted to revert , and this change requires your final confirmation. Thanks you.\nare we guaranteed kubelets always speak to kube-apiserver over http/2? if they use a load-balancer that is not http/2 capable, isn't the \"close all connections\" fix still required as a backstop?\nI thought http1.1 wasn't affected because it will always try to connect a new connection\nI'm not confident in that. The original issue dated back to before client-go defaulted to http/2, and we definitely saw issues with stuck TCP connections then.\nyeah, I could reproduce it with http1.1, however, it can be solved using the transport CloseIdleConnections method please take a look , the last commit needs more work, but I think that the 2 first commits exposeing the CloseIdleConnections() are useful\nok, this seems to work , but it will be nice to have more feedback would you be able to test and see if this solve your issue?\nHi aojea, I have test on v1.21.1 before merge , there are 6 connections to kube-apiserver from kubelet ! after merge , there is only 1 connection to kube-apiserver from kubelet ! so, can solve my issue. thank you very much.", "positive_passages": [{"docid": "doc-en-kubernetes-b689b62f1b7f411a1b64dba4eb65e0b5df9e61c783f81eb48524172d327ad921", "text": "}) } } <ins> func TestReuseRequest(t *testing.T) { var tests = []struct { name        string enableHTTP2 bool }{ {\"HTTP1\", false}, {\"HTTP2\", true}, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.Write([]byte(r.RemoteAddr)) })) ts.EnableHTTP2 = tt.enableHTTP2 ts.StartTLS() defer ts.Close() ctx, cancel := context.WithCancel(context.Background()) defer cancel() c := testRESTClient(t, ts) req1, err := c.Verb(\"GET\"). Prefix(\"foo\"). DoRaw(ctx) if err != nil { t.Fatalf(\"Unexpected error: %v\", err) } req2, err := c.Verb(\"GET\"). Prefix(\"foo\"). DoRaw(ctx) if err != nil { t.Fatalf(\"Unexpected error: %v\", err) } if string(req1) != string(req2) { t.Fatalf(\"Expected %v to be equal to %v\", string(req1), string(req2)) } }) } } func TestHTTP1DoNotReuseRequestAfterTimeout(t *testing.T) { var tests = []struct { name        string enableHTTP2 bool }{ {\"HTTP1\", false}, {\"HTTP2\", true}, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { done := make(chan struct{}) ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { t.Logf(\"TEST Connected from %v on %vn\", r.RemoteAddr, r.URL.Path) if r.URL.Path == \"/hang\" { t.Logf(\"TEST hanging %vn\", r.RemoteAddr) <-done } w.Write([]byte(r.RemoteAddr)) })) ts.EnableHTTP2 = tt.enableHTTP2 ts.StartTLS() defer ts.Close() // close hanging connection before shutting down the http server defer close(done) ctx, cancel := context.WithCancel(context.Background()) defer cancel() transport, ok := ts.Client().Transport.(*http.Transport) if !ok { t.Fatalf(\"failed to assert *http.Transport\") } config := &Config{ Host:      ts.URL, Transport: utilnet.SetTransportDefaults(transport), Timeout:   100 * time.Millisecond, // These fields are required to create a REST client. ContentConfig: ContentConfig{ GroupVersion:         &schema.GroupVersion{}, NegotiatedSerializer: &serializer.CodecFactory{}, }, } if !tt.enableHTTP2 { config.TLSClientConfig.NextProtos = []string{\"http/1.1\"} } c, err := RESTClientFor(config) if err != nil { t.Fatalf(\"failed to create REST client: %v\", err) } req1, err := c.Verb(\"GET\"). Prefix(\"foo\"). DoRaw(ctx) if err != nil { t.Fatalf(\"Unexpected error: %v\", err) } _, err = c.Verb(\"GET\"). Prefix(\"/hang\"). DoRaw(ctx) if err == nil { t.Fatalf(\"Expected error\") } req2, err := c.Verb(\"GET\"). Prefix(\"foo\"). DoRaw(ctx) if err != nil { t.Fatalf(\"Unexpected error: %v\", err) } // http1 doesn't reuse the connection after it times if tt.enableHTTP2 != (string(req1) == string(req2)) { if tt.enableHTTP2 { t.Fatalf(\"Expected %v to be the same as %v\", string(req1), string(req2)) } else { t.Fatalf(\"Expected %v to be different to %v\", string(req1), string(req2)) } } }) } } func TestTransportConcurrency(t *testing.T) { const numReqs = 10 var tests = []struct { name        string enableHTTP2 bool }{ {\"HTTP1\", false}, {\"HTTP2\", true}, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { t.Logf(\"Connected from %v %v\", r.RemoteAddr, r.URL) fmt.Fprintf(w, \"%v\", r.FormValue(\"echo\")) })) ts.EnableHTTP2 = tt.enableHTTP2 ts.StartTLS() defer ts.Close() var wg sync.WaitGroup wg.Add(numReqs) c := testRESTClient(t, ts) reqs := make(chan string) defer close(reqs) for i := 0; i < 4; i++ { go func() { for req := range reqs { res, err := c.Get().Param(\"echo\", req).DoRaw(context.Background()) if err != nil { t.Errorf(\"error on req %s: %v\", req, err) wg.Done() continue } if string(res) != req { t.Errorf(\"body of req %s = %q; want %q\", req, res, req) } wg.Done() } }() } for i := 0; i < numReqs; i++ { reqs <- fmt.Sprintf(\"request-%d\", i) } wg.Wait() }) } } </ins>", "commid": "kubernetes_pr_104844"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aba51dd96df40d0beb046926abc87ad433d09ca6fbfd961a87056932acd3b90a", "query": "is wrong as it says default label can be specified, but KEP and other lines of changelog mentions annotation. Changelog is correct and consistent about default container feature for kubectl. I'm still not able to get this feature to work actually for . Kubernetes version (use ): v1.21.0\n/triage accepted thanks for reporting early!\n/remove-kind bug /kind documentation\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-ed84afd51951ac0b21a9d020b7a1a6f82f5f115c12a9a018bc06452fb51012aa", "text": "- [Deprecation of PodSecurityPolicy](#deprecation-of-podsecuritypolicy) - [Kubernetes API Reference Documentation](#kubernetes-api-reference-documentation) - [Kustomize Updates in Kubectl](#kustomize-updates-in-kubectl) <del> - [Default Container Labels](#default-container-labels) </del> <ins> - [Default Container Annotation](#default-container-annotation) </ins> - [Immutable Secrets and ConfigMaps](#immutable-secrets-and-configmaps) - [Structured Logging in Kubelet](#structured-logging-in-kubelet) - [Storage Capacity Tracking](#storage-capacity-tracking)", "commid": "kubernetes_pr_100985"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-aba51dd96df40d0beb046926abc87ad433d09ca6fbfd961a87056932acd3b90a", "query": "is wrong as it says default label can be specified, but KEP and other lines of changelog mentions annotation. Changelog is correct and consistent about default container feature for kubectl. I'm still not able to get this feature to work actually for . Kubernetes version (use ): v1.21.0\n/triage accepted thanks for reporting early!\n/remove-kind bug /kind documentation\n/sig release", "positive_passages": [{"docid": "doc-en-kubernetes-21f21a306230e84aee51c2b53326a067d600e748090732dc481d6dbf2844ec37", "text": "[Kustomize](https://github.com/kubernetes-sigs/kustomize) version in kubectl had a jump from v2.0.3 to [v4.0.5](https://github.com/kubernetes/kubernetes/pull/98946). Kustomize is now treated as a library and future updates will be less sporadic. <del> ### Default Container Labels </del> <ins> ### Default Container Annotation </ins> <del> Pod with multiple containers can use `kubectl.kubernetes.io/default-container` label to have a container preselected for kubectl commands. More can be read in [KEP-2227](https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/2227-kubectl-default-container/README.md). </del> <ins> Pod with multiple containers can use `kubectl.kubernetes.io/default-container` annotation to have a container preselected for kubectl commands. More can be read in [KEP-2227](https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/2227-kubectl-default-container/README.md). </ins> ### Immutable Secrets and ConfigMaps", "commid": "kubernetes_pr_100985"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5dbeddbf5de175404f5522b2077e28a64b79b608e6265257d0db899db5393953", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --panic as below when an Endpoint doesn't have zone. should print zone as if an Endpoint's zone is unset. not set \"\" for Nodes. Pods and export them as a service. kubectl to describe the corresponding EndpointSlice. Kubernetes version (use ): v1.21.0 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network /sig cli /assign", "positive_passages": [{"docid": "doc-en-kubernetes-8f1345774fd4700172cfcfad6cfb27c9ac41f5a2c0def80c1483c54b268d4e77", "text": "w.Write(LEVEL_2, \"NodeName:t%sn\", nodeNameText) zoneText := \"<unset>\" <del> if endpoint.NodeName != nil { </del> <ins> if endpoint.Zone != nil { </ins> zoneText = *endpoint.Zone } w.Write(LEVEL_2, \"Zone:t%sn\", zoneText)", "commid": "kubernetes_pr_101025"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5dbeddbf5de175404f5522b2077e28a64b79b608e6265257d0db899db5393953", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --panic as below when an Endpoint doesn't have zone. should print zone as if an Endpoint's zone is unset. not set \"\" for Nodes. Pods and export them as a service. kubectl to describe the corresponding EndpointSlice. Kubernetes version (use ): v1.21.0 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network /sig cli /assign", "positive_passages": [{"docid": "doc-en-kubernetes-dafac4dd7690088332508390c3763a72fa61000e64dc8701b425875d72c61fe2", "text": "Addresses:  []string{\"1.2.3.6\", \"1.2.3.7\"}, Conditions: discoveryv1.EndpointConditions{Ready: utilpointer.BoolPtr(true)}, TargetRef:  &corev1.ObjectReference{Kind: \"Pod\", Name: \"test-124\"}, <ins> NodeName:   utilpointer.StringPtr(\"node-2\"), </ins> }, }, Ports: []discoveryv1.EndpointPort{", "commid": "kubernetes_pr_101025"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5dbeddbf5de175404f5522b2077e28a64b79b608e6265257d0db899db5393953", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --panic as below when an Endpoint doesn't have zone. should print zone as if an Endpoint's zone is unset. not set \"\" for Nodes. Pods and export them as a service. kubectl to describe the corresponding EndpointSlice. Kubernetes version (use ): v1.21.0 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network /sig cli /assign", "positive_passages": [{"docid": "doc-en-kubernetes-65a3b913a3097252f7044442fa2d7476dab45f180406bbdf87563e06a1196609", "text": "Ready:    true Hostname:   <unset> TargetRef:  Pod/test-124 <del> NodeName:   <unset> </del> <ins> NodeName:   node-2 </ins> Zone:       <unset> Events:         <none>` + \"n\", },", "commid": "kubernetes_pr_101025"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bbd0dea25958876674448dd36e75dcb0eab526dc9c6df3a993f93a241b35e43d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --The default fluent-bit configuration for GCE Windows nodes produces unparsed JSON logs and does not forward container logs. Container log output is produced. fluent-bit on a given windows image. a GCE Windows e2e cluster and view the stackdriver output for pods. Kubernetes version (use ): 1.20+ Cloud provider or hardware configuration: GKE/GCE OS (e.g: ): Windows Kernel (e.g. ): Any version Install tools: fluent-bit Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows", "positive_passages": [{"docid": "doc-en-kubernetes-5cf38097eb66a71a57c8659aeee47f5bcf5e3c7e267387822f025f5820ddbc01", "text": "# Windows path it'll use it instead of the default unzipper. # See: https://github.com/containerd/containerd/issues/1896 Add-MachineEnvironmentPath -Path $PIGZ_ROOT <del> # Add process exclusion for Windows Defender to boost performance. </del> <ins> # Add process exclusion for Windows Defender to boost performance. </ins> Add-MpPreference -ExclusionProcess \"$PIGZ_ROOTunpigz.exe\" Log-Output \"Installed Pigz $PIGZ_VERSION\" } else {", "commid": "kubernetes_pr_101271"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bbd0dea25958876674448dd36e75dcb0eab526dc9c6df3a993f93a241b35e43d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --The default fluent-bit configuration for GCE Windows nodes produces unparsed JSON logs and does not forward container logs. Container log output is produced. fluent-bit on a given windows image. a GCE Windows e2e cluster and view the stackdriver output for pods. Kubernetes version (use ): 1.20+ Cloud provider or hardware configuration: GKE/GCE OS (e.g: ): Windows Kernel (e.g. ): Any version Install tools: fluent-bit Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows", "positive_passages": [{"docid": "doc-en-kubernetes-3cd7ad0a6e76c236b214015fcfee447773fcc23d1f287f67d94a976339731b08", "text": "# TODO(pjh): move the logging agent code below into a separate # module; it was put here temporarily to avoid disrupting the file layout in # the K8s release machinery. <del> $LOGGINGAGENT_VERSION = '1.6.0' </del> <ins> $LOGGINGAGENT_VERSION = '1.7.3' </ins> $LOGGINGAGENT_ROOT = 'C:fluent-bit' $LOGGINGAGENT_SERVICE = 'fluent-bit' $LOGGINGAGENT_CMDLINE = '*fluent-bit.exe*' <del> $LOGGINGEXPORTER_VERSION = 'v0.10.3' </del> <ins> $LOGGINGEXPORTER_VERSION = 'v0.16.2' </ins> $LOGGINGEXPORTER_ROOT = 'C:flb-exporter' $LOGGINGEXPORTER_SERVICE = 'flb-exporter' $LOGGINGEXPORTER_CMDLINE = '*flb-exporter.exe*'", "commid": "kubernetes_pr_101271"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bbd0dea25958876674448dd36e75dcb0eab526dc9c6df3a993f93a241b35e43d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --The default fluent-bit configuration for GCE Windows nodes produces unparsed JSON logs and does not forward container logs. Container log output is produced. fluent-bit on a given windows image. a GCE Windows e2e cluster and view the stackdriver output for pods. Kubernetes version (use ): 1.20+ Cloud provider or hardware configuration: GKE/GCE OS (e.g: ): Windows Kernel (e.g. ): Any version Install tools: fluent-bit Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows", "positive_passages": [{"docid": "doc-en-kubernetes-75ec052fc512b5d0f8a6cb62e54b1bde8782d26795ec886642e2be36de13d90a", "text": "$fluentbit_parser_file = \"$LOGGINGAGENT_ROOTconfparsers.conf\" $PARSERS_CONFIG | Out-File -FilePath $fluentbit_parser_file -Encoding ASCII <ins> # Create directory for all the log position files. New-Item -Type Directory -Path \"/var/run/google-fluentbit/pos-files/\" </ins> Log-Output \"Wrote logging config to $fluentbit_parser_file\" }", "commid": "kubernetes_pr_101271"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bbd0dea25958876674448dd36e75dcb0eab526dc9c6df3a993f93a241b35e43d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --The default fluent-bit configuration for GCE Windows nodes produces unparsed JSON logs and does not forward container logs. Container log output is produced. fluent-bit on a given windows image. a GCE Windows e2e cluster and view the stackdriver output for pods. Kubernetes version (use ): 1.20+ Cloud provider or hardware configuration: GKE/GCE OS (e.g: ): Windows Kernel (e.g. ): Any version Install tools: fluent-bit Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows", "positive_passages": [{"docid": "doc-en-kubernetes-495a07bdb8c542b5542dc9675959de7279bf530cf8d0033722c8f12b93cb7012", "text": "[SERVICE] Flush         5 Grace         120 <del> Log_Level     debug </del> <ins> Log_Level     info </ins> Log_File      /var/log/fluentbit.log Daemon        off Parsers_File  parsers.conf", "commid": "kubernetes_pr_101271"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bbd0dea25958876674448dd36e75dcb0eab526dc9c6df3a993f93a241b35e43d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --The default fluent-bit configuration for GCE Windows nodes produces unparsed JSON logs and does not forward container logs. Container log output is produced. fluent-bit on a given windows image. a GCE Windows e2e cluster and view the stackdriver output for pods. Kubernetes version (use ): 1.20+ Cloud provider or hardware configuration: GKE/GCE OS (e.g: ): Windows Kernel (e.g. ): Any version Install tools: fluent-bit Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows", "positive_passages": [{"docid": "doc-en-kubernetes-d97de0202439b80557a32ca70a402a348a64bb1eec440779f8716dea91085f7e", "text": "# # storage.backlog.mem_limit 5M [INPUT] Name         winlog Interval_Sec 2 # Channels Setup,Windows PowerShell Channels     application,system,security Tag          winevent.raw <del> DB           winlog.sqlite   # </del> <ins> DB           /var/run/google-fluentbit/pos-files/winlog.db </ins> # Json Log Example: # {\"log\":\"[info:2016-02-16T16:04:05.930-08:00] Some log text heren\",\"stream\":\"stdout\",\"time\":\"2016-02-17T00:04:05.931087621Z\"}", "commid": "kubernetes_pr_101271"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bbd0dea25958876674448dd36e75dcb0eab526dc9c6df3a993f93a241b35e43d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --The default fluent-bit configuration for GCE Windows nodes produces unparsed JSON logs and does not forward container logs. Container log output is produced. fluent-bit on a given windows image. a GCE Windows e2e cluster and view the stackdriver output for pods. Kubernetes version (use ): 1.20+ Cloud provider or hardware configuration: GKE/GCE OS (e.g: ): Windows Kernel (e.g. ): Any version Install tools: fluent-bit Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows", "positive_passages": [{"docid": "doc-en-kubernetes-a74df0e798ddf0c6397032a80ff491e9e952c884bf8062bbe934a85b7682324c", "text": "Alias            kube_containers Tag              kube_<namespace_name>_<pod_name>_<container_name> Tag_Regex        (?<pod_name>[a-z0-9]([-a-z0-9]*[a-z0-9])?(.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*)_(?<namespace_name>[^_]+)_(?<container_name>.+)- <del> Path             /var/log/containers/*.log </del> Mem_Buf_Limit    5MB Skip_Long_Lines  On Refresh_Interval 5 <del> DB               flb_kube.db # Settings from fluentd missing here. # tag reform.* # format json # time_key time # time_format %Y-%m-%dT%H:%M:%S.%NZ </del> <ins> Path             C:varlogcontainers*.log DB               /var/run/google-fluentbit/pos-files/flb_kube.db [FILTER] Name         parser Match        kube_* Key_Name     log Reserve_Data True Parser       docker Parser       containerd </ins> # Example: <del> # I0204 07:32:30.020537    3368 server.go:1048] POST /stats/container/: (13.972191ms) 200 [[Go-http-client/1.1] 10.244.1.3:40537] </del> <ins> # I0928 03:15:50.440223    4880 main.go:51] Starting CSI-Proxy Server ... </ins> [INPUT] Name             tail <del> Alias            kubelet Tag              kubelet #Multiline        on #Multiline_Flush  5 </del> <ins> Alias            csi-proxy Tag              csi-proxy </ins> Mem_Buf_Limit    5MB Skip_Long_Lines  On Refresh_Interval 5 <del> Path /etc/kubernetes/logs/kubelet.log DB               /etc/kubernetes/logs/gcp-kubelet.db # Copied from fluentbit config. How is this used ? In match stages ? Parser_Firstline /^wd{4}/ Parser_1         ^(?<severity>w)(?<time>d{4} [^s]*)s+(?<pid>d+)s+(?<source>[^ ]]+)] (?<message>.*)/ # missing from fluentbit #   time_format %m%d %H:%M:%S.%N </del> <ins> Path             /etc/kubernetes/logs/csi-proxy.log DB               /var/run/google-fluentbit/pos-files/csi-proxy.db Multiline        On Parser_Firstline glog </ins> <del> # Example: # I0928 03:15:50.440223    4880 main.go:51] Starting CSI-Proxy Server ... </del> <ins> # I1118 21:26:53.975789       6 proxier.go:1096] Port \"nodePort for kube-system/default-http-backend:http\" (:31429/tcp) was open before and is still needed </ins> [INPUT] Name             tail <del> Alias            csi-proxy Tag              csi-proxy #Multiline        on #Multiline_Flush  5 </del> <ins> Alias            kube-proxy Tag              kube-proxy </ins> Mem_Buf_Limit    5MB Skip_Long_Lines  On Refresh_Interval 5 <del> Path             /etc/kubernetes/logs/csi-proxy.log DB               /etc/kubernetes/logs/gcp-csi-proxy.db # Copied from fluentbit config. How is this used ? In match stages ? Parser_Firstline /^wd{4}/ Parser_1         ^(?<severity>w)(?<time>d{4} [^s]*)s+(?<pid>d+)s+(?<source>[^ ]]+)] (?<message>.*)/ # missing from fluentbit #   time_format %m%d %H:%M:%S.%N </del> <ins> Path             /etc/kubernetes/logs/kube-proxy.log DB               /var/run/google-fluentbit/pos-files/kube-proxy.db Multiline        On Parser_Firstline glog </ins> # Example: # time=\"2019-12-10T21:27:59.836946700Z\" level=info msg=\"loading plugin \"io.containerd.grpc.v1.cri\"...\" type=io.containerd.grpc.v1 [INPUT] Name             tail Alias            container-runtime <del> Tag container-runtime #Multiline        on #Multiline_Flush  5 </del> <ins> Tag              container-runtime </ins> Mem_Buf_Limit    5MB Skip_Long_Lines  On Refresh_Interval 5 Path             /etc/kubernetes/logs/containerd.log <del> DB               /etc/kubernetes/logs/gcp-containerd.log.pos # Copied from fluentbit config. How is this used ? In match stages ? Parser_Firstline /^wd{4}/ Parser_1         ^(?<severity>w)(?<time>d{4} [^s]*)s+(?<pid>d+)s+(?<source>[^ ]]+)] (?<message>.*)/ </del> <ins> DB               /var/run/google-fluentbit/pos-files/container-runtime.db # TODO: Add custom parser for containerd logs once format is settled. </ins> <del> # missing from fluentbit #   time_format %m%d %H:%M:%S.%N # I1118 21:26:53.975789       6 proxier.go:1096] Port \"nodePort for kube-system/default-http-backend:http\" (:31429/tcp) was open before and is still needed </del> <ins> # Example: # I0204 07:32:30.020537    3368 server.go:1048] POST /stats/container/: (13.972191ms) 200 [[Go-http-client/1.1] 10.244.1.3:40537] </ins> [INPUT] Name             tail <del> Alias            kube-proxy Tag              kube-proxy #Multiline        on #Multiline_Flush  5 </del> <ins> Alias            kubelet Tag              kubelet </ins> Mem_Buf_Limit    5MB Skip_Long_Lines  On Refresh_Interval 5 <del> Path             /etc/kubernetes/logs/kube-proxy.log DB               /etc/kubernetes/logs/gcp-kubeproxy.db # Copied from fluentbit config. How is this used ? In match stages ? Parser_Firstline /^wd{4}/ Parser_1         ^(?<severity>w)(?<time>d{4} [^s]*)s+(?<pid>d+)s+(?<source>[^ ]]+)] (?<message>.*)/ # missing from fluentbit #   time_format %m%d %H:%M:%S.%N </del> <ins> Path             /etc/kubernetes/logs/kubelet.log DB               /var/run/google-fluentbit/pos-files/kubelet.db Multiline        On Parser_Firstline glog </ins> [FILTER] Name        modify Match       * Hard_rename log message <del> # [OUTPUT] #    Name        http #    Match       * #    Host        127.0.0.1 #    Port        2021 #    URI         /logs #    header_tag  FLUENT-TAG #    Format      msgpack #    Retry_Limit 2 </del> <ins> [FILTER] Name         parser Match        kube_* Key_Name     message Reserve_Data True Parser       glog Parser       json </ins> [OUTPUT] <del> name  stackdriver match * </del> <ins> Name        http Match       * Host        127.0.0.1 Port        2021 URI         /logs header_tag  FLUENT-TAG Format      msgpack Retry_Limit 2 </ins> '@ # Fluentbit parsers config file $PARSERS_CONFIG = @' [PARSER] Name        docker Format      json", "commid": "kubernetes_pr_101271"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bbd0dea25958876674448dd36e75dcb0eab526dc9c6df3a993f93a241b35e43d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --The default fluent-bit configuration for GCE Windows nodes produces unparsed JSON logs and does not forward container logs. Container log output is produced. fluent-bit on a given windows image. a GCE Windows e2e cluster and view the stackdriver output for pods. Kubernetes version (use ): 1.20+ Cloud provider or hardware configuration: GKE/GCE OS (e.g: ): Windows Kernel (e.g. ): Any version Install tools: fluent-bit Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows", "positive_passages": [{"docid": "doc-en-kubernetes-23fbc61f7a28fe3f931e7b24d2e82d40e2941562cdc2544440b738b7dbd273ce", "text": "Time_Key    timestamp Time_Format %Y-%m-%dT%H:%M:%S.%L%z <del> # ---------- [PARSER] Name   json Format json Time_Key time Time_Format %d/%b/%Y:%H:%M:%S %z [PARSER] Name         docker Format       json Time_Key     time Time_Format  %Y-%m-%dT%H:%M:%S.%L Time_Keep    On </del> [PARSER] Name        syslog-rfc5424 Format      regex", "commid": "kubernetes_pr_101271"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bbd0dea25958876674448dd36e75dcb0eab526dc9c6df3a993f93a241b35e43d", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --The default fluent-bit configuration for GCE Windows nodes produces unparsed JSON logs and does not forward container logs. Container log output is produced. fluent-bit on a given windows image. a GCE Windows e2e cluster and view the stackdriver output for pods. Kubernetes version (use ): 1.20+ Cloud provider or hardware configuration: GKE/GCE OS (e.g: ): Windows Kernel (e.g. ): Any version Install tools: fluent-bit Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig windows", "positive_passages": [{"docid": "doc-en-kubernetes-5a4c7307dc03a412a270ef407bfa502aee997fc72e05b80614fb1d1dfc9547af", "text": "$PARSERS_CONFIG | Out-File -FilePath $fluentbit_parser_file -Encoding ASCII # Create directory for all the log position files. <del> New-Item -Type Directory -Path \"/var/run/google-fluentbit/pos-files/\" </del> <ins> New-Item -Type Directory -Path \"/var/run/google-fluentbit/pos-files/\" -Force | Out-Null </ins> Log-Output \"Wrote logging config to $fluentbit_parser_file\" }", "commid": "kubernetes_pr_101621"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0d31b529ad18ab8ac0c277cb97efa356e067ca8611b5a6622e5e9dbc9e5cd06a", "query": "I am aware that the following is a corner case that does not occur in day-to-day business, but it took me a long while to debug, so I thought I would raise this issue to save others from the same pain. Deploying the following job with empty imagePullSecrets leads to it being stuck in forever, and status looking the following way: The status should look something like: This would allow my autoscaler to kick in and add the corresponding nodes. Run Kubernetes version (use ):Cloud provider or hardware configuration: AWS EKS OS (e.g: ): MacOSX 11.3 Kernel (e.g. ): Darwin Kernel Version 20.4.0 Install tools: brew\n/sig scheduling (I assume)\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig scheduling (I assume) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign Scheduler log\nShould we instead forbid empty items in ? Is there a use case for using as ?\nFor me personally that would be totally fine I had no use case for it. It was more produced by chance as I wasn't aware that I had to handle the case separately. An error which led to an early failure would have been fine by me and solved all my problems in tracking this down.\n/assign as\nForbidding it is the appropriate solution. However, we can't do it for backwards compatibility of the API. /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-6ccd0d68a678c5a65dd9eb1ec83155726e78e337e69042fc0f4e4c10e7193959", "text": "func updatePod(client clientset.Interface, pod *v1.Pod, condition *v1.PodCondition, nominatedNode string) error { klog.V(3).InfoS(\"Updating pod condition\", \"pod\", klog.KObj(pod), \"conditionType\", condition.Type, \"conditionStatus\", condition.Status, \"conditionReason\", condition.Reason) <del> podCopy := pod.DeepCopy() </del> <ins> podStatusCopy := pod.Status.DeepCopy() </ins> // NominatedNodeName is updated only if we are trying to set it, and the value is // different from the existing one. <del> if !podutil.UpdatePodCondition(&podCopy.Status, condition) && </del> <ins> if !podutil.UpdatePodCondition(podStatusCopy, condition) && </ins> (len(nominatedNode) == 0 || pod.Status.NominatedNodeName == nominatedNode) { return nil } if nominatedNode != \"\" { <del> podCopy.Status.NominatedNodeName = nominatedNode </del> <ins> podStatusCopy.NominatedNodeName = nominatedNode </ins> } <del> return util.PatchPod(client, pod, podCopy) </del> <ins> return util.PatchPodStatus(client, pod, podStatusCopy) </ins> } // assume signals to the cache that a pod is already in the cache, so that binding can be asynchronous.", "commid": "kubernetes_pr_103133"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0d31b529ad18ab8ac0c277cb97efa356e067ca8611b5a6622e5e9dbc9e5cd06a", "query": "I am aware that the following is a corner case that does not occur in day-to-day business, but it took me a long while to debug, so I thought I would raise this issue to save others from the same pain. Deploying the following job with empty imagePullSecrets leads to it being stuck in forever, and status looking the following way: The status should look something like: This would allow my autoscaler to kick in and add the corresponding nodes. Run Kubernetes version (use ):Cloud provider or hardware configuration: AWS EKS OS (e.g: ): MacOSX 11.3 Kernel (e.g. ): Darwin Kernel Version 20.4.0 Install tools: brew\n/sig scheduling (I assume)\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig scheduling (I assume) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign Scheduler log\nShould we instead forbid empty items in ? Is there a use case for using as ?\nFor me personally that would be totally fine I had no use case for it. It was more produced by chance as I wasn't aware that I had to handle the case separately. An error which led to an early failure would have been fine by me and solved all my problems in tracking this down.\n/assign as\nForbidding it is the appropriate solution. However, we can't do it for backwards compatibility of the API. /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-ad8189506a6f58ad8ffb5365c90cc4f03ddd77498d632354e0c1f180a585c8c6", "text": "return GetPodStartTime(pod1).Before(GetPodStartTime(pod2)) } <del> // PatchPod calculates the delta bytes change from <old> to <new>, </del> <ins> // PatchPodStatus calculates the delta bytes change from <old.Status> to <newStatus>, </ins> // and then submit a request to API server to patch the pod changes. <del> func PatchPod(cs kubernetes.Interface, old *v1.Pod, new *v1.Pod) error { oldData, err := json.Marshal(old) </del> <ins> func PatchPodStatus(cs kubernetes.Interface, old *v1.Pod, newStatus *v1.PodStatus) error { if newStatus == nil { return nil } oldData, err := json.Marshal(v1.Pod{Status: old.Status}) </ins> if err != nil { return err } <del> newData, err := json.Marshal(new) </del> <ins> newData, err := json.Marshal(v1.Pod{Status: *newStatus}) </ins> if err != nil { return err }", "commid": "kubernetes_pr_103133"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0d31b529ad18ab8ac0c277cb97efa356e067ca8611b5a6622e5e9dbc9e5cd06a", "query": "I am aware that the following is a corner case that does not occur in day-to-day business, but it took me a long while to debug, so I thought I would raise this issue to save others from the same pain. Deploying the following job with empty imagePullSecrets leads to it being stuck in forever, and status looking the following way: The status should look something like: This would allow my autoscaler to kick in and add the corresponding nodes. Run Kubernetes version (use ):Cloud provider or hardware configuration: AWS EKS OS (e.g: ): MacOSX 11.3 Kernel (e.g. ): Darwin Kernel Version 20.4.0 Install tools: brew\n/sig scheduling (I assume)\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig scheduling (I assume) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign Scheduler log\nShould we instead forbid empty items in ? Is there a use case for using as ?\nFor me personally that would be totally fine I had no use case for it. It was more produced by chance as I wasn't aware that I had to handle the case separately. An error which led to an early failure would have been fine by me and solved all my problems in tracking this down.\n/assign as\nForbidding it is the appropriate solution. However, we can't do it for backwards compatibility of the API. /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-94e68225d207bdcde6b92b6b6316f8a30d4b84104da9923292c1adbb65f2ca16", "text": "if len(p.Status.NominatedNodeName) == 0 { continue } <del> podCopy := p.DeepCopy() podCopy.Status.NominatedNodeName = \"\" if err := PatchPod(cs, p, podCopy); err != nil { </del> <ins> podStatusCopy := p.Status.DeepCopy() podStatusCopy.NominatedNodeName = \"\" if err := PatchPodStatus(cs, p, podStatusCopy); err != nil { </ins> errs = append(errs, err) } }", "commid": "kubernetes_pr_103133"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0d31b529ad18ab8ac0c277cb97efa356e067ca8611b5a6622e5e9dbc9e5cd06a", "query": "I am aware that the following is a corner case that does not occur in day-to-day business, but it took me a long while to debug, so I thought I would raise this issue to save others from the same pain. Deploying the following job with empty imagePullSecrets leads to it being stuck in forever, and status looking the following way: The status should look something like: This would allow my autoscaler to kick in and add the corresponding nodes. Run Kubernetes version (use ):Cloud provider or hardware configuration: AWS EKS OS (e.g: ): MacOSX 11.3 Kernel (e.g. ): Darwin Kernel Version 20.4.0 Install tools: brew\n/sig scheduling (I assume)\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig scheduling (I assume) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign Scheduler log\nShould we instead forbid empty items in ? Is there a use case for using as ?\nFor me personally that would be totally fine I had no use case for it. It was more produced by chance as I wasn't aware that I had to handle the case separately. An error which led to an early failure would have been fine by me and solved all my problems in tracking this down.\n/assign as\nForbidding it is the appropriate solution. However, we can't do it for backwards compatibility of the API. /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-f4d9fe29293608a3ad0c45e403df181ec396b4ed5c70d50abac5a0682ef0baaf", "text": "package util import ( <ins> \"context\" </ins> \"fmt\" <ins> \"github.com/google/go-cmp/cmp\" </ins> \"testing\" \"time\"", "commid": "kubernetes_pr_103133"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0d31b529ad18ab8ac0c277cb97efa356e067ca8611b5a6622e5e9dbc9e5cd06a", "query": "I am aware that the following is a corner case that does not occur in day-to-day business, but it took me a long while to debug, so I thought I would raise this issue to save others from the same pain. Deploying the following job with empty imagePullSecrets leads to it being stuck in forever, and status looking the following way: The status should look something like: This would allow my autoscaler to kick in and add the corresponding nodes. Run Kubernetes version (use ):Cloud provider or hardware configuration: AWS EKS OS (e.g: ): MacOSX 11.3 Kernel (e.g. ): Darwin Kernel Version 20.4.0 Install tools: brew\n/sig scheduling (I assume)\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig scheduling (I assume) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign Scheduler log\nShould we instead forbid empty items in ? Is there a use case for using as ?\nFor me personally that would be totally fine I had no use case for it. It was more produced by chance as I wasn't aware that I had to handle the case separately. An error which led to an early failure would have been fine by me and solved all my problems in tracking this down.\n/assign as\nForbidding it is the appropriate solution. However, we can't do it for backwards compatibility of the API. /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-a808255da8a57e4775a86d359f489655b3d3b14f0caddca596c571ffdea74665", "text": "}) } } <ins> func TestPatchPodStatus(t *testing.T) { tests := []struct { name           string pod            v1.Pod statusToUpdate v1.PodStatus }{ { name: \"Should update pod conditions successfully\", pod: v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Namespace: \"ns\", Name:      \"pod1\", }, Spec: v1.PodSpec{ ImagePullSecrets: []v1.LocalObjectReference{{Name: \"foo\"}}, }, }, statusToUpdate: v1.PodStatus{ Conditions: []v1.PodCondition{ { Type:   v1.PodScheduled, Status: v1.ConditionFalse, }, }, }, }, { // ref: #101697, #94626 - ImagePullSecrets are allowed to have empty secret names // which would fail the 2-way merge patch generation on Pod patches // due to the mergeKey being the name field name: \"Should update pod conditions successfully on a pod Spec with secrets with empty name\", pod: v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Namespace: \"ns\", Name:      \"pod2\", }, Spec: v1.PodSpec{ // this will serialize to imagePullSecrets:[{}] ImagePullSecrets: make([]v1.LocalObjectReference, 1), }, }, statusToUpdate: v1.PodStatus{ Conditions: []v1.PodCondition{ { Type:   v1.PodScheduled, Status: v1.ConditionFalse, }, }, }, }, } client := clientsetfake.NewSimpleClientset() for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { _, err := client.CoreV1().Pods(tc.pod.Namespace).Create(context.TODO(), &tc.pod, metav1.CreateOptions{}) if err != nil { t.Fatal(err) } err = PatchPodStatus(client, &tc.pod, &tc.statusToUpdate) if err != nil { t.Fatal(err) } retrievedPod, err := client.CoreV1().Pods(tc.pod.Namespace).Get(context.TODO(), tc.pod.Name, metav1.GetOptions{}) if err != nil { t.Fatal(err) } if diff := cmp.Diff(tc.statusToUpdate, retrievedPod.Status); diff != \"\" { t.Errorf(\"unexpected pod status (-want,+got):n%s\", diff) } }) } } </ins>", "commid": "kubernetes_pr_103133"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-42ade061097ae5f80973c5fd4b117fd96ad5db21a1537dde34d7fd47084d9373", "query": "This issue is a bucket placeholder for collaborating on the \"Known Issues\" additions for the 1.22 Release Notes(). If you know of issues or API changes that are going out in 1.22, please comment here so that we can coordinate incorporating information about these changes in the Release Notes. /assign /sig release /milestone v1.22\nGitHub didn't allow me to assign the following users: simcard0000. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : This issue is a bucket placeholder for collaborating on the \"Known Issues\" additions for the 1.22 Release Notes(). If you know of issues or API changes that are going out in 1.19, please comment here so that we can coordinate incorporating information about these changes in the Release Notes. /sig release /milestone v1.22 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\n1.19 or 1.22 ?\n/assign\nFor the 1.21 example in , should be changed to\nPlease add the following to the Known Issues section of the 1.22 Release Notes: CC\nCan you also mention the CSIMigrationVSphere feature gate in the note as well?\nwhat should I mention about the CSIMigrationVSphere feature gate? If someone uses vSphere CSI Driver, he/she should not upgrade to v1.22 whether CSIMigrationVSphere is on or off. If someone does not use vSphere CSI Driver, then we also don't need to worry about this feature gate.\nIf the feature gate is enabled, they should also hold off on upgrading to 1.22\nThe main concern as far as k8s release is - it is intree to CSI migration of vSphere volumes that is broken in 1.22. So I think our release note should say something like:", "positive_passages": [{"docid": "doc-en-kubernetes-d0b2a1694e137a25f0c9d773183746b4cbbfdc14bd5ba535205288f1c6c3991e", "text": "<ins> # Maintainers Eric Paris <eparis@redhat.com> </ins>", "commid": "kubernetes_pr_1647"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-42ade061097ae5f80973c5fd4b117fd96ad5db21a1537dde34d7fd47084d9373", "query": "This issue is a bucket placeholder for collaborating on the \"Known Issues\" additions for the 1.22 Release Notes(). If you know of issues or API changes that are going out in 1.22, please comment here so that we can coordinate incorporating information about these changes in the Release Notes. /assign /sig release /milestone v1.22\nGitHub didn't allow me to assign the following users: simcard0000. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : This issue is a bucket placeholder for collaborating on the \"Known Issues\" additions for the 1.22 Release Notes(). If you know of issues or API changes that are going out in 1.19, please comment here so that we can coordinate incorporating information about these changes in the Release Notes. /sig release /milestone v1.22 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\n1.19 or 1.22 ?\n/assign\nFor the 1.21 example in , should be changed to\nPlease add the following to the Known Issues section of the 1.22 Release Notes: CC\nCan you also mention the CSIMigrationVSphere feature gate in the note as well?\nwhat should I mention about the CSIMigrationVSphere feature gate? If someone uses vSphere CSI Driver, he/she should not upgrade to v1.22 whether CSIMigrationVSphere is on or off. If someone does not use vSphere CSI Driver, then we also don't need to worry about this feature gate.\nIf the feature gate is enabled, they should also hold off on upgrading to 1.22\nThe main concern as far as k8s release is - it is intree to CSI migration of vSphere volumes that is broken in 1.22. So I think our release note should say something like:", "positive_passages": [{"docid": "doc-en-kubernetes-a70238982f99fadc61e7ce926d51d6c8b6faa8bfc5da0332d4165249799ad153", "text": "<ins> #!bash # # bash completion file for core kubecfg commands # # This script provides completion of non replication controller options # # To enable the completions either: #  - place this file in /etc/bash_completion.d #  or #  - copy this file and add the line below to your .bashrc after #    bash completion features are loaded #     . kubecfg # # Note: # Currently, the completions will not work if the apiserver daemon is not # running on localhost on the standard port 8080 __contains_word () { local w word=$1; shift for w in \"$@\"; do [[ $w = \"$word\" ]] && return done return 1 } # This should be provided by the bash-completions, but give a really simple # stoopid version just in case.  It works most of the time. if ! declare -F _get_comp_words_by_ref >/dev/null 2>&1; then _get_comp_words_by_ref () { while [ $# -gt 0 ]; do case \"$1\" in cur) cur=${COMP_WORDS[COMP_CWORD]} ;; prev) prev=${COMP_WORDS[COMP_CWORD-1]} ;; words) words=(\"${COMP_WORDS[@]}\") ;; cword) cword=$COMP_CWORD ;; -n) shift # we don't handle excludes ;; esac shift done } fi __has_service() { local i for ((i=0; i < cword; i++)); do local word=${words[i]} # strip everything after a / so things like pods/[id] match word=${word%%/*} if __contains_word \"${word}\" \"${services[@]}\" && ! __contains_word \"${words[i-1]}\" \"${opts[@]}\"; then return 0 fi done return 1 } # call kubecfg list $1, # exclude blank lines # skip the header stuff kubecfg prints on the first 2 lines # append $1/ to the first column and use that in compgen __kubecfg_parse_list() { local kubecfg_output if kubecfg_output=$(kubecfg list \"$1\" 2>/dev/null); then out=($(echo \"${kubecfg_output}\" | awk -v prefix=\"$1\" '/^$/ {next} NR > 2 {print prefix\"/\"$1}')) COMPREPLY=( $( compgen -W \"${out[*]}\" -- \"$cur\" ) ) fi } _kubecfg_specific_service_match() { case \"$cur\" in pods/*) __kubecfg_parse_list pods ;; minions/*) __kubecfg_parse_list minions ;; replicationControllers/*) __kubecfg_parse_list replicationControllers ;; services/*) __kubecfg_parse_list services ;; *) if __has_service; then return 0 fi compopt -o nospace COMPREPLY=( $( compgen -S / -W \"${services[*]}\" -- \"$cur\" ) ) ;; esac } _kubecfg_service_match() { if __has_service; then return 0 fi COMPREPLY=( $( compgen -W \"${services[*]}\" -- \"$cur\" ) ) } _kubecfg() { local opts=( -h -c ) local create_services=(pods replicationControllers services) local update_services=(replicationControllers) local all_services=(pods replicationControllers services minions) local services=(\"${all_services[@]}\") local json_commands=(create update) local all_commands=(create update get list delete stop rm rollingupdate resize) local commands=(\"${all_commands[@]}\") COMPREPLY=() local command local cur prev words cword _get_comp_words_by_ref -n : cur prev words cword if __contains_word \"$prev\" \"${opts[@]}\"; then case $prev in -c) _filedir '@(json|yml|yaml)' return 0 ;; -h) return 0 ;; esac fi if [[ \"$cur\" = -* ]]; then COMPREPLY=( $(compgen -W \"${opts[*]}\" -- \"$cur\") ) return 0 fi # if you passed -c, you are limited to create or update if __contains_word \"-c\" \"${words[@]}\"; then services=(\"${create_services[@]}\" \"${update_services[@]}\") commands=(\"${json_commands[@]}\") fi # figure out which command they are running, remembering that arguments to # options don't count as the command!  So a hostname named 'create' won't # trip things up local i for ((i=0; i < cword; i++)); do if __contains_word \"${words[i]}\" \"${commands[@]}\" && ! __contains_word \"${words[i-1]}\" \"${opts[@]}\"; then command=${words[i]} break fi done # tell the list of possible commands if [[ -z ${command} ]]; then COMPREPLY=( $( compgen -W \"${commands[*]}\" -- \"$cur\" ) ) return 0 fi # remove services which you can't update given your command if [[ ${command} == \"create\" ]]; then services=(\"${create_services[@]}\") elif [[ ${command} == \"update\" ]]; then services=(\"${update_services[@]}\") fi case $command in create | list) _kubecfg_service_match ;; update | get | delete) _kubecfg_specific_service_match ;; *) ;; esac return 0 } complete -F _kubecfg kubecfg # ex: ts=4 sw=4 et filetype=sh </ins>", "commid": "kubernetes_pr_1647"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-42ade061097ae5f80973c5fd4b117fd96ad5db21a1537dde34d7fd47084d9373", "query": "This issue is a bucket placeholder for collaborating on the \"Known Issues\" additions for the 1.22 Release Notes(). If you know of issues or API changes that are going out in 1.22, please comment here so that we can coordinate incorporating information about these changes in the Release Notes. /assign /sig release /milestone v1.22\nGitHub didn't allow me to assign the following users: simcard0000. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : This issue is a bucket placeholder for collaborating on the \"Known Issues\" additions for the 1.22 Release Notes(). If you know of issues or API changes that are going out in 1.19, please comment here so that we can coordinate incorporating information about these changes in the Release Notes. /sig release /milestone v1.22 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\n1.19 or 1.22 ?\n/assign\nFor the 1.21 example in , should be changed to\nPlease add the following to the Known Issues section of the 1.22 Release Notes: CC\nCan you also mention the CSIMigrationVSphere feature gate in the note as well?\nwhat should I mention about the CSIMigrationVSphere feature gate? If someone uses vSphere CSI Driver, he/she should not upgrade to v1.22 whether CSIMigrationVSphere is on or off. If someone does not use vSphere CSI Driver, then we also don't need to worry about this feature gate.\nIf the feature gate is enabled, they should also hold off on upgrading to 1.22\nThe main concern as far as k8s release is - it is intree to CSI migration of vSphere volumes that is broken in 1.22. So I think our release note should say something like:", "positive_passages": [{"docid": "doc-en-kubernetes-3b11a81468f6a5ac23a5c5152bea0f7aaadbb57189a6cd5f4abeb0c3a33cdcd4", "text": "<del> #!bash # # bash completion file for core kubecfg commands # # This script provides completion of non replication controller options # # To enable the completions either: #  - place this file in /etc/bash_completion.d #  or #  - copy this file and add the line below to your .bashrc after #    bash completion features are loaded #     . kubecfg # # Note: # Currently, the completions will not work if the apiserver daemon is not # running on localhost on the standard port 8080 __contains_word () { local w word=$1; shift for w in \"$@\"; do [[ $w = \"$word\" ]] && return done return 1 } # This should be provided by the bash-completions, but give a really simple # stoopid version just in case.  It works most of the time. if ! declare -F _get_comp_words_by_ref >/dev/null 2>&1; then _get_comp_words_by_ref () { while [ $# -gt 0 ]; do case \"$1\" in cur) cur=${COMP_WORDS[COMP_CWORD]} ;; prev) prev=${COMP_WORDS[COMP_CWORD-1]} ;; words) words=(\"${COMP_WORDS[@]}\") ;; cword) cword=$COMP_CWORD ;; -n) shift # we don't handle excludes ;; esac shift done } fi __has_service() { local i for ((i=0; i < cword; i++)); do local word=${words[i]} # strip everything after a / so things like pods/[id] match word=${word%%/*} if __contains_word \"${word}\" \"${services[@]}\" && ! __contains_word \"${words[i-1]}\" \"${opts[@]}\"; then return 0 fi done return 1 } # call kubecfg list $1, # exclude blank lines # skip the header stuff kubecfg prints on the first 2 lines # append $1/ to the first column and use that in compgen __kubecfg_parse_list() { local kubecfg_output if kubecfg_output=$(kubecfg list \"$1\" 2>/dev/null); then out=($(echo \"${kubecfg_output}\" | awk -v prefix=\"$1\" '/^$/ {next} NR > 2 {print prefix\"/\"$1}')) COMPREPLY=( $( compgen -W \"${out[*]}\" -- \"$cur\" ) ) fi } _kubecfg_specific_service_match() { case \"$cur\" in pods/*) __kubecfg_parse_list pods ;; minions/*) __kubecfg_parse_list minions ;; replicationControllers/*) __kubecfg_parse_list replicationControllers ;; services/*) __kubecfg_parse_list services ;; *) if __has_service; then return 0 fi compopt -o nospace COMPREPLY=( $( compgen -S / -W \"${services[*]}\" -- \"$cur\" ) ) ;; esac } _kubecfg_service_match() { if __has_service; then return 0 fi COMPREPLY=( $( compgen -W \"${services[*]}\" -- \"$cur\" ) ) } _kubecfg() { local opts=( -h -c ) local create_services=(pods replicationControllers services) local update_services=(replicationControllers) local all_services=(pods replicationControllers services minions) local services=(\"${all_services[@]}\") local json_commands=(create update) local all_commands=(create update get list delete stop rm rollingupdate resize) local commands=(\"${all_commands[@]}\") COMPREPLY=() local command local cur prev words cword _get_comp_words_by_ref -n : cur prev words cword if __contains_word \"$prev\" \"${opts[@]}\"; then case $prev in -c) _filedir '@(json|yml|yaml)' return 0 ;; -h) return 0 ;; esac fi if [[ \"$cur\" = -* ]]; then COMPREPLY=( $(compgen -W \"${opts[*]}\" -- \"$cur\") ) return 0 fi # if you passed -c, you are limited to create or update if __contains_word \"-c\" \"${words[@]}\"; then services=(\"${create_services[@]}\" \"${update_services[@]}\") commands=(\"${json_commands[@]}\") fi # figure out which command they are running, remembering that arguments to # options don't count as the command!  So a hostname named 'create' won't # trip things up local i for ((i=0; i < cword; i++)); do if __contains_word \"${words[i]}\" \"${commands[@]}\" && ! __contains_word \"${words[i-1]}\" \"${opts[@]}\"; then command=${words[i]} break fi done # tell the list of possible commands if [[ -z ${command} ]]; then COMPREPLY=( $( compgen -W \"${commands[*]}\" -- \"$cur\" ) ) return 0 fi # remove services which you can't update given your command if [[ ${command} == \"create\" ]]; then services=(\"${create_services[@]}\") elif [[ ${command} == \"update\" ]]; then services=(\"${update_services[@]}\") fi case $command in create | list) _kubecfg_service_match ;; update | get | delete) _kubecfg_specific_service_match ;; *) ;; esac return 0 } complete -F _kubecfg kubecfg # ex: ts=4 sw=4 et filetype=sh </del>", "commid": "kubernetes_pr_1647"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d3ee62bd648d090ba5f60cffe2913263c9a6e8cf4fbf17ccb827dfa4692ba2c", "query": "Expose totalAnnotationSizeLimitB in the validation package: This value is useful for validating annotations outside of the validation package, such as in SSA: Otherwise, size validation on annotations outside of the package would diverge and cause issues later. /kind cleanup /wg api-expression cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-0ae3493bdafcd2cfa1ddf0dec581c54b2be5291b5e50878392c3370a98a37931", "text": "// FieldImmutableErrorMsg is a error message for field is immutable. const FieldImmutableErrorMsg string = `field is immutable` <del> const totalAnnotationSizeLimitB int = 256 * (1 << 10) // 256 kB </del> <ins> const TotalAnnotationSizeLimitB int = 256 * (1 << 10) // 256 kB </ins> // BannedOwners is a black list of object that are not allowed to be owners. var BannedOwners = map[schema.GroupVersionKind]struct{}{", "commid": "kubernetes_pr_102150"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d3ee62bd648d090ba5f60cffe2913263c9a6e8cf4fbf17ccb827dfa4692ba2c", "query": "Expose totalAnnotationSizeLimitB in the validation package: This value is useful for validating annotations outside of the validation package, such as in SSA: Otherwise, size validation on annotations outside of the package would diverge and cause issues later. /kind cleanup /wg api-expression cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-82745622af70ba711fef92e167f1299dd5469f4e2002ec3348f7042a5786d985", "text": "// ValidateAnnotations validates that a set of annotations are correctly defined. func ValidateAnnotations(annotations map[string]string, fldPath *field.Path) field.ErrorList { allErrs := field.ErrorList{} <del> var totalSize int64 for k, v := range annotations { </del> <ins> for k := range annotations { </ins> for _, msg := range validation.IsQualifiedName(strings.ToLower(k)) { allErrs = append(allErrs, field.Invalid(fldPath, k, msg)) } <del> totalSize += (int64)(len(k)) + (int64)(len(v)) </del> } <del> if totalSize > (int64)(totalAnnotationSizeLimitB) { allErrs = append(allErrs, field.TooLong(fldPath, \"\", totalAnnotationSizeLimitB)) </del> <ins> if err := ValidateAnnotationsSize(annotations); err != nil { allErrs = append(allErrs, field.TooLong(fldPath, \"\", TotalAnnotationSizeLimitB)) </ins> } return allErrs } <ins> func ValidateAnnotationsSize(annotations map[string]string) error { var totalSize int64 for k, v := range annotations { totalSize += (int64)(len(k)) + (int64)(len(v)) } if totalSize > (int64)(TotalAnnotationSizeLimitB) { return fmt.Errorf(\"annotations size %d is larger than limit %d\", totalSize, TotalAnnotationSizeLimitB) } return nil } </ins> func validateOwnerReference(ownerReference metav1.OwnerReference, fldPath *field.Path) field.ErrorList { allErrs := field.ErrorList{} gvk := schema.FromAPIVersionAndKind(ownerReference.APIVersion, ownerReference.Kind)", "commid": "kubernetes_pr_102150"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d3ee62bd648d090ba5f60cffe2913263c9a6e8cf4fbf17ccb827dfa4692ba2c", "query": "Expose totalAnnotationSizeLimitB in the validation package: This value is useful for validating annotations outside of the validation package, such as in SSA: Otherwise, size validation on annotations outside of the package would diverge and cause issues later. /kind cleanup /wg api-expression cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-b21f4222d854a059bdae3ed9c2f834eaefd3d069df20510a6a76b201e6fff8ee", "text": "{\"1234/5678\": \"bar\"}, {\"1.2.3.4/5678\": \"bar\"}, {\"UpperCase123\": \"bar\"}, <del> {\"a\": strings.Repeat(\"b\", totalAnnotationSizeLimitB-1)}, </del> <ins> {\"a\": strings.Repeat(\"b\", TotalAnnotationSizeLimitB-1)}, </ins> { <del> \"a\": strings.Repeat(\"b\", totalAnnotationSizeLimitB/2-1), \"c\": strings.Repeat(\"d\", totalAnnotationSizeLimitB/2-1), </del> <ins> \"a\": strings.Repeat(\"b\", TotalAnnotationSizeLimitB/2-1), \"c\": strings.Repeat(\"d\", TotalAnnotationSizeLimitB/2-1), </ins> }, } for i := range successCases {", "commid": "kubernetes_pr_102150"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d3ee62bd648d090ba5f60cffe2913263c9a6e8cf4fbf17ccb827dfa4692ba2c", "query": "Expose totalAnnotationSizeLimitB in the validation package: This value is useful for validating annotations outside of the validation package, such as in SSA: Otherwise, size validation on annotations outside of the package would diverge and cause issues later. /kind cleanup /wg api-expression cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-f2eaed993bae425e6f8554913eef95f63320acc66c7d8524d4261344f49a5d37", "text": "} } totalSizeErrorCases := []map[string]string{ <del> {\"a\": strings.Repeat(\"b\", totalAnnotationSizeLimitB)}, </del> <ins> {\"a\": strings.Repeat(\"b\", TotalAnnotationSizeLimitB)}, </ins> { <del> \"a\": strings.Repeat(\"b\", totalAnnotationSizeLimitB/2), \"c\": strings.Repeat(\"d\", totalAnnotationSizeLimitB/2), </del> <ins> \"a\": strings.Repeat(\"b\", TotalAnnotationSizeLimitB/2), \"c\": strings.Repeat(\"d\", TotalAnnotationSizeLimitB/2), </ins> }, } for i := range totalSizeErrorCases {", "commid": "kubernetes_pr_102150"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d3ee62bd648d090ba5f60cffe2913263c9a6e8cf4fbf17ccb827dfa4692ba2c", "query": "Expose totalAnnotationSizeLimitB in the validation package: This value is useful for validating annotations outside of the validation package, such as in SSA: Otherwise, size validation on annotations outside of the package would diverge and cause issues later. /kind cleanup /wg api-expression cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-8f4b90ad7814df335406a1f13f772d4aa2e68bdba9244b25ee541c4533448138", "text": "corev1 \"k8s.io/api/core/v1\" \"k8s.io/apimachinery/pkg/api/meta\" <ins> apimachineryvalidation \"k8s.io/apimachinery/pkg/api/validation\" </ins> \"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured\" \"k8s.io/apimachinery/pkg/runtime\" ) <del> const totalAnnotationSizeLimitB int64 = 256 * (1 << 10) // 256 kB </del> type lastAppliedUpdater struct { fieldManager Manager }", "commid": "kubernetes_pr_102150"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d3ee62bd648d090ba5f60cffe2913263c9a6e8cf4fbf17ccb827dfa4692ba2c", "query": "Expose totalAnnotationSizeLimitB in the validation package: This value is useful for validating annotations outside of the validation package, such as in SSA: Otherwise, size validation on annotations outside of the package would diverge and cause issues later. /kind cleanup /wg api-expression cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-915d18095d0c439d7ce0e993f8c7b1020c818c3d6df1903570ca320b2365aa9c", "text": "annotations = map[string]string{} } annotations[corev1.LastAppliedConfigAnnotation] = value <del> if isAnnotationsValid(annotations) != nil { </del> <ins> if err := apimachineryvalidation.ValidateAnnotationsSize(annotations); err != nil { </ins> delete(annotations, corev1.LastAppliedConfigAnnotation) } accessor.SetAnnotations(annotations)", "commid": "kubernetes_pr_102150"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5d3ee62bd648d090ba5f60cffe2913263c9a6e8cf4fbf17ccb827dfa4692ba2c", "query": "Expose totalAnnotationSizeLimitB in the validation package: This value is useful for validating annotations outside of the validation package, such as in SSA: Otherwise, size validation on annotations outside of the package would diverge and cause issues later. /kind cleanup /wg api-expression cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-0a81e314bdddb29fec0520998957f99426d63064398d6091507c443b18a641d8", "text": "} return string(lastApplied), nil } <del> func isAnnotationsValid(annotations map[string]string) error { var totalSize int64 for k, v := range annotations { totalSize += (int64)(len(k)) + (int64)(len(v)) } if totalSize > (int64)(totalAnnotationSizeLimitB) { return fmt.Errorf(\"annotations size %d is larger than limit %d\", totalSize, totalAnnotationSizeLimitB) } return nil } </del>", "commid": "kubernetes_pr_102150"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b39b114e3f8b25c65861c9c397d758891e478151ec492017dfbfbc72cee16e3", "query": "[X] Test PR: kuberenetes/kubernetes [x] Two weeks soak end date: 1 July 2021 [x] Test promotion PR: kubernetes/kubernetes According to this APIsnoop query, there are still some remaining StatefulSet endpoints which are untested. Create a watch to track deployment events. Create a deployment with a static label. Confirm that the pods are running. Get the deployment status. Parse the response and confirm that the deployment status conditions can be listed. Update the deployment status. Confirm via the watch that the status has been updated. Patch the deployment status. Confirm via the watch that the status has been patched. Using an existing as a template for a new for deployment lifecycle test. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 1 point This test is also created with the goal of conformance promotion. /sig apps /sig testing /sig architecture /area conformance\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-73a3bb476970faf2e25ef6a84181c9aadc1bf64328fda2ba35dba2ca03f0f985", "text": "\"encoding/json\" \"fmt\" \"math/rand\" <ins> \"strings\" </ins> \"time\" \"github.com/davecgh/go-spew/spew\"", "commid": "kubernetes_pr_102260"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b39b114e3f8b25c65861c9c397d758891e478151ec492017dfbfbc72cee16e3", "query": "[X] Test PR: kuberenetes/kubernetes [x] Two weeks soak end date: 1 July 2021 [x] Test promotion PR: kubernetes/kubernetes According to this APIsnoop query, there are still some remaining StatefulSet endpoints which are untested. Create a watch to track deployment events. Create a deployment with a static label. Confirm that the pods are running. Get the deployment status. Parse the response and confirm that the deployment status conditions can be listed. Update the deployment status. Confirm via the watch that the status has been updated. Patch the deployment status. Confirm via the watch that the status has been patched. Using an existing as a template for a new for deployment lifecycle test. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 1 point This test is also created with the goal of conformance promotion. /sig apps /sig testing /sig architecture /area conformance\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-76acfdf3cfde97854d278be73ba3de6d1cda7ff5d72931713ee820c6f0861fb6", "text": "\"k8s.io/apimachinery/pkg/runtime/schema\" \"k8s.io/apimachinery/pkg/types\" \"k8s.io/apimachinery/pkg/util/intstr\" <ins> utilrand \"k8s.io/apimachinery/pkg/util/rand\" </ins> \"k8s.io/apimachinery/pkg/util/wait\" \"k8s.io/apimachinery/pkg/watch\" \"k8s.io/client-go/dynamic\" clientset \"k8s.io/client-go/kubernetes\" appsclient \"k8s.io/client-go/kubernetes/typed/apps/v1\" watchtools \"k8s.io/client-go/tools/watch\" <ins> \"k8s.io/client-go/util/retry\" </ins> appsinternal \"k8s.io/kubernetes/pkg/apis/apps\" deploymentutil \"k8s.io/kubernetes/pkg/controller/deployment/util\" \"k8s.io/kubernetes/test/e2e/framework\"", "commid": "kubernetes_pr_102260"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b39b114e3f8b25c65861c9c397d758891e478151ec492017dfbfbc72cee16e3", "query": "[X] Test PR: kuberenetes/kubernetes [x] Two weeks soak end date: 1 July 2021 [x] Test promotion PR: kubernetes/kubernetes According to this APIsnoop query, there are still some remaining StatefulSet endpoints which are untested. Create a watch to track deployment events. Create a deployment with a static label. Confirm that the pods are running. Get the deployment status. Parse the response and confirm that the deployment status conditions can be listed. Update the deployment status. Confirm via the watch that the status has been updated. Patch the deployment status. Confirm via the watch that the status has been patched. Using an existing as a template for a new for deployment lifecycle test. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 1 point This test is also created with the goal of conformance promotion. /sig apps /sig testing /sig architecture /area conformance\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-e5b990f82723e95ed268a3be05fb5914eeeff125984cd2010cac7ad4c318eaa1", "text": "}) framework.ExpectNoError(err, \"failed to see %v event\", watch.Deleted) }) <ins> ginkgo.It(\"should validate Deployment Status endpoints\", func() { dClient := c.AppsV1().Deployments(ns) dName := \"test-deployment-\" + utilrand.String(5) labelSelector := \"e2e=testing\" w := &cache.ListWatch{ WatchFunc: func(options metav1.ListOptions) (watch.Interface, error) { options.LabelSelector = labelSelector return dClient.Watch(context.TODO(), options) }, } dList, err := c.AppsV1().Deployments(\"\").List(context.TODO(), metav1.ListOptions{LabelSelector: labelSelector}) framework.ExpectNoError(err, \"failed to list Deployments\") ginkgo.By(\"creating a Deployment\") podLabels := map[string]string{\"name\": WebserverImageName, \"e2e\": \"testing\"} replicas := int32(1) framework.Logf(\"Creating simple deployment %s\", dName) d := e2edeployment.NewDeployment(dName, replicas, podLabels, WebserverImageName, WebserverImage, appsv1.RollingUpdateDeploymentStrategyType) deploy, err := c.AppsV1().Deployments(ns).Create(context.TODO(), d, metav1.CreateOptions{}) framework.ExpectNoError(err) // Wait for it to be updated to revision 1 err = e2edeployment.WaitForDeploymentRevisionAndImage(c, ns, dName, \"1\", WebserverImage) framework.ExpectNoError(err) err = e2edeployment.WaitForDeploymentComplete(c, deploy) framework.ExpectNoError(err) testDeployment, err := dClient.Get(context.TODO(), dName, metav1.GetOptions{}) framework.ExpectNoError(err) ginkgo.By(\"Getting /status\") dResource := schema.GroupVersionResource{Group: \"apps\", Version: \"v1\", Resource: \"deployments\"} dStatusUnstructured, err := f.DynamicClient.Resource(dResource).Namespace(ns).Get(context.TODO(), dName, metav1.GetOptions{}, \"status\") framework.ExpectNoError(err, \"Failed to fetch the status of deployment %s in namespace %s\", dName, ns) dStatusBytes, err := json.Marshal(dStatusUnstructured) framework.ExpectNoError(err, \"Failed to marshal unstructured response. %v\", err) var dStatus appsv1.Deployment err = json.Unmarshal(dStatusBytes, &dStatus) framework.ExpectNoError(err, \"Failed to unmarshal JSON bytes to a deployment object type\") framework.Logf(\"Deployment %s has Conditions: %v\", dName, dStatus.Status.Conditions) ginkgo.By(\"updating Deployment Status\") var statusToUpdate, updatedStatus *appsv1.Deployment err = retry.RetryOnConflict(retry.DefaultRetry, func() error { statusToUpdate, err = dClient.Get(context.TODO(), dName, metav1.GetOptions{}) framework.ExpectNoError(err, \"Unable to retrieve deployment %s\", dName) statusToUpdate.Status.Conditions = append(statusToUpdate.Status.Conditions, appsv1.DeploymentCondition{ Type:    \"StatusUpdate\", Status:  \"True\", Reason:  \"E2E\", Message: \"Set from e2e test\", }) updatedStatus, err = dClient.UpdateStatus(context.TODO(), statusToUpdate, metav1.UpdateOptions{}) return err }) framework.ExpectNoError(err, \"Failed to update status. %v\", err) framework.Logf(\"updatedStatus.Conditions: %#v\", updatedStatus.Status.Conditions) ginkgo.By(\"watching for the Deployment status to be updated\") ctx, cancel := context.WithTimeout(context.Background(), dRetryTimeout) defer cancel() _, err = watchtools.Until(ctx, dList.ResourceVersion, w, func(event watch.Event) (bool, error) { if d, ok := event.Object.(*appsv1.Deployment); ok { found := d.ObjectMeta.Name == testDeployment.ObjectMeta.Name && d.ObjectMeta.Namespace == testDeployment.ObjectMeta.Namespace && d.Labels[\"e2e\"] == \"testing\" if !found { framework.Logf(\"Observed Deployment %v in namespace %v with annotations: %v & Conditions: %vn\", d.ObjectMeta.Name, d.ObjectMeta.Namespace, d.Annotations, d.Status.Conditions) return false, nil } for _, cond := range d.Status.Conditions { if cond.Type == \"StatusUpdate\" && cond.Reason == \"E2E\" && cond.Message == \"Set from e2e test\" { framework.Logf(\"Found Deployment %v in namespace %v with labels: %v annotations: %v & Conditions: %v\", d.ObjectMeta.Name, d.ObjectMeta.Namespace, d.ObjectMeta.Labels, d.Annotations, cond) return found, nil } framework.Logf(\"Observed Deployment %v in namespace %v with annotations: %v & Conditions: %v\", d.ObjectMeta.Name, d.ObjectMeta.Namespace, d.Annotations, cond) } } object := strings.Split(fmt.Sprintf(\"%v\", event.Object), \"{\")[0] framework.Logf(\"Observed %v event: %+v\", object, event.Type) return false, nil }) framework.ExpectNoError(err, \"failed to locate Deployment %v in namespace %v\", testDeployment.ObjectMeta.Name, ns) framework.Logf(\"Deployment %s has an updated status\", dName) ginkgo.By(\"patching the Statefulset Status\") payload := []byte(`{\"status\":{\"conditions\":[{\"type\":\"StatusPatched\",\"status\":\"True\"}]}}`) framework.Logf(\"Patch payload: %v\", string(payload)) patchedDeployment, err := dClient.Patch(context.TODO(), dName, types.MergePatchType, payload, metav1.PatchOptions{}, \"status\") framework.ExpectNoError(err, \"Failed to patch status. %v\", err) framework.Logf(\"Patched status conditions: %#v\", patchedDeployment.Status.Conditions) ginkgo.By(\"watching for the Deployment status to be patched\") ctx, cancel = context.WithTimeout(context.Background(), dRetryTimeout) defer cancel() _, err = watchtools.Until(ctx, dList.ResourceVersion, w, func(event watch.Event) (bool, error) { if e, ok := event.Object.(*appsv1.Deployment); ok { found := e.ObjectMeta.Name == testDeployment.ObjectMeta.Name && e.ObjectMeta.Namespace == testDeployment.ObjectMeta.Namespace && e.ObjectMeta.Labels[\"e2e\"] == testDeployment.ObjectMeta.Labels[\"e2e\"] if !found { framework.Logf(\"Observed deployment %v in namespace %v with annotations: %v & Conditions: %v\", testDeployment.ObjectMeta.Name, testDeployment.ObjectMeta.Namespace, testDeployment.Annotations, testDeployment.Status.Conditions) return false, nil } for _, cond := range e.Status.Conditions { if cond.Type == \"StatusPatched\" { framework.Logf(\"Found deployment %v in namespace %v with labels: %v annotations: %v & Conditions: %v\", testDeployment.ObjectMeta.Name, testDeployment.ObjectMeta.Namespace, testDeployment.ObjectMeta.Labels, testDeployment.Annotations, cond) return found, nil } framework.Logf(\"Observed deployment %v in namespace %v with annotations: %v & Conditions: %v\", testDeployment.ObjectMeta.Name, testDeployment.ObjectMeta.Namespace, testDeployment.Annotations, cond) } } object := strings.Split(fmt.Sprintf(\"%v\", event.Object), \"{\")[0] framework.Logf(\"Observed %v event: %+v\", object, event.Type) return false, nil }) framework.ExpectNoError(err, \"failed to locate deployment %v in namespace %v\", testDeployment.ObjectMeta.Name, ns) framework.Logf(\"Deployment %s has a patched status\", dName) }) </ins> }) func failureTrap(c clientset.Interface, ns string) {", "commid": "kubernetes_pr_102260"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b39b114e3f8b25c65861c9c397d758891e478151ec492017dfbfbc72cee16e3", "query": "[X] Test PR: kuberenetes/kubernetes [x] Two weeks soak end date: 1 July 2021 [x] Test promotion PR: kubernetes/kubernetes According to this APIsnoop query, there are still some remaining StatefulSet endpoints which are untested. Create a watch to track deployment events. Create a deployment with a static label. Confirm that the pods are running. Get the deployment status. Parse the response and confirm that the deployment status conditions can be listed. Update the deployment status. Confirm via the watch that the status has been updated. Patch the deployment status. Confirm via the watch that the status has been patched. Using an existing as a template for a new for deployment lifecycle test. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 1 point This test is also created with the goal of conformance promotion. /sig apps /sig testing /sig architecture /area conformance\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-2b9a330e6d97f060759ca9ef35bc932e46b14df554d862047c444904f4742be9", "text": "MUST succeed. It MUST succeed when deleting the Deployment. release: v1.20 file: test/e2e/apps/deployment.go <ins> - testname: Deployment, status sub-resource codename: '[sig-apps] Deployment should validate Deployment Status endpoints [Conformance]' description: When a Deployment is created it MUST succeed. Attempt to read, update and patch its status sub-resource; all mutating sub-resource operations MUST be visible to subsequent reads. release: v1.22 file: test/e2e/apps/deployment.go </ins> - testname: 'PodDisruptionBudget: list and delete collection' codename: '[sig-apps] DisruptionController Listing PodDisruptionBudgets for all namespaces should list and delete a collection of PodDisruptionBudgets [Conformance]'", "commid": "kubernetes_pr_103242"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7b39b114e3f8b25c65861c9c397d758891e478151ec492017dfbfbc72cee16e3", "query": "[X] Test PR: kuberenetes/kubernetes [x] Two weeks soak end date: 1 July 2021 [x] Test promotion PR: kubernetes/kubernetes According to this APIsnoop query, there are still some remaining StatefulSet endpoints which are untested. Create a watch to track deployment events. Create a deployment with a static label. Confirm that the pods are running. Get the deployment status. Parse the response and confirm that the deployment status conditions can be listed. Update the deployment status. Confirm via the watch that the status has been updated. Patch the deployment status. Confirm via the watch that the status has been patched. Using an existing as a template for a new for deployment lifecycle test. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 1 point This test is also created with the goal of conformance promotion. /sig apps /sig testing /sig architecture /area conformance\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-e0acbf75126c8fe7a209e94517af48d42cc612a77a438f777b330aae41bd4685", "text": "framework.ExpectNoError(err, \"failed to see %v event\", watch.Deleted) }) <del> ginkgo.It(\"should validate Deployment Status endpoints\", func() { </del> <ins> /* Release: v1.22 Testname: Deployment, status sub-resource Description: When a Deployment is created it MUST succeed. Attempt to read, update and patch its status sub-resource; all mutating sub-resource operations MUST be visible to subsequent reads. */ framework.ConformanceIt(\"should validate Deployment Status endpoints\", func() { </ins> dClient := c.AppsV1().Deployments(ns) dName := \"test-deployment-\" + utilrand.String(5) labelSelector := \"e2e=testing\"", "commid": "kubernetes_pr_103242"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0bd6fcf7065619d9a1d0932d28d8889dbc56a60ae38b5c44380960e04fbf80d7", "query": "As part of the Kubernetes upgrade workflow we have in place, we are upgrading kubernetes from 1.15.3 -1.18.15 (both versions and all versions in the middle are custom patched for different behavior of the and . None of them having anything to do with kube-proxy's IPVS), and as part of this upgrade we are also migrating the from to mode. We have calico 3.12 running on the cluster as part of the CNI stack. Once the pods are migrated from to mode by applying the new DaemonSet manifest, the cluster has a series of stale rules for chain left around that breaks the runtime state of the pods. have cluster running in HA mode (3 Node cluster) where all nodes of the cluster are running as leaders and take the workload as well. There is no non-leader Pods. have customized the kubernetes and calico infra to enable the usage of Link local IP address in range for internal usecases Most of the IPs and the names have been mangled. Stale IP table rules to be cleaned up once the pods and endpoints are stable with all endpoints in Ready address mode. down the pods on a given namespace to 0 (leave the service and Endpoints around) the control plane to 1.18.15 (take the intermediate hop path. 1.15.3 -1.16.7 -1.17.5 -1.18.15) apply the kube-proxy manifest provided above. up the pods scaled down in Step 1. Current workaround we have been putting it use the as an init container and run the and then bring up the in IPVS mode and that seem to take care of the stale entries (but this seem to be too much of a big hammer approach of cleaning up) Kubernetes version (use ):Cloud provider or hardware configuration:OS (e.g: ):Kernel (e.g. ):Install tools: kubeadmNetwork plugin and version (if this is a network-related bug):Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe label(s) cannot be applied. These labels are supported: <detailsIn response to : /label area/kube-proxy Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig sig/network Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network\nI don't think that the live migration between kube-proxy implementations iptables<-ipvs is supported, at least I never heard about that and seems tricky. you use to have all the historical context, what do you think?\nWe tried implementing a cleanup mode but it was problematic and removed. (see ) You can run but that's pretty coarse. Maybe we should add a value to that flag to say which mode to try to cleanup? PRs welcome. The simplest answer is to reboot.\nLet's make this a docs issues - we should write this down\ncan we merge the above so that we can close this issue?\nnot just yet :-) wouldn't signal registration and calling clean-up would at least clean things up on graceful shutdown? Granted rules will not be there until kube-proxy is restarted.", "positive_passages": [{"docid": "doc-en-kubernetes-e965739a4b55eb8369cbc467a48d71459625d07f9f91de200b96fa0cede4a923", "text": "clone, err := conversion.NewCloner().DeepCopy(&volume) if err != nil { glog.Errorf(\"error cloning volume %q: %v\", volume.Name, err) <ins> continue </ins> } volumeClone := clone.(*api.PersistentVolume) ctrl.storeVolumeUpdate(volumeClone)", "commid": "kubernetes_pr_28147"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0bd6fcf7065619d9a1d0932d28d8889dbc56a60ae38b5c44380960e04fbf80d7", "query": "As part of the Kubernetes upgrade workflow we have in place, we are upgrading kubernetes from 1.15.3 -1.18.15 (both versions and all versions in the middle are custom patched for different behavior of the and . None of them having anything to do with kube-proxy's IPVS), and as part of this upgrade we are also migrating the from to mode. We have calico 3.12 running on the cluster as part of the CNI stack. Once the pods are migrated from to mode by applying the new DaemonSet manifest, the cluster has a series of stale rules for chain left around that breaks the runtime state of the pods. have cluster running in HA mode (3 Node cluster) where all nodes of the cluster are running as leaders and take the workload as well. There is no non-leader Pods. have customized the kubernetes and calico infra to enable the usage of Link local IP address in range for internal usecases Most of the IPs and the names have been mangled. Stale IP table rules to be cleaned up once the pods and endpoints are stable with all endpoints in Ready address mode. down the pods on a given namespace to 0 (leave the service and Endpoints around) the control plane to 1.18.15 (take the intermediate hop path. 1.15.3 -1.16.7 -1.17.5 -1.18.15) apply the kube-proxy manifest provided above. up the pods scaled down in Step 1. Current workaround we have been putting it use the as an init container and run the and then bring up the in IPVS mode and that seem to take care of the stale entries (but this seem to be too much of a big hammer approach of cleaning up) Kubernetes version (use ):Cloud provider or hardware configuration:OS (e.g: ):Kernel (e.g. ):Install tools: kubeadmNetwork plugin and version (if this is a network-related bug):Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe label(s) cannot be applied. These labels are supported: <detailsIn response to : /label area/kube-proxy Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig sig/network Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network\nI don't think that the live migration between kube-proxy implementations iptables<-ipvs is supported, at least I never heard about that and seems tricky. you use to have all the historical context, what do you think?\nWe tried implementing a cleanup mode but it was problematic and removed. (see ) You can run but that's pretty coarse. Maybe we should add a value to that flag to say which mode to try to cleanup? PRs welcome. The simplest answer is to reboot.\nLet's make this a docs issues - we should write this down\ncan we merge the above so that we can close this issue?\nnot just yet :-) wouldn't signal registration and calling clean-up would at least clean things up on graceful shutdown? Granted rules will not be there until kube-proxy is restarted.", "positive_passages": [{"docid": "doc-en-kubernetes-10cc9b1c024ec30ea1038527a77ae1068856a552c922528301fff079d93a9e7f", "text": "clone, err := conversion.NewCloner().DeepCopy(&claim) if err != nil { glog.Errorf(\"error cloning claim %q: %v\", claimToClaimKey(&claim), err) <ins> continue </ins> } claimClone := clone.(*api.PersistentVolumeClaim) ctrl.storeClaimUpdate(claimClone)", "commid": "kubernetes_pr_28147"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8aeed6724c27cddf2cc70c9bec327ee20c01cdda59dcd5cd082a6d29e4dc5236", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --kubelet panics on creation of inline ephemeral volume with FSType specified. creation of inline ephemeral volume succeeds with FSType specified. no existing isolated test case. Happens during e2e testing of pmem-csi. Kubernetes version (use ): The pmem-csi CI system where this was detected, runs same tests on k8s systems with 1.19 and 1.20. The problem occurs in testing on 1.20 system, problem does not occur on 1.19 system.Cloud provider or hardware configuration: pmem-csi tests run on cluster formed by few qemu-based systems running Fedora-33 and emulated pmem storage. The issue has been seen in e2e testing in , where a new test was recently introduced that creates a pod with an inline ephemeral volume. If the related VolumeSource has filesystem type set to empty \"\", or FSType is omitted in spec, then the pod creation works OK. In that case, pmem-csi chooses it's default fstype which is . Example of working definition of VolumeSource: If the filesystem type in the VolumeSource is set to or then kubelet fails to create the volume and pod. A panic trace is written in the node kubelet log and the creation will be retried few times, On pmem-csi side: the 1st NodePublishVolume is received, namespace and volume are created, formatted with mkfs, mounted and NodePublishVolume returns OK. Same request is received few times with increasing time interval. e2e testing code which tries to create the pod, will fail with:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/sig node storage\n... and ownership changed for those volumes.", "positive_passages": [{"docid": "doc-en-kubernetes-8eb968bc2eb4fc2433b98a4bcd77777af220397915898b58c4d54b54f530c281", "text": "return false } <del> accessModes := c.spec.PersistentVolume.Spec.AccessModes </del> <ins> if c.spec.PersistentVolume == nil { klog.V(4).Info(log(\"mounter.SetupAt Warning: skipping fsGroup permission change, no access mode available. The volume may only be accessible to root users.\")) return false } </ins> if c.spec.PersistentVolume.Spec.AccessModes == nil { klog.V(4).Info(log(\"mounter.SetupAt WARNING: skipping fsGroup, access modes not provided\")) return false } <del> if !hasReadWriteOnce(accessModes) { </del> <ins> if !hasReadWriteOnce(c.spec.PersistentVolume.Spec.AccessModes) { </ins> klog.V(4).Info(log(\"mounter.SetupAt WARNING: skipping fsGroup, only support ReadWriteOnce access mode\")) return false }", "commid": "kubernetes_pr_102653"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8aeed6724c27cddf2cc70c9bec327ee20c01cdda59dcd5cd082a6d29e4dc5236", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --kubelet panics on creation of inline ephemeral volume with FSType specified. creation of inline ephemeral volume succeeds with FSType specified. no existing isolated test case. Happens during e2e testing of pmem-csi. Kubernetes version (use ): The pmem-csi CI system where this was detected, runs same tests on k8s systems with 1.19 and 1.20. The problem occurs in testing on 1.20 system, problem does not occur on 1.19 system.Cloud provider or hardware configuration: pmem-csi tests run on cluster formed by few qemu-based systems running Fedora-33 and emulated pmem storage. The issue has been seen in e2e testing in , where a new test was recently introduced that creates a pod with an inline ephemeral volume. If the related VolumeSource has filesystem type set to empty \"\", or FSType is omitted in spec, then the pod creation works OK. In that case, pmem-csi chooses it's default fstype which is . Example of working definition of VolumeSource: If the filesystem type in the VolumeSource is set to or then kubelet fails to create the volume and pod. A panic trace is written in the node kubelet log and the creation will be retried few times, On pmem-csi side: the 1st NodePublishVolume is received, namespace and volume are created, formatted with mkfs, mounted and NodePublishVolume returns OK. Same request is received few times with increasing time interval. e2e testing code which tries to create the pod, will fail with:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/sig node storage\n... and ownership changed for those volumes.", "positive_passages": [{"docid": "doc-en-kubernetes-73590c036f7bed6f6de900e77059a75cd2748c82cbf1a419c21247fcaf3c0270", "text": "authenticationv1 \"k8s.io/api/authentication/v1\" api \"k8s.io/api/core/v1\" <ins> corev1 \"k8s.io/api/core/v1\" </ins> storage \"k8s.io/api/storage/v1\" meta \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/runtime\"", "commid": "kubernetes_pr_102653"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8aeed6724c27cddf2cc70c9bec327ee20c01cdda59dcd5cd082a6d29e4dc5236", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --kubelet panics on creation of inline ephemeral volume with FSType specified. creation of inline ephemeral volume succeeds with FSType specified. no existing isolated test case. Happens during e2e testing of pmem-csi. Kubernetes version (use ): The pmem-csi CI system where this was detected, runs same tests on k8s systems with 1.19 and 1.20. The problem occurs in testing on 1.20 system, problem does not occur on 1.19 system.Cloud provider or hardware configuration: pmem-csi tests run on cluster formed by few qemu-based systems running Fedora-33 and emulated pmem storage. The issue has been seen in e2e testing in , where a new test was recently introduced that creates a pod with an inline ephemeral volume. If the related VolumeSource has filesystem type set to empty \"\", or FSType is omitted in spec, then the pod creation works OK. In that case, pmem-csi chooses it's default fstype which is . Example of working definition of VolumeSource: If the filesystem type in the VolumeSource is set to or then kubelet fails to create the volume and pod. A panic trace is written in the node kubelet log and the creation will be retried few times, On pmem-csi side: the 1st NodePublishVolume is received, namespace and volume are created, formatted with mkfs, mounted and NodePublishVolume returns OK. Same request is received few times with increasing time interval. e2e testing code which tries to create the pod, will fail with:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/sig node storage\n... and ownership changed for those volumes.", "positive_passages": [{"docid": "doc-en-kubernetes-cdbbc23993cbc75638d1152dc1130164abe20ec5b400a4d54b955aa91df45408", "text": "}) } } <ins> func Test_csiMountMgr_supportsFSGroup(t *testing.T) { type fields struct { plugin              *csiPlugin driverName          csiDriverName volumeLifecycleMode storage.VolumeLifecycleMode fsGroupPolicy       storage.FSGroupPolicy volumeID            string specVolumeID        string readOnly            bool supportsSELinux     bool spec                *volume.Spec pod                 *api.Pod podUID              types.UID publishContext      map[string]string kubeVolHost         volume.KubeletVolumeHost MetricsProvider     volume.MetricsProvider } type args struct { fsType       string fsGroup      *int64 driverPolicy storage.FSGroupPolicy } tests := []struct { name   string fields fields args   args want   bool }{ { name: \"empty all\", args: args{}, want: false, }, { name: \"driverPolicy is FileFSGroupPolicy\", args: args{ fsGroup:      new(int64), driverPolicy: storage.FileFSGroupPolicy, }, want: true, }, { name: \"driverPolicy is ReadWriteOnceWithFSTypeFSGroupPolicy\", args: args{ fsGroup:      new(int64), driverPolicy: storage.ReadWriteOnceWithFSTypeFSGroupPolicy, }, want: false, }, { name: \"driverPolicy is ReadWriteOnceWithFSTypeFSGroupPolicy with empty Spec\", args: args{ fsGroup:      new(int64), fsType:       \"ext4\", driverPolicy: storage.ReadWriteOnceWithFSTypeFSGroupPolicy, }, fields: fields{ spec: &volume.Spec{}, }, want: false, }, { name: \"driverPolicy is ReadWriteOnceWithFSTypeFSGroupPolicy with empty PersistentVolume\", args: args{ fsGroup:      new(int64), fsType:       \"ext4\", driverPolicy: storage.ReadWriteOnceWithFSTypeFSGroupPolicy, }, fields: fields{ spec: volume.NewSpecFromPersistentVolume(&corev1.PersistentVolume{}, true), }, want: false, }, { name: \"driverPolicy is ReadWriteOnceWithFSTypeFSGroupPolicy with empty AccessModes\", args: args{ fsGroup:      new(int64), fsType:       \"ext4\", driverPolicy: storage.ReadWriteOnceWithFSTypeFSGroupPolicy, }, fields: fields{ spec: volume.NewSpecFromPersistentVolume(&api.PersistentVolume{ Spec: api.PersistentVolumeSpec{ AccessModes: []api.PersistentVolumeAccessMode{}, }, }, true), }, want: false, }, { name: \"driverPolicy is ReadWriteOnceWithFSTypeFSGroupPolicy with ReadWriteOnce AccessModes\", args: args{ fsGroup:      new(int64), fsType:       \"ext4\", driverPolicy: storage.ReadWriteOnceWithFSTypeFSGroupPolicy, }, fields: fields{ spec: volume.NewSpecFromPersistentVolume(&api.PersistentVolume{ Spec: api.PersistentVolumeSpec{ AccessModes: []api.PersistentVolumeAccessMode{api.ReadWriteOnce}, }, }, true), }, want: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { c := &csiMountMgr{ plugin:              tt.fields.plugin, driverName:          tt.fields.driverName, volumeLifecycleMode: tt.fields.volumeLifecycleMode, fsGroupPolicy:       tt.fields.fsGroupPolicy, volumeID:            tt.fields.volumeID, specVolumeID:        tt.fields.specVolumeID, readOnly:            tt.fields.readOnly, supportsSELinux:     tt.fields.supportsSELinux, spec:                tt.fields.spec, pod:                 tt.fields.pod, podUID:              tt.fields.podUID, publishContext:      tt.fields.publishContext, kubeVolHost:         tt.fields.kubeVolHost, MetricsProvider:     tt.fields.MetricsProvider, } if got := c.supportsFSGroup(tt.args.fsType, tt.args.fsGroup, tt.args.driverPolicy); got != tt.want { t.Errorf(\"supportsFSGroup() = %v, want %v\", got, tt.want) } }) } } </ins>", "commid": "kubernetes_pr_102653"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64e2dd7a9a7961a18efa8850e8dfe40f31f4c0585f7d06bddc3f08c803cd6a78", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --When I ran , it failed with the following error: I expected the build to successfully complete, or to be warned that I am missing a required build dependency. If you don't have docker buildx installed, you will hit this error. However, that error is masked when you pass the full command line: Appears to have been introduced in Kubernetes version (use ): HEAD (1.22.x) Cloud provider or hardware configuration: N/A, local build OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release\nThat's not the same as in the script, which should be setting which ungates this command. (we depended on this env for much longer in the project to use ) Stable docker versions should have buildx, at least behind this env. unfortunately the project has never validated a minimum docker version for building.\nbuildx as a build requirement was actually introduced at least as back as 1.21 as well, for some of the core images. we've just standardized on it more since then (including the linked commit), so if we do add some validation we should probably backport it. I think docker buildx has been available since 19.03?, but it appears your install is too old to have the flag in buildx. we could also try switching to , I'm not sure which version introduced .\nNo difference with the flag. But I am not running upstream Docker, I'm running Docker out of the Debian repos.\ndiscussed on slack: seems debian packages don't have the buildx plugin , while docker-ce / docker desktop do. we should at least be checking for the command and throwing a clear error like we do with e.g. tar.\nFiled to discuss the expectation users might have re: the docker PPAs vs the Debian repos and buildx availability.\n/\nalso\nNote: reverting fixes the issue, so I have been building locally with that as a carry patch as a workaround.\ncc apparently there are docker packages that don't ship this, which maybe changes the equations a bit, see above.\n/assign\ntl;dr from isn't actually part of moby, but Docker Inc. ships it as part of their Docker packages in their PPA. It's a separate tool with a separate code repo.\nwould it be eligible for another package? otherwise we probably need to provide support for installing it at least to some extent, e.g. if you are on mac with ancient bash we point to installing with homebrew in the failure message that detects this (and we should also be detecting that the command is missing).\nYou can build it from source and install it as a docker plugin by following the instructions at I doubt it'll be part of any of the FOSS distro repos soon (although I'm happy to be proven wrong on that).\nwe don't have the yard stick that something we use should be part of FOSS distro repos. Just that it needs to be easily installable.\nSeems like you can also use the release artifacts from github as well, you don't need their ppa and you won't need to build it either.\nHere is an image I created to solve not having buildx in the official image\n/assign\nhas been updated to use the official binary buildx image\nAL2 also does not come with buildx built in and I landed in with the same issue.", "positive_passages": [{"docid": "doc-en-kubernetes-a130c4451efc22860f77d6fed2fb09a17f3941d7f12873811c69aa917b50885f", "text": "# $3 is the value to set the --pull flag for docker build; true by default # $4 is the set of --build-args for docker. function kube::build::docker_build() { <ins> kube::util::ensure-docker-buildx </ins> local -r image=$1 local -r context_dir=$2 local -r pull=\"${3:-true}\"", "commid": "kubernetes_pr_104749"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bb9d05ab47b1643a3c91e70feca768ba7aea05c3a73104d8523869b02a612c9e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --pod with nodeSeletor edit pod, delete the nodeSeletor field report error with: ! The errors message should displayed as: Because the nodeSeletor is been deleted with this edit. Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig api Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\n/remove-sig api-machinery /sig apps\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle stale\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-8c04645bf76954eee9faf9a0f01806b4af0aef3d6e865f770d86333fdcec9cb5", "text": "\"unicode\" \"unicode/utf8\" <ins> \"github.com/google/go-cmp/cmp\" </ins> v1 \"k8s.io/api/core/v1\" apiequality \"k8s.io/apimachinery/pkg/api/equality\" \"k8s.io/apimachinery/pkg/api/resource\"", "commid": "kubernetes_pr_103036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bb9d05ab47b1643a3c91e70feca768ba7aea05c3a73104d8523869b02a612c9e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --pod with nodeSeletor edit pod, delete the nodeSeletor field report error with: ! The errors message should displayed as: Because the nodeSeletor is been deleted with this edit. Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig api Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\n/remove-sig api-machinery /sig apps\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle stale\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-cb83af9e4af546e7f98b6cbe863b22e1c9399f87e2082d91c5e69d9040db3354", "text": "metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" unversionedvalidation \"k8s.io/apimachinery/pkg/apis/meta/v1/validation\" \"k8s.io/apimachinery/pkg/labels\" <del> \"k8s.io/apimachinery/pkg/util/diff\" </del> \"k8s.io/apimachinery/pkg/util/intstr\" \"k8s.io/apimachinery/pkg/util/sets\" \"k8s.io/apimachinery/pkg/util/validation\"", "commid": "kubernetes_pr_103036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bb9d05ab47b1643a3c91e70feca768ba7aea05c3a73104d8523869b02a612c9e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --pod with nodeSeletor edit pod, delete the nodeSeletor field report error with: ! The errors message should displayed as: Because the nodeSeletor is been deleted with this edit. Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig api Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\n/remove-sig api-machinery /sig apps\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle stale\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-5f6f87669f90474adcaf27e5bea8ade0cc6f2d2a071b85cc8fdbb25ac97c55d3", "text": "// PersistentVolumeSource should be immutable after creation. if !apiequality.Semantic.DeepEqual(newPv.Spec.PersistentVolumeSource, oldPv.Spec.PersistentVolumeSource) { <del> pvcSourceDiff := diff.ObjectDiff(newPv.Spec.PersistentVolumeSource, oldPv.Spec.PersistentVolumeSource) </del> <ins> pvcSourceDiff := cmp.Diff(oldPv.Spec.PersistentVolumeSource, newPv.Spec.PersistentVolumeSource) </ins> allErrs = append(allErrs, field.Forbidden(field.NewPath(\"spec\", \"persistentvolumesource\"), fmt.Sprintf(\"spec.persistentvolumesource is immutable after creationn%v\", pvcSourceDiff))) } allErrs = append(allErrs, ValidateImmutableField(newPv.Spec.VolumeMode, oldPv.Spec.VolumeMode, field.NewPath(\"volumeMode\"))...)", "commid": "kubernetes_pr_103036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bb9d05ab47b1643a3c91e70feca768ba7aea05c3a73104d8523869b02a612c9e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --pod with nodeSeletor edit pod, delete the nodeSeletor field report error with: ! The errors message should displayed as: Because the nodeSeletor is been deleted with this edit. Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig api Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\n/remove-sig api-machinery /sig apps\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle stale\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-fb303da8d5207fe61aa66b8f7fd3e5e9609eb3b7fcfc82070bc24d50e23c86c7", "text": "statusSize := oldPvc.Status.Capacity[\"storage\"] if !apiequality.Semantic.DeepEqual(newPvcClone.Spec, oldPvcClone.Spec) { <del> specDiff := diff.ObjectDiff(newPvcClone.Spec, oldPvcClone.Spec) </del> <ins> specDiff := cmp.Diff(oldPvcClone.Spec, newPvcClone.Spec) </ins> allErrs = append(allErrs, field.Forbidden(field.NewPath(\"spec\"), fmt.Sprintf(\"spec is immutable after creation except resources.requests for bound claimsn%v\", specDiff))) } if newSize.Cmp(oldSize) < 0 {", "commid": "kubernetes_pr_103036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bb9d05ab47b1643a3c91e70feca768ba7aea05c3a73104d8523869b02a612c9e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --pod with nodeSeletor edit pod, delete the nodeSeletor field report error with: ! The errors message should displayed as: Because the nodeSeletor is been deleted with this edit. Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig api Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\n/remove-sig api-machinery /sig apps\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle stale\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-8cf87f99ac4fb28410a2f88fd44c8d77641ecab5c8958e5cfb0078e01d0d7bba", "text": "// changes to Spec are not allowed, but updates to label/and some annotations are OK. // no-op updates pass validation. if !apiequality.Semantic.DeepEqual(newPvcClone.Spec, oldPvcClone.Spec) { <del> specDiff := diff.ObjectDiff(newPvcClone.Spec, oldPvcClone.Spec) </del> <ins> specDiff := cmp.Diff(oldPvcClone.Spec, newPvcClone.Spec) </ins> allErrs = append(allErrs, field.Forbidden(field.NewPath(\"spec\"), fmt.Sprintf(\"field is immutable after creationn%v\", specDiff))) } }", "commid": "kubernetes_pr_103036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bb9d05ab47b1643a3c91e70feca768ba7aea05c3a73104d8523869b02a612c9e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --pod with nodeSeletor edit pod, delete the nodeSeletor field report error with: ! The errors message should displayed as: Because the nodeSeletor is been deleted with this edit. Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig api Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\n/remove-sig api-machinery /sig apps\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle stale\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-251a208186162a5097a64379248adc3a1c540909d88b02529ccc5dde068abc01", "text": "if !apiequality.Semantic.DeepEqual(mungedPodSpec, oldPod.Spec) { // This diff isn't perfect, but it's a helluva lot better an \"I'm not going to tell you what the difference is\". //TODO: Pinpoint the specific field that causes the invalid error after we have strategic merge diff <del> specDiff := diff.ObjectDiff(mungedPodSpec, oldPod.Spec) </del> <ins> specDiff := cmp.Diff(oldPod.Spec, mungedPodSpec) </ins> allErrs = append(allErrs, field.Forbidden(specPath, fmt.Sprintf(\"pod updates may not change fields other than `spec.containers[*].image`, `spec.initContainers[*].image`, `spec.activeDeadlineSeconds`, `spec.tolerations` (only additions to existing tolerations) or `spec.terminationGracePeriodSeconds` (allow it to be set to 1 if it was previously negative)n%v\", specDiff))) }", "commid": "kubernetes_pr_103036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bb9d05ab47b1643a3c91e70feca768ba7aea05c3a73104d8523869b02a612c9e", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --pod with nodeSeletor edit pod, delete the nodeSeletor field report error with: ! The errors message should displayed as: Because the nodeSeletor is been deleted with this edit. Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig api Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\n/remove-sig api-machinery /sig apps\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle stale\n/remove-lifecycle rotten", "positive_passages": [{"docid": "doc-en-kubernetes-768c950437c5064b5e3262e1c28f96185ffe9e454c00f71d948c5a7b65fe891e", "text": "if new, ok := newContainerIndex[old.Name]; !ok { allErrs = append(allErrs, field.Forbidden(specPath, fmt.Sprintf(\"existing ephemeral containers %q may not be removedn\", old.Name))) } else if !apiequality.Semantic.DeepEqual(old, *new) { <del> specDiff := diff.ObjectDiff(old, *new) </del> <ins> specDiff := cmp.Diff(old, *new) </ins> allErrs = append(allErrs, field.Forbidden(specPath, fmt.Sprintf(\"existing ephemeral containers %q may not be changedn%v\", old.Name, specDiff))) } }", "commid": "kubernetes_pr_103036"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-47e3fff376584abbbc5a14b242e4a53be291e4510620d46d1cf2cd7fab556e9c", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/sig node /cc\nThe failure should be caused by\n/assign\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-a987065e93b534e9c4ad7bd42a418a6aca2e707e211efcaf284019e03b96d0b5", "text": "import ( \"context\" \"fmt\" <ins> \"os\" \"path/filepath\" </ins> \"strconv\" \"time\"", "commid": "kubernetes_pr_103076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-47e3fff376584abbbc5a14b242e4a53be291e4510620d46d1cf2cd7fab556e9c", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/sig node /cc\nThe failure should be caused by\n/assign\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-b8270999648a8dd45b2c967f68127229dab4d8ce74e53d8209302813a86165b9", "text": "}) ginkgo.It(\"after restart dbus, should be able to gracefully shutdown\", func() { <ins> // allows manual restart of dbus to work in Ubuntu. err := overlayDbusConfig() framework.ExpectNoError(err) defer func() { err := restoreDbusConfig() framework.ExpectNoError(err) }() </ins> ginkgo.By(\"Restart Dbus\") <del> err := restartDbus() </del> <ins> err = restartDbus() </ins> framework.ExpectNoError(err) ginkgo.By(\"Emitting Shutdown signal\")", "commid": "kubernetes_pr_103076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-47e3fff376584abbbc5a14b242e4a53be291e4510620d46d1cf2cd7fab556e9c", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/sig node /cc\nThe failure should be caused by\n/assign\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-76757c12c65de09f195f9aa0bd146216861820419b65b95da4c7735e2b7a2b58", "text": "_, err := runCommand(\"sh\", \"-c\", cmd) return err } <ins> func systemctlDaemonReload() error { cmd := \"systemctl daemon-reload\" _, err := runCommand(\"sh\", \"-c\", cmd) return err } var ( dbusConfPath = \"/etc/systemd/system/dbus.service.d/k8s-graceful-node-shutdown-e2e.conf\" dbusConf     = ` [Unit] RefuseManualStart=no RefuseManualStop=no [Service] KillMode=control-group ExecStop= ` ) func overlayDbusConfig() error { err := os.MkdirAll(filepath.Dir(dbusConf), 0755) if err != nil { return err } err = os.WriteFile(dbusConfPath, []byte(dbusConf), 0644) if err != nil { return err } return systemctlDaemonReload() } func restoreDbusConfig() error { err := os.Remove(dbusConf) if err != nil { return err } return systemctlDaemonReload() } </ins>", "commid": "kubernetes_pr_103076"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d927c7177ed39805b33b660a9c2d4d7bf5946fae73d5160a4555c76e83f9522e", "query": "I am getting a crash when trying to sort pod with kubectl on Not crashing and at least an error message <details<summaryCrash log</summary</details- Kubernetes version (use ): Cloud provider or hardware configuration: tried on kind latest and openshift 4.7 OS (e.g: ): debian sid Kernel (e.g. ): 5.11.x Install tools: NA Network plugin and version (if this is a network-related bug): NA Others: kubectl compiled from tip branch (as of this bug report) with GO version 1.16.5\n/sig cli\nHey I'm not able to reproduce the crash, although I do get an error on running However, the following works: Could you try this and check if this crashes as well?\nIt definitively crashes it, did you test it in a repo where there is actual pod in there? that error would not show if there is nothing.\nYep Hmm, interesting. Will try to reproduce it again\nSorry, not sure how to remove the label but this is expected. When sorting if the type is not expected it will output errors using over which will logs to the FATAL, ERROR, WARNING, and INFO logs, including a stack trace of all running goroutines, then calls os.Exit(255). Arguments are handled in the manner of fmt.Printf; a newline is appended if missing.\nThose labels are not set on the issue: <detailsIn response to : /remove-kind bug Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nYou need to have multiple pods to reproduce this error. It won't happen with just one pod. For example: The error says the type can't be sorted, so that is the problem: As said, this error is generated intentionally. Here is the code: The problem stems from the fact that  has no way to return an error, so it logs a fatal error which os.Exits. It seems like the problem is that the error message is too verbose. One solution could be to change the code to only print the error message and exit, instead of using which is what is outputting the stack trace. It probably doesn't make sense to dump a stack trace for something that is a user error.", "positive_passages": [{"docid": "doc-en-kubernetes-2913ab4002d365a53991e9ff9c02a2da56464182c138c3a113572c12133bee77", "text": "less, err := isLess(iField, jField) if err != nil { <del> klog.Fatalf(\"Field %s in %T is an unsortable type: %s, err: %v\", r.field, iObj, iField.Kind().String(), err) </del> <ins> klog.Exitf(\"Field %s in %T is an unsortable type: %s, err: %v\", r.field, iObj, iField.Kind().String(), err) </ins> } return less }", "commid": "kubernetes_pr_103458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d927c7177ed39805b33b660a9c2d4d7bf5946fae73d5160a4555c76e83f9522e", "query": "I am getting a crash when trying to sort pod with kubectl on Not crashing and at least an error message <details<summaryCrash log</summary</details- Kubernetes version (use ): Cloud provider or hardware configuration: tried on kind latest and openshift 4.7 OS (e.g: ): debian sid Kernel (e.g. ): 5.11.x Install tools: NA Network plugin and version (if this is a network-related bug): NA Others: kubectl compiled from tip branch (as of this bug report) with GO version 1.16.5\n/sig cli\nHey I'm not able to reproduce the crash, although I do get an error on running However, the following works: Could you try this and check if this crashes as well?\nIt definitively crashes it, did you test it in a repo where there is actual pod in there? that error would not show if there is nothing.\nYep Hmm, interesting. Will try to reproduce it again\nSorry, not sure how to remove the label but this is expected. When sorting if the type is not expected it will output errors using over which will logs to the FATAL, ERROR, WARNING, and INFO logs, including a stack trace of all running goroutines, then calls os.Exit(255). Arguments are handled in the manner of fmt.Printf; a newline is appended if missing.\nThose labels are not set on the issue: <detailsIn response to : /remove-kind bug Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nYou need to have multiple pods to reproduce this error. It won't happen with just one pod. For example: The error says the type can't be sorted, so that is the problem: As said, this error is generated intentionally. Here is the code: The problem stems from the fact that  has no way to return an error, so it logs a fatal error which os.Exits. It seems like the problem is that the error message is too verbose. One solution could be to change the code to only print the error message and exit, instead of using which is what is outputting the stack trace. It probably doesn't make sense to dump a stack trace for something that is a user error.", "positive_passages": [{"docid": "doc-en-kubernetes-6b9eee0670d11f67c6a6106f65e8be83a603f9db1f69a22a28ea47f332e34a76", "text": "less, err := isLess(iField, jField) if err != nil { <del> klog.Fatalf(\"Field %s in %T is an unsortable type: %s, err: %v\", t.field, t.parsedRows, iField.Kind().String(), err) </del> <ins> klog.Exitf(\"Field %s in %T is an unsortable type: %s, err: %v\", t.field, t.parsedRows, iField.Kind().String(), err) </ins> } return less }", "commid": "kubernetes_pr_103458"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-862f32665f7ff5a74e5631fecd3a9519d01b2fb3056b9a5567a6d9f9cb201478", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI -- (containerd) (crio) [sig-node] ResourceMetricsAPI [NodeFeature:ResourceMetrics] when querying /resource/metrics should report resource usage through the resource metrics api Ever since this commit was merged (containerd) (crio) We need to see what the commit is breaking this particular NodeFeatures test on both crio and containerd.\n/sig node\n/cc\n/cc\n/triage accepted\nah, let's use the RT's issue /close\nClosing this issue. <detailsIn response to : ah, let's use the RT's issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-c5cb85394c649b044f4e0d3f7e495377fb5379385d02d4228ada8f8dbc29eb0a", "text": "return } <del> ch <- metrics.NewLazyConstMetric(containerStartTimeDesc, metrics.GaugeValue, float64(s.StartTime.UnixNano())/float64(time.Second), s.Name, pod.PodRef.Name, pod.PodRef.Namespace) </del> <ins> ch <- metrics.NewLazyMetricWithTimestamp(s.StartTime.Time, metrics.NewLazyConstMetric(containerStartTimeDesc, metrics.GaugeValue, float64(s.StartTime.UnixNano())/float64(time.Second), s.Name, pod.PodRef.Name, pod.PodRef.Namespace)) </ins> } func (rc *resourceMetricsCollector) collectContainerCPUMetrics(ch chan<- metrics.Metric, pod summary.PodStats, s summary.ContainerStats) {", "commid": "kubernetes_pr_103429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-862f32665f7ff5a74e5631fecd3a9519d01b2fb3056b9a5567a6d9f9cb201478", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI -- (containerd) (crio) [sig-node] ResourceMetricsAPI [NodeFeature:ResourceMetrics] when querying /resource/metrics should report resource usage through the resource metrics api Ever since this commit was merged (containerd) (crio) We need to see what the commit is breaking this particular NodeFeatures test on both crio and containerd.\n/sig node\n/cc\n/cc\n/triage accepted\nah, let's use the RT's issue /close\nClosing this issue. <detailsIn response to : ah, let's use the RT's issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-914097ec45946cf672a6932094575ba2f30edd2dabdb3829783e6259c04d85e2", "text": "container_memory_working_set_bytes{container=\"container_b\",namespace=\"namespace_a\",pod=\"pod_a\"} 1000 1624396278302 # HELP container_start_time_seconds [ALPHA] Start time of the container since unix epoch in seconds # TYPE container_start_time_seconds gauge <del> container_start_time_seconds{container=\"container_a\",namespace=\"namespace_a\",pod=\"pod_a\"} 1.6243962483020916e+09 container_start_time_seconds{container=\"container_a\",namespace=\"namespace_b\",pod=\"pod_b\"} 1.6243956783020916e+09 container_start_time_seconds{container=\"container_b\",namespace=\"namespace_a\",pod=\"pod_a\"} 1.6243961583020916e+09 </del> <ins> container_start_time_seconds{container=\"container_a\",namespace=\"namespace_a\",pod=\"pod_a\"} 1.6243962483020916e+09 1624396248302 container_start_time_seconds{container=\"container_a\",namespace=\"namespace_b\",pod=\"pod_b\"} 1.6243956783020916e+09 1624395678302 container_start_time_seconds{container=\"container_b\",namespace=\"namespace_a\",pod=\"pod_a\"} 1.6243961583020916e+09 1624396158302 </ins> `, }, {", "commid": "kubernetes_pr_103429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-862f32665f7ff5a74e5631fecd3a9519d01b2fb3056b9a5567a6d9f9cb201478", "query": "<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI -- (containerd) (crio) [sig-node] ResourceMetricsAPI [NodeFeature:ResourceMetrics] when querying /resource/metrics should report resource usage through the resource metrics api Ever since this commit was merged (containerd) (crio) We need to see what the commit is breaking this particular NodeFeatures test on both crio and containerd.\n/sig node\n/cc\n/cc\n/triage accepted\nah, let's use the RT's issue /close\nClosing this issue. <detailsIn response to : ah, let's use the RT's issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-052881a332d8230a2598e96c32df0184bb4f770bf0e60e3d04b688c603510528", "text": "}), \"container_start_time_seconds\": gstruct.MatchElements(containerID, gstruct.IgnoreExtras, gstruct.Elements{ <del> fmt.Sprintf(\"%s::%s::%s\", f.Namespace.Name, pod0, \"busybox-container\"): boundedSample(time.Now().Add(-maxStatsAge).UnixNano(), time.Now().Add(2*time.Minute).UnixNano()), fmt.Sprintf(\"%s::%s::%s\", f.Namespace.Name, pod1, \"busybox-container\"): boundedSample(time.Now().Add(-maxStatsAge).UnixNano(), time.Now().Add(2*time.Minute).UnixNano()), </del> <ins> fmt.Sprintf(\"%s::%s::%s\", f.Namespace.Name, pod0, \"busybox-container\"): boundedSample(time.Now().Add(-maxStatsAge).Unix(), time.Now().Add(2*time.Minute).Unix()), fmt.Sprintf(\"%s::%s::%s\", f.Namespace.Name, pod1, \"busybox-container\"): boundedSample(time.Now().Add(-maxStatsAge).Unix(), time.Now().Add(2*time.Minute).Unix()), </ins> }), \"pod_cpu_usage_seconds_total\": gstruct.MatchElements(podID, gstruct.IgnoreExtras, gstruct.Elements{", "commid": "kubernetes_pr_103429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e603fe5ce8ece9dbd9f0832cb091bd8f6895f7a263b51dd8de4e2124e6f25cdb", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --kubelet failed to start when specifying ,with following error: Try to start kubelet with : Kubernetes version (use ): master branch Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node\nSubmitted PR to fix this issue.\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-c4b4a49b78248a7493a431b229a261a00b148896f6b0eedd6c34eb94d55197a7", "text": "Subsystem:         KubeletSubsystem, Name:              AssignedConfigKey, Help:              \"The node's understanding of intended config. The count is always 1.\", <del> DeprecatedVersion: \"1.22\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, []string{ConfigSourceLabelKey, ConfigUIDLabelKey, ConfigResourceVersionLabelKey, KubeletConfigKeyLabelKey},", "commid": "kubernetes_pr_103580"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e603fe5ce8ece9dbd9f0832cb091bd8f6895f7a263b51dd8de4e2124e6f25cdb", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --kubelet failed to start when specifying ,with following error: Try to start kubelet with : Kubernetes version (use ): master branch Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node\nSubmitted PR to fix this issue.\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-2ebe5965897a39fdbe8e762d6ac827656e8a5aba55657794130146fdbec05ebd", "text": "Subsystem:         KubeletSubsystem, Name:              ActiveConfigKey, Help:              \"The config source the node is actively using. The count is always 1.\", <del> DeprecatedVersion: \"1.22\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, []string{ConfigSourceLabelKey, ConfigUIDLabelKey, ConfigResourceVersionLabelKey, KubeletConfigKeyLabelKey},", "commid": "kubernetes_pr_103580"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e603fe5ce8ece9dbd9f0832cb091bd8f6895f7a263b51dd8de4e2124e6f25cdb", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --kubelet failed to start when specifying ,with following error: Try to start kubelet with : Kubernetes version (use ): master branch Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node\nSubmitted PR to fix this issue.\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-33cdfb0c1fa6701dca11916d58f0fc0cfb834a5eed3099123c7630a56115c6ce", "text": "Subsystem:         KubeletSubsystem, Name:              LastKnownGoodConfigKey, Help:              \"The config source the node will fall back to when it encounters certain errors. The count is always 1.\", <del> DeprecatedVersion: \"1.22\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, []string{ConfigSourceLabelKey, ConfigUIDLabelKey, ConfigResourceVersionLabelKey, KubeletConfigKeyLabelKey},", "commid": "kubernetes_pr_103580"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e603fe5ce8ece9dbd9f0832cb091bd8f6895f7a263b51dd8de4e2124e6f25cdb", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --kubelet failed to start when specifying ,with following error: Try to start kubelet with : Kubernetes version (use ): master branch Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig node\nSubmitted PR to fix this issue.\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-cb3c90adeb5623e6e623f058961e85eb494a8111e04de86e58384ae8f459a7f9", "text": "Subsystem:         KubeletSubsystem, Name:              ConfigErrorKey, Help:              \"This metric is true (1) if the node is experiencing a configuration-related error, false (0) otherwise.\", <del> DeprecatedVersion: \"1.22\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, )", "commid": "kubernetes_pr_103580"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-804d53620cf3fadbbe0ac63047ffbcfe1b763effbb880645a77f54d2588b9780", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --I found that for with returns a very small value. The value should be almost the same as the one of . My minimal : Result: While the top three lines () are good, the float values in the bottom three lines () might be broken. Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery\n/assign\n/cc /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-30e1490f18740534caf20a50d555b9368b648df9b422646f969e0046d1cb8d57", "text": "\"custom\": resource.MustParse(\"0\"), }, Limits: v1.ResourceList{ <del> \"memory\": resource.MustParse(\"2G\"), </del> <ins> \"memory\": resource.MustParse(\"2.5Gi\"), </ins> \"custom\": resource.MustParse(\"6\"), }, }},", "commid": "kubernetes_pr_103751"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-804d53620cf3fadbbe0ac63047ffbcfe1b763effbb880645a77f54d2588b9780", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --I found that for with returns a very small value. The value should be almost the same as the one of . My minimal : Result: While the top three lines () are good, the float values in the bottom three lines () might be broken. Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery\n/assign\n/cc /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-e2a032c49b1f110e234f4358afbdb1c8d4b2b436803a716cc058208834b52e0a", "text": "expected := `# HELP kube_pod_resource_limit [ALPHA] Resources limit for workloads on the cluster, broken down by pod. This shows the resource usage the scheduler and kubelet expect per pod for resources along with the unit for the resource if any. # TYPE kube_pod_resource_limit gauge kube_pod_resource_limit{namespace=\"test\",node=\"node-one\",pod=\"foo\",priority=\"\",resource=\"custom\",scheduler=\"\",unit=\"\"} 6 <del> kube_pod_resource_limit{namespace=\"test\",node=\"node-one\",pod=\"foo\",priority=\"\",resource=\"memory\",scheduler=\"\",unit=\"bytes\"} 2e+09 </del> <ins> kube_pod_resource_limit{namespace=\"test\",node=\"node-one\",pod=\"foo\",priority=\"\",resource=\"memory\",scheduler=\"\",unit=\"bytes\"} 2.68435456e+09 </ins> # HELP kube_pod_resource_request [ALPHA] Resources requested by workloads on the cluster, broken down by pod. This shows the resource usage the scheduler and kubelet expect per pod for resources along with the unit for the resource if any. # TYPE kube_pod_resource_request gauge kube_pod_resource_request{namespace=\"test\",node=\"node-one\",pod=\"foo\",priority=\"\",resource=\"cpu\",scheduler=\"\",unit=\"cores\"} 2", "commid": "kubernetes_pr_103751"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-804d53620cf3fadbbe0ac63047ffbcfe1b763effbb880645a77f54d2588b9780", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --I found that for with returns a very small value. The value should be almost the same as the one of . My minimal : Result: While the top three lines () are good, the float values in the bottom three lines () might be broken. Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery\n/assign\n/cc /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-fce64b596a833b2624fc0ddf425bf224e73616847d886f6aded0ff907572e472", "text": "return base } <del> // multiply by the appropriate exponential scale switch q.Format { case DecimalExponent, DecimalSI: return base * math.Pow10(exponent) default: // fast path for exponents that can fit in 64 bits if exponent > 0 && exponent < 7 { return base * float64(int64(1)<<(exponent*10)) } return base * math.Pow(2, float64(exponent*10)) } </del> <ins> return base * math.Pow10(exponent) </ins> } // AsInt64 returns a representation of the current value as an int64 if a fast conversion", "commid": "kubernetes_pr_103751"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-804d53620cf3fadbbe0ac63047ffbcfe1b763effbb880645a77f54d2588b9780", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --I found that for with returns a very small value. The value should be almost the same as the one of . My minimal : Result: While the top three lines () are good, the float values in the bottom three lines () might be broken. Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery\n/assign\n/cc /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-9aea365cbe7f7f141758687902a91709e93c6ddd69f14ae66c201c10580f0972", "text": "{decQuantity(1024, 0, BinarySI), 1024}, {decQuantity(8*1024, 0, BinarySI), 8 * 1024}, {decQuantity(7*1024*1024, 0, BinarySI), 7 * 1024 * 1024}, <del> {decQuantity(7*1024*1024, 1, BinarySI), (7 * 1024 * 1024) * 1024}, {decQuantity(7*1024*1024, 4, BinarySI), (7 * 1024 * 1024) * (1024 * 1024 * 1024 * 1024)}, {decQuantity(7*1024*1024, 8, BinarySI), (7 * 1024 * 1024) * (1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024)}, {decQuantity(7*1024*1024, -1, BinarySI), (7 * 1024 * 1024) / float64(1024)}, {decQuantity(7*1024*1024, -8, BinarySI), (7 * 1024 * 1024) / float64(1024*1024*1024*1024*1024*1024*1024*1024)}, </del> <ins> {decQuantity(7*1024*1024, 1, BinarySI), (7 * 1024 * 1024) * 10}, {decQuantity(7*1024*1024, 4, BinarySI), (7 * 1024 * 1024) * 10000}, {decQuantity(7*1024*1024, 8, BinarySI), (7 * 1024 * 1024) * 100000000}, {decQuantity(7*1024*1024, -1, BinarySI), (7 * 1024 * 1024) * math.Pow10(-1)}, // '* Pow10' and '/ float(10)' do not round the same way {decQuantity(7*1024*1024, -8, BinarySI), (7 * 1024 * 1024) / float64(100000000)}, </ins> {decQuantity(1024, 0, DecimalSI), 1024}, {decQuantity(8*1024, 0, DecimalSI), 8 * 1024},", "commid": "kubernetes_pr_103751"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-804d53620cf3fadbbe0ac63047ffbcfe1b763effbb880645a77f54d2588b9780", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --I found that for with returns a very small value. The value should be almost the same as the one of . My minimal : Result: While the top three lines () are good, the float values in the bottom three lines () might be broken. Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig api-machinery\n/assign\n/cc /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-6be1d322ec16ddb86f9462bf2934b4abe5af020bb26269e2eeb8c8af73af3e90", "text": "} } <ins> func TestStringQuantityAsApproximateFloat64(t *testing.T) { table := []struct { in  string out float64 }{ {\"2Ki\", 2048}, {\"1.1Ki\", 1126.4e+0}, {\"1Mi\", 1.048576e+06}, {\"2Gi\", 2.147483648e+09}, } for _, item := range table { t.Run(item.in, func(t *testing.T) { in, err := ParseQuantity(item.in) if err != nil { t.Fatal(err) } out := in.AsApproximateFloat64() if out != item.out { t.Fatalf(\"expected %v, got %v\", item.out, out) } if in.d.Dec != nil { if i, ok := in.AsInt64(); ok { q := intQuantity(i, 0, in.Format) out := q.AsApproximateFloat64() if out != item.out { t.Fatalf(\"as int quantity: expected %v, got %v\", item.out, out) } } } }) } } </ins> func benchmarkQuantities() []Quantity { return []Quantity{ intQuantity(1024*1024*1024, 0, BinarySI),", "commid": "kubernetes_pr_103751"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cae18774614f470926558066cfaad9f76aa35af725b3532d8618aeed63a7d6a4", "query": "While investigating some slowness in mounting/unmounting operations of PVs (in this case EFS volumes) for pods, we observed errors like these: fortunately it does recover quickly on Kubelet\u2019s next retry: Looking through the Kubelet code I found out that the issue is not related to the umount calls themselves, but rather a race condition inside where we call umount. Because of the way golang\u2019s function (called inside ) is implemented, it for the child process to finish after it is . Since there isn't any locking on the child process across those function calls, it's possible that the child process exits event before the Wait() call starts. In such case the wait call returns with a error (). This error is more likely to happen especially if the gap between the Start() and Wait() calls is more (which could for e,g happen if the goroutine had CPU cycles snatched away from it for some time in between those calls). A similar issue also exists in the . While this is a self-recovering issue (because of Kubelet retries), it does seem to increase the pod startup/cleanup latency upto a 1s. Open to suggestions for a fix. The simplest one occurring to me is to treat the error as a special one on which we don't actually return an error for the mount/unmount calls. /sig storage /sig scalability /assign\nAnother thing is when analyzing a distribution of such errors across different nodes, we observed a skew. The top 10% of the nodes were seeing more than 90% of these errors. And these are nodes that are running hotter (w.r.t the pod churn) compared to others: ! Given this, I'm wondering if those errors are higher on those nodes just because of statistical significance or other causes like more GC pauses happening on those nodes.\n/triage accepted\n^ I've opened this PR to fix the Mount/Unmount functions in the file. In general we might want to make a similar fix to other invocations of exec.Run() and exec.CombinedOutput() within our codebase. But that'll be a bigger change. Happy to open another issue for it.\nSorry for opening the PR against wrong repo, here's the right one -", "positive_passages": [{"docid": "doc-en-kubernetes-36d6edb12924e50d7aad94e39c5c8f6fd6660068ba62fdf4f37bc00888be0bd3", "text": "fsckErrorsCorrected = 1 // 'fsck' found errors but exited without correcting them fsckErrorsUncorrected = 4 <ins> // Error thrown by exec cmd.Run() when process spawned by cmd.Start() completes before cmd.Wait() is called (see - k/k issue #103753) errNoChildProcesses = \"wait: no child processes\" </ins> ) // Mounter provides the default implementation of mount.Interface", "commid": "kubernetes_pr_103780"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cae18774614f470926558066cfaad9f76aa35af725b3532d8618aeed63a7d6a4", "query": "While investigating some slowness in mounting/unmounting operations of PVs (in this case EFS volumes) for pods, we observed errors like these: fortunately it does recover quickly on Kubelet\u2019s next retry: Looking through the Kubelet code I found out that the issue is not related to the umount calls themselves, but rather a race condition inside where we call umount. Because of the way golang\u2019s function (called inside ) is implemented, it for the child process to finish after it is . Since there isn't any locking on the child process across those function calls, it's possible that the child process exits event before the Wait() call starts. In such case the wait call returns with a error (). This error is more likely to happen especially if the gap between the Start() and Wait() calls is more (which could for e,g happen if the goroutine had CPU cycles snatched away from it for some time in between those calls). A similar issue also exists in the . While this is a self-recovering issue (because of Kubelet retries), it does seem to increase the pod startup/cleanup latency upto a 1s. Open to suggestions for a fix. The simplest one occurring to me is to treat the error as a special one on which we don't actually return an error for the mount/unmount calls. /sig storage /sig scalability /assign\nAnother thing is when analyzing a distribution of such errors across different nodes, we observed a skew. The top 10% of the nodes were seeing more than 90% of these errors. And these are nodes that are running hotter (w.r.t the pod churn) compared to others: ! Given this, I'm wondering if those errors are higher on those nodes just because of statistical significance or other causes like more GC pauses happening on those nodes.\n/triage accepted\n^ I've opened this PR to fix the Mount/Unmount functions in the file. In general we might want to make a similar fix to other invocations of exec.Run() and exec.CombinedOutput() within our codebase. But that'll be a bigger change. Happy to open another issue for it.\nSorry for opening the PR against wrong repo, here's the right one -", "positive_passages": [{"docid": "doc-en-kubernetes-dbba9438f97e8971e0f3fbc906b6e71a85f54dcf02cd6a18fa5341d05bb27de4", "text": "command := exec.Command(mountCmd, mountArgs...) output, err := command.CombinedOutput() if err != nil { <ins> if err.Error() == errNoChildProcesses { if command.ProcessState.Success() { // We don't consider errNoChildProcesses an error if the process itself succeeded (see - k/k issue #103753). return nil } // Rewrite err with the actual exit error of the process. err = &exec.ExitError{ProcessState: command.ProcessState} } </ins> klog.Errorf(\"Mount failed: %vnMounting command: %snMounting arguments: %snOutput: %sn\", err, mountCmd, mountArgsLogStr, string(output)) return fmt.Errorf(\"mount failed: %vnMounting command: %snMounting arguments: %snOutput: %s\", err, mountCmd, mountArgsLogStr, string(output))", "commid": "kubernetes_pr_103780"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-cae18774614f470926558066cfaad9f76aa35af725b3532d8618aeed63a7d6a4", "query": "While investigating some slowness in mounting/unmounting operations of PVs (in this case EFS volumes) for pods, we observed errors like these: fortunately it does recover quickly on Kubelet\u2019s next retry: Looking through the Kubelet code I found out that the issue is not related to the umount calls themselves, but rather a race condition inside where we call umount. Because of the way golang\u2019s function (called inside ) is implemented, it for the child process to finish after it is . Since there isn't any locking on the child process across those function calls, it's possible that the child process exits event before the Wait() call starts. In such case the wait call returns with a error (). This error is more likely to happen especially if the gap between the Start() and Wait() calls is more (which could for e,g happen if the goroutine had CPU cycles snatched away from it for some time in between those calls). A similar issue also exists in the . While this is a self-recovering issue (because of Kubelet retries), it does seem to increase the pod startup/cleanup latency upto a 1s. Open to suggestions for a fix. The simplest one occurring to me is to treat the error as a special one on which we don't actually return an error for the mount/unmount calls. /sig storage /sig scalability /assign\nAnother thing is when analyzing a distribution of such errors across different nodes, we observed a skew. The top 10% of the nodes were seeing more than 90% of these errors. And these are nodes that are running hotter (w.r.t the pod churn) compared to others: ! Given this, I'm wondering if those errors are higher on those nodes just because of statistical significance or other causes like more GC pauses happening on those nodes.\n/triage accepted\n^ I've opened this PR to fix the Mount/Unmount functions in the file. In general we might want to make a similar fix to other invocations of exec.Run() and exec.CombinedOutput() within our codebase. But that'll be a bigger change. Happy to open another issue for it.\nSorry for opening the PR against wrong repo, here's the right one -", "positive_passages": [{"docid": "doc-en-kubernetes-c56823e1189bc6fc779e0e30b57438bc4d9578d206f1ab1e9a2190c9b296b5e1", "text": "command := exec.Command(\"umount\", target) output, err := command.CombinedOutput() if err != nil { <ins> if err.Error() == errNoChildProcesses { if command.ProcessState.Success() { // We don't consider errNoChildProcesses an error if the process itself succeeded (see - k/k issue #103753). return nil } // Rewrite err with the actual exit error of the process. err = &exec.ExitError{ProcessState: command.ProcessState} } </ins> return fmt.Errorf(\"unmount failed: %vnUnmounting arguments: %snOutput: %s\", err, target, string(output)) } return nil", "commid": "kubernetes_pr_103780"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-6c377b6cd30e8dc2ed4266dec9ffe50b3a2afcbd89c00e74880bb16d19da7d32", "text": "Subsystem:         KubeletSubsystem, Name:              AssignedConfigKey, Help:              \"The node's understanding of intended config. The count is always 1.\", <del> DeprecatedVersion: \"1.23.0\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, []string{ConfigSourceLabelKey, ConfigUIDLabelKey, ConfigResourceVersionLabelKey, KubeletConfigKeyLabelKey},", "commid": "kubernetes_pr_104075"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-a65bcb593900744f4ee9899c2642080e3656ecbdfa9749f2476a8178a59d35d2", "text": "Subsystem:         KubeletSubsystem, Name:              ActiveConfigKey, Help:              \"The config source the node is actively using. The count is always 1.\", <del> DeprecatedVersion: \"1.23.0\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, []string{ConfigSourceLabelKey, ConfigUIDLabelKey, ConfigResourceVersionLabelKey, KubeletConfigKeyLabelKey},", "commid": "kubernetes_pr_104075"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-9faa0a296f1f7feffe199f288f012edf10f855f80b5684733f94d5e56905ed93", "text": "Subsystem:         KubeletSubsystem, Name:              LastKnownGoodConfigKey, Help:              \"The config source the node will fall back to when it encounters certain errors. The count is always 1.\", <del> DeprecatedVersion: \"1.23.0\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, []string{ConfigSourceLabelKey, ConfigUIDLabelKey, ConfigResourceVersionLabelKey, KubeletConfigKeyLabelKey},", "commid": "kubernetes_pr_104075"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-2cab39e7b6e5e255c397699825d3de1c24403ac442d4ccaeaf9668f3d7be3f74", "text": "Subsystem:         KubeletSubsystem, Name:              ConfigErrorKey, Help:              \"This metric is true (1) if the node is experiencing a configuration-related error, false (0) otherwise.\", <del> DeprecatedVersion: \"1.23.0\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, )", "commid": "kubernetes_pr_104075"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-4f56a5830c1aa514eba019dfd6f8e816b5292686c28f28959b607a47e47fd01c", "text": "framework.ExpectNoError(err) beforeKC = kc } <ins> // show hidden metrics for release 1.22 beforeKC = updateShowHiddenMetricsForVersion(beforeKC, \"1.22\") </ins> // reset the node's assigned/active/last-known-good config by setting the source to nil, // so each test starts from a clean-slate (&nodeConfigTestCase{", "commid": "kubernetes_pr_104075"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-ee2542e785d02ad9ce07034e92a249e05e87250643a63962e549246cbc1cd2b4", "text": "framework.ExpectNoError(err) localKC = kc } <ins> // show hidden metrics for release 1.22 localKC = updateShowHiddenMetricsForVersion(localKC, \"1.22\") </ins> }) ginkgo.AfterEach(func() {", "commid": "kubernetes_pr_104075"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-29b2c6e62f60954096cd431da8484fa1404d7f6db8427399c720e0abcaddcb86", "text": "return nil }, timeout, interval).Should(gomega.BeNil()) } <ins> func updateShowHiddenMetricsForVersion(cfg *kubeletconfig.KubeletConfiguration, version string) *kubeletconfig.KubeletConfiguration { if cfg == nil { return &kubeletconfig.KubeletConfiguration{ ShowHiddenMetricsForVersion: version, } } cfg.ShowHiddenMetricsForVersion = version return cfg } </ins>", "commid": "kubernetes_pr_104075"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-6c377b6cd30e8dc2ed4266dec9ffe50b3a2afcbd89c00e74880bb16d19da7d32", "text": "Subsystem:         KubeletSubsystem, Name:              AssignedConfigKey, Help:              \"The node's understanding of intended config. The count is always 1.\", <del> DeprecatedVersion: \"1.23.0\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, []string{ConfigSourceLabelKey, ConfigUIDLabelKey, ConfigResourceVersionLabelKey, KubeletConfigKeyLabelKey},", "commid": "kubernetes_pr_106505"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-a65bcb593900744f4ee9899c2642080e3656ecbdfa9749f2476a8178a59d35d2", "text": "Subsystem:         KubeletSubsystem, Name:              ActiveConfigKey, Help:              \"The config source the node is actively using. The count is always 1.\", <del> DeprecatedVersion: \"1.23.0\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, []string{ConfigSourceLabelKey, ConfigUIDLabelKey, ConfigResourceVersionLabelKey, KubeletConfigKeyLabelKey},", "commid": "kubernetes_pr_106505"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-9faa0a296f1f7feffe199f288f012edf10f855f80b5684733f94d5e56905ed93", "text": "Subsystem:         KubeletSubsystem, Name:              LastKnownGoodConfigKey, Help:              \"The config source the node will fall back to when it encounters certain errors. The count is always 1.\", <del> DeprecatedVersion: \"1.23.0\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, []string{ConfigSourceLabelKey, ConfigUIDLabelKey, ConfigResourceVersionLabelKey, KubeletConfigKeyLabelKey},", "commid": "kubernetes_pr_106505"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6addd3c1e7199aac87ba907f15b2227475fea0adf298db12db53b8969dda42ad", "query": "This shipped in 1.22 as deprecated in 1.22. As a hacky fix to unbreak tests on 1.23 dev, I bumped the deprecation policy one release: We will need to revert that before 1.23 ships and figure out a better solution. /kind cleanup /milestone v1.23 /sig node\n/triage accepted\nI want to try it. Can I take this issue?\nI have explained how to fix this on PR:\n/reopen reverted in as fix did not work\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nHi, Im the bug triage shadow. Since we're in 1.23 milestone code freeze, could we move this issue to milestone 1.24?\nthis is critical for 1.23 and I think it just got forgotten... we need to get this fixed before test freeze\n/priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-2cab39e7b6e5e255c397699825d3de1c24403ac442d4ccaeaf9668f3d7be3f74", "text": "Subsystem:         KubeletSubsystem, Name:              ConfigErrorKey, Help:              \"This metric is true (1) if the node is experiencing a configuration-related error, false (0) otherwise.\", <del> DeprecatedVersion: \"1.23.0\", </del> <ins> DeprecatedVersion: \"1.22.0\", </ins> StabilityLevel:    metrics.ALPHA, }, )", "commid": "kubernetes_pr_106505"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07ff28dc2e90ab46673a9e73d897dd1721db789904ba063b78fff5090ea32daf", "query": "When calling GetAllocatableDevices, the API returns all the registered devices, regardless of their health status. Thing is, the - and in general doesn't make much sense to report as allocatable Unhealthy devices, as is also documented in the (see last paragraph) The API should not report unhealthy device. This means the reported device set can potentially change across multiple invocations of the API, as . a kube = 1.21 environment, enable the feature gate any device plugin - including sample device plugin sure 1+ devices are reported unhealthy the podresources GetAllocatableResources API, observe the unhealthy device is reported in the return value. N/A Kubernetes version (use ): 1.21 and beyond Cloud provider or hardware configuration: not relevant OS (e.g: ): any Kernel (e.g. ): not relevant Install tools: not relevant Network plugin and version (if this is a network-related bug): not relevant Others: not relevant\n/sig node\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-46a6e2b652d3fdcffc36f9b22b680ce5e68d4524d74b99945ee969a4d0008f4b", "text": "return false } <del> // GetAllocatableDevices returns information about all the devices known to the manager </del> <ins> // GetAllocatableDevices returns information about all the healthy devices known to the manager </ins> func (m *ManagerImpl) GetAllocatableDevices() ResourceDeviceInstances { m.mutex.Lock() <del> resp := m.allDevices.Clone() m.mutex.Unlock() klog.V(4).InfoS(\"Known devices\", \"numDevices\", len(resp)) </del> <ins> defer m.mutex.Unlock() resp := m.allDevices.Filter(m.healthyDevices) klog.V(4).InfoS(\"GetAllocatableDevices\", \"known\", len(m.allDevices), \"allocatable\", len(resp)) </ins> return resp }", "commid": "kubernetes_pr_104123"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07ff28dc2e90ab46673a9e73d897dd1721db789904ba063b78fff5090ea32daf", "query": "When calling GetAllocatableDevices, the API returns all the registered devices, regardless of their health status. Thing is, the - and in general doesn't make much sense to report as allocatable Unhealthy devices, as is also documented in the (see last paragraph) The API should not report unhealthy device. This means the reported device set can potentially change across multiple invocations of the API, as . a kube = 1.21 environment, enable the feature gate any device plugin - including sample device plugin sure 1+ devices are reported unhealthy the podresources GetAllocatableResources API, observe the unhealthy device is reported in the return value. N/A Kubernetes version (use ): 1.21 and beyond Cloud provider or hardware configuration: not relevant OS (e.g: ): any Kernel (e.g. ): not relevant Install tools: not relevant Network plugin and version (if this is a network-related bug): not relevant Others: not relevant\n/sig node\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-4542bb3955476f032fb447769c1820bd66b0ef2cdb73df72d3326e6dc880b5bb", "text": "as.True(testManager.isDevicePluginResource(resourceName2)) } <ins> func TestGetAllocatableDevicesMultipleResources(t *testing.T) { socketDir, socketName, _, err := tmpSocketDir() topologyStore := topologymanager.NewFakeManager() require.NoError(t, err) defer os.RemoveAll(socketDir) testManager, err := newManagerImpl(socketName, nil, topologyStore) as := assert.New(t) as.NotNil(testManager) as.Nil(err) resource1Devs := []pluginapi.Device{ {ID: \"R1Device1\", Health: pluginapi.Healthy}, {ID: \"R1Device2\", Health: pluginapi.Healthy}, {ID: \"R1Device3\", Health: pluginapi.Unhealthy}, } resourceName1 := \"domain1.com/resource1\" e1 := &endpointImpl{} testManager.endpoints[resourceName1] = endpointInfo{e: e1, opts: nil} testManager.genericDeviceUpdateCallback(resourceName1, resource1Devs) resource2Devs := []pluginapi.Device{ {ID: \"R2Device1\", Health: pluginapi.Healthy}, } resourceName2 := \"other.domain2.org/resource2\" e2 := &endpointImpl{} testManager.endpoints[resourceName2] = endpointInfo{e: e2, opts: nil} testManager.genericDeviceUpdateCallback(resourceName2, resource2Devs) allocatableDevs := testManager.GetAllocatableDevices() as.Equal(2, len(allocatableDevs)) devInstances1, ok := allocatableDevs[resourceName1] as.True(ok) checkAllocatableDevicesConsistsOf(as, devInstances1, []string{\"R1Device1\", \"R1Device2\"}) devInstances2, ok := allocatableDevs[resourceName2] as.True(ok) checkAllocatableDevicesConsistsOf(as, devInstances2, []string{\"R2Device1\"}) } func TestGetAllocatableDevicesHealthTransition(t *testing.T) { socketDir, socketName, _, err := tmpSocketDir() topologyStore := topologymanager.NewFakeManager() require.NoError(t, err) defer os.RemoveAll(socketDir) testManager, err := newManagerImpl(socketName, nil, topologyStore) as := assert.New(t) as.NotNil(testManager) as.Nil(err) resource1Devs := []pluginapi.Device{ {ID: \"R1Device1\", Health: pluginapi.Healthy}, {ID: \"R1Device2\", Health: pluginapi.Healthy}, {ID: \"R1Device3\", Health: pluginapi.Unhealthy}, } // Adds three devices for resource1, two healthy and one unhealthy. // Expects allocatable devices for resource1 to be 2. resourceName1 := \"domain1.com/resource1\" e1 := &endpointImpl{} testManager.endpoints[resourceName1] = endpointInfo{e: e1, opts: nil} testManager.genericDeviceUpdateCallback(resourceName1, resource1Devs) allocatableDevs := testManager.GetAllocatableDevices() as.Equal(1, len(allocatableDevs)) devInstances, ok := allocatableDevs[resourceName1] as.True(ok) checkAllocatableDevicesConsistsOf(as, devInstances, []string{\"R1Device1\", \"R1Device2\"}) // Unhealthy device becomes healthy resource1Devs = []pluginapi.Device{ {ID: \"R1Device1\", Health: pluginapi.Healthy}, {ID: \"R1Device2\", Health: pluginapi.Healthy}, {ID: \"R1Device3\", Health: pluginapi.Healthy}, } testManager.genericDeviceUpdateCallback(resourceName1, resource1Devs) allocatableDevs = testManager.GetAllocatableDevices() as.Equal(1, len(allocatableDevs)) devInstances, ok = allocatableDevs[resourceName1] as.True(ok) checkAllocatableDevicesConsistsOf(as, devInstances, []string{\"R1Device1\", \"R1Device2\", \"R1Device3\"}) } func checkAllocatableDevicesConsistsOf(as *assert.Assertions, devInstances DeviceInstances, expectedDevs []string) { as.Equal(len(expectedDevs), len(devInstances)) for _, deviceID := range expectedDevs { _, ok := devInstances[deviceID] as.True(ok) } } </ins> func constructDevices(devices []string) checkpoint.DevicesPerNUMA { ret := checkpoint.DevicesPerNUMA{} for _, dev := range devices {", "commid": "kubernetes_pr_104123"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07ff28dc2e90ab46673a9e73d897dd1721db789904ba063b78fff5090ea32daf", "query": "When calling GetAllocatableDevices, the API returns all the registered devices, regardless of their health status. Thing is, the - and in general doesn't make much sense to report as allocatable Unhealthy devices, as is also documented in the (see last paragraph) The API should not report unhealthy device. This means the reported device set can potentially change across multiple invocations of the API, as . a kube = 1.21 environment, enable the feature gate any device plugin - including sample device plugin sure 1+ devices are reported unhealthy the podresources GetAllocatableResources API, observe the unhealthy device is reported in the return value. N/A Kubernetes version (use ): 1.21 and beyond Cloud provider or hardware configuration: not relevant OS (e.g: ): any Kernel (e.g. ): not relevant Install tools: not relevant Network plugin and version (if this is a network-related bug): not relevant Others: not relevant\n/sig node\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-8a350b824ac1882f0e44326a9e6afc883d1c47dc8d64ff943a18b5e3f719ab81", "text": "} return clone } <ins> // Filter takes a condition set expressed as map[string]sets.String and returns a new // ResourceDeviceInstances with only the devices matching the condition set. func (rdev ResourceDeviceInstances) Filter(cond map[string]sets.String) ResourceDeviceInstances { filtered := NewResourceDeviceInstances() for resourceName, filterIDs := range cond { if _, exists := rdev[resourceName]; !exists { continue } filtered[resourceName] = DeviceInstances{} for instanceID, instance := range rdev[resourceName] { if filterIDs.Has(instanceID) { filtered[resourceName][instanceID] = instance } } } return filtered } </ins>", "commid": "kubernetes_pr_104123"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07ff28dc2e90ab46673a9e73d897dd1721db789904ba063b78fff5090ea32daf", "query": "When calling GetAllocatableDevices, the API returns all the registered devices, regardless of their health status. Thing is, the - and in general doesn't make much sense to report as allocatable Unhealthy devices, as is also documented in the (see last paragraph) The API should not report unhealthy device. This means the reported device set can potentially change across multiple invocations of the API, as . a kube = 1.21 environment, enable the feature gate any device plugin - including sample device plugin sure 1+ devices are reported unhealthy the podresources GetAllocatableResources API, observe the unhealthy device is reported in the return value. N/A Kubernetes version (use ): 1.21 and beyond Cloud provider or hardware configuration: not relevant OS (e.g: ): any Kernel (e.g. ): not relevant Install tools: not relevant Network plugin and version (if this is a network-related bug): not relevant Others: not relevant\n/sig node\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-71ec2d331d1fdcdab02f35581cf3be22e997329536b79ea7b3539d3afc6cfd32", "text": "package devicemanager import ( <ins> \"encoding/json\" </ins> \"testing\" \"github.com/stretchr/testify/require\" <ins> \"k8s.io/apimachinery/pkg/util/sets\" pluginapi \"k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1\" </ins> \"k8s.io/kubernetes/pkg/kubelet/cm/devicemanager/checkpoint\" )", "commid": "kubernetes_pr_104123"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-07ff28dc2e90ab46673a9e73d897dd1721db789904ba063b78fff5090ea32daf", "query": "When calling GetAllocatableDevices, the API returns all the registered devices, regardless of their health status. Thing is, the - and in general doesn't make much sense to report as allocatable Unhealthy devices, as is also documented in the (see last paragraph) The API should not report unhealthy device. This means the reported device set can potentially change across multiple invocations of the API, as . a kube = 1.21 environment, enable the feature gate any device plugin - including sample device plugin sure 1+ devices are reported unhealthy the podresources GetAllocatableResources API, observe the unhealthy device is reported in the return value. N/A Kubernetes version (use ): 1.21 and beyond Cloud provider or hardware configuration: not relevant OS (e.g: ): any Kernel (e.g. ): not relevant Install tools: not relevant Network plugin and version (if this is a network-related bug): not relevant Others: not relevant\n/sig node\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-89e4c2da4719049109d780bfbc395500f0c1248c01fdf504174cdf13cd6c5efd", "text": "} } } <ins> func TestResourceDeviceInstanceFilter(t *testing.T) { var expected string var cond map[string]sets.String var resp ResourceDeviceInstances devs := ResourceDeviceInstances{ \"foo\": DeviceInstances{ \"dev-foo1\": pluginapi.Device{ ID: \"foo1\", }, \"dev-foo2\": pluginapi.Device{ ID: \"foo2\", }, \"dev-foo3\": pluginapi.Device{ ID: \"foo3\", }, }, \"bar\": DeviceInstances{ \"dev-bar1\": pluginapi.Device{ ID: \"bar1\", }, \"dev-bar2\": pluginapi.Device{ ID: \"bar2\", }, \"dev-bar3\": pluginapi.Device{ ID: \"bar3\", }, }, \"baz\": DeviceInstances{ \"dev-baz1\": pluginapi.Device{ ID: \"baz1\", }, \"dev-baz2\": pluginapi.Device{ ID: \"baz2\", }, \"dev-baz3\": pluginapi.Device{ ID: \"baz3\", }, }, } resp = devs.Filter(map[string]sets.String{}) expected = `{}` expectResourceDeviceInstances(t, resp, expected) cond = map[string]sets.String{ \"foo\": sets.NewString(\"dev-foo1\", \"dev-foo2\"), \"bar\": sets.NewString(\"dev-bar1\"), } resp = devs.Filter(cond) expected = `{\"bar\":{\"dev-bar1\":{\"ID\":\"bar1\"}},\"foo\":{\"dev-foo1\":{\"ID\":\"foo1\"},\"dev-foo2\":{\"ID\":\"foo2\"}}}` expectResourceDeviceInstances(t, resp, expected) cond = map[string]sets.String{ \"foo\": sets.NewString(\"dev-foo1\", \"dev-foo2\", \"dev-foo3\"), \"bar\": sets.NewString(\"dev-bar1\", \"dev-bar2\", \"dev-bar3\"), \"baz\": sets.NewString(\"dev-baz1\", \"dev-baz2\", \"dev-baz3\"), } resp = devs.Filter(cond) expected = `{\"bar\":{\"dev-bar1\":{\"ID\":\"bar1\"},\"dev-bar2\":{\"ID\":\"bar2\"},\"dev-bar3\":{\"ID\":\"bar3\"}},\"baz\":{\"dev-baz1\":{\"ID\":\"baz1\"},\"dev-baz2\":{\"ID\":\"baz2\"},\"dev-baz3\":{\"ID\":\"baz3\"}},\"foo\":{\"dev-foo1\":{\"ID\":\"foo1\"},\"dev-foo2\":{\"ID\":\"foo2\"},\"dev-foo3\":{\"ID\":\"foo3\"}}}` expectResourceDeviceInstances(t, resp, expected) cond = map[string]sets.String{ \"foo\": sets.NewString(\"dev-foo1\", \"dev-foo2\", \"dev-foo3\", \"dev-foo4\"), \"bar\": sets.NewString(\"dev-bar1\", \"dev-bar2\", \"dev-bar3\", \"dev-bar4\"), \"baz\": sets.NewString(\"dev-baz1\", \"dev-baz2\", \"dev-baz3\", \"dev-bar4\"), } resp = devs.Filter(cond) expected = `{\"bar\":{\"dev-bar1\":{\"ID\":\"bar1\"},\"dev-bar2\":{\"ID\":\"bar2\"},\"dev-bar3\":{\"ID\":\"bar3\"}},\"baz\":{\"dev-baz1\":{\"ID\":\"baz1\"},\"dev-baz2\":{\"ID\":\"baz2\"},\"dev-baz3\":{\"ID\":\"baz3\"}},\"foo\":{\"dev-foo1\":{\"ID\":\"foo1\"},\"dev-foo2\":{\"ID\":\"foo2\"},\"dev-foo3\":{\"ID\":\"foo3\"}}}` expectResourceDeviceInstances(t, resp, expected) cond = map[string]sets.String{ \"foo\": sets.NewString(\"dev-foo1\", \"dev-foo4\", \"dev-foo7\"), \"bar\": sets.NewString(\"dev-bar1\", \"dev-bar4\", \"dev-bar7\"), \"baz\": sets.NewString(\"dev-baz1\", \"dev-baz4\", \"dev-baz7\"), } resp = devs.Filter(cond) expected = `{\"bar\":{\"dev-bar1\":{\"ID\":\"bar1\"}},\"baz\":{\"dev-baz1\":{\"ID\":\"baz1\"}},\"foo\":{\"dev-foo1\":{\"ID\":\"foo1\"}}}` expectResourceDeviceInstances(t, resp, expected) } func expectResourceDeviceInstances(t *testing.T, resp ResourceDeviceInstances, expected string) { // per docs in https://pkg.go.dev/encoding/json#Marshal // \"Map values encode as JSON objects. The map's key type must either be a string, an integer type, or // implement encoding.TextMarshaler. The map keys are sorted [...]\" // so this check is expected to be stable and not flaky data, err := json.Marshal(resp) if err != nil { t.Fatalf(\"unexpected JSON marshalling error: %v\", err) } got := string(data) if got != expected { t.Errorf(\"expected %q got %q\", expected, got) } } </ins>", "commid": "kubernetes_pr_104123"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-986ebc5f1ee3014f101ca7c08d0a452a9f1e89012ba9ad9c3742f7a63611d2f5", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --Following link on sig-network page () is broken Link should be working Kubernetes version (use ):1.21 Cloud provider or hardware configuration:None OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig-network\n/sig network\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-fb3c1833fc8d41cb273b0bc0836a6515ef52cb0d881b3b8ec01dc0108b9b6470", "text": "}, { \"ImportPath\": \"github.com/google/cadvisor/api\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/container\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/events\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/fs\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/healthz\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/http\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/info/v1\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/info/v2\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/manager\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/metrics\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/pages\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/storage\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/summary\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/utils\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/validate\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/cadvisor/version\", <del> \"Comment\": \"0.10.1-92-g41a0c30\", \"Rev\": \"41a0c30fbf4df4d5d711b752785febb6ed5330a4\" </del> <ins> \"Comment\": \"0.10.1-103-gbfaf70b\", \"Rev\": \"bfaf70b2555fcaba212130da04a21302344e38f5\" </ins> }, { \"ImportPath\": \"github.com/google/gofuzz\",", "commid": "kubernetes_pr_5934"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-986ebc5f1ee3014f101ca7c08d0a452a9f1e89012ba9ad9c3742f7a63611d2f5", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --Following link on sig-network page () is broken Link should be working Kubernetes version (use ):1.21 Cloud provider or hardware configuration:None OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig-network\n/sig network\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-e1c56c6c0d9a189f37eb2fdb8a64607ed1dc7709c9b01a45aaf3601863891746", "text": "// TODO(jnagal): Infer schema through reflection. (See bigquery/client/example) func (self *bigqueryStorage) GetSchema() *bigquery.TableSchema { <del> fields := make([]*bigquery.TableFieldSchema, 18) </del> <ins> fields := make([]*bigquery.TableFieldSchema, 19) </ins> i := 0 fields[i] = &bigquery.TableFieldSchema{ Type: typeTimestamp,", "commid": "kubernetes_pr_5934"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-986ebc5f1ee3014f101ca7c08d0a452a9f1e89012ba9ad9c3742f7a63611d2f5", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --Following link on sig-network page () is broken Link should be working Kubernetes version (use ):1.21 Cloud provider or hardware configuration:None OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig-network\n/sig network\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-cb7dc19af35ecb78e127748d6f93ccd886b8188b34316748560191e41fb7fb2b", "text": "\"flag\" \"fmt\" \"io/ioutil\" <del> \"net/http\" </del> \"strings\" <del> \"code.google.com/p/goauth2/oauth\" \"code.google.com/p/goauth2/oauth/jwt\" </del> bigquery \"code.google.com/p/google-api-go-client/bigquery/v2\" <ins> \"golang.org/x/oauth2\" \"golang.org/x/oauth2/jwt\" </ins> ) var (", "commid": "kubernetes_pr_5934"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-986ebc5f1ee3014f101ca7c08d0a452a9f1e89012ba9ad9c3742f7a63611d2f5", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --Following link on sig-network page () is broken Link should be working Kubernetes version (use ):1.21 Cloud provider or hardware configuration:None OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig-network\n/sig network\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-f03cb0c879ad052e21da2ca3ecfe14bb2f8afd6b975470e8111b330b4edfbfbf", "text": "type Client struct { service   *bigquery.Service <del> token     *oauth.Token </del> <ins> token     *oauth2.Token </ins> datasetId string tableId   string } // Helper method to create an authenticated connection. <del> func connect() (*oauth.Token, *bigquery.Service, error) { </del> <ins> func connect() (*oauth2.Token, *bigquery.Service, error) { </ins> if *clientId == \"\" { return nil, nil, fmt.Errorf(\"no client id specified\") }", "commid": "kubernetes_pr_5934"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-986ebc5f1ee3014f101ca7c08d0a452a9f1e89012ba9ad9c3742f7a63611d2f5", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --Following link on sig-network page () is broken Link should be working Kubernetes version (use ):1.21 Cloud provider or hardware configuration:None OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig-network\n/sig network\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-27862f4af45699396def7e8c1c4ea0fa6e5091ea51fc3b37366911703f215604", "text": "return nil, nil, fmt.Errorf(\"could not access credential file %v - %v\", pemFile, err) } <del> t := jwt.NewToken(*serviceAccount, authScope, pemBytes) token, err := t.Assert(&http.Client{}) </del> <ins> jwtConfig := &jwt.Config{ Email:      *serviceAccount, Scopes:     []string{authScope}, PrivateKey: pemBytes, TokenURL:   \"https://accounts.google.com/o/oauth2/token\", } token, err := jwtConfig.TokenSource(oauth2.NoContext).Token() </ins> if err != nil { <del> fmt.Printf(\"Invalid token: %vn\", err) </del> return nil, nil, err } <del> config := &oauth.Config{ ClientId:     *clientId, ClientSecret: *clientSecret, Scope:        authScope, AuthURL:      \"https://accounts.google.com/o/oauth2/auth\", TokenURL:     \"https://accounts.google.com/o/oauth2/token\", </del> <ins> if !token.Valid() { return nil, nil, fmt.Errorf(\"invalid token for BigQuery oauth\") </ins> } <del> transport := &oauth.Transport{ Token:  token, Config: config, </del> <ins> config := &oauth2.Config{ ClientID:     *clientId, ClientSecret: *clientSecret, Scopes:       []string{authScope}, Endpoint: oauth2.Endpoint{ AuthURL:  \"https://accounts.google.com/o/oauth2/auth\", TokenURL: \"https://accounts.google.com/o/oauth2/token\", }, </ins> } <del> client := transport.Client() </del> <ins> client := config.Client(oauth2.NoContext, token) </ins> service, err := bigquery.New(client) if err != nil {", "commid": "kubernetes_pr_5934"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-986ebc5f1ee3014f101ca7c08d0a452a9f1e89012ba9ad9c3742f7a63611d2f5", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --Following link on sig-network page () is broken Link should be working Kubernetes version (use ):1.21 Cloud provider or hardware configuration:None OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/sig-network\n/sig network\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-6a1f500bb6b44fccb544909744180296fac074f66aaaf4224abfbedaba596cae", "text": "} // Refresh expired token. <del> if c.token.Expired() { </del> <ins> if !c.token.Valid() { </ins> token, service, err := connect() if err != nil { return nil, err", "commid": "kubernetes_pr_5934"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-667c03a1dc8f1ee7f1158d9381efb0236f75ce957c008d6835a5d4ca1b7b96b9", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --As described in issue , we found kubernetes have been running normally, but the control-plane nodes's metrics value of startTime is similar to the timestamp. Get the correct metrics of node As described in issue anything else we need to provide? As described in issue Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\n/remove-sig node /sig instrumentation /assign\nI think the issue is about Summary API having start time for node metric, but this timestamp is incorrect. This is node issue, not instrumentation. /sig node /remove-sig instrumentation /unassign\nWhen discussing adding node start time metric to /metrics/resource endpoint I remember that SIG Node response to this was that there is no good way to define node start time. I don't think we will be able to provide correct value here. As summary API is technically deprecated, it makes no sense to fix it. We should warn users against using it and wait for removal of Summary API.\nOkay, let's wait for the release of metrics-server v0.6.0\nDo you know if this is fixed in metrics server?\n/triage needs-information Can you please add info on name of timeserias and other steps to repro ti understand exactly what is needed here. Thank you!\nin metrics server v0.6.0, we will use /metrics/resource Kubelet endpoint instead summary API\nas issue described , the result is: for example : the startup time of the node test-us-west-1-control-plane-577lp is \"startTime\": \"2021-08-03T19:33:50Z\",, and timestamp reported by metrics is \"2021-08-03T19:34:36Z\", but as described, output from control plane node", "positive_passages": [{"docid": "doc-en-kubernetes-1db92e840964042ed863a0a90109d32c72cd1a9aab044836b761ab67e4cacfb9", "text": "apiVersion: apps/v1 kind: Deployment metadata: <del> name: metrics-server-v0.5.0 </del> <ins> name: metrics-server-v0.5.1 </ins> namespace: kube-system labels: k8s-app: metrics-server addonmanager.kubernetes.io/mode: Reconcile <del> version: v0.5.0 </del> <ins> version: v0.5.1 </ins> spec: selector: matchLabels: k8s-app: metrics-server <del> version: v0.5.0 </del> <ins> version: v0.5.1 </ins> template: metadata: name: metrics-server labels: k8s-app: metrics-server <del> version: v0.5.0 </del> <ins> version: v0.5.1 </ins> spec: securityContext: seccompProfile:", "commid": "kubernetes_pr_105263"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-667c03a1dc8f1ee7f1158d9381efb0236f75ce957c008d6835a5d4ca1b7b96b9", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --As described in issue , we found kubernetes have been running normally, but the control-plane nodes's metrics value of startTime is similar to the timestamp. Get the correct metrics of node As described in issue anything else we need to provide? As described in issue Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\n/remove-sig node /sig instrumentation /assign\nI think the issue is about Summary API having start time for node metric, but this timestamp is incorrect. This is node issue, not instrumentation. /sig node /remove-sig instrumentation /unassign\nWhen discussing adding node start time metric to /metrics/resource endpoint I remember that SIG Node response to this was that there is no good way to define node start time. I don't think we will be able to provide correct value here. As summary API is technically deprecated, it makes no sense to fix it. We should warn users against using it and wait for removal of Summary API.\nOkay, let's wait for the release of metrics-server v0.6.0\nDo you know if this is fixed in metrics server?\n/triage needs-information Can you please add info on name of timeserias and other steps to repro ti understand exactly what is needed here. Thank you!\nin metrics server v0.6.0, we will use /metrics/resource Kubelet endpoint instead summary API\nas issue described , the result is: for example : the startup time of the node test-us-west-1-control-plane-577lp is \"startTime\": \"2021-08-03T19:33:50Z\",, and timestamp reported by metrics is \"2021-08-03T19:34:36Z\", but as described, output from control plane node", "positive_passages": [{"docid": "doc-en-kubernetes-a1941efea21025550e37c756e6400362d07d6a1df0cc57faae88c298dbb95990", "text": "kubernetes.io/os: linux containers: - name: metrics-server <del> image: k8s.gcr.io/metrics-server/metrics-server:v0.5.0 </del> <ins> image: k8s.gcr.io/metrics-server/metrics-server:v0.5.1 </ins> command: - /metrics-server - --metric-resolution=30s", "commid": "kubernetes_pr_105263"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-667c03a1dc8f1ee7f1158d9381efb0236f75ce957c008d6835a5d4ca1b7b96b9", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --As described in issue , we found kubernetes have been running normally, but the control-plane nodes's metrics value of startTime is similar to the timestamp. Get the correct metrics of node As described in issue anything else we need to provide? As described in issue Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\n/remove-sig node /sig instrumentation /assign\nI think the issue is about Summary API having start time for node metric, but this timestamp is incorrect. This is node issue, not instrumentation. /sig node /remove-sig instrumentation /unassign\nWhen discussing adding node start time metric to /metrics/resource endpoint I remember that SIG Node response to this was that there is no good way to define node start time. I don't think we will be able to provide correct value here. As summary API is technically deprecated, it makes no sense to fix it. We should warn users against using it and wait for removal of Summary API.\nOkay, let's wait for the release of metrics-server v0.6.0\nDo you know if this is fixed in metrics server?\n/triage needs-information Can you please add info on name of timeserias and other steps to repro ti understand exactly what is needed here. Thank you!\nin metrics server v0.6.0, we will use /metrics/resource Kubelet endpoint instead summary API\nas issue described , the result is: for example : the startup time of the node test-us-west-1-control-plane-577lp is \"startTime\": \"2021-08-03T19:33:50Z\",, and timestamp reported by metrics is \"2021-08-03T19:34:36Z\", but as described, output from control plane node", "positive_passages": [{"docid": "doc-en-kubernetes-bc4558b981d99291b5ef500347b2bdf4922653aabd61d59efc483cfcc7627fea", "text": "- --memory={{ base_metrics_server_memory }} - --extra-memory={{ metrics_server_memory_per_node }}Mi - --threshold=5 <del> - --deployment=metrics-server-v0.5.0 </del> <ins> - --deployment=metrics-server-v0.5.1 </ins> - --container=metrics-server - --poll-period=30000 - --estimator=exponential", "commid": "kubernetes_pr_105263"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e7c38fb3a79882bd75a0e0f99bc9ad04f971dd72570ffcd22429185f154951f1", "query": "I'm seeing a panic in kube apiserver (see stack trace below). It appears to be linked to the migration away from Hashicorp's LRU implementation to in The Hashicorp implementation is thread-safe, however the forked copy in utils is not. See the comment here Looking at the utils PR, I see there's actually a wrapper around the thread unsafe LRU cache, and that's being used here: The LRU isn't a lot of code and I think I've convinced myself the locking works fine, so not sure why the element Value is coming back as nil instead of *entry. Stack trace: Not to panic Not sure, but I see it in our CI fairly often Kubernetes version (use ): 1.22Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/cc\n/sig api-machinery\nif Add(key, nil) was called, that could set the value to nil in an existing object... does that happen?\nThe nil value we're hitting is on the linked list element, which is managed by the LRU code, not the user-facing value given in -- that gets saved The panic we hit is , where it tries to re-cast the LL element value back to the lru entry type. I don't see how that can happen.\nThe actual cache is perfectly happy with nil values:\nFrom is mutating since it moves an element to the front when it's accessed. Thanks !\nwould you consider sending a PR to fix it? /assign /triage accepted\nis the PR to fix", "positive_passages": [{"docid": "doc-en-kubernetes-6299537b75e46cd595a6a56dfe8089da66fc514406585915b706fee60bca4490", "text": "log.Printf(\"Error parsing response (%#v): %s\", response, err) return err } <del> log.Printf(\"Got initial state from etcd: %+v\", manifests) </del> <ins> log.Printf(\"Got state from etcd: %+v\", manifests) </ins> updateChannel <- manifestUpdate{etcdSource, manifests} return nil }", "commid": "kubernetes_pr_216"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e7c38fb3a79882bd75a0e0f99bc9ad04f971dd72570ffcd22429185f154951f1", "query": "I'm seeing a panic in kube apiserver (see stack trace below). It appears to be linked to the migration away from Hashicorp's LRU implementation to in The Hashicorp implementation is thread-safe, however the forked copy in utils is not. See the comment here Looking at the utils PR, I see there's actually a wrapper around the thread unsafe LRU cache, and that's being used here: The LRU isn't a lot of code and I think I've convinced myself the locking works fine, so not sure why the element Value is coming back as nil instead of *entry. Stack trace: Not to panic Not sure, but I see it in our CI fairly often Kubernetes version (use ): 1.22Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/cc\n/sig api-machinery\nif Add(key, nil) was called, that could set the value to nil in an existing object... does that happen?\nThe nil value we're hitting is on the linked list element, which is managed by the LRU code, not the user-facing value given in -- that gets saved The panic we hit is , where it tries to re-cast the LL element value back to the lru entry type. I don't see how that can happen.\nThe actual cache is perfectly happy with nil values:\nFrom is mutating since it moves an element to the front when it's accessed. Thanks !\nwould you consider sending a PR to fix it? /assign /triage accepted\nis the PR to fix", "positive_passages": [{"docid": "doc-en-kubernetes-f7ec3dd4bad84d9dc9c82d273658469bc089e47124cf1d4c8597cbd3d251fab3", "text": "defer util.HandleCrash() for { watchResponse := <-watchChannel <del> log.Printf(\"Got change: %#v\", watchResponse) </del> // This means the channel has been closed. if watchResponse == nil { return } <ins> log.Printf(\"Got etcd change: %#v\", watchResponse) </ins> manifests, err := kl.extractFromEtcd(watchResponse) if err != nil { log.Printf(\"Error handling response from etcd: %#v\", err)", "commid": "kubernetes_pr_216"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e7c38fb3a79882bd75a0e0f99bc9ad04f971dd72570ffcd22429185f154951f1", "query": "I'm seeing a panic in kube apiserver (see stack trace below). It appears to be linked to the migration away from Hashicorp's LRU implementation to in The Hashicorp implementation is thread-safe, however the forked copy in utils is not. See the comment here Looking at the utils PR, I see there's actually a wrapper around the thread unsafe LRU cache, and that's being used here: The LRU isn't a lot of code and I think I've convinced myself the locking works fine, so not sure why the element Value is coming back as nil instead of *entry. Stack trace: Not to panic Not sure, but I see it in our CI fairly often Kubernetes version (use ): 1.22Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/cc\n/sig api-machinery\nif Add(key, nil) was called, that could set the value to nil in an existing object... does that happen?\nThe nil value we're hitting is on the linked list element, which is managed by the LRU code, not the user-facing value given in -- that gets saved The panic we hit is , where it tries to re-cast the LL element value back to the lru entry type. I don't see how that can happen.\nThe actual cache is perfectly happy with nil values:\nFrom is mutating since it moves an element to the front when it's accessed. Thanks !\nwould you consider sending a PR to fix it? /assign /triage accepted\nis the PR to fix", "positive_passages": [{"docid": "doc-en-kubernetes-60910d6ca096282709b6601a50655240952dc1205af410f307358e581d24f2e5", "text": "// Sync the configured list of containers (desired state) with the host current state func (kl *Kubelet) SyncManifests(config []api.ContainerManifest) error { <del> log.Printf(\"Desired:%#v\", config) </del> <ins> log.Printf(\"Desired: %#v\", config) </ins> var err error desired := map[string]bool{} for _, manifest := range config {", "commid": "kubernetes_pr_216"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e7c38fb3a79882bd75a0e0f99bc9ad04f971dd72570ffcd22429185f154951f1", "query": "I'm seeing a panic in kube apiserver (see stack trace below). It appears to be linked to the migration away from Hashicorp's LRU implementation to in The Hashicorp implementation is thread-safe, however the forked copy in utils is not. See the comment here Looking at the utils PR, I see there's actually a wrapper around the thread unsafe LRU cache, and that's being used here: The LRU isn't a lot of code and I think I've convinced myself the locking works fine, so not sure why the element Value is coming back as nil instead of *entry. Stack trace: Not to panic Not sure, but I see it in our CI fairly often Kubernetes version (use ): 1.22Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/cc\n/sig api-machinery\nif Add(key, nil) was called, that could set the value to nil in an existing object... does that happen?\nThe nil value we're hitting is on the linked list element, which is managed by the LRU code, not the user-facing value given in -- that gets saved The panic we hit is , where it tries to re-cast the LL element value back to the lru entry type. I don't see how that can happen.\nThe actual cache is perfectly happy with nil values:\nFrom is mutating since it moves an element to the front when it's accessed. Thanks !\nwould you consider sending a PR to fix it? /assign /triage accepted\nis the PR to fix", "positive_passages": [{"docid": "doc-en-kubernetes-9e463620af1cee186461adf80df3db4be130a743bf4b585ef52071b9458a04d9", "text": "continue } if !exists { <del> log.Printf(\"Network container doesn't exit, creating\") </del> <ins> log.Printf(\"Network container doesn't exist, creating\") </ins> netName, err = kl.createNetworkContainer(&manifest) if err != nil { log.Printf(\"Failed to create network container: %#v\", err)", "commid": "kubernetes_pr_216"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e7c38fb3a79882bd75a0e0f99bc9ad04f971dd72570ffcd22429185f154951f1", "query": "I'm seeing a panic in kube apiserver (see stack trace below). It appears to be linked to the migration away from Hashicorp's LRU implementation to in The Hashicorp implementation is thread-safe, however the forked copy in utils is not. See the comment here Looking at the utils PR, I see there's actually a wrapper around the thread unsafe LRU cache, and that's being used here: The LRU isn't a lot of code and I think I've convinced myself the locking works fine, so not sure why the element Value is coming back as nil instead of *entry. Stack trace: Not to panic Not sure, but I see it in our CI fairly often Kubernetes version (use ): 1.22Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:\n/cc\n/sig api-machinery\nif Add(key, nil) was called, that could set the value to nil in an existing object... does that happen?\nThe nil value we're hitting is on the linked list element, which is managed by the LRU code, not the user-facing value given in -- that gets saved The panic we hit is , where it tries to re-cast the LL element value back to the lru entry type. I don't see how that can happen.\nThe actual cache is perfectly happy with nil values:\nFrom is mutating since it moves an element to the front when it's accessed. Thanks !\nwould you consider sending a PR to fix it? /assign /triage accepted\nis the PR to fix", "positive_passages": [{"docid": "doc-en-kubernetes-8b36924118ca1405be3843d60357d799228ee89c61c4501dd97c8fd3f1b4fea0", "text": "} } existingContainers, _ := kl.ListContainers() <del> log.Printf(\"Existing:n%#v Desired: %#v\", existingContainers, desired) </del> <ins> log.Printf(\"Existing: %#v Desired: %#v\", existingContainers, desired) </ins> for _, container := range existingContainers { // Skip containers that we didn't create to allow users to manually // spin up their own containers if they want.", "commid": "kubernetes_pr_216"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-777ad7d72db143a151a24bf09007bd12775400d0d01897525cdcd0ecea974fac", "query": "SSH'ed into a GKE node running on GCP and was welcomed by following MOTD message: a) Noticed download link is not working, I suspect this storage bucket is no longer used (?) b) Link to get Kuberntes source version does not work: This should be following (without ) Working links :) This is defined in the \"configure-\" file bellow: As this seems GCP specific (IIUC), I think filtering \"-gke.501\" will fix part a) For b) I am not sure what the correct download link should be Kubernetes version: Kubernetes v1.18.20-gke.501 Cloud provider: GCP OS: COS\nPull request to remove \"-gke.\" from link to Github to make it valid. Regarding the wrong download link to GKE source code release, I noticed that: When running on GKE the link has (GCS storage bucket name) while in OOS Kubernetes it is . (So GKE is patched here) I think is depreciated and replaced by but in either case link don' work. It's unclear how one can download the source code.\n/sig cloud-provider release for triagingnot sure if the link is maintained by release team /area provider/gcp\nWas able to confirm the right download location ( GCS bucket) to download GKE source release. Submitted separate PR to fix the URL.\n/assign /triage accepted\nThis is an related to the GKE product. I've filed this to the public :\n/close\nClosing this issue. <detailsIn response to : /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-ffc927f4c03eea1d4bac152a493cd2cf93f7da342a71bdf1f045ed533c7b8356", "text": "https://storage.googleapis.com/kubernetes-release/release/${version}/kubernetes-src.tar.gz It is based on the Kubernetes source at: <del> https://github.com/kubernetes/kubernetes/tree/${gitref} </del> <ins> https://github.com/kubernetes/kubernetes/tree/${gitref/-gke.*/} </ins> ${devel} For Kubernetes copyright and licensing information, see: /home/kubernetes/LICENSES", "commid": "kubernetes_pr_104519"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c07e91eb7d66ee92c3b6d05f523cece58039dffcf1123c44ba752c30922deab", "query": "N/A [sig-node] NodeProblemDetector: N/A https://prow- Not cgroupv2 compatible when access cpu and memory data\n/sig node\nHi, can i work on this ?\nSure. Thanks\n/assign\n/triage accepted\n/priority important-soon\n/cc\nare you still working on this? Were you able to setup environment to repro the test failure? Let us know if you need any help. Thanks!\nSorry for the delay, I followed the wrong guide and ended up getting stuck. But now I have managed to set it up. Please give me few more days to work on it.\nThanks Feel free to reach out here or on slack if you need any help, thanks for working on this!\n/retitle Make nodeproblemdetector test cgroupv2 compatible\nFailing job:\nTestgrid:", "positive_passages": [{"docid": "doc-en-kubernetes-f7ff62d616972738022bbb109de62d090adbb925e77279916310f81d743b548d", "text": "} func getMemoryStat(f *framework.Framework, host string) (rss, workingSet float64) { <del> memCmd := \"cat /sys/fs/cgroup/memory/system.slice/node-problem-detector.service/memory.usage_in_bytes && cat /sys/fs/cgroup/memory/system.slice/node-problem-detector.service/memory.stat\" </del> <ins> var memCmd string isCgroupV2 := isHostRunningCgroupV2(f, host) if isCgroupV2 { memCmd = \"cat /sys/fs/cgroup/system.slice/node-problem-detector.service/memory.current && cat /sys/fs/cgroup/system.slice/node-problem-detector.service/memory.stat\" } else { memCmd = \"cat /sys/fs/cgroup/memory/system.slice/node-problem-detector.service/memory.usage_in_bytes && cat /sys/fs/cgroup/memory/system.slice/node-problem-detector.service/memory.stat\" } </ins> result, err := e2essh.SSH(memCmd, host, framework.TestContext.Provider) framework.ExpectNoError(err) framework.ExpectEqual(result.Code, 0)", "commid": "kubernetes_pr_105755"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c07e91eb7d66ee92c3b6d05f523cece58039dffcf1123c44ba752c30922deab", "query": "N/A [sig-node] NodeProblemDetector: N/A https://prow- Not cgroupv2 compatible when access cpu and memory data\n/sig node\nHi, can i work on this ?\nSure. Thanks\n/assign\n/triage accepted\n/priority important-soon\n/cc\nare you still working on this? Were you able to setup environment to repro the test failure? Let us know if you need any help. Thanks!\nSorry for the delay, I followed the wrong guide and ended up getting stuck. But now I have managed to set it up. Please give me few more days to work on it.\nThanks Feel free to reach out here or on slack if you need any help, thanks for working on this!\n/retitle Make nodeproblemdetector test cgroupv2 compatible\nFailing job:\nTestgrid:", "positive_passages": [{"docid": "doc-en-kubernetes-3efdca3d7f3f8a011b4c9c0e64c2312418fac47ef7639a403c56b324c2c90619", "text": "memoryUsage, err := strconv.ParseFloat(lines[0], 64) framework.ExpectNoError(err) <ins> var rssToken, inactiveFileToken string if isCgroupV2 { // Use Anon memory for RSS as cAdvisor on cgroupv2 // see https://github.com/google/cadvisor/blob/a9858972e75642c2b1914c8d5428e33e6392c08a/container/libcontainer/handler.go#L799 rssToken = \"anon\" inactiveFileToken = \"inactive_file\" } else { rssToken = \"total_rss\" inactiveFileToken = \"total_inactive_file\" } </ins> var totalInactiveFile float64 for _, line := range lines[1:] { tokens := strings.Split(line, \" \") <del> if tokens[0] == \"total_rss\" { </del> <ins> if tokens[0] == rssToken { </ins> rss, err = strconv.ParseFloat(tokens[1], 64) framework.ExpectNoError(err) } <del> if tokens[0] == \"total_inactive_file\" { </del> <ins> if tokens[0] == inactiveFileToken { </ins> totalInactiveFile, err = strconv.ParseFloat(tokens[1], 64) framework.ExpectNoError(err) }", "commid": "kubernetes_pr_105755"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c07e91eb7d66ee92c3b6d05f523cece58039dffcf1123c44ba752c30922deab", "query": "N/A [sig-node] NodeProblemDetector: N/A https://prow- Not cgroupv2 compatible when access cpu and memory data\n/sig node\nHi, can i work on this ?\nSure. Thanks\n/assign\n/triage accepted\n/priority important-soon\n/cc\nare you still working on this? Were you able to setup environment to repro the test failure? Let us know if you need any help. Thanks!\nSorry for the delay, I followed the wrong guide and ended up getting stuck. But now I have managed to set it up. Please give me few more days to work on it.\nThanks Feel free to reach out here or on slack if you need any help, thanks for working on this!\n/retitle Make nodeproblemdetector test cgroupv2 compatible\nFailing job:\nTestgrid:", "positive_passages": [{"docid": "doc-en-kubernetes-6bf6b78f6e63368a7f16114587d7c81b66cbd0ef30b977c6f48473b0894682eb", "text": "} func getCPUStat(f *framework.Framework, host string) (usage, uptime float64) { <del> cpuCmd := \"cat /sys/fs/cgroup/cpu/system.slice/node-problem-detector.service/cpuacct.usage && cat /proc/uptime | awk '{print $1}'\" </del> <ins> var cpuCmd string if isHostRunningCgroupV2(f, host) { cpuCmd = \" cat /sys/fs/cgroup/cpu.stat | grep 'usage_usec' | sed 's/[^0-9]*//g' && cat /proc/uptime | awk '{print $1}'\" } else { cpuCmd = \"cat /sys/fs/cgroup/cpu/system.slice/node-problem-detector.service/cpuacct.usage && cat /proc/uptime | awk '{print $1}'\" } </ins> result, err := e2essh.SSH(cpuCmd, host, framework.TestContext.Provider) framework.ExpectNoError(err) framework.ExpectEqual(result.Code, 0)", "commid": "kubernetes_pr_105755"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0c07e91eb7d66ee92c3b6d05f523cece58039dffcf1123c44ba752c30922deab", "query": "N/A [sig-node] NodeProblemDetector: N/A https://prow- Not cgroupv2 compatible when access cpu and memory data\n/sig node\nHi, can i work on this ?\nSure. Thanks\n/assign\n/triage accepted\n/priority important-soon\n/cc\nare you still working on this? Were you able to setup environment to repro the test failure? Let us know if you need any help. Thanks!\nSorry for the delay, I followed the wrong guide and ended up getting stuck. But now I have managed to set it up. Please give me few more days to work on it.\nThanks Feel free to reach out here or on slack if you need any help, thanks for working on this!\n/retitle Make nodeproblemdetector test cgroupv2 compatible\nFailing job:\nTestgrid:", "positive_passages": [{"docid": "doc-en-kubernetes-50e13d61eba1a90973b7a8a15336d0853f022952e4eaea242723b1d75d68d6b1", "text": "return } <ins> func isHostRunningCgroupV2(f *framework.Framework, host string) bool { result, err := e2essh.SSH(\"stat -fc %T /sys/fs/cgroup/\", host, framework.TestContext.Provider) framework.ExpectNoError(err) framework.ExpectEqual(result.Code, 0) // 0x63677270 == CGROUP2_SUPER_MAGIC // https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v2.html return strings.Contains(result.Stdout, \"cgroup2\") || strings.Contains(result.Stdout, \"0x63677270\") } </ins> func getNpdPodStat(f *framework.Framework, nodeName string) (cpuUsage, rss, workingSet float64) { summary, err := e2ekubelet.GetStatsSummary(f.ClientSet, nodeName) framework.ExpectNoError(err)", "commid": "kubernetes_pr_105755"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a25bba4518f771786855331651a60fed00feaa6f22555c429465b3e593778196", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --ci-cos-cgroupv2-containerd-node-e2e <!-- You can identify the SIG from the \"prowjobconfigurl\" on the testgrid dashboard for a test --<!-- Please see the deflaking doc () for more guidance! --/sig node\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : #### Which jobs are flaking: links to appreciated links to specific failures in spyglass appreciated </details\nOn cgroupv2, it looks like like the number of for cgroup is sometimes higher than is currently expected in the test. We currently expect this however, in a few runs of the test we've seen We may need to adjust this value similar as was done in for\n/cc\nyes, good idea. I think we need to adjust the PageFaults test as well. I've opened a PR:\n/assign /triage accepted /area test /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-798f477312544883e9ff4aa9ed96cb4c466a1969513b18ad159158640097aeb1", "text": "\"UserDefinedMetrics\": gomega.BeEmpty(), }) } <ins> expectedPageFaultsUpperBound := 1000000 </ins> expectedMajorPageFaultsUpperBound := 10 if IsCgroup2UnifiedMode() { <del> expectedMajorPageFaultsUpperBound = 1000 </del> <ins> // On cgroupv2 these stats are recursive, so make sure they are at least like the value set // above for the container. expectedPageFaultsUpperBound = 1e9 expectedMajorPageFaultsUpperBound = 100000 </ins> } podsContExpectations := sysContExpectations().(*gstruct.FieldsMatcher)", "commid": "kubernetes_pr_105313"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a25bba4518f771786855331651a60fed00feaa6f22555c429465b3e593778196", "query": "<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --ci-cos-cgroupv2-containerd-node-e2e <!-- You can identify the SIG from the \"prowjobconfigurl\" on the testgrid dashboard for a test --<!-- Please see the deflaking doc () for more guidance! --/sig node\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : #### Which jobs are flaking: links to appreciated links to specific failures in spyglass appreciated </details\nOn cgroupv2, it looks like like the number of for cgroup is sometimes higher than is currently expected in the test. We currently expect this however, in a few runs of the test we've seen We may need to adjust this value similar as was done in for\n/cc\nyes, good idea. I think we need to adjust the PageFaults test as well. I've opened a PR:\n/assign /triage accepted /area test /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-3f648b3309d5602371b7dd3d74c19b5b95ed64486e80bec1a1154c7de648adc2", "text": "\"UsageBytes\":      bounded(10*e2evolume.Kb, memoryLimit), \"WorkingSetBytes\": bounded(10*e2evolume.Kb, memoryLimit), \"RSSBytes\":        bounded(1*e2evolume.Kb, memoryLimit), <del> \"PageFaults\":      bounded(0, 1000000), </del> <ins> \"PageFaults\":      bounded(0, expectedPageFaultsUpperBound), </ins> \"MajorPageFaults\": bounded(0, expectedMajorPageFaultsUpperBound), }) runtimeContExpectations := sysContExpectations().(*gstruct.FieldsMatcher)", "commid": "kubernetes_pr_105313"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b0aaebc10595b2310d879ccfd264c1dbafd916f75ddeabf532337c80b30d324", "query": "pull-kubernetes-unit TestUpdatePodWithTerminatedPod 10/8 (when it was introduced in ) No response No response Running with shows immediate failures: /sig node\n/cc\n/assign I will try to fix this. At present, I found that adding before the status check will definitely trigger the error\nLooks like it stopped flaking? Was this fixed? /triage accepted\nIf the test runs fast enough, it won't failed but it's not guaranteed. fixed in\nIt's still flaking\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nthis started flaking more on 3/21 - adding to the milestone for investigation to make sure something didn't regress here\ncc\n/unassign /assign", "positive_passages": [{"docid": "doc-en-kubernetes-22e10fd6596ec120fe3a0fcd9b4cf1e7e66de116e53efd9a289d39e216284036", "text": "func TestUpdatePodWithTerminatedPod(t *testing.T) { podWorkers, _ := createPodWorkers() terminatedPod := newPodWithPhase(\"0000-0000-0000\", \"done-pod\", v1.PodSucceeded) <del> runningPod := &kubecontainer.Pod{ID: \"0000-0000-0001\", Name: \"done-pod\"} </del> <ins> orphanedPod := &kubecontainer.Pod{ID: \"0000-0000-0001\", Name: \"orphaned-pod\"} </ins> pod := newPod(\"0000-0000-0002\", \"running-pod\") podWorkers.UpdatePod(UpdatePodOptions{", "commid": "kubernetes_pr_105599"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4b0aaebc10595b2310d879ccfd264c1dbafd916f75ddeabf532337c80b30d324", "query": "pull-kubernetes-unit TestUpdatePodWithTerminatedPod 10/8 (when it was introduced in ) No response No response Running with shows immediate failures: /sig node\n/cc\n/assign I will try to fix this. At present, I found that adding before the status check will definitely trigger the error\nLooks like it stopped flaking? Was this fixed? /triage accepted\nIf the test runs fast enough, it won't failed but it's not guaranteed. fixed in\nIt's still flaking\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nthis started flaking more on 3/21 - adding to the milestone for investigation to make sure something didn't regress here\ncc\n/unassign /assign", "positive_passages": [{"docid": "doc-en-kubernetes-80046fa1778f3ee8ebfa9bffc37c2a1f4dd35f9065a795b8c616d008d5831d3e", "text": "}) podWorkers.UpdatePod(UpdatePodOptions{ UpdateType: kubetypes.SyncPodKill, <del> RunningPod: runningPod, </del> <ins> RunningPod: orphanedPod, </ins> }) <ins> drainAllWorkers(podWorkers) </ins> if podWorkers.IsPodKnownTerminated(pod.UID) == true { t.Errorf(\"podWorker state should not be terminated\") } if podWorkers.IsPodKnownTerminated(terminatedPod.UID) == false { t.Errorf(\"podWorker state should be terminated\") } <del> if podWorkers.IsPodKnownTerminated(runningPod.ID) == true { t.Errorf(\"podWorker state should not be marked terminated for a running pod\") </del> <ins> if podWorkers.IsPodKnownTerminated(orphanedPod.ID) == false { t.Errorf(\"podWorker state should be terminated for orphaned pod\") </ins> } }", "commid": "kubernetes_pr_105599"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4bf9b19d24a261d47cc6eedfe299569e554e3becd9dcdf9c665d53af5c9e2eb", "query": "As per the PRs kubernetes/kubernetes kubernetes/kubernetes, the defaulting behaviour of the pod exec parameters had been changed however in the code there is a comment where it is mentioned it defaults to True The comment about the default value must be removed and the openapi spec must be fixed Present in the file as comment and also in the OpenApiSpec swagger If this issue seems appropriate can I take it up please <details</details<details</details<details</details<details</details<details</details<details</details\n/sig docs\n/sig node\n/assign\n/assign\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted </details\n/kind documentation", "positive_passages": [{"docid": "doc-en-kubernetes-9c9f997aeac05a8507615c3ba44e151e73c848a81fd6d9db9cb007fe6d2c8970", "text": "\"uniqueItems\": true }, { <del> \"description\": \"Redirect the standard error stream of the pod for this call. Defaults to true.\", </del> <ins> \"description\": \"Redirect the standard error stream of the pod for this call.\", </ins> \"in\": \"query\", \"name\": \"stderr\", \"type\": \"boolean\",", "commid": "kubernetes_pr_105726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4bf9b19d24a261d47cc6eedfe299569e554e3becd9dcdf9c665d53af5c9e2eb", "query": "As per the PRs kubernetes/kubernetes kubernetes/kubernetes, the defaulting behaviour of the pod exec parameters had been changed however in the code there is a comment where it is mentioned it defaults to True The comment about the default value must be removed and the openapi spec must be fixed Present in the file as comment and also in the OpenApiSpec swagger If this issue seems appropriate can I take it up please <details</details<details</details<details</details<details</details<details</details<details</details\n/sig docs\n/sig node\n/assign\n/assign\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted </details\n/kind documentation", "positive_passages": [{"docid": "doc-en-kubernetes-981247e0f32454e69574c79de530d8ad36bd2ca74536edcdfb469a21f25b7b29", "text": "\"uniqueItems\": true }, { <del> \"description\": \"Redirect the standard output stream of the pod for this call. Defaults to true.\", </del> <ins> \"description\": \"Redirect the standard output stream of the pod for this call.\", </ins> \"in\": \"query\", \"name\": \"stdout\", \"type\": \"boolean\",", "commid": "kubernetes_pr_105726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4bf9b19d24a261d47cc6eedfe299569e554e3becd9dcdf9c665d53af5c9e2eb", "query": "As per the PRs kubernetes/kubernetes kubernetes/kubernetes, the defaulting behaviour of the pod exec parameters had been changed however in the code there is a comment where it is mentioned it defaults to True The comment about the default value must be removed and the openapi spec must be fixed Present in the file as comment and also in the OpenApiSpec swagger If this issue seems appropriate can I take it up please <details</details<details</details<details</details<details</details<details</details<details</details\n/sig docs\n/sig node\n/assign\n/assign\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted </details\n/kind documentation", "positive_passages": [{"docid": "doc-en-kubernetes-adbe46fc6a82fd9ddd68dcf851089e7f033af547693b4230f492e1890b5a69f3", "text": "optional bool stdin = 1; // Redirect the standard output stream of the pod for this call. <del> // Defaults to true. </del> // +optional optional bool stdout = 2; // Redirect the standard error stream of the pod for this call. <del> // Defaults to true. </del> // +optional optional bool stderr = 3;", "commid": "kubernetes_pr_105726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4bf9b19d24a261d47cc6eedfe299569e554e3becd9dcdf9c665d53af5c9e2eb", "query": "As per the PRs kubernetes/kubernetes kubernetes/kubernetes, the defaulting behaviour of the pod exec parameters had been changed however in the code there is a comment where it is mentioned it defaults to True The comment about the default value must be removed and the openapi spec must be fixed Present in the file as comment and also in the OpenApiSpec swagger If this issue seems appropriate can I take it up please <details</details<details</details<details</details<details</details<details</details<details</details\n/sig docs\n/sig node\n/assign\n/assign\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted </details\n/kind documentation", "positive_passages": [{"docid": "doc-en-kubernetes-007abfc00af047191756e7b0093f388b261fc0cce4e3b55fe8e357179357b9dd", "text": "Stdin bool `json:\"stdin,omitempty\" protobuf:\"varint,1,opt,name=stdin\"` // Redirect the standard output stream of the pod for this call. <del> // Defaults to true. </del> // +optional Stdout bool `json:\"stdout,omitempty\" protobuf:\"varint,2,opt,name=stdout\"` // Redirect the standard error stream of the pod for this call. <del> // Defaults to true. </del> // +optional Stderr bool `json:\"stderr,omitempty\" protobuf:\"varint,3,opt,name=stderr\"`", "commid": "kubernetes_pr_105726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4bf9b19d24a261d47cc6eedfe299569e554e3becd9dcdf9c665d53af5c9e2eb", "query": "As per the PRs kubernetes/kubernetes kubernetes/kubernetes, the defaulting behaviour of the pod exec parameters had been changed however in the code there is a comment where it is mentioned it defaults to True The comment about the default value must be removed and the openapi spec must be fixed Present in the file as comment and also in the OpenApiSpec swagger If this issue seems appropriate can I take it up please <details</details<details</details<details</details<details</details<details</details<details</details\n/sig docs\n/sig node\n/assign\n/assign\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted </details\n/kind documentation", "positive_passages": [{"docid": "doc-en-kubernetes-e9057fe5739d638c786f5acee94b52a1663362d92346f244bb276b060ec7b316", "text": "var map_PodExecOptions = map[string]string{ \"\":          \"PodExecOptions is the query options to a Pod's remote exec call.\", \"stdin\":     \"Redirect the standard input stream of the pod for this call. Defaults to false.\", <del> \"stdout\":    \"Redirect the standard output stream of the pod for this call. Defaults to true.\", \"stderr\":    \"Redirect the standard error stream of the pod for this call. Defaults to true.\", </del> <ins> \"stdout\":    \"Redirect the standard output stream of the pod for this call.\", \"stderr\":    \"Redirect the standard error stream of the pod for this call.\", </ins> \"tty\":       \"TTY if true indicates that a tty will be allocated for the exec call. Defaults to false.\", \"container\": \"Container in which to execute the command. Defaults to only container if there is only one container in the pod.\", \"command\":   \"Command is the remote command to execute. argv array. Not executed within a shell.\",", "commid": "kubernetes_pr_105726"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-768e64f47ada6db7cc30fd697f7a40f044b4c151072bc930e0f353b7e0a147a6", "query": "runs in a container. Talos sets OOM score to -450 for the kubelet container and passes in the kubelet config. End result is that OOM score adj is -999 though. should have configured OOM score . Source code analysis. First, OOM score is set correctly from the config (flags): But then, in container manager, OOM score is reset to -999 via the following: This function should skip action if the PID is not running on the host: But the function looks to be confusing: When kubelet runs in a container with PID namespace shared with the host, kubelet's PID namespace will be equal to PID 1 namespace. If kubelet runs in a container with unshared PID namespace, kubelet's PID is 1 and its PID namespace is identical to PID 1 namespace. So how this function can return ever? Moreover, function is always setting OOM score to a hardcoded constant -999 ignoring configuation (). No response <details, reproduced with 1.22. </details<details</details<details</details<details</details<details</details<details</details\n/sig node\n/triage accepted\n/assign\nI don't think this method needs to change... I have make a draft PR for the default value to use the flag if present, but I would like more time to add some testing. Maybe you can have a look: ?\nThanks, this PR looks good to me, as it's going to set the OOM score to the configured value. And in our case kubelet runs in a container (not on the host, with proper OOM score via OCI spec), so this code should be even skipped, not sure how this can be addressed.\nneither do I...\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-cae769ae8d5340c601cae948407294c4183503fa9ce98f6a8257412452138a58", "text": "RuntimeCgroupsName:    s.RuntimeCgroups, SystemCgroupsName:     s.SystemCgroups, KubeletCgroupsName:    s.KubeletCgroups, <ins> KubeletOOMScoreAdj:    s.OOMScoreAdj, </ins> CgroupsPerQOS:         s.CgroupsPerQOS, CgroupRoot:            s.CgroupRoot, CgroupDriver:          s.CgroupDriver,", "commid": "kubernetes_pr_106082"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-768e64f47ada6db7cc30fd697f7a40f044b4c151072bc930e0f353b7e0a147a6", "query": "runs in a container. Talos sets OOM score to -450 for the kubelet container and passes in the kubelet config. End result is that OOM score adj is -999 though. should have configured OOM score . Source code analysis. First, OOM score is set correctly from the config (flags): But then, in container manager, OOM score is reset to -999 via the following: This function should skip action if the PID is not running on the host: But the function looks to be confusing: When kubelet runs in a container with PID namespace shared with the host, kubelet's PID namespace will be equal to PID 1 namespace. If kubelet runs in a container with unshared PID namespace, kubelet's PID is 1 and its PID namespace is identical to PID 1 namespace. So how this function can return ever? Moreover, function is always setting OOM score to a hardcoded constant -999 ignoring configuation (). No response <details, reproduced with 1.22. </details<details</details<details</details<details</details<details</details<details</details\n/sig node\n/triage accepted\n/assign\nI don't think this method needs to change... I have make a draft PR for the default value to use the flag if present, but I would like more time to add some testing. Maybe you can have a look: ?\nThanks, this PR looks good to me, as it's going to set the OOM score to the configured value. And in our case kubelet runs in a container (not on the host, with proper OOM score via OCI spec), so this code should be even skipped, not sure how this can be addressed.\nneither do I...\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-4f5e4d69119685fe0acefa00ad4a6d0e209f7e0004a344a7a97356e506702b1a", "text": "RuntimeCgroupsName    string SystemCgroupsName     string KubeletCgroupsName    string <ins> KubeletOOMScoreAdj    int32 </ins> ContainerRuntime      string CgroupsPerQOS         bool CgroupRoot            string", "commid": "kubernetes_pr_106082"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-768e64f47ada6db7cc30fd697f7a40f044b4c151072bc930e0f353b7e0a147a6", "query": "runs in a container. Talos sets OOM score to -450 for the kubelet container and passes in the kubelet config. End result is that OOM score adj is -999 though. should have configured OOM score . Source code analysis. First, OOM score is set correctly from the config (flags): But then, in container manager, OOM score is reset to -999 via the following: This function should skip action if the PID is not running on the host: But the function looks to be confusing: When kubelet runs in a container with PID namespace shared with the host, kubelet's PID namespace will be equal to PID 1 namespace. If kubelet runs in a container with unshared PID namespace, kubelet's PID is 1 and its PID namespace is identical to PID 1 namespace. So how this function can return ever? Moreover, function is always setting OOM score to a hardcoded constant -999 ignoring configuation (). No response <details, reproduced with 1.22. </details<details</details<details</details<details</details<details</details<details</details\n/sig node\n/triage accepted\n/assign\nI don't think this method needs to change... I have make a draft PR for the default value to use the flag if present, but I would like more time to add some testing. Maybe you can have a look: ?\nThanks, this PR looks good to me, as it's going to set the OOM score to the configured value. And in our case kubelet runs in a container (not on the host, with proper OOM score via OCI spec), so this code should be even skipped, not sure how this can be addressed.\nneither do I...\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-b0fbbb2f369450db958d014c5291eb90e2f2fbbac837ec0896f543b0a98aec8b", "text": "kubecontainer \"k8s.io/kubernetes/pkg/kubelet/container\" \"k8s.io/kubernetes/pkg/kubelet/lifecycle\" \"k8s.io/kubernetes/pkg/kubelet/pluginmanager/cache\" <del> \"k8s.io/kubernetes/pkg/kubelet/qos\" </del> \"k8s.io/kubernetes/pkg/kubelet/stats/pidlimit\" \"k8s.io/kubernetes/pkg/kubelet/status\" schedulerframework \"k8s.io/kubernetes/pkg/scheduler/framework\"", "commid": "kubernetes_pr_106082"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-768e64f47ada6db7cc30fd697f7a40f044b4c151072bc930e0f353b7e0a147a6", "query": "runs in a container. Talos sets OOM score to -450 for the kubelet container and passes in the kubelet config. End result is that OOM score adj is -999 though. should have configured OOM score . Source code analysis. First, OOM score is set correctly from the config (flags): But then, in container manager, OOM score is reset to -999 via the following: This function should skip action if the PID is not running on the host: But the function looks to be confusing: When kubelet runs in a container with PID namespace shared with the host, kubelet's PID namespace will be equal to PID 1 namespace. If kubelet runs in a container with unshared PID namespace, kubelet's PID is 1 and its PID namespace is identical to PID 1 namespace. So how this function can return ever? Moreover, function is always setting OOM score to a hardcoded constant -999 ignoring configuation (). No response <details, reproduced with 1.22. </details<details</details<details</details<details</details<details</details<details</details\n/sig node\n/triage accepted\n/assign\nI don't think this method needs to change... I have make a draft PR for the default value to use the flag if present, but I would like more time to add some testing. Maybe you can have a look: ?\nThanks, this PR looks good to me, as it's going to set the OOM score to the configured value. And in our case kubelet runs in a container (not on the host, with proper OOM score via OCI spec), so this code should be even skipped, not sure how this can be addressed.\nneither do I...\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-bc0f566ea046f9936dc3ef1eefa6ae91c8202db3ec81afe4df6991a7b03cc881", "text": "} cont.ensureStateFunc = func(_ cgroups.Manager) error { <del> return ensureProcessInContainerWithOOMScore(os.Getpid(), qos.KubeletOOMScoreAdj, cont.manager) </del> <ins> return ensureProcessInContainerWithOOMScore(os.Getpid(), int(cm.KubeletOOMScoreAdj), cont.manager) </ins> } systemContainers = append(systemContainers, cont) } else { cm.periodicTasks = append(cm.periodicTasks, func() { <del> if err := ensureProcessInContainerWithOOMScore(os.Getpid(), qos.KubeletOOMScoreAdj, nil); err != nil { </del> <ins> if err := ensureProcessInContainerWithOOMScore(os.Getpid(), int(cm.KubeletOOMScoreAdj), nil); err != nil { </ins> klog.ErrorS(err, \"Failed to ensure process in container with oom score\") return }", "commid": "kubernetes_pr_106082"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-921d22c2f559c36be3e8ae85e52ba24120da7ee8caf115af1ba9cbca6aaf812b", "query": "This is an umbrella issue to track changes in the . It is required to update the guide based on the suggestion we've received so far after officially migrating , , and (ongoing migration). The guide can be improved by adding more relevant details about structured logging migration, examples, common mistakes, and easy navigation in the guide using appropriate referencing. We've observed common mistakes made by contributors while doing the migration. To avoid those \"common mistakes\", more examples are needed in the structured logging migration guide: approach could be manually looking at various review comments that we've received so far while performing migration of , , and and figure out common mistakes done by contributors. Add examples to avoid those mistakes, and enhance the guidelines present in addition to this, people involved in the previous migration process, either as approver/reviewer or as contributors, can suggest changes in this umbrella issue or open a pull request towards the necessary changes referencing this issue. As we advance, we need to make the migration guide suitable for both \"contributors\" and \"users\" of Kubernetes. Since slowly we are progressing and covering more components of Kubernetes, it is required to improve the guide so that both contributors and Kubernetes users can effectively use it.\nSuggestions in form of review comments from previous migrations are here:\n/sig instrumentation /wg structured-logging /area logging /priority important-longterm /kind documentation /cc\nDo you intend to update the documentation yourself, or are you looking for others to help here?\nYes, 1) I'm looking for contributors and reviewers to suggest more changes (I may not be able to cover all the required changes) and I'll add those changes in the table above. 2) Contributors can submit PRs for these changes in the migration guide, I can definitely submit PRs if we see that the issue is not progressing enough\nThanks. I'm going to assign this to you for now then. /assign shivanshu1333\n/assign\n/triage accepted\n/sig docs\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-ed6fab0c6cf8e2f24387f5dc8c90675ce9c83d0f88e7d9c814dc8fb9b3cd8417", "text": "echo \"minion-$((${BASH_REMATCH[1]} - 1))\" } <del> # Find the vagrant machien name based on the host name of the minion </del> <ins> # Find the vagrant machine name based on the host name of the minion </ins> function find-vagrant-name-by-minion-name { local ip=\"$1\" if [[ \"$ip\" == \"${INSTANCE_PREFIX}-master\" ]]; then", "commid": "kubernetes_pr_6283"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-35499a3ca46347fc92f5eaa71524164ce200edabc0d3f386dc26b07d9278777e", "query": "I was trying a scenario where liveness/readiness probe command run inside the container for long time('sleep 10 && exit 10') with shorter timeoutSecod value say 2 Sec. As expected container restarted because of timeout but when i check the events in pod describe it stated only unhealthy and in events actual reason for probe failure is not printed \"liveness probe failed:<'no reason printed'\". Without clear logs or pod events description it is very difficult to debug and understand what is the failure. Below is the example manifest file to reproduce the issue. apiVersion: v1 kind: Pod metadata: labels: test: liveness name: liveness-exec spec: containers: name: liveness image: args: /bin/sh -c touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600 readinessProbe: exec: command: [/bin/sh, -c , 'sleep 10 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 livenessProbe: exec: command: [/bin/sh, -c ,'sleep 5 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 It would be better if actual reason or something for probe failure printed in pod describe events incase of liveness/readiness probe gets timeout. Example like below in pod describe events: Warning Unhealthy 3s (x2 over 8s) kubelet Liveness probe failed: \"probe failed due to timeout \" Warning Unhealthy 3s (x2 over 8s) kubelet Readiness probe failed: \"probe failed due to timeout \" ! It would be better if actual reason or something for probe failure printed in pod describe events incase of liveness/readiness probe gets timeout. Example like below in pod describe events: Warning Unhealthy 3s (x2 over 8s) kubelet Liveness probe failed: \"probe failed due to timeout \" Warning Unhealthy 3s (x2 over 8s) kubelet Readiness probe failed: \"probe failed due to timeout \" Below is the example manifest file to reproduce the issue. apiVersion: v1 kind: Pod metadata: labels: test: liveness name: liveness-exec spec: containers: name: liveness image: args: /bin/sh -c touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600 readinessProbe: exec: command: [/bin/sh, -c , 'sleep 10 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 livenessProbe: exec: command: [/bin/sh, -c ,'sleep 5 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 Create a pod using above manifest file and do pod describe (kubectl describe pod <pod-name ) and check for the events. ! No response kubectl version Client Version: version.Info{Major:\"1\", Minor:\"21\", GitVersion:\"v1.21.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2021-08-31T06:59:53Z\", GoVersion:\"go1.16.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"21\", GitVersion:\"v1.21.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2021-08-31T06:52:44Z\", GoVersion:\"go1.16.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} openstack <details</details<details</detailscontainerd No response\nI tried to fix one similar issue in\n/sig node\n/triage accepted\ncan I work on this issue? Thanks very much. /assign\nWe've experienced this issue with clusters on v1.20. The for that version mention the following change: Since v1.20 is seemingly when exec probe timeouts started being enforced, would it be possible to have this fix for this issue backported to all minor versions since then? Thanks!\nbump on that question\nWhat do you think of? Thanks very much.", "positive_passages": [{"docid": "doc-en-kubernetes-31ab650fba7580f20b4cdaffe6262ba5a8d2d77f7afa1a7d56c1ff0177b5905f", "text": "} func (eic *execInContainer) SetDir(dir string) { <del> //unimplemented </del> <ins> // unimplemented </ins> } func (eic *execInContainer) SetStdin(in io.Reader) { <del> //unimplemented </del> <ins> // unimplemented </ins> } func (eic *execInContainer) SetStdout(out io.Writer) {", "commid": "kubernetes_pr_106201"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-35499a3ca46347fc92f5eaa71524164ce200edabc0d3f386dc26b07d9278777e", "query": "I was trying a scenario where liveness/readiness probe command run inside the container for long time('sleep 10 && exit 10') with shorter timeoutSecod value say 2 Sec. As expected container restarted because of timeout but when i check the events in pod describe it stated only unhealthy and in events actual reason for probe failure is not printed \"liveness probe failed:<'no reason printed'\". Without clear logs or pod events description it is very difficult to debug and understand what is the failure. Below is the example manifest file to reproduce the issue. apiVersion: v1 kind: Pod metadata: labels: test: liveness name: liveness-exec spec: containers: name: liveness image: args: /bin/sh -c touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600 readinessProbe: exec: command: [/bin/sh, -c , 'sleep 10 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 livenessProbe: exec: command: [/bin/sh, -c ,'sleep 5 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 It would be better if actual reason or something for probe failure printed in pod describe events incase of liveness/readiness probe gets timeout. Example like below in pod describe events: Warning Unhealthy 3s (x2 over 8s) kubelet Liveness probe failed: \"probe failed due to timeout \" Warning Unhealthy 3s (x2 over 8s) kubelet Readiness probe failed: \"probe failed due to timeout \" ! It would be better if actual reason or something for probe failure printed in pod describe events incase of liveness/readiness probe gets timeout. Example like below in pod describe events: Warning Unhealthy 3s (x2 over 8s) kubelet Liveness probe failed: \"probe failed due to timeout \" Warning Unhealthy 3s (x2 over 8s) kubelet Readiness probe failed: \"probe failed due to timeout \" Below is the example manifest file to reproduce the issue. apiVersion: v1 kind: Pod metadata: labels: test: liveness name: liveness-exec spec: containers: name: liveness image: args: /bin/sh -c touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600 readinessProbe: exec: command: [/bin/sh, -c , 'sleep 10 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 livenessProbe: exec: command: [/bin/sh, -c ,'sleep 5 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 Create a pod using above manifest file and do pod describe (kubectl describe pod <pod-name ) and check for the events. ! No response kubectl version Client Version: version.Info{Major:\"1\", Minor:\"21\", GitVersion:\"v1.21.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2021-08-31T06:59:53Z\", GoVersion:\"go1.16.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"21\", GitVersion:\"v1.21.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2021-08-31T06:52:44Z\", GoVersion:\"go1.16.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} openstack <details</details<details</detailscontainerd No response\nI tried to fix one similar issue in\n/sig node\n/triage accepted\ncan I work on this issue? Thanks very much. /assign\nWe've experienced this issue with clusters on v1.20. The for that version mention the following change: Since v1.20 is seemingly when exec probe timeouts started being enforced, would it be possible to have this fix for this issue backported to all minor versions since then? Thanks!\nbump on that question\nWhat do you think of? Thanks very much.", "positive_passages": [{"docid": "doc-en-kubernetes-0ef26a2263562c704a323eee07982b2769b15c74c82bb7be841fe83749a74ed0", "text": "} func (eic *execInContainer) SetEnv(env []string) { <del> //unimplemented </del> <ins> // unimplemented </ins> } func (eic *execInContainer) Stop() { <del> //unimplemented </del> <ins> // unimplemented </ins> } func (eic *execInContainer) Start() error {", "commid": "kubernetes_pr_106201"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-35499a3ca46347fc92f5eaa71524164ce200edabc0d3f386dc26b07d9278777e", "query": "I was trying a scenario where liveness/readiness probe command run inside the container for long time('sleep 10 && exit 10') with shorter timeoutSecod value say 2 Sec. As expected container restarted because of timeout but when i check the events in pod describe it stated only unhealthy and in events actual reason for probe failure is not printed \"liveness probe failed:<'no reason printed'\". Without clear logs or pod events description it is very difficult to debug and understand what is the failure. Below is the example manifest file to reproduce the issue. apiVersion: v1 kind: Pod metadata: labels: test: liveness name: liveness-exec spec: containers: name: liveness image: args: /bin/sh -c touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600 readinessProbe: exec: command: [/bin/sh, -c , 'sleep 10 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 livenessProbe: exec: command: [/bin/sh, -c ,'sleep 5 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 It would be better if actual reason or something for probe failure printed in pod describe events incase of liveness/readiness probe gets timeout. Example like below in pod describe events: Warning Unhealthy 3s (x2 over 8s) kubelet Liveness probe failed: \"probe failed due to timeout \" Warning Unhealthy 3s (x2 over 8s) kubelet Readiness probe failed: \"probe failed due to timeout \" ! It would be better if actual reason or something for probe failure printed in pod describe events incase of liveness/readiness probe gets timeout. Example like below in pod describe events: Warning Unhealthy 3s (x2 over 8s) kubelet Liveness probe failed: \"probe failed due to timeout \" Warning Unhealthy 3s (x2 over 8s) kubelet Readiness probe failed: \"probe failed due to timeout \" Below is the example manifest file to reproduce the issue. apiVersion: v1 kind: Pod metadata: labels: test: liveness name: liveness-exec spec: containers: name: liveness image: args: /bin/sh -c touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600 readinessProbe: exec: command: [/bin/sh, -c , 'sleep 10 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 livenessProbe: exec: command: [/bin/sh, -c ,'sleep 5 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 Create a pod using above manifest file and do pod describe (kubectl describe pod <pod-name ) and check for the events. ! No response kubectl version Client Version: version.Info{Major:\"1\", Minor:\"21\", GitVersion:\"v1.21.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2021-08-31T06:59:53Z\", GoVersion:\"go1.16.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"21\", GitVersion:\"v1.21.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2021-08-31T06:52:44Z\", GoVersion:\"go1.16.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} openstack <details</details<details</detailscontainerd No response\nI tried to fix one similar issue in\n/sig node\n/triage accepted\ncan I work on this issue? Thanks very much. /assign\nWe've experienced this issue with clusters on v1.20. The for that version mention the following change: Since v1.20 is seemingly when exec probe timeouts started being enforced, would it be possible to have this fix for this issue backported to all minor versions since then? Thanks!\nbump on that question\nWhat do you think of? Thanks very much.", "positive_passages": [{"docid": "doc-en-kubernetes-b1d0079db29a3a4a57d44b620294c9a520e160a4ce73d7f4d341f0a10d445281", "text": "timeoutErr, ok := err.(*TimeoutError) if ok { if utilfeature.DefaultFeatureGate.Enabled(features.ExecProbeTimeout) { <del> return probe.Failure, string(data), nil </del> <ins> // When exec probe timeout, data is empty, so we should return timeoutErr.Error() as the stdout. return probe.Failure, timeoutErr.Error(), nil </ins> } klog.Warningf(\"Exec probe timed out after %s but ExecProbeTimeout feature gate was disabled\", timeoutErr.Timeout())", "commid": "kubernetes_pr_106201"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-35499a3ca46347fc92f5eaa71524164ce200edabc0d3f386dc26b07d9278777e", "query": "I was trying a scenario where liveness/readiness probe command run inside the container for long time('sleep 10 && exit 10') with shorter timeoutSecod value say 2 Sec. As expected container restarted because of timeout but when i check the events in pod describe it stated only unhealthy and in events actual reason for probe failure is not printed \"liveness probe failed:<'no reason printed'\". Without clear logs or pod events description it is very difficult to debug and understand what is the failure. Below is the example manifest file to reproduce the issue. apiVersion: v1 kind: Pod metadata: labels: test: liveness name: liveness-exec spec: containers: name: liveness image: args: /bin/sh -c touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600 readinessProbe: exec: command: [/bin/sh, -c , 'sleep 10 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 livenessProbe: exec: command: [/bin/sh, -c ,'sleep 5 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 It would be better if actual reason or something for probe failure printed in pod describe events incase of liveness/readiness probe gets timeout. Example like below in pod describe events: Warning Unhealthy 3s (x2 over 8s) kubelet Liveness probe failed: \"probe failed due to timeout \" Warning Unhealthy 3s (x2 over 8s) kubelet Readiness probe failed: \"probe failed due to timeout \" ! It would be better if actual reason or something for probe failure printed in pod describe events incase of liveness/readiness probe gets timeout. Example like below in pod describe events: Warning Unhealthy 3s (x2 over 8s) kubelet Liveness probe failed: \"probe failed due to timeout \" Warning Unhealthy 3s (x2 over 8s) kubelet Readiness probe failed: \"probe failed due to timeout \" Below is the example manifest file to reproduce the issue. apiVersion: v1 kind: Pod metadata: labels: test: liveness name: liveness-exec spec: containers: name: liveness image: args: /bin/sh -c touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600 readinessProbe: exec: command: [/bin/sh, -c , 'sleep 10 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 livenessProbe: exec: command: [/bin/sh, -c ,'sleep 5 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 Create a pod using above manifest file and do pod describe (kubectl describe pod <pod-name ) and check for the events. ! No response kubectl version Client Version: version.Info{Major:\"1\", Minor:\"21\", GitVersion:\"v1.21.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2021-08-31T06:59:53Z\", GoVersion:\"go1.16.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"21\", GitVersion:\"v1.21.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2021-08-31T06:52:44Z\", GoVersion:\"go1.16.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} openstack <details</details<details</detailscontainerd No response\nI tried to fix one similar issue in\n/sig node\n/triage accepted\ncan I work on this issue? Thanks very much. /assign\nWe've experienced this issue with clusters on v1.20. The for that version mention the following change: Since v1.20 is seemingly when exec probe timeouts started being enforced, would it be possible to have this fix for this issue backported to all minor versions since then? Thanks!\nbump on that question\nWhat do you think of? Thanks very much.", "positive_passages": [{"docid": "doc-en-kubernetes-f16efbf3c6aa8818500568c3ac6aa84c479ee298be9aabf392b401e4ff34b8a0", "text": "\"io\" \"strings\" \"testing\" <ins> \"time\" </ins> \"k8s.io/kubernetes/pkg/probe\" )", "commid": "kubernetes_pr_106201"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-35499a3ca46347fc92f5eaa71524164ce200edabc0d3f386dc26b07d9278777e", "query": "I was trying a scenario where liveness/readiness probe command run inside the container for long time('sleep 10 && exit 10') with shorter timeoutSecod value say 2 Sec. As expected container restarted because of timeout but when i check the events in pod describe it stated only unhealthy and in events actual reason for probe failure is not printed \"liveness probe failed:<'no reason printed'\". Without clear logs or pod events description it is very difficult to debug and understand what is the failure. Below is the example manifest file to reproduce the issue. apiVersion: v1 kind: Pod metadata: labels: test: liveness name: liveness-exec spec: containers: name: liveness image: args: /bin/sh -c touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600 readinessProbe: exec: command: [/bin/sh, -c , 'sleep 10 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 livenessProbe: exec: command: [/bin/sh, -c ,'sleep 5 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 It would be better if actual reason or something for probe failure printed in pod describe events incase of liveness/readiness probe gets timeout. Example like below in pod describe events: Warning Unhealthy 3s (x2 over 8s) kubelet Liveness probe failed: \"probe failed due to timeout \" Warning Unhealthy 3s (x2 over 8s) kubelet Readiness probe failed: \"probe failed due to timeout \" ! It would be better if actual reason or something for probe failure printed in pod describe events incase of liveness/readiness probe gets timeout. Example like below in pod describe events: Warning Unhealthy 3s (x2 over 8s) kubelet Liveness probe failed: \"probe failed due to timeout \" Warning Unhealthy 3s (x2 over 8s) kubelet Readiness probe failed: \"probe failed due to timeout \" Below is the example manifest file to reproduce the issue. apiVersion: v1 kind: Pod metadata: labels: test: liveness name: liveness-exec spec: containers: name: liveness image: args: /bin/sh -c touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600 readinessProbe: exec: command: [/bin/sh, -c , 'sleep 10 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 livenessProbe: exec: command: [/bin/sh, -c ,'sleep 5 && exit10'] initialDelaySeconds: 5 periodSeconds: 5 timeoutSeconds: 2 Create a pod using above manifest file and do pod describe (kubectl describe pod <pod-name ) and check for the events. ! No response kubectl version Client Version: version.Info{Major:\"1\", Minor:\"21\", GitVersion:\"v1.21.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2021-08-31T06:59:53Z\", GoVersion:\"go1.16.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} Server Version: version.Info{Major:\"1\", Minor:\"21\", GitVersion:\"v1.21.1\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2021-08-31T06:52:44Z\", GoVersion:\"go1.16.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} openstack <details</details<details</detailscontainerd No response\nI tried to fix one similar issue in\n/sig node\n/triage accepted\ncan I work on this issue? Thanks very much. /assign\nWe've experienced this issue with clusters on v1.20. The for that version mention the following change: Since v1.20 is seemingly when exec probe timeouts started being enforced, would it be possible to have this fix for this issue backported to all minor versions since then? Thanks!\nbump on that question\nWhat do you think of? Thanks very much.", "positive_passages": [{"docid": "doc-en-kubernetes-15024ff35c457dce4d9a500135e0a9bbc5904712e346b8b24447b654434ab44d", "text": "{probe.Unknown, true, \"\", \"\", fmt.Errorf(\"test error\")}, // Unhealthy {probe.Failure, false, \"Fail\", \"\", &fakeExitError{true, 1}}, <ins> // Timeout {probe.Failure, false, \"\", \"command testcmd timed out\", NewTimeoutError(fmt.Errorf(\"command testcmd timed out\"), time.Second)}, </ins> } for i, test := range tests { fake := FakeCmd{", "commid": "kubernetes_pr_106201"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d3c8c14a47bead0a2aabecf2aacf5b825b61c49fe97ab53351d341210fbbc8d4", "query": "kubeadm-kinder-latest ci-kubernetes-e2e-kubeadm-kinder-latest.Overall E2EKubeadm suite.[sig-cluster-lifecycle] [area-kubeadm] proxy addon kube-proxy ServiceAccount should be bound to the system:node-proxier cluster role 2021-11-09 23:32 CET () E2EKubeadm suite: [sig-cluster-lifecycle] [area-kubeadm] proxy addon kube-proxy ServiceAccount should be bound to the system:node-proxier cluster role This issue seems to be linked to FYI: /cc /sig cluster-lifecycle /area kubeadm\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nfix PR is here, needs LGTM:\nAlso failing on Thanks !", "positive_passages": [{"docid": "doc-en-kubernetes-dfcb17671562997e03cc008d4836d91cf70578c7555f1266c59eb14ec03f5c8a", "text": "// TODO: This k8s-generic, well-known constant should be fetchable from another source, not be in this package KubeProxyClusterRoleName = \"system:node-proxier\" <ins> // KubeProxyClusterRoleBindingName sets the name for the kube-proxy CluterRoleBinding KubeProxyClusterRoleBindingName = \"kubeadm:node-proxier\" </ins> // KubeProxyServiceAccountName describes the name of the ServiceAccount for the kube-proxy addon KubeProxyServiceAccountName = \"kube-proxy\" <del> // KubeProxyClusterRoleBindingName sets the name for the kube-proxy CluterRoleBinding KubeProxyClusterRoleBindingName = \"kubeam:node-proxier\" </del> // KubeProxyConfigMapRoleName sets the name of ClusterRole for ConfigMap KubeProxyConfigMapRoleName = \"kube-proxy\" )", "commid": "kubernetes_pr_106321"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d3c8c14a47bead0a2aabecf2aacf5b825b61c49fe97ab53351d341210fbbc8d4", "query": "kubeadm-kinder-latest ci-kubernetes-e2e-kubeadm-kinder-latest.Overall E2EKubeadm suite.[sig-cluster-lifecycle] [area-kubeadm] proxy addon kube-proxy ServiceAccount should be bound to the system:node-proxier cluster role 2021-11-09 23:32 CET () E2EKubeadm suite: [sig-cluster-lifecycle] [area-kubeadm] proxy addon kube-proxy ServiceAccount should be bound to the system:node-proxier cluster role This issue seems to be linked to FYI: /cc /sig cluster-lifecycle /area kubeadm\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nfix PR is here, needs LGTM:\nAlso failing on Thanks !", "positive_passages": [{"docid": "doc-en-kubernetes-64eae22749511524fd719f48560cfbabad13a515c523c6497dee8a40afe59ad7", "text": "// https://github.com/kubernetes/kubeadm/issues/1582 var UnversionedKubeletConfigMap bool if _, ok := m[\"featureGates\"]; ok { <del> if featureGates, ok := m[\"featureGates\"].(map[string]bool); ok { </del> <ins> if featureGates, ok := m[\"featureGates\"].(map[interface{}]interface{}); ok { </ins> // TODO: update the default to true once this graduates to Beta. UnversionedKubeletConfigMap = false if val, ok := featureGates[\"UnversionedKubeletConfigMap\"]; ok { <del> UnversionedKubeletConfigMap = val </del> <ins> if valBool, ok := val.(bool); ok { UnversionedKubeletConfigMap = valBool } else { framework.Failf(\"unable to cast the value of feature gate UnversionedKubeletConfigMap to bool\") } </ins> } } else { framework.Failf(\"unable to cast the featureGates field in the %s ConfigMap\", kubeadmConfigName)", "commid": "kubernetes_pr_106321"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-84ac6b29d3552ee4565d85bb68dd153f357ab1763ab9daf494e08879761ee84b", "query": "ci-kubernetes-e2e-aks-engine-azure-master-windows-containerd-serial-slow Kubernetes e2e suite: [sig-windows] [Feature:Windows] Memory Limits [Serial] [Slow] Allocatable node memory should be equal to a calculated allocatable memory value expandmore this month No response_ /sig windows\n/assign\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-aa15d9772bf5d20b3e6b666524c03863b97984613406040ee3d1e94f509e63fe", "text": "import ( \"context\" <ins> \"encoding/json\" </ins> \"fmt\" \"strconv\" \"time\" <ins> kubeletconfigv1beta1 \"k8s.io/kubelet/config/v1beta1\" kubeletconfig \"k8s.io/kubernetes/pkg/kubelet/apis/config\" kubeletconfigscheme \"k8s.io/kubernetes/pkg/kubelet/apis/config/scheme\" </ins> v1 \"k8s.io/api/core/v1\" \"k8s.io/apimachinery/pkg/api/resource\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/labels\" \"k8s.io/apimachinery/pkg/util/uuid\" \"k8s.io/kubernetes/test/e2e/framework\" <del> e2ekubelet \"k8s.io/kubernetes/test/e2e/framework/kubelet\" </del> e2eskipper \"k8s.io/kubernetes/test/e2e/framework/skipper\" imageutils \"k8s.io/kubernetes/test/utils/image\"", "commid": "kubernetes_pr_106471"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-84ac6b29d3552ee4565d85bb68dd153f357ab1763ab9daf494e08879761ee84b", "query": "ci-kubernetes-e2e-aks-engine-azure-master-windows-containerd-serial-slow Kubernetes e2e suite: [sig-windows] [Feature:Windows] Memory Limits [Serial] [Slow] Allocatable node memory should be equal to a calculated allocatable memory value expandmore this month No response_ /sig windows\n/assign\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-3dbd1eed5bcfec73efa14e05137c07ef54ba7b31f01c873d22beb2301e74e5c2", "text": "framework.ExpectNotEqual(nodeList.Size(), 0) ginkgo.By(\"Getting memory details from node status and kubelet config\") status := nodeList.Items[0].Status nodeName := nodeList.Items[0].ObjectMeta.Name <del> kubeletConfig, err := e2ekubelet.GetCurrentKubeletConfig(nodeName, f.Namespace.Name, true) </del> <ins> framework.Logf(\"Getting configuration details for node %s\", nodeName) request := f.ClientSet.CoreV1().RESTClient().Get().Resource(\"nodes\").Name(nodeName).SubResource(\"proxy\").Suffix(\"configz\") rawbytes, err := request.DoRaw(context.Background()) framework.ExpectNoError(err) kubeletConfig, err := decodeConfigz(rawbytes) </ins> framework.ExpectNoError(err) systemReserve, err := resource.ParseQuantity(kubeletConfig.SystemReserved[\"memory\"])", "commid": "kubernetes_pr_106471"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-84ac6b29d3552ee4565d85bb68dd153f357ab1763ab9daf494e08879761ee84b", "query": "ci-kubernetes-e2e-aks-engine-azure-master-windows-containerd-serial-slow Kubernetes e2e suite: [sig-windows] [Feature:Windows] Memory Limits [Serial] [Slow] Allocatable node memory should be equal to a calculated allocatable memory value expandmore this month No response_ /sig windows\n/assign\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-f7cc5ad58fc841f2aeb2efcd23a2d258559836907568c3d72752f472265d390e", "text": "return totalAllocatable } <ins> // modified from https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/kubelet/config.go#L110 // the proxy version was causing and non proxy used a value that isn't set by e2e func decodeConfigz(contentsBytes []byte) (*kubeletconfig.KubeletConfiguration, error) { // This hack because /configz reports the following structure: // {\"kubeletconfig\": {the JSON representation of kubeletconfigv1beta1.KubeletConfiguration}} type configzWrapper struct { ComponentConfig kubeletconfigv1beta1.KubeletConfiguration `json:\"kubeletconfig\"` } configz := configzWrapper{} kubeCfg := kubeletconfig.KubeletConfiguration{} err := json.Unmarshal(contentsBytes, &configz) if err != nil { return nil, err } scheme, _, err := kubeletconfigscheme.NewSchemeAndCodecs() if err != nil { return nil, err } err = scheme.Convert(&configz.ComponentConfig, &kubeCfg, nil) if err != nil { return nil, err } return &kubeCfg, nil } </ins>", "commid": "kubernetes_pr_106471"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-70cc8a837504b60a5c6c5f5140cd4a6de426afd5bd1cc3a810b5342e232bd03d", "query": "integration-master ci-kubernetes-integration-master.OverallChanges 11/19/2021 23:54 CET see this as example to get information about the failure No response No response_\ngreat catch /sig api-machinery /priority critical-urgent it seems all tests fail with how can this fail consistently only in periodics and not in presubmits? is an external dependency?\nI would say this is the origin Server Side Strict Field Validation \npresubmits only run short tests, periodics run all long ones... looking if there's a long test that needs fixup\nfix in", "positive_passages": [{"docid": "doc-en-kubernetes-053eff727a21b343aa7d5f278bf254d95ee89937d98c2e7ddbb6e298e3604d02", "text": "} patchedJS, retErr = jsonpatch.MergePatch(versionedJS, p.patchBytes) <ins> if retErr == jsonpatch.ErrBadJSONPatch { return nil, nil, errors.NewBadRequest(retErr.Error()) } </ins> return patchedJS, strictErrors, retErr default: // only here as a safety net - go-restful filters content-type", "commid": "kubernetes_pr_106576"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f6b8358021d22b6a22cf92b93e9370729451ca3669c4f6afe9d84808b437dd55", "query": "ci-kubernetes-node-kubelet-serial-containerd: ci-kubernetes-node-kubelet-serial: (This is just an example, most of the tests appear to be failing) /sig node /kind failing-test /milestone v1.23 since test is failing in a release-blocking job /priority critical-urgent /assign /cc I believe this stems from\n/triage accepted These failures look weird - I don't understand why dockershim is sometimes failing after restarting the kubelet. I guess we should double check that timings match the old GPU test (I think I might've tightened them a bit, bc they were passing when I ran the device suite on the same nodes). What's weirder is that they passed on my PR and all of a sudden broke after merging\nDiscussed at today - the easiest solution now that 1.23 has been branched is to punt these tests out of the serial lane so we can get it green again for 1.23, since any changes at this point must be backported and we would prefer that this is not release-blocking.\n/milestone clear should address this; we won't get a fresh serial run for another ~6 hours so let's confirm next business day that this is temporarily fixed.\n/remove-priority critical-urgent /priority important-longterm\ncan we keep it in the milestone until we get a verified green run?\nCI is green today after skipping DevicePluginProbe tests .\n/assign Maybe related to\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nLooks like serial has been stable for a while, closing: /close\nClosing this issue. <detailsIn response to : Looks like serial has been stable for a while, closing: Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen it is referred to here: Tests are skipped today\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ndid you have a chance to look at this? I remember you were close to understanding on what is going wrong here\noh welp, missed that\nI was (past tense) but now I need to go back and look at my notes. If someone else wants to take over, be my guest, I've been quite busy with other tasks lately. Otherwise I'll get back to this!\nSo! I'm able to resume working in this area. So I'm testing last k/k master branch tip and running with : and the tests seems to be running and passing quite reliably! (5 times in a row seems like a promising start :) ) To move forward I suggest to: a explicit s in . This will make more evident we have a pending issue in our camp, that's the most egregious exception we have and it's confusing the skip in the config: - this will enable us to do focused work in this area a PR to remove the skip and iterate over it running CI until it's good enough I can take care of all the above. If CI is still failing, we need to explore possible missing/wrong configuration, but then other e2enode tests should be failing, not just this one.\nI agree, this plan sounds good. Thank you!\nxref:\nstarted to fail also locally - we have baremetal lanes in RH - in the project CI they skip the relevant test. Investigating a possible common root cause\nafter a very long troubleshooting and quite few attempts, is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-33ad06757a56f653c3bf19142296c8d79c4e89b185d2e32dc6d67b53fcf5e23f", "text": "import ( \"context\" \"path/filepath\" <ins> \"regexp\" </ins> \"time\" <ins> \"github.com/onsi/ginkgo\" \"github.com/onsi/gomega\" </ins> appsv1 \"k8s.io/api/apps/v1\" v1 \"k8s.io/api/core/v1\" \"k8s.io/apimachinery/pkg/runtime\" \"k8s.io/apimachinery/pkg/runtime/serializer\" <del> e2eskipper \"k8s.io/kubernetes/test/e2e/framework/skipper\" </del> <ins> kubeletdevicepluginv1beta1 \"k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1\" </ins> e2etestfiles \"k8s.io/kubernetes/test/e2e/framework/testfiles\" admissionapi \"k8s.io/pod-security-admission/api\" <del> \"regexp\" </del> \"k8s.io/apimachinery/pkg/api/resource\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/util/uuid\"", "commid": "kubernetes_pr_109820"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f6b8358021d22b6a22cf92b93e9370729451ca3669c4f6afe9d84808b437dd55", "query": "ci-kubernetes-node-kubelet-serial-containerd: ci-kubernetes-node-kubelet-serial: (This is just an example, most of the tests appear to be failing) /sig node /kind failing-test /milestone v1.23 since test is failing in a release-blocking job /priority critical-urgent /assign /cc I believe this stems from\n/triage accepted These failures look weird - I don't understand why dockershim is sometimes failing after restarting the kubelet. I guess we should double check that timings match the old GPU test (I think I might've tightened them a bit, bc they were passing when I ran the device suite on the same nodes). What's weirder is that they passed on my PR and all of a sudden broke after merging\nDiscussed at today - the easiest solution now that 1.23 has been branched is to punt these tests out of the serial lane so we can get it green again for 1.23, since any changes at this point must be backported and we would prefer that this is not release-blocking.\n/milestone clear should address this; we won't get a fresh serial run for another ~6 hours so let's confirm next business day that this is temporarily fixed.\n/remove-priority critical-urgent /priority important-longterm\ncan we keep it in the milestone until we get a verified green run?\nCI is green today after skipping DevicePluginProbe tests .\n/assign Maybe related to\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nLooks like serial has been stable for a while, closing: /close\nClosing this issue. <detailsIn response to : Looks like serial has been stable for a while, closing: Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen it is referred to here: Tests are skipped today\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ndid you have a chance to look at this? I remember you were close to understanding on what is going wrong here\noh welp, missed that\nI was (past tense) but now I need to go back and look at my notes. If someone else wants to take over, be my guest, I've been quite busy with other tasks lately. Otherwise I'll get back to this!\nSo! I'm able to resume working in this area. So I'm testing last k/k master branch tip and running with : and the tests seems to be running and passing quite reliably! (5 times in a row seems like a promising start :) ) To move forward I suggest to: a explicit s in . This will make more evident we have a pending issue in our camp, that's the most egregious exception we have and it's confusing the skip in the config: - this will enable us to do focused work in this area a PR to remove the skip and iterate over it running CI until it's good enough I can take care of all the above. If CI is still failing, we need to explore possible missing/wrong configuration, but then other e2enode tests should be failing, not just this one.\nI agree, this plan sounds good. Thank you!\nxref:\nstarted to fail also locally - we have baremetal lanes in RH - in the project CI they skip the relevant test. Investigating a possible common root cause\nafter a very long troubleshooting and quite few attempts, is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-d929ca3e3e7c55ecbcfa27c54a49103c25b6e40a2779beb5856ee21b2a526cd0", "text": "\"k8s.io/kubernetes/test/e2e/framework\" e2enode \"k8s.io/kubernetes/test/e2e/framework/node\" e2epod \"k8s.io/kubernetes/test/e2e/framework/pod\" <del> \"github.com/onsi/ginkgo\" \"github.com/onsi/gomega\" </del> ) const (", "commid": "kubernetes_pr_109820"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f6b8358021d22b6a22cf92b93e9370729451ca3669c4f6afe9d84808b437dd55", "query": "ci-kubernetes-node-kubelet-serial-containerd: ci-kubernetes-node-kubelet-serial: (This is just an example, most of the tests appear to be failing) /sig node /kind failing-test /milestone v1.23 since test is failing in a release-blocking job /priority critical-urgent /assign /cc I believe this stems from\n/triage accepted These failures look weird - I don't understand why dockershim is sometimes failing after restarting the kubelet. I guess we should double check that timings match the old GPU test (I think I might've tightened them a bit, bc they were passing when I ran the device suite on the same nodes). What's weirder is that they passed on my PR and all of a sudden broke after merging\nDiscussed at today - the easiest solution now that 1.23 has been branched is to punt these tests out of the serial lane so we can get it green again for 1.23, since any changes at this point must be backported and we would prefer that this is not release-blocking.\n/milestone clear should address this; we won't get a fresh serial run for another ~6 hours so let's confirm next business day that this is temporarily fixed.\n/remove-priority critical-urgent /priority important-longterm\ncan we keep it in the milestone until we get a verified green run?\nCI is green today after skipping DevicePluginProbe tests .\n/assign Maybe related to\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nLooks like serial has been stable for a while, closing: /close\nClosing this issue. <detailsIn response to : Looks like serial has been stable for a while, closing: Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen it is referred to here: Tests are skipped today\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ndid you have a chance to look at this? I remember you were close to understanding on what is going wrong here\noh welp, missed that\nI was (past tense) but now I need to go back and look at my notes. If someone else wants to take over, be my guest, I've been quite busy with other tasks lately. Otherwise I'll get back to this!\nSo! I'm able to resume working in this area. So I'm testing last k/k master branch tip and running with : and the tests seems to be running and passing quite reliably! (5 times in a row seems like a promising start :) ) To move forward I suggest to: a explicit s in . This will make more evident we have a pending issue in our camp, that's the most egregious exception we have and it's confusing the skip in the config: - this will enable us to do focused work in this area a PR to remove the skip and iterate over it running CI until it's good enough I can take care of all the above. If CI is still failing, we need to explore possible missing/wrong configuration, but then other e2enode tests should be failing, not just this one.\nI agree, this plan sounds good. Thank you!\nxref:\nstarted to fail also locally - we have baremetal lanes in RH - in the project CI they skip the relevant test. Investigating a possible common root cause\nafter a very long troubleshooting and quite few attempts, is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-3eb63af23c4708fe83a810195be576dc6060831819f890b329d131e1317baa00", "text": "var _ = SIGDescribe(\"Device Plugin [Feature:DevicePluginProbe][NodeFeature:DevicePluginProbe][Serial]\", func() { f := framework.NewDefaultFramework(\"device-plugin-errors\") f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged <del> testDevicePlugin(f, \"/var/lib/kubelet/plugins_registry\") </del> <ins> testDevicePlugin(f, kubeletdevicepluginv1beta1.DevicePluginPath) </ins> }) // numberOfSampleResources returns the number of resources advertised by a node.", "commid": "kubernetes_pr_109820"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f6b8358021d22b6a22cf92b93e9370729451ca3669c4f6afe9d84808b437dd55", "query": "ci-kubernetes-node-kubelet-serial-containerd: ci-kubernetes-node-kubelet-serial: (This is just an example, most of the tests appear to be failing) /sig node /kind failing-test /milestone v1.23 since test is failing in a release-blocking job /priority critical-urgent /assign /cc I believe this stems from\n/triage accepted These failures look weird - I don't understand why dockershim is sometimes failing after restarting the kubelet. I guess we should double check that timings match the old GPU test (I think I might've tightened them a bit, bc they were passing when I ran the device suite on the same nodes). What's weirder is that they passed on my PR and all of a sudden broke after merging\nDiscussed at today - the easiest solution now that 1.23 has been branched is to punt these tests out of the serial lane so we can get it green again for 1.23, since any changes at this point must be backported and we would prefer that this is not release-blocking.\n/milestone clear should address this; we won't get a fresh serial run for another ~6 hours so let's confirm next business day that this is temporarily fixed.\n/remove-priority critical-urgent /priority important-longterm\ncan we keep it in the milestone until we get a verified green run?\nCI is green today after skipping DevicePluginProbe tests .\n/assign Maybe related to\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nLooks like serial has been stable for a while, closing: /close\nClosing this issue. <detailsIn response to : Looks like serial has been stable for a while, closing: Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen it is referred to here: Tests are skipped today\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ndid you have a chance to look at this? I remember you were close to understanding on what is going wrong here\noh welp, missed that\nI was (past tense) but now I need to go back and look at my notes. If someone else wants to take over, be my guest, I've been quite busy with other tasks lately. Otherwise I'll get back to this!\nSo! I'm able to resume working in this area. So I'm testing last k/k master branch tip and running with : and the tests seems to be running and passing quite reliably! (5 times in a row seems like a promising start :) ) To move forward I suggest to: a explicit s in . This will make more evident we have a pending issue in our camp, that's the most egregious exception we have and it's confusing the skip in the config: - this will enable us to do focused work in this area a PR to remove the skip and iterate over it running CI until it's good enough I can take care of all the above. If CI is still failing, we need to explore possible missing/wrong configuration, but then other e2enode tests should be failing, not just this one.\nI agree, this plan sounds good. Thank you!\nxref:\nstarted to fail also locally - we have baremetal lanes in RH - in the project CI they skip the relevant test. Investigating a possible common root cause\nafter a very long troubleshooting and quite few attempts, is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-b1263a5c3ebf3797e9bb02ac1213581af3d745f40ef628ae1e13d4fa01b8d662", "text": "var devicePluginPod, dptemplate *v1.Pod ginkgo.BeforeEach(func() { <del> e2eskipper.Skipf(\"Device Plugin tests are currently broken and being investigated\") </del> ginkgo.By(\"Wait for node to be ready\") gomega.Eventually(func() bool { nodes, err := e2enode.TotalReady(f.ClientSet)", "commid": "kubernetes_pr_109820"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f6b8358021d22b6a22cf92b93e9370729451ca3669c4f6afe9d84808b437dd55", "query": "ci-kubernetes-node-kubelet-serial-containerd: ci-kubernetes-node-kubelet-serial: (This is just an example, most of the tests appear to be failing) /sig node /kind failing-test /milestone v1.23 since test is failing in a release-blocking job /priority critical-urgent /assign /cc I believe this stems from\n/triage accepted These failures look weird - I don't understand why dockershim is sometimes failing after restarting the kubelet. I guess we should double check that timings match the old GPU test (I think I might've tightened them a bit, bc they were passing when I ran the device suite on the same nodes). What's weirder is that they passed on my PR and all of a sudden broke after merging\nDiscussed at today - the easiest solution now that 1.23 has been branched is to punt these tests out of the serial lane so we can get it green again for 1.23, since any changes at this point must be backported and we would prefer that this is not release-blocking.\n/milestone clear should address this; we won't get a fresh serial run for another ~6 hours so let's confirm next business day that this is temporarily fixed.\n/remove-priority critical-urgent /priority important-longterm\ncan we keep it in the milestone until we get a verified green run?\nCI is green today after skipping DevicePluginProbe tests .\n/assign Maybe related to\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nLooks like serial has been stable for a while, closing: /close\nClosing this issue. <detailsIn response to : Looks like serial has been stable for a while, closing: Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen it is referred to here: Tests are skipped today\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ndid you have a chance to look at this? I remember you were close to understanding on what is going wrong here\noh welp, missed that\nI was (past tense) but now I need to go back and look at my notes. If someone else wants to take over, be my guest, I've been quite busy with other tasks lately. Otherwise I'll get back to this!\nSo! I'm able to resume working in this area. So I'm testing last k/k master branch tip and running with : and the tests seems to be running and passing quite reliably! (5 times in a row seems like a promising start :) ) To move forward I suggest to: a explicit s in . This will make more evident we have a pending issue in our camp, that's the most egregious exception we have and it's confusing the skip in the config: - this will enable us to do focused work in this area a PR to remove the skip and iterate over it running CI until it's good enough I can take care of all the above. If CI is still failing, we need to explore possible missing/wrong configuration, but then other e2enode tests should be failing, not just this one.\nI agree, this plan sounds good. Thank you!\nxref:\nstarted to fail also locally - we have baremetal lanes in RH - in the project CI they skip the relevant test. Investigating a possible common root cause\nafter a very long troubleshooting and quite few attempts, is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-f41cb9355f735d7dfe3aecfaf8cfee1729ae8bd1f7231bf0a9647f81ab16904f", "text": "dp.Spec.Containers[0].Env[i].Value = pluginSockDir } } <del> dptemplate = dp </del> <ins> dptemplate = dp.DeepCopy() </ins> devicePluginPod = f.PodClient().CreateSync(dp) ginkgo.By(\"Waiting for devices to become available on the local node\") gomega.Eventually(func() bool { <del> return numberOfSampleResources(getLocalNode(f)) > 0 </del> <ins> node, ready := getLocalTestNode(f) return ready && numberOfSampleResources(node) > 0 </ins> }, 5*time.Minute, framework.Poll).Should(gomega.BeTrue()) framework.Logf(\"Successfully created device plugin pod\") ginkgo.By(\"Waiting for the resource exported by the sample device plugin to become available on the local node\") gomega.Eventually(func() bool { <del> node := getLocalNode(f) return numberOfDevicesCapacity(node, resourceName) == devsLen && </del> <ins> node, ready := getLocalTestNode(f) return ready && numberOfDevicesCapacity(node, resourceName) == devsLen && </ins> numberOfDevicesAllocatable(node, resourceName) == devsLen }, 30*time.Second, framework.Poll).Should(gomega.BeTrue()) })", "commid": "kubernetes_pr_109820"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f6b8358021d22b6a22cf92b93e9370729451ca3669c4f6afe9d84808b437dd55", "query": "ci-kubernetes-node-kubelet-serial-containerd: ci-kubernetes-node-kubelet-serial: (This is just an example, most of the tests appear to be failing) /sig node /kind failing-test /milestone v1.23 since test is failing in a release-blocking job /priority critical-urgent /assign /cc I believe this stems from\n/triage accepted These failures look weird - I don't understand why dockershim is sometimes failing after restarting the kubelet. I guess we should double check that timings match the old GPU test (I think I might've tightened them a bit, bc they were passing when I ran the device suite on the same nodes). What's weirder is that they passed on my PR and all of a sudden broke after merging\nDiscussed at today - the easiest solution now that 1.23 has been branched is to punt these tests out of the serial lane so we can get it green again for 1.23, since any changes at this point must be backported and we would prefer that this is not release-blocking.\n/milestone clear should address this; we won't get a fresh serial run for another ~6 hours so let's confirm next business day that this is temporarily fixed.\n/remove-priority critical-urgent /priority important-longterm\ncan we keep it in the milestone until we get a verified green run?\nCI is green today after skipping DevicePluginProbe tests .\n/assign Maybe related to\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nLooks like serial has been stable for a while, closing: /close\nClosing this issue. <detailsIn response to : Looks like serial has been stable for a while, closing: Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen it is referred to here: Tests are skipped today\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ndid you have a chance to look at this? I remember you were close to understanding on what is going wrong here\noh welp, missed that\nI was (past tense) but now I need to go back and look at my notes. If someone else wants to take over, be my guest, I've been quite busy with other tasks lately. Otherwise I'll get back to this!\nSo! I'm able to resume working in this area. So I'm testing last k/k master branch tip and running with : and the tests seems to be running and passing quite reliably! (5 times in a row seems like a promising start :) ) To move forward I suggest to: a explicit s in . This will make more evident we have a pending issue in our camp, that's the most egregious exception we have and it's confusing the skip in the config: - this will enable us to do focused work in this area a PR to remove the skip and iterate over it running CI until it's good enough I can take care of all the above. If CI is still failing, we need to explore possible missing/wrong configuration, but then other e2enode tests should be failing, not just this one.\nI agree, this plan sounds good. Thank you!\nxref:\nstarted to fail also locally - we have baremetal lanes in RH - in the project CI they skip the relevant test. Investigating a possible common root cause\nafter a very long troubleshooting and quite few attempts, is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-2a4162c6651b26c2dd02449e24446b24d67b740bccab213aeddb110e49bff0e3", "text": "ginkgo.By(\"Waiting for devices to become unavailable on the local node\") gomega.Eventually(func() bool { <del> return numberOfSampleResources(getLocalNode(f)) <= 0 </del> <ins> node, ready := getLocalTestNode(f) return ready && numberOfSampleResources(node) <= 0 </ins> }, 5*time.Minute, framework.Poll).Should(gomega.BeTrue()) <ins> ginkgo.By(\"devices now unavailable on the local node\") </ins> }) ginkgo.It(\"Can schedule a pod that requires a device\", func() {", "commid": "kubernetes_pr_109820"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f6b8358021d22b6a22cf92b93e9370729451ca3669c4f6afe9d84808b437dd55", "query": "ci-kubernetes-node-kubelet-serial-containerd: ci-kubernetes-node-kubelet-serial: (This is just an example, most of the tests appear to be failing) /sig node /kind failing-test /milestone v1.23 since test is failing in a release-blocking job /priority critical-urgent /assign /cc I believe this stems from\n/triage accepted These failures look weird - I don't understand why dockershim is sometimes failing after restarting the kubelet. I guess we should double check that timings match the old GPU test (I think I might've tightened them a bit, bc they were passing when I ran the device suite on the same nodes). What's weirder is that they passed on my PR and all of a sudden broke after merging\nDiscussed at today - the easiest solution now that 1.23 has been branched is to punt these tests out of the serial lane so we can get it green again for 1.23, since any changes at this point must be backported and we would prefer that this is not release-blocking.\n/milestone clear should address this; we won't get a fresh serial run for another ~6 hours so let's confirm next business day that this is temporarily fixed.\n/remove-priority critical-urgent /priority important-longterm\ncan we keep it in the milestone until we get a verified green run?\nCI is green today after skipping DevicePluginProbe tests .\n/assign Maybe related to\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nLooks like serial has been stable for a while, closing: /close\nClosing this issue. <detailsIn response to : Looks like serial has been stable for a while, closing: Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen it is referred to here: Tests are skipped today\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ndid you have a chance to look at this? I remember you were close to understanding on what is going wrong here\noh welp, missed that\nI was (past tense) but now I need to go back and look at my notes. If someone else wants to take over, be my guest, I've been quite busy with other tasks lately. Otherwise I'll get back to this!\nSo! I'm able to resume working in this area. So I'm testing last k/k master branch tip and running with : and the tests seems to be running and passing quite reliably! (5 times in a row seems like a promising start :) ) To move forward I suggest to: a explicit s in . This will make more evident we have a pending issue in our camp, that's the most egregious exception we have and it's confusing the skip in the config: - this will enable us to do focused work in this area a PR to remove the skip and iterate over it running CI until it's good enough I can take care of all the above. If CI is still failing, we need to explore possible missing/wrong configuration, but then other e2enode tests should be failing, not just this one.\nI agree, this plan sounds good. Thank you!\nxref:\nstarted to fail also locally - we have baremetal lanes in RH - in the project CI they skip the relevant test. Investigating a possible common root cause\nafter a very long troubleshooting and quite few attempts, is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-eae3e55b0a9a79df13d0c379858f7a3a65daf43fa5879fc9ccfb3222cf00b526", "text": "ginkgo.By(\"Waiting for resource to become available on the local node after re-registration\") gomega.Eventually(func() bool { <del> node := getLocalNode(f) return numberOfDevicesCapacity(node, resourceName) == devsLen && </del> <ins> node, ready := getLocalTestNode(f) return ready && numberOfDevicesCapacity(node, resourceName) == devsLen && </ins> numberOfDevicesAllocatable(node, resourceName) == devsLen }, 30*time.Second, framework.Poll).Should(gomega.BeTrue())", "commid": "kubernetes_pr_109820"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f6b8358021d22b6a22cf92b93e9370729451ca3669c4f6afe9d84808b437dd55", "query": "ci-kubernetes-node-kubelet-serial-containerd: ci-kubernetes-node-kubelet-serial: (This is just an example, most of the tests appear to be failing) /sig node /kind failing-test /milestone v1.23 since test is failing in a release-blocking job /priority critical-urgent /assign /cc I believe this stems from\n/triage accepted These failures look weird - I don't understand why dockershim is sometimes failing after restarting the kubelet. I guess we should double check that timings match the old GPU test (I think I might've tightened them a bit, bc they were passing when I ran the device suite on the same nodes). What's weirder is that they passed on my PR and all of a sudden broke after merging\nDiscussed at today - the easiest solution now that 1.23 has been branched is to punt these tests out of the serial lane so we can get it green again for 1.23, since any changes at this point must be backported and we would prefer that this is not release-blocking.\n/milestone clear should address this; we won't get a fresh serial run for another ~6 hours so let's confirm next business day that this is temporarily fixed.\n/remove-priority critical-urgent /priority important-longterm\ncan we keep it in the milestone until we get a verified green run?\nCI is green today after skipping DevicePluginProbe tests .\n/assign Maybe related to\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nLooks like serial has been stable for a while, closing: /close\nClosing this issue. <detailsIn response to : Looks like serial has been stable for a while, closing: Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/reopen it is referred to here: Tests are skipped today\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ndid you have a chance to look at this? I remember you were close to understanding on what is going wrong here\noh welp, missed that\nI was (past tense) but now I need to go back and look at my notes. If someone else wants to take over, be my guest, I've been quite busy with other tasks lately. Otherwise I'll get back to this!\nSo! I'm able to resume working in this area. So I'm testing last k/k master branch tip and running with : and the tests seems to be running and passing quite reliably! (5 times in a row seems like a promising start :) ) To move forward I suggest to: a explicit s in . This will make more evident we have a pending issue in our camp, that's the most egregious exception we have and it's confusing the skip in the config: - this will enable us to do focused work in this area a PR to remove the skip and iterate over it running CI until it's good enough I can take care of all the above. If CI is still failing, we need to explore possible missing/wrong configuration, but then other e2enode tests should be failing, not just this one.\nI agree, this plan sounds good. Thank you!\nxref:\nstarted to fail also locally - we have baremetal lanes in RH - in the project CI they skip the relevant test. Investigating a possible common root cause\nafter a very long troubleshooting and quite few attempts, is ready for review", "positive_passages": [{"docid": "doc-en-kubernetes-5d480d5cd96dc34e1d7d2c7cc056d0dbf4d772571e1fdd0c8e810ac7cf08d1bc", "text": "return &nodeList.Items[0] } <ins> // getLocalTestNode fetches the node object describing the local worker node set up by the e2e_node infra, alongside with its ready state. // getLocalTestNode is a variant of `getLocalNode` which reports but does not set any requirement about the node readiness state, letting // the caller decide. The check is intentionally done like `getLocalNode` does. // Note `getLocalNode` aborts (as in ginkgo.Expect) the test implicitly if the worker node is not ready. func getLocalTestNode(f *framework.Framework) (*v1.Node, bool) { node, err := f.ClientSet.CoreV1().Nodes().Get(context.TODO(), framework.TestContext.NodeName, metav1.GetOptions{}) framework.ExpectNoError(err) ready := e2enode.IsNodeReady(node) schedulable := e2enode.IsNodeSchedulable(node) framework.Logf(\"node %q ready=%v schedulable=%v\", node.Name, ready, schedulable) return node, ready && schedulable } </ins> // logKubeletLatencyMetrics logs KubeletLatencyMetrics computed from the Prometheus // metrics exposed on the current node and identified by the metricNames. // The Kubelet subsystem prefix is automatically prepended to these metric names.", "commid": "kubernetes_pr_109820"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bc1f56f76d806f780c64417014c4b072addf1f4df6d254dd55319774f349a24c", "query": "Flaked a couple of times on serial lane with the same error. Test is relatively new. This run only has the single test flake: /sig node /kind flake /cc\n/assign\nNew recent failures: /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-b6c11e1973260c6dbb785cff750d65221e758c441f6056d42030c965a64ad8e7", "text": "\"strconv\" \"time\" <ins> apierrors \"k8s.io/apimachinery/pkg/api/errors\" </ins> \"k8s.io/apimachinery/pkg/fields\" \"github.com/onsi/ginkgo\"", "commid": "kubernetes_pr_106671"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bc1f56f76d806f780c64417014c4b072addf1f4df6d254dd55319774f349a24c", "query": "Flaked a couple of times on serial lane with the same error. Test is relatively new. This run only has the single test flake: /sig node /kind flake /cc\n/assign\nNew recent failures: /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-49ac6e2a8d890b23d5b546431f225c35995e5a6452fe78a76f10a0729c7c9561", "text": "ginkgo.Context(\"when gracefully shutting down with Pod priority\", func() { const ( <del> pollInterval           = 1 * time.Second podStatusUpdateTimeout = 10 * time.Second </del> <ins> pollInterval                 = 1 * time.Second podStatusUpdateTimeout       = 10 * time.Second priorityClassesCreateTimeout = 10 * time.Second </ins> ) var (", "commid": "kubernetes_pr_106671"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bc1f56f76d806f780c64417014c4b072addf1f4df6d254dd55319774f349a24c", "query": "Flaked a couple of times on serial lane with the same error. Test is relatively new. This run only has the single test flake: /sig node /kind flake /cc\n/assign\nNew recent failures: /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-f8a8e302e4a026e47c36fdce91d3ad335d8e6dc9a8eb510585ee0081875bf364", "text": "ginkgo.By(\"Wait for the node to be ready\") waitForNodeReady() <del> for _, customClass := range []*schedulingv1.PriorityClass{customClassA, customClassB, customClassC} { </del> <ins> customClasses := []*schedulingv1.PriorityClass{customClassA, customClassB, customClassC} for _, customClass := range customClasses { </ins> _, err := f.ClientSet.SchedulingV1().PriorityClasses().Create(context.Background(), customClass, metav1.CreateOptions{}) <del> framework.ExpectNoError(err) </del> <ins> if err != nil && !apierrors.IsAlreadyExists(err) { framework.ExpectNoError(err) } </ins> } <ins> gomega.Eventually(func() error { for _, customClass := range customClasses { _, err := f.ClientSet.SchedulingV1().PriorityClasses().Get(context.Background(), customClass.Name, metav1.GetOptions{}) if err != nil { return err } } return nil }, priorityClassesCreateTimeout, pollInterval).Should(gomega.BeNil()) </ins> }) ginkgo.AfterEach(func() {", "commid": "kubernetes_pr_106671"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-828b2f2bc9a1c73b1b130d20e1091ab566168df681bda6f542cc66f3f230828b", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --<!-- Please assign a SIG using: /sig SIG-NAME --\n/sig cli\nThere may have two issues to fix: doesn't support run with assertion must check whether schema is nil first\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-b589a3169e02c1097257359b4f95fd09f5319a70b544edb41b1960eae6fb1150", "text": "It(\"should lookup the Schema by its GroupVersionKind\", func() { schema = resources.LookupResource(gvk) Expect(schema).ToNot(BeNil()) <del> }) var deployment *proto.Kind It(\"should be a Kind\", func() { deployment = schema.(*proto.Kind) Expect(deployment).ToNot(BeNil()) </del> <ins> Expect(schema.(*proto.Kind)).ToNot(BeNil()) </ins> }) })", "commid": "kubernetes_pr_106762"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-828b2f2bc9a1c73b1b130d20e1091ab566168df681bda6f542cc66f3f230828b", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --<!-- Please assign a SIG using: /sig SIG-NAME --\n/sig cli\nThere may have two issues to fix: doesn't support run with assertion must check whether schema is nil first\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-8ab764be11aaaa9d4a3094e05c9736abb48eee1f9fdef6bb0be64fcb7e5b11a7", "text": "It(\"should lookup the Schema by its GroupVersionKind\", func() { schema = resources.LookupResource(gvk) Expect(schema).ToNot(BeNil()) <del> }) var sarspec *proto.Kind It(\"should be a Kind and have a spec\", func() { </del> sar := schema.(*proto.Kind) Expect(sar).ToNot(BeNil()) Expect(sar.Fields).To(HaveKey(\"spec\")) specRef := sar.Fields[\"spec\"].(proto.Reference) Expect(specRef).ToNot(BeNil()) Expect(specRef.Reference()).To(Equal(\"io.k8s.api.authorization.v1.SubjectAccessReviewSpec\")) <del> sarspec = specRef.SubSchema().(*proto.Kind) Expect(sarspec).ToNot(BeNil()) </del> <ins> Expect(specRef.SubSchema().(*proto.Kind)).ToNot(BeNil()) </ins> }) })", "commid": "kubernetes_pr_106762"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b00d4aab62f403b854c1a0aa3c8ac8b12f2203f1df9b02fc2cc1a8c8fa361c58", "query": "gce-master-scale-correctness Kubernetes e2e suite.[sig-network] Networking Granular Checks: Services should update nodePort: udp [Slow] ci-kubernetes-e2e-gce-scale-correctness.Overall kubetest.Test Kubernetes e2e suite.[sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: Dynamic PV (filesystem volmode)] volumeMode should not mount / map unused volumes in a pod [LinuxOnly] Kubernetes e2e suite.[sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: Generic Ephemeral-volume (default fs) (late-binding)] ephemeral should support two pods which have the same volume definition Kubernetes e2e suite.[sig-network] Services should be able to update service type to NodePort listening on same port number but different protocols 12/1/2021 17:36:39 ET No response No response /sig storage /sig network\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/milestone v1.23 /priority important-soon\n/assign aojea\n/assign bowei\nheh, what are the chances, two different test services took the same port The test was expecting to not receive any answer but the second service replies and makes the test fail link", "positive_passages": [{"docid": "doc-en-kubernetes-6ea79a38b83c00c5846821fa1cda075b055c7b3205f257b01c48086cc057b6aa", "text": "config.DeleteNodePortService() ginkgo.By(fmt.Sprintf(\"dialing(http) %v (node) --> %v:%v (nodeIP) and getting ZERO host endpoints\", config.NodeIP, config.NodeIP, config.NodeHTTPPort)) <del> err = config.DialFromNode(\"http\", config.NodeIP, config.NodeHTTPPort, config.MaxTries, config.MaxTries, sets.NewString()) </del> <ins> // #106770 MaxTries can be very large on large clusters, with the risk that a new NodePort is created by another test and start to answer traffic. // Since we only want to assert that traffic is not being forwarded anymore and the retry timeout is 2 seconds, consider the test is correct // if the service doesn't answer after 10 tries. err = config.DialFromNode(\"http\", config.NodeIP, config.NodeHTTPPort, 10, 10, sets.NewString()) </ins> if err != nil { <del> framework.Failf(\"Error dialing http from node: %v\", err) </del> <ins> framework.Failf(\"Failure validating that node port service STOPPED removed properly: %v\", err) </ins> } })", "commid": "kubernetes_pr_106990"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b00d4aab62f403b854c1a0aa3c8ac8b12f2203f1df9b02fc2cc1a8c8fa361c58", "query": "gce-master-scale-correctness Kubernetes e2e suite.[sig-network] Networking Granular Checks: Services should update nodePort: udp [Slow] ci-kubernetes-e2e-gce-scale-correctness.Overall kubetest.Test Kubernetes e2e suite.[sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: Dynamic PV (filesystem volmode)] volumeMode should not mount / map unused volumes in a pod [LinuxOnly] Kubernetes e2e suite.[sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: Generic Ephemeral-volume (default fs) (late-binding)] ephemeral should support two pods which have the same volume definition Kubernetes e2e suite.[sig-network] Services should be able to update service type to NodePort listening on same port number but different protocols 12/1/2021 17:36:39 ET No response No response /sig storage /sig network\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/milestone v1.23 /priority important-soon\n/assign aojea\n/assign bowei\nheh, what are the chances, two different test services took the same port The test was expecting to not receive any answer but the second service replies and makes the test fail link", "positive_passages": [{"docid": "doc-en-kubernetes-c2bbd4cb941e47164c70a3f504c70123a27df1105c78d640952b40c60a7ffa82", "text": "config.DeleteNodePortService() ginkgo.By(fmt.Sprintf(\"dialing(udp) %v (node) --> %v:%v (nodeIP) and getting ZERO host endpoints\", config.NodeIP, config.NodeIP, config.NodeUDPPort)) <del> err = config.DialFromNode(\"udp\", config.NodeIP, config.NodeUDPPort, config.MaxTries, config.MaxTries, sets.NewString()) </del> <ins> // #106770 MaxTries can be very large on large clusters, with the risk that a new NodePort is created by another test and start to answer traffic. // Since we only want to assert that traffic is not being forwarded anymore and the retry timeout is 2 seconds, consider the test is correct // if the service doesn't answer after 10 tries. err = config.DialFromNode(\"udp\", config.NodeIP, config.NodeUDPPort, 10, 10, sets.NewString()) </ins> if err != nil { framework.Failf(\"Failure validating that node port service STOPPED removed properly: %v\", err) }", "commid": "kubernetes_pr_106990"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a058229eb86de6555a991f0b180b07c42b35b29d04a1ae7b1d2febd668ac9b4", "query": "During a Kubernetes deployment the connectivity to web services from Windows nodes is flapping. There are intermittent traffic delays and some errors observed on web services during the deployment. Post deployment the flapping is no longer observed. No flapping in connectivity during the deployment. Create a deployment with multiple services and monitor connectivity. No response <details20 </details<detailsAKS </details<details</details<details</details<details</details<details</details\n/sig windows\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-3cfff5af395b0993b3400a88df8c1dd60519585e5cb62f28063d354aa48aa115", "text": "if svcInfo.preserveDIP || svcInfo.localTrafficDSR { nodePortEndpoints = hnsLocalEndpoints } <del> hnsLoadBalancer, err := hns.getLoadBalancer( nodePortEndpoints, loadBalancerFlags{isDSR: svcInfo.localTrafficDSR, localRoutedVIP: true, sessionAffinity: sessionAffinityClientIP, isIPv6: proxier.isIPv6Mode}, sourceVip, \"\", Enum(svcInfo.Protocol()), uint16(svcInfo.targetPort), uint16(svcInfo.NodePort()), ) if err != nil { klog.ErrorS(err, \"Policy creation failed\") continue } svcInfo.nodePorthnsID = hnsLoadBalancer.hnsID klog.V(3).InfoS(\"Hns LoadBalancer resource created for nodePort resources\", \"clusterIP\", svcInfo.ClusterIP(), \"hnsID\", hnsLoadBalancer.hnsID) </del> <ins> if len(nodePortEndpoints) > 0 { hnsLoadBalancer, err := hns.getLoadBalancer( nodePortEndpoints, loadBalancerFlags{isDSR: svcInfo.localTrafficDSR, localRoutedVIP: true, sessionAffinity: sessionAffinityClientIP, isIPv6: proxier.isIPv6Mode}, sourceVip, \"\", Enum(svcInfo.Protocol()), uint16(svcInfo.targetPort), uint16(svcInfo.NodePort()), ) if err != nil { klog.ErrorS(err, \"Policy creation failed\") continue } svcInfo.nodePorthnsID = hnsLoadBalancer.hnsID klog.V(3).InfoS(\"Hns LoadBalancer resource created for nodePort resources\", \"clusterIP\", svcInfo.ClusterIP(), \"nodeport\", svcInfo.NodePort(), \"hnsID\", hnsLoadBalancer.hnsID) } else { klog.V(3).InfoS(\"Skipped creating Hns LoadBalancer for nodePort resources\", \"clusterIP\", svcInfo.ClusterIP(), \"nodeport\", svcInfo.NodePort(), \"hnsID\", hnsLoadBalancer.hnsID) } </ins> } // Create a Load Balancer Policy for each external IP", "commid": "kubernetes_pr_106936"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a058229eb86de6555a991f0b180b07c42b35b29d04a1ae7b1d2febd668ac9b4", "query": "During a Kubernetes deployment the connectivity to web services from Windows nodes is flapping. There are intermittent traffic delays and some errors observed on web services during the deployment. Post deployment the flapping is no longer observed. No flapping in connectivity during the deployment. Create a deployment with multiple services and monitor connectivity. No response <details20 </details<detailsAKS </details<details</details<details</details<details</details<details</details\n/sig windows\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-2a450238b9d6a00c9449ae99197daa01df736ee5bb8effc48c60739dcdb1dd61", "text": "if svcInfo.localTrafficDSR { externalIPEndpoints = hnsLocalEndpoints } <del> // Try loading existing policies, if already available hnsLoadBalancer, err = hns.getLoadBalancer( externalIPEndpoints, loadBalancerFlags{isDSR: svcInfo.localTrafficDSR, sessionAffinity: sessionAffinityClientIP, isIPv6: proxier.isIPv6Mode}, sourceVip, externalIP.ip, Enum(svcInfo.Protocol()), uint16(svcInfo.targetPort), uint16(svcInfo.Port()), ) if err != nil { klog.ErrorS(err, \"Policy creation failed\") continue </del> <ins> if len(externalIPEndpoints) > 0 { // Try loading existing policies, if already available hnsLoadBalancer, err = hns.getLoadBalancer( externalIPEndpoints, loadBalancerFlags{isDSR: svcInfo.localTrafficDSR, sessionAffinity: sessionAffinityClientIP, isIPv6: proxier.isIPv6Mode}, sourceVip, externalIP.ip, Enum(svcInfo.Protocol()), uint16(svcInfo.targetPort), uint16(svcInfo.Port()), ) if err != nil { klog.ErrorS(err, \"Policy creation failed\") continue } externalIP.hnsID = hnsLoadBalancer.hnsID klog.V(3).InfoS(\"Hns LoadBalancer resource created for externalIP resources\", \"externalIP\", externalIP, \"hnsID\", hnsLoadBalancer.hnsID) } else { klog.V(3).InfoS(\"Skipped creating Hns LoadBalancer for externalIP resources\", \"externalIP\", externalIP, \"hnsID\", hnsLoadBalancer.hnsID) </ins> } <del> externalIP.hnsID = hnsLoadBalancer.hnsID klog.V(3).InfoS(\"Hns LoadBalancer resource created for externalIP resources\", \"externalIP\", externalIP, \"hnsID\", hnsLoadBalancer.hnsID) </del> } // Create a Load Balancer Policy for each loadbalancer ingress for _, lbIngressIP := range svcInfo.loadBalancerIngressIPs {", "commid": "kubernetes_pr_106936"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a058229eb86de6555a991f0b180b07c42b35b29d04a1ae7b1d2febd668ac9b4", "query": "During a Kubernetes deployment the connectivity to web services from Windows nodes is flapping. There are intermittent traffic delays and some errors observed on web services during the deployment. Post deployment the flapping is no longer observed. No flapping in connectivity during the deployment. Create a deployment with multiple services and monitor connectivity. No response <details20 </details<detailsAKS </details<details</details<details</details<details</details<details</details\n/sig windows\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-9a5e74672d1d68e9d613ea72b5be4b40577b94510a449e59dc265167204e6fd5", "text": "if svcInfo.preserveDIP || svcInfo.localTrafficDSR { lbIngressEndpoints = hnsLocalEndpoints } <del> hnsLoadBalancer, err := hns.getLoadBalancer( lbIngressEndpoints, loadBalancerFlags{isDSR: svcInfo.preserveDIP || svcInfo.localTrafficDSR, useMUX: svcInfo.preserveDIP, preserveDIP: svcInfo.preserveDIP, sessionAffinity: sessionAffinityClientIP, isIPv6: proxier.isIPv6Mode}, sourceVip, lbIngressIP.ip, Enum(svcInfo.Protocol()), uint16(svcInfo.targetPort), uint16(svcInfo.Port()), ) if err != nil { klog.ErrorS(err, \"Policy creation failed\") continue </del> <ins> if len(lbIngressEndpoints) > 0 { hnsLoadBalancer, err := hns.getLoadBalancer( lbIngressEndpoints, loadBalancerFlags{isDSR: svcInfo.preserveDIP || svcInfo.localTrafficDSR, useMUX: svcInfo.preserveDIP, preserveDIP: svcInfo.preserveDIP, sessionAffinity: sessionAffinityClientIP, isIPv6: proxier.isIPv6Mode}, sourceVip, lbIngressIP.ip, Enum(svcInfo.Protocol()), uint16(svcInfo.targetPort), uint16(svcInfo.Port()), ) if err != nil { klog.ErrorS(err, \"Policy creation failed\") continue } lbIngressIP.hnsID = hnsLoadBalancer.hnsID klog.V(3).InfoS(\"Hns LoadBalancer resource created for loadBalancer Ingress resources\", \"lbIngressIP\", lbIngressIP) } else { klog.V(3).InfoS(\"Skipped creating Hns LoadBalancer for loadBalancer Ingress resources\", \"lbIngressIP\", lbIngressIP) </ins> } <del> lbIngressIP.hnsID = hnsLoadBalancer.hnsID klog.V(3).InfoS(\"Hns LoadBalancer resource created for loadBalancer Ingress resources\", \"lbIngressIP\", lbIngressIP) </del> } svcInfo.policyApplied = true klog.V(2).InfoS(\"Policy successfully applied for service\", \"serviceInfo\", svcInfo)", "commid": "kubernetes_pr_106936"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e7e95e6f142ca39e6e3ca0b78c3932bd6cbdfdc898eed9d3ffda27d28f904c7", "query": "We should make the change in PR API reference links to should use HTTPS, not HTTP Visit h and look at the IANA hyperlinks Once this fix is made, a PR to is needed to update the docs (by autogenerating them). This typically would be deferred until the next Kubernetes release. v1.23 not applicable not applicable not applicable not applicable not applicable\n/sig docs\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI opened this issue so that someone else can open a new PR that is equivalent to .\n/retitle Update links to IANA for Service Name and Transport Protocol Port Number Registry\nI would like to work on this issue. May I assign it to myself?\nAnyone - including you - is welcome to work on this issue! So long as you've you can open a pull request to propose a fix.\nThanks\n/assign\nI have made the PR. I hope this works. If not then will be happy to do the necessary changes.\nHad to close the previous PR because of issues, here is the new one I made.", "positive_passages": [{"docid": "doc-en-kubernetes-c25610b7503458d6b99b3fe26dc1c64d544038ba8ce3768c0663c098c74b7bea", "text": "\"description\": \"EndpointPort is a tuple that describes a single port.\", \"properties\": { \"appProtocol\": { <del> \"description\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and http://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </del> <ins> \"description\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and https://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </ins> \"type\": \"string\" }, \"name\": {", "commid": "kubernetes_pr_107603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e7e95e6f142ca39e6e3ca0b78c3932bd6cbdfdc898eed9d3ffda27d28f904c7", "query": "We should make the change in PR API reference links to should use HTTPS, not HTTP Visit h and look at the IANA hyperlinks Once this fix is made, a PR to is needed to update the docs (by autogenerating them). This typically would be deferred until the next Kubernetes release. v1.23 not applicable not applicable not applicable not applicable not applicable\n/sig docs\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI opened this issue so that someone else can open a new PR that is equivalent to .\n/retitle Update links to IANA for Service Name and Transport Protocol Port Number Registry\nI would like to work on this issue. May I assign it to myself?\nAnyone - including you - is welcome to work on this issue! So long as you've you can open a pull request to propose a fix.\nThanks\n/assign\nI have made the PR. I hope this works. If not then will be happy to do the necessary changes.\nHad to close the previous PR because of issues, here is the new one I made.", "positive_passages": [{"docid": "doc-en-kubernetes-2cf7a7938161786550a8a4b636fc5d4c20ddad13464a0c5da2fc3af4ce8d640f", "text": "\"description\": \"ServicePort contains information on service's port.\", \"properties\": { \"appProtocol\": { <del> \"description\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and http://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </del> <ins> \"description\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and https://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </ins> \"type\": \"string\" }, \"name\": {", "commid": "kubernetes_pr_107603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e7e95e6f142ca39e6e3ca0b78c3932bd6cbdfdc898eed9d3ffda27d28f904c7", "query": "We should make the change in PR API reference links to should use HTTPS, not HTTP Visit h and look at the IANA hyperlinks Once this fix is made, a PR to is needed to update the docs (by autogenerating them). This typically would be deferred until the next Kubernetes release. v1.23 not applicable not applicable not applicable not applicable not applicable\n/sig docs\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI opened this issue so that someone else can open a new PR that is equivalent to .\n/retitle Update links to IANA for Service Name and Transport Protocol Port Number Registry\nI would like to work on this issue. May I assign it to myself?\nAnyone - including you - is welcome to work on this issue! So long as you've you can open a pull request to propose a fix.\nThanks\n/assign\nI have made the PR. I hope this works. If not then will be happy to do the necessary changes.\nHad to close the previous PR because of issues, here is the new one I made.", "positive_passages": [{"docid": "doc-en-kubernetes-54fbd2d1f5d7308a7d9c0757a250f7dc6544bbe50e57ad3ca55c662fff5a372e", "text": "\"name\":        \"The name of this port.  This must match the 'name' field in the corresponding ServicePort. Must be a DNS_LABEL. Optional only if one port is defined.\", \"port\":        \"The port number of the endpoint.\", \"protocol\":    \"The IP protocol for this port. Must be UDP, TCP, or SCTP. Default is TCP.\", <del> \"appProtocol\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and http://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </del> <ins> \"appProtocol\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and https://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </ins> } func (EndpointPort) SwaggerDoc() map[string]string {", "commid": "kubernetes_pr_107603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e7e95e6f142ca39e6e3ca0b78c3932bd6cbdfdc898eed9d3ffda27d28f904c7", "query": "We should make the change in PR API reference links to should use HTTPS, not HTTP Visit h and look at the IANA hyperlinks Once this fix is made, a PR to is needed to update the docs (by autogenerating them). This typically would be deferred until the next Kubernetes release. v1.23 not applicable not applicable not applicable not applicable not applicable\n/sig docs\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI opened this issue so that someone else can open a new PR that is equivalent to .\n/retitle Update links to IANA for Service Name and Transport Protocol Port Number Registry\nI would like to work on this issue. May I assign it to myself?\nAnyone - including you - is welcome to work on this issue! So long as you've you can open a pull request to propose a fix.\nThanks\n/assign\nI have made the PR. I hope this works. If not then will be happy to do the necessary changes.\nHad to close the previous PR because of issues, here is the new one I made.", "positive_passages": [{"docid": "doc-en-kubernetes-1b35d6083434fc17e65853be19d37f2c51553ed9f09eb75daac77301bfae7638", "text": "\"\":            \"ServicePort contains information on service's port.\", \"name\":        \"The name of this port within the service. This must be a DNS_LABEL. All ports within a ServiceSpec must have unique names. When considering the endpoints for a Service, this must match the 'name' field in the EndpointPort. Optional if only one ServicePort is defined on this service.\", \"protocol\":    \"The IP protocol for this port. Supports \"TCP\", \"UDP\", and \"SCTP\". Default is TCP.\", <del> \"appProtocol\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and http://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </del> <ins> \"appProtocol\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and https://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </ins> \"port\":        \"The port that will be exposed by this service.\", \"targetPort\":  \"Number or name of the port to access on the pods targeted by the service. Number must be in the range 1 to 65535. Name must be an IANA_SVC_NAME. If this is a string, it will be looked up as a named port in the target Pod's container ports. If this is not specified, the value of the 'port' field is used (an identity map). This field is ignored for services with clusterIP=None, and should be omitted or set equal to the 'port' field. More info: https://kubernetes.io/docs/concepts/services-networking/service/#defining-a-service\", \"nodePort\":    \"The port on each node on which this service is exposed when type is NodePort or LoadBalancer.  Usually assigned by the system. If a value is specified, in-range, and not in use it will be used, otherwise the operation will fail.  If not specified, a port will be allocated if this Service requires one.  If this field is specified when creating a Service which does not need it, creation will fail. This field will be wiped when updating a Service to no longer need it (e.g. changing type from NodePort to ClusterIP). More info: https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport\",", "commid": "kubernetes_pr_107603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e7e95e6f142ca39e6e3ca0b78c3932bd6cbdfdc898eed9d3ffda27d28f904c7", "query": "We should make the change in PR API reference links to should use HTTPS, not HTTP Visit h and look at the IANA hyperlinks Once this fix is made, a PR to is needed to update the docs (by autogenerating them). This typically would be deferred until the next Kubernetes release. v1.23 not applicable not applicable not applicable not applicable not applicable\n/sig docs\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI opened this issue so that someone else can open a new PR that is equivalent to .\n/retitle Update links to IANA for Service Name and Transport Protocol Port Number Registry\nI would like to work on this issue. May I assign it to myself?\nAnyone - including you - is welcome to work on this issue! So long as you've you can open a pull request to propose a fix.\nThanks\n/assign\nI have made the PR. I hope this works. If not then will be happy to do the necessary changes.\nHad to close the previous PR because of issues, here is the new one I made.", "positive_passages": [{"docid": "doc-en-kubernetes-4baabd3b0850d356278c598613dfd94ed7ea2eeb31a45735bb0a9d84ac12a444", "text": "// The application protocol for this port. // This field follows standard Kubernetes label syntax. // Un-prefixed names are reserved for IANA standard service names (as per <del> // RFC-6335 and http://www.iana.org/assignments/service-names). </del> <ins> // RFC-6335 and https://www.iana.org/assignments/service-names). </ins> // Non-standard protocols should use prefixed names such as // mycompany.com/my-custom-protocol. // +optional", "commid": "kubernetes_pr_107603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e7e95e6f142ca39e6e3ca0b78c3932bd6cbdfdc898eed9d3ffda27d28f904c7", "query": "We should make the change in PR API reference links to should use HTTPS, not HTTP Visit h and look at the IANA hyperlinks Once this fix is made, a PR to is needed to update the docs (by autogenerating them). This typically would be deferred until the next Kubernetes release. v1.23 not applicable not applicable not applicable not applicable not applicable\n/sig docs\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI opened this issue so that someone else can open a new PR that is equivalent to .\n/retitle Update links to IANA for Service Name and Transport Protocol Port Number Registry\nI would like to work on this issue. May I assign it to myself?\nAnyone - including you - is welcome to work on this issue! So long as you've you can open a pull request to propose a fix.\nThanks\n/assign\nI have made the PR. I hope this works. If not then will be happy to do the necessary changes.\nHad to close the previous PR because of issues, here is the new one I made.", "positive_passages": [{"docid": "doc-en-kubernetes-e37adc53cafd89f74bfb02f5c90d82fadbfcdcad19c3f189c8ae1c8bb0a8ca3d", "text": "\"name\":        \"The name of this port. All ports in an EndpointSlice must have a unique name. If the EndpointSlice is dervied from a Kubernetes service, this corresponds to the Service.ports[].name. Name must either be an empty string or pass DNS_LABEL validation: * must be no more than 63 characters long. * must consist of lower case alphanumeric characters or '-'. * must start and end with an alphanumeric character. Default is empty string.\", \"protocol\":    \"The IP protocol for this port. Must be UDP, TCP, or SCTP. Default is TCP.\", \"port\":        \"The port number of the endpoint. If this is not specified, ports are not restricted and must be interpreted in the context of the specific consumer.\", <del> \"appProtocol\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and http://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </del> <ins> \"appProtocol\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and https://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </ins> } func (EndpointPort) SwaggerDoc() map[string]string {", "commid": "kubernetes_pr_107603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e7e95e6f142ca39e6e3ca0b78c3932bd6cbdfdc898eed9d3ffda27d28f904c7", "query": "We should make the change in PR API reference links to should use HTTPS, not HTTP Visit h and look at the IANA hyperlinks Once this fix is made, a PR to is needed to update the docs (by autogenerating them). This typically would be deferred until the next Kubernetes release. v1.23 not applicable not applicable not applicable not applicable not applicable\n/sig docs\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI opened this issue so that someone else can open a new PR that is equivalent to .\n/retitle Update links to IANA for Service Name and Transport Protocol Port Number Registry\nI would like to work on this issue. May I assign it to myself?\nAnyone - including you - is welcome to work on this issue! So long as you've you can open a pull request to propose a fix.\nThanks\n/assign\nI have made the PR. I hope this works. If not then will be happy to do the necessary changes.\nHad to close the previous PR because of issues, here is the new one I made.", "positive_passages": [{"docid": "doc-en-kubernetes-718a96f0663797fccf6cec1365e3d1ffc94cc79229396dcfcd62a7941b8f333f", "text": "\"description\": \"EndpointPort is a tuple that describes a single port.\", \"properties\": { \"appProtocol\": { <del> \"description\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and http://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol. This is a beta field that is guarded by the ServiceAppProtocol feature gate and enabled by default.\", </del> <ins> \"description\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and https://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol. This is a beta field that is guarded by the ServiceAppProtocol feature gate and enabled by default.\", </ins> \"type\": \"string\" }, \"name\": {", "commid": "kubernetes_pr_107603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e7e95e6f142ca39e6e3ca0b78c3932bd6cbdfdc898eed9d3ffda27d28f904c7", "query": "We should make the change in PR API reference links to should use HTTPS, not HTTP Visit h and look at the IANA hyperlinks Once this fix is made, a PR to is needed to update the docs (by autogenerating them). This typically would be deferred until the next Kubernetes release. v1.23 not applicable not applicable not applicable not applicable not applicable\n/sig docs\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI opened this issue so that someone else can open a new PR that is equivalent to .\n/retitle Update links to IANA for Service Name and Transport Protocol Port Number Registry\nI would like to work on this issue. May I assign it to myself?\nAnyone - including you - is welcome to work on this issue! So long as you've you can open a pull request to propose a fix.\nThanks\n/assign\nI have made the PR. I hope this works. If not then will be happy to do the necessary changes.\nHad to close the previous PR because of issues, here is the new one I made.", "positive_passages": [{"docid": "doc-en-kubernetes-29ad0ed9eda1bf1ef6a60e1452ab272ffb32160d08160a2c8396de4e3b885024", "text": "\"description\": \"ServicePort contains information on service's port.\", \"properties\": { \"appProtocol\": { <del> \"description\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and http://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol. This is a beta field that is guarded by the ServiceAppProtocol feature gate and enabled by default.\", </del> <ins> \"description\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and https://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol. This is a beta field that is guarded by the ServiceAppProtocol feature gate and enabled by default.\", </ins> \"type\": \"string\" }, \"name\": {", "commid": "kubernetes_pr_107603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e7e95e6f142ca39e6e3ca0b78c3932bd6cbdfdc898eed9d3ffda27d28f904c7", "query": "We should make the change in PR API reference links to should use HTTPS, not HTTP Visit h and look at the IANA hyperlinks Once this fix is made, a PR to is needed to update the docs (by autogenerating them). This typically would be deferred until the next Kubernetes release. v1.23 not applicable not applicable not applicable not applicable not applicable\n/sig docs\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI opened this issue so that someone else can open a new PR that is equivalent to .\n/retitle Update links to IANA for Service Name and Transport Protocol Port Number Registry\nI would like to work on this issue. May I assign it to myself?\nAnyone - including you - is welcome to work on this issue! So long as you've you can open a pull request to propose a fix.\nThanks\n/assign\nI have made the PR. I hope this works. If not then will be happy to do the necessary changes.\nHad to close the previous PR because of issues, here is the new one I made.", "positive_passages": [{"docid": "doc-en-kubernetes-05c4e6878112ce64375041da94bbd0932ff7432bb56daa057f00523a0683a935", "text": "\"description\": \"EndpointPort represents a Port used by an EndpointSlice\", \"properties\": { \"appProtocol\": { <del> \"description\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and http://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </del> <ins> \"description\": \"The application protocol for this port. This field follows standard Kubernetes label syntax. Un-prefixed names are reserved for IANA standard service names (as per RFC-6335 and https://www.iana.org/assignments/service-names). Non-standard protocols should use prefixed names such as mycompany.com/my-custom-protocol.\", </ins> \"type\": \"string\" }, \"name\": {", "commid": "kubernetes_pr_107603"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2214f549829b0bccc5ce423eaca68e7f13803c72fd2591e1ab24d03ad7fdf316", "query": "Condition PIDPressure is not set to true when the system thread number exceeds even it's reaching the limit. Condition PIDPressure is set to true correctly See cause below The bug is due to , which truncates any process number greater than because of type conversion. See kernel code . Reading it from should be working. v1.23.1 <detailsNA </details<details</details<details</details<details</details<details</details\n/sig node\n/triage accepted /priority important-longterm", "positive_passages": [{"docid": "doc-en-kubernetes-613ff8d7d82ee6f9e921fa3c265023d71f34c8bf3ed937125c57e43ee40d455d", "text": "package pidlimit import ( <ins> \"fmt\" </ins> \"io/ioutil\" \"strconv\" <ins> \"strings\" </ins> \"syscall\" \"time\" <del> \"k8s.io/apimachinery/pkg/apis/meta/v1\" </del> <ins> v1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" </ins> statsapi \"k8s.io/kubelet/pkg/apis/stats/v1alpha1\" )", "commid": "kubernetes_pr_107108"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2214f549829b0bccc5ce423eaca68e7f13803c72fd2591e1ab24d03ad7fdf316", "query": "Condition PIDPressure is not set to true when the system thread number exceeds even it's reaching the limit. Condition PIDPressure is set to true correctly See cause below The bug is due to , which truncates any process number greater than because of type conversion. See kernel code . Reading it from should be working. v1.23.1 <detailsNA </details<details</details<details</details<details</details<details</details\n/sig node\n/triage accepted /priority important-longterm", "positive_passages": [{"docid": "doc-en-kubernetes-fef10ea3dbe978d2b340dd9dc02d65aba9e308241bc3cacbb54dc435fa4e7a0f", "text": "} } <del> var info syscall.Sysinfo_t syscall.Sysinfo(&info) procs := int64(info.Procs) rlimit.NumOfRunningProcesses = &procs </del> <ins> // Prefer to read \"/proc/loadavg\" when possible because sysinfo(2) // returns truncated number when greater than 65538. See // https://github.com/kubernetes/kubernetes/issues/107107 if procs, err := runningTaskCount(); err == nil { rlimit.NumOfRunningProcesses = &procs } else { var info syscall.Sysinfo_t syscall.Sysinfo(&info) procs := int64(info.Procs) rlimit.NumOfRunningProcesses = &procs } </ins> rlimit.Time = v1.NewTime(time.Now()) return rlimit, nil } <ins> func runningTaskCount() (int64, error) { // Example: 1.36 3.49 4.53 2/3518 3715089 bytes, err := ioutil.ReadFile(\"/proc/loadavg\") if err != nil { return 0, err } fields := strings.Fields(string(bytes)) if len(fields) < 5 { return 0, fmt.Errorf(\"not enough fields in /proc/loadavg\") } subfields := strings.Split(fields[3], \"/\") if len(subfields) != 2 { return 0, fmt.Errorf(\"error parsing fourth field of /proc/loadavg\") } return strconv.ParseInt(subfields[1], 10, 64) } </ins>", "commid": "kubernetes_pr_107108"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9f83a27f9592105435bbac386998288b990d6f5d165b5fe2e78e2c4c68ba6eee", "query": "There is no receive or close operation on channel of struct () . Thus, a goroutine leak happens when is executed (), such as when running . no goroutine leak run TestRunPositiveRegister() No response <details97d40890d00acf721ecabb8c9a6fec3b3234b74b and following versions </details<details</details<details</details<details</details<details</details<details</details\n/area kubelet /sig node /assign I'd try to fix it\n/sig node\nThe author has submitted a PR for this issue:\n/triage accepted /assign /priority important-longterm\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\nThe issue has been marked as an important bug and triaged. Such issues are automatically marked as frozen when hitting the rotten state to avoid missing important bugs. Please send feedback to sig-contributor-experience at . /lifecycle frozen", "positive_passages": [{"docid": "doc-en-kubernetes-40d245af514a0a9ba7664c14ea1877c3bc7c00149004318199adf1619d21799e", "text": "pluginName := fmt.Sprintf(\"example-plugin\") p := pluginwatcher.NewTestExamplePlugin(pluginName, registerapi.DevicePlugin, socketPath, supportedVersions...) require.NoError(t, p.Serve(\"v1beta1\", \"v1beta2\")) <ins> defer func() { require.NoError(t, p.Stop()) }() </ins> timestampBeforeRegistration := time.Now() dsw.AddOrUpdatePlugin(socketPath) waitForRegistration(t, socketPath, timestampBeforeRegistration, asw)", "commid": "kubernetes_pr_115617"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c3c001164d06967bffc88ae4a064b83e4730508e6212066ef72f1419123a3c10", "query": "I deployed a pod with and on a namesapace with a set with and elements and I get the error: The pod to be deployed Create a new namespace Create (using a manifest file named resource-quota-) and verify a named compute-resources Content of the resource-quota- file Create (using a manifest file named ) a pod named high-priority with the and for both and . Content of the file The pod is deployed correctly if I delete the <details</details<detailsaws </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig Scheduling\n/wg API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg API Expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg <API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg <API ExpressionInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg \"API Expression\"\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg \"API Expression\" Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg APIExpression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg APIExpression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg wg-api-expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg wg-api-expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhey, v1.18.20 is out of support now, you should try with a newer version. Besides, I tried with an old version v1.18.19, but worked as well.\nAre u using some mutating webhook which inject some sidecar into the pod without setting resources fields?\nIt's probably that, but IDK which WebHook is doing that. The feature you suggested would really help.\nhi the fix pr has been merged, maybe u could use it to locate which container is causing the problem.\nThanks", "positive_passages": [{"docid": "doc-en-kubernetes-bdb61d976ccb6b458de9ce949c6ad7f92abf9a8256fffa8a303d053903885b4a", "text": "// validation with resource counting, but we did this before QoS was even defined. // let's not make that mistake again with other resources now that QoS is defined. requiredSet := quota.ToSet(required).Intersection(validationSet) <del> missingSet := sets.NewString() </del> <ins> missingSetResourceToContainerNames := make(map[string]sets.String) </ins> for i := range pod.Spec.Containers { <del> enforcePodContainerConstraints(&pod.Spec.Containers[i], requiredSet, missingSet) </del> <ins> enforcePodContainerConstraints(&pod.Spec.Containers[i], requiredSet, missingSetResourceToContainerNames) </ins> } for i := range pod.Spec.InitContainers { <del> enforcePodContainerConstraints(&pod.Spec.InitContainers[i], requiredSet, missingSet) </del> <ins> enforcePodContainerConstraints(&pod.Spec.InitContainers[i], requiredSet, missingSetResourceToContainerNames) </ins> } <del> if len(missingSet) == 0 { </del> <ins> if len(missingSetResourceToContainerNames) == 0 { </ins> return nil } <del> return fmt.Errorf(\"must specify %s\", strings.Join(missingSet.List(), \",\")) </del> <ins> var resources = sets.NewString() for resource := range missingSetResourceToContainerNames { resources.Insert(resource) } var errorMessages = make([]string, 0, len(missingSetResourceToContainerNames)) for _, resource := range resources.List() { errorMessages = append(errorMessages, fmt.Sprintf(\"%s for: %s\", resource, strings.Join(missingSetResourceToContainerNames[resource].List(), \",\"))) } return fmt.Errorf(\"must specify %s\", strings.Join(errorMessages, \"; \")) </ins> } // GroupResource that this evaluator tracks", "commid": "kubernetes_pr_107210"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c3c001164d06967bffc88ae4a064b83e4730508e6212066ef72f1419123a3c10", "query": "I deployed a pod with and on a namesapace with a set with and elements and I get the error: The pod to be deployed Create a new namespace Create (using a manifest file named resource-quota-) and verify a named compute-resources Content of the resource-quota- file Create (using a manifest file named ) a pod named high-priority with the and for both and . Content of the file The pod is deployed correctly if I delete the <details</details<detailsaws </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig Scheduling\n/wg API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg API Expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg <API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg <API ExpressionInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg \"API Expression\"\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg \"API Expression\" Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg APIExpression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg APIExpression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg wg-api-expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg wg-api-expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhey, v1.18.20 is out of support now, you should try with a newer version. Besides, I tried with an old version v1.18.19, but worked as well.\nAre u using some mutating webhook which inject some sidecar into the pod without setting resources fields?\nIt's probably that, but IDK which WebHook is doing that. The feature you suggested would really help.\nhi the fix pr has been merged, maybe u could use it to locate which container is causing the problem.\nThanks", "positive_passages": [{"docid": "doc-en-kubernetes-c24fb137b5888fee061bd47d7a0714d1f3f0503a1e3a44650b5e230da20ddfbe", "text": "// enforcePodContainerConstraints checks for required resources that are not set on this container and // adds them to missingSet. <del> func enforcePodContainerConstraints(container *corev1.Container, requiredSet, missingSet sets.String) { </del> <ins> func enforcePodContainerConstraints(container *corev1.Container, requiredSet sets.String, missingSetResourceToContainerNames map[string]sets.String) { </ins> requests := container.Resources.Requests limits := container.Resources.Limits containerUsage := podComputeUsageHelper(requests, limits) containerSet := quota.ToSet(quota.ResourceNames(containerUsage)) if !containerSet.Equal(requiredSet) { <del> difference := requiredSet.Difference(containerSet) missingSet.Insert(difference.List()...) </del> <ins> if difference := requiredSet.Difference(containerSet); difference.Len() != 0 { for _, diff := range difference.List() { if _, ok := missingSetResourceToContainerNames[diff]; !ok { missingSetResourceToContainerNames[diff] = sets.NewString(container.Name) } else { missingSetResourceToContainerNames[diff].Insert(container.Name) } } } </ins> } }", "commid": "kubernetes_pr_107210"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c3c001164d06967bffc88ae4a064b83e4730508e6212066ef72f1419123a3c10", "query": "I deployed a pod with and on a namesapace with a set with and elements and I get the error: The pod to be deployed Create a new namespace Create (using a manifest file named resource-quota-) and verify a named compute-resources Content of the resource-quota- file Create (using a manifest file named ) a pod named high-priority with the and for both and . Content of the file The pod is deployed correctly if I delete the <details</details<detailsaws </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig Scheduling\n/wg API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg API Expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg <API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg <API ExpressionInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg \"API Expression\"\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg \"API Expression\" Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg APIExpression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg APIExpression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg wg-api-expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg wg-api-expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhey, v1.18.20 is out of support now, you should try with a newer version. Besides, I tried with an old version v1.18.19, but worked as well.\nAre u using some mutating webhook which inject some sidecar into the pod without setting resources fields?\nIt's probably that, but IDK which WebHook is doing that. The feature you suggested would really help.\nhi the fix pr has been merged, maybe u could use it to locate which container is causing the problem.\nThanks", "positive_passages": [{"docid": "doc-en-kubernetes-b2cf83809e6c4a29f4d63b1fba61a9aecdd7416d9a1977029b696834394df95e", "text": "\"time\" \"github.com/google/go-cmp/cmp\" corev1 \"k8s.io/api/core/v1\" \"k8s.io/apimachinery/pkg/api/resource\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"", "commid": "kubernetes_pr_107210"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c3c001164d06967bffc88ae4a064b83e4730508e6212066ef72f1419123a3c10", "query": "I deployed a pod with and on a namesapace with a set with and elements and I get the error: The pod to be deployed Create a new namespace Create (using a manifest file named resource-quota-) and verify a named compute-resources Content of the resource-quota- file Create (using a manifest file named ) a pod named high-priority with the and for both and . Content of the file The pod is deployed correctly if I delete the <details</details<detailsaws </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig Scheduling\n/wg API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg API Expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg <API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg <API ExpressionInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg \"API Expression\"\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg \"API Expression\" Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg APIExpression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg APIExpression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg wg-api-expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg wg-api-expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhey, v1.18.20 is out of support now, you should try with a newer version. Besides, I tried with an old version v1.18.19, but worked as well.\nAre u using some mutating webhook which inject some sidecar into the pod without setting resources fields?\nIt's probably that, but IDK which WebHook is doing that. The feature you suggested would really help.\nhi the fix pr has been merged, maybe u could use it to locate which container is causing the problem.\nThanks", "positive_passages": [{"docid": "doc-en-kubernetes-975d6394f4d72738db9fff7b98a2b75a8eab92863860c942312065b95528e947", "text": "pod: &api.Pod{ Spec: api.PodSpec{ InitContainers: []api.Container{{ <ins> Name: \"dummy\", Resources: api.ResourceRequirements{ Requests: api.ResourceList{api.ResourceCPU: resource.MustParse(\"1m\")}, Limits:   api.ResourceList{api.ResourceCPU: resource.MustParse(\"2m\")}, }, }}, }, }, required: []corev1.ResourceName{corev1.ResourceMemory}, err:      `must specify memory for: dummy`, }, \"multiple init container resource missing\": { pod: &api.Pod{ Spec: api.PodSpec{ InitContainers: []api.Container{{ Name: \"foo\", Resources: api.ResourceRequirements{ Requests: api.ResourceList{api.ResourceCPU: resource.MustParse(\"1m\")}, Limits:   api.ResourceList{api.ResourceCPU: resource.MustParse(\"2m\")}, }, }, { Name: \"bar\", </ins> Resources: api.ResourceRequirements{ Requests: api.ResourceList{api.ResourceCPU: resource.MustParse(\"1m\")}, Limits:   api.ResourceList{api.ResourceCPU: resource.MustParse(\"2m\")},", "commid": "kubernetes_pr_107210"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c3c001164d06967bffc88ae4a064b83e4730508e6212066ef72f1419123a3c10", "query": "I deployed a pod with and on a namesapace with a set with and elements and I get the error: The pod to be deployed Create a new namespace Create (using a manifest file named resource-quota-) and verify a named compute-resources Content of the resource-quota- file Create (using a manifest file named ) a pod named high-priority with the and for both and . Content of the file The pod is deployed correctly if I delete the <details</details<detailsaws </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig Scheduling\n/wg API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg API Expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg <API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg <API ExpressionInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg \"API Expression\"\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg \"API Expression\" Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg APIExpression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg APIExpression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg wg-api-expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg wg-api-expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhey, v1.18.20 is out of support now, you should try with a newer version. Besides, I tried with an old version v1.18.19, but worked as well.\nAre u using some mutating webhook which inject some sidecar into the pod without setting resources fields?\nIt's probably that, but IDK which WebHook is doing that. The feature you suggested would really help.\nhi the fix pr has been merged, maybe u could use it to locate which container is causing the problem.\nThanks", "positive_passages": [{"docid": "doc-en-kubernetes-93a3283d3046650651b961ba8c833c97c9ac0e991a1672d723bb558c14d07f2a", "text": "}, }, required: []corev1.ResourceName{corev1.ResourceMemory}, <del> err:      `must specify memory`, </del> <ins> err:      `must specify memory for: bar,foo`, </ins> }, \"container resource missing\": { pod: &api.Pod{ Spec: api.PodSpec{ Containers: []api.Container{{ <ins> Name: \"dummy\", Resources: api.ResourceRequirements{ Requests: api.ResourceList{api.ResourceCPU: resource.MustParse(\"1m\")}, Limits:   api.ResourceList{api.ResourceCPU: resource.MustParse(\"2m\")}, }, }}, }, }, required: []corev1.ResourceName{corev1.ResourceMemory}, err:      `must specify memory for: dummy`, }, \"multiple container resource missing\": { pod: &api.Pod{ Spec: api.PodSpec{ Containers: []api.Container{{ Name: \"foo\", Resources: api.ResourceRequirements{ Requests: api.ResourceList{api.ResourceCPU: resource.MustParse(\"1m\")}, Limits:   api.ResourceList{api.ResourceCPU: resource.MustParse(\"2m\")}, }, }, { Name: \"bar\", </ins> Resources: api.ResourceRequirements{ Requests: api.ResourceList{api.ResourceCPU: resource.MustParse(\"1m\")}, Limits:   api.ResourceList{api.ResourceCPU: resource.MustParse(\"2m\")},", "commid": "kubernetes_pr_107210"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c3c001164d06967bffc88ae4a064b83e4730508e6212066ef72f1419123a3c10", "query": "I deployed a pod with and on a namesapace with a set with and elements and I get the error: The pod to be deployed Create a new namespace Create (using a manifest file named resource-quota-) and verify a named compute-resources Content of the resource-quota- file Create (using a manifest file named ) a pod named high-priority with the and for both and . Content of the file The pod is deployed correctly if I delete the <details</details<detailsaws </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig Scheduling\n/wg API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg API Expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg <API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg <API ExpressionInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg \"API Expression\"\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg \"API Expression\" Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg APIExpression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg APIExpression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg wg-api-expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg wg-api-expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhey, v1.18.20 is out of support now, you should try with a newer version. Besides, I tried with an old version v1.18.19, but worked as well.\nAre u using some mutating webhook which inject some sidecar into the pod without setting resources fields?\nIt's probably that, but IDK which WebHook is doing that. The feature you suggested would really help.\nhi the fix pr has been merged, maybe u could use it to locate which container is causing the problem.\nThanks", "positive_passages": [{"docid": "doc-en-kubernetes-ad6d581655672fed5c468e8d5ca654d00af5c2b66f77a9ed92f1bc22cb56428c", "text": "}, }, required: []corev1.ResourceName{corev1.ResourceMemory}, <del> err:      `must specify memory`, </del> <ins> err:      `must specify memory for: bar,foo`, }, \"container resource missing multiple\": { pod: &api.Pod{ Spec: api.PodSpec{ Containers: []api.Container{{ Name:      \"foo\", Resources: api.ResourceRequirements{}, }, { Name:      \"bar\", Resources: api.ResourceRequirements{}, }}, }, }, required: []corev1.ResourceName{corev1.ResourceMemory, corev1.ResourceCPU}, err:      `must specify cpu for: bar,foo; memory for: bar,foo`, </ins> }, } evaluator := NewPodEvaluator(nil, clock.RealClock{})", "commid": "kubernetes_pr_107210"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-c3c001164d06967bffc88ae4a064b83e4730508e6212066ef72f1419123a3c10", "query": "I deployed a pod with and on a namesapace with a set with and elements and I get the error: The pod to be deployed Create a new namespace Create (using a manifest file named resource-quota-) and verify a named compute-resources Content of the resource-quota- file Create (using a manifest file named ) a pod named high-priority with the and for both and . Content of the file The pod is deployed correctly if I delete the <details</details<detailsaws </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig Scheduling\n/wg API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg API Expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg <API Expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg <API ExpressionInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg \"API Expression\"\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg \"API Expression\" Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg APIExpression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg APIExpression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/wg wg-api-expression\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /wg wg-api-expression Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nhey, v1.18.20 is out of support now, you should try with a newer version. Besides, I tried with an old version v1.18.19, but worked as well.\nAre u using some mutating webhook which inject some sidecar into the pod without setting resources fields?\nIt's probably that, but IDK which WebHook is doing that. The feature you suggested would really help.\nhi the fix pr has been merged, maybe u could use it to locate which container is causing the problem.\nThanks", "positive_passages": [{"docid": "doc-en-kubernetes-f0a09b02eef41b4a5a15c13669d87eb48e8503a0e530502868b43a25ea802e39", "text": "case err != nil && len(test.err) == 0, err == nil && len(test.err) != 0, err != nil && test.err != err.Error(): <del> t.Errorf(\"%s unexpected error: %v\", testName, err) </del> <ins> t.Errorf(\"%s want: %v,got: %v\", testName, test.err, err) </ins> } } }", "commid": "kubernetes_pr_107210"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a8d1b8b007f3b41febd8e28d8c3f6d762909a93ce545d0ad364f8e401a78d99f", "query": "In the implement of GCE mode WaitForAttach: when the runtime.GOOS = \"windows\" and it meets err , it should instead of . the code should be like this : None The modification is in order to match the code cosistant pattern. Any GCE Any Any Any Any\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig cloud-provider\n/assign\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-2ee9284e6f18f5981b3fd46924fc7b2e1a557190e11aa7b485195e4a9719ac2e", "text": "id, err := getDiskID(pdName, exec) if err != nil { klog.Errorf(\"WaitForAttach (windows) failed with error %s\", err) <ins> return \"\", err </ins> } <del> return id, err </del> <ins> return id, nil </ins> } partition := \"\"", "commid": "kubernetes_pr_107236"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4fde01bf9e733eb02396ee79e06a0d3d7fd635df01f60f51582a52b831148901", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/kind flake <!-- Please assign a SIG using: /sig SIG-NAME --/sig api-machinery\n/assign I want to take a try\n2 but actual 0 till timeout resource services, expected 2, actual 0 error waiting or ResourceQuota status: timed out waiting for the condition time later, actual state became 2 Seems polls a ResourceQuota status with timeout 10s may be not enough, we should enlarge it into 300s, that is poll for 300s timeout instead of 10s.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-89ffd7043eefa39531dc42605371ca95193e15c04504e9489d32cf5b01527716", "text": "clientset \"k8s.io/client-go/kubernetes\" \"k8s.io/client-go/rest\" v1 \"k8s.io/client-go/tools/clientcmd/api/v1\" <ins> resttransport \"k8s.io/client-go/transport\" </ins> kubeapiservertesting \"k8s.io/kubernetes/cmd/kube-apiserver/app/testing\" \"k8s.io/kubernetes/pkg/apis/autoscaling\" api \"k8s.io/kubernetes/pkg/apis/core\"", "commid": "kubernetes_pr_107276"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4fde01bf9e733eb02396ee79e06a0d3d7fd635df01f60f51582a52b831148901", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/kind flake <!-- Please assign a SIG using: /sig SIG-NAME --/sig api-machinery\n/assign I want to take a try\n2 but actual 0 till timeout resource services, expected 2, actual 0 error waiting or ResourceQuota status: timed out waiting for the condition time later, actual state became 2 Seems polls a ResourceQuota status with timeout 10s may be not enough, we should enlarge it into 300s, that is poll for 300s timeout instead of 10s.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-6d3873542fc65ab2a9aed07f5009cea74e81d263ba12848fd1d3006f2ef51564", "text": "controlPlaneConfig.GenericConfig.Authorization.Authorizer = authorizerfactory.NewAlwaysDenyAuthorizer() _, s, closeFn := framework.RunAnAPIServer(controlPlaneConfig) defer closeFn() ns := framework.CreateTestingNamespace(\"auth-always-deny\", s, t) defer framework.DeleteTestingNamespace(ns, s, t) <del> transport := http.DefaultTransport </del> <ins> transport := resttransport.NewBearerAuthRoundTripper(framework.UnprivilegedUserToken, http.DefaultTransport) </ins> for _, r := range getTestRequests(ns.Name) { bodyBytes := bytes.NewReader([]byte(r.body))", "commid": "kubernetes_pr_107276"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4fde01bf9e733eb02396ee79e06a0d3d7fd635df01f60f51582a52b831148901", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/kind flake <!-- Please assign a SIG using: /sig SIG-NAME --/sig api-machinery\n/assign I want to take a try\n2 but actual 0 till timeout resource services, expected 2, actual 0 error waiting or ResourceQuota status: timed out waiting for the condition time later, actual state became 2 Seems polls a ResourceQuota status with timeout 10s may be not enough, we should enlarge it into 300s, that is poll for 300s timeout instead of 10s.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-a35afca203a22947ef89bdfd6d8fd138abb0c6071e02d9d35fff70708244220a", "text": "apierrors \"k8s.io/apimachinery/pkg/api/errors\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/util/wait\" <ins> authauthenticator \"k8s.io/apiserver/pkg/authentication/authenticator\" </ins> \"k8s.io/apiserver/pkg/authentication/group\" \"k8s.io/apiserver/pkg/authentication/request/bearertoken\" <ins> authenticatorunion \"k8s.io/apiserver/pkg/authentication/request/union\" </ins> \"k8s.io/apiserver/pkg/authentication/user\" \"k8s.io/apiserver/pkg/authorization/authorizer\" \"k8s.io/apiserver/pkg/authorization/authorizerfactory\"", "commid": "kubernetes_pr_107276"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4fde01bf9e733eb02396ee79e06a0d3d7fd635df01f60f51582a52b831148901", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/kind flake <!-- Please assign a SIG using: /sig SIG-NAME --/sig api-machinery\n/assign I want to take a try\n2 but actual 0 till timeout resource services, expected 2, actual 0 error waiting or ResourceQuota status: timed out waiting for the condition time later, actual state became 2 Seems polls a ResourceQuota status with timeout 10s may be not enough, we should enlarge it into 300s, that is poll for 300s timeout instead of 10s.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-9c7f8ad2103236513034b8924077b810def4b5ed210be6fb11d1022f7cf02be0", "text": "func initStatusForbiddenControlPlaneConfig() *controlplane.Config { controlPlaneConfig := framework.NewIntegrationTestControlPlaneConfig() <ins> controlPlaneConfig.GenericConfig.Authentication.Authenticator = authenticatorunion.New( authauthenticator.RequestFunc(func(req *http.Request) (*authauthenticator.Response, bool, error) { return &authauthenticator.Response{ User: &user.DefaultInfo{ Name:   \"unprivileged\", Groups: []string{user.AllAuthenticated}, }, }, true, nil })) </ins> controlPlaneConfig.GenericConfig.Authorization.Authorizer = authorizerfactory.NewAlwaysDenyAuthorizer() return controlPlaneConfig }", "commid": "kubernetes_pr_107276"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4fde01bf9e733eb02396ee79e06a0d3d7fd635df01f60f51582a52b831148901", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/kind flake <!-- Please assign a SIG using: /sig SIG-NAME --/sig api-machinery\n/assign I want to take a try\n2 but actual 0 till timeout resource services, expected 2, actual 0 error waiting or ResourceQuota status: timed out waiting for the condition time later, actual state became 2 Seems polls a ResourceQuota status with timeout 10s may be not enough, we should enlarge it into 300s, that is poll for 300s timeout instead of 10s.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-f48df30e6df0447ec9b7d166a9bd3140616fef0cea7a468c80d6953ffcbfde62", "text": "statusCode:         http.StatusForbidden, reqPath:            \"/apis\", reason:             \"Forbidden\", <del> message:            `forbidden: User \"\" cannot get path \"/apis\": Everything is forbidden.`, </del> <ins> message:            `forbidden: User \"unprivileged\" cannot get path \"/apis\": Everything is forbidden.`, </ins> }, { name:               \"401\",", "commid": "kubernetes_pr_107276"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4fde01bf9e733eb02396ee79e06a0d3d7fd635df01f60f51582a52b831148901", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/kind flake <!-- Please assign a SIG using: /sig SIG-NAME --/sig api-machinery\n/assign I want to take a try\n2 but actual 0 till timeout resource services, expected 2, actual 0 error waiting or ResourceQuota status: timed out waiting for the condition time later, actual state became 2 Seems polls a ResourceQuota status with timeout 10s may be not enough, we should enlarge it into 300s, that is poll for 300s timeout instead of 10s.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-6f4352f1a7a3044323ca34738a483533b32d3a42510d1b23c697cdab1a1f4e05", "text": "netutils \"k8s.io/utils/net\" ) <ins> const ( UnprivilegedUserToken = \"unprivileged-user\" ) </ins> // Config is a struct of configuration directives for NewControlPlaneComponents. type Config struct { // If nil, a default is used, partially filled configs will not get populated.", "commid": "kubernetes_pr_107276"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4fde01bf9e733eb02396ee79e06a0d3d7fd635df01f60f51582a52b831148901", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/kind flake <!-- Please assign a SIG using: /sig SIG-NAME --/sig api-machinery\n/assign I want to take a try\n2 but actual 0 till timeout resource services, expected 2, actual 0 error waiting or ResourceQuota status: timed out waiting for the condition time later, actual state became 2 Seems polls a ResourceQuota status with timeout 10s may be not enough, we should enlarge it into 300s, that is poll for 300s timeout instead of 10s.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-7e1d347656e1ba52ee8717b75abdd6ee8500ee8eab211fdc3b5bd80af4901af4", "text": "return authorizer.DecisionAllow, \"always allow\", nil } <del> // alwaysEmpty simulates \"no authentication\" for old tests func alwaysEmpty(req *http.Request) (*authauthenticator.Response, bool, error) { </del> <ins> // unsecuredUser simulates requests to the unsecured endpoint for old tests func unsecuredUser(req *http.Request) (*authauthenticator.Response, bool, error) { auth := req.Header.Get(\"Authorization\") if len(auth) != 0 { return nil, false, nil } </ins> return &authauthenticator.Response{ User: &user.DefaultInfo{ <del> Name: \"\", </del> <ins> Name:   \"system:unsecured\", Groups: []string{user.SystemPrivilegedGroup, user.AllAuthenticated}, </ins> }, }, true, nil }", "commid": "kubernetes_pr_107276"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4fde01bf9e733eb02396ee79e06a0d3d7fd635df01f60f51582a52b831148901", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/kind flake <!-- Please assign a SIG using: /sig SIG-NAME --/sig api-machinery\n/assign I want to take a try\n2 but actual 0 till timeout resource services, expected 2, actual 0 error waiting or ResourceQuota status: timed out waiting for the condition time later, actual state became 2 Seems polls a ResourceQuota status with timeout 10s may be not enough, we should enlarge it into 300s, that is poll for 300s timeout instead of 10s.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-430130c236576de2a3e8710885761ec8dde0d7ff675bec5ec603577ac0de8da4", "text": "tokens[privilegedLoopbackToken] = &user.DefaultInfo{ Name:   user.APIServerUser, UID:    uuid.New().String(), <del> Groups: []string{user.SystemPrivilegedGroup}, </del> <ins> Groups: []string{user.SystemPrivilegedGroup, user.AllAuthenticated}, } tokens[UnprivilegedUserToken] = &user.DefaultInfo{ Name:   \"unprivileged\", UID:    uuid.New().String(), Groups: []string{user.AllAuthenticated}, </ins> } tokenAuthenticator := authenticatorfactory.NewFromTokens(tokens, controlPlaneConfig.GenericConfig.Authentication.APIAudiences) if controlPlaneConfig.GenericConfig.Authentication.Authenticator == nil { <del> controlPlaneConfig.GenericConfig.Authentication.Authenticator = authenticatorunion.New(tokenAuthenticator, authauthenticator.RequestFunc(alwaysEmpty)) </del> <ins> controlPlaneConfig.GenericConfig.Authentication.Authenticator = authenticatorunion.New(tokenAuthenticator, authauthenticator.RequestFunc(unsecuredUser)) </ins> } else { controlPlaneConfig.GenericConfig.Authentication.Authenticator = authenticatorunion.New(tokenAuthenticator, controlPlaneConfig.GenericConfig.Authentication.Authenticator) }", "commid": "kubernetes_pr_107276"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-638e1ca866d667abba257ab7bbd4b65d0d17bd2e9e09c09309c35a895edf6db9", "query": "There are pre-defined tests patterns that specify \"CSI Ephemeral\" in combination with a non-default fstype, for example: This code then should set but currently doesn't: Not sure whether these patterns are used in Kubernetes. I ran into this with PMEM-CSI, which uses them. The effect is that all test cases using those patterns use the default fstype instead of ext4 or XFS. /sig storage Kubernetes 1.24 and several older versions. n/a No response No response No response No response_\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/assign /remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-86eccc1a2bdba6f53f013bcb61d57099e955d4b68a8a6fcc79268029047ad352", "text": "VolumeAttributes: attributes, }, } <ins> if pattern.FsType != \"\" { r.VolSource.CSI.FSType = &pattern.FsType } </ins> } default: framework.Failf(\"VolumeResource doesn't support: %s\", pattern.VolType)", "commid": "kubernetes_pr_109279"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9fbcd5201ae07f3b7a89bd2301992ba7ab5d6d8edc83db6ef44c2beaac86b1f5", "query": "Integration test timed out due to the following error The error appeared 748 times in the log. Looks like lots of churning happens during the apf configuration bootstrapping phase. Is there a race condition between when the type is being registered and the API calls? Stack trace: Integration job link: PR: I searched for this error in CI and this PR, looks like we only see this error in this PR so far. So I am hoping it has not introduced any flake. (maybe we need to let more time to pass to start seeing flakes) We should not see this error I saw it only in the PR mentioned.\n/sig api-machinery cc\nI see\nThe fact that it happens to a non-mandatory object implies that the object was received from the server, so the type must be in the server. The APF config-consuming controller does this:\nLook for the output from this line:\nAnother PR with this failure:\nthe panic means the request scope FieldManager is nil that is initialized here: OpenAPIModels is set here: called from here: and openAPIModels is constructed here: it looks like it is possible for openapiconfig to be unset, which causes the openapi models to be nil, which causes apply to panic. I don't know if it is only the integration tests that are subject to that configuration. cc /priority important-soon (since this is now being exercised in bring-up of integration test servers)\nif APF is creating/bootstrapping the objects without using apply, and then updating status using apply, that would explain how the object exists but apply fails\nI suspect that APF is not successfully updating status at all in the integration tests with this server configuration\ndo you want me to revert , while we work on a solution?\nI don't know how bad the test impact is. Work with / to determine if we should revert or fix forward\n: I do not follow why you talked about server-side stuff then suggested the problem is in the client (a controller in the kube-apiserver) not supplying a fieldManager. The client does supply the fieldManager, for both creates and updates. See the following lines:\nDifferent field manager. is set server-side in the endpoint handler based on the server configuration.\nSo if the problem is server-side, why did you suggest the problem is in the client?\nRegarding the client, I looked in and found this line: actually several of the same form, all with the same fieldManager.\nI don't think I did suggest that :) all of the setup and calls in are server-side\n: please help me understand . That is about the client side. Are you saying that a client that creates an object using and later updates the object using --- with a non-empty fieldManager in both --- will run into this server-side scenario? If so, is that because this client behavior is wrong or because there is a bug server side?\nThat was in response to , trying to figure out how the object was created but could not be updated. Yes, when the server is not configured to enable openapi and therefore does not have apply enabled. Because the server is misconfigured (which, from what I can tell, is limited to some of the server instances started for integration tests)\nLooking at and it is not obvious to me whether or how openapi could be disabled. Would that be by turning off the feature flag? FYI, the inclusion of \"V3\" in the flag makes me unsure what the server does about other versions. : I think you are saying that it is possible to disable openapi and that this in turn disables server-side apply. That seems kind of surprising to me. Does this mean that it is simply incorrect to run a client that does server-side apply with a server that has openapi disabled? Is this intended? Is it documented anywhere?\nIt's not intended as an externalized configuration option. integration tests have the ability to fiddle with many of the config struct options in the server that a kube-apiserver binary invocation could not. They intentionally use this to do things like inject specialized authorizers / authenticators for testing purposes, but also can unintentionally result in a test server that doesn't match a real API server invocation. I think this is an integration test server configuration problem, which should be fixed.\nis correct that we have a misconfiguration in the integration tests and SSA is only enabled on a subset of integration tests. I'd like to understand the test failure conditions a bit better though. The can be consistently reproduced on a non SSA targeted test. (Eg: selected from one of the test failures). However, I'm seeing the panic message while the test is still green and passes locally. it's a bit bizarre what contributes to the flakiness of the test because the FieldManager panic can be reproduced 100% of the time.\nThe panic occurs when APF is updating status (which it just switched to do using SSA). The APF status update failure does not block the API requests the test cares about, so the test passes. I could see extra CPU usage contributing to flakiness.\nThanks for the explanation. Created to fix the integration test configurations.\n/triage accepted\nThe integration test job started timing out dramatically last night (50% of runs) once merged. Since that was the only change made to integration tests recently, it seems related. I think we should revert (and therefore ) until the test impact is understood\nrevert of -\ndid this get fully reverted? we're still seeing panics in integration tests over this:\nbumping priority and milestoning until we know we're not currently triggering panics\nlooks like it got reintroduced in , revert open in\nFor integration tests, maybe we can cheat and cache the OpenAPI data, so that it's not recomputed for each test?\n:-/ maybe... but I really don't want to have non-real init paths in integration if at all possible\nI wish we could go a little further in lazily initializing openapi (especially v2), so let's see what we can do here (after code-freeze probably)\nif SSA is actively using the openapi, it being lazy won't help, right?\ndoes the revert mean that we can remove milestone v1.24 from this issue?\nYes, cleared\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle rotten\nTaking a fresh look at this PR and wondering if it has been mostly fixed already? From comments my understanding is that this panic occurred due to two conditions: running as part of the integration test suite is asked to service an SSA request while are nil. The apiservice has logic to panic in this case. From the code path commented is nil when the server is created with is nil. APF worker (running alongside an integration test) issues an SSA request to the test apiserver. Since the apiserver is misconfigured it panics. This panic could happen sporadically because sometimes the tests finish before the APF worker is able to issue the request. As a brief check to see if this might be fixed, I ran the test mentioned was failing from SSA. I logged out the 's created and found that they all had managed fields. I saw this as an indication SSA was now functioning properly. Indeed, to start the test server the function calls . This function has a code path which unconditionally leads to the apiserver's being set. calls before running the returned apiserver: calls before using the returned config to create the returned apiserver: uses which sets : Thus, any test using should no longer be affected by this panic. The question then becomes: do all integration tests start their servers in this way? It's hard to say. I found a PR (, ) which refactors many occurrences of the old stanza: Into something using the new method: ` But it appears is still being used in a few integration tests: Should these occurrences be refactored to use too?\nThere was a ton of changes I did around that. But the last PR (already removing the old is already out for review): - FYI Thinking about it now, I guess I agree that the problem might have been 10 different way kube-apiserver was set up through different tests. I just don't know why it was causing flakes, not failing consistently...\nThere were definitely test setups that were not enabling openapi in the recent past. Two possibilities for flakes: Enabling openapi in all integration test setups was expensive and caused spurious timeouts The excessive numbers of background panics handled and logged in integration tests when the API server tried to handle SSA requests bogged down the CI machine (I think something like 40,000 panics with full stack traces each were getting logged)\ni don't think that's the case. With the recent changes that I was doing as part of I think OpenAPI is already enabled for all tests having kube-apiserver (almost all) and that seems to work. But you remainded me that back then we also had an issue that we were running many more tests simulanuously, which could have been contributing to this problem significantly. The second reason is definitely possible contributor too. I guess my concern was that if some requests were panicing due to lack of OpenAPI, this means that these aren't really needed. But that actually might make sense - the fact that we weren't able to upgrade status of PriorityLevels/FlowSchemas shouldn't prevent non P&F-tests from succeeding, and that worked in P&F tests...\nI think the panics were happening in async controllers, and no functionality blocked by the controllers intersected with the surface being tested, it just (maybe) caused log/perf issues\nI believe has resolved the panic issue, I was able to verify with which changes the priority & fairness controller to use server side apply. Before merged, I analyzed the integration log: Integration test log file from an unrelated pr does not contain any trace of the panic as expected: On the other hand, the log file from integration job for (before merged) had plenty of these panics even though the integration job turned green: I wanted to check which tests produced these panics, so I did a breakdown by package Then I narrowed it down to the individual test(s): Before merged, the above tests used , and either is or is which results in to be nil. But a quick code search revealed that many more integration tests used , so why were the other tests not affected by the panic? I inspected the log of a test that was not affected by the panic, and grepped for , and found the following: In the above case, the apf controller had not advanced far enough, the controller was active for about , may be these tests finish quickly and signals the server to shutdown before the apf controller can send an APPLY command. On the other hand, log from a test that was affected by the panic shows that the apf controller was active for more than , and has lot more activities: I am assuming that integration tests have at least log level 4. Also, the size of the log file differed significantly, without panics around , and with panics over and changed all these tests to use and now integration log for shows no panic.\nGreat! (This also proves why eliminating gazilion different things of initializing stuff in favor of one makes sense). - FYI ^^ - let's merge the PR then - I just one question there, so let's wait for Jordan to respond it.\nCan we just force the openapi/fieldmanager to be set at start-time now that SSA is GA, it should basically always be present, rather than fail when SSA is unavailable (that's probably wrong by the way). If that triggers any test flakiness, then we would solve these. We can wait for to be solved since it will almost certainly have a huge impact on this.\nHas this been done Jeff?", "positive_passages": [{"docid": "doc-en-kubernetes-2a4f285e10d3a46e7a0449c9735ca417d1befa0ed590564fea85c27235de0d27", "text": "\"context\" \"crypto/sha256\" \"encoding/binary\" <del> \"encoding/json\" </del> \"errors\" \"fmt\" \"math\"", "commid": "kubernetes_pr_110173"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9fbcd5201ae07f3b7a89bd2301992ba7ab5d6d8edc83db6ef44c2beaac86b1f5", "query": "Integration test timed out due to the following error The error appeared 748 times in the log. Looks like lots of churning happens during the apf configuration bootstrapping phase. Is there a race condition between when the type is being registered and the API calls? Stack trace: Integration job link: PR: I searched for this error in CI and this PR, looks like we only see this error in this PR so far. So I am hoping it has not introduced any flake. (maybe we need to let more time to pass to start seeing flakes) We should not see this error I saw it only in the PR mentioned.\n/sig api-machinery cc\nI see\nThe fact that it happens to a non-mandatory object implies that the object was received from the server, so the type must be in the server. The APF config-consuming controller does this:\nLook for the output from this line:\nAnother PR with this failure:\nthe panic means the request scope FieldManager is nil that is initialized here: OpenAPIModels is set here: called from here: and openAPIModels is constructed here: it looks like it is possible for openapiconfig to be unset, which causes the openapi models to be nil, which causes apply to panic. I don't know if it is only the integration tests that are subject to that configuration. cc /priority important-soon (since this is now being exercised in bring-up of integration test servers)\nif APF is creating/bootstrapping the objects without using apply, and then updating status using apply, that would explain how the object exists but apply fails\nI suspect that APF is not successfully updating status at all in the integration tests with this server configuration\ndo you want me to revert , while we work on a solution?\nI don't know how bad the test impact is. Work with / to determine if we should revert or fix forward\n: I do not follow why you talked about server-side stuff then suggested the problem is in the client (a controller in the kube-apiserver) not supplying a fieldManager. The client does supply the fieldManager, for both creates and updates. See the following lines:\nDifferent field manager. is set server-side in the endpoint handler based on the server configuration.\nSo if the problem is server-side, why did you suggest the problem is in the client?\nRegarding the client, I looked in and found this line: actually several of the same form, all with the same fieldManager.\nI don't think I did suggest that :) all of the setup and calls in are server-side\n: please help me understand . That is about the client side. Are you saying that a client that creates an object using and later updates the object using --- with a non-empty fieldManager in both --- will run into this server-side scenario? If so, is that because this client behavior is wrong or because there is a bug server side?\nThat was in response to , trying to figure out how the object was created but could not be updated. Yes, when the server is not configured to enable openapi and therefore does not have apply enabled. Because the server is misconfigured (which, from what I can tell, is limited to some of the server instances started for integration tests)\nLooking at and it is not obvious to me whether or how openapi could be disabled. Would that be by turning off the feature flag? FYI, the inclusion of \"V3\" in the flag makes me unsure what the server does about other versions. : I think you are saying that it is possible to disable openapi and that this in turn disables server-side apply. That seems kind of surprising to me. Does this mean that it is simply incorrect to run a client that does server-side apply with a server that has openapi disabled? Is this intended? Is it documented anywhere?\nIt's not intended as an externalized configuration option. integration tests have the ability to fiddle with many of the config struct options in the server that a kube-apiserver binary invocation could not. They intentionally use this to do things like inject specialized authorizers / authenticators for testing purposes, but also can unintentionally result in a test server that doesn't match a real API server invocation. I think this is an integration test server configuration problem, which should be fixed.\nis correct that we have a misconfiguration in the integration tests and SSA is only enabled on a subset of integration tests. I'd like to understand the test failure conditions a bit better though. The can be consistently reproduced on a non SSA targeted test. (Eg: selected from one of the test failures). However, I'm seeing the panic message while the test is still green and passes locally. it's a bit bizarre what contributes to the flakiness of the test because the FieldManager panic can be reproduced 100% of the time.\nThe panic occurs when APF is updating status (which it just switched to do using SSA). The APF status update failure does not block the API requests the test cares about, so the test passes. I could see extra CPU usage contributing to flakiness.\nThanks for the explanation. Created to fix the integration test configurations.\n/triage accepted\nThe integration test job started timing out dramatically last night (50% of runs) once merged. Since that was the only change made to integration tests recently, it seems related. I think we should revert (and therefore ) until the test impact is understood\nrevert of -\ndid this get fully reverted? we're still seeing panics in integration tests over this:\nbumping priority and milestoning until we know we're not currently triggering panics\nlooks like it got reintroduced in , revert open in\nFor integration tests, maybe we can cheat and cache the OpenAPI data, so that it's not recomputed for each test?\n:-/ maybe... but I really don't want to have non-real init paths in integration if at all possible\nI wish we could go a little further in lazily initializing openapi (especially v2), so let's see what we can do here (after code-freeze probably)\nif SSA is actively using the openapi, it being lazy won't help, right?\ndoes the revert mean that we can remove milestone v1.24 from this issue?\nYes, cleared\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle rotten\nTaking a fresh look at this PR and wondering if it has been mostly fixed already? From comments my understanding is that this panic occurred due to two conditions: running as part of the integration test suite is asked to service an SSA request while are nil. The apiservice has logic to panic in this case. From the code path commented is nil when the server is created with is nil. APF worker (running alongside an integration test) issues an SSA request to the test apiserver. Since the apiserver is misconfigured it panics. This panic could happen sporadically because sometimes the tests finish before the APF worker is able to issue the request. As a brief check to see if this might be fixed, I ran the test mentioned was failing from SSA. I logged out the 's created and found that they all had managed fields. I saw this as an indication SSA was now functioning properly. Indeed, to start the test server the function calls . This function has a code path which unconditionally leads to the apiserver's being set. calls before running the returned apiserver: calls before using the returned config to create the returned apiserver: uses which sets : Thus, any test using should no longer be affected by this panic. The question then becomes: do all integration tests start their servers in this way? It's hard to say. I found a PR (, ) which refactors many occurrences of the old stanza: Into something using the new method: ` But it appears is still being used in a few integration tests: Should these occurrences be refactored to use too?\nThere was a ton of changes I did around that. But the last PR (already removing the old is already out for review): - FYI Thinking about it now, I guess I agree that the problem might have been 10 different way kube-apiserver was set up through different tests. I just don't know why it was causing flakes, not failing consistently...\nThere were definitely test setups that were not enabling openapi in the recent past. Two possibilities for flakes: Enabling openapi in all integration test setups was expensive and caused spurious timeouts The excessive numbers of background panics handled and logged in integration tests when the API server tried to handle SSA requests bogged down the CI machine (I think something like 40,000 panics with full stack traces each were getting logged)\ni don't think that's the case. With the recent changes that I was doing as part of I think OpenAPI is already enabled for all tests having kube-apiserver (almost all) and that seems to work. But you remainded me that back then we also had an issue that we were running many more tests simulanuously, which could have been contributing to this problem significantly. The second reason is definitely possible contributor too. I guess my concern was that if some requests were panicing due to lack of OpenAPI, this means that these aren't really needed. But that actually might make sense - the fact that we weren't able to upgrade status of PriorityLevels/FlowSchemas shouldn't prevent non P&F-tests from succeeding, and that worked in P&F tests...\nI think the panics were happening in async controllers, and no functionality blocked by the controllers intersected with the surface being tested, it just (maybe) caused log/perf issues\nI believe has resolved the panic issue, I was able to verify with which changes the priority & fairness controller to use server side apply. Before merged, I analyzed the integration log: Integration test log file from an unrelated pr does not contain any trace of the panic as expected: On the other hand, the log file from integration job for (before merged) had plenty of these panics even though the integration job turned green: I wanted to check which tests produced these panics, so I did a breakdown by package Then I narrowed it down to the individual test(s): Before merged, the above tests used , and either is or is which results in to be nil. But a quick code search revealed that many more integration tests used , so why were the other tests not affected by the panic? I inspected the log of a test that was not affected by the panic, and grepped for , and found the following: In the above case, the apf controller had not advanced far enough, the controller was active for about , may be these tests finish quickly and signals the server to shutdown before the apf controller can send an APPLY command. On the other hand, log from a test that was affected by the panic shows that the apf controller was active for more than , and has lot more activities: I am assuming that integration tests have at least log level 4. Also, the size of the log file differed significantly, without panics around , and with panics over and changed all these tests to use and now integration log for shows no panic.\nGreat! (This also proves why eliminating gazilion different things of initializing stuff in favor of one makes sense). - FYI ^^ - let's merge the PR then - I just one question there, so let's wait for Jordan to respond it.\nCan we just force the openapi/fieldmanager to be set at start-time now that SSA is GA, it should basically always be present, rather than fail when SSA is unavailable (that's probably wrong by the way). If that triggers any test flakiness, then we would solve these. We can wait for to be solved since it will almost certainly have a huge impact on this.\nHas this been done Jeff?", "positive_passages": [{"docid": "doc-en-kubernetes-4c271da8450c49c70c4b2ef4b1f404acbd28a0c82d9ad09579c605e8ce567be6", "text": "apierrors \"k8s.io/apimachinery/pkg/api/errors\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/labels\" <del> apitypes \"k8s.io/apimachinery/pkg/types\" </del> utilerrors \"k8s.io/apimachinery/pkg/util/errors\" utilruntime \"k8s.io/apimachinery/pkg/util/runtime\" \"k8s.io/apimachinery/pkg/util/sets\"", "commid": "kubernetes_pr_110173"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9fbcd5201ae07f3b7a89bd2301992ba7ab5d6d8edc83db6ef44c2beaac86b1f5", "query": "Integration test timed out due to the following error The error appeared 748 times in the log. Looks like lots of churning happens during the apf configuration bootstrapping phase. Is there a race condition between when the type is being registered and the API calls? Stack trace: Integration job link: PR: I searched for this error in CI and this PR, looks like we only see this error in this PR so far. So I am hoping it has not introduced any flake. (maybe we need to let more time to pass to start seeing flakes) We should not see this error I saw it only in the PR mentioned.\n/sig api-machinery cc\nI see\nThe fact that it happens to a non-mandatory object implies that the object was received from the server, so the type must be in the server. The APF config-consuming controller does this:\nLook for the output from this line:\nAnother PR with this failure:\nthe panic means the request scope FieldManager is nil that is initialized here: OpenAPIModels is set here: called from here: and openAPIModels is constructed here: it looks like it is possible for openapiconfig to be unset, which causes the openapi models to be nil, which causes apply to panic. I don't know if it is only the integration tests that are subject to that configuration. cc /priority important-soon (since this is now being exercised in bring-up of integration test servers)\nif APF is creating/bootstrapping the objects without using apply, and then updating status using apply, that would explain how the object exists but apply fails\nI suspect that APF is not successfully updating status at all in the integration tests with this server configuration\ndo you want me to revert , while we work on a solution?\nI don't know how bad the test impact is. Work with / to determine if we should revert or fix forward\n: I do not follow why you talked about server-side stuff then suggested the problem is in the client (a controller in the kube-apiserver) not supplying a fieldManager. The client does supply the fieldManager, for both creates and updates. See the following lines:\nDifferent field manager. is set server-side in the endpoint handler based on the server configuration.\nSo if the problem is server-side, why did you suggest the problem is in the client?\nRegarding the client, I looked in and found this line: actually several of the same form, all with the same fieldManager.\nI don't think I did suggest that :) all of the setup and calls in are server-side\n: please help me understand . That is about the client side. Are you saying that a client that creates an object using and later updates the object using --- with a non-empty fieldManager in both --- will run into this server-side scenario? If so, is that because this client behavior is wrong or because there is a bug server side?\nThat was in response to , trying to figure out how the object was created but could not be updated. Yes, when the server is not configured to enable openapi and therefore does not have apply enabled. Because the server is misconfigured (which, from what I can tell, is limited to some of the server instances started for integration tests)\nLooking at and it is not obvious to me whether or how openapi could be disabled. Would that be by turning off the feature flag? FYI, the inclusion of \"V3\" in the flag makes me unsure what the server does about other versions. : I think you are saying that it is possible to disable openapi and that this in turn disables server-side apply. That seems kind of surprising to me. Does this mean that it is simply incorrect to run a client that does server-side apply with a server that has openapi disabled? Is this intended? Is it documented anywhere?\nIt's not intended as an externalized configuration option. integration tests have the ability to fiddle with many of the config struct options in the server that a kube-apiserver binary invocation could not. They intentionally use this to do things like inject specialized authorizers / authenticators for testing purposes, but also can unintentionally result in a test server that doesn't match a real API server invocation. I think this is an integration test server configuration problem, which should be fixed.\nis correct that we have a misconfiguration in the integration tests and SSA is only enabled on a subset of integration tests. I'd like to understand the test failure conditions a bit better though. The can be consistently reproduced on a non SSA targeted test. (Eg: selected from one of the test failures). However, I'm seeing the panic message while the test is still green and passes locally. it's a bit bizarre what contributes to the flakiness of the test because the FieldManager panic can be reproduced 100% of the time.\nThe panic occurs when APF is updating status (which it just switched to do using SSA). The APF status update failure does not block the API requests the test cares about, so the test passes. I could see extra CPU usage contributing to flakiness.\nThanks for the explanation. Created to fix the integration test configurations.\n/triage accepted\nThe integration test job started timing out dramatically last night (50% of runs) once merged. Since that was the only change made to integration tests recently, it seems related. I think we should revert (and therefore ) until the test impact is understood\nrevert of -\ndid this get fully reverted? we're still seeing panics in integration tests over this:\nbumping priority and milestoning until we know we're not currently triggering panics\nlooks like it got reintroduced in , revert open in\nFor integration tests, maybe we can cheat and cache the OpenAPI data, so that it's not recomputed for each test?\n:-/ maybe... but I really don't want to have non-real init paths in integration if at all possible\nI wish we could go a little further in lazily initializing openapi (especially v2), so let's see what we can do here (after code-freeze probably)\nif SSA is actively using the openapi, it being lazy won't help, right?\ndoes the revert mean that we can remove milestone v1.24 from this issue?\nYes, cleared\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle rotten\nTaking a fresh look at this PR and wondering if it has been mostly fixed already? From comments my understanding is that this panic occurred due to two conditions: running as part of the integration test suite is asked to service an SSA request while are nil. The apiservice has logic to panic in this case. From the code path commented is nil when the server is created with is nil. APF worker (running alongside an integration test) issues an SSA request to the test apiserver. Since the apiserver is misconfigured it panics. This panic could happen sporadically because sometimes the tests finish before the APF worker is able to issue the request. As a brief check to see if this might be fixed, I ran the test mentioned was failing from SSA. I logged out the 's created and found that they all had managed fields. I saw this as an indication SSA was now functioning properly. Indeed, to start the test server the function calls . This function has a code path which unconditionally leads to the apiserver's being set. calls before running the returned apiserver: calls before using the returned config to create the returned apiserver: uses which sets : Thus, any test using should no longer be affected by this panic. The question then becomes: do all integration tests start their servers in this way? It's hard to say. I found a PR (, ) which refactors many occurrences of the old stanza: Into something using the new method: ` But it appears is still being used in a few integration tests: Should these occurrences be refactored to use too?\nThere was a ton of changes I did around that. But the last PR (already removing the old is already out for review): - FYI Thinking about it now, I guess I agree that the problem might have been 10 different way kube-apiserver was set up through different tests. I just don't know why it was causing flakes, not failing consistently...\nThere were definitely test setups that were not enabling openapi in the recent past. Two possibilities for flakes: Enabling openapi in all integration test setups was expensive and caused spurious timeouts The excessive numbers of background panics handled and logged in integration tests when the API server tried to handle SSA requests bogged down the CI machine (I think something like 40,000 panics with full stack traces each were getting logged)\ni don't think that's the case. With the recent changes that I was doing as part of I think OpenAPI is already enabled for all tests having kube-apiserver (almost all) and that seems to work. But you remainded me that back then we also had an issue that we were running many more tests simulanuously, which could have been contributing to this problem significantly. The second reason is definitely possible contributor too. I guess my concern was that if some requests were panicing due to lack of OpenAPI, this means that these aren't really needed. But that actually might make sense - the fact that we weren't able to upgrade status of PriorityLevels/FlowSchemas shouldn't prevent non P&F-tests from succeeding, and that worked in P&F tests...\nI think the panics were happening in async controllers, and no functionality blocked by the controllers intersected with the surface being tested, it just (maybe) caused log/perf issues\nI believe has resolved the panic issue, I was able to verify with which changes the priority & fairness controller to use server side apply. Before merged, I analyzed the integration log: Integration test log file from an unrelated pr does not contain any trace of the panic as expected: On the other hand, the log file from integration job for (before merged) had plenty of these panics even though the integration job turned green: I wanted to check which tests produced these panics, so I did a breakdown by package Then I narrowed it down to the individual test(s): Before merged, the above tests used , and either is or is which results in to be nil. But a quick code search revealed that many more integration tests used , so why were the other tests not affected by the panic? I inspected the log of a test that was not affected by the panic, and grepped for , and found the following: In the above case, the apf controller had not advanced far enough, the controller was active for about , may be these tests finish quickly and signals the server to shutdown before the apf controller can send an APPLY command. On the other hand, log from a test that was affected by the panic shows that the apf controller was active for more than , and has lot more activities: I am assuming that integration tests have at least log level 4. Also, the size of the log file differed significantly, without panics around , and with panics over and changed all these tests to use and now integration log for shows no panic.\nGreat! (This also proves why eliminating gazilion different things of initializing stuff in favor of one makes sense). - FYI ^^ - let's merge the PR then - I just one question there, so let's wait for Jordan to respond it.\nCan we just force the openapi/fieldmanager to be set at start-time now that SSA is GA, it should basically always be present, rather than fail when SSA is unavailable (that's probably wrong by the way). If that triggers any test flakiness, then we would solve these. We can wait for to be solved since it will almost certainly have a huge impact on this.\nHas this been done Jeff?", "positive_passages": [{"docid": "doc-en-kubernetes-ddb7795976f3a32697578d01133f450e65a4f5fa48b415484bae8729aaaa4b80", "text": "\"k8s.io/utils/clock\" flowcontrol \"k8s.io/api/flowcontrol/v1beta3\" <ins> flowcontrolapplyconfiguration \"k8s.io/client-go/applyconfigurations/flowcontrol/v1beta3\" </ins> flowcontrolclient \"k8s.io/client-go/kubernetes/typed/flowcontrol/v1beta3\" flowcontrollister \"k8s.io/client-go/listers/flowcontrol/v1beta3\" )", "commid": "kubernetes_pr_110173"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9fbcd5201ae07f3b7a89bd2301992ba7ab5d6d8edc83db6ef44c2beaac86b1f5", "query": "Integration test timed out due to the following error The error appeared 748 times in the log. Looks like lots of churning happens during the apf configuration bootstrapping phase. Is there a race condition between when the type is being registered and the API calls? Stack trace: Integration job link: PR: I searched for this error in CI and this PR, looks like we only see this error in this PR so far. So I am hoping it has not introduced any flake. (maybe we need to let more time to pass to start seeing flakes) We should not see this error I saw it only in the PR mentioned.\n/sig api-machinery cc\nI see\nThe fact that it happens to a non-mandatory object implies that the object was received from the server, so the type must be in the server. The APF config-consuming controller does this:\nLook for the output from this line:\nAnother PR with this failure:\nthe panic means the request scope FieldManager is nil that is initialized here: OpenAPIModels is set here: called from here: and openAPIModels is constructed here: it looks like it is possible for openapiconfig to be unset, which causes the openapi models to be nil, which causes apply to panic. I don't know if it is only the integration tests that are subject to that configuration. cc /priority important-soon (since this is now being exercised in bring-up of integration test servers)\nif APF is creating/bootstrapping the objects without using apply, and then updating status using apply, that would explain how the object exists but apply fails\nI suspect that APF is not successfully updating status at all in the integration tests with this server configuration\ndo you want me to revert , while we work on a solution?\nI don't know how bad the test impact is. Work with / to determine if we should revert or fix forward\n: I do not follow why you talked about server-side stuff then suggested the problem is in the client (a controller in the kube-apiserver) not supplying a fieldManager. The client does supply the fieldManager, for both creates and updates. See the following lines:\nDifferent field manager. is set server-side in the endpoint handler based on the server configuration.\nSo if the problem is server-side, why did you suggest the problem is in the client?\nRegarding the client, I looked in and found this line: actually several of the same form, all with the same fieldManager.\nI don't think I did suggest that :) all of the setup and calls in are server-side\n: please help me understand . That is about the client side. Are you saying that a client that creates an object using and later updates the object using --- with a non-empty fieldManager in both --- will run into this server-side scenario? If so, is that because this client behavior is wrong or because there is a bug server side?\nThat was in response to , trying to figure out how the object was created but could not be updated. Yes, when the server is not configured to enable openapi and therefore does not have apply enabled. Because the server is misconfigured (which, from what I can tell, is limited to some of the server instances started for integration tests)\nLooking at and it is not obvious to me whether or how openapi could be disabled. Would that be by turning off the feature flag? FYI, the inclusion of \"V3\" in the flag makes me unsure what the server does about other versions. : I think you are saying that it is possible to disable openapi and that this in turn disables server-side apply. That seems kind of surprising to me. Does this mean that it is simply incorrect to run a client that does server-side apply with a server that has openapi disabled? Is this intended? Is it documented anywhere?\nIt's not intended as an externalized configuration option. integration tests have the ability to fiddle with many of the config struct options in the server that a kube-apiserver binary invocation could not. They intentionally use this to do things like inject specialized authorizers / authenticators for testing purposes, but also can unintentionally result in a test server that doesn't match a real API server invocation. I think this is an integration test server configuration problem, which should be fixed.\nis correct that we have a misconfiguration in the integration tests and SSA is only enabled on a subset of integration tests. I'd like to understand the test failure conditions a bit better though. The can be consistently reproduced on a non SSA targeted test. (Eg: selected from one of the test failures). However, I'm seeing the panic message while the test is still green and passes locally. it's a bit bizarre what contributes to the flakiness of the test because the FieldManager panic can be reproduced 100% of the time.\nThe panic occurs when APF is updating status (which it just switched to do using SSA). The APF status update failure does not block the API requests the test cares about, so the test passes. I could see extra CPU usage contributing to flakiness.\nThanks for the explanation. Created to fix the integration test configurations.\n/triage accepted\nThe integration test job started timing out dramatically last night (50% of runs) once merged. Since that was the only change made to integration tests recently, it seems related. I think we should revert (and therefore ) until the test impact is understood\nrevert of -\ndid this get fully reverted? we're still seeing panics in integration tests over this:\nbumping priority and milestoning until we know we're not currently triggering panics\nlooks like it got reintroduced in , revert open in\nFor integration tests, maybe we can cheat and cache the OpenAPI data, so that it's not recomputed for each test?\n:-/ maybe... but I really don't want to have non-real init paths in integration if at all possible\nI wish we could go a little further in lazily initializing openapi (especially v2), so let's see what we can do here (after code-freeze probably)\nif SSA is actively using the openapi, it being lazy won't help, right?\ndoes the revert mean that we can remove milestone v1.24 from this issue?\nYes, cleared\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle rotten\nTaking a fresh look at this PR and wondering if it has been mostly fixed already? From comments my understanding is that this panic occurred due to two conditions: running as part of the integration test suite is asked to service an SSA request while are nil. The apiservice has logic to panic in this case. From the code path commented is nil when the server is created with is nil. APF worker (running alongside an integration test) issues an SSA request to the test apiserver. Since the apiserver is misconfigured it panics. This panic could happen sporadically because sometimes the tests finish before the APF worker is able to issue the request. As a brief check to see if this might be fixed, I ran the test mentioned was failing from SSA. I logged out the 's created and found that they all had managed fields. I saw this as an indication SSA was now functioning properly. Indeed, to start the test server the function calls . This function has a code path which unconditionally leads to the apiserver's being set. calls before running the returned apiserver: calls before using the returned config to create the returned apiserver: uses which sets : Thus, any test using should no longer be affected by this panic. The question then becomes: do all integration tests start their servers in this way? It's hard to say. I found a PR (, ) which refactors many occurrences of the old stanza: Into something using the new method: ` But it appears is still being used in a few integration tests: Should these occurrences be refactored to use too?\nThere was a ton of changes I did around that. But the last PR (already removing the old is already out for review): - FYI Thinking about it now, I guess I agree that the problem might have been 10 different way kube-apiserver was set up through different tests. I just don't know why it was causing flakes, not failing consistently...\nThere were definitely test setups that were not enabling openapi in the recent past. Two possibilities for flakes: Enabling openapi in all integration test setups was expensive and caused spurious timeouts The excessive numbers of background panics handled and logged in integration tests when the API server tried to handle SSA requests bogged down the CI machine (I think something like 40,000 panics with full stack traces each were getting logged)\ni don't think that's the case. With the recent changes that I was doing as part of I think OpenAPI is already enabled for all tests having kube-apiserver (almost all) and that seems to work. But you remainded me that back then we also had an issue that we were running many more tests simulanuously, which could have been contributing to this problem significantly. The second reason is definitely possible contributor too. I guess my concern was that if some requests were panicing due to lack of OpenAPI, this means that these aren't really needed. But that actually might make sense - the fact that we weren't able to upgrade status of PriorityLevels/FlowSchemas shouldn't prevent non P&F-tests from succeeding, and that worked in P&F tests...\nI think the panics were happening in async controllers, and no functionality blocked by the controllers intersected with the surface being tested, it just (maybe) caused log/perf issues\nI believe has resolved the panic issue, I was able to verify with which changes the priority & fairness controller to use server side apply. Before merged, I analyzed the integration log: Integration test log file from an unrelated pr does not contain any trace of the panic as expected: On the other hand, the log file from integration job for (before merged) had plenty of these panics even though the integration job turned green: I wanted to check which tests produced these panics, so I did a breakdown by package Then I narrowed it down to the individual test(s): Before merged, the above tests used , and either is or is which results in to be nil. But a quick code search revealed that many more integration tests used , so why were the other tests not affected by the panic? I inspected the log of a test that was not affected by the panic, and grepped for , and found the following: In the above case, the apf controller had not advanced far enough, the controller was active for about , may be these tests finish quickly and signals the server to shutdown before the apf controller can send an APPLY command. On the other hand, log from a test that was affected by the panic shows that the apf controller was active for more than , and has lot more activities: I am assuming that integration tests have at least log level 4. Also, the size of the log file differed significantly, without panics around , and with panics over and changed all these tests to use and now integration log for shows no panic.\nGreat! (This also proves why eliminating gazilion different things of initializing stuff in favor of one makes sense). - FYI ^^ - let's merge the PR then - I just one question there, so let's wait for Jordan to respond it.\nCan we just force the openapi/fieldmanager to be set at start-time now that SSA is GA, it should basically always be present, rather than fail when SSA is unavailable (that's probably wrong by the way). If that triggers any test flakiness, then we would solve these. We can wait for to be solved since it will almost certainly have a huge impact on this.\nHas this been done Jeff?", "positive_passages": [{"docid": "doc-en-kubernetes-92c8793edca32ab6b7b03535d9859693100389c5faa8dadcd0b62e3e4d195ad2", "text": "// if we are going to issue an update, be sure we track every name we update so we know if we update it too often. currResult.updatedItems.Insert(fsu.flowSchema.Name) <del> patchBytes, err := makeFlowSchemaConditionPatch(fsu.condition) if err != nil { // should never happen because these conditions are created here and well formed panic(fmt.Sprintf(\"Failed to json.Marshall(%#+v): %s\", fsu.condition, err.Error())) } </del> if klogV := klog.V(4); klogV.Enabled() { klogV.Infof(\"%s writing Condition %s to FlowSchema %s, which had ResourceVersion=%s, because its previous value was %s, diff: %s\", cfgCtlr.name, fsu.condition, fsu.flowSchema.Name, fsu.flowSchema.ResourceVersion, fcfmt.Fmt(fsu.oldValue), cmp.Diff(fsu.oldValue, fsu.condition)) } <del> fsIfc := cfgCtlr.flowcontrolClient.FlowSchemas() patchOptions := metav1.PatchOptions{FieldManager: cfgCtlr.asFieldManager} _, err = fsIfc.Patch(context.TODO(), fsu.flowSchema.Name, apitypes.StrategicMergePatchType, patchBytes, patchOptions, \"status\") if err != nil { </del> <ins> if err := apply(cfgCtlr.flowcontrolClient.FlowSchemas(), fsu, cfgCtlr.asFieldManager); err != nil { </ins> if apierrors.IsNotFound(err) { // This object has been deleted.  A notification is coming // and nothing more needs to be done here.", "commid": "kubernetes_pr_110173"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9fbcd5201ae07f3b7a89bd2301992ba7ab5d6d8edc83db6ef44c2beaac86b1f5", "query": "Integration test timed out due to the following error The error appeared 748 times in the log. Looks like lots of churning happens during the apf configuration bootstrapping phase. Is there a race condition between when the type is being registered and the API calls? Stack trace: Integration job link: PR: I searched for this error in CI and this PR, looks like we only see this error in this PR so far. So I am hoping it has not introduced any flake. (maybe we need to let more time to pass to start seeing flakes) We should not see this error I saw it only in the PR mentioned.\n/sig api-machinery cc\nI see\nThe fact that it happens to a non-mandatory object implies that the object was received from the server, so the type must be in the server. The APF config-consuming controller does this:\nLook for the output from this line:\nAnother PR with this failure:\nthe panic means the request scope FieldManager is nil that is initialized here: OpenAPIModels is set here: called from here: and openAPIModels is constructed here: it looks like it is possible for openapiconfig to be unset, which causes the openapi models to be nil, which causes apply to panic. I don't know if it is only the integration tests that are subject to that configuration. cc /priority important-soon (since this is now being exercised in bring-up of integration test servers)\nif APF is creating/bootstrapping the objects without using apply, and then updating status using apply, that would explain how the object exists but apply fails\nI suspect that APF is not successfully updating status at all in the integration tests with this server configuration\ndo you want me to revert , while we work on a solution?\nI don't know how bad the test impact is. Work with / to determine if we should revert or fix forward\n: I do not follow why you talked about server-side stuff then suggested the problem is in the client (a controller in the kube-apiserver) not supplying a fieldManager. The client does supply the fieldManager, for both creates and updates. See the following lines:\nDifferent field manager. is set server-side in the endpoint handler based on the server configuration.\nSo if the problem is server-side, why did you suggest the problem is in the client?\nRegarding the client, I looked in and found this line: actually several of the same form, all with the same fieldManager.\nI don't think I did suggest that :) all of the setup and calls in are server-side\n: please help me understand . That is about the client side. Are you saying that a client that creates an object using and later updates the object using --- with a non-empty fieldManager in both --- will run into this server-side scenario? If so, is that because this client behavior is wrong or because there is a bug server side?\nThat was in response to , trying to figure out how the object was created but could not be updated. Yes, when the server is not configured to enable openapi and therefore does not have apply enabled. Because the server is misconfigured (which, from what I can tell, is limited to some of the server instances started for integration tests)\nLooking at and it is not obvious to me whether or how openapi could be disabled. Would that be by turning off the feature flag? FYI, the inclusion of \"V3\" in the flag makes me unsure what the server does about other versions. : I think you are saying that it is possible to disable openapi and that this in turn disables server-side apply. That seems kind of surprising to me. Does this mean that it is simply incorrect to run a client that does server-side apply with a server that has openapi disabled? Is this intended? Is it documented anywhere?\nIt's not intended as an externalized configuration option. integration tests have the ability to fiddle with many of the config struct options in the server that a kube-apiserver binary invocation could not. They intentionally use this to do things like inject specialized authorizers / authenticators for testing purposes, but also can unintentionally result in a test server that doesn't match a real API server invocation. I think this is an integration test server configuration problem, which should be fixed.\nis correct that we have a misconfiguration in the integration tests and SSA is only enabled on a subset of integration tests. I'd like to understand the test failure conditions a bit better though. The can be consistently reproduced on a non SSA targeted test. (Eg: selected from one of the test failures). However, I'm seeing the panic message while the test is still green and passes locally. it's a bit bizarre what contributes to the flakiness of the test because the FieldManager panic can be reproduced 100% of the time.\nThe panic occurs when APF is updating status (which it just switched to do using SSA). The APF status update failure does not block the API requests the test cares about, so the test passes. I could see extra CPU usage contributing to flakiness.\nThanks for the explanation. Created to fix the integration test configurations.\n/triage accepted\nThe integration test job started timing out dramatically last night (50% of runs) once merged. Since that was the only change made to integration tests recently, it seems related. I think we should revert (and therefore ) until the test impact is understood\nrevert of -\ndid this get fully reverted? we're still seeing panics in integration tests over this:\nbumping priority and milestoning until we know we're not currently triggering panics\nlooks like it got reintroduced in , revert open in\nFor integration tests, maybe we can cheat and cache the OpenAPI data, so that it's not recomputed for each test?\n:-/ maybe... but I really don't want to have non-real init paths in integration if at all possible\nI wish we could go a little further in lazily initializing openapi (especially v2), so let's see what we can do here (after code-freeze probably)\nif SSA is actively using the openapi, it being lazy won't help, right?\ndoes the revert mean that we can remove milestone v1.24 from this issue?\nYes, cleared\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle rotten\nTaking a fresh look at this PR and wondering if it has been mostly fixed already? From comments my understanding is that this panic occurred due to two conditions: running as part of the integration test suite is asked to service an SSA request while are nil. The apiservice has logic to panic in this case. From the code path commented is nil when the server is created with is nil. APF worker (running alongside an integration test) issues an SSA request to the test apiserver. Since the apiserver is misconfigured it panics. This panic could happen sporadically because sometimes the tests finish before the APF worker is able to issue the request. As a brief check to see if this might be fixed, I ran the test mentioned was failing from SSA. I logged out the 's created and found that they all had managed fields. I saw this as an indication SSA was now functioning properly. Indeed, to start the test server the function calls . This function has a code path which unconditionally leads to the apiserver's being set. calls before running the returned apiserver: calls before using the returned config to create the returned apiserver: uses which sets : Thus, any test using should no longer be affected by this panic. The question then becomes: do all integration tests start their servers in this way? It's hard to say. I found a PR (, ) which refactors many occurrences of the old stanza: Into something using the new method: ` But it appears is still being used in a few integration tests: Should these occurrences be refactored to use too?\nThere was a ton of changes I did around that. But the last PR (already removing the old is already out for review): - FYI Thinking about it now, I guess I agree that the problem might have been 10 different way kube-apiserver was set up through different tests. I just don't know why it was causing flakes, not failing consistently...\nThere were definitely test setups that were not enabling openapi in the recent past. Two possibilities for flakes: Enabling openapi in all integration test setups was expensive and caused spurious timeouts The excessive numbers of background panics handled and logged in integration tests when the API server tried to handle SSA requests bogged down the CI machine (I think something like 40,000 panics with full stack traces each were getting logged)\ni don't think that's the case. With the recent changes that I was doing as part of I think OpenAPI is already enabled for all tests having kube-apiserver (almost all) and that seems to work. But you remainded me that back then we also had an issue that we were running many more tests simulanuously, which could have been contributing to this problem significantly. The second reason is definitely possible contributor too. I guess my concern was that if some requests were panicing due to lack of OpenAPI, this means that these aren't really needed. But that actually might make sense - the fact that we weren't able to upgrade status of PriorityLevels/FlowSchemas shouldn't prevent non P&F-tests from succeeding, and that worked in P&F tests...\nI think the panics were happening in async controllers, and no functionality blocked by the controllers intersected with the surface being tested, it just (maybe) caused log/perf issues\nI believe has resolved the panic issue, I was able to verify with which changes the priority & fairness controller to use server side apply. Before merged, I analyzed the integration log: Integration test log file from an unrelated pr does not contain any trace of the panic as expected: On the other hand, the log file from integration job for (before merged) had plenty of these panics even though the integration job turned green: I wanted to check which tests produced these panics, so I did a breakdown by package Then I narrowed it down to the individual test(s): Before merged, the above tests used , and either is or is which results in to be nil. But a quick code search revealed that many more integration tests used , so why were the other tests not affected by the panic? I inspected the log of a test that was not affected by the panic, and grepped for , and found the following: In the above case, the apf controller had not advanced far enough, the controller was active for about , may be these tests finish quickly and signals the server to shutdown before the apf controller can send an APPLY command. On the other hand, log from a test that was affected by the panic shows that the apf controller was active for more than , and has lot more activities: I am assuming that integration tests have at least log level 4. Also, the size of the log file differed significantly, without panics around , and with panics over and changed all these tests to use and now integration log for shows no panic.\nGreat! (This also proves why eliminating gazilion different things of initializing stuff in favor of one makes sense). - FYI ^^ - let's merge the PR then - I just one question there, so let's wait for Jordan to respond it.\nCan we just force the openapi/fieldmanager to be set at start-time now that SSA is GA, it should basically always be present, rather than fail when SSA is unavailable (that's probably wrong by the way). If that triggers any test flakiness, then we would solve these. We can wait for to be solved since it will almost certainly have a huge impact on this.\nHas this been done Jeff?", "positive_passages": [{"docid": "doc-en-kubernetes-f386a203da17b33683bf4909146697a909204820ad922f1b45aa78104fbe1734", "text": "return suggestedDelay, utilerrors.NewAggregate(errs) } <del> // makeFlowSchemaConditionPatch takes in a condition and returns the patch status as a json. func makeFlowSchemaConditionPatch(condition flowcontrol.FlowSchemaCondition) ([]byte, error) { o := struct { Status flowcontrol.FlowSchemaStatus `json:\"status\"` }{ Status: flowcontrol.FlowSchemaStatus{ Conditions: []flowcontrol.FlowSchemaCondition{ condition, }, }, } return json.Marshal(o) </del> <ins> func apply(client flowcontrolclient.FlowSchemaInterface, fsu fsStatusUpdate, asFieldManager string) error { applyOptions := metav1.ApplyOptions{FieldManager: asFieldManager, Force: true} // the condition field in fsStatusUpdate holds the new condition we want to update. // TODO: this will break when we have multiple conditions for a flowschema _, err := client.ApplyStatus(context.TODO(), toFlowSchemaApplyConfiguration(fsu), applyOptions) return err } func toFlowSchemaApplyConfiguration(fsUpdate fsStatusUpdate) *flowcontrolapplyconfiguration.FlowSchemaApplyConfiguration { condition := flowcontrolapplyconfiguration.FlowSchemaCondition(). WithType(fsUpdate.condition.Type). WithStatus(fsUpdate.condition.Status). WithReason(fsUpdate.condition.Reason). WithLastTransitionTime(fsUpdate.condition.LastTransitionTime). WithMessage(fsUpdate.condition.Message) return flowcontrolapplyconfiguration.FlowSchema(fsUpdate.flowSchema.Name). WithStatus(flowcontrolapplyconfiguration.FlowSchemaStatus(). WithConditions(condition), ) </ins> } // shouldDelayUpdate checks to see if a flowschema has been updated too often and returns true if a delay is needed.", "commid": "kubernetes_pr_110173"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9fbcd5201ae07f3b7a89bd2301992ba7ab5d6d8edc83db6ef44c2beaac86b1f5", "query": "Integration test timed out due to the following error The error appeared 748 times in the log. Looks like lots of churning happens during the apf configuration bootstrapping phase. Is there a race condition between when the type is being registered and the API calls? Stack trace: Integration job link: PR: I searched for this error in CI and this PR, looks like we only see this error in this PR so far. So I am hoping it has not introduced any flake. (maybe we need to let more time to pass to start seeing flakes) We should not see this error I saw it only in the PR mentioned.\n/sig api-machinery cc\nI see\nThe fact that it happens to a non-mandatory object implies that the object was received from the server, so the type must be in the server. The APF config-consuming controller does this:\nLook for the output from this line:\nAnother PR with this failure:\nthe panic means the request scope FieldManager is nil that is initialized here: OpenAPIModels is set here: called from here: and openAPIModels is constructed here: it looks like it is possible for openapiconfig to be unset, which causes the openapi models to be nil, which causes apply to panic. I don't know if it is only the integration tests that are subject to that configuration. cc /priority important-soon (since this is now being exercised in bring-up of integration test servers)\nif APF is creating/bootstrapping the objects without using apply, and then updating status using apply, that would explain how the object exists but apply fails\nI suspect that APF is not successfully updating status at all in the integration tests with this server configuration\ndo you want me to revert , while we work on a solution?\nI don't know how bad the test impact is. Work with / to determine if we should revert or fix forward\n: I do not follow why you talked about server-side stuff then suggested the problem is in the client (a controller in the kube-apiserver) not supplying a fieldManager. The client does supply the fieldManager, for both creates and updates. See the following lines:\nDifferent field manager. is set server-side in the endpoint handler based on the server configuration.\nSo if the problem is server-side, why did you suggest the problem is in the client?\nRegarding the client, I looked in and found this line: actually several of the same form, all with the same fieldManager.\nI don't think I did suggest that :) all of the setup and calls in are server-side\n: please help me understand . That is about the client side. Are you saying that a client that creates an object using and later updates the object using --- with a non-empty fieldManager in both --- will run into this server-side scenario? If so, is that because this client behavior is wrong or because there is a bug server side?\nThat was in response to , trying to figure out how the object was created but could not be updated. Yes, when the server is not configured to enable openapi and therefore does not have apply enabled. Because the server is misconfigured (which, from what I can tell, is limited to some of the server instances started for integration tests)\nLooking at and it is not obvious to me whether or how openapi could be disabled. Would that be by turning off the feature flag? FYI, the inclusion of \"V3\" in the flag makes me unsure what the server does about other versions. : I think you are saying that it is possible to disable openapi and that this in turn disables server-side apply. That seems kind of surprising to me. Does this mean that it is simply incorrect to run a client that does server-side apply with a server that has openapi disabled? Is this intended? Is it documented anywhere?\nIt's not intended as an externalized configuration option. integration tests have the ability to fiddle with many of the config struct options in the server that a kube-apiserver binary invocation could not. They intentionally use this to do things like inject specialized authorizers / authenticators for testing purposes, but also can unintentionally result in a test server that doesn't match a real API server invocation. I think this is an integration test server configuration problem, which should be fixed.\nis correct that we have a misconfiguration in the integration tests and SSA is only enabled on a subset of integration tests. I'd like to understand the test failure conditions a bit better though. The can be consistently reproduced on a non SSA targeted test. (Eg: selected from one of the test failures). However, I'm seeing the panic message while the test is still green and passes locally. it's a bit bizarre what contributes to the flakiness of the test because the FieldManager panic can be reproduced 100% of the time.\nThe panic occurs when APF is updating status (which it just switched to do using SSA). The APF status update failure does not block the API requests the test cares about, so the test passes. I could see extra CPU usage contributing to flakiness.\nThanks for the explanation. Created to fix the integration test configurations.\n/triage accepted\nThe integration test job started timing out dramatically last night (50% of runs) once merged. Since that was the only change made to integration tests recently, it seems related. I think we should revert (and therefore ) until the test impact is understood\nrevert of -\ndid this get fully reverted? we're still seeing panics in integration tests over this:\nbumping priority and milestoning until we know we're not currently triggering panics\nlooks like it got reintroduced in , revert open in\nFor integration tests, maybe we can cheat and cache the OpenAPI data, so that it's not recomputed for each test?\n:-/ maybe... but I really don't want to have non-real init paths in integration if at all possible\nI wish we could go a little further in lazily initializing openapi (especially v2), so let's see what we can do here (after code-freeze probably)\nif SSA is actively using the openapi, it being lazy won't help, right?\ndoes the revert mean that we can remove milestone v1.24 from this issue?\nYes, cleared\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle rotten\nTaking a fresh look at this PR and wondering if it has been mostly fixed already? From comments my understanding is that this panic occurred due to two conditions: running as part of the integration test suite is asked to service an SSA request while are nil. The apiservice has logic to panic in this case. From the code path commented is nil when the server is created with is nil. APF worker (running alongside an integration test) issues an SSA request to the test apiserver. Since the apiserver is misconfigured it panics. This panic could happen sporadically because sometimes the tests finish before the APF worker is able to issue the request. As a brief check to see if this might be fixed, I ran the test mentioned was failing from SSA. I logged out the 's created and found that they all had managed fields. I saw this as an indication SSA was now functioning properly. Indeed, to start the test server the function calls . This function has a code path which unconditionally leads to the apiserver's being set. calls before running the returned apiserver: calls before using the returned config to create the returned apiserver: uses which sets : Thus, any test using should no longer be affected by this panic. The question then becomes: do all integration tests start their servers in this way? It's hard to say. I found a PR (, ) which refactors many occurrences of the old stanza: Into something using the new method: ` But it appears is still being used in a few integration tests: Should these occurrences be refactored to use too?\nThere was a ton of changes I did around that. But the last PR (already removing the old is already out for review): - FYI Thinking about it now, I guess I agree that the problem might have been 10 different way kube-apiserver was set up through different tests. I just don't know why it was causing flakes, not failing consistently...\nThere were definitely test setups that were not enabling openapi in the recent past. Two possibilities for flakes: Enabling openapi in all integration test setups was expensive and caused spurious timeouts The excessive numbers of background panics handled and logged in integration tests when the API server tried to handle SSA requests bogged down the CI machine (I think something like 40,000 panics with full stack traces each were getting logged)\ni don't think that's the case. With the recent changes that I was doing as part of I think OpenAPI is already enabled for all tests having kube-apiserver (almost all) and that seems to work. But you remainded me that back then we also had an issue that we were running many more tests simulanuously, which could have been contributing to this problem significantly. The second reason is definitely possible contributor too. I guess my concern was that if some requests were panicing due to lack of OpenAPI, this means that these aren't really needed. But that actually might make sense - the fact that we weren't able to upgrade status of PriorityLevels/FlowSchemas shouldn't prevent non P&F-tests from succeeding, and that worked in P&F tests...\nI think the panics were happening in async controllers, and no functionality blocked by the controllers intersected with the surface being tested, it just (maybe) caused log/perf issues\nI believe has resolved the panic issue, I was able to verify with which changes the priority & fairness controller to use server side apply. Before merged, I analyzed the integration log: Integration test log file from an unrelated pr does not contain any trace of the panic as expected: On the other hand, the log file from integration job for (before merged) had plenty of these panics even though the integration job turned green: I wanted to check which tests produced these panics, so I did a breakdown by package Then I narrowed it down to the individual test(s): Before merged, the above tests used , and either is or is which results in to be nil. But a quick code search revealed that many more integration tests used , so why were the other tests not affected by the panic? I inspected the log of a test that was not affected by the panic, and grepped for , and found the following: In the above case, the apf controller had not advanced far enough, the controller was active for about , may be these tests finish quickly and signals the server to shutdown before the apf controller can send an APPLY command. On the other hand, log from a test that was affected by the panic shows that the apf controller was active for more than , and has lot more activities: I am assuming that integration tests have at least log level 4. Also, the size of the log file differed significantly, without panics around , and with panics over and changed all these tests to use and now integration log for shows no panic.\nGreat! (This also proves why eliminating gazilion different things of initializing stuff in favor of one makes sense). - FYI ^^ - let's merge the PR then - I just one question there, so let's wait for Jordan to respond it.\nCan we just force the openapi/fieldmanager to be set at start-time now that SSA is GA, it should basically always be present, rather than fail when SSA is unavailable (that's probably wrong by the way). If that triggers any test flakiness, then we would solve these. We can wait for to be solved since it will almost certainly have a huge impact on this.\nHas this been done Jeff?", "positive_passages": [{"docid": "doc-en-kubernetes-93225da96a516ca529003757567582f9ea126f16e21f449d6ab0df15e1c3251b", "text": "<del> /* Copyright 2021 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package flowcontrol import ( \"fmt\" \"reflect\" \"testing\" \"time\" \"github.com/google/go-cmp/cmp\" flowcontrol \"k8s.io/api/flowcontrol/v1beta3\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" ) func Test_configController_generatePatchBytes(t *testing.T) { now := time.Now().UTC() tests := []struct { name      string condition flowcontrol.FlowSchemaCondition want      []byte }{ { name: \"check if only condition is parsed\", condition: flowcontrol.FlowSchemaCondition{ Type:               flowcontrol.FlowSchemaConditionDangling, Status:             flowcontrol.ConditionTrue, Reason:             \"test reason\", Message:            \"test none\", LastTransitionTime: metav1.NewTime(now), }, want: []byte(fmt.Sprintf(`{\"status\":{\"conditions\":[{\"type\":\"Dangling\",\"status\":\"True\",\"lastTransitionTime\":\"%s\",\"reason\":\"test reason\",\"message\":\"test none\"}]}}`, now.Format(time.RFC3339))), }, { name: \"check when message has double quotes\", condition: flowcontrol.FlowSchemaCondition{ Type:               flowcontrol.FlowSchemaConditionDangling, Status:             flowcontrol.ConditionTrue, Reason:             \"test reason\", Message:            `test \"\"none`, LastTransitionTime: metav1.NewTime(now), }, want: []byte(fmt.Sprintf(`{\"status\":{\"conditions\":[{\"type\":\"Dangling\",\"status\":\"True\",\"lastTransitionTime\":\"%s\",\"reason\":\"test reason\",\"message\":\"test \"\"none\"}]}}`, now.Format(time.RFC3339))), }, { name: \"check when message has a whitespace character that can be escaped\", condition: flowcontrol.FlowSchemaCondition{ Type:               flowcontrol.FlowSchemaConditionDangling, Status:             flowcontrol.ConditionTrue, Reason:             \"test reason\", Message:            \"test u0009u0009none\", LastTransitionTime: metav1.NewTime(now), }, want: []byte(fmt.Sprintf(`{\"status\":{\"conditions\":[{\"type\":\"Dangling\",\"status\":\"True\",\"lastTransitionTime\":\"%s\",\"reason\":\"test reason\",\"message\":\"test ttnone\"}]}}`, now.Format(time.RFC3339))), }, { name: \"check when a few fields (message & lastTransitionTime) are missing\", condition: flowcontrol.FlowSchemaCondition{ Type:   flowcontrol.FlowSchemaConditionDangling, Status: flowcontrol.ConditionTrue, Reason: \"test reason\", }, want: []byte(`{\"status\":{\"conditions\":[{\"type\":\"Dangling\",\"status\":\"True\",\"lastTransitionTime\":null,\"reason\":\"test reason\"}]}}`), }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { got, _ := makeFlowSchemaConditionPatch(tt.condition) if !reflect.DeepEqual(got, tt.want) { t.Errorf(\"makeFlowSchemaConditionPatch() got = %s, want %s; diff is %s\", got, tt.want, cmp.Diff(tt.want, got)) } }) } } </del>", "commid": "kubernetes_pr_110173"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9fac73cbeefff3e50660c328aaeeb2b47c423f7885694acc8690c878b3ad99f5", "query": "Unit test in package flakes there is a race condition between the go routine that executes the request handler and the timeout go routine that waits for the handler to finish /sig api-machinery\n/assign\nI have a PR in the works\nshould fix it, I can easily reproduce it with the PR, the flake is not reproducible any more cc\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-6a3a0d101ee9a9bd9b64004faf299e3f3517939f5d662486d2142deb8f145941", "text": "}() }() <del> postTimeoutFn() </del> <ins> defer postTimeoutFn() </ins> tw.timeout(err) } }", "commid": "kubernetes_pr_107992"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9fac73cbeefff3e50660c328aaeeb2b47c423f7885694acc8690c878b3ad99f5", "query": "Unit test in package flakes there is a race condition between the go routine that executes the request handler and the timeout go routine that waits for the handler to finish /sig api-machinery\n/assign\nI have a PR in the works\nshould fix it, I can easily reproduce it with the PR, the flake is not reproducible any more cc\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-546e0f0e94660ad0ffe2b3404674af482246a476bea24fd28278735d1db11693", "text": "}) } <ins> postTimeoutCh := make(chan struct{}) </ins> ts := httptest.NewServer( withDeadline( WithTimeout(", "commid": "kubernetes_pr_107992"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9fac73cbeefff3e50660c328aaeeb2b47c423f7885694acc8690c878b3ad99f5", "query": "Unit test in package flakes there is a race condition between the go routine that executes the request handler and the timeout go routine that waits for the handler to finish /sig api-machinery\n/assign\nI have a PR in the works\nshould fix it, I can easily reproduce it with the PR, the flake is not reproducible any more cc\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-18d7b0e088c3001bef37ed708a585c2916f0df9bd44dda4bc2ca467cb02545b7", "text": "h := w.Header() // trigger the timeout cancel() <del> // mutate response Headers for j := 0; j < 1000; j++ { h.Set(\"Test\", \"post\") </del> <ins> // keep mutating response Headers until the request times out for { select { case <-postTimeoutCh: return default: h.Set(\"Test\", \"post\") } </ins> } }), func(req *http.Request) (*http.Request, bool, func(), *apierrors.StatusError) { <del> return req, false, func() {}, apierrors.NewServerTimeout(schema.GroupResource{Group: \"foo\", Resource: \"bar\"}, \"get\", 0) </del> <ins> return req, false, func() { close(postTimeoutCh) }, apierrors.NewServerTimeout(schema.GroupResource{Group: \"foo\", Resource: \"bar\"}, \"get\", 0) </ins> }, ), ),", "commid": "kubernetes_pr_107992"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-56e7478c97a10d92fc7484acd2b672ce77d361e72c8e8784f90182dd99033ab6", "query": "In </span /kind failing-test <!-- If this is a flake, please add: /kind flake --/sig node I believe the issue here is that the test is trying to get 5 restarts, but if we don't start the loop until after a few failures have occurred we start getting caught up in exponential backoff. The 6th backoff iteration is a 2m30s wait (i believe), so we exceed the default timeout of 5m for the test. We may need to change the test so that we are watching for pod status updates and catch the first one. HOWEVER - there's also some head of line blocking in pod status manager updates that I suspect might result in updates getting delayed, leading to timeout. Either way, the test has too little margin with exponential failure backoff to be reliable, and needs to be improved.\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-8a1b50b2b7a81c9fa0575a72ba5bacb76bb19f7079a358a77c60df2d229a8d2d", "text": "FailureThreshold:    1, } pod := livenessPodSpec(f.Namespace.Name, nil, livenessProbe) <del> RunLivenessTest(f, pod, 5, time.Minute*5) </del> <ins> // ~2 minutes backoff timeouts + 4 minutes defaultObservationTimeout + 2 minutes for each pod restart RunLivenessTest(f, pod, 5, 2*time.Minute+defaultObservationTimeout+4*2*time.Minute) </ins> }) /*", "commid": "kubernetes_pr_108652"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f05405644445a0e792013d4eae28a3cb46c227199ee42d853fdd090273fe2800", "query": "Since scheduler Policy API was total removed, we don't support any more. Remove unsupported configuration.\n/sig scheduling /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig scheduling /cc\n/sig scheduling (trying to tell the bots to remove )\nThe label(s) cannot be applied. These labels are supported: <detailsIn response to : /remove-needs sig /remove-label needs-sig Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's true scheduler doesn't quite use this field anymore, but I'm wondering if some other project like ClusterAutoscaler or simulator still consumes this via .\nThere's no place we can config this field now by configure file(before we can apply the change by policy api, but now it's removed). So it seems like unless we support this feature with CC, or this field is useless. To other projects, it's the same. When they are using legacy policy api, they can configure this field, but once they synced with the latest kubernetes, with the policy api removed, they can not configure this anymore. In this situation, we should add support in CC. I don't quite understand the relationship between k/k with k/autoscaling or others, I think they sync with k/k periodic.\nAs I mentioned above, it's still accessible via a framework runtime programmatically, and thus may be still useful. For example, upon a scheduling failure, a ClusterAutoscaler's implementation may choose to dryrun through all filter plugins to ensure a new provisioned node can fit the pod, instead of resolving the failure while failing at another latter filter plugin.\nOh, I haven't thought of configuration via programmatically, that saved my concern. But a little strange.\nThat's exactly what I meant. Given it's a public option in framework, and there is no alternative if we disabled it, it'd be good to check with potential consumers. For now I can think of CA ( and k-sigs/scheduler-simulator ( If they can confirm it's not needed in their usecases, I'm fine with removing .\nTo k/autoscaler, at least these codes are still there together with the legacy policy api. , looking forward to the response.\nis not used in sigs/kube-scheduler-simulator. \u200d\nthis isn't used by cluster autoscaler, we can remove it.", "positive_passages": [{"docid": "doc-en-kubernetes-784f8eba5c56b8ef10e9d121a12b108cd15eaea7bb9c86158d9dbf2eb227c275", "text": "framework.PodNominator parallelizer parallelize.Parallelizer <del> // Indicates that RunFilterPlugins should accumulate all failed statuses and not return // after the first failure. runAllFilters bool </del> } // extensionPoint encapsulates desired and applied set of plugins at a specific extension", "commid": "kubernetes_pr_108829"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f05405644445a0e792013d4eae28a3cb46c227199ee42d853fdd090273fe2800", "query": "Since scheduler Policy API was total removed, we don't support any more. Remove unsupported configuration.\n/sig scheduling /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig scheduling /cc\n/sig scheduling (trying to tell the bots to remove )\nThe label(s) cannot be applied. These labels are supported: <detailsIn response to : /remove-needs sig /remove-label needs-sig Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's true scheduler doesn't quite use this field anymore, but I'm wondering if some other project like ClusterAutoscaler or simulator still consumes this via .\nThere's no place we can config this field now by configure file(before we can apply the change by policy api, but now it's removed). So it seems like unless we support this feature with CC, or this field is useless. To other projects, it's the same. When they are using legacy policy api, they can configure this field, but once they synced with the latest kubernetes, with the policy api removed, they can not configure this anymore. In this situation, we should add support in CC. I don't quite understand the relationship between k/k with k/autoscaling or others, I think they sync with k/k periodic.\nAs I mentioned above, it's still accessible via a framework runtime programmatically, and thus may be still useful. For example, upon a scheduling failure, a ClusterAutoscaler's implementation may choose to dryrun through all filter plugins to ensure a new provisioned node can fit the pod, instead of resolving the failure while failing at another latter filter plugin.\nOh, I haven't thought of configuration via programmatically, that saved my concern. But a little strange.\nThat's exactly what I meant. Given it's a public option in framework, and there is no alternative if we disabled it, it'd be good to check with potential consumers. For now I can think of CA ( and k-sigs/scheduler-simulator ( If they can confirm it's not needed in their usecases, I'm fine with removing .\nTo k/autoscaler, at least these codes are still there together with the legacy policy api. , looking forward to the response.\nis not used in sigs/kube-scheduler-simulator. \u200d\nthis isn't used by cluster autoscaler, we can remove it.", "positive_passages": [{"docid": "doc-en-kubernetes-cb6e30dbef9523459a5931d304cdaab869194e0351389d8a6becd33d7306e60c", "text": "metricsRecorder        *metricsRecorder podNominator           framework.PodNominator extenders              []framework.Extender <del> runAllFilters          bool </del> captureProfile         CaptureProfile clusterEventMap        map[framework.ClusterEvent]sets.String parallelizer           parallelize.Parallelizer", "commid": "kubernetes_pr_108829"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f05405644445a0e792013d4eae28a3cb46c227199ee42d853fdd090273fe2800", "query": "Since scheduler Policy API was total removed, we don't support any more. Remove unsupported configuration.\n/sig scheduling /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig scheduling /cc\n/sig scheduling (trying to tell the bots to remove )\nThe label(s) cannot be applied. These labels are supported: <detailsIn response to : /remove-needs sig /remove-label needs-sig Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's true scheduler doesn't quite use this field anymore, but I'm wondering if some other project like ClusterAutoscaler or simulator still consumes this via .\nThere's no place we can config this field now by configure file(before we can apply the change by policy api, but now it's removed). So it seems like unless we support this feature with CC, or this field is useless. To other projects, it's the same. When they are using legacy policy api, they can configure this field, but once they synced with the latest kubernetes, with the policy api removed, they can not configure this anymore. In this situation, we should add support in CC. I don't quite understand the relationship between k/k with k/autoscaling or others, I think they sync with k/k periodic.\nAs I mentioned above, it's still accessible via a framework runtime programmatically, and thus may be still useful. For example, upon a scheduling failure, a ClusterAutoscaler's implementation may choose to dryrun through all filter plugins to ensure a new provisioned node can fit the pod, instead of resolving the failure while failing at another latter filter plugin.\nOh, I haven't thought of configuration via programmatically, that saved my concern. But a little strange.\nThat's exactly what I meant. Given it's a public option in framework, and there is no alternative if we disabled it, it'd be good to check with potential consumers. For now I can think of CA ( and k-sigs/scheduler-simulator ( If they can confirm it's not needed in their usecases, I'm fine with removing .\nTo k/autoscaler, at least these codes are still there together with the legacy policy api. , looking forward to the response.\nis not used in sigs/kube-scheduler-simulator. \u200d\nthis isn't used by cluster autoscaler, we can remove it.", "positive_passages": [{"docid": "doc-en-kubernetes-25c7a23ee31e825031d53a13c06806bfda44da61344a194321b931d894dfde12", "text": "} } <del> // WithRunAllFilters sets the runAllFilters flag, which means RunFilterPlugins accumulates // all failure Statuses. func WithRunAllFilters(runAllFilters bool) Option { return func(o *frameworkOptions) { o.runAllFilters = runAllFilters } } </del> // WithPodNominator sets podNominator for the scheduling frameworkImpl. func WithPodNominator(nominator framework.PodNominator) Option { return func(o *frameworkOptions) {", "commid": "kubernetes_pr_108829"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f05405644445a0e792013d4eae28a3cb46c227199ee42d853fdd090273fe2800", "query": "Since scheduler Policy API was total removed, we don't support any more. Remove unsupported configuration.\n/sig scheduling /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig scheduling /cc\n/sig scheduling (trying to tell the bots to remove )\nThe label(s) cannot be applied. These labels are supported: <detailsIn response to : /remove-needs sig /remove-label needs-sig Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's true scheduler doesn't quite use this field anymore, but I'm wondering if some other project like ClusterAutoscaler or simulator still consumes this via .\nThere's no place we can config this field now by configure file(before we can apply the change by policy api, but now it's removed). So it seems like unless we support this feature with CC, or this field is useless. To other projects, it's the same. When they are using legacy policy api, they can configure this field, but once they synced with the latest kubernetes, with the policy api removed, they can not configure this anymore. In this situation, we should add support in CC. I don't quite understand the relationship between k/k with k/autoscaling or others, I think they sync with k/k periodic.\nAs I mentioned above, it's still accessible via a framework runtime programmatically, and thus may be still useful. For example, upon a scheduling failure, a ClusterAutoscaler's implementation may choose to dryrun through all filter plugins to ensure a new provisioned node can fit the pod, instead of resolving the failure while failing at another latter filter plugin.\nOh, I haven't thought of configuration via programmatically, that saved my concern. But a little strange.\nThat's exactly what I meant. Given it's a public option in framework, and there is no alternative if we disabled it, it'd be good to check with potential consumers. For now I can think of CA ( and k-sigs/scheduler-simulator ( If they can confirm it's not needed in their usecases, I'm fine with removing .\nTo k/autoscaler, at least these codes are still there together with the legacy policy api. , looking forward to the response.\nis not used in sigs/kube-scheduler-simulator. \u200d\nthis isn't used by cluster autoscaler, we can remove it.", "positive_passages": [{"docid": "doc-en-kubernetes-c894b5616cc624512592b7f3e76d8f3980f50d59a2c68c7912c5893263353e80", "text": "eventRecorder:        options.eventRecorder, informerFactory:      options.informerFactory, metricsRecorder:      options.metricsRecorder, <del> runAllFilters:        options.runAllFilters, </del> extenders:            options.extenders, PodNominator:         options.podNominator, parallelizer:         options.parallelizer,", "commid": "kubernetes_pr_108829"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f05405644445a0e792013d4eae28a3cb46c227199ee42d853fdd090273fe2800", "query": "Since scheduler Policy API was total removed, we don't support any more. Remove unsupported configuration.\n/sig scheduling /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig scheduling /cc\n/sig scheduling (trying to tell the bots to remove )\nThe label(s) cannot be applied. These labels are supported: <detailsIn response to : /remove-needs sig /remove-label needs-sig Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's true scheduler doesn't quite use this field anymore, but I'm wondering if some other project like ClusterAutoscaler or simulator still consumes this via .\nThere's no place we can config this field now by configure file(before we can apply the change by policy api, but now it's removed). So it seems like unless we support this feature with CC, or this field is useless. To other projects, it's the same. When they are using legacy policy api, they can configure this field, but once they synced with the latest kubernetes, with the policy api removed, they can not configure this anymore. In this situation, we should add support in CC. I don't quite understand the relationship between k/k with k/autoscaling or others, I think they sync with k/k periodic.\nAs I mentioned above, it's still accessible via a framework runtime programmatically, and thus may be still useful. For example, upon a scheduling failure, a ClusterAutoscaler's implementation may choose to dryrun through all filter plugins to ensure a new provisioned node can fit the pod, instead of resolving the failure while failing at another latter filter plugin.\nOh, I haven't thought of configuration via programmatically, that saved my concern. But a little strange.\nThat's exactly what I meant. Given it's a public option in framework, and there is no alternative if we disabled it, it'd be good to check with potential consumers. For now I can think of CA ( and k-sigs/scheduler-simulator ( If they can confirm it's not needed in their usecases, I'm fine with removing .\nTo k/autoscaler, at least these codes are still there together with the legacy policy api. , looking forward to the response.\nis not used in sigs/kube-scheduler-simulator. \u200d\nthis isn't used by cluster autoscaler, we can remove it.", "positive_passages": [{"docid": "doc-en-kubernetes-e68972a7190657f58cc7d298b8fc7677f3e3648f3779549168dff69b572095d1", "text": "} pluginStatus.SetFailedPlugin(pl.Name()) statuses[pl.Name()] = pluginStatus <del> if !f.runAllFilters { // Exit early if we don't need to run all filters. return statuses } </del> } }", "commid": "kubernetes_pr_108829"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f05405644445a0e792013d4eae28a3cb46c227199ee42d853fdd090273fe2800", "query": "Since scheduler Policy API was total removed, we don't support any more. Remove unsupported configuration.\n/sig scheduling /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig scheduling /cc\n/sig scheduling (trying to tell the bots to remove )\nThe label(s) cannot be applied. These labels are supported: <detailsIn response to : /remove-needs sig /remove-label needs-sig Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's true scheduler doesn't quite use this field anymore, but I'm wondering if some other project like ClusterAutoscaler or simulator still consumes this via .\nThere's no place we can config this field now by configure file(before we can apply the change by policy api, but now it's removed). So it seems like unless we support this feature with CC, or this field is useless. To other projects, it's the same. When they are using legacy policy api, they can configure this field, but once they synced with the latest kubernetes, with the policy api removed, they can not configure this anymore. In this situation, we should add support in CC. I don't quite understand the relationship between k/k with k/autoscaling or others, I think they sync with k/k periodic.\nAs I mentioned above, it's still accessible via a framework runtime programmatically, and thus may be still useful. For example, upon a scheduling failure, a ClusterAutoscaler's implementation may choose to dryrun through all filter plugins to ensure a new provisioned node can fit the pod, instead of resolving the failure while failing at another latter filter plugin.\nOh, I haven't thought of configuration via programmatically, that saved my concern. But a little strange.\nThat's exactly what I meant. Given it's a public option in framework, and there is no alternative if we disabled it, it'd be good to check with potential consumers. For now I can think of CA ( and k-sigs/scheduler-simulator ( If they can confirm it's not needed in their usecases, I'm fine with removing .\nTo k/autoscaler, at least these codes are still there together with the legacy policy api. , looking forward to the response.\nis not used in sigs/kube-scheduler-simulator. \u200d\nthis isn't used by cluster autoscaler, we can remove it.", "positive_passages": [{"docid": "doc-en-kubernetes-6759317b68e0c9ee8df08422fe2f716e005f2c6e1ec69dd5473f9fb36707a6b6", "text": "plugins       []*TestPlugin wantStatus    *framework.Status wantStatusMap framework.PluginToStatus <del> runAllFilters bool </del> }{ { name: \"SuccessFilter\",", "commid": "kubernetes_pr_108829"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f05405644445a0e792013d4eae28a3cb46c227199ee42d853fdd090273fe2800", "query": "Since scheduler Policy API was total removed, we don't support any more. Remove unsupported configuration.\n/sig scheduling /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig scheduling /cc\n/sig scheduling (trying to tell the bots to remove )\nThe label(s) cannot be applied. These labels are supported: <detailsIn response to : /remove-needs sig /remove-label needs-sig Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's true scheduler doesn't quite use this field anymore, but I'm wondering if some other project like ClusterAutoscaler or simulator still consumes this via .\nThere's no place we can config this field now by configure file(before we can apply the change by policy api, but now it's removed). So it seems like unless we support this feature with CC, or this field is useless. To other projects, it's the same. When they are using legacy policy api, they can configure this field, but once they synced with the latest kubernetes, with the policy api removed, they can not configure this anymore. In this situation, we should add support in CC. I don't quite understand the relationship between k/k with k/autoscaling or others, I think they sync with k/k periodic.\nAs I mentioned above, it's still accessible via a framework runtime programmatically, and thus may be still useful. For example, upon a scheduling failure, a ClusterAutoscaler's implementation may choose to dryrun through all filter plugins to ensure a new provisioned node can fit the pod, instead of resolving the failure while failing at another latter filter plugin.\nOh, I haven't thought of configuration via programmatically, that saved my concern. But a little strange.\nThat's exactly what I meant. Given it's a public option in framework, and there is no alternative if we disabled it, it'd be good to check with potential consumers. For now I can think of CA ( and k-sigs/scheduler-simulator ( If they can confirm it's not needed in their usecases, I'm fine with removing .\nTo k/autoscaler, at least these codes are still there together with the legacy policy api. , looking forward to the response.\nis not used in sigs/kube-scheduler-simulator. \u200d\nthis isn't used by cluster autoscaler, we can remove it.", "positive_passages": [{"docid": "doc-en-kubernetes-3dec127209ab6b8e23e0e7876197ce50114bde8e0c5802d1eb79b8d6fd5eb64b", "text": "\"TestPlugin2\": framework.NewStatus(framework.Unschedulable, \"injected filter status\").WithFailedPlugin(\"TestPlugin2\"), }, }, <del> { name: \"SuccessFilterWithRunAllFilters\", plugins: []*TestPlugin{ { name: \"TestPlugin\", inj:  injectedResult{FilterStatus: int(framework.Success)}, }, }, runAllFilters: true, wantStatus:    nil, wantStatusMap: framework.PluginToStatus{}, }, { name: \"ErrorAndErrorFilters\", plugins: []*TestPlugin{ { name: \"TestPlugin1\", inj:  injectedResult{FilterStatus: int(framework.Error)}, }, { name: \"TestPlugin2\", inj:  injectedResult{FilterStatus: int(framework.Error)}, }, }, runAllFilters: true, wantStatus:    framework.AsStatus(fmt.Errorf(`running \"TestPlugin1\" filter plugin: %w`, errInjectedFilterStatus)).WithFailedPlugin(\"TestPlugin1\"), wantStatusMap: framework.PluginToStatus{ \"TestPlugin1\": framework.AsStatus(fmt.Errorf(`running \"TestPlugin1\" filter plugin: %w`, errInjectedFilterStatus)).WithFailedPlugin(\"TestPlugin1\"), }, }, { name: \"ErrorAndErrorFilters\", plugins: []*TestPlugin{ { name: \"TestPlugin1\", inj:  injectedResult{FilterStatus: int(framework.UnschedulableAndUnresolvable)}, }, { name: \"TestPlugin2\", inj:  injectedResult{FilterStatus: int(framework.Unschedulable)}, }, }, runAllFilters: true, wantStatus:    framework.NewStatus(framework.UnschedulableAndUnresolvable, \"injected filter status\", \"injected filter status\").WithFailedPlugin(\"TestPlugin1\"), wantStatusMap: framework.PluginToStatus{ \"TestPlugin1\": framework.NewStatus(framework.UnschedulableAndUnresolvable, \"injected filter status\").WithFailedPlugin(\"TestPlugin1\"), \"TestPlugin2\": framework.NewStatus(framework.Unschedulable, \"injected filter status\").WithFailedPlugin(\"TestPlugin2\"), }, }, </del> } for _, tt := range tests {", "commid": "kubernetes_pr_108829"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f05405644445a0e792013d4eae28a3cb46c227199ee42d853fdd090273fe2800", "query": "Since scheduler Policy API was total removed, we don't support any more. Remove unsupported configuration.\n/sig scheduling /assign\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig scheduling /cc\n/sig scheduling (trying to tell the bots to remove )\nThe label(s) cannot be applied. These labels are supported: <detailsIn response to : /remove-needs sig /remove-label needs-sig Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nIt's true scheduler doesn't quite use this field anymore, but I'm wondering if some other project like ClusterAutoscaler or simulator still consumes this via .\nThere's no place we can config this field now by configure file(before we can apply the change by policy api, but now it's removed). So it seems like unless we support this feature with CC, or this field is useless. To other projects, it's the same. When they are using legacy policy api, they can configure this field, but once they synced with the latest kubernetes, with the policy api removed, they can not configure this anymore. In this situation, we should add support in CC. I don't quite understand the relationship between k/k with k/autoscaling or others, I think they sync with k/k periodic.\nAs I mentioned above, it's still accessible via a framework runtime programmatically, and thus may be still useful. For example, upon a scheduling failure, a ClusterAutoscaler's implementation may choose to dryrun through all filter plugins to ensure a new provisioned node can fit the pod, instead of resolving the failure while failing at another latter filter plugin.\nOh, I haven't thought of configuration via programmatically, that saved my concern. But a little strange.\nThat's exactly what I meant. Given it's a public option in framework, and there is no alternative if we disabled it, it'd be good to check with potential consumers. For now I can think of CA ( and k-sigs/scheduler-simulator ( If they can confirm it's not needed in their usecases, I'm fine with removing .\nTo k/autoscaler, at least these codes are still there together with the legacy policy api. , looking forward to the response.\nis not used in sigs/kube-scheduler-simulator. \u200d\nthis isn't used by cluster autoscaler, we can remove it.", "positive_passages": [{"docid": "doc-en-kubernetes-78b17766ff0d4dcf22d1a50e6e387561ca7e578193e8f5a66c56b7fd2610a628", "text": "config.Plugin{Name: pl.name}) } profile := config.KubeSchedulerProfile{Plugins: cfgPls} <del> f, err := newFrameworkWithQueueSortAndBind(registry, profile, WithRunAllFilters(tt.runAllFilters)) </del> <ins> f, err := newFrameworkWithQueueSortAndBind(registry, profile) </ins> if err != nil { t.Fatalf(\"fail to create framework: %s\", err) }", "commid": "kubernetes_pr_108829"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ee63e795a95b2ddd1db27a0ea604546840d3c5aaaaad1cbf8e9f94cee6783df", "query": "In the K8s Conformance meeting of 6 April the testing of Node endpoints and their eligibility for conformance testing was discussed. This issue is created to get more community input on the topic. Should node endpoints be tested? Can we accualy test these endpoints with the current test framework /sig testing /sig architecture /area conformance\n/triage accepted /cc\nI have lost track of this issue where it have already been discussed. Let's continue to discuss further here. Apologies for the confusion /cc\nClayton We have historically focused conformance on the perceived end user experience deploying applications to a conformant Kubernetes cluster as being consistently successful. From that perspective, while these are actions that are indeed key to conformant behavior on the majority of distributions, the first two are not invoked by end users, only by kubelets and potentially administrators in rare cases. I would expect to be able to create a node object, delete it, mutate its status, and delete a portion of them on a conformant Kubernetes cluster as an admin - but I would not expect a similar end user to do so. If we can make a case that a conformant Kubernetes distribution would reasonably not allow any of these actions via the API, then we could make a case to omit them from conformance. I can see a small path to adding these to conformance under a \"they may be necessary as administrative action on the vast majority of kubernetes clusters\", but I can't necessarily bump that to 100% of Kube clusters, especially if we put the application deployer as the center of our story (an application deployer does not need to delete node collections in order to succeed at running an application on conformant kubernetes)\nAddressed the question in SIG Node\nCreated to make the remaining node endpoints ineligible. readCoreV1NodeStatus replaceCoreV1NodeStatus deleteCoreV1CollectionNode", "positive_passages": [{"docid": "doc-en-kubernetes-f8aa00e1604463c8bae74a3f6e2be8b865845fb49decfedffd799cba28733da5", "text": "- endpoint: replaceNetworkingV1NamespacedNetworkPolicyStatus reason: endpoints is currently feature gated and and will only receive e2e & conformance test in 1.25 link: https://github.com/kubernetes/kubernetes/pull/107963 <ins> - endpoint: readCoreV1NodeStatus reason: Kubernetes distribution would reasonably not allow this action via the API link: https://github.com/kubernetes/kubernetes/issues/109379 - endpoint: replaceCoreV1NodeStatus reason: Kubernetes distribution would reasonably not allow this action via the API link: https://github.com/kubernetes/kubernetes/issues/109379 - endpoint: deleteCoreV1CollectionNode reason: Kubernetes distribution would reasonably not allow this action via the API link: https://github.com/kubernetes/kubernetes/issues/109379 </ins>", "commid": "kubernetes_pr_110583"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-de92c939e0a1e60c55a5cf3ecf8c3bdeb2213fc2caf98746cabbe1f6c74c2fbb", "query": "ci-kubernetes-e2e-gce-master-new-gci-kubectl-skew kubetest.SkewTest 2022-04-14 15:13:42 +0000 UTC The error message is It's complaining about \"file contents\" and not \"url contents\". And because this is a skew test I am assuming this is due to The fix might be to cherry pick this to 1.23. No response /sig cli\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI've opened the cherry pick at if we decide that's the right route. The other options I can think of are to revert this change on master or to add the old environment variable back in as a file path. /assign /priority critical-urgent\nTracked the root of this to This should start passing once that merges. The cherry pick will also fix. We really need to get skew tests running on PRs.", "positive_passages": [{"docid": "doc-en-kubernetes-3843cfdfc1daf8ef0e1b4ec695fe429a8a2ec3dcca5f71586486446614308a0d", "text": "OPENSTACK_IMAGE_NAME=${OPENSTACK_IMAGE_NAME:-CentOS7} # Downloaded image name for Openstack project <del> IMAGE_FILE=${IMAGE_FILE:-CentOS-7-x86_64-GenericCloud-1510.qcow2} </del> <ins> IMAGE_FILE=${IMAGE_FILE:-CentOS-7-x86_64-GenericCloud-1604.qcow2} </ins> # Absolute path where image file is stored. IMAGE_PATH=${IMAGE_PATH:-~/Downloads/openstack}", "commid": "kubernetes_pr_25985"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-de92c939e0a1e60c55a5cf3ecf8c3bdeb2213fc2caf98746cabbe1f6c74c2fbb", "query": "ci-kubernetes-e2e-gce-master-new-gci-kubectl-skew kubetest.SkewTest 2022-04-14 15:13:42 +0000 UTC The error message is It's complaining about \"file contents\" and not \"url contents\". And because this is a skew test I am assuming this is due to The fix might be to cherry pick this to 1.23. No response /sig cli\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI've opened the cherry pick at if we decide that's the right route. The other options I can think of are to revert this change on master or to add the old environment variable back in as a file path. /assign /priority critical-urgent\nTracked the root of this to This should start passing once that merges. The cherry pick will also fix. We really need to get skew tests running on PRs.", "positive_passages": [{"docid": "doc-en-kubernetes-96dd8d3801799f5deaa85e260085777c08b5e12ec26ad0f898f4879a9a0da65c", "text": "# Verify prereqs on host machine function verify-prereqs() { # Check the OpenStack command-line clients <del> for client in swift glance nova openstack; </del> <ins> for client in swift glance nova heat openstack; </ins> do if which $client >/dev/null 2>&1; then echo \"${client} client installed\"", "commid": "kubernetes_pr_25985"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a798c609678596178892c7255d5cb622f9a5ebde3e41ac4403c4fdb42531beb", "query": "Please publish 3.5.4-0 image and update to to benefit from fix for , while still keeping v3.5.3 critical correctness fixes (, ). For recent PRs for update to etcd v3.5.3 see and\n/sig release /sig api-machinery /kind bug\n/cc /triage accepted\nHey, Can I work on this ? I'm a beginner, but all the good first issues are mostly assigned. Can you guide me on doing this ?\nI am working on this. /assign\nHi I would like to work on Make sense to backport in v1.22, v1.23 & v1.24? Thanks!!\nhi, it makes sense to me, but requires approval from dependency maintainers. i can only approve the kubeadm changes.\nwas this backported ?", "positive_passages": [{"docid": "doc-en-kubernetes-787b127fd1c6a48bf1758c8a3ccdd6bee8e0a186adc55ab78078642c9d95e002", "text": "# etcd - name: \"etcd\" <del> version: 3.5.3 </del> <ins> version: 3.5.4 </ins> refPaths: - path: cluster/gce/manifests/etcd.manifest match: etcd_docker_tag|etcd_version", "commid": "kubernetes_pr_110033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a798c609678596178892c7255d5cb622f9a5ebde3e41ac4403c4fdb42531beb", "query": "Please publish 3.5.4-0 image and update to to benefit from fix for , while still keeping v3.5.3 critical correctness fixes (, ). For recent PRs for update to etcd v3.5.3 see and\n/sig release /sig api-machinery /kind bug\n/cc /triage accepted\nHey, Can I work on this ? I'm a beginner, but all the good first issues are mostly assigned. Can you guide me on doing this ?\nI am working on this. /assign\nHi I would like to work on Make sense to backport in v1.22, v1.23 & v1.24? Thanks!!\nhi, it makes sense to me, but requires approval from dependency maintainers. i can only approve the kubeadm changes.\nwas this backported ?", "positive_passages": [{"docid": "doc-en-kubernetes-083623d7de21a74c29510153716d5c58a9443e348aca224767162bb48378e768", "text": "{ \"name\": \"etcd-container\", {{security_context}} <del> \"image\": \"{{ pillar.get('etcd_docker_repository', 'registry.k8s.io/etcd') }}:{{ pillar.get('etcd_docker_tag', '3.5.3-0') }}\", </del> <ins> \"image\": \"{{ pillar.get('etcd_docker_repository', 'registry.k8s.io/etcd') }}:{{ pillar.get('etcd_docker_tag', '3.5.4-0') }}\", </ins> \"resources\": { \"requests\": { \"cpu\": {{ cpulimit }}", "commid": "kubernetes_pr_110033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a798c609678596178892c7255d5cb622f9a5ebde3e41ac4403c4fdb42531beb", "query": "Please publish 3.5.4-0 image and update to to benefit from fix for , while still keeping v3.5.3 critical correctness fixes (, ). For recent PRs for update to etcd v3.5.3 see and\n/sig release /sig api-machinery /kind bug\n/cc /triage accepted\nHey, Can I work on this ? I'm a beginner, but all the good first issues are mostly assigned. Can you guide me on doing this ?\nI am working on this. /assign\nHi I would like to work on Make sense to backport in v1.22, v1.23 & v1.24? Thanks!!\nhi, it makes sense to me, but requires approval from dependency maintainers. i can only approve the kubeadm changes.\nwas this backported ?", "positive_passages": [{"docid": "doc-en-kubernetes-c5ac68470522c0e6f08ea52f61fd9cddea704b325bac1c98cfa986d39fbebb60", "text": "\"value\": \"{{ pillar.get('storage_backend', 'etcd3') }}\" }, { \"name\": \"TARGET_VERSION\", <del> \"value\": \"{{ pillar.get('etcd_version', '3.5.3') }}\" </del> <ins> \"value\": \"{{ pillar.get('etcd_version', '3.5.4') }}\" </ins> }, { \"name\": \"DO_NOT_MOVE_BINARIES\",", "commid": "kubernetes_pr_110033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a798c609678596178892c7255d5cb622f9a5ebde3e41ac4403c4fdb42531beb", "query": "Please publish 3.5.4-0 image and update to to benefit from fix for , while still keeping v3.5.3 critical correctness fixes (, ). For recent PRs for update to etcd v3.5.3 see and\n/sig release /sig api-machinery /kind bug\n/cc /triage accepted\nHey, Can I work on this ? I'm a beginner, but all the good first issues are mostly assigned. Can you guide me on doing this ?\nI am working on this. /assign\nHi I would like to work on Make sense to backport in v1.22, v1.23 & v1.24? Thanks!!\nhi, it makes sense to me, but requires approval from dependency maintainers. i can only approve the kubeadm changes.\nwas this backported ?", "positive_passages": [{"docid": "doc-en-kubernetes-1c92efc8afcfbd836f84b10386f7de51ca13ea1647578b3ac0ec45e32205f462", "text": "export SECONDARY_RANGE_NAME=\"pods-default\" export STORAGE_BACKEND=\"etcd3\" export STORAGE_MEDIA_TYPE=\"application/vnd.kubernetes.protobuf\" <del> export ETCD_IMAGE=3.5.3-0 export ETCD_VERSION=3.5.3 </del> <ins> export ETCD_IMAGE=3.5.4-0 export ETCD_VERSION=3.5.4 </ins> # Upgrade master with updated kube envs \"${KUBE_ROOT}/cluster/gce/upgrade.sh\" -M -l", "commid": "kubernetes_pr_110033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a798c609678596178892c7255d5cb622f9a5ebde3e41ac4403c4fdb42531beb", "query": "Please publish 3.5.4-0 image and update to to benefit from fix for , while still keeping v3.5.3 critical correctness fixes (, ). For recent PRs for update to etcd v3.5.3 see and\n/sig release /sig api-machinery /kind bug\n/cc /triage accepted\nHey, Can I work on this ? I'm a beginner, but all the good first issues are mostly assigned. Can you guide me on doing this ?\nI am working on this. /assign\nHi I would like to work on Make sense to backport in v1.22, v1.23 & v1.24? Thanks!!\nhi, it makes sense to me, but requires approval from dependency maintainers. i can only approve the kubeadm changes.\nwas this backported ?", "positive_passages": [{"docid": "doc-en-kubernetes-55a4e03abe9a52a7450f1f110781351252d8f104234db6bc08a9a49beb2cc6a7", "text": "MinExternalEtcdVersion = \"3.2.18\" // DefaultEtcdVersion indicates the default etcd version that kubeadm uses <del> DefaultEtcdVersion = \"3.5.3-0\" </del> <ins> DefaultEtcdVersion = \"3.5.4-0\" </ins> // Etcd defines variable used internally when referring to etcd component Etcd = \"etcd\"", "commid": "kubernetes_pr_110033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a798c609678596178892c7255d5cb622f9a5ebde3e41ac4403c4fdb42531beb", "query": "Please publish 3.5.4-0 image and update to to benefit from fix for , while still keeping v3.5.3 critical correctness fixes (, ). For recent PRs for update to etcd v3.5.3 see and\n/sig release /sig api-machinery /kind bug\n/cc /triage accepted\nHey, Can I work on this ? I'm a beginner, but all the good first issues are mostly assigned. Can you guide me on doing this ?\nI am working on this. /assign\nHi I would like to work on Make sense to backport in v1.22, v1.23 & v1.24? Thanks!!\nhi, it makes sense to me, but requires approval from dependency maintainers. i can only approve the kubeadm changes.\nwas this backported ?", "positive_passages": [{"docid": "doc-en-kubernetes-bfa5c7fbc9ce04dece0a4da73b4375b6e20b0f1902609423eef6b6484cb7af26", "text": "19: \"3.4.13-0\", 20: \"3.4.13-0\", 21: \"3.4.13-0\", <del> 22: \"3.5.3-0\", 23: \"3.5.3-0\", 24: \"3.5.3-0\", </del> <ins> 22: \"3.5.4-0\", 23: \"3.5.4-0\", 24: \"3.5.4-0\", 25: \"3.5.4-0\", </ins> } // KubeadmCertsClusterRoleName sets the name for the ClusterRole that allows", "commid": "kubernetes_pr_110033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a798c609678596178892c7255d5cb622f9a5ebde3e41ac4403c4fdb42531beb", "query": "Please publish 3.5.4-0 image and update to to benefit from fix for , while still keeping v3.5.3 critical correctness fixes (, ). For recent PRs for update to etcd v3.5.3 see and\n/sig release /sig api-machinery /kind bug\n/cc /triage accepted\nHey, Can I work on this ? I'm a beginner, but all the good first issues are mostly assigned. Can you guide me on doing this ?\nI am working on this. /assign\nHi I would like to work on Make sense to backport in v1.22, v1.23 & v1.24? Thanks!!\nhi, it makes sense to me, but requires approval from dependency maintainers. i can only approve the kubeadm changes.\nwas this backported ?", "positive_passages": [{"docid": "doc-en-kubernetes-c04e254653ab1e291fa8be01b665ba25384658936f2205f8747b4f4deeb2ba4b", "text": "# A set of helpers for starting/running etcd for tests <del> ETCD_VERSION=${ETCD_VERSION:-3.5.3} </del> <ins> ETCD_VERSION=${ETCD_VERSION:-3.5.4} </ins> ETCD_HOST=${ETCD_HOST:-127.0.0.1} ETCD_PORT=${ETCD_PORT:-2379} # This is intentionally not called ETCD_LOG_LEVEL:", "commid": "kubernetes_pr_110033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a798c609678596178892c7255d5cb622f9a5ebde3e41ac4403c4fdb42531beb", "query": "Please publish 3.5.4-0 image and update to to benefit from fix for , while still keeping v3.5.3 critical correctness fixes (, ). For recent PRs for update to etcd v3.5.3 see and\n/sig release /sig api-machinery /kind bug\n/cc /triage accepted\nHey, Can I work on this ? I'm a beginner, but all the good first issues are mostly assigned. Can you guide me on doing this ?\nI am working on this. /assign\nHi I would like to work on Make sense to backport in v1.22, v1.23 & v1.24? Thanks!!\nhi, it makes sense to me, but requires approval from dependency maintainers. i can only approve the kubeadm changes.\nwas this backported ?", "positive_passages": [{"docid": "doc-en-kubernetes-7abea5b46c4141a2a83f00f9369761ff9bd87988ccbbf587c9ba45f80357d49a", "text": "imagePullPolicy: Never args: [ \"--etcd-servers=http://localhost:2379\" ] - name: etcd <del> image: gcr.io/etcd-development/etcd:v3.5.3 </del> <ins> image: gcr.io/etcd-development/etcd:v3.5.4 </ins>", "commid": "kubernetes_pr_110033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a798c609678596178892c7255d5cb622f9a5ebde3e41ac4403c4fdb42531beb", "query": "Please publish 3.5.4-0 image and update to to benefit from fix for , while still keeping v3.5.3 critical correctness fixes (, ). For recent PRs for update to etcd v3.5.3 see and\n/sig release /sig api-machinery /kind bug\n/cc /triage accepted\nHey, Can I work on this ? I'm a beginner, but all the good first issues are mostly assigned. Can you guide me on doing this ?\nI am working on this. /assign\nHi I would like to work on Make sense to backport in v1.22, v1.23 & v1.24? Thanks!!\nhi, it makes sense to me, but requires approval from dependency maintainers. i can only approve the kubeadm changes.\nwas this backported ?", "positive_passages": [{"docid": "doc-en-kubernetes-e3a4271ec8db6cdc365986c8bdd58370bcd7b86777b94dd3182c5de8552c58db", "text": "e2essh \"k8s.io/kubernetes/test/e2e/framework/ssh\" ) <del> const etcdImage = \"3.5.3-0\" </del> <ins> const etcdImage = \"3.5.4-0\" </ins> // EtcdUpgrade upgrades etcd on GCE. func EtcdUpgrade(targetStorage, targetVersion string) error {", "commid": "kubernetes_pr_110033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4a798c609678596178892c7255d5cb622f9a5ebde3e41ac4403c4fdb42531beb", "query": "Please publish 3.5.4-0 image and update to to benefit from fix for , while still keeping v3.5.3 critical correctness fixes (, ). For recent PRs for update to etcd v3.5.3 see and\n/sig release /sig api-machinery /kind bug\n/cc /triage accepted\nHey, Can I work on this ? I'm a beginner, but all the good first issues are mostly assigned. Can you guide me on doing this ?\nI am working on this. /assign\nHi I would like to work on Make sense to backport in v1.22, v1.23 & v1.24? Thanks!!\nhi, it makes sense to me, but requires approval from dependency maintainers. i can only approve the kubeadm changes.\nwas this backported ?", "positive_passages": [{"docid": "doc-en-kubernetes-ba5a58b815d1216b8e631749f25b6bdcb60bd126558ccb5763f075531c4162a9", "text": "configs[CudaVectorAdd2] = Config{list.PromoterE2eRegistry, \"cuda-vector-add\", \"2.2\"} configs[DebianIptables] = Config{list.BuildImageRegistry, \"debian-iptables\", \"bullseye-v1.3.0\"} configs[EchoServer] = Config{list.PromoterE2eRegistry, \"echoserver\", \"2.4\"} <del> configs[Etcd] = Config{list.GcEtcdRegistry, \"etcd\", \"3.5.3-0\"} </del> <ins> configs[Etcd] = Config{list.GcEtcdRegistry, \"etcd\", \"3.5.4-0\"} </ins> configs[GlusterDynamicProvisioner] = Config{list.PromoterE2eRegistry, \"glusterdynamic-provisioner\", \"v1.3\"} configs[Httpd] = Config{list.PromoterE2eRegistry, \"httpd\", \"2.4.38-2\"} configs[HttpdNew] = Config{list.PromoterE2eRegistry, \"httpd\", \"2.4.39-2\"}", "commid": "kubernetes_pr_110033"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6bd60201c464597f57742f0cdd678358885c62b89b4b459f1bb929b8b5a182ee", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --/kind flake the test case was add in /cc smarterclayton <!-- Please assign a SIG using: /sig SIG-NAME --/sig node\n/assign\nbumping priority, seeing this in PR presubmit runs\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-1aa24fdddb9f4f52e322927595f77ee6f8395269ab86d968ac855c757c5d5097", "text": "Pod:        newNamedPod(\"5-static\", \"test1\", \"pod1\", true), UpdateType: kubetypes.SyncPodUpdate, }) <ins> // Wait for the previous work to be delivered to the worker drainAllWorkers(podWorkers) </ins> channels.Channel(\"5-static\").Hold() podWorkers.UpdatePod(UpdatePodOptions{ Pod:        newNamedPod(\"5-static\", \"test1\", \"pod1\", true),", "commid": "kubernetes_pr_110071"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-108be3290e39da28e1ba1a62ee2acdaabaf58121c5b483bdc1d93743d8cdb6ec", "query": "Follow-up cleanup work for: Most of the information about this issue can be found in , where the work merged with a to change the function signature of to return a func() as well as an error. This issue will help to track that. All TODOs introduced in are resolved. N/A N/A <detailsN/A </details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority low Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /triage accepted\n/priority important-longterm\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-f598162e0f5a8c0b5a1b81c312dd2a75d42c6e1e0481befb84dba896627d14fc", "text": "return true, binding, nil }) controllers := make(map[string]string) <del> stopFn := broadcaster.StartEventWatcher(func(obj runtime.Object) { </del> <ins> stopFn, err := broadcaster.StartEventWatcher(func(obj runtime.Object) { </ins> e, ok := obj.(*eventsv1.Event) if !ok || e.Reason != \"Scheduled\" { return", "commid": "kubernetes_pr_111545"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-108be3290e39da28e1ba1a62ee2acdaabaf58121c5b483bdc1d93743d8cdb6ec", "query": "Follow-up cleanup work for: Most of the information about this issue can be found in , where the work merged with a to change the function signature of to return a func() as well as an error. This issue will help to track that. All TODOs introduced in are resolved. N/A N/A <detailsN/A </details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority low Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /triage accepted\n/priority important-longterm\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-a0aeb9471e2477d28c6142856f5ed8be9479588e62d67fbef886c2cacda8c026", "text": "controllers[e.Regarding.Name] = e.ReportingController wg.Done() }) <ins> if err != nil { t.Fatal(err) } </ins> defer stopFn() // Run scheduler.", "commid": "kubernetes_pr_111545"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-108be3290e39da28e1ba1a62ee2acdaabaf58121c5b483bdc1d93743d8cdb6ec", "query": "Follow-up cleanup work for: Most of the information about this issue can be found in , where the work merged with a to change the function signature of to return a func() as well as an error. This issue will help to track that. All TODOs introduced in are resolved. N/A N/A <detailsN/A </details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority low Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /triage accepted\n/priority important-longterm\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-8727884e10f2bdaf2d8a553d67983ded94697f227ace33511bde1b3868aadb37", "text": "fwk.EventRecorder().Eventf(p.Pod, nil, v1.EventTypeWarning, \"FailedScheduling\", \"Scheduling\", msg) } called := make(chan struct{}) <del> stopFunc := eventBroadcaster.StartEventWatcher(func(obj runtime.Object) { </del> <ins> stopFunc, err := eventBroadcaster.StartEventWatcher(func(obj runtime.Object) { </ins> e, _ := obj.(*eventsv1.Event) if e.Reason != item.eventReason { t.Errorf(\"got event %v, want %v\", e.Reason, item.eventReason) } close(called) }) <ins> if err != nil { t.Fatal(err) } </ins> sched.scheduleOne(ctx) <-called if e, a := item.expectAssumedPod, gotAssumedPod; !reflect.DeepEqual(e, a) {", "commid": "kubernetes_pr_111545"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-108be3290e39da28e1ba1a62ee2acdaabaf58121c5b483bdc1d93743d8cdb6ec", "query": "Follow-up cleanup work for: Most of the information about this issue can be found in , where the work merged with a to change the function signature of to return a func() as well as an error. This issue will help to track that. All TODOs introduced in are resolved. N/A N/A <detailsN/A </details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority low Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /triage accepted\n/priority important-longterm\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-e111ced0aec596bd5a3feb53c8649f0c4b281b4c4641729afbbc2197a5203a89", "text": "fakeVolumeBinder := volumebinding.NewFakeVolumeBinder(item.volumeBinderConfig) s, bindingChan, errChan := setupTestSchedulerWithVolumeBinding(ctx, fakeVolumeBinder, eventBroadcaster) eventChan := make(chan struct{}) <del> stopFunc := eventBroadcaster.StartEventWatcher(func(obj runtime.Object) { </del> <ins> stopFunc, err := eventBroadcaster.StartEventWatcher(func(obj runtime.Object) { </ins> e, _ := obj.(*eventsv1.Event) if e, a := item.eventReason, e.Reason; e != a { t.Errorf(\"expected %v, got %v\", e, a) } close(eventChan) }) <ins> if err != nil { t.Fatal(err) } </ins> s.scheduleOne(ctx) // Wait for pod to succeed or fail scheduling select {", "commid": "kubernetes_pr_111545"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-108be3290e39da28e1ba1a62ee2acdaabaf58121c5b483bdc1d93743d8cdb6ec", "query": "Follow-up cleanup work for: Most of the information about this issue can be found in , where the work merged with a to change the function signature of to return a func() as well as an error. This issue will help to track that. All TODOs introduced in are resolved. N/A N/A <detailsN/A </details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority low Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /triage accepted\n/priority important-longterm\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-e142d9aed8b74cd7c7eef9b5473aded2ae944dd756d84bda301222392b541d2d", "text": "// StartStructuredLogging starts sending events received from this EventBroadcaster to the structured logging function. // The return value can be ignored or used to stop recording, if desired. <ins> // TODO: this function should also return an error. </ins> func (e *eventBroadcasterImpl) StartStructuredLogging(verbosity klog.Level) func() { <del> return e.StartEventWatcher( </del> <ins> stopWatcher, err := e.StartEventWatcher( </ins> func(obj runtime.Object) { event, ok := obj.(*eventsv1.Event) if !ok {", "commid": "kubernetes_pr_111545"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-108be3290e39da28e1ba1a62ee2acdaabaf58121c5b483bdc1d93743d8cdb6ec", "query": "Follow-up cleanup work for: Most of the information about this issue can be found in , where the work merged with a to change the function signature of to return a func() as well as an error. This issue will help to track that. All TODOs introduced in are resolved. N/A N/A <detailsN/A </details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority low Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /triage accepted\n/priority important-longterm\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-b80fe5863c46ceb880a325bb86e700961737df6a10bec1d4cb852692bfbcfaaf", "text": "} klog.V(verbosity).InfoS(\"Event occurred\", \"object\", klog.KRef(event.Regarding.Namespace, event.Regarding.Name), \"kind\", event.Regarding.Kind, \"apiVersion\", event.Regarding.APIVersion, \"type\", event.Type, \"reason\", event.Reason, \"action\", event.Action, \"note\", event.Note) }) <ins> if err != nil { klog.Errorf(\"failed to start event watcher: '%v'\", err) return func() {} } return stopWatcher </ins> } // StartEventWatcher starts sending events received from this EventBroadcaster to the given event handler function. // The return value is used to stop recording <del> func (e *eventBroadcasterImpl) StartEventWatcher(eventHandler func(event runtime.Object)) func() { </del> <ins> func (e *eventBroadcasterImpl) StartEventWatcher(eventHandler func(event runtime.Object)) (func(), error) { </ins> watcher, err := e.Watch() if err != nil { klog.Errorf(\"Unable start event watcher: '%v' (will not retry!)\", err) <del> // TODO: Rewrite the function signature to return an error, for // now just return a no-op function return func() { klog.Error(\"The event watcher failed to start\") } </del> <ins> return nil, err </ins> } go func() { defer utilruntime.HandleCrash()", "commid": "kubernetes_pr_111545"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-108be3290e39da28e1ba1a62ee2acdaabaf58121c5b483bdc1d93743d8cdb6ec", "query": "Follow-up cleanup work for: Most of the information about this issue can be found in , where the work merged with a to change the function signature of to return a func() as well as an error. This issue will help to track that. All TODOs introduced in are resolved. N/A N/A <detailsN/A </details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority low Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /triage accepted\n/priority important-longterm\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-1e519579175705fad15e45aa3b326503d86cc525df5fcf72cdd6a1c915502f0e", "text": "eventHandler(watchEvent.Object) } }() <del> return watcher.Stop </del> <ins> return watcher.Stop, nil </ins> } <del> func (e *eventBroadcasterImpl) startRecordingEvents(stopCh <-chan struct{}) { </del> <ins> func (e *eventBroadcasterImpl) startRecordingEvents(stopCh <-chan struct{}) error { </ins> eventHandler := func(obj runtime.Object) { event, ok := obj.(*eventsv1.Event) if !ok {", "commid": "kubernetes_pr_111545"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-108be3290e39da28e1ba1a62ee2acdaabaf58121c5b483bdc1d93743d8cdb6ec", "query": "Follow-up cleanup work for: Most of the information about this issue can be found in , where the work merged with a to change the function signature of to return a func() as well as an error. This issue will help to track that. All TODOs introduced in are resolved. N/A N/A <detailsN/A </details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority low Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /triage accepted\n/priority important-longterm\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-0a2b74c39293b824723109a19b169c67b95d6151efc2a10ca37e8fcdf0b9a9ec", "text": "} e.recordToSink(event, clock.RealClock{}) } <del> stopWatcher := e.StartEventWatcher(eventHandler) </del> <ins> stopWatcher, err := e.StartEventWatcher(eventHandler) if err != nil { return err } </ins> go func() { <-stopCh stopWatcher() }() <ins> return nil </ins> } // StartRecordingToSink starts sending events received from the specified eventBroadcaster to the given sink. func (e *eventBroadcasterImpl) StartRecordingToSink(stopCh <-chan struct{}) { go wait.Until(e.refreshExistingEventSeries, refreshTime, stopCh) go wait.Until(e.finishSeries, finishTime, stopCh) <del> e.startRecordingEvents(stopCh) </del> <ins> err := e.startRecordingEvents(stopCh) if err != nil { klog.Errorf(\"unexpected type, expected eventsv1.Event\") return } </ins> } type eventBroadcasterAdapterImpl struct {", "commid": "kubernetes_pr_111545"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-108be3290e39da28e1ba1a62ee2acdaabaf58121c5b483bdc1d93743d8cdb6ec", "query": "Follow-up cleanup work for: Most of the information about this issue can be found in , where the work merged with a to change the function signature of to return a func() as well as an error. This issue will help to track that. All TODOs introduced in are resolved. N/A N/A <detailsN/A </details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority low Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /triage accepted\n/priority important-longterm\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-9e70573c17f52ec2eccf6d7c57fec03437eb5dbbfeb1251ed572ab34f512489f", "text": "// Don't call StartRecordingToSink, as we don't need neither refreshing event // series nor finishing them in this tests and additional events updated would // race with our expected ones. <del> broadcaster.startRecordingEvents(stopCh) </del> <ins> err = broadcaster.startRecordingEvents(stopCh) if err != nil { t.Fatal(err) } </ins> recorder.Eventf(regarding, related, isomorphicEvent.Type, isomorphicEvent.Reason, isomorphicEvent.Action, isomorphicEvent.Note, []interface{}{1}) // read from the chan as this was needed only to populate the cache <-createEvent", "commid": "kubernetes_pr_111545"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-108be3290e39da28e1ba1a62ee2acdaabaf58121c5b483bdc1d93743d8cdb6ec", "query": "Follow-up cleanup work for: Most of the information about this issue can be found in , where the work merged with a to change the function signature of to return a func() as well as an error. This issue will help to track that. All TODOs introduced in are resolved. N/A N/A <detailsN/A </details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority low Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc /triage accepted\n/priority important-longterm\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale", "positive_passages": [{"docid": "doc-en-kubernetes-2e3e949cc0168beb41f3cefd4b7b55089553931d74f9d2403d76f89a6f70c126", "text": "// of StartRecordingToSink. This lets you also process events in a custom way (e.g. in tests). // NOTE: events received on your eventHandler should be copied before being used. // TODO: figure out if this can be removed. <del> StartEventWatcher(eventHandler func(event runtime.Object)) func() </del> <ins> StartEventWatcher(eventHandler func(event runtime.Object)) (func(), error) </ins> // StartStructuredLogging starts sending events received from this EventBroadcaster to the structured // logging function. The return value can be ignored or used to stop recording, if desired.", "commid": "kubernetes_pr_111545"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-11931a81f49292e30fa187df18acf1a79a4af7c51f2db8ca1fc930b4aeb6f468", "query": "Un-deperecate the kubelet flag, as this option is typically set per-node similar to (which is not deprecated). Or more generally, consider not deprecating fields available in config that make sense to set per-node. I noticed this while trying to ensure KIND moves towards not setting any deprecated flags, this one is tricky because it's not a fixed value. For a lot of kubernetes users, kubeadm is used for bootstrapping, and kubeadm supports supplying additional kubelet flags when configuring each node, but the kubelet config is cluster-wide, created during setting up the first node and uploaded to a configmap then used for all nodes. In the future kubeadm may have the ability to do per-node kubelet config, but that effort will probably be involved and isn't staffed at the moment. technically you could run kubeadm in phases and then modify the config, but this is more complex to implement. It's possible this won't be necessary if kubeadm patches can be extended to kubelet which may be a smaller feature change for kubeadm, but personally I think being able to configure simple per-node strings with a flag override is desirable for implementing clusters, and we've had the flag for many years with no trouble ... The actual deprecation seems to be due to a blanket deprecation on things possible to set in config, and not targeted at this flag in particular. See discussion in\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\ntechnically KIND doesn't strictly need this flag, FWIW, but we were asked by users to set it to make detection easier and have values more similar to \"real\" clusters. other projects in Kubernetes are also doing this, e.g. some of of the cluster api-provider implementations:\nI think for 1.25 in kubeadm we can enable patching of kubeletconfuguration. This will allow us to use the current global kubletconfiguration for all nodes, but patches can act as the node instance specific config. Flags would still take precedence over patches and are the simpler UX. But if one day all flags are removed the above solution will still support the instance specific use case. I don't know whether some flags should be de-deprecated, but IIRC the plan to migrate all flags to kubeletconfiguration and not add more flags was still desirable by sig node.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\nThe Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle rotten [1]:\n/remove-lifecycle rotten\n/assign It seems to be reasonable. I opened to undeprecate it.", "positive_passages": [{"docid": "doc-en-kubernetes-881c51b2c221f126166cf6cf7a98555045bac8f077b4549f94936f386f5db281", "text": "\"v\":                   true, \"vmodule\":             true, \"log-flush-frequency\": true, <ins> \"provider-id\":         true, </ins> } fs.VisitAll(func(f *pflag.Flag) { if notDeprecated[f.Name] {", "commid": "kubernetes_pr_116530"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72d7af02b7cb24adccad9225734c2fb8351d64a440dcf1418ee834dbb0676072", "query": "release-master-informing capg-conformance-main-ci-artifacts Kubernetes e2e suite.BeforeSuite 05-25 06:37 IST Failure Error waiting for all pods to be running and ready: 3 / 13 pods in namespace kube-system are NOT in RUNNING and READY state in 10m0s No response /sig network /sig node cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove sig-network /remove sig-node /unassign This seems a deployment problem ... on calico to be precise first point of contact for initial triage should be the job/sig owners ... this job also seems to be failing for a long time /sig cluster-lifecycle sig-cluster-lifecycle-cluster-api-alerts\n/remove-sig network /remove-sig node\ncc\nwill take a look /assign\nCheck the Calico version, there was a similar report that was fixed bumping the version. As a side not, I'm seeing a lot of problems related to Lots of projects/test/code were assuming the secret was created and is causing a lot of noise in different CIs\nHey thanks for the PR! The test still shows in the - will it take some time for the changes you made in the PR to reflect?\nhello! those are not failures, they are flakys :/ afaik\nHey folks, this test has now started failing again on the dashboard. Should we open a new issue for it or is it okay to track it here itself? !\nchecking that\nthe capg conformance failed but now have flakys only\nThanks a ton", "positive_passages": [{"docid": "doc-en-kubernetes-7014bcf0cdcebfde8535ee72aa0d2871478b64bb8d5da659571495211602f9bb", "text": "\"api/v1.0\", }, \"/\"), } <del> _, err := c.MachineInfo() if err != nil { return nil, err } </del> return c, nil }", "commid": "kubernetes_pr_624"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-72d7af02b7cb24adccad9225734c2fb8351d64a440dcf1418ee834dbb0676072", "query": "release-master-informing capg-conformance-main-ci-artifacts Kubernetes e2e suite.BeforeSuite 05-25 06:37 IST Failure Error waiting for all pods to be running and ready: 3 / 13 pods in namespace kube-system are NOT in RUNNING and READY state in 10m0s No response /sig network /sig node cc\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove sig-network /remove sig-node /unassign This seems a deployment problem ... on calico to be precise first point of contact for initial triage should be the job/sig owners ... this job also seems to be failing for a long time /sig cluster-lifecycle sig-cluster-lifecycle-cluster-api-alerts\n/remove-sig network /remove-sig node\ncc\nwill take a look /assign\nCheck the Calico version, there was a similar report that was fixed bumping the version. As a side not, I'm seeing a lot of problems related to Lots of projects/test/code were assuming the secret was created and is causing a lot of noise in different CIs\nHey thanks for the PR! The test still shows in the - will it take some time for the changes you made in the PR to reflect?\nhello! those are not failures, they are flakys :/ afaik\nHey folks, this test has now started failing again on the dashboard. Should we open a new issue for it or is it okay to track it here itself? !\nchecking that\nthe capg conformance failed but now have flakys only\nThanks a ton", "positive_passages": [{"docid": "doc-en-kubernetes-bfe152df2cc3397a3cf811398511debdf025b46af4480f92194baa502e16e043", "text": "NumStats:               3, NumSamples:             2, CpuUsagePercentiles:    []int{10, 50, 90}, <del> MemoryUsagePercentages: []int{10, 80, 90}, </del> <ins> MemoryUsagePercentiles: []int{10, 80, 90}, </ins> } containerName := \"/some/container\" cinfo := itest.GenerateRandomContainerInfo(containerName, 4, query, 1*time.Second)", "commid": "kubernetes_pr_624"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3a31751d8f7078739317089d27ce716cd397688065176cd536a90311245cb433", "query": "[X] test approval issue : [X] test pr : [x] two weeks soak end date : 15 Jul 2022 [x] test promotion pr : According to this APIsnoop query, there are still a single remaining Event endpoint which is untested. replaceCoreV1NamespacedEvent Using a number of existing e2e test practices a new has been created for this pod status endpoint. The e2e logs for this test are listed below. This query shows the event endpoints hit within a short period of running the e2e test. If a test with these calls gets merged, test coverage will go up by 1 point. This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance\n/triage accepted\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-233a8bcb2d10693aef1e2fddafbb0b9d4be5182b14d0f4de6621269d7c5cbd11", "text": "\"time\" v1 \"k8s.io/api/core/v1\" <ins> apiequality \"k8s.io/apimachinery/pkg/api/equality\" </ins> metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" <ins> \"k8s.io/apimachinery/pkg/util/diff\" </ins> \"k8s.io/apimachinery/pkg/util/wait\" \"k8s.io/kubernetes/test/e2e/framework\" \"k8s.io/kubernetes/test/e2e/instrumentation/common\"", "commid": "kubernetes_pr_110798"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3a31751d8f7078739317089d27ce716cd397688065176cd536a90311245cb433", "query": "[X] test approval issue : [X] test pr : [x] two weeks soak end date : 15 Jul 2022 [x] test promotion pr : According to this APIsnoop query, there are still a single remaining Event endpoint which is untested. replaceCoreV1NamespacedEvent Using a number of existing e2e test practices a new has been created for this pod status endpoint. The e2e logs for this test are listed below. This query shows the event endpoints hit within a short period of running the e2e test. If a test with these calls gets merged, test coverage will go up by 1 point. This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance\n/triage accepted\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-37f44d1423a470bc4305078c2efed274c565d687def6f6dc1a5c3325aff3c4b1", "text": "} }) <ins> ginkgo.It(\"should manage the lifecycle of an event\", func() { eventTestName := \"event-test\" ginkgo.By(\"creating a test event\") // create a test event in test namespace _, err := f.ClientSet.CoreV1().Events(f.Namespace.Name).Create(context.TODO(), &v1.Event{ ObjectMeta: metav1.ObjectMeta{ Name: eventTestName, Labels: map[string]string{ \"testevent-constant\": \"true\", }, }, Message: \"This is a test event\", Reason:  \"Test\", Type:    \"Normal\", Count:   1, InvolvedObject: v1.ObjectReference{ Namespace: f.Namespace.Name, }, }, metav1.CreateOptions{}) framework.ExpectNoError(err, \"failed to create test event\") ginkgo.By(\"listing all events in all namespaces\") // get a list of Events in all namespaces to ensure endpoint coverage eventsList, err := f.ClientSet.CoreV1().Events(\"\").List(context.TODO(), metav1.ListOptions{ LabelSelector: \"testevent-constant=true\", }) framework.ExpectNoError(err, \"failed list all events\") foundCreatedEvent := false var eventCreatedName string for _, val := range eventsList.Items { if val.ObjectMeta.Name == eventTestName && val.ObjectMeta.Namespace == f.Namespace.Name { foundCreatedEvent = true eventCreatedName = val.ObjectMeta.Name break } } if !foundCreatedEvent { framework.Failf(\"unable to find test event %s in namespace %s, full list of events is %+v\", eventTestName, f.Namespace.Name, eventsList.Items) } ginkgo.By(\"patching the test event\") // patch the event's message eventPatchMessage := \"This is a test event - patched\" eventPatch, err := json.Marshal(map[string]interface{}{ \"message\": eventPatchMessage, }) framework.ExpectNoError(err, \"failed to marshal the patch JSON payload\") _, err = f.ClientSet.CoreV1().Events(f.Namespace.Name).Patch(context.TODO(), eventTestName, types.StrategicMergePatchType, []byte(eventPatch), metav1.PatchOptions{}) framework.ExpectNoError(err, \"failed to patch the test event\") ginkgo.By(\"fetching the test event\") // get event by name event, err := f.ClientSet.CoreV1().Events(f.Namespace.Name).Get(context.TODO(), eventCreatedName, metav1.GetOptions{}) framework.ExpectNoError(err, \"failed to fetch the test event\") framework.ExpectEqual(event.Message, eventPatchMessage, \"test event message does not match patch message\") ginkgo.By(\"updating the test event\") testEvent, err := f.ClientSet.CoreV1().Events(f.Namespace.Name).Get(context.TODO(), event.Name, metav1.GetOptions{}) framework.ExpectNoError(err, \"failed to get test event\") testEvent.Series = &v1.EventSeries{ Count:            100, LastObservedTime: metav1.MicroTime{Time: time.Unix(1505828956, 0)}, } // clear ResourceVersion and ManagedFields which are set by control-plane testEvent.ObjectMeta.ResourceVersion = \"\" testEvent.ObjectMeta.ManagedFields = nil _, err = f.ClientSet.CoreV1().Events(f.Namespace.Name).Update(context.TODO(), testEvent, metav1.UpdateOptions{}) framework.ExpectNoError(err, \"failed to update the test event\") ginkgo.By(\"getting the test event\") event, err = f.ClientSet.CoreV1().Events(f.Namespace.Name).Get(context.TODO(), testEvent.Name, metav1.GetOptions{}) framework.ExpectNoError(err, \"failed to get test event\") // clear ResourceVersion and ManagedFields which are set by control-plane event.ObjectMeta.ResourceVersion = \"\" event.ObjectMeta.ManagedFields = nil if !apiequality.Semantic.DeepEqual(testEvent, event) { framework.Failf(\"test event wasn't properly updated: %v\", diff.ObjectReflectDiff(testEvent, event)) } ginkgo.By(\"deleting the test event\") // delete original event err = f.ClientSet.CoreV1().Events(f.Namespace.Name).Delete(context.TODO(), eventCreatedName, metav1.DeleteOptions{}) framework.ExpectNoError(err, \"failed to delete the test event\") ginkgo.By(\"listing all events in all namespaces\") // get a list of Events list namespace eventsList, err = f.ClientSet.CoreV1().Events(\"\").List(context.TODO(), metav1.ListOptions{ LabelSelector: \"testevent-constant=true\", }) framework.ExpectNoError(err, \"fail to list all events\") foundCreatedEvent = false for _, val := range eventsList.Items { if val.ObjectMeta.Name == eventTestName && val.ObjectMeta.Namespace == f.Namespace.Name { foundCreatedEvent = true break } } if foundCreatedEvent { framework.Failf(\"Should not have found test event %s in namespace %s, full list of events %+v\", eventTestName, f.Namespace.Name, eventsList.Items) } }) </ins> /* Release: v1.20 Testname: Event, delete a collection", "commid": "kubernetes_pr_110798"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3a31751d8f7078739317089d27ce716cd397688065176cd536a90311245cb433", "query": "[X] test approval issue : [X] test pr : [x] two weeks soak end date : 15 Jul 2022 [x] test promotion pr : According to this APIsnoop query, there are still a single remaining Event endpoint which is untested. replaceCoreV1NamespacedEvent Using a number of existing e2e test practices a new has been created for this pod status endpoint. The e2e logs for this test are listed below. This query shows the event endpoints hit within a short period of running the e2e test. If a test with these calls gets merged, test coverage will go up by 1 point. This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance\n/triage accepted\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-ed49cbf19a58678d9d8f8be8231ad1e40c3947a114d7281b0110c6ab840b02c4", "text": "its label selector. release: v1.20 file: test/e2e/instrumentation/core_events.go <del> - testname: Event resource lifecycle codename: '[sig-instrumentation] Events should ensure that an event can be fetched, patched, deleted, and listed [Conformance]' description: Create an event, the event MUST exist. The event is patched with a new message, the check MUST have the update message. The event is deleted and MUST NOT show up when listing all events. release: v1.20 </del> <ins> - testname: Event, manage lifecycle of an Event codename: '[sig-instrumentation] Events should manage the lifecycle of an event [Conformance]' description: Attempt to create an event which MUST succeed. Attempt to list all namespaces with a label selector which MUST succeed. One list MUST be found. The event is patched with a new message, the check MUST have the update message. The event is updated with a new series of events, the check MUST confirm this update. The event is deleted and MUST NOT show up when listing all events. release: v1.25 </ins> file: test/e2e/instrumentation/core_events.go - testname: DNS, cluster codename: '[sig-network] DNS should provide /etc/hosts entries for the cluster [Conformance]'", "commid": "kubernetes_pr_111265"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3a31751d8f7078739317089d27ce716cd397688065176cd536a90311245cb433", "query": "[X] test approval issue : [X] test pr : [x] two weeks soak end date : 15 Jul 2022 [x] test promotion pr : According to this APIsnoop query, there are still a single remaining Event endpoint which is untested. replaceCoreV1NamespacedEvent Using a number of existing e2e test practices a new has been created for this pod status endpoint. The e2e logs for this test are listed below. This query shows the event endpoints hit within a short period of running the e2e test. If a test with these calls gets merged, test coverage will go up by 1 point. This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance\n/triage accepted\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-ba7c55e8d338a5af807161432feb7b968580fae3f273799ab005d07a78be9e78", "text": "f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged /* <del> Release: v1.20 Testname: Event resource lifecycle Description: Create an event, the event MUST exist. The event is patched with a new message, the check MUST have the update message. The event is deleted and MUST NOT show up when listing all events. </del> <ins> Release: v1.25 Testname: Event, manage lifecycle of an Event Description: Attempt to create an event which MUST succeed. Attempt to list all namespaces with a label selector which MUST succeed. One list MUST be found. The event is patched with a new message, the check MUST have the update message. The event is updated with a new series of events, the check MUST confirm this update. The event is deleted and MUST NOT show up when listing all events. </ins> */ <del> framework.ConformanceIt(\"should ensure that an event can be fetched, patched, deleted, and listed\", func() { eventTestName := \"event-test\" ginkgo.By(\"creating a test event\") // create a test event in test namespace _, err := f.ClientSet.CoreV1().Events(f.Namespace.Name).Create(context.TODO(), &v1.Event{ ObjectMeta: metav1.ObjectMeta{ Name: eventTestName, Labels: map[string]string{ \"testevent-constant\": \"true\", }, }, Message: \"This is a test event\", Reason:  \"Test\", Type:    \"Normal\", Count:   1, InvolvedObject: v1.ObjectReference{ Namespace: f.Namespace.Name, }, }, metav1.CreateOptions{}) framework.ExpectNoError(err, \"failed to create test event\") ginkgo.By(\"listing all events in all namespaces\") // get a list of Events in all namespaces to ensure endpoint coverage eventsList, err := f.ClientSet.CoreV1().Events(\"\").List(context.TODO(), metav1.ListOptions{ LabelSelector: \"testevent-constant=true\", }) framework.ExpectNoError(err, \"failed list all events\") foundCreatedEvent := false var eventCreatedName string for _, val := range eventsList.Items { if val.ObjectMeta.Name == eventTestName && val.ObjectMeta.Namespace == f.Namespace.Name { foundCreatedEvent = true eventCreatedName = val.ObjectMeta.Name break } } if !foundCreatedEvent { framework.Failf(\"unable to find test event %s in namespace %s, full list of events is %+v\", eventTestName, f.Namespace.Name, eventsList.Items) } ginkgo.By(\"patching the test event\") // patch the event's message eventPatchMessage := \"This is a test event - patched\" eventPatch, err := json.Marshal(map[string]interface{}{ \"message\": eventPatchMessage, }) framework.ExpectNoError(err, \"failed to marshal the patch JSON payload\") _, err = f.ClientSet.CoreV1().Events(f.Namespace.Name).Patch(context.TODO(), eventTestName, types.StrategicMergePatchType, []byte(eventPatch), metav1.PatchOptions{}) framework.ExpectNoError(err, \"failed to patch the test event\") ginkgo.By(\"fetching the test event\") // get event by name event, err := f.ClientSet.CoreV1().Events(f.Namespace.Name).Get(context.TODO(), eventCreatedName, metav1.GetOptions{}) framework.ExpectNoError(err, \"failed to fetch the test event\") framework.ExpectEqual(event.Message, eventPatchMessage, \"test event message does not match patch message\") ginkgo.By(\"deleting the test event\") // delete original event err = f.ClientSet.CoreV1().Events(f.Namespace.Name).Delete(context.TODO(), eventCreatedName, metav1.DeleteOptions{}) framework.ExpectNoError(err, \"failed to delete the test event\") ginkgo.By(\"listing all events in all namespaces\") // get a list of Events list namespace eventsList, err = f.ClientSet.CoreV1().Events(\"\").List(context.TODO(), metav1.ListOptions{ LabelSelector: \"testevent-constant=true\", }) framework.ExpectNoError(err, \"fail to list all events\") foundCreatedEvent = false for _, val := range eventsList.Items { if val.ObjectMeta.Name == eventTestName && val.ObjectMeta.Namespace == f.Namespace.Name { foundCreatedEvent = true break } } if foundCreatedEvent { framework.Failf(\"Should not have found test event %s in namespace %s, full list of events %+v\", eventTestName, f.Namespace.Name, eventsList.Items) } }) </del> <ins> framework.ConformanceIt(\"should manage the lifecycle of an event\", func() { // As per SIG-Arch meeting 14 July 2022 this e2e test now supersede // e2e test \"Event resource lifecycle\", which has been removed. </ins> <del> ginkgo.It(\"should manage the lifecycle of an event\", func() { </del> eventTestName := \"event-test\" ginkgo.By(\"creating a test event\")", "commid": "kubernetes_pr_111265"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fa1e3592e03be9bd9db82b235e463f224a9a94bfb5a37ca2bda074ac06ed4ee4", "query": "Creating a destroying services test is a required test case in , but it's missing in the upstream e2e test. Since creating a destroying services test should work in both windows and linux cluster, it's worthy adding it to create a service and corresponding pod delete the service re-create the service load balancing rules for pods are recovered e2e tests for sig-network would have coverage for recover load balancing rules for pods after service is deleted and re-created. Reproducer is above No response <detailsmain </details<detailsany </details<details</details<details</details<details</details<details</details\n/sig network testing\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-327ad2b920a90a0254f49336e4adabd566dd85b7630cf19b11b562c0ba7e122f", "text": "v1 \"k8s.io/api/core/v1\" discoveryv1 \"k8s.io/api/discovery/v1\" <ins> apierrors \"k8s.io/apimachinery/pkg/api/errors\" </ins> \"k8s.io/apimachinery/pkg/api/resource\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/labels\"", "commid": "kubernetes_pr_111120"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fa1e3592e03be9bd9db82b235e463f224a9a94bfb5a37ca2bda074ac06ed4ee4", "query": "Creating a destroying services test is a required test case in , but it's missing in the upstream e2e test. Since creating a destroying services test should work in both windows and linux cluster, it's worthy adding it to create a service and corresponding pod delete the service re-create the service load balancing rules for pods are recovered e2e tests for sig-network would have coverage for recover load balancing rules for pods after service is deleted and re-created. Reproducer is above No response <detailsmain </details<detailsany </details<details</details<details</details<details</details<details</details\n/sig network testing\n/triage accepted /assign", "positive_passages": [{"docid": "doc-en-kubernetes-eceab5f049a8fe61ffadffa03b4abc32c620a97a3a254234bbd7e03117bda149", "text": "framework.ExpectNoError(verifyServeHostnameServiceUp(cs, ns, podNames3, svc3IP, servicePort)) }) <ins> ginkgo.It(\"should work after the service has been recreated\", func() { serviceName := \"service-deletion\" ns := f.Namespace.Name numPods, servicePort := 1, defaultServeHostnameServicePort ginkgo.By(\"creating the service \" + serviceName + \" in namespace \" + ns) defer func() { framework.ExpectNoError(StopServeHostnameService(f.ClientSet, ns, serviceName)) }() podNames, svcIP, _ := StartServeHostnameService(cs, getServeHostnameService(serviceName), ns, numPods) framework.ExpectNoError(verifyServeHostnameServiceUp(cs, ns, podNames, svcIP, servicePort)) ginkgo.By(\"deleting the service \" + serviceName + \" in namespace \" + ns) err := cs.CoreV1().Services(ns).Delete(context.TODO(), serviceName, metav1.DeleteOptions{}) framework.ExpectNoError(err) ginkgo.By(\"Waiting for the service \" + serviceName + \" in namespace \" + ns + \" to disappear\") if pollErr := wait.PollImmediate(framework.Poll, e2eservice.RespondingTimeout, func() (bool, error) { _, err := cs.CoreV1().Services(ns).Get(context.TODO(), serviceName, metav1.GetOptions{}) if err != nil { if apierrors.IsNotFound(err) { framework.Logf(\"Service %s/%s is gone.\", ns, serviceName) return true, nil } return false, err } framework.Logf(\"Service %s/%s still exists\", ns, serviceName) return false, nil }); pollErr != nil { framework.Failf(\"Failed to wait for service to disappear: %v\", pollErr) } ginkgo.By(\"recreating the service \" + serviceName + \" in namespace \" + ns) svc, err := cs.CoreV1().Services(ns).Create(context.TODO(), getServeHostnameService(serviceName), metav1.CreateOptions{}) framework.ExpectNoError(err) framework.ExpectNoError(verifyServeHostnameServiceUp(cs, ns, podNames, svc.Spec.ClusterIP, servicePort)) }) </ins> ginkgo.It(\"should work after restarting kube-proxy [Disruptive]\", func() { kubeProxyLabelSet := map[string]string{clusterAddonLabelKey: kubeProxyLabelName} e2eskipper.SkipUnlessComponentRunsAsPodsAndClientCanDeleteThem(kubeProxyLabelName, cs, metav1.NamespaceSystem, kubeProxyLabelSet)", "commid": "kubernetes_pr_111120"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-90016efc10ba60fd2e2129cd26baae3371a7d9a65592210e7cc6dfa34ade5cb3", "query": "in this test the rootfs is limited to 5M and the pod is evicted by creating a 10M file with; But this fails if the fs doesn't support the fallocate syscall. The K8s e2e must not itself require support for features that K8s does not require. I am unsure why my overlay fs in containers doesn't support fallocate(2) while the fs on the node (ext4) does. I have queried on the slack. I build my Linux kernel myself but I can't find anything related. If the command is changed to; the test works on an fs that doesn't support fallocate(2). It may seem more \"primitive\" but it doesn't require a feature that K8s doesn't. <detailsNone </detailsNo response No response\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig testing\nInteresting /Triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-472520db07d4e8d6c2c17d3da809752ebbdaabe758126d9e7bab3edb0423bf87", "text": "// Create a pod in one node to get evicted ginkgo.By(\"creating a client pod that is going to be evicted for the service \" + serviceName) evictedPod := e2epod.NewAgnhostPod(namespace, \"evicted-pod\", nil, nil, nil) <del> evictedPod.Spec.Containers[0].Command = []string{\"/bin/sh\", \"-c\", \"sleep 10; fallocate -l 10M file; sleep 10000\"} </del> <ins> evictedPod.Spec.Containers[0].Command = []string{\"/bin/sh\", \"-c\", \"sleep 10; dd if=/dev/zero of=file bs=1M count=10; sleep 10000\"} </ins> evictedPod.Spec.Containers[0].Name = \"evicted-pod\" evictedPod.Spec.Containers[0].Resources = v1.ResourceRequirements{ Limits: v1.ResourceList{\"ephemeral-storage\": resource.MustParse(\"5Mi\")},", "commid": "kubernetes_pr_111369"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-90016efc10ba60fd2e2129cd26baae3371a7d9a65592210e7cc6dfa34ade5cb3", "query": "in this test the rootfs is limited to 5M and the pod is evicted by creating a 10M file with; But this fails if the fs doesn't support the fallocate syscall. The K8s e2e must not itself require support for features that K8s does not require. I am unsure why my overlay fs in containers doesn't support fallocate(2) while the fs on the node (ext4) does. I have queried on the slack. I build my Linux kernel myself but I can't find anything related. If the command is changed to; the test works on an fs that doesn't support fallocate(2). It may seem more \"primitive\" but it doesn't require a feature that K8s doesn't. <detailsNone </detailsNo response No response\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig testing\nInteresting /Triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-7c11ab54384d2ad4b9247f575ddad48fda2ed9ee0191d1c4b3699600cf6b1116", "text": "Name:  \"bar\", Image: image, Command: []string{ <del> \"/bin/sh\", \"-c\", \"sleep 10; fallocate -l 10M file; sleep 10000\", </del> <ins> \"/bin/sh\", \"-c\", \"sleep 10; dd if=/dev/zero of=file bs=1M count=10; sleep 10000\", </ins> }, Resources: v1.ResourceRequirements{ Limits: v1.ResourceList{", "commid": "kubernetes_pr_111369"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7679fec6fc3307560ba7099cdd14fd03a7bc8aa630e2c9e270959a4136246b1d", "query": "The project uses a lot of CRDs - in some cases almost 2,000. I do mean here, not custom resources. We've noticed that API server memory consumption balloons when many CRDs are installed - for example with ~1,900 CRDs we see the API server using up to ~8Gi RSS. A little profiling shows that around 1.5Gi of that memory is being used by the etcd3 client's logger. With Kubernetes built from with the CRDs at loaded I'm seeing the API server using up to ~7.5GiB RSS. I see it dip to ~5.5GiB, presumably when garbage collection runs. You can see taking up a ton of memory below. Zap is the logger used by the etcd client. Note that this is a sample, so it's actually using more than the indicated ~800MiB. ! I'm seeing the API server using up to ~6GiB RSS. I see it dip to ~4.5GiB, presumably due to GC runs. You can see no longer appears below. ! I would not expect a logger to be responsible for such a significant amount of the API server's memory consumption. You can get the above profile by: out . to build a kind node. to start a control plane for the above build. to allow anonymous pprof access the CRDs from I used to see the RSS but I imagine would show it too. See for details on how I disabled the logger to get the \"without logger\" numbers. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nSince you looked at the code, and I'd rather not spend time doing that. Any chance you can tell if it's because it's being mis-used?\nThis is a scale dimension where the apiserver has historically . With the OpenAPI discovery performance being improved it looks like this might be a hint at what the next bottleneck might be? Any idea how many etcd clients were instantiated? I suspect it's quite a lot.\nSadly I didn't yet look deeply past turning it off. I was slightly optimistic that we might just be able to disable it without any meaningful impact. What I do know is that the offending code seems to be on the etcd3 client end - i.e. it defaults to creating its own logger when one isn't supplied. You can see that code at\nI don't - will try to find out.\nThe zap logs might tell you if you have the data. If my memory of the code is right, you should get 1 etcd client per CRD right now (plus some for builtin types).\n/triage accepted\nBased on my read of the code, you're right. I see roughly: All of /apis is handled by a crdHandler When a request comes in it gets an instance of the crd (from an informer) Gets serving info from a map of CRDs - if there is none it... Calls customresource.NewStorage which creates a genericregistry.Store Calls its CompleteWithOptions method That calls its \u201cDecorator\u201d, which is a genericregistry.StorageWithCacher That calls generic.NewRawStorage which just wraps factory.Create factory.Create calls newETCD3Storage which calls newETCD3Client I'm experiencing technical difficulties getting lsof running in my kind container but /proc/pid/net confirms we have a connection to etcd per CRD: Note that 1,937 - 60 = 1,877 - the number of CRDs we have loaded (the 1,878 above includes the header line).", "positive_passages": [{"docid": "doc-en-kubernetes-6a6d087d754dfb8bc5734fde8ddcf751592578d9e2c99a66b14520eddfc74869", "text": "import ( \"context\" \"fmt\" <ins> \"log\" </ins> \"net\" \"net/url\" <ins> \"os\" </ins> \"path\" \"strings\" \"sync\" \"time\" grpcprom \"github.com/grpc-ecosystem/go-grpc-prometheus\" <ins> \"go.etcd.io/etcd/client/pkg/v3/logutil\" </ins> \"go.etcd.io/etcd/client/pkg/v3/transport\" clientv3 \"go.etcd.io/etcd/client/v3\" \"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc\" <ins> \"go.uber.org/zap\" \"go.uber.org/zap/zapcore\" </ins> \"google.golang.org/grpc\" \"k8s.io/apimachinery/pkg/runtime\"", "commid": "kubernetes_pr_111477"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7679fec6fc3307560ba7099cdd14fd03a7bc8aa630e2c9e270959a4136246b1d", "query": "The project uses a lot of CRDs - in some cases almost 2,000. I do mean here, not custom resources. We've noticed that API server memory consumption balloons when many CRDs are installed - for example with ~1,900 CRDs we see the API server using up to ~8Gi RSS. A little profiling shows that around 1.5Gi of that memory is being used by the etcd3 client's logger. With Kubernetes built from with the CRDs at loaded I'm seeing the API server using up to ~7.5GiB RSS. I see it dip to ~5.5GiB, presumably when garbage collection runs. You can see taking up a ton of memory below. Zap is the logger used by the etcd client. Note that this is a sample, so it's actually using more than the indicated ~800MiB. ! I'm seeing the API server using up to ~6GiB RSS. I see it dip to ~4.5GiB, presumably due to GC runs. You can see no longer appears below. ! I would not expect a logger to be responsible for such a significant amount of the API server's memory consumption. You can get the above profile by: out . to build a kind node. to start a control plane for the above build. to allow anonymous pprof access the CRDs from I used to see the RSS but I imagine would show it too. See for details on how I disabled the logger to get the \"without logger\" numbers. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nSince you looked at the code, and I'd rather not spend time doing that. Any chance you can tell if it's because it's being mis-used?\nThis is a scale dimension where the apiserver has historically . With the OpenAPI discovery performance being improved it looks like this might be a hint at what the next bottleneck might be? Any idea how many etcd clients were instantiated? I suspect it's quite a lot.\nSadly I didn't yet look deeply past turning it off. I was slightly optimistic that we might just be able to disable it without any meaningful impact. What I do know is that the offending code seems to be on the etcd3 client end - i.e. it defaults to creating its own logger when one isn't supplied. You can see that code at\nI don't - will try to find out.\nThe zap logs might tell you if you have the data. If my memory of the code is right, you should get 1 etcd client per CRD right now (plus some for builtin types).\n/triage accepted\nBased on my read of the code, you're right. I see roughly: All of /apis is handled by a crdHandler When a request comes in it gets an instance of the crd (from an informer) Gets serving info from a map of CRDs - if there is none it... Calls customresource.NewStorage which creates a genericregistry.Store Calls its CompleteWithOptions method That calls its \u201cDecorator\u201d, which is a genericregistry.StorageWithCacher That calls generic.NewRawStorage which just wraps factory.Create factory.Create calls newETCD3Storage which calls newETCD3Client I'm experiencing technical difficulties getting lsof running in my kind container but /proc/pid/net confirms we have a connection to etcd per CRD: Note that 1,937 - 60 = 1,877 - the number of CRDs we have loaded (the 1,878 above includes the header line).", "positive_passages": [{"docid": "doc-en-kubernetes-42c6c2327fa61c372454cccb7c58f283839a8bbd86bcb8bd1dda8b6c290fb496", "text": "dbMetricsMonitorJitter = 0.5 ) <ins> // TODO(negz): Stop using a package scoped logger. At the time of writing we're // creating an etcd client for each CRD. We need to pass each etcd client a // logger or each client will create its own, which comes with a significant // memory cost (around 20% of the API server's memory when hundreds of CRDs are // present). The correct fix here is to not create a client per CRD. See // https://github.com/kubernetes/kubernetes/issues/111476 for more. var etcd3ClientLogger *zap.Logger </ins> func init() { // grpcprom auto-registers (via an init function) their client metrics, since we are opting out of // using the global prometheus registry and using our own wrapped global registry,", "commid": "kubernetes_pr_111477"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7679fec6fc3307560ba7099cdd14fd03a7bc8aa630e2c9e270959a4136246b1d", "query": "The project uses a lot of CRDs - in some cases almost 2,000. I do mean here, not custom resources. We've noticed that API server memory consumption balloons when many CRDs are installed - for example with ~1,900 CRDs we see the API server using up to ~8Gi RSS. A little profiling shows that around 1.5Gi of that memory is being used by the etcd3 client's logger. With Kubernetes built from with the CRDs at loaded I'm seeing the API server using up to ~7.5GiB RSS. I see it dip to ~5.5GiB, presumably when garbage collection runs. You can see taking up a ton of memory below. Zap is the logger used by the etcd client. Note that this is a sample, so it's actually using more than the indicated ~800MiB. ! I'm seeing the API server using up to ~6GiB RSS. I see it dip to ~4.5GiB, presumably due to GC runs. You can see no longer appears below. ! I would not expect a logger to be responsible for such a significant amount of the API server's memory consumption. You can get the above profile by: out . to build a kind node. to start a control plane for the above build. to allow anonymous pprof access the CRDs from I used to see the RSS but I imagine would show it too. See for details on how I disabled the logger to get the \"without logger\" numbers. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nSince you looked at the code, and I'd rather not spend time doing that. Any chance you can tell if it's because it's being mis-used?\nThis is a scale dimension where the apiserver has historically . With the OpenAPI discovery performance being improved it looks like this might be a hint at what the next bottleneck might be? Any idea how many etcd clients were instantiated? I suspect it's quite a lot.\nSadly I didn't yet look deeply past turning it off. I was slightly optimistic that we might just be able to disable it without any meaningful impact. What I do know is that the offending code seems to be on the etcd3 client end - i.e. it defaults to creating its own logger when one isn't supplied. You can see that code at\nI don't - will try to find out.\nThe zap logs might tell you if you have the data. If my memory of the code is right, you should get 1 etcd client per CRD right now (plus some for builtin types).\n/triage accepted\nBased on my read of the code, you're right. I see roughly: All of /apis is handled by a crdHandler When a request comes in it gets an instance of the crd (from an informer) Gets serving info from a map of CRDs - if there is none it... Calls customresource.NewStorage which creates a genericregistry.Store Calls its CompleteWithOptions method That calls its \u201cDecorator\u201d, which is a genericregistry.StorageWithCacher That calls generic.NewRawStorage which just wraps factory.Create factory.Create calls newETCD3Storage which calls newETCD3Client I'm experiencing technical difficulties getting lsof running in my kind container but /proc/pid/net confirms we have a connection to etcd per CRD: Note that 1,937 - 60 = 1,877 - the number of CRDs we have loaded (the 1,878 above includes the header line).", "positive_passages": [{"docid": "doc-en-kubernetes-a7469fc201ba6ee067d595028f8a58acbe3fd0da431267548118179a6e611b3e", "text": "// For reference: https://github.com/kubernetes/kubernetes/pull/81387 legacyregistry.RawMustRegister(grpcprom.DefaultClientMetrics) dbMetricsMonitors = make(map[string]struct{}) <ins> l, err := logutil.CreateDefaultZapLogger(etcdClientDebugLevel()) if err != nil { l = zap.NewNop() } etcd3ClientLogger = l.Named(\"etcd-client\") } // etcdClientDebugLevel translates ETCD_CLIENT_DEBUG into zap log level. // NOTE(negz): This is a copy of a private etcd client function: // https://github.com/etcd-io/etcd/blob/v3.5.4/client/v3/logger.go#L47 func etcdClientDebugLevel() zapcore.Level { envLevel := os.Getenv(\"ETCD_CLIENT_DEBUG\") if envLevel == \"\" || envLevel == \"true\" { return zapcore.InfoLevel } var l zapcore.Level if err := l.Set(envLevel); err == nil { log.Printf(\"Deprecated env ETCD_CLIENT_DEBUG value. Using default level: 'info'\") return zapcore.InfoLevel } return l </ins> } func newETCD3HealthCheck(c storagebackend.Config, stopCh <-chan struct{}) (func() error, error) {", "commid": "kubernetes_pr_111477"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7679fec6fc3307560ba7099cdd14fd03a7bc8aa630e2c9e270959a4136246b1d", "query": "The project uses a lot of CRDs - in some cases almost 2,000. I do mean here, not custom resources. We've noticed that API server memory consumption balloons when many CRDs are installed - for example with ~1,900 CRDs we see the API server using up to ~8Gi RSS. A little profiling shows that around 1.5Gi of that memory is being used by the etcd3 client's logger. With Kubernetes built from with the CRDs at loaded I'm seeing the API server using up to ~7.5GiB RSS. I see it dip to ~5.5GiB, presumably when garbage collection runs. You can see taking up a ton of memory below. Zap is the logger used by the etcd client. Note that this is a sample, so it's actually using more than the indicated ~800MiB. ! I'm seeing the API server using up to ~6GiB RSS. I see it dip to ~4.5GiB, presumably due to GC runs. You can see no longer appears below. ! I would not expect a logger to be responsible for such a significant amount of the API server's memory consumption. You can get the above profile by: out . to build a kind node. to start a control plane for the above build. to allow anonymous pprof access the CRDs from I used to see the RSS but I imagine would show it too. See for details on how I disabled the logger to get the \"without logger\" numbers. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nSince you looked at the code, and I'd rather not spend time doing that. Any chance you can tell if it's because it's being mis-used?\nThis is a scale dimension where the apiserver has historically . With the OpenAPI discovery performance being improved it looks like this might be a hint at what the next bottleneck might be? Any idea how many etcd clients were instantiated? I suspect it's quite a lot.\nSadly I didn't yet look deeply past turning it off. I was slightly optimistic that we might just be able to disable it without any meaningful impact. What I do know is that the offending code seems to be on the etcd3 client end - i.e. it defaults to creating its own logger when one isn't supplied. You can see that code at\nI don't - will try to find out.\nThe zap logs might tell you if you have the data. If my memory of the code is right, you should get 1 etcd client per CRD right now (plus some for builtin types).\n/triage accepted\nBased on my read of the code, you're right. I see roughly: All of /apis is handled by a crdHandler When a request comes in it gets an instance of the crd (from an informer) Gets serving info from a map of CRDs - if there is none it... Calls customresource.NewStorage which creates a genericregistry.Store Calls its CompleteWithOptions method That calls its \u201cDecorator\u201d, which is a genericregistry.StorageWithCacher That calls generic.NewRawStorage which just wraps factory.Create factory.Create calls newETCD3Storage which calls newETCD3Client I'm experiencing technical difficulties getting lsof running in my kind container but /proc/pid/net confirms we have a connection to etcd per CRD: Note that 1,937 - 60 = 1,877 - the number of CRDs we have loaded (the 1,878 above includes the header line).", "positive_passages": [{"docid": "doc-en-kubernetes-a192d21328c23f188c5c7324f40f90677e68cc8b29905e42cd680edaa3d742f4", "text": "} dialOptions = append(dialOptions, grpc.WithContextDialer(dialer)) } cfg := clientv3.Config{ DialTimeout:          dialTimeout, DialKeepAliveTime:    keepaliveTime,", "commid": "kubernetes_pr_111477"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7679fec6fc3307560ba7099cdd14fd03a7bc8aa630e2c9e270959a4136246b1d", "query": "The project uses a lot of CRDs - in some cases almost 2,000. I do mean here, not custom resources. We've noticed that API server memory consumption balloons when many CRDs are installed - for example with ~1,900 CRDs we see the API server using up to ~8Gi RSS. A little profiling shows that around 1.5Gi of that memory is being used by the etcd3 client's logger. With Kubernetes built from with the CRDs at loaded I'm seeing the API server using up to ~7.5GiB RSS. I see it dip to ~5.5GiB, presumably when garbage collection runs. You can see taking up a ton of memory below. Zap is the logger used by the etcd client. Note that this is a sample, so it's actually using more than the indicated ~800MiB. ! I'm seeing the API server using up to ~6GiB RSS. I see it dip to ~4.5GiB, presumably due to GC runs. You can see no longer appears below. ! I would not expect a logger to be responsible for such a significant amount of the API server's memory consumption. You can get the above profile by: out . to build a kind node. to start a control plane for the above build. to allow anonymous pprof access the CRDs from I used to see the RSS but I imagine would show it too. See for details on how I disabled the logger to get the \"without logger\" numbers. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nSince you looked at the code, and I'd rather not spend time doing that. Any chance you can tell if it's because it's being mis-used?\nThis is a scale dimension where the apiserver has historically . With the OpenAPI discovery performance being improved it looks like this might be a hint at what the next bottleneck might be? Any idea how many etcd clients were instantiated? I suspect it's quite a lot.\nSadly I didn't yet look deeply past turning it off. I was slightly optimistic that we might just be able to disable it without any meaningful impact. What I do know is that the offending code seems to be on the etcd3 client end - i.e. it defaults to creating its own logger when one isn't supplied. You can see that code at\nI don't - will try to find out.\nThe zap logs might tell you if you have the data. If my memory of the code is right, you should get 1 etcd client per CRD right now (plus some for builtin types).\n/triage accepted\nBased on my read of the code, you're right. I see roughly: All of /apis is handled by a crdHandler When a request comes in it gets an instance of the crd (from an informer) Gets serving info from a map of CRDs - if there is none it... Calls customresource.NewStorage which creates a genericregistry.Store Calls its CompleteWithOptions method That calls its \u201cDecorator\u201d, which is a genericregistry.StorageWithCacher That calls generic.NewRawStorage which just wraps factory.Create factory.Create calls newETCD3Storage which calls newETCD3Client I'm experiencing technical difficulties getting lsof running in my kind container but /proc/pid/net confirms we have a connection to etcd per CRD: Note that 1,937 - 60 = 1,877 - the number of CRDs we have loaded (the 1,878 above includes the header line).", "positive_passages": [{"docid": "doc-en-kubernetes-61101037dbd2ff92e2dc4719a13668affad732e2d9958c9948919a16bd8b71e0", "text": "DialOptions:          dialOptions, Endpoints:            c.ServerList, TLS:                  tlsConfig, <ins> Logger:               etcd3ClientLogger, </ins> } return clientv3.New(cfg)", "commid": "kubernetes_pr_111477"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64820056d60c9d73c0e10b019a42542bb69a2317edd6420a8df0a40f5860c9c1", "query": "The gets very long testing mulitple functions in such as , and . These checks should be performed in dedicated Test functions using table for different scenarios. Target functions and are being as part of The remaining checks should be migrated to these functions. Also, a test function should be to migrate the remaining tests.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nAny progress on this? I'm working on and I noticed that has relatively low coverage so I was going to work on getting the coverage up.\nI created that is somewhat related to this.\nno progess. go ahead please\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-4e93843c5b693c9bf5e8501ea04546ee591504eeaaa44031099da5f70989ca98", "text": "package job import ( <del> \"reflect\" </del> \"testing\" \"github.com/google/go-cmp/cmp\" \"github.com/google/go-cmp/cmp/cmpopts\" batchv1 \"k8s.io/api/batch/v1\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" <ins> \"k8s.io/apimachinery/pkg/labels\" </ins> \"k8s.io/apimachinery/pkg/types\" \"k8s.io/apimachinery/pkg/util/validation/field\" genericapirequest \"k8s.io/apiserver/pkg/endpoints/request\"", "commid": "kubernetes_pr_115111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64820056d60c9d73c0e10b019a42542bb69a2317edd6420a8df0a40f5860c9c1", "query": "The gets very long testing mulitple functions in such as , and . These checks should be performed in dedicated Test functions using table for different scenarios. Target functions and are being as part of The remaining checks should be migrated to these functions. Also, a test function should be to migrate the remaining tests.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nAny progress on this? I'm working on and I noticed that has relatively low coverage so I was going to work on getting the coverage up.\nI created that is somewhat related to this.\nno progess. go ahead please\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-7a4686d1c1b8ebd3569f00f9433c63734410560f778ee5aff09324315075fa78", "text": "}, }, }, <ins> \"attempt status update and verify it doesn't change\": { job: batch.Job{ ObjectMeta: getValidObjectMeta(0), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, }, Status: batch.JobStatus{ Active: 1, }, }, updatedJob: batch.Job{ ObjectMeta: getValidObjectMeta(0), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, }, Status: batch.JobStatus{ Active: 2, }, }, wantJob: batch.Job{ ObjectMeta: getValidObjectMeta(0), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, }, Status: batch.JobStatus{ Active: 1, }, }, }, \"ensure generation doesn't change over non spec updates\": { job: batch.Job{ ObjectMeta: getValidObjectMeta(0), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, }, Status: batch.JobStatus{ Active: 1, }, }, updatedJob: batch.Job{ ObjectMeta: getValidObjectMetaWithAnnotations(0, map[string]string{\"hello\": \"world\"}), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, }, Status: batch.JobStatus{ Active: 2, }, }, wantJob: batch.Job{ ObjectMeta: getValidObjectMetaWithAnnotations(0, map[string]string{\"hello\": \"world\"}), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, }, Status: batch.JobStatus{ Active: 1, }, }, }, \"test updating suspend false->true\": { job: batch.Job{ ObjectMeta: getValidObjectMeta(0), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, Suspend:  pointer.Bool(false), }, }, updatedJob: batch.Job{ ObjectMeta: getValidObjectMetaWithAnnotations(0, map[string]string{\"hello\": \"world\"}), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, Suspend:  pointer.Bool(true), }, }, wantJob: batch.Job{ ObjectMeta: getValidObjectMetaWithAnnotations(1, map[string]string{\"hello\": \"world\"}), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, Suspend:  pointer.Bool(true), }, }, }, \"test updating suspend nil -> true\": { job: batch.Job{ ObjectMeta: getValidObjectMeta(0), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, }, }, updatedJob: batch.Job{ ObjectMeta: getValidObjectMetaWithAnnotations(0, map[string]string{\"hello\": \"world\"}), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, Suspend:  pointer.Bool(true), }, }, wantJob: batch.Job{ ObjectMeta: getValidObjectMetaWithAnnotations(1, map[string]string{\"hello\": \"world\"}), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, Suspend:  pointer.Bool(true), }, }, }, </ins> } for name, tc := range cases {", "commid": "kubernetes_pr_115111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64820056d60c9d73c0e10b019a42542bb69a2317edd6420a8df0a40f5860c9c1", "query": "The gets very long testing mulitple functions in such as , and . These checks should be performed in dedicated Test functions using table for different scenarios. Target functions and are being as part of The remaining checks should be migrated to these functions. Also, a test function should be to migrate the remaining tests.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nAny progress on this? I'm working on and I noticed that has relatively low coverage so I was going to work on getting the coverage up.\nI created that is somewhat related to this.\nno progess. go ahead please\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-e10afb2399d4050cf176f0d83ad21ed2bc517f329724d0687be9db79b1ff10ad", "text": "Strategy.PrepareForUpdate(ctx, &tc.updatedJob, &tc.job) if diff := cmp.Diff(tc.wantJob, tc.updatedJob); diff != \"\" { <del> t.Errorf(\"Job pod failure policy (-want,+got):n%s\", diff) </del> <ins> t.Errorf(\"Job update differences (-want,+got):n%s\", diff) </ins> } }) } } <del> // TestJobStrategy_PrepareForUpdate tests various scenearios for PrepareForCreate </del> <ins> // TestJobStrategy_PrepareForCreate tests various scenarios for PrepareForCreate </ins> func TestJobStrategy_PrepareForCreate(t *testing.T) { validSelector := getValidLabelSelector() validPodTemplateSpec := getValidPodTemplateSpecForSelector(validSelector)", "commid": "kubernetes_pr_115111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64820056d60c9d73c0e10b019a42542bb69a2317edd6420a8df0a40f5860c9c1", "query": "The gets very long testing mulitple functions in such as , and . These checks should be performed in dedicated Test functions using table for different scenarios. Target functions and are being as part of The remaining checks should be migrated to these functions. Also, a test function should be to migrate the remaining tests.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nAny progress on this? I'm working on and I noticed that has relatively low coverage so I was going to work on getting the coverage up.\nI created that is somewhat related to this.\nno progess. go ahead please\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-2e1a11132dc05f919cd26de47b8b4cbd5cb4798bb2d3969469e50c12da957324", "text": "}, }, }, <ins> \"job does not allow setting status on create\": { job: batch.Job{ ObjectMeta: getValidObjectMeta(0), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, }, Status: batch.JobStatus{ Active: 1, }, }, wantJob: batch.Job{ ObjectMeta: getValidObjectMetaWithAnnotations(1, map[string]string{batchv1.JobTrackingFinalizer: \"\"}), Spec: batch.JobSpec{ Selector: validSelector, Template: validPodTemplateSpec, }, }, }, </ins> } for name, tc := range cases {", "commid": "kubernetes_pr_115111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64820056d60c9d73c0e10b019a42542bb69a2317edd6420a8df0a40f5860c9c1", "query": "The gets very long testing mulitple functions in such as , and . These checks should be performed in dedicated Test functions using table for different scenarios. Target functions and are being as part of The remaining checks should be migrated to these functions. Also, a test function should be to migrate the remaining tests.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nAny progress on this? I'm working on and I noticed that has relatively low coverage so I was going to work on getting the coverage up.\nI created that is somewhat related to this.\nno progess. go ahead please\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-dcb1e559d885447b6841f3d8f93fbdcee82f6bfd49e69b1fdd09179e0b2eb2a1", "text": "} } <del> // TODO(#111514): refactor by spliting into dedicated test functions func TestJobStrategy(t *testing.T) { ctx := genericapirequest.NewDefaultContext() if !Strategy.NamespaceScoped() { t.Errorf(\"Job must be namespace scoped\") } if Strategy.AllowCreateOnUpdate() { t.Errorf(\"Job should not allow create on update\") } validSelector := &metav1.LabelSelector{ MatchLabels: map[string]string{\"a\": \"b\"}, } validPodTemplateSpec := api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: api.PodSpec{ RestartPolicy: api.RestartPolicyOnFailure, DNSPolicy:     api.DNSClusterFirst, Containers:    []api.Container{{Name: \"abc\", Image: \"image\", ImagePullPolicy: \"IfNotPresent\", TerminationMessagePolicy: api.TerminationMessageReadFile}}, }, } job := &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:      \"myjob\", Namespace: metav1.NamespaceDefault, Annotations: map[string]string{ \"foo\": \"bar\", }, ResourceVersion: \"0\", }, Spec: batch.JobSpec{ Selector:       validSelector, Template:       validPodTemplateSpec, ManualSelector: pointer.BoolPtr(true), Completions:    pointer.Int32Ptr(2), // Set gated values. Suspend:                 pointer.BoolPtr(true), TTLSecondsAfterFinished: pointer.Int32Ptr(0), CompletionMode:          completionModePtr(batch.IndexedCompletion), }, Status: batch.JobStatus{ Active: 11, }, } Strategy.PrepareForCreate(ctx, job) if job.Status.Active != 0 { t.Errorf(\"Job does not allow setting status on create\") } if job.Generation != 1 { t.Errorf(\"expected Generation=1, got %d\", job.Generation) } errs := Strategy.Validate(ctx, job) if len(errs) != 0 { t.Errorf(\"Unexpected error validating %v\", errs) } if job.Spec.CompletionMode == nil { t.Errorf(\"Job should allow setting .spec.completionMode\") } wantAnnotations := map[string]string{ \"foo\":                        \"bar\", batchv1.JobTrackingFinalizer: \"\", } if diff := cmp.Diff(wantAnnotations, job.Annotations); diff != \"\" { t.Errorf(\"Job has annotations (-want,+got):n%s\", diff) } parallelism := int32(10) // ensure we do not change generation for non-spec updates updatedLabelJob := job.DeepCopy() updatedLabelJob.Labels = map[string]string{\"a\": \"true\"} Strategy.PrepareForUpdate(ctx, updatedLabelJob, job) if updatedLabelJob.Generation != 1 { t.Errorf(\"expected Generation=1, got %d\", updatedLabelJob.Generation) } errs = Strategy.ValidateUpdate(ctx, updatedLabelJob, job) if len(errs) != 0 { t.Errorf(\"Unexpected update validation error\") } updatedJob := &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"bar\", ResourceVersion: \"4\", // remove one annotation and try to enforce the job tracking finalizer. Annotations: map[string]string{batchv1.JobTrackingFinalizer: \"\"}, }, Spec: batch.JobSpec{ Parallelism: &parallelism, Completions: pointer.Int32Ptr(2), // Update gated features. TTLSecondsAfterFinished: pointer.Int32Ptr(1), CompletionMode:          completionModePtr(batch.IndexedCompletion), // No change because field is immutable. }, Status: batch.JobStatus{ Active: 11, }, } // Ensure we do not change status job.Status.Active = 10 Strategy.PrepareForUpdate(ctx, updatedJob, job) if updatedJob.Status.Active != 10 { t.Errorf(\"PrepareForUpdate should have preserved prior version status\") } if updatedJob.Generation != 2 { t.Errorf(\"expected Generation=2, got %d\", updatedJob.Generation) } wantAnnotations = map[string]string{ batchv1.JobTrackingFinalizer: \"\", } if diff := cmp.Diff(wantAnnotations, updatedJob.Annotations); diff != \"\" { t.Errorf(\"Job has annotations (-want,+got):n%s\", diff) } errs = Strategy.ValidateUpdate(ctx, updatedJob, job) if len(errs) == 0 { t.Errorf(\"Expected a validation error\") } // Test updating suspend false->true and nil-> true when the feature gate is // disabled. We don't care about other combinations. job.Spec.Suspend, updatedJob.Spec.Suspend = pointer.BoolPtr(false), pointer.BoolPtr(true) Strategy.PrepareForUpdate(ctx, updatedJob, job) job.Spec.Suspend, updatedJob.Spec.Suspend = nil, pointer.BoolPtr(true) Strategy.PrepareForUpdate(ctx, updatedJob, job) </del> <ins> func TestJobStrategy_GarbageCollectionPolicy(t *testing.T) { </ins> // Make sure we correctly implement the interface. // Otherwise a typo could silently change the default. var gcds rest.GarbageCollectionDeleteStrategy = Strategy", "commid": "kubernetes_pr_115111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64820056d60c9d73c0e10b019a42542bb69a2317edd6420a8df0a40f5860c9c1", "query": "The gets very long testing mulitple functions in such as , and . These checks should be performed in dedicated Test functions using table for different scenarios. Target functions and are being as part of The remaining checks should be migrated to these functions. Also, a test function should be to migrate the remaining tests.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nAny progress on this? I'm working on and I noticed that has relatively low coverage so I was going to work on getting the coverage up.\nI created that is somewhat related to this.\nno progess. go ahead please\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-4342ed7ed62e17c5beebaf4db525335bab53b2ca16e7840a487b89b45c1cec91", "text": "} } <del> func TestValidateToleratingBadLabels(t *testing.T) { invalidSelector := getValidLabelSelector() invalidSelector.MatchExpressions = []metav1.LabelSelectorRequirement{{Key: \"key\", Operator: metav1.LabelSelectorOpNotIn, Values: []string{\"bad value\"}}} validPodTemplateSpec := getValidPodTemplateSpecForSelector(getValidLabelSelector()) job := &batch.Job{ ObjectMeta: getValidObjectMeta(0), Spec: batch.JobSpec{ Selector:       invalidSelector, ManualSelector: pointer.BoolPtr(true), Template:       validPodTemplateSpec, }, } job.ResourceVersion = \"1\" oldObj := job.DeepCopy() newObj := job.DeepCopy() context := genericapirequest.NewContext() errorList := Strategy.ValidateUpdate(context, newObj, oldObj) if len(errorList) > 0 { t.Errorf(\"Unexpected error list with no-op update of bad object: %v\", errorList) } } func TestJobStrategyValidateUpdate(t *testing.T) { </del> <ins> func TestJobStrategy_ValidateUpdate(t *testing.T) { </ins> ctx := genericapirequest.NewDefaultContext() validSelector := &metav1.LabelSelector{ MatchLabels: map[string]string{\"a\": \"b\"},", "commid": "kubernetes_pr_115111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64820056d60c9d73c0e10b019a42542bb69a2317edd6420a8df0a40f5860c9c1", "query": "The gets very long testing mulitple functions in such as , and . These checks should be performed in dedicated Test functions using table for different scenarios. Target functions and are being as part of The remaining checks should be migrated to these functions. Also, a test function should be to migrate the remaining tests.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nAny progress on this? I'm working on and I noticed that has relatively low coverage so I was going to work on getting the coverage up.\nI created that is somewhat related to this.\nno progess. go ahead please\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-23226c334bf4f2a43dc905ec39988a986a0b62ef68179434de037bbe29347a75", "text": "}, }, update: func(job *batch.Job) { <del> // change something. </del> job.Annotations[\"foo\"] = \"bar\" }, }, <ins> \"deleting user annotation\": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"0\", Annotations: map[string]string{ batch.JobTrackingFinalizer: \"\", \"foo\":                      \"bar\", }, }, Spec: batch.JobSpec{ Selector:       validSelector, Template:       validPodTemplateSpec, ManualSelector: pointer.BoolPtr(true), Parallelism:    pointer.Int32Ptr(1), }, }, update: func(job *batch.Job) { delete(job.Annotations, \"foo\") }, }, </ins> \"updating node selector for unsuspended job disallowed\": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{", "commid": "kubernetes_pr_115111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64820056d60c9d73c0e10b019a42542bb69a2317edd6420a8df0a40f5860c9c1", "query": "The gets very long testing mulitple functions in such as , and . These checks should be performed in dedicated Test functions using table for different scenarios. Target functions and are being as part of The remaining checks should be migrated to these functions. Also, a test function should be to migrate the remaining tests.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nAny progress on this? I'm working on and I noticed that has relatively low coverage so I was going to work on getting the coverage up.\nI created that is somewhat related to this.\nno progess. go ahead please\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-0fd7a2713ab31d66ead784c4b723ca4b392533b627ab9f12b392a7a6fda972d7", "text": "}, mutableSchedulingDirectivesEnabled: false, }, <ins> \"invalid label selector\": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"0\", Annotations:     map[string]string{\"foo\": \"bar\"}, }, Spec: batch.JobSpec{ Selector: &metav1.LabelSelector{ MatchLabels:      map[string]string{\"a\": \"b\"}, MatchExpressions: []metav1.LabelSelectorRequirement{{Key: \"key\", Operator: metav1.LabelSelectorOpNotIn, Values: []string{\"bad value\"}}}, }, ManualSelector: pointer.BoolPtr(true), Template:       validPodTemplateSpec, }, }, update: func(job *batch.Job) { job.Annotations[\"hello\"] = \"world\" }, }, </ins> } for name, tc := range cases { t.Run(name, func(t *testing.T) {", "commid": "kubernetes_pr_115111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64820056d60c9d73c0e10b019a42542bb69a2317edd6420a8df0a40f5860c9c1", "query": "The gets very long testing mulitple functions in such as , and . These checks should be performed in dedicated Test functions using table for different scenarios. Target functions and are being as part of The remaining checks should be migrated to these functions. Also, a test function should be to migrate the remaining tests.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nAny progress on this? I'm working on and I noticed that has relatively low coverage so I was going to work on getting the coverage up.\nI created that is somewhat related to this.\nno progess. go ahead please\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-b6572f6bd741977739dca2f5d828f4b022526c65492a231affb3fef11ebeb68c", "text": "} } <del> func TestJobStrategyWithGeneration(t *testing.T) { ctx := genericapirequest.NewDefaultContext() theUID := types.UID(\"1a2b3c4d5e6f7g8h9i0k\") validPodTemplateSpec := api.PodTemplateSpec{ Spec: api.PodSpec{ RestartPolicy: api.RestartPolicyOnFailure, DNSPolicy:     api.DNSClusterFirst, Containers:    []api.Container{{Name: \"abc\", Image: \"image\", ImagePullPolicy: \"IfNotPresent\", TerminationMessagePolicy: api.TerminationMessageReadFile}}, }, } job := &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:      \"myjob2\", Namespace: metav1.NamespaceDefault, UID:       theUID, }, Spec: batch.JobSpec{ Selector: nil, Template: validPodTemplateSpec, }, } Strategy.PrepareForCreate(ctx, job) errs := Strategy.Validate(ctx, job) if len(errs) != 0 { t.Errorf(\"Unexpected error validating %v\", errs) } // Validate the stuff that validation should have validated. if job.Spec.Selector == nil { t.Errorf(\"Selector not generated\") } expectedLabels := make(map[string]string) expectedLabels[\"controller-uid\"] = string(theUID) if !reflect.DeepEqual(job.Spec.Selector.MatchLabels, expectedLabels) { t.Errorf(\"Expected label selector not generated\") } if job.Spec.Template.ObjectMeta.Labels == nil { t.Errorf(\"Expected template labels not generated\") } if v, ok := job.Spec.Template.ObjectMeta.Labels[\"job-name\"]; !ok || v != \"myjob2\" { t.Errorf(\"Expected template labels not present\") } if v, ok := job.Spec.Template.ObjectMeta.Labels[\"controller-uid\"]; !ok || v != string(theUID) { t.Errorf(\"Expected template labels not present: ok: %v, v: %v\", ok, v) } } func TestJobStatusStrategy(t *testing.T) { </del> <ins> func TestJobStrategy_WarningsOnUpdate(t *testing.T) { </ins> ctx := genericapirequest.NewDefaultContext() <del> if !StatusStrategy.NamespaceScoped() { t.Errorf(\"Job must be namespace scoped\") } if StatusStrategy.AllowCreateOnUpdate() { t.Errorf(\"Job should not allow create on update\") } </del> validSelector := &metav1.LabelSelector{ MatchLabels: map[string]string{\"a\": \"b\"}, }", "commid": "kubernetes_pr_115111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-64820056d60c9d73c0e10b019a42542bb69a2317edd6420a8df0a40f5860c9c1", "query": "The gets very long testing mulitple functions in such as , and . These checks should be performed in dedicated Test functions using table for different scenarios. Target functions and are being as part of The remaining checks should be migrated to these functions. Also, a test function should be to migrate the remaining tests.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps\n/assign\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\nAny progress on this? I'm working on and I noticed that has relatively low coverage so I was going to work on getting the coverage up.\nI created that is somewhat related to this.\nno progess. go ahead please\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-d05d4c2265fbfeee93379b33e236ba8a92aa63fd7495574735c734bf2862a56e", "text": "Containers:    []api.Container{{Name: \"abc\", Image: \"image\", ImagePullPolicy: \"IfNotPresent\", TerminationMessagePolicy: api.TerminationMessageReadFile}}, }, } <del> oldParallelism := int32(10) newParallelism := int32(11) oldJob := &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"10\", }, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: &oldParallelism, }, Status: batch.JobStatus{ Active: 11, }, } newJob := &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"9\", }, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: &newParallelism, }, Status: batch.JobStatus{ Active: 12, }, } </del> <ins> cases := map[string]struct { oldJob            *batch.Job job               *batch.Job wantWarningsCount int32 }{ \"generation 0 for both\": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"0\", Generation:      0, }, Spec: batch.JobSpec{ Selector:       validSelector, Template:       validPodTemplateSpec, ManualSelector: pointer.BoolPtr(true), Parallelism:    pointer.Int32Ptr(1), }, }, </ins> <del> StatusStrategy.PrepareForUpdate(ctx, newJob, oldJob) if newJob.Status.Active != 12 { t.Errorf(\"Job status updates must allow changes to job status\") } if *newJob.Spec.Parallelism != 10 { t.Errorf(\"Job status updates must now allow changes to job spec\") </del> <ins> oldJob: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"0\", Generation:      0, }, Spec: batch.JobSpec{ Selector:       validSelector, Template:       validPodTemplateSpec, ManualSelector: pointer.BoolPtr(true), Parallelism:    pointer.Int32Ptr(1), }, }, }, \"generation 1 for new; force WarningsOnUpdate to check PodTemplate for updates\": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"0\", Generation:      1, }, Spec: batch.JobSpec{ Selector:       validSelector, Template:       validPodTemplateSpec, ManualSelector: pointer.BoolPtr(true), Parallelism:    pointer.Int32Ptr(1), }, }, oldJob: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"0\", Generation:      0, }, Spec: batch.JobSpec{ Selector:       validSelector, Template:       validPodTemplateSpec, ManualSelector: pointer.BoolPtr(true), Parallelism:    pointer.Int32Ptr(1), }, }, }, \"force validation failure in pod template\": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"0\", Generation:      1, }, Spec: batch.JobSpec{ Selector: validSelector, Template: api.PodTemplateSpec{ Spec: api.PodSpec{Volumes: []api.Volume{{Name: \"volume-name\"}, {Name: \"volume-name\"}}}, }, ManualSelector: pointer.BoolPtr(true), Parallelism:    pointer.Int32Ptr(1), }, }, oldJob: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"0\", Generation:      0, }, Spec: batch.JobSpec{ Selector:       validSelector, Template:       validPodTemplateSpec, ManualSelector: pointer.BoolPtr(true), Parallelism:    pointer.Int32Ptr(1), }, }, wantWarningsCount: 1, }, } for val, tc := range cases { t.Run(val, func(t *testing.T) { gotWarnings := Strategy.WarningsOnUpdate(ctx, tc.job, tc.oldJob) if len(gotWarnings) != int(tc.wantWarningsCount) { t.Errorf(\"got warning length of %d but expected %d\", len(gotWarnings), tc.wantWarningsCount) } }) } } func TestJobStrategy_WarningsOnCreate(t *testing.T) { ctx := genericapirequest.NewDefaultContext() theUID := types.UID(\"1a2b3c4d5e6f7g8h9i0k\") validSelector := &metav1.LabelSelector{ MatchLabels: map[string]string{\"a\": \"b\"}, } validSpec := batch.JobSpec{ Selector: nil, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: api.PodSpec{ RestartPolicy: api.RestartPolicyOnFailure, DNSPolicy:     api.DNSClusterFirst, Containers:    []api.Container{{Name: \"abc\", Image: \"image\", ImagePullPolicy: \"IfNotPresent\", TerminationMessagePolicy: api.TerminationMessageReadFile}}, }, }, } testcases := map[string]struct { job               *batch.Job wantWarningsCount int32 }{ \"happy path job\": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:      \"myjob2\", Namespace: metav1.NamespaceDefault, UID:       theUID, }, Spec: validSpec, }, }, \"dns invalid name\": { wantWarningsCount: 1, job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:      \"my job2\", Namespace: metav1.NamespaceDefault, UID:       theUID, }, Spec: validSpec, }, }, } for name, tc := range testcases { t.Run(name, func(t *testing.T) { gotWarnings := Strategy.WarningsOnCreate(ctx, tc.job) if len(gotWarnings) != int(tc.wantWarningsCount) { t.Errorf(\"got warning length of %d but expected %d\", len(gotWarnings), tc.wantWarningsCount) } }) } } func TestJobStrategy_Validate(t *testing.T) { ctx := genericapirequest.NewDefaultContext() theUID := types.UID(\"1a2b3c4d5e6f7g8h9i0k\") validSelector := &metav1.LabelSelector{ MatchLabels: map[string]string{\"a\": \"b\"}, } validPodSpec := api.PodSpec{ RestartPolicy: api.RestartPolicyOnFailure, DNSPolicy:     api.DNSClusterFirst, Containers:    []api.Container{{Name: \"abc\", Image: \"image\", ImagePullPolicy: \"IfNotPresent\", TerminationMessagePolicy: api.TerminationMessageReadFile}}, } validObjectMeta := metav1.ObjectMeta{ Name:      \"myjob2\", Namespace: metav1.NamespaceDefault, UID:       theUID, } testcases := map[string]struct { job              *batch.Job wantJob          *batch.Job wantWarningCount int32 }{ \"valid job with labels in pod template\": { job: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: nil, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: validPodSpec, }}, }, wantJob: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: &metav1.LabelSelector{MatchLabels: map[string]string{\"controller-uid\": string(theUID)}}, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: validPodSpec, }}, }, }, \"no labels in job\": { job: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: nil, Template: api.PodTemplateSpec{ Spec: validPodSpec, }}, }, wantJob: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: &metav1.LabelSelector{MatchLabels: map[string]string{\"controller-uid\": string(theUID)}}, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: map[string]string{\"job-name\": \"myjob2\", \"controller-uid\": string(theUID)}, }, Spec: validPodSpec, }}, }, }, \"labels exist\": { job: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: nil, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: map[string]string{\"a\": \"b\", \"job-name\": \"myjob2\", \"controller-uid\": string(theUID)}, }, Spec: validPodSpec, }}, }, wantJob: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: &metav1.LabelSelector{MatchLabels: map[string]string{\"controller-uid\": string(theUID)}}, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: map[string]string{\"a\": \"b\", \"job-name\": \"myjob2\", \"controller-uid\": string(theUID)}, }, Spec: validPodSpec, }}, }, }, \"manual selector; do not generate labels\": { job: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: validSelector, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: validPodSpec, }, Completions:    pointer.Int32Ptr(2), ManualSelector: pointer.BoolPtr(true), }, }, wantJob: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: validSelector, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: validPodSpec, }, Completions:    pointer.Int32Ptr(2), ManualSelector: pointer.BoolPtr(true), }, }, }, \"valid job with extended configuration\": { job: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: nil, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: validPodSpec, }, Completions:             pointer.Int32Ptr(2), Suspend:                 pointer.BoolPtr(true), TTLSecondsAfterFinished: pointer.Int32Ptr(0), CompletionMode:          completionModePtr(batch.IndexedCompletion), }, }, wantJob: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: &metav1.LabelSelector{MatchLabels: map[string]string{\"controller-uid\": string(theUID)}}, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: map[string]string{\"a\": \"b\", \"job-name\": \"myjob2\", \"controller-uid\": string(theUID)}, }, Spec: validPodSpec, }, Completions:             pointer.Int32Ptr(2), Suspend:                 pointer.BoolPtr(true), TTLSecondsAfterFinished: pointer.Int32Ptr(0), CompletionMode:          completionModePtr(batch.IndexedCompletion), }, }, }, \"fail validation due to invalid volume spec\": { job: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: nil, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: api.PodSpec{ RestartPolicy: api.RestartPolicyOnFailure, DNSPolicy:     api.DNSClusterFirst, Containers:    []api.Container{{Name: \"abc\", Image: \"image\", ImagePullPolicy: \"IfNotPresent\", TerminationMessagePolicy: api.TerminationMessageReadFile}}, Volumes:       []api.Volume{{Name: \"volume-name\"}}, }, }, }, }, wantJob: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector: &metav1.LabelSelector{MatchLabels: map[string]string{\"controller-uid\": string(theUID)}}, Template: api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: map[string]string{\"a\": \"b\", \"job-name\": \"myjob2\", \"controller-uid\": string(theUID)}, }, Spec: api.PodSpec{ RestartPolicy: api.RestartPolicyOnFailure, DNSPolicy:     api.DNSClusterFirst, Containers:    []api.Container{{Name: \"abc\", Image: \"image\", ImagePullPolicy: \"IfNotPresent\", TerminationMessagePolicy: api.TerminationMessageReadFile}}, Volumes:       []api.Volume{{Name: \"volume-name\"}}, }, }, }, }, wantWarningCount: 1, }, } for name, tc := range testcases { t.Run(name, func(t *testing.T) { errs := Strategy.Validate(ctx, tc.job) if len(errs) != int(tc.wantWarningCount) { t.Errorf(\"want warnings %d but got %d\", tc.wantWarningCount, len(errs)) } if diff := cmp.Diff(tc.wantJob, tc.job); diff != \"\" { t.Errorf(\"Unexpected job (-want,+got):n%s\", diff) } }) } } func TestStrategy_ResetFields(t *testing.T) { resetFields := Strategy.GetResetFields() if len(resetFields) != 1 { t.Error(\"ResetFields should have 1 element\") } } func TestJobStatusStrategy_ResetFields(t *testing.T) { resetFields := StatusStrategy.GetResetFields() if len(resetFields) != 1 { t.Error(\"ResetFields should have 1 element\") } } func TestStatusStrategy_PrepareForUpdate(t *testing.T) { ctx := genericapirequest.NewDefaultContext() validSelector := &metav1.LabelSelector{ MatchLabels: map[string]string{\"a\": \"b\"}, } validPodTemplateSpec := api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: api.PodSpec{ RestartPolicy: api.RestartPolicyOnFailure, DNSPolicy:     api.DNSClusterFirst, Containers:    []api.Container{{Name: \"abc\", Image: \"image\", ImagePullPolicy: \"IfNotPresent\", TerminationMessagePolicy: api.TerminationMessageReadFile}}, }, } validObjectMeta := metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"10\", } cases := map[string]struct { job     *batch.Job newJob  *batch.Job wantJob *batch.Job }{ \"job must allow status updates\": { job: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: pointer.Int32(4), }, Status: batch.JobStatus{ Active: 11, }, }, newJob: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: pointer.Int32(4), }, Status: batch.JobStatus{ Active: 12, }, }, wantJob: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: pointer.Int32(4), }, Status: batch.JobStatus{ Active: 12, }, }, }, \"parallelism changes not allowed\": { job: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: pointer.Int32(3), }, }, newJob: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: pointer.Int32(4), }, }, wantJob: &batch.Job{ ObjectMeta: validObjectMeta, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: pointer.Int32(3), }, }, }, } for name, tc := range cases { t.Run(name, func(t *testing.T) { StatusStrategy.PrepareForUpdate(ctx, tc.newJob, tc.job) if diff := cmp.Diff(tc.wantJob, tc.newJob); diff != \"\" { t.Errorf(\"Unexpected job (-want,+got):n%s\", diff) } }) } } func TestStatusStrategy_ValidateUpdate(t *testing.T) { ctx := genericapirequest.NewDefaultContext() validSelector := &metav1.LabelSelector{ MatchLabels: map[string]string{\"a\": \"b\"}, } validPodTemplateSpec := api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: api.PodSpec{ RestartPolicy: api.RestartPolicyOnFailure, DNSPolicy:     api.DNSClusterFirst, Containers:    []api.Container{{Name: \"abc\", Image: \"image\", ImagePullPolicy: \"IfNotPresent\", TerminationMessagePolicy: api.TerminationMessageReadFile}}, }, } cases := map[string]struct { job     *batch.Job newJob  *batch.Job wantJob *batch.Job }{ \"incoming resource version on update should not be mutated\": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"10\", }, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: pointer.Int32(4), }, }, newJob: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"9\", }, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: pointer.Int32(4), }, }, wantJob: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"9\", }, Spec: batch.JobSpec{ Selector:    validSelector, Template:    validPodTemplateSpec, Parallelism: pointer.Int32(4), }, }, }, } for name, tc := range cases { t.Run(name, func(t *testing.T) { errs := StatusStrategy.ValidateUpdate(ctx, tc.newJob, tc.job) if len(errs) != 0 { t.Errorf(\"Unexpected error %v\", errs) } if diff := cmp.Diff(tc.wantJob, tc.newJob); diff != \"\" { t.Errorf(\"Unexpected job (-want,+got):n%s\", diff) } }) } } func TestJobStrategy_GetAttrs(t *testing.T) { validSelector := &metav1.LabelSelector{ MatchLabels: map[string]string{\"a\": \"b\"}, } validPodTemplateSpec := api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: validSelector.MatchLabels, }, Spec: api.PodSpec{ RestartPolicy: api.RestartPolicyOnFailure, DNSPolicy:     api.DNSClusterFirst, Containers:    []api.Container{{Name: \"abc\", Image: \"image\", ImagePullPolicy: \"IfNotPresent\", TerminationMessagePolicy: api.TerminationMessageReadFile}}, }, </ins> } <del> errs := StatusStrategy.ValidateUpdate(ctx, newJob, oldJob) if len(errs) != 0 { t.Errorf(\"Unexpected error %v\", errs) </del> <ins> cases := map[string]struct { job          *batch.Job wantErr      string nonJobObject *api.Pod }{ \"valid job with no labels\": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"0\", }, Spec: batch.JobSpec{ Selector:       validSelector, Template:       validPodTemplateSpec, ManualSelector: pointer.BoolPtr(true), Parallelism:    pointer.Int32Ptr(1), }, }, }, \"valid job with a label\": { job: &batch.Job{ ObjectMeta: metav1.ObjectMeta{ Name:            \"myjob\", Namespace:       metav1.NamespaceDefault, ResourceVersion: \"0\", Labels:          map[string]string{\"a\": \"b\"}, }, Spec: batch.JobSpec{ Selector:       validSelector, Template:       validPodTemplateSpec, ManualSelector: pointer.BoolPtr(true), Parallelism:    pointer.Int32Ptr(1), }, }, }, \"pod instead\": { job:          nil, nonJobObject: &api.Pod{}, wantErr:      \"given object is not a job.\", }, </ins> } <del> if newJob.ResourceVersion != \"9\" { t.Errorf(\"Incoming resource version on update should not be mutated\") </del> <ins> for name, tc := range cases { t.Run(name, func(t *testing.T) { if tc.job == nil { _, _, err := GetAttrs(tc.nonJobObject) if diff := cmp.Diff(tc.wantErr, err.Error()); diff != \"\" { t.Errorf(\"Unexpected errors (-want,+got):n%s\", diff) } } else { gotLabels, _, err := GetAttrs(tc.job) if err != nil { t.Errorf(\"Error %s supposed to be nil\", err.Error()) } if diff := cmp.Diff(labels.Set(tc.job.ObjectMeta.Labels), gotLabels); diff != \"\" { t.Errorf(\"Unexpected attrs (-want,+got):n%s\", diff) } } }) </ins> } } <del> func TestSelectableFieldLabelConversions(t *testing.T) { </del> <ins> func TestJobToSelectiableFields(t *testing.T) { </ins> apitesting.TestSelectableFieldLabelConversionsOfKind(t, \"batch/v1\", \"Job\",", "commid": "kubernetes_pr_115111"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-647cba4e10e47735b73ba312460d98b00a45cf0c5a34d59d8529290e678b0deb", "query": "When enable apiserver tracing, the webhook request spans only show spanName as /, mostly because use http request operations as default span name, which is hard to understand. ! Following the open-telemetry standard of spanName, it's recommended to use as spanName. ! SpanName of webhook request should be , like ! APIServerTracing feature gates of apiserver a pod tracing dashboard No response <details18 </details<detailsNone </details<details</details<details</details<details</details<details</details\nI make a fix for this.\n/sig api-machinery instrumentation\nDo you know if this is fixed in later versions of opentelemetry?\n/triage accepted /assign\nLooks like might be related\nnot yet, I think we can fix this in otel upstream, but it's hard to backport to otel , which is the version of otel used in Kubernetes\nGood point. It think fixing it here is a good idea in that case.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\ncould I take on this issue?\nyes. Feel free to work on this.\n! I test locally by 1.29 kubernetes and start a sample webhook, looks like the client span has already conforms to semantic conventions , which should be in the form of \"HTTP {METHODNAME}\"\n! For apiserver as a server, now the spanName is still KubernetesAPI, which I think we could enhance it into \"HTTP get_account/{accountId}\" format\nAfter digging for a while, I found one solution to implement this, I draft this idea in , could you help review about whether this is a correct way to implement it?", "positive_passages": [{"docid": "doc-en-kubernetes-41dab007d51335667f36b6b1b94d65985f715ba2368b989409e3ee36af97635e", "text": "\"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp\" semconv \"go.opentelemetry.io/otel/semconv/v1.17.0\" \"go.opentelemetry.io/otel/trace\" <ins> \"k8s.io/apiserver/pkg/endpoints/request\" </ins> tracing \"k8s.io/component-base/tracing\" )", "commid": "kubernetes_pr_123584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-647cba4e10e47735b73ba312460d98b00a45cf0c5a34d59d8529290e678b0deb", "query": "When enable apiserver tracing, the webhook request spans only show spanName as /, mostly because use http request operations as default span name, which is hard to understand. ! Following the open-telemetry standard of spanName, it's recommended to use as spanName. ! SpanName of webhook request should be , like ! APIServerTracing feature gates of apiserver a pod tracing dashboard No response <details18 </details<detailsNone </details<details</details<details</details<details</details<details</details\nI make a fix for this.\n/sig api-machinery instrumentation\nDo you know if this is fixed in later versions of opentelemetry?\n/triage accepted /assign\nLooks like might be related\nnot yet, I think we can fix this in otel upstream, but it's hard to backport to otel , which is the version of otel used in Kubernetes\nGood point. It think fixing it here is a good idea in that case.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\ncould I take on this issue?\nyes. Feel free to work on this.\n! I test locally by 1.29 kubernetes and start a sample webhook, looks like the client span has already conforms to semantic conventions , which should be in the form of \"HTTP {METHODNAME}\"\n! For apiserver as a server, now the spanName is still KubernetesAPI, which I think we could enhance it into \"HTTP get_account/{accountId}\" format\nAfter digging for a while, I found one solution to implement this, I draft this idea in , could you help review about whether this is a correct way to implement it?", "positive_passages": [{"docid": "doc-en-kubernetes-dd4b460e33e5009219b29e1c1e52e4ee07ef1dacfe5cab18ce386f944c4b9998", "text": "otelhttp.WithPropagators(tracing.Propagators()), otelhttp.WithPublicEndpoint(), otelhttp.WithTracerProvider(tp), <ins> otelhttp.WithSpanNameFormatter(func(operation string, r *http.Request) string { ctx := r.Context() info, exist := request.RequestInfoFrom(ctx) if !exist || !info.IsResourceRequest { return r.Method } return getSpanNameFromRequestInfo(info, r) }), </ins> } wrappedHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { // Add the http.target attribute to the otelhttp span", "commid": "kubernetes_pr_123584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-647cba4e10e47735b73ba312460d98b00a45cf0c5a34d59d8529290e678b0deb", "query": "When enable apiserver tracing, the webhook request spans only show spanName as /, mostly because use http request operations as default span name, which is hard to understand. ! Following the open-telemetry standard of spanName, it's recommended to use as spanName. ! SpanName of webhook request should be , like ! APIServerTracing feature gates of apiserver a pod tracing dashboard No response <details18 </details<detailsNone </details<details</details<details</details<details</details<details</details\nI make a fix for this.\n/sig api-machinery instrumentation\nDo you know if this is fixed in later versions of opentelemetry?\n/triage accepted /assign\nLooks like might be related\nnot yet, I think we can fix this in otel upstream, but it's hard to backport to otel , which is the version of otel used in Kubernetes\nGood point. It think fixing it here is a good idea in that case.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\ncould I take on this issue?\nyes. Feel free to work on this.\n! I test locally by 1.29 kubernetes and start a sample webhook, looks like the client span has already conforms to semantic conventions , which should be in the form of \"HTTP {METHODNAME}\"\n! For apiserver as a server, now the spanName is still KubernetesAPI, which I think we could enhance it into \"HTTP get_account/{accountId}\" format\nAfter digging for a while, I found one solution to implement this, I draft this idea in , could you help review about whether this is a correct way to implement it?", "positive_passages": [{"docid": "doc-en-kubernetes-ee6459558ef95e56b27e225d18c66356ce63ec33e6612158468a717ec3768bc3", "text": "// See https://github.com/open-telemetry/opentelemetry-go/tree/main/example/passthrough return otelhttp.NewHandler(wrappedHandler, \"KubernetesAPI\", opts...) } <ins> func getSpanNameFromRequestInfo(info *request.RequestInfo, r *http.Request) string { spanName := \"/\" + info.APIPrefix if info.APIGroup != \"\" { spanName += \"/\" + info.APIGroup } spanName += \"/\" + info.APIVersion if info.Namespace != \"\" { spanName += \"/namespaces/{:namespace}\" } spanName += \"/\" + info.Resource if info.Name != \"\" { spanName += \"/\" + \"{:name}\" } if info.Subresource != \"\" { spanName += \"/\" + info.Subresource } return r.Method + \" \" + spanName } </ins>", "commid": "kubernetes_pr_123584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-647cba4e10e47735b73ba312460d98b00a45cf0c5a34d59d8529290e678b0deb", "query": "When enable apiserver tracing, the webhook request spans only show spanName as /, mostly because use http request operations as default span name, which is hard to understand. ! Following the open-telemetry standard of spanName, it's recommended to use as spanName. ! SpanName of webhook request should be , like ! APIServerTracing feature gates of apiserver a pod tracing dashboard No response <details18 </details<detailsNone </details<details</details<details</details<details</details<details</details\nI make a fix for this.\n/sig api-machinery instrumentation\nDo you know if this is fixed in later versions of opentelemetry?\n/triage accepted /assign\nLooks like might be related\nnot yet, I think we can fix this in otel upstream, but it's hard to backport to otel , which is the version of otel used in Kubernetes\nGood point. It think fixing it here is a good idea in that case.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\ncould I take on this issue?\nyes. Feel free to work on this.\n! I test locally by 1.29 kubernetes and start a sample webhook, looks like the client span has already conforms to semantic conventions , which should be in the form of \"HTTP {METHODNAME}\"\n! For apiserver as a server, now the spanName is still KubernetesAPI, which I think we could enhance it into \"HTTP get_account/{accountId}\" format\nAfter digging for a while, I found one solution to implement this, I draft this idea in , could you help review about whether this is a correct way to implement it?", "positive_passages": [{"docid": "doc-en-kubernetes-f470e1849b0e5132bd7228937e42f06b3e493018b6ed067cea47fdf36fbc09b6", "text": "}, expectedTrace: []*spanExpectation{ { <del> name: \"KubernetesAPI\", </del> <ins> name: \"POST /api/v1/nodes\", </ins> attributes: map[string]func(*commonv1.AnyValue) bool{ \"http.user_agent\": func(v *commonv1.AnyValue) bool { return strings.HasPrefix(v.GetStringValue(), \"tracing.test\")", "commid": "kubernetes_pr_123584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-647cba4e10e47735b73ba312460d98b00a45cf0c5a34d59d8529290e678b0deb", "query": "When enable apiserver tracing, the webhook request spans only show spanName as /, mostly because use http request operations as default span name, which is hard to understand. ! Following the open-telemetry standard of spanName, it's recommended to use as spanName. ! SpanName of webhook request should be , like ! APIServerTracing feature gates of apiserver a pod tracing dashboard No response <details18 </details<detailsNone </details<details</details<details</details<details</details<details</details\nI make a fix for this.\n/sig api-machinery instrumentation\nDo you know if this is fixed in later versions of opentelemetry?\n/triage accepted /assign\nLooks like might be related\nnot yet, I think we can fix this in otel upstream, but it's hard to backport to otel , which is the version of otel used in Kubernetes\nGood point. It think fixing it here is a good idea in that case.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\ncould I take on this issue?\nyes. Feel free to work on this.\n! I test locally by 1.29 kubernetes and start a sample webhook, looks like the client span has already conforms to semantic conventions , which should be in the form of \"HTTP {METHODNAME}\"\n! For apiserver as a server, now the spanName is still KubernetesAPI, which I think we could enhance it into \"HTTP get_account/{accountId}\" format\nAfter digging for a while, I found one solution to implement this, I draft this idea in , could you help review about whether this is a correct way to implement it?", "positive_passages": [{"docid": "doc-en-kubernetes-69f5187a2bc41ac133a1ccdadbf7b4a570de042730b069934f329c883372e1be", "text": "}, expectedTrace: []*spanExpectation{ { <del> name: \"KubernetesAPI\", </del> <ins> name: \"GET /api/v1/nodes/{:name}\", </ins> attributes: map[string]func(*commonv1.AnyValue) bool{ \"http.user_agent\": func(v *commonv1.AnyValue) bool { return strings.HasPrefix(v.GetStringValue(), \"tracing.test\")", "commid": "kubernetes_pr_123584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-647cba4e10e47735b73ba312460d98b00a45cf0c5a34d59d8529290e678b0deb", "query": "When enable apiserver tracing, the webhook request spans only show spanName as /, mostly because use http request operations as default span name, which is hard to understand. ! Following the open-telemetry standard of spanName, it's recommended to use as spanName. ! SpanName of webhook request should be , like ! APIServerTracing feature gates of apiserver a pod tracing dashboard No response <details18 </details<detailsNone </details<details</details<details</details<details</details<details</details\nI make a fix for this.\n/sig api-machinery instrumentation\nDo you know if this is fixed in later versions of opentelemetry?\n/triage accepted /assign\nLooks like might be related\nnot yet, I think we can fix this in otel upstream, but it's hard to backport to otel , which is the version of otel used in Kubernetes\nGood point. It think fixing it here is a good idea in that case.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\ncould I take on this issue?\nyes. Feel free to work on this.\n! I test locally by 1.29 kubernetes and start a sample webhook, looks like the client span has already conforms to semantic conventions , which should be in the form of \"HTTP {METHODNAME}\"\n! For apiserver as a server, now the spanName is still KubernetesAPI, which I think we could enhance it into \"HTTP get_account/{accountId}\" format\nAfter digging for a while, I found one solution to implement this, I draft this idea in , could you help review about whether this is a correct way to implement it?", "positive_passages": [{"docid": "doc-en-kubernetes-7593cdd3c4ece785e077f3f8673bc21e66cf5babedd28f9785339dd9767de26b", "text": "}, expectedTrace: []*spanExpectation{ { <del> name: \"KubernetesAPI\", </del> <ins> name: \"GET /api/v1/nodes\", </ins> attributes: map[string]func(*commonv1.AnyValue) bool{ \"http.user_agent\": func(v *commonv1.AnyValue) bool { return strings.HasPrefix(v.GetStringValue(), \"tracing.test\")", "commid": "kubernetes_pr_123584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-647cba4e10e47735b73ba312460d98b00a45cf0c5a34d59d8529290e678b0deb", "query": "When enable apiserver tracing, the webhook request spans only show spanName as /, mostly because use http request operations as default span name, which is hard to understand. ! Following the open-telemetry standard of spanName, it's recommended to use as spanName. ! SpanName of webhook request should be , like ! APIServerTracing feature gates of apiserver a pod tracing dashboard No response <details18 </details<detailsNone </details<details</details<details</details<details</details<details</details\nI make a fix for this.\n/sig api-machinery instrumentation\nDo you know if this is fixed in later versions of opentelemetry?\n/triage accepted /assign\nLooks like might be related\nnot yet, I think we can fix this in otel upstream, but it's hard to backport to otel , which is the version of otel used in Kubernetes\nGood point. It think fixing it here is a good idea in that case.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\ncould I take on this issue?\nyes. Feel free to work on this.\n! I test locally by 1.29 kubernetes and start a sample webhook, looks like the client span has already conforms to semantic conventions , which should be in the form of \"HTTP {METHODNAME}\"\n! For apiserver as a server, now the spanName is still KubernetesAPI, which I think we could enhance it into \"HTTP get_account/{accountId}\" format\nAfter digging for a while, I found one solution to implement this, I draft this idea in , could you help review about whether this is a correct way to implement it?", "positive_passages": [{"docid": "doc-en-kubernetes-564bc1a18137cba321e421ec2f0f2d19443847d4d667a17b781d24509e2029da", "text": "}, expectedTrace: []*spanExpectation{ { <del> name: \"KubernetesAPI\", </del> <ins> name: \"PUT /api/v1/nodes/{:name}\", </ins> attributes: map[string]func(*commonv1.AnyValue) bool{ \"http.user_agent\": func(v *commonv1.AnyValue) bool { return strings.HasPrefix(v.GetStringValue(), \"tracing.test\")", "commid": "kubernetes_pr_123584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-647cba4e10e47735b73ba312460d98b00a45cf0c5a34d59d8529290e678b0deb", "query": "When enable apiserver tracing, the webhook request spans only show spanName as /, mostly because use http request operations as default span name, which is hard to understand. ! Following the open-telemetry standard of spanName, it's recommended to use as spanName. ! SpanName of webhook request should be , like ! APIServerTracing feature gates of apiserver a pod tracing dashboard No response <details18 </details<detailsNone </details<details</details<details</details<details</details<details</details\nI make a fix for this.\n/sig api-machinery instrumentation\nDo you know if this is fixed in later versions of opentelemetry?\n/triage accepted /assign\nLooks like might be related\nnot yet, I think we can fix this in otel upstream, but it's hard to backport to otel , which is the version of otel used in Kubernetes\nGood point. It think fixing it here is a good idea in that case.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\ncould I take on this issue?\nyes. Feel free to work on this.\n! I test locally by 1.29 kubernetes and start a sample webhook, looks like the client span has already conforms to semantic conventions , which should be in the form of \"HTTP {METHODNAME}\"\n! For apiserver as a server, now the spanName is still KubernetesAPI, which I think we could enhance it into \"HTTP get_account/{accountId}\" format\nAfter digging for a while, I found one solution to implement this, I draft this idea in , could you help review about whether this is a correct way to implement it?", "positive_passages": [{"docid": "doc-en-kubernetes-fe0ef984fd2ed13a70096fa69a8a3d9f90641643171cecca31955ba0c17752f9", "text": "}, expectedTrace: []*spanExpectation{ { <del> name: \"KubernetesAPI\", </del> <ins> name: \"PATCH /api/v1/nodes/{:name}\", </ins> attributes: map[string]func(*commonv1.AnyValue) bool{ \"http.user_agent\": func(v *commonv1.AnyValue) bool { return strings.HasPrefix(v.GetStringValue(), \"tracing.test\")", "commid": "kubernetes_pr_123584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-647cba4e10e47735b73ba312460d98b00a45cf0c5a34d59d8529290e678b0deb", "query": "When enable apiserver tracing, the webhook request spans only show spanName as /, mostly because use http request operations as default span name, which is hard to understand. ! Following the open-telemetry standard of spanName, it's recommended to use as spanName. ! SpanName of webhook request should be , like ! APIServerTracing feature gates of apiserver a pod tracing dashboard No response <details18 </details<detailsNone </details<details</details<details</details<details</details<details</details\nI make a fix for this.\n/sig api-machinery instrumentation\nDo you know if this is fixed in later versions of opentelemetry?\n/triage accepted /assign\nLooks like might be related\nnot yet, I think we can fix this in otel upstream, but it's hard to backport to otel , which is the version of otel used in Kubernetes\nGood point. It think fixing it here is a good idea in that case.\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:\n/remove-lifecycle stale\ncould I take on this issue?\nyes. Feel free to work on this.\n! I test locally by 1.29 kubernetes and start a sample webhook, looks like the client span has already conforms to semantic conventions , which should be in the form of \"HTTP {METHODNAME}\"\n! For apiserver as a server, now the spanName is still KubernetesAPI, which I think we could enhance it into \"HTTP get_account/{accountId}\" format\nAfter digging for a while, I found one solution to implement this, I draft this idea in , could you help review about whether this is a correct way to implement it?", "positive_passages": [{"docid": "doc-en-kubernetes-bd5105c0dd910e8e6600e86f8de00d3592a9672f8d0390ca5b5d2c05ec241ea2", "text": "}, expectedTrace: []*spanExpectation{ { <del> name: \"KubernetesAPI\", </del> <ins> name: \"DELETE /api/v1/nodes/{:name}\", </ins> attributes: map[string]func(*commonv1.AnyValue) bool{ \"http.user_agent\": func(v *commonv1.AnyValue) bool { return strings.HasPrefix(v.GetStringValue(), \"tracing.test\")", "commid": "kubernetes_pr_123584"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a1f837590f81f9849ac7605d8bd9eccee30ea8328192a45383fa25504691e30", "query": "This one involves systemd, DNS, musl, and Kubelet v1.25 Starting in v1.25.0, pods running on Kubelets on certain nodes with a FQDN hostname (more on that later) will not be able to resolve DNS queries if they're using musl (e.g. alpine:3.16.2, busybox, etc). Our story starts with systemd. Back in 2020, systemd a \"search .\" in stub resolvers if it detected the hostname to be a FQDN (to solve a separate problem). Check for a static hostname with . In , a change was made to Kubelet to propagate that \"search .\" into pods (to solve a separate DNS problem). That change landed in and appears in . Unfortunatey, musl based DNS resolvers struggle with this \"search .\" EDIT: details in musl-based DNS resolvers (depite their other quirks) should continue to function To see if you have a suitable repro node, check your (likely a symlink to . Next, start a container (any CNI) that makes some use of musl resolvers. Confirm that starting in Kubelet v1.25.0, the container now includes the \"search .\" if it was present on the host. Try using musl-based DNS resolution. Note that uses its own DNS resolver, its not a reproducer. Note also that pod-to-pod traffic and outbound masquerade are fine too. This is not a masquerade problem. Edit the in the container to remove the \".\" and your musl problems instantly disappear. Add the dot and they're back. I've been spelunking for a while. I can confirm this is not related to a specific CNI - flannel, Calico, and Cilium all reproduce the issue. Not networking related OpenShift is not affected. In 2021, RedHat folks noticed DNS \"breaks\" and reverted the systemd change on their OS cc <details</details<detailsThis isn't cloud provider specific. However, the most likely cases where folks use FQDN's are on-prem imo. So you're likely to see reports originating from there. </details<details</details<detailsThis was found while preparing Typhoon's v1.25.0 release of Kubernetes v1.25.0 </details<detailscontainerd 1.6.6 </details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nCould either revert (which propagates \"search .\" into containers) or find a different solution to the empty \"search \" problem it was trying to solve (does OpenShift even need that fix if they already ? cc A workaournd to problem is to configure hosts to strip \"search .\" from ala\nhas a great packet capture and this has been reported to musl\n/sig network /cc\nimpressive investigation in the linked issue , that seems to conclude that is a muslc bug, since it happens outside of Kubernetes too. Just reverting the PR in Kubernetes doesn't looks right, it fixed a known bug ... and this is really a muslc bug .... maybe always removing the single dot from ? I think that for Kubernetes we should understand first what does and means and its implications, maybe some developer can help? you know someone?\nIts discussed by the musl folks what means. It does not sound trivial to implement on the musl side, its a new case they did not anticipate supporting. Unfortunately this is subtle, and folks using alpine or related ecosystem things will get bitten and eventually end up here. I agree its a musl issue, but Kubelet now propagating triggers this I think its worth noting that did not set out to propagate , it was merely trying to prevent an empty . There may be better ways to achive that.\nIIUC means \"try the input name without any suffix\". Resolvers will do this ANYWAY, but it's implementation-defined whether they do it first or last or in parallel, so allowing lets node owners be explicit (though, curiously, it seems at least glibc may try the same name AGAIN at the end of the search list). This is pretty clearly a bug in MUSL, but I wonder if, instead of , we should have treated as rather than or the errant ? It nullifies the control that provides, but it wouldn't tickle musl like this.\n/cc I foresee a new wave of bug reports caused because of this muslc bug , better to keep CoreDNS friends in the loop\nThe patch for this got merged for the upcoming 1.25.1 and 1.26.", "positive_passages": [{"docid": "doc-en-kubernetes-ae112e7d66469272b6853db4c49475ee25e39731adafdf588b785ef59c546575", "text": "\"path/filepath\" \"strings\" <del> \"k8s.io/api/core/v1\" </del> <ins> v1 \"k8s.io/api/core/v1\" </ins> utilerrors \"k8s.io/apimachinery/pkg/util/errors\" utilvalidation \"k8s.io/apimachinery/pkg/util/validation\" utilfeature \"k8s.io/apiserver/pkg/util/feature\"", "commid": "kubernetes_pr_112157"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a1f837590f81f9849ac7605d8bd9eccee30ea8328192a45383fa25504691e30", "query": "This one involves systemd, DNS, musl, and Kubelet v1.25 Starting in v1.25.0, pods running on Kubelets on certain nodes with a FQDN hostname (more on that later) will not be able to resolve DNS queries if they're using musl (e.g. alpine:3.16.2, busybox, etc). Our story starts with systemd. Back in 2020, systemd a \"search .\" in stub resolvers if it detected the hostname to be a FQDN (to solve a separate problem). Check for a static hostname with . In , a change was made to Kubelet to propagate that \"search .\" into pods (to solve a separate DNS problem). That change landed in and appears in . Unfortunatey, musl based DNS resolvers struggle with this \"search .\" EDIT: details in musl-based DNS resolvers (depite their other quirks) should continue to function To see if you have a suitable repro node, check your (likely a symlink to . Next, start a container (any CNI) that makes some use of musl resolvers. Confirm that starting in Kubelet v1.25.0, the container now includes the \"search .\" if it was present on the host. Try using musl-based DNS resolution. Note that uses its own DNS resolver, its not a reproducer. Note also that pod-to-pod traffic and outbound masquerade are fine too. This is not a masquerade problem. Edit the in the container to remove the \".\" and your musl problems instantly disappear. Add the dot and they're back. I've been spelunking for a while. I can confirm this is not related to a specific CNI - flannel, Calico, and Cilium all reproduce the issue. Not networking related OpenShift is not affected. In 2021, RedHat folks noticed DNS \"breaks\" and reverted the systemd change on their OS cc <details</details<detailsThis isn't cloud provider specific. However, the most likely cases where folks use FQDN's are on-prem imo. So you're likely to see reports originating from there. </details<details</details<detailsThis was found while preparing Typhoon's v1.25.0 release of Kubernetes v1.25.0 </details<detailscontainerd 1.6.6 </details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nCould either revert (which propagates \"search .\" into containers) or find a different solution to the empty \"search \" problem it was trying to solve (does OpenShift even need that fix if they already ? cc A workaournd to problem is to configure hosts to strip \"search .\" from ala\nhas a great packet capture and this has been reported to musl\n/sig network /cc\nimpressive investigation in the linked issue , that seems to conclude that is a muslc bug, since it happens outside of Kubernetes too. Just reverting the PR in Kubernetes doesn't looks right, it fixed a known bug ... and this is really a muslc bug .... maybe always removing the single dot from ? I think that for Kubernetes we should understand first what does and means and its implications, maybe some developer can help? you know someone?\nIts discussed by the musl folks what means. It does not sound trivial to implement on the musl side, its a new case they did not anticipate supporting. Unfortunately this is subtle, and folks using alpine or related ecosystem things will get bitten and eventually end up here. I agree its a musl issue, but Kubelet now propagating triggers this I think its worth noting that did not set out to propagate , it was merely trying to prevent an empty . There may be better ways to achive that.\nIIUC means \"try the input name without any suffix\". Resolvers will do this ANYWAY, but it's implementation-defined whether they do it first or last or in parallel, so allowing lets node owners be explicit (though, curiously, it seems at least glibc may try the same name AGAIN at the end of the search list). This is pretty clearly a bug in MUSL, but I wonder if, instead of , we should have treated as rather than or the errant ? It nullifies the control that provides, but it wouldn't tickle musl like this.\n/cc I foresee a new wave of bug reports caused because of this muslc bug , better to keep CoreDNS friends in the loop\nThe patch for this got merged for the upcoming 1.25.1 and 1.26.", "positive_passages": [{"docid": "doc-en-kubernetes-6e250f2f1be06a9ababb78bbeacdf2d19afda965ca13191136434dea2c143988", "text": "searches = []string{} for _, s := range fields[1:] { if s != \".\" { <del> s = strings.TrimSuffix(s, \".\") </del> <ins> searches = append(searches, strings.TrimSuffix(s, \".\")) </ins> } <del> searches = append(searches, s) </del> } } if fields[0] == \"options\" {", "commid": "kubernetes_pr_112157"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a1f837590f81f9849ac7605d8bd9eccee30ea8328192a45383fa25504691e30", "query": "This one involves systemd, DNS, musl, and Kubelet v1.25 Starting in v1.25.0, pods running on Kubelets on certain nodes with a FQDN hostname (more on that later) will not be able to resolve DNS queries if they're using musl (e.g. alpine:3.16.2, busybox, etc). Our story starts with systemd. Back in 2020, systemd a \"search .\" in stub resolvers if it detected the hostname to be a FQDN (to solve a separate problem). Check for a static hostname with . In , a change was made to Kubelet to propagate that \"search .\" into pods (to solve a separate DNS problem). That change landed in and appears in . Unfortunatey, musl based DNS resolvers struggle with this \"search .\" EDIT: details in musl-based DNS resolvers (depite their other quirks) should continue to function To see if you have a suitable repro node, check your (likely a symlink to . Next, start a container (any CNI) that makes some use of musl resolvers. Confirm that starting in Kubelet v1.25.0, the container now includes the \"search .\" if it was present on the host. Try using musl-based DNS resolution. Note that uses its own DNS resolver, its not a reproducer. Note also that pod-to-pod traffic and outbound masquerade are fine too. This is not a masquerade problem. Edit the in the container to remove the \".\" and your musl problems instantly disappear. Add the dot and they're back. I've been spelunking for a while. I can confirm this is not related to a specific CNI - flannel, Calico, and Cilium all reproduce the issue. Not networking related OpenShift is not affected. In 2021, RedHat folks noticed DNS \"breaks\" and reverted the systemd change on their OS cc <details</details<detailsThis isn't cloud provider specific. However, the most likely cases where folks use FQDN's are on-prem imo. So you're likely to see reports originating from there. </details<details</details<detailsThis was found while preparing Typhoon's v1.25.0 release of Kubernetes v1.25.0 </details<detailscontainerd 1.6.6 </details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nCould either revert (which propagates \"search .\" into containers) or find a different solution to the empty \"search \" problem it was trying to solve (does OpenShift even need that fix if they already ? cc A workaournd to problem is to configure hosts to strip \"search .\" from ala\nhas a great packet capture and this has been reported to musl\n/sig network /cc\nimpressive investigation in the linked issue , that seems to conclude that is a muslc bug, since it happens outside of Kubernetes too. Just reverting the PR in Kubernetes doesn't looks right, it fixed a known bug ... and this is really a muslc bug .... maybe always removing the single dot from ? I think that for Kubernetes we should understand first what does and means and its implications, maybe some developer can help? you know someone?\nIts discussed by the musl folks what means. It does not sound trivial to implement on the musl side, its a new case they did not anticipate supporting. Unfortunately this is subtle, and folks using alpine or related ecosystem things will get bitten and eventually end up here. I agree its a musl issue, but Kubelet now propagating triggers this I think its worth noting that did not set out to propagate , it was merely trying to prevent an empty . There may be better ways to achive that.\nIIUC means \"try the input name without any suffix\". Resolvers will do this ANYWAY, but it's implementation-defined whether they do it first or last or in parallel, so allowing lets node owners be explicit (though, curiously, it seems at least glibc may try the same name AGAIN at the end of the search list). This is pretty clearly a bug in MUSL, but I wonder if, instead of , we should have treated as rather than or the errant ? It nullifies the control that provides, but it wouldn't tickle musl like this.\n/cc I foresee a new wave of bug reports caused because of this muslc bug , better to keep CoreDNS friends in the loop\nThe patch for this got merged for the upcoming 1.25.1 and 1.26.", "positive_passages": [{"docid": "doc-en-kubernetes-082206c81b1f5b03de212e0f2186b7097979a323be3e06f2497b019c7cc287c9", "text": "{\"nameserver t 1.2.3.4\", []string{\"1.2.3.4\"}, []string{}, []string{}, false}, {\"nameserver 1.2.3.4nnameserver 5.6.7.8\", []string{\"1.2.3.4\", \"5.6.7.8\"}, []string{}, []string{}, false}, {\"nameserver 1.2.3.4 #comment\", []string{\"1.2.3.4\"}, []string{}, []string{}, false}, <del> {\"search \", []string{}, []string{}, []string{}, false}, // search empty {\"search .\", []string{}, []string{\".\"}, []string{}, false}, </del> <ins> {\"search \", []string{}, []string{}, []string{}, false},  // search empty {\"search .\", []string{}, []string{}, []string{}, false}, // ignore lone dot {\"search . foo\", []string{}, []string{\"foo\"}, []string{}, false}, {\"search foo .\", []string{}, []string{\"foo\"}, []string{}, false}, {\"search foo .  bar\", []string{}, []string{\"foo\", \"bar\"}, []string{}, false}, </ins> {\"search foo\", []string{}, []string{\"foo\"}, []string{}, false}, {\"search foo bar\", []string{}, []string{\"foo\", \"bar\"}, []string{}, false}, {\"search foo. bar\", []string{}, []string{\"foo\", \"bar\"}, []string{}, false},", "commid": "kubernetes_pr_112157"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9749eb152fe9034471d7606d65c1d581b51dd64e96b9b33d9a702d9b22cce3f4", "query": "adds new version for in 1.26. For 1.26, we are setting the storage version to because vN-1 understands that level. In 1.27, we should change the storage version from to .\n/sig api-machinery\n/cc\n/cc\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-00b2e9293e8a57e274a2be9213827dda471a10149cdedb86992e6ada9e77ccf2", "text": "utilruntime.Must(flowcontrolv1beta1.AddToScheme(scheme)) utilruntime.Must(flowcontrolv1beta2.AddToScheme(scheme)) utilruntime.Must(flowcontrolv1beta3.AddToScheme(scheme)) <del> // TODO(#112512): This controls serialization order, for 1.26, we can //  set the serialization version to v1beta2 because vN-1 understands that //  level. In 1.27, we should set the serialization version to v1beta3. utilruntime.Must(scheme.SetVersionPriority(flowcontrolv1beta2.SchemeGroupVersion, flowcontrolv1beta3.SchemeGroupVersion, </del> <ins> utilruntime.Must(scheme.SetVersionPriority(flowcontrolv1beta3.SchemeGroupVersion, flowcontrolv1beta2.SchemeGroupVersion, </ins> flowcontrolv1beta1.SchemeGroupVersion, flowcontrolv1alpha1.SchemeGroupVersion)) }", "commid": "kubernetes_pr_114492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9749eb152fe9034471d7606d65c1d581b51dd64e96b9b33d9a702d9b22cce3f4", "query": "adds new version for in 1.26. For 1.26, we are setting the storage version to because vN-1 understands that level. In 1.27, we should change the storage version from to .\n/sig api-machinery\n/cc\n/cc\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-3fe5b93ab821157e0616cc0256043635c5b5289c728214eb737b047f84a86548", "text": "\"admissionregistration.k8s.io/v1/mutatingwebhookconfigurations\":    \"Sqi0GUgDaX0=\", \"admissionregistration.k8s.io/v1/validatingwebhookconfigurations\":  \"B0wHjQmsGNk=\", \"events.k8s.io/v1/events\":                                          \"r2yiGXH7wu8=\", <del> \"flowcontrol.apiserver.k8s.io/v1beta3/flowschemas\":                 \"G+8IkrqFuJw=\", \"flowcontrol.apiserver.k8s.io/v1beta3/prioritylevelconfigurations\": \"wltM4WMeeXs=\", \"flowcontrol.apiserver.k8s.io/v1beta2/flowschemas\":                 \"G+8IkrqFuJw=\", \"flowcontrol.apiserver.k8s.io/v1beta2/prioritylevelconfigurations\": \"wltM4WMeeXs=\", </del> <ins> \"flowcontrol.apiserver.k8s.io/v1beta3/flowschemas\":                 \"9NnFrw7ZEmA=\", \"flowcontrol.apiserver.k8s.io/v1beta3/prioritylevelconfigurations\": \"+CwSrEWTDhc=\", \"flowcontrol.apiserver.k8s.io/v1beta2/flowschemas\":                 \"9NnFrw7ZEmA=\", \"flowcontrol.apiserver.k8s.io/v1beta2/prioritylevelconfigurations\": \"+CwSrEWTDhc=\", </ins> }", "commid": "kubernetes_pr_114492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9749eb152fe9034471d7606d65c1d581b51dd64e96b9b33d9a702d9b22cce3f4", "query": "adds new version for in 1.26. For 1.26, we are setting the storage version to because vN-1 understands that level. In 1.27, we should change the storage version from to .\n/sig api-machinery\n/cc\n/cc\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-0e741408572a3beda86e2d49e8f986f1ff77d4b2e07f814b9c7f3128756840ce", "text": "gvr(\"flowcontrol.apiserver.k8s.io\", \"v1alpha1\", \"flowschemas\"): { Stub:             `{\"metadata\": {\"name\": \"va1\"}, \"spec\": {\"priorityLevelConfiguration\": {\"name\": \"name1\"}}}`, ExpectedEtcdPath: \"/registry/flowschemas/va1\", <del> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta2\", \"FlowSchema\"), </del> <ins> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta3\", \"FlowSchema\"), </ins> }, // --", "commid": "kubernetes_pr_114492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9749eb152fe9034471d7606d65c1d581b51dd64e96b9b33d9a702d9b22cce3f4", "query": "adds new version for in 1.26. For 1.26, we are setting the storage version to because vN-1 understands that level. In 1.27, we should change the storage version from to .\n/sig api-machinery\n/cc\n/cc\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-2e9a9dc29a72657b31d3afc6452288cc51ae11af9cfac87b4d5dc851420cf3cc", "text": "gvr(\"flowcontrol.apiserver.k8s.io\", \"v1alpha1\", \"prioritylevelconfigurations\"): { Stub:             `{\"metadata\": {\"name\": \"conf1\"}, \"spec\": {\"type\": \"Limited\", \"limited\": {\"assuredConcurrencyShares\":3, \"limitResponse\": {\"type\": \"Reject\"}}}}`, ExpectedEtcdPath: \"/registry/prioritylevelconfigurations/conf1\", <del> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta2\", \"PriorityLevelConfiguration\"), </del> <ins> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta3\", \"PriorityLevelConfiguration\"), </ins> }, // --", "commid": "kubernetes_pr_114492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9749eb152fe9034471d7606d65c1d581b51dd64e96b9b33d9a702d9b22cce3f4", "query": "adds new version for in 1.26. For 1.26, we are setting the storage version to because vN-1 understands that level. In 1.27, we should change the storage version from to .\n/sig api-machinery\n/cc\n/cc\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-d2863f3591ef6e3c28166078afe570f66b659e51237d1e03f63fcfcc8c265a4a", "text": "gvr(\"flowcontrol.apiserver.k8s.io\", \"v1beta1\", \"flowschemas\"): { Stub:             `{\"metadata\": {\"name\": \"va2\"}, \"spec\": {\"priorityLevelConfiguration\": {\"name\": \"name1\"}}}`, ExpectedEtcdPath: \"/registry/flowschemas/va2\", <del> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta2\", \"FlowSchema\"), </del> <ins> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta3\", \"FlowSchema\"), </ins> }, // --", "commid": "kubernetes_pr_114492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9749eb152fe9034471d7606d65c1d581b51dd64e96b9b33d9a702d9b22cce3f4", "query": "adds new version for in 1.26. For 1.26, we are setting the storage version to because vN-1 understands that level. In 1.27, we should change the storage version from to .\n/sig api-machinery\n/cc\n/cc\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-94066cf3a30600c69e2e38ee51e0c40d2992ecc70a1e438a75844ff31934e2f7", "text": "gvr(\"flowcontrol.apiserver.k8s.io\", \"v1beta1\", \"prioritylevelconfigurations\"): { Stub:             `{\"metadata\": {\"name\": \"conf2\"}, \"spec\": {\"type\": \"Limited\", \"limited\": {\"assuredConcurrencyShares\":3, \"limitResponse\": {\"type\": \"Reject\"}}}}`, ExpectedEtcdPath: \"/registry/prioritylevelconfigurations/conf2\", <del> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta2\", \"PriorityLevelConfiguration\"), </del> <ins> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta3\", \"PriorityLevelConfiguration\"), </ins> }, // --", "commid": "kubernetes_pr_114492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9749eb152fe9034471d7606d65c1d581b51dd64e96b9b33d9a702d9b22cce3f4", "query": "adds new version for in 1.26. For 1.26, we are setting the storage version to because vN-1 understands that level. In 1.27, we should change the storage version from to .\n/sig api-machinery\n/cc\n/cc\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-34675e0525f6941e43a27e393b161a2472dcff9acc23b8b5133ebc376d5332b4", "text": "gvr(\"flowcontrol.apiserver.k8s.io\", \"v1beta2\", \"flowschemas\"): { Stub:             `{\"metadata\": {\"name\": \"fs-1\"}, \"spec\": {\"priorityLevelConfiguration\": {\"name\": \"name1\"}}}`, ExpectedEtcdPath: \"/registry/flowschemas/fs-1\", <ins> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta3\", \"FlowSchema\"), </ins> }, // --", "commid": "kubernetes_pr_114492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9749eb152fe9034471d7606d65c1d581b51dd64e96b9b33d9a702d9b22cce3f4", "query": "adds new version for in 1.26. For 1.26, we are setting the storage version to because vN-1 understands that level. In 1.27, we should change the storage version from to .\n/sig api-machinery\n/cc\n/cc\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-a540f2466de949b471e4d91d42572e7d4b8ea534c17584e49720de9349d373d6", "text": "gvr(\"flowcontrol.apiserver.k8s.io\", \"v1beta2\", \"prioritylevelconfigurations\"): { Stub:             `{\"metadata\": {\"name\": \"conf3\"}, \"spec\": {\"type\": \"Limited\", \"limited\": {\"assuredConcurrencyShares\":3, \"limitResponse\": {\"type\": \"Reject\"}}}}`, ExpectedEtcdPath: \"/registry/prioritylevelconfigurations/conf3\", <ins> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta3\", \"PriorityLevelConfiguration\"), </ins> }, // --", "commid": "kubernetes_pr_114492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9749eb152fe9034471d7606d65c1d581b51dd64e96b9b33d9a702d9b22cce3f4", "query": "adds new version for in 1.26. For 1.26, we are setting the storage version to because vN-1 understands that level. In 1.27, we should change the storage version from to .\n/sig api-machinery\n/cc\n/cc\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-95dbd7c60e06d53681fbe8686dd363fd7000ad3e78afd2015f7c1691a642e646", "text": "gvr(\"flowcontrol.apiserver.k8s.io\", \"v1beta3\", \"flowschemas\"): { Stub:             `{\"metadata\": {\"name\": \"fs-2\"}, \"spec\": {\"priorityLevelConfiguration\": {\"name\": \"name1\"}}}`, ExpectedEtcdPath: \"/registry/flowschemas/fs-2\", <del> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta2\", \"FlowSchema\"), </del> }, // --", "commid": "kubernetes_pr_114492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9749eb152fe9034471d7606d65c1d581b51dd64e96b9b33d9a702d9b22cce3f4", "query": "adds new version for in 1.26. For 1.26, we are setting the storage version to because vN-1 understands that level. In 1.27, we should change the storage version from to .\n/sig api-machinery\n/cc\n/cc\n/triage accepted\nThe Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:", "positive_passages": [{"docid": "doc-en-kubernetes-0951d1a2e69b06311eb321f421ade492f91733369cb517912840046b047e2565", "text": "gvr(\"flowcontrol.apiserver.k8s.io\", \"v1beta3\", \"prioritylevelconfigurations\"): { Stub:             `{\"metadata\": {\"name\": \"conf4\"}, \"spec\": {\"type\": \"Limited\", \"limited\": {\"nominalConcurrencyShares\":3, \"limitResponse\": {\"type\": \"Reject\"}}}}`, ExpectedEtcdPath: \"/registry/prioritylevelconfigurations/conf4\", <del> ExpectedGVK:      gvkP(\"flowcontrol.apiserver.k8s.io\", \"v1beta2\", \"PriorityLevelConfiguration\"), </del> }, // --", "commid": "kubernetes_pr_114492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e83118de03d0fe14a8145255f936afcefd6219ebb776fa0fe02b7cedc1c13ef", "query": "Upgraded from Kubernetes v1.25.0 to v1.25.1. Standard metrics-server deployment now causes the following message to appear in the kube-apiserver logs on a recurring basis: Adding a quick hack debug Infof print shows: It appears that the apiserver is sending an If-None-Match cache control header when refreshing the openapi spec, and the metrics-server service is correctly responding with a 304 Not Modified. No errors logged; proper refresh of OpenAPI specs Deploy metrics-server, or any other service that uses apiserver aggregation and honors caching headers such as , to a Kubernetes 1.25.1 cluster. made bad assumptions; not all HTTP 3XX responses are redirects. It should probably only reject the response if it is 300-399 AND the header is set. <details</detailsnone <details</detailsk3s containerd flannel\nTaking a stab at some tags here... /cc /cc /cc /area apiserver /sig api-machinery\nthanks for the report, looks like this should be /priority critical-urgent /kind regression cc since this requires a respin of a final 1.22 patch release :-/\nFix open in , will get cherry-picks open to start greening up CI\n/triage accepted\nI need to make a redirect to the external URL but it's not allowed :(", "positive_passages": [{"docid": "doc-en-kubernetes-1beecfa7407c2c19191a25dccc03e7283f658e62c9f0f863fbea672103132515", "text": "oldModifyResponse := proxy.ModifyResponse proxy.ModifyResponse = func(response *http.Response) error { code := response.StatusCode <del> if code >= 300 && code <= 399 { </del> <ins> if code >= 300 && code <= 399 && len(response.Header.Get(\"Location\")) > 0 { </ins> // close the original response response.Body.Close() msg := \"the backend attempted to redirect this request, which is not permitted\"", "commid": "kubernetes_pr_112526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e83118de03d0fe14a8145255f936afcefd6219ebb776fa0fe02b7cedc1c13ef", "query": "Upgraded from Kubernetes v1.25.0 to v1.25.1. Standard metrics-server deployment now causes the following message to appear in the kube-apiserver logs on a recurring basis: Adding a quick hack debug Infof print shows: It appears that the apiserver is sending an If-None-Match cache control header when refreshing the openapi spec, and the metrics-server service is correctly responding with a 304 Not Modified. No errors logged; proper refresh of OpenAPI specs Deploy metrics-server, or any other service that uses apiserver aggregation and honors caching headers such as , to a Kubernetes 1.25.1 cluster. made bad assumptions; not all HTTP 3XX responses are redirects. It should probably only reject the response if it is 300-399 AND the header is set. <details</detailsnone <details</detailsk3s containerd flannel\nTaking a stab at some tags here... /cc /cc /cc /area apiserver /sig api-machinery\nthanks for the report, looks like this should be /priority critical-urgent /kind regression cc since this requires a respin of a final 1.22 patch release :-/\nFix open in , will get cherry-picks open to start greening up CI\n/triage accepted\nI need to make a redirect to the external URL but it's not allowed :(", "positive_passages": [{"docid": "doc-en-kubernetes-bf3dce4ea8f9b88906ca841aee45fc57d9a24ee565d3ec737092e166edf6299e", "text": "name                      string rejectForwardingRedirects bool serverStatusCode          int <ins> redirect                  string </ins> expectStatusCode          int expectBody                []byte }{", "commid": "kubernetes_pr_112526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e83118de03d0fe14a8145255f936afcefd6219ebb776fa0fe02b7cedc1c13ef", "query": "Upgraded from Kubernetes v1.25.0 to v1.25.1. Standard metrics-server deployment now causes the following message to appear in the kube-apiserver logs on a recurring basis: Adding a quick hack debug Infof print shows: It appears that the apiserver is sending an If-None-Match cache control header when refreshing the openapi spec, and the metrics-server service is correctly responding with a 304 Not Modified. No errors logged; proper refresh of OpenAPI specs Deploy metrics-server, or any other service that uses apiserver aggregation and honors caching headers such as , to a Kubernetes 1.25.1 cluster. made bad assumptions; not all HTTP 3XX responses are redirects. It should probably only reject the response if it is 300-399 AND the header is set. <details</detailsnone <details</detailsk3s containerd flannel\nTaking a stab at some tags here... /cc /cc /cc /area apiserver /sig api-machinery\nthanks for the report, looks like this should be /priority critical-urgent /kind regression cc since this requires a respin of a final 1.22 patch release :-/\nFix open in , will get cherry-picks open to start greening up CI\n/triage accepted\nI need to make a redirect to the external URL but it's not allowed :(", "positive_passages": [{"docid": "doc-en-kubernetes-999c692a854de3c692a05cc415367d5758a756aef79818d3d862232c7822f553", "text": "name:                      \"reject redirection enabled in proxy, backend server sending 301 response\", rejectForwardingRedirects: true, serverStatusCode:          301, <ins> redirect:                  \"/\", </ins> expectStatusCode:          502, expectBody:                []byte(`the backend attempted to redirect this request, which is not permitted`), }, { <ins> name:                      \"reject redirection enabled in proxy, backend server sending 304 response with a location header\", rejectForwardingRedirects: true, serverStatusCode:          304, redirect:                  \"/\", expectStatusCode:          502, expectBody:                []byte(`the backend attempted to redirect this request, which is not permitted`), }, { name:                      \"reject redirection enabled in proxy, backend server sending 304 response with no location header\", rejectForwardingRedirects: true, serverStatusCode:          304, expectStatusCode:          304, expectBody:                []byte{}, // client doesn't read the body for 304 responses }, { </ins> name:                      \"reject redirection disabled in proxy, backend server sending 200 response\", rejectForwardingRedirects: false, serverStatusCode:          200,", "commid": "kubernetes_pr_112526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e83118de03d0fe14a8145255f936afcefd6219ebb776fa0fe02b7cedc1c13ef", "query": "Upgraded from Kubernetes v1.25.0 to v1.25.1. Standard metrics-server deployment now causes the following message to appear in the kube-apiserver logs on a recurring basis: Adding a quick hack debug Infof print shows: It appears that the apiserver is sending an If-None-Match cache control header when refreshing the openapi spec, and the metrics-server service is correctly responding with a 304 Not Modified. No errors logged; proper refresh of OpenAPI specs Deploy metrics-server, or any other service that uses apiserver aggregation and honors caching headers such as , to a Kubernetes 1.25.1 cluster. made bad assumptions; not all HTTP 3XX responses are redirects. It should probably only reject the response if it is 300-399 AND the header is set. <details</detailsnone <details</detailsk3s containerd flannel\nTaking a stab at some tags here... /cc /cc /cc /area apiserver /sig api-machinery\nthanks for the report, looks like this should be /priority critical-urgent /kind regression cc since this requires a respin of a final 1.22 patch release :-/\nFix open in , will get cherry-picks open to start greening up CI\n/triage accepted\nI need to make a redirect to the external URL but it's not allowed :(", "positive_passages": [{"docid": "doc-en-kubernetes-adffc7be632442e548c7f8750d76cc38ecd4300e98f50ed403e231dd5364f7e2", "text": "name:                      \"reject redirection disabled in proxy, backend server sending 301 response\", rejectForwardingRedirects: false, serverStatusCode:          301, <ins> redirect:                  \"/\", </ins> expectStatusCode:          301, expectBody:                originalBody, },", "commid": "kubernetes_pr_112526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3e83118de03d0fe14a8145255f936afcefd6219ebb776fa0fe02b7cedc1c13ef", "query": "Upgraded from Kubernetes v1.25.0 to v1.25.1. Standard metrics-server deployment now causes the following message to appear in the kube-apiserver logs on a recurring basis: Adding a quick hack debug Infof print shows: It appears that the apiserver is sending an If-None-Match cache control header when refreshing the openapi spec, and the metrics-server service is correctly responding with a 304 Not Modified. No errors logged; proper refresh of OpenAPI specs Deploy metrics-server, or any other service that uses apiserver aggregation and honors caching headers such as , to a Kubernetes 1.25.1 cluster. made bad assumptions; not all HTTP 3XX responses are redirects. It should probably only reject the response if it is 300-399 AND the header is set. <details</detailsnone <details</detailsk3s containerd flannel\nTaking a stab at some tags here... /cc /cc /cc /area apiserver /sig api-machinery\nthanks for the report, looks like this should be /priority critical-urgent /kind regression cc since this requires a respin of a final 1.22 patch release :-/\nFix open in , will get cherry-picks open to start greening up CI\n/triage accepted\nI need to make a redirect to the external URL but it's not allowed :(", "positive_passages": [{"docid": "doc-en-kubernetes-2b818ef8062aa1e229b5e7f3e40aad6b3efc2aa959402c488c77f5aeeba5ec57", "text": "t.Run(tc.name, func(t *testing.T) { // Set up a backend server backendServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { <ins> if tc.redirect != \"\" { w.Header().Set(\"Location\", tc.redirect) } </ins> w.WriteHeader(tc.serverStatusCode) w.Write(originalBody) }))", "commid": "kubernetes_pr_112526"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-2fe80e49aa5ae53d41f8add8e37445a19adaf3497eeef8427dfc711a0635077f", "query": "When a Pod admission fails due to node-pressure condition then the Pod's looks like this: \"Pod The node had condition: [DiskPressure].\" The \"Pod The node...\" reads awkward. A message like: \"The node had condition: [DiskPressure].\". a job with a pod on a single node cluster, when the node is under disk pressure (then it is tainted with ). The Pod gets stuck in the phase. the node by kubectl command line: Pod is scheduled but admission by Kubelet fails as the taint is re- shortly after its manual removal. Then, the status of the Pod contains the awkward message. No response <details</details<detailsReproducible on kind </details<details</details<details</details<details</details<details</details\n/sig node /triage accepted /priority backlog\nThe first part () is returned here: . I wonder where the is being appended to the beginning. It's my first try to contribute, so I am a little bit lost.\nI think this is a candidate place which might be responsible for the prefix (but haven't checked): I would suggest you to try to reproduce the issue locally first then experiment with modifying the code.\n/assign\nthanks, I've managed to reproduce and used Delve to make sure who's responsible. I opened the changing the message. If it's accepted it will change to .", "positive_passages": [{"docid": "doc-en-kubernetes-b673eb1d3d8e084cea9a49aaba0f3560f26929320ad24528bd15a1b743b8997d", "text": "kl.statusManager.SetPodStatus(pod, v1.PodStatus{ Phase:   v1.PodFailed, Reason:  reason, <del> Message: \"Pod \" + message}) </del> <ins> Message: \"Pod was rejected: \" + message}) </ins> } // canAdmitPod determines if a pod can be admitted, and gives a reason if it", "commid": "kubernetes_pr_112644"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ce0e421c34eed98860db911d5d334cd66db99e26a231af53f976763de79a714f", "query": "A common pattern in Kubernetes (both internally and in third party usage) is something like: (this is from the ). This is commonly called at a fairly high rate; in our case we would actually end up seeing this account for significant portions of CPU/memory to compute the and run on it. In our controller, as an optimization, we replaced usage of and just used our own simpler label matching code, leading to a 70% speed up in our function (which does more than just match) and 96% allocation size improvement; see I believe similar could be done in Kubernetes directly by having a specialized Selector implementation for simple labels. This would transparently given substantial performance benefits to anyone using the library\n/sig api-machinery\nis the change here a new kind of selector matching or a tweak to something existing? It's hard to tell if this is proposing a new design to partition types of selectors that needs a kep versus a perf tweak to existing code that is straight-forward.\nThe proposal is an internal performance improvement to make a specialized implementation of the selector matching internally. So two concrete implementations for 1 shared interface. is a PoC of this. I think it can be extended (by me, or others if someone wants to) to complete it\nWe discussed this one during our bug triage. There seemed to be the feeling that this is large enough to need a KEP? Would you be up for that? Additionally you could bring it up in our SIG meeting to socialize / discuss it more if you wanted.\nThe patch shared in helps to explain, it's a lot smaller than the description made it sound. This is a special case for equality-only selectors. Probably still worth bringing up at a sig-meeting, but if if the patch is a good representation, it is more bounded than expected from the issue description.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-f8ad730ece4cc4a91ed2c249c539decb88588fa7cae6bc80f278b3d960482b9d", "text": "// perform any validation. // According to our measurements this is significantly faster // in codepaths that matter at high scale. <ins> // Note: this method copies the Set; if the Set is immutable, consider wrapping it with ValidatedSetSelector // instead, which does not copy. </ins> func (ls Set) AsSelectorPreValidated() Selector { return SelectorFromValidatedSet(ls) }", "commid": "kubernetes_pr_112648"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ce0e421c34eed98860db911d5d334cd66db99e26a231af53f976763de79a714f", "query": "A common pattern in Kubernetes (both internally and in third party usage) is something like: (this is from the ). This is commonly called at a fairly high rate; in our case we would actually end up seeing this account for significant portions of CPU/memory to compute the and run on it. In our controller, as an optimization, we replaced usage of and just used our own simpler label matching code, leading to a 70% speed up in our function (which does more than just match) and 96% allocation size improvement; see I believe similar could be done in Kubernetes directly by having a specialized Selector implementation for simple labels. This would transparently given substantial performance benefits to anyone using the library\n/sig api-machinery\nis the change here a new kind of selector matching or a tweak to something existing? It's hard to tell if this is proposing a new design to partition types of selectors that needs a kep versus a perf tweak to existing code that is straight-forward.\nThe proposal is an internal performance improvement to make a specialized implementation of the selector matching internally. So two concrete implementations for 1 shared interface. is a PoC of this. I think it can be extended (by me, or others if someone wants to) to complete it\nWe discussed this one during our bug triage. There seemed to be the feeling that this is large enough to need a KEP? Would you be up for that? Additionally you could bring it up in our SIG meeting to socialize / discuss it more if you wanted.\nThe patch shared in helps to explain, it's a lot smaller than the description made it sound. This is a special case for equality-only selectors. Probably still worth bringing up at a sig-meeting, but if if the patch is a good representation, it is more bounded than expected from the issue description.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-53e595ea5e3aa0e3c81b389b27567ad82863b6e968d4a2c96bc2d8dad3cef9dd", "text": "// SelectorFromValidatedSet returns a Selector which will match exactly the given Set. // A nil and empty Sets are considered equivalent to Everything(). // It assumes that Set is already validated and doesn't do any validation. <ins> // Note: this method copies the Set; if the Set is immutable, consider wrapping it with ValidatedSetSelector // instead, which does not copy. </ins> func SelectorFromValidatedSet(ls Set) Selector { if ls == nil || len(ls) == 0 { return internalSelector{}", "commid": "kubernetes_pr_112648"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ce0e421c34eed98860db911d5d334cd66db99e26a231af53f976763de79a714f", "query": "A common pattern in Kubernetes (both internally and in third party usage) is something like: (this is from the ). This is commonly called at a fairly high rate; in our case we would actually end up seeing this account for significant portions of CPU/memory to compute the and run on it. In our controller, as an optimization, we replaced usage of and just used our own simpler label matching code, leading to a 70% speed up in our function (which does more than just match) and 96% allocation size improvement; see I believe similar could be done in Kubernetes directly by having a specialized Selector implementation for simple labels. This would transparently given substantial performance benefits to anyone using the library\n/sig api-machinery\nis the change here a new kind of selector matching or a tweak to something existing? It's hard to tell if this is proposing a new design to partition types of selectors that needs a kep versus a perf tweak to existing code that is straight-forward.\nThe proposal is an internal performance improvement to make a specialized implementation of the selector matching internally. So two concrete implementations for 1 shared interface. is a PoC of this. I think it can be extended (by me, or others if someone wants to) to complete it\nWe discussed this one during our bug triage. There seemed to be the feeling that this is large enough to need a KEP? Would you be up for that? Additionally you could bring it up in our SIG meeting to socialize / discuss it more if you wanted.\nThe patch shared in helps to explain, it's a lot smaller than the description made it sound. This is a special case for equality-only selectors. Probably still worth bringing up at a sig-meeting, but if if the patch is a good representation, it is more bounded than expected from the issue description.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-43957c1d625b90c4fa64785b3f5578395dc84fedcc58b86ec5e48488f141dbcb", "text": "func ParseToRequirements(selector string, opts ...field.PathOption) ([]Requirement, error) { return parse(selector, field.ToPath(opts...)) } <ins> // ValidatedSetSelector wraps a Set, allowing it to implement the Selector interface. Unlike // Set.AsSelectorPreValidated (which copies the input Set), this type simply wraps the underlying // Set. As a result, it is substantially more efficient. A nil and empty Sets are considered // equivalent to Everything(). // // Callers MUST ensure the underlying Set is not mutated, and that it is already validated. If these // constraints are not met, Set.AsValidatedSelector should be preferred // // None of the Selector methods mutate the underlying Set, but Add() and Requirements() convert to // the less optimized version. type ValidatedSetSelector Set func (s ValidatedSetSelector) Matches(labels Labels) bool { for k, v := range s { if !labels.Has(k) || v != labels.Get(k) { return false } } return true } func (s ValidatedSetSelector) Empty() bool { return len(s) == 0 } func (s ValidatedSetSelector) String() string { keys := make([]string, 0, len(s)) for k := range s { keys = append(keys, k) } // Ensure deterministic output sort.Strings(keys) b := strings.Builder{} for i, key := range keys { v := s[key] b.Grow(len(key) + 2 + len(v)) if i != 0 { b.WriteString(\",\") } b.WriteString(key) b.WriteString(\"=\") b.WriteString(v) } return b.String() } func (s ValidatedSetSelector) Add(r ...Requirement) Selector { return s.toFullSelector().Add(r...) } func (s ValidatedSetSelector) Requirements() (requirements Requirements, selectable bool) { return s.toFullSelector().Requirements() } func (s ValidatedSetSelector) DeepCopySelector() Selector { res := make(ValidatedSetSelector, len(s)) for k, v := range s { res[k] = v } return res } func (s ValidatedSetSelector) RequiresExactMatch(label string) (value string, found bool) { v, f := s[label] return v, f } func (s ValidatedSetSelector) toFullSelector() Selector { return SelectorFromValidatedSet(Set(s)) } var _ Selector = ValidatedSetSelector{} </ins>", "commid": "kubernetes_pr_112648"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ce0e421c34eed98860db911d5d334cd66db99e26a231af53f976763de79a714f", "query": "A common pattern in Kubernetes (both internally and in third party usage) is something like: (this is from the ). This is commonly called at a fairly high rate; in our case we would actually end up seeing this account for significant portions of CPU/memory to compute the and run on it. In our controller, as an optimization, we replaced usage of and just used our own simpler label matching code, leading to a 70% speed up in our function (which does more than just match) and 96% allocation size improvement; see I believe similar could be done in Kubernetes directly by having a specialized Selector implementation for simple labels. This would transparently given substantial performance benefits to anyone using the library\n/sig api-machinery\nis the change here a new kind of selector matching or a tweak to something existing? It's hard to tell if this is proposing a new design to partition types of selectors that needs a kep versus a perf tweak to existing code that is straight-forward.\nThe proposal is an internal performance improvement to make a specialized implementation of the selector matching internally. So two concrete implementations for 1 shared interface. is a PoC of this. I think it can be extended (by me, or others if someone wants to) to complete it\nWe discussed this one during our bug triage. There seemed to be the feeling that this is large enough to need a KEP? Would you be up for that? Additionally you could bring it up in our SIG meeting to socialize / discuss it more if you wanted.\nThe patch shared in helps to explain, it's a lot smaller than the description made it sound. This is a special case for equality-only selectors. Probably still worth bringing up at a sig-meeting, but if if the patch is a good representation, it is more bounded than expected from the issue description.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-9a8d3291d84e2ef64ea0b6a45408ce2ebbe2376d53d830150abe75136498aa98", "text": "\"foo\": \"foo\", \"bar\": \"bar\", } <ins> matchee := Set(map[string]string{ \"foo\":   \"foo\", \"bar\":   \"bar\", \"extra\": \"label\", }) </ins> for i := 0; i < b.N; i++ { <del> if SelectorFromValidatedSet(set).Empty() { </del> <ins> s := SelectorFromValidatedSet(set) if s.Empty() { </ins> b.Errorf(\"Unexpected selector\") } <ins> if !s.Matches(matchee) { b.Errorf(\"Unexpected match\") } } } func BenchmarkSetSelector(b *testing.B) { set := map[string]string{ \"foo\": \"foo\", \"bar\": \"bar\", } matchee := Set(map[string]string{ \"foo\":   \"foo\", \"bar\":   \"bar\", \"extra\": \"label\", }) for i := 0; i < b.N; i++ { s := ValidatedSetSelector(set) if s.Empty() { b.Errorf(\"Unexpected selector\") } if !s.Matches(matchee) { b.Errorf(\"Unexpected match\") } } } func TestSetSelectorString(t *testing.T) { cases := []struct { set Set out string }{ { Set{}, \"\", }, { Set{\"app\": \"foo\"}, \"app=foo\", }, { Set{\"app\": \"foo\", \"a\": \"b\"}, \"a=b,app=foo\", }, } for _, tt := range cases { t.Run(tt.out, func(t *testing.T) { if got := ValidatedSetSelector(tt.set).String(); tt.out != got { t.Fatalf(\"expected %v, got %v\", tt.out, got) } }) </ins> } }", "commid": "kubernetes_pr_112648"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4de8d19fa7577b91e9d20fe50de242313fdcfa4e902ab568769fed1654a59ef", "query": "Created limit range object with this parameters then tried to create this pod got message: Error from server (Invalid): error when creating \"pod-to-be-\": Pod \"nginx-to-be-removed-4\" is invalid: spec.containers[0].resources.requests: Invalid value: \"700m\": must be less than or equal to cpu limit Pod should be created with Requests & Limits of cpu equal to 700m (since it is in range of min/max cpu limitrange object) create limitrange object and pod as in description No response <details</details<detailson premise/AKS </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nYou have a default CPU limit of 10m, and no explicit CPU limit on the container, but a request larger than the limit. The request must always be less than or equal to the limit. Your pod needs to also set a higher limit, or the limit range needs to not set a default limit.\n/remove-kind bug /kind support\n/cc\nbut this is not obvious behavior since there is min & max set in limit range. This is limits (not min/max) that should be overwritten by pod. limits should be set to requests in this case imho\nlimit range limits what the user can set, it doesn't perform any mutations other than the defaulting and doesn't claim to. Min/max enforce that pods cannot set higher / lower. The default ensures that if the pod doesn't set a limit it will have one. personally I would remove the default limit, especially at 10m, this will aggressively limit pods. it would be, if the pod set a limit that would be a substantial breaking change, I don't think we could do that short of a v2 API and I'm not sure it would be correct behavior even then. we could make it opt-in, but then, why not just set them to match on the pod to begin with?", "positive_passages": [{"docid": "doc-en-kubernetes-a9e3475ae74f6a4e5849e2c67032de9c729aa5ba7bd290faed341d741dc80a1f", "text": "\"fmt\" \"strings\" <del> \"k8s.io/api/core/v1\" </del> <ins> v1 \"k8s.io/api/core/v1\" </ins> \"k8s.io/apimachinery/pkg/api/resource\" \"k8s.io/apimachinery/pkg/util/sets\" \"k8s.io/apimachinery/pkg/util/validation/field\"", "commid": "kubernetes_pr_112925"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4de8d19fa7577b91e9d20fe50de242313fdcfa4e902ab568769fed1654a59ef", "query": "Created limit range object with this parameters then tried to create this pod got message: Error from server (Invalid): error when creating \"pod-to-be-\": Pod \"nginx-to-be-removed-4\" is invalid: spec.containers[0].resources.requests: Invalid value: \"700m\": must be less than or equal to cpu limit Pod should be created with Requests & Limits of cpu equal to 700m (since it is in range of min/max cpu limitrange object) create limitrange object and pod as in description No response <details</details<detailson premise/AKS </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nYou have a default CPU limit of 10m, and no explicit CPU limit on the container, but a request larger than the limit. The request must always be less than or equal to the limit. Your pod needs to also set a higher limit, or the limit range needs to not set a default limit.\n/remove-kind bug /kind support\n/cc\nbut this is not obvious behavior since there is min & max set in limit range. This is limits (not min/max) that should be overwritten by pod. limits should be set to requests in this case imho\nlimit range limits what the user can set, it doesn't perform any mutations other than the defaulting and doesn't claim to. Min/max enforce that pods cannot set higher / lower. The default ensures that if the pod doesn't set a limit it will have one. personally I would remove the default limit, especially at 10m, this will aggressively limit pods. it would be, if the pod set a limit that would be a substantial breaking change, I don't think we could do that short of a v2 API and I'm not sure it would be correct behavior even then. we could make it opt-in, but then, why not just set them to match on the pod to begin with?", "positive_passages": [{"docid": "doc-en-kubernetes-ab78ce70a3b3db9c734626e19ec127251fc233a14c84df8daeb3adc22a8704fa", "text": "if exists { // For GPUs, not only requests can't exceed limits, they also can't be lower, i.e. must be equal. if quantity.Cmp(limitQuantity) != 0 && !v1helper.IsOvercommitAllowed(resourceName) { <del> allErrs = append(allErrs, field.Invalid(reqPath, quantity.String(), fmt.Sprintf(\"must be equal to %s limit\", resourceName))) </del> <ins> allErrs = append(allErrs, field.Invalid(reqPath, quantity.String(), fmt.Sprintf(\"must be equal to %s limit of %s\", resourceName, limitQuantity.String()))) </ins> } else if quantity.Cmp(limitQuantity) > 0 { <del> allErrs = append(allErrs, field.Invalid(reqPath, quantity.String(), fmt.Sprintf(\"must be less than or equal to %s limit\", resourceName))) </del> <ins> allErrs = append(allErrs, field.Invalid(reqPath, quantity.String(), fmt.Sprintf(\"must be less than or equal to %s limit of %s\", resourceName, limitQuantity.String()))) </ins> } } }", "commid": "kubernetes_pr_112925"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4de8d19fa7577b91e9d20fe50de242313fdcfa4e902ab568769fed1654a59ef", "query": "Created limit range object with this parameters then tried to create this pod got message: Error from server (Invalid): error when creating \"pod-to-be-\": Pod \"nginx-to-be-removed-4\" is invalid: spec.containers[0].resources.requests: Invalid value: \"700m\": must be less than or equal to cpu limit Pod should be created with Requests & Limits of cpu equal to 700m (since it is in range of min/max cpu limitrange object) create limitrange object and pod as in description No response <details</details<detailson premise/AKS </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nYou have a default CPU limit of 10m, and no explicit CPU limit on the container, but a request larger than the limit. The request must always be less than or equal to the limit. Your pod needs to also set a higher limit, or the limit range needs to not set a default limit.\n/remove-kind bug /kind support\n/cc\nbut this is not obvious behavior since there is min & max set in limit range. This is limits (not min/max) that should be overwritten by pod. limits should be set to requests in this case imho\nlimit range limits what the user can set, it doesn't perform any mutations other than the defaulting and doesn't claim to. Min/max enforce that pods cannot set higher / lower. The default ensures that if the pod doesn't set a limit it will have one. personally I would remove the default limit, especially at 10m, this will aggressively limit pods. it would be, if the pod set a limit that would be a substantial breaking change, I don't think we could do that short of a v2 API and I'm not sure it would be correct behavior even then. we could make it opt-in, but then, why not just set them to match on the pod to begin with?", "positive_passages": [{"docid": "doc-en-kubernetes-6f781b2460661f733fe8efa774f70ab76927ea355514e1cecb1c71a5f620913f", "text": "package validation import ( <ins> \"strings\" </ins> \"testing\" <del> \"k8s.io/api/core/v1\" </del> <ins> v1 \"k8s.io/api/core/v1\" </ins> \"k8s.io/apimachinery/pkg/api/resource\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/util/sets\"", "commid": "kubernetes_pr_112925"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4de8d19fa7577b91e9d20fe50de242313fdcfa4e902ab568769fed1654a59ef", "query": "Created limit range object with this parameters then tried to create this pod got message: Error from server (Invalid): error when creating \"pod-to-be-\": Pod \"nginx-to-be-removed-4\" is invalid: spec.containers[0].resources.requests: Invalid value: \"700m\": must be less than or equal to cpu limit Pod should be created with Requests & Limits of cpu equal to 700m (since it is in range of min/max cpu limitrange object) create limitrange object and pod as in description No response <details</details<detailson premise/AKS </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nYou have a default CPU limit of 10m, and no explicit CPU limit on the container, but a request larger than the limit. The request must always be less than or equal to the limit. Your pod needs to also set a higher limit, or the limit range needs to not set a default limit.\n/remove-kind bug /kind support\n/cc\nbut this is not obvious behavior since there is min & max set in limit range. This is limits (not min/max) that should be overwritten by pod. limits should be set to requests in this case imho\nlimit range limits what the user can set, it doesn't perform any mutations other than the defaulting and doesn't claim to. Min/max enforce that pods cannot set higher / lower. The default ensures that if the pod doesn't set a limit it will have one. personally I would remove the default limit, especially at 10m, this will aggressively limit pods. it would be, if the pod set a limit that would be a substantial breaking change, I don't think we could do that short of a v2 API and I'm not sure it would be correct behavior even then. we could make it opt-in, but then, why not just set them to match on the pod to begin with?", "positive_passages": [{"docid": "doc-en-kubernetes-f48791571bd758d7cf5e24281c1f6be2bc6d3d0c7cd32b7be3b2b63d3f1ffe4d", "text": "} errorCase := []struct { <del> name         string requirements v1.ResourceRequirements </del> <ins> name                  string requirements          v1.ResourceRequirements skipLimitValueCheck   bool skipRequestValueCheck bool </ins> }{ { name: \"Resources with Requests Larger Than Limits\",", "commid": "kubernetes_pr_112925"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4de8d19fa7577b91e9d20fe50de242313fdcfa4e902ab568769fed1654a59ef", "query": "Created limit range object with this parameters then tried to create this pod got message: Error from server (Invalid): error when creating \"pod-to-be-\": Pod \"nginx-to-be-removed-4\" is invalid: spec.containers[0].resources.requests: Invalid value: \"700m\": must be less than or equal to cpu limit Pod should be created with Requests & Limits of cpu equal to 700m (since it is in range of min/max cpu limitrange object) create limitrange object and pod as in description No response <details</details<detailson premise/AKS </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nYou have a default CPU limit of 10m, and no explicit CPU limit on the container, but a request larger than the limit. The request must always be less than or equal to the limit. Your pod needs to also set a higher limit, or the limit range needs to not set a default limit.\n/remove-kind bug /kind support\n/cc\nbut this is not obvious behavior since there is min & max set in limit range. This is limits (not min/max) that should be overwritten by pod. limits should be set to requests in this case imho\nlimit range limits what the user can set, it doesn't perform any mutations other than the defaulting and doesn't claim to. Min/max enforce that pods cannot set higher / lower. The default ensures that if the pod doesn't set a limit it will have one. personally I would remove the default limit, especially at 10m, this will aggressively limit pods. it would be, if the pod set a limit that would be a substantial breaking change, I don't think we could do that short of a v2 API and I'm not sure it would be correct behavior even then. we could make it opt-in, but then, why not just set them to match on the pod to begin with?", "positive_passages": [{"docid": "doc-en-kubernetes-b731dccd452ca098487d8216eb36b405f1fd9853a69d166141308e5eb8d264d9", "text": "v1.ResourceName(\"my.org\"): resource.MustParse(\"10m\"), }, }, <ins> skipRequestValueCheck: true, </ins> }, { name: \"Invalid Resources with Limits\",", "commid": "kubernetes_pr_112925"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4de8d19fa7577b91e9d20fe50de242313fdcfa4e902ab568769fed1654a59ef", "query": "Created limit range object with this parameters then tried to create this pod got message: Error from server (Invalid): error when creating \"pod-to-be-\": Pod \"nginx-to-be-removed-4\" is invalid: spec.containers[0].resources.requests: Invalid value: \"700m\": must be less than or equal to cpu limit Pod should be created with Requests & Limits of cpu equal to 700m (since it is in range of min/max cpu limitrange object) create limitrange object and pod as in description No response <details</details<detailson premise/AKS </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nYou have a default CPU limit of 10m, and no explicit CPU limit on the container, but a request larger than the limit. The request must always be less than or equal to the limit. Your pod needs to also set a higher limit, or the limit range needs to not set a default limit.\n/remove-kind bug /kind support\n/cc\nbut this is not obvious behavior since there is min & max set in limit range. This is limits (not min/max) that should be overwritten by pod. limits should be set to requests in this case imho\nlimit range limits what the user can set, it doesn't perform any mutations other than the defaulting and doesn't claim to. Min/max enforce that pods cannot set higher / lower. The default ensures that if the pod doesn't set a limit it will have one. personally I would remove the default limit, especially at 10m, this will aggressively limit pods. it would be, if the pod set a limit that would be a substantial breaking change, I don't think we could do that short of a v2 API and I'm not sure it would be correct behavior even then. we could make it opt-in, but then, why not just set them to match on the pod to begin with?", "positive_passages": [{"docid": "doc-en-kubernetes-0085d2a7933714ec618ca72d1967d9c9236117548baa44ee683a1c6eb5f253c4", "text": "v1.ResourceName(\"my.org\"): resource.MustParse(\"9m\"), }, }, <ins> skipLimitValueCheck: true, </ins> }, } for _, tc := range errorCase { t.Run(tc.name, func(t *testing.T) { <del> if errs := ValidateResourceRequirements(&tc.requirements, field.NewPath(\"resources\")); len(errs) == 0 { </del> <ins> errs := ValidateResourceRequirements(&tc.requirements, field.NewPath(\"resources\")) if len(errs) == 0 { </ins> t.Errorf(\"expected error\") } <ins> validateNamesAndValuesInDescription(t, tc.requirements.Limits, errs, tc.skipLimitValueCheck, \"limit\") validateNamesAndValuesInDescription(t, tc.requirements.Requests, errs, tc.skipRequestValueCheck, \"request\") </ins> }) } } <ins> func validateNamesAndValuesInDescription(t *testing.T, r v1.ResourceList, errs field.ErrorList, skipValueTest bool, rl string) { for name, value := range r { containsName := false containsValue := false for _, e := range errs { if strings.Contains(e.Error(), name.String()) { containsName = true } if strings.Contains(e.Error(), value.String()) { containsValue = true } } if !containsName { t.Errorf(\"error must contain %s name\", rl) } if !containsValue && !skipValueTest { t.Errorf(\"error must contain %s value\", rl) } } } </ins> func TestValidateContainerResourceName(t *testing.T) { successCase := []struct { name         string", "commid": "kubernetes_pr_112925"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b4de8d19fa7577b91e9d20fe50de242313fdcfa4e902ab568769fed1654a59ef", "query": "Created limit range object with this parameters then tried to create this pod got message: Error from server (Invalid): error when creating \"pod-to-be-\": Pod \"nginx-to-be-removed-4\" is invalid: spec.containers[0].resources.requests: Invalid value: \"700m\": must be less than or equal to cpu limit Pod should be created with Requests & Limits of cpu equal to 700m (since it is in range of min/max cpu limitrange object) create limitrange object and pod as in description No response <details</details<detailson premise/AKS </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nYou have a default CPU limit of 10m, and no explicit CPU limit on the container, but a request larger than the limit. The request must always be less than or equal to the limit. Your pod needs to also set a higher limit, or the limit range needs to not set a default limit.\n/remove-kind bug /kind support\n/cc\nbut this is not obvious behavior since there is min & max set in limit range. This is limits (not min/max) that should be overwritten by pod. limits should be set to requests in this case imho\nlimit range limits what the user can set, it doesn't perform any mutations other than the defaulting and doesn't claim to. Min/max enforce that pods cannot set higher / lower. The default ensures that if the pod doesn't set a limit it will have one. personally I would remove the default limit, especially at 10m, this will aggressively limit pods. it would be, if the pod set a limit that would be a substantial breaking change, I don't think we could do that short of a v2 API and I'm not sure it would be correct behavior even then. we could make it opt-in, but then, why not just set them to match on the pod to begin with?", "positive_passages": [{"docid": "doc-en-kubernetes-2663bee782152df929b3b1d6c289b18ac0e53e4638995780e7e17df557e7149d", "text": "if exists { // For non overcommitable resources, not only requests can't exceed limits, they also can't be lower, i.e. must be equal. if quantity.Cmp(limitQuantity) != 0 && !helper.IsOvercommitAllowed(resourceName) { <del> allErrs = append(allErrs, field.Invalid(reqPath, quantity.String(), fmt.Sprintf(\"must be equal to %s limit\", resourceName))) </del> <ins> allErrs = append(allErrs, field.Invalid(reqPath, quantity.String(), fmt.Sprintf(\"must be equal to %s limit of %s\", resourceName, limitQuantity.String()))) </ins> } else if quantity.Cmp(limitQuantity) > 0 { <del> allErrs = append(allErrs, field.Invalid(reqPath, quantity.String(), fmt.Sprintf(\"must be less than or equal to %s limit\", resourceName))) </del> <ins> allErrs = append(allErrs, field.Invalid(reqPath, quantity.String(), fmt.Sprintf(\"must be less than or equal to %s limit of %s\", resourceName, limitQuantity.String()))) </ins> } } else if !helper.IsOvercommitAllowed(resourceName) { allErrs = append(allErrs, field.Required(limPath, \"Limit must be set for non overcommitable resources\"))", "commid": "kubernetes_pr_112925"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a929f3f32506a77af05bbb3d419a7027c81550ce76cd4ecbbbd64d2b06017fd", "query": "As per, , wire up metrics/slis for ccm\n/assign /sig instrumentation /sig cloud-provider\nGitHub didn't allow me to assign the following users: Richabanker. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign /sig instrumentation /sig cloud-provider Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/triage accepted\n/remove-triage accepted\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-e69f4ca60537de83169f58e05ee218518073e230cf14c1570631a78db46abeac", "text": "\"k8s.io/apimachinery/pkg/util/uuid\" \"k8s.io/apimachinery/pkg/util/wait\" \"k8s.io/apiserver/pkg/server/healthz\" <ins> utilfeature \"k8s.io/apiserver/pkg/util/feature\" </ins> cacheddiscovery \"k8s.io/client-go/discovery/cached\" \"k8s.io/client-go/informers\" v1core \"k8s.io/client-go/kubernetes/typed/core/v1\"", "commid": "kubernetes_pr_113340"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a929f3f32506a77af05bbb3d419a7027c81550ce76cd4ecbbbd64d2b06017fd", "query": "As per, , wire up metrics/slis for ccm\n/assign /sig instrumentation /sig cloud-provider\nGitHub didn't allow me to assign the following users: Richabanker. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign /sig instrumentation /sig cloud-provider Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/triage accepted\n/remove-triage accepted\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-43a10479caec81feabb89c6a392a169e571f1bdf297dc423fcb66c853ade5c5d", "text": "cliflag \"k8s.io/component-base/cli/flag\" \"k8s.io/component-base/cli/globalflag\" \"k8s.io/component-base/configz\" <ins> \"k8s.io/component-base/metrics/features\" </ins> controllersmetrics \"k8s.io/component-base/metrics/prometheus/controllers\" <ins> \"k8s.io/component-base/metrics/prometheus/slis\" </ins> \"k8s.io/component-base/term\" \"k8s.io/component-base/version\" \"k8s.io/component-base/version/verflag\"", "commid": "kubernetes_pr_113340"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a929f3f32506a77af05bbb3d419a7027c81550ce76cd4ecbbbd64d2b06017fd", "query": "As per, , wire up metrics/slis for ccm\n/assign /sig instrumentation /sig cloud-provider\nGitHub didn't allow me to assign the following users: Richabanker. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign /sig instrumentation /sig cloud-provider Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/triage accepted\n/remove-triage accepted\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-cb8c24aad2e4aae68f87805beed7f34ca104226ef40ba33f283354a22413470f", "text": "\"k8s.io/klog/v2\" ) <ins> func init() { utilruntime.Must(features.AddFeatureGates(utilfeature.DefaultMutableFeatureGate)) } </ins> const ( // ControllerStartJitter is the jitter value used when starting controller managers. ControllerStartJitter = 1.0", "commid": "kubernetes_pr_113340"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1a929f3f32506a77af05bbb3d419a7027c81550ce76cd4ecbbbd64d2b06017fd", "query": "As per, , wire up metrics/slis for ccm\n/assign /sig instrumentation /sig cloud-provider\nGitHub didn't allow me to assign the following users: Richabanker. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign /sig instrumentation /sig cloud-provider Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/triage accepted\n/remove-triage accepted\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-78f6dda7950219444b7e83361c1d1d64e69b532c5b77c8509487e482dde86e11", "text": "// Start the controller manager HTTP server if c.SecureServing != nil { unsecuredMux := genericcontrollermanager.NewBaseHandler(&c.ComponentConfig.Generic.Debugging, healthzHandler) <ins> if utilfeature.DefaultFeatureGate.Enabled(features.ComponentSLIs) { slis.SLIMetricsWithReset{}.Install(unsecuredMux) } </ins> handler := genericcontrollermanager.BuildHandlerChain(unsecuredMux, &c.Authorization, &c.Authentication) // TODO: handle stoppedCh and listenerStoppedCh returned by c.SecureServing.Serve if _, _, err := c.SecureServing.Serve(handler, 0, stopCh); err != nil {", "commid": "kubernetes_pr_113340"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3adf443a08b875ded3a1c0a6a2e6a06ab5e3f98761de8f84e4c945877614c7fc", "query": "After merged, build logs for e2e tests have started showing stack traces that look like: It seems like the used in this is nil I have a suspicion this is happening for storage tests that skip No new stack traces in build logs Run e2e tests against the in-development version of kubernetes I identified when this started happening by looking for an increase in build-log size is the first build where this started happening, which happens to be the first build after merged, which is the PR that introduced this new way of invoking <details</details<details</details<details</details<details</details<details</details<details</details\n/sig testing /triage accepted /assign To put this on your radar\n/cc\nCorrect. This happens because of the ordering in Tests gets skipped before is called. This avoids the expensive namespace creation/deletion for tests that don't need to run. The for then gets executed although the framework didn't get initialized. My preferred solution is to document that the framework instance might not be initialized in an AfterEach callback and add a nil check to .\nSee Only was affected. The other framework extensions use DeferCleanup, which only runs when needed.", "positive_passages": [{"docid": "doc-en-kubernetes-c97cf825faf7482b327e03190e44a2e7d4095f2ab2b07285e0c70e431e97c910", "text": "// with gingko.BeforeEach/AfterEach/DeferCleanup. // // When a test runs, functions will be invoked in this order: <ins> // - BeforeEaches defined by tests before f.NewDefaultFramework //   in the order in which they were defined (first-in-first-out) </ins> // - f.BeforeEach <del> // - all BeforeEaches in the order in which they were defined (first-in-first-out) </del> <ins> // - BeforeEaches defined by tests after f.NewDefaultFramework </ins> // - It callback // - all AfterEaches in the order in which they were defined // - all DeferCleanups with the order reversed (first-in-last-out) // - f.AfterEach <ins> // // Because a test might skip test execution in a BeforeEach that runs // before f.BeforeEach, AfterEach callbacks that depend on the // framework instance must check whether it was initialized. They can // do that by checking f.ClientSet for nil. DeferCleanup callbacks // don't need to do this because they get defined when the test // runs. </ins> NewFrameworkExtensions []func(f *Framework) )", "commid": "kubernetes_pr_113097"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3adf443a08b875ded3a1c0a6a2e6a06ab5e3f98761de8f84e4c945877614c7fc", "query": "After merged, build logs for e2e tests have started showing stack traces that look like: It seems like the used in this is nil I have a suspicion this is happening for storage tests that skip No new stack traces in build logs Run e2e tests against the in-development version of kubernetes I identified when this started happening by looking for an increase in build-log size is the first build where this started happening, which happens to be the first build after merged, which is the PR that introduced this new way of invoking <details</details<details</details<details</details<details</details<details</details<details</details\n/sig testing /triage accepted /assign To put this on your radar\n/cc\nCorrect. This happens because of the ordering in Tests gets skipped before is called. This avoids the expensive namespace creation/deletion for tests that don't need to run. The for then gets executed although the framework didn't get initialized. My preferred solution is to document that the framework instance might not be initialized in an AfterEach callback and add a nil check to .\nSee Only was affected. The other framework extensions use DeferCleanup, which only runs when needed.", "positive_passages": [{"docid": "doc-en-kubernetes-5af32f6f98e6aa7ff0605f9ac14c820e9d5da92406ea9f37bf2ca563cc1f3d15", "text": "} } <del> // Paranoia-- prevent reuse! </del> <ins> // Unsetting this is relevant for a following test that uses // the same instance because it might not reach f.BeforeEach // when some other BeforeEach skips the test first. </ins> f.Namespace = nil f.clientConfig = nil f.ClientSet = nil", "commid": "kubernetes_pr_113097"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3adf443a08b875ded3a1c0a6a2e6a06ab5e3f98761de8f84e4c945877614c7fc", "query": "After merged, build logs for e2e tests have started showing stack traces that look like: It seems like the used in this is nil I have a suspicion this is happening for storage tests that skip No new stack traces in build logs Run e2e tests against the in-development version of kubernetes I identified when this started happening by looking for an increase in build-log size is the first build where this started happening, which happens to be the first build after merged, which is the PR that introduced this new way of invoking <details</details<details</details<details</details<details</details<details</details<details</details\n/sig testing /triage accepted /assign To put this on your radar\n/cc\nCorrect. This happens because of the ordering in Tests gets skipped before is called. This avoids the expensive namespace creation/deletion for tests that don't need to run. The for then gets executed although the framework didn't get initialized. My preferred solution is to document that the framework instance might not be initialized in an AfterEach callback and add a nil check to .\nSee Only was affected. The other framework extensions use DeferCleanup, which only runs when needed.", "positive_passages": [{"docid": "doc-en-kubernetes-b220792593828af5aba52209f8f5ea01a39030ba0d14f484540fc624df19baf5", "text": "framework.NewFrameworkExtensions = append(framework.NewFrameworkExtensions, func(f *framework.Framework) { ginkgo.AfterEach(func() { <ins> if f.ClientSet == nil { // Test didn't reach f.BeforeEach, most // likely because the test got // skipped. Nothing to check... return } </ins> e2enode.AllNodesReady(f.ClientSet, 3*time.Minute) }) },", "commid": "kubernetes_pr_113097"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-05984e835f1e73cb4c0b2223127020e6f9a06b8a22eb8f8d9b6ab8ff80249f40", "query": "The replicas is 3 but just create 1 pod 'web-0' and one pvc, then kube-controller-manager panic happend. Should create 3 pod and 3 pvc add '--feature-gates=StatefulSetAutoDeletePVC=true' arg for kube-controller-manager, then create statefulset with 2 replicas and volumeClaimTemplates. No response <details</details<details</details<details</details<details</details<details</details<details</details\n/sig apps\nI can reproduce the issue and want to fix it. It seems like variables cause . /assign\n/triage accepted\nGreat find! Does this only happen on an upgraded cluster? I'll spin up a cluster and see if the e2e test catches this problem.\nThe e2e tests are still passing on a 1.24 cluster, so I suspect this is an upgrade problem. I wonder if there are other holes here.\nI installed the Kubernetes 1.25 cluster directly using and still reproduced this issue, so it was probably not caused by upgrading the cluster.\nInteresting. I thought that would set the policy to be non-nil. Let's keep this bug open after you submit your PR as I think something else is going on here---I don't think we should be seeing the null policy in the first place.\nI suspect that somewhere accidentally set it to nil, and I'll keep looking at this code.\nI tried the following (and also with parallel pod management), and it didn't seem to cause the panic. This was a 1.24 cluster, maybe this is only happening on head versions?\nI just tried this on a kind cluster running on k8s head, and the problem didn't seem to reproduce. But this was setting the feature flag default in I wonder----does the api server need to have the feature gate as well? That would explain why defaulting wasn't happening.\nAs far as I'm concerned,I just set the in kube-controller-manager manifests to reproduce this issue. I repeat the yaml used as follows: I tested that in statefulset yaml, setting or not would cause the component to panic. The panic logs are the same as above, so ignore them here. statefulset with : The environment\nI believe you---this doesn't seem to be well-documented, but it's my understanding that you need to set the feature gate on all of the system components. Obviously failing to do so shouldn't cause a panic, so thank you again for finding & fixing this bug! Let me ask around to see what the expected behavior is. I know there may be skew between kubelets and master versions, but I didn't expect to have to deal with skew between master components.\nI read the code, and now I understand what you mean. This feature gate must be enabled in both the and components. We need to describe it in the to prevent someone from ignoring the component, which also needs to enable the feature gate.\nI don't think we need all the system components, like the component, right? I read the original KEP documentation. This feature gate only involves components and :\nI had a bit of discussion about this with others. Because upgrades don't occur atomically, any feature gate has to work regardless of how the other system components are configured (things shouldn't panic!). I suppose if the cluster administrator wants to track what needs to be enabled on each feature they can try to sequence which component has which feature gate. If it were me I'd try to make all the components consistent though.\nThis is certainly a method, but it is a bit more cumbersome for the administrator. It is best to have a place for the document to be queried by the administrator and avoid confusion. I don't think everyone is very familiar with the k8s mechanism. I suggest adding a partial description to this section of the : Before: After: I can submit this PR on .\nThis is going to be true of any api change. When you tried to use it with only adding the controller manager feature gate, I think you would be able to set the retain policy, but there wouldn't be any defaulting or validation (?).\nI've seen other feature gates that say what components are needed to enable it to use the new feature. For example: If it's not necessary, then I close .\nonly adding the controller manager feature gate, I think you would be able to set the retain policy, but there wouldn't be any defaulting or validation (?). I remember just enabling it in kube-controller-manager. it using the retain policy, but the statefulset does not have the policy from output of (It should be the apiserver authentication forbids it)\nYeah I think that makes sense. Thanks for finding this issue! After your PR with the panic fix is submitted, I think we can close this?\nYes. I agree. /close\nClosing this issue. <detailsIn response to : Yes. I agree. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-8a24aee8beb1a8d4ac362630e22675b2fb661e88c86b5a009e165fa86c1ee62a", "text": "WhenScaled:  apps.DeletePersistentVolumeClaimRetentionPolicyType, WhenDeleted: apps.DeletePersistentVolumeClaimRetentionPolicyType, }, <ins> // tests the case when no policy is set. nil, </ins> } { subtestName := pvcDeletePolicyString(policy) + \"/StatefulSetAutoDeletePVCEnabled\" if testName != \"\" {", "commid": "kubernetes_pr_113358"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-05984e835f1e73cb4c0b2223127020e6f9a06b8a22eb8f8d9b6ab8ff80249f40", "query": "The replicas is 3 but just create 1 pod 'web-0' and one pvc, then kube-controller-manager panic happend. Should create 3 pod and 3 pvc add '--feature-gates=StatefulSetAutoDeletePVC=true' arg for kube-controller-manager, then create statefulset with 2 replicas and volumeClaimTemplates. No response <details</details<details</details<details</details<details</details<details</details<details</details\n/sig apps\nI can reproduce the issue and want to fix it. It seems like variables cause . /assign\n/triage accepted\nGreat find! Does this only happen on an upgraded cluster? I'll spin up a cluster and see if the e2e test catches this problem.\nThe e2e tests are still passing on a 1.24 cluster, so I suspect this is an upgrade problem. I wonder if there are other holes here.\nI installed the Kubernetes 1.25 cluster directly using and still reproduced this issue, so it was probably not caused by upgrading the cluster.\nInteresting. I thought that would set the policy to be non-nil. Let's keep this bug open after you submit your PR as I think something else is going on here---I don't think we should be seeing the null policy in the first place.\nI suspect that somewhere accidentally set it to nil, and I'll keep looking at this code.\nI tried the following (and also with parallel pod management), and it didn't seem to cause the panic. This was a 1.24 cluster, maybe this is only happening on head versions?\nI just tried this on a kind cluster running on k8s head, and the problem didn't seem to reproduce. But this was setting the feature flag default in I wonder----does the api server need to have the feature gate as well? That would explain why defaulting wasn't happening.\nAs far as I'm concerned,I just set the in kube-controller-manager manifests to reproduce this issue. I repeat the yaml used as follows: I tested that in statefulset yaml, setting or not would cause the component to panic. The panic logs are the same as above, so ignore them here. statefulset with : The environment\nI believe you---this doesn't seem to be well-documented, but it's my understanding that you need to set the feature gate on all of the system components. Obviously failing to do so shouldn't cause a panic, so thank you again for finding & fixing this bug! Let me ask around to see what the expected behavior is. I know there may be skew between kubelets and master versions, but I didn't expect to have to deal with skew between master components.\nI read the code, and now I understand what you mean. This feature gate must be enabled in both the and components. We need to describe it in the to prevent someone from ignoring the component, which also needs to enable the feature gate.\nI don't think we need all the system components, like the component, right? I read the original KEP documentation. This feature gate only involves components and :\nI had a bit of discussion about this with others. Because upgrades don't occur atomically, any feature gate has to work regardless of how the other system components are configured (things shouldn't panic!). I suppose if the cluster administrator wants to track what needs to be enabled on each feature they can try to sequence which component has which feature gate. If it were me I'd try to make all the components consistent though.\nThis is certainly a method, but it is a bit more cumbersome for the administrator. It is best to have a place for the document to be queried by the administrator and avoid confusion. I don't think everyone is very familiar with the k8s mechanism. I suggest adding a partial description to this section of the : Before: After: I can submit this PR on .\nThis is going to be true of any api change. When you tried to use it with only adding the controller manager feature gate, I think you would be able to set the retain policy, but there wouldn't be any defaulting or validation (?).\nI've seen other feature gates that say what components are needed to enable it to use the new feature. For example: If it's not necessary, then I close .\nonly adding the controller manager feature gate, I think you would be able to set the retain policy, but there wouldn't be any defaulting or validation (?). I remember just enabling it in kube-controller-manager. it using the retain policy, but the statefulset does not have the policy from output of (It should be the apiserver authentication forbids it)\nYeah I think that makes sense. Thanks for finding this issue! After your PR with the panic fix is submitted, I think we can close this?\nYes. I agree. /close\nClosing this issue. <detailsIn response to : Yes. I agree. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-a688c882943d891e578f38d10a181b608761cb3841c8683b7d4e998158b9799d", "text": "} func pvcDeletePolicyString(policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) string { <ins> if policy == nil { return \"nullPolicy\" } </ins> const retain = apps.RetainPersistentVolumeClaimRetentionPolicyType const delete = apps.DeletePersistentVolumeClaimRetentionPolicyType switch {", "commid": "kubernetes_pr_113358"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-05984e835f1e73cb4c0b2223127020e6f9a06b8a22eb8f8d9b6ab8ff80249f40", "query": "The replicas is 3 but just create 1 pod 'web-0' and one pvc, then kube-controller-manager panic happend. Should create 3 pod and 3 pvc add '--feature-gates=StatefulSetAutoDeletePVC=true' arg for kube-controller-manager, then create statefulset with 2 replicas and volumeClaimTemplates. No response <details</details<details</details<details</details<details</details<details</details<details</details\n/sig apps\nI can reproduce the issue and want to fix it. It seems like variables cause . /assign\n/triage accepted\nGreat find! Does this only happen on an upgraded cluster? I'll spin up a cluster and see if the e2e test catches this problem.\nThe e2e tests are still passing on a 1.24 cluster, so I suspect this is an upgrade problem. I wonder if there are other holes here.\nI installed the Kubernetes 1.25 cluster directly using and still reproduced this issue, so it was probably not caused by upgrading the cluster.\nInteresting. I thought that would set the policy to be non-nil. Let's keep this bug open after you submit your PR as I think something else is going on here---I don't think we should be seeing the null policy in the first place.\nI suspect that somewhere accidentally set it to nil, and I'll keep looking at this code.\nI tried the following (and also with parallel pod management), and it didn't seem to cause the panic. This was a 1.24 cluster, maybe this is only happening on head versions?\nI just tried this on a kind cluster running on k8s head, and the problem didn't seem to reproduce. But this was setting the feature flag default in I wonder----does the api server need to have the feature gate as well? That would explain why defaulting wasn't happening.\nAs far as I'm concerned,I just set the in kube-controller-manager manifests to reproduce this issue. I repeat the yaml used as follows: I tested that in statefulset yaml, setting or not would cause the component to panic. The panic logs are the same as above, so ignore them here. statefulset with : The environment\nI believe you---this doesn't seem to be well-documented, but it's my understanding that you need to set the feature gate on all of the system components. Obviously failing to do so shouldn't cause a panic, so thank you again for finding & fixing this bug! Let me ask around to see what the expected behavior is. I know there may be skew between kubelets and master versions, but I didn't expect to have to deal with skew between master components.\nI read the code, and now I understand what you mean. This feature gate must be enabled in both the and components. We need to describe it in the to prevent someone from ignoring the component, which also needs to enable the feature gate.\nI don't think we need all the system components, like the component, right? I read the original KEP documentation. This feature gate only involves components and :\nI had a bit of discussion about this with others. Because upgrades don't occur atomically, any feature gate has to work regardless of how the other system components are configured (things shouldn't panic!). I suppose if the cluster administrator wants to track what needs to be enabled on each feature they can try to sequence which component has which feature gate. If it were me I'd try to make all the components consistent though.\nThis is certainly a method, but it is a bit more cumbersome for the administrator. It is best to have a place for the document to be queried by the administrator and avoid confusion. I don't think everyone is very familiar with the k8s mechanism. I suggest adding a partial description to this section of the : Before: After: I can submit this PR on .\nThis is going to be true of any api change. When you tried to use it with only adding the controller manager feature gate, I think you would be able to set the retain policy, but there wouldn't be any defaulting or validation (?).\nI've seen other feature gates that say what components are needed to enable it to use the new feature. For example: If it's not necessary, then I close .\nonly adding the controller manager feature gate, I think you would be able to set the retain policy, but there wouldn't be any defaulting or validation (?). I remember just enabling it in kube-controller-manager. it using the retain policy, but the statefulset does not have the policy from output of (It should be the apiserver authentication forbids it)\nYeah I think that makes sense. Thanks for finding this issue! After your PR with the panic fix is submitted, I think we can close this?\nYes. I agree. /close\nClosing this issue. <detailsIn response to : Yes. I agree. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-0db8b9a9963fe172f8c526f5dbad63325026a59f82106da42a11e780e7146730", "text": "// claimOwnerMatchesSetAndPod returns false if the ownerRefs of the claim are not set consistently with the // PVC deletion policy for the StatefulSet. func claimOwnerMatchesSetAndPod(claim *v1.PersistentVolumeClaim, set *apps.StatefulSet, pod *v1.Pod) bool { <del> policy := set.Spec.PersistentVolumeClaimRetentionPolicy </del> <ins> policy := getPersistentVolumeClaimRetentionPolicy(set) </ins> const retain = apps.RetainPersistentVolumeClaimRetentionPolicyType const delete = apps.DeletePersistentVolumeClaimRetentionPolicyType switch {", "commid": "kubernetes_pr_113358"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-05984e835f1e73cb4c0b2223127020e6f9a06b8a22eb8f8d9b6ab8ff80249f40", "query": "The replicas is 3 but just create 1 pod 'web-0' and one pvc, then kube-controller-manager panic happend. Should create 3 pod and 3 pvc add '--feature-gates=StatefulSetAutoDeletePVC=true' arg for kube-controller-manager, then create statefulset with 2 replicas and volumeClaimTemplates. No response <details</details<details</details<details</details<details</details<details</details<details</details\n/sig apps\nI can reproduce the issue and want to fix it. It seems like variables cause . /assign\n/triage accepted\nGreat find! Does this only happen on an upgraded cluster? I'll spin up a cluster and see if the e2e test catches this problem.\nThe e2e tests are still passing on a 1.24 cluster, so I suspect this is an upgrade problem. I wonder if there are other holes here.\nI installed the Kubernetes 1.25 cluster directly using and still reproduced this issue, so it was probably not caused by upgrading the cluster.\nInteresting. I thought that would set the policy to be non-nil. Let's keep this bug open after you submit your PR as I think something else is going on here---I don't think we should be seeing the null policy in the first place.\nI suspect that somewhere accidentally set it to nil, and I'll keep looking at this code.\nI tried the following (and also with parallel pod management), and it didn't seem to cause the panic. This was a 1.24 cluster, maybe this is only happening on head versions?\nI just tried this on a kind cluster running on k8s head, and the problem didn't seem to reproduce. But this was setting the feature flag default in I wonder----does the api server need to have the feature gate as well? That would explain why defaulting wasn't happening.\nAs far as I'm concerned,I just set the in kube-controller-manager manifests to reproduce this issue. I repeat the yaml used as follows: I tested that in statefulset yaml, setting or not would cause the component to panic. The panic logs are the same as above, so ignore them here. statefulset with : The environment\nI believe you---this doesn't seem to be well-documented, but it's my understanding that you need to set the feature gate on all of the system components. Obviously failing to do so shouldn't cause a panic, so thank you again for finding & fixing this bug! Let me ask around to see what the expected behavior is. I know there may be skew between kubelets and master versions, but I didn't expect to have to deal with skew between master components.\nI read the code, and now I understand what you mean. This feature gate must be enabled in both the and components. We need to describe it in the to prevent someone from ignoring the component, which also needs to enable the feature gate.\nI don't think we need all the system components, like the component, right? I read the original KEP documentation. This feature gate only involves components and :\nI had a bit of discussion about this with others. Because upgrades don't occur atomically, any feature gate has to work regardless of how the other system components are configured (things shouldn't panic!). I suppose if the cluster administrator wants to track what needs to be enabled on each feature they can try to sequence which component has which feature gate. If it were me I'd try to make all the components consistent though.\nThis is certainly a method, but it is a bit more cumbersome for the administrator. It is best to have a place for the document to be queried by the administrator and avoid confusion. I don't think everyone is very familiar with the k8s mechanism. I suggest adding a partial description to this section of the : Before: After: I can submit this PR on .\nThis is going to be true of any api change. When you tried to use it with only adding the controller manager feature gate, I think you would be able to set the retain policy, but there wouldn't be any defaulting or validation (?).\nI've seen other feature gates that say what components are needed to enable it to use the new feature. For example: If it's not necessary, then I close .\nonly adding the controller manager feature gate, I think you would be able to set the retain policy, but there wouldn't be any defaulting or validation (?). I remember just enabling it in kube-controller-manager. it using the retain policy, but the statefulset does not have the policy from output of (It should be the apiserver authentication forbids it)\nYeah I think that makes sense. Thanks for finding this issue! After your PR with the panic fix is submitted, I think we can close this?\nYes. I agree. /close\nClosing this issue. <detailsIn response to : Yes. I agree. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-47465fe8816417c02c40a19dfb97d753521676e0f20d2b2d300b96d801c88151", "text": "updateMeta(&podMeta, \"Pod\") setMeta := set.TypeMeta updateMeta(&setMeta, \"StatefulSet\") <del> policy := set.Spec.PersistentVolumeClaimRetentionPolicy </del> <ins> policy := getPersistentVolumeClaimRetentionPolicy(set) </ins> const retain = apps.RetainPersistentVolumeClaimRetentionPolicyType const delete = apps.DeletePersistentVolumeClaimRetentionPolicyType switch {", "commid": "kubernetes_pr_113358"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8d104fb08a54b1aafbf227b5ff87163913c73afc8318e39b926ee160b7ff0192", "query": "release-master-informing: capz-windows-containerd-masterKubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute prestop https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute poststart https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] Both the tests have been failing during most of the runs since 20th October Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute prestop https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] | 1m6s -- | -- {Oct 31 18:42:02.425: Timed out after 30.001s. Expected <errors.errorString | 0xc0015283b0: { s: \"failed to match regexp \"GET /echo?msg=prestop\" in output \"I1031 18:41:06. 8988 ] Started HTTP server on port 9090nI1031 18:41:06. 8988 ] Started UDP server on port 9091n\"\", } to be nil failed (0xc000f1d000) +0x469 () +0x335} Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute poststart https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] | 5m11s -- | -- {Oct 31 19:05:50.205: timed out while waiting for pod container-lifecycle-hook-6892/pod-with-poststart-https-hook to be running and ready failed (PodClient).CreateSync(0xc000eb5920, 0x22?) +0x94 (0xc0045e8c00) +0x73 () +0x325} No response_ /sig windows cc\n/triage accepted /cc\nThese failures happen also with Kubernetes master + containerd master with Flannel CNI. Testgrid link:\nI figured out why these new failures appear. I've submitted the fix via PR\nThis issue is also affecting 1.25 tests: If possible, we should cherry-pick to the release-1.25 branch once it's merged on master.", "positive_passages": [{"docid": "doc-en-kubernetes-9ddef8812cad782f4c5e8137ed479959bc608d8f005148172df935e1d20d011d", "text": "/* Release : v1.23 Testname: Pod Lifecycle, poststart https hook <del> Description: When a post-start handler is specified in the container lifecycle using a 'HttpGet' action, then the handler MUST be invoked before the container is terminated. A server pod is created that will serve https requests, create a second pod with a container lifecycle specifying a post-start that invokes the server pod to validate that the post-start is executed. </del> <ins> Description: When a post-start handler is specified in the container lifecycle using a 'HttpGet' action, then the handler MUST be invoked before the container is terminated. A server pod is created that will serve https requests, create a second pod on the same node with a container lifecycle specifying a post-start that invokes the server pod to validate that the post-start is executed. </ins> */ ginkgo.It(\"should execute poststart https hook properly [MinimumKubeletVersion:1.23] [NodeConformance]\", func() { lifecycle := &v1.Lifecycle{", "commid": "kubernetes_pr_113597"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8d104fb08a54b1aafbf227b5ff87163913c73afc8318e39b926ee160b7ff0192", "query": "release-master-informing: capz-windows-containerd-masterKubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute prestop https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute poststart https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] Both the tests have been failing during most of the runs since 20th October Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute prestop https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] | 1m6s -- | -- {Oct 31 18:42:02.425: Timed out after 30.001s. Expected <errors.errorString | 0xc0015283b0: { s: \"failed to match regexp \"GET /echo?msg=prestop\" in output \"I1031 18:41:06. 8988 ] Started HTTP server on port 9090nI1031 18:41:06. 8988 ] Started UDP server on port 9091n\"\", } to be nil failed (0xc000f1d000) +0x469 () +0x335} Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute poststart https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] | 5m11s -- | -- {Oct 31 19:05:50.205: timed out while waiting for pod container-lifecycle-hook-6892/pod-with-poststart-https-hook to be running and ready failed (PodClient).CreateSync(0xc000eb5920, 0x22?) +0x94 (0xc0045e8c00) +0x73 () +0x325} No response_ /sig windows cc\n/triage accepted /cc\nThese failures happen also with Kubernetes master + containerd master with Flannel CNI. Testgrid link:\nI figured out why these new failures appear. I've submitted the fix via PR\nThis issue is also affecting 1.25 tests: If possible, we should cherry-pick to the release-1.25 branch once it's merged on master.", "positive_passages": [{"docid": "doc-en-kubernetes-08079a1a3b9c6995ad34ad1086db607120a55d908c66f497eaa08ce57604a009", "text": "}, } podWithHook := getPodWithHook(\"pod-with-poststart-https-hook\", imageutils.GetPauseImageName(), lifecycle) <ins> // make sure we spawn the test pod on the same node as the webserver. nodeSelection := e2epod.NodeSelection{} e2epod.SetAffinity(&nodeSelection, targetNode) e2epod.SetNodeSelection(&podWithHook.Spec, nodeSelection) </ins> testPodWithHook(podWithHook) }) /*", "commid": "kubernetes_pr_113597"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8d104fb08a54b1aafbf227b5ff87163913c73afc8318e39b926ee160b7ff0192", "query": "release-master-informing: capz-windows-containerd-masterKubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute prestop https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute poststart https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] Both the tests have been failing during most of the runs since 20th October Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute prestop https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] | 1m6s -- | -- {Oct 31 18:42:02.425: Timed out after 30.001s. Expected <errors.errorString | 0xc0015283b0: { s: \"failed to match regexp \"GET /echo?msg=prestop\" in output \"I1031 18:41:06. 8988 ] Started HTTP server on port 9090nI1031 18:41:06. 8988 ] Started UDP server on port 9091n\"\", } to be nil failed (0xc000f1d000) +0x469 () +0x335} Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute poststart https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] | 5m11s -- | -- {Oct 31 19:05:50.205: timed out while waiting for pod container-lifecycle-hook-6892/pod-with-poststart-https-hook to be running and ready failed (PodClient).CreateSync(0xc000eb5920, 0x22?) +0x94 (0xc0045e8c00) +0x73 () +0x325} No response_ /sig windows cc\n/triage accepted /cc\nThese failures happen also with Kubernetes master + containerd master with Flannel CNI. Testgrid link:\nI figured out why these new failures appear. I've submitted the fix via PR\nThis issue is also affecting 1.25 tests: If possible, we should cherry-pick to the release-1.25 branch once it's merged on master.", "positive_passages": [{"docid": "doc-en-kubernetes-7b10299e55d8707ba818ea889ba9c71cf79a004115f22f50d03ec71032faccd3", "text": "/* Release : v1.23 Testname: Pod Lifecycle, prestop https hook <del> Description: When a pre-stop handler is specified in the container lifecycle using a 'HttpGet' action, then the handler MUST be invoked before the container is terminated. A server pod is created that will serve https requests, create a second pod with a container lifecycle specifying a pre-stop that invokes the server pod to validate that the pre-stop is executed. </del> <ins> Description: When a pre-stop handler is specified in the container lifecycle using a 'HttpGet' action, then the handler MUST be invoked before the container is terminated. A server pod is created that will serve https requests, create a second pod on the same node with a container lifecycle specifying a pre-stop that invokes the server pod to validate that the pre-stop is executed. </ins> */ ginkgo.It(\"should execute prestop https hook properly [MinimumKubeletVersion:1.23] [NodeConformance]\", func() { lifecycle := &v1.Lifecycle{", "commid": "kubernetes_pr_113597"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8d104fb08a54b1aafbf227b5ff87163913c73afc8318e39b926ee160b7ff0192", "query": "release-master-informing: capz-windows-containerd-masterKubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute prestop https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute poststart https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] Both the tests have been failing during most of the runs since 20th October Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute prestop https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] | 1m6s -- | -- {Oct 31 18:42:02.425: Timed out after 30.001s. Expected <errors.errorString | 0xc0015283b0: { s: \"failed to match regexp \"GET /echo?msg=prestop\" in output \"I1031 18:41:06. 8988 ] Started HTTP server on port 9090nI1031 18:41:06. 8988 ] Started UDP server on port 9091n\"\", } to be nil failed (0xc000f1d000) +0x469 () +0x335} Kubernetes e2e suite: [It] [sig-node] Container Lifecycle Hook when create a pod with lifecycle hook should execute poststart https hook properly [MinimumKubeletVersion:1.23] [NodeConformance] | 5m11s -- | -- {Oct 31 19:05:50.205: timed out while waiting for pod container-lifecycle-hook-6892/pod-with-poststart-https-hook to be running and ready failed (PodClient).CreateSync(0xc000eb5920, 0x22?) +0x94 (0xc0045e8c00) +0x73 () +0x325} No response_ /sig windows cc\n/triage accepted /cc\nThese failures happen also with Kubernetes master + containerd master with Flannel CNI. Testgrid link:\nI figured out why these new failures appear. I've submitted the fix via PR\nThis issue is also affecting 1.25 tests: If possible, we should cherry-pick to the release-1.25 branch once it's merged on master.", "positive_passages": [{"docid": "doc-en-kubernetes-182e647ca66ce6caa006ed411b395cb25d5be03667e62db9fd654f71dd0eb9a1", "text": "}, } podWithHook := getPodWithHook(\"pod-with-prestop-https-hook\", imageutils.GetPauseImageName(), lifecycle) <ins> // make sure we spawn the test pod on the same node as the webserver. nodeSelection := e2epod.NodeSelection{} e2epod.SetAffinity(&nodeSelection, targetNode) e2epod.SetNodeSelection(&podWithHook.Spec, nodeSelection) </ins> testPodWithHook(podWithHook) }) })", "commid": "kubernetes_pr_113597"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1237b61a9a420f0c0b04915325043b5410a2d3bac53dd2246fffcf46a7cfe4ca", "query": "Why is this needed? The functionality that the package provides is already present in golang's builtin errors (using in ) and the github repo is now read-only. /kind cleanup /priority backlog /good-first-issue Notes to people that want to collaborate Avoid creating a single PR for the entire repo. Create multiple PRs, each targeting a specific SIG. Do not submit PRs for\n/area code-organization\n/kind cleanup\nthis is only partially true, e.g. %w does not provide stack traces\n/assign\nI see. Should we close this issue then?\nI think it depends on how it's being used. If the traces are not the goal then we can do a simple substitution. It's probably best to drop read only dependencies ASAP but it's worth noting that if we depended on the full functionality in any way we'll need a more complex replacement (KIND did/does, not sure about k/k)\nk/k git log suggests that some cleanup has already been done in the past (maybe in other commits too): This issue triggered 3 PRs and 2 of them are merged. there does not seem to be calls to so most cases it looks it's just wrapping errors.\nfor cmd/kubeadm in kubernetes/kubernetes we decided to not drop usage of pkg/errors even if it's a deprecated project. prior ticket and comments are here\nfor cmd/kubeadm in kubernetes/kubernetes we decided to not drop usage of pkg/errors even if it's a deprecated project. prior ticket and comments are here\nI see. Added a note.\nis it still open ?\nshould be replaced with the standard library for the following reasons: archived library with no maintenance or security updates the go community used pkg/errors to introduce eventually into the standard library hence the approach that was selected is more idiomatic stack traces are hardly used in error wrapping and are not a reason not to refactor\nOn place left in Except the k/k repo, as is archived, some other repos may need an update.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nThe label cannot be applied. Only GitHub organization members can add the label. <detailsIn response to : /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis it necessary to remove \"\" from every location? I noticed it in many places. Also, do I need to create separate PRs for each file where I remove it?\n/assign\nFrom kuberentes/kubernetes repo view, only two locations of kubectl code should be updated. (Do not submit PRs for ) see For other repos, we should follow up until the dependencies' repo is updated. I will track them in\n/assign\n/assign\nto remove dependency you can use the standard Go error package or creating your own handling package, this could contain custom functions for generating and handling errors.\nlet me work on this issue now please /assign\nWe are in code freeze. I suggest waiting for a couple of weeks.\nHello, is this still up?\nLet's get this going\n/assign\nJust opened a PR for this issue\n/assign\nUpdate the remaining todo items.\n/sig architecture umbrella / code org\n/assign\nHey Are you still working on this one? If not- would you mind if I take a stab at it? Thanks!\nIs this issue really still open? When I do I only get hits for cmd/kubeadm. Am I missing something?\n/close\nClosing this issue. <detailsIn response to : /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-750f8c2f1564e8e5e516e6b822cb4ccee06db2609f7d616c8b608c728609bc93", "text": "\"fmt\" \"unsafe\" <del> \"github.com/pkg/errors\" </del> \"golang.org/x/sys/windows\" \"k8s.io/klog/v2\" \"k8s.io/kubernetes/pkg/windows/service\" )", "commid": "kubernetes_pr_113672"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1237b61a9a420f0c0b04915325043b5410a2d3bac53dd2246fffcf46a7cfe4ca", "query": "Why is this needed? The functionality that the package provides is already present in golang's builtin errors (using in ) and the github repo is now read-only. /kind cleanup /priority backlog /good-first-issue Notes to people that want to collaborate Avoid creating a single PR for the entire repo. Create multiple PRs, each targeting a specific SIG. Do not submit PRs for\n/area code-organization\n/kind cleanup\nthis is only partially true, e.g. %w does not provide stack traces\n/assign\nI see. Should we close this issue then?\nI think it depends on how it's being used. If the traces are not the goal then we can do a simple substitution. It's probably best to drop read only dependencies ASAP but it's worth noting that if we depended on the full functionality in any way we'll need a more complex replacement (KIND did/does, not sure about k/k)\nk/k git log suggests that some cleanup has already been done in the past (maybe in other commits too): This issue triggered 3 PRs and 2 of them are merged. there does not seem to be calls to so most cases it looks it's just wrapping errors.\nfor cmd/kubeadm in kubernetes/kubernetes we decided to not drop usage of pkg/errors even if it's a deprecated project. prior ticket and comments are here\nfor cmd/kubeadm in kubernetes/kubernetes we decided to not drop usage of pkg/errors even if it's a deprecated project. prior ticket and comments are here\nI see. Added a note.\nis it still open ?\nshould be replaced with the standard library for the following reasons: archived library with no maintenance or security updates the go community used pkg/errors to introduce eventually into the standard library hence the approach that was selected is more idiomatic stack traces are hardly used in error wrapping and are not a reason not to refactor\nOn place left in Except the k/k repo, as is archived, some other repos may need an update.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nThe label cannot be applied. Only GitHub organization members can add the label. <detailsIn response to : /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis it necessary to remove \"\" from every location? I noticed it in many places. Also, do I need to create separate PRs for each file where I remove it?\n/assign\nFrom kuberentes/kubernetes repo view, only two locations of kubectl code should be updated. (Do not submit PRs for ) see For other repos, we should follow up until the dependencies' repo is updated. I will track them in\n/assign\n/assign\nto remove dependency you can use the standard Go error package or creating your own handling package, this could contain custom functions for generating and handling errors.\nlet me work on this issue now please /assign\nWe are in code freeze. I suggest waiting for a couple of weeks.\nHello, is this still up?\nLet's get this going\n/assign\nJust opened a PR for this issue\n/assign\nUpdate the remaining todo items.\n/sig architecture umbrella / code org\n/assign\nHey Are you still working on this one? If not- would you mind if I take a stab at it? Thanks!\nIs this issue really still open? When I do I only get hits for cmd/kubeadm. Am I missing something?\n/close\nClosing this issue. <detailsIn response to : /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-881f487c7d5ec6a348d872becf20cd39d9bcb213c5a6400fa8d70ebe8314fed5", "text": "func createWindowsJobObject(pc uint32) (windows.Handle, error) { job, err := windows.CreateJobObject(nil, nil) if err != nil { <del> return windows.InvalidHandle, errors.Wrap(err, \"windows.CreateJobObject failed\") </del> <ins> return windows.InvalidHandle, fmt.Errorf(\"windows.CreateJobObject failed: %w\", err) </ins> } limitInfo := windows.JOBOBJECT_BASIC_LIMIT_INFORMATION{ LimitFlags:    windows.JOB_OBJECT_LIMIT_PRIORITY_CLASS,", "commid": "kubernetes_pr_113672"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1237b61a9a420f0c0b04915325043b5410a2d3bac53dd2246fffcf46a7cfe4ca", "query": "Why is this needed? The functionality that the package provides is already present in golang's builtin errors (using in ) and the github repo is now read-only. /kind cleanup /priority backlog /good-first-issue Notes to people that want to collaborate Avoid creating a single PR for the entire repo. Create multiple PRs, each targeting a specific SIG. Do not submit PRs for\n/area code-organization\n/kind cleanup\nthis is only partially true, e.g. %w does not provide stack traces\n/assign\nI see. Should we close this issue then?\nI think it depends on how it's being used. If the traces are not the goal then we can do a simple substitution. It's probably best to drop read only dependencies ASAP but it's worth noting that if we depended on the full functionality in any way we'll need a more complex replacement (KIND did/does, not sure about k/k)\nk/k git log suggests that some cleanup has already been done in the past (maybe in other commits too): This issue triggered 3 PRs and 2 of them are merged. there does not seem to be calls to so most cases it looks it's just wrapping errors.\nfor cmd/kubeadm in kubernetes/kubernetes we decided to not drop usage of pkg/errors even if it's a deprecated project. prior ticket and comments are here\nfor cmd/kubeadm in kubernetes/kubernetes we decided to not drop usage of pkg/errors even if it's a deprecated project. prior ticket and comments are here\nI see. Added a note.\nis it still open ?\nshould be replaced with the standard library for the following reasons: archived library with no maintenance or security updates the go community used pkg/errors to introduce eventually into the standard library hence the approach that was selected is more idiomatic stack traces are hardly used in error wrapping and are not a reason not to refactor\nOn place left in Except the k/k repo, as is archived, some other repos may need an update.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nThe label cannot be applied. Only GitHub organization members can add the label. <detailsIn response to : /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis it necessary to remove \"\" from every location? I noticed it in many places. Also, do I need to create separate PRs for each file where I remove it?\n/assign\nFrom kuberentes/kubernetes repo view, only two locations of kubectl code should be updated. (Do not submit PRs for ) see For other repos, we should follow up until the dependencies' repo is updated. I will track them in\n/assign\n/assign\nto remove dependency you can use the standard Go error package or creating your own handling package, this could contain custom functions for generating and handling errors.\nlet me work on this issue now please /assign\nWe are in code freeze. I suggest waiting for a couple of weeks.\nHello, is this still up?\nLet's get this going\n/assign\nJust opened a PR for this issue\n/assign\nUpdate the remaining todo items.\n/sig architecture umbrella / code org\n/assign\nHey Are you still working on this one? If not- would you mind if I take a stab at it? Thanks!\nIs this issue really still open? When I do I only get hits for cmd/kubeadm. Am I missing something?\n/close\nClosing this issue. <detailsIn response to : /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-b8f8a06d9e27d7471d21e5fc0be14d6be393c1a7995067d319cfc97f82859209", "text": "windows.JobObjectBasicLimitInformation, uintptr(unsafe.Pointer(&limitInfo)), uint32(unsafe.Sizeof(limitInfo))); err != nil { <del> return windows.InvalidHandle, errors.Wrap(err, \"windows.SetInformationJobObject failed\") </del> <ins> return windows.InvalidHandle, fmt.Errorf(\"windows.SetInformationJobObject failed: %w\", err) </ins> } return job, nil }", "commid": "kubernetes_pr_113672"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1237b61a9a420f0c0b04915325043b5410a2d3bac53dd2246fffcf46a7cfe4ca", "query": "Why is this needed? The functionality that the package provides is already present in golang's builtin errors (using in ) and the github repo is now read-only. /kind cleanup /priority backlog /good-first-issue Notes to people that want to collaborate Avoid creating a single PR for the entire repo. Create multiple PRs, each targeting a specific SIG. Do not submit PRs for\n/area code-organization\n/kind cleanup\nthis is only partially true, e.g. %w does not provide stack traces\n/assign\nI see. Should we close this issue then?\nI think it depends on how it's being used. If the traces are not the goal then we can do a simple substitution. It's probably best to drop read only dependencies ASAP but it's worth noting that if we depended on the full functionality in any way we'll need a more complex replacement (KIND did/does, not sure about k/k)\nk/k git log suggests that some cleanup has already been done in the past (maybe in other commits too): This issue triggered 3 PRs and 2 of them are merged. there does not seem to be calls to so most cases it looks it's just wrapping errors.\nfor cmd/kubeadm in kubernetes/kubernetes we decided to not drop usage of pkg/errors even if it's a deprecated project. prior ticket and comments are here\nfor cmd/kubeadm in kubernetes/kubernetes we decided to not drop usage of pkg/errors even if it's a deprecated project. prior ticket and comments are here\nI see. Added a note.\nis it still open ?\nshould be replaced with the standard library for the following reasons: archived library with no maintenance or security updates the go community used pkg/errors to introduce eventually into the standard library hence the approach that was selected is more idiomatic stack traces are hardly used in error wrapping and are not a reason not to refactor\nOn place left in Except the k/k repo, as is archived, some other repos may need an update.\n/reopen\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nThe label cannot be applied. Only GitHub organization members can add the label. <detailsIn response to : /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis it necessary to remove \"\" from every location? I noticed it in many places. Also, do I need to create separate PRs for each file where I remove it?\n/assign\nFrom kuberentes/kubernetes repo view, only two locations of kubectl code should be updated. (Do not submit PRs for ) see For other repos, we should follow up until the dependencies' repo is updated. I will track them in\n/assign\n/assign\nto remove dependency you can use the standard Go error package or creating your own handling package, this could contain custom functions for generating and handling errors.\nlet me work on this issue now please /assign\nWe are in code freeze. I suggest waiting for a couple of weeks.\nHello, is this still up?\nLet's get this going\n/assign\nJust opened a PR for this issue\n/assign\nUpdate the remaining todo items.\n/sig architecture umbrella / code org\n/assign\nHey Are you still working on this one? If not- would you mind if I take a stab at it? Thanks!\nIs this issue really still open? When I do I only get hits for cmd/kubeadm. Am I missing something?\n/close\nClosing this issue. <detailsIn response to : /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-044508cc8890a3b5cf143e81cafe0349b661e0b1a236d9150c16f2e00a6ac093", "text": "return err } if err := windows.AssignProcessToJobObject(job, windows.CurrentProcess()); err != nil { <del> return errors.Wrap(err, \"windows.AssignProcessToJobObject failed\") </del> <ins> return fmt.Errorf(\"windows.AssignProcessToJobObject failed: %w\", err) </ins> } if windowsService {", "commid": "kubernetes_pr_113672"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ec1f2b5e3111beba9c3d5972d4887c5fb5222f18baca7cc1195b15978a145ffe", "query": "It was found during a review that stateful set status might not be correctly updated when new revision is being rolled out and API error occurs when deleting a pod. The status should be updated correctly Not easy to reproduce, but should be possible with this unit test No response_ <details</details<details</details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps", "positive_passages": [{"docid": "doc-en-kubernetes-1b81cab78b3be285a7de1fe08224f3e0e9dd2edbee19c49b110dfd21f6077d54", "text": "if getPodRevision(replicas[target]) != updateRevision.Name && !isTerminating(replicas[target]) { klog.V(2).InfoS(\"Pod of StatefulSet is terminating for update\", \"statefulSet\", klog.KObj(set), \"pod\", klog.KObj(replicas[target])) <del> err := ssc.podControl.DeleteStatefulPod(set, replicas[target]) </del> <ins> if err := ssc.podControl.DeleteStatefulPod(set, replicas[target]); err != nil { if !errors.IsNotFound(err) { return &status, err } } </ins> status.CurrentReplicas-- return &status, err }", "commid": "kubernetes_pr_113834"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ec1f2b5e3111beba9c3d5972d4887c5fb5222f18baca7cc1195b15978a145ffe", "query": "It was found during a review that stateful set status might not be correctly updated when new revision is being rolled out and API error occurs when deleting a pod. The status should be updated correctly Not easy to reproduce, but should be possible with this unit test No response_ <details</details<details</details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps", "positive_passages": [{"docid": "doc-en-kubernetes-93d10f14d22084814069711852b9f7520c53a05eb83bf26a8149dd478cdbf201", "text": "{UpdatePodFailure, simpleSetFn}, {UpdateSetStatusFailure, simpleSetFn}, {PodRecreateDeleteFailure, simpleSetFn}, <ins> {NewRevisionDeletePodFailure, simpleSetFn}, </ins> } for _, testCase := range testCases {", "commid": "kubernetes_pr_113834"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-ec1f2b5e3111beba9c3d5972d4887c5fb5222f18baca7cc1195b15978a145ffe", "query": "It was found during a review that stateful set status might not be correctly updated when new revision is being rolled out and API error occurs when deleting a pod. The status should be updated correctly Not easy to reproduce, but should be possible with this unit test No response_ <details</details<details</details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig apps", "positive_passages": [{"docid": "doc-en-kubernetes-a8cdb49cea2f148f26828b00c69742add3e4f5706c5399e0c24babab8f9d491a", "text": "} } <ins> func NewRevisionDeletePodFailure(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) { client := fake.NewSimpleClientset(set) om, _, ssc := setupController(client) if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil { t.Errorf(\"Failed to turn up StatefulSet : %s\", err) } var err error set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name) if err != nil { t.Fatalf(\"Error getting updated StatefulSet: %v\", err) } if set.Status.Replicas != 3 { t.Error(\"Failed to scale StatefulSet to 3 replicas\") } selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector) if err != nil { t.Error(err) } pods, err := om.podsLister.Pods(set.Namespace).List(selector) if err != nil { t.Error(err) } // trigger a new revision updateSet := set.DeepCopy() updateSet.Spec.Template.Spec.Containers[0].Image = \"nginx-new\" if err := om.setsIndexer.Update(updateSet); err != nil { t.Error(\"Failed to update StatefulSet\") } set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name) if err != nil { t.Fatalf(\"Error getting updated StatefulSet: %v\", err) } // delete fails om.SetDeleteStatefulPodError(apierrors.NewInternalError(errors.New(\"API server failed\")), 0) _, err = ssc.UpdateStatefulSet(context.TODO(), set, pods) if err == nil { t.Error(\"Expected err in update StatefulSet when deleting a pod\") } set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name) if err != nil { t.Fatalf(\"Error getting updated StatefulSet: %v\", err) } if err := invariants(set, om); err != nil { t.Error(err) } if set.Status.CurrentReplicas != 3 { t.Fatalf(\"Failed pod deletion should not update CurrentReplicas: want 3, got %d\", set.Status.CurrentReplicas) } if set.Status.CurrentRevision == set.Status.UpdateRevision { t.Error(\"Failed to create new revision\") } // delete works om.SetDeleteStatefulPodError(nil, 0) status, err := ssc.UpdateStatefulSet(context.TODO(), set, pods) if err != nil { t.Fatalf(\"Unexpected err in update StatefulSet: %v\", err) } if status.CurrentReplicas != 2 { t.Fatalf(\"Pod deletion should update CurrentReplicas: want 2, got %d\", status.CurrentReplicas) } if err := invariants(set, om); err != nil { t.Error(err) } } </ins> func emptyInvariants(set *apps.StatefulSet, om *fakeObjectManager) error { return nil }", "commid": "kubernetes_pr_113834"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f2910a5a7757744dd88700c551fb3f5fe81db92c4ae532e768f1444ef3ba7b10", "query": "It's at line 111 When the server stopped before timeout, the first goroutine will be block on because the receiver in the second goroutine is not exist. Changing to a buffered one may fix it. no goroutine leaks run related test with leak checker No response <detailsdev </details<detailsunknown </details<details</details<details</details<details</details<details</details\n/sig api-machinery\n/assign /triage accepted\n/cc\nIt should close the channel rather than write to it, that's the easiest fix", "positive_passages": [{"docid": "doc-en-kubernetes-1bb34495b1d041d5d95e073f59088059ce3d68f35de964beecd12f72511b1d16", "text": "} interval := time.NewTicker(time.Millisecond * 500) defer interval.Stop() <del> done := make(chan bool, 1) </del> <ins> done := make(chan bool) </ins> go func() { time.Sleep(time.Minute * 2) <del> done <- true </del> <ins> close(done) </ins> }() for { select {", "commid": "kubernetes_pr_114071"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f2910a5a7757744dd88700c551fb3f5fe81db92c4ae532e768f1444ef3ba7b10", "query": "It's at line 111 When the server stopped before timeout, the first goroutine will be block on because the receiver in the second goroutine is not exist. Changing to a buffered one may fix it. no goroutine leaks run related test with leak checker No response <detailsdev </details<detailsunknown </details<details</details<details</details<details</details<details</details\n/sig api-machinery\n/assign /triage accepted\n/cc\nIt should close the channel rather than write to it, that's the easiest fix", "positive_passages": [{"docid": "doc-en-kubernetes-95c58e1230e051455e52970857e78f2c2a51ca86f779d02394eca54298f5f413", "text": "timedout := make(chan bool) go func() { time.Sleep(gracefulWait) <del> timedout <- true </del> <ins> close(timedout) </ins> }() go func() { select {", "commid": "kubernetes_pr_114071"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f2910a5a7757744dd88700c551fb3f5fe81db92c4ae532e768f1444ef3ba7b10", "query": "It's at line 111 When the server stopped before timeout, the first goroutine will be block on because the receiver in the second goroutine is not exist. Changing to a buffered one may fix it. no goroutine leaks run related test with leak checker No response <detailsdev </details<detailsunknown </details<details</details<details</details<details</details<details</details\n/sig api-machinery\n/assign /triage accepted\n/cc\nIt should close the channel rather than write to it, that's the easiest fix", "positive_passages": [{"docid": "doc-en-kubernetes-86a25aed3aa0af9d5c4e2b2180ea579278ca5076c77702b4bb8b4fb1b2da2778", "text": "} }() err = r.cmd.Wait() <del> stopped <- true </del> <ins> close(stopped) </ins> if exiterr, ok := err.(*exec.ExitError); ok { klog.Infof(\"etcd server stopped (signal: %s)\", exiterr.Error()) // stopped", "commid": "kubernetes_pr_114071"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7718a29788b98b66982a35f9fbeb8ad977aaca8c841112c95b4581bb5c967dce", "query": "Events from node taint manager doesn't report involved object apiVersion: ! apiVersion is reported as other events. For example: ! a pod on node A (not master) off node A is reported, but without apiVersion in involvedObject. The apiVersion is not reported in The issue is still not fixed in master: ! <details</details<detailsIrrelevant </details<details</details<details</details<details</details<details</details\n/sig node /sig apps\n/assign In the latest version, the issue is confirmed\none suggestion you should wait for the corresponding SIG to triage the issue and accept it before sending PRs, the chances of your PR getting reviewed and approver are much higher\nYou are right sorry about that. It won\u2019t happen again.\nno no worries, it was a suggestion, is not that you did something wrong, but it is possible that your PR doesn't get reviews and you get frustrated\n/remove-sig node please re-add if this is node-related issue\nI think it is a node related issue. The root cause in taint manager.\n/sig node\n/assign /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-c3efdefcf1b0213c11b5b0f794a0940b5fa03eb3dfdf700ed0dcedbea6da2c6c", "text": "return } ref := &v1.ObjectReference{ <del> Kind:      \"Pod\", Name:      nsName.Name, Namespace: nsName.Namespace, </del> <ins> APIVersion: \"v1\", Kind:       \"Pod\", Name:       nsName.Name, Namespace:  nsName.Namespace, </ins> } tc.recorder.Eventf(ref, v1.EventTypeNormal, \"TaintManagerEviction\", \"Marking for deletion Pod %s\", nsName.String()) }", "commid": "kubernetes_pr_114095"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7718a29788b98b66982a35f9fbeb8ad977aaca8c841112c95b4581bb5c967dce", "query": "Events from node taint manager doesn't report involved object apiVersion: ! apiVersion is reported as other events. For example: ! a pod on node A (not master) off node A is reported, but without apiVersion in involvedObject. The apiVersion is not reported in The issue is still not fixed in master: ! <details</details<detailsIrrelevant </details<details</details<details</details<details</details<details</details\n/sig node /sig apps\n/assign In the latest version, the issue is confirmed\none suggestion you should wait for the corresponding SIG to triage the issue and accept it before sending PRs, the chances of your PR getting reviewed and approver are much higher\nYou are right sorry about that. It won\u2019t happen again.\nno no worries, it was a suggestion, is not that you did something wrong, but it is possible that your PR doesn't get reviews and you get frustrated\n/remove-sig node please re-add if this is node-related issue\nI think it is a node related issue. The root cause in taint manager.\n/sig node\n/assign /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-559e2f0a2bcc27c25b0a5f92cdb4491a4fa3a090803238883ce4e65e4b578790", "text": "return } ref := &v1.ObjectReference{ <del> Kind:      \"Pod\", Name:      nsName.Name, Namespace: nsName.Namespace, </del> <ins> APIVersion: \"v1\", Kind:       \"Pod\", Name:       nsName.Name, Namespace:  nsName.Namespace, </ins> } tc.recorder.Eventf(ref, v1.EventTypeNormal, \"TaintManagerEviction\", \"Cancelling deletion of Pod %s\", nsName.String()) }", "commid": "kubernetes_pr_114095"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7718a29788b98b66982a35f9fbeb8ad977aaca8c841112c95b4581bb5c967dce", "query": "Events from node taint manager doesn't report involved object apiVersion: ! apiVersion is reported as other events. For example: ! a pod on node A (not master) off node A is reported, but without apiVersion in involvedObject. The apiVersion is not reported in The issue is still not fixed in master: ! <details</details<detailsIrrelevant </details<details</details<details</details<details</details<details</details\n/sig node /sig apps\n/assign In the latest version, the issue is confirmed\none suggestion you should wait for the corresponding SIG to triage the issue and accept it before sending PRs, the chances of your PR getting reviewed and approver are much higher\nYou are right sorry about that. It won\u2019t happen again.\nno no worries, it was a suggestion, is not that you did something wrong, but it is possible that your PR doesn't get reviews and you get frustrated\n/remove-sig node please re-add if this is node-related issue\nI think it is a node related issue. The root cause in taint manager.\n/sig node\n/assign /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-3b546bc510fb8f0e1d76e687a0830836fb800db91194f70269d0eec1bed51f1d", "text": "\"testing\" \"time\" <ins> \"github.com/google/go-cmp/cmp\" </ins> v1 \"k8s.io/api/core/v1\" <ins> metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" </ins> \"k8s.io/apimachinery/pkg/fields\" \"k8s.io/apimachinery/pkg/labels\" \"k8s.io/apimachinery/pkg/types\"", "commid": "kubernetes_pr_114095"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7718a29788b98b66982a35f9fbeb8ad977aaca8c841112c95b4581bb5c967dce", "query": "Events from node taint manager doesn't report involved object apiVersion: ! apiVersion is reported as other events. For example: ! a pod on node A (not master) off node A is reported, but without apiVersion in involvedObject. The apiVersion is not reported in The issue is still not fixed in master: ! <details</details<detailsIrrelevant </details<details</details<details</details<details</details<details</details\n/sig node /sig apps\n/assign In the latest version, the issue is confirmed\none suggestion you should wait for the corresponding SIG to triage the issue and accept it before sending PRs, the chances of your PR getting reviewed and approver are much higher\nYou are right sorry about that. It won\u2019t happen again.\nno no worries, it was a suggestion, is not that you did something wrong, but it is possible that your PR doesn't get reviews and you get frustrated\n/remove-sig node please re-add if this is node-related issue\nI think it is a node related issue. The root cause in taint manager.\n/sig node\n/assign /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-cf18add881e048df34f006f85bf4a99c9553be1e96376e86fc05986a59a19d45", "text": "featuregatetesting \"k8s.io/component-base/featuregate/testing\" \"k8s.io/kubernetes/pkg/controller/testutil\" \"k8s.io/kubernetes/pkg/features\" <del> metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" </del> ) var timeForControllerToProgressForSanityCheck = 20 * time.Millisecond", "commid": "kubernetes_pr_114095"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7718a29788b98b66982a35f9fbeb8ad977aaca8c841112c95b4581bb5c967dce", "query": "Events from node taint manager doesn't report involved object apiVersion: ! apiVersion is reported as other events. For example: ! a pod on node A (not master) off node A is reported, but without apiVersion in involvedObject. The apiVersion is not reported in The issue is still not fixed in master: ! <details</details<detailsIrrelevant </details<details</details<details</details<details</details<details</details\n/sig node /sig apps\n/assign In the latest version, the issue is confirmed\none suggestion you should wait for the corresponding SIG to triage the issue and accept it before sending PRs, the chances of your PR getting reviewed and approver are much higher\nYou are right sorry about that. It won\u2019t happen again.\nno no worries, it was a suggestion, is not that you did something wrong, but it is possible that your PR doesn't get reviews and you get frustrated\n/remove-sig node please re-add if this is node-related issue\nI think it is a node related issue. The root cause in taint manager.\n/sig node\n/assign /triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-42e49b939a114222aff19db006b56ff573886edb4ca06e5d0e6b42eb6482bb78", "text": "t.Errorf(\"[%v]Unexpected test result. Expected delete %v, got %v\", description, expectDelete, podDeleted) } } <ins> // TestPodDeletionEvent Verify that the output events are as expected func TestPodDeletionEvent(t *testing.T) { f := func(path cmp.Path) bool { switch path.String() { // These fields change at runtime, so ignore it case \"LastTimestamp\", \"FirstTimestamp\", \"ObjectMeta.Name\": return true } return false } t.Run(\"emitPodDeletionEvent\", func(t *testing.T) { controller := &NoExecuteTaintManager{} recorder := testutil.NewFakeRecorder() controller.recorder = recorder controller.emitPodDeletionEvent(types.NamespacedName{ Name:      \"test\", Namespace: \"test\", }) want := []*v1.Event{ { ObjectMeta: metav1.ObjectMeta{ Namespace: \"test\", }, InvolvedObject: v1.ObjectReference{ Kind:       \"Pod\", APIVersion: \"v1\", Namespace:  \"test\", Name:       \"test\", }, Reason:  \"TaintManagerEviction\", Type:    \"Normal\", Count:   1, Message: \"Marking for deletion Pod test/test\", Source:  v1.EventSource{Component: \"nodeControllerTest\"}, }, } if diff := cmp.Diff(want, recorder.Events, cmp.FilterPath(f, cmp.Ignore())); len(diff) > 0 { t.Errorf(\"emitPodDeletionEvent() returned data (-want,+got):n%s\", diff) } }) t.Run(\"emitCancelPodDeletionEvent\", func(t *testing.T) { controller := &NoExecuteTaintManager{} recorder := testutil.NewFakeRecorder() controller.recorder = recorder controller.emitCancelPodDeletionEvent(types.NamespacedName{ Name:      \"test\", Namespace: \"test\", }) want := []*v1.Event{ { ObjectMeta: metav1.ObjectMeta{ Namespace: \"test\", }, InvolvedObject: v1.ObjectReference{ Kind:       \"Pod\", APIVersion: \"v1\", Namespace:  \"test\", Name:       \"test\", }, Reason:  \"TaintManagerEviction\", Type:    \"Normal\", Count:   1, Message: \"Cancelling deletion of Pod test/test\", Source:  v1.EventSource{Component: \"nodeControllerTest\"}, }, } if diff := cmp.Diff(want, recorder.Events, cmp.FilterPath(f, cmp.Ignore())); len(diff) > 0 { t.Errorf(\"emitPodDeletionEvent() returned data (-want,+got):n%s\", diff) } }) } </ins>", "commid": "kubernetes_pr_114095"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d3f41b4011457970a44dc6eb8b0abccf584d90cb550d7555d38ecc0463a883", "query": "For 1.27 we should graduate the ReadWriteOncePod feature to beta. This is needed to rollout the feature to GA. In beta this feature will support preemption of pods using PVCs. See:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage /sig scheduling", "positive_passages": [{"docid": "doc-en-kubernetes-7f6359f8009a905146c68591c2df21e80c4a5ddd068c74724afa7eaeff417d2b", "text": "QOSReserved featuregate.Feature = \"QOSReserved\" // owner: @chrishenzie <ins> // kep: https://kep.k8s.io/2485 </ins> // alpha: v1.22 <ins> // beta: v1.27 </ins> // // Enables usage of the ReadWriteOncePod PersistentVolume access mode. ReadWriteOncePod featuregate.Feature = \"ReadWriteOncePod\"", "commid": "kubernetes_pr_114494"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d3f41b4011457970a44dc6eb8b0abccf584d90cb550d7555d38ecc0463a883", "query": "For 1.27 we should graduate the ReadWriteOncePod feature to beta. This is needed to rollout the feature to GA. In beta this feature will support preemption of pods using PVCs. See:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage /sig scheduling", "positive_passages": [{"docid": "doc-en-kubernetes-0a16b5ecc9be6e2428d0e6b98c200dac304cc003f5d2a224805d5f94ce93e9bf", "text": "QOSReserved: {Default: false, PreRelease: featuregate.Alpha}, <del> ReadWriteOncePod: {Default: false, PreRelease: featuregate.Alpha}, </del> <ins> ReadWriteOncePod: {Default: true, PreRelease: featuregate.Beta}, </ins> RecoverVolumeExpansionFailure: {Default: false, PreRelease: featuregate.Alpha},", "commid": "kubernetes_pr_114494"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d3f41b4011457970a44dc6eb8b0abccf584d90cb550d7555d38ecc0463a883", "query": "For 1.27 we should graduate the ReadWriteOncePod feature to beta. This is needed to rollout the feature to GA. In beta this feature will support preemption of pods using PVCs. See:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage /sig scheduling", "positive_passages": [{"docid": "doc-en-kubernetes-5953a87766769761732ebcdcea96a76a7df9e6aab24a70a0165adc4e01b3ab61", "text": "\"github.com/onsi/ginkgo/v2\" v1 \"k8s.io/api/core/v1\" <ins> schedulingv1 \"k8s.io/api/scheduling/v1\" </ins> metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/fields\" errors \"k8s.io/apimachinery/pkg/util/errors\" <ins> \"k8s.io/apimachinery/pkg/util/uuid\" </ins> clientset \"k8s.io/client-go/kubernetes\" \"k8s.io/kubernetes/pkg/kubelet/events\" \"k8s.io/kubernetes/test/e2e/framework\"", "commid": "kubernetes_pr_114494"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d3f41b4011457970a44dc6eb8b0abccf584d90cb550d7555d38ecc0463a883", "query": "For 1.27 we should graduate the ReadWriteOncePod feature to beta. This is needed to rollout the feature to GA. In beta this feature will support preemption of pods using PVCs. See:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage /sig scheduling", "positive_passages": [{"docid": "doc-en-kubernetes-e3b0a1d1a8ac2daeb2621b38a091dc56c063acc5ab92497aa6ea140c63e648cd", "text": "type readWriteOncePodTest struct { config *storageframework.PerTestConfig <del> cs     clientset.Interface volume *storageframework.VolumeResource pods   []*v1.Pod </del> <ins> cs            clientset.Interface volume        *storageframework.VolumeResource pods          []*v1.Pod priorityClass *schedulingv1.PriorityClass </ins> migrationCheck *migrationOpCheck }", "commid": "kubernetes_pr_114494"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d3f41b4011457970a44dc6eb8b0abccf584d90cb550d7555d38ecc0463a883", "query": "For 1.27 we should graduate the ReadWriteOncePod feature to beta. This is needed to rollout the feature to GA. In beta this feature will support preemption of pods using PVCs. See:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage /sig scheduling", "positive_passages": [{"docid": "doc-en-kubernetes-db8d3802dc354affbf2415d06d78696115f36193a02c4dca075d1433cda40746", "text": "tsInfo: storageframework.TestSuiteInfo{ Name:         \"read-write-once-pod\", TestPatterns: patterns, <del> FeatureTag:   \"[Feature:ReadWriteOncePod]\", </del> }, } }", "commid": "kubernetes_pr_114494"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d3f41b4011457970a44dc6eb8b0abccf584d90cb550d7555d38ecc0463a883", "query": "For 1.27 we should graduate the ReadWriteOncePod feature to beta. This is needed to rollout the feature to GA. In beta this feature will support preemption of pods using PVCs. See:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage /sig scheduling", "positive_passages": [{"docid": "doc-en-kubernetes-a8504e0b194bcc5f8a0ff2c0c76073ef27676f43528abffe1df9bc8b481f238b", "text": "err := l.volume.CleanupResource(ctx) errs = append(errs, err) <ins> if l.priorityClass != nil { framework.Logf(\"Deleting PriorityClass %v\", l.priorityClass.Name) err := l.cs.SchedulingV1().PriorityClasses().Delete(ctx, l.priorityClass.Name, metav1.DeleteOptions{}) errs = append(errs, err) } </ins> framework.ExpectNoError(errors.NewAggregate(errs), \"while cleaning up resource\") l.migrationCheck.validateMigrationVolumeOpCounts(ctx) }", "commid": "kubernetes_pr_114494"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d3f41b4011457970a44dc6eb8b0abccf584d90cb550d7555d38ecc0463a883", "query": "For 1.27 we should graduate the ReadWriteOncePod feature to beta. This is needed to rollout the feature to GA. In beta this feature will support preemption of pods using PVCs. See:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage /sig scheduling", "positive_passages": [{"docid": "doc-en-kubernetes-94e60e759438403e7f5a112f4ae6517c54fc76454be6af44e1b83319b10b2859", "text": "ginkgo.DeferCleanup(cleanup) }) <del> ginkgo.It(\"should block a second pod from using an in-use ReadWriteOncePod volume\", func(ctx context.Context) { </del> <ins> ginkgo.It(\"should preempt lower priority pods using ReadWriteOncePod volumes\", func(ctx context.Context) { </ins> // Create the ReadWriteOncePod PVC. accessModes := []v1.PersistentVolumeAccessMode{v1.ReadWriteOncePod} l.volume = storageframework.CreateVolumeResourceWithAccessModes(ctx, driver, l.config, pattern, t.GetTestSuiteInfo().SupportedSizeRange, accessModes) <ins> l.priorityClass = &schedulingv1.PriorityClass{ ObjectMeta: metav1.ObjectMeta{Name: \"e2e-test-read-write-once-pod-\" + string(uuid.NewUUID())}, Value:      int32(1000), } _, err := l.cs.SchedulingV1().PriorityClasses().Create(ctx, l.priorityClass, metav1.CreateOptions{}) framework.ExpectNoError(err, \"failed to create priority class\") </ins> podConfig := e2epod.Config{ NS:           f.Namespace.Name, PVCs:         []*v1.PersistentVolumeClaim{l.volume.Pvc},", "commid": "kubernetes_pr_114494"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d3f41b4011457970a44dc6eb8b0abccf584d90cb550d7555d38ecc0463a883", "query": "For 1.27 we should graduate the ReadWriteOncePod feature to beta. This is needed to rollout the feature to GA. In beta this feature will support preemption of pods using PVCs. See:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage /sig scheduling", "positive_passages": [{"docid": "doc-en-kubernetes-5c24de8b325db41b337232a7756baddc260a20f5d6462c2b1bf7a113cb5aa0a0", "text": "framework.ExpectNoError(err, \"failed to wait for pod1 running status\") l.pods = append(l.pods, pod1) <del> // Create the second pod, which will fail scheduling because the ReadWriteOncePod PVC is already in use. </del> <ins> // Create the second pod, which will preempt the first pod because it's using the // ReadWriteOncePod PVC and has higher priority. </ins> pod2, err := e2epod.MakeSecPod(&podConfig) framework.ExpectNoError(err, \"failed to create spec for pod2\") <ins> pod2.Spec.PriorityClassName = l.priorityClass.Name </ins> _, err = l.cs.CoreV1().Pods(pod2.Namespace).Create(ctx, pod2, metav1.CreateOptions{}) framework.ExpectNoError(err, \"failed to create pod2\") <del> err = e2epod.WaitForPodNameUnschedulableInNamespace(ctx, l.cs, pod2.Name, pod2.Namespace) framework.ExpectNoError(err, \"failed to wait for pod2 unschedulable status\") </del> l.pods = append(l.pods, pod2) <del> // Delete the first pod and observe the second pod can now start. err = e2epod.DeletePodWithWait(ctx, l.cs, pod1) framework.ExpectNoError(err, \"failed to delete pod1\") </del> <ins> // Wait for the first pod to be preempted and the second pod to start. err = e2epod.WaitForPodNotFoundInNamespace(ctx, l.cs, pod1.Name, pod1.Namespace, f.Timeouts.PodStart) framework.ExpectNoError(err, \"failed to wait for pod1 to be preempted\") </ins> err = e2epod.WaitTimeoutForPodRunningInNamespace(ctx, l.cs, pod2.Name, pod2.Namespace, f.Timeouts.PodStart) framework.ExpectNoError(err, \"failed to wait for pod2 running status\") <ins> // Recreate the first pod, which will fail to schedule because the second pod // is using the ReadWriteOncePod PVC and has higher priority. _, err = l.cs.CoreV1().Pods(pod1.Namespace).Create(ctx, pod1, metav1.CreateOptions{}) framework.ExpectNoError(err, \"failed to create pod1\") err = e2epod.WaitForPodNameUnschedulableInNamespace(ctx, l.cs, pod1.Name, pod1.Namespace) framework.ExpectNoError(err, \"failed to wait for pod1 unschedulable status\") // Delete the second pod with higher priority and observe the first pod can now start. err = e2epod.DeletePodWithWait(ctx, l.cs, pod2) framework.ExpectNoError(err, \"failed to delete pod2\") err = e2epod.WaitTimeoutForPodRunningInNamespace(ctx, l.cs, pod1.Name, pod1.Namespace, f.Timeouts.PodStart) framework.ExpectNoError(err, \"failed to wait for pod1 running status\") </ins> }) ginkgo.It(\"should block a second pod from using an in-use ReadWriteOncePod volume on the same node\", func(ctx context.Context) {", "commid": "kubernetes_pr_114494"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-00d3f41b4011457970a44dc6eb8b0abccf584d90cb550d7555d38ecc0463a883", "query": "For 1.27 we should graduate the ReadWriteOncePod feature to beta. This is needed to rollout the feature to GA. In beta this feature will support preemption of pods using PVCs. See:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage /sig scheduling", "positive_passages": [{"docid": "doc-en-kubernetes-e5cd31dfe5b443de321beffe6f81fd00a7fd2b8f22b9ec2099fab26e16b72697", "text": "serviceAccountName: csi-hostpathplugin-sa containers: - name: hostpath <del> image: registry.k8s.io/sig-storage/hostpathplugin:v1.9.0 </del> <ins> image: registry.k8s.io/sig-storage/hostpathplugin:v1.11.0 </ins> args: - \"--drivername=hostpath.csi.k8s.io\" - \"--v=5\"", "commid": "kubernetes_pr_114494"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-61647fea4f7cc5c6dab498ac59084869bf5ba9359cc60d961aee8801ff28bc5d", "text": "command := exec.Command(\"umount\", target) output, err := command.CombinedOutput() if err != nil { <del> if err.Error() == errNoChildProcesses { if command.ProcessState.Success() { // We don't consider errNoChildProcesses an error if the process itself succeeded (see - k/k issue #103753). return nil } // Rewrite err with the actual exit error of the process. err = &exec.ExitError{ProcessState: command.ProcessState} } if mounter.withSafeNotMountedBehavior && strings.Contains(string(output), errNotMounted) { klog.V(4).Infof(\"ignoring 'not mounted' error for %s\", target) return nil } return fmt.Errorf(\"unmount failed: %vnUnmounting arguments: %snOutput: %s\", err, target, string(output)) </del> <ins> return checkUmountError(target, command, output, err, mounter.withSafeNotMountedBehavior) </ins> } return nil }", "commid": "kubernetes_pr_114605"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-377ccfbf775d1e9ffdcf76e091db7351528f419c681b17c08328f7a5fa04525b", "text": "// UnmountWithForce unmounts given target but will retry unmounting with force option // after given timeout. func (mounter *Mounter) UnmountWithForce(target string, umountTimeout time.Duration) error { <del> err := tryUnmount(mounter, target, umountTimeout) </del> <ins> err := tryUnmount(target, mounter.withSafeNotMountedBehavior, umountTimeout) </ins> if err != nil { if err == context.DeadlineExceeded { klog.V(2).Infof(\"Timed out waiting for unmount of %s, trying with -f\", target) <del> err = forceUmount(target) </del> <ins> err = forceUmount(target, mounter.withSafeNotMountedBehavior) </ins> } return err }", "commid": "kubernetes_pr_114605"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-153ec76bdf93a2c9767070adb6f6ee8e66918f0dc6e85af80a8bd8a8fcdcd956", "text": "} // tryUnmount calls plain \"umount\" and waits for unmountTimeout for it to finish. <del> func tryUnmount(mounter *Mounter, path string, unmountTimeout time.Duration) error { klog.V(4).Infof(\"Unmounting %s\", path) </del> <ins> func tryUnmount(target string, withSafeNotMountedBehavior bool, unmountTimeout time.Duration) error { klog.V(4).Infof(\"Unmounting %s\", target) </ins> ctx, cancel := context.WithTimeout(context.Background(), unmountTimeout) defer cancel() <del> cmd := exec.CommandContext(ctx, \"umount\", path) out, cmderr := cmd.CombinedOutput() </del> <ins> command := exec.CommandContext(ctx, \"umount\", target) output, err := command.CombinedOutput() </ins> // CombinedOutput() does not return DeadlineExceeded, make sure it's // propagated on timeout.", "commid": "kubernetes_pr_114605"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-2b7bec511880531f4cdd70c8b4a9856c0e97fbffbd6a09bd51e5f6eccf1e90e6", "text": "return ctx.Err() } <del> if cmderr != nil { if mounter.withSafeNotMountedBehavior && strings.Contains(string(out), errNotMounted) { klog.V(4).Infof(\"ignoring 'not mounted' error for %s\", path) return nil } return fmt.Errorf(\"unmount failed: %vnUnmounting arguments: %snOutput: %s\", cmderr, path, string(out)) </del> <ins> if err != nil { return checkUmountError(target, command, output, err, withSafeNotMountedBehavior) </ins> } return nil } <del> func forceUmount(path string) error { cmd := exec.Command(\"umount\", \"-f\", path) out, cmderr := cmd.CombinedOutput() </del> <ins> func forceUmount(target string, withSafeNotMountedBehavior bool) error { command := exec.Command(\"umount\", \"-f\", target) output, err := command.CombinedOutput() </ins> <del> if cmderr != nil { return fmt.Errorf(\"unmount failed: %vnUnmounting arguments: %snOutput: %s\", cmderr, path, string(out)) </del> <ins> if err != nil { return checkUmountError(target, command, output, err, withSafeNotMountedBehavior) </ins> } return nil } <ins> // checkUmountError checks a result of umount command and determine a return value. func checkUmountError(target string, command *exec.Cmd, output []byte, err error, withSafeNotMountedBehavior bool) error { if err.Error() == errNoChildProcesses { if command.ProcessState.Success() { // We don't consider errNoChildProcesses an error if the process itself succeeded (see - k/k issue #103753). return nil } // Rewrite err with the actual exit error of the process. err = &exec.ExitError{ProcessState: command.ProcessState} } if withSafeNotMountedBehavior && strings.Contains(string(output), errNotMounted) { klog.V(4).Infof(\"ignoring 'not mounted' error for %s\", target) return nil } return fmt.Errorf(\"unmount failed: %vnUnmounting arguments: %snOutput: %s\", err, target, string(output)) } </ins>", "commid": "kubernetes_pr_114605"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-14f82cd59f6b8474588f1f2f9bee62af0d328529cd6e114e05d34174b718b843", "text": "\"reflect\" \"strings\" \"testing\" <ins> \"time\" </ins> utilexec \"k8s.io/utils/exec\" testexec \"k8s.io/utils/exec/testing\"", "commid": "kubernetes_pr_114605"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-c36fcfdc5bb58bd809d02b9f813244194b5cc37d091d1863d8fccc24a6ed0973", "text": "return testexec.InitFakeCmd(&c, cmd, args...) } } <ins> func TestNotMountedBehaviorOfUnmount(t *testing.T) { target, err := ioutil.TempDir(\"\", \"kubelet-umount\") if err != nil { t.Errorf(\"Cannot create temp dir: %v\", err) } defer os.RemoveAll(target) m := Mounter{withSafeNotMountedBehavior: true} if err = m.Unmount(target); err != nil { t.Errorf(`Expect complete Unmount(), but it dose not: %v`, err) } if err = tryUnmount(target, m.withSafeNotMountedBehavior, time.Minute); err != nil { t.Errorf(`Expect complete tryUnmount(), but it does not: %v`, err) } // forceUmount exec \"umount -f\", so skip this case if user is not root. if os.Getuid() == 0 { if err = forceUmount(target, m.withSafeNotMountedBehavior); err != nil { t.Errorf(`Expect complete forceUnmount(), but it does not: %v`, err) } } } </ins>", "commid": "kubernetes_pr_114605"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-61647fea4f7cc5c6dab498ac59084869bf5ba9359cc60d961aee8801ff28bc5d", "text": "command := exec.Command(\"umount\", target) output, err := command.CombinedOutput() if err != nil { <del> if err.Error() == errNoChildProcesses { if command.ProcessState.Success() { // We don't consider errNoChildProcesses an error if the process itself succeeded (see - k/k issue #103753). return nil } // Rewrite err with the actual exit error of the process. err = &exec.ExitError{ProcessState: command.ProcessState} } if mounter.withSafeNotMountedBehavior && strings.Contains(string(output), errNotMounted) { klog.V(4).Infof(\"ignoring 'not mounted' error for %s\", target) return nil } return fmt.Errorf(\"unmount failed: %vnUnmounting arguments: %snOutput: %s\", err, target, string(output)) </del> <ins> return checkUmountError(target, command, output, err, mounter.withSafeNotMountedBehavior) </ins> } return nil }", "commid": "kubernetes_pr_115769"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-377ccfbf775d1e9ffdcf76e091db7351528f419c681b17c08328f7a5fa04525b", "text": "// UnmountWithForce unmounts given target but will retry unmounting with force option // after given timeout. func (mounter *Mounter) UnmountWithForce(target string, umountTimeout time.Duration) error { <del> err := tryUnmount(mounter, target, umountTimeout) </del> <ins> err := tryUnmount(target, mounter.withSafeNotMountedBehavior, umountTimeout) </ins> if err != nil { if err == context.DeadlineExceeded { klog.V(2).Infof(\"Timed out waiting for unmount of %s, trying with -f\", target) <del> err = forceUmount(target) </del> <ins> err = forceUmount(target, mounter.withSafeNotMountedBehavior) </ins> } return err }", "commid": "kubernetes_pr_115769"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-153ec76bdf93a2c9767070adb6f6ee8e66918f0dc6e85af80a8bd8a8fcdcd956", "text": "} // tryUnmount calls plain \"umount\" and waits for unmountTimeout for it to finish. <del> func tryUnmount(mounter *Mounter, path string, unmountTimeout time.Duration) error { klog.V(4).Infof(\"Unmounting %s\", path) </del> <ins> func tryUnmount(target string, withSafeNotMountedBehavior bool, unmountTimeout time.Duration) error { klog.V(4).Infof(\"Unmounting %s\", target) </ins> ctx, cancel := context.WithTimeout(context.Background(), unmountTimeout) defer cancel() <del> cmd := exec.CommandContext(ctx, \"umount\", path) out, cmderr := cmd.CombinedOutput() </del> <ins> command := exec.CommandContext(ctx, \"umount\", target) output, err := command.CombinedOutput() </ins> // CombinedOutput() does not return DeadlineExceeded, make sure it's // propagated on timeout.", "commid": "kubernetes_pr_115769"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-2b7bec511880531f4cdd70c8b4a9856c0e97fbffbd6a09bd51e5f6eccf1e90e6", "text": "return ctx.Err() } <del> if cmderr != nil { if mounter.withSafeNotMountedBehavior && strings.Contains(string(out), errNotMounted) { klog.V(4).Infof(\"ignoring 'not mounted' error for %s\", path) return nil } return fmt.Errorf(\"unmount failed: %vnUnmounting arguments: %snOutput: %s\", cmderr, path, string(out)) </del> <ins> if err != nil { return checkUmountError(target, command, output, err, withSafeNotMountedBehavior) </ins> } return nil } <del> func forceUmount(path string) error { cmd := exec.Command(\"umount\", \"-f\", path) out, cmderr := cmd.CombinedOutput() </del> <ins> func forceUmount(target string, withSafeNotMountedBehavior bool) error { command := exec.Command(\"umount\", \"-f\", target) output, err := command.CombinedOutput() </ins> <del> if cmderr != nil { return fmt.Errorf(\"unmount failed: %vnUnmounting arguments: %snOutput: %s\", cmderr, path, string(out)) </del> <ins> if err != nil { return checkUmountError(target, command, output, err, withSafeNotMountedBehavior) </ins> } return nil } <ins> // checkUmountError checks a result of umount command and determine a return value. func checkUmountError(target string, command *exec.Cmd, output []byte, err error, withSafeNotMountedBehavior bool) error { if err.Error() == errNoChildProcesses { if command.ProcessState.Success() { // We don't consider errNoChildProcesses an error if the process itself succeeded (see - k/k issue #103753). return nil } // Rewrite err with the actual exit error of the process. err = &exec.ExitError{ProcessState: command.ProcessState} } if withSafeNotMountedBehavior && strings.Contains(string(output), errNotMounted) { klog.V(4).Infof(\"ignoring 'not mounted' error for %s\", target) return nil } return fmt.Errorf(\"unmount failed: %vnUnmounting arguments: %snOutput: %s\", err, target, string(output)) } </ins>", "commid": "kubernetes_pr_115769"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-7195293e21e841b5bc109de05d1c86b72e1fe61357bb67008f4daa4312fe0134", "text": "\"fmt\" \"io/ioutil\" \"os\" <ins> \"os/exec\" </ins> \"reflect\" \"strings\" \"sync\"", "commid": "kubernetes_pr_115769"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f808b7b53b871e2ad503a490ab8a8853ac035cebad77b88506654bcda75080a5", "query": "A status of Pod mounted NFS PV remain as terminating when a node shutdown and restart. A Pod is completely terminated. Deploy a Pod mounted NFS PV Shutdown the node where the Pod is running Wait for 5 min and the Pod status become Restart the node The Pod status is still and the Pod is never terminated completely <detailsPrepare a NFS Server.(I used ) Deploy a Pod mounted NFS PV like this. Shutdown the node where the Pod is running.(In this case ) And the status of node02 becomes . After 5 min later(by default), the Pod status becomes . (The time a Pod becomes status depends on .) Then, restart the node and the status of node02 becomes . But the Pod status is still and the Pod is never terminated completely. It seems that a faild to delete Pod because of trying to unmount a not mounted directory. Force delete Pod. Delete Pod's directory on the node. </detailsNo response <details</details<detailsnone(on premise) </details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/sig node\nIt dose not happen using , so it seems to depend on NFS volume plugin.\n/assign\nI try to build and run kubelet with comment out this logic. Then it seems to get well. related: This change checks the result of instead of the mount point check. However, check logic is not implemented in and (these functions are used in NFS volume plugin), despite it is done in .\n/remove-sig node /sig storage\nReopening, fix had to be reverted due to unit tests requiring root permissions ()\nI am terribly sorry... Please wait a moment. I'll try to fix it.\nno worries, just get to review the rework, making sure the units tests don't require root permissions\nThank you! Fixed in .\nAre there any plans to backport this to older Kubernetes versions? This seems like a critical fix.", "positive_passages": [{"docid": "doc-en-kubernetes-f66792a91a32e30fb7d9ceeb45979a02576e4004723e8cd747511e3e1ca3e7eb", "text": "} } <ins> func TestCheckUmountError(t *testing.T) { target := \"/test/path\" withSafeNotMountedBehavior := true command := exec.Command(\"uname\", \"-r\") // dummy command return status 0 if err := command.Run(); err != nil { t.Errorf(\"Faild to exec dummy command. err: %s\", err) } testcases := []struct { output   []byte err      error expected bool }{ { err:      errors.New(\"wait: no child processes\"), expected: true, }, { output:   []byte(\"umount: /test/path: not mounted.\"), err:      errors.New(\"exit status 1\"), expected: true, }, { output:   []byte(\"umount: /test/path: No such file or directory\"), err:      errors.New(\"exit status 1\"), expected: false, }, } for _, v := range testcases { if err := checkUmountError(target, command, v.output, v.err, withSafeNotMountedBehavior); (err == nil) != v.expected { if v.expected { t.Errorf(\"Expected to return nil, but did not. err: %s\", err) } else { t.Errorf(\"Expected to return error, but did not.\") } } } } </ins> func TestFormat(t *testing.T) { const ( formatCount    = 5", "commid": "kubernetes_pr_115769"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f8e0420493392a2143d7cf5c6fd188de94eceb8d975eec8e70d5b38a422ea455", "query": "It \"connects\" to dockershim There is no Run crictl v1.26.0, without setting up (or using -r) Worked in crictl v1.25.0, that still had CRI v1alpha2 This patch fixed the issue, to make the fallbacks work: <detailsv1.26.0 </details<detailsLima </details<detailsPRETTY_NAME=\"Ubuntu 22.04.1 LTS\" </details<details</details<detailsv1.6.12 </details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI agree that we can check for unavailable connection because it will only be done on kubelet startup.", "positive_passages": [{"docid": "doc-en-kubernetes-5fabaa1ef5e18fdf0cac95825723bc1fde24abc351648883f957d54c8804a7fe", "text": "\"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc\" \"go.opentelemetry.io/otel/trace\" \"google.golang.org/grpc\" <del> \"google.golang.org/grpc/codes\" </del> \"google.golang.org/grpc/credentials/insecure\" <del> \"google.golang.org/grpc/status\" </del> utilfeature \"k8s.io/apiserver/pkg/util/feature\" tracing \"k8s.io/component-base/tracing\" \"k8s.io/klog/v2\"", "commid": "kubernetes_pr_115102"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f8e0420493392a2143d7cf5c6fd188de94eceb8d975eec8e70d5b38a422ea455", "query": "It \"connects\" to dockershim There is no Run crictl v1.26.0, without setting up (or using -r) Worked in crictl v1.25.0, that still had CRI v1alpha2 This patch fixed the issue, to make the fallbacks work: <detailsv1.26.0 </details<detailsLima </details<detailsPRETTY_NAME=\"Ubuntu 22.04.1 LTS\" </details<details</details<detailsv1.6.12 </details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI agree that we can check for unavailable connection because it will only be done on kubelet startup.", "positive_passages": [{"docid": "doc-en-kubernetes-4c3ebe408f3c174cb7eb265a4316b6139527812068bb4088a09fa26665883bb2", "text": "klog.V(4).InfoS(\"Validating the CRI v1 API image version\") r.imageClient = runtimeapi.NewImageServiceClient(conn) <del> if _, err := r.imageClient.ImageFsInfo(ctx, &runtimeapi.ImageFsInfoRequest{}); err == nil { klog.V(2).InfoS(\"Validated CRI v1 image API\") } else if status.Code(err) == codes.Unimplemented { return fmt.Errorf(\"CRI v1 image API is not implemented for endpoint %q: %w\", endpoint, err) </del> <ins> if _, err := r.imageClient.ImageFsInfo(ctx, &runtimeapi.ImageFsInfoRequest{}); err != nil { return fmt.Errorf(\"validate CRI v1 image API for endpoint %q: %w\", endpoint, err) </ins> } <ins> klog.V(2).InfoS(\"Validated CRI v1 image API\") </ins> return nil }", "commid": "kubernetes_pr_115102"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f8e0420493392a2143d7cf5c6fd188de94eceb8d975eec8e70d5b38a422ea455", "query": "It \"connects\" to dockershim There is no Run crictl v1.26.0, without setting up (or using -r) Worked in crictl v1.25.0, that still had CRI v1alpha2 This patch fixed the issue, to make the fallbacks work: <detailsv1.26.0 </details<detailsLima </details<detailsPRETTY_NAME=\"Ubuntu 22.04.1 LTS\" </details<details</details<detailsv1.6.12 </details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI agree that we can check for unavailable connection because it will only be done on kubelet startup.", "positive_passages": [{"docid": "doc-en-kubernetes-6836797365fcdc844f53c8c2083ff6b36fd6f577087ad386ae82cd80134fb227", "text": "klog.V(4).InfoS(\"Validating the CRI v1 API runtime version\") r.runtimeClient = runtimeapi.NewRuntimeServiceClient(conn) <del> if _, err := r.runtimeClient.Version(ctx, &runtimeapi.VersionRequest{}); err == nil { klog.V(2).InfoS(\"Validated CRI v1 runtime API\") } else if status.Code(err) == codes.Unimplemented { return fmt.Errorf(\"CRI v1 runtime API is not implemented for endpoint %q: %w\", endpoint, err) </del> <ins> if _, err := r.runtimeClient.Version(ctx, &runtimeapi.VersionRequest{}); err != nil { return fmt.Errorf(\"validate CRI v1 runtime API for endpoint %q: %w\", endpoint, err) </ins> } <ins> klog.V(2).InfoS(\"Validated CRI v1 runtime API\") </ins> return nil }", "commid": "kubernetes_pr_115102"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bea37ab7d4f377c040141f3da5d077816029ad50feb7b6c4d294ebb6078f8089", "query": "If a CR converter is wired in and it modifies the input list, the delegating CR converter does not protect against this. A converter cannot effect the input list Not really possible externally - it's a coding issue that the current converters don't hit. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-f6ebfb124acae2bee7092d418f947188ed9235e33bae82de296d75f2046e847b", "text": "return converted, nil } <ins> // Deep copy the list before we invoke the converter to ensure that if the converter does mutate the // list (which it shouldn't, but you never know), it doesn't have any impact. convertedList := list.DeepCopy() convertedList.SetAPIVersion(desiredAPIVersion) </ins> convertedObjects, err := c.converter.Convert(list, toGVK.GroupVersion()) if err != nil { return nil, fmt.Errorf(\"conversion for %v failed: %w\", in.GetObjectKind().GroupVersionKind(), err)", "commid": "kubernetes_pr_114959"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bea37ab7d4f377c040141f3da5d077816029ad50feb7b6c4d294ebb6078f8089", "query": "If a CR converter is wired in and it modifies the input list, the delegating CR converter does not protect against this. A converter cannot effect the input list Not really possible externally - it's a coding issue that the current converters don't hit. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-e23b5ada498d0d420e13c2db171eeb8ba4aa0432046b4dee1ebbc0dce6bd9119", "text": "return nil, fmt.Errorf(\"conversion for %v returned %d objects, expected %d\", in.GetObjectKind().GroupVersionKind(), len(convertedObjects.Items), len(objectsToConvert)) } <del> // start a deepcopy of the input and fill in the converted objects from the response at the right spots. </del> <ins> // Fill in the converted objects from the response at the right spots. </ins> // The response list might be sparse because objects had the right version already. <del> convertedList := list.DeepCopy() convertedList.SetAPIVersion(desiredAPIVersion) </del> convertedIndex := 0 for i := range convertedList.Items { original := &convertedList.Items[i]", "commid": "kubernetes_pr_114959"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bea37ab7d4f377c040141f3da5d077816029ad50feb7b6c4d294ebb6078f8089", "query": "If a CR converter is wired in and it modifies the input list, the delegating CR converter does not protect against this. A converter cannot effect the input list Not really possible externally - it's a coding issue that the current converters don't hit. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-dde2b985fac44014badd51f6f748f1037273b347fd2d2055d69ea05dc9d4ccc3", "text": "SourceObject: &unstructured.Unstructured{ Object: map[string]interface{}{ \"apiVersion\": \"example.com/v1\", <ins> \"metadata\":   map[string]interface{}{}, </ins> \"other\":      \"data\", \"kind\":       \"foo\", },", "commid": "kubernetes_pr_114959"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bea37ab7d4f377c040141f3da5d077816029ad50feb7b6c4d294ebb6078f8089", "query": "If a CR converter is wired in and it modifies the input list, the delegating CR converter does not protect against this. A converter cannot effect the input list Not really possible externally - it's a coding issue that the current converters don't hit. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-87525da44b04e42da38b60aa4ac7fc43345bd9130cd3a76cc9b541bd58e299b6", "text": "ExpectedObject: &unstructured.Unstructured{ Object: map[string]interface{}{ \"apiVersion\": \"example.com/v2\", <ins> \"metadata\":   map[string]interface{}{}, </ins> \"other\":      \"data\", \"kind\":       \"foo\", },", "commid": "kubernetes_pr_114959"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bea37ab7d4f377c040141f3da5d077816029ad50feb7b6c4d294ebb6078f8089", "query": "If a CR converter is wired in and it modifies the input list, the delegating CR converter does not protect against this. A converter cannot effect the input list Not really possible externally - it's a coding issue that the current converters don't hit. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-c1ef26fabdb9ee6ff0b78660ef6f26ccfab9e8b79ce5d56101cd54763e3dc582", "text": "{ Object: map[string]interface{}{ \"apiVersion\": \"example.com/v1\", <ins> \"metadata\":   map[string]interface{}{}, </ins> \"kind\":       \"foo\", \"other\":      \"data\", },", "commid": "kubernetes_pr_114959"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bea37ab7d4f377c040141f3da5d077816029ad50feb7b6c4d294ebb6078f8089", "query": "If a CR converter is wired in and it modifies the input list, the delegating CR converter does not protect against this. A converter cannot effect the input list Not really possible externally - it's a coding issue that the current converters don't hit. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-42207d85f475963b3eb5f453c5cafb5d85333abf0eb5f168d6f298c0c5539227", "text": "{ Object: map[string]interface{}{ \"apiVersion\": \"example.com/v1\", <ins> \"metadata\":   map[string]interface{}{}, </ins> \"kind\":       \"foo\", \"other\":      \"data2\", },", "commid": "kubernetes_pr_114959"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bea37ab7d4f377c040141f3da5d077816029ad50feb7b6c4d294ebb6078f8089", "query": "If a CR converter is wired in and it modifies the input list, the delegating CR converter does not protect against this. A converter cannot effect the input list Not really possible externally - it's a coding issue that the current converters don't hit. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-0403aea06cfd3e8c136caaa2b3e63f13b2dab2e203359045f6e3fc7ec6d71f36", "text": "{ Object: map[string]interface{}{ \"apiVersion\": \"example.com/v2\", <ins> \"metadata\":   map[string]interface{}{}, </ins> \"kind\":       \"foo\", \"other\":      \"data\", },", "commid": "kubernetes_pr_114959"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bea37ab7d4f377c040141f3da5d077816029ad50feb7b6c4d294ebb6078f8089", "query": "If a CR converter is wired in and it modifies the input list, the delegating CR converter does not protect against this. A converter cannot effect the input list Not really possible externally - it's a coding issue that the current converters don't hit. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-3ef43cfc5d9eeeb497df17bf0f02643f4d067a7300d6adca0a0ef6708565aed4", "text": "{ Object: map[string]interface{}{ \"apiVersion\": \"example.com/v2\", <ins> \"metadata\":   map[string]interface{}{}, </ins> \"kind\":       \"foo\", \"other\":      \"data2\", },", "commid": "kubernetes_pr_114959"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bea37ab7d4f377c040141f3da5d077816029ad50feb7b6c4d294ebb6078f8089", "query": "If a CR converter is wired in and it modifies the input list, the delegating CR converter does not protect against this. A converter cannot effect the input list Not really possible externally - it's a coding issue that the current converters don't hit. No response <details</details<detailsN/A </details<details</details<details</details<details</details<details</details\n/sig api-machinery /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-a05131c5aa70c71e56cd8f7f32e793214b781d471b1d3ea80e2f64604e63dbe1", "text": "}) } } <ins> func TestConverterMutatesInput(t *testing.T) { testCRD := apiextensionsv1.CustomResourceDefinition{ Spec: apiextensionsv1.CustomResourceDefinitionSpec{ Conversion: &apiextensionsv1.CustomResourceConversion{ Strategy: apiextensionsv1.NoneConverter, }, Group: \"test.k8s.io\", Versions: []apiextensionsv1.CustomResourceDefinitionVersion{ { Name:   \"v1alpha1\", Served: true, }, { Name:   \"v1alpha2\", Served: true, }, }, }, } safeConverter, _, err := NewDelegatingConverter(&testCRD, &inputMutatingConverter{}) if err != nil { t.Fatalf(\"Cannot create converter: %v\", err) } input := &unstructured.UnstructuredList{ Object: map[string]interface{}{ \"apiVersion\": \"test.k8s.io/v1alpha1\", }, Items: []unstructured.Unstructured{ { Object: map[string]interface{}{ \"apiVersion\": \"test.k8s.io/v1alpha1\", \"metadata\": map[string]interface{}{ \"name\": \"item1\", }, }, }, { Object: map[string]interface{}{ \"apiVersion\": \"test.k8s.io/v1alpha1\", \"metadata\": map[string]interface{}{ \"name\": \"item2\", }, }, }, }, } toVersion, _ := schema.ParseGroupVersion(\"test.k8s.io/v1alpha2\") toVersions := schema.GroupVersions{toVersion} converted, err := safeConverter.ConvertToVersion(input, toVersions) if err != nil { t.Fatalf(\"unexpected error: %v\", err) } convertedList := converted.(*unstructured.UnstructuredList) if e, a := 2, len(convertedList.Items); e != a { t.Fatalf(\"length: expected %d, got %d\", e, a) } } type inputMutatingConverter struct{} func (i *inputMutatingConverter) Convert(in *unstructured.UnstructuredList, targetGVK schema.GroupVersion) (*unstructured.UnstructuredList, error) { out := &unstructured.UnstructuredList{} for _, obj := range in.Items { u := obj.DeepCopy() u.SetAPIVersion(targetGVK.String()) out.Items = append(out.Items, *u) } in.Items = nil return out, nil } </ins>", "commid": "kubernetes_pr_114959"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5ae73f290b7cbed5a20c411ecd6584ae3e0bb9d2c39b6882eb361e82242274a2", "query": "It seems that it was recently and it was always failing ! /sig cli /kind failing-test /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-8ba0f29a2302e8ad4ef036950ff44fde7ff0dc861bb3d2ddf4377e654be935fa", "text": "ginkgo.It(\"should log default container if not specified\", func(ctx context.Context) { ginkgo.By(\"Waiting for log generator to start.\") <del> if !e2epod.CheckPodsRunningReadyOrSucceeded(ctx, c, ns, []string{podName}, framework.PodStartTimeout) { framework.Failf(\"Pod %s was not ready\", podName) </del> <ins> // we need to wait for pod completion, to check the generated number of lines if err := e2epod.WaitForPodSuccessInNamespaceTimeout(ctx, c, podName, ns, framework.PodStartTimeout); err != nil { framework.Failf(\"Pod %s did not finish: %v\", podName, err) </ins> } ginkgo.By(\"specified container log lines\")", "commid": "kubernetes_pr_115127"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-67ba6216c2f0a82dc146b5437e105db9d39096631ebad5fab166c989773fd1f7", "query": "master-blocking build-master Overall build is failing ! 2023-02-09 23:09:58 +0000 UTC make: [Makefile:487: cross] Error 1 !!! [0210 00:35:55] Call tree: !!! [0210 00:35:55] 1: kube::build::runbuildcommandex(...) !!! [0210 00:35:55] 2: kube::build::runbuildcommand(...) make: [Makefile:374: release] Error 1 level=fatal msg=\"failed to run: running make release: command /usr/bin/make release did not succeed: !!! [0210 00:35:54] Call tree:n!!! [0210 00:35:54] 1: hack/make- kube::golang::buildbinaries(...)nmake[1]: [Makefile:92: all] Error 1nmake: [Makefile:487: cross] Error 1n!!! [0210 00:35:55] Call tree:n!!! [0210 00:35:55] 1: kube::build::runbuildcommandex(...)n!!! [0210 00:35:55] 2: kube::build::runbuildcommand(...)nmake: * [Makefile:374: release] Error 1n\" No response_ /sig testing\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority critical-urgent\nlooks like the same issue again: /cc\nThis would fall under sig-release or sig-testing? couldn't really gather much from logs about this though failure is so I guess sig-release then.\nI'm going to reopen for that, which should work around the issue.\nthat's correct :) /remove-sig testing /sig release\nThe PR does not seem to fix the problem without disabling test cases. Opening a slack discussion and closing the loop:\nFailing again. /reopen\nReopened this issue. <detailsIn response to : Failing again. /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nthis is a different error: can we spawn a new issue to track rather than reopening the same one and mixing investigations for different issues?\nOh just the stack trace for make was the same, my bad, opened /close\nClosing this issue. <detailsIn response to : Oh just the stack trace for make was the same, my bad, opened Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-24790636d336cd0b8f75346ce85d4473283bc8eab2818e608e713da56d5399c1", "text": "kube::golang::build_some_binaries \"${nonstatics[@]}\" fi <ins> # Workaround for https://github.com/kubernetes/kubernetes/issues/115675 local testgogcflags=\"${gogcflags}\" local testgoexperiment=\"${GOEXPERIMENT:-}\" if [[ \"$(go version)\" == *\"go1.20\"* && \"${platform}\" == \"linux/arm\" ]]; then # work around https://github.com/golang/go/issues/58339 until fixed in go1.20.x testgogcflags=\"${testgogcflags} -d=inlstaticinit=0\" # work around https://github.com/golang/go/issues/58425 testgoexperiment=\"nounified,${testgoexperiment}\" kube::log::info \"Building test binaries with GOEXPERIMENT=${testgoexperiment} GCFLAGS=${testgogcflags} ASMFLAGS=${goasmflags} LDFLAGS=${goldflags}\" fi </ins> for test in \"${tests[@]:+${tests[@]}}\"; do local outfile testpkg outfile=$(kube::golang::outfile_for_binary \"${test}\" \"${platform}\") testpkg=$(dirname \"${test}\") mkdir -p \"$(dirname \"${outfile}\")\" <del> go test -c  </del> <ins> GOEXPERIMENT=\"${testgoexperiment}\" go test -c  </ins> ${goflags:+\"${goflags[@]}\"}  <del> -gcflags=\"${gogcflags}\"  </del> <ins> -gcflags=\"${testgogcflags}\"  </ins> -asmflags=\"${goasmflags}\"  -ldflags=\"${goldflags}\"  -tags=\"${gotags:-}\" ", "commid": "kubernetes_pr_115692"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bf562bafe869012db15c0a17b6d5b8a3c02c53240756e36c1b24f8106551c642", "query": "Currently, when the Label Selector in the Pod Affinity is empty, no objects will be match. That means if it's in a required PodAffinity, the Pod will never be schedulable. And if it's in a required PodAntiAffinity, that PodAntiAffinity will be no-op. So, I'm thinking PodAffinity with empty Label Selector is very likely mistake. It'd be good if we could notice it for users. To prevent such a misconfiguration. Probably, we cannot filter out such a Pod creation in the validation for a backward compatibility. /assign /sig scheduling\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI'm wondering if it has already discussed somewhere or not. Please just let me know if we have some decisions on it.\nI am not sure, where do you propose to put the warning? If the pod is unschedulable, that will show up in the events and pod status.\nDo you mean the place to implement this warning? I suspect \u2193 is a suitable place:\nA warning sounds useful, even if the pod is unschedulable, as it gives you a heads up at the time when you create the Pod. Whereas the Pod scheduling failure might be a bit harder to interpret.\nok, I thought you were referring to something that the scheduler will produce after attempting to schedule the pod. Yeah, if there is already a setup to print warnings on pod creation, it is certainly useful for this case.\nCan you please also add it in topology spread?\nSure", "positive_passages": [{"docid": "doc-en-kubernetes-e663e0c65a3891a0c90abbb0e97decdb9f173ed7d25db5edaf86ac6925e1c3c9", "text": "msg, )) } <ins> // warn if labelSelector is empty which is no-match. if t.LabelSelector == nil { warnings = append(warnings, fmt.Sprintf(\"%s: a null labelSelector results in matching no pod\", fieldPath.Child(\"spec\", \"topologySpreadConstraints\").Index(i).Child(\"labelSelector\"))) } </ins> } // use of deprecated annotations", "commid": "kubernetes_pr_117025"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bf562bafe869012db15c0a17b6d5b8a3c02c53240756e36c1b24f8106551c642", "query": "Currently, when the Label Selector in the Pod Affinity is empty, no objects will be match. That means if it's in a required PodAffinity, the Pod will never be schedulable. And if it's in a required PodAntiAffinity, that PodAntiAffinity will be no-op. So, I'm thinking PodAffinity with empty Label Selector is very likely mistake. It'd be good if we could notice it for users. To prevent such a misconfiguration. Probably, we cannot filter out such a Pod creation in the validation for a backward compatibility. /assign /sig scheduling\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI'm wondering if it has already discussed somewhere or not. Please just let me know if we have some decisions on it.\nI am not sure, where do you propose to put the warning? If the pod is unschedulable, that will show up in the events and pod status.\nDo you mean the place to implement this warning? I suspect \u2193 is a suitable place:\nA warning sounds useful, even if the pod is unschedulable, as it gives you a heads up at the time when you create the Pod. Whereas the Pod scheduling failure might be a bit harder to interpret.\nok, I thought you were referring to something that the scheduler will produce after attempting to schedule the pod. Yeah, if there is already a setup to print warnings on pod creation, it is certainly useful for this case.\nCan you please also add it in topology spread?\nSure", "positive_passages": [{"docid": "doc-en-kubernetes-66a5ffea1ce2aaf5fa6fdf309125a07d35569e3d06416d7ac0d00027fabdeea5", "text": "if podSpec.TerminationGracePeriodSeconds != nil && *podSpec.TerminationGracePeriodSeconds < 0 { warnings = append(warnings, fmt.Sprintf(\"%s: must be >= 0; negative values are invalid and will be treated as 1\", fieldPath.Child(\"spec\", \"terminationGracePeriodSeconds\"))) } <ins> if podSpec.Affinity != nil { if affinity := podSpec.Affinity.PodAffinity; affinity != nil { warnings = append(warnings, warningsForPodAffinityTerms(affinity.RequiredDuringSchedulingIgnoredDuringExecution, fieldPath.Child(\"spec\", \"affinity\", \"podAffinity\", \"requiredDuringSchedulingIgnoredDuringExecution\"))...) warnings = append(warnings, warningsForWeightedPodAffinityTerms(affinity.PreferredDuringSchedulingIgnoredDuringExecution, fieldPath.Child(\"spec\", \"affinity\", \"podAffinity\", \"preferredDuringSchedulingIgnoredDuringExecution\"))...) } if affinity := podSpec.Affinity.PodAntiAffinity; affinity != nil { warnings = append(warnings, warningsForPodAffinityTerms(affinity.RequiredDuringSchedulingIgnoredDuringExecution, fieldPath.Child(\"spec\", \"affinity\", \"podAntiAffinity\", \"requiredDuringSchedulingIgnoredDuringExecution\"))...) warnings = append(warnings, warningsForWeightedPodAffinityTerms(affinity.PreferredDuringSchedulingIgnoredDuringExecution, fieldPath.Child(\"spec\", \"affinity\", \"podAntiAffinity\", \"preferredDuringSchedulingIgnoredDuringExecution\"))...) } } return warnings } func warningsForPodAffinityTerms(terms []api.PodAffinityTerm, fieldPath *field.Path) []string { var warnings []string for i, t := range terms { if t.LabelSelector == nil { warnings = append(warnings, fmt.Sprintf(\"%s: a null labelSelector results in matching no pod\", fieldPath.Index(i).Child(\"labelSelector\"))) } } return warnings } func warningsForWeightedPodAffinityTerms(terms []api.WeightedPodAffinityTerm, fieldPath *field.Path) []string { var warnings []string for i, t := range terms { // warn if labelSelector is empty which is no-match. if t.PodAffinityTerm.LabelSelector == nil { warnings = append(warnings, fmt.Sprintf(\"%s: a null labelSelector results in matching no pod\", fieldPath.Index(i).Child(\"podAffinityTerm\", \"labelSelector\"))) } } </ins> return warnings }", "commid": "kubernetes_pr_117025"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bf562bafe869012db15c0a17b6d5b8a3c02c53240756e36c1b24f8106551c642", "query": "Currently, when the Label Selector in the Pod Affinity is empty, no objects will be match. That means if it's in a required PodAffinity, the Pod will never be schedulable. And if it's in a required PodAntiAffinity, that PodAntiAffinity will be no-op. So, I'm thinking PodAffinity with empty Label Selector is very likely mistake. It'd be good if we could notice it for users. To prevent such a misconfiguration. Probably, we cannot filter out such a Pod creation in the validation for a backward compatibility. /assign /sig scheduling\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI'm wondering if it has already discussed somewhere or not. Please just let me know if we have some decisions on it.\nI am not sure, where do you propose to put the warning? If the pod is unschedulable, that will show up in the events and pod status.\nDo you mean the place to implement this warning? I suspect \u2193 is a suitable place:\nA warning sounds useful, even if the pod is unschedulable, as it gives you a heads up at the time when you create the Pod. Whereas the Pod scheduling failure might be a bit harder to interpret.\nok, I thought you were referring to something that the scheduler will produce after attempting to schedule the pod. Yeah, if there is already a setup to print warnings on pod creation, it is certainly useful for this case.\nCan you please also add it in topology spread?\nSure", "positive_passages": [{"docid": "doc-en-kubernetes-3098c9875f9adf66f3267994dc33650fc0979076a3959d8b7d3577ec8a97201c", "text": "template: &api.PodTemplateSpec{ Spec: api.PodSpec{ TopologySpreadConstraints: []api.TopologySpreadConstraint{ <del> {TopologyKey: `foo`}, {TopologyKey: `beta.kubernetes.io/arch`}, {TopologyKey: `beta.kubernetes.io/os`}, {TopologyKey: `failure-domain.beta.kubernetes.io/region`}, {TopologyKey: `failure-domain.beta.kubernetes.io/zone`}, {TopologyKey: `beta.kubernetes.io/instance-type`}, </del> <ins> { TopologyKey:   `foo`, LabelSelector: &metav1.LabelSelector{}, }, { TopologyKey:   `beta.kubernetes.io/arch`, LabelSelector: &metav1.LabelSelector{}, }, { TopologyKey:   `beta.kubernetes.io/os`, LabelSelector: &metav1.LabelSelector{}, }, { TopologyKey:   `failure-domain.beta.kubernetes.io/region`, LabelSelector: &metav1.LabelSelector{}, }, { TopologyKey:   `failure-domain.beta.kubernetes.io/zone`, LabelSelector: &metav1.LabelSelector{}, }, { TopologyKey:   `beta.kubernetes.io/instance-type`, LabelSelector: &metav1.LabelSelector{}, }, </ins> }, }, },", "commid": "kubernetes_pr_117025"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-bf562bafe869012db15c0a17b6d5b8a3c02c53240756e36c1b24f8106551c642", "query": "Currently, when the Label Selector in the Pod Affinity is empty, no objects will be match. That means if it's in a required PodAffinity, the Pod will never be schedulable. And if it's in a required PodAntiAffinity, that PodAntiAffinity will be no-op. So, I'm thinking PodAffinity with empty Label Selector is very likely mistake. It'd be good if we could notice it for users. To prevent such a misconfiguration. Probably, we cannot filter out such a Pod creation in the validation for a backward compatibility. /assign /sig scheduling\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI'm wondering if it has already discussed somewhere or not. Please just let me know if we have some decisions on it.\nI am not sure, where do you propose to put the warning? If the pod is unschedulable, that will show up in the events and pod status.\nDo you mean the place to implement this warning? I suspect \u2193 is a suitable place:\nA warning sounds useful, even if the pod is unschedulable, as it gives you a heads up at the time when you create the Pod. Whereas the Pod scheduling failure might be a bit harder to interpret.\nok, I thought you were referring to something that the scheduler will produce after attempting to schedule the pod. Yeah, if there is already a setup to print warnings on pod creation, it is certainly useful for this case.\nCan you please also add it in topology spread?\nSure", "positive_passages": [{"docid": "doc-en-kubernetes-de5a4f4a8aeec010d4621a987e7b1632fdaab182209876eb68fb7324dc5722fe", "text": "`spec.terminationGracePeriodSeconds: must be >= 0; negative values are invalid and will be treated as 1`, }, }, <ins> { name: \"null LabelSelector in topologySpreadConstraints\", template: &api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{}, Spec: api.PodSpec{ TopologySpreadConstraints: []api.TopologySpreadConstraint{ { LabelSelector: &metav1.LabelSelector{}, }, { LabelSelector: nil, }, }, }, }, expected: []string{ `spec.topologySpreadConstraints[1].labelSelector: a null labelSelector results in matching no pod`, }, }, { name: \"null LabelSelector in PodAffinity\", template: &api.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{}, Spec: api.PodSpec{ Affinity: &api.Affinity{ PodAffinity: &api.PodAffinity{ RequiredDuringSchedulingIgnoredDuringExecution: []api.PodAffinityTerm{ { LabelSelector: &metav1.LabelSelector{}, }, { LabelSelector: nil, }, }, PreferredDuringSchedulingIgnoredDuringExecution: []api.WeightedPodAffinityTerm{ { PodAffinityTerm: api.PodAffinityTerm{ LabelSelector: &metav1.LabelSelector{}, }, }, { PodAffinityTerm: api.PodAffinityTerm{ LabelSelector: nil, }, }, }, }, PodAntiAffinity: &api.PodAntiAffinity{ RequiredDuringSchedulingIgnoredDuringExecution: []api.PodAffinityTerm{ { LabelSelector: &metav1.LabelSelector{}, }, { LabelSelector: nil, }, }, PreferredDuringSchedulingIgnoredDuringExecution: []api.WeightedPodAffinityTerm{ { PodAffinityTerm: api.PodAffinityTerm{ LabelSelector: &metav1.LabelSelector{}, }, }, { PodAffinityTerm: api.PodAffinityTerm{ LabelSelector: nil, }, }, }, }, }, }, }, expected: []string{ `spec.affinity.podAffinity.requiredDuringSchedulingIgnoredDuringExecution[1].labelSelector: a null labelSelector results in matching no pod`, `spec.affinity.podAffinity.preferredDuringSchedulingIgnoredDuringExecution[1].podAffinityTerm.labelSelector: a null labelSelector results in matching no pod`, `spec.affinity.podAntiAffinity.requiredDuringSchedulingIgnoredDuringExecution[1].labelSelector: a null labelSelector results in matching no pod`, `spec.affinity.podAntiAffinity.preferredDuringSchedulingIgnoredDuringExecution[1].podAffinityTerm.labelSelector: a null labelSelector results in matching no pod`, }, }, </ins> } for _, tc := range testcases {", "commid": "kubernetes_pr_117025"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2a207ab5c5251abdddcfb02c46fba9f20ebf7280d6accb8963d5b3a92615c69", "query": "The EndpointSlice API says and it works as expected in normal circumstances I delete the pod and the endpoints conditions are the expected However, if during this time I set we run into an incoherence with the API doc, but it seems that we already documented this edge case in the code I think that at this point is just to amend this information to the API, no? /kind bug /kind documentation\n/sig network /assign\nI would like to work on this. I just want a bit more clarification on what needs to be done!\nI proposed a solution, that is clarify it in the doc ... once we reach an agreement in this issue we implement it ...\n+1 to docs. I'd make it a little more vague, like: \"\"\" when the normal readiness behavior is being explicitly overridden, for example when the associated Service has set the publishNotReadyAddresses flag. \"\"\"\nso, the thing is to update the docs here with Tim's suggestion and here and do to update the generated code and submit a PR\n/assign\nI am not able to run command in windows, I am checking it. This error message is coming: *\n/triage accepted\nIs there a PR for this? Happy to review\nI will raise the PR if my above problem gets solved. I am trying to make an update but the error mentioned above is coming.\nWhat platform are you on? If the Makefile were really broken EVERYTHING would be failing.\nhe's on windows ... you will need a linux/macos. see\nLet me know if you want someone to take it over.\nI think in that case, you can assign this to someone else.", "positive_passages": [{"docid": "doc-en-kubernetes-3d0a3c274c7013b51a541f560f2d817469406c3c81ae2e147d9a98f9f132d51d", "text": "\"description\": \"EndpointConditions represents the current condition of an endpoint.\", \"properties\": { \"ready\": { <del> \"description\": \"ready indicates that this endpoint is prepared to receive traffic, according to whatever system is managing the endpoint. A nil value indicates an unknown state. In most cases consumers should interpret this unknown state as ready. For compatibility reasons, ready should never be \"true\" for terminating endpoints.\", </del> <ins> \"description\": \"ready indicates that this endpoint is prepared to receive traffic, according to whatever system is managing the endpoint. A nil value indicates an unknown state. In most cases consumers should interpret this unknown state as ready. For compatibility reasons, ready should never be \"true\" for terminating endpoints, except when the normal readiness behavior is being explicitly overridden, for example when the associated Service has set the publishNotReadyAddresses flag.\", </ins> \"type\": \"boolean\" }, \"serving\": {", "commid": "kubernetes_pr_116743"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2a207ab5c5251abdddcfb02c46fba9f20ebf7280d6accb8963d5b3a92615c69", "query": "The EndpointSlice API says and it works as expected in normal circumstances I delete the pod and the endpoints conditions are the expected However, if during this time I set we run into an incoherence with the API doc, but it seems that we already documented this edge case in the code I think that at this point is just to amend this information to the API, no? /kind bug /kind documentation\n/sig network /assign\nI would like to work on this. I just want a bit more clarification on what needs to be done!\nI proposed a solution, that is clarify it in the doc ... once we reach an agreement in this issue we implement it ...\n+1 to docs. I'd make it a little more vague, like: \"\"\" when the normal readiness behavior is being explicitly overridden, for example when the associated Service has set the publishNotReadyAddresses flag. \"\"\"\nso, the thing is to update the docs here with Tim's suggestion and here and do to update the generated code and submit a PR\n/assign\nI am not able to run command in windows, I am checking it. This error message is coming: *\n/triage accepted\nIs there a PR for this? Happy to review\nI will raise the PR if my above problem gets solved. I am trying to make an update but the error mentioned above is coming.\nWhat platform are you on? If the Makefile were really broken EVERYTHING would be failing.\nhe's on windows ... you will need a linux/macos. see\nLet me know if you want someone to take it over.\nI think in that case, you can assign this to someone else.", "positive_passages": [{"docid": "doc-en-kubernetes-ec653db5f4b98e2ba57c79ad50752b8bac68208ea594dd3b7a8909e7a0d93631", "text": "// according to whatever system is managing the endpoint. A nil value // indicates an unknown state. In most cases consumers should interpret this // unknown state as ready. For compatibility reasons, ready should never be <del> // \"true\" for terminating endpoints. </del> <ins> // \"true\" for terminating endpoints, except when the normal readiness // behavior is being explicitly overridden, for example when the associated // Service has set the publishNotReadyAddresses flag. </ins> Ready *bool // serving is identical to ready except that it is set regardless of the", "commid": "kubernetes_pr_116743"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2a207ab5c5251abdddcfb02c46fba9f20ebf7280d6accb8963d5b3a92615c69", "query": "The EndpointSlice API says and it works as expected in normal circumstances I delete the pod and the endpoints conditions are the expected However, if during this time I set we run into an incoherence with the API doc, but it seems that we already documented this edge case in the code I think that at this point is just to amend this information to the API, no? /kind bug /kind documentation\n/sig network /assign\nI would like to work on this. I just want a bit more clarification on what needs to be done!\nI proposed a solution, that is clarify it in the doc ... once we reach an agreement in this issue we implement it ...\n+1 to docs. I'd make it a little more vague, like: \"\"\" when the normal readiness behavior is being explicitly overridden, for example when the associated Service has set the publishNotReadyAddresses flag. \"\"\"\nso, the thing is to update the docs here with Tim's suggestion and here and do to update the generated code and submit a PR\n/assign\nI am not able to run command in windows, I am checking it. This error message is coming: *\n/triage accepted\nIs there a PR for this? Happy to review\nI will raise the PR if my above problem gets solved. I am trying to make an update but the error mentioned above is coming.\nWhat platform are you on? If the Makefile were really broken EVERYTHING would be failing.\nhe's on windows ... you will need a linux/macos. see\nLet me know if you want someone to take it over.\nI think in that case, you can assign this to someone else.", "positive_passages": [{"docid": "doc-en-kubernetes-68a1dab516c4d853b8d2456f9a045d023fb304a2d04d30958fe9ab9ad34f210f", "text": "Properties: map[string]spec.Schema{ \"ready\": { SchemaProps: spec.SchemaProps{ <del> Description: \"ready indicates that this endpoint is prepared to receive traffic, according to whatever system is managing the endpoint. A nil value indicates an unknown state. In most cases consumers should interpret this unknown state as ready. For compatibility reasons, ready should never be \"true\" for terminating endpoints.\", </del> <ins> Description: \"ready indicates that this endpoint is prepared to receive traffic, according to whatever system is managing the endpoint. A nil value indicates an unknown state. In most cases consumers should interpret this unknown state as ready. For compatibility reasons, ready should never be \"true\" for terminating endpoints, except when the normal readiness behavior is being explicitly overridden, for example when the associated Service has set the publishNotReadyAddresses flag.\", </ins> Type:        []string{\"boolean\"}, Format:      \"\", },", "commid": "kubernetes_pr_116743"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2a207ab5c5251abdddcfb02c46fba9f20ebf7280d6accb8963d5b3a92615c69", "query": "The EndpointSlice API says and it works as expected in normal circumstances I delete the pod and the endpoints conditions are the expected However, if during this time I set we run into an incoherence with the API doc, but it seems that we already documented this edge case in the code I think that at this point is just to amend this information to the API, no? /kind bug /kind documentation\n/sig network /assign\nI would like to work on this. I just want a bit more clarification on what needs to be done!\nI proposed a solution, that is clarify it in the doc ... once we reach an agreement in this issue we implement it ...\n+1 to docs. I'd make it a little more vague, like: \"\"\" when the normal readiness behavior is being explicitly overridden, for example when the associated Service has set the publishNotReadyAddresses flag. \"\"\"\nso, the thing is to update the docs here with Tim's suggestion and here and do to update the generated code and submit a PR\n/assign\nI am not able to run command in windows, I am checking it. This error message is coming: *\n/triage accepted\nIs there a PR for this? Happy to review\nI will raise the PR if my above problem gets solved. I am trying to make an update but the error mentioned above is coming.\nWhat platform are you on? If the Makefile were really broken EVERYTHING would be failing.\nhe's on windows ... you will need a linux/macos. see\nLet me know if you want someone to take it over.\nI think in that case, you can assign this to someone else.", "positive_passages": [{"docid": "doc-en-kubernetes-0f352df96f8b08a686bf4b1e44c5b6c10bb8901e61d79f0a9eaa13965e697517", "text": "// according to whatever system is managing the endpoint. A nil value // indicates an unknown state. In most cases consumers should interpret this // unknown state as ready. For compatibility reasons, ready should never be <del> // \"true\" for terminating endpoints. </del> <ins> // \"true\" for terminating endpoints, except when the normal readiness // behavior is being explicitly overridden, for example when the associated // Service has set the publishNotReadyAddresses flag. </ins> // +optional optional bool ready = 1;", "commid": "kubernetes_pr_116743"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2a207ab5c5251abdddcfb02c46fba9f20ebf7280d6accb8963d5b3a92615c69", "query": "The EndpointSlice API says and it works as expected in normal circumstances I delete the pod and the endpoints conditions are the expected However, if during this time I set we run into an incoherence with the API doc, but it seems that we already documented this edge case in the code I think that at this point is just to amend this information to the API, no? /kind bug /kind documentation\n/sig network /assign\nI would like to work on this. I just want a bit more clarification on what needs to be done!\nI proposed a solution, that is clarify it in the doc ... once we reach an agreement in this issue we implement it ...\n+1 to docs. I'd make it a little more vague, like: \"\"\" when the normal readiness behavior is being explicitly overridden, for example when the associated Service has set the publishNotReadyAddresses flag. \"\"\"\nso, the thing is to update the docs here with Tim's suggestion and here and do to update the generated code and submit a PR\n/assign\nI am not able to run command in windows, I am checking it. This error message is coming: *\n/triage accepted\nIs there a PR for this? Happy to review\nI will raise the PR if my above problem gets solved. I am trying to make an update but the error mentioned above is coming.\nWhat platform are you on? If the Makefile were really broken EVERYTHING would be failing.\nhe's on windows ... you will need a linux/macos. see\nLet me know if you want someone to take it over.\nI think in that case, you can assign this to someone else.", "positive_passages": [{"docid": "doc-en-kubernetes-8ba03c88d9c899536faaa69d97aa3fd9785efe51bc1ffad0c697ff06346d42cd", "text": "// according to whatever system is managing the endpoint. A nil value // indicates an unknown state. In most cases consumers should interpret this // unknown state as ready. For compatibility reasons, ready should never be <del> // \"true\" for terminating endpoints. </del> <ins> // \"true\" for terminating endpoints, except when the normal readiness // behavior is being explicitly overridden, for example when the associated // Service has set the publishNotReadyAddresses flag. </ins> // +optional Ready *bool `json:\"ready,omitempty\" protobuf:\"bytes,1,name=ready\"`", "commid": "kubernetes_pr_116743"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2a207ab5c5251abdddcfb02c46fba9f20ebf7280d6accb8963d5b3a92615c69", "query": "The EndpointSlice API says and it works as expected in normal circumstances I delete the pod and the endpoints conditions are the expected However, if during this time I set we run into an incoherence with the API doc, but it seems that we already documented this edge case in the code I think that at this point is just to amend this information to the API, no? /kind bug /kind documentation\n/sig network /assign\nI would like to work on this. I just want a bit more clarification on what needs to be done!\nI proposed a solution, that is clarify it in the doc ... once we reach an agreement in this issue we implement it ...\n+1 to docs. I'd make it a little more vague, like: \"\"\" when the normal readiness behavior is being explicitly overridden, for example when the associated Service has set the publishNotReadyAddresses flag. \"\"\"\nso, the thing is to update the docs here with Tim's suggestion and here and do to update the generated code and submit a PR\n/assign\nI am not able to run command in windows, I am checking it. This error message is coming: *\n/triage accepted\nIs there a PR for this? Happy to review\nI will raise the PR if my above problem gets solved. I am trying to make an update but the error mentioned above is coming.\nWhat platform are you on? If the Makefile were really broken EVERYTHING would be failing.\nhe's on windows ... you will need a linux/macos. see\nLet me know if you want someone to take it over.\nI think in that case, you can assign this to someone else.", "positive_passages": [{"docid": "doc-en-kubernetes-474ef678c840409bb26d69788ddd281fadc0b62ba3417e9cdb6844f49f9da5fc", "text": "var map_EndpointConditions = map[string]string{ \"\":            \"EndpointConditions represents the current condition of an endpoint.\", <del> \"ready\":       \"ready indicates that this endpoint is prepared to receive traffic, according to whatever system is managing the endpoint. A nil value indicates an unknown state. In most cases consumers should interpret this unknown state as ready. For compatibility reasons, ready should never be \"true\" for terminating endpoints.\", </del> <ins> \"ready\":       \"ready indicates that this endpoint is prepared to receive traffic, according to whatever system is managing the endpoint. A nil value indicates an unknown state. In most cases consumers should interpret this unknown state as ready. For compatibility reasons, ready should never be \"true\" for terminating endpoints, except when the normal readiness behavior is being explicitly overridden, for example when the associated Service has set the publishNotReadyAddresses flag.\", </ins> \"serving\":     \"serving is identical to ready except that it is set regardless of the terminating state of endpoints. This condition should be set to true for a ready endpoint that is terminating. If nil, consumers should defer to the ready condition.\", \"terminating\": \"terminating indicates that this endpoint is terminating. A nil value indicates an unknown state. Consumers should interpret this unknown state to mean that the endpoint is not terminating.\", }", "commid": "kubernetes_pr_116743"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04e3b909e513627c5b2af9f40bf2e8ca20eddfe7646c93203a450ce8a9a58db3", "query": "From the Deprecated API Migration Guide: , since v1.19, the has been using the new reportingController and reportingInstance to replace the decrecated source.component and But when I checked the Kube events in a cluster with version 1.26.0, those new fields are empty and the supposed to be deprecated fields have not been renamed. Seeing the values in the new fields like reportingController and reportingInstance an Kubernetes cluster with version 1.26.0 some Kube events the Kube events details for the field of reportingController, reportingInstance, source.component, No response <detailsServer Version: version.Info{Major:\"1\", Minor:\"26\", GitVersion:\"v1.26.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2022-12-11T00:15:47Z\", GoVersion:\"go1.19.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} </details<detailsAzure </details<details</details<details</details<details</details<details</details\n/sig instrumentation\nI have also encountered this issue in my local 1.26.0 Kubernetes cluster, which does not align with the deprecation guide described in I believe I can investigate this further\n/assign\nThank you for making the PR to fix this! Also a comment in the PR for the doc update.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-1aacb98fcd461517e38e2ba5f3a4002551aaf1d41e7145438f2f3715611177ea", "text": "event := recorder.makeEvent(ref, annotations, eventtype, reason, message) event.Source = recorder.source <ins> event.ReportingInstance = recorder.source.Host event.ReportingController = recorder.source.Component </ins> // NOTE: events should be a non-blocking operation, but we also need to not // put this in a goroutine, otherwise we'll race to write to a closed channel // when we go to shut down this broadcaster.  Just drop events if we get overloaded,", "commid": "kubernetes_pr_116506"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04e3b909e513627c5b2af9f40bf2e8ca20eddfe7646c93203a450ce8a9a58db3", "query": "From the Deprecated API Migration Guide: , since v1.19, the has been using the new reportingController and reportingInstance to replace the decrecated source.component and But when I checked the Kube events in a cluster with version 1.26.0, those new fields are empty and the supposed to be deprecated fields have not been renamed. Seeing the values in the new fields like reportingController and reportingInstance an Kubernetes cluster with version 1.26.0 some Kube events the Kube events details for the field of reportingController, reportingInstance, source.component, No response <detailsServer Version: version.Info{Major:\"1\", Minor:\"26\", GitVersion:\"v1.26.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2022-12-11T00:15:47Z\", GoVersion:\"go1.19.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} </details<detailsAzure </details<details</details<details</details<details</details<details</details\n/sig instrumentation\nI have also encountered this issue in my local 1.26.0 Kubernetes cluster, which does not align with the deprecation guide described in I believe I can investigate this further\n/assign\nThank you for making the PR to fix this! Also a comment in the PR for the doc update.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-f9bd611d0196e5887517d4cda3f1a9c84657eaf7e320b98a559c02fcbc7b2d96", "text": "APIVersion: \"v1\", FieldPath:  \"spec.containers[2]\", }, <del> Reason:  \"Started\", Message: \"some verbose message: 1\", Source:  v1.EventSource{Component: \"eventTest\"}, Count:   1, Type:    v1.EventTypeNormal, </del> <ins> Reason:              \"Started\", Message:             \"some verbose message: 1\", Source:              v1.EventSource{Component: \"eventTest\"}, ReportingController: \"eventTest\", Count:               1, Type:                v1.EventTypeNormal, </ins> }, expectLog:    `Event(v1.ObjectReference{Kind:\"Pod\", Namespace:\"baz\", Name:\"foo\", UID:\"bar\", APIVersion:\"v1\", ResourceVersion:\"\", FieldPath:\"spec.containers[2]\"}): type: 'Normal' reason: 'Started' some verbose message: 1`, expectUpdate: false,", "commid": "kubernetes_pr_116506"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04e3b909e513627c5b2af9f40bf2e8ca20eddfe7646c93203a450ce8a9a58db3", "query": "From the Deprecated API Migration Guide: , since v1.19, the has been using the new reportingController and reportingInstance to replace the decrecated source.component and But when I checked the Kube events in a cluster with version 1.26.0, those new fields are empty and the supposed to be deprecated fields have not been renamed. Seeing the values in the new fields like reportingController and reportingInstance an Kubernetes cluster with version 1.26.0 some Kube events the Kube events details for the field of reportingController, reportingInstance, source.component, No response <detailsServer Version: version.Info{Major:\"1\", Minor:\"26\", GitVersion:\"v1.26.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2022-12-11T00:15:47Z\", GoVersion:\"go1.19.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} </details<detailsAzure </details<details</details<details</details<details</details<details</details\n/sig instrumentation\nI have also encountered this issue in my local 1.26.0 Kubernetes cluster, which does not align with the deprecation guide described in I believe I can investigate this further\n/assign\nThank you for making the PR to fix this! Also a comment in the PR for the doc update.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-b5b2a67d25871754b585e0b8d70fa2b2012a0b41d1d6133068bc07b8bbf4f719", "text": "UID:        \"bar\", APIVersion: \"v1\", }, <del> Reason:  \"Killed\", Message: \"some other verbose message: 1\", Source:  v1.EventSource{Component: \"eventTest\"}, Count:   1, Type:    v1.EventTypeNormal, </del> <ins> Reason:              \"Killed\", Message:             \"some other verbose message: 1\", Source:              v1.EventSource{Component: \"eventTest\"}, ReportingController: \"eventTest\", Count:               1, Type:                v1.EventTypeNormal, </ins> }, expectLog:    `Event(v1.ObjectReference{Kind:\"Pod\", Namespace:\"baz\", Name:\"foo\", UID:\"bar\", APIVersion:\"v1\", ResourceVersion:\"\", FieldPath:\"\"}): type: 'Normal' reason: 'Killed' some other verbose message: 1`, expectUpdate: false,", "commid": "kubernetes_pr_116506"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04e3b909e513627c5b2af9f40bf2e8ca20eddfe7646c93203a450ce8a9a58db3", "query": "From the Deprecated API Migration Guide: , since v1.19, the has been using the new reportingController and reportingInstance to replace the decrecated source.component and But when I checked the Kube events in a cluster with version 1.26.0, those new fields are empty and the supposed to be deprecated fields have not been renamed. Seeing the values in the new fields like reportingController and reportingInstance an Kubernetes cluster with version 1.26.0 some Kube events the Kube events details for the field of reportingController, reportingInstance, source.component, No response <detailsServer Version: version.Info{Major:\"1\", Minor:\"26\", GitVersion:\"v1.26.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2022-12-11T00:15:47Z\", GoVersion:\"go1.19.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} </details<detailsAzure </details<details</details<details</details<details</details<details</details\n/sig instrumentation\nI have also encountered this issue in my local 1.26.0 Kubernetes cluster, which does not align with the deprecation guide described in I believe I can investigate this further\n/assign\nThank you for making the PR to fix this! Also a comment in the PR for the doc update.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-286445f587731ca9f2eada1ab69a3838bf480cccbfc9086589298747a05cca60", "text": "APIVersion: \"v1\", FieldPath:  \"spec.containers[2]\", }, <del> Reason:  \"Started\", Message: \"some verbose message: 1\", Source:  v1.EventSource{Component: \"eventTest\"}, Count:   2, Type:    v1.EventTypeNormal, </del> <ins> Reason:              \"Started\", Message:             \"some verbose message: 1\", Source:              v1.EventSource{Component: \"eventTest\"}, ReportingController: \"eventTest\", Count:               2, Type:                v1.EventTypeNormal, </ins> }, expectLog:    `Event(v1.ObjectReference{Kind:\"Pod\", Namespace:\"baz\", Name:\"foo\", UID:\"bar\", APIVersion:\"v1\", ResourceVersion:\"\", FieldPath:\"spec.containers[2]\"}): type: 'Normal' reason: 'Started' some verbose message: 1`, expectUpdate: true,", "commid": "kubernetes_pr_116506"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04e3b909e513627c5b2af9f40bf2e8ca20eddfe7646c93203a450ce8a9a58db3", "query": "From the Deprecated API Migration Guide: , since v1.19, the has been using the new reportingController and reportingInstance to replace the decrecated source.component and But when I checked the Kube events in a cluster with version 1.26.0, those new fields are empty and the supposed to be deprecated fields have not been renamed. Seeing the values in the new fields like reportingController and reportingInstance an Kubernetes cluster with version 1.26.0 some Kube events the Kube events details for the field of reportingController, reportingInstance, source.component, No response <detailsServer Version: version.Info{Major:\"1\", Minor:\"26\", GitVersion:\"v1.26.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2022-12-11T00:15:47Z\", GoVersion:\"go1.19.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} </details<detailsAzure </details<details</details<details</details<details</details<details</details\n/sig instrumentation\nI have also encountered this issue in my local 1.26.0 Kubernetes cluster, which does not align with the deprecation guide described in I believe I can investigate this further\n/assign\nThank you for making the PR to fix this! Also a comment in the PR for the doc update.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-d0cfe6b1d9ccbd44ecb01d3a3e7b750f694a528e324483c6e73b1fc5cbd60010", "text": "APIVersion: \"v1\", FieldPath:  \"spec.containers[3]\", }, <del> Reason:  \"Started\", Message: \"some verbose message: 1\", Source:  v1.EventSource{Component: \"eventTest\"}, Count:   1, Type:    v1.EventTypeNormal, </del> <ins> Reason:              \"Started\", Message:             \"some verbose message: 1\", Source:              v1.EventSource{Component: \"eventTest\"}, ReportingController: \"eventTest\", Count:               1, Type:                v1.EventTypeNormal, </ins> }, expectLog:    `Event(v1.ObjectReference{Kind:\"Pod\", Namespace:\"baz\", Name:\"foo\", UID:\"differentUid\", APIVersion:\"v1\", ResourceVersion:\"\", FieldPath:\"spec.containers[3]\"}): type: 'Normal' reason: 'Started' some verbose message: 1`, expectUpdate: false,", "commid": "kubernetes_pr_116506"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04e3b909e513627c5b2af9f40bf2e8ca20eddfe7646c93203a450ce8a9a58db3", "query": "From the Deprecated API Migration Guide: , since v1.19, the has been using the new reportingController and reportingInstance to replace the decrecated source.component and But when I checked the Kube events in a cluster with version 1.26.0, those new fields are empty and the supposed to be deprecated fields have not been renamed. Seeing the values in the new fields like reportingController and reportingInstance an Kubernetes cluster with version 1.26.0 some Kube events the Kube events details for the field of reportingController, reportingInstance, source.component, No response <detailsServer Version: version.Info{Major:\"1\", Minor:\"26\", GitVersion:\"v1.26.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2022-12-11T00:15:47Z\", GoVersion:\"go1.19.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} </details<detailsAzure </details<details</details<details</details<details</details<details</details\n/sig instrumentation\nI have also encountered this issue in my local 1.26.0 Kubernetes cluster, which does not align with the deprecation guide described in I believe I can investigate this further\n/assign\nThank you for making the PR to fix this! Also a comment in the PR for the doc update.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-efe7fe86f801a0f095c6b082221d93b9409a7d1d643606027f9d72ac11036866", "text": "APIVersion: \"v1\", FieldPath:  \"spec.containers[2]\", }, <del> Reason:  \"Started\", Message: \"some verbose message: 1\", Source:  v1.EventSource{Component: \"eventTest\"}, Count:   3, Type:    v1.EventTypeNormal, </del> <ins> Reason:              \"Started\", Message:             \"some verbose message: 1\", Source:              v1.EventSource{Component: \"eventTest\"}, ReportingController: \"eventTest\", Count:               3, Type:                v1.EventTypeNormal, </ins> }, expectLog:    `Event(v1.ObjectReference{Kind:\"Pod\", Namespace:\"baz\", Name:\"foo\", UID:\"bar\", APIVersion:\"v1\", ResourceVersion:\"\", FieldPath:\"spec.containers[2]\"}): type: 'Normal' reason: 'Started' some verbose message: 1`, expectUpdate: true,", "commid": "kubernetes_pr_116506"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04e3b909e513627c5b2af9f40bf2e8ca20eddfe7646c93203a450ce8a9a58db3", "query": "From the Deprecated API Migration Guide: , since v1.19, the has been using the new reportingController and reportingInstance to replace the decrecated source.component and But when I checked the Kube events in a cluster with version 1.26.0, those new fields are empty and the supposed to be deprecated fields have not been renamed. Seeing the values in the new fields like reportingController and reportingInstance an Kubernetes cluster with version 1.26.0 some Kube events the Kube events details for the field of reportingController, reportingInstance, source.component, No response <detailsServer Version: version.Info{Major:\"1\", Minor:\"26\", GitVersion:\"v1.26.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2022-12-11T00:15:47Z\", GoVersion:\"go1.19.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} </details<detailsAzure </details<details</details<details</details<details</details<details</details\n/sig instrumentation\nI have also encountered this issue in my local 1.26.0 Kubernetes cluster, which does not align with the deprecation guide described in I believe I can investigate this further\n/assign\nThank you for making the PR to fix this! Also a comment in the PR for the doc update.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-9da816cf695c4adaa97ece94c02192f5908a58d3b8b196827698f64368036224", "text": "APIVersion: \"v1\", FieldPath:  \"spec.containers[3]\", }, <del> Reason:  \"Stopped\", Message: \"some verbose message: 1\", Source:  v1.EventSource{Component: \"eventTest\"}, Count:   1, Type:    v1.EventTypeNormal, </del> <ins> Reason:              \"Stopped\", Message:             \"some verbose message: 1\", Source:              v1.EventSource{Component: \"eventTest\"}, ReportingController: \"eventTest\", Count:               1, Type:                v1.EventTypeNormal, </ins> }, expectLog:    `Event(v1.ObjectReference{Kind:\"Pod\", Namespace:\"baz\", Name:\"foo\", UID:\"differentUid\", APIVersion:\"v1\", ResourceVersion:\"\", FieldPath:\"spec.containers[3]\"}): type: 'Normal' reason: 'Stopped' some verbose message: 1`, expectUpdate: false,", "commid": "kubernetes_pr_116506"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04e3b909e513627c5b2af9f40bf2e8ca20eddfe7646c93203a450ce8a9a58db3", "query": "From the Deprecated API Migration Guide: , since v1.19, the has been using the new reportingController and reportingInstance to replace the decrecated source.component and But when I checked the Kube events in a cluster with version 1.26.0, those new fields are empty and the supposed to be deprecated fields have not been renamed. Seeing the values in the new fields like reportingController and reportingInstance an Kubernetes cluster with version 1.26.0 some Kube events the Kube events details for the field of reportingController, reportingInstance, source.component, No response <detailsServer Version: version.Info{Major:\"1\", Minor:\"26\", GitVersion:\"v1.26.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2022-12-11T00:15:47Z\", GoVersion:\"go1.19.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} </details<detailsAzure </details<details</details<details</details<details</details<details</details\n/sig instrumentation\nI have also encountered this issue in my local 1.26.0 Kubernetes cluster, which does not align with the deprecation guide described in I believe I can investigate this further\n/assign\nThank you for making the PR to fix this! Also a comment in the PR for the doc update.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-e5727c6e949267e3af7a6337170e707f885cf00253c3e724c1a2619e84ef2cef", "text": "APIVersion: \"v1\", FieldPath:  \"spec.containers[3]\", }, <del> Reason:  \"Stopped\", Message: \"some verbose message: 1\", Source:  v1.EventSource{Component: \"eventTest\"}, Count:   2, Type:    v1.EventTypeNormal, </del> <ins> Reason:              \"Stopped\", Message:             \"some verbose message: 1\", Source:              v1.EventSource{Component: \"eventTest\"}, ReportingController: \"eventTest\", Count:               2, Type:                v1.EventTypeNormal, </ins> }, expectLog:    `Event(v1.ObjectReference{Kind:\"Pod\", Namespace:\"baz\", Name:\"foo\", UID:\"differentUid\", APIVersion:\"v1\", ResourceVersion:\"\", FieldPath:\"spec.containers[3]\"}): type: 'Normal' reason: 'Stopped' some verbose message: 1`, expectUpdate: true,", "commid": "kubernetes_pr_116506"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-04e3b909e513627c5b2af9f40bf2e8ca20eddfe7646c93203a450ce8a9a58db3", "query": "From the Deprecated API Migration Guide: , since v1.19, the has been using the new reportingController and reportingInstance to replace the decrecated source.component and But when I checked the Kube events in a cluster with version 1.26.0, those new fields are empty and the supposed to be deprecated fields have not been renamed. Seeing the values in the new fields like reportingController and reportingInstance an Kubernetes cluster with version 1.26.0 some Kube events the Kube events details for the field of reportingController, reportingInstance, source.component, No response <detailsServer Version: version.Info{Major:\"1\", Minor:\"26\", GitVersion:\"v1.26.0\", GitCommit:\"\", GitTreeState:\"clean\", BuildDate:\"2022-12-11T00:15:47Z\", GoVersion:\"go1.19.4\", Compiler:\"gc\", Platform:\"linux/amd64\"} </details<detailsAzure </details<details</details<details</details<details</details<details</details\n/sig instrumentation\nI have also encountered this issue in my local 1.26.0 Kubernetes cluster, which does not align with the deprecation guide described in I believe I can investigate this further\n/assign\nThank you for making the PR to fix this! Also a comment in the PR for the doc update.\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-12196467217c3f52922fc6d09a6fe74e4500bbe0f8c057c3c1f89c6f56ec3b22", "text": "// Temp clear time stamps for comparison because actual values don't matter for comparison recvEvent.FirstTimestamp = expectedEvent.FirstTimestamp recvEvent.LastTimestamp = expectedEvent.LastTimestamp <ins> recvEvent.ReportingController = expectedEvent.ReportingController </ins> // Check that name has the right prefix. if n, en := recvEvent.Name, expectedEvent.Name; !strings.HasPrefix(n, en) { t.Errorf(\"%v - Name '%v' does not contain prefix '%v'\", messagePrefix, n, en)", "commid": "kubernetes_pr_116506"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1f4123c828672256c348bc539b38c34a946e71292e23552bc51c4890f70b8975", "query": "tc.shutdownActive is captured by 'func' literals in 'go' statements(Line177), it may cause a data race. I use t.Run(..., ){...}() or t.Run() {...}(tc) to avoid it . I don't know whether it is accurate, so I 'm looking forward to your reply. Data Race Nil No response <detailsNil </details<detailsNil </details<details</details<details</details<details</details<details</details\n/sig node\nTarget file:\n/area test /priority backlog\nhave you observed any test failures or this is found by code analysis?\nYes, it is found by code analysis. In terms of the source code, the scenario can happen.\n/assign\n/remove-kind bug /kind failing-test since it is not a product bug, but the test issue\nAlthough each test case calls a goroutine, tests run serially and block on the goroutine return, so it doesn't look like it could cause an issue. However, to be safe we can create a local copy of inside the loop. I'll send a PR briefly.\nCreated to address this.\n/triage accepted /priority important-longterm", "positive_passages": [{"docid": "doc-en-kubernetes-3c744483a6f2e230791711870f0302d453174c5e0f21d08b0f155af860c0d3fd", "text": "} for _, tc := range tests { <ins> tc := tc </ins> t.Run(tc.desc, func(t *testing.T) { fakeSystemBus := &fakeSystemDBus{} bus := DBusCon{", "commid": "kubernetes_pr_116994"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f7b92d2ae4c7de8a3091c04ca1d11b65c719334aa69b8d7a201e03a33f42c804", "query": "Example: this PR seems to be flaking: comparing age of a node from the output of two commands: Kubernetes e2e suite: [It] [sig-cli] Kubectl client kubectl subresource flag GET on status subresource of built-in type (node) returns identical info as GET on the built-in type expandless 5 hours back No response No response No response_ /sig cli\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority important-soon\nit seems that is comparing subresources and there is something there that changes over time As Sergey correctly points out is the Age The test can not assume the executions will be done in the same second\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-767018e3cdeebc7830a590adc9b5278cb06c6b4689f543ce6d59072588d56fc0", "text": "outBuiltIn := e2ekubectl.RunKubectlOrDie(\"\", \"get\", \"nodes\", node.Name) ginkgo.By(fmt.Sprintf(\"calling kubectl get nodes %s --subresource=status\", node.Name)) outStatusSubresource := e2ekubectl.RunKubectlOrDie(\"\", \"get\", \"nodes\", node.Name, \"--subresource=status\") <del> gomega.Expect(outBuiltIn).To(gomega.Equal(outStatusSubresource)) </del> <ins> // Avoid comparing values of fields that might end up // changing between the two invocations of kubectl. requiredOutput := [][]string{ {\"NAME\"}, {\"STATUS\"}, {\"ROLES\"}, {\"AGE\"}, {\"VERSION\"}, {node.Name},                           // check for NAME {\"\"},                                  // avoid comparing STATUS {\"\"},                                  // avoid comparing ROLES {\"\"},                                  // avoid comparing AGE {node.Status.NodeInfo.KubeletVersion}, // check for VERSION } checkOutput(outBuiltIn, requiredOutput) checkOutput(outStatusSubresource, requiredOutput) </ins> }) }) })", "commid": "kubernetes_pr_116619"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1d19a749ded70ac40f5a4e3891ac8db5a4f9a3cf9321999067374a962e0dd578", "query": "The following log line is often (~30times) logged during our tests in : . This suggests a possible bug as it was assumed to do not happen. No log line saying . Look at artifacts of all (or almost all) builds of: No response <details</details<detailsReproducible in tests </details<details</details<details</details<details</details<details</details\n/sig node FYI\n/triage accepted since it's a new error, it is a regression. So adding a corresponding priority /priority important-soon\nare you working on this? Should I assign bug to you?\nYes, I'm taking a look at this. /assign\n/cc\nThis is a metrics only error (we don\u2019t report a fraction of metrics) and has no functional impact.\nThat makes sense, but is it expected that this is a valid state in first place? . My assumption was that if static is false, (i.e. API pod) then we should have a config?\nI took a closer look at the logs, it seems that this is happening when we enter while a static pod is being synced which has UID reuse and another pod which has the same full name did not terminate yet. In this case, we block the static pod from starting i.e. () returns false: Because the pod can't start, we don't set : which means that when we log metrics there is no set and thus or are both defaulted to false:\nBased on the above, it looks like this case is expected. As a result, maybe the simplest option is to simply drop the log statement since by design we only want to into account a subset of the states for the metrics?", "positive_passages": [{"docid": "doc-en-kubernetes-63f6b4cdcc3623dff60b3a1e3db7a3a3138f421c46f0292a6be341af575da4bf", "text": "}, }, { <ins> name:    \"pod that could not start still has a pending update and is tracked in metrics\", wantErr: false, pods: []*v1.Pod{ staticPod(), }, prepareWorker: func(t *testing.T, w *podWorkers, records map[types.UID][]syncPodRecord) { // send a create of a static pod pod := staticPod() // block startup of the static pod due to full name collision w.startedStaticPodsByFullname[kubecontainer.GetPodFullName(pod)] = types.UID(\"2\") w.UpdatePod(UpdatePodOptions{ UpdateType: kubetypes.SyncPodCreate, StartTime:  time.Unix(1, 0).UTC(), Pod:        pod, }) drainAllWorkers(w) if _, ok := records[pod.UID]; ok { t.Fatalf(\"unexpected records: %#v\", records) } // pod worker is unaware of pod1 yet }, wantWorker: func(t *testing.T, w *podWorkers, records map[types.UID][]syncPodRecord) { uid := types.UID(\"1\") if len(w.podSyncStatuses) != 1 { t.Fatalf(\"unexpected sync statuses: %#v\", w.podSyncStatuses) } s, ok := w.podSyncStatuses[uid] if !ok || s.IsTerminationRequested() || s.IsTerminationStarted() || s.IsFinished() || s.IsWorking() || s.IsDeleted() || s.restartRequested || s.activeUpdate != nil || s.pendingUpdate == nil { t.Errorf(\"unexpected requested pod termination: %#v\", s) } // expect that no sync calls are made, since the pod doesn't ever start if actual, expected := records[uid], []syncPodRecord(nil); !reflect.DeepEqual(expected, actual) { t.Fatalf(\"unexpected pod sync records: %s\", cmp.Diff(expected, actual, cmp.AllowUnexported(syncPodRecord{}))) } }, expectMetrics: map[string]string{ metrics.DesiredPodCount.FQName(): `# HELP kubelet_desired_pods [ALPHA] The number of pods the kubelet is being instructed to run. static is true if the pod is not from the apiserver. # TYPE kubelet_desired_pods gauge kubelet_desired_pods{static=\"\"} 0 kubelet_desired_pods{static=\"true\"} 1 `, metrics.WorkingPodCount.FQName(): `# HELP kubelet_working_pods [ALPHA] Number of pods the kubelet is actually running, broken down by lifecycle phase, whether the pod is desired, orphaned, or runtime only (also orphaned), and whether the pod is static. An orphaned pod has been removed from local configuration or force deleted in the API and consumes resources that are not otherwise visible. # TYPE kubelet_working_pods gauge kubelet_working_pods{config=\"desired\",lifecycle=\"sync\",static=\"\"} 0 kubelet_working_pods{config=\"desired\",lifecycle=\"sync\",static=\"true\"} 1 kubelet_working_pods{config=\"desired\",lifecycle=\"terminated\",static=\"\"} 0 kubelet_working_pods{config=\"desired\",lifecycle=\"terminated\",static=\"true\"} 0 kubelet_working_pods{config=\"desired\",lifecycle=\"terminating\",static=\"\"} 0 kubelet_working_pods{config=\"desired\",lifecycle=\"terminating\",static=\"true\"} 0 kubelet_working_pods{config=\"orphan\",lifecycle=\"sync\",static=\"\"} 0 kubelet_working_pods{config=\"orphan\",lifecycle=\"sync\",static=\"true\"} 0 kubelet_working_pods{config=\"orphan\",lifecycle=\"terminated\",static=\"\"} 0 kubelet_working_pods{config=\"orphan\",lifecycle=\"terminated\",static=\"true\"} 0 kubelet_working_pods{config=\"orphan\",lifecycle=\"terminating\",static=\"\"} 0 kubelet_working_pods{config=\"orphan\",lifecycle=\"terminating\",static=\"true\"} 0 kubelet_working_pods{config=\"runtime_only\",lifecycle=\"sync\",static=\"unknown\"} 0 kubelet_working_pods{config=\"runtime_only\",lifecycle=\"terminated\",static=\"unknown\"} 0 kubelet_working_pods{config=\"runtime_only\",lifecycle=\"terminating\",static=\"unknown\"} 0 `, }, }, { </ins> name:           \"pod that could not start and is not in config is force terminated without runtime during pod cleanup\", wantErr:        false, terminatingErr: errors.New(\"unable to terminate\"),", "commid": "kubernetes_pr_116995"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1d19a749ded70ac40f5a4e3891ac8db5a4f9a3cf9321999067374a962e0dd578", "query": "The following log line is often (~30times) logged during our tests in : . This suggests a possible bug as it was assumed to do not happen. No log line saying . Look at artifacts of all (or almost all) builds of: No response <details</details<detailsReproducible in tests </details<details</details<details</details<details</details<details</details\n/sig node FYI\n/triage accepted since it's a new error, it is a regression. So adding a corresponding priority /priority important-soon\nare you working on this? Should I assign bug to you?\nYes, I'm taking a look at this. /assign\n/cc\nThis is a metrics only error (we don\u2019t report a fraction of metrics) and has no functional impact.\nThat makes sense, but is it expected that this is a valid state in first place? . My assumption was that if static is false, (i.e. API pod) then we should have a config?\nI took a closer look at the logs, it seems that this is happening when we enter while a static pod is being synced which has UID reuse and another pod which has the same full name did not terminate yet. In this case, we block the static pod from starting i.e. () returns false: Because the pod can't start, we don't set : which means that when we log metrics there is no set and thus or are both defaulted to false:\nBased on the above, it looks like this case is expected. As a result, maybe the simplest option is to simply drop the log statement since by design we only want to into account a subset of the states for the metrics?", "positive_passages": [{"docid": "doc-en-kubernetes-6e40e5aec75e92b6f493a71bde00b4e67833acbb00f29c5f9953a1f389324311", "text": "// or can be started, and updates the cached pod state so that downstream components can observe what the // pod worker goroutine is currently attempting to do. If ok is false, there is no available event. If any // of the boolean values is false, ensure the appropriate cleanup happens before returning. <ins> // // This method should ensure that either status.pendingUpdate is cleared and merged into status.activeUpdate, // or when a pod cannot be started status.pendingUpdate remains the same. Pods that have not been started // should never have an activeUpdate because that is exposed to downstream components on started pods. </ins> func (p *podWorkers) startPodSync(podUID types.UID) (ctx context.Context, update podWork, canStart, canEverStart, ok bool) { p.podLock.Lock() defer p.podLock.Unlock()", "commid": "kubernetes_pr_116995"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1d19a749ded70ac40f5a4e3891ac8db5a4f9a3cf9321999067374a962e0dd578", "query": "The following log line is often (~30times) logged during our tests in : . This suggests a possible bug as it was assumed to do not happen. No log line saying . Look at artifacts of all (or almost all) builds of: No response <details</details<detailsReproducible in tests </details<details</details<details</details<details</details<details</details\n/sig node FYI\n/triage accepted since it's a new error, it is a regression. So adding a corresponding priority /priority important-soon\nare you working on this? Should I assign bug to you?\nYes, I'm taking a look at this. /assign\n/cc\nThis is a metrics only error (we don\u2019t report a fraction of metrics) and has no functional impact.\nThat makes sense, but is it expected that this is a valid state in first place? . My assumption was that if static is false, (i.e. API pod) then we should have a config?\nI took a closer look at the logs, it seems that this is happening when we enter while a static pod is being synced which has UID reuse and another pod which has the same full name did not terminate yet. In this case, we block the static pod from starting i.e. () returns false: Because the pod can't start, we don't set : which means that when we log metrics there is no set and thus or are both defaulted to false:\nBased on the above, it looks like this case is expected. As a result, maybe the simplest option is to simply drop the log statement since by design we only want to into account a subset of the states for the metrics?", "positive_passages": [{"docid": "doc-en-kubernetes-974d81673621e949b2174a966258faf76edbae1683e9d2d8165c353efffcc738", "text": "klog.V(4).InfoS(\"Pod cannot start ever\", \"pod\", klog.KObj(update.Options.Pod), \"podUID\", podUID, \"updateType\", update.WorkType) return ctx, update, canStart, canEverStart, true case !canStart: <ins> // this is the only path we don't start the pod, so we need to put the change back in pendingUpdate status.pendingUpdate = &update.Options </ins> status.working = false klog.V(4).InfoS(\"Pod cannot start yet\", \"pod\", klog.KObj(update.Options.Pod), \"podUID\", podUID) return ctx, update, canStart, canEverStart, true", "commid": "kubernetes_pr_116995"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1d19a749ded70ac40f5a4e3891ac8db5a4f9a3cf9321999067374a962e0dd578", "query": "The following log line is often (~30times) logged during our tests in : . This suggests a possible bug as it was assumed to do not happen. No log line saying . Look at artifacts of all (or almost all) builds of: No response <details</details<detailsReproducible in tests </details<details</details<details</details<details</details<details</details\n/sig node FYI\n/triage accepted since it's a new error, it is a regression. So adding a corresponding priority /priority important-soon\nare you working on this? Should I assign bug to you?\nYes, I'm taking a look at this. /assign\n/cc\nThis is a metrics only error (we don\u2019t report a fraction of metrics) and has no functional impact.\nThat makes sense, but is it expected that this is a valid state in first place? . My assumption was that if static is false, (i.e. API pod) then we should have a config?\nI took a closer look at the logs, it seems that this is happening when we enter while a static pod is being synced which has UID reuse and another pod which has the same full name did not terminate yet. In this case, we block the static pod from starting i.e. () returns false: Because the pod can't start, we don't set : which means that when we log metrics there is no set and thus or are both defaulted to false:\nBased on the above, it looks like this case is expected. As a result, maybe the simplest option is to simply drop the log statement since by design we only want to into account a subset of the states for the metrics?", "positive_passages": [{"docid": "doc-en-kubernetes-474cfd8dcd0f6c8309c869ec2a05ec4ac53fe293c4ecb917b74f40a483fed415", "text": "State:  status.WorkType(), Orphan: orphan, } <del> if status.activeUpdate != nil && status.activeUpdate.Pod != nil { sync.HasConfig = true sync.Static = kubetypes.IsStaticPod(status.activeUpdate.Pod) </del> <ins> switch { case status.activeUpdate != nil: if status.activeUpdate.Pod != nil { sync.HasConfig = true sync.Static = kubetypes.IsStaticPod(status.activeUpdate.Pod) } case status.pendingUpdate != nil: if status.pendingUpdate.Pod != nil { sync.HasConfig = true sync.Static = kubetypes.IsStaticPod(status.pendingUpdate.Pod) } </ins> } workers[uid] = sync }", "commid": "kubernetes_pr_116995"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-37578c7ef1fc35bcc9b20a625a2453047827b433a40713775cf7720c37f7ee33", "query": "If a pod is created and then deleted an entry in processedPods map remains forever (sometimes, it's racy). The problem comes from the fact that calls volume_manager asynchronously. If the last call happens after populator cleaned up resources, an entry is to processedPods and will never be seen. An entry in processedPods map must be deleted if pod doesn't exist and pod runtime should removed according to . To verify that the issue really exists I applaied a simple printing resources in map. Here is a reproducer: brand-new fresh k8s cluster with entries in : a pod, check its uid: that this uid is accurately reported: the pod, wait for a few mins, check for again: The entry will be kept forever because kubelet doesn't know anything about this pod anymore: so no more events will ever come to populater for this uid, and the loop in won't find it because it was already deleted from . n/a <details</details<detailsany </details<details</details<details</details<details</details<details</details\n/sig storage\n/triage accepted\n/priority impoerant-soon\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority impoerant-soon Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority important-soon\n/assign\nPR () fixed this issue. It is ready to merge since Mar 21.\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-1ac72de09af1145881f243319e62bb8c4d838f0e88ee72ecf86239eb4f6d2246", "text": "// Iterate through all pods in desired state of world, and remove if they no // longer exist func (dswp *desiredStateOfWorldPopulator) findAndRemoveDeletedPods() { <ins> podsFromCache := make(map[volumetypes.UniquePodName]struct{}) </ins> for _, volumeToMount := range dswp.desiredStateOfWorld.GetVolumesToMount() { <ins> podsFromCache[volumetypes.UniquePodName(volumeToMount.Pod.UID)] = struct{}{} </ins> pod, podExists := dswp.podManager.GetPodByUID(volumeToMount.Pod.UID) if podExists {", "commid": "kubernetes_pr_116833"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-37578c7ef1fc35bcc9b20a625a2453047827b433a40713775cf7720c37f7ee33", "query": "If a pod is created and then deleted an entry in processedPods map remains forever (sometimes, it's racy). The problem comes from the fact that calls volume_manager asynchronously. If the last call happens after populator cleaned up resources, an entry is to processedPods and will never be seen. An entry in processedPods map must be deleted if pod doesn't exist and pod runtime should removed according to . To verify that the issue really exists I applaied a simple printing resources in map. Here is a reproducer: brand-new fresh k8s cluster with entries in : a pod, check its uid: that this uid is accurately reported: the pod, wait for a few mins, check for again: The entry will be kept forever because kubelet doesn't know anything about this pod anymore: so no more events will ever come to populater for this uid, and the loop in won't find it because it was already deleted from . n/a <details</details<detailsany </details<details</details<details</details<details</details<details</details\n/sig storage\n/triage accepted\n/priority impoerant-soon\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority impoerant-soon Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority important-soon\n/assign\nPR () fixed this issue. It is ready to merge since Mar 21.\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-7249c9ed7f82a2385e7647832912ab77f9e1470c9edd64e1b7c744fd2d348312", "text": "dswp.deleteProcessedPod(volumeToMount.PodName) } <ins> // Cleanup orphanded entries from processedPods dswp.pods.Lock() orphanedPods := make([]volumetypes.UniquePodName, 0, len(dswp.pods.processedPods)) for k := range dswp.pods.processedPods { if _, ok := podsFromCache[k]; !ok { orphanedPods = append(orphanedPods, k) } } dswp.pods.Unlock() for _, orphanedPod := range orphanedPods { uid := types.UID(orphanedPod) _, podExists := dswp.podManager.GetPodByUID(uid) if !podExists && dswp.podStateProvider.ShouldPodRuntimeBeRemoved(uid) { dswp.deleteProcessedPod(orphanedPod) } } </ins> podsWithError := dswp.desiredStateOfWorld.GetPodsWithErrors() for _, podName := range podsWithError { if _, podExists := dswp.podManager.GetPodByUID(types.UID(podName)); !podExists {", "commid": "kubernetes_pr_116833"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-37578c7ef1fc35bcc9b20a625a2453047827b433a40713775cf7720c37f7ee33", "query": "If a pod is created and then deleted an entry in processedPods map remains forever (sometimes, it's racy). The problem comes from the fact that calls volume_manager asynchronously. If the last call happens after populator cleaned up resources, an entry is to processedPods and will never be seen. An entry in processedPods map must be deleted if pod doesn't exist and pod runtime should removed according to . To verify that the issue really exists I applaied a simple printing resources in map. Here is a reproducer: brand-new fresh k8s cluster with entries in : a pod, check its uid: that this uid is accurately reported: the pod, wait for a few mins, check for again: The entry will be kept forever because kubelet doesn't know anything about this pod anymore: so no more events will ever come to populater for this uid, and the loop in won't find it because it was already deleted from . n/a <details</details<detailsany </details<details</details<details</details<details</details<details</details\n/sig storage\n/triage accepted\n/priority impoerant-soon\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /priority impoerant-soon Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/priority important-soon\n/assign\nPR () fixed this issue. It is ready to merge since Mar 21.\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-17b45a9a4146c1747102c7076bd161ed85de258b354895d7ffa2c65f35847a67", "text": "t.Fatalf(\"Failed to remove pods from desired state of world since they no longer exist\") } <ins> // podWorker may call volume_manager WaitForUnmount() after we processed the pod in findAndRemoveDeletedPods() dswp.ReprocessPod(podName) dswp.findAndRemoveDeletedPods() // findAndRemoveDeletedPods() above must detect orphaned pod and delete it from the map if _, ok := dswp.pods.processedPods[podName]; ok { t.Fatalf(\"Failed to remove orphanded pods from internal map\") } </ins> volumeExists := dswp.desiredStateOfWorld.VolumeExists(expectedVolumeName, \"\" /* SELinuxContext */) if volumeExists { t.Fatalf(", "commid": "kubernetes_pr_116833"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-482aab5c60c854e49844e9f7b501458de493923e9ab6838dc8496864ffefd996", "query": "Not , but removed: Looking at this comment: this should be removed once the migration to lease in leader-election was done. Can this be removed already? I mean, the following 2 lines: Security folks internally were asking if we could get rid of this upstream if it is not needed anymore (if this \"migration to lease in leader-election\" was fully done)\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig sig-scheduling\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig sig-scheduling Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig scheduling\n/cc\n/assign\nSupport for endpoints and configmap based leader election has been removed with this PR: Validation to error out leader elections configuration for resource lock type other than \"lease\" has been implemented in With this, it looks safe to remove the two lines mentioned in this issue.", "positive_passages": [{"docid": "doc-en-kubernetes-2302997c615d74634885f9fb7ee60f0f18e976544b325e927485a8aa0466467c", "text": "// TODO: scope this to the kube-system namespace rbacv1helpers.NewRule(\"create\").Groups(coordinationGroup).Resources(\"leases\").RuleOrDie(), rbacv1helpers.NewRule(\"get\", \"update\").Groups(coordinationGroup).Resources(\"leases\").Names(\"kube-scheduler\").RuleOrDie(), <del> // TODO: Remove once we fully migrate to lease in leader-election. rbacv1helpers.NewRule(\"create\").Groups(legacyGroup).Resources(\"endpoints\").RuleOrDie(), rbacv1helpers.NewRule(\"get\", \"update\").Groups(legacyGroup).Resources(\"endpoints\").Names(\"kube-scheduler\").RuleOrDie(), </del> // Fundamental resources rbacv1helpers.NewRule(Read...).Groups(legacyGroup).Resources(\"nodes\").RuleOrDie(),", "commid": "kubernetes_pr_117140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-482aab5c60c854e49844e9f7b501458de493923e9ab6838dc8496864ffefd996", "query": "Not , but removed: Looking at this comment: this should be removed once the migration to lease in leader-election was done. Can this be removed already? I mean, the following 2 lines: Security folks internally were asking if we could get rid of this upstream if it is not needed anymore (if this \"migration to lease in leader-election\" was fully done)\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig sig-scheduling\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig sig-scheduling Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig scheduling\n/cc\n/assign\nSupport for endpoints and configmap based leader election has been removed with this PR: Validation to error out leader elections configuration for resource lock type other than \"lease\" has been implemented in With this, it looks safe to remove the two lines mentioned in this issue.", "positive_passages": [{"docid": "doc-en-kubernetes-5c303e630474962f9bb41b1adfe059880df754a1569c92cf11eca715f9c439d7", "text": "- apiGroups: - \"\" resources: <del> - endpoints verbs: - create - apiGroups: - \"\" resourceNames: - kube-scheduler resources: - endpoints verbs: - get - update - apiGroups: - \"\" resources: </del> - nodes verbs: - get", "commid": "kubernetes_pr_117140"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8ef15e9cb2af20fdd7b292d3dde46c3ffb64b6b0323788d679b26abe3d6fd30a", "query": "Followup feedback from In a few e2e node tests (e.g. tests of deletion grace period) we have some busybox pods that wait for SIGTERM and perform some action like a small sleep to simulate SIGTERM taking some time. These tests follow the pattern of -- see The will block the SIGTERM handler from being run until after the time is elapsed. We should consider to remove the and instead use to avoid blocking the SIGTERM handler, see pattern followed in n/a n/a No response n/a n/a <details</details<details</details<details</details<details</details\n/sig node /cc\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-4a242efb49069a471e25bff67e50c5ce6f8cc22726f3c8c9dbcca077d79c5194", "text": "Image:   imageutils.GetE2EImage(imageutils.BusyBox), Command: []string{\"sh\", \"-c\"}, Args: []string{` <ins> sleep 9999999 & PID=$! </ins> _term() { <ins> kill $PID </ins> echo \"Caught SIGTERM signal!\" <del> exit 0 </del> } trap _term SIGTERM <del> while true; do sleep 5; done </del> <ins> wait $PID exit 0 </ins> `, }, },", "commid": "kubernetes_pr_117393"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8ef15e9cb2af20fdd7b292d3dde46c3ffb64b6b0323788d679b26abe3d6fd30a", "query": "Followup feedback from In a few e2e node tests (e.g. tests of deletion grace period) we have some busybox pods that wait for SIGTERM and perform some action like a small sleep to simulate SIGTERM taking some time. These tests follow the pattern of -- see The will block the SIGTERM handler from being run until after the time is elapsed. We should consider to remove the and instead use to avoid blocking the SIGTERM handler, see pattern followed in n/a n/a No response n/a n/a <details</details<details</details<details</details<details</details\n/sig node /cc\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-67bef338da6642ea46ee656e5c8d9cddf87eb29b70a8199d8e8bb873174755e7", "text": "} return priority } <ins> // getGracePeriodOverrideTestPod returns a new Pod object containing a container // runs a shell script, hangs the process until a SIGTERM signal is received. // The script waits for $PID to ensure that the process does not exist. // If priorityClassName is scheduling.SystemNodeCritical, the Pod is marked as critical and a comment is added. </ins> func getGracePeriodOverrideTestPod(name string, node string, gracePeriod int64, priorityClassName string) *v1.Pod { pod := &v1.Pod{ TypeMeta: metav1.TypeMeta{", "commid": "kubernetes_pr_117393"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8ef15e9cb2af20fdd7b292d3dde46c3ffb64b6b0323788d679b26abe3d6fd30a", "query": "Followup feedback from In a few e2e node tests (e.g. tests of deletion grace period) we have some busybox pods that wait for SIGTERM and perform some action like a small sleep to simulate SIGTERM taking some time. These tests follow the pattern of -- see The will block the SIGTERM handler from being run until after the time is elapsed. We should consider to remove the and instead use to avoid blocking the SIGTERM handler, see pattern followed in n/a n/a No response n/a n/a <details</details<details</details<details</details<details</details\n/sig node /cc\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-727aeaed32e48daa907513b833e33297d9151ce0a8c710c43c0516a217d7b568", "text": "Image:   busyboxImage, Command: []string{\"sh\", \"-c\"}, Args: []string{` <del> _term() { echo \"Caught SIGTERM signal!\" while true; do sleep 5; done } trap _term SIGTERM while true; do sleep 5; done `}, </del> <ins> sleep 9999999 & PID=$! _term() { echo \"Caught SIGTERM signal!\" wait $PID } trap _term SIGTERM wait $PID `}, </ins> }, }, TerminationGracePeriodSeconds: &gracePeriod,", "commid": "kubernetes_pr_117393"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1ffde837085a7cf8fda14061815d3ec79e4cb9af8d9e5a4c3a326fb5831a1bf9", "query": "No response No response /sig windows /kind failing-test\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/sig windows\ni think this problem can be fixed when it imports os/net in Am i right?\nI also found some other unit test bugs in CI, such as running linux-related tests on windows. I will try to fix them. /assign\n/cc\nThanks for opening the issue! I didn't notice the failure through the testgrid dashboard. I've sent a PR here: . While fixing this issue, I noticed there's one unit test that was failing, so that PR also addresses that as well.\nYep, the imports you mentioned are needed. Keep in mind that imports are in alphabetical order. But in addition to that, there was another failing unit test which was masked by this import errors.", "positive_passages": [{"docid": "doc-en-kubernetes-bf89a1c2ba2838f819785a6e44e79106e4e377e0169945cac9ad7ae05e11acf6", "text": "\"fmt\" \"net\" \"net/url\" <ins> \"os\" </ins> \"path/filepath\" \"strings\" \"syscall\"", "commid": "kubernetes_pr_117616"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1ffde837085a7cf8fda14061815d3ec79e4cb9af8d9e5a4c3a326fb5831a1bf9", "query": "No response No response /sig windows /kind failing-test\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/sig windows\ni think this problem can be fixed when it imports os/net in Am i right?\nI also found some other unit test bugs in CI, such as running linux-related tests on windows. I will try to fix them. /assign\n/cc\nThanks for opening the issue! I didn't notice the failure through the testgrid dashboard. I've sent a PR here: . While fixing this issue, I noticed there's one unit test that was failing, so that PR also addresses that as well.\nYep, the imports you mentioned are needed. Keep in mind that imports are in alphabetical order. But in addition to that, there was another failing unit test which was masked by this import errors.", "positive_passages": [{"docid": "doc-en-kubernetes-7a7474227f63a81b5699bcc38053e2da10c8d2aa2776d42a3c57022754ca9891", "text": "// does NOT work in 1809 if the socket file is created within a bind mounted directory by a container // and the FSCTL is issued in the host by the kubelet. <ins> // If the file does not exist, it cannot be a Unix domain socket. if _, err := os.Stat(filePath); os.IsNotExist(err) { return false, fmt.Errorf(\"File %s not found. Err: %v\", filePath, err) } </ins> klog.V(6).InfoS(\"Function IsUnixDomainSocket starts\", \"filePath\", filePath) // As detailed in https://github.com/kubernetes/kubernetes/issues/104584 we cannot rely // on the Unix Domain socket working on the very first try, hence the potential need to", "commid": "kubernetes_pr_117616"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1ffde837085a7cf8fda14061815d3ec79e4cb9af8d9e5a4c3a326fb5831a1bf9", "query": "No response No response /sig windows /kind failing-test\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/sig windows\ni think this problem can be fixed when it imports os/net in Am i right?\nI also found some other unit test bugs in CI, such as running linux-related tests on windows. I will try to fix them. /assign\n/cc\nThanks for opening the issue! I didn't notice the failure through the testgrid dashboard. I've sent a PR here: . While fixing this issue, I noticed there's one unit test that was failing, so that PR also addresses that as well.\nYep, the imports you mentioned are needed. Keep in mind that imports are in alphabetical order. But in addition to that, there was another failing unit test which was masked by this import errors.", "positive_passages": [{"docid": "doc-en-kubernetes-5c6d6967756cfbc2a4991d78056d2ab9e665e8f4b6d88da81e46507e930812f0", "text": "import ( \"fmt\" \"math/rand\" <ins> \"net\" \"os\" </ins> \"reflect\" \"runtime\" \"sync\"", "commid": "kubernetes_pr_117616"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9969bd986508ea8ad3b87aed5184f6e5ca5490b6e36b50732a630680ba555908", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Following the example here: Everything here works when you use , but when using 1.27.1, I see the following panic: What you expected to happen: When downgrading, this works as expected: How to reproduce it (as minimally and precisely as possible): <!-- Please make sure you are able to reproduce the bug using a supported version and version skew of Kubernetes. See for which versions and are currently supported. --You will need a Kubernetes cluster with Agones installed (I'm testing on 1.25.x, as you can see above), then follow this quickstart: Anything else we need to know?: The is implemented as an API Extension, not a CRD -- which is probably where the issue lies. Looking at the line: There seems to be an assuming that there will be a under and , in - there should be some nil checks in there. Environment: Kubernetes client and server versions (use ): See above Cloud provider or hardware configuration: GKE OS (e.g: ): Linux\nseems like an another edge case; Due to the server version is old and openapiv3 is returning empty?\nThanks for opening this issue /triage accepted\nI'm digging into the Agones code, but I'm 99.4% sure we don't even implement openapiv3 at all for our api endpoint\nYep, confirmed -- I see a bunch of 404's in my API Extension logs for requests for\n/transfer kubernetes /kind regression\n/sig cli /assign\nI can also work on tomorrow if Sean can not get time to look at it\nIf nothing else, this does also force me to publish an openapi spec for our API extension\nnot sure if needed to handle nils inside the schema better, or if didn't fall back to v2 correctly in the absence of v3 data\nIt appears to be the former, where an OpenAPI V3 document is returned without , while the code assumes this field is non-nil.\nseems like that should still fall back to v2\nCan we get a kubectl -v8 to see what actually happens with downloading the OpenAPI?\nAs requested!\nThanks for the quick response. It looks like the OpenAPI V3 document is almost completely empty The code is expecting an Open API document with . I will have a fix out shortly.\nI was digging through that - I found that really interesting. We only expose an basically empty spec for the api extension. It's always \"just worked\", so never needed to update it. I am curious where K8s is even getting the something that it is outputting for , but that's a side note.", "positive_passages": [{"docid": "doc-en-kubernetes-99e534531cdb36136cf541a104bf771ad29de6175c86df88a8f0da26c9086056", "text": "// the PATCH end-point. Returns true if the query param is supported by the // spec for the passed GVK; false otherwise. func supportsQueryParamV3(doc *spec3.OpenAPI, gvk schema.GroupVersionKind, queryParam VerifiableQueryParam) bool { <ins> if doc == nil || doc.Paths == nil { return false } </ins> for _, path := range doc.Paths.Paths { // If operation is not PATCH, then continue. op := path.PathProps.Patch", "commid": "kubernetes_pr_117768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9969bd986508ea8ad3b87aed5184f6e5ca5490b6e36b50732a630680ba555908", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Following the example here: Everything here works when you use , but when using 1.27.1, I see the following panic: What you expected to happen: When downgrading, this works as expected: How to reproduce it (as minimally and precisely as possible): <!-- Please make sure you are able to reproduce the bug using a supported version and version skew of Kubernetes. See for which versions and are currently supported. --You will need a Kubernetes cluster with Agones installed (I'm testing on 1.25.x, as you can see above), then follow this quickstart: Anything else we need to know?: The is implemented as an API Extension, not a CRD -- which is probably where the issue lies. Looking at the line: There seems to be an assuming that there will be a under and , in - there should be some nil checks in there. Environment: Kubernetes client and server versions (use ): See above Cloud provider or hardware configuration: GKE OS (e.g: ): Linux\nseems like an another edge case; Due to the server version is old and openapiv3 is returning empty?\nThanks for opening this issue /triage accepted\nI'm digging into the Agones code, but I'm 99.4% sure we don't even implement openapiv3 at all for our api endpoint\nYep, confirmed -- I see a bunch of 404's in my API Extension logs for requests for\n/transfer kubernetes /kind regression\n/sig cli /assign\nI can also work on tomorrow if Sean can not get time to look at it\nIf nothing else, this does also force me to publish an openapi spec for our API extension\nnot sure if needed to handle nils inside the schema better, or if didn't fall back to v2 correctly in the absence of v3 data\nIt appears to be the former, where an OpenAPI V3 document is returned without , while the code assumes this field is non-nil.\nseems like that should still fall back to v2\nCan we get a kubectl -v8 to see what actually happens with downloading the OpenAPI?\nAs requested!\nThanks for the quick response. It looks like the OpenAPI V3 document is almost completely empty The code is expecting an Open API document with . I will have a fix out shortly.\nI was digging through that - I found that really interesting. We only expose an basically empty spec for the api extension. It's always \"just worked\", so never needed to update it. I am curious where K8s is even getting the something that it is outputting for , but that's a side note.", "positive_passages": [{"docid": "doc-en-kubernetes-f4796f9bc661004f167851a7e86d6bf70d421cafeaf7278cb6d6141a719b82c0", "text": "\"k8s.io/client-go/openapi/cached\" \"k8s.io/client-go/openapi/openapitest\" \"k8s.io/client-go/openapi3\" <ins> \"k8s.io/kube-openapi/pkg/spec3\" </ins> ) func TestV3SupportsQueryParamBatchV1(t *testing.T) {", "commid": "kubernetes_pr_117768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9969bd986508ea8ad3b87aed5184f6e5ca5490b6e36b50732a630680ba555908", "query": "<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Following the example here: Everything here works when you use , but when using 1.27.1, I see the following panic: What you expected to happen: When downgrading, this works as expected: How to reproduce it (as minimally and precisely as possible): <!-- Please make sure you are able to reproduce the bug using a supported version and version skew of Kubernetes. See for which versions and are currently supported. --You will need a Kubernetes cluster with Agones installed (I'm testing on 1.25.x, as you can see above), then follow this quickstart: Anything else we need to know?: The is implemented as an API Extension, not a CRD -- which is probably where the issue lies. Looking at the line: There seems to be an assuming that there will be a under and , in - there should be some nil checks in there. Environment: Kubernetes client and server versions (use ): See above Cloud provider or hardware configuration: GKE OS (e.g: ): Linux\nseems like an another edge case; Due to the server version is old and openapiv3 is returning empty?\nThanks for opening this issue /triage accepted\nI'm digging into the Agones code, but I'm 99.4% sure we don't even implement openapiv3 at all for our api endpoint\nYep, confirmed -- I see a bunch of 404's in my API Extension logs for requests for\n/transfer kubernetes /kind regression\n/sig cli /assign\nI can also work on tomorrow if Sean can not get time to look at it\nIf nothing else, this does also force me to publish an openapi spec for our API extension\nnot sure if needed to handle nils inside the schema better, or if didn't fall back to v2 correctly in the absence of v3 data\nIt appears to be the former, where an OpenAPI V3 document is returned without , while the code assumes this field is non-nil.\nseems like that should still fall back to v2\nCan we get a kubectl -v8 to see what actually happens with downloading the OpenAPI?\nAs requested!\nThanks for the quick response. It looks like the OpenAPI V3 document is almost completely empty The code is expecting an Open API document with . I will have a fix out shortly.\nI was digging through that - I found that really interesting. We only expose an basically empty spec for the api extension. It's always \"just worked\", so never needed to update it. I am curious where K8s is even getting the something that it is outputting for , but that's a side note.", "positive_passages": [{"docid": "doc-en-kubernetes-ff6569ddb5fd1e308943d55c03c3e84018fe1d3808f390f6804c94a2afd07842", "text": "}) } } <ins> func TestInvalidOpenAPIV3Document(t *testing.T) { tests := map[string]struct { spec *spec3.OpenAPI }{ \"nil document correctly returns Unsupported error\": { spec: nil, }, \"empty document correctly returns Unsupported error\": { spec: &spec3.OpenAPI{}, }, \"minimal document correctly returns Unsupported error\": { spec: &spec3.OpenAPI{ Version: \"openapi 3.0.0\", Paths:   nil, }, }, \"document with empty Paths correctly returns Unsupported error\": { spec: &spec3.OpenAPI{ Version: \"openapi 3.0.0\", Paths:   &spec3.Paths{}, }, }, } gvk := schema.GroupVersionKind{ Group:   \"batch\", Version: \"v1\", Kind:    \"Job\", } for tn, tc := range tests { t.Run(tn, func(t *testing.T) { verifier := &queryParamVerifierV3{ finder: NewCRDFinder(func() ([]schema.GroupKind, error) { return []schema.GroupKind{}, nil }), root:       &fakeRoot{tc.spec}, queryParam: QueryParamFieldValidation, } err := verifier.HasSupport(gvk) if err == nil { t.Errorf(\"Expected not supports error, but none received.\") } }) } } // fakeRoot implements Root interface; manually specifies the returned OpenAPI V3 document. type fakeRoot struct { spec *spec3.OpenAPI } func (f *fakeRoot) GroupVersions() ([]schema.GroupVersion, error) { // Unused return nil, nil } // GVSpec returns hard-coded OpenAPI V3 document. func (f *fakeRoot) GVSpec(gv schema.GroupVersion) (*spec3.OpenAPI, error) { return f.spec, nil } func (f *fakeRoot) GVSpecAsMap(gv schema.GroupVersion) (map[string]interface{}, error) { // Unused return nil, nil } </ins>", "commid": "kubernetes_pr_117768"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f7bde9e341cfa5fb4aef7bf1e2ef4213057d2455b858e397a168aa2266e9e827", "query": "is recording the time that a Pod is gated. We use the timestamp when the scheduler inserts the pod into the queue: The period of time when a Pod fails PreEnque (like being gated) shouldn't be accounted in the podschedulingdurationseconds. Create a Pod with scheduling gates. Wait some time before removing the gate. Observe the metric No response <details</details<detailsAny </details<details</details<details</details<details</details<details</details\n/sig scheduling\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nwould you want to take a stab on this issue?\nYup, I can give it a shot. /assign helayoty\n, as we discussed, we can address this issue with different solutions: the pod timestamp to the current time , so the gated time is substituted. timestamp . Use a pointer to the InitialAttemptTimestamp and interpret as the newest timestamp so the pod will go to the back of the queue. I'll go ahead and implement solution no. 3, wdyt?\nsgtm. Any concerns ?\nI think it should be option 1 + 3, and pInfo.Timestamp should be pInfo.InitialAttemptTimestamp, right? as records the time based on :\nI think we should revisit this issue, in terms of its assumption: So is it reasonable to always exclude time spent in PreEnqueue from ? Note that PreEnqueue != SchedulingGates, is one of the PreEnqueue's usecases. In other words, some user of PreEnqueue may want to include the time spent in PreEnqueue.\nis a signal that cluster providers can use to build SLOs. The time spent before passing PreEnqueue is not under control of kube-scheduler, so considering it would not allow to build an SLO. Are you aware of other users of PreEnqueue?\nTrue, but comparing to state that metric X can or cannot be used to build SLO (which is hard IMO), I'm in favor of giving suggestion on SLI/SLO's semantic definition, for example: the official SLI definition of has a footnote clearly explaining its definition: So if a pod is gated, it's not \"immediately schedulable\", and hence doesn't fall into the definition of podstartup_latency.\nA viable solution might be providing an extra label like to explicitly exclude the time spent on preenqueue.\nThat is true, but there is no way today to exclude those pods from the metric, or separate the time. Maybe we need an extra metric, but I think the new metric could be the one that includes the time guarded in PreEnqueue. It should probably be part of the KEP. The old metric is already stable, so we can't add labels. And it might already be in use for SLOs.\ncc\nI think we should be working on that. And treat it as part of GA requirement for PodSchedulingReadiness.\nAn edge(maybe not edge) case is a pod's scheduling attempts is 0 but the is a long time, so prefer not to account for the waiting time when gated. For users not using PreEnqueue, they will not be impacted, but for users using PreEnqueue, it's a break change for it increases the duration time. And we can add a new metric like to measure how long a pod stays in a scheduler.\nI thought of \"attempts\", it's just I'm not sure it's a good idea to rely on \"attempts\" to define a SLI/SLO, b/c \"attempts\" is obtained from the in-memory object and in a HA config env, it's only updated by the primary scheduler instance. In other words, the value is inaccurate when the lease owner switches.\nattempt=0 is good enough for most scenarios\ndo we have a conclusion? Should we move on with the solution or remove this issue and the linked PR from the current release?\nI would like to move forward with this proposal. ?\nTo move it forward, I think we should add new metric(s) to explicitly tell it's including or excluding the time spent on PreEnqueue. Given is in stable level: We will need a new metric like \"podschedulingexcludingpreenqueuedurationseconds\".\n28 Bug Triage Shadow here. Just checking-in, if this is still on track for the 1.28 release?\nWe don't have a conclusion yet, but as a bug, it should qualify for changes after the freezes.", "positive_passages": [{"docid": "doc-en-kubernetes-c46f9c38dc4b02afbfbf1d67c7ae6fb887ccabf6e0aa933110eb56cd3d34498a", "text": "// back to the queue multiple times before it's successfully scheduled. // It shouldn't be updated once initialized. It's used to record the e2e scheduling // latency for a pod. <del> InitialAttemptTimestamp time.Time </del> <ins> InitialAttemptTimestamp *time.Time </ins> // If a Pod failed in a scheduling cycle, record the plugin names it failed by. UnschedulablePlugins sets.Set[string] // Whether the Pod is scheduling gated (by PreEnqueuePlugins) or not.", "commid": "kubernetes_pr_118049"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f7bde9e341cfa5fb4aef7bf1e2ef4213057d2455b858e397a168aa2266e9e827", "query": "is recording the time that a Pod is gated. We use the timestamp when the scheduler inserts the pod into the queue: The period of time when a Pod fails PreEnque (like being gated) shouldn't be accounted in the podschedulingdurationseconds. Create a Pod with scheduling gates. Wait some time before removing the gate. Observe the metric No response <details</details<detailsAny </details<details</details<details</details<details</details<details</details\n/sig scheduling\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nwould you want to take a stab on this issue?\nYup, I can give it a shot. /assign helayoty\n, as we discussed, we can address this issue with different solutions: the pod timestamp to the current time , so the gated time is substituted. timestamp . Use a pointer to the InitialAttemptTimestamp and interpret as the newest timestamp so the pod will go to the back of the queue. I'll go ahead and implement solution no. 3, wdyt?\nsgtm. Any concerns ?\nI think it should be option 1 + 3, and pInfo.Timestamp should be pInfo.InitialAttemptTimestamp, right? as records the time based on :\nI think we should revisit this issue, in terms of its assumption: So is it reasonable to always exclude time spent in PreEnqueue from ? Note that PreEnqueue != SchedulingGates, is one of the PreEnqueue's usecases. In other words, some user of PreEnqueue may want to include the time spent in PreEnqueue.\nis a signal that cluster providers can use to build SLOs. The time spent before passing PreEnqueue is not under control of kube-scheduler, so considering it would not allow to build an SLO. Are you aware of other users of PreEnqueue?\nTrue, but comparing to state that metric X can or cannot be used to build SLO (which is hard IMO), I'm in favor of giving suggestion on SLI/SLO's semantic definition, for example: the official SLI definition of has a footnote clearly explaining its definition: So if a pod is gated, it's not \"immediately schedulable\", and hence doesn't fall into the definition of podstartup_latency.\nA viable solution might be providing an extra label like to explicitly exclude the time spent on preenqueue.\nThat is true, but there is no way today to exclude those pods from the metric, or separate the time. Maybe we need an extra metric, but I think the new metric could be the one that includes the time guarded in PreEnqueue. It should probably be part of the KEP. The old metric is already stable, so we can't add labels. And it might already be in use for SLOs.\ncc\nI think we should be working on that. And treat it as part of GA requirement for PodSchedulingReadiness.\nAn edge(maybe not edge) case is a pod's scheduling attempts is 0 but the is a long time, so prefer not to account for the waiting time when gated. For users not using PreEnqueue, they will not be impacted, but for users using PreEnqueue, it's a break change for it increases the duration time. And we can add a new metric like to measure how long a pod stays in a scheduler.\nI thought of \"attempts\", it's just I'm not sure it's a good idea to rely on \"attempts\" to define a SLI/SLO, b/c \"attempts\" is obtained from the in-memory object and in a HA config env, it's only updated by the primary scheduler instance. In other words, the value is inaccurate when the lease owner switches.\nattempt=0 is good enough for most scenarios\ndo we have a conclusion? Should we move on with the solution or remove this issue and the linked PR from the current release?\nI would like to move forward with this proposal. ?\nTo move it forward, I think we should add new metric(s) to explicitly tell it's including or excluding the time spent on PreEnqueue. Given is in stable level: We will need a new metric like \"podschedulingexcludingpreenqueuedurationseconds\".\n28 Bug Triage Shadow here. Just checking-in, if this is still on track for the 1.28 release?\nWe don't have a conclusion yet, but as a bug, it should qualify for changes after the freezes.", "positive_passages": [{"docid": "doc-en-kubernetes-c80195a7c273d4dca74f109501d960d2fdd46e076535c1a5410d649ad1f918a1", "text": "p.unschedulablePods.addOrUpdate(pInfo) return false, nil } <ins> if pInfo.InitialAttemptTimestamp == nil { now := p.clock.Now() pInfo.InitialAttemptTimestamp = &now } </ins> if err := p.activeQ.Add(pInfo); err != nil { logger.Error(err, \"Error adding pod to the active queue\", \"pod\", klog.KObj(pInfo.Pod)) return false, err", "commid": "kubernetes_pr_118049"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f7bde9e341cfa5fb4aef7bf1e2ef4213057d2455b858e397a168aa2266e9e827", "query": "is recording the time that a Pod is gated. We use the timestamp when the scheduler inserts the pod into the queue: The period of time when a Pod fails PreEnque (like being gated) shouldn't be accounted in the podschedulingdurationseconds. Create a Pod with scheduling gates. Wait some time before removing the gate. Observe the metric No response <details</details<detailsAny </details<details</details<details</details<details</details<details</details\n/sig scheduling\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nwould you want to take a stab on this issue?\nYup, I can give it a shot. /assign helayoty\n, as we discussed, we can address this issue with different solutions: the pod timestamp to the current time , so the gated time is substituted. timestamp . Use a pointer to the InitialAttemptTimestamp and interpret as the newest timestamp so the pod will go to the back of the queue. I'll go ahead and implement solution no. 3, wdyt?\nsgtm. Any concerns ?\nI think it should be option 1 + 3, and pInfo.Timestamp should be pInfo.InitialAttemptTimestamp, right? as records the time based on :\nI think we should revisit this issue, in terms of its assumption: So is it reasonable to always exclude time spent in PreEnqueue from ? Note that PreEnqueue != SchedulingGates, is one of the PreEnqueue's usecases. In other words, some user of PreEnqueue may want to include the time spent in PreEnqueue.\nis a signal that cluster providers can use to build SLOs. The time spent before passing PreEnqueue is not under control of kube-scheduler, so considering it would not allow to build an SLO. Are you aware of other users of PreEnqueue?\nTrue, but comparing to state that metric X can or cannot be used to build SLO (which is hard IMO), I'm in favor of giving suggestion on SLI/SLO's semantic definition, for example: the official SLI definition of has a footnote clearly explaining its definition: So if a pod is gated, it's not \"immediately schedulable\", and hence doesn't fall into the definition of podstartup_latency.\nA viable solution might be providing an extra label like to explicitly exclude the time spent on preenqueue.\nThat is true, but there is no way today to exclude those pods from the metric, or separate the time. Maybe we need an extra metric, but I think the new metric could be the one that includes the time guarded in PreEnqueue. It should probably be part of the KEP. The old metric is already stable, so we can't add labels. And it might already be in use for SLOs.\ncc\nI think we should be working on that. And treat it as part of GA requirement for PodSchedulingReadiness.\nAn edge(maybe not edge) case is a pod's scheduling attempts is 0 but the is a long time, so prefer not to account for the waiting time when gated. For users not using PreEnqueue, they will not be impacted, but for users using PreEnqueue, it's a break change for it increases the duration time. And we can add a new metric like to measure how long a pod stays in a scheduler.\nI thought of \"attempts\", it's just I'm not sure it's a good idea to rely on \"attempts\" to define a SLI/SLO, b/c \"attempts\" is obtained from the in-memory object and in a HA config env, it's only updated by the primary scheduler instance. In other words, the value is inaccurate when the lease owner switches.\nattempt=0 is good enough for most scenarios\ndo we have a conclusion? Should we move on with the solution or remove this issue and the linked PR from the current release?\nI would like to move forward with this proposal. ?\nTo move it forward, I think we should add new metric(s) to explicitly tell it's including or excluding the time spent on PreEnqueue. Given is in stable level: We will need a new metric like \"podschedulingexcludingpreenqueuedurationseconds\".\n28 Bug Triage Shadow here. Just checking-in, if this is still on track for the 1.28 release?\nWe don't have a conclusion yet, but as a bug, it should qualify for changes after the freezes.", "positive_passages": [{"docid": "doc-en-kubernetes-9883ae5aee85f0faa16adb970e767a538539c1b53c0739ba4383702fe31753cb", "text": "return &framework.QueuedPodInfo{ PodInfo:                 podInfo, Timestamp:               now, <del> InitialAttemptTimestamp: now, </del> <ins> InitialAttemptTimestamp: nil, </ins> UnschedulablePlugins:    sets.New(plugins...), } }", "commid": "kubernetes_pr_118049"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f7bde9e341cfa5fb4aef7bf1e2ef4213057d2455b858e397a168aa2266e9e827", "query": "is recording the time that a Pod is gated. We use the timestamp when the scheduler inserts the pod into the queue: The period of time when a Pod fails PreEnque (like being gated) shouldn't be accounted in the podschedulingdurationseconds. Create a Pod with scheduling gates. Wait some time before removing the gate. Observe the metric No response <details</details<detailsAny </details<details</details<details</details<details</details<details</details\n/sig scheduling\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nwould you want to take a stab on this issue?\nYup, I can give it a shot. /assign helayoty\n, as we discussed, we can address this issue with different solutions: the pod timestamp to the current time , so the gated time is substituted. timestamp . Use a pointer to the InitialAttemptTimestamp and interpret as the newest timestamp so the pod will go to the back of the queue. I'll go ahead and implement solution no. 3, wdyt?\nsgtm. Any concerns ?\nI think it should be option 1 + 3, and pInfo.Timestamp should be pInfo.InitialAttemptTimestamp, right? as records the time based on :\nI think we should revisit this issue, in terms of its assumption: So is it reasonable to always exclude time spent in PreEnqueue from ? Note that PreEnqueue != SchedulingGates, is one of the PreEnqueue's usecases. In other words, some user of PreEnqueue may want to include the time spent in PreEnqueue.\nis a signal that cluster providers can use to build SLOs. The time spent before passing PreEnqueue is not under control of kube-scheduler, so considering it would not allow to build an SLO. Are you aware of other users of PreEnqueue?\nTrue, but comparing to state that metric X can or cannot be used to build SLO (which is hard IMO), I'm in favor of giving suggestion on SLI/SLO's semantic definition, for example: the official SLI definition of has a footnote clearly explaining its definition: So if a pod is gated, it's not \"immediately schedulable\", and hence doesn't fall into the definition of podstartup_latency.\nA viable solution might be providing an extra label like to explicitly exclude the time spent on preenqueue.\nThat is true, but there is no way today to exclude those pods from the metric, or separate the time. Maybe we need an extra metric, but I think the new metric could be the one that includes the time guarded in PreEnqueue. It should probably be part of the KEP. The old metric is already stable, so we can't add labels. And it might already be in use for SLOs.\ncc\nI think we should be working on that. And treat it as part of GA requirement for PodSchedulingReadiness.\nAn edge(maybe not edge) case is a pod's scheduling attempts is 0 but the is a long time, so prefer not to account for the waiting time when gated. For users not using PreEnqueue, they will not be impacted, but for users using PreEnqueue, it's a break change for it increases the duration time. And we can add a new metric like to measure how long a pod stays in a scheduler.\nI thought of \"attempts\", it's just I'm not sure it's a good idea to rely on \"attempts\" to define a SLI/SLO, b/c \"attempts\" is obtained from the in-memory object and in a HA config env, it's only updated by the primary scheduler instance. In other words, the value is inaccurate when the lease owner switches.\nattempt=0 is good enough for most scenarios\ndo we have a conclusion? Should we move on with the solution or remove this issue and the linked PR from the current release?\nI would like to move forward with this proposal. ?\nTo move it forward, I think we should add new metric(s) to explicitly tell it's including or excluding the time spent on PreEnqueue. Given is in stable level: We will need a new metric like \"podschedulingexcludingpreenqueuedurationseconds\".\n28 Bug Triage Shadow here. Just checking-in, if this is still on track for the 1.28 release?\nWe don't have a conclusion yet, but as a bug, it should qualify for changes after the freezes.", "positive_passages": [{"docid": "doc-en-kubernetes-700dfa5a18592c641c98782cccc0e4631069bf540c2df43eae10d956fdc85111", "text": "t.Fatalf(\"Failed to pop a pod %v\", err) } checkPerPodSchedulingMetrics(\"Attempt twice with update\", t, pInfo, 2, timestamp) <ins> // Case 4: A gated pod is created and scheduled after lifting gate. The queue operations are //  Add gated pod -> check unschedulablePods -> lift gate & update pod -> Pop. c = testingclock.NewFakeClock(timestamp) // Create a queue with PreEnqueuePlugin m := map[string][]framework.PreEnqueuePlugin{\"\": {&preEnqueuePlugin{allowlists: []string{\"foo\"}}}} queue = NewTestQueue(ctx, newDefaultQueueSort(), WithClock(c), WithPreEnqueuePluginMap(m), WithPluginMetricsSamplePercent(0)) // Create a pod without PreEnqueuePlugin label. gatedPod := st.MakePod().Name(\"gated-test-pod\").Namespace(\"test-ns\").UID(\"test-uid\").Obj() err = queue.Add(logger, gatedPod) if err != nil { t.Fatalf(\"Failed to add a pod %v\", err) } // Check pod is added to the unschedulablePods queue. if getUnschedulablePod(queue, gatedPod) != gatedPod { t.Errorf(\"Pod %v was not found in the unschedulablePods.\", gatedPod.Name) } // Override clock to get different InitialAttemptTimestamp c.Step(1 * time.Minute) // Update pod with the required label to get it out of unschedulablePods queue. updateGatedPod := gatedPod.DeepCopy() updateGatedPod.Labels = map[string]string{\"foo\": \"\"} queue.Update(logger, gatedPod, updateGatedPod) pInfo, err = queue.Pop() if err != nil { t.Fatalf(\"Failed to pop a pod %v\", err) } checkPerPodSchedulingMetrics(\"Attempt once/gated\", t, pInfo, 1, timestamp.Add(1*time.Minute)) </ins> } func TestIncomingPodsMetrics(t *testing.T) {", "commid": "kubernetes_pr_118049"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f7bde9e341cfa5fb4aef7bf1e2ef4213057d2455b858e397a168aa2266e9e827", "query": "is recording the time that a Pod is gated. We use the timestamp when the scheduler inserts the pod into the queue: The period of time when a Pod fails PreEnque (like being gated) shouldn't be accounted in the podschedulingdurationseconds. Create a Pod with scheduling gates. Wait some time before removing the gate. Observe the metric No response <details</details<detailsAny </details<details</details<details</details<details</details<details</details\n/sig scheduling\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nwould you want to take a stab on this issue?\nYup, I can give it a shot. /assign helayoty\n, as we discussed, we can address this issue with different solutions: the pod timestamp to the current time , so the gated time is substituted. timestamp . Use a pointer to the InitialAttemptTimestamp and interpret as the newest timestamp so the pod will go to the back of the queue. I'll go ahead and implement solution no. 3, wdyt?\nsgtm. Any concerns ?\nI think it should be option 1 + 3, and pInfo.Timestamp should be pInfo.InitialAttemptTimestamp, right? as records the time based on :\nI think we should revisit this issue, in terms of its assumption: So is it reasonable to always exclude time spent in PreEnqueue from ? Note that PreEnqueue != SchedulingGates, is one of the PreEnqueue's usecases. In other words, some user of PreEnqueue may want to include the time spent in PreEnqueue.\nis a signal that cluster providers can use to build SLOs. The time spent before passing PreEnqueue is not under control of kube-scheduler, so considering it would not allow to build an SLO. Are you aware of other users of PreEnqueue?\nTrue, but comparing to state that metric X can or cannot be used to build SLO (which is hard IMO), I'm in favor of giving suggestion on SLI/SLO's semantic definition, for example: the official SLI definition of has a footnote clearly explaining its definition: So if a pod is gated, it's not \"immediately schedulable\", and hence doesn't fall into the definition of podstartup_latency.\nA viable solution might be providing an extra label like to explicitly exclude the time spent on preenqueue.\nThat is true, but there is no way today to exclude those pods from the metric, or separate the time. Maybe we need an extra metric, but I think the new metric could be the one that includes the time guarded in PreEnqueue. It should probably be part of the KEP. The old metric is already stable, so we can't add labels. And it might already be in use for SLOs.\ncc\nI think we should be working on that. And treat it as part of GA requirement for PodSchedulingReadiness.\nAn edge(maybe not edge) case is a pod's scheduling attempts is 0 but the is a long time, so prefer not to account for the waiting time when gated. For users not using PreEnqueue, they will not be impacted, but for users using PreEnqueue, it's a break change for it increases the duration time. And we can add a new metric like to measure how long a pod stays in a scheduler.\nI thought of \"attempts\", it's just I'm not sure it's a good idea to rely on \"attempts\" to define a SLI/SLO, b/c \"attempts\" is obtained from the in-memory object and in a HA config env, it's only updated by the primary scheduler instance. In other words, the value is inaccurate when the lease owner switches.\nattempt=0 is good enough for most scenarios\ndo we have a conclusion? Should we move on with the solution or remove this issue and the linked PR from the current release?\nI would like to move forward with this proposal. ?\nTo move it forward, I think we should add new metric(s) to explicitly tell it's including or excluding the time spent on PreEnqueue. Given is in stable level: We will need a new metric like \"podschedulingexcludingpreenqueuedurationseconds\".\n28 Bug Triage Shadow here. Just checking-in, if this is still on track for the 1.28 release?\nWe don't have a conclusion yet, but as a bug, it should qualify for changes after the freezes.", "positive_passages": [{"docid": "doc-en-kubernetes-9739c1fa7417db6258a2cadf6e63760efaf6c57f2ec886d10627e6b239fd417e", "text": "if pInfo.Attempts != wantAttempts { t.Errorf(\"[%s] Pod schedule attempt unexpected, got %v, want %v\", name, pInfo.Attempts, wantAttempts) } <del> if pInfo.InitialAttemptTimestamp != wantInitialAttemptTs { t.Errorf(\"[%s] Pod initial schedule attempt timestamp unexpected, got %v, want %v\", name, pInfo.InitialAttemptTimestamp, wantInitialAttemptTs) </del> <ins> if *pInfo.InitialAttemptTimestamp != wantInitialAttemptTs { t.Errorf(\"[%s] Pod initial schedule attempt timestamp unexpected, got %v, want %v\", name, *pInfo.InitialAttemptTimestamp, wantInitialAttemptTs) </ins> } }", "commid": "kubernetes_pr_118049"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f7bde9e341cfa5fb4aef7bf1e2ef4213057d2455b858e397a168aa2266e9e827", "query": "is recording the time that a Pod is gated. We use the timestamp when the scheduler inserts the pod into the queue: The period of time when a Pod fails PreEnque (like being gated) shouldn't be accounted in the podschedulingdurationseconds. Create a Pod with scheduling gates. Wait some time before removing the gate. Observe the metric No response <details</details<detailsAny </details<details</details<details</details<details</details<details</details\n/sig scheduling\n/help /triage accepted\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nwould you want to take a stab on this issue?\nYup, I can give it a shot. /assign helayoty\n, as we discussed, we can address this issue with different solutions: the pod timestamp to the current time , so the gated time is substituted. timestamp . Use a pointer to the InitialAttemptTimestamp and interpret as the newest timestamp so the pod will go to the back of the queue. I'll go ahead and implement solution no. 3, wdyt?\nsgtm. Any concerns ?\nI think it should be option 1 + 3, and pInfo.Timestamp should be pInfo.InitialAttemptTimestamp, right? as records the time based on :\nI think we should revisit this issue, in terms of its assumption: So is it reasonable to always exclude time spent in PreEnqueue from ? Note that PreEnqueue != SchedulingGates, is one of the PreEnqueue's usecases. In other words, some user of PreEnqueue may want to include the time spent in PreEnqueue.\nis a signal that cluster providers can use to build SLOs. The time spent before passing PreEnqueue is not under control of kube-scheduler, so considering it would not allow to build an SLO. Are you aware of other users of PreEnqueue?\nTrue, but comparing to state that metric X can or cannot be used to build SLO (which is hard IMO), I'm in favor of giving suggestion on SLI/SLO's semantic definition, for example: the official SLI definition of has a footnote clearly explaining its definition: So if a pod is gated, it's not \"immediately schedulable\", and hence doesn't fall into the definition of podstartup_latency.\nA viable solution might be providing an extra label like to explicitly exclude the time spent on preenqueue.\nThat is true, but there is no way today to exclude those pods from the metric, or separate the time. Maybe we need an extra metric, but I think the new metric could be the one that includes the time guarded in PreEnqueue. It should probably be part of the KEP. The old metric is already stable, so we can't add labels. And it might already be in use for SLOs.\ncc\nI think we should be working on that. And treat it as part of GA requirement for PodSchedulingReadiness.\nAn edge(maybe not edge) case is a pod's scheduling attempts is 0 but the is a long time, so prefer not to account for the waiting time when gated. For users not using PreEnqueue, they will not be impacted, but for users using PreEnqueue, it's a break change for it increases the duration time. And we can add a new metric like to measure how long a pod stays in a scheduler.\nI thought of \"attempts\", it's just I'm not sure it's a good idea to rely on \"attempts\" to define a SLI/SLO, b/c \"attempts\" is obtained from the in-memory object and in a HA config env, it's only updated by the primary scheduler instance. In other words, the value is inaccurate when the lease owner switches.\nattempt=0 is good enough for most scenarios\ndo we have a conclusion? Should we move on with the solution or remove this issue and the linked PR from the current release?\nI would like to move forward with this proposal. ?\nTo move it forward, I think we should add new metric(s) to explicitly tell it's including or excluding the time spent on PreEnqueue. Given is in stable level: We will need a new metric like \"podschedulingexcludingpreenqueuedurationseconds\".\n28 Bug Triage Shadow here. Just checking-in, if this is still on track for the 1.28 release?\nWe don't have a conclusion yet, but as a bug, it should qualify for changes after the freezes.", "positive_passages": [{"docid": "doc-en-kubernetes-38101ba1d0a72c9df9947eb5c8cb278b7cb03b0ea17b5c5f882c647a5f45e85a", "text": "logger.V(2).Info(\"Successfully bound pod to node\", \"pod\", klog.KObj(assumedPod), \"node\", scheduleResult.SuggestedHost, \"evaluatedNodes\", scheduleResult.EvaluatedNodes, \"feasibleNodes\", scheduleResult.FeasibleNodes) metrics.PodScheduled(fwk.ProfileName(), metrics.SinceInSeconds(start)) metrics.PodSchedulingAttempts.Observe(float64(assumedPodInfo.Attempts)) <del> metrics.PodSchedulingDuration.WithLabelValues(getAttemptsLabel(assumedPodInfo)).Observe(metrics.SinceInSeconds(assumedPodInfo.InitialAttemptTimestamp)) </del> <ins> if assumedPodInfo.InitialAttemptTimestamp != nil { metrics.PodSchedulingDuration.WithLabelValues(getAttemptsLabel(assumedPodInfo)).Observe(metrics.SinceInSeconds(*assumedPodInfo.InitialAttemptTimestamp)) } </ins> // Run \"postbind\" plugins. fwk.RunPostBindPlugins(ctx, state, assumedPod, scheduleResult.SuggestedHost)", "commid": "kubernetes_pr_118049"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e778adaebb7204aaccdb6b0ad852288af0cc70a46f89c26d93abbff84abe1ce5", "query": "Data as of June 3rd, 9:00 PM Eastern. Latest data can be found here: Additional Context:\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig release\ncc Do we want to keep this job and fix it, or do something different considering the debs/rpms efforts?\nI think we should keep this job as long as we build packages for Google infra (those are using different specs then packages for OBS).\nfixed it:", "positive_passages": [{"docid": "doc-en-kubernetes-45fee3bfc08af62be5d24cd2722e2016f6c08ac4378d0c9b3df4d14a51eba8b1", "text": "<ins> #!/bin/bash # Copyright 2014 Google Inc. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the \"License\"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # #     http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an \"AS IS\" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # Bring up a Kubernetes cluster. # Usage: #   wget -q -O - https://get.k8s.io | sh # or #   curl -sS https://get.k8s.io | sh # # Advanced options #  Set KUBERNETES_PROVIDER to choose between different providers: #  Google Compute Engine [default] #   * export KUBERNETES_PROVIDER=gce; wget -q -O - https://get.k8s.io | sh #  Amazon EC2 #   * export KUBERNETES_PROVIDER=aws; wget -q -O - https://get.k8s.io | sh #  Microsoft Azure #   * export KUBERNETES_PROVIDER=azure; wget -q -O - https://get.k8s.io | sh #  Vagrant (local virtual machines) #   * export KUBERNETES_PROVIDER=vagrant; wget -q -O - https://get.k8s.io | sh #  VMWare VSphere #   * export KUBERNETES_PROVIDER=vsphere; wget -q -O - https://get.k8s.io | sh #  Rackspace #   * export KUBERNETES_PROVIDER=rackspace; wget -q -O - https://get.k8s.io | sh # #  Set KUBERNETES_SKIP_DOWNLOAD to non-empty to skip downloading a release. #  Set KUBERNETES_SKIP_CONFIRM to skip the installation confirmation prompt. set -o errexit set -o nounset set -o pipefail function create-cluster { echo \"Creating a kubernetes on ${KUBERNETES_PROVIDER:-gce}...\" ( cd kubernetes ./cluster/kube-up.sh echo \"Kubernetes binaries at ${PWD}/kubernetes/cluster/\" echo \"You may want to add this directory to your PATH in $HOME/.profile\" echo \"Installation successful!\" ) } if [[ \"${KUBERNETES_SKIP_DOWNLOAD-}\" ]]; then create-cluster exit 0 fi release=v0.7.2 release_url=https://storage.googleapis.com/kubernetes-release/release/${release}/kubernetes.tar.gz uname=$(uname) if [[ \"${uname}\" == \"Darwin\" ]]; then platform=\"darwin\" elif [[ \"${uname}\" == \"Linux\" ]]; then platform=\"linux\" else echo \"Unknown, unsupported platform: (${uname}).\" echo \"Supported platforms: Linux, Darwin.\" echo \"Bailing out.\" exit 2 fi machine=$(uname -m) if [[ \"${machine}\" == \"x86_64\" ]]; then arch=\"amd64\" elif [[ \"${machine}\" == \"i686\" ]]; then arch=\"386\" elif [[ \"${machine}\" == \"arm*\" ]]; then arch=\"arm\" else echo \"Unknown, unsupported architecture (${machine}).\" echo \"Supported architectures x86_64, i686, arm*\" echo \"Bailing out.\" exit 3 fi file=kubernetes.tar.gz echo \"Downloading kubernetes release ${release} to ${PWD}/kubernetes.tar.gz\" if [[ -n \"${KUBERNETES_SKIP_CONFIRM-}\" ]]; then echo \"Is this ok? [Y]/n\" read confirm if [[ \"$confirm\" == \"n\" ]]; then echo \"Aborting.\" exit 0 fi fi if [[ $(which wget) ]]; then wget -O ${file} ${release_url} elif [[ $(which curl) ]]; then curl -L -o ${file} ${release_url} else echo \"Couldn't find curl or wget.  Bailing out.\" exit 1 fi echo \"Unpacking kubernetes release ${release}\" tar -xzf ${file} rm ${file} create-cluster </ins>", "commid": "kubernetes_pr_3106"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc4591d5a968b672a0570388697c9d60ee563c13cd8a5a0b6a61949383cd02ed", "query": "This pertains more for clusters running in GCP but not necessarily in a GKE environment. Clusters that using a CNI supporting overlay such as Calico, do not need explicit routes to be created on the infrastructure level, meaning that the route controller should not be necessary. The following snippet sets the condition for new GCE nodes when a new node is picked up by the node controller. This condition is supposed to be removed later by the route controller in However, as stated above there are cases where the route controller is not needed and should not be running. When Calico is deployed in such a way that the calico-node pods are ignoring any and all taints including the cloudprovider's taint (which we consider reasonable for a system pod such as calico), the above check creates the following race condition: a Calico pod may start and set the node network conditions ( to false) before the node controller reconciles the node. After that the node controller picks up the node and sets the condition to an otherwise healthy node. Leaving aside the race condition itself, I have to ask whether the check is meaningful in the first place. AFAIK, the kubelet in Kubelet only sets the condition for provider, but clusters should already be using kubelet with cloudprovider= For the node controller to not set the condition unnecessarily. An easy way to do it with a custom CCM image is to introduce some delay in the node sync loop, enough for pods such as calico-node to start on that node. No response <details</details<detailsGCP </details<details</details<details</details<details</details<detailsCalico </details\nThis should be fixed by /cc\n/sig cloud-provider /sig network /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-e0e53f532102924fc5ada3fcfcf1b086bc16eb7d9d66146b0724830b772af52d", "text": "}) err = clientretry.RetryOnConflict(UpdateNodeSpecBackoff, func() error { <del> var curNode *v1.Node if cnc.cloud.ProviderName() == \"gce\" { // TODO(wlan0): Move this logic to the route controller using the node taint instead of condition // Since there are node taints, do we still need this? // This condition marks the node as unusable until routes are initialized in the cloud provider if err := nodeutil.SetNodeCondition(cnc.kubeClient, types.NodeName(nodeName), v1.NodeCondition{ Type:               v1.NodeNetworkUnavailable, Status:             v1.ConditionTrue, Reason:             \"NoRouteCreated\", Message:            \"Node created without a route\", LastTransitionTime: metav1.Now(), }); err != nil { return err } // fetch latest node from API server since GCE-specific condition was set and informer cache may be stale curNode, err = cnc.kubeClient.CoreV1().Nodes().Get(context.TODO(), nodeName, metav1.GetOptions{}) if err != nil { return err } } else { curNode, err = cnc.nodeInformer.Lister().Get(nodeName) if err != nil { return err } </del> <ins> curNode, err = cnc.nodeInformer.Lister().Get(nodeName) if err != nil { return err </ins> } newNode := curNode.DeepCopy()", "commid": "kubernetes_pr_123777"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-fc4591d5a968b672a0570388697c9d60ee563c13cd8a5a0b6a61949383cd02ed", "query": "This pertains more for clusters running in GCP but not necessarily in a GKE environment. Clusters that using a CNI supporting overlay such as Calico, do not need explicit routes to be created on the infrastructure level, meaning that the route controller should not be necessary. The following snippet sets the condition for new GCE nodes when a new node is picked up by the node controller. This condition is supposed to be removed later by the route controller in However, as stated above there are cases where the route controller is not needed and should not be running. When Calico is deployed in such a way that the calico-node pods are ignoring any and all taints including the cloudprovider's taint (which we consider reasonable for a system pod such as calico), the above check creates the following race condition: a Calico pod may start and set the node network conditions ( to false) before the node controller reconciles the node. After that the node controller picks up the node and sets the condition to an otherwise healthy node. Leaving aside the race condition itself, I have to ask whether the check is meaningful in the first place. AFAIK, the kubelet in Kubelet only sets the condition for provider, but clusters should already be using kubelet with cloudprovider= For the node controller to not set the condition unnecessarily. An easy way to do it with a custom CCM image is to introduce some delay in the node sync loop, enough for pods such as calico-node to start on that node. No response <details</details<detailsGCP </details<details</details<details</details<details</details<detailsCalico </details\nThis should be fixed by /cc\n/sig cloud-provider /sig network /assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-5ef55e7c72186ffac2352dd3d40f297d6308fc5eca7857dd420fe6e9e72a343f", "text": "} } <del> // test syncNode with instanceV2, same test case with TestGCECondition. func TestGCEConditionV2(t *testing.T) { existingNode := &v1.Node{ ObjectMeta: metav1.ObjectMeta{ Name:              \"node0\", CreationTimestamp: metav1.Date(2012, 1, 1, 0, 0, 0, 0, time.UTC), }, Status: v1.NodeStatus{ Conditions: []v1.NodeCondition{ { Type:               v1.NodeReady, Status:             v1.ConditionUnknown, LastHeartbeatTime:  metav1.Date(2015, 1, 1, 12, 0, 0, 0, time.UTC), LastTransitionTime: metav1.Date(2015, 1, 1, 12, 0, 0, 0, time.UTC), }, }, }, Spec: v1.NodeSpec{ Taints: []v1.Taint{ { Key:    cloudproviderapi.TaintExternalCloudProvider, Value:  \"true\", Effect: v1.TaintEffectNoSchedule, }, }, }, } fakeCloud := &fakecloud.Cloud{ EnableInstancesV2: true, InstanceTypes: map[types.NodeName]string{ types.NodeName(\"node0\"): \"t1.micro\", }, ProviderID: map[types.NodeName]string{ types.NodeName(\"node0\"): \"fake://12334\", }, Addresses: []v1.NodeAddress{ { Type:    v1.NodeHostName, Address: \"node0.cloud.internal\", }, { Type:    v1.NodeInternalIP, Address: \"10.0.0.1\", }, { Type:    v1.NodeExternalIP, Address: \"132.143.154.163\", }, }, Provider: \"gce\", Err:      nil, } clientset := fake.NewSimpleClientset(existingNode) factory := informers.NewSharedInformerFactory(clientset, 0) eventBroadcaster := record.NewBroadcaster() cloudNodeController := &CloudNodeController{ kubeClient:                clientset, nodeInformer:              factory.Core().V1().Nodes(), nodesLister:               factory.Core().V1().Nodes().Lister(), cloud:                     fakeCloud, recorder:                  eventBroadcaster.NewRecorder(scheme.Scheme, v1.EventSource{Component: \"cloud-node-controller\"}), nodeStatusUpdateFrequency: 1 * time.Second, } stopCh := make(chan struct{}) defer close(stopCh) factory.Start(stopCh) factory.WaitForCacheSync(stopCh) w := eventBroadcaster.StartLogging(klog.Infof) defer w.Stop() cloudNodeController.syncNode(context.TODO(), existingNode.Name) updatedNode, err := clientset.CoreV1().Nodes().Get(context.TODO(), existingNode.Name, metav1.GetOptions{}) if err != nil { t.Fatalf(\"error getting updated nodes: %v\", err) } conditionAdded := false for _, cond := range updatedNode.Status.Conditions { if cond.Status == \"True\" && cond.Type == \"NetworkUnavailable\" && cond.Reason == \"NoRouteCreated\" { conditionAdded = true } } assert.True(t, conditionAdded, \"Network Route Condition for GCE not added by external cloud initializer\") } // This test checks that a node with the external cloud provider taint is cloudprovider initialized and // the GCE route condition is added if cloudprovider is GCE func TestGCECondition(t *testing.T) { existingNode := &v1.Node{ ObjectMeta: metav1.ObjectMeta{ Name:              \"node0\", CreationTimestamp: metav1.Date(2012, 1, 1, 0, 0, 0, 0, time.UTC), }, Status: v1.NodeStatus{ Conditions: []v1.NodeCondition{ { Type:               v1.NodeReady, Status:             v1.ConditionUnknown, LastHeartbeatTime:  metav1.Date(2015, 1, 1, 12, 0, 0, 0, time.UTC), LastTransitionTime: metav1.Date(2015, 1, 1, 12, 0, 0, 0, time.UTC), }, }, }, Spec: v1.NodeSpec{ Taints: []v1.Taint{ { Key:    cloudproviderapi.TaintExternalCloudProvider, Value:  \"true\", Effect: v1.TaintEffectNoSchedule, }, }, }, } fakeCloud := &fakecloud.Cloud{ EnableInstancesV2: false, InstanceTypes: map[types.NodeName]string{ types.NodeName(\"node0\"): \"t1.micro\", }, Addresses: []v1.NodeAddress{ { Type:    v1.NodeHostName, Address: \"node0.cloud.internal\", }, { Type:    v1.NodeInternalIP, Address: \"10.0.0.1\", }, { Type:    v1.NodeExternalIP, Address: \"132.143.154.163\", }, }, Provider: \"gce\", Err:      nil, } clientset := fake.NewSimpleClientset(existingNode) factory := informers.NewSharedInformerFactory(clientset, 0) eventBroadcaster := record.NewBroadcaster() cloudNodeController := &CloudNodeController{ kubeClient:                clientset, nodeInformer:              factory.Core().V1().Nodes(), nodesLister:               factory.Core().V1().Nodes().Lister(), cloud:                     fakeCloud, recorder:                  eventBroadcaster.NewRecorder(scheme.Scheme, v1.EventSource{Component: \"cloud-node-controller\"}), nodeStatusUpdateFrequency: 1 * time.Second, } stopCh := make(chan struct{}) defer close(stopCh) factory.Start(stopCh) factory.WaitForCacheSync(stopCh) w := eventBroadcaster.StartLogging(klog.Infof) defer w.Stop() cloudNodeController.syncNode(context.TODO(), existingNode.Name) updatedNode, err := clientset.CoreV1().Nodes().Get(context.TODO(), existingNode.Name, metav1.GetOptions{}) if err != nil { t.Fatalf(\"error getting updated nodes: %v\", err) } conditionAdded := false for _, cond := range updatedNode.Status.Conditions { if cond.Status == \"True\" && cond.Type == \"NetworkUnavailable\" && cond.Reason == \"NoRouteCreated\" { conditionAdded = true } } assert.True(t, conditionAdded, \"Network Route Condition for GCE not added by external cloud initializer\") } </del> func Test_reconcileNodeLabels(t *testing.T) { testcases := []struct { name           string", "commid": "kubernetes_pr_123777"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-770086606bae719d268caabc123abc30e449a3085cd77438e71558b5b1142417", "query": "Add the following to be safe sysctls: net.ipv4.tcpfintimeout net.ipv4.tcpkeepaliveintvl net.ipv4.tcpkeepaliveprobes These are related settings to net.ipv4.tcpkeepalivetime that was enabled in These are related ipv4 TCP settings for tuning network connections between a client and a pod.\n/sig network\nMay you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node.\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : May you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node. /sig nodes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI adjusted it with the plugin.\nWould this change apply at the node level or the pod level? I assumed it would be at the pod level, and should not affect any other pods--however Kubernetes does not natively have any limits on network connections that I am aware of--but only the pod with the changed net settings would be affected.\nTo verify that a sysctl has an effect on other pods, we need to verify that it's a namespace sysctl.\nHere's a simple test Use net.ipv4.tcpfintimeout sysctl to create a container check if it set on the host =It is the default value on host run another container attach to the network namespace of the one where the sysctl is set =results in sysctl being set Verify in another container under a different network namespace that it is not set =It is the default value According to the test results, net.ipv4.tcpfintimeout is a namespaced sysctl\nI likewise verified and , which are also namespaced sysctl, and I believe we can add them to the safe sysctl /assign\nProbably need to wait for to finish before start working on it\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-eaaea2d6ff6c8bd60953a71a37cc668f06e41282243f4b8d042b66194cb72f31", "text": "name: \"net.ipv4.tcp_keepalive_time\", // refer to https://github.com/torvalds/linux/commit/13b287e8d1cad951634389f85b8c9b816bd3bb1e. kernel: \"4.5\", <ins> }, { // refer to https://github.com/torvalds/linux/commit/1e579caa18b96f9eb18f4f5416658cd15f37c062. name:   \"net.ipv4.tcp_fin_timeout\", kernel: \"4.6\", }, { // refer to https://github.com/torvalds/linux/commit/b840d15d39128d08ed4486085e5507d2617b9ae1. name:   \"net.ipv4.tcp_keepalive_intvl\", kernel: \"4.5\", }, { // refer to https://github.com/torvalds/linux/commit/9bd6861bd4326e3afd3f14a9ec8a723771fb20bb. name:   \"net.ipv4.tcp_keepalive_probes\", kernel: \"4.5\", </ins> }, }", "commid": "kubernetes_pr_121240"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-770086606bae719d268caabc123abc30e449a3085cd77438e71558b5b1142417", "query": "Add the following to be safe sysctls: net.ipv4.tcpfintimeout net.ipv4.tcpkeepaliveintvl net.ipv4.tcpkeepaliveprobes These are related settings to net.ipv4.tcpkeepalivetime that was enabled in These are related ipv4 TCP settings for tuning network connections between a client and a pod.\n/sig network\nMay you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node.\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : May you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node. /sig nodes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI adjusted it with the plugin.\nWould this change apply at the node level or the pod level? I assumed it would be at the pod level, and should not affect any other pods--however Kubernetes does not natively have any limits on network connections that I am aware of--but only the pod with the changed net settings would be affected.\nTo verify that a sysctl has an effect on other pods, we need to verify that it's a namespace sysctl.\nHere's a simple test Use net.ipv4.tcpfintimeout sysctl to create a container check if it set on the host =It is the default value on host run another container attach to the network namespace of the one where the sysctl is set =results in sysctl being set Verify in another container under a different network namespace that it is not set =It is the default value According to the test results, net.ipv4.tcpfintimeout is a namespaced sysctl\nI likewise verified and , which are also namespaced sysctl, and I believe we can add them to the safe sysctl /assign\nProbably need to wait for to finish before start working on it\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-3616c13cf6f0820033356172eb6c21489043d12ad489306ac39c88e61ec87d72", "text": "}, }, { <del> name: \"kernelVersion is 5.15.0, return safeSysctls with no kernelVersion limit and net.ipv4.ip_local_reserved_ports and net.ipv4.tcp_keepalive_time\", </del> <ins> name: \"kernelVersion is 5.15.0, return safeSysctls with no kernelVersion limit and kernelVersion below 5.15.0\", </ins> getVersion: func() (*version.Version, error) { kernelVersionStr := \"5.15.0-75-generic\" return version.ParseGeneric(kernelVersionStr)", "commid": "kubernetes_pr_121240"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-770086606bae719d268caabc123abc30e449a3085cd77438e71558b5b1142417", "query": "Add the following to be safe sysctls: net.ipv4.tcpfintimeout net.ipv4.tcpkeepaliveintvl net.ipv4.tcpkeepaliveprobes These are related settings to net.ipv4.tcpkeepalivetime that was enabled in These are related ipv4 TCP settings for tuning network connections between a client and a pod.\n/sig network\nMay you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node.\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : May you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node. /sig nodes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI adjusted it with the plugin.\nWould this change apply at the node level or the pod level? I assumed it would be at the pod level, and should not affect any other pods--however Kubernetes does not natively have any limits on network connections that I am aware of--but only the pod with the changed net settings would be affected.\nTo verify that a sysctl has an effect on other pods, we need to verify that it's a namespace sysctl.\nHere's a simple test Use net.ipv4.tcpfintimeout sysctl to create a container check if it set on the host =It is the default value on host run another container attach to the network namespace of the one where the sysctl is set =results in sysctl being set Verify in another container under a different network namespace that it is not set =It is the default value According to the test results, net.ipv4.tcpfintimeout is a namespaced sysctl\nI likewise verified and , which are also namespaced sysctl, and I believe we can add them to the safe sysctl /assign\nProbably need to wait for to finish before start working on it\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-055631af0db00abc99b90036008baaec6ec5de122865a8315a043972612c0e77", "text": "\"net.ipv4.ip_unprivileged_port_start\", \"net.ipv4.ip_local_reserved_ports\", \"net.ipv4.tcp_keepalive_time\", <ins> \"net.ipv4.tcp_fin_timeout\", \"net.ipv4.tcp_keepalive_intvl\", \"net.ipv4.tcp_keepalive_probes\", </ins> }, }, }", "commid": "kubernetes_pr_121240"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-770086606bae719d268caabc123abc30e449a3085cd77438e71558b5b1142417", "query": "Add the following to be safe sysctls: net.ipv4.tcpfintimeout net.ipv4.tcpkeepaliveintvl net.ipv4.tcpkeepaliveprobes These are related settings to net.ipv4.tcpkeepalivetime that was enabled in These are related ipv4 TCP settings for tuning network connections between a client and a pod.\n/sig network\nMay you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node.\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : May you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node. /sig nodes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI adjusted it with the plugin.\nWould this change apply at the node level or the pod level? I assumed it would be at the pod level, and should not affect any other pods--however Kubernetes does not natively have any limits on network connections that I am aware of--but only the pod with the changed net settings would be affected.\nTo verify that a sysctl has an effect on other pods, we need to verify that it's a namespace sysctl.\nHere's a simple test Use net.ipv4.tcpfintimeout sysctl to create a container check if it set on the host =It is the default value on host run another container attach to the network namespace of the one where the sysctl is set =results in sysctl being set Verify in another container under a different network namespace that it is not set =It is the default value According to the test results, net.ipv4.tcpfintimeout is a namespaced sysctl\nI likewise verified and , which are also namespaced sysctl, and I believe we can add them to the safe sysctl /assign\nProbably need to wait for to finish before start working on it\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-d2ce1c1799cd74bb499f84923b0ee3ccbfe772d199fc9f700b749d24cfc0387e", "text": "'net.ipv4.ip_unprivileged_port_start' 'net.ipv4.ip_local_reserved_ports' 'net.ipv4.tcp_keepalive_time' <ins> 'net.ipv4.tcp_fin_timeout' 'net.ipv4.tcp_keepalive_intvl' 'net.ipv4.tcp_keepalive_probes' </ins> */", "commid": "kubernetes_pr_121240"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-770086606bae719d268caabc123abc30e449a3085cd77438e71558b5b1142417", "query": "Add the following to be safe sysctls: net.ipv4.tcpfintimeout net.ipv4.tcpkeepaliveintvl net.ipv4.tcpkeepaliveprobes These are related settings to net.ipv4.tcpkeepalivetime that was enabled in These are related ipv4 TCP settings for tuning network connections between a client and a pod.\n/sig network\nMay you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node.\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : May you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node. /sig nodes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI adjusted it with the plugin.\nWould this change apply at the node level or the pod level? I assumed it would be at the pod level, and should not affect any other pods--however Kubernetes does not natively have any limits on network connections that I am aware of--but only the pod with the changed net settings would be affected.\nTo verify that a sysctl has an effect on other pods, we need to verify that it's a namespace sysctl.\nHere's a simple test Use net.ipv4.tcpfintimeout sysctl to create a container check if it set on the host =It is the default value on host run another container attach to the network namespace of the one where the sysctl is set =results in sysctl being set Verify in another container under a different network namespace that it is not set =It is the default value According to the test results, net.ipv4.tcpfintimeout is a namespaced sysctl\nI likewise verified and , which are also namespaced sysctl, and I believe we can add them to the safe sysctl /assign\nProbably need to wait for to finish before start working on it\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-dd73d8e9c2bc20d55eeb2795934164dbb6073e2977c7470298f3279f62029c81", "text": "\"net.ipv4.ip_unprivileged_port_start\", \"net.ipv4.ip_local_reserved_ports\", \"net.ipv4.tcp_keepalive_time\", <ins> \"net.ipv4.tcp_fin_timeout\", \"net.ipv4.tcp_keepalive_intvl\", \"net.ipv4.tcp_keepalive_probes\", </ins> ) )", "commid": "kubernetes_pr_121240"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-770086606bae719d268caabc123abc30e449a3085cd77438e71558b5b1142417", "query": "Add the following to be safe sysctls: net.ipv4.tcpfintimeout net.ipv4.tcpkeepaliveintvl net.ipv4.tcpkeepaliveprobes These are related settings to net.ipv4.tcpkeepalivetime that was enabled in These are related ipv4 TCP settings for tuning network connections between a client and a pod.\n/sig network\nMay you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node.\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : May you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node. /sig nodes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI adjusted it with the plugin.\nWould this change apply at the node level or the pod level? I assumed it would be at the pod level, and should not affect any other pods--however Kubernetes does not natively have any limits on network connections that I am aware of--but only the pod with the changed net settings would be affected.\nTo verify that a sysctl has an effect on other pods, we need to verify that it's a namespace sysctl.\nHere's a simple test Use net.ipv4.tcpfintimeout sysctl to create a container check if it set on the host =It is the default value on host run another container attach to the network namespace of the one where the sysctl is set =results in sysctl being set Verify in another container under a different network namespace that it is not set =It is the default value According to the test results, net.ipv4.tcpfintimeout is a namespaced sysctl\nI likewise verified and , which are also namespaced sysctl, and I believe we can add them to the safe sysctl /assign\nProbably need to wait for to finish before start working on it\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-e74b8789a37068cae5ca2ea7bedea803efc2eab1e1a928ef16192e7344b95543", "text": "expectReason: `forbidden sysctls`, expectDetail: `net.ipv4.tcp_keepalive_time`, }, <ins> { name: \"new supported sysctls not supported: net.ipv4.tcp_fin_timeout\", pod: &corev1.Pod{Spec: corev1.PodSpec{ SecurityContext: &corev1.PodSecurityContext{ Sysctls: []corev1.Sysctl{{Name: \"net.ipv4.tcp_fin_timeout\", Value: \"60\"}}, }, }}, allowed:      false, expectReason: `forbidden sysctls`, expectDetail: `net.ipv4.tcp_fin_timeout`, }, { name: \"new supported sysctls not supported: net.ipv4.tcp_keepalive_intvl\", pod: &corev1.Pod{Spec: corev1.PodSpec{ SecurityContext: &corev1.PodSecurityContext{ Sysctls: []corev1.Sysctl{{Name: \"net.ipv4.tcp_keepalive_intvl\", Value: \"75\"}}, }, }}, allowed:      false, expectReason: `forbidden sysctls`, expectDetail: `net.ipv4.tcp_keepalive_intvl`, }, { name: \"new supported sysctls not supported: net.ipv4.tcp_keepalive_probes\", pod: &corev1.Pod{Spec: corev1.PodSpec{ SecurityContext: &corev1.PodSecurityContext{ Sysctls: []corev1.Sysctl{{Name: \"net.ipv4.tcp_keepalive_probes\", Value: \"9\"}}, }, }}, allowed:      false, expectReason: `forbidden sysctls`, expectDetail: `net.ipv4.tcp_keepalive_probes`, }, </ins> } for _, tc := range tests {", "commid": "kubernetes_pr_121240"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-770086606bae719d268caabc123abc30e449a3085cd77438e71558b5b1142417", "query": "Add the following to be safe sysctls: net.ipv4.tcpfintimeout net.ipv4.tcpkeepaliveintvl net.ipv4.tcpkeepaliveprobes These are related settings to net.ipv4.tcpkeepalivetime that was enabled in These are related ipv4 TCP settings for tuning network connections between a client and a pod.\n/sig network\nMay you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node.\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : May you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node. /sig nodes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI adjusted it with the plugin.\nWould this change apply at the node level or the pod level? I assumed it would be at the pod level, and should not affect any other pods--however Kubernetes does not natively have any limits on network connections that I am aware of--but only the pod with the changed net settings would be affected.\nTo verify that a sysctl has an effect on other pods, we need to verify that it's a namespace sysctl.\nHere's a simple test Use net.ipv4.tcpfintimeout sysctl to create a container check if it set on the host =It is the default value on host run another container attach to the network namespace of the one where the sysctl is set =results in sysctl being set Verify in another container under a different network namespace that it is not set =It is the default value According to the test results, net.ipv4.tcpfintimeout is a namespaced sysctl\nI likewise verified and , which are also namespaced sysctl, and I believe we can add them to the safe sysctl /assign\nProbably need to wait for to finish before start working on it\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-29c6d80b543a2e479c63ecf75c011fc72422d30d9cfdff99f30c4b9304bd9a7c", "text": "expectDetail: `a, b`, }, { <del> name: \"new supported sysctls\", </del> <ins> name: \"new supported sysctls: net.ipv4.tcp_keepalive_time\", </ins> pod: &corev1.Pod{Spec: corev1.PodSpec{ SecurityContext: &corev1.PodSecurityContext{ Sysctls: []corev1.Sysctl{{Name: \"net.ipv4.tcp_keepalive_time\", Value: \"7200\"}},", "commid": "kubernetes_pr_121240"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-770086606bae719d268caabc123abc30e449a3085cd77438e71558b5b1142417", "query": "Add the following to be safe sysctls: net.ipv4.tcpfintimeout net.ipv4.tcpkeepaliveintvl net.ipv4.tcpkeepaliveprobes These are related settings to net.ipv4.tcpkeepalivetime that was enabled in These are related ipv4 TCP settings for tuning network connections between a client and a pod.\n/sig network\nMay you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node.\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : May you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node. /sig nodes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI adjusted it with the plugin.\nWould this change apply at the node level or the pod level? I assumed it would be at the pod level, and should not affect any other pods--however Kubernetes does not natively have any limits on network connections that I am aware of--but only the pod with the changed net settings would be affected.\nTo verify that a sysctl has an effect on other pods, we need to verify that it's a namespace sysctl.\nHere's a simple test Use net.ipv4.tcpfintimeout sysctl to create a container check if it set on the host =It is the default value on host run another container attach to the network namespace of the one where the sysctl is set =results in sysctl being set Verify in another container under a different network namespace that it is not set =It is the default value According to the test results, net.ipv4.tcpfintimeout is a namespaced sysctl\nI likewise verified and , which are also namespaced sysctl, and I believe we can add them to the safe sysctl /assign\nProbably need to wait for to finish before start working on it\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-410e8453b8f78f376ff7c17f6bb71bc2b4406102a86db877ef849b188d4e7e49", "text": "}}, allowed: true, }, <ins> { name: \"new supported sysctls: net.ipv4.tcp_fin_timeout\", pod: &corev1.Pod{Spec: corev1.PodSpec{ SecurityContext: &corev1.PodSecurityContext{ Sysctls: []corev1.Sysctl{{Name: \"net.ipv4.tcp_fin_timeout\", Value: \"60\"}}, }, }}, allowed: true, }, { name: \"new supported sysctls: net.ipv4.tcp_keepalive_intvl\", pod: &corev1.Pod{Spec: corev1.PodSpec{ SecurityContext: &corev1.PodSecurityContext{ Sysctls: []corev1.Sysctl{{Name: \"net.ipv4.tcp_keepalive_intvl\", Value: \"75\"}}, }, }}, allowed: true, }, { name: \"new supported sysctls: net.ipv4.tcp_keepalive_probes\", pod: &corev1.Pod{Spec: corev1.PodSpec{ SecurityContext: &corev1.PodSecurityContext{ Sysctls: []corev1.Sysctl{{Name: \"net.ipv4.tcp_keepalive_probes\", Value: \"9\"}}, }, }}, allowed: true, }, </ins> } for _, tc := range tests {", "commid": "kubernetes_pr_121240"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-770086606bae719d268caabc123abc30e449a3085cd77438e71558b5b1142417", "query": "Add the following to be safe sysctls: net.ipv4.tcpfintimeout net.ipv4.tcpkeepaliveintvl net.ipv4.tcpkeepaliveprobes These are related settings to net.ipv4.tcpkeepalivetime that was enabled in These are related ipv4 TCP settings for tuning network connections between a client and a pod.\n/sig network\nMay you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node.\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : May you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node. /sig nodes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI adjusted it with the plugin.\nWould this change apply at the node level or the pod level? I assumed it would be at the pod level, and should not affect any other pods--however Kubernetes does not natively have any limits on network connections that I am aware of--but only the pod with the changed net settings would be affected.\nTo verify that a sysctl has an effect on other pods, we need to verify that it's a namespace sysctl.\nHere's a simple test Use net.ipv4.tcpfintimeout sysctl to create a container check if it set on the host =It is the default value on host run another container attach to the network namespace of the one where the sysctl is set =results in sysctl being set Verify in another container under a different network namespace that it is not set =It is the default value According to the test results, net.ipv4.tcpfintimeout is a namespaced sysctl\nI likewise verified and , which are also namespaced sysctl, and I believe we can add them to the safe sysctl /assign\nProbably need to wait for to finish before start working on it\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-e88bb8e866924064be3c717bb69ac1e0729dacf91e655d9b7c0314e24275deff", "text": "{Name: \"net.ipv4.ip_unprivileged_port_start\", Value: \"1024\"}, {Name: \"net.ipv4.ip_local_reserved_ports\", Value: \"1024-4999\"}, {Name: \"net.ipv4.tcp_keepalive_time\", Value: \"7200\"}, <ins> {Name: \"net.ipv4.tcp_fin_timeout\", Value: \"60\"}, {Name: \"net.ipv4.tcp_keepalive_intvl\", Value: \"75\"}, {Name: \"net.ipv4.tcp_keepalive_probes\", Value: \"9\"}, </ins> } }), }", "commid": "kubernetes_pr_121240"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-770086606bae719d268caabc123abc30e449a3085cd77438e71558b5b1142417", "query": "Add the following to be safe sysctls: net.ipv4.tcpfintimeout net.ipv4.tcpkeepaliveintvl net.ipv4.tcpkeepaliveprobes These are related settings to net.ipv4.tcpkeepalivetime that was enabled in These are related ipv4 TCP settings for tuning network connections between a client and a pod.\n/sig network\nMay you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node.\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : May you help provide some tests to ensure that setting this sysctl can't affect any other pods or the node. /sig nodes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nI adjusted it with the plugin.\nWould this change apply at the node level or the pod level? I assumed it would be at the pod level, and should not affect any other pods--however Kubernetes does not natively have any limits on network connections that I am aware of--but only the pod with the changed net settings would be affected.\nTo verify that a sysctl has an effect on other pods, we need to verify that it's a namespace sysctl.\nHere's a simple test Use net.ipv4.tcpfintimeout sysctl to create a container check if it set on the host =It is the default value on host run another container attach to the network namespace of the one where the sysctl is set =results in sysctl being set Verify in another container under a different network namespace that it is not set =It is the default value According to the test results, net.ipv4.tcpfintimeout is a namespaced sysctl\nI likewise verified and , which are also namespaced sysctl, and I believe we can add them to the safe sysctl /assign\nProbably need to wait for to finish before start working on it\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-05f4cdc6a215a9c9f15c6b1e945dc34ca6fa0c9f51fb2404262ba685b2d8ceb0", "text": "value: 1024-4999 - name: net.ipv4.tcp_keepalive_time value: \"7200\" <ins> - name: net.ipv4.tcp_fin_timeout value: \"60\" - name: net.ipv4.tcp_keepalive_intvl value: \"75\" - name: net.ipv4.tcp_keepalive_probes value: \"9\" </ins>", "commid": "kubernetes_pr_121240"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a0f44ff49904c630a236a41ae82dec0f4b59be25538001c026bb3cf6d3eff7eb", "query": "N/A 07/18 02:38 PDT No response /sig release\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nSlack thread:\n/sig cli", "positive_passages": [{"docid": "doc-en-kubernetes-b764b8bdd87c0fd0cadc998bfb7011da12ae406dc8663fc57390324a38a93f84", "text": "# See the License for the specific language governing permissions and # limitations under the License. <del> ARG BASEIMAGE </del> ARG RUNNERIMAGE <del> FROM ${BASEIMAGE} as debbase </del> FROM ${RUNNERIMAGE} <del> # This is a dependency for `kubectl diff` tests COPY --from=debbase /usr/bin/diff /usr/local/bin/ COPY --from=debbase /lib/x86_64-linux-gnu/libc.so.6 /lib/x86_64-linux-gnu COPY --from=debbase /lib/x86_64-linux-gnu/libpthread.so.0 /lib/x86_64-linux-gnu COPY --from=debbase /lib64/ld-linux-x86-64.so.2 /lib64 </del> COPY cluster /kubernetes/cluster COPY ginkgo /usr/local/bin/ COPY e2e.test /usr/local/bin/", "commid": "kubernetes_pr_119422"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a0f44ff49904c630a236a41ae82dec0f4b59be25538001c026bb3cf6d3eff7eb", "query": "N/A 07/18 02:38 PDT No response /sig release\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nSlack thread:\n/sig cli", "positive_passages": [{"docid": "doc-en-kubernetes-30bf2e3dfe34ad9826895b5c1732969b33de9f131a5b655ba62a86bac446a576", "text": "# This is defined in root Makefile, but some build contexts do not refer to them KUBE_BASE_IMAGE_REGISTRY?=registry.k8s.io BASE_IMAGE_VERSION?=bookworm-v1.0.0 <del> BASEIMAGE?=${KUBE_BASE_IMAGE_REGISTRY}/build-image/debian-base-${ARCH}:${BASE_IMAGE_VERSION} # Keep debian releases (e.g. debian 11 == bullseye) consistent # between BASE_IMAGE_VERSION and DISTROLESS_IMAGE images DISTROLESS_IMAGE?=base-debian11 RUNNERIMAGE?=gcr.io/distroless/${DISTROLESS_IMAGE}:latest </del> <ins> RUNNERIMAGE?=${KUBE_BASE_IMAGE_REGISTRY}/build-image/debian-base-${ARCH}:${BASE_IMAGE_VERSION} </ins> TEMP_DIR:=$(shell mktemp -d -t conformance-XXXXXX)", "commid": "kubernetes_pr_119422"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a0f44ff49904c630a236a41ae82dec0f4b59be25538001c026bb3cf6d3eff7eb", "query": "N/A 07/18 02:38 PDT No response /sig release\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nSlack thread:\n/sig cli", "positive_passages": [{"docid": "doc-en-kubernetes-88a5ea8c1f60f5376bf035069de4c9cc362ff1f96e1cb84e7e6a32b22fbffb59", "text": "--load  --pull  -t ${REGISTRY}/conformance-${ARCH}:${VERSION}  <del> --build-arg BASEIMAGE=$(BASEIMAGE)  </del> --build-arg RUNNERIMAGE=$(RUNNERIMAGE)  ${TEMP_DIR} rm -rf \"${TEMP_DIR}\"", "commid": "kubernetes_pr_119422"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ac47953c966d73cdb4f8db4df90c7a83ec7544295f353614ecb5b18cb1183e4", "query": "/sig scheduling /kind regression caused a performance degradation in the 5k nodes scalability tests ! The PR changed how to split the load among parallel threads. Previously, we would parallelize over the number of nodes. The PR does it over the number of plugins, which is much smaller. Performance to improve or remain the same https://perf- No response 28 N/A <details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign The quickest fix is to revert, but I'm open to other suggestions.\n/priority critical-urgent\nCan we just use another Parallelizer to handle the score process for each plugin? I ran the UT locally and it seems fine, but I'm not familar with\nDepending on how many cores you have available, you might just overload the routines. I think it's better to revert the parallizer over plugins while keeping the change from map to slice. Although I don't expect a major impact for the latter. You might want to run a profiler for the benchmark with a higher number of nodes.\nI'll create a revert version first :)\nLet's revert this first since we reached the code freeze. We can do the refactor later.\nSorry for causing this trouble and thanks everyone for a prompt action", "positive_passages": [{"docid": "doc-en-kubernetes-5b3e6d0001b3ec58a1e73cfb730932bccd76477c0b9dd11f0913464cd9780006", "text": "allNodePluginScores := make([]framework.NodePluginScores, len(nodes)) numPlugins := len(f.scorePlugins) - state.SkipScorePlugins.Len() plugins := make([]framework.ScorePlugin, 0, numPlugins) <del> pluginToNodeScores := make([]framework.NodeScoreList, numPlugins) </del> <ins> pluginToNodeScores := make(map[string]framework.NodeScoreList, numPlugins) </ins> for _, pl := range f.scorePlugins { if state.SkipScorePlugins.Has(pl.Name()) { continue } plugins = append(plugins, pl) <ins> pluginToNodeScores[pl.Name()] = make(framework.NodeScoreList, len(nodes)) </ins> } ctx, cancel := context.WithCancel(ctx) defer cancel() errCh := parallelize.NewErrorChannel() <del> logger := klog.FromContext(ctx) logger = klog.LoggerWithName(logger, \"Score\") // TODO(knelasevero): Remove duplicated keys from log entry calls // When contextualized logging hits GA // https://github.com/kubernetes/kubernetes/issues/111672 logger = klog.LoggerWithValues(logger, \"pod\", klog.KObj(pod)) // Run Score method for each node in parallel. f.Parallelizer().Until(ctx, len(plugins), func(i int) { pl := plugins[i] logger := klog.LoggerWithName(logger, pl.Name()) nodeScores := make(framework.NodeScoreList, len(nodes)) for index, node := range nodes { nodeName := node.Name </del> <ins> if len(plugins) > 0 { logger := klog.FromContext(ctx) logger = klog.LoggerWithName(logger, \"Score\") // TODO(knelasevero): Remove duplicated keys from log entry calls // When contextualized logging hits GA // https://github.com/kubernetes/kubernetes/issues/111672 logger = klog.LoggerWithValues(logger, \"pod\", klog.KObj(pod)) // Run Score method for each node in parallel. f.Parallelizer().Until(ctx, len(nodes), func(index int) { nodeName := nodes[index].Name </ins> logger := klog.LoggerWithValues(logger, \"node\", klog.ObjectRef{Name: nodeName}) <del> ctx := klog.NewContext(ctx, logger) s, status := f.runScorePlugin(ctx, pl, state, pod, nodeName) if !status.IsSuccess() { err := fmt.Errorf(\"plugin %q failed with: %w\", pl.Name(), status.AsError()) errCh.SendErrorWithCancel(err, cancel) return } nodeScores[index] = framework.NodeScore{ Name:  nodeName, Score: s, </del> <ins> for _, pl := range plugins { logger := klog.LoggerWithName(logger, pl.Name()) ctx := klog.NewContext(ctx, logger) s, status := f.runScorePlugin(ctx, pl, state, pod, nodeName) if !status.IsSuccess() { err := fmt.Errorf(\"plugin %q failed with: %w\", pl.Name(), status.AsError()) errCh.SendErrorWithCancel(err, cancel) return } pluginToNodeScores[pl.Name()][index] = framework.NodeScore{ Name:  nodeName, Score: s, } </ins> } <ins> }, metrics.Score) if err := errCh.ReceiveError(); err != nil { return nil, framework.AsStatus(fmt.Errorf(\"running Score plugins: %w\", err)) </ins> } <ins> } // Run NormalizeScore method for each ScorePlugin in parallel. f.Parallelizer().Until(ctx, len(plugins), func(index int) { pl := plugins[index] </ins> if pl.ScoreExtensions() == nil { <del> pluginToNodeScores[i] = nodeScores </del> return } <del> status := f.runScoreExtension(ctx, pl, state, pod, nodeScores) </del> <ins> nodeScoreList := pluginToNodeScores[pl.Name()] status := f.runScoreExtension(ctx, pl, state, pod, nodeScoreList) </ins> if !status.IsSuccess() { err := fmt.Errorf(\"plugin %q failed with: %w\", pl.Name(), status.AsError()) errCh.SendErrorWithCancel(err, cancel) return } <del> pluginToNodeScores[i] = nodeScores </del> }, metrics.Score) if err := errCh.ReceiveError(); err != nil { return nil, framework.AsStatus(fmt.Errorf(\"running Normalize on Score plugins: %w\", err))", "commid": "kubernetes_pr_119444"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4ac47953c966d73cdb4f8db4df90c7a83ec7544295f353614ecb5b18cb1183e4", "query": "/sig scheduling /kind regression caused a performance degradation in the 5k nodes scalability tests ! The PR changed how to split the load among parallel threads. Previously, we would parallelize over the number of nodes. The PR does it over the number of plugins, which is much smaller. Performance to improve or remain the same https://perf- No response 28 N/A <details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign The quickest fix is to revert, but I'm open to other suggestions.\n/priority critical-urgent\nCan we just use another Parallelizer to handle the score process for each plugin? I ran the UT locally and it seems fine, but I'm not familar with\nDepending on how many cores you have available, you might just overload the routines. I think it's better to revert the parallizer over plugins while keeping the change from map to slice. Although I don't expect a major impact for the latter. You might want to run a profiler for the benchmark with a higher number of nodes.\nI'll create a revert version first :)\nLet's revert this first since we reached the code freeze. We can do the refactor later.\nSorry for causing this trouble and thanks everyone for a prompt action", "positive_passages": [{"docid": "doc-en-kubernetes-36543ad31ece4c84bf9328a28b403ee8d044d433337610518ca702ca3f9cc381", "text": "for i, pl := range plugins { weight := f.scorePluginWeight[pl.Name()] <del> nodeScoreList := pluginToNodeScores[i] </del> <ins> nodeScoreList := pluginToNodeScores[pl.Name()] </ins> score := nodeScoreList[index].Score if score > framework.MaxNodeScore || score < framework.MinNodeScore {", "commid": "kubernetes_pr_119444"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-606c1d95a05ee07ac0fb0270728c195eba6457caa0c36194149dc09bc972c356", "query": "This flakiness is reproducible on x86 and ppc64le architectures. https://prow.ppc64le- in /sig\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig testing\n/sig node /assign", "positive_passages": [{"docid": "doc-en-kubernetes-cfc1602c663fefa00781dd2024b69becc12f6c6f39b0ea298e02bb27e7b6e6de", "text": "driverName: driverName, } if shouldTimeout { <del> timeout := plugin.PluginClientTimeout + time.Millisecond </del> <ins> timeout := plugin.PluginClientTimeout + 10*time.Millisecond </ins> fakeDRADriverGRPCServer.timeout = &timeout }", "commid": "kubernetes_pr_119709"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-3da1785f6bd753c45736bbd293a0a746d294fd81adc36664d7eaa0f7a74eafb0", "query": "/sig scheduling Include the Pod UID in the event message for preemption by kube-scheduler Minimizes the need for an end user to consult the ops team to learn about what caused their pods to be preempted, without compromising PII. From\n/triage accepted\nCan I pick this up?\nYes, just type . Note that we are in code freeze, so this won't be merged until about a month from now.\n/assign\nPII? I know that as personally identifying information (ie, data about humans).\nBTW, ideally we'd also document the change.\nIn a multi-tenant environment, pod names could be sensitive information.", "positive_passages": [{"docid": "doc-en-kubernetes-40a0dfcca293e47661384ae974b9655d34c33e75ae651726e1564fd0dbce2b96", "text": "klog.V(2).InfoS(\"Preemptor Pod preempted victim Pod\", \"preemptor\", klog.KObj(pod), \"victim\", klog.KObj(victim), \"node\", c.Name()) } <del> fh.EventRecorder().Eventf(victim, pod, v1.EventTypeNormal, \"Preempted\", \"Preempting\", \"Preempted by a pod on node %v\", c.Name()) </del> <ins> fh.EventRecorder().Eventf(victim, pod, v1.EventTypeNormal, \"Preempted\", \"Preempting\", \"Preempted by pod %v on node %v\", pod.UID, c.Name()) </ins> } fh.Parallelizer().Until(ctx, len(c.Victims().Pods), preemptPod, ev.PluginName)", "commid": "kubernetes_pr_119971"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-06fbdef5e504dc3aae9c51820398a7847ef7322d8eaf0fbadc20091d1460d8a8", "query": "Calculate sidecar containers resource in pod autoscaler. From 1.28 user could run Sidecar containers in , those sidecar containers remain running during the entire life of the Pod, it should be calculated in . If missing the sidecar resources, we will get a wrong pod resource utilization. We should also correct the related Cadvisor metrics.\n/assign /sig autoscaling\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-d30062f0cdecee594c8ed201ab4d5e25ac193cd8d4ebe15173c042fb16728139", "text": "requests := make(map[string]int64, len(pods)) for _, pod := range pods { podSum := int64(0) <del> for _, c := range pod.Spec.Containers { </del> <ins> // Calculate all regular containers and restartable init containers requests. containers := append([]v1.Container{}, pod.Spec.Containers...) for _, c := range pod.Spec.InitContainers { if c.RestartPolicy != nil && *c.RestartPolicy == v1.ContainerRestartPolicyAlways { containers = append(containers, c) } } for _, c := range containers { </ins> if container == \"\" || container == c.Name { if containerRequest, ok := c.Resources.Requests[resource]; ok { podSum += containerRequest.MilliValue()", "commid": "kubernetes_pr_120001"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-06fbdef5e504dc3aae9c51820398a7847ef7322d8eaf0fbadc20091d1460d8a8", "query": "Calculate sidecar containers resource in pod autoscaler. From 1.28 user could run Sidecar containers in , those sidecar containers remain running during the entire life of the Pod, it should be calculated in . If missing the sidecar resources, we will get a wrong pod resource utilization. We should also correct the related Cadvisor metrics.\n/assign /sig autoscaling\n/triage accepted /priority important-soon", "positive_passages": [{"docid": "doc-en-kubernetes-fef58ba7d6e732164995444f2a73bb622bb42a5be64898fdabcc2cf218be63a5", "text": "}) } } <ins> func TestCalculatePodRequests(t *testing.T) { containerRestartPolicyAlways := v1.ContainerRestartPolicyAlways testPod := \"test-pod\" tests := []struct { name             string pods             []*v1.Pod container        string resource         v1.ResourceName expectedRequests map[string]int64 expectedError    error }{ { name:             \"void\", pods:             []*v1.Pod{}, container:        \"\", resource:         v1.ResourceCPU, expectedRequests: map[string]int64{}, expectedError:    nil, }, { name: \"pod with regular containers\", pods: []*v1.Pod{{ ObjectMeta: metav1.ObjectMeta{ Name:      testPod, Namespace: testNamespace, }, Spec: v1.PodSpec{ Containers: []v1.Container{ {Name: \"container1\", Resources: v1.ResourceRequirements{Requests: v1.ResourceList{v1.ResourceCPU: *resource.NewMilliQuantity(100, resource.DecimalSI)}}}, {Name: \"container2\", Resources: v1.ResourceRequirements{Requests: v1.ResourceList{v1.ResourceCPU: *resource.NewMilliQuantity(50, resource.DecimalSI)}}}, }, }, }}, container:        \"\", resource:         v1.ResourceCPU, expectedRequests: map[string]int64{testPod: 150}, expectedError:    nil, }, { name: \"calculate requests with special container\", pods: []*v1.Pod{{ ObjectMeta: metav1.ObjectMeta{ Name:      testPod, Namespace: testNamespace, }, Spec: v1.PodSpec{ Containers: []v1.Container{ {Name: \"container1\", Resources: v1.ResourceRequirements{Requests: v1.ResourceList{v1.ResourceCPU: *resource.NewMilliQuantity(100, resource.DecimalSI)}}}, {Name: \"container2\", Resources: v1.ResourceRequirements{Requests: v1.ResourceList{v1.ResourceCPU: *resource.NewMilliQuantity(50, resource.DecimalSI)}}}, }, }, }}, container:        \"container1\", resource:         v1.ResourceCPU, expectedRequests: map[string]int64{testPod: 100}, expectedError:    nil, }, { name: \"container missing requests\", pods: []*v1.Pod{{ ObjectMeta: metav1.ObjectMeta{ Name:      testPod, Namespace: testNamespace, }, Spec: v1.PodSpec{ Containers: []v1.Container{ {Name: \"container1\"}, }, }, }}, container:        \"\", resource:         v1.ResourceCPU, expectedRequests: nil, expectedError:    fmt.Errorf(\"missing request for %s in container %s of Pod %s\", v1.ResourceCPU, \"container1\", testPod), }, { name: \"pod with restartable init containers\", pods: []*v1.Pod{{ ObjectMeta: metav1.ObjectMeta{ Name:      testPod, Namespace: testNamespace, }, Spec: v1.PodSpec{ Containers: []v1.Container{ {Name: \"container1\", Resources: v1.ResourceRequirements{Requests: v1.ResourceList{v1.ResourceCPU: *resource.NewMilliQuantity(100, resource.DecimalSI)}}}, }, InitContainers: []v1.Container{ {Name: \"init-container1\", Resources: v1.ResourceRequirements{Requests: v1.ResourceList{v1.ResourceCPU: *resource.NewMilliQuantity(20, resource.DecimalSI)}}}, {Name: \"restartable-container1\", RestartPolicy: &containerRestartPolicyAlways, Resources: v1.ResourceRequirements{Requests: v1.ResourceList{v1.ResourceCPU: *resource.NewMilliQuantity(50, resource.DecimalSI)}}}, }, }, }}, container:        \"\", resource:         v1.ResourceCPU, expectedRequests: map[string]int64{testPod: 150}, expectedError:    nil, }, } for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { requests, err := calculatePodRequests(tc.pods, tc.container, tc.resource) assert.Equal(t, tc.expectedRequests, requests, \"requests should be as expected\") assert.Equal(t, tc.expectedError, err, \"error should be as expected\") }) } } </ins>", "commid": "kubernetes_pr_120001"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-042b753178b6ae4cd5699af58dadfe9c574839d637069cd42426a55d84a81866", "query": "We have a pod fake function in , but this is not a base util anymore, we have a lot of arguments, we can replace this with here /sig scheduling /kind cleanup /help This is an easy one to get start. Cleaner code for maintenance.\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : ### What would you like to be ? /kind cleanup /help Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-kind feature\nI want to try this one, the problem we solve here is to replace the *v1.Pod with type PodWrapper {}? /assign\nReplace with in\nyou mean replace ` in I check the code and didn't found out that we have makeBasePod in\nI have tried it. But there will be error about cycle import, because package import package, where locate.\nyes, I've tried it as well. guess I need to wait for kerthcet's response <img width=\"805\" alt=\"image\" src=\"\"\nSorry, forgot to reply on this, I introduced another PR to help solve this import cycle, but waits for other maintainers' response. So generally, if that pr accepted, we can work on this one then. Thanks for the volunteer.\nthe import cycle is resolved, you can start your work now, thanks!\nthanks for the ping!", "positive_passages": [{"docid": "doc-en-kubernetes-7882b17b329ae48d33d71ca5e6dffa2d994f8e0727b8ae8b7a828b28ccdd7d71", "text": "import ( \"fmt\" \"reflect\" <del> \"strings\" </del> \"testing\" \"github.com/google/go-cmp/cmp\"", "commid": "kubernetes_pr_120711"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-042b753178b6ae4cd5699af58dadfe9c574839d637069cd42426a55d84a81866", "query": "We have a pod fake function in , but this is not a base util anymore, we have a lot of arguments, we can replace this with here /sig scheduling /kind cleanup /help This is an easy one to get start. Cleaner code for maintenance.\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : ### What would you like to be ? /kind cleanup /help Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-kind feature\nI want to try this one, the problem we solve here is to replace the *v1.Pod with type PodWrapper {}? /assign\nReplace with in\nyou mean replace ` in I check the code and didn't found out that we have makeBasePod in\nI have tried it. But there will be error about cycle import, because package import package, where locate.\nyes, I've tried it as well. guess I need to wait for kerthcet's response <img width=\"805\" alt=\"image\" src=\"\"\nSorry, forgot to reply on this, I introduced another PR to help solve this import cycle, but waits for other maintainers' response. So generally, if that pr accepted, we can work on this one then. Thanks for the volunteer.\nthe import cycle is resolved, you can start your work now, thanks!\nthanks for the ping!", "positive_passages": [{"docid": "doc-en-kubernetes-779bb930e888a0c623b848607b8c6c74369af92523305542e03a4c7f5317d7f2", "text": "utilfeature \"k8s.io/apiserver/pkg/util/feature\" featuregatetesting \"k8s.io/component-base/featuregate/testing\" \"k8s.io/kubernetes/pkg/features\" <ins> st \"k8s.io/kubernetes/pkg/scheduler/testing\" </ins> ) func TestNewResource(t *testing.T) {", "commid": "kubernetes_pr_120711"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-042b753178b6ae4cd5699af58dadfe9c574839d637069cd42426a55d84a81866", "query": "We have a pod fake function in , but this is not a base util anymore, we have a lot of arguments, we can replace this with here /sig scheduling /kind cleanup /help This is an easy one to get start. Cleaner code for maintenance.\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : ### What would you like to be ? /kind cleanup /help Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-kind feature\nI want to try this one, the problem we solve here is to replace the *v1.Pod with type PodWrapper {}? /assign\nReplace with in\nyou mean replace ` in I check the code and didn't found out that we have makeBasePod in\nI have tried it. But there will be error about cycle import, because package import package, where locate.\nyes, I've tried it as well. guess I need to wait for kerthcet's response <img width=\"805\" alt=\"image\" src=\"\"\nSorry, forgot to reply on this, I introduced another PR to help solve this import cycle, but waits for other maintainers' response. So generally, if that pr accepted, we can work on this one then. Thanks for the volunteer.\nthe import cycle is resolved, you can start your work now, thanks!\nthanks for the ping!", "positive_passages": [{"docid": "doc-en-kubernetes-fc59c25dd9d187b5cfd8188a26b7f2ea4ad302dfc9fefeb5806bbdfac0cbb15c", "text": "} } <del> type testingMode interface { Fatalf(format string, args ...interface{}) } func makeBasePod(t testingMode, nodeName, objName, cpu, mem, extended string, ports []v1.ContainerPort, volumes []v1.Volume) *v1.Pod { req := v1.ResourceList{} if cpu != \"\" { req = v1.ResourceList{ v1.ResourceCPU:    resource.MustParse(cpu), v1.ResourceMemory: resource.MustParse(mem), } if extended != \"\" { parts := strings.Split(extended, \":\") if len(parts) != 2 { t.Fatalf(\"Invalid extended resource string: \"%s\"\", extended) } req[v1.ResourceName(parts[0])] = resource.MustParse(parts[1]) } } return &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ UID:       types.UID(objName), Namespace: \"node_info_cache_test\", Name:      objName, }, Spec: v1.PodSpec{ Containers: []v1.Container{{ Resources: v1.ResourceRequirements{ Requests: req, }, Ports: ports, }}, NodeName: nodeName, Volumes:  volumes, }, } } </del> func TestNewNodeInfo(t *testing.T) { nodeName := \"test-node\" pods := []*v1.Pod{ <del> makeBasePod(t, nodeName, \"test-1\", \"100m\", \"500\", \"\", []v1.ContainerPort{{HostIP: \"127.0.0.1\", HostPort: 80, Protocol: \"TCP\"}}, nil), makeBasePod(t, nodeName, \"test-2\", \"200m\", \"1Ki\", \"\", []v1.ContainerPort{{HostIP: \"127.0.0.1\", HostPort: 8080, Protocol: \"TCP\"}}, nil), </del> <ins> st.MakePod().UID(\"test-1\").Namespace(\"node_info_cache_test\").Name(\"test-1\").Node(nodeName). Containers([]v1.Container{st.MakeContainer().ResourceRequests(map[v1.ResourceName]string{ v1.ResourceCPU:    \"100m\", v1.ResourceMemory: \"500\", }).ContainerPort([]v1.ContainerPort{{ HostIP:   \"127.0.0.1\", HostPort: 80, Protocol: \"TCP\", }}).Obj()}). Obj(), st.MakePod().UID(\"test-2\").Namespace(\"node_info_cache_test\").Name(\"test-2\").Node(nodeName). Containers([]v1.Container{st.MakeContainer().ResourceRequests(map[v1.ResourceName]string{ v1.ResourceCPU:    \"200m\", v1.ResourceMemory: \"1Ki\", }).ContainerPort([]v1.ContainerPort{{ HostIP:   \"127.0.0.1\", HostPort: 8080, Protocol: \"TCP\", }}).Obj()}). Obj(), </ins> } expected := &NodeInfo{", "commid": "kubernetes_pr_120711"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-042b753178b6ae4cd5699af58dadfe9c574839d637069cd42426a55d84a81866", "query": "We have a pod fake function in , but this is not a base util anymore, we have a lot of arguments, we can replace this with here /sig scheduling /kind cleanup /help This is an easy one to get start. Cleaner code for maintenance.\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : ### What would you like to be ? /kind cleanup /help Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-kind feature\nI want to try this one, the problem we solve here is to replace the *v1.Pod with type PodWrapper {}? /assign\nReplace with in\nyou mean replace ` in I check the code and didn't found out that we have makeBasePod in\nI have tried it. But there will be error about cycle import, because package import package, where locate.\nyes, I've tried it as well. guess I need to wait for kerthcet's response <img width=\"805\" alt=\"image\" src=\"\"\nSorry, forgot to reply on this, I introduced another PR to help solve this import cycle, but waits for other maintainers' response. So generally, if that pr accepted, we can work on this one then. Thanks for the volunteer.\nthe import cycle is resolved, you can start your work now, thanks!\nthanks for the ping!", "positive_passages": [{"docid": "doc-en-kubernetes-6081a8593e6d75237c81154909861d6ed6fccb474e6137cf09aa561ef4d54f0f", "text": "func TestNodeInfoRemovePod(t *testing.T) { nodeName := \"test-node\" pods := []*v1.Pod{ <del> makeBasePod(t, nodeName, \"test-1\", \"100m\", \"500\", \"\", []v1.ContainerPort{{HostIP: \"127.0.0.1\", HostPort: 80, Protocol: \"TCP\"}}, []v1.Volume{{VolumeSource: v1.VolumeSource{PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{ClaimName: \"pvc-1\"}}}}), makeBasePod(t, nodeName, \"test-2\", \"200m\", \"1Ki\", \"\", []v1.ContainerPort{{HostIP: \"127.0.0.1\", HostPort: 8080, Protocol: \"TCP\"}}, nil), </del> <ins> st.MakePod().UID(\"test-1\").Namespace(\"node_info_cache_test\").Name(\"test-1\").Node(nodeName). Containers([]v1.Container{st.MakeContainer().ResourceRequests(map[v1.ResourceName]string{ v1.ResourceCPU:    \"100m\", v1.ResourceMemory: \"500\", }).ContainerPort([]v1.ContainerPort{{ HostIP:   \"127.0.0.1\", HostPort: 80, Protocol: \"TCP\", }}).Obj()}). Volumes([]v1.Volume{{VolumeSource: v1.VolumeSource{PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{ClaimName: \"pvc-1\"}}}}). Obj(), st.MakePod().UID(\"test-2\").Namespace(\"node_info_cache_test\").Name(\"test-2\").Node(nodeName). Containers([]v1.Container{st.MakeContainer().ResourceRequests(map[v1.ResourceName]string{ v1.ResourceCPU:    \"200m\", v1.ResourceMemory: \"1Ki\", }).ContainerPort([]v1.ContainerPort{{ HostIP:   \"127.0.0.1\", HostPort: 8080, Protocol: \"TCP\", }}).Obj()}). Obj(), </ins> } // add pod Overhead", "commid": "kubernetes_pr_120711"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-042b753178b6ae4cd5699af58dadfe9c574839d637069cd42426a55d84a81866", "query": "We have a pod fake function in , but this is not a base util anymore, we have a lot of arguments, we can replace this with here /sig scheduling /kind cleanup /help This is an easy one to get start. Cleaner code for maintenance.\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : ### What would you like to be ? /kind cleanup /help Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-kind feature\nI want to try this one, the problem we solve here is to replace the *v1.Pod with type PodWrapper {}? /assign\nReplace with in\nyou mean replace ` in I check the code and didn't found out that we have makeBasePod in\nI have tried it. But there will be error about cycle import, because package import package, where locate.\nyes, I've tried it as well. guess I need to wait for kerthcet's response <img width=\"805\" alt=\"image\" src=\"\"\nSorry, forgot to reply on this, I introduced another PR to help solve this import cycle, but waits for other maintainers' response. So generally, if that pr accepted, we can work on this one then. Thanks for the volunteer.\nthe import cycle is resolved, you can start your work now, thanks!\nthanks for the ping!", "positive_passages": [{"docid": "doc-en-kubernetes-7bf54f0094bf4c897747699647bab479c91fe1dee3ee395824a60b8ba50f982e", "text": "expectedNodeInfo *NodeInfo }{ { <del> pod:         makeBasePod(t, nodeName, \"non-exist\", \"0\", \"0\", \"\", []v1.ContainerPort{{}}, []v1.Volume{}), </del> <ins> pod:         st.MakePod().UID(\"non-exist\").Namespace(\"node_info_cache_test\").Node(nodeName).Obj(), </ins> errExpected: true, expectedNodeInfo: &NodeInfo{ node: &v1.Node{", "commid": "kubernetes_pr_120711"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-042b753178b6ae4cd5699af58dadfe9c574839d637069cd42426a55d84a81866", "query": "We have a pod fake function in , but this is not a base util anymore, we have a lot of arguments, we can replace this with here /sig scheduling /kind cleanup /help This is an easy one to get start. Cleaner code for maintenance.\nThis request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : ### What would you like to be ? /kind cleanup /help Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-kind feature\nI want to try this one, the problem we solve here is to replace the *v1.Pod with type PodWrapper {}? /assign\nReplace with in\nyou mean replace ` in I check the code and didn't found out that we have makeBasePod in\nI have tried it. But there will be error about cycle import, because package import package, where locate.\nyes, I've tried it as well. guess I need to wait for kerthcet's response <img width=\"805\" alt=\"image\" src=\"\"\nSorry, forgot to reply on this, I introduced another PR to help solve this import cycle, but waits for other maintainers' response. So generally, if that pr accepted, we can work on this one then. Thanks for the volunteer.\nthe import cycle is resolved, you can start your work now, thanks!\nthanks for the ping!", "positive_passages": [{"docid": "doc-en-kubernetes-0fb24445872f115407f2e3ad9a425a36d1c2eda8429fc1dc2b4c37164e0e22ed", "text": "return p } <ins> // Volumes set the volumes and inject into the inner pod. func (p *PodWrapper) Volumes(volumes []v1.Volume) *PodWrapper { p.Spec.Volumes = volumes return p } </ins> // SchedulingGates sets `gates` as additional SchedulerGates of the inner pod. func (p *PodWrapper) SchedulingGates(gates []string) *PodWrapper { for _, gate := range gates {", "commid": "kubernetes_pr_120711"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0754ac7bcf463db71ff62e3e2bf376844b1f4020d08fde9752e5a4b08b9e97da", "query": "remove and was introduced in to fix This is to overcome the situation that volume is to DSW at first and then deleted before it is to ASW, which causes mounted volume neither in DSW nor ASW and won't execute unmount/detach: The reason the volume cannot be to ASW in time is , which is . However, there is another PR also solved the issue. What it did is to check whether ASW already has the volume before deleting it from DSW, this makes sure that volume can be detached/unmounted after it is deleted from DSW. I suggest that we can keep the second solution and remove related code to make the reconstruction process and reconcile loop cleaner?\n/sig storage\ncc\nShould I proceed with this issue? Your guidance is appreciated.\nI think we'd better wait for the feedback from\ncc\nSorry for a late reply. This is how behind we are with reviews :-(. Reading Now that is on by default, it reconstructs volumes first and always puts them to ASW, it should never happen that a reconstructed volume is in DSW and not in ASW, right? So we can remove easily. I would not be so sure without , because the code is 5 years old and who knows all the implications. You could be right though, it may not be necessary there too.\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-9fbf74991035fe7f1b8cdf19513aee69eea1d20184ac8aa219a36029efbd74f1", "text": "// This will start reconciliation of node.status.volumesInUse. rc.updateLastSyncTime() } <del> if len(rc.volumesNeedReportedInUse) != 0 && rc.populatorHasAddedPods() { // Once DSW is populated, mark all reconstructed as reported in node.status, // so they can proceed with MountDevice / SetUp. rc.desiredStateOfWorld.MarkVolumesReportedInUse(rc.volumesNeedReportedInUse) rc.volumesNeedReportedInUse = nil } </del> }", "commid": "kubernetes_pr_125014"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0754ac7bcf463db71ff62e3e2bf376844b1f4020d08fde9752e5a4b08b9e97da", "query": "remove and was introduced in to fix This is to overcome the situation that volume is to DSW at first and then deleted before it is to ASW, which causes mounted volume neither in DSW nor ASW and won't execute unmount/detach: The reason the volume cannot be to ASW in time is , which is . However, there is another PR also solved the issue. What it did is to check whether ASW already has the volume before deleting it from DSW, this makes sure that volume can be detached/unmounted after it is deleted from DSW. I suggest that we can keep the second solution and remove related code to make the reconstruction process and reconcile loop cleaner?\n/sig storage\ncc\nShould I proceed with this issue? Your guidance is appreciated.\nI think we'd better wait for the feedback from\ncc\nSorry for a late reply. This is how behind we are with reviews :-(. Reading Now that is on by default, it reconstructs volumes first and always puts them to ASW, it should never happen that a reconstructed volume is in DSW and not in ASW, right? So we can remove easily. I would not be so sure without , because the code is 5 years old and who knows all the implications. You could be right though, it may not be necessary there too.\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-b3645ea7f18d526a7c7dfe0dcd1ff944d823b0d61653c18c5624046b4dba7a6d", "text": "timeOfLastSync:                  time.Time{}, volumesFailedReconstruction:     make([]podVolume, 0), volumesNeedUpdateFromNodeStatus: make([]v1.UniqueVolumeName, 0), <del> volumesNeedReportedInUse:        make([]v1.UniqueVolumeName, 0), </del> } }", "commid": "kubernetes_pr_125014"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0754ac7bcf463db71ff62e3e2bf376844b1f4020d08fde9752e5a4b08b9e97da", "query": "remove and was introduced in to fix This is to overcome the situation that volume is to DSW at first and then deleted before it is to ASW, which causes mounted volume neither in DSW nor ASW and won't execute unmount/detach: The reason the volume cannot be to ASW in time is , which is . However, there is another PR also solved the issue. What it did is to check whether ASW already has the volume before deleting it from DSW, this makes sure that volume can be detached/unmounted after it is deleted from DSW. I suggest that we can keep the second solution and remove related code to make the reconstruction process and reconcile loop cleaner?\n/sig storage\ncc\nShould I proceed with this issue? Your guidance is appreciated.\nI think we'd better wait for the feedback from\ncc\nSorry for a late reply. This is how behind we are with reviews :-(. Reading Now that is on by default, it reconstructs volumes first and always puts them to ASW, it should never happen that a reconstructed volume is in DSW and not in ASW, right? So we can remove easily. I would not be so sure without , because the code is 5 years old and who knows all the implications. You could be right though, it may not be necessary there too.\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-222e217eea6a87615da3cc6e1988e808d21cc83f113a8eee7412e0c3fc2042e8", "text": "timeOfLastSync                  time.Time volumesFailedReconstruction     []podVolume volumesNeedUpdateFromNodeStatus []v1.UniqueVolumeName <del> volumesNeedReportedInUse        []v1.UniqueVolumeName </del> } func (rc *reconciler) unmountVolumes() {", "commid": "kubernetes_pr_125014"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0754ac7bcf463db71ff62e3e2bf376844b1f4020d08fde9752e5a4b08b9e97da", "query": "remove and was introduced in to fix This is to overcome the situation that volume is to DSW at first and then deleted before it is to ASW, which causes mounted volume neither in DSW nor ASW and won't execute unmount/detach: The reason the volume cannot be to ASW in time is , which is . However, there is another PR also solved the issue. What it did is to check whether ASW already has the volume before deleting it from DSW, this makes sure that volume can be detached/unmounted after it is deleted from DSW. I suggest that we can keep the second solution and remove related code to make the reconstruction process and reconcile loop cleaner?\n/sig storage\ncc\nShould I proceed with this issue? Your guidance is appreciated.\nI think we'd better wait for the feedback from\ncc\nSorry for a late reply. This is how behind we are with reviews :-(. Reading Now that is on by default, it reconstructs volumes first and always puts them to ASW, it should never happen that a reconstructed volume is in DSW and not in ASW, right? So we can remove easily. I would not be so sure without , because the code is 5 years old and who knows all the implications. You could be right though, it may not be necessary there too.\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-a1738fd15de37baa2d26bc537bdde0070168e4700ef1a2b62c9b2df1c959d63c", "text": "// Add the volumes to ASW rc.updateStates(reconstructedVolumes) <del> // The reconstructed volumes are mounted, hence a previous kubelet must have already put it into node.status.volumesInUse. // Remember to update DSW with this information. rc.volumesNeedReportedInUse = reconstructedVolumeNames </del> // Remember to update devicePath from node.status.volumesAttached rc.volumesNeedUpdateFromNodeStatus = reconstructedVolumeNames }", "commid": "kubernetes_pr_125014"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0754ac7bcf463db71ff62e3e2bf376844b1f4020d08fde9752e5a4b08b9e97da", "query": "remove and was introduced in to fix This is to overcome the situation that volume is to DSW at first and then deleted before it is to ASW, which causes mounted volume neither in DSW nor ASW and won't execute unmount/detach: The reason the volume cannot be to ASW in time is , which is . However, there is another PR also solved the issue. What it did is to check whether ASW already has the volume before deleting it from DSW, this makes sure that volume can be detached/unmounted after it is deleted from DSW. I suggest that we can keep the second solution and remove related code to make the reconstruction process and reconcile loop cleaner?\n/sig storage\ncc\nShould I proceed with this issue? Your guidance is appreciated.\nI think we'd better wait for the feedback from\ncc\nSorry for a late reply. This is how behind we are with reviews :-(. Reading Now that is on by default, it reconstructs volumes first and always puts them to ASW, it should never happen that a reconstructed volume is in DSW and not in ASW, right? So we can remove easily. I would not be so sure without , because the code is 5 years old and who knows all the implications. You could be right though, it may not be necessary there too.\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-700772fb13aad9b39389317d58214a492df0751379fd74a42153befcd19d0884", "text": "tests := []struct { name                                string volumePaths                         []string <del> expectedVolumesNeedReportedInUse    []string </del> expectedVolumesNeedDevicePath       []string expectedVolumesFailedReconstruction []string verifyFunc                          func(rcInstance *reconciler, fakePlugin *volumetesting.FakeVolumePlugin) error", "commid": "kubernetes_pr_125014"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0754ac7bcf463db71ff62e3e2bf376844b1f4020d08fde9752e5a4b08b9e97da", "query": "remove and was introduced in to fix This is to overcome the situation that volume is to DSW at first and then deleted before it is to ASW, which causes mounted volume neither in DSW nor ASW and won't execute unmount/detach: The reason the volume cannot be to ASW in time is , which is . However, there is another PR also solved the issue. What it did is to check whether ASW already has the volume before deleting it from DSW, this makes sure that volume can be detached/unmounted after it is deleted from DSW. I suggest that we can keep the second solution and remove related code to make the reconstruction process and reconcile loop cleaner?\n/sig storage\ncc\nShould I proceed with this issue? Your guidance is appreciated.\nI think we'd better wait for the feedback from\ncc\nSorry for a late reply. This is how behind we are with reviews :-(. Reading Now that is on by default, it reconstructs volumes first and always puts them to ASW, it should never happen that a reconstructed volume is in DSW and not in ASW, right? So we can remove easily. I would not be so sure without , because the code is 5 years old and who knows all the implications. You could be right though, it may not be necessary there too.\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-5fc00d8f83cef0518bc6ddb4628f308c23b58935f6af4249242fed3d0b606d61", "text": "filepath.Join(\"pod1\", \"volumes\", \"fake-plugin\", \"pvc-abcdef\"), filepath.Join(\"pod2\", \"volumes\", \"fake-plugin\", \"pvc-abcdef\"), }, <del> expectedVolumesNeedReportedInUse:    []string{\"fake-plugin/pvc-abcdef\", \"fake-plugin/pvc-abcdef\"}, </del> expectedVolumesNeedDevicePath:       []string{\"fake-plugin/pvc-abcdef\", \"fake-plugin/pvc-abcdef\"}, expectedVolumesFailedReconstruction: []string{}, verifyFunc: func(rcInstance *reconciler, fakePlugin *volumetesting.FakeVolumePlugin) error {", "commid": "kubernetes_pr_125014"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0754ac7bcf463db71ff62e3e2bf376844b1f4020d08fde9752e5a4b08b9e97da", "query": "remove and was introduced in to fix This is to overcome the situation that volume is to DSW at first and then deleted before it is to ASW, which causes mounted volume neither in DSW nor ASW and won't execute unmount/detach: The reason the volume cannot be to ASW in time is , which is . However, there is another PR also solved the issue. What it did is to check whether ASW already has the volume before deleting it from DSW, this makes sure that volume can be detached/unmounted after it is deleted from DSW. I suggest that we can keep the second solution and remove related code to make the reconstruction process and reconcile loop cleaner?\n/sig storage\ncc\nShould I proceed with this issue? Your guidance is appreciated.\nI think we'd better wait for the feedback from\ncc\nSorry for a late reply. This is how behind we are with reviews :-(. Reading Now that is on by default, it reconstructs volumes first and always puts them to ASW, it should never happen that a reconstructed volume is in DSW and not in ASW, right? So we can remove easily. I would not be so sure without , because the code is 5 years old and who knows all the implications. You could be right though, it may not be necessary there too.\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-526eeeea77a0227ccede9dc62555a106a3071bd074d0df92937c01b4fd39f3c0", "text": "volumePaths: []string{ filepath.Join(\"pod1\", \"volumes\", \"missing-plugin\", \"pvc-abcdef\"), }, <del> expectedVolumesNeedReportedInUse:    []string{}, </del> expectedVolumesNeedDevicePath:       []string{}, expectedVolumesFailedReconstruction: []string{\"pvc-abcdef\"}, },", "commid": "kubernetes_pr_125014"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-0754ac7bcf463db71ff62e3e2bf376844b1f4020d08fde9752e5a4b08b9e97da", "query": "remove and was introduced in to fix This is to overcome the situation that volume is to DSW at first and then deleted before it is to ASW, which causes mounted volume neither in DSW nor ASW and won't execute unmount/detach: The reason the volume cannot be to ASW in time is , which is . However, there is another PR also solved the issue. What it did is to check whether ASW already has the volume before deleting it from DSW, this makes sure that volume can be detached/unmounted after it is deleted from DSW. I suggest that we can keep the second solution and remove related code to make the reconstruction process and reconcile loop cleaner?\n/sig storage\ncc\nShould I proceed with this issue? Your guidance is appreciated.\nI think we'd better wait for the feedback from\ncc\nSorry for a late reply. This is how behind we are with reviews :-(. Reading Now that is on by default, it reconstructs volumes first and always puts them to ASW, it should never happen that a reconstructed volume is in DSW and not in ASW, right? So we can remove easily. I would not be so sure without , because the code is 5 years old and who knows all the implications. You could be right though, it may not be necessary there too.\n/triage accepted\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-f2cb6035d4fde3da5465ba636c114c569f543c8c10ed4ec537c0d4053b3d59d1", "text": "t.Errorf(\"Expected expectedVolumesNeedDevicePath:n%vn got:n%v\", expectedVolumes, rcInstance.volumesNeedUpdateFromNodeStatus) } <del> expectedVolumes = make([]v1.UniqueVolumeName, len(tc.expectedVolumesNeedReportedInUse)) for i := range tc.expectedVolumesNeedReportedInUse { expectedVolumes[i] = v1.UniqueVolumeName(tc.expectedVolumesNeedReportedInUse[i]) } if !reflect.DeepEqual(expectedVolumes, rcInstance.volumesNeedReportedInUse) { t.Errorf(\"Expected volumesNeedReportedInUse:n%vn got:n%v\", expectedVolumes, rcInstance.volumesNeedReportedInUse) } </del> volumesFailedReconstruction := sets.NewString() for _, vol := range rcInstance.volumesFailedReconstruction { volumesFailedReconstruction.Insert(vol.volumeSpecName)", "commid": "kubernetes_pr_125014"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e5239da31475cc408e37fe1270e0f340149f1b179f79b6ece1d3aa35708ff9fc", "query": "We need to explore how DRA interacts with One likely outcome is that the DRA helper code watches for nodes with the special label and helps DRA drivers clean up. /sig node\n/assign\n/triage important-soon as this is a DRA Beta criteria and DRA is going to be graduated to Beta in 1.29\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /triage important-soon as this is a DRA Beta criteria and DRA is going to be graduated to Beta in 1.29 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nHere's a test that was written for volumes:\nThank you. I\u2019ve found it last week. Unfortunately kind image doesn\u2019t have ssh, so stopping kubelet is not possible the way this test does. I\u2019ve found another solution.\nI was able to simulate non-graceful node shutdown by running . It turned out that after adding tent, all node pods are deleted by the GC controller and the resource claim controller successfully deallocated the resource. So, it looks like a non-graceful shutdown is handled correctly and no code changes are required. However, the fact that can potentially be called without calling should be explained in the DRA KEP, so that DRA plugin authors will be aware of this. I'll add an explanation of handling non-graceful node shoutdown to the and add a correspondent e2e test case to the DRA e2e test suite.\nKEP update PR: E2E PR:", "positive_passages": [{"docid": "doc-en-kubernetes-57c3f01813b26e4bfe435421f506d6bb1d9e560addca1e92dbcf872e70b9cb03", "text": "resourcev1alpha2 \"k8s.io/api/resource/v1alpha2\" apierrors \"k8s.io/apimachinery/pkg/api/errors\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" <ins> \"k8s.io/apimachinery/pkg/labels\" </ins> \"k8s.io/client-go/kubernetes\" \"k8s.io/dynamic-resource-allocation/controller\" \"k8s.io/klog/v2\" \"k8s.io/kubernetes/test/e2e/dra/test-driver/app\" \"k8s.io/kubernetes/test/e2e/framework\" <ins> e2enode \"k8s.io/kubernetes/test/e2e/framework/node\" </ins> e2epod \"k8s.io/kubernetes/test/e2e/framework/pod\" admissionapi \"k8s.io/pod-security-admission/api\" utilpointer \"k8s.io/utils/pointer\"", "commid": "kubernetes_pr_120965"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e5239da31475cc408e37fe1270e0f340149f1b179f79b6ece1d3aa35708ff9fc", "query": "We need to explore how DRA interacts with One likely outcome is that the DRA helper code watches for nodes with the special label and helps DRA drivers clean up. /sig node\n/assign\n/triage important-soon as this is a DRA Beta criteria and DRA is going to be graduated to Beta in 1.29\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /triage important-soon as this is a DRA Beta criteria and DRA is going to be graduated to Beta in 1.29 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nHere's a test that was written for volumes:\nThank you. I\u2019ve found it last week. Unfortunately kind image doesn\u2019t have ssh, so stopping kubelet is not possible the way this test does. I\u2019ve found another solution.\nI was able to simulate non-graceful node shutdown by running . It turned out that after adding tent, all node pods are deleted by the GC controller and the resource claim controller successfully deallocated the resource. So, it looks like a non-graceful shutdown is handled correctly and no code changes are required. However, the fact that can potentially be called without calling should be explained in the DRA KEP, so that DRA plugin authors will be aware of this. I'll add an explanation of handling non-graceful node shoutdown to the and add a correspondent e2e test case to the DRA e2e test suite.\nKEP update PR: E2E PR:", "positive_passages": [{"docid": "doc-en-kubernetes-f6dac0d3936b40e088d69588be46ff2edd7ff9acc26ffba5d13b05925c67d187", "text": "framework.ExpectNoError(err, \"start pod\") } }) <ins> // This test covers aspects of non graceful node shutdown by DRA controller // More details about this can be found in the KEP: // https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2268-non-graceful-shutdown // NOTE: this test depends on kind. It will only work with kind cluster as it shuts down one of the // nodes by running `docker stop <node name>`, which is very kind-specific. ginkgo.It(\"[Serial] [Disruptive] [Slow] must deallocate on non graceful node shutdown\", func(ctx context.Context) { ginkgo.By(\"create test pod\") parameters := b.parameters() label := \"app.kubernetes.io/instance\" instance := f.UniqueName + \"-test-app\" pod := b.podExternal() pod.Labels[label] = instance claim := b.externalClaim(resourcev1alpha2.AllocationModeWaitForFirstConsumer) b.create(ctx, parameters, claim, pod) ginkgo.By(\"wait for test pod \" + pod.Name + \" to run\") labelSelector := labels.SelectorFromSet(labels.Set(pod.Labels)) pods, err := e2epod.WaitForPodsWithLabelRunningReady(ctx, f.ClientSet, pod.Namespace, labelSelector, 1, framework.PodStartTimeout) framework.ExpectNoError(err, \"start pod\") runningPod := &pods.Items[0] nodeName := runningPod.Spec.NodeName // Prevent builder tearDown to fail waiting for unprepared resources delete(b.driver.Nodes, nodeName) ginkgo.By(\"stop node \" + nodeName + \" non gracefully\") _, stderr, err := framework.RunCmd(\"docker\", \"stop\", nodeName) gomega.Expect(stderr).To(gomega.BeEmpty()) framework.ExpectNoError(err) ginkgo.DeferCleanup(framework.RunCmd, \"docker\", \"start\", nodeName) if ok := e2enode.WaitForNodeToBeNotReady(ctx, f.ClientSet, nodeName, f.Timeouts.NodeNotReady); !ok { framework.Failf(\"Node %s failed to enter NotReady state\", nodeName) } ginkgo.By(\"apply out-of-service taint on node \" + nodeName) taint := v1.Taint{ Key:    v1.TaintNodeOutOfService, Effect: v1.TaintEffectNoExecute, } e2enode.AddOrUpdateTaintOnNode(ctx, f.ClientSet, nodeName, taint) e2enode.ExpectNodeHasTaint(ctx, f.ClientSet, nodeName, &taint) ginkgo.DeferCleanup(e2enode.RemoveTaintOffNode, f.ClientSet, nodeName, taint) ginkgo.By(\"waiting for claim to get deallocated\") gomega.Eventually(ctx, framework.GetObject(b.f.ClientSet.ResourceV1alpha2().ResourceClaims(b.f.Namespace.Name).Get, claim.Name, metav1.GetOptions{})).WithTimeout(f.Timeouts.PodDelete).Should(gomega.HaveField(\"Status.Allocation\", gomega.BeNil())) }) </ins> }) ginkgo.Context(\"with node-local resources\", func() {", "commid": "kubernetes_pr_120965"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e5239da31475cc408e37fe1270e0f340149f1b179f79b6ece1d3aa35708ff9fc", "query": "We need to explore how DRA interacts with One likely outcome is that the DRA helper code watches for nodes with the special label and helps DRA drivers clean up. /sig node\n/assign\n/triage important-soon as this is a DRA Beta criteria and DRA is going to be graduated to Beta in 1.29\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /triage important-soon as this is a DRA Beta criteria and DRA is going to be graduated to Beta in 1.29 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nHere's a test that was written for volumes:\nThank you. I\u2019ve found it last week. Unfortunately kind image doesn\u2019t have ssh, so stopping kubelet is not possible the way this test does. I\u2019ve found another solution.\nI was able to simulate non-graceful node shutdown by running . It turned out that after adding tent, all node pods are deleted by the GC controller and the resource claim controller successfully deallocated the resource. So, it looks like a non-graceful shutdown is handled correctly and no code changes are required. However, the fact that can potentially be called without calling should be explained in the DRA KEP, so that DRA plugin authors will be aware of this. I'll add an explanation of handling non-graceful node shoutdown to the and add a correspondent e2e test case to the DRA e2e test suite.\nKEP update PR: E2E PR:", "positive_passages": [{"docid": "doc-en-kubernetes-59af271218eb753db235a0723b908ac3556f17671983ce289cd2fc3485564f03", "text": "SystemPodsStartup:         10 * time.Minute, NodeSchedulable:           30 * time.Minute, SystemDaemonsetStartup:    5 * time.Minute, <ins> NodeNotReady:              3 * time.Minute, </ins> } // TimeoutContext contains timeout settings for several actions.", "commid": "kubernetes_pr_120965"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e5239da31475cc408e37fe1270e0f340149f1b179f79b6ece1d3aa35708ff9fc", "query": "We need to explore how DRA interacts with One likely outcome is that the DRA helper code watches for nodes with the special label and helps DRA drivers clean up. /sig node\n/assign\n/triage important-soon as this is a DRA Beta criteria and DRA is going to be graduated to Beta in 1.29\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /triage important-soon as this is a DRA Beta criteria and DRA is going to be graduated to Beta in 1.29 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/triage accepted\nHere's a test that was written for volumes:\nThank you. I\u2019ve found it last week. Unfortunately kind image doesn\u2019t have ssh, so stopping kubelet is not possible the way this test does. I\u2019ve found another solution.\nI was able to simulate non-graceful node shutdown by running . It turned out that after adding tent, all node pods are deleted by the GC controller and the resource claim controller successfully deallocated the resource. So, it looks like a non-graceful shutdown is handled correctly and no code changes are required. However, the fact that can potentially be called without calling should be explained in the DRA KEP, so that DRA plugin authors will be aware of this. I'll add an explanation of handling non-graceful node shoutdown to the and add a correspondent e2e test case to the DRA e2e test suite.\nKEP update PR: E2E PR:", "positive_passages": [{"docid": "doc-en-kubernetes-5d0019655d9bc4c7d02ef4874909fceac8304d17b894fd8d155794805e7e6101", "text": "// SystemDaemonsetStartup is how long to wait for all system daemonsets to be ready. SystemDaemonsetStartup time.Duration <ins> // NodeNotReady is how long to wait for a node to be not ready. NodeNotReady time.Duration </ins> } // NewTimeoutContext returns a TimeoutContext with all values set either to", "commid": "kubernetes_pr_120965"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-a94389136d5400b7671ed2395a7109adb782a1b881c8b9bece92bf6fea526415", "text": "// implementing this brute force approach instead of fancy channel notification to avoid test specific code in prod. // wait for config to be observed <del> verifyIfKMSTransformersSwapped(t, wantPrefixForSecrets, test) </del> <ins> verifyIfKMSTransformersSwapped(t, wantPrefixForSecrets, \"\", test) </ins> // run storage migration // get secrets", "commid": "kubernetes_pr_121452"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-4cd0608f42d86e49d18135e2538da1b9c4c17eae8d0c59aec70d9576bb4518c8", "text": "} // remove old KMS provider <ins> // verifyIfKMSTransformersSwapped sometimes passes even before the changes in the encryption config file are observed. // this causes the metrics tests to fail, which validate two config changes. // this may happen when an existing KMS provider is already running (e.g., new-kms-provider-for-secrets in this case). // to ensure that the changes are observed, we added one more provider (kms-provider-to-encrypt-all) and are validating it in verifyIfKMSTransformersSwapped. </ins> encryptionConfigWithoutOldProvider := ` kind: EncryptionConfiguration apiVersion: apiserver.config.k8s.io/v1", "commid": "kubernetes_pr_121452"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-da98bf7b7e7114a55fc7e286046af3149c1654c26d8df15528e9fd483d06a2e8", "text": "name: new-kms-provider-for-configmaps cachesize: 1000 endpoint: unix:///@new-kms-provider.sock <ins> - resources: - '*.*' providers: - kms: name: kms-provider-to-encrypt-all cachesize: 1000 endpoint: unix:///@new-encrypt-all-kms-provider.sock - identity: {} </ins> ` <ins> // start new KMS Plugin _ = mock.NewBase64Plugin(t, \"@new-encrypt-all-kms-provider.sock\") </ins> // update encryption config and wait for hot reload if err := os.WriteFile(filepath.Join(test.configDir, encryptionConfigFileName), []byte(encryptionConfigWithoutOldProvider), 0644); err != nil { t.Fatalf(\"failed to update encryption config, err: %v\", err) } <ins> wantPrefixForEncryptAll := \"k8s:enc:kms:v1:kms-provider-to-encrypt-all:\" </ins> // wait for config to be observed <del> verifyIfKMSTransformersSwapped(t, wantPrefixForSecrets, test) </del> <ins> verifyIfKMSTransformersSwapped(t, wantPrefixForSecrets, wantPrefixForEncryptAll, test) </ins> // confirm that reading secrets still works _, err = test.restClient.CoreV1().Secrets(testNamespace).Get(", "commid": "kubernetes_pr_121452"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-93a5f15b7352da3ea5124f7cdb159fb1ac2f736a1d6ac52580b8c3b0f906787f", "text": "func verifyPrefixOfSecretResource(t *testing.T, wantPrefix string, test *transformTest) { // implementing this brute force approach instead of fancy channel notification to avoid test specific code in prod. // wait for config to be observed <del> verifyIfKMSTransformersSwapped(t, wantPrefix, test) </del> <ins> verifyIfKMSTransformersSwapped(t, wantPrefix, \"\", test) </ins> // run storage migration secretsList, err := test.restClient.CoreV1().Secrets(\"\").List(", "commid": "kubernetes_pr_121452"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-33f4a1afec0cea9cc4c6934a44d5b5164d557fa06c524615ad07f3a92559d09d", "text": "} } <del> func verifyIfKMSTransformersSwapped(t *testing.T, wantPrefix string, test *transformTest) { </del> <ins> func verifyIfKMSTransformersSwapped(t *testing.T, wantPrefix, wantPrefixForEncryptAll string, test *transformTest) { </ins> t.Helper() var swapErr error", "commid": "kubernetes_pr_121452"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-7d45391f9562796d50f7a663b519d78a142d412ab8aaa9e1d4e47df7a604ddab", "text": "return false, nil } <ins> if wantPrefixForEncryptAll != \"\" { deploymentName := fmt.Sprintf(\"deployment-%d\", idx) _, err := test.createDeployment(deploymentName, \"default\") if err != nil { t.Fatalf(\"Failed to create test secret, error: %v\", err) } rawEnvelope, err := test.readRawRecordFromETCD(test.getETCDPathForResource(test.storageConfig.Prefix, \"\", \"deployments\", deploymentName, \"default\")) if err != nil { t.Fatalf(\"failed to read %s from etcd: %v\", test.getETCDPathForResource(test.storageConfig.Prefix, \"\", \"deployments\", deploymentName, \"default\"), err) } // check prefix if !bytes.HasPrefix(rawEnvelope.Kvs[0].Value, []byte(wantPrefixForEncryptAll)) { idx++ swapErr = fmt.Errorf(\"expected deployment to be prefixed with %s, but got %s\", wantPrefixForEncryptAll, rawEnvelope.Kvs[0].Value) // return nil error to continue polling till timeout return false, nil } } </ins> return true, nil }) if pollErr == wait.ErrWaitTimeout {", "commid": "kubernetes_pr_121452"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-09545ca7f9a9ce659367b555d47cd66829b5a8476d36cf42a76416d02a23cdc8", "text": "// start new KMS Plugin _ = mock.NewBase64Plugin(t, \"@new-kms-provider.sock\") // update encryption config <del> if err := os.WriteFile(filepath.Join(test.configDir, encryptionConfigFileName), []byte(encryptionConfigWithNewProvider), 0644); err != nil { t.Fatalf(\"failed to update encryption config, err: %v\", err) } </del> <ins> updateFile(t, test.configDir, encryptionConfigFileName, []byte(encryptionConfigWithNewProvider)) </ins> wantPrefixForSecrets := \"k8s:enc:kms:v1:new-kms-provider-for-secrets:\" // implementing this brute force approach instead of fancy channel notification to avoid test specific code in prod. // wait for config to be observed <del> verifyIfKMSTransformersSwapped(t, wantPrefixForSecrets, \"\", test) </del> <ins> verifyIfKMSTransformersSwapped(t, wantPrefixForSecrets, test) </ins> // run storage migration // get secrets", "commid": "kubernetes_pr_121497"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-6d3ae2161f513801e472f49fc96ee32a65635eec1b9de225b5bcbc91eeeec8d9", "text": "} // remove old KMS provider <del> // verifyIfKMSTransformersSwapped sometimes passes even before the changes in the encryption config file are observed. // this causes the metrics tests to fail, which validate two config changes. // this may happen when an existing KMS provider is already running (e.g., new-kms-provider-for-secrets in this case). // to ensure that the changes are observed, we added one more provider (kms-provider-to-encrypt-all) and are validating it in verifyIfKMSTransformersSwapped. </del> encryptionConfigWithoutOldProvider := ` kind: EncryptionConfiguration apiVersion: apiserver.config.k8s.io/v1", "commid": "kubernetes_pr_121497"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-cdfcf4a1df5663e2219ae88e212c8084d1bf0300a3ec4826cfcd091046cacf2d", "text": "name: new-kms-provider-for-configmaps cachesize: 1000 endpoint: unix:///@new-kms-provider.sock <del> - resources: - '*.*' providers: - kms: name: kms-provider-to-encrypt-all cachesize: 1000 endpoint: unix:///@new-encrypt-all-kms-provider.sock - identity: {} </del> ` <del> // start new KMS Plugin _ = mock.NewBase64Plugin(t, \"@new-encrypt-all-kms-provider.sock\") </del> // update encryption config and wait for hot reload <del> if err := os.WriteFile(filepath.Join(test.configDir, encryptionConfigFileName), []byte(encryptionConfigWithoutOldProvider), 0644); err != nil { t.Fatalf(\"failed to update encryption config, err: %v\", err) } wantPrefixForEncryptAll := \"k8s:enc:kms:v1:kms-provider-to-encrypt-all:\" </del> <ins> updateFile(t, test.configDir, encryptionConfigFileName, []byte(encryptionConfigWithoutOldProvider)) </ins> // wait for config to be observed <del> verifyIfKMSTransformersSwapped(t, wantPrefixForSecrets, wantPrefixForEncryptAll, test) </del> <ins> verifyIfKMSTransformersSwapped(t, wantPrefixForSecrets, test) </ins> // confirm that reading secrets still works _, err = test.restClient.CoreV1().Secrets(testNamespace).Get(", "commid": "kubernetes_pr_121497"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-3021be26d46e5d12eced84521e3a6a3b58cce7cf908fa20453a8b13759127fb4", "text": "func verifyPrefixOfSecretResource(t *testing.T, wantPrefix string, test *transformTest) { // implementing this brute force approach instead of fancy channel notification to avoid test specific code in prod. // wait for config to be observed <del> verifyIfKMSTransformersSwapped(t, wantPrefix, \"\", test) </del> <ins> verifyIfKMSTransformersSwapped(t, wantPrefix, test) </ins> // run storage migration secretsList, err := test.restClient.CoreV1().Secrets(\"\").List(", "commid": "kubernetes_pr_121497"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-5e6a75c273349cccea3e0d3459a9bddcb9b0d60cf5adf5f80109784bc3a02499", "text": "} } <del> func verifyIfKMSTransformersSwapped(t *testing.T, wantPrefix, wantPrefixForEncryptAll string, test *transformTest) { </del> <ins> func verifyIfKMSTransformersSwapped(t *testing.T, wantPrefix string, test *transformTest) { </ins> t.Helper() var swapErr error", "commid": "kubernetes_pr_121497"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-3845e47adac5d9440b4038adeac4909d4d1212256ee08440f9021291e1d29d23", "text": "return false, nil } <del> if wantPrefixForEncryptAll != \"\" { deploymentName := fmt.Sprintf(\"deployment-%d\", idx) _, err := test.createDeployment(deploymentName, \"default\") if err != nil { t.Fatalf(\"Failed to create test secret, error: %v\", err) } rawEnvelope, err := test.readRawRecordFromETCD(test.getETCDPathForResource(test.storageConfig.Prefix, \"\", \"deployments\", deploymentName, \"default\")) if err != nil { t.Fatalf(\"failed to read %s from etcd: %v\", test.getETCDPathForResource(test.storageConfig.Prefix, \"\", \"deployments\", deploymentName, \"default\"), err) } // check prefix if !bytes.HasPrefix(rawEnvelope.Kvs[0].Value, []byte(wantPrefixForEncryptAll)) { idx++ swapErr = fmt.Errorf(\"expected deployment to be prefixed with %s, but got %s\", wantPrefixForEncryptAll, rawEnvelope.Kvs[0].Value) // return nil error to continue polling till timeout return false, nil } } </del> return true, nil }) if pollErr == wait.ErrWaitTimeout {", "commid": "kubernetes_pr_121497"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-9833d436ed0d7cd87bff14a39dccbe4377f5e87cdff15de0c9b2b0d561aa663a", "query": "transformation expandless | 14m1s Failed; === RUN TestEncryptionConfigHotReload TestEncryptionConfigHotReload When I see this flake, 10-09 is the first one.(But the job history in the testgrid only started from 10-03) some PR that may be related: /sig auth /cc\n/cc\n/triage accepted\n/cc failed two times in recent 3 runs:\n/reopen as of this is still .\nReopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details", "positive_passages": [{"docid": "doc-en-kubernetes-f09b89ee07b171e14f466ce58c45a0d6b8be43aaa0da93f40f73c3a99b7feb06", "text": "} } <ins> func updateFile(t *testing.T, configDir, filename string, newContent []byte) { t.Helper() // Create a temporary file tempFile, err := os.CreateTemp(configDir, \"tempfile\") if err != nil { t.Fatal(err) } defer tempFile.Close() // Write the new content to the temporary file _, err = tempFile.Write(newContent) if err != nil { t.Fatal(err) } // Atomically replace the original file with the temporary file err = os.Rename(tempFile.Name(), filepath.Join(configDir, filename)) if err != nil { t.Fatal(err) } } </ins> func TestKMSHealthz(t *testing.T) { encryptionConfig := ` kind: EncryptionConfiguration", "commid": "kubernetes_pr_121497"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0df5b59049720637ee6899078c8355df04a35b6393ba5d6263465e50214aa4a", "query": "4 other Test Failures in ci-crio-cgroupv1-node-e2e-features. Test has failed 61 times (no passing result found). Earliest failure found at commit/ (Thu Oct 19 21:41 PDT). /cc { failed [FAILED] Error creating Pod: pods \"pod-dualstack-host-ips9ddb9810-134c-4d35-a0c6-\" is forbidden: violates PodSecurity \"restricted:latest\": host namespaces (hostNetwork=true) In [It] at: @ 10/23/23 01:38:06.024 } No response_ /sig network node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis also failing on these tests\nthe test has a bug, it checks the contrary\n, let's start over, 1 commit for the e2e test, other for the promotion, and let's validate everything is alright before merging", "positive_passages": [{"docid": "doc-en-kubernetes-9f29cbbb543ce7ca348458022a81aac37d0b408f46f2b5891caaa6b5913ee5d8", "text": "\"k8s.io/apimachinery/pkg/util/uuid\" netutils \"k8s.io/utils/net\" <ins> utilfeature \"k8s.io/apiserver/pkg/util/feature\" </ins> kubefeatures \"k8s.io/kubernetes/pkg/features\" kubeletconfig \"k8s.io/kubernetes/pkg/kubelet/apis/config\" \"k8s.io/kubernetes/test/e2e/framework\"", "commid": "kubernetes_pr_121429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0df5b59049720637ee6899078c8355df04a35b6393ba5d6263465e50214aa4a", "query": "4 other Test Failures in ci-crio-cgroupv1-node-e2e-features. Test has failed 61 times (no passing result found). Earliest failure found at commit/ (Thu Oct 19 21:41 PDT). /cc { failed [FAILED] Error creating Pod: pods \"pod-dualstack-host-ips9ddb9810-134c-4d35-a0c6-\" is forbidden: violates PodSecurity \"restricted:latest\": host namespaces (hostNetwork=true) In [It] at: @ 10/23/23 01:38:06.024 } No response_ /sig network node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis also failing on these tests\nthe test has a bug, it checks the contrary\n, let's start over, 1 commit for the e2e test, other for the promotion, and let's validate everything is alright before merging", "positive_passages": [{"docid": "doc-en-kubernetes-74d64b4f81f4ba440c4b9353c89a2aec9a23ceb152282ff1f5a7421ac48d6b20", "text": "e2enode \"k8s.io/kubernetes/test/e2e/framework/node\" e2epod \"k8s.io/kubernetes/test/e2e/framework/pod\" e2epodoutput \"k8s.io/kubernetes/test/e2e/framework/pod/output\" <ins> e2eskipper \"k8s.io/kubernetes/test/e2e/framework/skipper\" </ins> \"k8s.io/kubernetes/test/e2e/network/common\" imageutils \"k8s.io/kubernetes/test/utils/image\" <ins> admissionapi \"k8s.io/pod-security-admission/api\" </ins> ) <del> var _ = common.SIGDescribe(\"Dual Stack Host IP [Feature:PodHostIPs]\", func() { </del> <ins> var _ = common.SIGDescribe(\"DualStack Host IP [Serial] [NodeFeature:PodHostIPs] [Feature:PodHostIPs]\", func() { </ins> f := framework.NewDefaultFramework(\"dualstack\") <ins> f.NamespacePodSecurityLevel = admissionapi.LevelPrivileged </ins> ginkgo.Context(\"when creating a Pod, it has no PodHostIPs feature\", func() { tempSetCurrentKubeletConfig(f, func(ctx context.Context, initialConfig *kubeletconfig.KubeletConfiguration) {", "commid": "kubernetes_pr_121429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0df5b59049720637ee6899078c8355df04a35b6393ba5d6263465e50214aa4a", "query": "4 other Test Failures in ci-crio-cgroupv1-node-e2e-features. Test has failed 61 times (no passing result found). Earliest failure found at commit/ (Thu Oct 19 21:41 PDT). /cc { failed [FAILED] Error creating Pod: pods \"pod-dualstack-host-ips9ddb9810-134c-4d35-a0c6-\" is forbidden: violates PodSecurity \"restricted:latest\": host namespaces (hostNetwork=true) In [It] at: @ 10/23/23 01:38:06.024 } No response_ /sig network node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis also failing on these tests\nthe test has a bug, it checks the contrary\n, let's start over, 1 commit for the e2e test, other for the promotion, and let's validate everything is alright before merging", "positive_passages": [{"docid": "doc-en-kubernetes-276042380d8b33c655e7024d6f597990ed0b5659b744034ccc000ed158089184", "text": "gomega.Expect(p.Status.HostIPs).Should(gomega.BeNil()) ginkgo.By(\"deleting the pod\") <del> err := podClient.Delete(ctx, pod.Name, *metav1.NewDeleteOptions(30)) </del> <ins> err := podClient.Delete(ctx, pod.Name, *metav1.NewDeleteOptions(1)) </ins> framework.ExpectNoError(err, \"failed to delete pod\") })", "commid": "kubernetes_pr_121429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0df5b59049720637ee6899078c8355df04a35b6393ba5d6263465e50214aa4a", "query": "4 other Test Failures in ci-crio-cgroupv1-node-e2e-features. Test has failed 61 times (no passing result found). Earliest failure found at commit/ (Thu Oct 19 21:41 PDT). /cc { failed [FAILED] Error creating Pod: pods \"pod-dualstack-host-ips9ddb9810-134c-4d35-a0c6-\" is forbidden: violates PodSecurity \"restricted:latest\": host namespaces (hostNetwork=true) In [It] at: @ 10/23/23 01:38:06.024 } No response_ /sig network node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis also failing on these tests\nthe test has a bug, it checks the contrary\n, let's start over, 1 commit for the e2e test, other for the promotion, and let's validate everything is alright before merging", "positive_passages": [{"docid": "doc-en-kubernetes-9b20111c2af74c7d9ccb38b85dbdd2074ac90c6e72f156e7b905f6f231e7369e", "text": "gomega.Expect(p.Status.HostIPs).Should(gomega.BeNil()) ginkgo.By(\"deleting the pod\") <del> err := podClient.Delete(ctx, pod.Name, *metav1.NewDeleteOptions(30)) </del> <ins> err := podClient.Delete(ctx, pod.Name, *metav1.NewDeleteOptions(1)) </ins> framework.ExpectNoError(err, \"failed to delete pod\") }) })", "commid": "kubernetes_pr_121429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0df5b59049720637ee6899078c8355df04a35b6393ba5d6263465e50214aa4a", "query": "4 other Test Failures in ci-crio-cgroupv1-node-e2e-features. Test has failed 61 times (no passing result found). Earliest failure found at commit/ (Thu Oct 19 21:41 PDT). /cc { failed [FAILED] Error creating Pod: pods \"pod-dualstack-host-ips9ddb9810-134c-4d35-a0c6-\" is forbidden: violates PodSecurity \"restricted:latest\": host namespaces (hostNetwork=true) In [It] at: @ 10/23/23 01:38:06.024 } No response_ /sig network node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis also failing on these tests\nthe test has a bug, it checks the contrary\n, let's start over, 1 commit for the e2e test, other for the promotion, and let's validate everything is alright before merging", "positive_passages": [{"docid": "doc-en-kubernetes-8c6ef80098fc182c8cbf347856544b6f7b3e58487b25000fda2c07dcb8fc3b3b", "text": "podName := \"pod-dualstack-host-ips\" <del> pod := &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name:   podName, Labels: map[string]string{\"test\": \"dualstack-host-ips\"}, }, Spec: v1.PodSpec{ Containers: []v1.Container{ { Name:  \"dualstack-host-ips\", Image: imageutils.GetE2EImage(imageutils.Agnhost), }, }, }, } </del> <ins> pod := genPodHostIPs(podName+string(uuid.NewUUID()), false) </ins> ginkgo.By(\"submitting the pod to kubernetes\") podClient := e2epod.NewPodClient(f)", "commid": "kubernetes_pr_121429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0df5b59049720637ee6899078c8355df04a35b6393ba5d6263465e50214aa4a", "query": "4 other Test Failures in ci-crio-cgroupv1-node-e2e-features. Test has failed 61 times (no passing result found). Earliest failure found at commit/ (Thu Oct 19 21:41 PDT). /cc { failed [FAILED] Error creating Pod: pods \"pod-dualstack-host-ips9ddb9810-134c-4d35-a0c6-\" is forbidden: violates PodSecurity \"restricted:latest\": host namespaces (hostNetwork=true) In [It] at: @ 10/23/23 01:38:06.024 } No response_ /sig network node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis also failing on these tests\nthe test has a bug, it checks the contrary\n, let's start over, 1 commit for the e2e test, other for the promotion, and let's validate everything is alright before merging", "positive_passages": [{"docid": "doc-en-kubernetes-80528975ce0b8bd3638706cdfa0996a7aa7888c51510261d307ed57dfa72d1a5", "text": "} ginkgo.By(\"deleting the pod\") <del> err = podClient.Delete(ctx, pod.Name, *metav1.NewDeleteOptions(30)) </del> <ins> err = podClient.Delete(ctx, pod.Name, *metav1.NewDeleteOptions(1)) </ins> framework.ExpectNoError(err, \"failed to delete pod\") })", "commid": "kubernetes_pr_121429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0df5b59049720637ee6899078c8355df04a35b6393ba5d6263465e50214aa4a", "query": "4 other Test Failures in ci-crio-cgroupv1-node-e2e-features. Test has failed 61 times (no passing result found). Earliest failure found at commit/ (Thu Oct 19 21:41 PDT). /cc { failed [FAILED] Error creating Pod: pods \"pod-dualstack-host-ips9ddb9810-134c-4d35-a0c6-\" is forbidden: violates PodSecurity \"restricted:latest\": host namespaces (hostNetwork=true) In [It] at: @ 10/23/23 01:38:06.024 } No response_ /sig network node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis also failing on these tests\nthe test has a bug, it checks the contrary\n, let's start over, 1 commit for the e2e test, other for the promotion, and let's validate everything is alright before merging", "positive_passages": [{"docid": "doc-en-kubernetes-43b61cc6e1afbbbd9c4ba05debb9032dc2733348f11ad4b197187377446b5f2b", "text": "podName := \"pod-dualstack-host-ips\" <del> pod := &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name:   podName, Labels: map[string]string{\"test\": \"dualstack-host-ips\"}, }, Spec: v1.PodSpec{ Containers: []v1.Container{ { Name:  \"dualstack-host-ips\", Image: imageutils.GetE2EImage(imageutils.Agnhost), }, }, HostNetwork: true, }, } </del> <ins> pod := genPodHostIPs(podName+string(uuid.NewUUID()), true) </ins> ginkgo.By(\"submitting the pod to kubernetes\") podClient := e2epod.NewPodClient(f)", "commid": "kubernetes_pr_121429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0df5b59049720637ee6899078c8355df04a35b6393ba5d6263465e50214aa4a", "query": "4 other Test Failures in ci-crio-cgroupv1-node-e2e-features. Test has failed 61 times (no passing result found). Earliest failure found at commit/ (Thu Oct 19 21:41 PDT). /cc { failed [FAILED] Error creating Pod: pods \"pod-dualstack-host-ips9ddb9810-134c-4d35-a0c6-\" is forbidden: violates PodSecurity \"restricted:latest\": host namespaces (hostNetwork=true) In [It] at: @ 10/23/23 01:38:06.024 } No response_ /sig network node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis also failing on these tests\nthe test has a bug, it checks the contrary\n, let's start over, 1 commit for the e2e test, other for the promotion, and let's validate everything is alright before merging", "positive_passages": [{"docid": "doc-en-kubernetes-2ddde7d176b0fe38b3c5e7fe87058d59c97e9118c4199c78b50020fb73611c5f", "text": "} ginkgo.By(\"deleting the pod\") <del> err = podClient.Delete(ctx, pod.Name, *metav1.NewDeleteOptions(30)) </del> <ins> err = podClient.Delete(ctx, pod.Name, *metav1.NewDeleteOptions(1)) </ins> framework.ExpectNoError(err, \"failed to delete pod\") }) ginkgo.It(\"should provide hostIPs as an env var\", func(ctx context.Context) { <ins> if !utilfeature.DefaultFeatureGate.Enabled(kubefeatures.PodHostIPs) { e2eskipper.Skipf(\"PodHostIPs feature is not enabled\") } </ins> podName := \"downward-api-\" + string(uuid.NewUUID()) env := []v1.EnvVar{ {", "commid": "kubernetes_pr_121429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b0df5b59049720637ee6899078c8355df04a35b6393ba5d6263465e50214aa4a", "query": "4 other Test Failures in ci-crio-cgroupv1-node-e2e-features. Test has failed 61 times (no passing result found). Earliest failure found at commit/ (Thu Oct 19 21:41 PDT). /cc { failed [FAILED] Error creating Pod: pods \"pod-dualstack-host-ips9ddb9810-134c-4d35-a0c6-\" is forbidden: violates PodSecurity \"restricted:latest\": host namespaces (hostNetwork=true) In [It] at: @ 10/23/23 01:38:06.024 } No response_ /sig network node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nis also failing on these tests\nthe test has a bug, it checks the contrary\n, let's start over, 1 commit for the e2e test, other for the promotion, and let's validate everything is alright before merging", "positive_passages": [{"docid": "doc-en-kubernetes-ff7ab673520fe116ad012d061b9950a80a01bbc1e2a03ae9975717d51d9606c0", "text": "testDownwardAPI(ctx, f, podName, env, expectations) }) }) <ins> ginkgo.Context(\"when feature rollback\", func() { tempSetCurrentKubeletConfig(f, func(ctx context.Context, initialConfig *kubeletconfig.KubeletConfiguration) { initialConfig.FeatureGates = map[string]bool{ string(kubefeatures.PodHostIPs): true, } }) ginkgo.It(\"should able upgrade and rollback\", func(ctx context.Context) { podName := \"pod-dualstack-host-ips\" pod := genPodHostIPs(podName+string(uuid.NewUUID()), false) ginkgo.By(\"submitting the pod to kubernetes\") podClient := e2epod.NewPodClient(f) p := podClient.CreateSync(ctx, pod) gomega.Expect(p.Status.HostIPs).ShouldNot(gomega.BeNil()) ginkgo.By(\"Disable PodHostIPs feature\") cfg, err := getCurrentKubeletConfig(ctx) framework.ExpectNoError(err) newCfg := cfg.DeepCopy() newCfg.FeatureGates = map[string]bool{ string(kubefeatures.PodHostIPs): false, } updateKubeletConfig(ctx, f, newCfg, true) gomega.Expect(p.Status.HostIPs).ShouldNot(gomega.BeNil()) ginkgo.By(\"deleting the pod\") err = podClient.Delete(ctx, pod.Name, *metav1.NewDeleteOptions(1)) framework.ExpectNoError(err, \"failed to delete pod\") ginkgo.By(\"recreate pod\") pod = genPodHostIPs(podName+string(uuid.NewUUID()), false) p = podClient.CreateSync(ctx, pod) // Feature PodHostIPs is disabled, HostIPs should be nil gomega.Expect(p.Status.HostIPs).Should(gomega.BeNil()) newCfg.FeatureGates = map[string]bool{ string(kubefeatures.PodHostIPs): true, } updateKubeletConfig(ctx, f, newCfg, true) p, err = podClient.Get(ctx, pod.Name, metav1.GetOptions{}) framework.ExpectNoError(err) // Feature PodHostIPs is enabled, HostIPs should not be nil gomega.Expect(p.Status.HostIPs).ShouldNot(gomega.BeNil()) ginkgo.By(\"deleting the pod\") err = podClient.Delete(ctx, pod.Name, *metav1.NewDeleteOptions(1)) framework.ExpectNoError(err, \"failed to delete pod\") }) }) </ins> }) <ins> func genPodHostIPs(podName string, hostNetwork bool) *v1.Pod { return &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name:   podName, Labels: map[string]string{\"test\": \"dualstack-host-ips\"}, }, Spec: v1.PodSpec{ Containers: []v1.Container{ { Name:  \"test-container\", Image: imageutils.GetE2EImage(imageutils.Agnhost), }, }, RestartPolicy: v1.RestartPolicyNever, HostNetwork:   hostNetwork, }, } } </ins> func testDownwardAPI(ctx context.Context, f *framework.Framework, podName string, env []v1.EnvVar, expectations []string) { pod := &v1.Pod{ ObjectMeta: metav1.ObjectMeta{", "commid": "kubernetes_pr_121429"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-550f4382eaf6f2574b193eb10497a48e4e8c7bfa87371b6f8dd7ca8be3c8d2cd", "query": "we just log that the user should install etcd, which is impractical in an ephemeral container we actually already call installing etcd in the verify script, but we don't export it into the current PATH for the process so it doesn't work ... ref: /sig api-machinery /assign /kind bug\n/triage accepted\nfor one possible fix\n/sig etcd", "positive_passages": [{"docid": "doc-en-kubernetes-2c7bc61437be7446ffaf9173c34735d7135c8ccc2a86da4101f0743136414d75", "text": "} kube::etcd::install() { <del> ( local os local arch os=$(kube::util::host_os) arch=$(kube::util::host_arch) cd \"${KUBE_ROOT}/third_party\" || return 1 if [[ $(readlink etcd) == etcd-v${ETCD_VERSION}-${os}-* ]]; then kube::log::info \"etcd v${ETCD_VERSION} already installed. To use:\" kube::log::info \"export PATH=\"$(pwd)/etcd:${PATH}\"\" return  #already installed fi if [[ ${os} == \"darwin\" ]]; then download_file=\"etcd-v${ETCD_VERSION}-${os}-${arch}.zip\" url=\"https://github.com/etcd-io/etcd/releases/download/v${ETCD_VERSION}/${download_file}\" kube::util::download_file \"${url}\" \"${download_file}\" unzip -o \"${download_file}\" ln -fns \"etcd-v${ETCD_VERSION}-${os}-${arch}\" etcd rm \"${download_file}\" elif [[ ${os} == \"linux\" ]]; then url=\"https://github.com/coreos/etcd/releases/download/v${ETCD_VERSION}/etcd-v${ETCD_VERSION}-${os}-${arch}.tar.gz\" download_file=\"etcd-v${ETCD_VERSION}-${os}-${arch}.tar.gz\" kube::util::download_file \"${url}\" \"${download_file}\" tar xzf \"${download_file}\" ln -fns \"etcd-v${ETCD_VERSION}-${os}-${arch}\" etcd rm \"${download_file}\" else kube::log::info \"${os} is NOT supported.\" fi kube::log::info \"etcd v${ETCD_VERSION} installed. To use:\" </del> <ins> local os local arch os=$(kube::util::host_os) arch=$(kube::util::host_arch) cd \"${KUBE_ROOT}/third_party\" || return 1 if [[ $(readlink etcd) == etcd-v${ETCD_VERSION}-${os}-* ]]; then kube::log::info \"etcd v${ETCD_VERSION} already installed. To use:\" </ins> kube::log::info \"export PATH=\"$(pwd)/etcd:${PATH}\"\" <del> ) </del> <ins> # export into current process PATH=\"$(pwd)/etcd:${PATH}\" export PATH return  #already installed fi if [[ ${os} == \"darwin\" ]]; then download_file=\"etcd-v${ETCD_VERSION}-${os}-${arch}.zip\" url=\"https://github.com/etcd-io/etcd/releases/download/v${ETCD_VERSION}/${download_file}\" kube::util::download_file \"${url}\" \"${download_file}\" unzip -o \"${download_file}\" ln -fns \"etcd-v${ETCD_VERSION}-${os}-${arch}\" etcd rm \"${download_file}\" elif [[ ${os} == \"linux\" ]]; then url=\"https://github.com/coreos/etcd/releases/download/v${ETCD_VERSION}/etcd-v${ETCD_VERSION}-${os}-${arch}.tar.gz\" download_file=\"etcd-v${ETCD_VERSION}-${os}-${arch}.tar.gz\" kube::util::download_file \"${url}\" \"${download_file}\" tar xzf \"${download_file}\" ln -fns \"etcd-v${ETCD_VERSION}-${os}-${arch}\" etcd rm \"${download_file}\" else kube::log::info \"${os} is NOT supported.\" fi kube::log::info \"etcd v${ETCD_VERSION} installed. To use:\" kube::log::info \"export PATH=\"$(pwd)/etcd:${PATH}\"\" # export into current process PATH=\"$(pwd)/etcd:${PATH}\" export PATH </ins> }", "commid": "kubernetes_pr_121493"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-550f4382eaf6f2574b193eb10497a48e4e8c7bfa87371b6f8dd7ca8be3c8d2cd", "query": "we just log that the user should install etcd, which is impractical in an ephemeral container we actually already call installing etcd in the verify script, but we don't export it into the current PATH for the process so it doesn't work ... ref: /sig api-machinery /assign /kind bug\n/triage accepted\nfor one possible fix\n/sig etcd", "positive_passages": [{"docid": "doc-en-kubernetes-897f13579190a5c8d8a1e0e35cc310d066b23c66638a16e0d8faadca03eacf6c", "text": "kube::util::require-jq kube::golang::setup_env <ins> kube::etcd::install </ins> make -C \"${KUBE_ROOT}\" WHAT=cmd/kube-apiserver", "commid": "kubernetes_pr_121493"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-550f4382eaf6f2574b193eb10497a48e4e8c7bfa87371b6f8dd7ca8be3c8d2cd", "query": "we just log that the user should install etcd, which is impractical in an ephemeral container we actually already call installing etcd in the verify script, but we don't export it into the current PATH for the process so it doesn't work ... ref: /sig api-machinery /assign /kind bug\n/triage accepted\nfor one possible fix\n/sig etcd", "positive_passages": [{"docid": "doc-en-kubernetes-96afe983c4a4db63fea89916c5ab6e07112224ed7592f98e898406a3f0280563", "text": "trap cleanup EXIT SIGINT <del> kube::golang::setup_env </del> TMP_DIR=${TMP_DIR:-$(kube::realpath \"$(mktemp -d -t \"$(basename \"$0\").XXXXXX\")\")} ETCD_HOST=${ETCD_HOST:-127.0.0.1} ETCD_PORT=${ETCD_PORT:-2379}", "commid": "kubernetes_pr_121493"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d28453dfc6bcf829133f35627fac482c86b9caf8a20943cea67f030688a8c436", "query": "Runs k8s with master golang: test Failure was observed on Aug 25th, it is passing after that. However it can be reproduced with stress tool. No response No response It is failing on both ppc and x86 architectures. Steps to reproduce: up golang tip version. clone kubernetes master /sig testing\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nit is a sig node test, sig testing charter is not about doing or maintain tests, we need to remove that old mindset of having a QA department, that is not how software development works or should work :) Besides, thanks for spotting it and submittn a patch /sig node /remove-sig testing\nFlaky in\nmerging this PR will fix the issue", "positive_passages": [{"docid": "doc-en-kubernetes-2eda084ecb25b594e923a9f1e4a72c64945109105af7662dd45b827669ac9170", "text": "if err != nil { assert.NoErrorf(t, err, \"unable to create temp file\") } stdoutBuf := &bytes.Buffer{} stderrBuf := &bytes.Buffer{} containerID := \"fake-container-id\"", "commid": "kubernetes_pr_121565"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d28453dfc6bcf829133f35627fac482c86b9caf8a20943cea67f030688a8c436", "query": "Runs k8s with master golang: test Failure was observed on Aug 25th, it is passing after that. However it can be reproduced with stress tool. No response No response It is failing on both ppc and x86 architectures. Steps to reproduce: up golang tip version. clone kubernetes master /sig testing\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nit is a sig node test, sig testing charter is not about doing or maintain tests, we need to remove that old mindset of having a QA department, that is not how software development works or should work :) Besides, thanks for spotting it and submittn a patch /sig node /remove-sig testing\nFlaky in\nmerging this PR will fix the issue", "positive_passages": [{"docid": "doc-en-kubernetes-98265b155578a94de2d8391a7d4a48d899ff560bac6662052e09cd4dbd93a80c", "text": "ctx, cancel := context.WithCancel(context.Background()) defer cancel() // Start to follow the container's log. <ins> fileName := file.Name() </ins> go func(ctx context.Context) { podLogOptions := v1.PodLogOptions{ Follow: true, } opts := NewLogOptions(&podLogOptions, time.Now()) <del> ReadLogs(ctx, file.Name(), containerID, opts, fakeRuntimeService, stdoutBuf, stderrBuf) </del> <ins> _ = ReadLogs(ctx, fileName, containerID, opts, fakeRuntimeService, stdoutBuf, stderrBuf) </ins> }(ctx) // log in stdout", "commid": "kubernetes_pr_121565"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d28453dfc6bcf829133f35627fac482c86b9caf8a20943cea67f030688a8c436", "query": "Runs k8s with master golang: test Failure was observed on Aug 25th, it is passing after that. However it can be reproduced with stress tool. No response No response It is failing on both ppc and x86 architectures. Steps to reproduce: up golang tip version. clone kubernetes master /sig testing\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\nit is a sig node test, sig testing charter is not about doing or maintain tests, we need to remove that old mindset of having a QA department, that is not how software development works or should work :) Besides, thanks for spotting it and submittn a patch /sig node /remove-sig testing\nFlaky in\nmerging this PR will fix the issue", "positive_passages": [{"docid": "doc-en-kubernetes-a6df48e174beefffa0800f0afb38d17410ec77c007cc0658e26039ff501b959e", "text": "// Write 10 lines to log file. // Let ReadLogs start. time.Sleep(50 * time.Millisecond) for line := 0; line < 10; line++ { // Write the first three lines to log file now := time.Now().Format(types.RFC3339NanoLenient)", "commid": "kubernetes_pr_121565"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-18a5f78a5b4039c2d6c090416c6a2637771f1d0c6604c73c3afd50f185f1a3f4", "query": "The swap fedora job is failing consistently for OOM. For a while. It looks like OOM is not actually killing these pods when swap is enabled. I did not see any examples of this failing without swap enabled so I think this is a real issue. There is a failure in OOMKilled as part of the serial fedora job but that is not related to this. This is part of and should be required for promotion to Beta2. /sig node\n/triage accepted /priority important-longterm", "positive_passages": [{"docid": "doc-en-kubernetes-b045e766d9cd50e0dcd15aa6d0d74a5ba9eeff580db30f9bf6825059a245d567", "text": "v1 \"k8s.io/api/core/v1\" \"k8s.io/apimachinery/pkg/api/resource\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" <ins> utilfeature \"k8s.io/apiserver/pkg/util/feature\" \"k8s.io/kubernetes/pkg/features\" </ins> kubeletconfig \"k8s.io/kubernetes/pkg/kubelet/apis/config\" \"k8s.io/kubernetes/test/e2e/framework\" e2epod \"k8s.io/kubernetes/test/e2e/framework/pod\"", "commid": "kubernetes_pr_121706"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-18a5f78a5b4039c2d6c090416c6a2637771f1d0c6604c73c3afd50f185f1a3f4", "query": "The swap fedora job is failing consistently for OOM. For a while. It looks like OOM is not actually killing these pods when swap is enabled. I did not see any examples of this failing without swap enabled so I think this is a real issue. There is a failure in OOMKilled as part of the serial fedora job but that is not related to this. This is part of and should be required for promotion to Beta2. /sig node\n/triage accepted /priority important-longterm", "positive_passages": [{"docid": "doc-en-kubernetes-04af650392faedb6456b1e7d0b7e32d9542580b3826b7ef1c0265399389480d9", "text": "}) ginkgo.It(\"The containers terminated by OOM killer should have the reason set to OOMKilled\", func() { <ins> cfg, configErr := getCurrentKubeletConfig(context.TODO()) framework.ExpectNoError(configErr) if utilfeature.DefaultFeatureGate.Enabled(features.NodeSwap) { // If Swap is enabled, we should test OOM with LimitedSwap. // UnlimitedSwap allows for workloads to use unbounded swap which // makes testing OOM challenging. // We are not able to change the default for these conformance tests, // so we will skip these tests if swap is enabled. if cfg.MemorySwap.SwapBehavior == \"\" || cfg.MemorySwap.SwapBehavior == \"UnlimitedSwap\" { ginkgo.Skip(\"OOMKiller should not run with UnlimitedSwap\") } } </ins> ginkgo.By(\"Waiting for the pod to be failed\") err := e2epod.WaitForPodTerminatedInNamespace(context.TODO(), f.ClientSet, testCase.podSpec.Name, \"\", f.Namespace.Name) framework.ExpectNoError(err, \"Failed waiting for pod to terminate, %s/%s\", f.Namespace.Name, testCase.podSpec.Name)", "commid": "kubernetes_pr_121706"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f8cba96d7af492bbd89bb089b4aed949aa9507e872bf2bb7a99f04a32adbe03f", "query": "pkg/registry/core/persistentvolume/storage TestUpdateStatus unknown No response /sig storage\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/priority important-soon as it failed in master blocking", "positive_passages": [{"docid": "doc-en-kubernetes-c79d4923510889bc39a23b8743886aba8bc61aa906f6fd59830e57806b616e8b", "text": "package storage import ( <del> utilfeature \"k8s.io/apiserver/pkg/util/feature\" featuregatetesting \"k8s.io/component-base/featuregate/testing\" \"k8s.io/kubernetes/pkg/features\" </del> <ins> \"context\" </ins> \"testing\" <ins> \"time\" </ins> <del> \"context\" </del> \"github.com/google/go-cmp/cmp\" apiequality \"k8s.io/apimachinery/pkg/api/equality\" \"k8s.io/apimachinery/pkg/api/resource\"", "commid": "kubernetes_pr_122011"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f8cba96d7af492bbd89bb089b4aed949aa9507e872bf2bb7a99f04a32adbe03f", "query": "pkg/registry/core/persistentvolume/storage TestUpdateStatus unknown No response /sig storage\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/priority important-soon as it failed in master blocking", "positive_passages": [{"docid": "doc-en-kubernetes-f0bf8d5c2563a6d2fd426b7e4a219f692f00a1db4ab0135e05f41cb64b890588", "text": "genericregistrytest \"k8s.io/apiserver/pkg/registry/generic/testing\" \"k8s.io/apiserver/pkg/registry/rest\" etcd3testing \"k8s.io/apiserver/pkg/storage/etcd3/testing\" <ins> utilfeature \"k8s.io/apiserver/pkg/util/feature\" featuregatetesting \"k8s.io/component-base/featuregate/testing\" </ins> api \"k8s.io/kubernetes/pkg/apis/core\" <ins> \"k8s.io/kubernetes/pkg/features\" </ins> \"k8s.io/kubernetes/pkg/registry/core/persistentvolume\" \"k8s.io/kubernetes/pkg/registry/registrytest\" )", "commid": "kubernetes_pr_122011"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f8cba96d7af492bbd89bb089b4aed949aa9507e872bf2bb7a99f04a32adbe03f", "query": "pkg/registry/core/persistentvolume/storage TestUpdateStatus unknown No response /sig storage\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/assign\n/priority important-soon as it failed in master blocking", "positive_passages": [{"docid": "doc-en-kubernetes-6b45ccf8bd6e710cb15fc14017c7c532f3e6a3232c49691223f7d87fc55abf4c", "text": "t.Errorf(\"unexpected error: %v\", err) } <ins> // We need to set custom timestamp which is not the same as the one on existing PV // - doing so will prevent timestamp update on phase change and custom one is used instead. pvStartTimestamp = &metav1.Time{Time: pvStartTimestamp.Time.Add(time.Second)} </ins> pvIn := &api.PersistentVolume{ ObjectMeta: metav1.ObjectMeta{ Name: \"foo\", }, Status: api.PersistentVolumeStatus{ <del> Phase: api.VolumeBound, // Set the same timestamp as original PV so this won't get updated on phase change breaking DeepEqual() later in test. </del> <ins> Phase:                   api.VolumeBound, </ins> LastPhaseTransitionTime: pvStartTimestamp, }, }", "commid": "kubernetes_pr_122011"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-eb5589dd8109b546f3f24867d42590a81e8b93836006e7a26d7a84d50aa0ef54", "query": "When unit tests in are invoked with 1, it fails Unit tests should work for any . This is important for troubleshooting flaking tests. Discovered when I tried to add parallel execution as described in master N/A N/A N/A N/A N/A\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network /area kube-proxy\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-cb5e35350061f2d51703de7eef3e595ffa001d99226c06afce9dfe6e9ffd454a", "text": "\"k8s.io/apimachinery/pkg/util/sets\" utilfeature \"k8s.io/apiserver/pkg/util/feature\" featuregatetesting \"k8s.io/component-base/featuregate/testing\" <ins> \"k8s.io/component-base/metrics/legacyregistry\" </ins> \"k8s.io/component-base/metrics/testutil\" \"k8s.io/klog/v2\" \"k8s.io/kubernetes/pkg/features\"", "commid": "kubernetes_pr_121801"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-eb5589dd8109b546f3f24867d42590a81e8b93836006e7a26d7a84d50aa0ef54", "query": "When unit tests in are invoked with 1, it fails Unit tests should work for any . This is important for troubleshooting flaking tests. Discovered when I tried to add parallel execution as described in master N/A N/A N/A N/A N/A\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network /area kube-proxy\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-59a30f80a0ec2ccb453bdb3bf7d4a0d7b721f072809f6e1374cb96e74cd9ab99", "text": "ipt := iptablestest.NewFake() fp := NewFakeProxier(ipt) metrics.RegisterMetrics() <ins> defer legacyregistry.Reset() </ins> // Create initial state var svc2 *v1.Service", "commid": "kubernetes_pr_121801"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-eb5589dd8109b546f3f24867d42590a81e8b93836006e7a26d7a84d50aa0ef54", "query": "When unit tests in are invoked with 1, it fails Unit tests should work for any . This is important for troubleshooting flaking tests. Discovered when I tried to add parallel execution as described in master N/A N/A N/A N/A N/A\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network /area kube-proxy\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-015cca6cb4332e5626d69456650d1be5a010f1d2cfe7b31ebe59c5c22e03ba76", "text": "if fp.needFullSync { t.Fatalf(\"Proxier unexpectedly already needs a full sync?\") } <del> prFailures, err := testutil.GetCounterMetricValue(metrics.IptablesPartialRestoreFailuresTotal) </del> <ins> partialRestoreFailures, err := testutil.GetCounterMetricValue(metrics.IptablesPartialRestoreFailuresTotal) </ins> if err != nil { t.Fatalf(\"Could not get partial restore failures metric: %v\", err) } <del> if prFailures != 0.0 { </del> <ins> if partialRestoreFailures != 0.0 { </ins> t.Errorf(\"Already did a partial resync? Something failed earlier!\") }", "commid": "kubernetes_pr_121801"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-eb5589dd8109b546f3f24867d42590a81e8b93836006e7a26d7a84d50aa0ef54", "query": "When unit tests in are invoked with 1, it fails Unit tests should work for any . This is important for troubleshooting flaking tests. Discovered when I tried to add parallel execution as described in master N/A N/A N/A N/A N/A\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network /area kube-proxy\n/cc", "positive_passages": [{"docid": "doc-en-kubernetes-36310cf7e8a2de8cb1c5b96162764c71d8584ce9aec5908126c4d166c06cc5d6", "text": "if !fp.needFullSync { t.Errorf(\"Proxier did not fail on previous partial resync?\") } <del> updatedPRFailures, err := testutil.GetCounterMetricValue(metrics.IptablesPartialRestoreFailuresTotal) </del> <ins> updatedPartialRestoreFailures, err := testutil.GetCounterMetricValue(metrics.IptablesPartialRestoreFailuresTotal) </ins> if err != nil { t.Errorf(\"Could not get partial restore failures metric: %v\", err) } <del> if updatedPRFailures != prFailures+1.0 { t.Errorf(\"Partial restore failures metric was not incremented after failed partial resync (expected %.02f, got %.02f)\", prFailures+1.0, updatedPRFailures) </del> <ins> if updatedPartialRestoreFailures != partialRestoreFailures+1.0 { t.Errorf(\"Partial restore failures metric was not incremented after failed partial resync (expected %.02f, got %.02f)\", partialRestoreFailures+1.0, updatedPartialRestoreFailures) </ins> } // On retry we should do a full resync, which should succeed (and delete svc4)", "commid": "kubernetes_pr_121801"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-b02b380dc71b93d08e0ccc7768a8b4ce44c6911102d809bff80ab3a21d026127", "query": "Created a RWX volume and mounted it on a pod having readOnly flag set to true. While the volume provisioning happened successfully, we did observe some warning message on describing the pod: Warning FileSystemResizeFailed 27m kubelet MountVolume.NodeExpandVolume failed for volume \"pvc--a6ba-49f4-a560-\" requested read-only file system It seems like this message is being triggered from here: But we never did an expand volume call, so we should not be seeing warning message. It can be confusing to see this warning message. The warning message should not be displayed when expand volume was not even called. Create a RWX volume and mount it on a pod with readOnly flag set to true. Wait for a few minutes and describe the pod. No response_ 28 vSphere <details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig storage\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-adf2f74349521d883a8a2da7ecc2f46ab0adad61319b9c10474c373218062e8e", "text": "return false, fmt.Errorf(\"mountVolume.NodeExpandVolume get PVC failed : %v\", err) } <del> if volumeToMount.VolumeSpec.ReadOnly { simpleMsg, detailedMsg := volumeToMount.GenerateMsg(\"MountVolume.NodeExpandVolume failed\", \"requested read-only file system\") klog.Warningf(detailedMsg) og.recorder.Eventf(volumeToMount.Pod, v1.EventTypeWarning, kevents.FileSystemResizeFailed, simpleMsg) og.recorder.Eventf(pvc, v1.EventTypeWarning, kevents.FileSystemResizeFailed, simpleMsg) return true, nil } </del> pvcStatusCap := pvc.Status.Capacity[v1.ResourceStorage] pvSpecCap := pv.Spec.Capacity[v1.ResourceStorage] if pvcStatusCap.Cmp(pvSpecCap) < 0 { <ins> if volumeToMount.VolumeSpec.ReadOnly { simpleMsg, detailedMsg := volumeToMount.GenerateMsg(\"MountVolume.NodeExpandVolume failed\", \"requested read-only file system\") klog.Warningf(detailedMsg) og.recorder.Eventf(volumeToMount.Pod, v1.EventTypeWarning, kevents.FileSystemResizeFailed, simpleMsg) og.recorder.Eventf(pvc, v1.EventTypeWarning, kevents.FileSystemResizeFailed, simpleMsg) return true, nil } </ins> rsOpts.NewSize = pvSpecCap rsOpts.OldSize = pvcStatusCap resizeOp := nodeResizeOperationOpts{", "commid": "kubernetes_pr_122508"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4cedb06a566ea432b70bad38aa75afb5c41b6d4b476ff1019ee7757e2034ed6b", "query": "When running subcommand like this: a warning message will display: which is incorrect in mode. It is only correct in mode. Warning message to only display when flag is passed in. Run No response <details</details<details</details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig cli", "positive_passages": [{"docid": "doc-en-kubernetes-736f614f13e1fc0ab367d19a068093eb556327c9414c4498d2be5e79b613f535", "text": "} switch { <del> case o.Watch || o.WatchOnly: </del> <ins> case o.Watch: </ins> if len(o.SortBy) > 0 { <del> fmt.Fprintf(o.IOStreams.ErrOut, \"warning: --watch or --watch-only requested, --sort-by will be ignoredn\") </del> <ins> fmt.Fprintf(o.IOStreams.ErrOut, \"warning: --watch requested, --sort-by will be ignored for watch events receivedn\") } case o.WatchOnly: if len(o.SortBy) > 0 { fmt.Fprintf(o.IOStreams.ErrOut, \"warning: --watch-only requested, --sort-by will be ignoredn\") </ins> } default: if len(args) == 0 && cmdutil.IsFilenameSliceEmpty(o.Filenames, o.Kustomize) {", "commid": "kubernetes_pr_123619"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-6593a5f6eee2ae8487ea83fb7883fea797662788ba1018ee349fd7ca0ec07e76", "query": "! Please also see /kind failing-test <!-- If this is a flake, please add: /kind flake --<!-- Please assign a SIG using: /sig SIG-NAME --/sig testing\ncc\nslack thread:\n/triage accepted\ngot one good run!", "positive_passages": [{"docid": "doc-en-kubernetes-596f9cc851c3d715a7112830195858e025a65fffec6a31f26b01c09af03f5e69", "text": "scheduledJobTimeout = 5 * time.Minute ) <del> var _ = framework.KubeDescribe(\"[Feature:ScheduledJob]\", func() { </del> <ins> var _ = framework.KubeDescribe(\"ScheduledJob\", func() { </ins> options := framework.FrameworkOptions{ ClientQPS:    20, ClientBurst:  50,", "commid": "kubernetes_pr_32254"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-dbf813432d184c58d7382219162d9513652adc2416b194ce1ef0f3c6ef9ee302", "query": "/kind failing-test /sig node\n/assign\n/triage accepted\nSeems to me that problem is related with test-infra config ? I noticed Checking kubelet logs there are complains about kubelet not finding configuration file. Even if this job run in AWS it is defined under ( ) and not under aws subfolder. Performing vimdiff periodic- ./aws/periodic-eks- i notice some variables are missing, but i don't have permissions to re-run the job to be able to debug more on this. Test code for InPlacePodVerticalScaling doesn't seem to be the root cause here, if we could increase the kubelet log level and perform a rerun might be helpful to debug more. Checking containerd logs , it seems that a container failed to stop, this might explain why pod resize failed due to lack of resources)\nThese two tests are permanent failing on this job\nTrue, but looking deeper it seems for the first test it fails ( unable to resize there are no available resources ) because a previous pod has not been deleted according to containerd logs . For second error it seems to be a config error , it complains that it could not login. I believe something is wrong with the setup ( repeated kubelet config errors in kubelet logs )\n/sig storage\nMore information for the container delete error, it belongs to mainpod-with-poststart-http-hookrestartable-init-container-lifecycle-hook. I will try to check if InPlacePodVerticalScaling test can be improved to cover this corner case. Please note, Garbage collect error happens before the InPlacePodVerticalScaling test failure, perhaps this is the root cause of the failure in InPlacePodVerticalScaling error. Perhaps we should update Issue title and include the garbage collect error for this issue? ! Source: / . Please search for", "positive_passages": [{"docid": "doc-en-kubernetes-d57dda2ff8658c11477eda68d93377b8b4a64ba05aed46bd072bded9887ffc47", "text": "nodeAllocatableMilliCPU2, nodeAvailableMilliCPU2 := getNodeAllocatableAndAvailableMilliCPUValues(&node) framework.Logf(\"TEST2: Node '%s': NodeAllocatable MilliCPUs = %dm. MilliCPUs currently available to allocate = %dm.\", node.Name, nodeAllocatableMilliCPU2, nodeAvailableMilliCPU2) <del> testPod3CPUQuantity := resource.NewMilliQuantity(nodeAvailableMilliCPU2+testPod1CPUQuantity.MilliValue()/2, resource.DecimalSI) </del> <ins> testPod3CPUQuantity := resource.NewMilliQuantity(nodeAvailableMilliCPU2+testPod1CPUQuantity.MilliValue()/4, resource.DecimalSI) </ins> testPod1CPUQuantityResized := resource.NewMilliQuantity(testPod1CPUQuantity.MilliValue()/3, resource.DecimalSI) framework.Logf(\"TEST2: testPod1 MilliCPUs after resize '%dm'\", testPod1CPUQuantityResized.MilliValue())", "commid": "kubernetes_pr_125492"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8fba26730e225229cebfcc9e9c81c6027c2c910e6c9f6867d93937be1135e10f", "query": ",%20google-gce all I can't say , but at least a few weeks ,%20google-gce No response No response /sig network\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-4573a4186b3a3846b3ba2abac232fdcb94329e5e5d073cb98fd263a091f3f41d", "text": "<ins> # See the OWNERS docs at https://go.k8s.io/owners approvers: - aojea - danwinship reviewers: - aojea - danwinship </ins>", "commid": "kubernetes_pr_124117"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8fba26730e225229cebfcc9e9c81c6027c2c910e6c9f6867d93937be1135e10f", "query": ",%20google-gce all I can't say , but at least a few weeks ,%20google-gce No response No response /sig network\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-1b607b2373869277a791068b1924681c938506b607fbfd837cd02bcf8fdace64", "text": "<ins> kind: ClusterRole apiVersion: rbac.authorization.k8s.io/v1 metadata: name: system:network-policies namespace: kube-system labels: addonmanager.kubernetes.io/mode: Reconcile rules: - apiGroups: [\"\"] resources: - pods - nodes - namespaces verbs: - get - watch - list # Watch for changes to Kubernetes NetworkPolicies. - apiGroups: [\"networking.k8s.io\"] resources: - networkpolicies verbs: - watch - list --- kind: ClusterRoleBinding apiVersion: rbac.authorization.k8s.io/v1 metadata: name: kube-network-policies labels: addonmanager.kubernetes.io/mode: Reconcile roleRef: apiGroup: rbac.authorization.k8s.io kind: ClusterRole name: system:network-policies subjects: - kind: ServiceAccount name: kube-network-policies namespace: kube-system --- apiVersion: v1 kind: ServiceAccount metadata: name: kube-network-policies namespace: kube-system labels: k8s-app: kube-network-policies kubernetes.io/cluster-service: \"true\" addonmanager.kubernetes.io/mode: Reconcile </ins>  No newline at end of file", "commid": "kubernetes_pr_124117"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8fba26730e225229cebfcc9e9c81c6027c2c910e6c9f6867d93937be1135e10f", "query": ",%20google-gce all I can't say , but at least a few weeks ,%20google-gce No response No response /sig network\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-b0deff0c54a1a8918ed4d4e0cededb15a64f32039b3f975f3084a371887d7da4", "text": "<ins> --- apiVersion: apps/v1 kind: DaemonSet metadata: name: kube-network-policies namespace: kube-system labels: tier: node app: kube-network-policies k8s-app: kube-network-policies addonmanager.kubernetes.io/mode: Reconcile spec: selector: matchLabels: app: kube-network-policies template: metadata: labels: tier: node app: kube-network-policies k8s-app: kube-network-policies spec: hostNetwork: true tolerations: - operator: Exists effect: NoSchedule serviceAccountName: kube-network-policies containers: - name: kube-network-policies image: registry.k8s.io/networking/kube-network-policies:v0.1.0 command: - /bin/sh - -c - /bin/netpol -v 4 1>>/var/log/kube-network-policies.log 2>&1 resources: requests: cpu: \"100m\" memory: \"50Mi\" securityContext: privileged: true volumeMounts: - mountPath: /var/log name: varlog readOnly: false - mountPath: /lib/modules name: lib-modules readOnly: true volumes: - name: varlog hostPath: path: /var/log - name: lib-modules hostPath: path: /lib/modules </ins>", "commid": "kubernetes_pr_124117"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8fba26730e225229cebfcc9e9c81c6027c2c910e6c9f6867d93937be1135e10f", "query": ",%20google-gce all I can't say , but at least a few weeks ,%20google-gce No response No response /sig network\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-131c9b2cd11f47888fb2750d9b0349952c91e7f854f8bf629060d5cc15f8069f", "text": "local -r ds_file=\"${dst_dir}/calico-policy-controller/calico-node-daemonset.yaml\" sed -i -e \"s@__CALICO_CNI_DIR__@/home/kubernetes/bin@g\" \"${ds_file}\" fi <ins> if [[ \"${NETWORK_POLICY_PROVIDER:-}\" == \"kube-network-policies\" ]]; then setup-addon-manifests \"addons\" \"kube-network-policies\" fi </ins> if [[ \"${ENABLE_DEFAULT_STORAGE_CLASS:-}\" == \"true\" ]]; then setup-addon-manifests \"addons\" \"storage-class/gce\" fi", "commid": "kubernetes_pr_124117"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8fba26730e225229cebfcc9e9c81c6027c2c910e6c9f6867d93937be1135e10f", "query": ",%20google-gce all I can't say , but at least a few weeks ,%20google-gce No response No response /sig network\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-e1344680161244adc26ec477cf6ad6bf8e0bc6d3f484e7c1aca4ae98774ed635", "text": "} EOF if [[ \"${KUBERNETES_MASTER:-}\" != \"true\" ]]; then <del> if [[ \"${NETWORK_POLICY_PROVIDER:-\"none\"}\" != \"none\" || \"${ENABLE_NETD:-}\" == \"true\" ]]; then # Use Kubernetes cni daemonset on node if network policy provider is specified </del> <ins> if [[ \"${NETWORK_POLICY_PROVIDER:-\"none\"}\" == \"calico\" || \"${ENABLE_NETD:-}\" == \"true\" ]]; then # Use Kubernetes cni daemonset on node if network policy provider calico is specified </ins> # or netd is enabled. cni_template_path=\"\" fi", "commid": "kubernetes_pr_124117"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-8fba26730e225229cebfcc9e9c81c6027c2c910e6c9f6867d93937be1135e10f", "query": ",%20google-gce all I can't say , but at least a few weeks ,%20google-gce No response No response /sig network\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-29056360cb95507015afa8da4694f134491db736ca48ef5e99c9b87971fc86a4", "text": "readonly gcloud_supported_providers=\"gce gke\" readonly master_logfiles=\"kube-apiserver.log kube-apiserver-audit.log kube-scheduler.log kube-controller-manager.log cloud-controller-manager.log etcd.log etcd-events.log glbc.log cluster-autoscaler.log kube-addon-manager.log konnectivity-server.log fluentd.log kubelet.cov\" <del> readonly node_logfiles=\"kube-proxy.log containers/konnectivity-agent-*.log fluentd.log node-problem-detector.log kubelet.cov\" </del> <ins> readonly node_logfiles=\"kube-proxy.log containers/konnectivity-agent-*.log fluentd.log node-problem-detector.log kubelet.cov kube-network-policies.log\" </ins> readonly node_systemd_services=\"node-problem-detector\" readonly hollow_node_logfiles=\"kubelet-hollow-node-*.log kubeproxy-hollow-node-*.log npd-hollow-node-*.log\" readonly aws_logfiles=\"cloud-init-output.log\"", "commid": "kubernetes_pr_124117"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-29413a491ce4700b5090f2ccec5e3645bbc47d10dffa11e343f3d9f092c18349", "query": "The following api endpoints are currently in - As each group has no stable endpoints they are reported in as promoted to stable without tests. The current logic for endpoints will address this issue.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig architecture /area test", "positive_passages": [{"docid": "doc-en-kubernetes-50e23932b6ae52796f91a167c08303732c7c63554eff9a4a8b2c4df1f39a5d45", "text": "- endpoint: createAuthenticationV1SelfSubjectReview reason: Cluster providers are allowed to choose to not serve this API, and the whoami command handles unavailability gracefully. link: https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/3325-self-subject-attributes-review-api/README.md#ga <ins> - endpoint: getInternalApiserverAPIGroup reason: The endpoint is part of a group that has no stable endpoints yet, reporting as a stable endpoint in apisnoop. link: https://github.com/kubernetes/issues/124248 - endpoint: getResourceAPIGroup reason: The endpoint is part of a group that has no stable endpoints yet, reporting as a stable endpoint in apisnoop. link: https://github.com/kubernetes/issues/124248 - endpoint: getStoragemigrationAPIGroup reason: The endpoint is part of a group that has no stable endpoints yet, reporting as a stable endpoint in apisnoop. link: https://github.com/kubernetes/issues/124248 </ins>", "commid": "kubernetes_pr_124249"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-29413a491ce4700b5090f2ccec5e3645bbc47d10dffa11e343f3d9f092c18349", "query": "The following api endpoints are currently in - As each group has no stable endpoints they are reported in as promoted to stable without tests. The current logic for endpoints will address this issue.\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig architecture /area test", "positive_passages": [{"docid": "doc-en-kubernetes-8d3386d3b99a97d6db14e960531d7ead855a42b1bea69743aadb32b7473933f4", "text": "- deleteCoreV1Node - deleteStorageV1CollectionCSINode - deleteStorageV1CSINode <del> - getInternalApiserverAPIGroup - getResourceAPIGroup - getStoragemigrationAPIGroup </del> - listStorageV1CSINode - patchStorageV1CSINode - patchStorageV1VolumeAttachmentStatus", "commid": "kubernetes_pr_124249"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1fddb3b599751010fd024d59e4002c926ec297661adb30ed03755bb80c0f9141", "query": "After restart Kubelet, node will become notReady in first kubelet update period. node condition is : in kubelet's logs: when go in to next period (default 10s), node status resume to Ready. Restart Kubelet should not make node status change to notReady. Restart Kubelet, and watch node status for second The root case maybe here: When kubelet start, it will start two go routine, one detect runtime status, one check node status and update to APIServer; detect runtime status: in it will update : in it will check runtimeStatus include : is one of the notReady setter func: So if nodestatus execute before , kubelet will update a node status with notReady condition: In kubelet starting, both go routine and will be called before , so the first node status is notReady. In our cluster is v1.22.17, but I belive it can reproduce in latest version. <details</details<details</details<details</details<details</details<details</details<details</details\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig node\nThe label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig node Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI can reproduce this issue in v1.30 When the container runtime is healthy, the kubelet should not report with the reason We called in the function to update the status of the container runtime, but we did not do this in , We only need to execute function once before and , just like we did in the function, than this problem can be avoided. But in , seems to have some different opinions...\nYeah, in our env, we modify kubelet the same way as you said, to let it execute once before , it worked. I can submit a PR later.\nI may be missing something but what happens if something has changed that caused the kubelet to not be ready ... imagine, the Network plugin is not working ... during the initial period until the check changes the state pods will be scheduled on the node and will fail .... I think that we are operating the assumption that this is a restart and during that time nothing changed, but is this a safe assumption or can we guarantee somehow that nothing has changed that could impact the node readiness state?\nIn this issue, what I found is that nothing has changed, every time I restart kubelet, node will become notReady only in first sync period, in next period it will be ready; It's not an assumption. or other problem of course will cause node notReady, but they are not in this issue's scope, in this scope, notReady reason is message, have not relationship with other problem;\nok, I misread this issue sorry, so it is not to blindly set the node to ready, is just to perform the runtime check before the other checks ... I think you both are right ... actually it seems that if wins the race then there is no problem, righ ?\nYes, but and run in different goroutines, so we cannot guarantee that will complete faster. So it seems like a good choice to execute before running , or do you have better suggestions?\nWe need to put the goroutines in the right order to make the startup more predictable\nYes, if execute very fast, may there is no problem, because in it will execute . I have test in v1.28 (which code in fastStatusUpdateOnce almost same as 1.30 ) , it will not always reproduce, but still occurr some times. In 1.22, will sleep for about 100ms before everything, it can be reproduced everytimes.\nArranging the goroutines in order can solve our problems in most cases, but in the method, we need to call the containerRuntime api to get the status. I am worried that its response will not be timely enough in special scenarios, there may be a risk that will complete faster.\nmoving will execute first\nI think I must not have expressed clearly. What I'm worried about is that under special circumstances, calls the API of the container runtime and cannot return immediately (not sure if this situation really exists). Even if the method is executed first, it will still complete later than :)\nAdd some detail: in it call runtime api to check runtime status, then set variable . in , it will check variable, if is nil, this issue's problem will occurr. Even if goroutine call firstly, call container runtime check will still need some time, it can't guarantee that when firstly call, is setted.\nare you suggesting to lock syncNodeStatus on updateRuntimeUp? I'm afraid of some corner cases we can hit ... if the container runtime does not return do we block forever?\nContainer runtime API call have timeout.\nCan you try this on a newer version? 1.22 is out of support and we have made changes to node readiness since. /triage needs-information\nI have tried in 1.28, it can reproduce, can reproduce in 1.30.\n/remove-triage needs-information", "positive_passages": [{"docid": "doc-en-kubernetes-9f352892a7fa57bcc97f1de9b7140035c3e647ba5dd3ed85e340f48b8d8b7bb0", "text": "// Introduce some small jittering to ensure that over time the requests won't start // accumulating at approximately the same time from the set of nodes due to priority and // fairness effect. <del> go wait.JitterUntil(kl.syncNodeStatus, kl.nodeStatusUpdateFrequency, 0.04, true, wait.NeverStop) </del> <ins> go func() { // Call updateRuntimeUp once before syncNodeStatus to make sure kubelet had already checked runtime state // otherwise when restart kubelet, syncNodeStatus will report node notReady in first report period kl.updateRuntimeUp() wait.JitterUntil(kl.syncNodeStatus, kl.nodeStatusUpdateFrequency, 0.04, true, wait.NeverStop) }() </ins> go kl.fastStatusUpdateOnce() // start syncing lease", "commid": "kubernetes_pr_124430"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f9f3a4a9e4c80ea389fb8a9736c195405e1e162356b7859d014b4284b5404210", "query": "What happened: If you use to test whether a user can approve certificate signing requests, you get a response indicating that is not a valid verb An example of the verb being used can be seen What you expected to happen: should be recognized as a valid verb on objects. How to reproduce it (as minimally and precisely as possible): Run Anything else we need to know?: I think that needs to be to the kubectl auth can-i code Environment: Kubernetes client and server versions (use ): Cloud provider or hardware configuration: OS (e.g: ):\nThis issue is currently awaiting triage. SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the label. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI don't think is a valid verb for kubectl auth command. Valid verbs are in\nso in that line of code there are a number of verbs which are only usuable on specific objects for example which works on users. AFAIK the point of that line is to inform kubectl what the valid verbs are on any object in Kubernetes, so that it knows what's possible when users use the command. the verb is valid on certificate objects as shown in the docs example I listed. Without being present in that line of code, will incorrectly state that there is no verb in Kubernetes.\nI tested it, seems working when we add in that list. But the question is should we add it or not?\nThere have been cases where Kubectl has had additions to handle non-standard resources/verbs in the past (e.g. I raised a couple of years back). AFAIK the explicit list of verbs here is designed to address this point, it's just not got approve in it. You could ask SIG-Auth about it, I'm sure they'd have more info.\n/transfer kubenertes /sig auth Decision can be made by sig-auth\nSomething went wrong or the destination repo kubernetes/kubenertes does not exist. <detailsIn response to : /transfer kubenertes /sig auth Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/transfer kubernetes/kubernetes\nSomething went wrong or the destination repo kubernetes/kubernetes/kubernetes does not exist. <detailsIn response to : /transfer kubernetes/kubernetes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/transfer kubernetes\n/triage accepted\nThis will work even without adding verb there, adding verb just removes the warning. Submitted a PR to add that. /assign", "positive_passages": [{"docid": "doc-en-kubernetes-633c6bb622529525269f94f085be986dd89026d4d079018225a328a157b46439", "text": "# Check to see if I can access the URL /logs/ kubectl auth can-i get /logs/ <ins> # Check to see if I can approve certificates.k8s.io kubectl auth can-i approve certificates.k8s.io </ins> # List all allowed actions in namespace \"foo\" kubectl auth can-i --list --namespace=foo`) <del> resourceVerbs       = sets.NewString(\"get\", \"list\", \"watch\", \"create\", \"update\", \"patch\", \"delete\", \"deletecollection\", \"use\", \"bind\", \"impersonate\", \"*\") </del> <ins> resourceVerbs       = sets.NewString(\"get\", \"list\", \"watch\", \"create\", \"update\", \"patch\", \"delete\", \"deletecollection\", \"use\", \"bind\", \"impersonate\", \"*\", \"approve\") </ins> nonResourceURLVerbs = sets.NewString(\"get\", \"put\", \"post\", \"head\", \"options\", \"delete\", \"patch\", \"*\") // holds all the server-supported resources that cannot be discovered by clients. i.e. users and groups for the impersonate verb nonStandardResourceNames = sets.NewString(\"users\", \"groups\")", "commid": "kubernetes_pr_125131"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-f9f3a4a9e4c80ea389fb8a9736c195405e1e162356b7859d014b4284b5404210", "query": "What happened: If you use to test whether a user can approve certificate signing requests, you get a response indicating that is not a valid verb An example of the verb being used can be seen What you expected to happen: should be recognized as a valid verb on objects. How to reproduce it (as minimally and precisely as possible): Run Anything else we need to know?: I think that needs to be to the kubectl auth can-i code Environment: Kubernetes client and server versions (use ): Cloud provider or hardware configuration: OS (e.g: ):\nThis issue is currently awaiting triage. SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the label. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nI don't think is a valid verb for kubectl auth command. Valid verbs are in\nso in that line of code there are a number of verbs which are only usuable on specific objects for example which works on users. AFAIK the point of that line is to inform kubectl what the valid verbs are on any object in Kubernetes, so that it knows what's possible when users use the command. the verb is valid on certificate objects as shown in the docs example I listed. Without being present in that line of code, will incorrectly state that there is no verb in Kubernetes.\nI tested it, seems working when we add in that list. But the question is should we add it or not?\nThere have been cases where Kubectl has had additions to handle non-standard resources/verbs in the past (e.g. I raised a couple of years back). AFAIK the explicit list of verbs here is designed to address this point, it's just not got approve in it. You could ask SIG-Auth about it, I'm sure they'd have more info.\n/transfer kubenertes /sig auth Decision can be made by sig-auth\nSomething went wrong or the destination repo kubernetes/kubenertes does not exist. <detailsIn response to : /transfer kubenertes /sig auth Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/transfer kubernetes/kubernetes\nSomething went wrong or the destination repo kubernetes/kubernetes/kubernetes does not exist. <detailsIn response to : /transfer kubernetes/kubernetes Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/transfer kubernetes\n/triage accepted\nThis will work even without adding verb there, adding verb just removes the warning. Submitted a PR to add that. /assign", "positive_passages": [{"docid": "doc-en-kubernetes-b078998db8f7486dd516e2abaa4ffad5683dd67a81275e2ecfda24071daaf2a9", "text": "default: errString := \"you must specify two arguments: verb resource or verb resource/resourceName.\" usageString := \"See 'kubectl auth can-i -h' for help and examples.\" <del> return errors.New(fmt.Sprintf(\"%sn%s\", errString, usageString)) </del> <ins> return fmt.Errorf(\"%sn%s\", errString, usageString) </ins> } }", "commid": "kubernetes_pr_125131"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d6a2cfcf65b740093bf3b8dc935076e8c61a689f6ed71e2e391888aac4bf6a68", "query": "Everything 2024-05-24 No response /sig testing\n/sig node\nkubelet logs dmesg:\nSeems a regression in\n/cc\n/triage accepted /priority important-longterm", "positive_passages": [{"docid": "doc-en-kubernetes-7801e9ef3dc5ddd4db1c2902f0461319857aa99328108dacf3dfceba3be2e89f", "text": "\"k8s.io/apimachinery/pkg/util/version\" \"k8s.io/klog/v2\" <ins> \"k8s.io/kubernetes/pkg/kubelet/userns/inuserns\" </ins> utilkernel \"k8s.io/kubernetes/pkg/util/kernel\" \"k8s.io/mount-utils\" )", "commid": "kubernetes_pr_125138"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-d6a2cfcf65b740093bf3b8dc935076e8c61a689f6ed71e2e391888aac4bf6a68", "query": "Everything 2024-05-24 No response /sig testing\n/sig node\nkubelet logs dmesg:\nSeems a regression in\n/cc\n/triage accepted /priority important-longterm", "positive_passages": [{"docid": "doc-en-kubernetes-ba502f4233cba8f0a59cdcbaa3a63c2a43a5244c816fa161f79cc71fd807351d", "text": "return false } <ins> if inuserns.RunningInUserNS() { // Turning off swap in unprivileged tmpfs mounts unsupported // https://github.com/torvalds/linux/blob/v6.8/mm/shmem.c#L4004-L4011 // https://github.com/kubernetes/kubernetes/issues/125137 klog.InfoS(\"Running under a user namespace - tmpfs noswap is not supported\") return false } </ins> kernelVersion, err := utilkernel.GetVersion() if err != nil { klog.ErrorS(err, \"cannot determine kernel version, unable to determine is tmpfs noswap is supported\")", "commid": "kubernetes_pr_125138"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-16e9d6242dd147113f7225a4b24c8c9581a1b180a6b05f0edc47ba4e0c49bde0", "query": "master-blocking: ci-kubernetes-unit It starts flaking today 30-05-2024 The test fail is This failure may be caused by the error message's order sensitivity. The error message's order of Resource Classes versus is different. N/A /sig node /sig scheduling\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-sig testing /sig scheduling (sig testing doesn't own all of the unit tests, just test frameworks, tooling, CI infra, etc) This appears to be a flake in scheduler unit tests which would be sig scheduling ( )\n.. and it appears to be DRA specific subset of scheduling so /sig node as well\nFYI - looks like this is happening every 3-6 hours give or take. Yesterday it was every six hours and today it seems to be every 3-4 hours. Looking into it a bit more, it looks like it may just be an issue with a connection via the test while it's trying to hit the server. I don't think the test itself is failing, I think the connection to the server is failing. ! CC\nHey All - hope you're well. Michael here from the Release Signal team. Just wanted to touch base and make sure we're good to go for the cut on the 4th. CC /sig-node", "positive_passages": [{"docid": "doc-en-kubernetes-15a36e4cb37f3774b4e5d6f4bc30cfbb91fdbf3f9ce9f18f9691211baad69c33", "text": "} return parameters, nil default: <ins> sort.Slice(objs, func(i, j int) bool { obj1, obj2 := objs[i].(*resourcev1alpha2.ResourceClassParameters), objs[j].(*resourcev1alpha2.ResourceClassParameters) if obj1 == nil || obj2 == nil { return false } return obj1.Name < obj2.Name }) </ins> return nil, statusError(logger, fmt.Errorf(\"multiple generated class parameters for %s.%s %s found: %s\", class.ParametersRef.Kind, class.ParametersRef.APIGroup, klog.KRef(class.Namespace, class.ParametersRef.Name), klog.KObjSlice(objs))) } }", "commid": "kubernetes_pr_125213"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-16e9d6242dd147113f7225a4b24c8c9581a1b180a6b05f0edc47ba4e0c49bde0", "query": "master-blocking: ci-kubernetes-unit It starts flaking today 30-05-2024 The test fail is This failure may be caused by the error message's order sensitivity. The error message's order of Resource Classes versus is different. N/A /sig node /sig scheduling\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/remove-sig testing /sig scheduling (sig testing doesn't own all of the unit tests, just test frameworks, tooling, CI infra, etc) This appears to be a flake in scheduler unit tests which would be sig scheduling ( )\n.. and it appears to be DRA specific subset of scheduling so /sig node as well\nFYI - looks like this is happening every 3-6 hours give or take. Yesterday it was every six hours and today it seems to be every 3-4 hours. Looking into it a bit more, it looks like it may just be an issue with a connection via the test while it's trying to hit the server. I don't think the test itself is failing, I think the connection to the server is failing. ! CC\nHey All - hope you're well. Michael here from the Release Signal team. Just wanted to touch base and make sure we're good to go for the cut on the 4th. CC /sig-node", "positive_passages": [{"docid": "doc-en-kubernetes-555210586c074f6777944574c07886a890eb6d90f2fcc56156ac728f6587bdcc", "text": "} return parameters, nil default: <ins> sort.Slice(objs, func(i, j int) bool { obj1, obj2 := objs[i].(*resourcev1alpha2.ResourceClaimParameters), objs[j].(*resourcev1alpha2.ResourceClaimParameters) if obj1 == nil || obj2 == nil { return false } return obj1.Name < obj2.Name }) </ins> return nil, statusError(logger, fmt.Errorf(\"multiple generated claim parameters for %s.%s %s found: %s\", claim.Spec.ParametersRef.Kind, claim.Spec.ParametersRef.APIGroup, klog.KRef(claim.Namespace, claim.Spec.ParametersRef.Name), klog.KObjSlice(objs))) } }", "commid": "kubernetes_pr_125213"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1526b3852d29761d739a37aed35c379fa23d213ea73b054963472bd46c418c30", "query": "Kubelet soft admission handlers were created as a way for the Kubelet to block pods that cannot be run for reasons that can be resolved. In practice, this mechanism was only ever used by AppArmor (). Problems with soft-admission rejection: is only used by AppArmor, and only for situations that cannot realistically be resolved (host or build does not support apparmor) held in the blocked state must be manually cleaned up. While there they hold reserved capacity from the scheduler and continually retry syncpod. other features work this way - usually Kubelet hard rejects pods that it knows it cannot run, or the runtime fails to start the pod/container. This was originally to prevent controllers from continuously recreating pods that cannot run, but that is a separate problem that should be approached globally, rather than with this 1-off AppArmor solution. I propose we remove Kubelet soft admission entirely, and move the AppArmor admission handler to the hard-admission list. /sig node /milestone v1.31 /kind bug\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nWe have a different, alpha mechanism: . We could change AppArmor, seccomp and other mechanisms to work either with PodSchedulingContext or its eventual replacement. IMO we only need to sketch out an approach and see that it looks viable; we don't have to block graduation for AppArmor support on a fleshed-out design.\nFrom my admittedly limited PoV I'm not against removing soft admission, and I got no opinions about AppArmor specifically. However this seems to connected to the recent conversation we're having in WG serving and SIG-node about retriable vs unretriable errors so I think we would need some coordination cc\n+1\nMy understanding is that after this PR: soft admission just doesn't make sense any longer.\nHello ! Just a reminder, the code freeze is starting (about from now), and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time. As the issue is tagged for , is it still planned for this release?\nDiscussed in sig-node, decided to move forward with this (move AppArmor admission to the hard admission set, remove soft-admission code)\n/assign\n- do you want me to incorporate this change into", "positive_passages": [{"docid": "doc-en-kubernetes-df95bc4231687a001d0dc9c585503aeac17795b32cab1f70d83fc47eeddb4547", "text": "if sysruntime.GOOS == \"linux\" { // AppArmor is a Linux kernel security module and it does not support other operating systems. klet.appArmorValidator = apparmor.NewValidator() <del> klet.softAdmitHandlers.AddPodAdmitHandler(lifecycle.NewAppArmorAdmitHandler(klet.appArmorValidator)) </del> <ins> klet.admitHandlers.AddPodAdmitHandler(lifecycle.NewAppArmorAdmitHandler(klet.appArmorValidator)) </ins> } leaseDuration := time.Duration(kubeCfg.NodeLeaseDurationSeconds) * time.Second", "commid": "kubernetes_pr_125776"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1526b3852d29761d739a37aed35c379fa23d213ea73b054963472bd46c418c30", "query": "Kubelet soft admission handlers were created as a way for the Kubelet to block pods that cannot be run for reasons that can be resolved. In practice, this mechanism was only ever used by AppArmor (). Problems with soft-admission rejection: is only used by AppArmor, and only for situations that cannot realistically be resolved (host or build does not support apparmor) held in the blocked state must be manually cleaned up. While there they hold reserved capacity from the scheduler and continually retry syncpod. other features work this way - usually Kubelet hard rejects pods that it knows it cannot run, or the runtime fails to start the pod/container. This was originally to prevent controllers from continuously recreating pods that cannot run, but that is a separate problem that should be approached globally, rather than with this 1-off AppArmor solution. I propose we remove Kubelet soft admission entirely, and move the AppArmor admission handler to the hard-admission list. /sig node /milestone v1.31 /kind bug\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nWe have a different, alpha mechanism: . We could change AppArmor, seccomp and other mechanisms to work either with PodSchedulingContext or its eventual replacement. IMO we only need to sketch out an approach and see that it looks viable; we don't have to block graduation for AppArmor support on a fleshed-out design.\nFrom my admittedly limited PoV I'm not against removing soft admission, and I got no opinions about AppArmor specifically. However this seems to connected to the recent conversation we're having in WG serving and SIG-node about retriable vs unretriable errors so I think we would need some coordination cc\n+1\nMy understanding is that after this PR: soft admission just doesn't make sense any longer.\nHello ! Just a reminder, the code freeze is starting (about from now), and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time. As the issue is tagged for , is it still planned for this release?\nDiscussed in sig-node, decided to move forward with this (move AppArmor admission to the hard admission set, remove soft-admission code)\n/assign\n- do you want me to incorporate this change into", "positive_passages": [{"docid": "doc-en-kubernetes-0ff903d824d296204cbf1da5deeb96aa2410ea7120fb43fafa8550778673ca06", "text": "// the list of handlers to call during pod admission. admitHandlers lifecycle.PodAdmitHandlers <del> // softAdmithandlers are applied to the pod after it is admitted by the Kubelet, but before it is // run. A pod rejected by a softAdmitHandler will be left in a Pending state indefinitely. If a // rejected pod should not be recreated, or the scheduler is not aware of the rejection rule, the // admission rule should be applied by a softAdmitHandler. softAdmitHandlers lifecycle.PodAdmitHandlers </del> // the list of handlers to call during pod sync loop. lifecycle.PodSyncLoopHandlers", "commid": "kubernetes_pr_125776"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1526b3852d29761d739a37aed35c379fa23d213ea73b054963472bd46c418c30", "query": "Kubelet soft admission handlers were created as a way for the Kubelet to block pods that cannot be run for reasons that can be resolved. In practice, this mechanism was only ever used by AppArmor (). Problems with soft-admission rejection: is only used by AppArmor, and only for situations that cannot realistically be resolved (host or build does not support apparmor) held in the blocked state must be manually cleaned up. While there they hold reserved capacity from the scheduler and continually retry syncpod. other features work this way - usually Kubelet hard rejects pods that it knows it cannot run, or the runtime fails to start the pod/container. This was originally to prevent controllers from continuously recreating pods that cannot run, but that is a separate problem that should be approached globally, rather than with this 1-off AppArmor solution. I propose we remove Kubelet soft admission entirely, and move the AppArmor admission handler to the hard-admission list. /sig node /milestone v1.31 /kind bug\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nWe have a different, alpha mechanism: . We could change AppArmor, seccomp and other mechanisms to work either with PodSchedulingContext or its eventual replacement. IMO we only need to sketch out an approach and see that it looks viable; we don't have to block graduation for AppArmor support on a fleshed-out design.\nFrom my admittedly limited PoV I'm not against removing soft admission, and I got no opinions about AppArmor specifically. However this seems to connected to the recent conversation we're having in WG serving and SIG-node about retriable vs unretriable errors so I think we would need some coordination cc\n+1\nMy understanding is that after this PR: soft admission just doesn't make sense any longer.\nHello ! Just a reminder, the code freeze is starting (about from now), and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time. As the issue is tagged for , is it still planned for this release?\nDiscussed in sig-node, decided to move forward with this (move AppArmor admission to the hard admission set, remove soft-admission code)\n/assign\n- do you want me to incorporate this change into", "positive_passages": [{"docid": "doc-en-kubernetes-4460f4e927ff74a2e690790c6187023ddb2add17bdf356bb7da8ed5dfe46f841", "text": "return isTerminal, nil } <del> // If the pod should not be running, we request the pod's containers be stopped. This is not the same // as termination (we want to stop the pod, but potentially restart it later if soft admission allows // it later). Set the status and phase appropriately runnable := kl.canRunPod(pod) if !runnable.Admit { // Pod is not runnable; and update the Pod and Container statuses to why. if apiPodStatus.Phase != v1.PodFailed && apiPodStatus.Phase != v1.PodSucceeded { apiPodStatus.Phase = v1.PodPending } apiPodStatus.Reason = runnable.Reason apiPodStatus.Message = runnable.Message // Waiting containers are not creating. const waitingReason = \"Blocked\" for _, cs := range apiPodStatus.InitContainerStatuses { if cs.State.Waiting != nil { cs.State.Waiting.Reason = waitingReason } } for _, cs := range apiPodStatus.ContainerStatuses { if cs.State.Waiting != nil { cs.State.Waiting.Reason = waitingReason } } } </del> // Record the time it takes for the pod to become running // since kubelet first saw the pod if firstSeenTime is set. existingStatus, ok := kl.statusManager.GetPodStatus(pod.UID)", "commid": "kubernetes_pr_125776"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1526b3852d29761d739a37aed35c379fa23d213ea73b054963472bd46c418c30", "query": "Kubelet soft admission handlers were created as a way for the Kubelet to block pods that cannot be run for reasons that can be resolved. In practice, this mechanism was only ever used by AppArmor (). Problems with soft-admission rejection: is only used by AppArmor, and only for situations that cannot realistically be resolved (host or build does not support apparmor) held in the blocked state must be manually cleaned up. While there they hold reserved capacity from the scheduler and continually retry syncpod. other features work this way - usually Kubelet hard rejects pods that it knows it cannot run, or the runtime fails to start the pod/container. This was originally to prevent controllers from continuously recreating pods that cannot run, but that is a separate problem that should be approached globally, rather than with this 1-off AppArmor solution. I propose we remove Kubelet soft admission entirely, and move the AppArmor admission handler to the hard-admission list. /sig node /milestone v1.31 /kind bug\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nWe have a different, alpha mechanism: . We could change AppArmor, seccomp and other mechanisms to work either with PodSchedulingContext or its eventual replacement. IMO we only need to sketch out an approach and see that it looks viable; we don't have to block graduation for AppArmor support on a fleshed-out design.\nFrom my admittedly limited PoV I'm not against removing soft admission, and I got no opinions about AppArmor specifically. However this seems to connected to the recent conversation we're having in WG serving and SIG-node about retriable vs unretriable errors so I think we would need some coordination cc\n+1\nMy understanding is that after this PR: soft admission just doesn't make sense any longer.\nHello ! Just a reminder, the code freeze is starting (about from now), and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time. As the issue is tagged for , is it still planned for this release?\nDiscussed in sig-node, decided to move forward with this (move AppArmor admission to the hard admission set, remove soft-admission code)\n/assign\n- do you want me to incorporate this change into", "positive_passages": [{"docid": "doc-en-kubernetes-a74beac77b1758ed8c36f5473065d0ae1cf31d37bd350414654b4c655427c700", "text": "kl.statusManager.SetPodStatus(pod, apiPodStatus) <del> // Pods that are not runnable must be stopped - return a typed error to the pod worker if !runnable.Admit { klog.V(2).InfoS(\"Pod is not runnable and must have running containers stopped\", \"pod\", klog.KObj(pod), \"podUID\", pod.UID, \"message\", runnable.Message) var syncErr error p := kubecontainer.ConvertPodStatusToRunningPod(kl.getRuntime().Type(), podStatus) if err := kl.killPod(ctx, pod, p, nil); err != nil { if !wait.Interrupted(err) { kl.recorder.Eventf(pod, v1.EventTypeWarning, events.FailedToKillPod, \"error killing pod: %v\", err) syncErr = fmt.Errorf(\"error killing pod: %w\", err) utilruntime.HandleError(syncErr) } } else { // There was no error killing the pod, but the pod cannot be run. // Return an error to signal that the sync loop should back off. syncErr = fmt.Errorf(\"pod cannot be run: %v\", runnable.Message) } return false, syncErr } </del> // If the network plugin is not ready, only start the pod if it uses the host network if err := kl.runtimeState.networkErrors(); err != nil && !kubecontainer.IsHostNetworkPod(pod) { kl.recorder.Eventf(pod, v1.EventTypeWarning, events.NetworkNotReady, \"%s: %v\", NetworkNotReadyErrorMsg, err)", "commid": "kubernetes_pr_125776"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-1526b3852d29761d739a37aed35c379fa23d213ea73b054963472bd46c418c30", "query": "Kubelet soft admission handlers were created as a way for the Kubelet to block pods that cannot be run for reasons that can be resolved. In practice, this mechanism was only ever used by AppArmor (). Problems with soft-admission rejection: is only used by AppArmor, and only for situations that cannot realistically be resolved (host or build does not support apparmor) held in the blocked state must be manually cleaned up. While there they hold reserved capacity from the scheduler and continually retry syncpod. other features work this way - usually Kubelet hard rejects pods that it knows it cannot run, or the runtime fails to start the pod/container. This was originally to prevent controllers from continuously recreating pods that cannot run, but that is a separate problem that should be approached globally, rather than with this 1-off AppArmor solution. I propose we remove Kubelet soft admission entirely, and move the AppArmor admission handler to the hard-admission list. /sig node /milestone v1.31 /kind bug\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nWe have a different, alpha mechanism: . We could change AppArmor, seccomp and other mechanisms to work either with PodSchedulingContext or its eventual replacement. IMO we only need to sketch out an approach and see that it looks viable; we don't have to block graduation for AppArmor support on a fleshed-out design.\nFrom my admittedly limited PoV I'm not against removing soft admission, and I got no opinions about AppArmor specifically. However this seems to connected to the recent conversation we're having in WG serving and SIG-node about retriable vs unretriable errors so I think we would need some coordination cc\n+1\nMy understanding is that after this PR: soft admission just doesn't make sense any longer.\nHello ! Just a reminder, the code freeze is starting (about from now), and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time. As the issue is tagged for , is it still planned for this release?\nDiscussed in sig-node, decided to move forward with this (move AppArmor admission to the hard admission set, remove soft-admission code)\n/assign\n- do you want me to incorporate this change into", "positive_passages": [{"docid": "doc-en-kubernetes-68f2b0e74378a79643adf685ff6517fdf150ded87f0d20c5de606be04df5da74", "text": "return true, \"\", \"\" } <del> func (kl *Kubelet) canRunPod(pod *v1.Pod) lifecycle.PodAdmitResult { attrs := &lifecycle.PodAdmitAttributes{Pod: pod} // Get \"OtherPods\". Rejected pods are failed, so only include admitted pods that are alive. attrs.OtherPods = kl.GetActivePods() for _, handler := range kl.softAdmitHandlers { if result := handler.Admit(attrs); !result.Admit { return result } } return lifecycle.PodAdmitResult{Admit: true} } </del> // syncLoop is the main loop for processing changes. It watches for changes from // three channels (file, apiserver, and http) and creates a union of them. For // any new change seen, will run a sync against desired state and running state. If", "commid": "kubernetes_pr_125776"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-01221639ca87beb4d58486db98fdd31e7eab9aeb213cb02b235da5cb2047e034", "query": "pull-kubernetes-unit TestStoreListResourceVersion in seems like July 7th 2024: ! Don't know, here is the log: No response /sig\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\nSee also\n/sig etcd\n/assign /cc\nBisected this to cc\nI'm not sure if this is the proper way to fix it, but setting a limit in the ListOptions deflakes the test. The flakiness comes from the fact that the cache is sometimes not initialized in time which causes it to return a \"too many requests\". Perhaps in tests we could wait till the cache is ready in order to proceed?\nRight, setting a limit when a resource version is set would delegate the list to etcd when cache is not initialized based on the KEP description. It is due to this type of request is not that costly to etcd. Looks like it is exactly how the wait cache ready is in See below So I think we should implement this same thing in when initializing the .\nAgree - waiting for cacher to be initialized when creating it here is a better fix for it:\nI thought about this as well, but waiting on is not possible outside of the cacher module, since it is a private field. I'm thinking to either add an option to cacherstorage.Config and make wait or add a new public method to . Do you guys have a better idea? Thanks.\nExposing Wait(context) method sounds fine\nI have pushed the changes we discussed. Thank you all for your guidance.", "positive_passages": [{"docid": "doc-en-kubernetes-17f0da01b2e4ac0bf482dae578d7e6db4e5192b139cc341a84bd291fe20d0fce", "text": "if err != nil { t.Fatalf(\"Couldn't create cacher: %v\", err) } <ins> if utilfeature.DefaultFeatureGate.Enabled(features.ResilientWatchCacheInitialization) { // The tests assume that Get/GetList/Watch calls shouldn't fail. // However, 429 error can now be returned if watchcache is under initialization. // To avoid rewriting all tests, we wait for watchcache to initialize. if err := cacher.Wait(context.Background()); err != nil { t.Fatal(err) } } </ins> d := destroyFunc s = cacher destroyFunc = func() {", "commid": "kubernetes_pr_125450"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-01221639ca87beb4d58486db98fdd31e7eab9aeb213cb02b235da5cb2047e034", "query": "pull-kubernetes-unit TestStoreListResourceVersion in seems like July 7th 2024: ! Don't know, here is the log: No response /sig\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\nSee also\n/sig etcd\n/assign /cc\nBisected this to cc\nI'm not sure if this is the proper way to fix it, but setting a limit in the ListOptions deflakes the test. The flakiness comes from the fact that the cache is sometimes not initialized in time which causes it to return a \"too many requests\". Perhaps in tests we could wait till the cache is ready in order to proceed?\nRight, setting a limit when a resource version is set would delegate the list to etcd when cache is not initialized based on the KEP description. It is due to this type of request is not that costly to etcd. Looks like it is exactly how the wait cache ready is in See below So I think we should implement this same thing in when initializing the .\nAgree - waiting for cacher to be initialized when creating it here is a better fix for it:\nI thought about this as well, but waiting on is not possible outside of the cacher module, since it is a private field. I'm thinking to either add an option to cacherstorage.Config and make wait or add a new public method to . Do you guys have a better idea? Thanks.\nExposing Wait(context) method sounds fine\nI have pushed the changes we discussed. Thank you all for your guidance.", "positive_passages": [{"docid": "doc-en-kubernetes-0c613eaa0b7b23ac4311758e54dd174bafaa91dddfd830a3a1e77649bbc0487d", "text": "return nil } <ins> // Wait blocks until the cacher is Ready or Stopped, it returns an error if Stopped. func (c *Cacher) Wait(ctx context.Context) error { return c.ready.wait(ctx) } </ins> // errWatcher implements watch.Interface to return a single error type errWatcher struct { result chan watch.Event", "commid": "kubernetes_pr_125450"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-01221639ca87beb4d58486db98fdd31e7eab9aeb213cb02b235da5cb2047e034", "query": "pull-kubernetes-unit TestStoreListResourceVersion in seems like July 7th 2024: ! Don't know, here is the log: No response /sig\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\nSee also\n/sig etcd\n/assign /cc\nBisected this to cc\nI'm not sure if this is the proper way to fix it, but setting a limit in the ListOptions deflakes the test. The flakiness comes from the fact that the cache is sometimes not initialized in time which causes it to return a \"too many requests\". Perhaps in tests we could wait till the cache is ready in order to proceed?\nRight, setting a limit when a resource version is set would delegate the list to etcd when cache is not initialized based on the KEP description. It is due to this type of request is not that costly to etcd. Looks like it is exactly how the wait cache ready is in See below So I think we should implement this same thing in when initializing the .\nAgree - waiting for cacher to be initialized when creating it here is a better fix for it:\nI thought about this as well, but waiting on is not possible outside of the cacher module, since it is a private field. I'm thinking to either add an option to cacherstorage.Config and make wait or add a new public method to . Do you guys have a better idea? Thanks.\nExposing Wait(context) method sounds fine\nI have pushed the changes we discussed. Thank you all for your guidance.", "positive_passages": [{"docid": "doc-en-kubernetes-874a37a08f94b7f533ef1311a6539973b6439f55f661cf3d294eda7711a37455", "text": "if utilfeature.DefaultFeatureGate.Enabled(features.ResilientWatchCacheInitialization) { // The tests assume that Get/GetList/Watch calls shouldn't fail. // However, 429 error can now be returned if watchcache is under initialization. <del> // To avoid rewriting all tests, we wait for watcache to initialize. if err := cacher.ready.wait(ctx); err != nil { </del> <ins> // To avoid rewriting all tests, we wait for watchcache to initialize. if err := cacher.Wait(ctx); err != nil { </ins> t.Fatal(err) } }", "commid": "kubernetes_pr_125450"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-01221639ca87beb4d58486db98fdd31e7eab9aeb213cb02b235da5cb2047e034", "query": "pull-kubernetes-unit TestStoreListResourceVersion in seems like July 7th 2024: ! Don't know, here is the log: No response /sig\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig api-machinery\nSee also\n/sig etcd\n/assign /cc\nBisected this to cc\nI'm not sure if this is the proper way to fix it, but setting a limit in the ListOptions deflakes the test. The flakiness comes from the fact that the cache is sometimes not initialized in time which causes it to return a \"too many requests\". Perhaps in tests we could wait till the cache is ready in order to proceed?\nRight, setting a limit when a resource version is set would delegate the list to etcd when cache is not initialized based on the KEP description. It is due to this type of request is not that costly to etcd. Looks like it is exactly how the wait cache ready is in See below So I think we should implement this same thing in when initializing the .\nAgree - waiting for cacher to be initialized when creating it here is a better fix for it:\nI thought about this as well, but waiting on is not possible outside of the cacher module, since it is a private field. I'm thinking to either add an option to cacherstorage.Config and make wait or add a new public method to . Do you guys have a better idea? Thanks.\nExposing Wait(context) method sounds fine\nI have pushed the changes we discussed. Thank you all for your guidance.", "positive_passages": [{"docid": "doc-en-kubernetes-c6297158d2286fac93f67459d58047b5ec80f8e64453277a398ddec31e01eba5", "text": "// The tests assume that Get/GetList/Watch calls shouldn't fail. // However, 429 error can now be returned if watchcache is under initialization. // To avoid rewriting all tests, we wait for watcache to initialize. <del> if err := cacher.ready.wait(context.Background()); err != nil { </del> <ins> if err := cacher.Wait(context.Background()); err != nil { </ins> return nil, storage.APIObjectVersioner{}, err } }", "commid": "kubernetes_pr_125450"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e1c6f7407b346df6fb6212f23a2f930e04198e198bb03b9cff5041967802082d", "query": "The PR above moved everything related to into because that was where most of the code already was, but didn't renamed the files to avoid a larger diff and merge conflicts. Once is merged, we can do the renaming. Code clarity. /sig node\n/triage accepted /priority important-soon\n/assign\na PR can be created for this now.\nwill do", "positive_passages": [{"docid": "doc-en-kubernetes-16b5d66e99ca662616cef7bcb96f1ab6f214d1f1bdabfb8f5000c6ada3737d57", "text": "<del> /* Copyright 2022 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( \"context\" \"errors\" \"fmt\" \"net\" \"sync\" \"time\" \"google.golang.org/grpc\" \"google.golang.org/grpc/connectivity\" \"google.golang.org/grpc/credentials/insecure\" utilversion \"k8s.io/apimachinery/pkg/util/version\" \"k8s.io/klog/v2\" drapb \"k8s.io/kubelet/pkg/apis/dra/v1alpha4\" ) // NewDRAPluginClient returns a wrapper around those gRPC methods of a DRA // driver kubelet plugin which need to be called by kubelet. The wrapper // handles gRPC connection management and logging. Connections are reused // across different NewDRAPluginClient calls. func NewDRAPluginClient(pluginName string) (*Plugin, error) { if pluginName == \"\" { return nil, fmt.Errorf(\"plugin name is empty\") } existingPlugin := draPlugins.get(pluginName) if existingPlugin == nil { return nil, fmt.Errorf(\"plugin name %s not found in the list of registered DRA plugins\", pluginName) } return existingPlugin, nil } type Plugin struct { backgroundCtx context.Context cancel        func(cause error) mutex                   sync.Mutex conn                    *grpc.ClientConn endpoint                string highestSupportedVersion *utilversion.Version clientCallTimeout       time.Duration } func (p *Plugin) getOrCreateGRPCConn() (*grpc.ClientConn, error) { p.mutex.Lock() defer p.mutex.Unlock() if p.conn != nil { return p.conn, nil } ctx := p.backgroundCtx logger := klog.FromContext(ctx) network := \"unix\" logger.V(4).Info(\"Creating new gRPC connection\", \"protocol\", network, \"endpoint\", p.endpoint) // grpc.Dial is deprecated. grpc.NewClient should be used instead. // For now this gets ignored because this function is meant to establish // the connection, with the one second timeout below. Perhaps that // approach should be reconsidered? //nolint:staticcheck conn, err := grpc.Dial( p.endpoint, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(func(ctx context.Context, target string) (net.Conn, error) { return (&net.Dialer{}).DialContext(ctx, network, target) }), ) if err != nil { return nil, err } ctx, cancel := context.WithTimeout(context.Background(), time.Second) defer cancel() if ok := conn.WaitForStateChange(ctx, connectivity.Connecting); !ok { return nil, errors.New(\"timed out waiting for gRPC connection to be ready\") } p.conn = conn return p.conn, nil } func (p *Plugin) NodePrepareResources( ctx context.Context, req *drapb.NodePrepareResourcesRequest, opts ...grpc.CallOption, ) (*drapb.NodePrepareResourcesResponse, error) { logger := klog.FromContext(ctx) logger.V(4).Info(\"Calling NodePrepareResources rpc\", \"request\", req) conn, err := p.getOrCreateGRPCConn() if err != nil { return nil, err } ctx, cancel := context.WithTimeout(ctx, p.clientCallTimeout) defer cancel() nodeClient := drapb.NewNodeClient(conn) response, err := nodeClient.NodePrepareResources(ctx, req) logger.V(4).Info(\"Done calling NodePrepareResources rpc\", \"response\", response, \"err\", err) return response, err } func (p *Plugin) NodeUnprepareResources( ctx context.Context, req *drapb.NodeUnprepareResourcesRequest, opts ...grpc.CallOption, ) (*drapb.NodeUnprepareResourcesResponse, error) { logger := klog.FromContext(ctx) logger.V(4).Info(\"Calling NodeUnprepareResource rpc\", \"request\", req) conn, err := p.getOrCreateGRPCConn() if err != nil { return nil, err } ctx, cancel := context.WithTimeout(ctx, p.clientCallTimeout) defer cancel() nodeClient := drapb.NewNodeClient(conn) response, err := nodeClient.NodeUnprepareResources(ctx, req) logger.V(4).Info(\"Done calling NodeUnprepareResources rpc\", \"response\", response, \"err\", err) return response, err } </del>", "commid": "kubernetes_pr_126834"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e1c6f7407b346df6fb6212f23a2f930e04198e198bb03b9cff5041967802082d", "query": "The PR above moved everything related to into because that was where most of the code already was, but didn't renamed the files to avoid a larger diff and merge conflicts. Once is merged, we can do the renaming. Code clarity. /sig node\n/triage accepted /priority important-soon\n/assign\na PR can be created for this now.\nwill do", "positive_passages": [{"docid": "doc-en-kubernetes-825f3807cfa161a4ddffe2e8ab04417734cc47ff6f0541094e56f197b9659dba", "text": "<del> /* Copyright 2023 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( \"context\" \"fmt\" \"net\" \"os\" \"path/filepath\" \"sync\" \"testing\" \"github.com/stretchr/testify/assert\" \"google.golang.org/grpc\" drapb \"k8s.io/kubelet/pkg/apis/dra/v1alpha4\" \"k8s.io/kubernetes/test/utils/ktesting\" ) const ( v1alpha4Version = \"v1alpha4\" ) type fakeV1alpha4GRPCServer struct { drapb.UnimplementedNodeServer } var _ drapb.NodeServer = &fakeV1alpha4GRPCServer{} func (f *fakeV1alpha4GRPCServer) NodePrepareResources(ctx context.Context, in *drapb.NodePrepareResourcesRequest) (*drapb.NodePrepareResourcesResponse, error) { return &drapb.NodePrepareResourcesResponse{Claims: map[string]*drapb.NodePrepareResourceResponse{\"claim-uid\": { Devices: []*drapb.Device{ { RequestNames: []string{\"test-request\"}, CDIDeviceIDs: []string{\"test-cdi-id\"}, }, }, }}}, nil } func (f *fakeV1alpha4GRPCServer) NodeUnprepareResources(ctx context.Context, in *drapb.NodeUnprepareResourcesRequest) (*drapb.NodeUnprepareResourcesResponse, error) { return &drapb.NodeUnprepareResourcesResponse{}, nil } type tearDown func() func setupFakeGRPCServer(version string) (string, tearDown, error) { p, err := os.MkdirTemp(\"\", \"dra_plugin\") if err != nil { return \"\", nil, err } closeCh := make(chan struct{}) addr := filepath.Join(p, \"server.sock\") teardown := func() { close(closeCh) os.RemoveAll(addr) } listener, err := net.Listen(\"unix\", addr) if err != nil { teardown() return \"\", nil, err } s := grpc.NewServer() switch version { case v1alpha4Version: fakeGRPCServer := &fakeV1alpha4GRPCServer{} drapb.RegisterNodeServer(s, fakeGRPCServer) default: return \"\", nil, fmt.Errorf(\"unsupported version: %s\", version) } go func() { go s.Serve(listener) <-closeCh s.GracefulStop() }() return addr, teardown, nil } func TestGRPCConnIsReused(t *testing.T) { tCtx := ktesting.Init(t) addr, teardown, err := setupFakeGRPCServer(v1alpha4Version) if err != nil { t.Fatal(err) } defer teardown() reusedConns := make(map[*grpc.ClientConn]int) wg := sync.WaitGroup{} m := sync.Mutex{} p := &Plugin{ backgroundCtx:     tCtx, endpoint:          addr, clientCallTimeout: defaultClientCallTimeout, } conn, err := p.getOrCreateGRPCConn() defer func() { err := conn.Close() if err != nil { t.Error(err) } }() if err != nil { t.Fatal(err) } // ensure the plugin we are using is registered draPlugins.add(\"dummy-plugin\", p) defer draPlugins.delete(\"dummy-plugin\") // we call `NodePrepareResource` 2 times and check whether a new connection is created or the same is reused for i := 0; i < 2; i++ { wg.Add(1) go func() { defer wg.Done() client, err := NewDRAPluginClient(\"dummy-plugin\") if err != nil { t.Error(err) return } req := &drapb.NodePrepareResourcesRequest{ Claims: []*drapb.Claim{ { Namespace: \"dummy-namespace\", UID:       \"dummy-uid\", Name:      \"dummy-claim\", }, }, } _, err = client.NodePrepareResources(tCtx, req) assert.NoError(t, err) client.mutex.Lock() conn := client.conn client.mutex.Unlock() m.Lock() defer m.Unlock() reusedConns[conn]++ }() } wg.Wait() // We should have only one entry otherwise it means another gRPC connection has been created if len(reusedConns) != 1 { t.Errorf(\"expected length to be 1 but got %d\", len(reusedConns)) } if counter, ok := reusedConns[conn]; ok && counter != 2 { t.Errorf(\"expected counter to be 2 but got %d\", counter) } } func TestNewDRAPluginClient(t *testing.T) { for _, test := range []struct { description string setup       func(string) tearDown pluginName  string shouldError bool }{ { description: \"plugin name is empty\", setup: func(_ string) tearDown { return func() {} }, pluginName:  \"\", shouldError: true, }, { description: \"plugin name not found in the list\", setup: func(_ string) tearDown { return func() {} }, pluginName:  \"plugin-name-not-found-in-the-list\", shouldError: true, }, { description: \"plugin exists\", setup: func(name string) tearDown { draPlugins.add(name, &Plugin{}) return func() { draPlugins.delete(name) } }, pluginName: \"dummy-plugin\", }, } { t.Run(test.description, func(t *testing.T) { teardown := test.setup(test.pluginName) defer teardown() client, err := NewDRAPluginClient(test.pluginName) if test.shouldError { assert.Nil(t, client) assert.Error(t, err) } else { assert.NotNil(t, client) assert.Nil(t, err) } }) } } func TestNodeUnprepareResources(t *testing.T) { for _, test := range []struct { description   string serverSetup   func(string) (string, tearDown, error) serverVersion string request       *drapb.NodeUnprepareResourcesRequest }{ { description:   \"server supports v1alpha4\", serverSetup:   setupFakeGRPCServer, serverVersion: v1alpha4Version, request:       &drapb.NodeUnprepareResourcesRequest{}, }, } { t.Run(test.description, func(t *testing.T) { tCtx := ktesting.Init(t) addr, teardown, err := setupFakeGRPCServer(test.serverVersion) if err != nil { t.Fatal(err) } defer teardown() p := &Plugin{ backgroundCtx:     tCtx, endpoint:          addr, clientCallTimeout: defaultClientCallTimeout, } conn, err := p.getOrCreateGRPCConn() defer func() { err := conn.Close() if err != nil { t.Error(err) } }() if err != nil { t.Fatal(err) } draPlugins.add(\"dummy-plugin\", p) defer draPlugins.delete(\"dummy-plugin\") client, err := NewDRAPluginClient(\"dummy-plugin\") if err != nil { t.Fatal(err) } _, err = client.NodeUnprepareResources(tCtx, test.request) if err != nil { t.Fatal(err) } }) } } </del>", "commid": "kubernetes_pr_126834"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e1c6f7407b346df6fb6212f23a2f930e04198e198bb03b9cff5041967802082d", "query": "The PR above moved everything related to into because that was where most of the code already was, but didn't renamed the files to avoid a larger diff and merge conflicts. Once is merged, we can do the renaming. Code clarity. /sig node\n/triage accepted /priority important-soon\n/assign\na PR can be created for this now.\nwill do", "positive_passages": [{"docid": "doc-en-kubernetes-eb48251297b2ad77b0249236beb9681e9436ecfca440d7d8e68888932ae9779d", "text": "\"context\" \"errors\" \"fmt\" <ins> \"net\" \"sync\" </ins> \"time\" <del> v1 \"k8s.io/api/core/v1\" resourceapi \"k8s.io/api/resource/v1alpha3\" apierrors \"k8s.io/apimachinery/pkg/api/errors\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/fields\" </del> <ins> \"google.golang.org/grpc\" \"google.golang.org/grpc/connectivity\" \"google.golang.org/grpc/credentials/insecure\" </ins> utilversion \"k8s.io/apimachinery/pkg/util/version\" <del> \"k8s.io/apimachinery/pkg/util/wait\" \"k8s.io/client-go/kubernetes\" </del> \"k8s.io/klog/v2\" <del> \"k8s.io/kubernetes/pkg/kubelet/pluginmanager/cache\" </del> <ins> drapb \"k8s.io/kubelet/pkg/apis/dra/v1alpha4\" </ins> ) <del> // defaultClientCallTimeout is the default amount of time that a DRA driver has // to respond to any of the gRPC calls. kubelet uses this value by passing nil // to RegisterPlugin. Some tests use a different, usually shorter timeout to // speed up testing. // // This is half of the kubelet retry period (according to // https://github.com/kubernetes/kubernetes/commit/0449cef8fd5217d394c5cd331d852bd50983e6b3). const defaultClientCallTimeout = 45 * time.Second // RegistrationHandler is the handler which is fed to the pluginwatcher API. type RegistrationHandler struct { // backgroundCtx is used for all future activities of the handler. // This is necessary because it implements APIs which don't // provide a context. backgroundCtx context.Context kubeClient    kubernetes.Interface getNode       func() (*v1.Node, error) } </del> <ins> // NewDRAPluginClient returns a wrapper around those gRPC methods of a DRA // driver kubelet plugin which need to be called by kubelet. The wrapper // handles gRPC connection management and logging. Connections are reused // across different NewDRAPluginClient calls. func NewDRAPluginClient(pluginName string) (*Plugin, error) { if pluginName == \"\" { return nil, fmt.Errorf(\"plugin name is empty\") } </ins> <del> var _ cache.PluginHandler = &RegistrationHandler{} // NewPluginHandler returns new registration handler. // // Must only be called once per process because it manages global state. // If a kubeClient is provided, then it synchronizes ResourceSlices // with the resource information provided by plugins. func NewRegistrationHandler(kubeClient kubernetes.Interface, getNode func() (*v1.Node, error)) *RegistrationHandler { handler := &RegistrationHandler{ // The context and thus logger should come from the caller. backgroundCtx: klog.NewContext(context.TODO(), klog.LoggerWithName(klog.TODO(), \"DRA registration handler\")), kubeClient:    kubeClient, getNode:       getNode, </del> <ins> existingPlugin := draPlugins.get(pluginName) if existingPlugin == nil { return nil, fmt.Errorf(\"plugin name %s not found in the list of registered DRA plugins\", pluginName) </ins> } <del> // When kubelet starts up, no DRA driver has registered yet. None of // the drivers are usable until they come back, which might not happen // at all. Therefore it is better to not advertise any local resources // because pods could get stuck on the node waiting for the driver // to start up. // // This has to run in the background. go handler.wipeResourceSlices(\"\") </del> <ins> return existingPlugin, nil } type Plugin struct { backgroundCtx context.Context cancel        func(cause error) </ins> <del> return handler </del> <ins> mutex                   sync.Mutex conn                    *grpc.ClientConn endpoint                string highestSupportedVersion *utilversion.Version clientCallTimeout       time.Duration </ins> } <del> // wipeResourceSlices deletes ResourceSlices of the node, optionally just for a specific driver. func (h *RegistrationHandler) wipeResourceSlices(driver string) { if h.kubeClient == nil { return } ctx := h.backgroundCtx logger := klog.FromContext(ctx) </del> <ins> func (p *Plugin) getOrCreateGRPCConn() (*grpc.ClientConn, error) { p.mutex.Lock() defer p.mutex.Unlock() </ins> <del> backoff := wait.Backoff{ Duration: time.Second, Factor:   2, Jitter:   0.2, Cap:      5 * time.Minute, Steps:    100, </del> <ins> if p.conn != nil { return p.conn, nil </ins> } <del> // Error logging is done inside the loop. Context cancellation doesn't get logged. _ = wait.ExponentialBackoffWithContext(ctx, backoff, func(ctx context.Context) (bool, error) { node, err := h.getNode() if apierrors.IsNotFound(err) { return false, nil } if err != nil { logger.Error(err, \"Unexpected error checking for node\") return false, nil } fieldSelector := fields.Set{resourceapi.ResourceSliceSelectorNodeName: node.Name} if driver != \"\" { fieldSelector[resourceapi.ResourceSliceSelectorDriver] = driver } err = h.kubeClient.ResourceV1alpha3().ResourceSlices().DeleteCollection(ctx, metav1.DeleteOptions{}, metav1.ListOptions{FieldSelector: fieldSelector.String()}) switch { case err == nil: logger.V(3).Info(\"Deleted ResourceSlices\", \"fieldSelector\", fieldSelector) return true, nil case apierrors.IsUnauthorized(err): // This can happen while kubelet is still figuring out // its credentials. logger.V(5).Info(\"Deleting ResourceSlice failed, retrying\", \"fieldSelector\", fieldSelector, \"err\", err) return false, nil default: // Log and retry for other errors. logger.V(3).Info(\"Deleting ResourceSlice failed, retrying\", \"fieldSelector\", fieldSelector, \"err\", err) return false, nil } }) } // RegisterPlugin is called when a plugin can be registered. func (h *RegistrationHandler) RegisterPlugin(pluginName string, endpoint string, versions []string, pluginClientTimeout *time.Duration) error { // Prepare a context with its own logger for the plugin. // // The lifecycle of the plugin's background activities is tied to our // root context, so canceling that will also cancel the plugin. // // The logger injects the plugin name as additional value // into all log output related to the plugin. ctx := h.backgroundCtx </del> <ins> ctx := p.backgroundCtx </ins> logger := klog.FromContext(ctx) <del> logger = klog.LoggerWithValues(logger, \"pluginName\", pluginName) ctx = klog.NewContext(ctx, logger) logger.V(3).Info(\"Register new DRA plugin\", \"endpoint\", endpoint) highestSupportedVersion, err := h.validateVersions(pluginName, versions) </del> <ins> network := \"unix\" logger.V(4).Info(\"Creating new gRPC connection\", \"protocol\", network, \"endpoint\", p.endpoint) // grpc.Dial is deprecated. grpc.NewClient should be used instead. // For now this gets ignored because this function is meant to establish // the connection, with the one second timeout below. Perhaps that // approach should be reconsidered? //nolint:staticcheck conn, err := grpc.Dial( p.endpoint, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(func(ctx context.Context, target string) (net.Conn, error) { return (&net.Dialer{}).DialContext(ctx, network, target) }), ) </ins> if err != nil { <del> return fmt.Errorf(\"version check of plugin %s failed: %w\", pluginName, err) } var timeout time.Duration if pluginClientTimeout == nil { timeout = defaultClientCallTimeout } else { timeout = *pluginClientTimeout </del> <ins> return nil, err </ins> } <del> ctx, cancel := context.WithCancelCause(ctx) </del> <ins> ctx, cancel := context.WithTimeout(context.Background(), time.Second) defer cancel() </ins> <del> pluginInstance := &Plugin{ backgroundCtx:           ctx, cancel:                  cancel, conn:                    nil, endpoint:                endpoint, highestSupportedVersion: highestSupportedVersion, clientCallTimeout:       timeout, </del> <ins> if ok := conn.WaitForStateChange(ctx, connectivity.Connecting); !ok { return nil, errors.New(\"timed out waiting for gRPC connection to be ready\") </ins> } <del> // Storing endpoint of newly registered DRA Plugin into the map, where plugin name will be the key // all other DRA components will be able to get the actual socket of DRA plugins by its name. if draPlugins.add(pluginName, pluginInstance) { logger.V(1).Info(\"Already registered, previous plugin was replaced\") } return nil </del> <ins> p.conn = conn return p.conn, nil </ins> } <del> func (h *RegistrationHandler) validateVersions( pluginName string, versions []string, ) (*utilversion.Version, error) { if len(versions) == 0 { return nil, errors.New(\"empty list for supported versions\") } </del> <ins> func (p *Plugin) NodePrepareResources( ctx context.Context, req *drapb.NodePrepareResourcesRequest, opts ...grpc.CallOption, ) (*drapb.NodePrepareResourcesResponse, error) { logger := klog.FromContext(ctx) logger.V(4).Info(\"Calling NodePrepareResources rpc\", \"request\", req) </ins> <del> // Validate version newPluginHighestVersion, err := utilversion.HighestSupportedVersion(versions) </del> <ins> conn, err := p.getOrCreateGRPCConn() </ins> if err != nil { <del> // HighestSupportedVersion includes the list of versions in its error // if relevant, no need to repeat it here. return nil, fmt.Errorf(\"none of the versions are supported: %w\", err) } existingPlugin := draPlugins.get(pluginName) if existingPlugin == nil { return newPluginHighestVersion, nil </del> <ins> return nil, err </ins> } <del> if existingPlugin.highestSupportedVersion.LessThan(newPluginHighestVersion) { return newPluginHighestVersion, nil } return nil, fmt.Errorf(\"another plugin instance is already registered with a higher supported version: %q < %q\", newPluginHighestVersion, existingPlugin.highestSupportedVersion) } // DeRegisterPlugin is called when a plugin has removed its socket, // signaling it is no longer available. func (h *RegistrationHandler) DeRegisterPlugin(pluginName string) { if p := draPlugins.delete(pluginName); p != nil { logger := klog.FromContext(p.backgroundCtx) logger.V(3).Info(\"Deregister DRA plugin\", \"endpoint\", p.endpoint) // Clean up the ResourceSlices for the deleted Plugin since it // may have died without doing so itself and might never come // back. go h.wipeResourceSlices(pluginName) return } </del> <ins> ctx, cancel := context.WithTimeout(ctx, p.clientCallTimeout) defer cancel() </ins> <del> logger := klog.FromContext(h.backgroundCtx) logger.V(3).Info(\"Deregister DRA plugin not necessary, was already removed\") </del> <ins> nodeClient := drapb.NewNodeClient(conn) response, err := nodeClient.NodePrepareResources(ctx, req) logger.V(4).Info(\"Done calling NodePrepareResources rpc\", \"response\", response, \"err\", err) return response, err </ins> } <del> // ValidatePlugin is called by kubelet's plugin watcher upon detection // of a new registration socket opened by DRA plugin. func (h *RegistrationHandler) ValidatePlugin(pluginName string, endpoint string, versions []string) error { _, err := h.validateVersions(pluginName, versions) </del> <ins> func (p *Plugin) NodeUnprepareResources( ctx context.Context, req *drapb.NodeUnprepareResourcesRequest, opts ...grpc.CallOption, ) (*drapb.NodeUnprepareResourcesResponse, error) { logger := klog.FromContext(ctx) logger.V(4).Info(\"Calling NodeUnprepareResource rpc\", \"request\", req) conn, err := p.getOrCreateGRPCConn() </ins> if err != nil { <del> return fmt.Errorf(\"invalid versions of plugin %s: %w\", pluginName, err) </del> <ins> return nil, err </ins> } <del> return err </del> <ins> ctx, cancel := context.WithTimeout(ctx, p.clientCallTimeout) defer cancel() nodeClient := drapb.NewNodeClient(conn) response, err := nodeClient.NodeUnprepareResources(ctx, req) logger.V(4).Info(\"Done calling NodeUnprepareResources rpc\", \"response\", response, \"err\", err) return response, err </ins> }", "commid": "kubernetes_pr_126834"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e1c6f7407b346df6fb6212f23a2f930e04198e198bb03b9cff5041967802082d", "query": "The PR above moved everything related to into because that was where most of the code already was, but didn't renamed the files to avoid a larger diff and merge conflicts. Once is merged, we can do the renaming. Code clarity. /sig node\n/triage accepted /priority important-soon\n/assign\na PR can be created for this now.\nwill do", "positive_passages": [{"docid": "doc-en-kubernetes-48325ec8ae577dc508542ea0245f810885ec945d7172bd12a2cc78ebdd05489d", "text": "package plugin import ( <ins> \"context\" \"fmt\" \"net\" \"os\" \"path/filepath\" \"sync\" </ins> \"testing\" \"github.com/stretchr/testify/assert\" <del> v1 \"k8s.io/api/core/v1\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" </del> <ins> \"google.golang.org/grpc\" drapb \"k8s.io/kubelet/pkg/apis/dra/v1alpha4\" \"k8s.io/kubernetes/test/utils/ktesting\" </ins> ) <del> func getFakeNode() (*v1.Node, error) { return &v1.Node{ObjectMeta: metav1.ObjectMeta{Name: \"worker\"}}, nil </del> <ins> const ( v1alpha4Version = \"v1alpha4\" ) type fakeV1alpha4GRPCServer struct { drapb.UnimplementedNodeServer } var _ drapb.NodeServer = &fakeV1alpha4GRPCServer{} func (f *fakeV1alpha4GRPCServer) NodePrepareResources(ctx context.Context, in *drapb.NodePrepareResourcesRequest) (*drapb.NodePrepareResourcesResponse, error) { return &drapb.NodePrepareResourcesResponse{Claims: map[string]*drapb.NodePrepareResourceResponse{\"claim-uid\": { Devices: []*drapb.Device{ { RequestNames: []string{\"test-request\"}, CDIDeviceIDs: []string{\"test-cdi-id\"}, }, }, }}}, nil } func (f *fakeV1alpha4GRPCServer) NodeUnprepareResources(ctx context.Context, in *drapb.NodeUnprepareResourcesRequest) (*drapb.NodeUnprepareResourcesResponse, error) { return &drapb.NodeUnprepareResourcesResponse{}, nil } type tearDown func() func setupFakeGRPCServer(version string) (string, tearDown, error) { p, err := os.MkdirTemp(\"\", \"dra_plugin\") if err != nil { return \"\", nil, err } closeCh := make(chan struct{}) addr := filepath.Join(p, \"server.sock\") teardown := func() { close(closeCh) if err := os.RemoveAll(addr); err != nil { panic(err) } } listener, err := net.Listen(\"unix\", addr) if err != nil { teardown() return \"\", nil, err } s := grpc.NewServer() switch version { case v1alpha4Version: fakeGRPCServer := &fakeV1alpha4GRPCServer{} drapb.RegisterNodeServer(s, fakeGRPCServer) default: return \"\", nil, fmt.Errorf(\"unsupported version: %s\", version) } go func() { go func() { if err := s.Serve(listener); err != nil { panic(err) } }() <-closeCh s.GracefulStop() }() return addr, teardown, nil </ins> } <del> func TestRegistrationHandler_ValidatePlugin(t *testing.T) { newRegistrationHandler := func() *RegistrationHandler { return NewRegistrationHandler(nil, getFakeNode) </del> <ins> func TestGRPCConnIsReused(t *testing.T) { tCtx := ktesting.Init(t) addr, teardown, err := setupFakeGRPCServer(v1alpha4Version) if err != nil { t.Fatal(err) } defer teardown() reusedConns := make(map[*grpc.ClientConn]int) wg := sync.WaitGroup{} m := sync.Mutex{} p := &Plugin{ backgroundCtx:     tCtx, endpoint:          addr, clientCallTimeout: defaultClientCallTimeout, </ins> } <ins> conn, err := p.getOrCreateGRPCConn() defer func() { err := conn.Close() if err != nil { t.Error(err) } }() if err != nil { t.Fatal(err) } // ensure the plugin we are using is registered draPlugins.add(\"dummy-plugin\", p) defer draPlugins.delete(\"dummy-plugin\") // we call `NodePrepareResource` 2 times and check whether a new connection is created or the same is reused for i := 0; i < 2; i++ { wg.Add(1) go func() { defer wg.Done() client, err := NewDRAPluginClient(\"dummy-plugin\") if err != nil { t.Error(err) return } req := &drapb.NodePrepareResourcesRequest{ Claims: []*drapb.Claim{ { Namespace: \"dummy-namespace\", UID:       \"dummy-uid\", Name:      \"dummy-claim\", }, }, } _, err = client.NodePrepareResources(tCtx, req) assert.NoError(t, err) client.mutex.Lock() conn := client.conn client.mutex.Unlock() m.Lock() defer m.Unlock() reusedConns[conn]++ }() } wg.Wait() // We should have only one entry otherwise it means another gRPC connection has been created if len(reusedConns) != 1 { t.Errorf(\"expected length to be 1 but got %d\", len(reusedConns)) } if counter, ok := reusedConns[conn]; ok && counter != 2 { t.Errorf(\"expected counter to be 2 but got %d\", counter) } } func TestNewDRAPluginClient(t *testing.T) { </ins> for _, test := range []struct { description string <del> handler     func() *RegistrationHandler </del> <ins> setup       func(string) tearDown </ins> pluginName  string <del> endpoint    string versions    []string </del> shouldError bool }{ { <del> description: \"no versions provided\", handler:     newRegistrationHandler, </del> <ins> description: \"plugin name is empty\", setup: func(_ string) tearDown { return func() {} }, pluginName:  \"\", </ins> shouldError: true, }, { <del> description: \"unsupported version\", handler:     newRegistrationHandler, versions:    []string{\"v2.0.0\"}, </del> <ins> description: \"plugin name not found in the list\", setup: func(_ string) tearDown { return func() {} }, pluginName:  \"plugin-name-not-found-in-the-list\", </ins> shouldError: true, }, { <del> description: \"plugin already registered with a higher supported version\", handler: func() *RegistrationHandler { handler := newRegistrationHandler() if err := handler.RegisterPlugin(\"this-plugin-already-exists-and-has-a-long-name-so-it-doesnt-collide\", \"\", []string{\"v1.1.0\"}, nil); err != nil { t.Fatal(err) </del> <ins> description: \"plugin exists\", setup: func(name string) tearDown { draPlugins.add(name, &Plugin{}) return func() { draPlugins.delete(name) </ins> } <del> return handler </del> }, <del> pluginName:  \"this-plugin-already-exists-and-has-a-long-name-so-it-doesnt-collide\", versions:    []string{\"v1.0.0\"}, shouldError: true, }, { description: \"should validate the plugin\", handler:     newRegistrationHandler, pluginName:  \"this-is-a-dummy-plugin-with-a-long-name-so-it-doesnt-collide\", versions:    []string{\"v1.3.0\"}, </del> <ins> pluginName: \"dummy-plugin\", </ins> }, } { t.Run(test.description, func(t *testing.T) { <del> handler := test.handler() err := handler.ValidatePlugin(test.pluginName, test.endpoint, test.versions) </del> <ins> teardown := test.setup(test.pluginName) defer teardown() client, err := NewDRAPluginClient(test.pluginName) </ins> if test.shouldError { <ins> assert.Nil(t, client) </ins> assert.Error(t, err) } else { <ins> assert.NotNil(t, client) </ins> assert.Nil(t, err) } }) } <ins> } </ins> <del> t.Cleanup(func() { handler := newRegistrationHandler() handler.DeRegisterPlugin(\"this-plugin-already-exists-and-has-a-long-name-so-it-doesnt-collide\") handler.DeRegisterPlugin(\"this-is-a-dummy-plugin-with-a-long-name-so-it-doesnt-collide\") }) </del> <ins> func TestNodeUnprepareResources(t *testing.T) { for _, test := range []struct { description   string serverSetup   func(string) (string, tearDown, error) serverVersion string request       *drapb.NodeUnprepareResourcesRequest }{ { description:   \"server supports v1alpha4\", serverSetup:   setupFakeGRPCServer, serverVersion: v1alpha4Version, request:       &drapb.NodeUnprepareResourcesRequest{}, }, } { t.Run(test.description, func(t *testing.T) { tCtx := ktesting.Init(t) addr, teardown, err := setupFakeGRPCServer(test.serverVersion) if err != nil { t.Fatal(err) } defer teardown() p := &Plugin{ backgroundCtx:     tCtx, endpoint:          addr, clientCallTimeout: defaultClientCallTimeout, } conn, err := p.getOrCreateGRPCConn() defer func() { err := conn.Close() if err != nil { t.Error(err) } }() if err != nil { t.Fatal(err) } draPlugins.add(\"dummy-plugin\", p) defer draPlugins.delete(\"dummy-plugin\") client, err := NewDRAPluginClient(\"dummy-plugin\") if err != nil { t.Fatal(err) } _, err = client.NodeUnprepareResources(tCtx, test.request) if err != nil { t.Fatal(err) } }) } </ins> }", "commid": "kubernetes_pr_126834"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e1c6f7407b346df6fb6212f23a2f930e04198e198bb03b9cff5041967802082d", "query": "The PR above moved everything related to into because that was where most of the code already was, but didn't renamed the files to avoid a larger diff and merge conflicts. Once is merged, we can do the renaming. Code clarity. /sig node\n/triage accepted /priority important-soon\n/assign\na PR can be created for this now.\nwill do", "positive_passages": [{"docid": "doc-en-kubernetes-e7a7689f8e666e1bfd07eca3018d01693bb66e01512f2c4539798dee01350a6f", "text": "<ins> /* Copyright 2022 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( \"context\" \"errors\" \"fmt\" \"time\" v1 \"k8s.io/api/core/v1\" resourceapi \"k8s.io/api/resource/v1alpha3\" apierrors \"k8s.io/apimachinery/pkg/api/errors\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/fields\" utilversion \"k8s.io/apimachinery/pkg/util/version\" \"k8s.io/apimachinery/pkg/util/wait\" \"k8s.io/client-go/kubernetes\" \"k8s.io/klog/v2\" \"k8s.io/kubernetes/pkg/kubelet/pluginmanager/cache\" ) // defaultClientCallTimeout is the default amount of time that a DRA driver has // to respond to any of the gRPC calls. kubelet uses this value by passing nil // to RegisterPlugin. Some tests use a different, usually shorter timeout to // speed up testing. // // This is half of the kubelet retry period (according to // https://github.com/kubernetes/kubernetes/commit/0449cef8fd5217d394c5cd331d852bd50983e6b3). const defaultClientCallTimeout = 45 * time.Second // RegistrationHandler is the handler which is fed to the pluginwatcher API. type RegistrationHandler struct { // backgroundCtx is used for all future activities of the handler. // This is necessary because it implements APIs which don't // provide a context. backgroundCtx context.Context kubeClient    kubernetes.Interface getNode       func() (*v1.Node, error) } var _ cache.PluginHandler = &RegistrationHandler{} // NewPluginHandler returns new registration handler. // // Must only be called once per process because it manages global state. // If a kubeClient is provided, then it synchronizes ResourceSlices // with the resource information provided by plugins. func NewRegistrationHandler(kubeClient kubernetes.Interface, getNode func() (*v1.Node, error)) *RegistrationHandler { handler := &RegistrationHandler{ // The context and thus logger should come from the caller. backgroundCtx: klog.NewContext(context.TODO(), klog.LoggerWithName(klog.TODO(), \"DRA registration handler\")), kubeClient:    kubeClient, getNode:       getNode, } // When kubelet starts up, no DRA driver has registered yet. None of // the drivers are usable until they come back, which might not happen // at all. Therefore it is better to not advertise any local resources // because pods could get stuck on the node waiting for the driver // to start up. // // This has to run in the background. go handler.wipeResourceSlices(\"\") return handler } // wipeResourceSlices deletes ResourceSlices of the node, optionally just for a specific driver. func (h *RegistrationHandler) wipeResourceSlices(driver string) { if h.kubeClient == nil { return } ctx := h.backgroundCtx logger := klog.FromContext(ctx) backoff := wait.Backoff{ Duration: time.Second, Factor:   2, Jitter:   0.2, Cap:      5 * time.Minute, Steps:    100, } // Error logging is done inside the loop. Context cancellation doesn't get logged. _ = wait.ExponentialBackoffWithContext(ctx, backoff, func(ctx context.Context) (bool, error) { node, err := h.getNode() if apierrors.IsNotFound(err) { return false, nil } if err != nil { logger.Error(err, \"Unexpected error checking for node\") return false, nil } fieldSelector := fields.Set{resourceapi.ResourceSliceSelectorNodeName: node.Name} if driver != \"\" { fieldSelector[resourceapi.ResourceSliceSelectorDriver] = driver } err = h.kubeClient.ResourceV1alpha3().ResourceSlices().DeleteCollection(ctx, metav1.DeleteOptions{}, metav1.ListOptions{FieldSelector: fieldSelector.String()}) switch { case err == nil: logger.V(3).Info(\"Deleted ResourceSlices\", \"fieldSelector\", fieldSelector) return true, nil case apierrors.IsUnauthorized(err): // This can happen while kubelet is still figuring out // its credentials. logger.V(5).Info(\"Deleting ResourceSlice failed, retrying\", \"fieldSelector\", fieldSelector, \"err\", err) return false, nil default: // Log and retry for other errors. logger.V(3).Info(\"Deleting ResourceSlice failed, retrying\", \"fieldSelector\", fieldSelector, \"err\", err) return false, nil } }) } // RegisterPlugin is called when a plugin can be registered. func (h *RegistrationHandler) RegisterPlugin(pluginName string, endpoint string, versions []string, pluginClientTimeout *time.Duration) error { // Prepare a context with its own logger for the plugin. // // The lifecycle of the plugin's background activities is tied to our // root context, so canceling that will also cancel the plugin. // // The logger injects the plugin name as additional value // into all log output related to the plugin. ctx := h.backgroundCtx logger := klog.FromContext(ctx) logger = klog.LoggerWithValues(logger, \"pluginName\", pluginName) ctx = klog.NewContext(ctx, logger) logger.V(3).Info(\"Register new DRA plugin\", \"endpoint\", endpoint) highestSupportedVersion, err := h.validateVersions(pluginName, versions) if err != nil { return fmt.Errorf(\"version check of plugin %s failed: %w\", pluginName, err) } var timeout time.Duration if pluginClientTimeout == nil { timeout = defaultClientCallTimeout } else { timeout = *pluginClientTimeout } ctx, cancel := context.WithCancelCause(ctx) pluginInstance := &Plugin{ backgroundCtx:           ctx, cancel:                  cancel, conn:                    nil, endpoint:                endpoint, highestSupportedVersion: highestSupportedVersion, clientCallTimeout:       timeout, } // Storing endpoint of newly registered DRA Plugin into the map, where plugin name will be the key // all other DRA components will be able to get the actual socket of DRA plugins by its name. if draPlugins.add(pluginName, pluginInstance) { logger.V(1).Info(\"Already registered, previous plugin was replaced\") } return nil } func (h *RegistrationHandler) validateVersions( pluginName string, versions []string, ) (*utilversion.Version, error) { if len(versions) == 0 { return nil, errors.New(\"empty list for supported versions\") } // Validate version newPluginHighestVersion, err := utilversion.HighestSupportedVersion(versions) if err != nil { // HighestSupportedVersion includes the list of versions in its error // if relevant, no need to repeat it here. return nil, fmt.Errorf(\"none of the versions are supported: %w\", err) } existingPlugin := draPlugins.get(pluginName) if existingPlugin == nil { return newPluginHighestVersion, nil } if existingPlugin.highestSupportedVersion.LessThan(newPluginHighestVersion) { return newPluginHighestVersion, nil } return nil, fmt.Errorf(\"another plugin instance is already registered with a higher supported version: %q < %q\", newPluginHighestVersion, existingPlugin.highestSupportedVersion) } // DeRegisterPlugin is called when a plugin has removed its socket, // signaling it is no longer available. func (h *RegistrationHandler) DeRegisterPlugin(pluginName string) { if p := draPlugins.delete(pluginName); p != nil { logger := klog.FromContext(p.backgroundCtx) logger.V(3).Info(\"Deregister DRA plugin\", \"endpoint\", p.endpoint) // Clean up the ResourceSlices for the deleted Plugin since it // may have died without doing so itself and might never come // back. go h.wipeResourceSlices(pluginName) return } logger := klog.FromContext(h.backgroundCtx) logger.V(3).Info(\"Deregister DRA plugin not necessary, was already removed\") } // ValidatePlugin is called by kubelet's plugin watcher upon detection // of a new registration socket opened by DRA plugin. func (h *RegistrationHandler) ValidatePlugin(pluginName string, endpoint string, versions []string) error { _, err := h.validateVersions(pluginName, versions) if err != nil { return fmt.Errorf(\"invalid versions of plugin %s: %w\", pluginName, err) } return err } </ins>", "commid": "kubernetes_pr_126834"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-e1c6f7407b346df6fb6212f23a2f930e04198e198bb03b9cff5041967802082d", "query": "The PR above moved everything related to into because that was where most of the code already was, but didn't renamed the files to avoid a larger diff and merge conflicts. Once is merged, we can do the renaming. Code clarity. /sig node\n/triage accepted /priority important-soon\n/assign\na PR can be created for this now.\nwill do", "positive_passages": [{"docid": "doc-en-kubernetes-45ea7bb63b96eb792aed228dc7a8fcfc088731a6d0f5d925deee37756e48c689", "text": "<ins> /* Copyright 2023 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( \"testing\" \"github.com/stretchr/testify/assert\" v1 \"k8s.io/api/core/v1\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" ) func getFakeNode() (*v1.Node, error) { return &v1.Node{ObjectMeta: metav1.ObjectMeta{Name: \"worker\"}}, nil } func TestRegistrationHandler_ValidatePlugin(t *testing.T) { newRegistrationHandler := func() *RegistrationHandler { return NewRegistrationHandler(nil, getFakeNode) } for _, test := range []struct { description string handler     func() *RegistrationHandler pluginName  string endpoint    string versions    []string shouldError bool }{ { description: \"no versions provided\", handler:     newRegistrationHandler, shouldError: true, }, { description: \"unsupported version\", handler:     newRegistrationHandler, versions:    []string{\"v2.0.0\"}, shouldError: true, }, { description: \"plugin already registered with a higher supported version\", handler: func() *RegistrationHandler { handler := newRegistrationHandler() if err := handler.RegisterPlugin(\"this-plugin-already-exists-and-has-a-long-name-so-it-doesnt-collide\", \"\", []string{\"v1.1.0\"}, nil); err != nil { t.Fatal(err) } return handler }, pluginName:  \"this-plugin-already-exists-and-has-a-long-name-so-it-doesnt-collide\", versions:    []string{\"v1.0.0\"}, shouldError: true, }, { description: \"should validate the plugin\", handler:     newRegistrationHandler, pluginName:  \"this-is-a-dummy-plugin-with-a-long-name-so-it-doesnt-collide\", versions:    []string{\"v1.3.0\"}, }, } { t.Run(test.description, func(t *testing.T) { handler := test.handler() err := handler.ValidatePlugin(test.pluginName, test.endpoint, test.versions) if test.shouldError { assert.Error(t, err) } else { assert.NoError(t, err) } }) } t.Cleanup(func() { handler := newRegistrationHandler() handler.DeRegisterPlugin(\"this-plugin-already-exists-and-has-a-long-name-so-it-doesnt-collide\") handler.DeRegisterPlugin(\"this-is-a-dummy-plugin-with-a-long-name-so-it-doesnt-collide\") }) } </ins>", "commid": "kubernetes_pr_126834"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e3bf9f7cc9913c2c832ea7854e2bf968397de93b69e6c2711f2a32d2a4b8e55", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --<!-- Please assign a SIG using: /sig SIG-NAME --\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nlooks like started a few days ago ! /sig cluster-lifecycle\ncc\nfix was sent earlier\n/sig cluster-lifecycle\nthanks :) i saw it yesterday and forgot to raise the issue. i should have checked the PR queue :)", "positive_passages": [{"docid": "doc-en-kubernetes-7dd5a72080da59c6671ec6ba3f2c5d8a97ae8c4e9887bdb5395d06e2c262c600", "text": "``` cd kubernetes <del> sudo hack/local-up-cluster.sh </del> <ins> hack/local-up-cluster.sh </ins> ``` This will build and start a lightweight local cluster, consisting of a master", "commid": "kubernetes_pr_3088"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e3bf9f7cc9913c2c832ea7854e2bf968397de93b69e6c2711f2a32d2a4b8e55", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --<!-- Please assign a SIG using: /sig SIG-NAME --\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nlooks like started a few days ago ! /sig cluster-lifecycle\ncc\nfix was sent earlier\n/sig cluster-lifecycle\nthanks :) i saw it yesterday and forgot to raise the issue. i should have checked the PR queue :)", "positive_passages": [{"docid": "doc-en-kubernetes-794399533d7d0791ae0da6d0bf969c645a7e54308ef6a130032517993de56da7", "text": "GO_OUT=\"${KUBE_ROOT}/_output/local/bin/${host_os}/${host_arch}\" APISERVER_LOG=/tmp/kube-apiserver.log <del> \"${GO_OUT}/kube-apiserver\"  </del> <ins> sudo \"${GO_OUT}/kube-apiserver\"  </ins> -v=${LOG_LEVEL}  --address=\"${API_HOST}\"  --port=\"${API_PORT}\" ", "commid": "kubernetes_pr_3088"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e3bf9f7cc9913c2c832ea7854e2bf968397de93b69e6c2711f2a32d2a4b8e55", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --<!-- Please assign a SIG using: /sig SIG-NAME --\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nlooks like started a few days ago ! /sig cluster-lifecycle\ncc\nfix was sent earlier\n/sig cluster-lifecycle\nthanks :) i saw it yesterday and forgot to raise the issue. i should have checked the PR queue :)", "positive_passages": [{"docid": "doc-en-kubernetes-14a1e93cfd38a95107af68701619439f725cf9370c560d9d215b4b415238f960", "text": "kube::util::wait_for_url \"http://${API_HOST}:${API_PORT}/api/v1beta1/pods\" \"apiserver: \" CTLRMGR_LOG=/tmp/kube-controller-manager.log <del> \"${GO_OUT}/kube-controller-manager\"  </del> <ins> sudo \"${GO_OUT}/kube-controller-manager\"  </ins> -v=${LOG_LEVEL}  --machines=\"127.0.0.1\"  --master=\"${API_HOST}:${API_PORT}\" >\"${CTLRMGR_LOG}\" 2>&1 & CTLRMGR_PID=$! KUBELET_LOG=/tmp/kubelet.log <del> \"${GO_OUT}/kubelet\"  </del> <ins> sudo \"${GO_OUT}/kubelet\"  </ins> -v=${LOG_LEVEL}  --etcd_servers=\"http://127.0.0.1:4001\"  --hostname_override=\"127.0.0.1\" ", "commid": "kubernetes_pr_3088"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e3bf9f7cc9913c2c832ea7854e2bf968397de93b69e6c2711f2a32d2a4b8e55", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --<!-- Please assign a SIG using: /sig SIG-NAME --\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nlooks like started a few days ago ! /sig cluster-lifecycle\ncc\nfix was sent earlier\n/sig cluster-lifecycle\nthanks :) i saw it yesterday and forgot to raise the issue. i should have checked the PR queue :)", "positive_passages": [{"docid": "doc-en-kubernetes-2a779090d8150bad3aefd97d85cf5091d28a6aec6482a1d296d0759f5fde000d", "text": "KUBELET_PID=$! PROXY_LOG=/tmp/kube-proxy.log <del> \"${GO_OUT}/kube-proxy\"  </del> <ins> sudo \"${GO_OUT}/kube-proxy\"  </ins> -v=${LOG_LEVEL}  --master=\"http://${API_HOST}:${API_PORT}\" >\"${PROXY_LOG}\" 2>&1 & PROXY_PID=$! SCHEDULER_LOG=/tmp/kube-scheduler.log <del> \"${GO_OUT}/kube-scheduler\"  </del> <ins> sudo \"${GO_OUT}/kube-scheduler\"  </ins> -v=${LOG_LEVEL}  --master=\"http://${API_HOST}:${API_PORT}\" >\"${SCHEDULER_LOG}\" 2>&1 & SCHEDULER_PID=$!", "commid": "kubernetes_pr_3088"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-7e3bf9f7cc9913c2c832ea7854e2bf968397de93b69e6c2711f2a32d2a4b8e55", "query": "/kind failing-test <!-- If this is a flake, please add: /kind flake --<!-- Please assign a SIG using: /sig SIG-NAME --\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\nlooks like started a few days ago ! /sig cluster-lifecycle\ncc\nfix was sent earlier\n/sig cluster-lifecycle\nthanks :) i saw it yesterday and forgot to raise the issue. i should have checked the PR queue :)", "positive_passages": [{"docid": "doc-en-kubernetes-bdaf3886e5179a58b718af6c703f63999365245e4bb334abd5e1958fd796202a", "text": "cleanup() { echo \"Cleaning up...\" <del> kill \"${APISERVER_PID}\" kill \"${CTLRMGR_PID}\" kill \"${KUBELET_PID}\" kill \"${PROXY_PID}\" kill \"${SCHEDULER_PID}\" </del> <ins> sudo kill \"${APISERVER_PID}\" sudo kill \"${CTLRMGR_PID}\" sudo kill \"${KUBELET_PID}\" sudo kill \"${PROXY_PID}\" sudo kill \"${SCHEDULER_PID}\" </ins> kill \"${ETCD_PID}\" rm -rf \"${ETCD_DIR}\"", "commid": "kubernetes_pr_3088"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-86f72e96d548c4e81185c025a10e2d04ae6592e98dce4ac1020bbde868fad271", "query": "ci-cgroupv1-containerd-node-arm64-e2e-serial-ec2-eks ci-cgroupv1-containerd-node-e2e-serial-ec2-eks It has been failing consistently for a long time. No response /sig node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThere's another bug that was filed a long time ago. But there's no update on it and the same test in gce jobs seem to be green now.\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-f2cb6d9963d322aa8400359267db30879052756ba900e4a0fbbbd59b01f0a307", "text": "} ginkgo.BeforeEach(func() { <ins> // Precautionary check that kubelet is healthy before running the test. waitForKubeletToStart(context.TODO(), f) </ins> ginkgo.By(\"setting up the pod to be used in the test\") e2epod.NewPodClient(f).Create(context.TODO(), testCase.podSpec) })", "commid": "kubernetes_pr_126066"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-86f72e96d548c4e81185c025a10e2d04ae6592e98dce4ac1020bbde868fad271", "query": "ci-cgroupv1-containerd-node-arm64-e2e-serial-ec2-eks ci-cgroupv1-containerd-node-e2e-serial-ec2-eks It has been failing consistently for a long time. No response /sig node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThere's another bug that was filed a long time ago. But there's no update on it and the same test in gce jobs seem to be green now.\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-416f783ca3617065cdc2b07d53343a5fe2bb88a655c18978750d2bd4192389af", "text": "Name: podName, }, Spec: v1.PodSpec{ <del> RestartPolicy: v1.RestartPolicyNever, </del> <ins> PriorityClassName: \"system-node-critical\", RestartPolicy:     v1.RestartPolicyNever, </ins> Containers: []v1.Container{ createContainer(ctnName), },", "commid": "kubernetes_pr_126066"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-86f72e96d548c4e81185c025a10e2d04ae6592e98dce4ac1020bbde868fad271", "query": "ci-cgroupv1-containerd-node-arm64-e2e-serial-ec2-eks ci-cgroupv1-containerd-node-e2e-serial-ec2-eks It has been failing consistently for a long time. No response /sig node\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThere's another bug that was filed a long time ago. But there's no update on it and the same test in gce jobs seem to be green now.\ncc", "positive_passages": [{"docid": "doc-en-kubernetes-a9ce4fbb96cddbb793033aff653115f16a92ad6ef7acc09db6f2881a9ce46fce", "text": "\"sh\", \"-c\", // use the dd tool to attempt to allocate huge block of memory which exceeds the node allocatable <del> \"sleep 5 && dd if=/dev/zero of=/dev/null iflag=fullblock count=10 bs=10G\", </del> <ins> \"sleep 5 && dd if=/dev/zero of=/dev/null iflag=fullblock count=10 bs=1024G\", </ins> }, SecurityContext: &v1.SecurityContext{ SeccompProfile: &v1.SeccompProfile{", "commid": "kubernetes_pr_126066"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-773b1fcc123536d87743dbcce61564d4d99d0ef8f1bc9e99dc4abf4640767e58", "query": "ci-kubernetes-unit TestPickBestStrategy shows the jobs are success. but in test-grid and ci report, it shows a failure. After This failed the {Failed;Failed;Failed;Failed;Failed;Failed;Failed; === RUN TestPickBestStrategy === RUN TestPickBestStrategy/singlecandidate,singlepreferredstrategy === RUN TestPickBestStrategy/multiplecandidates,differentpreferredstrategiesshouldfail === RUN TestPickBestStrategy/multiplecandidates,multipleresolvedpreferredstrategy No response_ /sig testing\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc\nThanks for opening this Paco, just noticed.\ncc\n! It is weird as the test passed indeed and I cannot reproduce it.\nFixed in", "positive_passages": [{"docid": "doc-en-kubernetes-f9062ca1e26bd030a62605acf761de70a52b7dbcd19218ca29610aaf446e738a", "text": "} if len(sorted) != len(graph) { <del> fmt.Printf(\"%s\", (sorted)) </del> return nil // Cycle detected }", "commid": "kubernetes_pr_126377"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-503f4eb9e1101cd3b3a6307d9ade03528bfbb5ca0774f24cc21b9b3ac01d2621", "query": "This issue was supposed to have fixed the issue where endpoint stay out of sync I also wrote a small script which would get me the out of sync endpoints compared to the endpointslices I expect the endpoints to eventually sync and reflect the most upto date information. I have just deployed the newer patch to our cluster and that has resulted in endpoints never ending up being updated if the status goes out of sync. No response Client Version: v1.29.7 Kustomize Version: v5.0.4-0.- Server Version: v1.29.7 <details</detailsalmalinux-9 <details</detailscri-o No response\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network\nfrom the logs, endpoint controller was retrying test1/test-qa in the expected way. It has retried 5 times and the next retry should be after 320ms, which should long enough for the informer cache to get the updated endpoints. If there is no more logs related to the failure, I think it may have synced it successfully. The python script used to detect the failure seems capturing diff between endpoints and endpointslice at a moment, but that could happen if there is any Pod change in the cluster, and technically the script is comparing endpoints of one moment with endpointslice of another moment. So did you see the endpoints not being synced after endpoint controller stopped retrying it?\nYeah i still see it and see similar messages continuously. Let me post some additional log messages after the one i posted above.\nObserved the same issue in 1.29 and 1.30. I keep seeing the same error then new pods were behind a service. And the endpoint never catch up after all pods are settled.\ncould you provide complete log of kube-controller-manager and the yamls of the related endpoints and endpointslice?\n/assign Are you able to triage this since you are already looking at this?\nYes i can get that over by EOD today\nSure, I'm waiting for more logs and the content of the endpoints to understand how it happened. Currently there are only retry logs which is expected in some cases.\nWe found a customer that triggered an edge case in your change of , which will cause Endpoints never updated. They have a mutatingWebhook on Endpoints object that automatically injects a label, let's say . syncServices, the endpoints controller , and they won't match since Endpoints have the extra \"dummy-k: value\". endpoints controller will by removing the label. mutatingWebhook will automatically adds back the label as part of the update request. From the APIServer's POV, the Endpoints object don't have any changes, thus the update request will succeed but returns the same resourceVersion as before. change in will mark that resourceVersion as stale. future pods events won't be handled correctly due to the step didn't result in a new resourceVersion. I think we should fix this by check the resulting resourceVersion from the update request, and only mark the old resourceVersion as stale when a new resourceVersion is generated. Not sure whether this is the same case others in this thread encountered :D\nthanks for explaining the use case and the analysis. I did analyze the code after the issue was opened and suspected the only possibility is the returned resource version somehow equals to the one in the request but didn't know how it could happen after it has checked the desired endpoints and the current endpoints are different: Now I understand this could happen when the endpoints appear different on client side but are mutated to be same on server side. Do you plan to create a PR since you have proposed a fix? could you confirm if this is also your case, i.e. there is a mutatingWebhook for endpoints objects that could make the endpoints different from what endpoints controller expects?\nYeah, i can do a fix for this\n- can we assign to you?\nSure, I'm already assigned. Given that we've had three user reports on this issue, I think it's important to address it as soon as possible. Could you please let me know when you plan to create the PR? If you're currently occupied, I'm happy to handle it and submit the PR.\nSorry, were occupied by some internal incidents last week. Just created a WIP PR for it. Will test it in kops for this specific webhook scenario in the following two days and and remove the WIP flag\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-13569e6844295f9deb842c4b449da540a5309899d6f978415a634ccdf68055d8", "text": "} logger.V(4).Info(\"Update endpoints\", \"service\", klog.KObj(service), \"readyEndpoints\", totalReadyEps, \"notreadyEndpoints\", totalNotReadyEps) <ins> var updatedEndpoints *v1.Endpoints </ins> if createEndpoints { // No previous endpoints, create them _, err = e.client.CoreV1().Endpoints(service.Namespace).Create(ctx, newEndpoints, metav1.CreateOptions{}) } else { // Pre-existing <del> _, err = e.client.CoreV1().Endpoints(service.Namespace).Update(ctx, newEndpoints, metav1.UpdateOptions{}) </del> <ins> updatedEndpoints, err = e.client.CoreV1().Endpoints(service.Namespace).Update(ctx, newEndpoints, metav1.UpdateOptions{}) </ins> } if err != nil { if createEndpoints && errors.IsForbidden(err) {", "commid": "kubernetes_pr_127417"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-503f4eb9e1101cd3b3a6307d9ade03528bfbb5ca0774f24cc21b9b3ac01d2621", "query": "This issue was supposed to have fixed the issue where endpoint stay out of sync I also wrote a small script which would get me the out of sync endpoints compared to the endpointslices I expect the endpoints to eventually sync and reflect the most upto date information. I have just deployed the newer patch to our cluster and that has resulted in endpoints never ending up being updated if the status goes out of sync. No response Client Version: v1.29.7 Kustomize Version: v5.0.4-0.- Server Version: v1.29.7 <details</detailsalmalinux-9 <details</detailscri-o No response\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network\nfrom the logs, endpoint controller was retrying test1/test-qa in the expected way. It has retried 5 times and the next retry should be after 320ms, which should long enough for the informer cache to get the updated endpoints. If there is no more logs related to the failure, I think it may have synced it successfully. The python script used to detect the failure seems capturing diff between endpoints and endpointslice at a moment, but that could happen if there is any Pod change in the cluster, and technically the script is comparing endpoints of one moment with endpointslice of another moment. So did you see the endpoints not being synced after endpoint controller stopped retrying it?\nYeah i still see it and see similar messages continuously. Let me post some additional log messages after the one i posted above.\nObserved the same issue in 1.29 and 1.30. I keep seeing the same error then new pods were behind a service. And the endpoint never catch up after all pods are settled.\ncould you provide complete log of kube-controller-manager and the yamls of the related endpoints and endpointslice?\n/assign Are you able to triage this since you are already looking at this?\nYes i can get that over by EOD today\nSure, I'm waiting for more logs and the content of the endpoints to understand how it happened. Currently there are only retry logs which is expected in some cases.\nWe found a customer that triggered an edge case in your change of , which will cause Endpoints never updated. They have a mutatingWebhook on Endpoints object that automatically injects a label, let's say . syncServices, the endpoints controller , and they won't match since Endpoints have the extra \"dummy-k: value\". endpoints controller will by removing the label. mutatingWebhook will automatically adds back the label as part of the update request. From the APIServer's POV, the Endpoints object don't have any changes, thus the update request will succeed but returns the same resourceVersion as before. change in will mark that resourceVersion as stale. future pods events won't be handled correctly due to the step didn't result in a new resourceVersion. I think we should fix this by check the resulting resourceVersion from the update request, and only mark the old resourceVersion as stale when a new resourceVersion is generated. Not sure whether this is the same case others in this thread encountered :D\nthanks for explaining the use case and the analysis. I did analyze the code after the issue was opened and suspected the only possibility is the returned resource version somehow equals to the one in the request but didn't know how it could happen after it has checked the desired endpoints and the current endpoints are different: Now I understand this could happen when the endpoints appear different on client side but are mutated to be same on server side. Do you plan to create a PR since you have proposed a fix? could you confirm if this is also your case, i.e. there is a mutatingWebhook for endpoints objects that could make the endpoints different from what endpoints controller expects?\nYeah, i can do a fix for this\n- can we assign to you?\nSure, I'm already assigned. Given that we've had three user reports on this issue, I think it's important to address it as soon as possible. Could you please let me know when you plan to create the PR? If you're currently occupied, I'm happy to handle it and submit the PR.\nSorry, were occupied by some internal incidents last week. Just created a WIP PR for it. Will test it in kops for this specific webhook scenario in the following two days and and remove the WIP flag\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-abeeedd4bea0f0be7862d90e5be3fb0bf82532434d6c0e71abbe54d0a17b4012", "text": "// If the current endpoints is updated we track the old resource version, so // if we obtain this resource version again from the lister we know is outdated // and we need to retry later to wait for the informer cache to be up-to-date. <del> if !createEndpoints { </del> <ins> // there are some operations (webhooks, truncated endpoints, ...) that can potentially cause endpoints updates became noop // and return the same resourceVersion. // Ref: https://issues.k8s.io/127370 , https://issues.k8s.io/126578 if updatedEndpoints != nil && updatedEndpoints.ResourceVersion != currentEndpoints.ResourceVersion { </ins> e.staleEndpointsTracker.Stale(currentEndpoints) } return nil", "commid": "kubernetes_pr_127417"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-503f4eb9e1101cd3b3a6307d9ade03528bfbb5ca0774f24cc21b9b3ac01d2621", "query": "This issue was supposed to have fixed the issue where endpoint stay out of sync I also wrote a small script which would get me the out of sync endpoints compared to the endpointslices I expect the endpoints to eventually sync and reflect the most upto date information. I have just deployed the newer patch to our cluster and that has resulted in endpoints never ending up being updated if the status goes out of sync. No response Client Version: v1.29.7 Kustomize Version: v5.0.4-0.- Server Version: v1.29.7 <details</detailsalmalinux-9 <details</detailscri-o No response\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network\nfrom the logs, endpoint controller was retrying test1/test-qa in the expected way. It has retried 5 times and the next retry should be after 320ms, which should long enough for the informer cache to get the updated endpoints. If there is no more logs related to the failure, I think it may have synced it successfully. The python script used to detect the failure seems capturing diff between endpoints and endpointslice at a moment, but that could happen if there is any Pod change in the cluster, and technically the script is comparing endpoints of one moment with endpointslice of another moment. So did you see the endpoints not being synced after endpoint controller stopped retrying it?\nYeah i still see it and see similar messages continuously. Let me post some additional log messages after the one i posted above.\nObserved the same issue in 1.29 and 1.30. I keep seeing the same error then new pods were behind a service. And the endpoint never catch up after all pods are settled.\ncould you provide complete log of kube-controller-manager and the yamls of the related endpoints and endpointslice?\n/assign Are you able to triage this since you are already looking at this?\nYes i can get that over by EOD today\nSure, I'm waiting for more logs and the content of the endpoints to understand how it happened. Currently there are only retry logs which is expected in some cases.\nWe found a customer that triggered an edge case in your change of , which will cause Endpoints never updated. They have a mutatingWebhook on Endpoints object that automatically injects a label, let's say . syncServices, the endpoints controller , and they won't match since Endpoints have the extra \"dummy-k: value\". endpoints controller will by removing the label. mutatingWebhook will automatically adds back the label as part of the update request. From the APIServer's POV, the Endpoints object don't have any changes, thus the update request will succeed but returns the same resourceVersion as before. change in will mark that resourceVersion as stale. future pods events won't be handled correctly due to the step didn't result in a new resourceVersion. I think we should fix this by check the resulting resourceVersion from the update request, and only mark the old resourceVersion as stale when a new resourceVersion is generated. Not sure whether this is the same case others in this thread encountered :D\nthanks for explaining the use case and the analysis. I did analyze the code after the issue was opened and suspected the only possibility is the returned resource version somehow equals to the one in the request but didn't know how it could happen after it has checked the desired endpoints and the current endpoints are different: Now I understand this could happen when the endpoints appear different on client side but are mutated to be same on server side. Do you plan to create a PR since you have proposed a fix? could you confirm if this is also your case, i.e. there is a mutatingWebhook for endpoints objects that could make the endpoints different from what endpoints controller expects?\nYeah, i can do a fix for this\n- can we assign to you?\nSure, I'm already assigned. Given that we've had three user reports on this issue, I think it's important to address it as soon as possible. Could you please let me know when you plan to create the PR? If you're currently occupied, I'm happy to handle it and submit the PR.\nSorry, were occupied by some internal incidents last week. Just created a WIP PR for it. Will test it in kops for this specific webhook scenario in the following two days and and remove the WIP flag\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-d3eac6868b6a507086819a53b798e4077c9ca5ab0d48abb0ca009330c1d6332b", "text": "apierrors \"k8s.io/apimachinery/pkg/api/errors\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/util/intstr\" <ins> \"k8s.io/apimachinery/pkg/util/sets\" </ins> \"k8s.io/apimachinery/pkg/util/wait\" \"k8s.io/client-go/informers\" clientset \"k8s.io/client-go/kubernetes\"", "commid": "kubernetes_pr_127417"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-503f4eb9e1101cd3b3a6307d9ade03528bfbb5ca0774f24cc21b9b3ac01d2621", "query": "This issue was supposed to have fixed the issue where endpoint stay out of sync I also wrote a small script which would get me the out of sync endpoints compared to the endpointslices I expect the endpoints to eventually sync and reflect the most upto date information. I have just deployed the newer patch to our cluster and that has resulted in endpoints never ending up being updated if the status goes out of sync. No response Client Version: v1.29.7 Kustomize Version: v5.0.4-0.- Server Version: v1.29.7 <details</detailsalmalinux-9 <details</detailscri-o No response\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network\nfrom the logs, endpoint controller was retrying test1/test-qa in the expected way. It has retried 5 times and the next retry should be after 320ms, which should long enough for the informer cache to get the updated endpoints. If there is no more logs related to the failure, I think it may have synced it successfully. The python script used to detect the failure seems capturing diff between endpoints and endpointslice at a moment, but that could happen if there is any Pod change in the cluster, and technically the script is comparing endpoints of one moment with endpointslice of another moment. So did you see the endpoints not being synced after endpoint controller stopped retrying it?\nYeah i still see it and see similar messages continuously. Let me post some additional log messages after the one i posted above.\nObserved the same issue in 1.29 and 1.30. I keep seeing the same error then new pods were behind a service. And the endpoint never catch up after all pods are settled.\ncould you provide complete log of kube-controller-manager and the yamls of the related endpoints and endpointslice?\n/assign Are you able to triage this since you are already looking at this?\nYes i can get that over by EOD today\nSure, I'm waiting for more logs and the content of the endpoints to understand how it happened. Currently there are only retry logs which is expected in some cases.\nWe found a customer that triggered an edge case in your change of , which will cause Endpoints never updated. They have a mutatingWebhook on Endpoints object that automatically injects a label, let's say . syncServices, the endpoints controller , and they won't match since Endpoints have the extra \"dummy-k: value\". endpoints controller will by removing the label. mutatingWebhook will automatically adds back the label as part of the update request. From the APIServer's POV, the Endpoints object don't have any changes, thus the update request will succeed but returns the same resourceVersion as before. change in will mark that resourceVersion as stale. future pods events won't be handled correctly due to the step didn't result in a new resourceVersion. I think we should fix this by check the resulting resourceVersion from the update request, and only mark the old resourceVersion as stale when a new resourceVersion is generated. Not sure whether this is the same case others in this thread encountered :D\nthanks for explaining the use case and the analysis. I did analyze the code after the issue was opened and suspected the only possibility is the returned resource version somehow equals to the one in the request but didn't know how it could happen after it has checked the desired endpoints and the current endpoints are different: Now I understand this could happen when the endpoints appear different on client side but are mutated to be same on server side. Do you plan to create a PR since you have proposed a fix? could you confirm if this is also your case, i.e. there is a mutatingWebhook for endpoints objects that could make the endpoints different from what endpoints controller expects?\nYeah, i can do a fix for this\n- can we assign to you?\nSure, I'm already assigned. Given that we've had three user reports on this issue, I think it's important to address it as soon as possible. Could you please let me know when you plan to create the PR? If you're currently occupied, I'm happy to handle it and submit the PR.\nSorry, were occupied by some internal incidents last week. Just created a WIP PR for it. Will test it in kops for this specific webhook scenario in the following two days and and remove the WIP flag\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-a28ed4d19f0618392cfe415de844a279c67718773649289e299e6c9b6cada423", "text": "\"k8s.io/kubernetes/pkg/controller/endpoint\" \"k8s.io/kubernetes/test/integration/framework\" \"k8s.io/kubernetes/test/utils/ktesting\" <ins> netutils \"k8s.io/utils/net\" </ins> ) func TestEndpointUpdates(t *testing.T) {", "commid": "kubernetes_pr_127417"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-503f4eb9e1101cd3b3a6307d9ade03528bfbb5ca0774f24cc21b9b3ac01d2621", "query": "This issue was supposed to have fixed the issue where endpoint stay out of sync I also wrote a small script which would get me the out of sync endpoints compared to the endpointslices I expect the endpoints to eventually sync and reflect the most upto date information. I have just deployed the newer patch to our cluster and that has resulted in endpoints never ending up being updated if the status goes out of sync. No response Client Version: v1.29.7 Kustomize Version: v5.0.4-0.- Server Version: v1.29.7 <details</detailsalmalinux-9 <details</detailscri-o No response\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/sig network\nfrom the logs, endpoint controller was retrying test1/test-qa in the expected way. It has retried 5 times and the next retry should be after 320ms, which should long enough for the informer cache to get the updated endpoints. If there is no more logs related to the failure, I think it may have synced it successfully. The python script used to detect the failure seems capturing diff between endpoints and endpointslice at a moment, but that could happen if there is any Pod change in the cluster, and technically the script is comparing endpoints of one moment with endpointslice of another moment. So did you see the endpoints not being synced after endpoint controller stopped retrying it?\nYeah i still see it and see similar messages continuously. Let me post some additional log messages after the one i posted above.\nObserved the same issue in 1.29 and 1.30. I keep seeing the same error then new pods were behind a service. And the endpoint never catch up after all pods are settled.\ncould you provide complete log of kube-controller-manager and the yamls of the related endpoints and endpointslice?\n/assign Are you able to triage this since you are already looking at this?\nYes i can get that over by EOD today\nSure, I'm waiting for more logs and the content of the endpoints to understand how it happened. Currently there are only retry logs which is expected in some cases.\nWe found a customer that triggered an edge case in your change of , which will cause Endpoints never updated. They have a mutatingWebhook on Endpoints object that automatically injects a label, let's say . syncServices, the endpoints controller , and they won't match since Endpoints have the extra \"dummy-k: value\". endpoints controller will by removing the label. mutatingWebhook will automatically adds back the label as part of the update request. From the APIServer's POV, the Endpoints object don't have any changes, thus the update request will succeed but returns the same resourceVersion as before. change in will mark that resourceVersion as stale. future pods events won't be handled correctly due to the step didn't result in a new resourceVersion. I think we should fix this by check the resulting resourceVersion from the update request, and only mark the old resourceVersion as stale when a new resourceVersion is generated. Not sure whether this is the same case others in this thread encountered :D\nthanks for explaining the use case and the analysis. I did analyze the code after the issue was opened and suspected the only possibility is the returned resource version somehow equals to the one in the request but didn't know how it could happen after it has checked the desired endpoints and the current endpoints are different: Now I understand this could happen when the endpoints appear different on client side but are mutated to be same on server side. Do you plan to create a PR since you have proposed a fix? could you confirm if this is also your case, i.e. there is a mutatingWebhook for endpoints objects that could make the endpoints different from what endpoints controller expects?\nYeah, i can do a fix for this\n- can we assign to you?\nSure, I'm already assigned. Given that we've had three user reports on this issue, I think it's important to address it as soon as possible. Could you please let me know when you plan to create the PR? If you're currently occupied, I'm happy to handle it and submit the PR.\nSorry, were occupied by some internal incidents last week. Just created a WIP PR for it. Will test it in kops for this specific webhook scenario in the following two days and and remove the WIP flag\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-a0c45b1ebc1f9bd7e1cefdec1b9f5a67cc89708a76990e05aec52218ba8c62ae", "text": "svc.Spec.ExternalName = \"google.com\" return svc } <ins> func TestEndpointTruncate(t *testing.T) { // Disable ServiceAccount admission plugin as we don't have serviceaccount controller running. server := kubeapiservertesting.StartTestServerOrDie(t, nil, framework.DefaultTestServerFlags(), framework.SharedEtcd()) defer server.TearDownFn() client, err := clientset.NewForConfig(server.ClientConfig) if err != nil { t.Fatalf(\"Error creating clientset: %v\", err) } informers := informers.NewSharedInformerFactory(client, 0) tCtx := ktesting.Init(t) epController := endpoint.NewEndpointController( tCtx, informers.Core().V1().Pods(), informers.Core().V1().Services(), informers.Core().V1().Endpoints(), client, 0) // Start informer and controllers informers.Start(tCtx.Done()) go epController.Run(tCtx, 1) // Create namespace ns := framework.CreateNamespaceOrDie(client, \"test-endpoints-truncate\", t) defer framework.DeleteNamespaceOrDie(client, ns, t) // Create a pod with labels basePod := &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name:   \"test-pod\", Labels: labelMap(), }, Spec: v1.PodSpec{ NodeName: \"fake-node\", Containers: []v1.Container{ { Name:  \"fakename\", Image: \"fakeimage\", Ports: []v1.ContainerPort{ { Name:          \"port-443\", ContainerPort: 443, }, }, }, }, }, Status: v1.PodStatus{ Phase: v1.PodRunning, Conditions: []v1.PodCondition{ { Type:   v1.PodReady, Status: v1.ConditionTrue, }, }, PodIP: \"10.0.0.1\", PodIPs: []v1.PodIP{ { IP: \"10.0.0.1\", }, }, }, } // create 1001 Pods to reach endpoint max capacity that is set to 1000 allPodNames := sets.New[string]() baseIP := netutils.BigForIP(netutils.ParseIPSloppy(\"10.0.0.1\")) for i := 0; i < 1001; i++ { pod := basePod.DeepCopy() pod.Name = fmt.Sprintf(\"%s-%d\", basePod.Name, i) allPodNames.Insert(pod.Name) podIP := netutils.AddIPOffset(baseIP, i).String() pod.Status.PodIP = podIP pod.Status.PodIPs[0] = v1.PodIP{IP: podIP} createdPod, err := client.CoreV1().Pods(ns.Name).Create(tCtx, pod, metav1.CreateOptions{}) if err != nil { t.Fatalf(\"Failed to create pod %s: %v\", pod.Name, err) } createdPod.Status = pod.Status _, err = client.CoreV1().Pods(ns.Name).UpdateStatus(tCtx, createdPod, metav1.UpdateOptions{}) if err != nil { t.Fatalf(\"Failed to update status of pod %s: %v\", pod.Name, err) } } // Create a service associated to the pod svc := &v1.Service{ ObjectMeta: metav1.ObjectMeta{ Name:      \"test-service\", Namespace: ns.Name, Labels: map[string]string{ \"foo\": \"bar\", }, }, Spec: v1.ServiceSpec{ Selector: map[string]string{ \"foo\": \"bar\", }, Ports: []v1.ServicePort{ {Name: \"port-443\", Port: 443, Protocol: \"TCP\", TargetPort: intstr.FromInt32(443)}, }, }, } _, err = client.CoreV1().Services(ns.Name).Create(tCtx, svc, metav1.CreateOptions{}) if err != nil { t.Fatalf(\"Failed to create service %s: %v\", svc.Name, err) } var truncatedPodName string // poll until associated Endpoints to the previously created Service exists if err := wait.PollUntilContextTimeout(tCtx, 1*time.Second, 10*time.Second, true, func(context.Context) (bool, error) { podNames := sets.New[string]() endpoints, err := client.CoreV1().Endpoints(ns.Name).Get(tCtx, svc.Name, metav1.GetOptions{}) if err != nil { return false, nil } for _, subset := range endpoints.Subsets { for _, address := range subset.Addresses { podNames.Insert(address.TargetRef.Name) } } if podNames.Len() != 1000 { return false, nil } truncated, ok := endpoints.Annotations[v1.EndpointsOverCapacity] if !ok || truncated != \"truncated\" { return false, nil } // There is only 1 truncated Pod. truncatedPodName, _ = allPodNames.Difference(podNames).PopAny() return true, nil }); err != nil { t.Fatalf(\"endpoints not found: %v\", err) } // Update the truncated Pod several times to make endpoints controller resync the service. truncatedPod, err := client.CoreV1().Pods(ns.Name).Get(tCtx, truncatedPodName, metav1.GetOptions{}) if err != nil { t.Fatalf(\"Failed to get pod %s: %v\", truncatedPodName, err) } for i := 0; i < 10; i++ { truncatedPod.Status.Conditions[0].Status = v1.ConditionFalse truncatedPod, err = client.CoreV1().Pods(ns.Name).UpdateStatus(tCtx, truncatedPod, metav1.UpdateOptions{}) if err != nil { t.Fatalf(\"Failed to update status of pod %s: %v\", truncatedPod.Name, err) } truncatedPod.Status.Conditions[0].Status = v1.ConditionTrue truncatedPod, err = client.CoreV1().Pods(ns.Name).UpdateStatus(tCtx, truncatedPod, metav1.UpdateOptions{}) if err != nil { t.Fatalf(\"Failed to update status of pod %s: %v\", truncatedPod.Name, err) } } // delete 501 Pods for i := 500; i < 1001; i++ { podName := fmt.Sprintf(\"%s-%d\", basePod.Name, i) err = client.CoreV1().Pods(ns.Name).Delete(tCtx, podName, metav1.DeleteOptions{}) if err != nil { t.Fatalf(\"error deleting test pod: %v\", err) } } // poll until endpoints for deleted Pod are no longer in Endpoints. if err := wait.PollUntilContextTimeout(tCtx, 1*time.Second, 10*time.Second, true, func(context.Context) (bool, error) { endpoints, err := client.CoreV1().Endpoints(ns.Name).Get(tCtx, svc.Name, metav1.GetOptions{}) if err != nil { return false, nil } numEndpoints := 0 for _, subset := range endpoints.Subsets { numEndpoints += len(subset.Addresses) } if numEndpoints != 500 { return false, nil } truncated, ok := endpoints.Annotations[v1.EndpointsOverCapacity] if ok || truncated == \"truncated\" { return false, nil } return true, nil }); err != nil { t.Fatalf(\"error checking for no endpoints with terminating pods: %v\", err) } } </ins>", "commid": "kubernetes_pr_127417"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-a2e77bc9d5795a4a17af5bcc5860b35587b39d7e25d603a866fcb410798b82da", "query": "seen in this inside a like loop we execute a function that return a bool and an error. If we want to fail fast we return the error directly and assert on the output of the wait function. If we want to retry we log the error and return false nil /kind flake /kind bug /sig testing /sig network\nThis issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details\n/cc since I think you this test but most probable the code is inherited and is a copy paste thing, but besides that, the change is to remove those there\n/assign", "positive_passages": [{"docid": "doc-en-kubernetes-bd53e66842fb9f0051aad196ae3200c4ebdf53ad5385cf363d168966eb761295", "text": "// our target metric should be updated by now if err := wait.PollUntilContextTimeout(ctx, 10*time.Second, 2*time.Minute, true, func(_ context.Context) (bool, error) { metrics, err := metricsGrabber.GrabFromKubeProxy(ctx, nodeName) <del> framework.ExpectNoError(err) </del> <ins> if err != nil { return false, fmt.Errorf(\"failed to fetch metrics: %w\", err) } </ins> targetMetricAfter, err := metrics.GetCounterMetricValue(metricName) <del> framework.ExpectNoError(err) </del> <ins> if err != nil { return false, fmt.Errorf(\"failed to fetch metric: %w\", err) } </ins> return targetMetricAfter > targetMetricBefore, nil }); err != nil { <del> framework.Failf(\"expected %s metric to be updated after accessing endpoints via localhost nodeports\", metricName) </del> <ins> if wait.Interrupted(err) { framework.Failf(\"expected %s metric to be updated after accessing endpoints via localhost nodeports\", metricName) } framework.ExpectNoError(err) </ins> } }) })", "commid": "kubernetes_pr_126888"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-49e05d2f2f317603fb57e106ed7f1dde07ec985be93eb80f96de35cb540b3d02", "query": "The code says this (): While the comment says this (): So..., what happened? The feature is still Alpha or it is a Beta? Be consistent about the features we add or change. Read the code. No response 30.0 <details</details<details</details<details</details<details</details<details</details\nAccording to the changelog: This feature has been demoted from Beta to Alpha. That is fine. We need to revise the code comment then.\n/sig api-machinery (not sure who owns it per se)\nnot worry, i think this can be resolved with\nI found same like this inconsistency between the comment and the actual feature gate definition for APIServingWithRoutine in due to this\nI want to raise PR on this if need another PR separately\nLooks like this comment should be updated to alpha based on . Thanks for catching. if you'd like to raise a PR to fix the comment that'd be great!\n/triage accepted\nsure I will raise", "positive_passages": [{"docid": "doc-en-kubernetes-7a25bf088444448a044cc2da8bc6893689acd492f5b8f76232586c42da79cdf1", "text": "APIServerTracing featuregate.Feature = \"APIServerTracing\" // owner: @linxiulei <del> // beta: v1.30 </del> <ins> // alpha: v1.30 </ins> // // Enables serving watch requests in separate goroutines. APIServingWithRoutine featuregate.Feature = \"APIServingWithRoutine\"", "commid": "kubernetes_pr_127244"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5db59427f7480c01036171cb909e9a21e32b3fce4bc46b1955a70f229c09fbe9", "query": "k8s component developers are using FQDNs as finalizers (e.g. or which triggers an error message that isn't particularly easy for an end user to understand: To a naive end user, a fully qualified domain name is a pretty safe thing that is unlikely to conflict with anything else (as long as it's only used by someone from within the domain that owns it, which is a reasonable assumption). If the finalizer has s inside it but no , the message should suggest that finalizers need a . Something like: Do whatever it is that triggered the warning in (this is probably simpler than installing cert-manager and asking for a certificate) introduced: <details</details<detailsGKE </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nIf thats ok I would like to work on that.\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-6845bf0286ab011877d7ffee83975cea62bef3842b3a1496e0f1c30c1bec2f70", "text": "} if len(strings.Split(stringValue, \"/\")) == 1 { if !standardFinalizers.Has(stringValue) { <del> allWarnings = append(allWarnings, fmt.Sprintf(\"%s: %q: prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers\", fldPath.String(), stringValue)) </del> <ins> if strings.Contains(stringValue, \".\") { allWarnings = append(allWarnings, fmt.Sprintf(\"%s: %q: prefer a domain-qualified finalizer name including a path (/) to avoid accidental conflicts with other finalizer writers\", fldPath.String(), stringValue)) } else { allWarnings = append(allWarnings, fmt.Sprintf(\"%s: %q: prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers\", fldPath.String(), stringValue)) } </ins> } } return allWarnings", "commid": "kubernetes_pr_127303"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-5db59427f7480c01036171cb909e9a21e32b3fce4bc46b1955a70f229c09fbe9", "query": "k8s component developers are using FQDNs as finalizers (e.g. or which triggers an error message that isn't particularly easy for an end user to understand: To a naive end user, a fully qualified domain name is a pretty safe thing that is unlikely to conflict with anything else (as long as it's only used by someone from within the domain that owns it, which is a reasonable assumption). If the finalizer has s inside it but no , the message should suggest that finalizers need a . Something like: Do whatever it is that triggered the warning in (this is probably simpler than installing cert-manager and asking for a certificate) introduced: <details</details<detailsGKE </details<details</details<details</details<details</details<details</details\n/sig api-machinery\nIf thats ok I would like to work on that.\n/assign\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-3772687ccf40d38b875849de61831c6752804410ca99c05c42fb4fc5c02a34aa", "text": "finalizer: []string{\"kubernetes.io/valid-finalizer\"}, }, { <ins> name:      \"create-crd-with-fqdn-like-finalizer-without-path\", finalizer: []string{\"finalizer.without.valid-path.io\"}, expectCreateWarnings: []string{ `metadata.finalizers: \"finalizer.without.valid-path.io\": prefer a domain-qualified finalizer name including a path (/) to avoid accidental conflicts with other finalizer writers`, }, }, { </ins> name:             \"update-crd-with-invalid-finalizer\", finalizer:        []string{\"invalid-finalizer\"}, updatedFinalizer: []string{\"another-invalid-finalizer\"},", "commid": "kubernetes_pr_127303"}], "negative_passages": []}
{"query_id": "q-en-kubernetes-4e1e8e3df5d85e92b0a012a0f9c66d157162fa3694ce62d536459d8af744fb03", "query": "[ ] two weeks soak end date : xxxx-xx-xx According to following APIsnoop query, there are six CSINode endpoints that are untested. Using a number of existing e2e test practices a new has been created to provide future Conformance coverage for the 7 endpoints. The e2e logs for this test are listed below. This query shows the following CSINode endpoints are hit within a short period of running this e2e test. If a test with these calls gets merged, test coverage will go up by 6 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance\n/triage accepted", "positive_passages": [{"docid": "doc-en-kubernetes-826ea3afba8e03a924a32dc792c4ca777d7d0b70dd5d30e4033d8a4493c979a4", "text": "<ins> /* Copyright 2024 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package storage import ( \"context\" \"fmt\" \"time\" storagev1 \"k8s.io/api/storage/v1\" metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\" \"k8s.io/apimachinery/pkg/labels\" \"k8s.io/apimachinery/pkg/types\" utilrand \"k8s.io/apimachinery/pkg/util/rand\" \"k8s.io/client-go/util/retry\" \"k8s.io/kubernetes/test/e2e/framework\" \"k8s.io/kubernetes/test/e2e/storage/utils\" \"github.com/onsi/ginkgo/v2\" \"github.com/onsi/gomega\" ) var _ = utils.SIGDescribe(\"CSINodes\", func() { f := framework.NewDefaultFramework(\"csinodes\") ginkgo.Describe(\"CSI Conformance\", func() { ginkgo.It(\"should run through the lifecycle of a csinode\", func(ctx context.Context) { csiNodeClient := f.ClientSet.StorageV1().CSINodes() initialCSINode := storagev1.CSINode{ ObjectMeta: metav1.ObjectMeta{ Name: \"e2e-csinode-\" + utilrand.String(5), }, } ginkgo.By(fmt.Sprintf(\"Creating initial csiNode %q\", initialCSINode.Name)) csiNode, err := csiNodeClient.Create(ctx, &initialCSINode, metav1.CreateOptions{}) framework.ExpectNoError(err, \"failed to create csiNode %q\", initialCSINode.Name) ginkgo.By(fmt.Sprintf(\"Getting initial csiNode %q\", initialCSINode.Name)) retrievedCSINode, err := csiNodeClient.Get(ctx, initialCSINode.Name, metav1.GetOptions{}) framework.ExpectNoError(err, \"Failed to retrieve csiNode %q\", initialCSINode.Name) gomega.Expect(retrievedCSINode.Name).To(gomega.Equal(csiNode.Name), \"Checking that the retrieved name has been found\") ginkgo.By(fmt.Sprintf(\"Patching initial csiNode: %q\", initialCSINode.Name)) payload := \"{\"metadata\":{\"labels\":{\"\" + csiNode.Name + \"\":\"patched\"}}}\" patchedCSINode, err := csiNodeClient.Patch(ctx, csiNode.Name, types.StrategicMergePatchType, []byte(payload), metav1.PatchOptions{}) framework.ExpectNoError(err, \"Failed to patch csiNode %q\", csiNode.Name) gomega.Expect(patchedCSINode.Labels).To(gomega.HaveKeyWithValue(csiNode.Name, \"patched\"), \"Checking that patched label has been applied\") patchedSelector := labels.Set{csiNode.Name: \"patched\"}.AsSelector().String() ginkgo.By(fmt.Sprintf(\"Listing csiNodes with LabelSelector %q\", patchedSelector)) csiNodeList, err := csiNodeClient.List(ctx, metav1.ListOptions{LabelSelector: patchedSelector}) framework.ExpectNoError(err, \"failed to list csiNodes\") gomega.Expect(csiNodeList.Items).To(gomega.HaveLen(1)) ginkgo.By(fmt.Sprintf(\"Delete initial csiNode: %q\", initialCSINode.Name)) err = csiNodeClient.Delete(ctx, csiNode.Name, metav1.DeleteOptions{}) framework.ExpectNoError(err, \"failed to delete csiNode %q\", initialCSINode.Name) ginkgo.By(fmt.Sprintf(\"Confirm deletion of csiNode %q\", initialCSINode.Name)) type state struct { CSINodes []storagev1.CSINode } err = framework.Gomega().Eventually(ctx, framework.HandleRetry(func(ctx context.Context) (*state, error) { csiNodeList, err := csiNodeClient.List(ctx, metav1.ListOptions{LabelSelector: patchedSelector}) if err != nil { return nil, fmt.Errorf(\"failed to list CSINode: %w\", err) } return &state{ CSINodes: csiNodeList.Items, }, nil })).WithTimeout(30 * time.Second).Should(framework.MakeMatcher(func(s *state) (func() string, error) { if len(s.CSINodes) == 0 { return nil, nil } return func() string { return fmt.Sprintf(\"Expected CSINode to be deleted, found %q\", s.CSINodes[0].Name) }, nil })) framework.ExpectNoError(err, \"Timeout while waiting to confirm CSINode %q deletion\", initialCSINode.Name) replacementCSINode := storagev1.CSINode{ ObjectMeta: metav1.ObjectMeta{ Name: \"e2e-csinode-\" + utilrand.String(5), }, } ginkgo.By(fmt.Sprintf(\"Creating replacement csiNode %q\", replacementCSINode.Name)) secondCSINode, err := csiNodeClient.Create(ctx, &replacementCSINode, metav1.CreateOptions{}) framework.ExpectNoError(err, \"failed to create csiNode %q\", replacementCSINode.Name) ginkgo.By(fmt.Sprintf(\"Getting replacement csiNode %q\", replacementCSINode.Name)) retrievedCSINode, err = csiNodeClient.Get(ctx, secondCSINode.Name, metav1.GetOptions{}) framework.ExpectNoError(err, \"Failed to retrieve CSINode %q\", replacementCSINode.Name) gomega.Expect(retrievedCSINode.Name).To(gomega.Equal(secondCSINode.Name), \"Checking that the retrieved name has been found\") ginkgo.By(fmt.Sprintf(\"Updating replacement csiNode %q\", retrievedCSINode.Name)) var updatedCSINode *storagev1.CSINode err = retry.RetryOnConflict(retry.DefaultRetry, func() error { tmpCSINode, err := csiNodeClient.Get(ctx, retrievedCSINode.Name, metav1.GetOptions{}) framework.ExpectNoError(err, \"Unable to get %q\", replacementCSINode.Name) tmpCSINode.Labels = map[string]string{replacementCSINode.Name: \"updated\"} updatedCSINode, err = csiNodeClient.Update(ctx, tmpCSINode, metav1.UpdateOptions{}) return err }) framework.ExpectNoError(err, \"failed to update %q\", replacementCSINode.Name) gomega.Expect(updatedCSINode.Labels).To(gomega.HaveKeyWithValue(secondCSINode.Name, \"updated\"), \"Checking that updated label has been applied\") updatedSelector := labels.Set{retrievedCSINode.Name: \"updated\"}.AsSelector().String() ginkgo.By(fmt.Sprintf(\"DeleteCollection of CSINodes with %q label\", updatedSelector)) err = csiNodeClient.DeleteCollection(ctx, metav1.DeleteOptions{}, metav1.ListOptions{LabelSelector: updatedSelector}) framework.ExpectNoError(err, \"failed to delete csiNode Colllection\") ginkgo.By(fmt.Sprintf(\"Confirm deletion of replacement csiNode with LabelSelector %q\", updatedSelector)) err = framework.Gomega().Eventually(ctx, framework.HandleRetry(func(ctx context.Context) (*state, error) { csiNodeList, err := csiNodeClient.List(ctx, metav1.ListOptions{LabelSelector: updatedSelector}) if err != nil { return nil, fmt.Errorf(\"failed to list CSINode: %w\", err) } return &state{ CSINodes: csiNodeList.Items, }, nil })).WithTimeout(30 * time.Second).Should(framework.MakeMatcher(func(s *state) (func() string, error) { if len(s.CSINodes) == 0 { return nil, nil } return func() string { return fmt.Sprintf(\"Expected CSINode to be deleted, found %q\", s.CSINodes[0].Name) }, nil })) framework.ExpectNoError(err, \"Timeout while waiting to confirm CSINode %q deletion\", replacementCSINode.Name) }) }) }) </ins>", "commid": "kubernetes_pr_127309"}], "negative_passages": []}