You are right, my analogy was incorrect.  There was no evidence that Trump Jr. intended to do anything illegal.  Meeting with a foreign person in the hope of obtaining information about your political opponent is not illegal.