She got the trade deal done and that's what counts. Which was a big deal for Canada. Kudos to the Conservatives for launching it and kudos to the Liberals for bringing it home. 

She is absolutely one of the strongest in the cabinet and would be a great pick for Foreign Affairs. Except, as the article states, you may want her right where she is if NAFTA gets reopened.