"Visible" is the new default in the Locations window, not "Unchanged"
Selecting "Unchanged" as a user and then saving the draft actually saves the selection as "Visible"
By default a node's hidden flag is "off".
The use of the Locations window in edit mode is only for hiding the node; otherwise its hidden flag is technically "unchanged".
The effects of the Locations window in edit mode are applied after the content/publish/after trigger.
The effects of the Locations window can thus unexpectedly override a content/publish/after workflow if "Visible" is selected.
The "Visible" option is never valid (or at least not a more accurate description than "Unchanged"). Thus it should not be used.
Peter Keung added a comment - 25/Oct/16 5:14 PM Given that: The Locations window in edit mode is only enabled for first drafts. (Ref: http://share.ez.no/learn/ez-publish/node-visibility-hiding-and-revealing-content/(page)/4#eztoc2634_0_4 ) A node's hidden flag is technically only hidden or not. (Hidden by superior is derived from the parent.) By default a node's hidden flag is "off". The use of the Locations window in edit mode is only for hiding the node; otherwise its hidden flag is technically "unchanged". The effects of the Locations window in edit mode are applied after the content/publish/after trigger. The effects of the Locations window can thus unexpectedly override a content/publish/after workflow if "Visible" is selected. This is technically true: The "Visible" option is never valid (or at least not a more accurate description than "Unchanged"). Thus it should not be used.
Create a new draft. "Visibility after publishing" should give you the options of "Unchanged" or "Hidden". "Unchanged" should be default.
Store the draft with "Unchanged" as the selection. Note that the selection is kept.
Store the draft with "Hidden" as the selection. Note that the selection is kept.
Edit an existing object. The selection should always show as "Unchanged".
Peter Keung added a comment - 25/Oct/16 5:18 PM PR: https://github.com/ezsystems/ezpublish-legacy/pull/1266 === How to test this fix === First, enable the Locations window: Select "on" for "Locations" under the "User preferences" panel in the right sidebar. Then test the following scenarios: Create a new draft. "Visibility after publishing" should give you the options of "Unchanged" or "Hidden". "Unchanged" should be default. Store the draft with "Unchanged" as the selection. Note that the selection is kept. Store the draft with "Hidden" as the selection. Note that the selection is kept. Edit an existing object. The selection should always show as "Unchanged".