Title: When writing suggestions in code reviews I have used all of these forms:<p>* Should we extract this to a separate function?<p>* Could you extract this to a separate function?<p>* I would extract this to a separate function.<p>* This could be extracted to a separate function.<p>* This should be extracted to a separate function.<p>* Extract this to a separate function.<p>As you can see, these have very different tones and I would like to be more consistent and as constructive as possible. Is there some general best practice for this? Are you or your team using a set of rules or guidelines?
Upvote: