Title: Looking at the diff between the two versions of sslKeyExchange.c released by Apple http:&#x2F;&#x2F;opensource.apple.com&#x2F;source&#x2F;Security&#x2F;Security-55471&#x2F;libsecurity_ssl&#x2F;lib&#x2F;sslKeyExchange.c and http:&#x2F;&#x2F;opensource.apple.com&#x2F;source&#x2F;Security&#x2F;Security-55179.13&#x2F;libsecurity_ssl&#x2F;lib&#x2F;sslKeyExchange.c
I was trying to come up with a reasonable explanations of how this could have happened, but failed.<p>Here the relevant part of the diff:<p><pre><code>  @@ -627,6 +628,7 @@
           goto fail;
       if ((err = SSLHashSHA1.update(&amp;hashCtx, &amp;signedParams)) != 0)
           goto fail;
  +        goto fail;
       if ((err = SSLHashSHA1.final(&amp;hashCtx, &amp;hashOut)) != 0)
           goto fail;
</code></pre>
How could this ever happen? It does not look like a copy &amp; paste error as suggested in other places,
it does not look like refactoring. Was it added intentionally to test something and commited by accident?
Is there any possible non malicious explanation someone could come up with?
Upvote: