He married actress and singer Noor Jehan but later they divorced. He was most popularly known for the portrayal of Ranjha in the film Heer Ranjha (1970). He was especially known for portraying in the films, Punjabi culture folk heroes from the epic love stories of the Punjab – Heer Ranjha and Mirza Sahiban.