On June 17, 1924, when he was 33, Macdonald married Agnes Foley, a member of a prominent Irish Catholic family.[17] They had worked together in the attorney general's office where Foley served as secretary.[21] Between 1925 and 1936, the Macdonalds would have three daughters and a son. Agnes raised the children and ran the household after Macdonald entered politics.[22] Biographer John Hawkins writes she eventually helped her husband win election in a Halifax riding with a significant Irish Catholic population. She had a large circle of friends including members of the powerful Liberal Women's societies of Halifax.[23] Hawkins also notes that Agnes Macdonald was a gifted hostess who loved conversation.