Page MenuHomePhabricator

Fix usage of deprecated API query pattern(s)
Closed, ResolvedPublic

Description

Certain API query patterns are deprecated as a result of the introduction of multi-content revisions; see https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2018-August/000140.html.

The following need fixing:

In mwapi.getMetadata, we query for prop=revisions&rvprop=contentmodel without specifying rvslots.

The (far less frequently used) check-featured-feed.js script also queries for prop=revisions&rvprop=content without specifying rvslots.

Event Timeline

Mholloway claimed this task.
Mholloway updated the task description. (Show Details)Aug 15 2018, 1:48 AM

Change 452884 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] Fix deprecated MW API queries

https://gerrit.wikimedia.org/r/452884

Change 452884 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Fix deprecated MW API queries

https://gerrit.wikimedia.org/r/452884

Mentioned in SAL (#wikimedia-operations) [2018-08-16T14:34:57Z] <mholloway-shell@deploy1001> Started deploy [mobileapps/deploy@166eafa]: Update mobileapps to a808c9d (T201979)

Mentioned in SAL (#wikimedia-releng) [2018-08-16T14:37:01Z] <mdholloway> deployed [mobileapps/deploy@166eafa]: Update mobileapps to a808c9d (T201979)

Mentioned in SAL (#wikimedia-operations) [2018-08-16T14:41:00Z] <mholloway-shell@deploy1001> Finished deploy [mobileapps/deploy@166eafa]: Update mobileapps to a808c9d (T201979) (duration: 06m 03s)

Jhernandez closed this task as Resolved.Aug 17 2018, 1:33 PM
{"cc_re__cc_re__cc_by_sa_3_0": ["olicy, and Code of Conduct.</span> \u00b7 <a href=\"https://wikimediafoundation.org/\">Wikimedia Foundation</a> \u00b7 <a href=\"https://foundation.wikimedia.org/wiki/Special:MyLanguage/Privacy_policy\">Privacy Policy</a> \u00b7 <a href=\"https://www.mediawiki.org/wiki/Special:MyLanguage/Code_of_Conduct\">Code of Conduct</a> \u00b7 <a href=\"https://foundation.wikimedia.org/wiki/Terms_of_Use/Phabricator\">Terms of Use</a> \u00b7 <a href=\"https://foundation.wikimedia.org/wiki/Wikimedia:General_disclaimer\">Disclaimer</a> \u00b7 <a href=\"https://creativecommons.org/licenses/by-sa/3.0/\">CC-BY-SA</a> \u00b7 <a href=\"https://www.gnu.org/licenses/old-licenses/gpl-2.0.html\">GPL</a></div></div></div></div><script type=\"text/javascript\" src=\"https://phab.wmfusercontent.org/res/defaultX/phabricator/91192d85/diffusion.pkg.js\"></script><script type=\"text/javascript\" src=\"https://phab.wmfusercontent.org/res/defaultX/phabricator/5c737607/core.pkg.js\"></script><script type=\"text/javascript\" src=\"https://phab.wmfusercontent.org/res/defaultX/phabricator/242aa08b/rsrc/js/phui/behavior-phui-tab-gr"]}