Bug 82706 [Wizards] WizardDialog: code inconsistent
As long as WizardDialog.updateTitleBar() is a public method (should it be?) it's not a bad idea to check dialog state in all appropriate places. Now: public void updateTitleBar() { String s = null; if(currentPage != null) s = currentPage.getTitle(); if (s == null) s = ""; //$NON-NLS-1$ setTitle(s); if(currentPage != null) setTitleImage(currentPage.getImage()); updateDescriptionMessage(); updateMessage(); } It accurately checks that currentPage != null, but forgets to do the same before calling of updateDescriptionMessage() method wich works with currentPage without any checking. This can cause NPE (which happened to me :-)).
bundles/org.eclipse.jface/src/org/eclipse/jface/wizard/WizardDialog.java
return;
        }
        if (!isMovingToPreviousPage)
            
            page.setPreviousPage(currentPage);
        else
            isMovingToPreviousPage = false;
        
        if (getContents() == null)
            updateForPage(page);
        else {
            final IWizardPage finalPage = page;
            BusyIndicator.showWhile(getContents().getDisplay(), new Runnable() {
                public void run() {
                    updateForPage(finalPage);
                }
            });
        }
    }
    /**
     * Update the receiver for the new page.
     * @param page
     */
    private void updateForPage(IWizardPage page) {
        
        if (wizard != page.getWizard())
            setWizard(page.getWizard());
        
        
        if (page.getControl() == null) {