Bug 304501 WBWRenderer has dead code
A layout is set on line 292... wbwShell.setLayout(new FillLayout()); ...then a layout is set again on line 305... if (element instanceof MWindow) { TrimmedPartLayout tl = new TrimmedPartLayout(wbwShell); wbwShell.setLayout(tl); } else { wbwShell.setLayout(new FillLayout()); } ...but the instanceof check was already done in the beginning. The TPL should just have been set on line 292 to begin with.
bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/workbench/ui/renderers/swt/WBWRenderer.java
public void shellClosed(ShellEvent e) {
					MContext context = (MContext) e.widget.getData(OWNING_ME);
					EPartService partService = (EPartService) context
							.getContext().get(EPartService.class.getName());
					if (partService != null) {
						e.doit = partService.saveAll(true);
					}
				}
			});
			shell.addListener(SWT.Activate, new Listener() {
				public void handleEvent(org.eclipse.swt.widgets.Event event) {
					IEclipseContext parentContext = getContextForParent(w);
					MApplication app = (MApplication) w.getContext().get(
							MApplication.class.getName());
					if (app != null && parentContext != null) {
						if (app.getSelectedElement() == w) {
							return;
						}
						app.setSelectedElement(w);
						parentContext.set(IContextConstants.ACTIVE_CHILD, w
								.getContext());
					}
				}
			});
		}
	}
	/*
	 * Processing the contents of a Workbench window has to take into account
	 * that theere may be trim elements contained in its child list. Since the
	 * (non-Javadoc)