Bug 61838 [Dialogs] Clean dialog should remember "build immediately" setting
I like the recent changes to the build menu/dialogs. Thanks. However, shouldn't clean the dialog remember that I unchecked "Start a build immediately" the previous 999 times I said Clean? I'll admit this is unlikely to be a common scenario, but odds are if something causes you to do it once, you'll want to do it again and your choice should be preserved across invocations. To reproduce: Select Project->Clean... In the Clean? dialog, uncheck "start a build immediately" Select Project->Clean... "start a build immediately" is checked again
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/CleanDialog.java
this.selection = selection;
        if (this.selection == null)
            this.selection = new Object[0];
    }
    /*
     * (non-Javadoc)
     * 
     * @see org.eclipse.jface.dialogs.Dialog#buttonPressed(int)
     */
    protected void buttonPressed(int buttonId) {
        final boolean cleanAll = allButton.getSelection();
        final boolean buildAll = buildNowButton != null
                && buildNowButton.getSelection();
        super.buttonPressed(buttonId);
        if (buttonId != IDialogConstants.OK_ID)
        	return;
        
    	WorkspaceJob cleanJob = new WorkspaceJob(IDEWorkbenchMessages.getString("CleanDialog.taskName")) { 
    		public boolean belongsTo(Object family) {
    			return ResourcesPlugin.FAMILY_MANUAL_BUILD.equals(family);
    		}
			public IStatus runInWorkspace(IProgressMonitor monitor) throws CoreException {
                doClean(cleanAll, monitor);
                
                if (buildAll) {
                    
                    GlobalBuildAction build = new GlobalBuildAction(window,
                            IncrementalProjectBuilder.INCREMENTAL_BUILD);
                    build.run();
                }