Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java
if (mi.getEnabled() != shouldBeEnabled) {
						mi.setEnabled(shouldBeEnabled);
					}
                }
                if (checkChanged) {
                    boolean bv = action.isChecked();
                    if (mi.getSelection() != bv) {
						mi.setSelection(bv);
					}
                }
                return;
            }
            if (widget instanceof Button) {
                Button button = (Button) widget;
                if (imageChanged && updateImages(false)) {
					textChanged = false; 
				}
                if (textChanged) {
                    String text = action.getText();
                    if (text == null) {
						text = ""; 
					} else {
						text = Action.removeAcceleratorText(text);
					}
                    button.setText(text);
                }
                if (tooltipTextChanged) {
					button.setToolTipText(action.getToolTipText());
				}
                if (enableStateChanged) {