Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java
if (image == null && forceImage) {
                image = ImageDescriptor.getMissingImageDescriptor();
            }
            
            
            LocalResourceManager localManager = new LocalResourceManager(parentResourceManager);
            
            if (widget instanceof Item) {
                ((Item) widget).setImage(image == null ? null : localManager.createImageWithDefault(image));
            } else if (widget instanceof Button) {
                ((Button) widget).setImage(image == null ? null : localManager.createImageWithDefault(image));
            }
            
            
            disposeOldImages();
            imageManager = localManager;
            
            return image != null;
        }
        return false;
    }
    /**
     * Dispose any images allocated for this contribution item
     */
    private void disposeOldImages() {
        if (imageManager != null) {
            imageManager.dispose();
            imageManager = null;
        }
    }