Bug 180701 [JFace] API - Popup dialog is creating image descriptors every time it is opened
We are not caching the imageDescriptors from PopupDialog but are recreating them all of the time. This is likely not a serious issue but it will generate garbage. Also the images are not looked up using bundles so they cannot be overridden in other Locales. As they are currently symmetric this is not an issue but they should be looked up in the same way we do it in JFaceResources when this fixed.
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/PopupDialog.java
*            the text to be shown when the title area is displayed.
	 * 
	 */
	protected void setTitleText(String text) {
		titleText = text;
		if (titleLabel != null) {
			titleLabel.setText(text);
		}
	}
	/**
	 * Return a boolean indicating whether this dialog will persist its bounds.
	 * This value is initially set in the dialog's constructor, but can be
	 * modified if the persist bounds action is shown on the menu and the user
	 * has changed its value. Subclasses may override this method.
	 * 
	 * @return <true> if the dialogs bounds will be persisted, false if it will
	 *         not.
	 */
	protected boolean getPersistBounds() {
		return persistBounds;
	}
	/**
	 * Opens this window, creating it first if it has not yet been created.
	 * <p>
	 * This method is reimplemented for special configuration of PopupDialogs.
	 * It never blocks on open, immediately returning <code>OK</code> if the
	 * open is successful, or <code>CANCEL</code> if it is not. It provides
	 * framework hooks that allow subclasses to set the focus and tab order, and
	 * avoids the use of <code>shell.open()</code> in cases where the focus
	 * should not be given to the shell initially.