Bug 242789 [Markers]If you hit escape on the delete markers dialog it deletes them anyway
Right click on a problem marker in the problems view and select delete. You get the confirmation dialog. Hit escape. The marker is deleted anyway. The problem looks to be in org.eclipse.ui.internal.views.markers.DeleteHandler.execute(ExecutionEvent): if (dialog.open() == Window.CANCEL) { return view; } It should probably be if (dialog.open() != Window.OK) { return view; }
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageDialog.java
* Creates and returns the contents of an area of the dialog which appears
     * below the message and above the button bar.
     * <p>
     * The default implementation of this framework method returns
     * <code>null</code>. Subclasses may override.
     * </p>
     * 
     * @param parent
     *            parent composite to contain the custom area
     * @return the custom area control, or <code>null</code>
     */
    protected Control createCustomArea(Composite parent) {
        return null;
    }
    /**
     * This implementation of the <code>Dialog</code> framework method creates
     * and lays out a composite and calls <code>createMessageArea</code> and
     * <code>createCustomArea</code> to populate it. Subclasses should
     * override <code>createCustomArea</code> to add contents below the
     * message.
     */
    protected Control createDialogArea(Composite parent) {
        
        createMessageArea(parent);
        
        Composite composite = new Composite(parent, SWT.NONE);
        GridLayout layout = new GridLayout();
        layout.marginHeight = 0;
        layout.marginWidth = 0;
        composite.setLayout(layout);