Bug 328221 Several error messages are confusing/useless
Build Identifier: BIRT 2.5.2 I've fixed a couple of error messages in BIRT 2.5.2 which are confusing/useless. See the attached patches. I'm aware that this patch is for an old version of BIRT but maybe they are still useful for someone stuck with BIRT 2.5.2. I didn't check whether the errors are still there in 2.6; feel free to have a look. Bugs fixed: 1. When a pre-compiled method is run and an error happens, the source of the method is included (so you get more than "There was an error in __bm_OPEN"). 2. Instead of "data.engine.BadFetchScriptReturnType", you get a real error message with the method name and the value returned. 3. If logging is enabled for jdbc.Statement, the log would fill with thousands of stack traces warning that "setSpecification is not supported." Feel free to use the patches in any legal way. Reproducible: Always
data/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/i18n/ResourceConstants.java
public final static String DATASETCACHE_LOAD_ERROR = "data.engine.datasetcache.load.error";
	public final static String EXCEED_MAX_DATA_OBJECT_ROWS = "data.engine.exceed.max.data.object.row";
	
	
	public final static String RD_INVALID_MODE = "data.engine.InvalidMode";
	public final static String RD_INVALID_ARCHIVE = "data.engine.InvalidArchive";
	public final static String RD_SAVE_ERROR = "data.engine.SaveReportDocumentError";
	public final static String RD_LOAD_ERROR = "data.engine.LoadReportDocumentError";
	public final static String RD_SAVE_STREAM_ERROR = "data.engine.GetSaveStreamError";
	public final static String RD_LOAD_STREAM_ERROR = "data.engine.GetLoadStreamError";
	public final static String RD_EXPR_NULL_ERROR = "data.engine.NullExpr";
	public final static String RD_EXPR_INVALID_ERROR = "data.engine.InValidExpr";
	public final static String RD_EXPR_RESULT_SET_NOT_START = "data.engine.ResultSetNotStart";
	public final static String RD_GET_LEVEL_MEMBER_ERROR = "data.engine.GetLevelMemberError";
	
	public final static String INVALID_ROW_INDEX = "data.engine.invalidRowIndex";
	public final static String BACKWARD_SEEK_ERROR = "data.engine.backwardSeekError";
	public final static String START_ERROR = "data.engine.startError";
	
	
	public final static String RD_INVALID_FILTER = "data.engine.rd.errorfilters";
	
	
	public final static String SCRIPT_EVAL_ERROR = "data.engine.ScriptEvalError";
	public final static String PREPARED_QUERY_CLOSED = "data.engine.PreparedQueryClosed";	
	public final static String DEFAULT_INPUT_PARAMETER_VALUE_CANNOT_BE_NULL = "data.engine.NullDefaultInParamValue";
	public final static String INVALID_GROUP_EXPR = "data.engine.BadGroupKeyExpr";
	public final static String GROUP_NOT_EXIST = "data.engine.GroupNotExist";
	public final static String INVALID_SORT_EXPR = "data.engine.BadSortKeyExpr";
	public final static String PARAMETER_METADATA_NOT_SUPPORTED = "data.engine.NoParamMetaForDataSource";