Bug 283359 [Browser] WebBrowserEditorInput#equals(Object) is wrong
Build ID: 3.2.201.v20080708_34x Steps To Reproduce: Looking at the WebBrowserEditorInput#equals(Object) method in 3.2.201.v20080708_34x version of the org.eclipse.ui.browser (similarly in the head), there are few issues: 1) The javadoc is wrong, and it doesn't make sense. 2) The line: if (url != null && !url.equals(obj)) should be if (url != null && !url.equals(other.url)) For reference, I'm pasting the contents of the equals method: /** * Indicates whether some other object is "equal to" this one. In this case * it means that the underlying IFolders are equal. */ public boolean equals(Object obj) { if (this == obj) return true; if (!(obj instanceof WebBrowserEditorInput)) return false; WebBrowserEditorInput other = (WebBrowserEditorInput) obj; if (url != null && !url.equals(obj)) return false; return canReplaceInput(other); } More information:
bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java
private static final String MEMENTO_ID = "id"; 
	private static final String MEMENTO_NAME = "name"; 
	private static final String MEMENTO_TOOLTIP = "tooltip"; 
	private URL url;
	private int style;
	private String id = null;
	private String name;
	private String tooltip;
	/**
	 * ExternalBrowserInstance editor input for the homepage.
	 */
	public WebBrowserEditorInput() {
		this(null);
	}
	/**
	 * WebBrowserEditorInput constructor comment.
	 */
	public WebBrowserEditorInput(URL url) {
		this(url, 0);
	}
	/**
	 * WebBrowserEditorInput constructor comment.
	 */
	public WebBrowserEditorInput(URL url, int style) {
		super();
		this.url = url;
		this.style = style;
	}
	/**
	 * WebBrowserEditorInput constructor comment.