Bug 308975 Can't recover from 'invalid' path variable
If a path variable is 'corrupted', the user is unable to recover. Steps to reproduce: 1) new path variable: PROJ_UP = ${PROJECT_LOC}/../ 2) You end up with this in your .project file: <variableList> <variable> <name>PROJ_UP</name> <value>$%7BPARENT-1-PROJECT_LOC%7D</value> </variable> </variableList> In e4 this was a more human readable: <variableList> <variable> <name>PROJ_UP</name> <value>${PARENT-1-PROJECT_LOC}</value> </variable> </variableList> If you change the .project file to contain the above, the Linked Resource property page is no longer accessible, and there's no indication of what went wrong. java.lang.IllegalArgumentException at java.net.URI.create(URI.java:842) at org.eclipse.core.internal.resources.ProjectPathVariableManager.getURIValue(ProjectPathVariableManager.java:123) at org.eclipse.ui.internal.ide.dialogs.PathVariablesGroup.initTemporaryState(PathVariablesGroup.java:542) at org.eclipse.ui.internal.ide.dialogs.PathVariablesGroup.setResource(PathVariablesGroup.java:727) at org.eclipse.ui.internal.ide.dialogs.ProjectLinkedResourcePage.createContents(ProjectLinkedResourcePage.java:66) at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:232) at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1501) at org.eclipse.jface.preference.PreferenceDialog$14.run(PreferenceDialog.java:1258) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/PathVariablesGroup.java
SWT.DEFAULT, true).x);
        button.setLayoutData(data);
        return data;
    }
    /**
     * Sets the enabled state of the group's widgets.
     * Does nothing if called prior to calling <code>createContents</code>.
     * 
     * @param enabled the new enabled state of the group's widgets
     */
    public void setEnabled(boolean enabled) {
        if (variableTable != null && !variableTable.getTable().isDisposed()) {
            variableLabel.setEnabled(enabled);
            variableTable.getTable().setEnabled(enabled);
            addButton.setEnabled(enabled);
            if (enabled) {
				updateEnabledState();
			} else {
                editButton.setEnabled(enabled);
                removeButton.setEnabled(enabled);
            }
        }
    }
    /**
     * Updates the widget's current state: refreshes the table with the current 
     * defined variables, selects the item corresponding to the given variable 
     * (selects the first item if <code>null</code> is provided) and updates 
     * the enabled state for the Add/Remove/Edit buttons.
     * 
     */