Bug 41743 [MenuMgmt] IContributionManager.remove has undocumented behavior
build 20030820 The doc for IContributionManager.remove says that null will be returned if "this manager has no contribution items with the given id". When I call remove on a menu with an invalid ID I get an IllegalArgumentException instead of a null return value.
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ContributionManager.java
public void insertBefore(String ID, IContributionItem item) {
	IContributionItem ci= find(ID);
	if (ci == null)
		throw new IllegalArgumentException("can't find ID " + ID);
	int ix = contributions.indexOf(ci);
	if (ix >= 0) {
		
	    if (allowItem(item)) {
	        item.setParent(this);
	        contributions.add(ix,item);
	        itemAdded(item);
	    }
	}
}
/* (non-Javadoc)
 * Method declared on IContributionManager.
 */
public boolean isDirty() {
	if(isDirty)
		return true;
	if(hasDynamicItems()) {
		for (Iterator iter = contributions.iterator(); iter.hasNext();) {
			IContributionItem item = (IContributionItem)iter.next();
			if(item.isDirty())
				return true;
		}
	}
	return false;
}
/* (non-Javadoc)