Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/internal/provisional/action/ToolBarManager2.java
listenerList = new ListenerList(ListenerList.IDENTITY);
		}
		listenerList.add(listener);
	}
	/* (non-Javadoc)
	 * @see org.eclipse.jface.action.IToolBarManager2#removePropertyChangeListener(org.eclipse.jface.util.IPropertyChangeListener)
	 */
	public void removePropertyChangeListener(IPropertyChangeListener listener) {
		if (listenerList != null) {
			listenerList.remove(listener);
			if (listenerList.isEmpty()) {
				listenerList = null;
			}
		}
	}
	
	/*
	 * Returns the listeners attached to this event manager.
	 * The listeners currently attached; may be empty, but never
	 * null.
	 */
	protected final Object[] getListeners() {
		final ListenerList list = listenerList;
		if (list == null) {
			return new Object[0];
		}
		return list.getListeners();
	}
	/*
	 * Notifies any property change listeners that a property has changed. Only