Bug 279123 [UI] View's context menus are over written with the contents from the drop-down menu
This appeared once we started populating legacy parts with menu and tb models... There is code in the PartRenderer that 'automatically' creates Menus and Toolbars from the existing model structures if they exist. Unfortunately it also calls 'setMenu' on the 'owning' control. For legacy parts the MMenu available through 'getMenu' is the 'drop down' menu that appears when you click on the drop down button on the view's toolbar. The control's menu for these parts is managed by the view's implementation itself.
bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/workbench/ui/renderers/swt/SWTPartFactory.java
Menu swtMenu;
		if (widget instanceof MenuItem) {
			swtMenu = new Menu(((MenuItem) widget).getParent().getShell(),
					SWT.DROP_DOWN);
			((MenuItem) widget).setMenu(swtMenu);
		} else if (widget instanceof ToolItem) {
			swtMenu = new Menu(((ToolItem) widget).getParent().getShell(),
					SWT.POP_UP);
		} else if (widget instanceof Decorations) {
			swtMenu = new Menu((Decorations) widget, SWT.BAR);
			((Decorations) widget).setMenuBar(swtMenu);
		} else if (widget instanceof Control) {
			swtMenu = new Menu((Control) widget);
			((Control) widget).setMenu(swtMenu);
		} else {
			throw new IllegalArgumentException(
					"The widget must be MenuItem, Decorations, or Control but is: " 
							+ widgetObject);
		}
		for (MMenuItem menuItem : menu.getItems()) {
			createMenuItem(part, swtMenu, menuItem);
		}
		return swtMenu;
	}
	public Object createToolBar(MPart<?> part, Object widgetObject,
			MToolBar toolbar) {
		int orientation = SWT.HORIZONTAL;
		Composite composite = (Composite) widgetObject;
		if (composite.getLayout() instanceof RowLayout) {
			RowLayout rl = (RowLayout) composite.getLayout();