Bug 299207 [CommonNavigator] Refactor NavigatorContentServiceContentProvider
There are a number of things about this code that make it less clear that it needs to be: 1) The internalGetChildren() and getElements() are largely duplicated. 2) The pipelinedChildren() private method returns the localSet which is never modified. 3) A ContributorTrackingSet is used in internalGetChildren() and getElements() when it is not necessary (setContribution() is never called on this, it should be just a LinkedHashSet) 4) The synchronization of methods is inconsistent 5) There are obsolete and unnecessary Javadoc comments 6) The order of the methods makes it hard to understand This refactoring (to be attached) cleans up these issues making the code easier to understand. No functionality change nor bug fix is intended here (except possibly by making the synchronization consistent).
bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorContentServiceContentProvider.java
return false;
	}
	/**
	 * <p>
	 * Handles any necessary clean up of the {@link NavigatorContentService}
	 * </p>
	 * 
	 * <p>
	 * <b>If a client uses this class outside of the framework of
	 * {@link CommonViewer}, the client must ensure that this method is called
	 * when finished. </b>
	 * </p>
	 * 
	 * @see org.eclipse.jface.viewers.IContentProvider#dispose()
	 */
	public synchronized void dispose() {
		if (isContentServiceSelfManaged) {
			contentService.dispose();
		}
	}
	/**
	 * <p>
	 * Indicates that the current content provider is now representing a
	 * different input element. The input element is the root thing that the
	 * viewer displays.
	 * </p>
	 * <p>
	 * This method should handle any cleanup associated with the old input
	 * element and any initialization associated with the new input element.
	 * </p>