Bug 252940 [Dialogs] DialogPage's dispose() method has a false javadoc specification
The DialogPage class's dispose() method is spec'ed as... /** * The <code>DialogPage</code> implementation of an * <code>IDialogPage</code> method does nothing. Subclasses may extend. */ ...unfortunately, the truth is that it actually does something rather important. public void dispose() { // deallocate SWT resources if (image != null) { image.dispose(); image = null; } } I am marking this as major since unwary subclasses that extends this method without calling super.dispose() will end up having a memory leak.
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogPage.java
* @param widgetId
     *            the id of the widget for which hover help is requested
     * @return the tool tip text, or <code>null</code> if none
     * @deprecated 
     */
    protected final String getToolTipText(int widgetId) {
        
        return null;
    }
    /**
     * Initializes the computation of horizontal and vertical dialog units based
     * on the size of current font.
     * <p>
     * This method must be called before any of the dialog unit based conversion
     * methods are called.
     * </p>
     * 
     * @param testControl
     *            a control from which to obtain the current font
     */
    protected void initializeDialogUnits(Control testControl) {
        
        GC gc = new GC(testControl);
        gc.setFont(JFaceResources.getDialogFont());
        fontMetrics = gc.getFontMetrics();
        gc.dispose();
    }
    /**
     * Sets the <code>GridData</code> on the specified button to be one that
     * is spaced for the current dialog page units. The method