Bug 187594 Compiler warnings in I20070517-0010
1. WARNING in /Eclipse RCP Tests/org/eclipse/ui/tests/rcp/WorkbenchWindowConfigurerTest.java (at line 189) ActionBarAdvisor advisor = new ActionBarAdvisor(configurer) { The local variable advisor is never read 1. WARNING in /src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java (at line 38) import org.eclipse.jface.dialogs.Dialog; The import org.eclipse.jface.dialogs.Dialog is never used 2. WARNING in /src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java (at line 46) import org.eclipse.jface.resource.ImageRegistry; The import org.eclipse.jface.resource.ImageRegistry is never used 3. WARNING in /src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java (at line 47) import org.eclipse.jface.resource.JFaceResources; The import org.eclipse.jface.resource.JFaceResources is never used
bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java
String[] previousFeaturesArray = settings.getArray(INSTALLED_FEATURES);
		
		
		Map bundleGroups = computeBundleGroupMap();
		String[] currentFeaturesArray = new String[bundleGroups.size()];
		bundleGroups.keySet().toArray(currentFeaturesArray);
		settings.put(INSTALLED_FEATURES, currentFeaturesArray);
		
		if (previousFeaturesArray != null) {
			for (int i = 0; i < previousFeaturesArray.length; ++i) {
				bundleGroups.remove(previousFeaturesArray[i]);
			}
		}
		return bundleGroups;
	}
	/**
	 * Declares all IDE-specific workbench images. This includes both "shared"
	 * images (named in {@link IDE.SharedImages}) and internal images (named in
	 * {@link org.eclipse.ui.internal.ide.IDEInternalWorkbenchImages}).
	 * 
	 * @see IWorkbenchConfigurer#declareImage
	 */
	private void declareWorkbenchImages() {
		final String ICONS_PATH = "$nl$/icons/full/";
		final String PATH_ELOCALTOOL = ICONS_PATH + "elcl16/"; 
		
		
		final String PATH_DLOCALTOOL = ICONS_PATH + "dlcl16/";