Bug 252940 [Dialogs] DialogPage's dispose() method has a false javadoc specification
The DialogPage class's dispose() method is spec'ed as... /** * The <code>DialogPage</code> implementation of an * <code>IDialogPage</code> method does nothing. Subclasses may extend. */ ...unfortunately, the truth is that it actually does something rather important. public void dispose() { // deallocate SWT resources if (image != null) { image.dispose(); image = null; } } I am marking this as major since unwary subclasses that extends this method without calling super.dispose() will end up having a memory leak.
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogPage.java
* </p>
     * 
     * @param newMessage
     *            the message, or <code>null</code> to clear the message
     * @param newType
     *            the message type
     * @since 2.0
     */
    public void setMessage(String newMessage, int newType) {
        message = newMessage;
        messageType = newType;
    }
    /**
     * The <code>DialogPage</code> implementation of this
     * <code>IDialogPage</code> method remembers the title in an internal
     * state variable. Subclasses may extend.
     */
    public void setTitle(String title) {
        this.title = title;
    }
    /**
     * The <code>DialogPage</code> implementation of this
     * <code>IDialogPage</code> method sets the control to the given
     * visibility state. Subclasses may extend.
     */
    public void setVisible(boolean visible) {
        control.setVisible(visible);
    }
}