Bug 60785 [Preferences] [Javadoc] Review of org.eclipse.jface.preference
Warnings: IPreferenceStore.java:379: warning - @param argument "value" is not a parameter name. BooleanFieldEditor.java:80: warning - @param argument "labelText" is not a parameter name. ColorSelector.java:63: warning - @param argument "parent." is not a parameter name. ColorSelector.java:192: warning - @param argument "rgb." is not a parameter name. FieldEditor.java:596: warning - @param argument "Button" is not a parameter name. FieldEditor.java:619: warning - @param argument "boolean." is not a parameter name. FieldEditor.java:619: warning - @param argument "parent." is not a parameter name. FileFieldEditor.java:143: warning - @param argument "extension" is not a parameter name. PreferenceConverter.java:45: warning - @issue is an unknown tag. PreferenceDialog.java:202: warning - @param argument "shell" is not a parameter name. PreferenceDialog.java:836: warning - @param argument "errorMessage" is not a parameter name. PreferenceNode.java:109: warning - @param argument "page" is not a parameter name. PreferenceStore.java:432: warning - @param argument "filename" is not a parameter name. StringFieldEditor.java:289: warning - @param argument "parent" is not a parameter name. BooleanPropertyAction: - BooleanPropertyAction has no description. - run() is not documented. ColorFieldEditor: - Class description is incomplete or just missing a period. - getColorSelector() is undocumented. - getNumberOfControls() has an incomplete description. ColorSelector: - updateColorImage() description ends in a comma. FieldEditorPreferencePage: - applyFont() is undocumented. PreferenceContentProvider: - All methods are undocumented. PreferenceDialog: - Undocumented methods: close(), configureShell(), constrainShellSize(), createTreeAreaContents(), getSingleSelection(), getTreeViewer(), layoutTreeAreaControl(). PreferenceLabelProvider: - All methods are undocumented. StringButtonFieldEditor: - getChangeControl() is undocumented. JFacePreferences: - *_COLOR undocumented.
bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceDialog.java
switch (buttonId) {
			case IDialogConstants.OK_ID :
				{
					okPressed();
					return;
				}
			case IDialogConstants.CANCEL_ID :
				{
					cancelPressed();
					return;
				}
			case IDialogConstants.HELP_ID :
				{
					helpPressed();
					return;
				}
		}
	}
	/* (non-Javadoc)
	 * @see org.eclipse.jface.dialogs.Dialog#cancelPressed()
	 */
	protected void cancelPressed() {
		
		Iterator nodes = preferenceManager.getElements(PreferenceManager.PRE_ORDER).iterator();
		while (nodes.hasNext()) {
			final IPreferenceNode node = (IPreferenceNode) nodes.next();
			if (node.getPage() != null) {
				Platform.run(new SafeRunnable() {
					public void run() {
						if (!node.getPage().performCancel())