Bug 238452 [Browser] External browser parameters are not passed to external browser
Build ID: I20080609-1311 Steps To Reproduce: 1.When I set values in to the Edit External Web Browser dialog from Window->Preferences->General->WebBrowser->Use external web browse->Edit these parameters have no effect. 2. 3. More information: The buggy code is in org.eclipse.ui.internal.browser.browsers.MozillaFactory.createBrowser(String, String, String) public IWebBrowser createBrowser(String id, String location, String parameters) { // Create single browser for all clients if (browserInstance == null) { browserInstance = new MozillaBrowser(id, location); } return browserInstance; } Parameters are ignored
bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/ExternalBrowserInstance.java
else
				process = Runtime.getRuntime().exec(location + " " + params); 
		} catch (Exception e) {
			Trace.trace(Trace.SEVERE, "Could not launch external browser", e); 
			WebBrowserUtil.openError(NLS.bind(
					Messages.errorCouldNotLaunchWebBrowser, urlText));
		}
		Thread thread = new Thread() {
			public void run() {
				try {
					process.waitFor();
					DefaultBrowserSupport.getInstance().removeBrowser(
							ExternalBrowserInstance.this);
				} catch (Exception e) {
					
				}
			}
		};
		thread.setDaemon(true);
		thread.start();
	}
	public boolean close() {
		try {
			process.destroy();
			return true;
		} catch (Exception e) {
			return false;
		}
	}
}