Bug 58985 [Dialogs] WizardDialog.getButton( IDialogConstants.CANCLE_ID ) always returns null
Here's a test case for this bug. Watch the stdout of the program. --WizardDialogBug import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.wizard.IWizard; import org.eclipse.jface.wizard.Wizard; import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.jface.wizard.WizardPage; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Shell; public class WizardDialogBug { public static void main(String[] args) { WizardDialogBug wizardDialogBug = new WizardDialogBug(); wizardDialogBug.run(); } public void run() { Display display = new Display(); Shell shell = new Shell( display, SWT.NONE ); TestWizard wizard = new TestWizard(); TestWizardDialog dialog = new TestWizardDialog( shell, wizard ); dialog.setBlockOnOpen( false ); dialog.open(); while( !shell.isDisposed() ) if( !display.readAndDispatch() ) display.sleep(); display.dispose(); } // test WizardPage public class TestWizardPage extends WizardPage { public TestWizardPage() { super( "TestWizardPage" ); } public void createControl(Composite parent) { Button b = new Button( parent, SWT.PUSH ); b.setText( "Button" ); setControl( b ); } } // test Wizard public class TestWizard extends Wizard { public TestWizard() { super(); setWindowTitle( "TestWizard" ); } public void addPages() { addPage( new TestWizardPage() ); } public boolean performFinish() { return false; } } // test WizardDialog public class TestWizardDialog extends WizardDialog { public TestWizardDialog( Shell shell, IWizard wizard ) { super( shell, wizard ); } public int open() { int rc = super.open(); // by now, all controls should have been created; System.out.println( getButton( IDialogConstants.FINISH_ID ) ); System.out.println( getButton( IDialogConstants.CANCEL_ID ) ); return rc; } } }
bundles/org.eclipse.jface/src/org/eclipse/jface/wizard/WizardDialog.java
activeRunningOperations--;
			
			if (state != null)
				stopped(state);
		}
	}
	/**
	 * Saves the enabled/disabled state of the given control in the
	 * given map, which must be modifiable.
	 *
	 * @param w the control, or <code>null</code> if none
	 * @param h the map (key type: <code>String</code>, element type:
	 *   <code>Boolean</code>)
	 * @param key the key
	 * @param enabled <code>true</code> to enable the control, 
	 *   and <code>false</code> to disable it
	 * @see #restoreEnableStateAndSet
	 */
	private void saveEnableStateAndSet(Control w, Map h, String key, boolean enabled) {
		if (w != null) {
			h.put(key, new Boolean(w.getEnabled()));
			w.setEnabled(enabled);
		}
	}
	/**
	 * Captures and returns the enabled/disabled state of the wizard dialog's
	 * buttons and the tree of controls for the currently showing page. All
	 * these controls are disabled in the process, with the possible excepton of
	 * the Cancel button.
	 *