Bug 87826 Need to improve image loading in Workbench
The Workbench image loading has several issues 1) The string "icons/full" is all over the place in the UI and should be made a constant 2) This needs to be prepended by /nl 3) The plugin descriptor is still in use to load images. This does not support nl which is required for BIDI support
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/PathVariablesGroup.java
for (Iterator removed = removedVariableNames.iterator(); removed
                    .hasNext();) {
                String removedVariableName = (String) removed.next();
                
                if (!tempPathVariables.containsKey(removedVariableName))
                    pathVariableManager.setValue(removedVariableName, null);
            }
            
            for (Iterator current = tempPathVariables.entrySet().iterator(); current
                    .hasNext();) {
                Map.Entry entry = (Map.Entry) current.next();
                String variableName = (String) entry.getKey();
                IPath variableValue = (IPath) entry.getValue();
                pathVariableManager.setValue(variableName, variableValue);
            }
            
            initTemporaryState();
            
            return true;
        } catch (CoreException ce) {
            ErrorDialog.openError(shell, null, null, ce.getStatus());
        }
        return false;
    }
    /**
     * Removes the currently selected variables.
     */
    private void removeSelectedVariables() {