Bug 293841 [FieldAssist] NumLock keyDown event should not close the proposal popup [with patch]
User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.0.14) Gecko/2009082707 Firefox/3.0.14 Build Identifier: 20090920-1017 I have a Text widget with a ContentProposalAdapter attached to it. The user shall input some numeric value, but on this platform (Windows 2003 Terminal Server with rdestop unix client, if that matters) there are additional keyDown events generated for num pad input. These events almost immediately close the proposal popup after user input. Input with the normal "digit keys" works as expected. The ContentProposalAdapter.ControlProposalPopup.TargetControlListener class currently does check for keyDown events on the SWT.CAPS_LOCK and SWT.MOD{1-4} keys and does ignore them. Any other key forces the popup to close. I suggest to also NOT close the popup on SWT.NUM_LOCK keyDown events. Reproducible: Always
bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/ContentProposalAdapter.java
internalPopupOpened();
					notifyPopupOpened();
				} else if (!autoActivated) {
					getControl().getDisplay().beep();
				}
			}
		}
	}
	/**
	 * Open the proposal popup and display the proposals provided by the
	 * proposal provider. This method returns immediately. That is, it does not
	 * wait for a proposal to be selected. This method is used by subclasses to
	 * explicitly invoke the opening of the popup. If there are no proposals to
	 * show, the popup will not open and a beep will be sounded.
	 */
	protected void openProposalPopup() {
		openProposalPopup(false);
	}
	/**
	 * Close the proposal popup without accepting a proposal. This method
	 * returns immediately, and has no effect if the proposal popup was not
	 * open. This method is used by subclasses to explicitly close the popup
	 * based on additional logic.
	 * 
	 * @since 3.3
	 */
	protected void closeProposalPopup() {
		if (popup != null) {
			popup.close();
		}