Bug 61838 [Dialogs] Clean dialog should remember "build immediately" setting
I like the recent changes to the build menu/dialogs. Thanks. However, shouldn't clean the dialog remember that I unchecked "Start a build immediately" the previous 999 times I said Clean? I'll admit this is unlikely to be a common scenario, but odds are if something causes you to do it once, you'll want to do it again and your choice should be preserved across invocations. To reproduce: Select Project->Clean... In the Clean? dialog, uncheck "start a build immediately" Select Project->Clean... "start a build immediately" is checked again
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/CleanDialog.java
if (!(element instanceof IProject))
					return false;
				IProject project = (IProject) element;
				if (!project.isAccessible())
					return false;
				projectHolder[0] = project;
				return BuildUtilities.isEnabled(projectHolder, IncrementalProjectBuilder.CLEAN_BUILD);
			}
		});
    	projectNames.setInput(ResourcesPlugin.getWorkspace().getRoot());
    	GridData data = new GridData(GridData.FILL_BOTH);
    	data.widthHint = IDialogConstants.ENTRY_FIELD_WIDTH;
    	data.heightHint = IDialogConstants.ENTRY_FIELD_WIDTH;
    	projectNames.getTable().setLayoutData(data);
    	projectNames.setCheckedElements(selection);
    	
    	projectNames.getTable().setEnabled(selectedButton.getSelection());
    	projectNames.addCheckStateListener(new ICheckStateListener() {
			public void checkStateChanged(CheckStateChangedEvent event) {
				selection = projectNames.getCheckedElements();
				updateEnablement();
			}
		});
	}
	/**
	 * Performs the actual clean operation.
	 * @param cleanAll if <code>true</true> clean all projects
	 * @param monitor The monitor that the build will report to
	 * @throws CoreException thrown if there is a problem from the
	 * core builder.