Bug 70088 [Actions] ActionContributionItem.fill(Composite) creates button with wrong text
1. Create an action with setText ("&Go@Ctrl+G"); 2. Use ActionContributionItem.fill(Composite) to create a button 3. The label of the button will be "_G_o@Ctrl+G" Looking at the source, it seems that the code which handles the text for buttons doesn't take the accelerator in account. Quick fix: Remove any text after the @ (incl) in the "set text for button" code. Suggested fix: Remove the ugly "@text" hack and use the real accelerator (set with setAccelerator()) instead (removes code duplication, too).
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java
public boolean isVisible() {
        return super.isVisible() && isCommandActive();
    }
    /**
     * Sets the presentation mode, which is the bitwise-or of the 
     * <code>MODE_*</code> constants.
     * 
     * @param mode the presentation mode settings
     * 
     * @since 3.0
     */
    public void setMode(int mode) {
        this.mode = mode;
        update();
    }
    /**
     * The action item implementation of this <code>IContributionItem</code>
     * method calls <code>update(null)</code>.
     */
    public final void update() {
        update(null);
    }
    /**
     * Synchronizes the UI with the given property.
     *
     * @param propertyName the name of the property, or <code>null</code> meaning all applicable
     *   properties 
     */
    public void update(String propertyName) {
        if (widget != null) {