Bug 92564 [Viewers] (doc only) incorrect use of html in javadoc of BackgroundContentProvider
Version: 3.1.0 Build id: I20050419-1200 The section that is explaining the information flow is not correctly defining the ordered list. Each item should be wrapped in a 'li', not an 'ol'. Index: BackgroundContentProvider.java =================================================================== RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java,v retrieving revision 1.4 diff -u -r1.4 BackgroundContentProvider.java --- BackgroundContentProvider.java 28 Mar 2005 14:57:36 -0000 1.4 +++ BackgroundContentProvider.java 25 Apr 2005 11:13:00 -0000 @@ -38,12 +38,12 @@ * <p> * Information flow is like this: * </p> - * <ol>IConcurrentModel sends unordered elements to BackgroundContentProvider (in a background thread)</ol> - * <ol>BackgroundContentProvider sorts, filters, and sends element/index pairs to - * ConcurrentTableUpdator (in a background thread)</ol> - * <ol>ConcurrentTableUpdator batches the updates and sends them to an AbstractVirtualTable - * (in the UI thread)</ol> - * <li> + * <ol> + * <li>IConcurrentModel sends unordered elements to BackgroundContentProvider (in a background thread)</li> + * <li>BackgroundContentProvider sorts, filters, and sends element/index pairs to + * ConcurrentTableUpdator (in a background thread)</li> + * <li>ConcurrentTableUpdator batches the updates and sends them to an AbstractVirtualTable + * (in the UI thread)</li> * </ol> * * <p>
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java
* Checks if currently visible range has changed, and triggers and update
     * and resort if necessary. Must be called in the UI thread, typically
     * within a SWT.SetData callback.
     * @param includeIndex the index that should be included in the visible range.
     */
    public void checkVisibleRange(int includeIndex) {
    	updator.checkVisibleRange(includeIndex);
		ConcurrentTableUpdator.Range newRange = updator.getVisibleRange();
		ConcurrentTableUpdator.Range oldRange = range;
		
		
		if (newRange.start != oldRange.start || newRange.length != oldRange.length) {
			sortMon.cancel();
		}
    }
    
    /**
     * This lock protects the two boolean variables sortThreadStarted and resortScheduled.
     */
    private Object lock = new Object();
    /**
     * true if the sort thread is running
     */
    private boolean sortThreadStarted = false;
    /**
     * true if we need to sort
     */
    private boolean sortScheduled = false;
    
	private final class SortThread extends Thread {