Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractListViewer.java
/**
     * Returns the index of the given element in listMap, or -1 if the element cannot be found.
     * As of 3.3, uses the element comparer if available.
     * 
     * @param element
     * @return the index
     */
    int getElementIndex(Object element) {
		IElementComparer comparer = getComparer();
		if (comparer == null) {
			return listMap.indexOf(element);
		}
		int size = listMap.size();
		for (int i = 0; i < size; i++) {
			if (comparer.equals(element, listMap.get(i)))
				return i;
		}
		return -1;
	}
    /**
	 * @param element
	 * @return true if listMap contains the given element
	 * 
	 * @since 3.3
	 */
	private boolean listMapContains(Object element) {
		return getElementIndex(element) != -1;
	}
}