Bug 48400 [Dialogs] MessageDialog needs javadoc for returnCode == -1
org.eclipse.jface.dialogs.MessageDialog extends handleShellCloseEvent() and sets a returnCode of -1 when the dialog is closed without pressing a button (pressed esc key or clicked close box). This special returnCode needs to be commented in JavaDocs, since it is an unexpected result (and already caused problems). I suggest to ... - transform the comment for handleShellCloseEvent() into a JavaDoc comment - replace '-1' by SWT.DEFAULT or a new 'public static final int' constant - mention the special returnCode in MessageDialog's class JavaDoc
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageDialog.java
* @param title the dialog's title, or <code>null</code> if none
 * @param message the message
 */
public static void openInformation(
	Shell parent,
	String title,
	String message) {
		MessageDialog dialog =
			new MessageDialog(parent, title, null, 
	message, INFORMATION, new String[] { IDialogConstants.OK_LABEL }, 0);
	
	dialog.open();
	return;
}
/** 
 * Convenience method to open a simple Yes/No question dialog.
 *
 * @param parent the parent shell of the dialog, or <code>null</code> if none
 * @param title the dialog's title, or <code>null</code> if none
 * @param message the message
 * @return <code>true</code> if the user presses the OK button,
 *    <code>false</code> otherwise
 */
public static boolean openQuestion(Shell parent, String title, String message) {
	MessageDialog dialog = new MessageDialog(
		parent,
		title, 
		null,	
		message, 
		QUESTION,