Bug 233313 [Preferences] Mistake in javadoc for PreferencePage
Build ID: M20080221-1800 Steps To Reproduce: Open source code for org.eclipse.jface.preference.PreferencePage. The javadoc of the PreferencePage states that: "Subclasses must implement the createControl framework method to supply the page's main control." I think this should be "Subclasses must implement the _createContents_ framework method to supply the page's main control." More information: Because createControl is inherited from DialogPage and implements buttons and decoration. The method then calls the abstract createContents that people use to fill out the preference page with SWT controls.
bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferencePage.java
* it must also increase the parent's grid layout number of columns
     * by one; that is,
     * <pre>
     * ((GridLayout) parent.getLayout()).numColumns++);
     * </pre>
     * </p>
     *
     * @param parent the button bar
     */
    protected void contributeButtons(Composite parent) {
    }
    /**
     * Creates and returns the SWT control for the customized body 
     * of this preference page under the given parent composite.
     * <p>
     * This framework method must be implemented by concrete subclasses. Any
     * subclass returning a <code>Composite</code> object whose <code>Layout</code>
     * has default margins (for example, a <code>GridLayout</code>) are expected to
     * set the margins of this <code>Layout</code> to 0 pixels. 
     * </p>
     *
     * @param parent the parent composite
     * @return the new control
     */
    protected abstract Control createContents(Composite parent);
    /**
     * The <code>PreferencePage</code> implementation of this 
     * <code>IDialogPage</code> method creates a description label
     * and button bar for the page. It calls <code>createContents</code>
     * to create the custom contents of the page.