Bug 252940 [Dialogs] DialogPage's dispose() method has a false javadoc specification
The DialogPage class's dispose() method is spec'ed as... /** * The <code>DialogPage</code> implementation of an * <code>IDialogPage</code> method does nothing. Subclasses may extend. */ ...unfortunately, the truth is that it actually does something rather important. public void dispose() { // deallocate SWT resources if (image != null) { image.dispose(); image = null; } } I am marking this as major since unwary subclasses that extends this method without calling super.dispose() will end up having a memory leak.
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogPage.java
* </p>
     * 
     * @param dlus
     *            the number of horizontal dialog units
     * @return the number of pixels
     */
    protected int convertHorizontalDLUsToPixels(int dlus) {
        
        if (fontMetrics == null) {
			return 0;
		}
        return Dialog.convertHorizontalDLUsToPixels(fontMetrics, dlus);
    }
    /**
     * Returns the number of pixels corresponding to the given number of
     * vertical dialog units.
     * <p>
     * This method may only be called after <code>initializeDialogUnits</code>
     * has been called.
     * </p>
     * <p>
     * Clients may call this framework method, but should not override it.
     * </p>
     * 
     * @param dlus
     *            the number of vertical dialog units
     * @return the number of pixels
     */
    protected int convertVerticalDLUsToPixels(int dlus) {