Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceDialog.java
if (selection instanceof IPreferenceNode) {
					if (!isCurrentPageValid()) {
						handleError();
					} else if (!showPage((IPreferenceNode) selection)) {
						
						handleError();
					} else {
						
						lastSuccessfulNode = (IPreferenceNode) selection;
					}
				}
			}
		});
		((Tree) viewer.getControl()).addSelectionListener(new SelectionAdapter() {
			public void widgetDefaultSelected(final SelectionEvent event) {
				ISelection selection = viewer.getSelection();
				if (selection.isEmpty()) {
					return;
				}
				IPreferenceNode singleSelection = getSingleSelection(selection);
				boolean expanded = viewer.getExpandedState(singleSelection);
				viewer.setExpandedState(singleSelection, !expanded);
			}
		});
		
		viewer.getControl().addHelpListener(new HelpListener() {
			public void helpRequested(HelpEvent event) {
				
				if (currentPage != null) {
					currentPage.performHelp();