Bug 83059 [RCP] No enablement of perspective menu items
RCP application using factory methods to create menu items for Close Perspective , Close All Perspectives, Reset Perspective, etc. does not maintain enablement state of actions. This code in WorkbenchAdvisor's fillActionBars() method recreates the problem: //Use standard factory methods for actions IWorkbenchAction resetPersAction = ActionFactory.RESET_PERSPECTIVE.create(window); IWorkbenchAction closePersAction = ActionFactory.CLOSE_PERSPECTIVE.create(window); IWorkbenchAction closeAllPersAction = ActionFactory.CLOSE_ALL_PERSPECTIVES.create(window); //Create menu items IMenuManager mgr = configurer.getMenuManager(); MenuManager windowMenu = new MenuManager("&Window", IWorkbenchActionConstants.M_WINDOW); mgr.add(windowMenu); windowMenu.add(resetPersAction); windowMenu.add(closePersAction); windowMenu.add(closeAllPersAction); //Register global actions configurer.registerGlobalAction(resetPersAction); configurer.registerGlobalAction(closePersAction); configurer.registerGlobalAction(closeAllPersAction); I have posted this issue to the RCP news group and received a reply stating that the enablement of these actions should be handled by the RCP developer. However, the ActionFactory API suggests that these actions maintain their enablement state.
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java
}
    /**
     * Enables the menu items dependent on an active
     * page and perspective.
     * Note, the show view action already does its own 
     * listening so no need to do it here.
     */
    private void enableActions(boolean value) {
        hideShowEditorAction.setEnabled(value);
        savePerspectiveAction.setEnabled(value);
        lockToolBarAction.setEnabled(value);
        resetPerspectiveAction.setEnabled(value);
        editActionSetAction.setEnabled(value);
        closePerspAction.setEnabled(value);
        closeAllPerspsAction.setEnabled(value);
        newWizardDropDownAction.setEnabled(value);
        
        newWizardAction.setEnabled(value);
        importResourcesAction.setEnabled(value);
        exportResourcesAction.setEnabled(value);
    }
    public void fillActionBars(int flags) {
        super.fillActionBars(flags);
        if ((flags & FILL_PROXY) == 0) {
            updateBuildActions();
            hookListeners();
        }
    }
    /**
     * Fills the coolbar with the workbench actions.