Bug 70088 [Actions] ActionContributionItem.fill(Composite) creates button with wrong text
1. Create an action with setText ("&Go@Ctrl+G"); 2. Use ActionContributionItem.fill(Composite) to create a button 3. The label of the button will be "_G_o@Ctrl+G" Looking at the source, it seems that the code which handles the text for buttons doesn't take the accelerator in account. Quick fix: Remove any text after the @ (incl) in the "set text for button" code. Suggested fix: Remove the ugly "@text" hack and use the real accelerator (set with setAccelerator()) instead (removes code duplication, too).
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java
private static final int LOWER_GTK_ACCEL_BOUND = SWT.MOD1 | SWT.MOD2 | 'A';
    /**
     * This is the lower bound of the continuous range of accelerator values
     * that should be handled specially on GTK.  This is to circumnavigate the
     * special input mode in some cases.
     */
    private static final int UPPER_GTK_ACCEL_BOUND = SWT.MOD1 | SWT.MOD2 | 'F';
    
    private static final String ellipsis = "..."; 
    private static boolean USE_COLOR_ICONS = true;
    /**
     * Returns whether color icons should be used in toolbars.
     * 
     * @return <code>true</code> if color icons should be used in toolbars, 
     *   <code>false</code> otherwise
     */
    public static boolean getUseColorIconsInToolbars() {
        return USE_COLOR_ICONS;
    }
    /**
     * Sets whether color icons should be used in toolbars.
     * 
     * @param useColorIcons <code>true</code> if color icons should be used in toolbars, 
     *   <code>false</code> otherwise
     */
    public static void setUseColorIconsInToolbars(boolean useColorIcons) {
        USE_COLOR_ICONS = useColorIcons;
    }
    /**
     * The presentation mode.