Bug 252940 [Dialogs] DialogPage's dispose() method has a false javadoc specification
The DialogPage class's dispose() method is spec'ed as... /** * The <code>DialogPage</code> implementation of an * <code>IDialogPage</code> method does nothing. Subclasses may extend. */ ...unfortunately, the truth is that it actually does something rather important. public void dispose() { // deallocate SWT resources if (image != null) { image.dispose(); image = null; } } I am marking this as major since unwary subclasses that extends this method without calling super.dispose() will end up having a memory leak.
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogPage.java
*/
    private FontMetrics fontMetrics;
    /**
     * Creates a new empty dialog page.
     */
    protected DialogPage() {
        
    }
    /**
     * Creates a new dialog page with the given title.
     * 
     * @param title
     *            the title of this dialog page, or <code>null</code> if none
     */
    protected DialogPage(String title) {
        this.title = title;
    }
    /**
     * Creates a new dialog page with the given title and image.
     * 
     * @param title
     *            the title of this dialog page, or <code>null</code> if none
     * @param image
     *            the image for this dialog page, or <code>null</code> if none
     */
    protected DialogPage(String title, ImageDescriptor image) {
        this(title);
        imageDescriptor = image;
    }
    /**