Bug 82706 [Wizards] WizardDialog: code inconsistent
As long as WizardDialog.updateTitleBar() is a public method (should it be?) it's not a bad idea to check dialog state in all appropriate places. Now: public void updateTitleBar() { String s = null; if(currentPage != null) s = currentPage.getTitle(); if (s == null) s = ""; //$NON-NLS-1$ setTitle(s); if(currentPage != null) setTitleImage(currentPage.getImage()); updateDescriptionMessage(); updateMessage(); } It accurately checks that currentPage != null, but forgets to do the same before calling of updateDescriptionMessage() method wich works with currentPage without any checking. This can cause NPE (which happened to me :-)).
bundles/org.eclipse.jface/src/org/eclipse/jface/wizard/WizardDialog.java
/**
         * The margin width; <code>5</code> pixels by default.
         */
        public int marginWidth = 5;
        /**
         * The margin height; <code>5</code> pixels by default.
         */
        public int marginHeight = 5;
        /**
         * The minimum width; <code>0</code> pixels by default.
         */
        public int minimumWidth = 0;
        /**
         * The minimum height; <code>0</code> pixels by default.