Bug 328221 Several error messages are confusing/useless
Build Identifier: BIRT 2.5.2 I've fixed a couple of error messages in BIRT 2.5.2 which are confusing/useless. See the attached patches. I'm aware that this patch is for an old version of BIRT but maybe they are still useful for someone stuck with BIRT 2.5.2. I didn't check whether the errors are still there in 2.6; feel free to have a look. Bugs fixed: 1. When a pre-compiled method is run and an error happens, the source of the method is included (so you get more than "There was an error in __bm_OPEN"). 2. Instead of "data.engine.BadFetchScriptReturnType", you get a real error message with the method name and the value returned. 3. If logging is enabled for jdbc.Statement, the log would fill with thousands of stack traces warning that "setSpecification is not supported." Feel free to use the patches in any legal way. Reproducible: Always
data/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/i18n/ResourceConstants.java
public final static String INVALID_BOUND_COLUMN_NAME = "data.engine.InvalidBoundColumnName";
	public final static String INVALID_GROUP_KEY = "data.engine.InvalidGroupKey";
	public final static String COLUMN_BINDING_NOT_EXIST = "data.engine.ColumnBindingNotExist";
	public final static String COLUMN_BINDING_CYCLE = "data.engine.ColumnBindingCycle";
	public final static String COLUMN_BINDING_REFER_TO_INEXIST_COLUMN = "data.engine.ColumnBindingReferToInexistColumn";
	public final static String COLUMN_BINDING_REFER_TO_INEXIST_BINDING = "data.engine.ColumnBindingReferToInexistBinding";
	public final static String COLUMN_BINDING_REFER_TO_AGGREGATION_COLUMN_BINDING_IN_PARENT_QUERY = "data.engine.ColumnBindingReferToAggregationColumnBindingInParentQuery";
	public final static String READ_COLUMN_VALUE_FROM_DOCUMENT_ERROR = "data.engine.ReadColumnValueFromDocumentError";
	public final static String NO_OUTER_RESULTS_EXIST = "data.engine.NoOuterResultsExist";
	public final static String DUPLICATED_BINDING_NAME = "data.engine.DuplicatedBindingName";
	public final static String INVALID_AGGR_LEVEL_IN_SUMMARY_QUERY = "data.engine.InvalidAggrLevelKeyInSummaryQuery";
	
	public final static String EXPR_INVALID_COMPUTED_COLUMN= "data.engine.BadCompColExpr";
	public final static String COMPUTED_COLUMN_CYCLE = "data.engine.ComputedColumnCycle";
	
	
	public final static String FAIL_RETRIEVE_VALUE_COMPUTED_COLUMN= "data.engine.CompCol.FailRetrieveValueComputedColumn";
	public final static String WRONG_SYSTEM_COMPUTED_COLUMN= "data.engine.ScriptResult.WrongSystemComputedColumn";
	
	public final static String SORT_ON_AGGR = "data.engine.SortOnAggregation";
	
	
	public final static String INVALID_EXPRESSION_IN_FILTER = "data.engine.BadFilterExpr";
	public final static String INVALID_DEFINITION_IN_FILTER = "data.engine.BadFilterDefn";
	public final static String BAD_GROUP_EXPRESSION = "data.engine.BadGroupExpr";
	public final static String FILTER_EXPR_CONTAIN_ROW_NUM = "data.engine.filterExprContainRowNum";
	public final static String SORT_EXPR_CONTAIN_ROW_NUM = "data.engine.sortExprContainRowNum";
	
	
	public final static String CLOB_OPEN_ERROR = "data.engine.opencloberror";