Bug 60785 [Preferences] [Javadoc] Review of org.eclipse.jface.preference
Warnings: IPreferenceStore.java:379: warning - @param argument "value" is not a parameter name. BooleanFieldEditor.java:80: warning - @param argument "labelText" is not a parameter name. ColorSelector.java:63: warning - @param argument "parent." is not a parameter name. ColorSelector.java:192: warning - @param argument "rgb." is not a parameter name. FieldEditor.java:596: warning - @param argument "Button" is not a parameter name. FieldEditor.java:619: warning - @param argument "boolean." is not a parameter name. FieldEditor.java:619: warning - @param argument "parent." is not a parameter name. FileFieldEditor.java:143: warning - @param argument "extension" is not a parameter name. PreferenceConverter.java:45: warning - @issue is an unknown tag. PreferenceDialog.java:202: warning - @param argument "shell" is not a parameter name. PreferenceDialog.java:836: warning - @param argument "errorMessage" is not a parameter name. PreferenceNode.java:109: warning - @param argument "page" is not a parameter name. PreferenceStore.java:432: warning - @param argument "filename" is not a parameter name. StringFieldEditor.java:289: warning - @param argument "parent" is not a parameter name. BooleanPropertyAction: - BooleanPropertyAction has no description. - run() is not documented. ColorFieldEditor: - Class description is incomplete or just missing a period. - getColorSelector() is undocumented. - getNumberOfControls() has an incomplete description. ColorSelector: - updateColorImage() description ends in a comma. FieldEditorPreferencePage: - applyFont() is undocumented. PreferenceContentProvider: - All methods are undocumented. PreferenceDialog: - Undocumented methods: close(), configureShell(), constrainShellSize(), createTreeAreaContents(), getSingleSelection(), getTreeViewer(), layoutTreeAreaControl(). PreferenceLabelProvider: - All methods are undocumented. StringButtonFieldEditor: - getChangeControl() is undocumented. JFacePreferences: - *_COLOR undocumented.
bundles/org.eclipse.jface/src/org/eclipse/jface/preference/FieldEditor.java
* Informs this field editor's listener, if it has one, about a change to
 * one of this field editor's boolean-valued properties. Does nothing
 * if the old and new values are the same.
 *
 * @param property the field editor property name, 
 *   such as <code>VALUE</code> or <code>IS_VALID</code>
 * @param oldValue the old value
 * @param newValue the new value
 */
protected void fireStateChanged(String property, boolean oldValue, boolean newValue) {
	if (oldValue == newValue)
		return;
	fireValueChanged(property, new Boolean(oldValue), new Boolean(newValue));
}
/**
 * Informs this field editor's listener, if it has one, about a change to
 * one of this field editor's properties.
 *
 * @param property the field editor property name, 
 *   such as <code>VALUE</code> or <code>IS_VALID</code>
 * @param oldValue the old value object, or <code>null</code>
 * @param newValue the new value, or <code>null</code>
 */
protected void fireValueChanged(String property, Object oldValue, Object newValue) {
	if (propertyChangeListener == null)
		return;
	propertyChangeListener.propertyChange(new PropertyChangeEvent(this, property, oldValue, newValue));
}
/**
 * Returns the symbolic font name used by this field editor.