Bug 238162 [RCP] Remove dependency on org.eclipse.update.core
Build: 3.4 final I noticed while browsing code that IDEWorkbenchAdvisor has a method "checkUpdates" which makes a call to update manager API (SiteManager.handleNewChanges()). Looking through the history, I see this SiteManager.handleNewChanges() method has had an empty body since the 3.0 release, so it's a no-op to call it. This reference should be removed because it allows org.eclipse.ui.ide.application to remove its dependency on org.eclipse.update.*. We will be gradually removing dependencies on classic update and this one is an easy place to start.
bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java
if (!hasIntro()) {
				Map m = getNewlyAddedBundleGroups();
				ArrayList list = new ArrayList(m.size());
				for (Iterator i = m.values().iterator(); i.hasNext();) {
					AboutInfo info = (AboutInfo) i.next();
					if (info != null && info.getWelcomePerspectiveId() != null
							&& info.getWelcomePageURL() != null) {
						list.add(info);
					}
				}
				welcomePerspectiveInfos = new AboutInfo[list.size()];
				list.toArray(welcomePerspectiveInfos);
			}
		}
		return welcomePerspectiveInfos;
	}
	/*
	 * (non-Javadoc)
	 * 
	 * @see org.eclipse.ui.application.WorkbenchAdvisor#getWorkbenchErrorHandler()
	 */
	public AbstractStatusHandler getWorkbenchErrorHandler() {
		if (ideWorkbenchErrorHandler == null) {
			ideWorkbenchErrorHandler = new IDEWorkbenchErrorHandler(
					getWorkbenchConfigurer());
		}
		return ideWorkbenchErrorHandler;
	}
}