Bug 83059 [RCP] No enablement of perspective menu items
RCP application using factory methods to create menu items for Close Perspective , Close All Perspectives, Reset Perspective, etc. does not maintain enablement state of actions. This code in WorkbenchAdvisor's fillActionBars() method recreates the problem: //Use standard factory methods for actions IWorkbenchAction resetPersAction = ActionFactory.RESET_PERSPECTIVE.create(window); IWorkbenchAction closePersAction = ActionFactory.CLOSE_PERSPECTIVE.create(window); IWorkbenchAction closeAllPersAction = ActionFactory.CLOSE_ALL_PERSPECTIVES.create(window); //Create menu items IMenuManager mgr = configurer.getMenuManager(); MenuManager windowMenu = new MenuManager("&Window", IWorkbenchActionConstants.M_WINDOW); mgr.add(windowMenu); windowMenu.add(resetPersAction); windowMenu.add(closePersAction); windowMenu.add(closeAllPersAction); //Register global actions configurer.registerGlobalAction(resetPersAction); configurer.registerGlobalAction(closePersAction); configurer.registerGlobalAction(closeAllPersAction); I have posted this issue to the RCP news group and received a reply stating that the enablement of these actions should be handled by the RCP developer. However, the ActionFactory API suggests that these actions maintain their enablement state.
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java
register(revertAction);
        refreshAction = ActionFactory.REFRESH.create(window);
        register(refreshAction);
        propertiesAction = ActionFactory.PROPERTIES.create(window);
        register(propertiesAction);
        quitAction = ActionFactory.QUIT.create(window);
        register(quitAction);
        moveAction = ActionFactory.MOVE.create(window);
        register(moveAction);
        renameAction = ActionFactory.RENAME.create(window);
        register(renameAction);
        goIntoAction = ActionFactory.GO_INTO.create(window);
        register(goIntoAction);
        backAction = ActionFactory.BACK.create(window);
        register(backAction);
        forwardAction = ActionFactory.FORWARD.create(window);
        register(forwardAction);
        upAction = ActionFactory.UP.create(window);
        register(upAction);
        nextAction = ActionFactory.NEXT.create(window);
        nextAction
                .setImageDescriptor(IDEInternalWorkbenchImages
                        .getImageDescriptor(IDEInternalWorkbenchImages.IMG_ETOOL_NEXT_NAV));
        register(nextAction);
        previousAction = ActionFactory.PREVIOUS.create(window);
        previousAction
                .setImageDescriptor(IDEInternalWorkbenchImages
                        .getImageDescriptor(IDEInternalWorkbenchImages.IMG_ETOOL_PREVIOUS_NAV));
        register(previousAction);
        buildProjectAction = IDEActionFactory.BUILD_PROJECT.create(window);