Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/resource/JFaceColors.java
}
    /**
     * Dispose of all allocated colors. Called on workbench
     * shutdown.
     * 
     * @deprecated JFaceColors no longer maintains a cache of colors.  This job 
     * is now handled by the ColorRegistry.
     */
    public static void disposeColors() {
        
    }
    /**
     * Set the foreground and background colors of the
     * control to the specified values. If the values are
     * null than ignore them.
     * 
     * @param foreground Color
     * @param background Color
     */
    public static void setColors(Control control, Color foreground,
            Color background) {
        if (foreground != null) {
			control.setForeground(foreground);
		}
        if (background != null) {
			control.setBackground(background);
		}
    }
}