Bug 92564 [Viewers] (doc only) incorrect use of html in javadoc of BackgroundContentProvider
Version: 3.1.0 Build id: I20050419-1200 The section that is explaining the information flow is not correctly defining the ordered list. Each item should be wrapped in a 'li', not an 'ol'. Index: BackgroundContentProvider.java =================================================================== RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java,v retrieving revision 1.4 diff -u -r1.4 BackgroundContentProvider.java --- BackgroundContentProvider.java 28 Mar 2005 14:57:36 -0000 1.4 +++ BackgroundContentProvider.java 25 Apr 2005 11:13:00 -0000 @@ -38,12 +38,12 @@ * <p> * Information flow is like this: * </p> - * <ol>IConcurrentModel sends unordered elements to BackgroundContentProvider (in a background thread)</ol> - * <ol>BackgroundContentProvider sorts, filters, and sends element/index pairs to - * ConcurrentTableUpdator (in a background thread)</ol> - * <ol>ConcurrentTableUpdator batches the updates and sends them to an AbstractVirtualTable - * (in the UI thread)</ol> - * <li> + * <ol> + * <li>IConcurrentModel sends unordered elements to BackgroundContentProvider (in a background thread)</li> + * <li>BackgroundContentProvider sorts, filters, and sends element/index pairs to + * ConcurrentTableUpdator (in a background thread)</li> + * <li>ConcurrentTableUpdator batches the updates and sends them to an AbstractVirtualTable + * (in the UI thread)</li> * </ol> * * <p>
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java
changeQueue.enqueue(ChangeQueue.REMOVE, toRemove);
        makeDirty();
        refresh();
    }
    /**
     * Notifies the updator that the given elements have changed 
     * 
     * @param toFlush changed elements
     * @param collection collection of currently-known elements
     */
    private void flush(Object[] toFlush, LazySortedCollection collection) {
        for (int i = 0; i < toFlush.length; i++) {
            Object item = toFlush[i];
            
            if (collection.contains(item)) {
                updator.clear(item);
            }
        }
    }
    /**
     * Called when elements in the model change
     * 
     * @param items changed items
     */
    private void update(Object[] items) {
        changeQueue.enqueue(ChangeQueue.UPDATE, items);
        makeDirty();
    }
}