Bug 283359 [Browser] WebBrowserEditorInput#equals(Object) is wrong
Build ID: 3.2.201.v20080708_34x Steps To Reproduce: Looking at the WebBrowserEditorInput#equals(Object) method in 3.2.201.v20080708_34x version of the org.eclipse.ui.browser (similarly in the head), there are few issues: 1) The javadoc is wrong, and it doesn't make sense. 2) The line: if (url != null && !url.equals(obj)) should be if (url != null && !url.equals(other.url)) For reference, I'm pasting the contents of the equals method: /** * Indicates whether some other object is "equal to" this one. In this case * it means that the underlying IFolders are equal. */ public boolean equals(Object obj) { if (this == obj) return true; if (!(obj instanceof WebBrowserEditorInput)) return false; WebBrowserEditorInput other = (WebBrowserEditorInput) obj; if (url != null && !url.equals(obj)) return false; return canReplaceInput(other); } More information:
bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java
if (input.isStatusbarVisible() != isStatusbarVisible())
			return false;
		else if (id != null) {
			String bid = input.getBrowserId();
			return id.equals(bid);
		} else
			return false;
	}
	/**
	 * Creates an <code>IElement</code> from the state captured within an
	 * <code>IMemento</code>.
	 * 
	 * @param memento
	 *            a memento containing the state for an element
	 * @return an element, or <code>null</code> if the element could not be
	 *         created
	 */
	public IAdaptable createElement(IMemento memento) {
		int style = 0;
		Integer integer = memento.getInteger(MEMENTO_STYLE);
		if (integer != null) {
			style = integer.intValue();
		}
		URL url = null;
		String str = memento.getString(MEMENTO_URL);
		if (str != null) {