Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/action/SubContributionManager.java
if (result == null) {
			return null;
		}
        itemRemoved(item);
        return item;
    }
    /* (non-Javadoc)
     * Method declared on IContributionManager.
     */
    public void removeAll() {
        Iterator it = mapItemToWrapper.values().iterator();
        while (it.hasNext()) {
            IContributionItem item = (IContributionItem) it.next();
            parentMgr.remove(item);
        }
        mapItemToWrapper.clear();
    }
    /**
     * Sets the visibility of the manager.  If the visibility is <code>true</code>
     * then each item within the manager appears within the parent manager.
     * Otherwise, the items are not visible.
     *
     * @param visible the new visibility
     */
    public void setVisible(boolean visible) {
        this.visible = visible;
        if (mapItemToWrapper.size() > 0) {
            Iterator it = mapItemToWrapper.values().iterator();
            while (it.hasNext()) {
                IContributionItem item = (IContributionItem) it.next();