Bug 238452 [Browser] External browser parameters are not passed to external browser
Build ID: I20080609-1311 Steps To Reproduce: 1.When I set values in to the Edit External Web Browser dialog from Window->Preferences->General->WebBrowser->Use external web browse->Edit these parameters have no effect. 2. 3. More information: The buggy code is in org.eclipse.ui.internal.browser.browsers.MozillaFactory.createBrowser(String, String, String) public IWebBrowser createBrowser(String id, String location, String parameters) { // Create single browser for all clients if (browserInstance == null) { browserInstance = new MozillaBrowser(id, location); } return browserInstance; } Parameters are ignored
bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/MozillaBrowser.java
waitForBrowser();
			if (exitRequested)
				return;
			if (firstLaunch && Platform.OS_WIN32.equals(Platform.getOS())) {
				if (openBrowser(executable + " " + url) == 0) 
					return;
				browserFullyOpenedAt = System.currentTimeMillis() + DELAY;
				return;
			}
			if (openBrowser(executable + " -remote openURL(" + url + ")") 
					== 0)
				return;
			
			if (exitRequested)
				return;
			browserFullyOpenedAt = System.currentTimeMillis() + DELAY;
			openBrowser(executable + " " + url); 
		}
		private void waitForBrowser() {
			while (System.currentTimeMillis() < browserFullyOpenedAt)
				try {
					if (exitRequested)
						return;
					Thread.sleep(100);
				} catch (InterruptedException ie) {
					
				}
		}
	}
}