Bug 308975 Can't recover from 'invalid' path variable
If a path variable is 'corrupted', the user is unable to recover. Steps to reproduce: 1) new path variable: PROJ_UP = ${PROJECT_LOC}/../ 2) You end up with this in your .project file: <variableList> <variable> <name>PROJ_UP</name> <value>$%7BPARENT-1-PROJECT_LOC%7D</value> </variable> </variableList> In e4 this was a more human readable: <variableList> <variable> <name>PROJ_UP</name> <value>${PARENT-1-PROJECT_LOC}</value> </variable> </variableList> If you change the .project file to contain the above, the Linked Resource property page is no longer accessible, and there's no indication of what went wrong. java.lang.IllegalArgumentException at java.net.URI.create(URI.java:842) at org.eclipse.core.internal.resources.ProjectPathVariableManager.getURIValue(ProjectPathVariableManager.java:123) at org.eclipse.ui.internal.ide.dialogs.PathVariablesGroup.initTemporaryState(PathVariablesGroup.java:542) at org.eclipse.ui.internal.ide.dialogs.PathVariablesGroup.setResource(PathVariablesGroup.java:727) at org.eclipse.ui.internal.ide.dialogs.ProjectLinkedResourcePage.createContents(ProjectLinkedResourcePage.java:66) at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:232) at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1501) at org.eclipse.jface.preference.PreferenceDialog$14.run(PreferenceDialog.java:1258) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/PathVariablesGroup.java
import java.util.SortedMap;
import java.util.TreeMap;
import org.eclipse.core.filesystem.IFileInfo;
import org.eclipse.core.filesystem.URIUtil;
import org.eclipse.core.resources.IPathVariableManager;
import org.eclipse.core.resources.IResource;
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.Path;
import org.eclipse.jface.dialogs.Dialog;
import org.eclipse.jface.dialogs.ErrorDialog;
import org.eclipse.jface.dialogs.IDialogConstants;
import org.eclipse.jface.layout.TableColumnLayout;
import org.eclipse.jface.resource.ImageDescriptor;
import org.eclipse.jface.viewers.CellLabelProvider;
import org.eclipse.jface.viewers.ColumnViewerToolTipSupport;
import org.eclipse.jface.viewers.ColumnWeightData;
import org.eclipse.jface.viewers.IStructuredContentProvider;
import org.eclipse.jface.viewers.TableViewer;
import org.eclipse.jface.viewers.TableViewerColumn;
import org.eclipse.jface.viewers.Viewer;
import org.eclipse.jface.viewers.ViewerCell;
import org.eclipse.jface.window.ToolTip;
import org.eclipse.jface.window.Window;
import org.eclipse.osgi.util.NLS;
import org.eclipse.osgi.util.TextProcessor;
import org.eclipse.swt.SWT;
import org.eclipse.swt.events.MouseEvent;
import org.eclipse.swt.events.MouseListener;