Bug 126155 [Markers] Issues of multi quick fix dialog
I20060131-1200 Here are a few things to improve in the multi quickfix dialog (problems view -> Quick fix on a missing SUID problem) - Description of the dialog ("Select the fix for...") should put the problem message in quotes to make it more readable. - What about an icon in the title area? We have not other dialogs like this which do not show an icon in the title area. - Either use "resolution" or "fix" as term for the offered proposal. I'd suggest to use fix (e.g. in "Select a resolution:") - Perhaps "Add Matching Problems" is not that clear. It is more something like searching for similar problems which can be fixed the same way, e.g. "Find similar problems" - The progress message which appears when clicking on "Add Matching Problems" ("Calculating Possible Resolutions working on...") should better rephrased to "Searching for similar problems..." - After having clicked on "Add Matching Problems", this button gets disabled. As soon as the selection is changed, it is reenabled again. I suggest to enable this button once for a specific fix to let the user find similar problems, and cache the results.
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerResolutionDialog.java
import org.eclipse.jface.viewers.ListViewer;
import org.eclipse.jface.viewers.SelectionChangedEvent;
import org.eclipse.jface.viewers.Viewer;
import org.eclipse.jface.viewers.ViewerSorter;
import org.eclipse.jface.wizard.ProgressMonitorPart;
import org.eclipse.osgi.util.NLS;
import org.eclipse.swt.SWT;
import org.eclipse.swt.custom.BusyIndicator;
import org.eclipse.swt.events.SelectionAdapter;
import org.eclipse.swt.events.SelectionEvent;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.layout.FormAttachment;
import org.eclipse.swt.layout.FormData;
import org.eclipse.swt.layout.FormLayout;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
import org.eclipse.swt.widgets.Button;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.ui.IMarkerResolution;
import org.eclipse.ui.views.markers.WorkbenchMarkerResolution;
/**
 * The MarkerResolutionDialog is the dialog used to select a marker resolution.
 * 
 * @since 3.2
 * 
 */
public class MarkerResolutionDialog extends TitleAreaDialog {