Bug 197475 [TrayDialog] Redundant check in isCompatibleLayout
Build ID: Build id: I20070621-1340 Inside TrayDialog#isCompatibleLayout(Layout layout) there is redundant check (grid.horizontalSpacing == 0). (line 237) Possible there should be (grid.verticalSpacing == 0). :)
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/TrayDialog.java
/**
	 * Creates a tray dialog instance. Note that the window will have no visual
	 * representation (no widgets) until it is told to open.
	 * 
	 * @param shell the parent shell, or <code>null</code> to create a top-level shell
	 */
	protected TrayDialog(Shell shell) {
		super(shell);
	}
	
	/**
	 * Creates a tray dialog with the given parent.
	 * 
	 * @param parentShell the object that returns the current parent shell
	 */
	protected TrayDialog(IShellProvider parentShell) {
		super(parentShell);
	}
	/**
	 * Closes this dialog's tray, disposing its widgets.
	 * 
	 * @throws IllegalStateException if the tray was not open
	 */
	public void closeTray() throws IllegalStateException {
		if (getTray() == null) {
			throw new IllegalStateException("Tray was not open"); 
		}
		int trayWidth = trayControl.getSize().x + leftSeparator.getSize().x + sash.getSize().x + rightSeparator.getSize().x;
		trayControl.dispose();
		trayControl = null;