Bug 238452 [Browser] External browser parameters are not passed to external browser
Build ID: I20080609-1311 Steps To Reproduce: 1.When I set values in to the Edit External Web Browser dialog from Window->Preferences->General->WebBrowser->Use external web browse->Edit these parameters have no effect. 2. 3. More information: The buggy code is in org.eclipse.ui.internal.browser.browsers.MozillaFactory.createBrowser(String, String, String) public IWebBrowser createBrowser(String id, String location, String parameters) { // Create single browser for all clients if (browserInstance == null) { browserInstance = new MozillaBrowser(id, location); } return browserInstance; } Parameters are ignored
bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/ExternalBrowserInstance.java
while (index >= 0) {
				urlText = urlText.substring(0, index)
						+ "%20" + urlText.substring(index + 1); 
				index = urlText.indexOf(" "); 
			}
		}
		String location = browser.getLocation();
		String parameters = browser.getParameters();
		Trace
				.trace(
						Trace.FINEST,
						"Launching external Web browser: " + location + " - " + parameters + " - " + urlText); 
		String params = parameters;
		if (params == null)
			params = ""; 
		if (urlText != null) {
			int urlIndex = params.indexOf(IBrowserDescriptor.URL_PARAMETER);
			if (urlIndex >= 0)
				params = params.substring(0, urlIndex)
						+ " " + urlText + " " + params.substring(urlIndex + IBrowserDescriptor.URL_PARAMETER.length()); 
			else {
				if (!params.endsWith(" ")) 
					params += " ";  
				params += urlText;
			}
		}
		try {
			Trace.trace(Trace.FINEST, "Launching " + location + " " + params); 
			if (params == null || params.length() == 0)
				process = Runtime.getRuntime().exec(location);