Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/ProgressMonitorDialog.java
private boolean fIsCanceled;
        protected boolean forked = false;
        protected boolean locked = false;
        public void beginTask(String name, int totalWork) {
            if (progressIndicator.isDisposed()) {
				return;
			}
            if (name == null) {
				task = "";
			} else {
				task = name;
			}
            String s = task;
            if (s.length() <= 0) {
				s = DEFAULT_TASKNAME;
			}
            setMessage(s);
            if (!forked) {
				update();
			}
            if (totalWork == UNKNOWN) {
                progressIndicator.beginAnimatedTask();
            } else {
                progressIndicator.beginTask(totalWork);
            }
        }
        public void done() {
            if (!progressIndicator.isDisposed()) {
                progressIndicator.sendRemainingWork();
                progressIndicator.done();