Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/resource/AbstractResourceManager.java
return;
        }
        
        Collection entries = map.entrySet();
        for (Iterator iter = entries.iterator(); iter.hasNext();) {
            Map.Entry next = (Map.Entry) iter.next();
            
            Object key = next.getKey();
            RefCount val = (RefCount)next.getValue();
            
            deallocate(val.resource, (DeviceResourceDescriptor)key);
        }
        
        map = null;
    }
    
    /* (non-Javadoc)
     * @see org.eclipse.jface.resource.ResourceManager#find(org.eclipse.jface.resource.DeviceResourceDescriptor)
     */
    public Object find(DeviceResourceDescriptor descriptor) {
        if (map == null) {
            return null;
        }
        RefCount refCount = (RefCount)map.get(descriptor);
        if (refCount == null)
        	return null;
		return refCount.resource;
    }
}