Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java
}
            }
        }
    }
    /* (non-Javadoc)
     * Method declared on Object.
     */
    public int hashCode() {
        return action.hashCode();
    }
    /**
     * Returns whether the given action has any images.
     * 
     * @param actionToCheck the action
     * @return <code>true</code> if the action has any images, <code>false</code> if not
     */
    private boolean hasImages(IAction actionToCheck) {
        return actionToCheck.getImageDescriptor() != null
                || actionToCheck.getHoverImageDescriptor() != null
                || actionToCheck.getDisabledImageDescriptor() != null;
    }
    /**
     * Returns whether the command corresponding to this action
     * is active.
     */
    private boolean isCommandActive() {
        IAction actionToCheck = getAction();
        if (actionToCheck != null) {
            String commandId = actionToCheck.getActionDefinitionId();
            ExternalActionManager.ICallback callback = ExternalActionManager