Bug 58985 [Dialogs] WizardDialog.getButton( IDialogConstants.CANCLE_ID ) always returns null
Here's a test case for this bug. Watch the stdout of the program. --WizardDialogBug import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.wizard.IWizard; import org.eclipse.jface.wizard.Wizard; import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.jface.wizard.WizardPage; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Shell; public class WizardDialogBug { public static void main(String[] args) { WizardDialogBug wizardDialogBug = new WizardDialogBug(); wizardDialogBug.run(); } public void run() { Display display = new Display(); Shell shell = new Shell( display, SWT.NONE ); TestWizard wizard = new TestWizard(); TestWizardDialog dialog = new TestWizardDialog( shell, wizard ); dialog.setBlockOnOpen( false ); dialog.open(); while( !shell.isDisposed() ) if( !display.readAndDispatch() ) display.sleep(); display.dispose(); } // test WizardPage public class TestWizardPage extends WizardPage { public TestWizardPage() { super( "TestWizardPage" ); } public void createControl(Composite parent) { Button b = new Button( parent, SWT.PUSH ); b.setText( "Button" ); setControl( b ); } } // test Wizard public class TestWizard extends Wizard { public TestWizard() { super(); setWindowTitle( "TestWizard" ); } public void addPages() { addPage( new TestWizardPage() ); } public boolean performFinish() { return false; } } // test WizardDialog public class TestWizardDialog extends WizardDialog { public TestWizardDialog( Shell shell, IWizard wizard ) { super( shell, wizard ); } public int open() { int rc = super.open(); // by now, all controls should have been created; System.out.println( getButton( IDialogConstants.FINISH_ID ) ); System.out.println( getButton( IDialogConstants.CANCEL_ID ) ); return rc; } } }
bundles/org.eclipse.jface/src/org/eclipse/jface/wizard/WizardDialog.java
}
	/**
	 * Allow the wizard's pages to pre-create their page controls.
	 * This allows the wizard dialog to open to the correct size.
	 */
	private void createPageControls() {
		
		
		wizard.createPageControls(pageContainer);
		
		IWizardPage[] pages = wizard.getPages();
		for (int i = 0; i < pages.length; i++) {
			IWizardPage page = pages[i];
			if (page.getControl() != null)
				page.getControl().setVisible(false);
		}
	}
	/**
	 * Creates the Previous and Next buttons for this wizard dialog.
	 * Creates standard (<code>SWT.PUSH</code>) buttons and registers for their
	 * selection events. Note that the number of columns in the button bar composite
	 * is incremented. These buttons are created specially to prevent any space 
	 * between them.
	 *
	 * @param parent the parent button bar
	 * @return a composite containing the new buttons
	 */
	private Composite createPreviousAndNextButtons(Composite parent) {
		
		((GridLayout) parent.getLayout()).numColumns++;