Bug 50151 Using SWT.RIGHT on a ToolBar leaves blank space
build I20040113 - changed the RCP Browser example to create its ToolBar using SWT.FLAT | SWT.RIGHT - the ToolBar has 4 ToolItems: Back (image only), Forward (image only), Stop (text only) and Refresh (text only) - when it comes up, the Back and Forward items have a fair bit of blank space after the arrow images (see attached screen shot) From scanning MSDN, it seems like this is platform behaviour on Windows, but it's almost certainly not what an app wants. I think that many RCP apps will want this style, with tool items having mixed icons and text, with no extra blank spaces (compare with IE).
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java
mi.addListener(SWT.Dispose, getMenuItemListener());
			mi.addListener(SWT.Selection, getMenuItemListener());
			if (action.getHelpListener() != null)
				mi.addHelpListener(action.getHelpListener());
			if (subMenu != null)
				mi.setMenu(subMenu);
			update(null);
			action.addPropertyChangeListener(propertyListener);
		}
	}
	/**
	 * The <code>ActionContributionItem</code> implementation of this ,
	 * <code>IContributionItem</code> method creates an SWT <code>ToolItem</code>
	 * for the action using the action's style. If the action's checked property has
	 * been set, a button is created and primed to the value of the checked
	 * property. If the action's menu creator property has been set, a drop-down
	 * tool item is created.
	 */
	public void fill(ToolBar parent, int index) {
		if (widget == null && parent != null) {
			int flags = SWT.PUSH;
			if (action != null) {
				int style = action.getStyle();
				if (style == IAction.AS_CHECK_BOX)
					flags = SWT.CHECK;
				else if (style == IAction.AS_RADIO_BUTTON)
					flags = SWT.RADIO;
				else if (style == IAction.AS_DROP_DOWN_MENU)
					flags = SWT.DROP_DOWN;
			}