Bug 238162 [RCP] Remove dependency on org.eclipse.update.core
Build: 3.4 final I noticed while browsing code that IDEWorkbenchAdvisor has a method "checkUpdates" which makes a call to update manager API (SiteManager.handleNewChanges()). Looking through the history, I see this SiteManager.handleNewChanges() method has had an empty body since the 3.0 release, so it's a no-op to call it. This reference should be removed because it allows org.eclipse.ui.ide.application to remove its dependency on org.eclipse.update.*. We will be gradually removing dependencies on classic update and this one is an easy place to start.
bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java
/*******************************************************************************
 * Copyright (c) 2003, 2008 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html
 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *******************************************************************************/
package org.eclipse.ui.internal.ide.application;
import java.lang.reflect.InvocationTargetException;
import java.net.URL;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.Map;
import java.util.TreeMap;
import org.eclipse.core.net.proxy.IProxyService;
import org.eclipse.core.resources.IContainer;
import org.eclipse.core.resources.IResource;
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.resources.WorkspaceJob;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.FileLocator;