Bug 87826 Need to improve image loading in Workbench
The Workbench image loading has several issues 1) The string "icons/full" is all over the place in the UI and should be made a constant 2) This needs to be prepended by /nl 3) The plugin descriptor is still in use to load images. This does not support nl which is required for BIDI support
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkbenchAdvisor.java
WorkbenchAdapterBuilder.registerAdapters();
        
        String[] cmdLineArgs = Platform.getCommandLineArgs();
         
        
        for (int i = 0; i < cmdLineArgs.length; i++) {
            if ("-showlocation".equalsIgnoreCase(cmdLineArgs[i])) { 
                workspaceLocation = Platform.getLocation().toOSString();
                break;
            }
        }
        
        declareWorkbenchImages();
        
        activityHelper = IDEWorkbenchActivityHelper.getInstance();
    }
    /* (non-Javadoc)
     * @see org.eclipse.ui.application.WorkbenchAdvisor#preStartup()
     */
    public void preStartup() {
        
        Platform.getJobManager().suspend();
        
        IProgressService service = PlatformUI.getWorkbench()
                .getProgressService();
        ImageDescriptor newImage = IDEInternalWorkbenchImages
                .getImageDescriptor(IDEInternalWorkbenchImages.IMG_ETOOL_BUILD_EXEC);
        service.registerIconForFamily(newImage,
                ResourcesPlugin.FAMILY_MANUAL_BUILD);
        service.registerIconForFamily(newImage,