Bug 26133 [Dialogs] TitleAreaDialog status line blinks when newMessage == currentMessage
Build id: 200211051258 The current implementation for TitleAreaDialog#showMessage(String,int) method has a guard against updates to the message with the same content (to avoid needlessly blinking). The problem is that after that the message may be concatenated with a space character: ==================== //If there is an image then add in a space to the message //for layout purposes if(newImage != null) message = " " + message; //$NON-NLS-1$ ==================== So the guard will fail in the next call even if the same string is provided by the client.
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/TitleAreaDialog.java
private Image messageImage;
	private Color normalMsgAreaBackground;
	private Color errorMsgAreaBackground;
	private Image errorMsgImage;
	private boolean showingError = false;
	private boolean titleImageLargest = true;
/**
 * Instantiate a new title area dialog.
 *
 * @param parentShell the parent SWT shell
 */
public TitleAreaDialog(Shell parentShell) {
	super(parentShell);
}
/*
 * @see Dialog.createContents(Composite)
 */
protected Control createContents(Composite parent) {
	
	
	initializeDialogUnits(parent);
	
	FormLayout layout = new FormLayout();
	parent.setLayout(layout);
	FormData data = new FormData();
	data.top = new FormAttachment(0,0);
	data.bottom = new FormAttachment(100,100);
	parent.setLayoutData(data);
	
	Control top = createTitleArea(parent);