Bug 89139 [JFace] - API Review - DerivedImageDescriptor not complete
while reviewing the API for DerivedImageDescriptor, I noticed that the constructor parameter originalImage is never assigned in the constructor to the instance variable originalImage, which is used in all the creation methods. I doubt this class works...?? Also, the #createResource method doesn't throw the DeviceResourceException as documented.
bundles/org.eclipse.jface/src/org/eclipse/jface/resource/DerivedImageDescriptor.java
/*******************************************************************************
 * Copyright (c) 2005 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials 
 * are made available under the terms of the Common Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/cpl-v10.html
 * 
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *******************************************************************************/
package org.eclipse.jface.resource;
import org.eclipse.swt.graphics.Device;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.graphics.ImageData;
import org.eclipse.swt.widgets.Display;
/**
 * An image descriptor which creates images based on another ImageDescriptor, but with
 * additional SWT flags. Note that this is only intended for compatibility. 
 * 
 * @since 3.1
 */
final class DerivedImageDescriptor extends ImageDescriptor {