Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java
boolean shouldBeEnabled = action.isEnabled()
                            && isEnabledAllowed();
                    if (button.getEnabled() != shouldBeEnabled) {
						button.setEnabled(shouldBeEnabled);
					}
                }
                if (checkChanged) {
                    boolean bv = action.isChecked();
                    if (button.getSelection() != bv) {
						button.setSelection(bv);
					}
                }
                return;
            }
        }
    }
    /**
     * Updates the images for this action.
     *
     * @param forceImage <code>true</code> if some form of image is compulsory,
     *  and <code>false</code> if it is acceptable for this item to have no image
     * @return <code>true</code> if there are images for this action, <code>false</code> if not
     */
    private boolean updateImages(boolean forceImage) {
        ResourceManager parentResourceManager = JFaceResources.getResources();
        
        if (widget instanceof ToolItem) {
            if (USE_COLOR_ICONS) {
                ImageDescriptor image = action.getHoverImageDescriptor();
                if (image == null) {