Bug 89139 [JFace] - API Review - DerivedImageDescriptor not complete
while reviewing the API for DerivedImageDescriptor, I noticed that the constructor parameter originalImage is never assigned in the constructor to the instance variable originalImage, which is used in all the creation methods. I doubt this class works...?? Also, the #createResource method doesn't throw the DeviceResourceException as documented.
bundles/org.eclipse.jface/src/org/eclipse/jface/resource/DerivedImageDescriptor.java
private ImageDescriptor original;
    private int flags;
    
    public DerivedImageDescriptor(ImageDescriptor original, int swtFlags) {
        flags = swtFlags;
    }
    
    public Object createResource(Device device) throws DeviceResourceException {
        return internalCreateImage(device);
    }
    
    public Image createImage(Device device) {
        return internalCreateImage(device);
    }
    
    public int hashCode() {
        return original.hashCode() + flags;
    }
    
    public boolean equals(Object arg0) {
        if (arg0 instanceof DerivedImageDescriptor) {
            DerivedImageDescriptor desc = (DerivedImageDescriptor)arg0;