Bug 92564 [Viewers] (doc only) incorrect use of html in javadoc of BackgroundContentProvider
Version: 3.1.0 Build id: I20050419-1200 The section that is explaining the information flow is not correctly defining the ordered list. Each item should be wrapped in a 'li', not an 'ol'. Index: BackgroundContentProvider.java =================================================================== RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java,v retrieving revision 1.4 diff -u -r1.4 BackgroundContentProvider.java --- BackgroundContentProvider.java 28 Mar 2005 14:57:36 -0000 1.4 +++ BackgroundContentProvider.java 25 Apr 2005 11:13:00 -0000 @@ -38,12 +38,12 @@ * <p> * Information flow is like this: * </p> - * <ol>IConcurrentModel sends unordered elements to BackgroundContentProvider (in a background thread)</ol> - * <ol>BackgroundContentProvider sorts, filters, and sends element/index pairs to - * ConcurrentTableUpdator (in a background thread)</ol> - * <ol>ConcurrentTableUpdator batches the updates and sends them to an AbstractVirtualTable - * (in the UI thread)</ol> - * <li> + * <ol> + * <li>IConcurrentModel sends unordered elements to BackgroundContentProvider (in a background thread)</li> + * <li>BackgroundContentProvider sorts, filters, and sends element/index pairs to + * ConcurrentTableUpdator (in a background thread)</li> + * <li>ConcurrentTableUpdator batches the updates and sends them to an AbstractVirtualTable + * (in the UI thread)</li> * </ol> * * <p>
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/deferred/BackgroundContentProvider.java
if (filter != AcceptAllFilter.getInstance()) { 
			for (int i = 0; i < toAdd.length; i++) {
				Object object = toAdd[i];
				
				if (filter.select(object)) {
					collection.add(object);
				}
			}
		} else {
			collection.addAll(toAdd);
		}
	}
    
    /**
     * Sets the sort order for this content provider
     * 
     * @param sorter sort order
     */
    public void setSortOrder(Comparator sorter) {
    	Assert.isNotNull(sorter);
        this.sortOrder = sorter;
    	sortMon.cancel();
        refresh();
    }
    
    /**
     * Sets the filter for this content provider
     * 
     * @param toSet filter to set
     */