Bug 283359 [Browser] WebBrowserEditorInput#equals(Object) is wrong
Build ID: 3.2.201.v20080708_34x Steps To Reproduce: Looking at the WebBrowserEditorInput#equals(Object) method in 3.2.201.v20080708_34x version of the org.eclipse.ui.browser (similarly in the head), there are few issues: 1) The javadoc is wrong, and it doesn't make sense. 2) The line: if (url != null && !url.equals(obj)) should be if (url != null && !url.equals(other.url)) For reference, I'm pasting the contents of the equals method: /** * Indicates whether some other object is "equal to" this one. In this case * it means that the underlying IFolders are equal. */ public boolean equals(Object obj) { if (this == obj) return true; if (!(obj instanceof WebBrowserEditorInput)) return false; WebBrowserEditorInput other = (WebBrowserEditorInput) obj; if (url != null && !url.equals(obj)) return false; return canReplaceInput(other); } More information:
bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java
*/
	public WebBrowserEditorInput(URL url, int style, String browserId) {
		super();
		this.url = url;
		this.style = style;
		this.id = browserId;
	}
	/**
	 * WebBrowserEditorInput constructor comment.
	 */
	public WebBrowserEditorInput(URL url, boolean b) {
		this(url);
	}
	public void setName(String n) {
		name = n;
	}
	public void setToolTipText(String t) {
		tooltip = t;
	}
	/**
	 * Returns true if this page can reuse the browser that the given input is
	 * being displayed in, or false if it should open up in a new page.
	 * 
	 * @param input
	 *            org.eclipse.ui.internal.browser.IWebBrowserEditorInput
	 * @return boolean
	 */
	public boolean canReplaceInput(WebBrowserEditorInput input) {
		Trace.trace(Trace.FINEST, "canReplaceInput " + this + " " + input);