Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceStore.java
properties.load(in);
        dirty = false;
    }
    /*
     * (non-Javadoc) Method declared on IPreferenceStore.
     */
    public boolean needsSaving() {
        return dirty;
    }
    /**
     * Returns an enumeration of all preferences known to this store which have
     * current values other than their default value.
     * 
     * @return an array of preference names
     */
    public String[] preferenceNames() {
        ArrayList list = new ArrayList();
        Enumeration it = properties.propertyNames();
        while (it.hasMoreElements()) {
            list.add(it.nextElement());
        }
        return (String[]) list.toArray(new String[list.size()]);
    }
    /*
     * (non-Javadoc) Method declared on IPreferenceStore.
     */
    public void putValue(String name, String value) {
        String oldValue = getString(name);
        if (oldValue == null || !oldValue.equals(value)) {
            setValue(properties, name, value);