Bug 287536 [CommonNavigator] Wrong sorter unit tests
Build ID: Build id: I20090611-1540 Steps To Reproduce: Several tests in SorterTest rely on the dynamicAddModelObjects method. That method breaks the contract of viewer.add ("This method should be called (by the content provider) when a single * element has been added to the model") in that it calls viewer.add(newData) but doesn't actually add newData to the project. More information: The corresponding tests will fail if for example _viewer.add(parent, children) is implemented as _viewer.refresh(parent), which should not make any difference.
tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/SorterTest.java
public SorterTest() {
		_navigatorInstanceId = TEST_VIEWER;
	}
	private int _statusCount;
	
	public void testSorterMissing() throws Exception {
		TestContentProviderResource._returnBadObject = true;
		_contentService.bindExtensions(
				new String[] { TEST_CONTENT_SORTER_MODEL }, false);
		_contentService.getActivationService().activateExtensions(
				new String[] { TEST_CONTENT_SORTER_MODEL }, true);
		refreshViewer();
		ILogListener ll = new ILogListener() {
			public void logging(IStatus status, String plugin) {
				_statusCount++;
			}
		};
		NavigatorPlugin.getDefault().getLog().addLogListener(ll);
		
		_viewer.expandAll();
		NavigatorPlugin.getDefault().getLog().removeLogListener(ll);
		
		
		assertTrue("Status Count: " + _statusCount, _statusCount == 0);
	}
	
	
	public void testSorterProperty() throws Exception {
		_contentService.bindExtensions(