Bug 238162 [RCP] Remove dependency on org.eclipse.update.core
Build: 3.4 final I noticed while browsing code that IDEWorkbenchAdvisor has a method "checkUpdates" which makes a call to update manager API (SiteManager.handleNewChanges()). Looking through the history, I see this SiteManager.handleNewChanges() method has had an empty body since the 3.0 release, so it's a no-op to call it. This reference should be removed because it allows org.eclipse.ui.ide.application to remove its dependency on org.eclipse.update.*. We will be gradually removing dependencies on classic update and this one is an easy place to start.
bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java
private AboutInfo[] welcomePerspectiveInfos = null;
	/**
	 * Helper for managing activites in response to workspace changes.
	 */
	private IDEWorkbenchActivityHelper activityHelper = null;
	/**
	 * Helper for managing work that is performed when the system is otherwise
	 * idle.
	 */
	private IDEIdleHelper idleHelper;
	private Listener settingsChangeListener;
	
	/**
	 * Support class for monitoring workspace changes and periodically
	 * validating the undo history
	 */
	private WorkspaceUndoMonitor workspaceUndoMonitor;
	/**
	 * The IDE workbench error handler.
	 */
	private AbstractStatusHandler ideWorkbenchErrorHandler;
	/**
	 * Creates a new workbench advisor instance.
	 */
	public IDEWorkbenchAdvisor() {
		super();
		if (workbenchAdvisor != null) {
			throw new IllegalStateException();
		}
		workbenchAdvisor = this;