Bug 189167 [KeyBindings] Binding.equals() gives back wrong value
org.eclipse.jface.bindings.Binding.equals() in line 272 (in 3.2.2 line 268) return (getType() != binding.getType()); This expression gives back false instead of true if the two values are same. Need to change to: return (getType() == binding.getType());
bundles/org.eclipse.jface/src/org/eclipse/jface/bindings/Binding.java
/*******************************************************************************
 * Copyright (c) 2004, 2007 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html
 *
 * Contributors:
 *     IBM Corporation - initial API and implementation
 *******************************************************************************/
package org.eclipse.jface.bindings;
import java.io.BufferedWriter;
import java.io.IOException;
import java.io.StringWriter;
import org.eclipse.core.commands.ParameterizedCommand;
import org.eclipse.jface.util.Util;
/**
 * <p>
 * A binding is a link between user input and the triggering of a particular
 * command. The most common example of a binding is a keyboard shortcut, but
 * there are also mouse and gesture bindings.
 * </p>