Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/action/MenuManager.java
if (ci.isSeparator()) {
                         
                        
                        separator = ci;
                    } else {
                        if (separator != null) {
                            if (clean.size() > 0) {
								clean.add(separator);
							}
                            separator = null;
                        }
                        clean.add(ci);
                    }
                }
                
                MenuItem[] mi = menu.getItems();
                for (int i = 0; i < mi.length; i++) {
                    Object data = mi[i].getData();
                    if (data == null || !clean.contains(data)) {
                        mi[i].dispose();
                    } else if (data instanceof IContributionItem
                            && ((IContributionItem) data).isDynamic()
                            && ((IContributionItem) data).isDirty()) {
                        mi[i].dispose();
                    }
                }
                
                mi = menu.getItems();
                int srcIx = 0;
                int destIx = 0;