Bug 161848 [JFace] Javadoc quality in org.eclipse.jface
As Tod announced on the platform-ui mailing list he wants to set the compiler settings to stricter mode so to ensure the javadoc quality. Because the weather was so lousy in Austria today I tried it and took the effort (~2 hours). I'll attach the patches package wise. This is a starting point.
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java
MenuItem mi = (MenuItem) widget;
                if (textChanged) {
                    int accelerator = 0;
					String acceleratorText = null;
					IAction updatedAction = getAction();
					String text = null;
					accelerator = updatedAction.getAccelerator();
					ExternalActionManager.ICallback callback = ExternalActionManager
							.getInstance().getCallback();
					
					if ((accelerator != 0) && (callback != null)
                            && (callback.isAcceleratorInUse(accelerator))) {
                        accelerator = 0;
					}
					/*
					 * Process accelerators on GTK in a special way to avoid Bug
					 * 42009. We will override the native input method by
					 * allowing these reserved accelerators to be placed on the
					 * menu. We will only do this for "Ctrl+Shift+[0-9A-FU]".
					 */
					final String commandId = updatedAction
							.getActionDefinitionId();
					if (("gtk".equals(SWT.getPlatform())) && (callback instanceof IBindingManagerCallback) 
							&& (commandId != null)) {
						final IBindingManagerCallback bindingManagerCallback = (IBindingManagerCallback) callback;
						final IKeyLookup lookup = KeyLookupFactory.getDefault();
						final TriggerSequence[] triggerSequences = bindingManagerCallback
								.getActiveBindingsFor(commandId);
						for (int i = 0; i < triggerSequences.length; i++) {
							final TriggerSequence triggerSequence = triggerSequences[i];