Bug 300862 Change buttons order in PathVariableDialog
IMHO more intuitive order for buttons in PathVariableDialog would be [File...][Folder...][Variable...] instead of [File...][Variable...][Folder...]. I can provide a patch if the swap makes sense to you too ;)
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/PathVariableDialog.java
String message = standardMessage;
        int newValidationStatus = IMessageProvider.NONE;
        if (variableValue.length() == 0) {
            
            if (locationEntered) {
                
                newValidationStatus = IMessageProvider.ERROR;
                message = IDEWorkbenchMessages.PathVariableDialog_variableValueEmptyMessage;
            }
        }
        if (currentResource != null) {
            
            
            allowFinish = true;
            String resolvedValue = getVariableResolvedValue();
            IPath resolvedPath = Path.fromPortableString(resolvedValue);
            if (!IDEResourceInfoUtils.exists(resolvedPath.toOSString())) {
                
                message = IDEWorkbenchMessages.PathVariableDialog_pathDoesNotExistMessage;
                newValidationStatus = IMessageProvider.WARNING;
            } else {
                IFileInfo info = IDEResourceInfoUtils.getFileInfo(resolvedPath
                        .toOSString());
                if ((info.isDirectory() && ((variableType & IResource.FOLDER) == 0)) ||
                		(!info.isDirectory() && ((variableType & IResource.FILE) == 0))){
                    allowFinish = false;
                    newValidationStatus = IMessageProvider.ERROR;
                    if (((variableType & IResource.FOLDER) != 0))
                        message = IDEWorkbenchMessages.PathVariableDialog_variableValueIsWrongTypeFolder;