Bug 331335 [Wizards] Bad implementation of IWizard's dispose() method can prevent the dialog from closing
If there is bad client code in an IWizard's dispose() method, the dialog get into a state where it cannot be closed. ------------ Run this code and try to close the wizard dialog, you will not be able to. Display display = new Display(); Wizard wizard = new Wizard() { public boolean performFinish() { return true; } public void dispose() { throw new RuntimeException(); } }; WizardDialog dialog = new WizardDialog(null, wizard); dialog.open(); display.dispose(); ------------ java.lang.RuntimeException at Main$5.dispose(Main.java:142) at org.eclipse.jface.wizard.WizardDialog.hardClose(WizardDialog.java:859) at org.eclipse.jface.wizard.WizardDialog.close(WizardDialog.java:484) at org.eclipse.jface.window.Window.handleShellCloseEvent(Window.java:741) at org.eclipse.jface.window.Window$3.shellClosed(Window.java:687) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:98)
bundles/org.eclipse.jface/src/org/eclipse/jface/wizard/WizardDialog.java
finishButton.moveBelow(null);
		}
	}
	/*
	 * (non-Javadoc)
	 * 
	 * @see org.eclipse.jface.dialogs.Dialog#setButtonLayoutData(org.eclipse.swt.widgets.Button)
	 */
	protected void setButtonLayoutData(Button button) {
		GridData data = new GridData(GridData.HORIZONTAL_ALIGN_FILL);
		int widthHint = convertHorizontalDLUsToPixels(IDialogConstants.BUTTON_WIDTH);
		
		widthHint = Math.min(widthHint,
				button.getDisplay().getBounds().width / 5);
		Point minSize = button.computeSize(SWT.DEFAULT, SWT.DEFAULT, true);
		data.widthHint = Math.max(widthHint, minSize.x);
		button.setLayoutData(data);
	}
	/**
	 * Creates the Cancel button for this wizard dialog. Creates a standard (<code>SWT.PUSH</code>)
	 * button and registers for its selection events. Note that the number of
	 * columns in the button bar composite is incremented. The Cancel button is
	 * created specially to give it a removeable listener.
	 * 
	 * @param parent
	 *            the parent button bar
	 * @return the new Cancel button
	 */