Bug 60785 [Preferences] [Javadoc] Review of org.eclipse.jface.preference
Warnings: IPreferenceStore.java:379: warning - @param argument "value" is not a parameter name. BooleanFieldEditor.java:80: warning - @param argument "labelText" is not a parameter name. ColorSelector.java:63: warning - @param argument "parent." is not a parameter name. ColorSelector.java:192: warning - @param argument "rgb." is not a parameter name. FieldEditor.java:596: warning - @param argument "Button" is not a parameter name. FieldEditor.java:619: warning - @param argument "boolean." is not a parameter name. FieldEditor.java:619: warning - @param argument "parent." is not a parameter name. FileFieldEditor.java:143: warning - @param argument "extension" is not a parameter name. PreferenceConverter.java:45: warning - @issue is an unknown tag. PreferenceDialog.java:202: warning - @param argument "shell" is not a parameter name. PreferenceDialog.java:836: warning - @param argument "errorMessage" is not a parameter name. PreferenceNode.java:109: warning - @param argument "page" is not a parameter name. PreferenceStore.java:432: warning - @param argument "filename" is not a parameter name. StringFieldEditor.java:289: warning - @param argument "parent" is not a parameter name. BooleanPropertyAction: - BooleanPropertyAction has no description. - run() is not documented. ColorFieldEditor: - Class description is incomplete or just missing a period. - getColorSelector() is undocumented. - getNumberOfControls() has an incomplete description. ColorSelector: - updateColorImage() description ends in a comma. FieldEditorPreferencePage: - applyFont() is undocumented. PreferenceContentProvider: - All methods are undocumented. PreferenceDialog: - Undocumented methods: close(), configureShell(), constrainShellSize(), createTreeAreaContents(), getSingleSelection(), getTreeViewer(), layoutTreeAreaControl(). PreferenceLabelProvider: - All methods are undocumented. StringButtonFieldEditor: - getChangeControl() is undocumented. JFacePreferences: - *_COLOR undocumented.
bundles/org.eclipse.jface/src/org/eclipse/jface/preference/ListEditor.java
/**
 * Helper method to create a push button.
 * 
 * @param parent the parent control
 * @param key the resource name used to supply the button's label text
 */
private Button createPushButton(Composite parent, String key) {
	Button button = new Button(parent, SWT.PUSH);
	button.setText(JFaceResources.getString(key));
	button.setFont(parent.getFont());
	GridData data = new GridData(GridData.FILL_HORIZONTAL);
	data.heightHint = convertVerticalDLUsToPixels(button, IDialogConstants.BUTTON_HEIGHT);
	int widthHint = convertHorizontalDLUsToPixels(button, IDialogConstants.BUTTON_WIDTH);
	data.widthHint = Math.max(widthHint, button.computeSize(SWT.DEFAULT, SWT.DEFAULT, true).x);
	button.setLayoutData(data);
	button.addSelectionListener(getSelectionListener());
	return button;
}
/**
 * Creates a selection listener.
 */
public void createSelectionListener() {
	selectionListener = new SelectionAdapter() {
		public void widgetSelected(SelectionEvent event) {
			Widget widget = event.widget;
			if (widget == addButton) {
				addPressed();
			} else
				if (widget == removeButton) {
					removePressed();