Bug 331335 [Wizards] Bad implementation of IWizard's dispose() method can prevent the dialog from closing
If there is bad client code in an IWizard's dispose() method, the dialog get into a state where it cannot be closed. ------------ Run this code and try to close the wizard dialog, you will not be able to. Display display = new Display(); Wizard wizard = new Wizard() { public boolean performFinish() { return true; } public void dispose() { throw new RuntimeException(); } }; WizardDialog dialog = new WizardDialog(null, wizard); dialog.open(); display.dispose(); ------------ java.lang.RuntimeException at Main$5.dispose(Main.java:142) at org.eclipse.jface.wizard.WizardDialog.hardClose(WizardDialog.java:859) at org.eclipse.jface.wizard.WizardDialog.close(WizardDialog.java:484) at org.eclipse.jface.window.Window.handleShellCloseEvent(Window.java:741) at org.eclipse.jface.window.Window$3.shellClosed(Window.java:687) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:98)
bundles/org.eclipse.jface/src/org/eclipse/jface/wizard/WizardDialog.java
private Button createCancelButton(Composite parent) {
		
		((GridLayout) parent.getLayout()).numColumns++;
		Button button = new Button(parent, SWT.PUSH);
		button.setText(IDialogConstants.CANCEL_LABEL);
		setButtonLayoutData(button);
		button.setFont(parent.getFont());
		button.setData(new Integer(IDialogConstants.CANCEL_ID));
		button.addSelectionListener(cancelListener);
		return button;
	}
	/**
	 * Return the cancel button if the id is a the cancel id.
	 * 
	 * @param id
	 *            the button id
	 * @return the button corresponding to the button id
	 */
	protected Button getButton(int id) {
		if (id == IDialogConstants.CANCEL_ID) {
			return cancelButton;
		}
		return super.getButton(id);
	}
	/**
	 * The <code>WizardDialog</code> implementation of this
	 * <code>Window</code> method calls call <code>IWizard.addPages</code>
	 * to allow the current wizard to add extra pages, then
	 * <code>super.createContents</code> to create the controls. It then calls
	 * <code>IWizard.createPageControls</code> to allow the wizard to