Bug 298130 Cannot add parameters to commands through Ecore editor
Build Identifier: I20091210-2100 [Apologies for mangling terminology: I'm not very familiar with EMF.] The definitions in UIElements.ecore of HandledItems and KeyBinding don't mark their "parameters" field as being contained. Since there's no other container for parameters, you cannot define parameters from the Ecore editor. Reproducible: Always Steps to Reproduce: 1. Open up an Application.xmi 2. Create a command that takes a parameter. 3. Add a handled item (e.g., a toolbar item). Set its command to to the command defined in step #2. 4. Right click on the handled item and ask to add a child. See that Command Parameter does not appear.
bundles/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/impl/KeyBindingImpl.java
import org.eclipse.emf.ecore.util.EObjectResolvingEList;
/**
 * <!-- begin-user-doc -->
 * An implementation of the model object '<em><b>Key Binding</b></em>'.
 * <!-- end-user-doc -->
 * <p>
 * The following features are implemented:
 * <ul>
 *   <li>{@link org.eclipse.e4.ui.model.application.impl.KeyBindingImpl#getKeySequence <em>Key Sequence</em>}</li>
 *   <li>{@link org.eclipse.e4.ui.model.application.impl.KeyBindingImpl#getId <em>Id</em>}</li>
 *   <li>{@link org.eclipse.e4.ui.model.application.impl.KeyBindingImpl#getStyle <em>Style</em>}</li>
 *   <li>{@link org.eclipse.e4.ui.model.application.impl.KeyBindingImpl#getCommand <em>Command</em>}</li>
 *   <li>{@link org.eclipse.e4.ui.model.application.impl.KeyBindingImpl#getParameters <em>Parameters</em>}</li>
 * </ul>
 * </p>
 *
 * @generated
 */
public class KeyBindingImpl extends EObjectImpl implements MKeyBinding {
	/**
	 * The default value of the '{@link #getKeySequence() <em>Key Sequence</em>}' attribute.
	 * <!-- begin-user-doc -->
	 * <!-- end-user-doc -->
	 * @see #getKeySequence()
	 * @generated
	 * @ordered
	 */
	protected static final String KEY_SEQUENCE_EDEFAULT = null;
	/**
	 * The cached value of the '{@link #getKeySequence() <em>Key Sequence</em>}' attribute.