Bug 299207 [CommonNavigator] Refactor NavigatorContentServiceContentProvider
There are a number of things about this code that make it less clear that it needs to be: 1) The internalGetChildren() and getElements() are largely duplicated. 2) The pipelinedChildren() private method returns the localSet which is never modified. 3) A ContributorTrackingSet is used in internalGetChildren() and getElements() when it is not necessary (setContribution() is never called on this, it should be just a LinkedHashSet) 4) The synchronization of methods is inconsistent 5) There are obsolete and unnecessary Javadoc comments 6) The order of the methods makes it hard to understand This refactoring (to be attached) cleans up these issues making the code easier to understand. No functionality change nor bug fix is intended here (except possibly by making the synchronization consistent).
bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorContentServiceContentProvider.java
* @return A TreePath with all segments from the compiler.
		 */
		public TreePath createPath() {
			return new TreePath(segments.toArray());
		}
		/**
		 * Create parent tree path.
		 * 
		 * @return A TreePath with all segments but the last from the compiler
		 */
		public TreePath createParentPath() {
			LinkedList parentSegments = new LinkedList(segments);
			parentSegments.removeLast();
			return new TreePath(parentSegments.toArray());
		}
		
		public Object getLastSegment() {
			return segments.getLast();
		}
		
		public Object getFirstSegment() {
			return segments.getFirst();
		}
		
		/* (non-Javadoc)
		 * @see java.lang.Object#toString()
		 */
		public String toString() {
		
			StringBuffer buffer = new StringBuffer();