Bug 140976 assert condition off by one in ReportEngineService
The following assertion appears around line 516 in org.eclipse.birt.report.viewer\birt\WEB-INF\classes\org\eclipse\birt\report\services\ReportEngineService.java assert pageNumber > 0 && pageNumber < reportDocument.getPageCount( ); However, since page numbers start at 1 instead of 0, pageNumber could equal reportDocument.getPageCount(). So the assertion should be assert pageNumber > 0 && pageNumber <= reportDocument.getPageCount( );
viewer/org.eclipse.birt.report.viewer/birt/WEB-INF/classes/org/eclipse/birt/report/service/BirtViewerReportService.java
{
			Object o = it.next( );
			if ( o instanceof ParameterGroupDefinition )
			{
				ParameterGroupDefinition group = ( ParameterGroupDefinition ) o;
				ret.addAll( group.getParameters( ) );
			} else
				ret.add( o );
		}
		return ret;
	}
	private static List convertParametersInGroup( Collection scalarParameters,
			ParameterGroupDefinition group, IGetParameterDefinitionTask task )
	{
		if ( scalarParameters == null )
			return null;
		List ret = new ArrayList( );
		for ( Iterator it = scalarParameters.iterator( ); it.hasNext( ); )
		{
			IScalarParameterDefn engineParam = ( IScalarParameterDefn ) it
					.next( );
			ParameterDefinition param = convertScalarParameter( engineParam,
					group, task );
			ret.add( param );
		}
		return ret;
	}
	private static ParameterGroupDefinition convertParameterGroup(
			IParameterGroupDefn engineParam, IGetParameterDefinitionTask task )
	{