Bug 152678 ParameterDialog cannot be build if compiler level is 5.0
Not sure if source is trying to be 1.5 supportive, however....using todays source head. If I try to build the source using the 1.5 JDK the class org.eclipse.birt.report.designer.ui.dialogs.ParameterDialog; has he following compiler errors: - The Method compareTo(BigDecimal) in the type BigDecimal is not applicable for the arguments (Object) - The Method compareTo(Double) in the type Double is not applicable for the arguments (Object) - The Method compareTo(Integer) in the type Integer is not applicable for the arguments (Object) if you look at method private boolean isEqual( String value1, String value2 ) There is the following comparisons that the compiler does not like. if ( v1 instanceof Double && v2 instanceof Double ) { return ( (Double) v1 ).compareTo( v2 ) == 0; } if ( v1 instanceof BigDecimal && v2 instanceof BigDecimal ) { return ( (BigDecimal) v1 ).compareTo( v2 ) == 0; } if ( v1 instanceof Integer && v2 instanceof Integer ) { return ( (Integer) v1 ).compareTo( v2 ) == 0; }
UI/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/ui/dialogs/ParameterDialog.java
public void widgetSelected( SelectionEvent e )
			{
				String type = getSelectedDataType( );
				ImportValueDialog dialog = new ImportValueDialog( type );
				if ( dialog.open( ) == OK )
				{
					String[] importValues = (String[]) dialog.getResult( );
					for ( int i = 0; i < importValues.length; i++ )
					{
						if ( !containValue( null, importValues[i], COLUMN_VALUE ) )
						{
							SelectionChoice choice = StructureFactory.createSelectionChoice( );
							choice.setValue( importValues[i] );
							choiceList.add( choice );
						}
					}
					refreshValueTable( );
				}
			}
		} );
		changeDefault = new Button( buttonBar, SWT.TOGGLE );
		changeDefault.addSelectionListener( new SelectionAdapter( ) {
			public void widgetSelected( SelectionEvent e )
			{
				SelectionChoice choice = (SelectionChoice) ( (IStructuredSelection) valueTable.getSelection( ) ).getFirstElement( );
				if ( isDefaultChoice( choice ) )
				{
					defaultValue = null;
				}
				else