Bug 200187 Deprecated HTMLServerImageHandler methods are not marked as deprecated
Build ID: 3.3.0 Steps To Reproduce: 1. Open IHTMLServerImageHandler and look at e.g. "public abstract String onDesignImage(IImage image, Object context)", which is marked as "deprecated" 2. Open HTMLImageHandler and look at e.g. "public String onDesignImage( IImage image, Object context )" which is not marked as deprecated The implementation class HTMLImageHandler which implements IHTMLImageHandler should mark the deprecated methods of IHTMLImageHandler as deprecated. E.g. public String onDesignImage( IImage image, Object context ) { return null; } to /** * @deprecated */ public String onDesignImage( IImage image, Object context ) { return null; } Reason: If someone (like me) extends the HTMLServerImageHandler class, he gets the following warning in the console (not in Eclipse): MyHTMLServerImageHandler.java:18: warning: [deprecation] onDesignImage((org.eclipse.birt.report.engine.api.IImage,java.lang.Object) in org.eclipse.birt.report.engine.api.IHTMLImageHandler has been deprecated I have to overwrite every in IHTMLServerImageHandler as deprecated marked method, to "remove" this warnings, like that: /** * @deprecated */ public String onDesignImage( IImage image, Object context ) { super.onDesignImage(image, context); } Would be nice, if this would be fixed.
engine/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/api/HTMLServerImageHandler.java
/*******************************************************************************
 * Copyright (c) 2004 Actuate Corporation. All rights reserved. This program and
 * the accompanying materials are made available under the terms of the Eclipse
 * Public License v1.0 which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html Contributors: Actuate Corporation -
 * initial API and implementation
 ******************************************************************************/
package org.eclipse.birt.report.engine.api;
import java.io.File;
import java.io.FileInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.util.HashMap;
import java.util.logging.Level;
import java.util.logging.Logger;
import org.eclipse.birt.report.engine.i18n.MessageConstants;
/**
 * Default implementation for writing images in a form that is used in a
 * web-application.
 */
public class HTMLServerImageHandler extends HTMLImageHandler
{
	protected Logger log = Logger.getLogger( HTMLServerImageHandler.class
			.getName( ) );
	
	private String handlerId;