Bug 200187 Deprecated HTMLServerImageHandler methods are not marked as deprecated
Build ID: 3.3.0 Steps To Reproduce: 1. Open IHTMLServerImageHandler and look at e.g. "public abstract String onDesignImage(IImage image, Object context)", which is marked as "deprecated" 2. Open HTMLImageHandler and look at e.g. "public String onDesignImage( IImage image, Object context )" which is not marked as deprecated The implementation class HTMLImageHandler which implements IHTMLImageHandler should mark the deprecated methods of IHTMLImageHandler as deprecated. E.g. public String onDesignImage( IImage image, Object context ) { return null; } to /** * @deprecated */ public String onDesignImage( IImage image, Object context ) { return null; } Reason: If someone (like me) extends the HTMLServerImageHandler class, he gets the following warning in the console (not in Eclipse): MyHTMLServerImageHandler.java:18: warning: [deprecation] onDesignImage((org.eclipse.birt.report.engine.api.IImage,java.lang.Object) in org.eclipse.birt.report.engine.api.IHTMLImageHandler has been deprecated I have to overwrite every in IHTMLServerImageHandler as deprecated marked method, to "remove" this warnings, like that: /** * @deprecated */ public String onDesignImage( IImage image, Object context ) { super.onDesignImage(image, context); } Would be nice, if this would be fixed.
engine/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/api/HTMLCompleteImageHandler.java
import java.util.logging.Logger;
import org.eclipse.birt.report.engine.util.FileUtil;
/**
 * Default implementation for writing images in a form that is compatible with a
 * web browser's "HTML Complete" save option, i.e., writes images to a
 * predefined folder.
 * 
 * ImageDirectory: absolute path save the image into that directy, return the
 * aboluste URL of that image.
 * 
 * ImageDirectory: null, treat it as "." ImageDirectory: relative relative to
 * the base folder.
 * 
 * BaseFolder: parent folder of the output file, save the file into image
 * directory and return the relative path (base on the base folder).
 * 
 * BaseFolder:null, use "." as the base folder and return the aboluste path,
 * 
 * 
 */
public class HTMLCompleteImageHandler extends HTMLImageHandler
{
	protected Logger log = Logger.getLogger( HTMLCompleteImageHandler.class
			.getName( ) );
	private static int count = 0;
	private static HashMap map = new HashMap( );
	/**
	 * dummy constructor
	 */
	public HTMLCompleteImageHandler( )