Bug 152678 ParameterDialog cannot be build if compiler level is 5.0
Not sure if source is trying to be 1.5 supportive, however....using todays source head. If I try to build the source using the 1.5 JDK the class org.eclipse.birt.report.designer.ui.dialogs.ParameterDialog; has he following compiler errors: - The Method compareTo(BigDecimal) in the type BigDecimal is not applicable for the arguments (Object) - The Method compareTo(Double) in the type Double is not applicable for the arguments (Object) - The Method compareTo(Integer) in the type Integer is not applicable for the arguments (Object) if you look at method private boolean isEqual( String value1, String value2 ) There is the following comparisons that the compiler does not like. if ( v1 instanceof Double && v2 instanceof Double ) { return ( (Double) v1 ).compareTo( v2 ) == 0; } if ( v1 instanceof BigDecimal && v2 instanceof BigDecimal ) { return ( (BigDecimal) v1 ).compareTo( v2 ) == 0; } if ( v1 instanceof Integer && v2 instanceof Integer ) { return ( (Integer) v1 ).compareTo( v2 ) == 0; }
UI/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/ui/dialogs/ParameterDialog.java
import org.eclipse.birt.report.designer.internal.ui.swt.custom.TableArea;
import org.eclipse.birt.report.designer.internal.ui.util.DataUtil;
import org.eclipse.birt.report.designer.internal.ui.util.ExceptionHandler;
import org.eclipse.birt.report.designer.internal.ui.util.IHelpContextIds;
import org.eclipse.birt.report.designer.internal.ui.util.UIUtil;
import org.eclipse.birt.report.designer.nls.Messages;
import org.eclipse.birt.report.designer.ui.IReportGraphicConstants;
import org.eclipse.birt.report.designer.ui.ReportPlatformUIImages;
import org.eclipse.birt.report.designer.ui.actions.NewDataSetAction;
import org.eclipse.birt.report.designer.ui.views.attributes.providers.ChoiceSetFactory;
import org.eclipse.birt.report.designer.util.DEUtil;
import org.eclipse.birt.report.model.api.DataSetHandle;
import org.eclipse.birt.report.model.api.PropertyHandle;
import org.eclipse.birt.report.model.api.ResultSetColumnHandle;
import org.eclipse.birt.report.model.api.ScalarParameterHandle;
import org.eclipse.birt.report.model.api.SelectionChoiceHandle;
import org.eclipse.birt.report.model.api.StructureFactory;
import org.eclipse.birt.report.model.api.activity.SemanticException;
import org.eclipse.birt.report.model.api.elements.DesignChoiceConstants;
import org.eclipse.birt.report.model.api.elements.structures.SelectionChoice;
import org.eclipse.birt.report.model.api.metadata.IChoice;
import org.eclipse.birt.report.model.api.metadata.IChoiceSet;
import org.eclipse.birt.report.model.api.util.StringUtil;
import org.eclipse.jface.dialogs.Dialog;
import org.eclipse.jface.util.Assert;
import org.eclipse.jface.viewers.ILabelProviderListener;
import org.eclipse.jface.viewers.ISelectionChangedListener;
import org.eclipse.jface.viewers.IStructuredContentProvider;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.jface.viewers.ITableLabelProvider;