Bug 140976 assert condition off by one in ReportEngineService
The following assertion appears around line 516 in org.eclipse.birt.report.viewer\birt\WEB-INF\classes\org\eclipse\birt\report\services\ReportEngineService.java assert pageNumber > 0 && pageNumber < reportDocument.getPageCount( ); However, since page numbers start at 1 instead of 0, pageNumber could equal reportDocument.getPageCount(). So the assertion should be assert pageNumber > 0 && pageNumber <= reportDocument.getPageCount( );
viewer/org.eclipse.birt.report.viewer/birt/WEB-INF/classes/org/eclipse/birt/report/service/BirtViewerReportService.java
if ( reportDesignName.endsWith( "\\" )
							|| reportDesignName.endsWith( "/" ) )
						reportDesignName = null;
				}
			}
		}
		return reportDesignName;
	}
	/*
	 * Convert engine parameters (IScalarParameterDefn and IParameterGroupDefn)
	 * into service api parameters (ParameterDefinition and
	 * ParameterGroupDefinition)
	 * 
	 * @param params a Collection of IScalarParameterDefn or IParameterGroupDefn
	 * @param task the task to use to get selection list for a parameter @param
	 * includeGroups if true, include groups (ParameterGroupDefinition) in the
	 * result, otherwise flatten the result (i.e. include the contents of the
	 * groups in the result)
	 * 
	 * @return a Collection of ParameterDefinition and ParameterGroupDefinition,
	 * or a Collection of only ParameterDefinition if includeGroups == false
	 */
	private static Collection convertEngineParameters( Collection params,
			IGetParameterDefinitionTask task, boolean includeGroups )
	{
		if ( params == null )
			return Collections.EMPTY_LIST;
		List ret = new ArrayList( );