Bug 152678 ParameterDialog cannot be build if compiler level is 5.0
Not sure if source is trying to be 1.5 supportive, however....using todays source head. If I try to build the source using the 1.5 JDK the class org.eclipse.birt.report.designer.ui.dialogs.ParameterDialog; has he following compiler errors: - The Method compareTo(BigDecimal) in the type BigDecimal is not applicable for the arguments (Object) - The Method compareTo(Double) in the type Double is not applicable for the arguments (Object) - The Method compareTo(Integer) in the type Integer is not applicable for the arguments (Object) if you look at method private boolean isEqual( String value1, String value2 ) There is the following comparisons that the compiler does not like. if ( v1 instanceof Double && v2 instanceof Double ) { return ( (Double) v1 ).compareTo( v2 ) == 0; } if ( v1 instanceof BigDecimal && v2 instanceof BigDecimal ) { return ( (BigDecimal) v1 ).compareTo( v2 ) == 0; } if ( v1 instanceof Integer && v2 instanceof Integer ) { return ( (Integer) v1 ).compareTo( v2 ) == 0; }
UI/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/ui/dialogs/ParameterDialog.java
import org.eclipse.jface.viewers.SelectionChangedEvent;
import org.eclipse.jface.viewers.TableViewer;
import org.eclipse.jface.viewers.Viewer;
import org.eclipse.swt.SWT;
import org.eclipse.swt.custom.CLabel;
import org.eclipse.swt.events.ModifyEvent;
import org.eclipse.swt.events.ModifyListener;
import org.eclipse.swt.events.SelectionAdapter;
import org.eclipse.swt.events.SelectionEvent;
import org.eclipse.swt.events.VerifyEvent;
import org.eclipse.swt.events.VerifyListener;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
import org.eclipse.swt.widgets.Button;
import org.eclipse.swt.widgets.Combo;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Group;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.swt.widgets.Table;
import org.eclipse.swt.widgets.TableColumn;
import org.eclipse.swt.widgets.Text;
import org.eclipse.ui.ISharedImages;
import com.ibm.icu.util.ULocale;
/**
 * The dialog used to create or edit a parameter
 */
public class ParameterDialog extends BaseDialog