Bug 123825 Compiler error in ViewSiteDecorator
I only caught this after committing a rather large set of changes. ViewSiteDecorator implements IViewSite, which is a violation of our API. IViewSite now extends (indirectly) IServiceLocator. This means ViewSiteDecorator needs to implement two new methods. public Object getService(Object key) { return fViewSite.getService(key); } public boolean hasService(Object key) { return false; } If the "Decorator" in ViewSiteDecorator refers to the decorator pattern, then you probably actually want: public boolean hasService(Object key) { return fViewSite.hasService(key); } I would rather not back out my change. Could someone please respond ASAP (if you happen to be working from home)? Thanks.
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/util/ViewSiteDecorator.java
public boolean isEmpty() {
			return fListeners.isEmpty();
		}
	}
	
	public ViewSiteDecorator(IViewSite site, ISelectionConverter converter) {
		fViewSite= site;
		fSelectionConverter= converter;
		ISelectionProvider provider= site.getSelectionProvider();
		if (provider != null) {
			fSelectionProvider= new SelectionProviderDecorator(provider);
		}
	}
	/* (non-Javadoc)
     * @see org.eclipse.ui.IWorkbenchPartSite#getPart()
     */
    public IWorkbenchPart getPart() {
		return fViewSite.getPart();
    }
	public IActionBars getActionBars() {
		return fViewSite.getActionBars();
	}
	public String getId() {
		return fViewSite.getId();
	}
	public IKeyBindingService getKeyBindingService() {
		return fViewSite.getKeyBindingService();
	}
	public String getPluginId() {
		return fViewSite.getPluginId();