Bug 32082 Creation of { } block captures first line
When creating an 'if' or 'for' block, the first line is always captured in the block. I believe this to be a fairly major bug, since it is very possible that when you are writing code you want to insert an if/for/while test into existing code, and definately /not/ end up accidentally capturing a statement. It may have been added in as an idea of productivity recently (don't recall seeing this in 2.1M3 or 4) but it really does not work. 2.1M5 Mac OS X 10.2.4 System.out.println("Before if"); System.out.println("After if"); -> System.out.println("Before if"); if (test) System.out.println("After if"); -> System.out.println("Before if"); if (test) { System.out.println("After if"); } I am reporting this as a major bug; I can't quite feel that it should be a critical bug. However, I do think it should be fixed in 2.1 rather than leaving it, because otherwise people are going to introduce a /lot/ of unneccessary coding errors without realising what is going on.
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/SmartBracesAutoEditStrategy.java
makeBlock(document, command);
			break;
		case ASTNode.IF_STATEMENT:
			{
				IfStatement ifStatement= (IfStatement) node;
				Expression expression= ifStatement.getExpression();
				Statement thenStatement= ifStatement.getThenStatement();
				Statement elseStatement= ifStatement.getElseStatement();
				Statement nextStatement= getNextStatement(ifStatement);
				IRegion expressionRegion= createRegion(expression, delta);
				IRegion thenRegion= createRegion(thenStatement, delta);
				IRegion elseRegion= createRegion(elseStatement, delta);
				IRegion nextRegion= createRegion(nextStatement, delta);
				IRegion elseToken= null;
				if (elseStatement != null) {
					int sourceOffset= thenRegion.getOffset() + thenRegion.getLength();
					int sourceLength= elseRegion.getOffset() - sourceOffset;
					elseToken= getToken(document, new Region(sourceOffset, sourceLength), ITerminalSymbols.TokenNameelse);
				}
				
				if (offset >= expressionRegion.getOffset() + expressionRegion.getLength() &&
					offset + length <= thenRegion.getOffset())
				{
					if (thenStatement == null || thenStatement.getNodeType() == ASTNode.BLOCK)
						return;
					if (elseToken != null)
						nextRegion= elseToken;
					
					int sourceOffset= expressionRegion.getOffset() + expressionRegion.getLength();
					int sourceLength= thenRegion.getOffset() - sourceOffset;