Bug 32082 Creation of { } block captures first line
When creating an 'if' or 'for' block, the first line is always captured in the block. I believe this to be a fairly major bug, since it is very possible that when you are writing code you want to insert an if/for/while test into existing code, and definately /not/ end up accidentally capturing a statement. It may have been added in as an idea of productivity recently (don't recall seeing this in 2.1M3 or 4) but it really does not work. 2.1M5 Mac OS X 10.2.4 System.out.println("Before if"); System.out.println("After if"); -> System.out.println("Before if"); if (test) System.out.println("After if"); -> System.out.println("Before if"); if (test) { System.out.println("After if"); } I am reporting this as a major bug; I can't quite feel that it should be a critical bug. However, I do think it should be fixed in 2.1 rather than leaving it, because otherwise people are going to introduce a /lot/ of unneccessary coding errors without realising what is going on.
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/SmartBracesAutoEditStrategy.java
public CompilationUnitInfo(char[] buffer, int delta) {
			this.buffer= buffer;
			this.delta= delta;
		}
		public char[] buffer;
		public int delta;
	}
	private static boolean areBlocksConsistent(IDocument document, int offset) {
		JavaCodeReader reader= new JavaCodeReader();
		try { 
			int begin= offset;
			int end= offset;
			
			while (true) {
				begin= searchForOpeningPeer(reader, begin, '{', '}', document);
				end= searchForClosingPeer(reader, end, '{', '}', document);
				if (begin == -1 && end == -1)
					return true;
				if (begin == -1 || end == -1)
					return false;
			}
		} catch (IOException e) {
			return false;
		}		
	}
	private static IRegion getSurroundingBlock(IDocument document, int offset) {
		JavaCodeReader reader= new JavaCodeReader();
		try {
			int begin= searchForOpeningPeer(reader, offset, '{', '}', document);
			int end= searchForClosingPeer(reader, offset, '{', '}', document);