Bug 74580 formatting for condition quick assists
3.1 M2 test pass The formatting of conditionals modified by the new quick assists is misleading. Consider the following: if (c1) { one(); } else if (c2) { two(); } else { three(); } translates into: if (!c1) if (c2) { two(); } else { three(); } else { one(); } which is correct, but it is barely visible from the formatting that the last else clause belongs to the first if statement. I would expect this (with or without the braces): if (!c1) if (c2) { two(); } else { three(); } else { one(); }
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/AdvancedQuickAssistProcessor.java
InfixExpression newExpression = ast.newInfixExpression();
		newExpression.setOperator(newOperator);
		newExpression.setLeftOperand(leftOperand);
		newExpression.setRightOperand(rightOperand);
		return newExpression;
	}
	private boolean getRemoveExtraParenthesisProposals(IInvocationContext context, ASTNode covering,
			Collection resultingCollections) {
		ArrayList coveredNodes = getFullyCoveredNodes(context);
		if (coveredNodes.isEmpty())
			return false;
		
		final AST ast = covering.getAST();
		final ASTRewrite rewrite = ASTRewrite.create(ast);
		
		final ArrayList changedNodes = new ArrayList();
		for (Iterator I = coveredNodes.iterator(); I.hasNext();) {
			ASTNode covered = (ASTNode) I.next();
			covered.accept(new ASTVisitor() {
				public void postVisit(ASTNode node) {
					if (!(node instanceof ParenthesizedExpression)) {
						return;
					}
					ParenthesizedExpression parenthesizedExpression = (ParenthesizedExpression) node;
					Expression expression = parenthesizedExpression.getExpression();
					while (expression instanceof ParenthesizedExpression) {
						expression = ((ParenthesizedExpression) expression).getExpression();
					}
					int expressionPrecedence = getExpressionPrecedence(expression);
					if (!(parenthesizedExpression.getParent() instanceof Expression)) {