Bug 129876 [quick fix] Light bulb on unneccessary else statement suggests "surround with runnable"
When a statement is unnessarily nested within an else clause, quick fix suggests to "surround with runnable". Which is of course incorrect. I'm using 3.2m5, check the quick fix on the else. (Java->Compiler->Errors/Warnings->Unnessary else statement = Warning) package demo; public class TestElse { public void main(String args[]) { if (true) { return; } else { return; } } }
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessor.java
ASTNode parent= node.getParent();
			if (parent instanceof ForStatement) {
				StructuralPropertyDescriptor locationInParent= node.getLocationInParent();
				if (locationInParent == ForStatement.EXPRESSION_PROPERTY
						|| locationInParent == ForStatement.INITIALIZERS_PROPERTY
						|| locationInParent == ForStatement.UPDATERS_PROPERTY)
					return (ForStatement) parent;
				else
					return null;
			}
			node= parent;
		}
		return null;
	}
	
	private boolean getMakeVariableDeclarationFinalProposals(IInvocationContext context, ASTNode node, ArrayList resultingCollections) {
		IFix fix= VariableDeclarationFix.createChangeModifierToFinalFix(context.getASTRoot(), node);
		if (fix == null)
			return false;
		
		if (resultingCollections == null)
			return true;
		Image image= JavaPluginImages.get(JavaPluginImages.IMG_CORRECTION_CHANGE);
		VariableDeclarationCleanUp cleanUp= new VariableDeclarationCleanUp(VariableDeclarationCleanUp.ADD_FINAL_MODIFIER_FIELDS | VariableDeclarationCleanUp.ADD_FINAL_MODIFIER_LOCAL_VARIABLES | VariableDeclarationCleanUp.ADD_FINAL_MODIFIER_PARAMETERS);
		FixCorrectionProposal proposal= new FixCorrectionProposal(fix, cleanUp, 5, image, context);
		resultingCollections.add(proposal);
		return true;
	}
}