Bug 32082 Creation of { } block captures first line
When creating an 'if' or 'for' block, the first line is always captured in the block. I believe this to be a fairly major bug, since it is very possible that when you are writing code you want to insert an if/for/while test into existing code, and definately /not/ end up accidentally capturing a statement. It may have been added in as an idea of productivity recently (don't recall seeing this in 2.1M3 or 4) but it really does not work. 2.1M5 Mac OS X 10.2.4 System.out.println("Before if"); System.out.println("After if"); -> System.out.println("Before if"); if (test) System.out.println("After if"); -> System.out.println("Before if"); if (test) { System.out.println("After if"); } I am reporting this as a major bug; I can't quite feel that it should be a critical bug. However, I do think it should be fixed in 2.1 rather than leaving it, because otherwise people are going to introduce a /lot/ of unneccessary coding errors without realising what is going on.
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/SmartBracesAutoEditStrategy.java
try {
			int id= scanner.getNextToken();
			while (id != ITerminalSymbols.TokenNameEOF && id != tokenId)
				id= scanner.getNextToken();
			if (id == ITerminalSymbols.TokenNameEOF)
				return null;
			int tokenOffset= scanner.getCurrentTokenStartPosition();
			int tokenLength= scanner.getCurrentTokenEndPosition() + 1 - tokenOffset; 
			return new Region(tokenOffset + scanRegion.getOffset(), tokenLength);
		} catch (InvalidInputException e) {
			return null;
		}
	}
	private void addReplace(IDocument document, DocumentCommand command, int offset, int length, String text) throws BadLocationException {
		command.addCommand(offset, length, text, fDocumentListener); 
		command.owner= fDocumentListener;
		command.doit= false;
		String oldText= document.get(offset, length);
		int delta= offset <= command.offset ? 0 : (command.text == null ? 0 : command.text.length()) - command.length; 
		IRegion replacedRegion= new Region(command.offset, command.text == null ? 0 : command.text.length());
		DocumentEvent undoEvent= new DocumentEvent(document, offset + delta, text == null ? 0 : text.length(), oldText);
		install(replacedRegion, undoEvent);
	}
	/**
	 * Closes the block immediately on the next line.
	 */
	private void makeBlock(IDocument document, DocumentCommand command) throws BadLocationException {
		int offset= command.offset;
		
		int insertionLine= document.getLineOfOffset(offset);