Bug 32082 Creation of { } block captures first line
When creating an 'if' or 'for' block, the first line is always captured in the block. I believe this to be a fairly major bug, since it is very possible that when you are writing code you want to insert an if/for/while test into existing code, and definately /not/ end up accidentally capturing a statement. It may have been added in as an idea of productivity recently (don't recall seeing this in 2.1M3 or 4) but it really does not work. 2.1M5 Mac OS X 10.2.4 System.out.println("Before if"); System.out.println("After if"); -> System.out.println("Before if"); if (test) System.out.println("After if"); -> System.out.println("Before if"); if (test) { System.out.println("After if"); } I am reporting this as a major bug; I can't quite feel that it should be a critical bug. However, I do think it should be fixed in 2.1 rather than leaving it, because otherwise people are going to introduce a /lot/ of unneccessary coding errors without realising what is going on.
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/SmartBracesAutoEditStrategy.java
fUndoEvent= null;
				}
			} else if (command.text != null && command.text.equals("{")) 
				smartBraces(document, command);
		} catch (BadLocationException e) {
			JavaPlugin.log(e);	
		}
	}
	private static String getLineDelimiter(IDocument document) {
		try {
			if (document.getNumberOfLines() > 1)
				return document.getLineDelimiter(0);
		} catch (BadLocationException e) {
			JavaPlugin.log(e);
		}
		return System.getProperty("line.separator"); 
	}
	private static String getLineIndentation(IDocument document, int line, int maxOffset) throws BadLocationException {
		int lineOffset= document.getLineOffset(line);
		String string= document.get(lineOffset, maxOffset - lineOffset);
		final int length= string.length();
		int i= 0;
		while (i != length && Character.isWhitespace(string.charAt(i)))
			++i;
		return string.substring(0, i);
	}
	private static IRegion getToken(IDocument document, IRegion scanRegion, int tokenId) throws BadLocationException {
		final String source= document.get(scanRegion.getOffset(), scanRegion.getLength());
		IScanner scanner= ToolFactory.createScanner(false, false, false, false);
		scanner.setSource(source.toCharArray());