Answers.Body: <p>Try upgrading civi to 5.28.4 as it should be fixed in this version</p>
  
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2020-09-30T09:37:10.303Z
Answers.Text: Hi Pradeep, thanks for your suggestion. Why would I be able to replicate this in dmaster demo site which is on 5.31.alpha1 if it was rectified in 5.28.4?
Answers.UserDisplayName: P Joseph
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2020-09-30T12:01:36.383Z
Answers.Text: Tried upgrading to 5.28.4 - same issue still exists. Not really sure what to try next.
Answers.UserDisplayName: P Joseph
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2020-09-30T08:46:12.133Z
Answers.LastActivityDate: 2020-09-30T08:46:12.133Z
Answers.UserDisplayName: Pradeep Nayak
Body: <p>We're running on Drupal 7 and the latest ESR 5.27.5 (was able to replicate on dmaster).</p>
  <p>On manual membership renewal with the member dues financial type which has a VAT/GST account attached to it that has 0% tax rate, sets it to pending, the contribution total amount displayed is double the actual contribution total.</p>
  <p>I thought this was only on the ESR version but I was able to replicate this on <a href="https://dmaster.demo.civicrm.org" rel="nofollow noreferrer">https://dmaster.demo.civicrm.org</a></p>
  <p>Steps to replicate:</p>
  <ol>
  <li>Add a VAT financial account with tax rate 0</li>
  <li>Add the financial account to the member dues financial type</li>
  <li>Go to any contact with an active membership.</li>
  <li>Renew the membership manually and set the status to pending and save. Check the contribution total amount.</li>
  </ol>
  <p><strong>Instead of setting it to pending, if the payment is set to completed, the total amount is correct but the subtotal seen on the invoice is incorrect.</strong></p>
  <p>This only happens when tax rate is set to 0.</p>
  <p>If the tax rate is even set to 0.0000001, this does not occur. Thought I would bring this up because I'm assuming it affects a few version.</p>
  <p>This is still visible on dmaster if someone wants to check.</p>
  <p><a href="https://i.sstatic.net/UuhWD.png" rel="nofollow noreferrer"><img src="https://i.sstatic.net/UuhWD.png" alt="enter image description here" /></a></p>
  <p><a href="https://i.sstatic.net/KiB6A.png" rel="nofollow noreferrer"><img src="https://i.sstatic.net/KiB6A.png" alt="dmaster" /></a></p>
  
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2020-09-30T22:26:58.107Z
Comments.Text: If your Tax Rate = 0 (so in config you have is Tax = yes but then Tax Rate = 0), why not use a Financial Type that has no Sales Tax associated with it?
Comments.UserDisplayName: KarinG - Semper IT
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2020-10-01T07:36:01.630Z
Comments.Text: @KarinG-SemperIT that seems reasonable but we want to be able to display the price as "€ 150 (includes VAT of € 0)", if we remove the sales tax, it just shows  € 150.000000.
Comments.UserDisplayName: P Joseph
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2020-10-01T12:11:49.647Z
Comments.Text: I meant using a Financial type that has no VAT associated with it at all. I agree it’s a bug but you can get the numbers correct and deal with the display issue differently e.g. in the invoice message template. Using 0% for Tax Rate is an unexpected use case of Tax Rates -> so I’m not surprised something unexpected happens
Comments.UserDisplayName: KarinG - Semper IT
Tags: <drupal><civicontribute><taxes>
Title: Contribution total amount being doubled when Tax Rate is set to 0 on manual membership renewal
ThreadText: # Contribution total amount being doubled when Tax Rate is set to 0 on manual membership renewal
  
  (Asked by: username_0 on 2020-09-30)
  
  We're running on Drupal 7 and the latest ESR 5.27.5 (was able to replicate on dmaster).
  
  On manual membership renewal with the member dues financial type which has a VAT/GST account attached to it that has 0% tax rate, sets it to pending, the contribution total amount displayed is double the actual contribution total.
  
  I thought this was only on the ESR version but I was able to replicate this on <https://dmaster.demo.civicrm.org>
  
  Steps to replicate:
  
  1. Add a VAT financial account with tax rate 0
  2. Add the financial account to the member dues financial type
  3. Go to any contact with an active membership.
  4. Renew the membership manually and set the status to pending and save. Check the contribution total amount.
  
  **Instead of setting it to pending, if the payment is set to completed, the total amount is correct but the subtotal seen on the invoice is incorrect.**
  
  This only happens when tax rate is set to 0.
  
  If the tax rate is even set to 0.0000001, this does not occur. Thought I would bring this up because I'm assuming it affects a few version.
  
  This is still visible on dmaster if someone wants to check.
  
  [![enter image description here](https://i.sstatic.net/UuhWD.png)](https://i.sstatic.net/UuhWD.png)
  
  [![dmaster](https://i.sstatic.net/KiB6A.png)](https://i.sstatic.net/KiB6A.png)
  
  **Tags:** drupal, civicontribute, taxes
  
  > **Comments:**
  > **username_1**: If your Tax Rate = 0 (so in config you have is Tax = yes but then Tax Rate = 0), why not use a Financial Type that has no Sales Tax associated with it?  
  > **username_0**: @KarinG-SemperIT that seems reasonable but we want to be able to display the price as "€ 150 (includes VAT of € 0)", if we remove the sales tax, it just shows  € 150.000000.  
  > **username_1**: I meant using a Financial type that has no VAT associated with it at all. I agree it’s a bug but you can get the numbers correct and deal with the display issue differently e.g. in the invoice message template. Using 0% for Tax Rate is an unexpected use case of Tax Rates -> so I’m not surprised something unexpected happens  
  
  ---
  
  ## 1 answers
  
  ### Answer by username_2 on 2020-09-30. Score: 0
  
  Try upgrading civi to 5.28.4 as it should be fixed in this version
  
  > **Comments:**
  > **username_0**: Hi Pradeep, thanks for your suggestion. Why would I be able to replicate this in dmaster demo site which is on 5.31.alpha1 if it was rectified in 5.28.4?  
  > **username_0**: Tried upgrading to 5.28.4 - same issue still exists. Not really sure what to try next.  
  
  ---
  
  