Answers.Body: <p>This might an important feature for folks using Event Cart functionality. It would be great if you can submit a PR against CiviDiscount repository at</p>
  
  <blockquote>
    <p><a href="https://github.com/dlobo/org.civicrm.module.cividiscount" rel="nofollow">https://github.com/dlobo/org.civicrm.module.cividiscount</a></p>
  </blockquote>
  
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2016-11-17T05:10:01.733Z
Answers.Text: Lesley or Kurund - I just looked through PR requests to see if i could see an outcome from this work but failed. Can anyone update this thread?
Answers.UserDisplayName: petednz - fuzion
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2015-04-22T15:19:27.257Z
Answers.Text: Because the Cart modules (ParticipantsandPrices, Payment.php) are not modeled on regular Event/Registration modules, I couldn't simply add Cart form names to _cividiscount - I called in _cividiscount methods in Cart.  I understand that no one supports Cart code as part of core CiviCRM, yet it isn't an extension? Should I  rewrite Cart to 'fit' CiviDiscount in the way Event/Reg is done?
Answers.UserDisplayName: Lesley Evensen
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2015-04-24T02:35:35.397Z
Answers.Text: OK, I submitted a PR for this in CiviDiscount and it will be added- it needs a PR in Event/Cart/Form/Checkout too, which I also submitted
Answers.UserDisplayName: Lesley Evensen
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2015-04-25T04:05:05.513Z
Answers.Text: If you think Cart code changes will be an improvement, then go for it. Alternatively you can also submit the PR against CiviDiscount repo.
Answers.UserDisplayName: Kurund Jalmi
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2015-04-17T22:37:10.707Z
Answers.LastActivityDate: 2015-04-17T22:37:10.707Z
Answers.UserDisplayName: Kurund Jalmi
Answers.Body: <p>Thanks very much for this. It would definitely be a useful feature, so please submit a PR.</p>
  
  <p>I think the best way to share desired features is via the issue queue for the extension at <a href="https://github.com/dlobo/org.civicrm.module.cividiscount/issues" rel="nofollow">https://github.com/dlobo/org.civicrm.module.cividiscount/issues</a>. Perhaps separate each suggestion into a different issue. That will make it easier to manage the suggestion, and to cite the issue when submitting a PR implementing a new feature.</p>
  
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2015-04-22T20:05:05.347Z
Answers.Text: As I commented to Kurund Jalmi, the problem is more with the Cart code- if it were modeled on the Event Registration code I could fairly easily add the correct form name to CiviDiscount to add the input textbox for the code, and enable it for applicable events/pricesets, but it is Cart code that needs re-writing. I added calls to _cividiscount_* to implement discounting in Cart/Form/Checkout modules
Answers.UserDisplayName: Lesley Evensen
Answers.ContentLicense: CC BY-SA 3.0
Answers.CreationDate: 2015-04-21T18:29:20.487Z
Answers.LastActivityDate: 2015-04-21T18:29:20.487Z
Answers.UserDisplayName: Joe Murray
Body: <p>I am testing/trying to use CiviEvent 'shopping cart' (needs to be enabled using CiviEvent Component Settings under Administer/CiviEvent) mode of registering for events and while I am on an older version of Civi I looked at 4.6 code and it looks about the same re: Cart functionality. I have modified Cart code to allow for using CiviDiscount, if an event is configured to allow discounts - is anyone else interested in this? I will submit a patch if so. (there are other features that seem lacking in Cart, I will include a README to document)</p>
  
Comments.ContentLicense: CC BY-SA 3.0
Comments.CreationDate: 2015-06-12T16:02:49.813Z
Comments.Text: hi Lesley, I really thought that CiviDiscount and CiviEvent's shopping cart were compatible, but after testing I have found some issues.
Comments.UserDisplayName: Jon-man
Comments.ContentLicense: CC BY-SA 3.0
Comments.CreationDate: 2016-10-20T16:07:18.230Z
Comments.Text: Should there be a new answer to this saying "yes this is possible now"?
Comments.UserDisplayName: petednz - fuzion
Tags: <civievent>
Title: Has anyone added discounting functionality to the 'cart' component of CiviEvent?
ThreadText: # Has anyone added discounting functionality to the 'cart' component of CiviEvent?
  
  (Asked by: username_0 on 2015-04-17)
  
  I am testing/trying to use CiviEvent 'shopping cart' (needs to be enabled using CiviEvent Component Settings under Administer/CiviEvent) mode of registering for events and while I am on an older version of Civi I looked at 4.6 code and it looks about the same re: Cart functionality. I have modified Cart code to allow for using CiviDiscount, if an event is configured to allow discounts - is anyone else interested in this? I will submit a patch if so. (there are other features that seem lacking in Cart, I will include a README to document)
  
  **Tags:** civievent
  
  > **Comments:**
  > **username_1**: hi Lesley, I really thought that CiviDiscount and CiviEvent's shopping cart were compatible, but after testing I have found some issues.  
  > **username_2**: Should there be a new answer to this saying "yes this is possible now"?  
  
  ---
  
  ## 2 answers
  
  ### Answer by username_3 on 2015-04-17. Score: 2
  
  This might an important feature for folks using Event Cart functionality. It would be great if you can submit a PR against CiviDiscount repository at
  
  > <https://github.com/dlobo/org.civicrm.module.cividiscount>
  
  > **Comments:**
  > **username_0**: Because the Cart modules (ParticipantsandPrices, Payment.php) are not modeled on regular Event/Registration modules, I couldn't simply add Cart form names to _cividiscount - I called in _cividiscount methods in Cart.  I understand that no one supports Cart code as part of core CiviCRM, yet it isn't an extension? Should I  rewrite Cart to 'fit' CiviDiscount in the way Event/Reg is done?  
  > **username_0**: OK, I submitted a PR for this in CiviDiscount and it will be added- it needs a PR in Event/Cart/Form/Checkout too, which I also submitted  
  > **username_3**: If you think Cart code changes will be an improvement, then go for it. Alternatively you can also submit the PR against CiviDiscount repo.  
  > **username_2**: Lesley or Kurund - I just looked through PR requests to see if i could see an outcome from this work but failed. Can anyone update this thread?  
  
  ---
  
  ### Answer by username_4 on 2015-04-21. Score: 1
  
  Thanks very much for this. It would definitely be a useful feature, so please submit a PR.
  
  I think the best way to share desired features is via the issue queue for the extension at <https://github.com/dlobo/org.civicrm.module.cividiscount/issues>. Perhaps separate each suggestion into a different issue. That will make it easier to manage the suggestion, and to cite the issue when submitting a PR implementing a new feature.
  
  > **Comments:**
  > **username_0**: As I commented to username_3, the problem is more with the Cart code- if it were modeled on the Event Registration code I could fairly easily add the correct form name to CiviDiscount to add the input textbox for the code, and enable it for applicable events/pricesets, but it is Cart code that needs re-writing. I added calls to _cividiscount_* to implement discounting in Cart/Form/Checkout modules  
  
  ---
  
  