Answers.Body: <p>Coleman recently pushed a <a href="https://github.com/civicrm/civicrm-core/pull/12552" rel="nofollow noreferrer">fix</a> for this on git. Can you please apply <a href="https://github.com/civicrm/civicrm-core/pull/12552.diff" rel="nofollow noreferrer">the patch</a> and QA if it fixes your problem(if so please comment on PR about your QA result)</p>
  
  <p>HTH</p>
  
  <p>Pradeep</p>
  
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2018-07-24T12:07:07.703Z
Answers.Text: Thanks Pradeep! Great to know it is an identified bug. I've applied the patch and I'm afraid it *didn't* work for me, I see the same behaviour. (Page refreshes on a known duplicate with no error message).  Having also now disabled the AJAX check while typing, it now works, but the patch did not work for me with duplicate checking "while typing" enabled. Happy to be part of any further testing
Answers.UserDisplayName: Robin Fenwick
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2018-07-24T12:13:02.620Z
Answers.Text: Must be worth discussing on PR https://github.com/civicrm/civicrm-core/pull/12552
Answers.UserDisplayName: Pradeep Nayak
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2018-07-25T21:31:28.297Z
Answers.Text: see https://lab.civicrm.org/eileen/Product-maintenance/issues/14
Answers.UserDisplayName: user4278
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2018-07-24T08:20:51.547Z
Answers.LastActivityDate: 2018-07-24T11:47:52.293Z
Answers.LastEditDate: 2018-07-24T11:47:52.293Z
Answers.UserDisplayName: Pradeep Nayak
Answers.Body: <p>the hook per comments looks like
  hook looks like </p>
  
  <pre><code>```
  /**
   * Add dedupe searches to actions available.
   *
   * @param array $actions
   * @param int $contactID
   */
  function dedupetools_civicrm_summaryActions(&amp;$actions, $contactID) {
    try {
      $ruleGroups = civicrm_api3('RuleGroup', 'get', array(
        'contact_type' =&gt; civicrm_api3('Contact', 'getvalue' , array('id' =&gt; $contactID, 'return' =&gt; 'contact_type')),
      ));
      $weight = 500;
  
      $contactIDS = array($contactID);
      foreach ($ruleGroups['values'] as $ruleGroup) {
        $actions['otherActions']['dupe' . $ruleGroup['id']] = array(
          'title' =&gt; ts('Find matches using Rule : %1', array(1 =&gt; $ruleGroup['title'])),
          'name' =&gt; ts('Find matches using Rule : %1', array(1 =&gt; $ruleGroup['title'])),
          'weight' =&gt; $weight,
          'ref' =&gt; 'dupe-rule crm-contact_activities-list',
          'key' =&gt; 'dupe' . $ruleGroup['id'],
          'href' =&gt; CRM_Utils_System::url('civicrm/contact/dedupefind', array(
            'reset' =&gt; 1,
            'action' =&gt; 'update',
            'rgid' =&gt; $ruleGroup['id'],
            'criteria' =&gt; json_encode(array('contact' =&gt; array('id' =&gt; array('IN' =&gt; $contactIDS)))),
            'limit' =&gt; count($contactIDS),
          )),
        );
        $weight++;
      }
    }
    catch (CiviCRM_API3_Exception $e) {
      // This would most likely happen if viewing a deleted contact since we are not forcing
      // them to be returned. Keep calm &amp; carry on.
    }
  }
  
  ```
  </code></pre>
  
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2018-07-24T02:53:55.477Z
Answers.LastActivityDate: 2018-07-24T02:53:55.477Z
Answers.UserDisplayName: user4278
Body: <p>Following the upgrade to 5.3.0, we are finding that the 'Check for Matching Contacts' button, which is in the edit contact screen, is not working. The screen refreshes and reloads the same contact, with no error message.</p>
  
  <p>If you run the default supervised rule from the 'Find and Merge Duplicate Contacts' screen, it picks the duplicate up.  But the Check for Matching Contacts function has stopped working.  Is this a bug anyone else is seeing?</p>
  
  <p>Thank you!</p>
  
  <p>Robin</p>
  
  <p>Drupal 7</p>
  
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-23T12:14:59.960Z
Comments.Text: Are you seeing proposed matches pop up as you type? There was a change in this functionality
Comments.UserDisplayName: user4278
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-23T19:26:34.560Z
Comments.Text: I tested on dmaster at "https://dmaster.demo.civicrm.org/civicrm/contact/add?reset=1&ct=Individual" by typing 'betty adams' and got "Similar Contacts Found
  If the contact you were trying to add is listed below, click their name to view or edit their record:
  Betty Jensen jensen.betty87@fakemail.biz
  Mrs. Betty Adams bettyadams@wisconsinactionfund.org" - but yes if I then click on "Check for Matching Contacts" it just reloads the page without the pop up. Does the pop up not give you the info you need and hence the 'check for matching contacts' is now a bit redundant?
Comments.UserDisplayName: petednz - fuzion
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-23T20:55:16.193Z
Comments.Text: We do see the pop-up duplicates warning when adding contacts in the admin interface.... BUT The duplicates are actually being created unsupervised, by users booking for events - we then go in and manually de-dupe.  This may seem odd, but we have found it is the best way for our organisation. I wonder if the change in this functionality  has broken the button, thank you for confirming it doesn't work for you either @petednz-fuzion
Comments.UserDisplayName: Robin Fenwick
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-23T22:23:59.160Z
Comments.Text: IN terms of duplicates being created - do you need to a/ review your Dedupe rules, b/ confirm which dedupe rules are being applied for each Event
Comments.UserDisplayName: petednz - fuzion
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-24T02:49:29.137Z
Comments.Text: I think Coleman is working on a patch for this - it has been discussed in the dev-post-release channel.
  
  Note that under Administer CiviCRM>>Customise Data and screens>>Display Preferences you can opt for Check for Similar Contacts While Typing and they will pop up on name or email match as you do data entry.
  
  We also have a hook that adds a link to find matches by rule to the actions on the contact summary screen
Comments.UserDisplayName: user4278
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2018-07-24T02:53:28.293Z
Comments.Text: hook looks like 
  ```
Comments.UserDisplayName: user4278
Tags: <contacts><duplicate-contacts>
Title: Bug with Check for Matching Contact(s) button
ThreadText: # Bug with Check for Matching Contact(s) button
  
  (Asked by: username_0 on 2018-07-23)
  
  Following the upgrade to 5.3.0, we are finding that the 'Check for Matching Contacts' button, which is in the edit contact screen, is not working. The screen refreshes and reloads the same contact, with no error message.
  
  If you run the default supervised rule from the 'Find and Merge Duplicate Contacts' screen, it picks the duplicate up. But the Check for Matching Contacts function has stopped working. Is this a bug anyone else is seeing?
  
  Thank you!
  
  Robin
  
  Drupal 7
  
  **Tags:** contacts, duplicate-contacts
  
  > **Comments:**
  > **username_1**: Are you seeing proposed matches pop up as you type? There was a change in this functionality  
  > **username_2**: I tested on dmaster at "https://dmaster.demo.civicrm.org/civicrm/contact/add?reset=1&ct=Individual" by typing 'betty adams' and got "Similar Contacts Found If the contact you were trying to add is listed below, click their name to view or edit their record: Betty Jensen jensen.betty87@fakemail.biz Mrs. Betty Adams bettyadams@wisconsinactionfund.org" - but yes if I then click on "Check for Matching Contacts" it just reloads the page without the pop up. Does the pop up not give you the info you need and hence the 'check for matching contacts' is now a bit redundant?  
  > **username_0**: We do see the pop-up duplicates warning when adding contacts in the admin interface.... BUT The duplicates are actually being created unsupervised, by users booking for events - we then go in and manually de-dupe.  This may seem odd, but we have found it is the best way for our organisation. I wonder if the change in this functionality  has broken the button, thank you for confirming it doesn't work for you either @petednz-fuzion  
  > **username_2**: IN terms of duplicates being created - do you need to a/ review your Dedupe rules, b/ confirm which dedupe rules are being applied for each Event  
  > **username_1**: I think Coleman is working on a patch for this - it has been discussed in the dev-post-release channel.  Note that under Administer CiviCRM>>Customise Data and screens>>Display Preferences you can opt for Check for Similar Contacts While Typing and they will pop up on name or email match as you do data entry.  We also have a hook that adds a link to find matches by rule to the actions on the contact summary screen  
  > **username_1**: hook looks like  ```  
  
  ---
  
  ## 2 answers
  
  ### Answer by username_3 on 2018-07-24. Score: 2 | Accepted answer
  
  Coleman recently pushed a [fix](https://github.com/civicrm/civicrm-core/pull/12552) for this on git. Can you please apply [the patch](https://github.com/civicrm/civicrm-core/pull/12552.diff) and QA if it fixes your problem(if so please comment on PR about your QA result)
  
  HTH
  
  Pradeep
  
  > **Comments:**
  > **username_0**: Thanks Pradeep! Great to know it is an identified bug. I've applied the patch and I'm afraid it *didn't* work for me, I see the same behaviour. (Page refreshes on a known duplicate with no error message).  Having also now disabled the AJAX check while typing, it now works, but the patch did not work for me with duplicate checking "while typing" enabled. Happy to be part of any further testing  
  > **username_3**: Must be worth discussing on PR https://github.com/civicrm/civicrm-core/pull/12552  
  > **username_1**: see https://lab.civicrm.org/eileen/Product-maintenance/issues/14  
  
  ---
  
  ### Answer by username_1 on 2018-07-24. Score: 1
  
  the hook per comments looks like
  hook looks like 
  ```
  /**
   * Add dedupe searches to actions available.
   *
   * @param array $actions
   * @param int $contactID
   */
  function dedupetools_civicrm_summaryActions(&$actions, $contactID) {
    try {
      $ruleGroups = civicrm_api3('RuleGroup', 'get', array(
        'contact_type' => civicrm_api3('Contact', 'getvalue' , array('id' => $contactID, 'return' => 'contact_type')),
      ));
      $weight = 500;
  
      $contactIDS = array($contactID);
      foreach ($ruleGroups['values'] as $ruleGroup) {
        $actions['otherActions']['dupe' . $ruleGroup['id']] = array(
          'title' => ts('Find matches using Rule : %1', array(1 => $ruleGroup['title'])),
          'name' => ts('Find matches using Rule : %1', array(1 => $ruleGroup['title'])),
          'weight' => $weight,
          'ref' => 'dupe-rule crm-contact_activities-list',
          'key' => 'dupe' . $ruleGroup['id'],
          'href' => CRM_Utils_System::url('civicrm/contact/dedupefind', array(
            'reset' => 1,
            'action' => 'update',
            'rgid' => $ruleGroup['id'],
            'criteria' => json_encode(array('contact' => array('id' => array('IN' => $contactIDS)))),
            'limit' => count($contactIDS),
          )),
        );
        $weight++;
      }
    }
    catch (CiviCRM_API3_Exception $e) {
      // This would most likely happen if viewing a deleted contact since we are not forcing
      // them to be returned. Keep calm & carry on.
    }
  }
  
  ```
  
  
  ---
  
  