Answers.Body: <p>Looks like you answered your own question...  and wrote a whole extension to migrate sites off activity revisions! <a href="https://civicrm.org/extensions/caseactivityrevisionmigrator" rel="nofollow noreferrer">https://civicrm.org/extensions/caseactivityrevisionmigrator</a></p>
  
Answers.ContentLicense: CC BY-SA 4.0
Answers.CreationDate: 2023-05-29T15:05:02.913Z
Answers.LastActivityDate: 2023-05-29T15:05:02.913Z
Answers.UserDisplayName: Coleman
Body: <p>Not sure when this changed. I'm using the master branch. There's a couple related things:</p>
  
  <ol>
  <li>The default for "logging" on the Misc admin screen is off, but so is the default for "Enable Embedded Activity Revisions" on the CiviCase settings admin screen. So by default nothing is logged anymore.</li>
  <li><p>Even if I turn on the setting on the civicase settings screen, it seems that there's then two sub-issues:</p>
  
  <p>(a) a quick look at the code used by the activity form suggests it doesn't use this setting, and</p>
  
  <p>(b) it looks like it should be making revisions anyway, but doesn't.</p></li>
  </ol>
  
  <p>I can reproduce on dmaster.demo.</p>
  
  <p>Anybody know when this changed and/or is it an intended change?</p>
  
  <p><strong>EDIT</strong>: This line 453 in postProcess is <em>part</em> of the problem, because it overwrites part of the passed in $params, but there's more going on somewhere too. Removing the line or reversing the arguments causes different problems.</p>
  
  <p><code>$params = array_merge($oldActivity, $params);</code></p>
  
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2019-04-25T00:33:12.703Z
Comments.Text: Is this related? https://lab.civicrm.org/dev/core/commit/58e9d36432b501ba6ff039d545186f4d138a5f30
Comments.UserDisplayName: petednz - fuzion
Comments.ContentLicense: CC BY-SA 4.0
Comments.CreationDate: 2019-04-25T01:03:41.073Z
Comments.Text: Thanks but no - that just sets the setting on upgrade, and even if you change it there's no revisions created. The API does seem to honor it, but not the actual activity edit form. At some point I'll run a debugger on it, but was just wondering if anyone knew if this was on purpose and when, or if it's a bug introduced somewhere.
Comments.UserDisplayName: Demerit
Tags: <civicase><activities>
Title: Are case activity revisions no longer working?
ThreadText: # Are case activity revisions no longer working?
  
  (Asked by: username_0 on 2019-04-24)
  
  Not sure when this changed. I'm using the master branch. There's a couple related things:
  
  1. The default for "logging" on the Misc admin screen is off, but so is the default for "Enable Embedded Activity Revisions" on the CiviCase settings admin screen. So by default nothing is logged anymore.
  2. Even if I turn on the setting on the civicase settings screen, it seems that there's then two sub-issues:
  
     (a) a quick look at the code used by the activity form suggests it doesn't use this setting, and
  
     (b) it looks like it should be making revisions anyway, but doesn't.
  
  I can reproduce on dmaster.demo.
  
  Anybody know when this changed and/or is it an intended change?
  
  **EDIT**: This line 453 in postProcess is *part* of the problem, because it overwrites part of the passed in $params, but there's more going on somewhere too. Removing the line or reversing the arguments causes different problems.
  
  `$params = array_merge($oldActivity, $params);`
  
  **Tags:** civicase, activities
  
  > **Comments:**
  > **username_1**: Is this related? https://lab.civicrm.org/dev/core/commit/58e9d36432b501ba6ff039d545186f4d138a5f30  
  > **username_0**: Thanks but no - that just sets the setting on upgrade, and even if you change it there's no revisions created. The API does seem to honor it, but not the actual activity edit form. At some point I'll run a debugger on it, but was just wondering if anyone knew if this was on purpose and when, or if it's a bug introduced somewhere.  
  
  ---
  
  ## 1 answers
  
  ### Answer by username_2 on 2023-05-29. Score: 1
  
  Looks like you answered your own question... and wrote a whole extension to migrate sites off activity revisions! <https://civicrm.org/extensions/caseactivityrevisionmigrator>
  
  
  ---
  
  