 He was a bank clerk and area treasurer of the National Union of Bank Employees.He served as a councillor on Chislehurst and Sidcup Urban District Council 1958-62 and as an alderman on the newly formed London Borough of Bromley from 1964.Macdonald contested Beckenham in 1964.